KeyboardDragListener end listener fired regardless of whether it is currently dragging

A bug introduced from https://github.com/phetsims/scenery/issues/1621. If the KeyboardDragListener is not dragging but the Hotkeys indicate it is pressed, the end action will still execute. This is possible if the dragging doesn't start because the Pointer is already attached (interacting with another target already - likely a descendent that got the event first). This should be fixed.

Fixed in the above commit. This is a similar case to https://github.com/phetsims/scenery/issues/1634. Just like that issue, this was missed in earlier testing because Hotkey generally handles this. But because AccessibleSlider does not use KeyboardListener (and therefore Hotkey), we hit this case.  This change is correct for KeyboardDragListener, but AccessibleSlider should be changed to use KeyboardListener.


Datatable to xlsx

I can transfer a table to xlsx?

For a single HTML table on a web page:
var table_dom_elt = document.getElementById("data-table");
var wb = XLSX.utils.table_to_book(table_dom_elt);
XLSX.writeFile(wb, "export.xlsx");

If you are using a library like canvas-datagrid the documentation will generally tell you how to export data as an array of arrays or an array of row objects.  json_to_sheet will generate a worksheet object from an array of objects, and aoa_to_sheet generates a worksheet object from an array of arrays of data.


What I have tried
 I've tried using /mv gamerule keepInventory false & /gamerule keepInventory false in the worlds but it hasn't worked.
Screenshots

What does it say when you run /mv gamerule keepInventory false? Also does the change reflect in /mv gamerules?
Another possibility is the essentials has the ability to cause keep inventory to by bypassed.

What does it say when you run /mv gamerule keepInventory false? Also does the change reflect in /mv gamerules?
Another possibility is the essentials has the ability to cause keep inventory to by bypassed.

It says "Success! Gamerule keepInventory was set to false". And yes, the change is reflected in /mv gamerules. It says that keepInventory is false.

It sounds like another plugin is causing it. Can you reproduce the issue with only mv plugins installed?

I can try to see if I can reproduce the issue with only mv plugins installed.

I got rid of every plugin except my Multiverse plugins. I was able to actually lose my items when I died in my world Hardmode. So it does sound like another plugin is causing the problem.


Publish new version

Umzug v2.2.0 has been published in November 2018. https://github.com/sequelize/umzug/pull/190 was merged in June 2019 but there hasn’t been a release since. Would it be possible to publish a new version? 🙂

Hello, sorry about that. @sushantdhiman - is semantic-release supposed to make auto-releases for this package as well? If not, is there a way I can trigger a release, or must it be you?

I can't publish to this package https://www.npmjs.com/package/umzug

@jukkah @PascalPflaum @sdepold Would one of you be willing to give permissions for me and @sushantdhiman? Thank you :)

Sorry guys. I pretty much ignore everything about this project as I'm not maintaining this any more. But any way, I've now added @sushantdhiman to maintainers of npm package. Please add others and remove me when you have access to it. I didn't remove myself yet that we don't lost access to it in case of failure. And if you need me in the future please contact me via email. That's how I become informed this time too. :smile:

@jukkah Thanks for the quick response :)
@papb I have added you to this package as well, let's discuss release plan for umzug and cli in docs team

2.3.0 released on NPM


added normalization in time_histogram analogsignal annotations

Coverage remained the same at 89.912% when pulling 6f5d358a0e7596bf0a7bc281dd32ce0dcb8cfc7a on INM-6:enh/time_histogram_annotations into d6efd2ca2a623ee85d7f24b4c65c87bcfb80c168 on NeuralEnsemble:master.


[Event Request] page 1190 "Create Payment" - OnCheckVendorLedgerEntryPostingDate

Describe the request
Hello, can you please add a new Event OnCheckVendorLedgerEntryPostingDate in page 1190 "Create Payment"?
    procedure MakeGenJnlLines(var VendorLedgerEntry: Record "Vendor Ledger Entry")
    var
        GenJnlLine: Record "Gen. Journal Line";
        Vendor: Record Vendor;
#if not CLEAN22
        TempPaymentBuffer: Record "Payment Buffer" temporary;
#endif
        TempVendorPaymentBuffer: Record "Vendor Payment Buffer" temporary;
        DocumentsToApply: List of [Text];
        PaymentAmt: Decimal;
        VendorLedgerEntryView: Text;
        GenJournalDocType: Enum "Gen. Journal Document Type";
        ThereAreNoPaymentsToProccesErr: Label 'There are no payments to process for the selected entries.';
        PaymentApplicationInProcessErr: Label 'A payment application process ''%1'' is in progress for the selected entry no. %2. Make sure you have not applied this entry in ongoing journals or payment reconciliation journals.', Comment = '%1 - A code for the payment application process, %2 - The entry no. that has an ongoing application process';
    begin
        TempVendorPaymentBuffer.Reset();
        TempVendorPaymentBuffer.DeleteAll();

        VendorLedgerEntryView := VendorLedgerEntry.GetView();
        VendorLedgerEntry.SetCurrentKey("Entry No.");
        if VendorLedgerEntry.Find('-') then
            repeat
                if Vendor.Get(VendorLedgerEntry."Vendor No.") then
                    Vendor.CheckBlockedVendOnJnls(Vendor, GenJournalDocType::Payment, true);
                if PostingDate < VendorLedgerEntry."Posting Date" then
                    Error(EarlierPostingDateErr, VendorLedgerEntry."Document Type", VendorLedgerEntry."Document No.");
                OnCheckVendorLedgerEntryPostingDate(VendorLedgerEntry, PostingDate);

                if VendorLedgerEntry."Applies-to ID" = '' then begin
                    VendorLedgerEntry.CalcFields("Remaining Amount");
                    TempVendorPaymentBuffer."Vendor No." := VendorLedgerEntry."Vendor No.";
                    TempVendorPaymentBuffer."Currency Code" := VendorLedgerEntry."Currency Code";

                    if VendorLedgerEntry."Payment Method Code" = '' then begin
                        if Vendor.Get(VendorLedgerEntry."Vendor No.") then
                            TempVendorPaymentBuffer."Payment Method Code" := Vendor."Payment Method Code";
                    end else
                        TempVendorPaymentBuffer."Payment Method Code" := VendorLedgerEntry."Payment Method Code";

                    TempVendorPaymentBuffer.CopyFieldsFromVendorLedgerEntry(VendorLedgerEntry);
                    OnUpdateVendorPaymentBufferFromVendorLedgerEntry(TempVendorPaymentBuffer, VendorLedgerEntry);

    [IntegrationEvent(false, false)]
    procedure OnCheckVendorLedgerEntryPostingDate(VendorLedgerEntry: Record "Vendor Ledger Entry"; PostingDate: Date)
    begin
    end;

Additional context
An event to allow additional PostingDate checks before actually creating the GenJnlLines.
Internal work item: AB#507943

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 18941.


[$1000] Report List option is not highlighted on long pressing in LNH

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the App
In LNH, long press/right click on any report option

Expected Result:
The Report option should be highlighted to indicate which one is being pinned.
Actual Result:
No option is highlighted and the user cannot see which one is being pinned.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.27-2
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/6e41ff0d-8751-4e5b-b4c3-78fa81f30e32
Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686629557027629
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01999e34796fd5152c
Upwork Job ID:<PHONE_NUMBER>437043200
Last Price Increase: 2023-06-19

Proposal
Please restate the problem
Report is not selected in LNH on long pressing for context menu.
What do you think is the root cause of the problem?
We have no logic in place to highlight the selected report in LNH.
What changes do you think we should make to fix that problem?
We should first add a state variable to track the context menu called isContextMenuActive in OptionRowLNH.js.
2. Then in the method showPopover :
https://github.com/Expensify/App/blob/93957f0eb66a7e6998365b201a4c54ea2029ff60/src/components/LHNOptionsList/OptionRowLHN.js#L93-L108
We should add setIsContextMenuActive(true) when called and pass () => setIsContextMenuActive(false) to the onHideparameter of the ReportActionContextMenu.showContextMenu
3.  Finally on line 137 in OptionRowLNH.js
https://github.com/Expensify/App/blob/93957f0eb66a7e6998365b201a4c54ea2029ff60/src/components/LHNOptionsList/OptionRowLHN.js#LL137C5-L137C5
We need to modify the condition to the following:
props.isFocused || isContextMenuActive
Result:
https://github.com/Expensify/App/assets/77237602/754c692e-e2f7-4778-ac61-e9cdd3b6da6d
What other alternatives did you explore (optional)

Pretty sure they can be External. @mollfpr can you please review @esh-g's proposal above?
For the fix/improvement, we def want the highlighting to be clearly visible on all platforms, since Desktop and iOS function differently (and I'm guessing others too)

@mallenexpensify Sure; I will review the proposal today!

Hi, Hope you're doing well.
I have checked the issue but when I clicked long press to any, the modal is open for report and pin.
So is the issue is resolved now?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012a1375209e7966f9

Hi, Hope you're doing well.
I have checked the issue but when I clicked long press to any, the modal is open for report and pin.
So is the issue is resolved now?

Proposal
Please restate the problem

Report is not selected in LNH on long pressing for context menu.

What do you think is the root cause of the problem?

There is no such implementation in the codebase right now.

What changes do you think we should make to fix that problem?

We can basically create a withPopUpContextReportId context Provider and then use it in SidebarLinks.js file to pass the popUpReportId to the LHNOptionsList component.
We will need to add PopUpContextReportIDProvider to the App.js file.
Then add withPopUpContextReportId to  PopoverReportActionContextMenu.js File and use updatePopUpContextReportId to update the popUpReportId in the context.
Finally we can use isContextActive to show the hovered style in OptionRowLHN.js file.
const isContextActive = `${props.popUpReportId}` === `${props.reportID}`;

Fixed:
https://github.com/Expensify/App/assets/78416198/4accee4b-1ec2-4d52-98e3-e59d9d3319b6
What other alternatives did you explore (optional)

N/A

@jeet-dhandha but where is the report list in your video?

@Ali-ch88 As you know the issue is that when long pressing / Right clicking on the OptionRowLHN the PopoverReportActionContextMenu is opened but OptionRowLHN is not highlighted in this case. So these are the below screenshots from video.
Before:

After:

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/fl/~01e6deb3b1064ee6bd

Thanks for the proposal @jeet-dhandha but I think using context is over engineered.

@mallenexpensify May I know the expected highlighted color for the focus LHN item?

@mollfpr I think the highlight color should be the dark one, the same as when you're hovering over a row in LHN with your pointer.

I had to use context as i am not able to get OptionRowLHN to re-render on change of reportID in ReportActionContextMenu

@jeet-dhandha Sorry, I'm not following this; could you elaborate more?

@mollfpr You are correct it was an over-engineering on my end, as i thought passing a callback function to context is not a good idea, but i have seen some of the code where we are having callbacks. So passing a callback should work, like we have in @kbecciv 's proposal.

Proposal #2
Please restate the problem

Report is not selected in LNH on long pressing for context menu.

What do you think is the root cause of the problem?

There is no such implementation in the codebase right now.

What changes do you think we should make to fix that problem?

We can create a contextRef like ReportActionContextMenu.js and provide its ref to LHNOptionsList in SideBarLinks.js file.
Then create a function in LHNOptionsList to update the popUpReportId in the state.
Then pass that popUpReportId to OptionsRowLHN component.
Finally we can use isContextActive to show the hovered style in OptionRowLHN.js file.
const isContextActive = `${props.popUpReportId}` === `${props.reportID}`;

What other alternatives did you explore (optional)

N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Long press in LHN is not highlighting the Report Option. Further, the highlighting must be visible for all platforms.
What is the root cause of that problem?
As others already mentioned, this use case was not implemented before
What changes do you think we should make in order to solve the problem?
The basic approach here is to leverage the use of currentReportId in withCurrentReportId.js. This is currently being used by SidebarLinks.js to decide on focusedIndex which is used to inform OptionRowLHN about whether it is currently in focus or not. The approach here is to set currentReportId to trigger a re-render and achieve our objective of showing highlighted option.

In 'OptionRowLHN.js, change showPopover` as follows.

Here, whenever popover needs to be displayed, we call a function that is passed as a property from SidebarLinks.js. This function will set currentReportId thereby triggering a re-render with a changed focusedIndex.
Further, when the popover is hidden, the currentReportId is reset which again triggers a rerender to remove the highlight.
     const showPopover = (event) => {
+        props.onReportOptionSelection(props.reportID);
         ReportActionContextMenu.showContextMenu(
             ContextMenuActions.CONTEXT_MENU_TYPES.REPORT,
             event,
	     ...
             {},
             '',
             () => {},
-            () => {},
+            () => {props.onReportOptionSelection(undefined);},
             false,
             false,
             optionItem.isPinned,

In LHNOptionsList.js, ignore the use of this.props.shouldDisableFocusOptions so that OptionRowLHN can re-render and highlight the selection.

            <OptionRowLHN
                ...
-               isFocused={!this.props.shouldDisableFocusOptions && this.props.focusedIndex === index}
+               isFocused={this.props.focusedIndex === index}
                ...
            />

In SidebarLinks.js, implement an handler as follows (pls refer inline comments for what it does). This function is passed to OptionRowLHN via LHNOptionsList as a prop.

+    onReportOptionSelection(reportID) {
+        if (this.props.isSmallScreenWidth) {
+            // For small screen width devices, update the current report id for the selected option row so that
+            // a rerender gets triggered for LHNoptionsList and, subsequently, the current report's option row gets hightlighted.
+            // An undefined reportID will reset the selection in the LHN
+            this.props.updateCurrentReportId(reportID);
+            return;
+        }
+        // For large screen width devices, there will always be a current report which is displayed in the central pane.
+        // For valid reportIDs, show the Report Page as well. Thus, on a right click within Sidebar in large screens, the central pane
+        // will be consistent with the highlighted LHN Option Row.
+        // Further, ignore `undefined` reportID as large screens always must have a valid report to show in central pane.
+        if(reportID !== undefined)
+        {
+            this.showReportPage({reportID});
+        }
+    }
+

Finally, update the updateCurrentReportId  in withCurrentReportId.js to include support for directly setting the current report id.

     const updateCurrentReportId = useCallback(
         (state) => {
+            if(typeof state === 'string')
+            {
+                setCurrentReportId(state);
+                return;
+            }
             setCurrentReportId(Navigation.getTopmostReportId(state));
         },
         [setCurrentReportId],

What alternative solutions did you explore? (Optional)

@mollfpr What do you think of the approach of using state here https://github.com/Expensify/App/issues/21066#issuecomment-1597572497 ?
I would also add a modification according to @mallenexpensify to change the color to the hovered one, we can just change the following:
https://github.com/Expensify/App/blob/18d62d0604501a32f6e7959647a88e93e5330046/src/components/LHNOptionsList/OptionRowLHN.js#L143
(hovered || isContextMenuActive) && !props.isFocused ? props.hoverStyle : null,

@esh-g I like your proposal, but the result is still not desirable. There's a delay before the option is highlighted.
https://github.com/Expensify/App/assets/25520267/41d876e6-1db4-4601-a635-5ea7ac3e7e24

@jeet-dhandha Why must we create a contextRef and handle the new state popUpReportId in LHNOptionsList?

@mollfpr I don't seem to be getting the flash that you are currently experiencing. Is it possible that you are setting the state to true with the onShow prop instead of setting it instantly in the method?
I have a branch for this in my fork, and I would request you to check this out once for streamlined implementation: https://github.com/esh-g/Expensify/tree/OptionListLHN-Hightlight
Should be this:

Not this:

Result(Actual):
https://github.com/Expensify/App/assets/77237602/5e67db99-050b-4074-b69b-db9fb07a3f48
Result(When using onShow)
https://github.com/Expensify/App/assets/77237602/96d30ac2-63a1-4e4d-846d-81c793f60590

@jeet-dhandha Why must we create a contextRef and handle the new state popUpReportId in LHNOptionsList?

@mollfpr It implements the current feature, as well provide us with the desired output where highlight should be without delay. If you are concerned on the re-rendering of the OptionsRowLHN then we can handle in to not re-render when popUpReportId is not equal to current report id (we will also need other params but yeah we can attain that easily.

Thank you all for the proposals!
I am inclined to go with @esh-g proposals. It can be simple enough to use the local state in the component and handle it based on the popover method call.
🎀 👀 🎀 C+ reviewed!

@mollfpr @roryabraham The PR is here https://github.com/Expensify/App/pull/21613 🚀

@esh-g @mollfpr, can you please accept the job?
https://www.upwork.com/jobs/~01999e34796fd5152c

Thanks @mallenexpensify I have accepted

Looks like the remaining TODOs here are BZ checklist and payments

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

The first commit that adds the secondary interaction to show popover is https://github.com/Expensify/App/pull/16079, but I don't think this is a bug but rather an improvement.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression steps should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Open the App
Observe the LHN
For small screens long-press or larger screen right click on the current focus chat
Verify the background of the chat in LHN is not changed and showing the context menu actions popover
Do step 3 but on the other chat where is not focused
Verify the background of the chat in LHN is darker or similar to the background when we hovered the chat list and showed the context menu actions popover
👍 or 👎

bump @mallenexpensify I think this issue is due

@esh-g paid $1750 - $1500 for job, w/ urgency bonus + $250 for reporting
@mollfpr paid $1500.
TestRail update GH here
Thanks all!


[#1922] Remove roadmap from ProjectDetails

Fixes #1922

@jamessspanggg there's an icon for the roadmap. Should we remove that too?


Dependency on scala compiler should be treated in special way

Hi,
If you add dependency on a compiler like this:
libraryDependencies <+= scalaVersion("org.scala-lang" % "scala-compiler" % _)

then you end up with compiler dependency being added as a normal jar to .classpath file as any other. However, we should be using the same kind of mechanism that is being used for Scala library dependency.

Greg,
Published to http://repo.typesafe.com/typesafe/ivy-snapshots/com.typesafe.sbteclipse/sbteclipse/scala_2.9.1/sbt_0.11.0/1.5.0-SNAPSHOT/...
Please try out in anger ...
Heiko


Move functions to under function directory

Codecov Report

Merging #10 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   31.66%   31.66%
=======================================
  Files           9        9
  Lines         259      259
=======================================
  Hits           82       82
  Misses        166      166
  Partials       11       11

Impacted Files
Coverage Δ

function/distributor/main.go
0.00% <ø> (ø)

function/downloader/http.go
60.00% <ø> (ø)

function/downloader/main.go
0.00% <ø> (ø)

function/gif-distributor/main.go
0.00% <ø> (ø)

function/gif-maker/gif.go
45.00% <ø> (ø)

function/gif-maker/main.go
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e5091...c3c6e3a. Read the comment docs.


[BUG] Acknowledging an alert leaves the checkbox checked and disabled

@Jon-AtAWS commented on Wed May 24 2023
Describe the bug
I am using the Alerting UI "Alerts by Triggers" panel to acknowledge alerts. I select the check box for one of the monitors, then click Acknowledge, then select the alert and Acknowledge. I return to the "Alerts by Triggers" page and the checkbox is checked and disabled.
From this point, I am not able to uncheck the box, or check a different box (the first box remains checked for a total of 2 checked boxes), and acknowledge alerts there.
To Reproduce
See above
Expected behavior
When I return to the "Alerts by Triggers" page, the box should be unchecked and disabled if I have no more alerts to acknowledge, or it should be enabled and not checked if there are more alerts to acknowledge.
OpenSearch Version
Please list the version of OpenSearch being used.
Dashboards Version
Please list the version of OpenSearch Dashboards being used.
OpenSearch 1.1, hosted in the AWS service
Plugins
Just the ones that come preloaded for the service
Screenshots

Host/Environment (please complete the following information):

OS: MacOS 12.6.5
Browser and version Firefox 113.0

@joshuarrrr commented on Thu May 25 2023
@opensearch-project/triage Please transfer issue to https://github.com/opensearch-project/alerting-dashboards-plugin

Is this issue still open?

I will work on this issue

Hey! I wanted to ask since I think the only way to handle this is to call the API to get alerts again or simply refresh the page. So will simply reloading the page using window.location.reload(false); be an efficient solution to it?


What will happen with blackjack4494 (and many other) fork's progress?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

First of all, I want to say I'm very glad the original project came back. And I'm also glad that, while the big boys weren't home, some people still gathered, and have made a lot of progress solving bugs, developing support for some more websites, and probably a lot more.
Having said that, what will happen with all of the changes made during the time this repo was taken down? I speak mostly because of the repo I know from @blackjack4494, but I'm sure there's a lot more whose commits are equally valuable to the project. Are you planning on merging them, or something similar?
Again, congrats on your comeback, and cheers.

The fork you mentioned existed before the repo was taken down, so it's not related.

It has been merging in fixes and features that ydl did not, even though ydl could have merged them in when the came ages ago.
It seems that they are merging in at a rapid rate ever since the DMCA situation, almost like a response to people realizing that ydlc was better than ydl. But jibes aside, it seems that at this rate, ydl can potentially surpass ydlc - but until then I'm sticking to ydlc


improve env created with baseURL

see #7

@hoegertn nice
thanks
:+1:

we will keep this out of master until we support an custom import UI so that the importer can ask the users as the if they want to enable this feature.


base_lisa_cluster function call does not pass p_thresh

The calling function plot_lisa_cluster(shp_link, lisa, p_thres=0.01...) in mapping.py does not not pass the p_thres argument to
base_lisa_cluster(lisa_obj, lisa) function call on line 1100
I think it should be:
base_lisa_cluster(lisa_obj, lisa, p_thres)
https://github.com/pysal/pysal/blob/1e254a023ca40949ce7c6f52421726495958f71e/pysal/contrib/viz/mapping.py#L1100

Thanks very much for the issue @pattyf. You're exactly right, that's a bug. Happy to accept a PR on that, or I can try to get to this next week otherwise.
Also, note that we're moving our plotting API to one that looks more like GeoPandas so it integrates better with the rest of the stack. For an example of how this could work, you can have a look at:
https://gist.github.com/darribas/691ad184280590d1219ffcf9a1678030
Thanks again for reporting!

I've made a small PR with a fix for this. Thank you very much for reporting again @pattyf!!!


How do you add authentication to protect the api.

If you can also also add oauth1 or oauth2 authentication to protect the api, that will also simplify the Json api process.  Thanks for the great library.

Hi there,
I can add something like this. Yet, you should be aware of what is oauth. It is not sufficient to "have" oauth to be secure or to prove authenticity.
https://oauth.net/articles/authentication/
Could you share the repetitive code that could be wrapped?

Point well noted. Am just trying to know the best mechanism to protect a Json api. So how about JWT. Since session is not best approach in securing an api.
Thanks

Please, tell me exactly what you would like to see and what you are struggling with.
JWT is the same idea as oauth. It all depends on what you want to achieve.


karma-sauce-launcher should be inside devDependencies not dependencies

It is correct that karma-sauce-launcher is installed as a production dependency? I think it should be inside devDependencies section. I'm right?
https://github.com/jashkenas/underscore/blob/c0e8feff7fc66ba399409ea0798e32d2806f3ff3/package.json#L50-L52
thanks

Quite right. That's just awful!
Thank you for catching it promptly.


[BUG] Cannot create nested field if parent does not exist

Error
write exception: write errors: [The path 'a field' must exist in the document in order to apply array updates.]
Step to reproduce:

Add a new array field with object type

Fixed as in https://github.com/amirkode/go-mongr8/pull/14


Consider add ranking features for fuzzy query operator

In https://github.com/vespa-engine/vespa/issues/13814 we added support for fuzzy query with maxEditDistance,  for larger values, it would make sense to expose the distance as a rank-feature, for example, rawScore() or a dedicated new rank-feature.

Matches features are missing as well. Example: https://stackoverflow.com/questions/74053567/ranking-in-fuzzy-match-in-vespa.

I'm resetting the milestone on this issue in light of recent work on fuzzy prefix support (#30720). Fuzzy prefix matching can have a lot more matches than non-prefix fuzzy matching, so exposing the edit distance as a rank feature (rawScore most likely) is all the more useful.


Configure SwiftWebSocket in background

All delegate methods plus the socket establishment are triggered on the main-thread. This is blocking UI and causing ugly glitches. is there anything I can configure to run everything in the background threads?

If you create the socket in a background thread, associated calls should also be in the background thread, no?


Controller-runtime v0.15 breaks the webhooks

With https://github.com/kubermatic/operating-system-manager/commit/67bdd421bad09618edc3cd676e624f6a2910a71a we updated k8s packages along with controller-runtime. This seems to have broken the webhooks.
	net/http/server.go:3089 +0x5ed
2023/06/13 05:05:12 http: panic serving <IP_ADDRESS>:14914: runtime error: invalid memory address or nil pointer dereference
goroutine 784 [running]:
net/http.(*conn).serve.func1()
	net/http/server.go:1854 +0xbf
panic({0x173c1a0, 0x2769b10})
	runtime/panic.go:890 +0x263
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Decoder).DecodeRaw(0x0, {{0xc0003ec000, 0x5afc, 0x6000}, {0x0, 0x0}}, {0x1b94278, 0xc000316000})
	sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/decode.go:76 +0x13a
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Decoder).Decode(_, {{{0xc0002fc180, 0x24}, {{0xc0004562c0, 0x1d}, {0xc000198160, 0x8}, {0xc00004a120, 0x16}}, {{0xc000456440, ...}, ...}, ...}}, ...)
	sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/decode.go:49 +0x8e
k8c.io/operating-system-manager/pkg/admission/operatingsystemprofile/validation.(*AdmissionHandler).Handle(_, {_, _}, {{{0xc0002fc180, 0x24}, {{0xc0004562c0, 0x1d}, {0xc000198160, 0x8}, {0xc00004a120, ...}}, ...}})
	k8c.io/operating-system-manager/pkg/admission/operatingsystemprofile/validation/validation.go:78 +0xe7
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).Handle(_, {_, _}, {{{0xc0002fc180, 0x24}, {{0xc0004562c0, 0x1d}, {0xc000198160, 0x8}, {0xc00004a120, ...}}, ...}})
	sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/webhook.go:169 +0x20a
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP(0xc00027af00, {0x7f7bc8e69738?, 0xc00008e140}, 0xc0001ae200)
	sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/http.go:98 +0xc94
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerInFlight.func1({0x7f7bc8e69738, 0xc00008e140}, 0x1ba4d00?)
	github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:60 +0xd4
net/http.HandlerFunc.ServeHTTP(0x1ba4d90?, {0x7f7bc8e69738?, 0xc00008e140?}, 0xc0006cf828?)
	net/http/server.go:2122 +0x2f
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerCounter.func1({0x1ba4d90?, 0xc0000ec1c0?}, 0xc0001ae200)
	github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:147 +0xc5
net/http.HandlerFunc.ServeHTTP(0x722be5?, {0x1ba4d90?, 0xc0000ec1c0?}, 0x7f7bf04de5b8?)
	net/http/server.go:2122 +0x2f
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2({0x1ba4d90, 0xc0000ec1c0}, 0xc0001ae200)
	github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:109 +0xc7
net/http.HandlerFunc.ServeHTTP(0xc0000ec1c0?, {0x1ba4d90?, 0xc0000ec1c0?}, 0x193caeb?)
	net/http/server.go:2122 +0x2f
net/http.(*ServeMux).ServeHTTP(0xc0001c419d?, {0x1ba4d90, 0xc0000ec1c0}, 0xc0001ae200)
	net/http/server.go:2500 +0x149
net/http.serverHandler.ServeHTTP({0x1b976f8?}, {0x1ba4d90, 0xc0000ec1c0}, 0xc0001ae200)
	net/http/server.go:2936 +0x316
net/http.(*conn).serve(0xc0000e2f30, {0x1ba59e0, 0xc0001a4e10})
	net/http/server.go:1995 +0x612
created by net/http.(*Server).Serve
	net/http/server.go:3089 +0x5ed

I spent quite a limited time debugging it but didn't have the capacity to expand on it and test this thoroughly. Hence reverting https://github.com/kubermatic/operating-system-manager/commit/67bdd421bad09618edc3cd676e624f6a2910a71a for now since we are close to a new OSM release.

/remove-lifecycle stale


Update Storyboard constraints / adapt constraints to different screen sizes

Specially to handle iPhone X
This can fix also the description title who can quickly be cropped

Nice work 👍

Good to still be active ;-)
Thanks for your work


README improvements

To be helpful for folks who might not have experience w/ Python development.

(+virtual env)
navigate to where you want the code to be
clone it, go there
windows instructions
open .
select expiration, select scope (public_repo)
paste it in .env, save close
that's it, move to usage

Also, Windows instructions?


When an instance of a  service with exposed port and side kick is deleted , on service reconcile scheduling errors are seen.

Rancher Versions: v1.4.0-rc3
Set up has 3 hosts
Steps to reproduce the problem:
Create a service with scale 2 which has an exposed port and a sidekick.
Delete one of the instances of the service.
When there is an attempt made to start an instance (service reconcile) , it errors out with exception - Degraded (Failed to allocate instance [container:1i45]: Bad instance [container:1i45] in state [error]: Scheduling failed: No healthy hosts with sufficient resources available)
Eventually there is another service reconcile that gets triggered resulting in instance to start successfully.


improve requirements file

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master    #5   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files           6     6
  Lines         518   518
====================================
  Misses        518   518

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d6c1c...98a5535. Read the comment docs.


In memory integration tests

Thanks arvinth I'll have a look when after I get tests working with vs2017


feat: gossip extensions to support role based features

role based extension in anti entropy while request new blocks
role based extension for ledger height calculations
ChannelInitializer extension to use current config block
role based extension for gossip in deliveryservice  blocks provider
block publisher to provide ledger height info
related to #96

Signed-off-by: sudesh.shetty<EMAIL_ADDRESS>

verify-integration


[BUG] Page permissions broken on LDAP admins

Describe the bug
page permissions broken on LDAP admins
Screenshots
If applicable, add screenshots to help explain your problem.

Version information (please complete the following information):

PfSense: 2.6.0
pfSense-pkg-WireGuard    0.0.7_1
wireguard-kmod    0.0.20210415
wireguard-tools    1.0.20210315_4

This needs to be tested on 2.5.1 as well...though I suspect I need to do some more study of other packages and see how define page permissions. I thought I had this worked out

Just pushed a fix for this. Will make it into the next build


anti-sauce

sauce labs is running after each platform build and if it errors -- not fails -- on any one, the whole build gets marked as errored. I propose running sauce either pre-publish or at regular intervals.

:herb:
I wonder if Travis allows any other triggers than check-in.  A daily build for this sounds perfect.

i think this would have to be outside the context of travis, since travis will always do what is configured in .travis.yml. but the idea of adding more infrastructure is making me feel sick

:deciduous_tree: No more 20-minute builds? Sounds good to me!

should probably do the same for bench tests

1798.1 	1 min 36 sec 	less than a minute ago 	0.10 	linux
1798.2 	1 min 31 sec 	less than a minute ago 	0.12 	linux
1798.3 	1 min 45 sec 	less than a minute ago 	io.js 	linux

its not too hard to run sauce on only one step of the matrix (see underscore).an alternative is to use twitters tool to run the sauce tests and comment on the relevant PR or commit

@megawac: That bit from Underscore looks very useful, and might also help with another issue.  I will look into that soon.


[BUG]  Memory Leak in ResolverProxy

Reproduction steps
I just finished triaging a memory leak in ResolverProxy.
This memory allocation is getting leaked (Source code link):
    CHIP_ERROR Init(Inet::EndPointManager<Inet::UDPEndPoint> * udpEndPoint = nullptr) override
    {
        ReturnErrorOnFailure(chip::Dnssd::Resolver::Instance().Init(udpEndPoint));
        VerifyOrReturnError(mDelegate == nullptr, CHIP_ERROR_INCORRECT_STATE);
-->     mDelegate = chip::Platform::New<ResolverDelegateProxy>();   <-- // Allocated and never freed.

...

This was the call stack of the leaked allocation:
src/lib/support/CHIPMem-Malloc.cpp: chip::Platform::MemoryAlloc()
src/lib/support/CHIPMem.h: chip::Platform::New<>()
src/lib/dnssd/ResolverProxy.h: chip::Dnssd::ResolverProxy::Init()
src/lib/dnssd/Discovery_ImplPlatform.cpp: chip::Dnssd::DiscoveryImplPlatform::HandleDnssdInit()
src/platform/google/dnssd_manager.cc: chip::Dnssd::ChipDnssdInit()
src/lib/dnssd/Discovery_ImplPlatform.cpp: chip::Dnssd::DiscoveryImplPlatform::InitImpl()
src/lib/dnssd/Discovery_ImplPlatform.h: chip::Dnssd::DiscoveryImplPlatform::Init()
src/lib/dnssd/Discovery_ImplPlatform.h: chip::Dnssd::DiscoveryImplPlatform::Init()
src/controller/CHIPDeviceControllerFactory.cpp: chip::Controller::DeviceControllerFactory::InitSystemState()
src/controller/CHIPDeviceControllerFactory.cpp: chip::Controller::DeviceControllerFactory::Init()

Although everything shuts down properly, This call to mDelegate->Release() in ResolverProxy::Shutdown is not freeing mDelegate as expected, as its ref count is still greater than 1 (Source code link):
    void Shutdown() override
    {
        VerifyOrReturn(mDelegate != nullptr);
        mDelegate->SetOperationalDelegate(nullptr);
        mDelegate->SetCommissioningDelegate(nullptr);
-->     mDelegate->Release(); <-- // Does not free mDelegate (ref count is > 1)
        mDelegate = nullptr;
    }

The reason is that ResolverProxy::ResolveNodeId obtained an additional ref to it here, and never released it (Source code link):
CHIP_ERROR ResolverProxy::ResolveNodeId(const PeerId & peerId)
{
    VerifyOrReturnError(mDelegate != nullptr, CHIP_ERROR_INCORRECT_STATE);

    ChipLogProgress(Discovery, "Resolving " ChipLogFormatX64 ":" ChipLogFormatX64 " ...",
                    ChipLogValueX64(peerId.GetCompressedFabricId()), ChipLogValueX64(peerId.GetNodeId()));

    DnssdService service;

    ReturnErrorOnFailure(MakeInstanceName(service.mName, sizeof(service.mName), peerId));
    Platform::CopyString(service.mType, kOperationalServiceName);
    service.mProtocol    = DnssdServiceProtocol::kDnssdProtocolTcp;
    service.mAddressType = Inet::IPAddressType::kAny;

--> mDelegate->Retain(); <-- // Increases the ref-count of mDelegate.

    CHIP_ERROR err = ChipDnssdResolve(&service, Inet::InterfaceId::Null(), HandleNodeIdResolve, mDelegate);
    if (err != CHIP_NO_ERROR)
    {
        mDelegate->Release();
    }
    return err;
}

In my specific use-case, it was expected to be released when ResolverProxy::NodeIdResolutionNoLongerNeeded is called, but it's clearly not (Source code link):
void ResolverProxy::NodeIdResolutionNoLongerNeeded(const PeerId & peerId)
{
    char name[Common::kInstanceNameMaxLength + 1];
    ReturnOnFailure(MakeInstanceName(name, sizeof(name), peerId));

    ChipDnssdResolveNoLongerNeeded(name);
}

Actually, DiscoveryImplPlatform doesn't even propagate the call to DiscoveryImplPlatform::NodeIdResolutionNoLongerNeeded to the ResolverProxy, which I think it should be, and surrounding functions do this (Source code link).
CHIP_ERROR DiscoveryImplPlatform::ResolveNodeId(const PeerId & peerId)
{
    ReturnErrorOnFailure(InitImpl());
--> return mResolverProxy.ResolveNodeId(peerId);  <-- // Calls ResolverProxy.
}

void DiscoveryImplPlatform::NodeIdResolutionNoLongerNeeded(const PeerId & peerId)
{
    char name[Common::kInstanceNameMaxLength + 1];
    ReturnOnFailure(MakeInstanceName(name, sizeof(name), peerId));

-->  ChipDnssdResolveNoLongerNeeded(name);  <-- // Does NOT call ResolverProxy.
}

CHIP_ERROR DiscoveryImplPlatform::DiscoverCommissionableNodes(DiscoveryFilter filter)
{
    ReturnErrorOnFailure(InitImpl());
--> return mResolverProxy.DiscoverCommissionableNodes(filter);  <-- // Calls ResolverProxy.
}

Thoughts on a fix
We need to call ResolverProxy::NodeIdResolutionNoLongerNeeded from DiscoveryImplPlatform::NodeIdResolutionNoLongerNeeded, and ResolverProxy::NodeIdResolutionNoLongerNeeded should be calling mDelegate->Release() if the specified PeerId is holding a ref.
We'll need a set of PeerIds to keep track of how many times we've retained mDelegate, since we don't want to decrease the ref-count if someone calls ResolverProxy::NodeIdResolutionNoLongerNeeded with a PeerId that doesn't have an active reference to mDelegate.  That risks prematurely freeing mDelegate which would lead to a crash.
Other concerns
It looks like there are a few other calls to mDelegate->Retain() in Discovery_ImplPlatform.cpp as well, and I don't see many calls to mDelegate->Release() so there may be other execution flows that leak the delegate as well.
Bug prevalence
Whenever the AddressResolve logic is used, and we no longer need to resolve a node.
GitHub hash of the SDK that was being used
af6cb3a6d7d4cd9a4eb38ec49687260bc5ec96e7
Platform
core
Platform Version(s)
No response
Anything else?
Although the hash I reported isn't the latest, I inspected the top-of-tree code, and the issue still exists.  All my permalinks are from the top of tree source.

The right fix here is to stop having ResolveNodeId go through a singleton resolver proxy (and in general to remove ResolveNodeId from ResolverProxy, since we are no longer using per-resolve resolver proxies for doing PeerId lookups).

I can reproduce the leak by stopping a test app while it is running resolution. Traces look like:
==1799042==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 112 byte(s) in 1 object(s) allocated from:
    #0 0x7f16f5eae7ff in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x559cfbdb7d92 in chip::Platform::MemoryAlloc(unsigned long) ../../src/lib/support/CHIPMem-Malloc.cpp:91
    #2 0x559cfbe223f2 in chip::Dnssd::MdnsAvahi::ResolveContext* chip::Platform::New<chip::Dnssd::MdnsAvahi::ResolveContext>() ../../src/lib/support/CHIPMem.h:145
    #3 0x559cfbe1c25a in chip::Dnssd::MdnsAvahi::Resolve(char const*, char const*, chip::Dnssd::DnssdServiceProtocol, chip::Inet::IPAddressType, chip::Inet::IPAddressType, chip::Inet::InterfaceId, void (*)(void*, chip::Dnssd::DnssdService*, chip::Span<chip::Inet::IPAddress> const&, chip::ChipError), void*) ../../src/platform/Linux/DnssdImpl.cpp:788
    #4 0x559cfbe1ead2 in chip::Dnssd::ChipDnssdResolve(chip::Dnssd::DnssdService*, chip::Inet::InterfaceId, void (*)(void*, chip::Dnssd::DnssdService*, chip::Span<chip::Inet::IPAddress> const&, chip::ChipError), void*) ../../src/platform/Linux/DnssdImpl.cpp:988
    #5 0x559cfbdcdbe5 in chip::Dnssd::ResolverProxy::ResolveNodeId(chip::PeerId const&) ../../src/lib/dnssd/Discovery_ImplPlatform.cpp:703
    #6 0x559cfbdcc97b in chip::Dnssd::DiscoveryImplPlatform::ResolveNodeId(chip::PeerId const&) (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x6e797b)
    #7 0x559cfbdb0a5f in chip::AddressResolve::Impl::Resolver::LookupNode(chip::AddressResolve::NodeLookupRequest const&, chip::AddressResolve::Impl::NodeLookupHandle&) ../../src/lib/address_resolve/AddressResolve_DefaultImpl.cpp:189
    #8 0x559cfba3c454 in (anonymous namespace)::leakcheck::SendRequest() (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x357454)
    #9 0x559cfba3c61d in (anonymous namespace)::leakcheck::PlatformEventHandler(chip::DeviceLayer::ChipDeviceEvent const*, long) (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x35761d)
    #10 0x559cfbde4ce6 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl<chip::DeviceLayer::PlatformManagerImpl>::DispatchEventToApplication(chip::DeviceLayer::ChipDeviceEvent const*) ../../src/include/platform/internal/GenericPlatformManagerImpl.ipp:336
    #11 0x559cfbde49cf in chip::DeviceLayer::Internal::GenericPlatformManagerImpl<chip::DeviceLayer::PlatformManagerImpl>::_DispatchEvent(chip::DeviceLayer::ChipDeviceEvent const*) ../../src/include/platform/internal/GenericPlatformManagerImpl.ipp:301
    #12 0x559cfbde2bda in chip::DeviceLayer::PlatformManager::DispatchEvent(chip::DeviceLayer::ChipDeviceEvent const*) ../../src/include/platform/PlatformManager.h:503
    #13 0x559cfbde5b9d in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::ProcessDeviceEvents() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:182
    #14 0x559cfbde54fd in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:224
    #15 0x559cfba3b2f7 in chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:403
    #16 0x559cfba3c778 in (anonymous namespace)::Cmd_Check(int, char const**) (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x357778)
    #17 0x559cfba3d8eb in main (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x3588eb)
    #18 0x7f16f51666c9 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x7f16f5eae7ff in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x559cfbdb7d92 in chip::Platform::MemoryAlloc(unsigned long) ../../src/lib/support/CHIPMem-Malloc.cpp:91
    #2 0x559cfbdd05a2 in chip::Dnssd::ResolverDelegateProxy* chip::Platform::New<chip::Dnssd::ResolverDelegateProxy>() ../../src/lib/support/CHIPMem.h:145
    #3 0x559cfbdc2a7a in chip::Dnssd::ResolverProxy::Init(chip::Inet::EndPointManager<chip::Inet::UDPEndPoint>*) ../../src/lib/dnssd/ResolverProxy.h:89
    #4 0x559cfbdc7ae1 in chip::Dnssd::DiscoveryImplPlatform::HandleDnssdInit(void*, chip::ChipError) (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x6e2ae1)
    #5 0x559cfbe16ea9 in chip::Dnssd::MdnsAvahi::HandleClientState(AvahiClient*, AvahiClientState) (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x731ea9)
    #6 0x559cfbe16bfc in chip::Dnssd::MdnsAvahi::HandleClientState(AvahiClient*, AvahiClientState, void*) (/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/linux-x64-leak-checker-platform-mdns-asan/leak-checker+0x731bfc)
    #7 0x7f16f682ab6f  (/lib/x86_64-linux-gnu/libavahi-client.so.3+0x4b6f)

SUMMARY: AddressSanitizer: 152 byte(s) leaked in 2 allocation(s).

To reproduce you can compile and run ./out/linux-x64-address-resolve-tool-platform-mdns-asan/address-resolve-tool node 1 2 and just ctrl-C out of it while resolution is running.


fix(linux): compilation with the linux-body feature

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Checklist

[ ] This PR will resolve #___
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary
[ ] It can be built on all targets and pass CI/CD.

Other information

Also fixes documentation build with the dox feature.


As a freshly authenticated user, I want to see a dashboard that shows my my orgs, my inventories, and buttons to add inventories and orgs

This can be closed now.


Tests

Seems like there's currently no tests implemented. Would probably be a good idea to consider writing a few tests before/if this project gets any larger.
I'm not very opinionated when it comes to JS test frameworks, any suggestions or preferences are welcome?
Also I'm happy to do this when I get time.

Hey,
I never done anything test-related, ever. It is something I always wanted to learn but never had the right inspiration.
What would you write tests for? The plugins?
I you want to implement them, feel free to choose any test framework you are comfortable with.
Off Topic: do you know where I could share the project to make it more popular? It seems to have the basic things that may get it a few users.
Thanks again, have a good day!

Hey @crisbal !
Ever since telegram implemented an official bots API I've been looking for a flexible javascript implementation that I could play around with and build bots with. One of the hardest things at the moment is deploying a bot that is always on, aside from a local server. I stumbled across this one and it seems to have lots of potential to become a super easy way to start a Bot with a few plugins and throw onto a service like Heroku.
Writing plugins for this look to be ridiculously easy. I have the intention of continuing to contribute to the project and make it better, I hope you don't mind if I do?
Not sure of anywhere to share the project, I believe there are a few telegram bot related directories like /r/TelegramBots. Might be worth throwing a link on to one of them.
In regards to tests, it would be beneficial to write a few test cases for the bot itself. Just to ensure that it is handling errors as expected, forwarding messages to plugins correctly, loading plugins correctly and so forth.
Writing plugins will be easier for contributors if they can be sure the bot itself is working as expected.

Hey,
feel free to do whatever you want in regards of tests.
I didn't  work on the project for a few weeks but now I might pick it up again: there are a few things to handle, update some plugins, improve the code, add some utils methods.... I will work on this in the next days.
If you want to work on it I have no problem: I will be very happy :+1:
I will post a link later on that subreddit, thanks!
Bye! :wave:


Removed unused macos variables

No changes needing a change description found.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1026/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1026/


ros_workspace: 1.0.1-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros_workspace to 1.0.1-1:

upstream repository: https://github.com/ros2/ros_workspace.git
release repository: https://github.com/ros2-gbp/ros_workspace-release.git
distro file: foxy/distribution.yaml
bloom version: 0.9.7
previous version for package: 1.0.0-1

ros_workspace
* set flag to skip parent_prefix_path (#19 <https://github.com/ros2/ros_workspace/issues/19>)
* Contributors: Dirk Thomas

Waiting for other Foxy releases...


Add state to Slack notification on edit

When an edit is submitted, at least if that edit only covers one state, identify the state in the Slack notification in #database-notifications
Request from Michal on Slack

Fixed

Pushed and published edit batch #146. state: AK. (user: ZL)
test


Add haskell-openapi3-code-generator

This is an interesting package because the source repo provides a flake, so all we have to do here is point to it.
Refactors abound because this is the first non-nixpkgs flake input and so it got me rethinking whether flake.nix should really instantiate nixpkgs; instead I'm just taking the approach now where it just passes the inputs and system arg down to let the individual folders do whatever they want with them directly.
There's no check for this one yet. This program doesn't support a --version command. I'm not sure they even bother to version it anymore.
I'm not totally sure whether this is the program we should be using to generate content-client or not; are there any alternatives?

AJ's answer is we have no plan for how to do this.

why are you adding it now?

I guess the answer is I though it would be more difficult to get this package building, and so I wanted a place to store that work. This was before I noticed it had a flake. So I guess there's really no reason at the moment.

Merging without the package because I still like the refactor.


.NET 8 RTM Update

Updates all dependencies and moves everything to .NET 8 RTM.

LGTM. Thanks for updating this.


TypeError: can't multiply sequence by non-int of type 'float'

Thansk for the code and tutorial. I found it very useful.
I am getting TypeError in my dataset. I set up this easy dataset and still getting the same error.
TypeError: can't multiply sequence by non-int of type 'float'
It maybe caused by feature_names because in your example you always used datasets that already have feature_names set up. Can you help me with that?
import pandas as pd
from sklearn import preprocessing, tree
from dtreeviz.trees import dtreeviz
Things = {'Feature01': [3,4,5,0],
'Feature02': [4,5,6,0],
'Feature03': [1,2,3,8],
'Target01': ['5','5','6','6']}
df = pd.DataFrame(Things,
columns= ['Feature01', 'Feature02',
'Feature03', 'Target01'])
y_variable=df[['Target01']]
X_variable=df[['Feature01', 'Feature02','Feature03']]
regressor = DecisionTreeRegressor(max_depth=2)
regressor.fit(X_variable, y_variable)
dtreeviz(regressor,
X_variable,
y_variable,
target_name='Target01',
feature_names=['Feature01', 'Feature02','Feature03']#df.columns[0:3]
     )

y_train needs to be a Pandas Series, in your snippet it is a Pandas DataFrame, if you remove one pair brackets it should be a Series
y_train should be a Series of numbers and class_names should contain the mapping of the numerical ids to the class names
I added an additional check/conversion in this pull request: #51
Can you try it with the modified code and updated library?

I converted the y-train to Panda series by adding:
y_variable=  df.ix[:,3]
And now the code is working. Thank you so much!


V2 : Cannot find module 'most' (npm run dev in 'packages/web')

Expected Behavior
Web running without errors
Actual Behavior

<EMAIL_ADDRESS>dev /opt/OpenJSCAD.org/packages/web
budo demo.js --port=8081 --css demo.css --live -- -b

[0000] info  Server running at http://<IP_ADDRESS>:8081/ (connect)
[0000] info  LiveReload running
Error: Cannot find module 'most' from '/opt/OpenJSCAD.org/packages/web/src/sideEffects/state'
at /opt/OpenJSCAD.org/packages/web/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
at process (/opt/OpenJSCAD.org/packages/web/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
at ondir (/opt/OpenJSCAD.org/packages/web/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
at load (/opt/OpenJSCAD.org/packages/web/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
at onex (/opt/OpenJSCAD.org/packages/web/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
at /opt/OpenJSCAD.org/packages/web/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
at FSReqCallback.oncomplete (fs.js:166:21) {
stream: [Labeled]
}
Steps to Reproduce the Problem

follow eyrly adopter document https://openjscad.org/dokuwiki/doku.php?id=early_v2
run the web: npm run dev in packages/web

Specifications

Version: V2
Platform: Debian, and Windows
Environment: (browser, local server, node.js etc)
nodejs 12.16.1 LTS

@hrgdavor Super. And thanks for the quick feedback. :)

I am using https://openjscad.org/ quite a lot lately, and have moved from OpenSCAD since OpenJSCAD i more live (development wise) ... and I love JS. So looking forward to your help fixing these initial steps, so I can test the V2 as early adopter.

@hrgdavor this was fixed with pull request #529
Can you try again?  :)


Added matrix-market-attoparsec

Sorry, would you mind fixing up that commit message?

NB Please use commit messages like "add foo-bar" or "add johndev's packages" (build-constraints.yaml is the most frequently changed file in this git repo so commit messages like "update build-constraints.yaml" are not helpful).

https://github.com/fpco/stackage/blob/master/MAINTAINERS.md

@lwm yep, sorry about that!

Thanks


Supports different packaging formats for different platforms

tar: true:  the default is tar.gz, but some software is zip for Windows; tar: false is binary format.
for exmaple:
tar: false
or
formatOverrides:
  windows: binary # zip/tar.gz
  linux: zip

@seanly I don't completely understand what is to be done as a part of this issue but I would like to attempt it if it can be explained better. Can you also give me some pointers on where to start and which code to look for?

hi @amoghrajesh , thanks for reaching out to us. As you may know, this project aims to make it be easier to download or install an executable binary file from GitHub release assets. But there is a problem which is related to the different platforms.
Let me give you an example. For this project, the asset file name is hd-windows-amd64.zip in windows, but the suffix is tar.gz in linux.
This is a sample config:
filename: "hd-{{.OS}}-{{.Arch}}.tar.gz"
binary: hd

It's incorrect for the windows platform. So @seanly might want to offer a potential solution to fix it. Add the following configuration support like below:
filename: "hd-{{.OS}}-{{.Arch}}"
binary: hd
formatOverrides:
  windows: zip
  linux: tar.gz

Deep reading
This command will fetch hd-home first, then parse the configuration.
References

https://github.com/LinuxSuRen/hd-home/blob/master/config/linuxsuren/http-downloader.yml
https://github.com/LinuxSuRen/http-downloader/releases/tag/v0.0.42
https://github.com/LinuxSuRen/http-downloader/blob/538372e964a724b165d2dc74ddbc7095217e3d42/pkg/installer/types.go#L4

@LinuxSuRen I am interested in working on this issue but I want a little more context on this.
A few doubts from me:

Will the code changes be in https://github.com/LinuxSuRen/http-downloader or https://github.com/LinuxSuRen/hd-home repo?
The url is constructed somewhere in the code which is using the old config. Now we want to make it use the right one through things like formatOverrides. Am I getting it right?

hi @amoghrajesh

hd-home is a config repo. http-downloader is the repo for the command line. So, we need to change the code from http-downloader
You got the point. But one more thing that we need to consider. Make sure no compatible issue happens.

Hi @LinuxSuRen I have understood the issue conceptually and have created PRs in the respective repositories to fix this.
In the hd-home repo: https://github.com/LinuxSuRen/hd-home/pull/68
In the hd-downloader repo: https://github.com/LinuxSuRen/http-downloader/pull/150.
I wanted to know a simple way this can be tested for sanity before a merge. How do I do that?

Thanks for your quick action. The test steps are simple.

Compile this project with command: make
Clone the repo https://github.com/amoghrajesh/hd-home into directory ~/.config/hd-home, change it to branch amogh-patch
Test this feature with command ./bin/hd install linuxsuren/http-downloader --fetch=false

The key point is about the flag --fetch, it would clone hd-home again.

It would be great if you have Windows and Linux platforms to test it. Virtualbox can help you to have a Windows if you don't have one.
An example of local directory hd-home:
~/.config/hd-home
➜  hd-home git:(master) ls -hal
total 56
drwxr-xr-x  13 rick  staff   416B Sep  3 14:00 .
drwxr-x--x  18 rick  staff   576B May  7 18:57 ..
drwxr-xr-x   5 rick  staff   160B Sep  3 14:00 .devcontainer
drwxr-xr-x  11 rick  staff   352B Oct  2 07:25 .git
drwxr-xr-x   4 rick  staff   128B May  7 18:57 .github
-rw-r--r--   1 rick  staff     7B May  7 18:57 .gitignore
-rw-r--r--   1 rick  staff   179B Jun 27 22:54 .gitpod.Dockerfile
-rw-r--r--   1 rick  staff    34B Jun 27 22:54 .gitpod.yml
-rw-r--r--   1 rick  staff   1.0K May  7 18:57 LICENSE
-rw-r--r--   1 rick  staff    55B Sep  3 14:00 Makefile
-rw-r--r--   1 rick  staff    28B May  7 18:57 OWNERS
-rw-r--r--   1 rick  staff   1.3K Jun 27 22:54 README.md
drwxr-xr-x  34 rick  staff   1.1K Sep 29 09:29 config

@LinuxSuRen I have handled these tasks in the PRs attached. Please have a look and review it. Thanks!


Downloaded only the indexed song in playlist

I know there are these 3 options:
    --playlist-start NUMBER
    --playlist-end NUMBER
    --playlist-items ITEM_SPEC

But what I want is to download the song indexed in the URL ONLY.
Ex: https://www.youtube.com/watch?v=zPlr-o-YEQ&index=5&list=RDwRzeRmFl-M
Song number 5.
Is it possible?

[youtube:playlist] Downloading playlist RDwRzeRmFl_-M - add --no-playlist to just download video _zPlr-o-YEQ


[bugfix]: fix gauc eval online

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Improve Site Subnet Section

Remove Creation Date from Site Subnet Section and replace it with the corresponding DCs of the Site


Passing timestamp to clients

Every room has a timestamp associated with it, which is the origin_server_ts value of the most recent event in the timeline. However, not all events are "useful". We added bump_event_types to only move rooms up the list if the event type matched one provided by the client. E.g bump_event_types: [ "m.room.message", "m.reaction" ] would only look at the timestamps for those event types when determining sort order. This means the most recent event isn't always taken into account, which is good because we don't want things like display name changes to bump rooms up the list.
This is encapsulated in a map[event_type]timestamp per room. This information is treated as global and is represented in RoomMetadata here https://github.com/matrix-org/sliding-sync/blob/main/internal/roomname.go#L42
However some of these events may be old, from before you have joined. Therefore, we need to track timestamps on a per connection basis. This is keyed by listKey (as bump_event_type is per-list) here https://github.com/matrix-org/sliding-sync/blob/main/sync3/room.go#L38 which is updated when live events come in and call SetRoom - https://github.com/matrix-org/sliding-sync/blob/main/sync3/lists.go#L95 and https://github.com/matrix-org/sliding-sync/blob/main/sync3/handler/connstate_live.go#L293 . This map is loaded when the connection is initially made here https://github.com/matrix-org/sliding-sync/blob/main/sync3/handler/connstate.go#L125
The point of this issue is to make  timestamp key in the sync3.Room response which is set to the correct timestamp which is what the server is using to sort based on. This needs to union multiple timestamps because 1 room can be in 2 lists each with different bump_event_types (e.g one bumps on messages, the other room names, so 2 different timestamps). In this case, choose the highest value.
End-to-end tests should ensure that:

upon joining a room, you don't see timestamps from before your join event (the join event is the lowest timestamp that should appear to avoid leaking information).
Events which shouldn't bump do not alter the timestamp.
Events which should bump do alter the timestamp.
Multiple lists with different bump_event_types choose the highest value for the timestamp.

This landed!


Add zstd to win19 image

In this PR zstd was added to win16 only, however, it's supposed to be presented on all images
https://github.com/actions/virtual-environments/pull/414
Related issue
https://github.com/actions/virtual-environments/issues/89
Changes:

Add zstd to win19
Minor version output fix to get rid of 'v' before the version number

/azp run windows2019


feat: configure force_screenshot

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #40 (47ed1fb) into ch24621b (ac44dd0) will decrease coverage by 0.14%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##           ch24621b      #40      +/-   ##
============================================
- Coverage     68.88%   68.74%   -0.15%
============================================
  Files          1598     1598
  Lines         65301    65301
  Branches       6953     6953
============================================
- Hits          44981    44889      -92
- Misses        18435    18527      +92
  Partials       1885     1885

Flag
Coverage Δ

hive
?

mysql
?

postgres
82.14% <ø> (-0.02%)
:arrow_down:

python
82.18% <ø> (-0.31%)
:arrow_down:

sqlite
81.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset-frontend/src/views/CRUD/alert/types.ts
100.00% <ø> (ø)

superset/reports/api.py
88.46% <ø> (ø)

...frontend/src/views/CRUD/alert/AlertReportModal.tsx
53.28% <62.50%> (ø)

superset/db_engines/hive.py
0.00% <0.00%> (-85.19%)
:arrow_down:

superset/db_engine_specs/hive.py
70.27% <0.00%> (-16.99%)
:arrow_down:

superset/db_engine_specs/mysql.py
94.04% <0.00%> (-3.58%)
:arrow_down:

superset/reports/commands/log_prune.py
85.71% <0.00%> (-3.58%)
:arrow_down:

superset/commands/importers/v1/utils.py
89.13% <0.00%> (-2.18%)
:arrow_down:

superset/views/database/mixins.py
81.03% <0.00%> (-1.73%)
:arrow_down:

superset/db_engine_specs/presto.py
83.50% <0.00%> (-0.84%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac44dd0...47ed1fb. Read the comment docs.


Add attribute logging example

This is an example solution to the discussion on issue #266.

This is great, I'm going to take a deeper read and test this week @Jyyjy!
Thinking that organization of examples is getting away from this. I'll raise on dev for thoughts on how to better organize our examples.

This is great, I'm going to take a deeper read and test this week @Jyyjy!
Thinking that organization of examples is getting away from this. I'll raise on dev for thoughts on how to better organize our examples.

I was planning on adding more examples after this one (e.g. mutation observer), so I just joined the flagon dev mailing list to join the discussion.

@Jyyjy this is a great example. Very elegant and shows off a lot of functionality. Made some basic wording mods (to tie back to project better) and fixed some sp. THANK YOU!


Add postgres-operator RBAC permissions for PDB

CrunchyData/postgres-operator#2828 introduced a feature to reconcile the Pod Disruption Budget (PDB) of PG instance sets. This requires additional API permissions which were added to the RBAC definitions (e.g. config/rbac/cluster/role.yaml) in the main repository but forgotten here.
Fixes #78

@ganto thanks for your submission.  However, please note these changes are currently in our devel branch, since this specific RBAC is attached to the Pod Disruption Budget (PDB) feature that has not yet been released.
Once the release of PGO with PDB's is made available, we will ensure the required change is included in the main branch in this repo.  However, for now the change is simply a bit premature.

I don't fully understand. The current Helm chart references the image registry.developers.crunchydata.com/crunchydata/postgres-operator:ubi8-5.0.4-0 and with this image the error as shown in #78 is triggered.


Fix website build failure caused by python doc generate script

Motivation
The CI - Pulsar Website Build has been broken for a long time. Here's an example run: https://github.com/apache/pulsar/runs/2635024657?check_suite_focus=true
CMake Error at python/CMakeLists.txt:85 (MESSAGE):
-- Using Boost Python libs:
  Could not find Boost Python library

It looks like to be the same issue with https://github.com/apache/pulsar/issues/9682. https://github.com/apache/pulsar/pull/9690 fixed the broken CI for cpp client but the ci-pulsar-website-build.yaml wasn't modified.
Another issue is after I fixed the cpp build for website build, the python-doc-gen.sh still failed because the default pdoc is a Python3 tool
+ pdoc pulsar --html --html-dir /pulsar/generated-site/api/python/2.8.0-SNAPSHOT
Traceback (most recent call last):
  File "/usr/local/bin/pdoc", line 7, in <module>
    from pdoc.__main__ import cli
  File "/usr/local/lib/python3.5/dist-packages/pdoc/__init__.py", line 328
    ) -> str:
    ^

So we need to install a Python2 version pdoc as well.
Modifications

Use ubuntu-16.04-py2 tag instead of old ubuntu-16.04 tag in docker-build-site.sh and force CMake to find Python2 in python-doc-gen.sh. The the Pulsar Python client library could be built successfully.
Install a Python2 version pdoc in python-doc-gen.sh.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

The change makes sense to me
but if I run the script locally I see this error:
tools/docker-build-site.sh

.....
+ cp -r /pulsar/target/doxygen/html /pulsar/generated-site/api/cpp/
+ mv /pulsar/target/doxygen/html /pulsar/generated-site/api/cpp/2.8.0-SNAPSHOT
mv: cannot move '/pulsar/target/doxygen/html' to '/pulsar/generated-site/api/cpp/2.8.0-SNAPSHOT/html': File exists

The change makes sense to me
but if I run the script locally I see this error:
tools/docker-build-site.sh

.....
+ cp -r /pulsar/target/doxygen/html /pulsar/generated-site/api/cpp/
+ mv /pulsar/target/doxygen/html /pulsar/generated-site/api/cpp/2.8.0-SNAPSHOT
mv: cannot move '/pulsar/target/doxygen/html' to '/pulsar/generated-site/api/cpp/2.8.0-SNAPSHOT/html': File exists

I think you have built the website before? I think you need to remove the local directory first.

Because the build script starts a docker container and maps the Pulsar project directory to /pulsar directory in container. So it will also create a generated-site directory.
I think it's a minor bug of the script that it uses mkdir to create directory but not mkdir -p. It's not a problem for CI but it could be annoyed when you test the script in local env.

I just built it in my local env. I'm not sure if it's a failure
warning<EMAIL_ADDRESS>Support has ended for 9.x series. Upgrade to @latest
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=12.0.0". Got "10.24.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@BewareMyPower does the website renders correctly on your machine ?
I mean, if you try to see it with a browser

@eolivelli

As for 2.8.0-SNAPSHOT URLs, they're the same with those URLs without 2.8.0-SNAPSHOT.

great


Spike: PCR changing randomly

FreedomFI has reported the PCR values 4 an 7 change after installation.
Acceptance Criterion:

Reproduce the issue for producing screenshots for evrtech.
Investigate TPM working if we can do something about it just in bios settings instead of new efi bios firmware.

Freedomfi had reported that the issue happens due to change in boot order. That is not the case. It happens as combination of old boot device being remove and then boot order changed to boot from new device.

I have verified that none of the options available in efi bios will fix it. It will have to be firmware change.

PCR values while booting from USB and installing system:

sha1:
0 : 0xFDEF400B07517268FAFC055152499AAAB021429E
1 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
2 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
3 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
4 : 0x98E6FFF39AC5CE672A07AB84A55CA6EBEB473AA8
5 : 0xE61A41B3FB7817B83670837C49DB854C0AF88B68
6 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
7 : 0xD1CFC37F866373428362BE3BE37B72B03F6B8845
8 : 0x515810EB5A7010A8516E4704C5E599217E0A6B2C
9 : 0x8B507C29CDECEE7222D260D3C6620664A2CFCE24
10: 0x2BB62B5369C707C1A440115ADA6478F55CF81FF6
11: 0x0000000000000000000000000000000000000000
12: 0x0000000000000000000000000000000000000000
13: 0x0000000000000000000000000000000000000000
14: 0x77DB66D60AA0C2CD1CEA6C34FED4F2AA014BF285
15: 0x0000000000000000000000000000000000000000
16: 0x0000000000000000000000000000000000000000
17: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
18: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
19: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
20: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
21: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
22: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
23: 0x0000000000000000000000000000000000000000

PCR values after USB is removed and system booted from hdd:

sha1:
0 : 0xFDEF400B07517268FAFC055152499AAAB021429E
1 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
2 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
3 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
4 : 0xEB350D4819B1A69730726AE064FB712D57B7AF8B
5 : 0x7127013D76DB4931E7BB7E05CC4FE594E737284D
6 : 0xB2A83B0EBF2F8374299A5B2BDFC31EA955AD7236
7 : 0x65DF28B4F1721D829BB487E36C9949AECC846C59
8 : 0xF36B35FBDF6EE107B748C7028AA8326B1B6AC2D2
9 : 0x415933E8AD69C711CF0E62D520585EBA00F97F8A
10: 0x211323AAAD54EBFAF86483B1BF261C7F1A4F629C
11: 0x0000000000000000000000000000000000000000
12: 0x0000000000000000000000000000000000000000
13: 0x0000000000000000000000000000000000000000
14: 0x0000000000000000000000000000000000000000
15: 0x0000000000000000000000000000000000000000
16: 0x0000000000000000000000000000000000000000
17: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
18: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
19: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
20: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
21: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
22: 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
23: 0x0000000000000000000000000000000000000000

These are only for reference. As these are hashes they will be different from device to device. This is just to prove the reproduction.
The dump as taken using:
sudo tmp2_pcrread
The command is provided by tpm2-tools package which can be installed with
sudo apt install tpm2-tools


Refactor: Investigate any better way for managing services lifecycle

Please describe the task that needs to be done
As a part of #1183 work, #1228 is turning services into class, and components are going to instantiate them like this
https://github.com/KaotoIO/kaoto-ui/pull/1228/commits/b3946131e6d8861c46d8724e50961272ed54d356#diff-b05d69f0aef9ae8d739a7510b44be6747508e1709033a2e44f609523c404f5fcR46
One concern here is the instantiation happens on every rerendering, on every component. It might cause performance degradation. Investigate if there's any better way. Possible option is context/provider pattern.

cf. https://github.com/KaotoIO/kaoto-ui/pull/1338/files#diff-20fc6180949d2fcf17d991cc62c6be55e572335ea16c00c805dcf3c7a8a6089dR41


Bump PROTOCOL_VERSION to 70211

I think we can bump the proto version now. Also makes it easier to test dip3 on develop, as it otherwise complains about an invalid proto version in ProRegTx

@UdjinM6 An idea how long we want to postpone this? My next PRs will introduce unittests and integration tests for DIP3 and they currently fail due to the proto version.
I can add a temporary hack to the tests to use PROTO_VERSION+1 so that the MIN_PROTX_PROTO_VERSION checks succeed. What do you think?

I was thinking about smth like https://github.com/UdjinM6/dash/commit/ac9b6195e4c7043177f21a3dd5632e9dad15074a to make sure that 70211 doesn't care about 70208 nodes too much (still need to drop deprecated code but that's another story).

Feel free to include it :)

@UdjinM6 done, but there was a merge conflict where I'm not sure the merge resolution (in masternode-payments.h) was correct.


Docstrings: recover lost docstring for L.Util.lastId

Related to #5349. It seems that the docstrings for L.Util.lastId was lost in the big rollupJS commit, over here.

Nice catch, I noticed I didn't see any docs when reviewed #5349, but just assumed it must be in some surprising location.

@perliedman That's kinda the point of having docstrings, to keep the docs in unsurprising locations :laughing:

@IvanSanchez lol, good point.


opera target view

This should be safe to merge as it affects only the opera portal.

Hi @Haishi2016 , eclipsefdn/eca checke failed in this PR. Can you please take a look?

Hi @Haishi2016 , eclipsefdn/eca checke failed in this PR. Can you please take a look?

This is because there's a commit from<EMAIL_ADDRESS>....


Migrate from "yum" install to "apt" install

See https://github.com/Senzing/community-roadmap/issues/53

Pull request:

https://github.com/Senzing/resolver/pull/88


upgrade to 6.2.2

Upgrade to https://confluence.atlassian.com/doc/issues-resolved-in-6-2-2-916521743.html

Thank you for your contribution! For a proper upgrade of the confluence version, just setting the version parameter inside the Dockerfile is not enough.
Please take a look at some recent pull request on what files have to be adjusted: https://github.com/blacklabelops/confluence/pull/14

sure, no problem, how that fits better.
You should really think about migrating to tag-based build for hub.docker.io - it would make it simpler and more transparent, in addition, one can easily jump to the tag in the repo to rebuild something.

Thank you very much!


.Paginator.RegularPages

Seeing as 0.18.0 added many new kinds of pages it would be nice if there was an easy way to paginate old way.
https://github.com/spf13/hugo/issues/2775 already added this feature .Site so I'd imagine it would be pretty easy to add to .Paginator as well.

Thanks for getting in touch, but it feels like this is a question  that would be better suited to the Hugo Discussion Forum.  We prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug. You may also find the answers you search for in Hugo Documentation.

https://discuss.gohugo.io/t/add-paginator-regularpages/5391
There you go...
I'm pretty sure this is an enhancement (which you admit belongs in an issue) but whatever.

Hi...I have an issue....I have a front matter field for expiryDate. I want pagination listing all the expired content posts..Is it possible?
My requirement is , I have two tabs for upcoming events and past events. so for showing the past events, I set the expiryDate.
Can somebody help please.....


NDRS-845: Added validator bonding ITS

REF: https://casperlabs.atlassian.net/browse/NDRS-845
CHANGELOG:

Added an integration test that simulates a scenario where a sixth node in a 5 node network bonds in and joins the network
The test will check if the sixth node is a validator by querying the auction contract and checking for the public key in the auction info

PS: This was the first time in a very very very long time I wrote in bash, so mea culpa in advance for not following any style guides

Once https://github.com/CasperLabs/casper-node/pull/1064 merges, most of the code will go away. I will wait with my review for that.

@darthsiroftardis You can merge with dev now.

@goral09 Merged with dev , scenario can be reviewed now

@darthsiroftardis , please wait for Tom's PR to get merged to dev and re-open your with cleaner git history and diff.

@goral09 I agree

Closing in favor of https://github.com/CasperLabs/casper-node/pull/1185


MapIter rename to Iter

@rultor release, tag is 0.0.2

@rultor release, tag is 0.0.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.2

@yegor256 Done! FYI, the full log is here (took me 3min)


Unable to send mail to<EMAIL_ADDRESS>

Describe the bug

Email account is not active for<EMAIL_ADDRESS> I was attempting to communicate important information to PyPi.
Expected behavior

Expected email to arrive, got (gmail) response that “Address not Found”
To Reproduce

My Platform

Additional context

Please email<EMAIL_ADDRESS>instead.


contents of the buffer

hello. As I see, the pio0 for each 32-bit sampled data fills the buffer by two values: the size of the sampled data and the sampled 32-bit data itself. then you add the end time of sampling that data as the third element. thus for each 32 data sampling, the buffer is filled by 3 elements in a row. but sometimes pio0 pushes out another element as a fourth value which is 0xFFFFFFFF.
so, what is this value and what does it mean? is it a flag for the end of the frame?

The size of the data from the PIO is indicated as 0xffffffff-actual size (it counts down from 0xffffffff) and the data is limited to 31 bits. So, highest bit can be used to distinguish size (end of packet) from the data bits.
The only time PIO0 can push 0xffffffff is when the actual size is 0, and that only happens in the case of a line reset (D+=low, D-=low), which appears as a valid start of packet marker, but then does not have synchronization field.
But 0xffffffff is never pushed as an additional data, it is always pushed as a length part.

So for each data sample, g.buffer is filled only with 3 elements: size,
time, data itself.
در تاریخ یکشنبه ۸ سپتامبر ۲۰۲۴، ۱۸:۵۳ Alex Taradov <
@.***> نوشت:

The size of the data from the PIO is indicated as 0xffffffff-actual size
(it counts down from 0xffffffff) and the data is limited to 31 bits. So,
highest bit can be used to distinguish size (end of packet) from the data
bits.
The only time PIO0 can push 0xffffffff is when the actual size is 0, and
that only happens in the case of a line reset (D+=low, D-=low), which
appears as a valid start of packet marker, but then does not have
synchronization field.
But 0xffffffff is never pushed as an additional data, it is always pushed
as a length part.
—
Reply to this email directly, view it on GitHub
https://github.com/ataradov/usb-sniffer-lite/issues/19#issuecomment-2336725079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2VUWY7YRITJFSGWIIOND5LZVRTYLAVCNFSM6AAAAABN3AZVACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWG4ZDKMBXHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Correct. You get data + size from the PIO itself and the time is added in the loop after the last element is read from the PIO.


Correct the interface of magnitudes in rail to flux in Delight

Bug report
Before submitting
Please check the following:

[ ] I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
[ ] I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a description of what I expected instead.
[ ] If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.

During the execution of the Delight demo in rail, there is probably a crash. I suspect a filtering out of the test set, then the results format is not compatible to what is expected. Need to work in convertDESCcat.py


[Feature][GitHub plugin] Support transformations from GitHub Environments

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
I want to classify Deployments and Production Deployments based on the GitHub Environment name that the Job is referring to, instead of only being able to use the Job name
Description
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

What does  GitHub Environment name refer to ?

What does  GitHub Environment name refer to ?

Refer to the name that are highlighed in these printscreens below:

Below is the documentation about the environment field in the Actions definition (ref)

Interesting, never notice this before.
@Startrekzky is following up

Interesting, never notice this before. @Startrekzky is following up

It's basically the same as the environment setting in a BitBucket pipeline step. We can reuse this logic if the environment keys and values are collected.

This is a valid feature, we need to do it.

Hi @Feggah , we are working on collecting GitHub deployments in #5949 . This will also collect the environment of GitHub deployments.
Although I've read GitHub's doc of how deployments are configured, since we're not using GitHub environments, I'm curious about how you configure them in real life. Do you mind sharing an example of your GitHub workflow or job to conduct deployments? Thank you in advance.

Can't help much any longer by giving real-life examples @Startrekzky, I'm not in the same company that I was before.
But our use case was simple: we used environments to apply specific policies to it. For example, for production environments, we had a policy that two people had to approve before the deployment job was executed.
For DevLake specifically, using GitHub Environments would be more reliable than the job name, because we had control over the GitHub Environments and it had a pattern across the company, but for pipeline/job names, each repository had its own different pattern.

Hi @Feggah , DevLake is going to support this in the upcoming v0.20. Please see the pic below. Feel free to reopen the issue if it can not meet your needs.


VirtioFS support for an alternative to 9P for sharing folder

Or support an option for disabling shared folder mounting for kernel without 9p virtio support.

Disabling shared directory support might make sense for an image target, but IIUC almost all distros ship module support for 9pfs. For the kernel target, we need some way to map userspace into the guest. I'd need to take a closer look at virtiofs to see if it'd work, but I'm not sure we can disable shared directory support altogether for kernel targets.

I think that actually virtiofs support is less likely to be present by default. I haven't done a comprehensive survey or anything of that sort, but the Arch kernel built as part of vmtest for example seems to compile that support into a module, which makes it unusable from what I gather (we don't have initrd infrastructure). Similar issue for Fedora, it seems (though it's harder to verify because it does not expose a config from the kernel and I haven't tried to dig out what it is built with).
That being said, I am looking at using it to address https://github.com/danobi/vmtest/issues/83. Wondering if we should just switch over or make virtiofs vs. 9p configurable?

But don't we control the guest kernel? We already have instructions for users to build their guest kernels with a few configs set to =y. Virtiofs module on host shouldn't even be used IIUC. Since on host side it's a FUSE.

But don't we control the guest kernel? We already have instructions for users to build their guest kernels with a few configs set to =y.

I mean yes, we can always tell users what is necessary. But at the same time there is big benefit in being able to just plug in pretty much any distro kernel floating around, in my opinion. Wider compatibility is just a nice-to-have.
That being said, I'd be totally onboard with ditching 9P completely, assuming VirtioFS provides some tangible benefits (hopefully without any downsides other than the above, hopefully)

Don't most distros already build 9p support as =m?
dlxu@dlxu-fedora~ $ grep 9P /boot/config-$(uname -r)
CONFIG_NET_9P=m
CONFIG_NET_9P_FD=m
CONFIG_NET_9P_VIRTIO=m
CONFIG_NET_9P_XEN=m
CONFIG_NET_9P_RDMA=m
# CONFIG_NET_9P_DEBUG is not set
CONFIG_VIDEO_MT9P031=m
CONFIG_9P_FS=m
CONFIG_9P_FSCACHE=y
CONFIG_9P_FS_POSIX_ACL=y
CONFIG_9P_FS_SECURITY=y

So virtiofs as =m wouldn't really regress anything.
Have you found any distro kernels that can plug and play with vmtest?

Virtiofs is also said to be faster. Could be nice if true.

Don't most distros already build 9p support as =m?

I don't know. But looking at the configuration that you use for archlinux, it has:
$ cargo run -- -k bzImage-v6.6-archlinux 'sh -c "zcat /proc/config.gz | grep NET_9P"'
CONFIG_NET_9P=y
CONFIG_NET_9P_FD=m
CONFIG_NET_9P_VIRTIO=y
CONFIG_NET_9P_XEN=m
CONFIG_NET_9P_RDMA=m
# CONFIG_NET_9P_DEBUG is not set

On the other hand, it has CONFIG_VIRTIO_FS=m and I had to change that to y in order to get stuff booting with / being on VirtioFS (at least I believe that was the crux of the matter -- evidentally a bunch of other options got toggled as well).
I don't have (or, personally, particularly care about) other kernels, because I always build my own anyway.

dlxu@dlxu-fedora~ $ grep 9P /boot/config-$(uname -r)
CONFIG_NET_9P=m

And does that kernel work with vmtest?

Nope, failed:
$ vmtest -k /boot/vmlinuz-$(uname -r) -- uname -r
=> vmlinuz-6.9.5-100.fc39.x86_64
===> Booting
[    0.510964]  mount_root_generic+0x1ac/0x360
[    0.511181]  prepare_namespace+0x69/0x280
[    0.511389]  kernel_init_freeable+0x453/0x510
[    0.511596]  ? __pfx_kernel_init+0x10/0x10
[    0.511793]  kernel_init+0x1a/0x1d0
[    0.511963]  ret_from_fork+0x31/0x50
[    0.512139]  ? __pfx_kernel_init+0x10/0x10
[    0.512356]  ret_from_fork_asm+0x1a/0x30
[    0.512611]  </TASK>
[    0.512830] Kernel Offset: 0xe000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)

Edit: Just to clarify, I was under the impression that most distro kernels would work with vmtest. But if they don't then it's fine as well and there would be no regression.

Haha, well I had the exact opposite impression.

Edit: Just to clarify, I was under the impression that most distro kernels would work with vmtest. But if they don't then it's fine as well and there would be no regression.

Haha, well I had the exact opposite impression.

Ah okay. Are the provided Arch and Fedora kernels not based on the respective stock distro config then?


Linux version of Nanobox doesn't work under WSL

Steps followed

Install VirtualBox under Windows
Make VBoxManage.exe available under WSL: sudo ln -s /mnt/c/Program\ Files/Oracle/VirtualBox/VBoxManage.exe /usr/bin/VBoxManage
Install NFS server under WSL: sudo apt install nfs-kernel-server

Output
kristof@DESKTOP-BVK6V55:~$ nanobox
Using nanobox with docker-machine requires tools that appear to not be available on your system.
netfs
View these requirements at docs.nanobox.io/install/requirements/docker-machine/

Looks like it's configured to use Docker instead of VirtualBox. Just as a side note.
As to NFS, the package you grabbed was the kernel package - there's no Linux kernel running on a Windows system, so that version can't work. I don't remember whether or not there's an NFS package that doesn't rely on kernel support, but you'd have to use it, if so.

@kristoftorfs I would assume we wont be able to do nfs using linux sub system for windows. I wonder if we would be able to run nanobox in this context using docker native, if when using docker-machine we would just have to use native mounting.

Well, I actually just moved from docker native to VirtualBox as I was unable to get it working at all (under Windows).

We intend to support windows subsystem for linux but we currently don't. Once WSL comes out of beta we will put the time and work into making both the windows version and the linux versions work in the context of WSL. Thanks for your patience.


Enable bus stops

bus stops are now returned based on route and direction, then matched with the user entry.


Compare time instance only

In my application only the time part of a date matters. Is it possible to compare dates only considering the time? Currently I am doing this by calculating minutes from the time part. This produces a lot of boilerplate code.
In JAVA: http://joda-time.sourceforge.net/api-release/org/joda/time/DateTimeComparator.html#getTimeOnlyInstance()

One way to compare the time (without extending the API) is to compare the date's components.
if (date1.hour == date2.hour && date1.minute == date2.minute ...etc)
It would be a nice feature, however. I will look at working this in, unless you would like to make a pull request.


Explicit guard against node label update when using kubelet plugin

This code adds explicit guard against having the code doing Node label updates when flag --kubelet-registration-path is provided.
See https://github.com/kubernetes-csi/driver-registrar/issues/42

Manually tested both scenarios with a local cluster.  The followings must kept in mind:

KubeletPluginWatcher feature is beta thus true by default
When flag --kubelet-registration-path is omitted in the driver-registrar container, it will automatically fall back to using the registrar directly as a way of registering the driver.
So, when starting the kubernetes kubelet binary, ensure to turn-off the kubelet plugin watcher feature with --feature-gates=KubeletPluginWatcher=false

/lgtm
/approve


Adds support for both API URIs

Description
Converts this example repo to use BASE_URL (or the HTML equivalent: commenting/uncommenting script tags) in order to use the US/EU API servers.
Acceptance Criteria
Anywhere there's an API Call, it should be possible to switch it from US to EU depending on what's commented / uncommented.

@tagspace - I think this is good to go but if I misunderstood what you were looking for, please let me know and I'll make changes as necessary!


GitHub release for v0.138.0 gone/deleted ?

It seems like the GH release for v0.138.0 was deleted sometime today. Probably unintentional?
https://github.com/gohugoio/hugo/releases/tag/v0.138.0

@bep this has caused some nock on effects as folks automated builds fail...

Hugo version: 0.138.0
##[debug]Hugo extended: true
##[debug]Operating System: Linux
##[debug]Processor Architecture: 64bit
##[debug]toolURL: https://github.com/gohugoio/hugo/releases/download/v0.138.0/hugo_extended_0.138.0_Linux-64bit.tar.gz
##[debug]homeDir: /home/runner
##[debug]workDir: /home/runner/actions_hugo
##[debug]binDir: /home/runner/actions_hugo/bin
##[debug]tempDir: /home/runner/actions_hugo/_temp
##[debug]Downloading https://github.com/gohugoio/hugo/releases/download/v0.138.0/hugo_extended_0.138.0_Linux-64bit.tar.gz
##[debug]Destination /home/runner/work/_temp/e86f1ea7-8f8c-4f16-ae92-f7e811f80a06
##[debug]Failed to download from "https://github.com/gohugoio/hugo/releases/download/v0.138.0/hugo_extended_0.138.0_Linux-64bit.tar.gz". Code(404) Message(Not Found)
Error: Action failed with error Unexpected HTTP response: 404
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Setup Hugo

Im guess it was either unintentional or there was something wrong with the release.

Yea,  that's me. I needed to re-start the 0.139 release, and I remember some confusion when the delete didn't work and I guess I forgot which release was the current. I'm not sure this is (easily) fixable, though, so I suggest you upgrade or downgrade.

Well, I guess I can rebuild the release tag ...

Its a github action that installs Hugo.
My note is this has taken out folks builds... looks like there was an issue with 1.32 as well according to the errors listed on the other repo.

\No idea how long it takes Githubs cache to expire on "latest".

The release is back; whether this fixes everything, I don't know -- but it's the best I can do.


Downloaded csv report date format

Is your feature request related to a problem? Please describe.
Not a problem per se, more of an annoyance.  When I download the results from a test run the timestamp is coming down as i.e. 1.64797E+12<PHONE_NUMBER>740)
Describe the solution you'd like
In Jmeter we have the functionality to change the settings so that a csv can be downloaded with a different format for a date by opening the jmeter.properties file and uncommenting #jmeter.save.saveservice.timestamp_format=yyyy/MM/dd HH:mm:ss.SSS.  A similar feature (to change the format) would definitely be a benefit.
Describe alternatives you've considered
At the moment I am having to amend the downloaded report to add a conversion column using formula =(B2 / 86400000) + DATE(1970,1,1) but this involves manual intervention.
AB#1505476

@crozzer Thanks for reporting this. Supporting Jmeter properties file is in our backlog. We will update when this feature is available