ASAP-Alchemy predict

Description
This PR adds the ASAP-Alchemy predict CLI command which can be used to calculate relative and absolute free energies, these are written to csv and can be uploaded to Postera, this will be done in another PR. Provided experimental data is present we also create interactive HTML reports which contain cinnabar style plots and sortable dataframes.
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] Predict absolute free energies from a free energy network result
[x] Create interactive reports when we have experimental data
[x] add simple tests for predict

Status

[x] Ready to go

Developers certificate of origin

[X] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report

Merging #711 (c94e65f) into main (25b3843) will increase coverage by 21.82%.
The diff coverage is n/a.

Additional details and impacted files

this is currently not processing one of my result_network.graphs, returning the error:
raise RuntimeError(
RuntimeError: The transformation - has too many simulated legs, found the following phases ['solvent', 'complex',
'solvent', 'complex', 'solvent', 'solvent', 'solvent', 'solvent', 'solvent', 'solvent', 'complex', 'solvent',
'solvent', 'complex', 'solvent', 'complex', 'solvent', 'solvent', 'solvent', 'complex', 'solvent', 'complex',
'solvent', 'complex', 'complex', 'complex', 'solvent', 'complex', 'complex', 'solvent', 'complex', 'complex',
'solvent', 'complex', 'complex', 'complex', 'solvent', 'solvent', 'solvent', 'solvent', 'complex', 'solvent',
'solvent', 'complex', 'complex', 'solvent', 'solvent', 'complex', 'complex', 'complex', 'solvent', 'solvent',
'complex', 'complex', 'complex', 'complex', 'solvent', 'complex', 'complex', 'complex', 'complex', 'complex',
'solvent', 'complex', 'solvent', 'solvent', 'solvent', 'complex', 'complex', 'complex', 'solvent', 'solvent',
'solvent', 'solvent', 'complex', 'complex', 'complex', 'complex', 'solvent', 'complex', 'complex', 'complex',
'complex', 'solvent', 'complex', 'solvent', 'complex', 'complex', 'solvent', 'solvent', 'complex', 'solvent',
'solvent', 'complex', 'complex', 'solvent', 'solvent', 'solvent', 'solvent', 'solvent', 'complex', 'complex',
'complex', 'solvent', 'solvent', 'solvent', 'complex', 'solvent', 'solvent', 'solvent', 'solvent', 'complex',
'complex', 'complex', 'solvent', 'complex', 'complex', 'solvent', 'complex', 'complex', 'complex', 'complex',
'solvent', 'solvent', 'solvent', 'complex', 'complex', 'solvent', 'complex', 'solvent', 'solvent', 'solvent',
'complex', 'solvent', 'solvent', 'complex', 'complex', 'complex', 'solvent', 'complex', 'solvent', 'complex',
'solvent', 'complex', 'solvent', 'complex', 'solvent', 'solvent', 'solvent', 'complex', 'complex', 'solvent',
'solvent', 'complex'] expected complex and solvent.

-> will investigate

@jthorton I went ahead and did some quick edits - current version of your branch now is also able to deal with singleton experimental data (i.e. if there is no "Mean" in the IC50 column). I also did some quick plotting/naming edits. Other than that, this all looks good, let me know if/when you need me to do a last run-through for approval.


Make Logagent work with Node 7.4

Tried upgrading node to 7.4 yesterday and Logagent failed to start because of missing deps...

This seems to be a general problem with 7.4.
First run
npm i npm@latest -g
Then update  node to 7.4

And then it works?  Or are you saying it doesn't work with 7.4 at all?

This is not a logagent issue - logaagent works with node 7.4.0 once npm and node 7 are correctly installed. Npm v4 must be installed before node gets updated to v7, when  you upgrade a system (at least this is one of the possible workarounds).
Relevant issues:
https://github.com/nodejs/node/issues/9377
https://github.com/npm/npm/issues/14438

One more link to solve the npm problems after upgrade to node 7:
http://stackoverflow.com/questions/40308623/cannot-find-module-internal-fs-afer-upgrading-to-node-7/40406482#40406482


Widevine Url

So basically how can we download mpd dash files which requires Widevine url with custom name & value (as headers). Is this possible with youtube-dl or ffmpeg?

well i am able to play it on https://developer.jwplayer.com/tools/stream-tester/?playerversion=8
if i add license server url and both header and value so i feel if same can be done with youtube-dl like adding header and value with license server url then maybe it's possible but idk.


[Request for External] Table 167 "Job" - UpdateBillToCust

We need to call the procedure "UpdateBillToCust" on Table 167 "Job" from outside.
Please change it from local to global.
OLD CODE:
local procedure UpdateBillToCust(ContactNo: Code[20])
var
    ContBusinessRelation: Record "Contact Business Relation";
    Cust: Record Customer;

NEW CODE:
procedure UpdateBillToCust(ContactNo: Code[20])
var
    ContBusinessRelation: Record "Contact Business Relation";
    Cust: Record Customer;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Proposal: MessageData to support BinaryData

Created a discussion awhile back (#5142) but figured I'd create a draft PR.
Adds support for BinaryData (from System.Memory.Data) as a supported type on MessageData<>.

The BinaryData type provides a lightweight abstraction for a payload of bytes. It provides convenient helper methods to get out commonly used primitives, such as streams, strings, or bytes. The assumption when converting to and from string is that the encoding is UTF-8.

The main value of this type is its ability to easily convert from string to bytes to stream. This can greatly simplify API surface areas by exposing this type as opposed to numerous overloads or properties.

The motivation is to enable easier consumption of MessageData<>, consolidate the existing conversion types (though it makes sense to leave MessageData<Stream> due to instances where the consumer may just be a proxy) and improve performance (easier access to Memory/Span to reduce allocations, etc.). The BinaryData abstraction has also become more widely utilized in the core MS libraries so this aligns MT more closely with standard conventions.
This takes an additional dependency on System.Memory.Data, however, it's arguably used by the vast majority of modern applications so this shouldn't be a burden.
If this is a desired change I'll add unit tests, etc.

The motivation is to enable easier consumption of MessageData<>

I don't know if I buy that, I don't know why in a messaging system you would need binary specifically.
Surely the implementation should be handling this and not the message system itself.
What is the benefit here over Streams ? I don't like the idea of reading arbitrary binary for text content.
I'm not sure yet also but I get the sentiment there is also a potential security issue here too but will need to do more to see.


Imbalance of C/NC samples

Hi,
I split PIE and JAAD dataset as your paper and codes. But I find imbalance of C/NC samples.
In PIE dataset, the numbers of different samples are as follows:

NC
C

Train
3576
1194

Test
2742
1074

In JAAD_beh dataset, , the numbers of different samples are as follows:

NC
C

Train
374
1760

Test
704
1177

In PIE dataset, the number of NC samples is far more than the number of C samples. In JAAD dataset, the number of C samples is more than the number of NC samples. I think it is harmful to train a model.  Is the split result correct? Could you please explain this distribution?

Yes, we are aware of the imbalance in the dataset. Please see the code of the benchmark and the text of the paper for details on how to deal with this. In short, you can either subsample the larger class or keep the data and set the class weights inversely proportional to the samples in each class. Both methods work, with the second option you get more training data.


[PLATFORM-1008]: Use macros for configuration

https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-1008

I converted this PR to a draft because it's a WIP "redesign" of how we configure Telepoison and I'm still poking around to understand how to proceed
The setup function is a bit misleading because it's actually optional and should probably be configure or something along those lines
Since it's implemented with an Agent the agent may not be there and that's why we check if the Agent has been started, but I think your suggestion of catching is better. As far as validating earlier: ideally yes, I'll try to see if I can change it to make it so.
In general, we were wondering if there was a way to make Telepoison more like bridge_ex and pass configuration using a macro, but I don't even know if it makes sense for this use case


ref/add_nativead_properties

Add icon, isOptionsViewAvailable, and isMediaViewAvailable, to ad object of native ad UI callbacks

Updated, please review.


Dockerfile not working.

I'm using a Linux server for tavernAI
but the docker file won't work at all.

We need an explanation of why the symlink is needed so that others can decide whether to delete or improve the line.

I have the same issue.
i BELIVE the ${APP_HOME}/config should be either a localmount (-v) or a volume.

docker run -v $(pwd)/config:/home/node/app/config -p 8000:8000 -it tavernia:1.3.1-1 sh


arvis-app-launcher-plugin cannot find some standard macOS apps by default

By default, typing "activity monitor" (with or without quotes) in Arvis search bar in macOS could not find the standard "Activity Monitor" app located inside /Applications/Utilities folder. What was strange was the following default user-config entries for arvis-app-launcher-plugin shown inside Arvis Preference window. I thought the "deep: 3" key/value would enable Arvis to find "Activity Monitor" app inside "/Applications/Utilities" folder.
object {2}
applicationFolders {3}
win32 [1]
darwin [1]
0: /Applications
linux [5]
deep: 3
Expected Behavior
Typing "activity" or "monitor" in arvis search bar should list "Activity Monitor" app which comes pre-installed in macOS.
Current Behavior
"Activity Monitor" is not found or listed by arvis.

Node version : 14.17.6
Arvis version, branch :  0.12.0
Operating System and version : macOS Big Sur (11.6.0)

Thanks for reporting this bug.
In fact, there is no Activity monitor.app (and other app files) in /Application/Utilities.
It is in the System/Applications/Utilities but mac's finder shows the files as if there are in /Application/Utilities.
I think I should add System/Applications/Utilities path to default path to arvis-app-launcher-plugin.

This bug is fixed on<EMAIL_ADDRESS>


Update readme file

On first attempt to run the flutter packages pub run build_runner build command, I ended up having a couple of errors regarding "conflicting outputs".
After digging up a little, I found out that the command could not modify the file for some reason.
Adding an additional argument to the command, let it delete and re-create the file if need be.
After that initial run I could run the initial command of the documentation without any issue.
It's minor, but might help

Thanks 👍


All Stock Size gas giants and stars still cannot be scaled correctly.

You claim that the latest version has solved the problem of rescaling gas giants and stars, but according to my test (game version 1.12.5), in a typical 10.66x rescaling test (if it works properly, then Kerbin's size and mass are the same as the Earth in the real world, making it reasonable to explore the Stock System using Realism Overhaul), I found that the laythe, which is 10.66x in size, surrounds the Jool of Stock Size, and the entire Jool System is closer to Kerbol than Moho, while Kerbol becomes quite huge and looks like a red giant star, which makes it impossible for this system to explore properly. Therefore, we hope the bug can be fixed as soon as possible. When combined with Outer Planets Mod, the three additional giant planets sarnus, Urlum and Neidon cannot rescale properly, just like jool. All celestial bodies in the real solar system can achieve normal rescaling, but stars and gas giant in stock system such as Kerbol and Jool still cannot rescale properly.I don't know why Jupiter, Saturn, Uranus, and Neptune can get the correct rescaling, but Jool in the stock system and Sarnus, Ullum, and Neidon in OPM cannot get the correct rescaling.

@OrganicRigel  could you send your log

should be fixed in the next update


cmake 配置项目

Unknown CMake command "query_qt_paths".

[main] Configuring project: framelesshelper
[driver] Removing e:/code/framelesshelper/build/CMakeCache.txt
[driver] Removing e:\code\framelesshelper\build\CMakeFiles
[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_TOOLCHAIN_FILE=F:/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows-static-md -DCMAKE_PREFIX_PATH=F:/Qt/5.15.2/msvc2019_64 -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -SE:/code/framelesshelper -Be:/code/framelesshelper/build -G "Visual Studio 16 2019" -T host=x64 -A x64
[cmake] Not searching for unused variables given on the command line.
[cmake] -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.22621.
[cmake] -- The C compiler identification is MSVC 19.29.30148.0
[cmake] -- The CXX compiler identification is MSVC 19.29.30148.0
[cmake] -- Detecting C compiler ABI info
[cmake] -- Detecting C compiler ABI info - done
[cmake] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting C compile features
[cmake] -- Detecting C compile features - done
[cmake] -- Detecting CXX compiler ABI info
[cmake] -- Detecting CXX compiler ABI info - done
[cmake] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting CXX compile features
[cmake] -- Detecting CXX compile features - done
[cmake] --------------------------- Toolchain ----------------------------
[cmake] CMake version: 3.25.0-rc2 (C:/Program Files/CMake/bin/cmake.exe)
[cmake] Host system: Windows-10.0.22621
[cmake] Host processor: AMD64
[cmake] C++ compiler: MSVC (C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe)
[cmake] C++ compiler version: 19.29.30148.0
[cmake] Linker: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/link.exe
[cmake] Make program: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/MSBuild/Current/Bin/MSBuild.exe
[cmake] Generator: Visual Studio 16 2019
[cmake] Build type:
[cmake] Configuration types: Debug;Release;MinSizeRel;RelWithDebInfo
[cmake] Install prefix: C:/Program Files/FramelessHelper
[cmake] Prefix paths: F:/vcpkg/installed/x64-windows-static-md/debug;F:/vcpkg/installed/x64-windows-static-md;F:/Qt/5.15.2/msvc2019_64
[cmake] Toolchain file: F:/vcpkg/scripts/buildsystems/vcpkg.cmake
[cmake] ------------------------------ Qt -------------------------------
[cmake] -- Configuring incomplete, errors occurred!
[cmake] See also "E:/code/framelesshelper/build/CMakeFiles/CMakeOutput.log".
[cmake] CMake Error at CMakeLists.txt:163 (query_qt_paths):
[cmake]   Unknown CMake command "query_qt_paths".
[cmake]
[cmake]
[proc] The command: "C:\Program Files\CMake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_TOOLCHAIN_FILE=F:/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows-static-md -DCMAKE_PREFIX_PATH=F:/Qt/5.15.2/msvc2019_64 -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -SE:/code/framelesshelper -Be:/code/framelesshelper/build -G "Visual Studio 16 2019" -T host=x64 -A x64 exited with code: 1

把子模块也一起拉下来

👌


fix bug in MMC

Codecov Report

Merging #85 into master will increase coverage by 0.66%.
The diff coverage is 97.95%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   87.48%   88.15%   +0.66%
==========================================
  Files          27       28       +1
  Lines         895      920      +25
==========================================
+ Hits          783      811      +28
+ Misses        112      109       -3

Impacted Files
Coverage Δ

libact/models/sklearn_adapter.py
95.65% <ø> (+4.34%)
:white_check_mark:

libact/models/multilabel/dummy_clf.py
94.11% <100%> (-5.89%)
:x:

...query_strategies/multilabel/binary_minimization.py
100% <100%> (ø)

..._strategies/multilabel/maximum_margin_reduction.py
97.77% <100%> (-0.3%)
:x:

libact/query_strategies/multilabel/init.py
100% <100%> (ø)
:white_check_mark:

libact/models/multilabel/binary_relevance.py
76.81% <100%> (ø)
:white_check_mark:

libact/models/logistic_regression.py
94.73% <ø> (+15.78%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1f799...801b9fa. Read the comment docs.


Exception binding parameter 'auth'. HexMaster.Functions.JwtBinding: Could not load file or assembly 'Microsoft.IdentityModel.Tokens, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

I have added your library to my functions and added an auth paramater with the binding. If I enable debugging it works.
If I send a token I get the error in the title.
 Microsoft.Azure.WebJobs.Host: Exception binding parameter 'auth'. HexMaster.Functions.JwtBinding: JWT Token Validation failed, request not authorized. Authorization header is missing, add a bearer token to the header of your HTTP request.
If I explicitly include <PackageReference Include="Microsoft.IdentityModel.Tokens" Version="<IP_ADDRESS>" /> it won't compile because your package requires >=<IP_ADDRESS>.

See https://github.com/nikneem/azure-functions-jwt-binding/issues/35

Ok that worked can the reaadme be updated with a note that you might have to do this.


Dependency not found for TestFrameworkType.Metrics

What happened?
When I add TestFrameworkType.Metrics, then the plugin is unable to locate this dependency. I'm building against IC-242.19533.56-EAP-SNAPSHOT.
        dependencies {
            intellijPlatform {
                testFramework(TestFrameworkType.Bundled)
                testFramework(TestFrameworkType.Metrics)
          // ...

Repositories:
            intellijPlatform {
                defaultRepositories()
                snapshots()
            }

Relevant log output or stack trace
* What went wrong:
Execution failed for task ':compileTestKotlin'.
> Could not resolve all files for configuration ':testCompileClasspath'.
   > Could not find com.jetbrains.intellij.tools:ide-metrics-benchmark:242.19533.56.
     Searched in the following locations:
       - file:/home/user/.m2/repository/com/jetbrains/intellij/tools/ide-metrics-benchmark/242.19533.56/ide-metrics-benchmark-242.19533.56.pom
       - https://repo.maven.apache.org/maven2/com/jetbrains/intellij/tools/ide-metrics-benchmark/242.19533.56/ide-metrics-benchmark-242.19533.56.pom
       - file:/home/user/project/libs/ide-metrics-benchmark-242.19533.56.jar
       - file:/home/user/project/libs/ide-metrics-benchmark.jar
       - http://localhost:7348/com.jetbrains.intellij.tools/ide-metrics-benchmark/242.19533.56/descriptor.ivy
       - https://cache-redirector.jetbrains.com/intellij-dependencies/com/jetbrains/intellij/tools/ide-metrics-benchmark/242.19533.56/ide-metrics-benchmark-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/releases/com/jetbrains/intellij/tools/ide-metrics-benchmark/242.19533.56/ide-metrics-benchmark-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/snapshots/com/jetbrains/intellij/tools/ide-metrics-benchmark/242.19533.56/ide-metrics-benchmark-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/plugins.jetbrains.com/maven/com/jetbrains/intellij/tools/ide-metrics-benchmark/242.19533.56/ide-metrics-benchmark-242.19533.56.pom
     Required by:
         project :
   > Could not find com.jetbrains.intellij.tools:ide-metrics-collector:242.19533.56.
     Searched in the following locations:
       - file:/home/user/.m2/repository/com/jetbrains/intellij/tools/ide-metrics-collector/242.19533.56/ide-metrics-collector-242.19533.56.pom
       - https://repo.maven.apache.org/maven2/com/jetbrains/intellij/tools/ide-metrics-collector/242.19533.56/ide-metrics-collector-242.19533.56.pom
       - file:/home/user/project/libs/ide-metrics-collector-242.19533.56.jar
       - file:/home/user/project/libs/ide-metrics-collector.jar
       - http://localhost:7348/com.jetbrains.intellij.tools/ide-metrics-collector/242.19533.56/descriptor.ivy
       - https://cache-redirector.jetbrains.com/intellij-dependencies/com/jetbrains/intellij/tools/ide-metrics-collector/242.19533.56/ide-metrics-collector-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/releases/com/jetbrains/intellij/tools/ide-metrics-collector/242.19533.56/ide-metrics-collector-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/snapshots/com/jetbrains/intellij/tools/ide-metrics-collector/242.19533.56/ide-metrics-collector-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/plugins.jetbrains.com/maven/com/jetbrains/intellij/tools/ide-metrics-collector/242.19533.56/ide-metrics-collector-242.19533.56.pom
     Required by:
         project :
   > Could not find com.jetbrains.intellij.tools:ide-util-common:242.19533.56.
     Searched in the following locations:
       - file:/home/user/.m2/repository/com/jetbrains/intellij/tools/ide-util-common/242.19533.56/ide-util-common-242.19533.56.pom
       - https://repo.maven.apache.org/maven2/com/jetbrains/intellij/tools/ide-util-common/242.19533.56/ide-util-common-242.19533.56.pom
       - file:/home/user/project/libs/ide-util-common-242.19533.56.jar
       - file:/home/user/project/libs/ide-util-common.jar
       - http://localhost:7348/com.jetbrains.intellij.tools/ide-util-common/242.19533.56/descriptor.ivy
       - https://cache-redirector.jetbrains.com/intellij-dependencies/com/jetbrains/intellij/tools/ide-util-common/242.19533.56/ide-util-common-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/releases/com/jetbrains/intellij/tools/ide-util-common/242.19533.56/ide-util-common-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/www.jetbrains.com/intellij-repository/snapshots/com/jetbrains/intellij/tools/ide-util-common/242.19533.56/ide-util-common-242.19533.56.pom
       - https://cache-redirector.jetbrains.com/plugins.jetbrains.com/maven/com/jetbrains/intellij/tools/ide-util-common/242.19533.56/ide-util-common-242.19533.56.pom
     Required by:
         project :

Steps to reproduce
Setup the dependency
Gradle IntelliJ Plugin version
2.0.0.beta8
Gradle version
8.8.0
Operating System
Linux
Link to build, i.e. failing GitHub Action job
No response

Thank you for reporting! Unfortunately, Test Framework libraries aren't published for every IntelliJ Platform build.
I have switched TF helpers to use closest version instead of fixed IntelliJ Platform build number.
See: https://github.com/JetBrains/intellij-platform-gradle-plugin/commit/f8332f5f53a5653fde064c8c7e883497c143534c


Record Videos with Custom Builder

Hello, i need some help. I don't get it, how to start and stop recording Video with own Widgets.
What i mean is: I have a Button, if i hold press on it, i wan't to start recording a video. and if 5 seconds are over or the button is released it should stop it. After that i wan't to return it as a xfile.
how can i do that?
would be very thankful for any kind of help.
here is my code:
 CameraAwesomeBuilder.custom(
        progressIndicator: _skeleton(),
        builder: (cameraState, previewSize, previewRect) {
          return Stack(
            alignment: Alignment.center,
            children: [
              ...
              Positioned(
                bottom: 20,
                // child: AwesomeCaptureButton(
                //   state: cameraState,
                // ),
                child: inProcess
                    ? const CircularProgressIndicator()
                    : GestureDetector(
                        onTap: () {
                          setState(() {
                            inProcess = true;
                          });
                          cameraState.when(
                            onPhotoMode: (p0) {
                              shotPhoto(p0);
                            },
                          );
                        },
                        onLongPress: () {
                          if (cameraState.captureMode == CaptureMode.photo) {
                            cameraState.setState(CaptureMode.video);
                          }
                          setState(() {
                            videoRecording = true;
                          });
                          cameraState.when(
                            onVideoMode: (state) {
                              state.startRecording();
                            },
                          );
                          // after 5 stop record
                          timer = Timer(const Duration(seconds: 5), () {
                            setState(() {
                              videoRecording = false;
                            });
                          });
                        },
                        onLongPressEnd: (details) {
                          setState(() {
                            videoRecording = false;
                          });
                          timer!.cancel();
                          cameraState.when(
                            onVideoRecordingMode: (p0) {
                              p0.stopRecording();
                            },
                          );
                          if (cameraState.captureMode == CaptureMode.video) {
                            cameraState.setState(CaptureMode.photo);
                          }
                        },
                        child: ClipRRect(
                          borderRadius: BorderRadius.circular(45),
                          child: Shimmer(
                            duration: const Duration(seconds: 1),
                            interval: const Duration(seconds: 1),
                            color: Theme.of(context).colorScheme.primary,
                            child: Stack(
                              children: [
                                Container(
                                  width: 70,
                                  height: 70,
                                  decoration: BoxDecoration(
                                    color: Colors.black.withOpacity(0.15),
                                    borderRadius: BorderRadius.circular(45),
                                    // color: Theme.of(context).colorScheme.background,
                                  ),
                                  child: const Icon(
                                    Icons.camera_alt_outlined,
                                    color: Colors.white,
                                    size: 40,
                                  ),
                                ),
                                if (videoRecording)
                                  const SimpleCircularProgressBar(
                                    size: 70,
                                    animationDuration: 5,
                                    mergeMode: true,
                                    progressColors: [
                                      Colors.red,
                                    ],
                                  ),
                              ],
                            ),
                          ),
                        ),
                      ),
              ),
            ],
          );
        },
        ...

this is how i did it for photos:
shotPhoto(PhotoCameraState cameraState) async {
    photos.clear();
    if (both == false) {
      await cameraState.takePhoto().then((value) {
        value.when(
          single: (p0) async {
            photos.add(p0.file!);
          },
        );
      });
    } else {
      await cameraState.takePhoto().then((value) {
        value.when(
          single: (p0) async {
            photos.add(p0.file!);
          },
        );
      });
      await cameraState.switchCameraSensor().then((value) async {
        await cameraState.takePhoto().then((value) {
          value.when(single: (p0) async {
            photos.add(p0.file!);
          });
        });
      });
    }
    await finish().then((value) {
      setState(() {
        inProcess = false;
      });
    });
  }

Hi you should taking a look at our premade UI here
Just use the state.when to handle the use cases.
You don't need to change from video state to recording state. That's all the beauty of using an orchestrator.
We do that for you.
widget.state.when(
    onPhotoMode: (photoState) => photoState.takePhoto(),
    onVideoMode: (videoState) => videoState.startRecording(),
    onVideoRecordingMode: (videoState) => videoState.stopRecording(),
  );

That's it.
You can handle that in the saveConfig

@kyrill-bo If you using android I think you should change getDownloadsDirectory();  to getTemporaryDirectory. The path provider plugin not supported getDownloadDirectory(); for android devices based on documentation. Check this : https://pub.dev/packages/path_provider

@kyrill-bo Accrording to the documentation path_provider, maybe you should replace "getDownloadsDectory();" with "getTemporaryDirectory();" when using an Android Device. The getDowloadsDirectory(); not supported for android platform. Check this :  https://pub.dev/packages/path_provider

@kyrill-bo According to the documentation from path_provider, maybe you should replace getDownloadsDectory with getTemporaryDirectory when using an Android Device. The getDowloadsDirectory not supported for android platform. Check this :  https://pub.dev/packages/path_provider

After stopRecording nothing happens there is no video stored, what could be the reason? (no, error logs)

how did u let the user automatically pop from recording? meaning after 5 seconds are you automatically redirecting the user to a video preview page automatically ?


Adding monitors and indexes via resources

Hey all,
I was looking through the source here and I can't see a generic way to add indexes and monitors via the standard Chefified resources. Does this exist in the cookbook today? If so where? Currently we just have shell resources executing the commands by hand but would rather have a more inline, idempotent way of doing this.

I think there's a broader discussion to be had about how to properly manage splunk configs. There are several different ways of doing it (e.g. templating the entire config file, using file_edit, or rolling out a splunk app), and each have their pros and cons.
I tend to favor app bundles for managing .conf files in my own deployments (which I can manage with the splunk_app resource), but I understand that's not the ideal approach for a lot of other folks.

+1 doesn't exist, would be great if it existed. Previous PR to add this was https://github.com/chef-cookbooks/chef-splunk/pull/8  ... and closed due to not having tests :(


Missing docs for "nat" resources

Didn't find docs for "nat" resources (ochk_manual_nat, ochk_auto_nat) - only way to learn to use it is to look at examples and provider code.
Also docs for "nat" data sources look incomplete/unfinished.

Fixed by #59


Grammar tweaks in readme

Hi, I made some grammar changes to the readme to improve readability. Hopefully you find this useful. Any changes to the meaning of the text are unintentional. Thanks.

Thanks!

Thanks!


Server down

Seems like any POST call to https://pyright-playground.azurewebsites.net/api/session ends up timing out since last week, at least on my end.

Thanks for the heads up. Looks like the server ran out of storage. I deleted a bunch of older pyright versions (which it caches), and this appears to have fixed the problem. Let me know if you continue to see issues.

Thanks for the quick follow up, it works now.


Deprecated gradle feature

Gradle: 4.7
Right now while using this pluiging gradle apwms warnings "registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)". Could you please patch it?

now broken with gradle-6.

I believe you that it's broken, however I am personally not using Victor anymore and don't have any time to fix it soon (especially given Thanksgiving weekend). PRs are welcome, otherwise I'll try to find some time in December to fix.

would you like a PR for this @dlew

I would accept PRs, yes.

Fixed by #71


[request] change to use github cli or add pull request feature ?

Do you want to change to use github-cli or add pull request checkout function?
I know that github-cli will call github api too but it has more feature and easy to use
https://github.com/nvim-telescope/telescope.nvim/pull/305

That looks awesome! Initially I thought about using GH CLI but didnt want to bring in any "unjustified" dependencies. But I can see how it can help solving problems such as pagination or rate limits. I dont know if it will be possible to get all the info we need from the CLI though, so it may only be valid in some places.
Octo.nvim is already using telescope so if you look for a home for those pickers, it would be nice to integrate them here (or have them in nvim-telescope/telescope-github.nvim as proposed by @tjdevries and then make that a dep for octo.nvim)

Voting for this feature! :+1:

Awesome, didnt know about the api command. Will definitely migrate it to use cli 👍🏻

@weilbith Just finished migrating to GH CLI, can you please check the ghcli branch? any help testing it is welcome!

Feedback in the PR. :upside_down_face:

Implemented in 6ec594dbd3261919f460395c62e3aca9b7f20de1


Improve TestYamls and TestExamples

For the current being, there are overlapped tests ie. pipelinerun.yaml in both examples test  and yaml test. This is confusing in the case for maintainers to decide whether we should maintain and keep both yamls synced or not. This issue is reported in order to find a way forward for TestYamls and TestExamples, we need to either:

[ ] rewrite TestYamls and TestExamples to avoid testing on repeated yaml cases
[ ] keep the testYamls yaml files and examples synced

cc @lbernick @vdemeester

Related: https://github.com/tektoncd/pipeline/issues/6142

From https://github.com/tektoncd/pipeline/pull/3564, it looks like testYamls was introduced to test pipelineruns w/ images built based on the pipelines source, while our examples tests would use the latest versions of the images. Looking at the two yaml tests remaining, they are duplicates of examples tests, and neither of them use ko to build images. So I think we can just remove the yamls tests. @vdemeester to confirm.


fix: limit grip events to 1 hour difference

Description of PR

Added a condition to limit grip events association to 1 hour time window.
What component(s) does this PR affect?

[ ] Back-End (Node.js, Next.js)
[x] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Node.js, Next.js)
[ ] Front-End (React.js)
[ ] Theming (CSS, React theme)
[ ] Build System
[ ] Docs

Related Issue

Resolves #
Solution

Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

)`>>>)>

Please merge the current master branch so that we see only the actual changes in the PR

I synced :)


Largest Palindromic Subsequence

Hey, I am Dhyani Desai , a GSSOC'21 participant. I am a Competitive Programmer and C++ enthusiastic.
I want to an for finding the Largest Palindromic Subsequence in C++ language.
Please assign this task to me.
@anubhavitis @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99 @rudrakshi99

@dhyanid13 do it for string

Hey. I'm GSSOC'21 participant and want to work on this problem in Java. Please assign this to me.

Hey, I'm GSSOC'21 participant.
I want to work on this issue in PYTHON with proper indentation and comment.
Please assign this issue to me.

Hey, I'm a GSSOC'21 participant. I would like to work on this issue in C++, please assign it to me.


Bug: Fix React native WebSocket detection

Thanks!
BTW. Nice package! Saved me a considerable amount of time!


Simple and Scientific Calculator.

How to make Simple and Scientific Calculator using classes and functions.
Hope you like it Sir.

Give proper extension

@abhilashmnair Done Sir.


How to release the deleted space in vearch

After I executed the command 'curl -XDELETE {{MASTER}}/space/test_vector_db/vector_space', I don't see any db space size change by 'df -h',  may I know how to relase the db space for those deleted space in vearch?

@liruixue  This feature is developing，we will release it later.

I C. Thank you.


single setUp/tearDown per suite/group?

The current examples I can find only show how to  do a setup/teardown per test. Is it possible to:

run a single test harness/suite setup/tear down
barring that:
a) get some hook into nodeunit to know how many tests are to be run (ie, if a -t option was used)
b) get some notification when all the test.done() are called to write a custom "done" hook

Ultimately the parent setUp and tearDown should only be run on the group not on each test case.  i.e:
exports.testCaseGroups2 = function (test) {
var call_order = [];
var s = {
setUp: function (callback) {
call_order.push('setUp');
callback();
},
tearDown: function (callback) {
call_order.push('tearDown');
callback();
},
test1: function (test) {
call_order.push('test1');
test.done();
},
group1: {
test2: function (test) {
call_order.push('group1.test2');
test.done();
},
test3: function (test) {
call_order.push('group1.test3');
test.done();
}
}
};
nodeunit.runSuite(null, s, {}, function (err, assertions) {
test.same(call_order, [
'setUp',
'test1',
'tearDown',
'setUp',
'group1.test2',
'group1.test3',
'tearDown'
]);
test.done();
});
};

I know that this is super old, but it confused me for a bit, so for the sake of anyone else that ends up here. I found this to be false:

Ultimately the parent setUp and tearDown should only be run on the group not on each test case.

I stuck a console.log() in the setUp() method where several groups of tests were required (each requiring their own subgroups too) and my log message displayed just before each individual test in the console instead of before each group.

I agree, just tested and the code posted by @chriskinsman follows this call order:
[
  'setUp',
  'test1',
  'tearDown',
  'setUp',
  'group1.test2',
  'tearDown',
  'setUp',
  'group1.test3',
  'tearDown'
]

@chasingmaxwell Have you found a nice workaround to fix this?

@jonas-wilhelm unfortunately, I don't have a workaround handy. The project I was working on recently migrated to a different test framework.


[otbn] What should traces look like?

At the moment, we haven't got a tracer in the RTL. We do, however, have tracing in otbnsim. The basic design is that you get a list of Python "trace items" which can be printed with str().
Eventually, we're going to want to compare the RTL's behaviour with that of the simulator. The easiest way to do this is diffing the output traces. Are we happy to force the SystemVerilog tracer to generate the existing trace format from otbnsim? If not, how do we fix it? Do we change the riscv-python-model code (dubious, because it's not just used by OTBN), or do we have some sort of translation layer?
I don't really have a preference but, if we do go for a translation layer, I propose that we put it in the otbnsim code. This will make it much simpler to do lock-step comparisons (because then the C++ or SystemVerilog code that's doing the juggling between the design and the model can just do a textual diff between the two outputs).

The tracer is now implemented and a documentation is available in the README.


Shivdev-- Added a portfolio

Portfolio Author
Shivani Yadav    (104)
Portfolio Link?
https://shivaniyadav.online/
GitHub Link:
https://github.com/ShivaniYadav07/

Done ! check it out


Webpack dev-client and dev-server

Question
I am curious why we have both dev-client and dev-server webpack config file.

You mean why reactGo separate two files? It is because webpack.config.dev-client.js is required at server/index.js, whereas webpack.config.dev-server.js and webpack.config.prod.js aren't.

This is the "isomorphic" nature of things, which can take a little getting used to (especially when you run into issues with why something runs on the client, but blows up on the server [tip: use DefinePlugin FLAGS]).
The "Client" config is built to be run in the client/browser/DOM/etc. The "Server" is built and executed on the server.  There is a PROD Client too, but it's all in the same config file along with the SSR/Server config.
First project I've worked w/ webpack, so correct me if I'm wrong, anybody 🍻

What about universal webpack?

Yeah I'm having a hard time trying to include few npm modules in webpack.
Should the css/js files be included in the 'entry' section in webpack config? If so, in which one?
Or maybe through the require() in App.jsx?
I've tried to require few css files (with style!css! flags), but I'm getting 'window' is not defined error.
Anyone got the same issue?

I found this config to be one of the best but workflow is not ideal as it is in https://github.com/kriasoft/react-starter-kit which has browserSync and many other things and only one webpack config. It even allows hot reloading on stateless components.

Thanks for that @alex-shamshurin
I do agree with

It's a little annoying to update 2-3 files.

That's kind of on my to do list to reduce the complexity of the configs. :(

To avoid problem with 'window' the best solution is isomorphic-style-loader, like this
 {
        test: /\.styl$/,
        loader: 'isomorphic-style-loader!css?modules&importLoaders=1&localIdentName=[path][local]___[hash:base64:5]!' +
        'stylus?paths[]=node_modules&include css&resolve url'
      },

@choonkending Let's then merge it with https://github.com/kriasoft/react-starter-kit config. Do try a workflow which it provides. Everything is hot reloaded.

this thread is out of control 🙈

We're cleaning the project of stale issues therefore i'm closing this. The different files were combined to one at https://github.com/reactGo/reactGo/pull/822


Support per-view custom methods

Long story short
I'm trying to implement DAV protocol over aiohttp, and for custom HTTP-methods like MKCOL, PROPFIND I'm receiving 405 Method Not Allowed.
Expected behaviour
web.View is able to define extra supported methods, not listed in web.hdrs.METH_ALL
Actual behaviour
@asyncio.coroutine
    def __iter__(self):
        if self.request.method not in hdrs.METH_ALL:
            self._raise_allowed_methods()

Steps to reproduce
Implement ANY method not listed in hdrs.METH_ALL
Your environment
python3.5 aiohttp 0.22.5

I think, that's enough:
class View:
    METHODS = hdrs.METH_ALL
    @asyncio.coroutine
    def __iter__(self):
        if self.request.method not in self.METHODS:
            self._raise_allowed_methods()
        ...

It's fixed by #1037 isn't it?

That's it. Is #1037 released?

Not yet.
Please wait for aiohttp 1.0.
I'm planing to release in a couple weeks.


Standardize tinylicious versions/start scripts

Standardizes all examples to use the same tinylicious startup script and tinylicious version

We should probably normalize on @fluidframework/azure-local-service since that's what we advertise to customers to use.

We should probably normalize on @fluidframework/azure-local-service since that's what we advertise to customers to use.

@ChumpChief, do you know where we advertise to customers to use azure-local-service? I can't really find it on ff.com and it looks like we encourage using either tinylicious or just FRS here.

@ChumpChief, do you know where we advertise to customers to use azure-local-service? I can't really find it on ff.com and it looks like we encourage using either tinylicious or just FRS here.

https://learn.microsoft.com/en-us/azure/azure-fluid-relay/how-tos/local-mode-with-azure-client#running-azure-fluid-relay-service-locally


security slack channel as a env var

Addressing https://github.com/Yelp/detect-secrets/issues/406

I'm closing this PR, given the conversation thread above.
@sfc-gh-nsfard : if you think the proposed solution doesn't address your needs, feel free to reopen.


Tracking Issue for serving an index over HTTP

Summary
RFC: #2789
Implementation: #10470
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#sparse-registry
Issues: https://github.com/rust-lang/cargo/labels/A-sparse-registry
This is a tracking issue for RFC #2789, an experimental extension to serve the index over HTTP instead of via git.
Unresolved issues

[ ] Cache invalidation

Currently 1 minute TTL.  Too long for publish, too short for effective caching.
Minor concern about how long an invalidation takes (Cloudfront says 10 to 100 seconds)
The cost is expected to negligible.
https://github.com/rust-lang/crates.io/issues/4913

[x] Make sparse+ and registry+ more consistent. https://github.com/rust-lang/cargo/pull/10470#discussion_r832484967 (resolved #11209)
[ ] Find a better name (and structure) for index_version https://github.com/rust-lang/cargo/pull/10470#discussion_r832529130
[ ] Handle user urls that start with http. They currently imply registry+. But if sparse+ are more common then it would be good to auto detect. https://github.com/rust-lang/rfcs/pull/2789#issuecomment-737240327
[x] Have a plan for lockfiles.
[x] Implement support in crates.io https://github.com/rust-lang/crates.io/pull/4661
[ ] Check that crates.io is willing to maintain their current system at production levels of traffic.
[x] Teach cargo that crates.io has two equivalent indexes. #10722
[ ] Make sure we are future compatible with a merkle tree design. #10928
[ ] The RFC is intentionally sparse on details, it is almost an eRFC. Do we need another RFC/PR to discuss the details we have chosen?
Does not support fuzzy queries. Is that a blocker? Only used by error messages. This was a misunderstanding, indexes don't support name-based typo suggestions at all. Sparse supports the same case-folding and -/_ fuzzy comparison as git indexes. Sparse fundamentally won't be able to support typo suggestions, but since cargo hasn't handled that in the past, this isn't a regression, and more like a "can't do that in the future" thing.
[ ] Investigate publish issues. 1 minute update is quite slow if publishing multiple packages (and cargo does not yet have retry logic).

Current best way to test
To try it out, add the -Z sparse-registry flag on nightly-2022-06-20 or newer build
of Cargo. For example, to update dependencies:
rustup update nightly
cargo +nightly -Z sparse-registry update

The feature can also be enabled by setting the environment variable
CARGO_UNSTABLE_SPARSE_REGISTRY=true. Setting this variable will have no effect on stable
Cargo, making it easy to opt-in for CI jobs.
If you see any issues please report them in new tickets here in the Cargo repo. The output of Cargo
with the environment variable CARGO_LOG=cargo::sources::registry::http_remote=trace set
will be helpful in debugging.
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Implementation history

#10064

#10470

#10482

#10698

#10725

#10738

#10830

#10831

#10835

#11068

#11069

#11177

#11209

#11215

https://github.com/rust-lang/crates.io/pull/4661

https://github.com/rust-lang/crates.io/pull/4826

Hey, would this mean that when cargo publish exits with 0 the published crate version is actually available (which is not the case now, due to CDN)?

It doesn't address this problem. There is still going to be a delay between cargo publish and the crate being available globally. It would be nice to improve this, but it's more of an issue for server-side crates-io implementation than the registry protocol.

Can the unstable feature be enabled via .cargo/config.toml?

Yes, I think it is:
[unstable]
sparse-registry = true

Hi, has there been any progress on this? Anything I can help with? We would really like to help this get into stable ASAP

Thank you for being interested in this feature! The Cargo team and contributors are currently working hard on this topic, as well as collaborating with crates.io team to build up the infrastructure needed (rust-lang/crates.io#5200, rust-lang/crates.io#5112, rust-lang/crates.io#5066, etc).
One of the things we're happy to collect is feedback for this feature. Personally I'd appreciate any user feedback, especially about user experiences. You can find more relevant issues from label https://github.com/rust-lang/cargo/labels/Z-sparse-registry.

Based on https://github.com/rust-lang/cargo/issues/10722 I was expecting it to be possible to fetch crates using -Zsparse-registry and then use them without it, but this fails:
> CARGO_HOME=$(mktemp -d) sh -c 'cargo fetch -Zsparse-registry && cargo check --locked --offline'
    Updating crates.io index
  Downloaded serde v1.0.145
  Downloaded 1 crate (76.6 KB) in 0.27s
error: no matching package named `serde` found
location searched: registry `crates-io`
required by package `foo v0.1.0 (/tmp/tmp.mos8FpTA4j/foo)`
As a reminder, you're using offline mode (--offline) which can sometimes cause surprising resolution failures, if this error is too confusing you may wish to retry without the offline flag.

I guess the equivalence is only known for some subset of operations? Is this something that should be supported, or must all operations always use the same variant of crates.io.

Using CARGO_UNSTABLE_SPARSE_REGISTRY: true with nightly seems to be broken on GHA:
Updating crates.io index
error: failed to get `clap` as a dependency of package `cargo-binstall v0.15.1 (/home/runner/work/cargo-binstall/cargo-binstall/crates/bin)`

Caused by:
  failed to query replaced source registry `crates-io`

Caused by:
  download of config.json failed

Caused by:
  failed to download from `sparse+[https://index.crates.io/config.json`](https://index.crates.io/config.json%60)

Caused by:
  [1] Unsupported protocol (Protocol "sparse+https" not supported or disabled in libcurl)
Error: Process completed with exit code 101.

Any estimation on when this will be available on stable? Using the sparse registry feature is the only available solution for the following issue in Artifactory https://www.jfrog.com/jira/browse/RTFACT-27248 which is currently a blocker for us.

@jasal82 for corporate proxies, use net.git-fetch-with-cli = true.

@kornelski We're already using that option in the clients. However, for production use we must not use the upstream repositories but Artifactory remote caches instead. Now the problem is that Artifactory cannot properly update its remote caches from the upstream repo when a new previously uncached package is requested. This is definitely a bug in Artifactory but they refuse to fix it and the only answer we got from them is that we should use sparse registries instead which seems to work.

For what it's worth, rust-analyzer also tends to get blamed for this ("but after I closed Code, cargo clean and cargo check and they were fast, it's RA that's slow!").

It's bad even on my gigabit internet at this point if I'm being honest.  But since that's once per install that doesn't seem worth complaining about, or something like that.  I'll be honest though: I dread that progress bar nowadays.

A proposal to stabilize this has been posted at #11224.

Sparse registries are now stabilized and will be available in Rust 1.68, which will be released on 2023-03-09. I'm going to close this tracking issue as I think it has served its purpose. There is still some future work to be continued, such as better support for third-party registries. Those issues can be tracked in the https://github.com/rust-lang/cargo/labels/A-sparse-registry label.

I'm super glad this got merged, but I am having trouble finding the necessary config steps to enable the new behaviour.
Most of the documentation, like in the first post in this issue, still mention it as unstable feature to be enabled with -Z.
Adding [registries.crates-io] protocol = sparse to my cargo.toml doesn't work, i suppose it needs to be added to some cargo config file somewhere else.
Could someone that got it running write some annotations or documentation in some easy to find places?

you're supposed to add the setting to .cargo/config.toml, not Cargo.toml.

thanks for this and those links, but for future outsider readers like me, it looks like this became the default in cargo 1.70 which was released on June 2023 (https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html#sparse-by-default-for-cratesio), so a better approach now IMO is just to rustup update, which will use the fast index on all repos by default without any per-repo config.


[RIP-50]RocketMQ Transaction Message Improvement Of Batch OP Message

Make sure set the target branch to develop
What is the purpose of the change
RocketMQ Transaction Message Improvement Of Batch OP Message
doc:https://github.com/apache/rocketmq/wiki/RIP-50-RocketMQ-Transaction-Message-Improvement
Brief changelog
Batch OP Message
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #5386 (6cb4452) into develop (03ffc45) will increase coverage by 0.06%.
The diff coverage is 62.38%.

@@              Coverage Diff              @@
##             develop    #5386      +/-   ##
=============================================
+ Coverage      43.40%   43.47%   +0.06%
- Complexity      7916     7934      +18
=============================================
  Files           1007     1009       +2
  Lines          70213    70385     +172
  Branches        9282     9322      +40
=============================================
+ Hits           30477    30598     +121
- Misses         35916    35930      +14
- Partials        3820     3857      +37

Impacted Files
Coverage Δ

...er/transaction/queue/TransactionalMessageUtil.java
80.00% <ø> (ø)

.../java/org/apache/rocketmq/common/BrokerConfig.java
28.24% <25.00%> (-0.05%)
:arrow_down:

...saction/queue/TransactionalMessageServiceImpl.java
54.09% <58.90%> (+4.09%)
:arrow_up:

...transaction/queue/TransactionalOpBatchService.java
71.42% <71.42%> (ø)

.../transaction/queue/TransactionalMessageBridge.java
74.71% <72.00%> (-1.86%)
:arrow_down:

...roker/transaction/queue/MessageQueueOpContext.java
100.00% <100.00%> (ø)

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
80.35% <0.00%> (-5.36%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-4.35%)
:arrow_down:

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
73.20% <0.00%> (-2.27%)
:arrow_down:

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add optional :use_page_one_param option for paginate() helper method

Added an optional parameter that can be passed to the paginate() helper that will force the navigation links to use the page=1 parameter instead of not including the page parameter at all. For most implementations, the default behavior works well. But if page 1 is not the default page when the parameter is not present, navigation to page 1 doesn't work. This small edit seems to do the trick. I'm using it like this in my current implementation:
<%= paginate audit_transactions, use_page_one_param: true %>

Code looks good to me.

closing in favor of #44.


Verify features values of contact submodule for grids

We need to test and be sure that the deeprank-core grid data contains correct electrostatic as well as vanderwaals values, like in the original deeprank. Check that the values are the same.

It seems the cutoff (from the old deeprank) isn't applied to the deeprank core contact features. We must incorporate this also.

The grid values are not the same. I presume this has many reasons, but one of them is that we don't use exactly the same set of atoms. Another reason is that we also consider contacts between atoms in the same chain, not just between two chains.

The grid values are not the same. I presume this has many reasons, but one of them is that we don't use exactly the same set of atoms. Another reason is that we also consider contacts between atoms in the same chain, not just between two chains.

Should this be further discussed or there is already a discussion going on (either on Slack or on GitHub)? @cbaakman

Should this be further discussed or there is already a discussion going on (either on Slack or on GitHub)? @cbaakman

It's being discussed in #357


[Feature] Hera 2.0 Miscellaneous

Feature for every issue of the Hera 2.0 milestone that does not quite fit the any of the other, more specific, features.

removed bin command from this


[04e] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):

Error
at c.create in src/vs/base/common/event.ts:900:15
at r.q [as onDidChange] in src/vs/base/common/event.ts:1095:34
at new v in src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsImpl.ts:41:38
at new x in src/vs/editor/common/model/textModel.ts:327:39
at $.J in src/vs/editor/common/services/modelService.ts:317:28
at $.createModel in src/vs/editor/common/services/modelService.ts:452:21
at <anonymous> in src/vs/workbench/api/browser/mainThreadDocumentContentProviders.ts:49:33
at async h.u in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:187:18
at async h.r in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:78:4
at async k.acquire in src/vs/base/common/lifecycle.ts:683:19
at async l.createModelReference in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:238:10
at async s.y in src/vs/workbench/api/browser/mainThreadDocuments.ts:254:15
at async s.$tryOpenDocument in src/vs/workbench/api/browser/mainThreadDocuments.ts:234:18

Go to Errors Site

Not yet sure if this is too many models opened by extensions or something with this particular listener

related to https://github.com/microsoft/vscode/issues/213209
@hediet This is about ILanguageConfigurationService#onDidChange and about having very many models in memory. I believe a simple, low-hanging improvement is have TextModel listen only once. Today, it listen via BracketPairsTextModelPart and TokenizationTextModelPart


Prevent evaluating subsets of code

Is it possible to comment a section of code, to not be evaluated by the Nextflow linter? This is in the same vein as the #noqa comment code to ignore Python PEP8 warnings?

There is no way to suppress things on specific lines

Can you give an example of a warning you'd like to suppress?

Closing in favor of https://github.com/nextflow-io/language-server/issues/75 and https://github.com/nextflow-io/language-server/issues/76


Add 'disapprovals'

Use Scenario
A reviewer is unhappy with the current state of the PR. They express they disapproval with a -1.
New Behavior
The lgtm approver counts all approvals as +1 and all disapprovals as -1, tallies them up, and only if their sum is greater than a configurable threshold is the PR approved.
Requirements
Configurable set of regexpressions for recognized disapprovals.

just wanted to note that we should probably make the disapproval pattern configurable:
approvals = 1
pattern = "(?i)LGTM"
+disapprovals = "(?i):\\-1:"

The option naming is inconsistent at this point (approvals means something completely different than disapprovals). A more consistent approach would be:
approval_threshold = 2
approval_pattern = "(?i)LGTM"
disapproval_pattern = "(?i):\\-1:"

Naming it approval_pattern and disapproval_pattern makes sense for me, but than we need to fallback to the old behavior to avoid breaking installs.

Probably disapproval_threshold would make sense too?

The option naming is inconsistent at this point (approvals means something completely different than disapprovals). A more consistent approach would be:

while I agree, unfortunately this would be a breaking change for projects using hosted lgtm.co. I would probably prefer a non-uniform solution for the initial implementation, and we can address naming consistency / file format changes in a separate pull request.

Probably disapproval_threshold would make sense too? That way people could set it to 0 to disable, or 2 to require 2 -1s before something's blocked, etc

@ljharb I hadn't thought of this, but seems to make sense. If too many people dislike the pull request drone refuses to unlock it. This should probably be an optional feature. In fact, disapprovals in general should probably be opt-in since I could see people not expecting that behavior and opening issues telling me everything is broken :)

Right - disapproval_threshold would default to 0 which means it can't be disapproved.

Also you could totally do approval_threshold || approvals and approval_pattern || pattern for now to make it semver-minor, and in the next semver-major, drop the || fallbacks.

@ljharb we can definitely update the naming conventions and map the old file values. If we adjust the file properties we could also consider nesting. The file (with all options) would then look something like this:
[approval]
threshold = 2
pattern = "(?i)LGTM"
disable_self = true

[disapproval]
enabled = true
threshold = 2
pattern = "(?i):\\-1:"

[maintainers]
path = "MAINTAINERS" # customize file path for teams that place in .github/MAINTAINERS
team = "maintainers" # customize team name container approver list

That sounds like a great idea! Should enabled and disable_self both be on disapproval? I'd think so.
Separately, what happens if the approval threshold is set to 0? I'd assume setting either threshold to 0 would also set that category's "enabled" to false.

It would also be nice if "maintainers" defaulted to, or had the option to be set to, "whoever github has set up with write privileges:

That sounds like a great idea! Should enabled and disable_self both be on disapproval? I'd think so.

yep makes sense. I updated the spec above

Separately, what happens if the approval threshold is set to 0? I'd assume setting either threshold to 0 would also set that category's "enabled" to false.

unfortunately the zero value of an integer is 0 in Go, which means we can't easily differentiate between 0 and unset. So if something is 0 we assume it is just unset

Too bad, that sounds like a serious flaw in Go :-/

Too bad, that sounds like a serious flaw in Go :-/

the workaround in Go is usually to create a custom type (called NullInt for example) that wraps an integer and implements a custom unmarshaler for that type. So it is possible but somewhat annoying to implement https://godoc.org/github.com/BurntSushi/toml#Unmarshaler

It would also be nice if "maintainers" defaulted to

yep, we do this today. When we encounter a configuration option that has a zero value (empty string, 0 integer) we use the defaults which are configurable by environment variable (at the server level)

or had the option to be set to, "whoever github has set up with write privileges:

we don't provide this option today but it certainly sounds like a good idea. I'm thinking something like collaborators = true although I'm not sure that is explicit enough. Open to ideas
[maintainers]
path = "MAINTAINERS"
team = "maintainers"
collaborators = true

hmm, that's not been my experience - when enabling LGTM on a new repo that lacks a config file, nobody's able to approve anything :-/


adopt SSWG security guidelines

add SECURITY.md detailing the security process

@swift-server-bot test this please


Fix: Train loop config validation was run during trainer.predict

What does this PR do?
Fixes:
While predicting, it was verifying the train_loop configuration.
Only necessary for the bug-fix release branch
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@carmocca Sure.
Wondering where should I do the Changelog update here.

Wondering where should I do the Changelog update here.

in Added section :]

Hello @kaushikb11! Thanks for updating this PR.

In the file tests/trainer/test_trainer.py:

Line 1857:121: E501 line too long (123 > 120 characters)
Line 1858:1: E124 closing bracket does not match visual indentation

@Borda Your commit won't work. dataloaders is not defined. Reverting back.

 Reverting back.

it shall be defined in the parameter, right?

what is the difference to #6543?


Unbinding events breaks other code

$(this).unbind('keyup');

This line is evil, it breaks other code relying on that event, such as form validation library Parsley.

This is fixed in just released 1.0.


cannot get basic service up

I started the getting started tutorial, and am blocked as soon as it is time to create a service or container.
I have 3 amazon boxes, all m3.mediums ubuntu 14.04 kernel 3.13.0-57-generic
If any more info is needed let me know.
one runs master server, the other 2 are slaves.
I have the slave connecting to master (I see them on the UI) however creating anything fails to complete.
I tried to get a vanilla mongo service running , and it just spins on networking

i tried just to run mongo itself on the host by clicking +add container, still spins on networking.
on slaves:
rancher/agent-instance:v0.3.1
rancher/agent:v0.7.9

error from agent
W0709 01:15:18.228136 27278 handler.go:524] Error while processing event ("/memory.kmem.tcp.max_usage_in_bytes": 0x200 == IN_DELETE): unable to detect container from watch event on directory "/memory.kmem.tcp.max_usage_in_bytes"
W0709 01:15:18.228150 27278 handler.go:524] Error while processing event ("/cgroup.procs": 0x200 == IN_DELETE): unable to detect container from watch event on directory "/cgroup.procs"
W0709 01:15:18.228164 27278 handler.go:524] Error while processing event ("/cgroup.event_control": 0x200 == IN_DELETE): unable to detect container from watch event on directory "/cgroup.event_control"
W0709 01:15:18.228185 27278 handler.go:524] Error while processing event ("/cgroup.clone_children": 0x200 == IN_DELETE): unable to detect container from watch event on directory "/cgroup.clone_children"
W0709 01:15:18.228205 27278 handler.go:524] Error while processing event ("/tasks": 0x200 == IN_DELETE): unable to detect container from watch event on directory "/tasks"
W0709 01:15:18.228217 27278 handler.go:524] Error while processing event ("/notify_on_release": 0x200 == IN_DELETE): unable to detect container from watch event on directory "/notify_on_release"
W0709 01:15:18.228252 27278 handler.go:524] Error while processing event ("/sys/fs/cgroup/memory/docker/b9f6596eecdfe650c1e86f5a5ce8a95921843bb062d4240d9b6e58447be49884": 0x40000200 == IN_DELETE|IN_ISDIR): inotify_rm_watch: invalid argument
2015-07-09 01:15:18,782 ERROR docker [139921774156848] [delegate.py:126] Can not call [f9984725-8757-4c71-8609-0cdc76465ac3], container is not running
2015-07-09 01:15:18,789 ERROR docker [139921774161424] [delegate.py:126] Can not call [f9984725-8757-4c71-8609-0cdc76465ac3], container is not running
2015-07-09 01:15:18,814 ERROR docker [139921774161424] [delegate.py:126] Can not call [f9984725-8757-4c71-8609-0cdc76465ac3], container is not running
2015-07-09 01:15:18,816 ERROR docker [139921774155568] [delegate.py:126] Can not call [f9984725-8757-4c71-8609-0cdc76465ac3], container is not running
2015-07-09 01:15:18,969 ERROR docker [139921774159824] [delegate.py:126] Can not call [f9984725-8757-4c71-8609-0cdc76465ac3], container is not running
time="2015-07-09T01:15:19Z" level="info" msg="Processing event: &docker.APIEvents{Status:\"start\", ID:\"b9f6596eecdfe650c1e86f5a5ce8a95921843bb062d4240d9b6e58447be49884\", From:\"rancher/agent-instance:v0.3.1\", Time:1436404519}"
time="2015-07-09T01:15:19Z" level="info" msg="Assigning IP [<IP_ADDRESS>/16], ContainerId [b9f6596eecdfe650c1e86f5a5ce8a95921843bb062d4240d9b6e58447be49884], Pid [14386]"
time="2015-07-09T01:15:19Z" level="info" msg="Processing event: &docker.APIEvents{Status:\"start\", ID:\"b9f6596eecdfe650c1e86f5a5ce8a95921843bb062d4240d9b6e58447be49884\", From:\"-simulated-\", Time:0}"
time="2015-07-09T01:15:19Z" level="info" msg="Container locked. Can't run StartHandler. ID: [b9f6596eecdfe650c1e86f5a5ce8a95921843bb062d4240d9b6e58447be49884]"

errors from agent-instance
line 7: Family mismatch at [ out ipsec esp/tunnel/<IP_ADDRESS>-::ffff:<IP_ADDRESS>/require]
parse failed, line 7.
[scripts.sh:165] '[' -e /var/lib/cattle/etc/cattle/setkey ']'
[scripts.sh:168] return 1
[config.sh:1] cleanup
[config.sh:9] EXIT=1
[config.sh:11] '[' -e /var/lib/cattle/download.iFeAmQ1 ']'
[config.sh:12] rm -rf /var/lib/cattle/download.iFeAmQ1
[config.sh:15] return 1
The system is going down NOW!
Sent SIGTERM to all processes
Sent SIGKILL to all processes
Requesting system reboot

I want to try out rancher, but basic functionally is broken out of the box and I can not easily find out why or how to fix it. any help would be appreciated.

I don't think we've seen this problem before @anandkumarpatel.
The errors from the agent that are like
Error while processing event ("/memory.kmem.tcp.max_usage_in_bytes": 0x200 == IN_DELETE):...

appear to be coming from cadvisor and are potentially related linux security. Do you have AppArmor or SELinux running?
Potentially related cadivor issues:
https://github.com/google/cadvisor/issues/616
https://github.com/google/cadvisor/issues/333
Can you post the output of docker info, docker version, and docker ps -a here?
Finally are you able to create a mongo container directly on the host by sshing into the host and doing the equivalent docker run ...?

@anandkumarpatel Could you also provide the specific AMI ID that you used? I'd like to try and set up with the same AMI.

I have already terminated the instances so I can't give you exact details but all I did was start 3 amazon EC2 instances Ubuntu Server 14.04 LTS (PV), SSD Volume Type - ami-d16a8b95
and I know I was running docker  1.7.0
I don't remember if I did apt-get update && apt-get upgrade or not, but after I launched the instances I installed docker via wget -qO- https://get.docker.com/ | sh and then just ran master rancher on one node and slaves on the other two. (for the slave I just copied the line the UI provided for adding manual host)

I used the same ami and steps you outlined, but had no issues.
Did you make sure your security group has the appropriate ports open?
http://docs.rancher.com/rancher/rancher-ui/infrastructure/hosts/amazon/#EC2Ports
When adding the host to Rancher, you'll want to make sure that the IP of the host is correctly shown in the Rancher UI. Sometimes Rancher selects the private IP or docker0 IP instead of the public one, which could cause issues. To fix that you add in the environment variable -e CATTLE_AGENT_IP=<public-ip> to the agent command.

FYI, I'm having the same issue, trying to run server/agent on the same Ubuntu 14.04 box. I'm passing the CATTLE IP through, and everything seems like it's working until I try to launch a service. I'm not having these same issues doing the same thing on an Arch box with an older version of Rancher. Details below. SELinux is not running, and this happens with event he most trivial single-instances services. I have no trouble starting them from Docker directly. I'm happy to provide as much info as possible, but I'm not sure what's most useful.
Arch Box: Linux 4.0.6-1-ARCH
Rancher 	v0.25.0
Cattle 	v0.58.0
User Interface 	v0.29.0
Rancher Compose 	latest
Ubuntu 14.04 Box: Linux 3.13.0-57-generic
Rancher 	v0.28.0
Cattle 	v0.64.0
User Interface 	v0.34.0
Rancher Compose 	beta/latest

@hasJackb What version of Docker are you running? I just tested with Docker 1.7.1 and did not encounter any issues.
Can you provide me some more details on your setup?

Where are you launching Rancher server (cloud, localhost)? Are you using SSL or any other unique scenario to get it up?
Did you configure access control or set up any environments before or after adding hosts?
Did you change the host registration from the default settings (typically the public IP)?
What image are you using the launch a service? Are you setting any advanced options or scheduling rules? Did you only have the issues after trying to start the service? Could you provide me a copy of the rancher-compose and docker-compose files from the stack/project?

Finally, can you provide me the docker logs for the rancher server container?
For the rancher agent, can you follow these directions to provide me the logs for the rancher agent?
# On the host with issues, navigate to the specific folder
$ cd /var/log/rancher/
$ cat agent.log

Sorry, I just asked for a lot of information, but I've been unable to reproduce.

@deniseschannon No problem! I appreciate the quick response.

I'm running Rancher server on a local, Ubuntu 14.04 desktop box. I'm not using SSL or anything other than a stock 'run the container' approach. I'm running both the server and the agent on the same box, and I've tried running it with and without setting the CATTLE_IP environment var on the agent. Same problem either way.
I did not add access control. Since this is in my lab, it has no inbound connections, and I was trying to keep things vanilla since I was going to tear it down after some testing.
I'm running internal DNS, and in the Rancher UI when going to the Add a Host page, I changed the suggested/guessed hostname from the hostname of the machine to the FQDN of the machine on the home network. It is resolvable; I've tested that. Thinking it might somehow be an issue, I also tried using the IP of the machine, with the same issues. As mentioned in 1), I've also tried setting the CATTLE_IP with no effect.
The docker-compose file is trivial (see below). After having issues I decided to just try to deploy MySQL to narrow things down; the problem is still there. I have no rancher-compose file (so a default scaling of 1, no addtl. settings).

My logs are 5k+ lines long; not sure how best to send them to you. I have 3 of them, from 3 different attempts. Let me know what would be easiest.
---
MySQL:
  image: library/mysql
  ports:
    - 3306
  environment:
    MYSQL_ROOT_PASSWORD: secret
    MYSQL_DATABASE: test
  stdin_open: true
  tty: true

For logs, would you be able to do a docker logs -f on the rancher/agent container  and at the same time a docker logs -f on the rancher/server container and try to start the service again? Can you provide just the snippet of logs for when you try to start the service?
Let's start with these logs when you try the service before looking into the more detailed ones.

Yeah, I can do that, but probably not until this weekend or Monday, as I'm now traveling.

@anandkumarpatel @hasJackb If you are still having these same issues, can you please let me know? If not, I will be closing this issue in a couple of days as I have been unable to reproduce.

@deniseschannon Sorry, things have been quite hectic. I'll try to verify today.


When using history.push, listener is called with action POP.

I'm navigating my app using history.push, and elsewhere using history.listen to capture route changes, and perform some actions given the change.
Each time my listener is called, action is POP:
    const unlistenToHistoryChange = this.props.history.listen((location, action) => {
        // location is an object like window.location
        console.log(action, location.pathname, location.state)
    });

I'm thinking I probably am missing the concept, as I was viewing history as a simple stack container.  Is this the case, or does documentation exist for this?
Thanks!

Are you using histor v3 or v4? If you are using v3 look at https://github.com/ReactTraining/history/issues/427

I'm using v4.6.3 and I have same problem.

Same here, and the multi rendering is a real issue

Can you please provide a failing test case or some other way to reproduce your issue? We have a test for this that is currently passing in all the environments we support.

Closing this due to inactivity. We've got tests that specifically assert the correct behavior, so I'm skeptical this is our problem.


Unauthenticated user can see tables list

Describe the bug
Starting shell with a bad username/password combination, the user can see the tables list using the tables command and only recieves an error when trying to scan
Versions (OS, Maven, Java, and others, as appropriate):

2.1
CentOs 7.5

To Reproduce
Steps to reproduce the behavior (or a link to an example repository that reproduces the problem):

Start shell with bad use/pass combination eg accumulo shell -u notAUser -p whoCaresItsFake
run tables command
See list of tables

Expected behavior
Either the user should be rejected when starting the shell, or when running the tables command before displaying output.

For 1.10.x, the Shell returns BAD_CREDENTIALS when a bad username/password is supplied, then the Shell exits. It seems like the behavior here has changed. Maybe it changed in 2.0 and it's not a bug?

Carrying BAD_CREDENTIALS behavior forward seems the safest option unless someone can provide an explicit, legitimate reason for relaxing it.

The information in ZooKeeper where the table name is stored is world readable and should not be considered sensitive.

Could we lock that down easily?

For 1.10.x, the Shell returns BAD_CREDENTIALS when a bad username/password is supplied, then the Shell exits. It seems like the behavior here has changed. Maybe it changed in 2.0 and it's not a bug?

The change is that we no longer authenticate an AccumuloClient with the server, until you try to do some action with that client. Some client operations only need to talk to ZK, so no authentication is needed to do those actions in our public API. So, no error in the shell when the shell uses our public API to do that. To change that, we would need to replace some client side implementations with RPC calls to servers to do those actions for the client.

The change is that we no longer authenticate an AccumuloClient with the server, until you try to do some action with that client (Connector always authenticated every time you created it, and that was intentionally changed). Some client operations only need to talk to ZK, so no authentication is needed to do those actions in our public API. So, no error in the shell when the shell uses our public API to do that. To change that, we would need to replace some client side implementations with RPC calls to servers to do those actions for the client.

So it sounds like you are saying that the behavior changed at some point between 1.10 and 2.1 (maybe 2.0), and that this is the expected behavior.

So it sounds like you are saying that the behavior changed at some point between 1.10 and 2.1 (maybe 2.0), and that this is the expected behavior.

It changed in 2.0. AccumuloClient intentionally never implemented the "fail fast" authentication check that ConnectorImpl did (and does still in 2.1). So, when the shell switched to use AccumuloClient instead of Connector, it stopped causing the error. The error wasn't with the retrieval of table info. It was with the initial construction of the shell. So, if there's a problem at all here, it's not with the shell... it's with the AccumuloClient API that doesn't require authentication for ZK read-only operations that work on the client side. AccumuloClient is just treating it the same way zkCli.sh would.
Put another way: it's what Ed said above: "The information in ZooKeeper where the table name is stored is world readable". This has always been the case. The user's observation of the change in shell behavior is only highlighting the pre-existing choice to not make table information private in ZK.
So no, this isn't exactly a bug. But, it does raise the question that is implied in the second part of Ed's comment. He said that this "should not be considered sensitive". If there is anything to be done here, it would be because we are now asking "should it be considered sensitive?" and have decided the answer is "yes". If that's the case, then we can change the API's implementation to get the information via an RPC call and we can lock down the ZK view so it can't be accessed publicly with zkCli.sh either. If, on the other hand, we answer "no", then there's probably nothing to do here, other than to make it clear that table (and namespace) names and count are not sensitive in the documentation.

Also, although AccumuloClient does not authenticate when it is constructed. We could make the shell do that. That's a separate issue than the question about whether table names and quantity are sensitive in ZK.

With the 2.0 prop change, the properties removed world:read permissions and require authentication to access.  Most other things  in ZooKeeper are world:read, but are restricted from making changes.

The client should absolutely be chnaged to authenticate when contstructed so that the user gets denied without getting to the prompt.
Can you site one example where that is not the case that would support leaving it as is? Should I be able to type a non existent username into the linux login prompt and be able to read any world readable files?

The client should absolutely be chnaged to authenticate when contstructed so that the user gets denied without getting to the prompt.

That was a design mistake initially made in Connector that caused performance issues. We ended up working around it for the system user, but we changed that when implementing AccumuloClient, to avoid that problem. Having that creates weird concurrency issues also, like the client can be constructed and authenticates, but then the client stops working because the password was changed by another client instance. That can happen now, but adding the fast failure will give false confidence that the initial construction is doing something more than it is. That would also prevent valid use cases, like being able to construct a client in a client application that is scheduled to perform a task in the future... such a client should be able to be constructed while servers are offline, as long as the task they execute doesn't occur until the servers are online again.
So, I don't think we should change this behavior of AccumuloClient. The current behavior is more flexible and prevents performance issues that were previously seen.
However, we can change the behavior in the shell, since the shell is intended to be an interactive client application, and it is strange for the shell to not authenticate right away.
This is a separate issue from the listing of tables, though. Adding in authentication to the shell initialization (or even the AccumuloClient) would not prevent an unauthenticated user from viewing the tables. They could still bypass Accumulo client code to use ZK client code to do that.

Can you site one example where that is not the case that would support leaving it as is? Should I be able to type a non existent username into the linux login prompt and be able to read any world readable files?

I don't think that's the right analogy. This is more like viewing the contents of a mounted drive. The fact that you're logging in is incidental to the viewer environment. You could mount a drive and view its contents using a password-protected computer, or a computer without a password. The issue isn't with the authentication in the viewer. It's with the exposure of the data in the drive. If you use zkCli.sh, you don't need to log in to Accumulo at all, and you can get all the same info.
As stated above, the performance issues, and the ability to pre-construct a client are the use cases for not authenticating AccumuloClient immediately. But that's a separate issue from the fact that ZK is world readable in the first place, or that the AccumuloClient implementation talks directly to ZK instead of going through an authenticated RPC endpoint to talk to an Accumulo service to get the info.
Steps we can take:

Add authentication to shell startup and any time the shell user switches to another user - can be done for 2.1.1
Consider locking down ZK table info and having AccumuloClient get the info via an authenticated RPC (can also look at other things in ZK that are world readable) - probably too disruptive of a design change for 2.1.x.

Option 1. That's all I was asking for in the first place and this entire discussion could have been avoided. I just want the shell to have the same behavior it had in 1.10, and the expected behavior when passing a bogus user/pass combination to any interface.

What needs to be online to validate user identity?  There may be distinction between authenticating as a user versus being able to authenticate with ZooKeeper.  If the shell was modified to allow ZooKeeper operations without having a running cluster - such as set properties, ZooKeeper authentication is required - but user authentication may not be available.
Using unix ACLs to protect the configuration should stop a shell user from creating and authenticating as Accumulo to ZooKeeper.
While the original request seems simple, this discussion is showing that the issue should be evaluated deeper than just mimicking the previous behavior and then assuming that is offering any degree of protection.  Ask a Jeep owner with a canvas top if they lock their doors.

Option 1. That's all I was asking for in the first place and this entire discussion could have been avoided. I just want the shell to have the same behavior it had in 1.10, and the expected behavior when passing a bogus user/pass combination to any interface.

The change in behavior you observed ended up highlighting the issue with the stuff in ZK being exposed, which might be worth revisiting. So, it's probably best that we did have the full conversation :smiley_cat:
I created #3433 to do item 1 for 2.1.1, and #3434 to explore item 2 for the future.


Feature/basic-chat-app-with-flagging

This PR includes a basic chatting app that stores feedback in a dataframe.
Next step: push dataframe to dataset repo

@burtenshaw https://huggingface.co/docs/huggingface_hub/main/en/guides/upload#scheduled-uploads

@burtenshaw https://huggingface.co/docs/huggingface_hub/main/en/guides/upload#scheduled-uploads

Nice. Are you suggesting that I use it for the upload step?

@burtenshaw It might help for inspiration. I am not sure how I implemented the flagging myself, but I believe it logs continuously (every interaction) instead of periodically as the implementation above but I guess it could work either way.

@burtenshaw It might help for inspiration. I am not sure how I implemented the flagging myself, but I believe it logs continuously (every interaction) instead of periodically as the implementation above but I guess it could work either way.

I'll add it to give us options. But we're still early so need to decide.

@davidberenstein1957 I've added persistence, so now I think we should move on to inference. The only outstanding issue are unique identifiers for user and session, this will make it easier for us to deal with the data downstream.

@burtenshaw I will have a look later today.


Adding parameter enableMultipleWriteLocations in Cosmos DB

To support multi-master, we are adding the parameter enableMultipleWriteLocations to the DatabaseAccountCreateUpdateParameters property so that users can enable this feature when creating an account.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node

Automation for azure-sdk-for-go

@shurd  please fix Model Validator error:
>>>>> Files changed in this PR are as follows:
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/examples/CosmosDBDatabaseAccountCreateMulti.json
>>>> Number of swaggers found in this PR: 1
>>>>> Files deleted in this PR are as follows:
[]
Validating "examples" and "x-ms-examples" in  specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json:
 error :
operationId: DatabaseAccounts_OfflineRegion
scenario: CosmosDBDatabaseAccountOfflineRegion
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "DatabaseAccounts_OfflineRegion", parameter
    regionParameterForOffline is required in the swagger spec but is not present
    in the provided example parameter values.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''
 error :
operationId: DatabaseAccounts_OnlineRegion
scenario: CosmosDBDatabaseAccountOnlineRegion
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "DatabaseAccounts_OnlineRegion", parameter
    regionParameterForOnline is required in the swagger spec but is not present
    in the provided example parameter values.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''


Update macOS build image and root folder for build

PR Summary
Update the build vmImage for the release build. Since catalina onwards, we cannot create folders at root. change the build to create folder under $HOME instead
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

@adityapatwardhan  Does this also have to be changed in 'mac-package-build.yml'?

@PaulHigin - good catch.. pushed.

Release is blocked on this. Merging.


rofi completion

Add completion support for rofi. You would call rofi -dmenu with gopass completion rofi similarly to calling dmenu with gopass completion dmenu.

If you're a little experienced with Go I invite you to basically copy what I've done for dmenu and create rofi support. Let me know if you're up to the challenge. :wink:

I have done a PR for rofi: #76

Would it be better to approach this from the perspective of allowing people to script themselves? Have an option to list which prints list of secrets which can be piped into any script the user chooses.
No point trying to wrap up every possibility into gopass. I'd consider the xdotool support to be another example of something that could be moved into a shell script simply by the user.


Update insar_tops and insar_tops_burst to grab orbit data from CDSE

Trufflehog is failing on the commit hash in a github link in the comments, and can be safely ignored.