Remove all request de-duping logic

Details
This is related to #fireroom-2024-04-10-unable-to-delete-comments. I've been working on a thorough fix for that in https://github.com/Expensify/App/pull/40059, but it's a risky PR to CP to staging then ship to prod. After all, CPing a similar PR is what caused the fire in the first place.
This PR is essentially just a revert of all request de-duping logic, which we can safely CP to resolve the fire. It will cause the following minor issues:

this bug will be re-introduced
If you add a comment then delete it offline, others might see that comment "flash" for a moment
If you open the same report offline multiple times, then come back online, it will take longer for your app to reload the data because we'll run OpenReport a few times for the same report when flushing the queue
Same deal with ReconnectApp - it may run redundantly several times

All of these will be fixed (soon) when I follow-up with https://github.com/Expensify/App/pull/40059 and have it go through a full suite of regression tests on staging. I anticipate these problems will only be re-introduced for 1 or 2 releases.
Fixed Issues
$ https://github.com/Expensify/App/issues/39432#issuecomment-2033695929
Tests / Offline Tests / QA Steps

Go offline
Add a comment
Delete it
Come back online
Verify that the comment deletes as expected
Add a comment
Delete it
Verify that the comment deletes as expected

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/47436092/8e1e1165-1f01-4455-b7a4-8238eb07166d
https://github.com/Expensify/App/assets/47436092/e612b67d-d7d7-495e-aa4a-fe4b7e074fcf

MacOS: Desktop

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Azaladshu Free bacame independant from Federation

Need to handle one off changes in factions/systems/stations. See https://discord.com/channels/164411426939600896/164411426939600896/859470964214988858

How do you want to handle this? Via an admin panel, or an edit button that any registered user can edit?

Via a manual database change 😩

I am anyway not planning to do this anymore. I have planned to rewrite the database schema and reimport all the data so as to handle these situations better.


[Feature]: More flexible peer deps version ranges

Context
Today the peer dependencies we are setting for the packages are using ~ so we allow only patches to be compatible.
This is raising a lot of warnings for yarn package manager (errors for npm) if a peer dep is not matching the minor version.
Proposal
-Use ^ instead of ~  (since there are no breaking changes between minors)
-Impose patch version 0 (example: ^2.4.0 instead of ^2.4.9)
-Update of minor versions in the peer dependencies by hand when needed

I would disagree with the 2 last points which are not aligned with the output of the Otter Discussion:

-Impose patch version 0 (example: ^2.4.0 instead of ^2.4.9)

I agree that patch version to 0 should be the default value when updating to new minor/major but it should not be "imposed".
In case of mandatory bugfix to propagate, the patch version may need to be upgraded (potentially manually).
This point has been discussed and agreed in Otter Discussion.

-Update of minor versions in the peer dependencies by hand when needed

Nop, the upgrade of minor version should be part of the automatic upgrade process to align the devDependencies (targeting the latest major/minor version) used in our development and , more important, our tests with the peerDependencies.
This point has already been discussed and agreed in Otter Discussions.


Add .spec.certSecretRef to Bucket API

Fixes #973

I just finished testing this with a test bucket from minio/minio configured with a self-signed certificate, and 👍 it worked
Here are the Helm values I used, for reference, in case anyone wants to replicate the test:
mode: standalone
replicas: 1
resources:
  requests:
    memory: 512Mi
rootPassword: rootpass123
rootUser: rootuser
tls:
  certSecret: bucket-secret
  enabled: true
  privateKey: tls.key
  publicCrt: tls.crt

and it took some time to figure out exactly what the other configuration artifacts should look like, writing them out here for completeness:
---
apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: Bucket
metadata:
  name: test-bucket
  namespace: test-bucket
spec:
  bucketName: test-bucket
  endpoint: minio.test-bucket.svc.cluster.local:9000
  interval: 1m0s
  provider: generic
  certSecretRef:
    name: bucket-secret
  secretRef:
    name: bucket-client-credentials

apiVersion: v1
kind: Secret
metadata:
  name: bucket-client-credentials
  namespace: test-bucket
type: Opaque
stringData:
  accesskey: rootuser
  secretkey: rootpass123

apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: my-bucket-cert
  namespace: test-bucket
spec:
  dnsNames:
    - minio.test-bucket.svc.cluster.local
  isCA: true
  commonName: my-bucket-cert
  secretName: bucket-secret
  privateKey:
    algorithm: ECDSA
    size: 256
  issuerRef:
    name: ca-issuer
    kind: Issuer
    group: cert-manager.io

apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: ca-issuer
  namespace: test-bucket
spec:
  selfSigned: {}

You can also create a real access key and secret, but in the tests we also use the root user/pass so it's fine, works as well.

Thanks @kingdonb for testing this on your cluster 🏅


chore(CI): reenable test:projects:cra-ts

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

just note aside - could you, please, suggest if you've had a chance to research the cause (source) of these TS warnings:

I mean, I see that those are produced by rollup's env, but just to understand which problem this is.

This problem caused by TS helpers in the transpiled code, more details are there: https://github.com/rollup/rollup/issues/794#issuecomment-262395554. I am not sure that we need to silence this warning, especially if we want to migrate to Babel.


ANSI coloring is broken after first answer

I'm using windows, powershell, php 7.2, latest master of this repo
First question is displayed with proper colored text, but after first letter shell codes are shown instead of coloring

IMHO, this can be fixed if we upgrade the Symfony version of the Console Component.
I'll try to find time to do it 👍

Probably fixed in v2 => closed !


[mac]TNB_Ver_31 In Notification sender account displaying number instead of showing name

Bug Description
I am Transfer coins from mac to windows and go to the notification icon and click on senders name account in highlighted
showing name of sender instead of showing account number even the in my friends account he's account exist
Steps to Reproduce
Steps to reproduce the behavior:

Launch TNB 31 application on mac
Add friend account
click on send coins button
select account number "TO"
Enter Coins
Enter Send Buttons
Now go to the receiver account
click on notification bell icon top right side corner
click on sender name (e.g. in my case [mac]Original_account)

Expected behavior
In middle window showing account number instead of showing name of sender
Actual behavior
In middle window showing account number
Screenshots/Recordings
https://prnt.sc/vu1eti
OS and Browser

OS: [Windows 10,mac]

Resolved with the latest changes

Resolved with the latest changes


ACS5YrSubjectTable: S2701 Artifacts

Includes S2701_spec.json and tests for the S2701 (Health Insurance Coverage) Subject Table import.

Done.
Using inplace (non GitLFS) test files.


update log & fix ctx exceeded & add ctx timeout in getting uuid

update log
fix ctx exceeded
add ctx timeout in getting uuid
update timeout of job to 40s because parent ctx timeout is 60s

Codecov Report

Merging #428 (3c0675a) into master (251b014) will decrease coverage by 0.02%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
- Coverage   46.87%   46.85%   -0.03%
==========================================
  Files          27       27
  Lines        2816     2828      +12
==========================================
+ Hits         1320     1325       +5
- Misses       1398     1404       +6
- Partials       98       99       +1

Impacted Files
Coverage Δ

pkg/juicefs/mount/pod_mount.go
39.57% <20.00%> (+0.06%)
:arrow_up:

pkg/juicefs/juicefs.go
58.37% <53.84%> (-0.48%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[BUG]Error compiling

Describe the bug
Error compiling.
godot 3.3.2
Additional context

@bubutime Hey! Please try to do with this video tutorial: https://www.youtube.com/watch?v=5J_RP2sCf7Y

im actually using the example project, i just change the necessary files to 3.3.2 from your download page.  install android bundle, etc. and yeah that shows the error.
anyway, ill try from scratch

Hey @bubutime any news?

Hey @bubutime any news?

eyy, so i checked it using a different computer and using my main project. so what i did was, remove other plugins first then reinstall android bundles then compile and it works.

Great news, thank you for using our Plugin!

Great news, thank you for using our Plugin!

yeah, but apparently its still not working on another computer. idk, either android sdk or java issue

I guess it is, I export the game in three different computers that I have and is normally. :(


fix(modal): fix allowing promises to be resolved

Wrap values otherwise and push to resolve handler

This fixes #4309

:+1:


AMBARI-23926. Phantom null request shows up on the bg ops for Stop All SCH.

What changes were proposed in this pull request?
Now server sends own host name in STOMP api request/task updates for ambari server action.
How was this patch tested?
Manual testing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2409/
Test PASSed.


Share postgresql docker container for tests

A new container is started for each test, it shouldbe shared

Done


Fuzz spike

We should fuzz spike to increase our confidence that it can handle malformed packets.

This tool might help: https://www.wireshark.org/docs/man-pages/randpkt.html


Backend: Creating simple server

"Listen to port 8080"

git fetch origin
git checkout 3-backend-creating-simple-server

Completed


Alphabetize fields in DeliverableSubmissionModel

#2544  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite


Overflow hidden bug

https://github.com/w3c/csswg-drafts/issues/865

I think this should be rephrased: "One of the all of nearest element ancestor"...not clear to me what that means.

How about this?
"Any ancestor between the sticky element and it's user scrollable container with overflow computed as anything but visible/clip will effectively prevent sticking behavior."
And this would consolidate this third description with the second about safari and auto overflow.

Is that actually a browser bug or just spec-defined behavior? If the latter it should be listed under Notes instead. If it's the former it should mention which browsers are affected.

It's the latter. This clarification should be listed under Notes.

Has been added under Notes, so closing this PR.

@Fyrd I see you added my suggestion in the non-numbered notes, but I'd also suggest removing the second bug from the bugs list.

A parent with overflow set to auto will prevent position: sticky from working in Safari
https://github.com/Fyrd/caniuse/blob/master/features-json/css-sticky.json#L37

First, it's not a bug as far as the spec is concerned. And two, the addition of the note encompasses what that "bug" was trying to communicate.


feat: implement ECDH

Description
ECDH Implementation with NoirJS for writing tests.
See ecdh.tests.js in the package.

Here is a detailed description for a GitHub Pull Request (PR) that covers the provided code:

Summary
This PR introduces a set of functions and utilities for elliptic curve cryptography using the Baby JubJub curve. It includes functionality to convert byte arrays to field elements, generate public keys from private keys, and compute shared keys for the Elliptic Curve Diffie-Hellman (ECDH) protocol. The code also provides a main function for generating ECDH shared keys and includes initial placeholders for testing.
Details

Function: field_from_bytes

Description: Converts a fixed-size byte array to a field element.
Arguments:

bytes: A fixed-size array of 32 bytes that represents the data to be converted.
big_endian: A boolean flag indicating if the byte array is in big-endian format. If true, the conversion uses big-endian ordering; otherwise, it uses little-endian ordering.

Returns: A Field element that represents the converted byte array.
Implementation:

Initializes the as_field and offset variables.
Iterates over the byte array, calculating the field element based on the byte values and their respective offsets.
Supports both big-endian and little-endian byte orders.

Function: generate_public_key

Description: Generates a public key from a private key using the Baby JubJub curve.
Arguments:

private_key: A Field element representing the private key.
base_point: A Point on the Baby JubJub curve used as the base point for the generation of the public key.

Returns: A Point on the Baby JubJub curve representing the public key.
Implementation:

Creates an instance of the Baby JubJub curve with predefined parameters.
Computes the public key by performing scalar multiplication of the private key with the base point.

Function: main

Description: Computes ECDH shared keys based on two private keys and validates their equality.
Arguments:

private_key1 and private_key2: Arrays of 32 bytes representing the private keys.

Implementation:

Defines a base point on the Baby JubJub curve.
Converts the private keys from byte arrays to Field elements.
Generates public keys for each private key.
Computes shared keys using the ECDH protocol.
Asserts that the computed shared keys are equal, validating the correctness of the ECDH operation.

Tests

Description: Placeholder functions for testing.
Included Tests:

field_from_bytes_correct: Tests the field_from_bytes function to ensure correct conversion of a byte array to a field element.

Note: The test functions are currently commented out and need to be implemented with actual test cases and expected values.

Changes Made

Added utility functions for converting byte arrays to field elements and generating public keys.
Implemented the main function for computing ECDH shared keys and validating their equality.
Included placeholder test functions for field_from_bytes and generate_public_key functions.

To Do

Implement the actual test cases for the placeholder test functions.
Validate the correctness of the generate_public_key function with real inputs.
Ensure all functions and tests are correctly integrated and working as expected.

@sripwoud Solved requested.
@cedoor Will implemented the new curves you requested soon *
I would appreciate it if you could comment on the integration and the unit tests. Will add those as soon as * is completed.

@YashBit

@cedoor Will implemented the new curves you requested soon *

👍🏽

I would appreciate it if you could comment on the integration and the unit tests. Will add those as soon as * is completed.

Re integration tests. I think there're not actual tests actually. You're just generating a proof without verifying it.
Looks like there's a function to verify proofs in the Noir tools: https://github.com/noir-lang/noir/blob/master/tooling/noir_js_backend_barretenberg/src/backend.ts#L127

Just wanted to know your opinion on the naming, other than that it looks good to go

@signorecello I think what I have done makes sense
We have a main.nr file, which is required for the nargo compile, and we have a separate lib.nr file which contains all the functions (which is in fact imported by main.nr)
Without a main.nr file + a pub fn main, there will no circuit and no integrated tests.

Let's merge this PR. Naming and other issues can be part of another PR in case.


az deployment * create --confirm-with-what-if asks for confirmation when nothing is changed

Describe the bug
When using any az deployment * create command with --confirm-with-what-if, if there are no changes (excluded using --what-if-exclude-change-types NoChange Ignore), Azure CLI still asks to confirm the execution of the deployment.
To Reproduce
Deploy any template with az deployment * create --confirm-with-what-if --what-if-exclude-change-types NoChange Ignore, then deploy it again without changing anything.
Expected behavior
One of two things:

Either the deployment does not ask for confirmation when "Resource changes: no change." is the what-if output
A parameter is made available that if there is no change as the what-if output, then do not ask for confirmation and simply proceed

Environment summary
Azure CLI v2.24.2 running in CentOS7 & Ubuntu 20.04LTS via WSL2, and in CentOS7 via Docker container on WSL2
OS: Windows 10 Enterprise 20H2
Additional context
This is mostly a problem because we have a lot of templates, and a good chunk of them are multistage templates, i.e.: We will run az deployment * create with a parameter -p stage=X via a custom Bash script that will trigger different sections of our templates based on the stage number.
This is needed because let's say Stage 2 might create Resource A, which we then need to get some information in Bash to do some manipulations outside of the ARM template OR to pass as additional parameters for later stages (i.e.: Deploy a storage account, use Azure CLI to fetch the Connection String, sanitise it, and pass it as a deployment parameter for a later stage). If those manipulations are not done, then Stage 3 resources will fail or not work properly.
We have up to 4 stages in our templates currently, and sometimes only one of the stages might have changes. Needing to confirm that nothing is being changed every single time is not really ideal in terms of user experience for the rest of our team.
And because of the above requirements, switching to using az deployment * what-if is not an option, because resources that would've been created by Stage X won't be available for a later stage, thus failing it.

ARM

@shenglol Could you please take a look at this issue~

My concern is that there are people who would expect it to ask for confirmation as a guard regardless whether there are changes or not. Adding a new parameter to allow a deployment to process if there's no change seems reasonable, but I'd like to hear @alex-frankel 's thoughts on this before committing to implementing it.

people who would expect it to ask for confirmation as a guard regardless whether there are changes or not

+1

A parameter is made available that if there is no change as the what-if output, then do not ask for confirmation and simply proceed

I can see us potentially doing this one. At that point it would be an opt-in capability:
az deployment * create -f main.bicep -c --proceed-if-no-changes

@alex-frankel , @shenglol , adding that kind of --proceed-if-no-changes opt-in capability would be perfect for our needs, and most likely the needs of others as well.

Sounds good. I've added a task to our backlog to track this and will be working on it later.

@shenglol - should we try to do this one at the same time? https://github.com/Azure/bicep/issues/2923#issuecomment-855191455

Yeah we should.


Format compatibility of iterators

Currently, SerialIterator and MultiprocessIterator serialize self._order in different names.
So we cannot change the type of iterator during training.
dataset = [1, 2, 3]

iterator = chainer.iterators.SerialIterator(dataset, 2)
chainer.serializers.save_npz('tmp', iterator)

iterator = chainer.iterators.MultiprocessIterator(dataset, 2)
chainer.serializers.load_npz('tmp', iterator) #  KeyError: 'order is not a file in the archive'

I think this behavior is inconvenient.
I unified the keys of self._order to order.
For backward compatibility, iterators try to load _order if they cannot find order.

I will add tests based on #2346.

I merged #2346. So, please go ahead with this PR.

Thank you for merging #2346. I added tests for backward compatibility and inter-iterator compatibility.

Thank you for reviewing. I fixed DummyDeserializer.

Thank you!


Feature: Implement contains/includes text function

API
Python
Description
There are already starts_with and ends_with text functions (https://docs.kuzudb.com/cypher/expressions/text-functions/).
What about a function contains/includes to also search for terms in-between? I think this is easier than doing full-regex searching for simple words. For case-insensitive search it might be used together with lower() and upper().
Related:

https://duckdb.org/docs/sql/functions/char#containsstring-search_string
https://github.com/kuzudb/kuzu/issues/1506

This should be done in #3531


[regression-test](dynamic table) Remove related case since it's deprecated

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Remove redundant dependent properties in test.properties files under external category

Remove all redundant properties declaration in all test.properties files under external category.
For example file https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties
we'd like to remove the following 4 lines as those are redundant dependent properties.
https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties#L8
https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties#L9
https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties#L12
https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties#L14

I would like to work on this


Update index.md

Edited for grammatical errors and some awkward sentences/phrases. Hope this is helpful.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Created grammatical edits.

You ignored a list of requirements including "My pull request has a descriptive title (not a vague title like Update index.md)". Descriptive titles and good explanations of changes are necessary for a well maintained codebase. Free Code Camp is choosing to relax some of its requirements to help people reach their Hacktoberfest goals, but this PR would normally be rejected. In the future, please help repository maintainers by providing useful titles and do not ignore contributing guidelines or requirements.

I’m so sorry. I thought the description was for the paragraph section and the title was supposed to remain “as is”. I totally see my error now. I hope this didn’t cause too much inconvenience.
Sent from my iPhone
On Oct 23, 2018, at 3:59 PM, Ariel <notifications<EMAIL_ADDRESS>wrote:
You ignored a list of requirements including "My pull request has a descriptive title (not a vague title like Update index.md)". Descriptive titles and good explanations of changes are necessary for a well maintained codebase. Free Code Camp is choosing to relax some of its requirements to help people reach their Hacktoberfest goals, but this PR would normally be rejected. In the future, please help repository maintainers by providing useful titles and do not ignore contributing guidelines or requirements.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/freeCodeCamp/freeCodeCamp/pull/27230#issuecomment-432395297, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AO5MbaGZx94-H-uGi4C4QtxQej10u5Arks5un3ULgaJpZM4X2Tu0.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Congrats @redsonjacode on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Import not working inside def (function)

I used the debug2production.py script as a base. When I try to use a function from an import inside a function that I created, it says the name of the import (time, in my example) is not defined (line 40). Everything works fine when I don't use functions. Also, the script only runs directly if __name__ == 'pypreprocessor'. If only __name__ =='__main__' is used, it only runs on the output file without preprocessing.
import sys
import time
from pypreprocessor import pypreprocessor

outputFile = 'output_file.py'
start_time = time.time()

#exclude
# run the script in 'debug' mode
if 'debug' in sys.argv:
    pypreprocessor.defines.append('debug')

# run the script in 'production' mode
if 'production' in sys.argv:
    pypreprocessor.defines.append('production')
    pypreprocessor.output = outputFile
    pypreprocessor.removeMeta = True

# run the script in 'postprocessed' mode
if 'postprocessed' in sys.argv:
    pypreprocessor.defines.append('postprocessed')
    pypreprocessor.output = outputFile

pypreprocessor.parse()
#endexclude

def do_stuff():
    global outputFile, start_time
#ifdef debug
    print('This script is running in \'debug\' mode')
#else
#ifdef production
    print('This script is running in \'production\' mode')
    print('To see the output open ' + outputFile)
#else
#ifdef postprocessed
    print('This script is running in \'postprocessed\' mode')
    print('To see the output open ' + outputFile)
#endifall
    print(time.time()-start_time)

if __name__ == '__main__' or __name__ == 'pypreprocessor':
    do_stuff()

IIRC, the 'magic' behind inline preprocessing is that parse() has to hijack import so it doesn't import anything that would otherwise be conditionally excluded. Then it generates a new source file in memory respecting the preprocessor statements and dynamically imports it at the end.
You have 2 options here:

define the function before parse() is called
don't use inline preprocessing at all, instead use the input/output params to preprocess an external file

Generally, I'd recommend the second option. It adds an extra step but there's no magic involved.

It may seem counter-intuitive but try placing the imports after the call to parse()
The magic behind this lib is that it hijacks the imp module, preprocesses the source in memory, they imports the postprocessed source directly from memory. Producing a bytecode file that reflects the postprocessed source.
That means any imports that happen prior to the call to parse() are invisible to the postprocessed source.
If you don't like the 'magic' behavior, you could always opt to define the preprocessing step as it's own script and apply it to an external file. There should be no side-effects to this approach.

Calling import time and start_time = time.time() after parse() still gives the same error: "name 'time' is not defined" at print(time.time()-start_time), but start_time = time.time() that is outside the def is working just as before. Using the postprocessed file is working fine when running the source file only for preprocessing, but I would like to run everything with a single file. I also don't understand how to  use a script to preprocess an external file. A working example in the repository would help.

I managed to run an external code with import, but still have the same issue. I will keep editing the source file and executing the output postprocessed


"Or"/disjunction query combinator

Currently Option allows you to "try" to fetch a fetchable thing; we just came across an issue where we'd like to be able to match on queries which have one fetchable subset or another fetchable subset. I think something like an Or<Q, P> combinator that implements Fetch would be feasible?

Semantically speaking, it'd be like (Option<Q>, Option<P>), except skipping cases where both are None, right? I think that should be pretty straightforward. Probably yielding an enum with cases for either or both.

Of course, you could reduce your query to disjunctive normal form and use separate loops for each conjunction, but it's easy to imagine that might be significantly less ergonomic.

Of course, you could reduce your query to disjunctive normal form and use separate loops for each conjunction, but it's easy to imagine that might be significantly less ergonomic.

Yeah, that's what we're currently doing. In our case we actually know that it will be an exclusive or w/ no possible "both" case, so I was imagining an Either<Q, P> kind of combinator, tbh. Though I don't know if an XOR style of combinator would want to skip "both" cases...

How's #192 look?
Exclusive OR feels kind of weird; logically it should skip both cases. An inclusive variant that picks an arbitrary case would be lossy, as well. Including both leaves the decision to ignore that case to the user, and I think with the right helpers it'll be plenty ergonomic.

Looks great! I mean, we know the both case won't happen anyways, so we can just mark it unreachable and honestly that's probably the best thing to do there, since if something does have both components something is very wrong. That was fast!

Great, thanks for the feedback! Let me know if you'd like a formal release sooner rather than later.


Fix bug #486

Thanks for putting this example test together. #542 fixes the bug shown here (I opted for a more fine-grained test that used the native selection API to select the exact nodes that Chrome and Safari would select on a triple-click).


Added custom port number

@mamathaRamaprasad Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

by mistake


Add Error Prop to Fieldset

Summary
Resolves #1480
This adds the error prop back to the fieldset
One thing I'm debating is if we want to use an isInvalid prop on this fieldset as well. Let me know what you guys think.

+1 to adding isInvalid. This would make field set consistent with field then.

Talked with UX and found out that adding error and isInvalid props to the fieldset component is not desired. Instead, we'll be building a new component to handle rendering checkbox or radio buttons inside of a fieldset along with displaying associated help text / error text with the field. @JakeLaCombe is working on a tech design for the new component.


semantic: referenced in export type {} but ReferenceFlag is a value

Please see: https://oxc-project.github.io/oxc/playground/?code=3YCAAICjgICAgICAgIC6nsrEgtebpnCnOkfmyvXpODDg8TpqyEqtH7oZDFcLulh6zbV%2Fe74ogA%3D%3D
Expect ReferenceFlag to be the type

Seems like working as intended?

https://github.com/oxc-project/oxc/blob/445603444f98402fb66a4a956b1023611bc66133/crates/oxc_semantic/src/builder.rs#L1690-L1695
Seems to be correct.

Yes, I checked now. It is correct. It may be due browser's cache  😕


feat(app): initial support of authenticating other users

:tada: This PR is included in version 2.130.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Option to import QtCreator scxmleditor state charts is requested

There is a feature request from user who wants to migrate from QtCreator's scxmleditor
Sample chart:

It is now imported as:

But it is required to keep original layout

Implemented since 2.2.4. Documentation here


Rule matching for HTML filtering rules

Need to implement rule matching for HTML filtering rules.
Syntax -- https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#html-filtering-rules

Merged in pull-requests/11 and pull-requests/13


[docs] Wrong element is highlighted in the sidebar menu

Describe the problem
Currently, if you directly navigate to a section in the docs, the preceding item is marked as active.
https://user-images.githubusercontent.com/47485431/163463849-4c5e825c-9504-45b4-ad9c-4b73073fe912.mov
This is happening because the active element in the sidebar menu is determined by the page position (i.e. the respective heading’s position in the viewport); if you navigate to a section directly, its heading is not high enough in the viewport to trigger a change.
Describe the proposed solution
Change the value from 40 to 102 or greater:
https://github.com/sveltejs/kit/blob/c46e08738199af8054c6496b921e118413046aa2/sites/kit.svelte.dev/src/lib/docs/Contents.svelte#L49
I guess the value should be tied to this CSS rule: https://github.com/sveltejs/kit/blob/c46e08738199af8054c6496b921e118413046aa2/sites/kit.svelte.dev/src/lib/docs/client/docs.css#L117
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

I'd like to resolve this issue, can you please assign it to me


fix(proxy): remove proxy on "osm namespace remove"

This fixes the issue where running "osm namespace remove"
on a namespace results in the namespace being removed,
but not the pods within the namespace. The Envoy certificates
are still not released, the pods (and their proxies) are still
considered part of the mesh, and the connected-proxies metric
count is not properly decremented.
Resolves #4166.
Signed-off-by: Johnson Shi<EMAIL_ADDRESS>Please describe how this change was tested. You could include supporting information
such as logs, snippets, and screenshots.
-->
Testing done: WIP

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[X]

Certificate Management
[X]

Control Plane
[X]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[X]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[X]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No

Did you notify the maintainers and provide attribution? NA

Is this a breaking change? No

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? NA

Tests to be added WIP once the functionality is fully tested.

Tried removing the bookbuyer namespace and checking the osm-controller's debug server, but the Envoy proxies are still connected and the certs are not released. @shashankram can you check out this draft PR + also check out my comments in issue https://github.com/openservicemesh/osm/issues/4166? Thanks and greatly appreciated!
johsh@MININT-06LHR58:~/dev/osm$ bin/osm namespace remove bookbuyer
pod [bookbuyer-5c7b89cd45-l58hk] in namespace [bookbuyer] successfully removed from mesh [osm]
Namespace [bookbuyer] successfully removed from mesh [osm]
johsh@MININT-06LHR58:~/dev/osm$ ./scripts/port-f
port-forward-all.sh              port-forward-bookstore-ui-v1.sh  port-forward-bookstore.sh        port-forward-grafana.sh          port-forward-osm-metrics.sh
port-forward-bookbuyer-ui.sh     port-forward-bookstore-ui-v2.sh  port-forward-bookthief-ui.sh     port-forward-jaeger.sh           port-forward-prometheus.sh
port-forward-bookbuyer.sh        port-forward-bookstore-ui.sh     port-forward-bookthief.sh        port-forward-osm-debug.sh
johsh@MININT-06LHR58:~/dev/osm$ ./scripts/port-forward-osm-debug.sh
Forwarding from <IP_ADDRESS>:9092 -> 9092
Forwarding from [::1]:9092 -> 9092
Handling connection for 9092
Handling connection for 9092
Handling connection for 9092


Destroy FilterState when object destroyed #3973

Examples
pixijs 4.7.1:
https://yahorpadlucki.github.io/pixiExample/default.html

this PR:
https://yahorpadlucki.github.io/pixiExample/custom.html

Seems to fix this issue - but not sure if I am doing it right?

Hi, @bigtimebuddy @themoonrat @ivanpopelyshev
can somebody look at it? Some how it is the only PR without comments ( Did I prepare it wrong?

Updated with 'destroyed' event listener

I think this solution a lot more. Thanks for iterating on that feedback!

@bigtimebuddy , Thanks a lot for review.
Made changes according to review, added unit-test for destroyed event

Closing in favor of #4897


Feature request: make search engine switch stick

Hi,
I switch between search engines quite often.
I'd prefer it if the selected search engine wouldn't switch back to the default search engine.
It would also be prefferable to have the favicon as a search engine's logo instead of a letter on a colored circle.
Having search results apear in a new tab would also be prefferable.
Thank you.

😁thank you hazuki0x0

This feature seems to have been removed in the last update


Fine-tune Problem

I have a pre-train model implemented in Sonnet. How do I fine-tune the model on another dataset?
For specific, how do I freezes variables or apply different learning rate for some layer, and add new layer on the top of the model?

Hi @RlChen0, the simplest way is to only request gradients to variables you want to train (e.g. use module.trainable_variables instead of tape.watched_variables()):
pretrained = snt.nets.MLP([300, 100, 10])
finetune = snt.nets.MLP([100, 10])

def forward(x):
  x = pretrained(x)
  x = tf.nn.relu(x)
  x = finetune(x)
  return x

x = tf.ones([1, 1])
with tf.GradientTape() as tape:
  y = forward(x)
  loss = tf.reduce_sum(y)

params = finetune.trainable_variables
grads = tape.gradient(loss, params)

If this is cumbersome (e.g. you are using a library which itself calls tape.watched_variables() or you don't have one module encapsulating what you want to finetune) then you can use a context manager to stop gradients being computed for specific parts of your forward pass:
def forward(x):
  with snt.custom_variable_getter(tf.stop_gradient):
    x = pretrained(x)
  x = tf.nn.relu(x)
  x = finetune(x)
  return x

with tf.GradientTape() as tape:
  y = forward(x)
  loss = tf.reduce_sum(y)

params = tape.watched_variables()
grads = tape.gradient(loss, params)

I put an example together in this Colab: https://colab.research.google.com/gist/tomhennigan/acf921df9a7e7dbbfd431414fd408fcb/example-of-selecting-variables-for-optimization.ipynb

Perfect solution to my problem.Thanks, Tom, you always help a lot.

Hi, Tom. I'm still confused about how to apply different learning rates.
Is there a way to do something like this?
pretrained = tf.saved_model.load(model_path)
finetune = snt.Linear(100, name='finetune')

opt1 = snt.optimizers.Adam(learning_rate)
opt2 = snt.optimizers.Adam(learning_rate *  10)

opt1.apply(pretained_grads, pretrained_params)
opt2.apply(finetune_grads, finetune_params)

Hi @RlChen0 , sure you just need to separate the gradients for pretrain and tune, the easiest way is to do this when you call into tape.gradient. Here is an example: https://colab.research.google.com/gist/tomhennigan/f6bf5520995e08fe54ade0736af9443b/example-of-selecting-variables-for-optimization.ipynb#scrollTo=WmcE3abMvMW2

Hi @RlChen0 , apologies it has been quite a while since I've used TF. Yes your suggestion would work, you can also query one of the traced functions on the restored model for the parameters it uses, that might be a bit more robust (e.g. it would work even if you change the names):
https://colab.research.google.com/gist/tomhennigan/43509a6d9156cf658666d6e158b557f6/example-of-selecting-variables-for-optimization.ipynb


Invalid certificate

Should be fixed now. Letsencrypt requires nginx to be manually reloaded with the new cert after it's generated. I'll apparently need to script up some automation to handle that in the future.


Things to be done before public release to Google Play.

[ ] EULA, license stuff

#873, @RSMNYS do we have the consolidated licenses file?

[ ] update the "About" page, it doesn't show latest SoCs.
[ ] Any other backend changes or docs changes needed?
[ ] CI/CD, if we had better CD with recent devices, we should be able too catch https://github.com/mlcommons/mobile_app_open/pull/745#issuecomment-2152006625, #347

@freedomtan  Here is the license file with the format we agreed. License text, and packages list under this license:
Let me know what else is needed.
3rdPartyLicenses.md

Per Scott's request: let's clarify backend licenses.
@Mostelk and @AhmedTElthakeb do you any idea of Samsung backend, as far as I can remember there are some .so libraries distributed with the apk.
For MediaTek, basically only libraries in the devices are used.

https://github.com/mlcommons/mobile_app_open/pull/892


⚠ Bofrost.de has degraded performance

In 62098df, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1265 ms

Resolved: Bofrost.de performance has improved in 6e85e72 after 6 minutes.


Navbar is not showing good in pc issue number #310 is solved

Navbar is not showing good in pc issue number #310  is solved
before

After navbar

@Hemraj-7 resolve the conflicts.

@Hemraj-7 resolve the conflicts.

@Hemraj-7


Missing field in record causes NullPointerException (for optional columns)

Given the following Avro schema:
{
  "name": "payload",
  "type": "record",
  "fields": [
    {
      "name": "field_a",
      "type": ["null", "boolean"],
      "default": null
    },
    {
      "name": "field_b",
      "type": ["null", "boolean"],
      "default": null
    }
  ]
}

Note that both fields in payload are optional.
It is allowed to encode the following object with this schema:
{
   payload: {field_a: true}
}

This encoded message will cause a NullPointerException in the clickhouse sink connector:

From the schema the existance of "field_b" will be defered, so this check will not lead to a null value.
The call to object.getValue() will return a null value
The null value will cause a NullPointerException when trying to extract the primitive value

I created a suggestion on how to fix this issue - what are your thoughts?
Checklist
Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@thilo-behnke would you mind signing CLA, please?

@thilo-behnke can you please provide some Unit tests

I just noticed when writing the tests that I was running version of 0.0.8-beta while this issue is already fixed (slightly differently) in 0.0.11-beta.
This for reference was the PR that fixed the issue: https://github.com/ClickHouse/clickhouse-kafka-connect/pull/65.


Har is not saved when Browser Server is closed

Describe the bug
Har file is not saved when Browser Server is closed using Close Browser Server keyword.
To Reproduce
Steps to reproduce the behavior:
${options_chrome}=    Create List
Append to List    ${options_chrome}    --remote-debugging-port=10000
${ws_endpoint}    Launch Browser Server    browser=chromium    headless=False    handleSIGHUP=False    handleSIGINT=False    handleSIGTERM=False    args=${options_chrome}    reuse_existing=True
${har}     Create Dictionary    path=${REPO_DIR}${/}browser${/}har.file
Connect To Browser    http://localhost:10000/    use_cdp=True
New Context    recordHar=${har}
New Page    URL
Close Browser Server    wsEndpoint=${ws_endpoint}

Expected behavior
Context and browser are closed. The HAR file is saved in the provided path
Desktop (please complete the following information):

OS: Windows 11
Browser chrome
Version 126.0.6478.127

Additional context

Python: 3.9.7
Robotframework: 6.0.2
Robotframework-browser: 18.6.3

I see that Browser and context for provided ws_endpoint are closed but the har file is not saved.

@allcontributors please add @Pawci3oo for bugs.

Most likely this forcefully closes browser/context/pages and in this case Playwright does not have time to create har file. As a workaround you could first run Close Browser keyword and then run  Close Browser Server keyword.

Basically, Close Browser and Close Context keywords do not work for me either but not in the described reproduction.
Before test execution I create Browser Servers and log in to the application using user credentials with specific permissions, then Suite is attached to a specific server, based on the needed user with permissions.
At the end of each suite, the browser server is not closed, but "passed" to the next suite to skip logging to the application.
I would like to close contexts and browser servers at the end of all suites.
As far as I know, Connect to Browser keyword with CDP connects to the server with CURRENT context and page, but I think I don't fully understand this implementation.
Below scenario to reproduce, where browser is not closed and har is not saved:
suite1_testSuite.robot
Test1
    ${options_chrome}=    Create List
    Append to List    ${options_chrome}    --remote-debugging-port=10000
    ${ws_endpoint}    Launch Browser Server    browser=chromium    headless=False    handleSIGHUP=False
    handleSIGINT=False    handleSIGTERM=False    args=${options_chrome}
    ${har}     Create Dictionary    path=${REPO_DIR}${/}browser${/}har.file
    ${id}    Connect To Browser    http://localhost:10000/    use_cdp=True
    ${ctx}    New Context    recordHar=${har}
    ${browser_ids}    Get Browser Ids <- browser with id X
    ${context_ids}    Get Context Ids  <- context with ids x and y
    New Page    URL
    [Tags]    reproduceIssue

suite2_testSuite.robot
Test2
    Connect To Browser    http://localhost:10000/    use_cdp=True
    ${browser_ids}    Get Browser Ids<- browser with id Y
    ${context_ids}    Get Context Ids <- context with id z
    Close Context - it doesn't work, context and browser are still open, har is not saved
    Close Browser - it doesn't work, context and browser are still open, har is not saved
    [Tags]    reproduceIssue

Pabot command:
pabot --processes 1 --pabotlib --verbose --include reproduceIssue *\*testSuite.robot


Error processing sketchy css background property

Given the css:
.test {
  background: url('http://example.com/testing/test.png') no-repeat right #fff;
}

cssnano produces the error TypeError: Cannot read property 'value' of undefined
Depending on the build tool (gulp, postcss, cli) this is expressed in different ways, but here's an example script.
var postcss = require('postcss');
var cssnano = require('cssnano');
var fs = require('fs');

postcss([cssnano()])
	.process(fs.readFileSync('example.css'), {
		from: 'example.css',
		to: 'example.min.css'
	}).then(function(result) {
		fs.writeFileSync('example.min.css', result.css);
	}).catch(function(err){
		console.warn(err);
	});

I realize this css isn't completely correct, but it should be dealt with, or a warning raised. Chrome actually parses it correctly, so that's why it wasn't caught before now, I think.

@apexskier Can you show stack trace?

TypeError: Cannot read property 'value' of undefined
    at /Users/cameronlittle/remitly-vagrant/html/portal/node_modules/cssnano/dist/lib/reducePositions.js:72:49
    at Array.forEach (native)
    at transform (/Users/cameronlittle/remitly-vagrant/html/portal/node_modules/cssnano/dist/lib/reducePositions.js:64:14)
    at /Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:88:34
    at /Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:73:26
    at Rule.each (/Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:60:22)
    at Rule.walk (/Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:72:21)
    at /Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:76:32
    at Root.each (/Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:60:22)
    at Root.walk (/Users/cameronlittle/remitly-vagrant/html/portal/node_modules/postcss/lib/container.js:72:21)

TypeError: Cannot read property 'value' of undefined
    at .../node_modules/cssnano/dist/lib/reducePositions.js:72:49
    at Array.forEach (native)
    at transform (.../node_modules/cssnano/dist/lib/reducePositions.js:64:14)
    at .../node_modules/postcss/lib/container.js:88:34
    at .../node_modules/postcss/lib/container.js:73:26
    at Rule.each (.../node_modules/postcss/lib/container.js:60:22)
    at Rule.walk (.../node_modules/postcss/lib/container.js:72:21)
    at .../node_modules/postcss/lib/container.js:76:32
    at Root.each (.../node_modules/postcss/lib/container.js:60:22)
    at Root.walk (.../node_modules/postcss/lib/container.js:72:21)

@apexskier As fast decision you can pass reducePositions: false option.

Thanks, that solves it temporarily!

I'm getting the same error, only I'm not sure where in my SASS the issue lies.
The reducePositions option fixes it. Still would be nice to know where I have an issue. Everything is rendering correctly.

@scottzirkel I was able to diagnose the location by logging the declaration being processed in reducePositions.js to get the file, then the args to get the tokens. I searched the tokens in css output and found the problem line.

Wow, just had this same issue at the same time. Just whittled it down to the first background:url('../images/icons/check.svg') center no-repeat; occurrence and then was like whaaaa? We have a bunch of these shortcut background:s all over the place. Great timing @apexskier
@scottzirkel I'm assuming the reducePositions is trying to use shorthand for positioning where it can map things like 10px 0px 10px 0px to 10px 0px and the like.

You can disable reducePositions option or use strict 3.4 version until 3.5 will be fixed.

@apexskier Oh smart.
I got lucky and found it rather quick. I am using one linear-gradient background and it turns out that was it.
I have in my sass: background: linear-gradient(to right, palette(primary, light), palette(primary), palette(primary, dark));
palette(primary) is a function that finds the primary color from the palette map and returns the value asked. In this case, light, default & dark. That is what's breaking. If I change out the palette for hex it works fine.

This fixed for me using gulp-cssnano:
var gulp = require('gulp');
var cssnano = require('gulp-cssnano');

gulp.task('default', function() {
    return gulp.src('./main.css')
        .pipe(cssnano({reducePositions: false}))
        .pipe(gulp.dest('./out'));
});

Thanks for the report, fixed in 3.5.1. :smile:


Beta

Description of the problem or steps to reproduce
Specifications

Commit hash:
OS:
Terminal:

are you okay


Loyalty Card

Please make possible that loyalty-card users receive the messages/News by email that our merchants broadcast and not only ones a week.
Thanks
client request of one of our believers
Please reply to<EMAIL_ADDRESS><EMAIL_ADDRESS>with the following link:
https://rogerth.at/internal/shop/questions
Title:
doorkrijgen mails
Description:
Beste,
Heb onlangs een bericht uitgezonden onder 'nieuws' met daarin een pdf (onze feestfolder) nu blijkt dat klanten die een fysieke kaart gebruiken (en dus niet de smartphone en dat zijn er heel wat bij ons) deze mail niet doorkrijgen. Hoe kunnen deze klanten die mail wel ontvangen?

Hi,
Can we have a ETC of this issue so we can update.
Else If the issue is resolved please put the state_resolved label and close the issue.
Thanks!

@FastGeert Do you want this feature?

Geert told me to wait until we had a chat with Tom about this

Update:

Customer scans his paper card at the merchant.
After loyalty finished a popup will be shown "do you want news updates" (only show this once)

Design needs to be made by a designer (also think about attachments etc...)

Can somebody explain this to me?
Thanks
http://www.onzestadapp.be
TOM VAN HECKE / CEO & Co-Founder
<EMAIL_ADDRESS>/ +32 (0)474 79 25 80
ONZE STAD APP
+32 (0)9 324 25 64
Antwerpsesteenweg 199080 Lochristi
www.onzestadapp.be
<EMAIL_ADDRESS>[image: Twitter] https://twitter.com/onzestadapp [image: Facebook]
https://www.facebook.com/onzestadapp [image: Youtube]
https://www.youtube.com/c/OnzestadappBe-Vlaanderen
Bekijk hier de Sint-Truiden-App-Movie! https://youtu.be/x8xJvfTNc7U
2017-07-14 15:08 GMT+02:00 Ruben Mattan<EMAIL_ADDRESS>
Update:

Customer scans his paper card at the merchant.
After loyalty finished a popup will be shown "do you want news
updates" (only show this once)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/our-city-app/oca-backend/issues/92#issuecomment-315355400,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV95CO-heLCZJ1QrF2elXxg5PMYQRwbKks5sN2hSgaJpZM4K5H-J
.

We need the design of the email containing the news item (think about all functionality of the news items)


Not working with Swift

Hello i try to use this repo but this is not working in swift.
Gives an problem with the tableview.delegate downcast, has anyone  solution for this problem?
Greetz

Yeah, I think all you have to do is extending BLKDelegateSplitter with the protocol you want to use. In your case UITableViewDelegate.

I'm pretty new to Swift and iOS and I spent a lot of hours to come to the conclusion that the break was with this class.  Modifying the BLKDelegateSplitter class to conform to the UITableViewDelegate protocol fixed it for me.  I have the demo running now with a Swift based view controller.

@trevisthomas  could you show your BLKDelegateSplitter conformation to the UITableViewDelegate?

Just edit the BLKDelegateSplitter.h file. Replace the @implementation declaration at line 29 with:
@interface BLKDelegateSplitter : NSObject <NSObject, UITableViewDelegate>

Thank you for your response. You're right.
Also @rabzu Demo in Swift pull request https://github.com/bryankeller/BLKFlexibleHeightBar/pull/20 was very helpful.
extension BLKDelegateSplitter: UICollectionViewDelegate {
}

Hi rafalkitta,
I tried with your extension so I don't get the compiler error. But at run time, the BLKDelegateSplitter does not forward the calls to any of its sub-delegates.
Have you modify anything else to make it work ? I use Swift 2.0

It appeared I have to make a strong reference to the splitter because tableView.delegate is weak. Why splitter was just deallocated by ARC...
Works perfectly now, great component !

add this extension to solve this issue this is work for me
extension BLKFlexibleHeightBarBehaviorDefiner :UITableViewDelegate{
}


CTD when placing a pipe next to a thermal tower

pipe was placed next to a regular tower block, not a valve.  world now fails to load
crash.txt

Seems to be fixed in build 288.


allow physac to be built as a shared library

if BUILD_LIBTYPE_SHARED is defined allow build as a shared dll
This is as per a discussion on discord yesterday, on how to get physac working with C# bindings.

@jasonswearingen thanks for the improvement!


GitLab now supports 2FA.

GitLab now supports 2 Factor Authentication. We can add it.

Already added in #1154


Raw Data by different data ranges

My raw data looks like this atm:
def get_raw_records
    CampaignOfferPublisherReport.where('start_time >= ?', 7.day.ago.at_beginning_of_day).group(:campaign_offer_id, :publisher_id).select(:campaign_offer_id, :publisher_id, "sum(`campaign_offer_publisher_reports`.`clicks`) as clicks","sum(`campaign_offer_publisher_reports`.`cost`) as cost","sum(`campaign_offer_publisher_reports`.`revenue`) as revenue", "sum(`campaign_offer_publisher_reports`.`profit`) as profit", "sum(`campaign_offer_publisher_reports`.`conversions`) as conversions", "sum(`campaign_offer_publisher_reports`.`visits`) as visits" ,"MIN(`campaign_offer_publisher_reports`.`start_time`) as start_time", "MAX(`campaign_offer_publisher_reports`.`end_time`) as end_time").order('profit asc')
  end

** I want the user to choose between 1 day 3 days or 7 days ago... so where can i put the where statement?**

@Stefflan00 here's what I would do
First, in the html view code, I would add a <select> tag with the options you need the user to choose (1 day, 3 days, 7 days ago).
Then I would ensure that changing the value on the select (and maybe clicking a "Search" button) results in a post/get request to the same rails route, where it appends the start_time param to the URL, something like: http://localhost:3000/campaign-offer-publisher-report?start_time=3.
Then in the controller I would pass in that param into the format.json handler, something like:
def index
  respond_to do |format|
    format.html {}
    format.json { render json: MyDatatableClass.new(view_context, { start_time: params[:start_time] }) }
  end
end

Then, as the documentation reads, I can use the hash passed in an options hash inside my datatable class.
def get_raw_records
  CampaingOfferPublisherReport.where(
    "start_time >= ?", options[:start_time]
  )
  .group(:campaign_offer_id, :publisher_id)
  .select(:campaign_offer_id, :publisher_id, "sum(`campaign_offer_publisher_reports`.`clicks`) as clicks","sum(`campaign_offer_publisher_reports`.`cost`) as cost","sum(`campaign_offer_publisher_reports`.`revenue`) as revenue", "sum(`campaign_offer_publisher_reports`.`profit`) as profit", "sum(`campaign_offer_publisher_reports`.`conversions`) as conversions", "sum(`campaign_offer_publisher_reports`.`visits`) as visits" ,"MIN(`campaign_offer_publisher_reports`.`start_time`) as start_time", "MAX(`campaign_offer_publisher_reports`.`end_time`) as end_time")
end

And also, will make sure to pass in (a default value for) that start_time param when drawing the html view (in the section where you build the table markup:
<table class="table" id="report-table" data-source="<%= table_index_path(format: :json, start_time: 3) %>">

Please notice in the get_raw_records method, I omitted the .order() clause... as that should be left to dataTables to handle, both by providing an array of sortable_columns inside the datatable class, and maybe add a default sorting param in the JS code.


Please help with my error log-format (custom nginx)

Hi
tried this
log-format %d %t %^ %^ %^ %^ "%r" %s %b "%R" "%u" "%T" "%^" "%^" "%^"
log file errors.log
2018/12/02 06:33:08 [error] 8001#8001: *655829940 "/var/www/html/index.html" is not found (2: No such file or directory), client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", host: "news1.golderynsaffet.webcam"
received
Token 'OST' doesn't match specifier '%s'
Token 'ET' doesn't match specifier '%s'
Token 'ET' doesn't match specifier '%s'
Token 'OST' doesn't match specifier '%s'
Token 'ET' doesn't match specifier '%s'
Token 'OST' doesn't match specifier '%s'
Token 'ET' doesn't match specifier '%s'
Token 'OST' doesn't match specifier '%s'
Token 'ET' doesn't match specifier '%s'
Token 'ET' doesn't match specifier '%s'
please tell me how to make a format?
explain to me how you do it. I do not understand, but I want to learn

log-format %d %t %^ %^ %^ %^ %^ %^ %^ %^ %^ %^ %^ %^ %^ ~h{,} %^ "%r" %v

html is not exported (

The following should work for the line you posted. However, please note goaccess is NOT an error log parser, so depending on the message, it will work or it may not.
goaccess access.log --log-format='%d %t %^ %^ "%^" %^, %^: %h, %^"%r", %^: "%v"' --date-format='%Y/%m/%d' --time-format=%T

Parsing... [0] [0/s]
not exported

As I said, you need to parse an access log not an error log for goaccess to work.


DockerHub Build and Tag on Release

Description
Adding a workflow on our release action to build and tag the docker images. I've commented out the section for engineering-effectiveness to add their secrets for the staging account.
Currently only builds the architecture the runner is on, will add cross arch build in a followup pr.

Category: Enhancement
Why these changes are required? Publishing to docker enables our solution to be consumed by other partners without building from source
What is the old behavior before changes and new behavior after changes? Release action will build docker images, no publishing occurring at this step

Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1570
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Tested in GHA https://github.com/opensearch-project/opensearch-migrations/actions/runs/10115830331/job/27977434308
Check List

[x] New functionality includes testing

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can we please merge this PR so I can only a new one on top of it.
Thanks.


[fix][broker] Fix create ns

Motivation
The bundles policy of the namespace is ignored if the namespace is created directly by the NamespaceResources, see the logic of admin service:
https://github.com/apache/pulsar/blob/9e4daeaa0817ade39be4377f219029c6419f61fe/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java#L1956-L1969
Modifications

Use admin to create a namespace instead of the NamespaceResources

Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

Matching PR in forked repository
https://github.com/nodece/pulsar/pull/4

Lgtm
What about adding a test case?

I think we should add an integration test, what do you think about that?

Could you clarify which policies are affected?

Could you clarify which policies are affected?

See the PR description.

If only the number of bundles were affected, could you use another solution? This PR brings a breaking change to the standalone. We need to add an integration test to protect it.

If only the number of bundles were affected, could you use another solution?

No.

This PR brings a breaking change to the standalone. We need to add an integration test to protect it.

Good catch. Let me add an integration test for this.

For how to reproduce it, you can reference the pulsar-test-service-start.sh, which uses standalone-ssl.conf as the config file. In additional, even if Pulsar service is ready was printed, the standalone actually didn't start successfully. You can log in the docker container and run bin/pulsar standalone -nss -nfw directly, you should see the following logs:
2022-12-09T07:45:12,311+0000 [main] INFO  org.apache.pulsar.broker.PulsarService - created admin with url http://localhost:8080
2022-12-09T07:45:12,664+0000 [pulsar-web-46-15] ERROR org.apache.pulsar.broker.admin.v2.Namespaces - [anonymous] Failed to create namespace public/default
java.util.concurrent.CompletionException: org.apache.pulsar.broker.web.RestException: Unauthorized to validateTenantOperation for originalPrincipal [null] and clientAppId [anonymous] about operation [CREATE_NAMESPACE] on tenant [public]
        at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
        at java.util.concurrent.CompletableFuture.uniAcceptNow(CompletableFuture.java:761) ~[?:?]
        at java.util.concurrent.CompletableFuture.uniAcceptStage(CompletableFuture.java:735) ~[?:?]
        at java.util.concurrent.CompletableFuture.thenAccept(CompletableFuture.java:2182) ~[?:?]
        at org.apache.pulsar.broker.web.PulsarWebResource.validateTenantOperationAsync(PulsarWebResource.java:995) ~[org.apache.pulsar-pulsar-broker-2.11.0.jar:2.11.0]
        at org.apache.pulsar.broker.admin.impl.NamespacesBase.internalCreateNamespace(NamespacesBase.java:138) ~[org.apache.pulsar-pulsar-broker-2.11.0.jar:2.11.0]
        at org.apache.pulsar.broker.admin.v2.Namespaces.createNamespace(Namespaces.java:166) ~[org.apache.pulsar-pulsar-broker-2.11.0.jar:2.11.0]

Because you didn't set up the brokerClientAuthenticationPlugin and brokerClientAuthenticationParameters in the standalone-ssl.conf.

The previous deployment also didn't set up these two configs and it has worked for a long time.

It's a real-world breaking change, not something like "it's an API that might already be used somewhere". The current semantics have already been applied in the standalone deployment of the C++/Python client tests.
I just confirmed that the Golang client tests would also fail after this change.
https://github.com/apache/pulsar-client-go/blob/055b00b83ccfef4ea12a593e3678cb4bdd18311c/integration-tests/conf/standalone.conf#L112-L115
Other ecosystems are not confirmed. But I think it's enough.
Breaking change is a breaking change not for "how it should be used", but for "whether it has already been used".


Add info about restoring tables with UDTs

Closes #7962, #7830.
To Do:

[ ] Once Eric's ENUM Types PR is merged, add links to ENUM, DROP TYPE (is there RENAME TYPE?) - cc @ericharmeling

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9a81fe119a2fdba7ed2d6b54ecaeeca648372f1f/
Edited pages:

v20.2/restore.md

Per this, why is the third example not necessarily compatible? Could the ADD VALUE ('lauren') append the new element to the beginning of the set (which would then be incompatible with ('hello', 'lauren')?

Yeah, this is the tricky part. The internal representation of 'lauren' is different when both enum members were created up front vs when only 'hello' is created up front and 'lauren' is added later. This representation is stored durably as part of each row, so they aren't compatible.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/83ba6959775b38cd1af61b30602f84df29e841c3/
Edited pages:

v20.2/restore.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8f0cdc86c625c186214730d222eeb58d694c4261/
Edited pages:

v20.2/restore.md

Also, is "batched" ok to use here?

No I don't think thats quite right. I think just "created in the same way" should be fine. I think the examples would help catch some confusion in advance though.

Linking to this section in the RFC might be useful https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/20200331_enums.md#physical-layout

Thanks! Added the link and examples. Can you take a look?

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fb1ba20c25d1ea9e03629fe98dfb2a7edb55151d/
Edited pages:

v20.2/restore.md

This makes sense, especially with the example, though I wonder if there is a more precise term than "kind", since an enum is a data type. Something like "two user-defined types are compatible if they have the same data type"? Possible I'm not understanding correctly, though.

Kind is a term used to describe the "type" of a type

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a56224b34970e38d2601973c12c7fb774af004a7/
Edited pages:

v20.2/restore.md


Use latest nixpkgs

This relates to this suggestion here. Ultimately, this is needed for Schnorr signature support.

I'm getting a really weird build failure locally:
error: builder for '/nix/store/di7r7vnkakysi0ambfgpdi48qyx4qzxj-discount-2.2.7.drv' failed with exit code 2;
       last 10 log lines:
       > installing
       > install flags: SHELL=/nix/store/cfwzs61rdvvziplxh4gyq49f8gwrf42k-bash-5.1-p12/bin/bash install
       > /tmp/nix-build-discount-2.2.7.drv-0/source/config.md /nix/store/31ypra6mzlx74kcva80nn3gaxxxxcy73-discount-2.2.7/bin
       > /tmp/nix-build-discount-2.2.7.drv-0/source/config.md /nix/store/31ypra6mzlx74kcva80nn3gaxxxxcy73-discount-2.2.7/lib
       > /tmp/nix-build-discount-2.2.7.drv-0/source/config.md /nix/store/31ypra6mzlx74kcva80nn3gaxxxxcy73-discount-2.2.7/include
       > /tmp/nix-build-discount-2.2.7.drv-0/source/config.md /nix/store/31ypra6mzlx74kcva80nn3gaxxxxcy73-discount-2.2.7/lib/pkgconfig
       > /nix/store/hjymmi7cq1wy3fb1l7nyk274y5ijgnhw-coreutils-9.0/bin/install -s -m 755 markdown /nix/store/31ypra6mzlx74kcva80nn3gaxxxxcy73-discount-2.2.7/bin
       > ./librarian.sh install libmarkdown VERSION /nix/store/31ypra6mzlx74kcva80nn3gaxxxxcy73-discount-2.2.7/lib
       > /sbin/ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied
       > make: *** [Makefile:43: install] Error 1

   For full logs, run 'nix log /nix/store/di7r7vnkakysi0ambfgpdi48qyx4qzxj-discount-2.2.7.drv'.

This clearly seems to be an issue locally, but I have no idea why this is happening or how to diagnose it.

Hydra has some odd eval errors. To minimize the change surface, I suggest using the same rev as in https://github.com/input-output-hk/haskell.nix/pull/1371

@michaelpj I tried (what I understood was) your suggestion, but I seem to hit the same issue. I've pushed that as a commit to this branch: please let me know if I have misunderstood something.

It was just a hope :sob:

I'm not sure what you did this time. It looks like you updated haskell.nix but didn't add nixpkgs at the revision that you wanted?

I took a stab at it here, let's see how it goes: https://github.com/input-output-hk/cardano-base/pull/257


Class Swift_CharacterReaderFactory_SimpleCharacterReaderFactory does not exist

hello i have just transfer our site one server to another server and now i am getting a error. i am now trying to use smtp
PHP Fatal error: Uncaught exception ‘ReflectionException’ with message ‘Class Swift_CharacterReaderFactory_SimpleCharacterReaderFactory does not exist’ in /assets/php/vendor/swiftmailer/swiftmailer/lib/classes/Swift/DependencyContainer.php:308
am i missing something ??
Thanks

Hi! I have the same problem with Swift_Encoder_Rfc2231Encoder


[Question] - Ubuntu Cosmic Support - Target release timeline.

Description of Problem / Feature Request
We are using clair for static scans of containers and we are seeing that it does a no-op/false-positive for Ubuntu 18.10 images as its not yet a supported namespace.
I am creating this ticket as a question to ask about the planned timeline of the next release (as the fix to support cosmic is already merged in)
Expected Outcome
Target date for next release to avail the support for Ubuntu cosmic based images.
Actual Outcome
Not sure when release will be cut
Environment

Clair version/image: 2.0.6
Clair client name/version: 2.0.6 (v2 api)
Host OS: Amazon ECS / Ubuntu Cosmic base layer from dockerhub
Kernel (e.g. uname -a):
Kubernetes version (use kubectl version): NA
Helm version (use helm version): NA
Network/Firewall setup: NA

Commit link for cosmic image support
https://github.com/coreos/clair/pull/650

I cut a stable release today (v2.0.7) that contains a fix for this.


Installation documentation for SvelteKit is outdated

The current documentation for using windicss with SvelteKit at https://windicss.org/guide/svelte.html#sveltekit is outdated, since it doesn't take SvelteKit's recent switch to vite into account. Although it's currently still in open beta and therefore likely a moving target, I think it would be nice to update the docs at least to the current situation.
After some fiddling, I found this to be a working solution for the latest SvelteKit/svelte@next:
// svelte.config.cjs
const node = require('@sveltejs/adapter-node');
const pkg = require('./package.json');

/** @type {import('@sveltejs/kit').Config} */
module.exports = {
  kit: {
    adapter: node(),

    target: '#svelte',

    vite: {
      ssr: {
        noExternal: Object.keys(pkg.dependencies || {})
      },
      plugins: [
        require('vite-plugin-windicss').default()
      ]
    }
  }
};

// src/routes/$layout.svelte
<script>
  import 'virtual:windi.css'
</script>

<slot></slot>

you are right! had no time to check on it. Please make a PR, i will approve it!

Sure, I just made a pull request!


request https via  https proxy but return 'unknown protocol:openssl ' error

Everything is fine if I request 'http' address via  'http' proxy
const rq = require('request-promise');
try {
    let res = rq({
        url: 'http://xxxx',
        timeout: TIME_OUT,
        gzip: true,
        proxy: 'http://<IP_ADDRESS>:8080'
    });
    res.then(res => {
        console.log('res');
        console.log(res);
    }).catch(err => {
        console.log(err);
    });
} catch (error) {
    console.log(error);
}

But if request 'https' addrss via 'https' proxy, it will return 'unknown protocol '

RequestError: Error: tunneling socket could not be established, cause=write EPROTO 101057795:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:openssl\ssl\s23_clnt.c:827:

try {
    let res = rq({
        url: 'https://ipinfo.io/', //  https address
        timeout: TIME_OUT,
        gzip: true,
        rejectUnauthorized: false,
        proxy: 'https://<IP_ADDRESS>:3128' //  https proxy
    });
    res.then(res => {
        console.log('res');
        console.log(res);
    }).catch(err => {
        console.log(err);
    });
} catch (error) {
    console.log(error);
}

At first I thought it was a problem with the proxy address. But the same proxy address works fine in python requests module

python code

import requests, os
os.environ['HTTP_PROXY'] = '<IP_ADDRESS>:8080'
os.environ['HTTPS_PROXY'] = '<IP_ADDRESS>:3128'
try:
    text = requests.get('https://ipinfo.io/').text # request https address
except Exception as e:
    print(e)
    print('connect failed')
print(text)
# it works fine!  {
  "ip": "<IP_ADDRESS>:3128",
  "hostname": "181.ip-158-69-206.net",
  "city": "Montreal",
  "region": "Quebec",
  "country": "CA",
  "loc": "45.5000,-73.5833",
  "postal": "H3A",
  "org": "AS16276 OVH SAS"
}
# The returned 'ip' information is the 'https' proxy address.

A similar problem was found in StackOverflow. Someone replied that it is a port problem.

Here is the link StackOverflow

But I think this is not a problem about the port,because when I use proxy by fiddler, it works!

Here is my configuration about fiddler

code (by fiddler)

try {
  let res = rq({
    url: 'https://ipinfo.io/',
    timeout: TIME_OUT,
    gzip: true,
    rejectUnauthorized: false,
    proxy: 'http://<IP_ADDRESS>:8888' // through fiddler
  });
  res
    .then(res => {
      console.log('res');
      console.log(res); // it works!!
    })
    .catch(err => {
      console.log(err);
    });
} catch (error) {
  console.log(error);
}

However, based on the above code, Proxy changed to '<IP_ADDRESS>:3128' (without fiddler) will still report 'unknown protocol:openssl\ssl\s23_clnt.c:827' error
So what went wrong? I have not solved it.

I have the same problem, but I don't know how to solve it.


Add Support for Inline  Blocks and Fenced code block

Description:

I need to enhance my application's Markdown rendering engine to support inline  blocks and fenced  blocks. Currently, enclosing text in a single backtick (`) and 3 backticks(```) doesn't render it as code, but I want it to be displayed as <code>...text...</code> in the HTML output.

Steps to Implement:

Implement the functionality to render inline <code> blocks by enclosing text in a single backtick (`) and rendering it as <code>...text...</code>.
Implement support for fenced code blocks by detecting triple backticks (```) and wrapping the content within
...
 tags.

close by 525e313


Auto import adds value import to type-only import statement

TypeScript Version:  3.8.0-dev.20200104

Search Terms:
Code
import type {SourceFile} from 'typescript';
const file: SourceFile = createSourceFile(

While typing createSourceFile use auto import.
Expected behavior:
Adds a named import for createSourceFile and removes the type keyword from the import.
Actual behavior:
Adds a named import for createSourceFile while keeping it a type-only import. This causes an error as createSourceFile does not exist in the type space.
Related Issues: Introduced by #35200 @andrewbranch

Already working on this one (it’s one of the two unchecked to-do boxes on the original PR)


numbat: 1.13.0 -> 1.14.0

Updated to: https://github.com/sharkdp/numbat/releases/tag/v1.14.0
Also, removed the patch that is not needed anymore since it is included in v1.14.0 now.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

 Please make it just do the update, no reformatting.
Your git user also appears to be wrong in your commit; its email is not connected to your GH account.

Yes, I noticed that too. I'm currently working from a different computer, but you were faster than me.
I don't quite understand the formatting. I have run the nixfmt-rfc-style over it?

The problem is that the update commit still does the format. Please make commits do one logical step rather than two of which the second step is then revised in another commit.
One commit for the update (and only the update) and optionally one commit that does the reformat. The order doesn't matter, though it'd be slightly better if the reformat happened before the update.

Yes that make sense.
Thanks for your help. Will do it.


Recreate original site contents (minus theme)

The new site must have the same functionality and content as the old site.

Main sections are represented.


Add --skip-test argument to CLI

Closes #2341

This seems to work, not for my intended usecase

So does this work or not? 🙈

Yes it works as intended, but not for my intended use case

I'm somewhat confused by this, how can this PR work as intended if it builds and runs the skipped test?

Because it skips tests on a filter, but not building the test completely, even if there are no tests. This is still useful, just not for what I had in mind.


[Localization] How can we help extend i18n support?

@dbaeumer
Looks like you are dealing with localization. If I'm wrong pls correct me.
As the title says, is there a way we can help extend i18n for other languages?

Found my answer at #2041. Looks like we aren't there yet.

@JimiC correct :-)


No longer store dist/ in repo

As per #32

Thanks for doing this! Looks like Travis is running off of /dist, which may make testing a bit more complicated. Might need to have @thebigspoon chime in on this one.

@svmatthews Okay, this should be good to go now!

:+1:

:+1:


Suggestion for block operations priority

There is some inconsistency with priority of block combining and removing.
Usually in such games block combining has higher priority, than other operations. Thus I'd expect on 'Down' action that two blue blocks selected on 'step_1.png' screenshot would combine to blue block with '8' level, and then this block would move to blue line. Instead, block with '7' level is moved to blue line (removed from main game field), and single block is just shifted a bit.
E.g. see attached screenshots (pay attention to block in red frame).

Done. The priority of the combination process has been increased. But I'm not sure that this is right. Waiting for feedback by players...
Thank you for your participation!

Probably, it would be better just to switch actions priorities?
Current change does both actions (combining 2 blocks and removing them) within one move. It might be less confusing if this action was done in separate moved. For the case above: 'Down' move -> 2 blocks combine making one '8' level blue block -> 'Down' move -> '8' level blue block is moved to blue line (removed).

That's a great idea. I've implemented it. So much better. Thank you.


Mark is_valid_string as non-API

Closes https://github.com/extendr/extendr/issues/841.
libR-sys PR https://github.com/extendr/libR-sys/pull/253 removed more non-API items. This needs to be reflected in extendr-api. At present if libR-sys 0.7.1 is used with extendr-api 0.7.0 compilation will fail.
This PR marks the is_valid_string() and is_valid_string_f() trait methods as non-api feature.

Ironically CI is failing with the error that this PR is intended to fix. @CGMossa when you have a chance, do you mind giving this a brief once over?

I've already been staring at it.

This PR did not yield a CI run that were successful.
An immediate follow-up, that aims to fix CI is needed.

What is really odd is that running cargo extendr r-cmd-check results in passing tests locally. The issue cannot be reproduced on my side.


Guidelines on how to test analyzer performance

Some ideas:

How do we measure an analyzer performance?
Create a sample test project or tool
What are acceptable thresholds? Could we create thresholds to bind slow, regular, fast analyzers?

I've been attempting to get this working, but all of my standard approaches to controlled benchmarking are producing unreliable results. I'm leaning towards running a large number of passes using the same analyzer, throwing out a fixed number of outliers (high and low), and averaging the results. However, the number of passes required to get the confidence interval small enough for meaningful results is large, so it takes nearly 2 hours to calculate the values for just our own relatively small solution. I'm concerned that we would additionally need to test other projects (#16) before we're sure that the numbers accurately reflect the expected real-world performance.

This continues to be an issue. I just got an issue to look into that, and we don't even know where to start... https://github.com/code-cracker/code-cracker/issues/766

any update on this?


Use new reportextension object in test example 7

With BC 18 MS has introduced the reportextension object. This could be used in test example 7 (how to test a report) instead of the report object that replaces the whole standard report 101.
References

Report Extension Object
Report Extension Example

Currently working on this, but there seems to be a bug in the new feature. Reported it the MS on yammer:
There seems to be a bug in the reportextension feature. At least on the VS Code side.
I am working on an extension of report 101 (Customer - List). The example below is part of the update of the 2nd edition of my book on test automation.
I am extending the Customer table with a field called Lookup Value Code.
tableextension 50000 "CustomerTableExt" extends Customer
{
    fields
    {
        field(50000; "Lookup Value Code"; Code[10])
        {
              Caption = 'Lookup Value Code';
              DataClassification = ToBeClassified;
              TableRelation = "LookupValue";

              // I have not added the definition of this table, for this issue you might want to remove the TableRelation
        }
    }
}

And want to add this field to report 101:
reportextension 50000 "CustomerListExt" extends "Customer - List"
{
    RDLCLayout = './reportlayouts/CustomerList.rdl';

    dataset
    {
        add(Customer)
        {
            column(Customer_Lookup_Value_Code; "Lookup Value Code")
            {
                IncludeCaption = true;
            }
        }
    }
}

CustomerList.rdl has been set up to contain the new field. This all seems to work fine including the deployment and selecting this new report layout as the new default layout on the Report Layout Selection page. But when I run it I get the error:
Rendering output for the report failed and the following error occurred: The Value expression for the text box ‘Customer_No_Caption’ refers to a non-existing report parameter ‘Customer_No_Caption’. Letters in the names of parameters must use the correct case.
When I compare the original layout and the replacing layout it's clear what is the case: double underscore, i.e. __, have been removed from the columns names by the AL Language compiler:
original
<Textbox Name="Customer__Balance__LCY__">
new
<Textbox Name="Customer_Balance_LCY_">
See also the screenshot of (a part of) the compare of the original layout (left) and the report extension layout (right).

Can you confirm this?
I have tested this on version: W1 18.0 (Platform 18.0.22893.23773 + Application 18.0.23013.23795)

On request of Peter Borring (MSFTE) I had also reported it on AL Github: https://github.com/microsoft/AL/issues/6612. And the issue was fixed.

Implemented Scenario #0032
Scenario 0032 'Test that lookup value shows on   standard Customer - List report' {
    Given '2 customers with   different lookup value'
    When 'Run standard report Customer - List'
    Then 'Report dataset   contains both customers with lookup value'
}

tested (in ADO pipelines) and OK.

See my addendum post.


agdaPackages.standard-library: 2.0 -> 2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/agda/agda-stdlib/releases.
meta.description for agdaPackages.standard-library is: Standard library for use with the Agda compiler
meta.homepage for agdaPackages.standard-library is: https://wiki.portal.chalmers.se/agda/pmwiki.php?n=Libraries.StandardLibrary
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.1 with grep in /nix/store/8s6gy3662wyd5kmjv95wkgb8krqzxmnb-standard-library-2.1
found 2.1 in filename of file in /nix/store/8s6gy3662wyd5kmjv95wkgb8krqzxmnb-standard-library-2.1

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

agdaPackages.agda-categories
agdaPackages.functional-linear-algebra
agdaPackages.generics
agdaPackages.standard-library

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8s6gy3662wyd5kmjv95wkgb8krqzxmnb-standard-library-2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A agdaPackages.standard-library https://github.com/r-ryantm/nixpkgs/archive/64f8e95b77458145c879d1cadd4dd660f2ef45db.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/64f8e95b77458145c879d1cadd4dd660f2ef45db#agdaPackages.standard-library

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8s6gy3662wyd5kmjv95wkgb8krqzxmnb-standard-library-2.1
ls -la /nix/store/8s6gy3662wyd5kmjv95wkgb8krqzxmnb-standard-library-2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

Maintainer pings
cc @jwiegley @laMudri @alexarice @turion for testing.

Pretty awesome that the bot now automatically updates the library and tests all its reverse dependencies


Splitting webpack "headers" from commons chunk

Hello guys, I have the following use case, that I cant design with webpack
I have an "app" entry point optimized with CommonsChunkPlugin plugin
entry: {
    app: './app.js',
    vendor: Object.keys(packageJSON.dependencies)
},
plugins: [
    new webpack.optimize.CommonsChunkPlugin(
        'vendor', '[name].js', Infinity
    )
]

It gives me
app.js
vendor.js

Which I require on my index file, first vendor, then app.
I want to create another entry that loads a promise lib before vendor and another one that will prefetch some data while the user waits the 'vendor.js' file to load.
entry: {
    promise: ['promise'],
    prefetch: './prefetch.js',
    app: './app.js',
    vendor: Object.keys(packageJSON.dependencies)
},

The problem with that approach is that the webpack jsonp loader is defined on the vendor entry (also the largest one), and I want to transfer it to another file so my application could be loaded on the following order
1: webpackLoader.js -> define webpack loaders
2: promise.js -> exposes promise library polyfill
3. prefetch.js -> requests data to be prefetched and parses them into a promise stored on global scope
4. vendor.js -> vendors are loaded
5. app.js -> uses vendor.js libraries to render stuffs

How can I do it?

Did you try specifying an array of files for your vendor entry? All files specified in an entry - string or array - are guaranteed to be executed (unless you do something really … yknow.)
So you can add your prefetch and promise stuff in your vendor bundle as well - just specify it all as an array.

Hi @IngwiePhoenix thanks
I am defining them as an array based on my dependencies
vendor: Object.keys(packageJSON.dependencies)

My problem is that I cant load my prefetch.js before vendor.js because of webpack jsonp loader is defined on vendor.js.

I want to create another entry that loads a promise lib before vendor and another one that will prefetch some data while the user waits the 'vendor.js' file to load.

When you say "wait for vendor file to load", do you mean you want to load the vendor chunk asynchronously?

@taurose Yes, but I could also use the order I mentioned synchronously (which is what I suggested):

1: webpackLoader.js -> define webpack loaders
2: promise.js -> exposes promise library polyfill

prefetch.js -> requests data to be prefetched and parses them into a promise stored on global scope
vendor.js -> vendors are loaded (load vendors)
app.js -> uses vendor.js libraries to render stuffs

For the synchronous case, does that work?
entry: {
    promise: ['promise'],
    prefetch: './prefetch.js',
    app: './app.js',
    vendor: Object.keys(packageJSON.dependencies)
},
plugins: [
    new webpack.optimize.CommonsChunkPlugin(
        'vendor', '[name].js', Infinity
    ),
    new webpack.optimize.CommonsChunkPlugin('loader.js')
]

I'm a bit confused though, why you'd want to split your modules that much, when you plan to load them all up-front anyways.

https://github.com/webpack/webpack/tree/master/examples/two-explicit-vendor-chunks
        new CommonsChunkPlugin({
            names: ["vender", "prefetch", "promise"],
            minChunks: Infinity
        })

Thank you guys, sokra's pattern worked for me!
@taurose the reason is to follow the "shell" structure, with offline apps. That way I can split my dependencies in offline / online, and manage them better with my service worker.


Support SPDY / HTTP2

SPDY and soon HTTP2 would allow to create 1 persistent connection in which each request and response get an id with "X-SPDY-Stream-ID" header so they can be handled async on that 1 connection.
This would allow for much more efficient etcd clients. Also TLS handshakes would only be done once on connection creation.

@jurmous @philips We probably will go with grpc for v3, which utilize HTTP2 features.

@xiang90 We can consider giving access to v2 over HTTP2 too, right?

Etcd v2 is a model citizen of how to expose resources on the web because it has such a great, simple and elegant general purpose API that anyone with a rest-client can easily begin to use against HTTP: I'd love to see the transport upgraded, while still keeping the blissful resourceful v2 API largely intact.
I do think there's room to explore using http2/push to enhance the wait capabilities: #2844.

If we build etcd with go 1.6 and enable HTTPs, everything will be HTTP2 (client needs to support HTTP2 too). Also v3 API is already http2 right now.


Browser buttons?

Would it be possible to support the back/forward buttons of the browser so that it's possible to use them to navigate the form? Is this something you have planned or is it outside the scope of this component?

Interesting. Certainly nothing Im currently working on though.

This was my first thought too; if there was a way to serialize the wizard state into the browser state, to facilitate the back/forward buttons.
I may explore this.
Nice demo, by the way!