Project contribution rules

Contribution rules must be clearly spelled out to make it easeier for potential contributors to develop sankaku.
So suggestion is in writing CONTRIBUTION.md file.

Added CONTRIBUTING.md file.


[HotFix] Updated Emote Clue Items to v4.0.3.

This patch features the following updates.
Adjusted imports after recent changes in RuneLite API. (see https://github.com/larsvansoest/emote-clue-items/issues/76)
Updated to RuneLite version 1.9.4.

Hey, this still isn't available on the hub for me. Has the named changed?


Detect waypoint too far (to close) issue before start mission

Hello all. Please help me with the question.
I uploaded the mission and get the warning:
WARN  [navigator] First waypoint too far away: 1638 meters, 900 max.
Then I cannot start mission because this issue.
The problem is the result of function upload_mission_async() and armed() is still SUCCESS, but I cannot fly.
I wonder how to detect the issue and show message before I start mission in this case?
Please help me. Thanks very much.

@dangviethieu this is a protection against missions set up incorrectly.
You can change or disable the protection using these two params:
https://dev.px4.io/master/en/advanced/parameter_reference.html#MIS_DIST_1WP
https://dev.px4.io/master/en/advanced/parameter_reference.html#MIS_DIST_WPS

@julianoes Yes, thank sir 🙇
I mean that we still protect missions with two params, but how to get result is fail when upload mission in this case. The SDK should return fail result and message to user when it cannot fly.

The upload is valid because you might be uploading the mission at home before going to the place where you will fly.
The protection is exactly against that case when you upload a mission in one place and then try to fly in another place.
I do agree though that the the mission start command should fail. I assume it does not?

I do agree though that the the mission start command should fail. I assume it does not?

Given the "but I cannot fly.", I would assume that start_mission fails, which is expected :blush:.

I wonder how to detect the issue and show message before I start mission in this case?

You can check that from your code: get the first waypoint, get the current drone position, and compute the distance. In the case of PX4, you can even use the param plugin to get the params @julianoes referenced above and act accordingly :+1:.

@julianoes @JonasVautherin Yes I got it
I think we need start_mission fails in this case.
And about protection is exactly against, I will check distance in my code
Thanks very about the reply 🙇♂

@JonasVautherin Could we get params of PX4 from our MAVSDK code?

Could we get params of PX4 from our MAVSDK code?

Yes, the param plugin of MAVSDK is there for that :wink:


Journalator error when processing a Public Engineering Crafting Order (on 10.1.5)

Please include as much of the following information as possible to help me fix the bug:
Brief Description of Bug
I actually found an Engineering Public Crafting Order I could complete.
Steps to Reproduce
Create an Engineering Public Crafting Order
Loaded Addons
Auctionator, Skillet, Journalator, and many others (if you really need the list, let me know and I'll create one).
Back Trace (LUA Error Output)
2x ...urnalator/Source/Monitor/CraftingOrderFulfilling.lua:16: table index is nil
[string "@Journalator/Source/Monitor/CraftingOrderFulfilling.lua"]:16: in function <...urnalator/Source/Monitor/CraftingOrderFulfilling.lua:13>
[string "=(tail call)"]: ?
[string "@Journalator/Source/Monitor/CraftingOrderFulfilling.lua"]:182: in function `ProcessReagents'
[string "@Journalator/Source/Monitor/CraftingOrderFulfilling.lua"]:198: in function <...urnalator/Source/Monitor/CraftingOrderFulfilling.lua:196>
Locals:
array =  {
1 =  {
}
}
toExclude =  {
1 =  {
}
}
hits =  {
}
(for generator) =  defined =[C]:-1
(for state) =  {
1 =  {
}
}
(for control) = 1
_ = 1
item =  {
quantity = 1
itemID = 203402
}
(*temporary) = nil
(*temporary) = 1
(*temporary) =  {
quantity = 1
itemID = 203402
}
(*temporary) = nil
(*temporary) = "table index is nil"

I completed four public orders and all produced the same error. I then completed two guild orders with no errors.
The public orders were for a Gnomish Voicebox with the customer supplied reagent, a broken Gnomish Voicebox.

I got this same error today when completing inscription treatise through guild orders. Here is an example of the Bug Sack capture:
1x ...urnalator/Source/Monitor/CraftingOrderFulfilling.lua:16: table index is nil
[string "@Journalator/Source/Monitor/CraftingOrderFulfilling.lua"]:16: in function <...urnalator/Source/Monitor/CraftingOrderFulfilling.lua:13>
[string "=(tail call)"]: ?
[string "@Journalator/Source/Monitor/CraftingOrderFulfilling.lua"]:182: in function `ProcessReagents'
[string "@Journalator/Source/Monitor/CraftingOrderFulfilling.lua"]:198: in function <...urnalator/Source/Monitor/CraftingOrderFulfilling.lua:196>
Locals:
array =  {
1 =  {
}
2 =  {
}
3 =  {
}
4 =  {
}
}
toExclude =  {
1 =  {
}
2 =  {
}
3 =  {
}
4 =  {
}
5 =  {
}
}
hits =  {
}
(for generator) =  defined =[C]:-1
(for state) =  {
1 =  {
}
2 =  {
}
3 =  {
}
4 =  {
}
5 =  {
}
}
(for control) = 1
_ = 1
item =  {
quantity = 10
itemID = 190456
}
(*temporary) = nil
(*temporary) = 1
(*temporary) =  {
quantity = 10
itemID = 190456
}
(*temporary) = nil
(*temporary) = "table index is nil"

I got the same error at the same time for 3 guild treatise and a public enchanting order. The majority of the error capture is identical with only the itemID changing.

Thanks for the bug report. I've added a fix into 1.52 will be available shortly.


Define stdin & stdout for Mbed

Specifically, Arduino Nano 33 BLE, Arduino Nano RP2040 Connect, and Raspberry Pi Pico

bcc2ef7 added support for RP2040. The Arduino Nano 33 BLE is still locking up the USB port.


cant even build kade engine 1.8

when i type "lime build windows" it says "Error: Could not find haxelib "extension-webm", does it need to be installed?" when i try to
"lime rebuild windows" it says "Error: Could not find haxelib "extension-webm", does it need to be installed?"
and when i try "haxelib git extension-webm https://github.com/KadeDev/extension-webm" it says "You already have extension-webm version git installed.
Updating extension-webm version git ..."
and it just freezes on "Updating extension-webm version git..." forever

btw heres a screenshot

lol this is crazy bro just try to build kade engine 1.5.2-

The error says extension-webm isnt installed for rebuilding. Reinstall extension-webm, then rebuild.

The error says extension-webm isnt installed for rebuilding. Reinstall extension-webm, then rebuild.

'when i try to install it it just freezes on updating extension-webm tho i dont have it


Adding Support for bitcoincash: URI on Private Keys

So back when BTC was my main coin and I was using Mycelium as my wallet, I pit my private key on a NFC tag encrypted ofcourse, I'd be able to scan the tag and mycelium would open up and sweep the private key.
However when I do this on the Bitcoin.com wallet with BCH you get a invalid private key error I think this is due to the bitcoincash: URI before it. Is there any chance that this can be fixed at all? Be cool if it can. :)

Hello,
This is something we have in the future roadmap, and is coming soon, but unfortunately i do not have an ETA on when this would be available. We have a lot of other tools and services we wish to introduce to the wallet first.

Sveiki,
tai yra kažkas, ką turime būsimoje gairėje ir ji bus netrukus, bet, deja, neturiu ETA, kada tai būtų galima gauti. Mes turime daugybę kitų priemonių ir paslaugų, kurias pirmiausia norime supažindinti su pinigine.

Pavogei mano pinigine

Good Idea


unicorn/prefer-native-coercion-functions doesn't work well with typescript and should be disabled.

The Boolean part of this rule and the auto fix break my code, because they don't work well with typescript.
I write this:
const testArray = ['test', null];

const output = testArray.filter((value): value is string => Boolean(value));

and it converts it to this:
const testArray = ['test', null];

const output = testArray.filter(Boolean);

This is not the same. The type of output is Array<string> in my code and Array<string | null> in the 'autofixed' code.

It seems there is an open issue for this: https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1857
Alternative option is to use isBoolean from isntnt, which is typeguarded.
But it seems that, until that issue is fixed, we should disable it.

Typescript now infers type predicates properly, but with this change I think we should disallow the use of the Boolean constructor as an argument for the Array.filter function.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/#inferred-type-predicates


Support for setting the remote address of a transaction via the public api

What does this PR do?
Adds support for setting the remote address of a transaction via the public api
Checklist

[x] This is an enhancement of existing features, or a new feature in existing plugins

[x] I have updated CHANGELOG.asciidoc
[ ] I have added tests that prove my fix is effective or that my feature works
[x] Added an API method or config option? Document in which version this will be introduced
[x] I have made corresponding changes to the documentation

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-03-17T11:27:52.602+0000

Duration: 3 min 23 sec

Pipeline error

  This error is likely related to the pipeline itself. Please go to the traditional console output here"
  You will see the error (either a wrong syntax or configuration)

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

ping

ping

superseded by #2513

ping

ping

Hi @tobiasstadler, could you give a little detail on why this feature addition is useful? We're more focused on enhancing our support of OpenTelemetry so that eventually that provides the API for the agent, but we can add to the existing API if it's useful and simple

I would like to record the "client ip" in my ejb plugin (https://github.com/tobiasstadler/apm-wildfly-remote-ejb-plugin). From time time I have the need to filter my transactions based on the service (which in our case is mostly identical with the client ip) that is calling my service. right now this is hard to accomplish reliably fro me.

Thanks. Couple of things.
We think that if the transaction api is used to set the remote address, then that should take precedence over any discovered address - even if the transaction sets it to null or empty string. I think atm the final value would just be down to the order of setting
Secondly, could you add a test?


Make everything responsive

I need to verify every page is responsive

I'd like to work on this

go for it

I made everything responsive


edits to kafka inputFormat

Editorial, style, and format fixes to Kafa inputFormat docs.
cc: @loquisgon
This PR has:

[x] been self-reviewed.

CI failure looks unrelated (docs checks are passing) so we can ignore it


Multiple: Hard-wire values for construct_array calls

JIRA: MADLIB-1185
Original investigation and RCA performed by
Nikhil Kak<EMAIL_ADDRESS>and
Orhan Kislal<EMAIL_ADDRESS>Multiple modules called get_typlenbyvalalign in the constructor of a
struct, which led to querying the catalog during dlopen. This is frowned
down upon [1] and the problem got exposed in PG10. This commit provides
a temporary solution by hard-wiring the necessary values. This is OK in
these scenarios, since the types used are INT4, INT8 and FLOAT8, all
with fixed, stable storage and alignment patterns. Ideal solution to the
problem is to use MADlib's Allocator::allocateArray instead of the
construct_array functions.
[1] https://www.postgresql.org/message-id/96420364a3d055172776752a1de80714%40smtp.hushmail.com
Closes #219

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/316/

LGTM +1


typo: Double word "before"

@nschonni : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.


add mafft

mafft is https://mafft.cbrc.jp/alignment/software/

@robertaboukhalil thanks the instructions at https://github.com/biowasm/biowasm/pull/94

Thanks @orangeSi, at a glance this looks great, thank you! I'll test it more extensively in the coming days.

Update: I should have time to review by this Friday.

@orangeSi This has been deployed: https://biowasm.com/cdn/v3/mafft/7.520, thanks so much for your contribution!


Interface asgi error with django

Great project, was trying to run with django got some error

    logs

myproj_local_django  | Running migrations:
myproj_local_django  |   No migrations to apply.
myproj_local_django  | [INFO] Starting granian
myproj_local_django  | [INFO] Listening at: <IP_ADDRESS>:8000
myproj_local_django  | [INFO] Spawning worker-1 with pid: 9
myproj_local_django  | INFO 2023-05-27 15:11:17,234 serve 9<PHONE_NUMBER>15840 Started worker-1
myproj_local_django  | INFO 2023-05-27 15:11:17,234 serve 9<PHONE_NUMBER>15840 Started worker-1 runtime-1
myproj_local_django  | WARNING 2023-05-27 15:11:28,481 callbacks 9<PHONE_NUMBER>15840 Application callable raised an exception
myproj_local_django  | Exception ignored in: <coroutine object application at 0x7f3fe1deba60>
myproj_local_django  | Traceback (most recent call last):
myproj_local_django  |   File "/app/config/asgi.py", line 36, in application
myproj_local_django  |     await django_application(scope, receive, send)
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/core/handlers/asgi.py", line 154, in __call__
myproj_local_django  |     async with ThreadSensitiveContext():
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 127, in __aexit__
myproj_local_django  |     SyncToAsync.thread_sensitive_context.reset(self.token)
myproj_local_django  | ValueError: <Token var=<ContextVar name='thread_sensitive_context' at 0x7f3fe3d790d0> at 0x7f3fe1c8e680> was created in a different Context
myproj_local_django  | ERROR 2023-05-27 15:11:28,530 log 9<PHONE_NUMBER>68064 Internal Server Error: /
myproj_local_django  | Traceback (most recent call last):
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 534, in thread_handler
myproj_local_django  |     raise exc_info[1]
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 43, in inner
myproj_local_django  |     response = await get_response(request)
myproj_local_django  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/utils/deprecation.py", line 148, in __acall__
myproj_local_django  |     response = await sync_to_async(
myproj_local_django  |                ^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 479, in __call__
myproj_local_django  |     ret: _R = await loop.run_in_executor(
myproj_local_django  |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
myproj_local_django  |     result = self.fn(*self.args, **self.kwargs)
myproj_local_django  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 538, in thread_handler
myproj_local_django  |     return func(*args, **kwargs)
myproj_local_django  |            ^^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/middleware/locale.py", line 35, in process_request
myproj_local_django  |     translation.activate(language)
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/utils/translation/__init__.py", line 181, in activate
myproj_local_django  |     return _trans.activate(language)
myproj_local_django  |            ^^^^^^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/utils/translation/trans_real.py", line 303, in activate
myproj_local_django  |     _active.value = translation(language)
myproj_local_django  |     ^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/local.py", line 111, in __setattr__
myproj_local_django  |     storage = self._get_storage()
myproj_local_django  |               ^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/local.py", line 83, in _get_storage
myproj_local_django  |     setattr(context_obj, self._attr_name, {})
myproj_local_django  | AttributeError: 'NoneType' object has no attribute '_asgiref_local_impl_139912375751504_IvidgRsU'
myproj_local_django  | WARNING 2023-05-27 15:11:28,552 callbacks 9<PHONE_NUMBER>15840 Application callable raised an exception
myproj_local_django  | Exception ignored in: <coroutine object application at 0x7f3fe1ca8040>
myproj_local_django  | Traceback (most recent call last):
myproj_local_django  |   File "/app/config/asgi.py", line 36, in application
myproj_local_django  | ERROR 2023-05-27 15:11:28,592 log 9<PHONE_NUMBER>68064 Internal Server Error: /favicon.ico
myproj_local_django  | Traceback (most recent call last):
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 534, in thread_handler
myproj_local_django  |     raise exc_info[1]
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 43, in inner
myproj_local_django  |     response = await get_response(request)
myproj_local_django  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
myproj_local_django  |     ^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/local.py", line 111, in __setattr__
myproj_local_django  |     storage = self._get_storage()
myproj_local_django  |               ^^^^^^^^^^^^^^^^^^^
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/local.py", line 83, in _get_storage
myproj_local_django  |     setattr(context_obj, self._attr_name, {})
myproj_local_django  | AttributeError: 'NoneType' object has no attribute '_asgiref_local_impl_139912375751504_IvidgRsU'
myproj_local_django  |     await django_application(scope, receive, send)
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/django/core/handlers/asgi.py", line 154, in __call__
myproj_local_django  |     async with ThreadSensitiveContext():
myproj_local_django  |   File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 127, in __aexit__
myproj_local_django  |     SyncToAsync.thread_sensitive_context.reset(self.token)
myproj_local_django  | ValueError: <Token var=<ContextVar name='thread_sensitive_context' at 0x7f3fe3d790d0> at 0x7f3fe0c567c0> was created in a different Context

Here's how I run granian
exec granian --interface asgi config.asgi:application --host <IP_ADDRESS>

and here's my asgi.py
"""
ASGI config for Myproj project.

It exposes the ASGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/dev/howto/deployment/asgi/

"""
import os
import sys
from pathlib import Path

from django.core.asgi import get_asgi_application

# This allows easy placement of apps within the interior
# myproj directory.
BASE_DIR = Path(__file__).resolve(strict=True).parent.parent
sys.path.append(str(BASE_DIR / "myproj"))

# If DJANGO_SETTINGS_MODULE is unset, default to the local settings
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "config.settings.local")

# This application object is used by any ASGI server configured to use this file.
django_application = get_asgi_application()
# Apply ASGI middleware here.
# from helloworld.asgi import HelloWorldApplication
# application = HelloWorldApplication(application)

# Import websocket application here, so apps from django_application are loaded first
from config.websocket import websocket_application  # noqa isort:skip

async def application(scope, receive, send):
    if scope["type"] == "http":
        await django_application(scope, receive, send)
    elif scope["type"] == "websocket":
        await websocket_application(scope, receive, send)
    else:
        raise NotImplementedError(f"Unknown scope type {scope['type']}")

Runs perfectly fine with uvicorn, daphne or nginx unit. Also runs fine with granian's wsgi interface.

@Hisham-Pak is that granian 0.4.2? if so, can you make a try with 0.3.2?

@gi0baro works fine with 0.3.2

It seems the loop optimisations introduced with 0.4 do not play well with how Django uses contextvars.
I gonna release a 0.4.3 in the following days with an option to disable 'em, in the meantime you can pin 0.3.2.
I'll consider to turn those optimisations off by default in next minor, but let's see how it goes.

0.4.3 will be available shortly.
You should be able to use ASGI on django adding a --no-opt option to the granian command.


bump restart process ext

pull in changes from https://github.com/tilt-dev/tilt-extensions/pull/167

LGTM
though I still don't really understand why we're vendoring these, given the desire to get the latest version every time

Oh whoops I honestly did this on autopilot. It would make the tests a bit slower but they run so infrequently that that's probably fine?


feat: add missing stories

Notes for Reviewers
This PR fixes #60
Components covered

[x] Accordion
[x] Avatar
[x] Backdrop
[x] Badge
[x] Box
[x] ButtonGroup
[x] Card
[x] Select
[x] Dialog

Signed commits

[x] Yes, I signed my commits.

@kunal70006 good stuff

I also converted all stories to ts just so we can get more controls and stuff

@nebula-aac you can review this one now, i'll update the description to add the list of components that i covered

okay, ill provide my feedback

hey @kunal70006
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

hey @Ghat0tkach I think it's already added in the word doc, do I need to do anything else? Also, can you tell me how long the meeting actually lasts because I've a blocker around 6PM IST/7:30AM CST(i think) so I'm only available from 7-7:30 Central

At this time, the design system isn't working for me. I'm creating another PR to convert the entire design system to Typescript from scratch.

what errors are you facing? do you want to discuss?


Make ActionFilter for simple filtering required by spec

Per section "Filtering", simple value filtering should be possible via the query string. Seems the place to add this would be via an ActionFilterAttribute subclass that could be used to decorate ApiController::Get() @csantero says he already has a basic implementation that may be adaptable here. See discussion in #7.
Suggest that in addition to single values, we also support comma-separated values--this should be easy and cheap to implement.

I'll try to whip up a PR for this today.
To clarify, when you mention comma-separated values, you're saying that the following query:
GET http://localhost/posts?title=foo,bar

should return posts whose title is either foo or bar? What about values that have a comma in them? Seems like that would need to be double-encoded. Would this be better instead?
GET http://localhost/posts?title=foo&title=bar

As an aside, is ember-data capable of performing queries in this manner?

Right, that's it, an "or" operation. The thought process is that I was wondering if we could leverage the same or similar ActionFilter to handle multiple-ID selection, which is like /posts/1,2,3. Right now that logic is in ApiController::Get(string id), and it makes it hard to override that method without losing the multiple-ID request feature--so I wondered if an ActionFilter on ApiController::Get() would be the way to go there as well.
FWIW, I think older versions of Ember Data actually did multiple id resolution as ids=1,2,3 by default. As for right now, while I don't think Ember Data will automatically do this for any reason, you can use fetchQuery and pass whatever parameters you want. And, off the top of my head, I'm not sure if you can make that mechanism issue the ?title=foo&title=bar format, since you mentioned it (maybe, if you pass title: ['foo','bar']?).
One use-case I had in mind was enums, for instance I have a ticket system with six severities for tickets, 0-5, where 0 is used for dismissed tickets. Right now, to show active tickets, I use an OData query for severity != 0...but I could do severity=1,2,3,4,5 to achieve the same result.
Commas in the value is a very good point. I asked the question about the escaping mechanism for the spec itself in an issue something like a year ago, which is not a simple issue because you can't just URLEncode it! I'll go dig that up because I don't remember what the answer was. The context then was what about IDs with commas in them (e.g. coordinates), and now the spec says that IDs SHOULD only contain alphanumerics, hyphens and underscores...but I suppose that means the question still remains.

On Jan 20, 2015, at 4:38 PM, Chris Santero<EMAIL_ADDRESS>wrote:
I'll try to whip up a PR for this today.
To clarify, when you mention comma-separated values, you're saying that the following query:
GET http://localhost/posts?title=foo,bar
should return posts whose title is either foo or bar? What about values that have a comma in them? Seems like that would need to be double-encoded. Would this be better instead?
GET http://localhost/posts?title=foo&title=bar
As an aside, is ember-data capable of performing queries in this manner?
—
Reply to this email directly or view it on GitHub.

I'd definitely like this feature too, but for now I think the most important thing is to get single-value filtering in. We can revisit OR-matching in a later PR.

Okay, I researched the comma-escaping question...it was never answered. I've asked to reopen my original issue WRT commas in the ID from nearly two years ago because it still isn't actually answered.
That said, while I was thinking about it, I've unfortunately decided that supporting comma-separated query values is probably a bad idea. Consider your question about what if a value has a comma in it? Well, if it does, and the user is querying for multiple values, fine, we need some rule for them to escape the comma--since we're going above and beyond the spec that's reasonable. However, if they query for only the single value, we would require them to escape the comma in that situation too...which makes us non-compliant with the spec because the unescaped comma is a valid request.
So unfortunately, I probably just need to wait to solve #15 for this use case. I'll strike it from the issue.

@SphtKr I think we can close this, right?

Was leaving it open to see if we could add support for filtering on object IDs after the ModelManager refactor. Now it should be easy to derive the Id property from within the action filer and add it to the linq expression, right?

Yeah, but now we have to get the ModelManager into the attribute instance. We can do this easily if you're adding the attributes programmatically, like so:
var pluralizationService = new PluralizationService();
var modelManager = new ModelManager(pluralizationService);

var formatter = new JsonApiFormatter(pluralizationService);
config.Formatters.Clear();
config.Formatters.Add(formatter);

config.Filters.Add(new EnableFilteringAttribute(modelManager));

but I think this makes it impossible to add the attribute directly to an action method. Do we care?

Actually I think IFilterProvider is what we want here. I'll look more into that.

Wait, I thought you already had a reference to the Formatter available in OnActionExecuted? Is that not the same formatter? If it is you can just access it's ModelManager property.

Speaking of which, I need access to ModelManager from within MetadataManager to do the conditional relationship serialization, so if we need to make it more generally accessible somehow, that might be good.

Wait, I thought you already had a reference to the Formatter available in OnActionExecuted? Is that not the same formatter? If it is you can just access it's ModelManager property.

Oh, yeah I guess that could work.

Wait, I thought you already had a reference to the Formatter available in OnActionExecuted? Is that not the same formatter? If it is you can just access it's ModelManager property.

Turns out this isn't reliable. My project uses the System.Web.Http.Diagnostics tracing library. That library wraps the media type formatter with its own formatter. So our filter can't rely on the ObjectContent.Formatter actually being our own JsonApiFormatter!
Looks like I have to do a filter provider after all.

Ugh...I definitely do think we need to be able to use this as an attribute. Also, the fundamental problem with constructor injection you're encountering has more facets. As I mentioned, I need MetadataManager to be able to find ModelManager's services, not to mention I need a user to be able to find MetadataManager's services. I suspect we'll hit more of these problems as we go, and we may need to look at a broader DI approach. Possibly MVC's already provided DependencyResolver? Or going all the way with Ninject or Castle Windsor? I've never actually used these before...using DependencyResolver is tempting because it doesn't require us to add another library dependency--if it meets our needs.


do you have objection detection .distiller demo?

You can use the demo code in FCOS. Our model can be directly loaded into the FCOS demo. If you have any questions, feel free to contact me.

hi irfan, could you provide the training code for fcos distilation

We do not have the plan for releasing fcos distilation recently. I use the training code of FCOS and insert the loss function of distillation. It is not very hard to reproduce. If you have any questions, feel free to contact me.


Clean up helm/config.go

The Config struct in internal/helm/config.go defines the interface between drone-helm3 and a project's Drone settings. As such, it should be clear and well-documented:

Remove the "Global helm config" and "Config specifically for helm upgrade" comments; they aren't particularly accurate
Make sure each struct field has a comment explaining what that setting does
Probably remove the custom decoder for helmCommand; that responsibility lies with the determineSteps function in internal/helm/plan.go.
Fix the inthe typo on line 8 🙃

Currently, there's some code that tries to guess which config fields might show up in the environment section of the consumer's .drone.yml, rather than the settings section. Those fields have to have an envconfig tag, so that envconfig will look for the non-prefixed form if it doesn't see a PLUGIN_ version.
It probably makes more sense to allow all fields to come from a non-prefixed env var. It should be a small change to cmd/drone-helm/main.go. After calling envconfig.Process("plugin", &c), call it again with an empty string for the prefix: envconfig.Process("", &c)
Make sure to confirm that

an empty-string prefix looks for ENV_VAR_NAME, not _ENV_VAR_NAME
if the prefixed form is present, but the non-prefixed form is empty, the second call to envconfig.Process won't stomp on the populated value.


Source map mappings is sometimes empty

Bug Report

🔎 Search Terms

source map empty mappings
🕗 Version & Regression Information

This is the behavior as far back as TypeScript 3.3

⏯ Playground Link

Playground link with relevant code
💻 Code

export type n = number

🙁 Actual behavior

The generated source map looks like this:
{
  "version": 3,
  "file": "input.js",
  "sourceRoot": "",
  "sources": [
    "input.tsx"
  ],
  "names": [],
  "mappings": "",
  "sourcesContent": [
    "export type n = number\n"
  ]
}

🙂 Expected behavior

I expected something like this instead:
{
  "version": 3,
  "file": "input.js",
  "sourceRoot": "",
  "sources": [
    "input.tsx"
  ],
  "names": [],
  "mappings": "AAAA",
  "sourcesContent": [
    "export type n = number\n"
  ]
}

The problem is that TypeScript generates an empty mappings value. This causes tools such as esbuild that process source maps to not carry through any mappings when the input is bundled with source maps enabled. The end user visible effect of this is a user using tsc to compile TypeScript to JavaScript, bundling the JavaScript with esbuild, and then being confused why there are intermediate build files in the final source map instead of the original TypeScript files. This was reported to me as a bug in esbuild (https://github.com/evanw/esbuild/issues/2767) but I think it should be considered a bug in TypeScript instead. My rationale:

The content in the sources array is only ever referenced by the "zero-based index into the sources list" in a mapping. So if there are no mappings, then there is no reference to the sources array for esbuild to carry forward, and the name in the sources array will never be included.

It would be incorrect for esbuild to assume that if there are no mappings but there is a single entry in the sources array, then esbuild should automatically generate a mapping from the start of the output code to the start of that single source. This is because esbuild doesn't have enough information to know whether the content of the source file is related to the code in the output or not. The code in the output could be entirely unrelated to the source file (one example scenario: https://github.com/evanw/esbuild/issues/2767#issuecomment-1364177552).

Arguably the module shim output that TypeScript generates even when the file is empty ("use strict", __esModule, etc.) should still be associated with the input source file in TypeScript's source map, since TypeScript is processing each file one-at-a-time so all code it generates relates to the input source file. It's ok for the mappings value to be empty if the output is empty (since there is nothing to map), but if the output is non-empty then I'd expect for mappings to also be non-empty.

I'm primarily reporting this for your awareness. You could also argue that the source map TypeScript generates should have an empty mappings value because none of the statements in the file made it into the final output, and the fact that the source file is missing from the final bundled source map is actually correct. If so, then feel free to close this issue.

Hello 👋,
I made a PR #52355 fixing this issue (at least trying to) .
I still need to check a lot of failing tests, but before that I would like to be sure this is the right way.
Can someone take a look at this?
Thanks!


Allow the SAC and asset to be identifiable from events

To avoid storing a mapping between contract id and the Asset, Horizon needs some way to identify if a contract event was emitted by the SAC, and which asset it belongs to using only the event. @tamirms has a PR that accomplishes this by including the issuer and symbol in the event body here, but this isn't ideal because it changes the format of the data.
Two alternatives we should explore -

Increase the Bytes limit on topics from 32 and put the asset information in the topics. This will allow consumers to query for the asset information if they'd like, but the body of the data will remain the same.
Update the ContractEvent xdr to store a SAC type along with asset information. This is more difficult to implement than the first option.

this isn't ideal because it changes the format of the data.

Why is that a problem?

this isn't ideal because it changes the format of the data.

Why is that a problem?

It special cases events that should be standard. For example, users will have to parse the transfer event data differently for the SAC vs a custom WASM token.

Resolved by https://github.com/stellar/rs-soroban-env/pull/705


test/e2e: libvirt: Try and reduce the resource usage of the kcli cluster

At the moment in the libvirt testing we are using the default node size. This leads to the situation were each of the work and control-plane defaults uses 4 vCPU and 6GB RAM:
# kcli info vm peer-pods-worker-0
name: peer-pods-worker-0
id: a5ce3795-a67c-4daf-854d-62df6736081b
creationdate: 09-10-2024 10:35
status: up
autostart: False
image: ubuntu2204
user: ubuntu
plan: peer-pods
profile: kvirt
numcpus: 4
memory: 6144

In an ideal world we'd like to reduce our test footprint to fit inside the github hosted runner, which is a 4x16GB machine.
Our peer pod VM is currently using 2x8GB of it's own, which we are working on reducing, but the 8 vCPU and 12 GB RAM that the kcli cluster uses is way to big. Actually reducing this shouldn't be too tricky as I think it's just editing the default parameters we pass in in kcli_cluster.sh, but the tricky bit is working out the minimum resources we can get away with without impacting the tests, so looking at the resource usage on an existing cluster might help there.

@wainersm, @mkulke do you know the size of the az-ubuntu-2204 (that I think are created by garm) at the moment as a reference point?

@wainersm, @mkulke do you know the size of the az-ubuntu-2204 (that I think are created by garm) at the moment as a reference point?

https://cloudprice.net/vm/Standard_D4s_v4

https://cloudprice.net/vm/Standard_D4s_v4

That's very interesting as if it's a 4x16 machine then it's the same size as the github hosted runners (and might explain some of the libvirt ci flakiness as we try and squeeze 10 vCPUs and 20GB RAM out of a 4x16 box! Maybe we can try out libvirt e2e on a self-hosted runner now... (I'll be back with results)

It failed (https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11331308718/job/31511037253) with:
time="2024-10-14T16:25:22Z" level=info msg="Installing peerpod-ctrl"
F1014 16:25:22.856817   22292 env.go:369] Setup failure: exit status 2
Error: No space left on device : '/home/runner/runners/2.320.0/_diag/pages/ca098555-ffe8-4649-a147-31a3909d57d3_9f5eba70-d33b-5377-96f2-d94c82946629_1.log'

The GH runners have 14GB of storage, so maybe that isn't enough, so it might be another path to investigate

It failed (https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11331308718/job/31511037253) with:
time="2024-10-14T16:25:22Z" level=info msg="Installing peerpod-ctrl"
F1014 16:25:22.856817   22292 env.go:369] Setup failure: exit status 2
Error: No space left on device : '/home/runner/runners/2.320.0/_diag/pages/ca098555-ffe8-4649-a147-31a3909d57d3_9f5eba70-d33b-5377-96f2-d94c82946629_1.log'

The GH runners have 14GB of storage, so maybe that isn't enough, so it might be another path to investigate

currently we build the kbs client with rust, which can produce a surprisingly large target folder. we could either clean that up or download the kbs-client via oras?

download the kbs-client via oras

Yeah, I think that would be great. I'll try out the e2e tests without the KBS section and see if that helps.

Ooh - cutting out the KBS deployment and test meant the gh-runner tests worked: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11331632234/job/31512084686 😃

that's great. if we change this line:
https://github.com/confidential-containers/cloud-api-adaptor/blob/7a784255db24d55578783e4d025f9aea114d5819/src/cloud-api-adaptor/test/utils/checkout_kbs.sh#L28
to
oras pull "ghcr.io/confidential-containers/staged-images/kbs-client:sample_only-x86_64-linux-gnu-${KBS_SHA}"
chmod +x ./kbs-client

we can also drop the rust toolchain installation

Cool - I'll give that a try in my fork

TestLibvirtKbsKeyRelease/KbsKeyReleasePod_test failed trying that approach: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11342464633/job/31542928046
When I get a chance I'll try and re-create and debug locally

TestLibvirtKbsKeyRelease/KbsKeyReleasePod_test failed trying that approach: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11342464633/job/31542928046
When I get a chance I'll try and re-create and debug locally

hmm I've never tested it either, the whole kbs-client business is a bit of a black box to me, so the available binary might not work. an alternative would be to build the kbs-client in another job and pass it around as an artifact.
upside: faster builds, b/c it can be built in parallel before the test; doesn't consume space on the test instance
downside: checkout-kbs.sh needs untangling, since it performs both cloning of the kbs repo and building of the kbs client

Ah - the kbs client is extracted to the wrong directory as it's build to targets/release. I'll try and fix that and see if that helps. I also want to understand why we aren't hitting errors in the e2e tests first trying to use a non-existing file?

I also want to understand why we aren't hitting errors in the e2e tests first trying to use a non-existing file?

So we just ignore any errors thrown in the kbs client code. I thought I remembered fixing that, but https://github.com/confidential-containers/cloud-api-adaptor/pull/2055/files hasn't merged yet.

(T)he kbs client is extracted to the wrong directory as it's build to targets/release.

I think we just move the expectation for the client to be in kbs directly, but I'm not sure if anyone would still want to build their own version of it


Getting error on retrieving data

I am getting a error when i am using bool or integer as data type of a attributes , its save to the data without showing any errors but then i am trying to retrieve the data its give me a error saying NSUnknownKeyException this class is not key value coding-compliant for the key
this is my class
class Message: NSObject,Storable{

    let database: SwiftyDB! = SwiftyDB(databaseName: AppConfig.DATABASE_NAME)

    var id : String?
    var body : String?
    var status : String?
    var timestamp : String?
    var isHide : Bool?
    var location : String?
    var msgType : String?
    var roomId : String?
    var userId : String?

    override required  init() {
        super.init()
    }

    func saveMesssage(shouldUpdate: Bool = false, completionHandler: (success: Bool) -> Void) {
        database.asyncAddObject(self, update: shouldUpdate) { (result) -> Void in
            if let error = result.error {
                print(error)
                completionHandler(success: false)
            }
            else {
                completionHandler(success: true)
            }
        }
    }

}

can anybody tell me what i am doing wrong here

Hello!
Unfortunately, Swift properties aren't key value coding compliant, so all your property types needs to be representable in ObjC when retrieving objects.
Bool? is not a valid ObjC type. I would recommend using either NSNumber?, or Bool instead.
If you need Bool?, you can use dataForType: to get the objects as dictionaries. You can map the dictionary to your object manually, or by using a JSON mapping  library. Both should be relatively straight forward :)
Hope this helps you sort it out :)

Thank you i also have one other problem can we use DISTINCT , group by in swiftdb ?

No problem.
DISTINCT and GROUP BY are not supported yet. If you need them, please create issues requesting the features, and they will be added in a future update


core changes made for Florence

I compared the Florence-2018 branch to the master branch and pulled in all changes except the additions of non-example files, .ind files, and build/status/*.yml files. I think this is probably good to go, but another set of eyes doing a quick skim would be useful to make sure I didn't add in anything that would get in the way of future vizzies.

Jordan votes for Insta portrait dimensions as our one and only format. Instagram max portrait size is 1080px x 1350px, but 720 width x 900 height worked well for Florence (and produces smaller / quicker-loading files)


Add armeria-logback14

Motivation:
The current armeria-logback module contains an api logback1.2 dependency declaration.
This essentially means that whatever project uses armeria-logback will have logback1.2 in its runtime dependencies by default.
This may be inconvenient for users who wish to use logback1.3, logback1.4. This is especially a problem since logback1.2 is not under active development anymore.
I propose that we add the logback14 module.
Modifications:

Modified logback13 to also copy over and run tests from armeria-logback
Added a logback14 module, which also copies over source and tests from other modules
Migrated logic from logback to logback12, now the logback module only exists for backwards compatibility
The directory structure is modified to the following:

hannam@AL01325349 armeria % tree -L 1 -- logback
logback
├── logback
├── logback12
├── logback13
└── logback14

5 directories, 0 files
hannam@AL01325349 armeria %

Result:

Better compatibility with logback

Should we deprecate :logback and add :logback12 instead? (We publish both for a while and then publish only :logback12 after then)

Updated 😄

🚀 🚀 🚀


Add additional colours

Red is regarded as the best colour for dark adaption, but there are cases where full colour control is useful and it would be good to have full RGB adjustment.

Just seconding this, it would be good for me. I'm using RedScreen to reduce exposure to blue light in the evening, to help with sleeping. But full red is a bit much. It might be nice to have a "color temperature" slider, the way f.lux does? Or RGB could also be fine. F.lux is good, but it lacks the dimming control of RedScreen, especially on external screens. Thanks!

this seems old but i third this? would be very useful


onChange event is sent before the font is loaded

Hey @samuelmeuli ,
Thanks for the great tool, very useful !
I am trying to use it in a demo with a canvas, so the onChange event seems perfect to re-render the canvas after the font is changed.
But that does not work as the event is fired before the font is fetched.
I have tried to dig in the code if it is expected behavior or issue.
The code here feels like the event should be fired after font is loaded:
https://github.com/samuelmeuli/font-manager/blob/fd522c973b06903e59b9fe756727100d993c8dad/src/FontManager.ts#L182
But inside that function, loading is not made async:
https://github.com/samuelmeuli/font-manager/blob/b11dce5cda750a2619e37581d3f2b2d19eefd010/src/loadFonts.ts#L79
What's your thoughts on this ?
Thank you!
Emmanuel

Sorry, I've fond the answer in the last issues ...
I put it here for reference:
https://github.com/samuelmeuli/font-picker-react/issues/17
https://stackoverflow.com/questions/5680013/how-to-be-notified-once-a-web-font-has-loaded/32292880#32292880


Addition of annotations for pods/components supplied via network.yaml - Fabric

Is your feature request related to a problem? Please describe.
Kubernetes components rely on annotations to perform additional tasks. For example, HAPROXY uses annotations to identify the sub-path where the server can play a proxy role. Similarly these annotations can be used on core blockchain components to manage the way they behave.
Describe the solution you'd like
An option to supply annotations from the input network.yaml and apply it on the deployed components. Pass them via the HelmRelease.
Describe alternatives you've considered
Post deployment of BAF, identify the resources and annotate the resources.
Additional context
NA

Hi @arsulegai , just to know, which type annotations are you expecting to have? I think the solution could be adding an annotation section in the network.yaml and specify them there. Will be working on this in the next days

Hi @alvaropicazo,
I was thinking of making this a generic feature, to give flexibility for somebody to add their own annotations. These annotations can be supplied from network.yaml as an input. Here is an example that I was considering
Possibility 1:
network:
  env: dev
  annotations-enabled: true
  ...

# applicable when the network setup is requested.
# user shall specify that custom annotations are enabled at the network level.
annotations:
  peers:
     peer1.example.org:
       - annotation-key1:value1
       - annotation-key2:value2
     peer2.example.org:
       - annotation-key1:value1
   orderers:
     orderer1.orderer-org.com:
       - annotation-key1:value1
   ca:
...

Possibility 2:
Pass the annotations as part of the current structure, within each organization where we pass peers information, orderers information, CA's information.
Any of these approaches is good to have. This feature will enable, the network setup through BAF to interoperate with advanced features for production management on K8s.

My initial idea was more like Possibility 2, but Possibility 1 could be also a nice one. Will discuss it with the team. Thank you @arsulegai !


Redefine allowEmptyValue

Currently the spec provides allowEmptyValue which is valid for query or formData parameters.
When sending query parameters, they can have no value (acting as a flag) or a an empty value. That is ?foo&bar or ?foo=&bar= respectively. Current spec doesn't allow specifying the difference
This issue is derived from #81.
Parent: #565.

@webron I think this has been handled in the 3.0 draft.  Can you please confirm?

Yes, it's indirectly explained (depends on style).


Windows 10 22H2 compatibility

Basic information

My operating system and version: Windows 10 enterprise
My MZmine version: 3.3.0

What happened
Hello,
We plan to migrate to Windows 10 22H2 and I wanted to know if my version of MZmine will still be supported?
thanks in advance,
best regards,
Quentin.

Hi,
yes, and I recommend to upgrade to 3.9.0
kind regards,
Ansgar


update /show to work like command line show

I really like the new
ollama show <model>

feature.
when running ollama from command line or url  it would be nice to be able to get the same type of info without actually loading the model and requesting all the individual sections.
Currently
>>> /show
Available Commands:
  /show info         Show details for this model
  /show license      Show model license
  /show modelfile    Show Modelfile for this model
  /show parameters   Show parameters for this model
  /show system       Show system message
  /show template     Show prompt template

I'm thinking something like
/show model <model>

for example would show the same as command line
ollama show llama3
  Model
  	arch            	llama
  	parameters      	8.0B
  	quantization    	Q4_0
  	context length  	8192
  	embedding length	4096

  Parameters
  	num_keep	24
  	stop    	"<|start_header_id|>"
  	stop    	"<|end_header_id|>"
  	stop    	"<|eot_id|>"

  License
  	META LLAMA 3 COMMUNITY LICENSE AGREEMENT
  	Meta Llama 3 Version Release Date: April 18, 2024

OR
/show model_json
which would show the same thing in json format.

I've been looking though the source code and I realised there are a number of improvements that could be made in this area.

/show gives family info (ie bert, llama,clip), ollama show should also give this info
In the source code is a function IsEmbedding() which will filter generate and chat. It would be nice to put this into the show commands (both /show model  and ollama show model
In the same vein as IsEmbedding() which just searches for keywords "bert" and "nomic-bert" to return true/false IsImageDetection() could be created which shows the "clip" family to indicate that the model can detect images.

Hey! Re 1. /show gives family info (ie bert, llama,clip), ollama show should also give this info, if you run ollama show llava you should see both llama and clip architectures like so:

In general, the architectures cover all the families. You can try for embedding models too.
For consistency with API info gonna hold off on 2 and 3 for now, but feel free to create a separate issue!