On mobile category products are shown as empty until loaded

Only visible on a very slow connection/docker but the 'whoops/empty' message is displayed by default until the products request has finished.
Problem is with this code in the velocity theme:
resources/themes/velocity/views/products/index.blade.php
Without the 'Loading...' code I've added below it reaches the end else statement first.
<shimmer-component v-if="isLoading && !isMobile()" shimmer-count="4"></shimmer-component>

    Loading...

<template v-else-if="products.length > 0">
    ...
</template>

{{ __('shop::app.products.whoops') }}

{{ __('shop::app.products.empty') }}

Hi @howdu,
Please refer to this issue i.e. https://github.com/bagisto/bagisto/issues/4269.


⚠ BCR Bot has degraded performance

In 5f213d5, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 908 ms

Resolved: BCR Bot performance has improved in 83b07fb.


feat(CategoryTheory/Category/RelCat): Show basic facts and self-duality of category of relations.

Add facts about rel somewhat like the facts about types, classify isos in rel, construct the inclusion from types to rel, show self-duality of rel.

WIP but I'd appreciate any comments in advance especially about the self-duality bits
TODO:

[X] products or coproducts

[X] the dual notion via the equivalence

[x] depends on: #11239

sorry for messing up the rebase, no idea what happened there I'll try to figure it out

Very weird things going on with git but it should be alright since it all gets squashed anyways

Thanks for the recommendation and sorry for yet another wait!

Thanks!
bors merge


为什么保存的模型权重不能再次用到训练中呢

我使用保存的权重和预训练权重作比对，内容不一致，该怎么解决呢

@xiachashuanghua
Hello! Which two sets of weights are you referring to? The pretrained weights are those obtained from training VMamba on ImageNet. The weights provided in the results are the ones that have been fine-tuned on downstream tasks, so they are definitely different.

训练完成后保存的best.pth无法在模型中当作预训练模型使用，这个问题怎么解决呢

@xiachashuanghua Hello! Which two sets of weights are you referring to? The pretrained weights are those obtained from training VMamba on ImageNet. The weights provided in the results are the ones that have been fine-tuned on downstream tasks, so they are definitely different.

确实遇到了这种问题，就是自己保存的训练后的权重，报错显示没有model,不能用 @xiachashuanghua

确实遇到了这种问题，就是自己保存训练后的权重，报错显示没有模型，不能用 @JCruan519

@sky1talent @sky1talent 直接load你保存的权重，注释掉加载预训练模型的代码不行吗？我自己的直接加载没问题的

请问问题解决了吗，我用保存的权重训练TPFP一直是0


Add validations and limit text field length

Added basic html 5 validations for the 4 input fields - username, time, interest, other.
Limits the username to 20 characters and is a required field

Included error message for time field if the input from the user does not match the pattern

**Limits the 'Interest' and 'Other' fields to 30 characters in length. Also these to fields are not mandatory. The user can submit the form even if they don't fill out these forms **

Now the text doesn't go out of screen area as the characters are limited. Hope this helps

Sounds great 👍 I'll test it soon.


Weird behavior with NavigatorIOS state updates

I am trying to load the locations data from AsyncStorage on componentDidMount for the component of NavigatorIOS, but it keeps showing the initial state empty response.  The data appears if I would push another View on the Stack, and then replace it.  Since, I am replacing instead of popping the View, it still keeps the old back button and title.
Here's the link to complete code -- https://github.com/opolyo01/locationTracker
I noticed there are similar issues were not answered on stackoverflow -- http://stackoverflow.com/questions/29622092/react-native-pass-data-between-sibling-views
Key snippets bellow:
componentDidMount(){
    AsyncStorage.getItem('listings')
      .then((value) => {
        this.state.listings = JSON.parse(value);
        this.state.passProps = {listings: this.state.listings};
        this.redrawListings(true);
      })
      .done();
  }

redrawListings(startWatch){
    //AlertIOS.alert('listings '+ this.state.listings.length);
    //this.refs.nav.pop();
    this.refs.nav.replace(this.state);
    if(startWatch){
      this.startWatch();
    }
  }

render() {
    return (
      <NavigatorIOS
        style={styles.container}
        ref="nav"
        initialRoute={this.state}/>
    );
  }

Adding componentWillReceiveProps method into Listings view controller made it update the view, and things now more logical.  I guess NavigatorIOS+ListView need a combination of componentWillReceiveProps and replace invocation.
componentWillReceiveProps(nextProps){
    this.state = {dataSource: this.state.dataSource.cloneWithRows(nextProps.listings)};
  }

@opolyo01 but, componentWillReceiveProps looks like it will not cause the second rendering


Add Surya model

Ticket: CVS-131138

In order to reuse surya-ocr package functions I implemented wrapper classes for ov model. This classes are fully depend on surya package internals. I fixed surya version to prevent possible inconsistency with surya package updates.

View entire conversation on ReviewNB


Normalize operations of the Get functions

The Get{repo, user, team} functions will throw when using Guid and will return null when used with string. This should be normalized to returning null.
This makes writing code that checks if the repo/user/team exists easier to write since the typical usecase is to check if the input from the user is good.

In what circumstances would you have an invalid Guid for a repo/user/team?

It's just the use case:
You are dealing with front-end code, so you do
if(Repo.GetRepo("some-repo-name-from-a-form") == null) // this works fine

Now you are on the back end and you got a guid from somewhere
if(Repo.GetRepo(some_foreign_guid) == null // this will not work but will also not complain

Until you exercise that code path there is no indication that the code you wrote is wrong.
And I think that to catch such silly mistakes unifying both would be a good idea.

Hmm.  I see your point, although I'm not really sure where the some_foreign_guid might come from - why would we be writing validations of guids anyway?
I would like code like this:  Repo.GetRepo(guid).Name to be correct, with an exception being thrown in the unlikely event that the guid is unknown to the system.   If  GetRepo(guid) can return null, every time you use it you should be adding a  (!= null) test.
Perhaps the real problem is that we're conflating two different operations - validating a name or a guid, and fetching a record from the database.
I do take your point about the inconsistency though - perhaps if we were to stick to the different behavious, then they should be given different names (like First() vs FirstOrDefault() in Linq)

Yeah, mayeb we should do something like bool TryGet("name", Model repo). I think this is very C# and would work for the string and make clear that it is different from just Get.

:+1: I know some people don't like out parameters to functions, but I like the idea of following the .NET TryParse idiom, which is a really good approximation of what we're doing.
In practice, I don't think we'll really need the Get(string) method, because we want to validate those things from strings as early as possible in a very small number of places and then pass them around as Guids everywhere internally.   But it would be an option.
At least being clear about what the contract of those various functions is will put us in a 10x better place than we were a month ago...


➕Feature: Adding Diagonal-Transitional Effect to "Each Profile Card"

Hey @sanjay-kv
I want to suggest a new feature for "Contributors" Page.
I Want to add a "Diagonal-Transitional" Effect Styling to each card of the Contributors.
Which means On hovering on Every card, The card will display a Transitional Effect
For ex.  Like this My prev Work-(I will follow better theme)
https://github.com/user-attachments/assets/b70c3c22-fc3f-4397-854f-53a413bf4d60
Current Contributor Cards -
https://github.com/user-attachments/assets/21249085-46ea-4d81-a951-0c2fc916c9d5
As you can see.
Please Assign me this issue.

i like the transitions, could you share the link of the finveda website.

@sanjay-kv
Here is the link : https://fin-veda.vercel.app/contributors.html

I will get back to you,


Link landing page to /stipendium and update scholarship count

Update number of awarded scholarships and link from landing page to /stipendium.

Does this close #46? Or just related?


feat(cake-icon): add cake icon

Adding the cake icon for the Tweniversary sale.
Thanks to Scott Gary and Zac Mau for flattening this icon.

Why didn't CI kick off on this PR?

LGTM :shipit:


Version 0.9.6 does not support DRF 3.3.X.

According to the compatibility list on pypi, version 0.9.6 supports DRF 3.1.X to 3.3.X. However, this does not match with requirements.txt:
https://github.com/djangonauts/django-rest-framework-gis/commit/b6549cbb298298a475a8105bfc9fb558d60aa335
What's the reason that this commit was reverted?

Because i discovered the issue described in #87

I started working on 3.3 and django 1.9 support and removal of obsolete python and django versions.

https://github.com/djangonauts/django-rest-framework-gis/pull/90 started

Everybody interested in django 1.9 support, follow #90.


dist.nuget.org download urls are case sensitive and inconsistent across versions

@AGBrown commented on Fri Dec 16 2016
Details about Problem
NuGet product used: NuGet.exe
NuGet version: various
Detailed repro steps so we can see the same problem
When downloading from https://dist.nuget.org/win-x86-commandline/<version>/NuGet.exe, the package naming is inconsistent with regard to case, but the web server is case sensitive. It is not possible therefore to write a simple script which can take a version parameter and insert it into the download url. For example, taking the most recent three versions and "latest" from https://dist.nuget.org/index.html

version
Pascal case
Lowercase

latest
✘ latest NuGet.exe
✓ latest nuget.exe

v3.5.0
✓ v3.5.0 NuGet.exe
✘ v3.5.0 nuget.exe

v3.4.4
✓ v3.4.4 NuGet.exe
✘ v3.4.4 nuget.exe

v3.3.0
✘ v3.3.0 NuGet.exe
✓ v3.3.0 nuget.exe

Suggestion for Fix

make the web server handler for nuget.exe download links case insensitive
if that is not possible then:

Future uploads to dist.nuget.org should be automated to ensure consistency
Both the lower and pascal case versions of all existing and future nuget.exe versions should be uploaded - standardising to lowercase will simply break things for half the nuget world and vice versa

And on a slightly flippant ending: it's lowercase in the text on the page at https://dist.nuget.org/index.html; the case varies in the download links; the case is pascal case in the page's title; and it is lowercase in the logo for nuget. I don't think there are enough standards here. Maybe we should adopt nUgET?

@emgarten commented on Fri Dec 16 2016
@AGBrown Thanks for pointing this out and the table of version casings. We'll investigate to see how this could be improved/fixed on dist.
//cc @skofman1 @joelverhagen

@joelverhagen commented on Fri Dec 16 2016
dist.nuget.org is living directly on Azure blob storage which has case-sensitive URLs. Thanks for the report @AGBrown. I'm going to move this to the server-side bug tracker so the server team has better visibility.

Things we should investigate:

Redirects / rules in CDN configuration to allow "nuget.exe" to point to "NuGet.exe".
In not 1, upload both "nuget.exe" and "NuGet.exe" as suggested.
Moving dist.nuget.org to be a web app (downside is compute...)

@rrelyea, we should decide on consistent filename for future uploads?

I believe we were trying to be consistent with the original casings used.

nuget.org/nuget.exe  (lowercase)
NuGet.Commandline package: tools/NuGet.exe

Dist should always be lowercase. But the package needs to keep the mixed casing for NuGet.exe update -self with mono.
It looks like for 3.4.4 and 3.5.0 the exe just wasn't renamed to lowercase when it was copied out of the package.

CDN rules should fix this. I'm investigating right now. Until the rule exists, we should provide both casing I think. No harm and provides ergonomic URL creation.

All of the broken links up there should be working now. I'll work on the CDN rule so we don't have to have copies of the blobs (future-proof) and oTHeR casings work as well.

Fixed in prod.


Integrate fastify-casbin plugins within titus

done in https://github.com/nearform/titus/pull/594

done in https://github.com/nearform/titus/pull/594


Add Twemojis for a good cause

Just for a good cause, but... I think it's beautiful 😂.
html:
<script src="https://twemoji.maxcdn.com/v/latest/twemoji.min.js" crossorigin="anonymous"></script>

js:
twemoji.parse(document.body)

css:
/*Blablabla*/
img.emoji {
width: 1em;
}

I hope this is a good thing... eh... Here I go!

Could you show examples instead of just how to implement it?

Could you show examples instead of just how to implement it?
If you leave it the way I did, it will be like this

I don't see a point of this for Documentation, where can this be used and why should it be?

It is an enchantment that could be added on the website only.

Where at on the site is it needed and why though

What's the point of adding it?

The documentation could have this as an element to make the site cool, see what point I want to get to?

No, I don't. It's documentation, it isn't really needed at all.

And what is your example showing exactly?

I don't have an example 🤦

🤦 let's drop this subject, it's hard to explain how far I'll go. Sorry the issue was weird.

This could find a use in bot/server pages, I believe.

If you were allowed to use script tags, yes. But you can't

If they we're pre-parsed or you had the option to pre-parse the body for twemoji that or just replace site-side emojis with twemoji, they're much better than some of the default PC fonts since some fonts on some machines dont even have emojis

If pre-parsed yes it could be useful actually. May be a suggestion that should be put on the main org repo though not docs

I agree.


Update Postgresql to 12.5

Description

Upgrade internal Postgresql in Chef Infra Server to 12.5 (install 12.5 by default).
Ensure that upgrades from 9.6 to 12.5 (including terraform and umbrella upgrade scenarios) work.

Tasks

[x] Add omnibus support for PG12.5.
[x] PG12.5 installed/used by default.
[x] Successful install and service startup of PG12.5, standalone fresh install (and other?) scenario(s).

Acceptance Criteria (copied over from issue)

[x] PG12.5 installed/used by default.
[x] Chef Infra server can migrate from PG9.6 to 12.x.
To upgrade from older versions can use: pg_upgrade followed by vacuum analyze.
[ ] Backward compatibility for older versions PG is tested and succeeds (QUESTION: Is this just whatever older upgrade is already performed by umbrella?).
[x] Add tests for external Postgres scenario with PG12.x to integration_test pipeline. At this point for a branch pointing to PG 12.5 by default should work by default.

Issues Resolved
https://github.com/chef/chef-server/issues/2157
Related PRs
https://github.com/chef/omnibus-software/pull/1305 [closed - apparently not needed]
https://github.com/chef/umbrella/pull/123
Related Branches
12.5
omnibus-software/lbaker/postgres12.5
umbrella/lbaker/standalone-upgrade-postgres
13.3
lbaker/postgres13.x
Tests
12.5
https://buildkite.com/chef/chef-chef-server-master-verify/builds/4088
https://buildkite.com/chef/chef-chef-server-master-verify/builds/4300
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2725
13.3
https://buildkite.com/chef/chef-chef-server-master-verify/builds/4291#9dfce11d-8265-4891-bc15-3f2921ce1515
https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2841#a404bc99-9df9-48d0-aa32-9179d2df1d34
For umbrella and other test results, see:
https://github.com/chef/umbrella/pull/123
Testing of chef-server-ctl commands that use PG gem:
ubuntu@ip-10-0-5-231:~$ sudo  -i
root@ip-10-0-5-231:~# head -n1 /opt/opscode/version-manifest.txt
chef-server 14.5.0+20210524054518
root@ip-10-0-5-231:~# chef-server-ctl user-create johndoe John Doe<EMAIL_ADDRESS>'abc123' --filename /tmp/johndoe.pem
root@ip-10-0-5-231:~# chef-server-ctl user-show
janedoe:      https://<IP_ADDRESS>/users/janedoe
janedoeafter: https://<IP_ADDRESS>/users/janedoeafter
johndoe:      https://<IP_ADDRESS>/users/johndoe
pivotal:      https://<IP_ADDRESS>/users/pivotal
root@ip-10-0-5-231:~# chef-server-ctl user-list
janedoe
janedoeafter
johndoe
pivotal
root@ip-10-0-5-231:~# EDITOR=vim chef-server-ctl user-edit johndoe # change display_name to John Deer
Saved johndoe.
root@ip-10-0-5-231:~# chef-server-ctl user-show johndoe
display_name: John Deer
email<EMAIL_ADDRESS>first_name:   John
last_name:    Doe
middle_name:
public_key:   -----BEGIN PUBLIC KEY-----
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA1gTXSR4d/jHjX4kGlsCn
nJKiN3pgoHa9NSoXlfEFinHNS/6wpbKZzpUgYL5ueDDhchhrSQJdM2pyQ3scyZhU
8IrF/S3tge4im196ls/xD5RTgWXqE+rK4s7EHSTOBBjiuRR4N5iOf0GPjUCBAuyE
HLr4sv/8FBM9Cx3T3hr0e1aQaW5FjL3YLKESJJ0eId5mqJDGRpAQ9rCLViHmLkgL
7JBvY0m8k4MmzMw3zFho7XES17S394fYYA64bNAupu6UO3E6kqguYr/Ux98nDQ23
i3Y9lrg3WSP5JboTTdqONIynVS70dVW5xAwqVZ6DWNQRFuhDBu9WHmRIX94BNhDl
3QIDAQAB
-----END PUBLIC KEY-----

username:     johndoe
root@ip-10-0-5-231:~# chef-server-ctl org-create 5thcafe '5th Cafe, Inc.' --association_user johndoe --filename /tmp/5thcafe-validator.pem
root@ip-10-0-5-231:~# chef-server-ctl org-show 5thcafe
full_name: 5th Cafe, Inc.
guid:      659d40a6b3a5628fa3112b547d3431b6
name:      5thcafe
root@ip-10-0-5-231:~# chef-server-ctl org-user-add 4thcoffee johndoe
root@ip-10-0-5-231:~# chef-server-ctl org-user-remove 4thcoffee johndoe
root@ip-10-0-5-231:~# chef-server-ctl password johndoe
Enter the new password:  ********
Enter the new password again:  ********
Authentication info updated for johndoe.
User's password has been updated.
root@ip-10-0-5-231:~# chef-server-ctl org-delete 5thcafe
Do you want to delete the organization 5thcafe? (Y/N) Y
full_name: 5th Cafe, Inc.
guid:      659d40a6b3a5628fa3112b547d3431b6
name:      5thcafe
root@ip-10-0-5-231:~# chef-server-ctl org-delete 5thcafe
Do you want to delete the organization 5thcafe? (Y/N) Y
ERROR: The object you are looking for could not be found
Response: organization '5thcafe' does not exist.
root@ip-10-0-5-231:~# chef-server-ctl org-list
4thcoffee
4thcoffeeafter
root@ip-10-0-5-231:~# chef-server-ctl user-delete johndoe
Do you want to delete the user johndoe? (Y/N) Y
Checking organization memberships...
Deleting user johndoe.
root@ip-10-0-5-231:~# chef-server-ctl user-show
janedoe:      https://<IP_ADDRESS>/users/janedoe
janedoeafter: https://<IP_ADDRESS>/users/janedoeafter
pivotal:      https://<IP_ADDRESS>/users/pivotal
chef-server-ctl psql opscode-erchef
psql (12.5)
Type "help" for help.

opscode_chef=>

Check List

[x] All buildkite tests pass
[x] Full omnibus build and tests in buildkite pass
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[x] PR title is a worthy inclusion in the CHANGELOG

closing in favor of #2577


Inability to debug Factory Components such as Mat Dialogs

Augury: 1.15.0
Date: Mon, 12 Feb 2018 11:20:38 GMT
OS: Win32
Demo test application:
-- https://angular-czrxrm.stackblitz.io/
-- https://stackblitz.com/edit/angular-czrxrm?file=app%2Fdialog-overview-example.ts
Description of issue:
-- Entry components are not added to the component graph. Neither you can search them by using the search field
Angular version (required): Tested in 5.2
Steps to reproduce:

See Components Tree. Mat Dialog is not present
Open Mat Dialog (then component is rendered-created-added)
Components Tree is not updated

Additional details:
MatDialog instantiates components at run-time. (https://material.angular.io/components/dialog/overview)

I'm having the same issue.  Would be really nice to have this fixed.

+1. I create complex components as pop ups and would need to debug them

Created consolidated issue #1380 to track this


Movie step sometimes fails

On some prognostic run jobs the "movie" step fails. This also means that the single-run prognostic report is not created, even though it does not require the movies.
Steps to reproduce the problem:

call prognostic_run_diags movie --n_timesteps 2 --n_jobs 2 gs://vcm-ml-experiments/claytons/2022-08-10/oos-full-year-sweep-ocsvm-tq-larger-gamma-0.5-default-trial1/fv3gfs_run output and the water vapor path movie fails

Traceback:
2022-08-11 11:40:55.297 INFO    fv3net.diagnostics.prognostic_run.views.movies: Forcing load for required variables for water_vapor_path movie
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/numpy/lib/nanfunctions.py", line 434, in nanmax
  File "<__array_function__ internals>", line 5, in nanmax
    result = getattr(npmodule, name)(values, axis=axis, **kwargs)
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/xarray/core/nputils.py", line 152, in f
    return module.nanmax(a, axis=axis)
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/xarray/core/nanops.py", line 91, in nanmax
    return func(values, axis=axis, **kwargs)
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/xarray/core/duck_array_ops.py", line 352, in f
    data = func(self.data, **kwargs)
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/xarray/core/variable.py", line 1758, in reduce
    var = self.variable.reduce(func, dim, axis, keep_attrs, keepdims, **kwargs)
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/xarray/core/dataarray.py", line 2676, in reduce
    return self.reduce(func, dim, axis, skipna=skipna, **kwargs)
  File "/opt/conda/envs/fv3net/lib/python3.8/site-packages/xarray/core/common.py", line 56, in wrapped_func
    if variable in ds and abs(ds[variable]).max() > tol:
  File "/home/jovyan/fv3net/workflows/diagnostics/fv3net/diagnostics/prognostic_run/views/movies.py", line 123, in _non_zero
    if _non_zero(data, required_variables):
  File "/home/jovyan/fv3net/workflows/diagnostics/fv3net/diagnostics/prognostic_run/views/movies.py", line 155, in _create_movie
    _create_movie(movie_spec, dataset, args.output, args.n_jobs)
  File "/home/jovyan/fv3net/workflows/diagnostics/fv3net/diagnostics/prognostic_run/views/movies.py", line 265, in main
    args.func(dissoc(args, "func"))
  File "/home/jovyan/fv3net/workflows/diagnostics/fv3net/diagnostics/prognostic_run/cli.py", line 47, in main
    sys.exit(load_entry_point('fv3net-diagnostics', 'console_scripts', 'prognostic_run_diags')())
  File "/opt/conda/envs/fv3net/bin/prognostic_run_diags", line 33, in <module>
Traceback (most recent call last):
    res = np.fmax.reduce(a, axis=axis, out=out, **kwargs)
ValueError: zero-size array to reduction operation fmax which has no identity

This is happening because the water vapor path movie requires a verification dataset, and the above run needs the PIRE verification data instead of the default verif data (if i provide --verification 1yr_pire_postspinup it works okay).
Furthermore, the argo template for generating movies does not allow providing a custom verification tag/url: https://github.com/ai2cm/fv3net/blob/8b937e1dd3e741c19af0fb6a2a4a4616b9e6f2fd/workflows/argo/prognostic_run_diags.yaml#L187
Don't think we want to simply pass along the online-diags-flags parameter to the movie step, since the prognostic_run_diags save CLI does not have exactly the same set of arguments as the prognostic_run_diags movie CLI.


Remove “basic logging”/log handling

This is overly complicated and non-standard.
The caller can add log handlers. The library shouldn’t add any.

I agree! The log handlers were the only grievance I had with jsonrpcserver but a surprisingly big one.
I didn't really figure out a simple way to silence the logging which interfered with my own server logging and gave me a great deal of confusion as I was also logging the requests/responses on my own...
Furthermore, converting a (complex) JSON object into a string isn't without a performance cost which might be critical for a server - I think that is always happening ATM, regardless of logging settings. Yet another reason to leave the logging on the caller as you suggest.
I wouldn't mind doing some nuking... PR incoming, probably ;)

I was planning to only remove the log handlers, leaving the caller to add handlers to the jsonrpc loggers. But I think you're right, there's no need to log at all. The caller can do all the logging.

I've updated the issue to remove all logging.

Complete in version 5

Worth mentioning - logging the requests and responses has been removed in version 5, but there are a couple of points where it still logs.
If the “method” (written by the user) has an uncaught exception, jsonrpcserver will log the exception and return a json-rpc Internal error response.
If jsonrpcserver itself has an exception, it will log the exception and return a json-rpc Server error response.


In the README.md file to run labellabs-client

Describe the bug
there are no instructions on how to run the clientside-server
it should say Run the Node server in the labellab-client folder: instead of
Run the Node server in the labellab-server folder:
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@carpecodeum Node server of backend server should be run on labellab-server before client's server. Reopen the issue if there is a further issue.


Is it possible to create proof chains or proof sets?

I had posted this questions earlier on json-ld signatures github repository. I would like to create proof chains where multiple parties can sign a proof. For example: If a party is transferring ownership of an asset to another party and both parties need to sign the contract. Is it possible to use proof chains?
Please let me know if there is a way to post questions instead of issues. Thanks.

I provided a response over here: https://github.com/digitalbazaar/jsonld-signatures/issues/101#issuecomment-637808541. We don't have a way to post questions here instead of issues. I'm going to close this issue as it seems that it's more germane to jsonld-signatures (linked above).


up arrow key in search field does not move line up

VSCode Version:
OS Version:

Steps to Reproduce:

Open the search tab (command+shift+f)
type in a multi-line search string in the search box.
Starting with your caret at the end of the search string, press the up arrow key.
observe: It does not move to the next line, instead it changes the input to the second most recent search string.

Does this issue occur when all extensions are disabled?: Yes/No
I have no idea if this is an introduced bug or a new feature, but if it is a feature, it  needs an override – this is very disruptive to my workflow and changes a fundamental way we interact with the search box.

/needsMoreInfo
Could you provide VSCode version, OS version and if it can be reproduces with all extension disabled as mentioned in template?
Also looks like this problem cannot be reproduced Insiders build on Windows. Could you check if it still a problem in insiders build https://code.visualstudio.com/insiders/ ?
UpArrow/DownArrow moves cursor between lines
Alt+UpArrow/DownArrow previous/next search string
Ctrl+UpArrow/DownArrow focuses previous/next field
I think similar shortcuts should be in place for MacOS


Fix compat with Laravel 5.2

Without it, Laravel throws
Declaration of Caffeinated\Shinobi\Traits\ShinobiTrait::can($permission) should be compatible with Illuminate\Foundation\Auth\User::can($ability, $arguments = Array)

Hi @antoniopaisfernandes : just a note, I suggested this back with issue #26 but it was decided against so your PR might sit here a while. If you are using it locally, you might want to check out issue #26 because if I recall correctly I needed to make at least 3 can() changes for it to work with full functionality.
Good luck.

Thanks for the info.
I've already forked the code and pointed my composer.json to it. If it's fixed in the future, I'll revert the composer.json. If not, I'll just update my fork.

I'll merge this and tag a new release~
If there are any other changes that can be made to make shinobi more compatible with 5.2 I'm all ears. I have yet to jump ship to Laravel 5.2 which is why these updates are slow going~

Don't you also need to make the same change on lines 145 and 207 (as I mentioned in issue #26)? (...or I guess the lines now would be 146 and 208)
Or are those same changes not necessary?


Improve unit tests

The way the unit tests make assertions to check behaviour is not very good. It relies on the phpunit configuration forcing a test to fail if it makes no assertions. It should instead bind a local variable to the closures by reference, modify it in the closure and assert it has changed. Or perhaps there is an even better way than that.

See #9 for my proposed solution. Also I think you forgot to tag this issue for Hacktoberfest!


⚠ Bofrost.lu has degraded performance

In d9ac1a6, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1482 ms

Resolved: Bofrost.lu performance has improved in c69eada after 28 minutes.


Initialize selection and selectionIndex for ListView and ListPicker

Initialize these to the empty string and zero.

This requires a companion change.

issue #634

Tested LGTM (Move to gerrit)

On Gerrit for ucr branch

@halatmit @afmckinney MERGED into ucr


Azure AD authentication not working

For Bug Reports

BookStack Version: v0.18.4
PHP Version: 7.0.19-1
MySQL Version: 15.1

Current Behavior
I followed https://www.bookstackapp.com/docs/admin/social-auth/ to set-up Azure AD authentication.
I checked my values 3 times and I am quite sure that all the information is correct.
When I am trying to add or log-in with Azure AD account I get error "Whoops, looks like something went wrong."
Debug log:
[2017-11-08 01:48:57] production.ERROR: Laravel\Socialite\Two\InvalidStateException in /var/www/html/BookStack/vendor/socialiteproviders/manager/src/OAuth2/AbstractProvider.php:32
Stack trace:
#0 /var/www/html/BookStack/app/Services/SocialAuthService.php(96): SocialiteProviders\Manager\OAuth2\AbstractProvider->user()
#1 /var/www/html/BookStack/app/Http/Controllers/Auth/RegisterController.php(263): BookStack\Services\SocialAuthService->handleLoginCallback('azure')
#2 [internal function]: BookStack\Http\Controllers\Auth\RegisterController->socialCallback('azure')
#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(55): call_user_func_array(Array, Array)
#4 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(44): Illuminate\Routing\Controller->callAction('socialCallback', Array)
#5 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(203): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(BookStack\Http\Controllers\Auth\RegisterController), 'socialCallback')
#6 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(160): Illuminate\Routing\Route->runController()
#7 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(559): Illuminate\Routing\Route->run()
#8 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#9 /var/www/html/BookStack/app/Http/Controllers/Controller.php(44): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#10 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(131): BookStack\Http\Controllers\Controller->BookStack\Http\Controllers\{closure}(Object(Illuminate\Http\Request), Object(Closure))
#11 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#12 /var/www/html/BookStack/app/Http/Middleware/Localization.php(31): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#13 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): BookStack\Http\Middleware\Localization->handle(Object(Illuminate\Http\Request), Object(Closure))
#14 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#15 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(41): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#16 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure))
#17 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#18 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(65): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#19 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle(Object(Illuminate\Http\Request), Object(Closure))
#20 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#21 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#22 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#23 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#24 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#25 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#26 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#27 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#28 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure))
#29 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#30 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(59): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#31 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure))
#32 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#33 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(102): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#34 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(561): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#35 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(520): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#36 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(498): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#37 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(174): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#38 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request))
#39 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(30): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#40 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#41 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#42 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#43 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure))
#44 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#45 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(46): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#46 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure))
#47 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#48 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(102): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#49 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(149): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#50 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(116): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#51 /var/www/html/BookStack/public/index.php(53): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#52 {main}

Hi @genxlee, This could happen if there's a mis-configuration for the URL set for BookStack. Can you check that you've set a APP_URL parameter in your .env file and that the start of it matches the callback url's you've set in azure.
Also, let me know if you've set any other .env variables that include a URL as that could cause a mis-match.

@ssddanbrown I have only one APP_URL in .env file and I don't have any other parameters with my website URL.
When it is missmatching let's say I set APP_URL https://domain/test then it will give me error at Microsoft's site:
Additional technical information:
--
Correlation ID: d59852b0-de8e-4621-ab48-7f9d794cdd15
Timestamp: 2017-11-12 09:37:23Z
AADSTS50011: The reply address 'https://domain/test/login/service/azure/callback' does not match the reply addresses configured for the application: '1211837d-b224-4dbc-9afb-6ba9cd4fee97'. More details: not specified

When I have correct APP_URL it will redirect me back to my BookStack but won't authenticate and will give "Whoops, looks like something went wrong."

Thank you for opening this issue. As part of an issue clean-up we're closing off older support issues that may be outdated or irrelevant so therefore I am closing this issue.
If the issue remains and it is one you are still seeking to actively solve please ensure it is still not apparent on the latest version of BookStack then open up a new issue referencing this one.
Sorry if we were not able to solve your original request.


Don't run side-effects for pure-clojurescript (non-interop) -> chains

Fixes https://github.com/clojure-emacs/clj-suitable/issues/30

The introduced logic is as follows:

If the 'operand' of a (-> ) (i.e. its first member) does not match js/* or js/*, then evaluation (side-effects) will shortcircuited.
For (. ,,,), (.. ,,,), (doto ,,,), evaluation will never be shortcircuited, because those macros are interop-oriented.

It's not perfect, but it seems to find a balance between shortcircuiting most pure clojurescript forms, and allow JS completions to still work for many cases.
In a future, logic may be refined by leveraging the cljs analyzer - we already do in cider-nrepl so it should be at hand.
Cheers - V

I'm fine with the changes, but they'll have to be reflected in the README, so the users don't have a hard time trying to figure out how the completion works.


Disorganised files relating to numbered file names regardless of windows folder organisation.

The folder display on the left hand side of atom has a bug where files are not displayed properly in order of name. I have 10 files named 1-10 and where file 2 should be, the file named 10 is in it's place. I have added a file named 40 and the files are now displayed like this:
1
10
2
3
4
40
5
6
7
8
9

I'm assuming you're on Windows?
I think Mac and Linux organize files by looking at the first letter, then the second, etc. while Windows does it alphanumerically-can someone confirm this?

I just tried it out and Windows Explorer sorts properly according to numeric values, if the filenames are just that:

While Atom takes them as Strings:

This issue was moved to atom/tree-view#391


Plans WRT LoLA?

Hi! Very interesting project!
Any plans on rewriting LoLA to Rust? Surely, going further, this project would benefit from importing LoLA instead of spawning a process.
Sub-question: what's the state of LoLA's development? Their paper was published 23 years ago and they seem to release tarballs on a webpage...
Do you feel that something else could replace LoLA? You seem to have organized your codebase thus.

LoLa is developed at the University of Rostock by Prof. Wolf and his graduate students (1-2) at the chair in Theoretical Computer Science . I am pretty sure that LoLa will not be rewritten, as it is developed parallel to the academic duties. But, LoLa is still in development and updated with current research for the foreseeable future.
LoLa could be replaced by another Petri net model checker. There is a model checking contest where other tools can be found (last results whit LoLa). I believe Tapaal was always a main competitor of LoLa. However, I don't think there is a rust competitor, and it is unlikely that any of the existing projects will change the codebase, since these model checkers are highly optimized to squeeze out every bit of performance.


Other language example

I'm looking for the python example from https://vercel.com/docs/runtimes, which I can git clone and run the code

We now have a deployable example with a hello world API (demo)
We now have a deployable example with Flask (demo)
We now have a deployable example with Django (demo)


Mocha

Depends on https://github.com/roundscope/ember-insights/pull/73

This code is requested by https://github.com/roundscope/ember-insights/issues/42


The icons at the bottom not visible in mobile mode

Describe the bug
The icons at the bottom not visible in mobile mode
@bdougie I want to work on this it can be assigned to me.

Steps to reproduce
Already present on site on mobile mode
Affected services
hot.opensauced.pizza
Platforms
No response
Browsers
No response
Environment
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

.take

Hey @parmishh, thanks for opening this issue.
This was already tackled in https://github.com/open-sauced/hot/pull/436. It's in the beta branch, visit beta.opensauced.pizza
We gonna close this issue for now, let us know if it's still present and we will re-open it :pizza:


Fix the issue of causing the UI UT cases failed

downgrade the zone.js version to 0.8.19 and fix it

Coverage increased (+0.01%) to 64.43% when pulling 75dc821bae1a57db8eff7e63d91f25250b013a92 on steven-zou:master into 28aea4d4399e311c22d28abd1051b975da3e49b7 on vmware:master.


[HUDI-5434] Fix archival in metadata table to not rely on completed rollback or clean in data table

Change Logs
Before this PR, the archival for the metadata table uses the earliest instant of all actions from the active timeline of the data table.  In the archival process, CLEAN and ROLLBACK instants are archived separately apart from commits (check HoodieTimelineArchiver#getCleanInstantsToArchive).  Because of this, a very old completed CLEAN or ROLLBACK instant in the data table can block the archive of the metadata table timeline and causes the active timeline of the metadata table to be extremely long, leading to performance issues for loading the timeline.
This PR changes the archival in metadata table to not rely on completed rollback or clean in data table, by archiving the metadata table's instants after the earliest commit (COMMIT, DELTA_COMMIT, and REPLACE_COMMIT only, considering non-savepoint commit only if enabling archive beyond savepoint) and the earliest inflight instant (all actions) in the data table's active timeline.
New tests are added and an existing test around the archival in the metadata table is adjusted to verify that the archival in the metadata table does not depend on the completed rollback in the data table.
This PR is tested locally to ensure the metadata table's archival works as expected.
Impact
Makes the active timeline of the metadata table shorter and improves the performance of loading the active timeline of the metadata table.
Risk level
low
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI passes

Before this PR, the archival for the metadata table uses the earliest instant of all actions from the active timeline of the data table. In the archival process, CLEAN and ROLLBACK instants are archived separately apart from commits (check HoodieTimelineArchiver#getCleanInstantsToArchive). Because of this, a very old completed CLEAN or ROLLBACK instant in the data table can block the archive of the metadata table timeline and causes the active timeline of the metadata table to be extremely long, leading to performance issues for loading the timeline.

Why not just archival all the clean/rollback instants before the oldest commit instant, the current logic of HoodieTimelineArchiver#getCleanInstantsToArchive doesn't really make sense

then these rollback instants will stay in the active timeline forever.

That's true, we should optimize the archiving of cleaning and rollback.

@danny0405

That's true, we should optimize the archiving of cleaning and rollback.
I see you are working on LSM tree based archive timeline, have you done some work on this?
If not, I'd like to work for it, the current process of getInstantsToArchive is a bit complicated, I will sort it out as a whole.

have you done some work on this

No.


Deploy Licensing Backups Everywhere

S3 backups are gated in the mongodb::backup class.  To enable s3 backups, we need to set the condition to true in the
node classifier.  This allows for deploying to specific nodes.

Merge away.


edgedb migration create breaks for function in schema returning optional union of abstract types

EdgeDB Version: 2.13+c171f92
EdgeDB CLI Version: 2.3.1+ef99779
OS Version: Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-147-generic x86_64)

My schema contains some abstract types and some concrete types that are derived from them. I've only copied the abstract types here as that's enough to reproduce the error
abstract type MessageFromUser {
    required property timestamp -> datetime;
    link replyTo -> MessageFromApi | MessageFromUser;
}

abstract type MessageFromApi {
    required property createdTimestamp -> datetime;
    required property apiPhoneId -> api_phone_id;
}

And I've just defined this fairly simple function in my schema
function getApiMsgRepliedTo(userMsg: MessageFromUser) -> optional (MessageFromApi | MessageFromUser)
    using (userMsg.replyTo);

But when I run edgedb migration create I get the below error
edgedb error: InternalServerError:
  Hint: This is most likely a bug in EdgeDB. Please consider opening an issue ticket at https://github.com/edgedb/edgedb/issues/new?template=bug_report.md
  Server traceback:
      Traceback (most recent call last):
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler_pool/worker_proc.py", line 55, in worker
          res = meth(*args)
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler_pool/worker.py", line 160, in compile
          units, cstate = COMPILER.compile(
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler/compiler.py", line 2524, in compile
          unit_group = self._compile(ctx=ctx, source=source)
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler/compiler.py", line 2049, in _compile
          return self._try_compile(ctx=ctx, source=source)
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler/compiler.py", line 2113, in _try_compile
          comp, capabilities = self._compile_dispatch_ql(
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler/compiler.py", line 1971, in _compile_dispatch_ql
          query = self._compile_ql_migration(
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/server/compiler/compiler.py", line 1160, in _compile_ql_migration
          target_schema = s_ddl.apply_sdl(
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/schema/ddl.py", line 442, in apply_sdl
          cmd = cmd_from_ddl(
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/schema/ddl.py", line 394, in cmd_from_ddl
          res = sd.compile_ddl(schema, ddl, context=context)
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/schema/delta.py", line 4255, in compile_ddl
          cmd = cmdcls._cmd_tree_from_ast(schema, astnode, context)
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/schema/functions.py", line 1903, in _cmd_tree_from_ast
          cmd = super()._cmd_tree_from_ast(schema, astnode, context)
        File "/home/edgedb/.local/share/edgedb/portable/2.14/lib/python3.10/site-packages/edb/schema/functions.py", line 1085, in _cmd_tree_from_ast
          assert isinstance(astnode.returning, qlast.TypeName)
      AssertionError

It producing an ISE is definitely a bug. If we aren't going to support something, we ought to produce a proper error message
I feel like properly supporting this shouldn't be /that/ hard either? I'd start by removing the assert and seeing where it goes.


document internal data dependencies & flow

This ticket is a little open ended, but one thing I'd like to try and do is document how data flows through Puffin and what is actually used in each step.
Part of the purpose of doing this is to build a better mental model for myself about how Puffin works.
But I think this sort of analysis can help with optimization. That is, if we know what is actually required at each step, that might expose some optimization opportunities by, say, deserializing less data.
I'm not sure if it makes sense for the output of this ticket to just be a comment here or if I should write a short doc and commit it to the repo. (The doc seems likely to get stale, but we could mitigate that by putting a timestamp with a warning on it.)

We've had a few attempts at this -- going to close for now as not super actionable.


remove aggregator AppendWorkloadHandler implement to prevent misuse

Please provide a description of this PR:

I am a bit confused how this works. Is the issue we are registering things 2x or something?

I don't see where we actually append handlers at the aggregate level today, so this seems safe to me. Are you seeing an actual issue right now, or is this code cleanup?

@stevenctl You are right, there is no append now. This is to make sure no developer in the future will misuse it unless we find it is useful.

/retest

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
25db4ba29f47bf52d1c5a3b72e0f47a1b1ab9f5b
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster_istio


Add AWS Architecture Icons (full set)

This is a logo request to update/augment the current set of AWS architecture icons in the logo set which can be retrieved from: https://aws.amazon.com/architecture/icons/
Related: https://github.com/iconify/icon-sets/issues/152

Hey @loozhengyuan
This repo is a curated list of logos, so we don't plan to add every logo.
While we have the most significant AWS logos, adding/maintaining the whole set isn't feasible.
Do you have any specific logos that you want to add? I could add an extra few.

Yeah, I think so too.
Good luck!


Listener leak; callbacks not invoked for commands without response bodies

For commands that don't have responses (e.g. 'tags', 'event', 'auth', 'handshake', ...) it appears that the callback will never be invoked. Consequently the once listeners will never be released == leak.
--
I'm evaluating this library as an alternative to the 'serf-rpc' library (which has a few critical bugs and unclear maintenance status -- looks like it was actually a port of this library). Are you actively accepting pull requests? In addition to the above, there are a few other changes I'd propose (including traditional error-first callbacks that are always invoked, supporting the rest of the methods, and maybe porting the coffeescript to JS if you're open to it).

Pull requests are welcomed. 😄
If we can agree on one coding style e.g. (feross/standard), proving to JS sounds good to be.

Awesome! What do you think of feross/standard + semicolons? :)

Personally I'm not a big fan of semicolons, but I can certainly live with that. :)

Hmm, I'll give no-semis a try :)


Multiquestion questions support

Rename ContentBuilder to ContentManifest
Class name is not used outside dmutils and ContentManifest feels
like a more descriptive name, especially since ContentSection was
added.
Add support for loading nested questions
Reuses the existing section loading to load questions: for question
files. Since the original function also added an id to the section
and we need a way to create URLs addressing multiquestions we kept
the existing logic but replaced id key with slug to differentiate
between addressable and non-addressable questions.
Section slug is only used internally for now: once section data is
transformed into ContentSection instance it can be addressed as
section.id. Since renaming it is a breaking change it's kept as
TODO for now. Questions should use .slug for URL referencing.
Add ContentQuestionSummary to replace service_attribute
Adds a new class for a question containing a reference to the service
data. This allows adding additional methods to the question: .value
and .answer_required.
ContentQuestionSummary instances are created by calling .summary
on manifest or section objects, which returns a copy of the object
with all questions transformed to ContentQuestionSummary instances.
This replaces service_attribute.Attribute class and removes the need
for creating section look-alike dictionaries with "rows" key for summary
table display since ordinary section objects can be used instead and
there's no need to propagate the changes in section attributes.
Add support for individually editable questions
Adds a helper method that allows returning a multiquestion question
as a section object containing all the nested questions. Parent
section edit_questions is stored to the new section.edtiable
so we can reuse the existing write protection/display section logic.
Allow access to question data keys as attributes on ContentQuestion
Similar to ContentSection we want to access question keys as
attributes. Since questions have a lot of keys, instead of listing
them in the constructor arguments we just set getattr to continue
attribute lookup in _data dictionary keys.
Use question.name or .question as ContentQuestion.label
Question content 'name' key can be used for short question names to
be displayed in the summary tables instead of the full question.
ContentQuestion.label attribute is now present on all questions and will
try to use name instead of question if set.

I agree that ContentManifest is a better name now but it does mean that get_builder is a really bad method name.

@robyoung renamed and added a note to CHANGELOG, but kept .get_builder as an alias (https://github.com/alphagov/digitalmarketplace-utils/commit/d98c8ef919714e4379ddd4c227a16d5c79938ed3#diff-346b98f8c34fcc00d15a2cc1629cfb6aR507) just so we don't have to update all apps right now.

The code looks great, I've left a few comments around documentation but code wise I think it's good to go. :+1:


Constructor was missing the argumen for the ImageResponse.

The Constructor was missing an argument and there was no setter for it, so add the argument to the constructor and fix callers.
Whilst this breaks backwards source (but not exposed API ) compatibility for clients we have only released betas so I do not consider this an issue, and even then they can keep using the old API version.
@reviewbybees

:+1:

:+1:


Feature: Avoid running clipster daemon when CopyQ or GPaste selected

Not sure how easy this would be to implement, but just quality-of-life wise it'd be nice to drop the clipster_bin daemon if/when another source is used to conserve memory

ulauncher-clipboard checks if you have picked any specific clipboard manager. If not it tries to find if you have any running. If not it checked if you have any installed. If neither of those are true it downloads a local copy of clipster, starts it and uses that.
So if you're concerned about memory usage it should be very easy to avoid this issue. Just kill the process manually, reboot or (assuming you would know this before installing the extension) make sure you have the clipboard manager of your choice installed before installing the extension.
If this isn't the case there's a bug somewhere, and I will look at it.
I agree it would be nice if ulauncher-clipboard handled this, but not sure the pros outweigh the cons (increasing the complexity). It's not just clipster. It starts any of them if they're the selected manager and not already running. So if you're changing the settings a lot this would happen, but I think this is the kind of thing people set and forget.

ulauncher-clipboard checks if you have picked any specific clipboard manager. If not it tries to find if you have any running. If not it checked if you have any installed. If neither of those are true it downloads a local copy of clipster, starts it and uses that.
So if you're concerned about memory usage it should be very easy to avoid this issue. Just kill the process manually, reboot or (assuming you would know this before installing the extension) make sure you have the clipboard manager of your choice installed before installing the extension.
If this isn't the case there's a bug somewhere, and I will look at it.
I agree it would be nice if ulauncher-clipboard handled this, but not sure the pros outweigh the cons (increasing the complexity). It's not just clipster. It starts any of them if they're the selected manager and not already running. So if you're changing the settings a lot this would happen, but I think this is the kind of thing people set and forget.

Cool, understandable. I've found that the process is started again regardless of setting, though this was after initially having no external manager. I guess might be worthwhile to check up on that? But considering minimal memory use anyway, no biggie :smile:

Cool, understandable. I've found that the process is started again regardless of setting, though this was after initially having no external manager. I guess might be worthwhile to check up on that? But considering minimal memory use anyway, no biggie :smile:

I'll look into it when I have time. Thanks for the report :+1:

I'll look into it when I have time. Thanks for the report :+1:

This is not happening if you start ulauncher with a supported clipboard manager installed.


api!: rename path to merkle path for contract api json msgs

Description
Explicitly break the api of json encoded contract msgs

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

base branch updated

Should we also open a PR targeting to main with these changes? (and backport to v9.0.x, so that when we create the release branch for 08-wasm compatible with v9 we also have the changes there)


Fix translation of ETH coordinates

Issue
/
Description
Fix bug in translation of eth coordinates
List of the changes
Fix bug in translation of eth coordinates
Testing
CI
API Changes
/

Thanks @tt-vjovanovic for catching this


Deprecate 'mdx rule' starting from 1.7.0

A Deprecated module sounds like a good idea, I added this and also changed the version numbers.

It looks good but can you add a pointer to the mdx stanza in the deprecation warning? I think we should always point users to the replacement when we deprecate a feature.


No MS-SSIM Loss.

I check the codes of the RateDistortionLoss in train.py. It seems that only the MSE loss exists.
So will you provide the MS-SSIM loss function you used?
Thanks.

You can refer to CompressAI for MS-SSIM training as we used.


feat: Override feature for Graphql Api

Description of changes

Added types for Appsync API , input-state-management and JSON schema
added cli-inputs to add /update walkthrough
removed authConfig fetch from amplify-meta to cli-inputs
removed resolver config from transformer.conf.json

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8466 (316e96a) into extOverrides (5a2a702) will increase coverage by 0.27%.
The diff coverage is 82.86%.

@@               Coverage Diff                @@
##           extOverrides    #8466      +/-   ##
================================================
+ Coverage         54.05%   54.33%   +0.27%
================================================
  Files               737      741       +4
  Lines             41819    42196     +377
  Branches           8412     8467      +55
================================================
+ Hits              22607    22927     +320
- Misses            18380    18434      +54
- Partials            832      835       +3

Impacted Files
Coverage Δ

...kages/amplify-category-geo/src/commands/geo/add.ts
54.54% <ø> (-5.46%)
:arrow_down:

...s/amplify-category-geo/src/commands/geo/console.ts
53.84% <ø> (+3.84%)
:arrow_up:

...es/amplify-category-geo/src/commands/geo/update.ts
54.54% <ø> (-5.46%)
:arrow_down:

...amplify-cli-core/src/feature-flags/featureFlags.ts
83.70% <ø> (ø)

packages/amplify-cli/src/context-manager.ts
77.41% <0.00%> (ø)

...chable-transformer/src/cdk/create-cfnParameters.ts
100.00% <ø> (ø)

...graphql-elasticsearch-transformer/src/resources.ts
100.00% <ø> (ø)

...ify-category-geo/src/provider-controllers/index.ts
28.94% <12.50%> (-1.94%)
:arrow_down:

...y-provider-awscloudformation/src/push-resources.ts
9.31% <16.66%> (-0.07%)
:arrow_down:

...amplify-category-geo/src/service-utils/mapUtils.ts
64.17% <20.00%> (-1.45%)
:arrow_down:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d3c3b...316e96a. Read the comment docs.

closing in favour https://github.com/aws-amplify/amplify-cli/pull/8599


Logo

paging @medensqui @nywillb

Ooh that could be a problem... @thatoddmailbox
Maybe a blueprint with PlanHub written on it? That would look cool

@medensqui but it needs to be small, and square, so it can fit into places like the favicon or the github org logo.

@thatoddmailbox What about the words PlanHub THEN AFTER THIS THE WORDS ARE UNDERNEATH Planning for the unexpected things with Einstein, Malala, etc. behind them

@thatoddmailbox Btw after things it's images in the background

@medensqui but we would still need a tiny one to fit in places like favicons and github org logos.

@thatoddmailbox So mini one is C+ Style Aka PlanHub

Did we not already do this?

@thatoddmailbox We need a header image for forms and other stuff

Oh okay.

Why not do a PH as a favicon and then PlanHub as a full logo.

@OnlyTwentyCharacters That does work, but we already have the blue book icon.

@OnlyTwentyCharacters how did you find us? Do you just randomly browse GitHub?

Also, what's up with PlanHub not working on desktop? I receive the webpage not available error on Chrome; yet when I access it on mobile it works.

Hi @OnlyTwentyCharacters,
We have never had that error reported before, so it would help you sent screenshots, and your OS and Chrome version (it can be found at chrome://help/)
Thanks!

@nywillb William, it's rare to have someone report this because the of OS used. It's POSEmbedded 2007. Not many people get their hands on it. The issue deals with the SSL certificate.

@OnlyTwentyCharacters
TL;DR: POSEmbedded 2007 (assuming you refer to Windows Embedded for Point of Service) is old. (extended support ends April 12, 2016!) Try another browser and/or upgrade SO.
PlanHub uses CloudFlare, which provides our SSL certificate. (see SSL Labs report for more info)
I could not find information on POSEmbedded 2007, but Windows Embedded for Point of Service seems to be a close match. If this is correct, then the version of Windows Embedded you are using is based off of Windows XP SP2.
Windows XP SP2 and below do not support certificates with SHA256 security methods. For security reasons, CloudFlare signs their certificates with SHA256 (see this page for more information). This causes a mismatch between the two, resulting in you not being able to access the site.
You should either try another browser (I think Firefox has its own independent cryptography system, which is not affected by the OS) or upgrade your OS.

@thatoddmailbox Yeah. It does work on other browsers/OS, I was just pointing it out. When I checked the console on Chrome, I found a SSL certificate mismatch (which basically means it's not supported).
When I checked the metadata on PlanHub, there was nothing in there that could be used to join the team. Same goes for the mysteriousImage.jpg file (that was made in Photoshop CS6 on OS X).

@OnlyTwentyCharacters Are you sure?

@thatoddmailbox Oh, I though that was something about the imgsrc. I just scanned through it.

Are you sure?

I think it is safe to say this issue is closed.

WHO CHANGED MY COMMENT

@RobotXLabs Not me.  I decoded every message in the end, you shortened that link which sent me to Dalton's login page (which I couldn't use the magical phrase).


[FLINK-25085][runtime] Add a scheduled thread pool in Endpoint and close it when the endpoint is stopped

What is the purpose of the change
This PR adds a scheduled thread pool to hold the periodic tasks and send them to akka with gateway when they should be executed. These periodic tasks such as resource timeout checker, heartbeat checker and some other tasks are scheduled by akka thread pool now,  and they are alive even when the job or tasks reach termination, it will cause FullGC.
Brief change log

Add a scheduled thread pool to hold the periodic tasks and send them to akka with gateway when they should be executed
Create the scheduled thread pool in Endpoint and close it when Endpoint is closed.

Verifying this change
This change added tests and can be verified as follows:

Added test ScheduledMainThreadExecutorTest that validates the ScheduledMainThreadExecutor
Endpoint related changes are covered by existing test RpcEndpointTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
The serializers: (yes / no / don't know) no
The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
The S3 file system connector: (yes / no / don't know) no

Documentation

Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented

@tillrohrmann @xintongsong Please have look at this PR for FLINK-25085 when you are free, thanks

Thanks for preparing this PR, @zjureel. @KarmaGYZ and I will both take a look.

@KarmaGYZ Thank you for your comments. I think it's a good question about ScheduledMainThreadExecutor and MainThreadExecutor. I create ScheduledMainThreadExecutor here for two reasons:

The ScheduledMainThreadExecutor instance is not only created and used in RpcEndpoint, but also created in HeartbeatManager.monitorTarget for each job in TaskExecutor to schedule the job's heartbeat. When a job terminates, its ScheduledMainThreadExecutor should be closed too.

In my conception,  MainThreadExecutor#schedule will be replaced with ScheduledMainThreadExecutor and it will throw Exception when all its calls are replaced. The MainThreadExecutor will be used as main thread to execute Runnable at once.

WDYT of that? THX

Thanks for the reply, @zjureel .
It seems we all agree that, in the end, the MainThreadExecutor#schedule will be replaced. Also, I don't think one should use ScheduledMainThreadExecutor#execute to execute tasks in the main thread. So, I would prefer to merge these two classes. As the MainThreadExecutor is indeed a ScheduledExecutor, one would expect to schedule tasks in the main thread directly by MainThreadExecutor#schedule.
Regarding the HeartbeatManager.monitorTarget, I'm not quite sure about what the problem is. Maybe we can construct a new ScheduledMainThreadExecutor from the MainThreadExecutor. That should be out of the scope of this PR.

@KarmaGYZ Thank you for your advice. Through the last communication, I think integrate ScheduledMainThreadExecutor and MainThreadExecutor is cool. I have made this update in code, checked the methods which call the MainThreadExecutor.schedule and add some test cases in RpcEndpointTest. Can you have a look when you are free and hope to hear from you. THX

@zjureel All the RpcEndpointTest.testScheduleXXX hangs because the TestMainThreadExecutable#runAsync do nothing. It only call the scheduleRunAsyncConsumer in the scheduleRunAsync. Please take a look.
Also, please squash your commits which are used to address the review comments.

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


dataPipeline renaming and separating it from dataAccess

dataAccess is set up as a separate component
Existing dataPipeline component / element is renamed internalImplementationDetails (or another descriptive name). It describes how a data product can be technically implemented (IaaS). dataAccess and technical implementation should be kept separate for clarity.

internalImplementationDetails does not sound beautiful, though

Usage examples are required. E.g. SQL / SQL Server and SQL db and SQL Insert Query in Yaml file.

"dataAccess" {
"type": "API",
"specification": "OAS",
"format": "JSON",
"specURL": "https://swagger.com/petstore.json",
"dataAccessDocumentationURL": "http://<IP_ADDRESS>/test/docs/dataaccess"
}


SELinux instructions cause WiFi issues

Describe the bug
I followed the SELinux instructions below and whitelisted my home directory which caused my IBM wifi certificate to not work. We should change the instructions to not recommend whitelisting the home directory
https://appsody.dev/docs/getting-started/installation
Environment Details (please complete the following information):

OS: [e.g. iOS] IBM RHEL 7.7

There is additional work to do in here, as part of the current instructions are not clear:
In our example we say if you are unsure about which directories are mounted by the stack you are using, you can inspect the output of the run command, and look at the -v parameters in the docker run command.
We then show a whole set of parameters being passed to run via -v and then make the statement "In the example above, there is one binding mount:"
It is unclear how we have come to the conclusion that there is only one binding mount in the example (I have a feeling that it's probably '/project/user-app' (our failing case in the example above) and the other folders listed are within the home directory but we've not made that clear).
Note, I was going to try and make this fix in the docs but I have a feeling that you'll have to change all the examples (if you're going to say don't whitelist the home directory) so that the user doesn't install Appsody projects into the user's home directory and I don't have access to SELinux to get sample output.

@helenmasters - I discussed this issue with @tnixa. I think we should drop the text from the point where it says:

In general - however - you should be required to run the command at most twice:

to the end of the section. I agree it's confusing.
We should replace all that with a single sentence that says something like:

We recommend you create a projects folder under your home directory - to host all of your future Appsody projects - and that you white-list that directory.

The problem I see here is that some stacks (the Java-based stacks) also mount the ~/.m2 directory - we should call that out, because for those stacks that directory also needs to be whitelisted. Thoughts?

I've reinstalled my machine and I'll be working with @chilanti on recreating this issue today.

@tnixa @chilanti I spoke with @doveye in the content team today about my idea to put these details into a FAQ and the main concern was that these are Troubleshooting not FAQ (but we don't currently have a Troubleshooting section within the docs). In addition, we don't want to maintain SELinux specific instructions in case anything changes under us.
So I'm investigating whether we can link out to SELinux docs to cover the basic issue instead (if we can find a link with enough detail in it to do that), we could then add a link to that doc from the Ubuntu and RHEL install pages (which I'm creating). It wouldn't stop us calling out the projects folder specifically, and stating that there may be issues with folders specific to other stacks (e.g. the Java-based stacks).

We haven't been able to reproduce the problem (i.e. Appsody - or Docker, for what matters - failing to function on SELinux). Things just work - we tried numerous times with fresh installs of RHEL 7.7, SELinux enabled and enforcing (clearly - with no special SELinux policies, just the out of the box scenario).  At this point, I am wondering whether we should even maintain a detailed discussion on what to do if someone is working on a system with SELinux turned on, and has special policies that prevent Docker from working. Would it be acceptable to just show the symptom (which we couldn't reproduce) and then point to the Docker docs that talk about SELinux? We should definitely refrain from recommending to white list the home dir.

Assigning to myself as part of refining and documenting the Installation pages for on all platforms under #375 as I need to make sure that we don't whitelist the home dir as per the current installation pages.

Closing, as I've reworked this and added the text we decided that we needed to keep to the FAQ.


[Dialog] Theme not updating on muiTheme change

Problem description

The mui theme is passed using context to down the tree.
It is controlled by a state in the main parent.
When the state is changed to switch to light theme to dark (or vice-versa).
It is not changed for the dialog.
Every other component's theme is updated (as discussed in #4362).

Steps to reproduce

Change state controlling the theme
Theme changed for all components except <Dialog />

Note: I also tried forceUpdate to update it but it doesn't update to the new state
Versions

Material-UI: 15.0.1
React: 15.1.0
Browser: Chrome 50.0.2661.102

Hi guys,
Original issue may be related to the way layer is rendered.
Currently React.createElement(DialogInline, this.props) is used to render the layer.
As per my observation context is not updated in DialogInline in this case after theme change.
Looks like react owner is not derived properly in this case and thus context is not captured during update phase.
I am new to React so I may be wrong with above assumptions about context...
However I was able to find workaround which worked fine for me.
I can see that open property is always passed as true in the Dialog.render function.
As result unrenderLayer function from RenderToLayer.js is not called even if Dialog's open property is changed to false.
Once I passed down the open property to RenderToLayer, newly opened dialog was rendered using new theme.
So if layer is removed from DOM using unrenderLayer and then recreated again using renderLayer - context is in sync with actual theme.
For now I am using monkey patch like this:
MaterialUI.Dialog.prototype.render = function() {
return React.createElement(MaterialUI.internal.RenderToLayer, { render: this.renderLayer, open: this.props.open, useLayerForClickAway: false })
}
If dialog was opened before theme change with this patch, changes will be reflected only after dialog reopening.

The core issue seems to be this one: https://github.com/facebook/react/issues/6599.
The workaround proposed by @bezrodnov is pretty brutal. We would basically unmount and mount again.
I would rather fill the gap by bypassing the context with a property where it's needed.

@oliviertassinari yes I agree with you on that but right now that issue is far from fixed, can we have the workaround in use right now? We could also use props in lieu but I'm not sure exactly what you have in mind. Can you comment on relevant parts of the pr? I'll update it with your suggestions

@puranjayjain Was simpler for me to propose fix. You can have a look at https://github.com/callemall/material-ui/pull/4548.

Thank you so much I tried to solve it the entire day!


List of public push webhooks

It would be nice to have a list of the public (if any) PUSH web hooks in the ZoL repos.
I'm considering setting up a Jenkins auto builder at home, but I need (would like) the URLs to subscribe to.

All of Github's webhooks are private as described in the documentation.  However, I'm find with registering one for you if you're interesting in setting up you own infrastructure.  All that's required is knowing which webhooks you want to receive and where to send them.

I see, thanx! I thought there was public ones as well (I've just started looking into this :). I'll let you know when I'm done in my end, thanx.

Please keep in mind the existing infrastructure in the back of your mind too.  Maybe some of what you're working on could be folded in to improve that automated testing.


[SPARK-33273][SQL] fix a race condition in subquery execution

What changes were proposed in this pull request?

If we call SubqueryExec.executeTake, it will call SubqueryExec.execute which will trigger the codegen of the query plan and create an RDD. However, SubqueryExec already has a thread (SubqueryExec.relationFuture) to execute the query plan, which means we have 2 threads triggering codegen of the same query plan at the same time.
Spark codegen is not thread-safe, as we have places like HashAggregateExec.bufferVars that is a shared variable. The bug in SubqueryExec may lead to correctness bugs.
Since https://issues.apache.org/jira/browse/SPARK-33119, ScalarSubquery will call SubqueryExec.executeTake, so flaky tests start to appear.
This PR fixes the bug by overriding executeTake and executeTail in SubqueryExec.
Why are the changes needed?

fix correctness bug.
Does this PR introduce any user-facing change?

no
How was this patch tested?

run build/sbt "sql/testOnly *SQLQueryTestSuite  -- -z scalar-subquery-select" more than 10 times. Previously it fails, now it passes.

cc @viirya @maropu @dongjoon-hyun @wangyum

Test build #132777 has started for PR 30765 at commit a5bb677.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37378/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37378/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37378/

Oh, it becomes more complex than the initial one. @cloud-fan , is this a final?

BTW, cc @sarutak since he has an another proposal.

Test build #132780 has started for PR 30765 at commit 7dbf490.

Test build #132780 has finished for PR 30765 at commit 7dbf490.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SubqueryExec(name: String, child: SparkPlan, maxNumRows: Option[Int])

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132780/

Added more comments, it's final now. Sorry I missed the perf impact in the first commit.

Test build #132777 has finished for PR 30765 at commit a5bb677.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132777/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37382/

Test build #132781 has started for PR 30765 at commit d66caca.

Test build #132781 has finished for PR 30765 at commit d66caca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SubqueryExec(name: String, child: SparkPlan, maxNumRows: Option[Int] = None)

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37383/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132781/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37383/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37383/

Good catch!

Test build #132803 has started for PR 30765 at commit 30a0f3f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37405/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37405/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37405/

Test build #132803 has finished for PR 30765 at commit 30a0f3f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master and branch-3.1.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132803/


[tlse] internal TLS support for manila

Creates certs for k8s service of the service operator when spec.tls.endpoint.internal.enabled: true
For a service like nova which talks to multiple service internal endpoints, this has to be set for each of them for, like:
  customServiceConfig: |
    [keystone_authtoken]
    insecure = true
    [placement]
    insecure = true
    [neutron]
    insecure = true
    [glance]
    insecure = true
    [cinder]
    insecure = true

Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/428
Depends-On: https://github.com/openstack-k8s-operators/openstack-operator/pull/620
Depends-On: https://github.com/openstack-k8s-operators/manila-operator/pull/212

the service operator PR merged, please rebase this one to update the go.mod

/retest openstack-operator-build-deploy-kuttl

/retest

recheck

recheck


feat: create customSelectorUrl config option

This new configuration option lets the user decide what URL to look out for once video uploading has been completed.
For my use case, I want the script to detect when a short has been uploaded, which doesn't currently work (the URL generated by youtube starts with https://youtube/shorts rather than https://youtu.be, meaning the processing fails if it cannot find the uploaded short)

This configuration option will allow the search selector to be set by the user in the Video object, like so:

This change is

Thanks for the PR

I opened as issue related to this MR. @lhjt would be apreciated if you could look into it to see if the MR I attached solves the same problem as you experienced but without the need for a config'.
https://github.com/fawazahmed0/youtube-uploader/issues/141


New exercise - darts

I haven't been able to take it out much because I don't have much time, I will add it as I have time.

I hope you well @ErikSchierboom


Add Evansville Indiana

Hi @mellard96, thanks for your interest in adding Evansville to the website. Emails on defund12.org are all written by community members. To add your city, you must provide:

Subject line for the email
Email addresses (at least one) of the government officials you’d like to receive the message
Detailed message concerning the budgeting decisions at stake in your community

Until you provide this content, we cannot post your city.
Follow our email style guidelines for quicker acceptance. Remember that messages must be city-specific and focused on defunding the police. If your message is copied from an external source, please provide a link to the original source.
Your request will be closed until you reply with the necessary content. Thank you!

I too an from evansville


experiments

Hello, may I ask how you adjust the parameters of other models to conduct comparative experiments? Can you share the code?

Most of the results are from the TimesNet paper, please refer to it.

Most of the results are from the TimesNet paper, please refer to it.

Due to the lack of GPU memory, there are only 3090
24G, I deleted the Electricity data field, and the other parameters remain the same. But I've been training for a long time, and I still haven't reached the accuracy in your table, and I've also tried to reduce the batch of the Electricity data field to 4, but it still doesn't work, and the MSE is probably 0.01 lower than in the table. Really looking forward to your reply, thank you


[FOR V2] Issue #87

https://github.com/chris-pearce/scally/issues/87

@stowball @kllevin can you please review?

@stowball @kllevin happy with this?

Unless I'm missing something, why would width: 100% be set if $apply-friendly-box-model == false? Wouldn't that push a input's width past its container because of the internal padding?

Also, I'd make your .ios class customisable like you do elsewhere:
@if $apply-top-inner-shadow-for-ios-inputs {
  .ios { }
}

Because I always use CssUserAgent for UA sniffing, which puts on a class of .ua-ios

@stowball https://github.com/chris-pearce/scally/commit/a54596f4b9442d626cf3be51fb17f962bcfb1b42, some comments here: https://github.com/chris-pearce/scally/blob/—87/core/base/_forms.scss#L54-L56.
For the .ios class fix see: https://github.com/chris-pearce/scally/issues/109.


Adding guide for setting up development environment.

A development guide will help new contributors set up the environment and thus create a smoother experience.
Maybe we can have a section for the same in the readme.md file or a separate contributing.md file.

Thanks @Abhijit! Are you working on this? If not, I can do it this weekend
On Wed, Jun 29, 2022, 23:44 Abhijit Deo @.***> wrote:

A development guide will help new contributors set up the environment and
thus create a smoother experience.
Maybe we can have a section for the same in the readme.md file or a
separate contributing.md file.
—
Reply to this email directly, view it on GitHub
https://github.com/SforAiDl/jeta/issues/20, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANCPEQVHI7NJJLIXLBZ3SIDVRSHCDANCNFSM52GVG2NA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Great! I think a separate CONTRIBUTIONS.md file would be better.
On Thu, Jun 30, 2022, 17:18 Abhijit Deo @.***> wrote:

yes, will do
On Thu, Jun 30, 2022 at 7:22 AM Vedant Shah @.***>
wrote:

Thanks @Abhijit! Are you working on this? If not, I can do it this
weekend
On Wed, Jun 29, 2022, 23:44 Abhijit Deo @.***> wrote:

A development guide will help new contributors set up the environment
and
thus create a smoother experience.
Maybe we can have a section for the same in the readme.md file or a
separate contributing.md file.
—
Reply to this email directly, view it on GitHub
https://github.com/SforAiDl/jeta/issues/20, or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ANCPEQVHI7NJJLIXLBZ3SIDVRSHCDANCNFSM52GVG2NA

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/SforAiDl/jeta/issues/20#issuecomment-1170662635, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ARLRQF3BN2PJFSJ3VTOTQHTVRT4UVANCNFSM52GVG2NA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
The information contained in this electronic communication is intended
solely for the individual(s) or entity to which it is addressed. It may
contain proprietary, confidential and/or legally privileged information.
Any review, retransmission, dissemination, printing, copying or other use
of, or taking any action in reliance on the contents of this information
by
person(s) or entities other than the intended recipient is strictly
prohibited and may be unlawful. If you have received this communication in
error, please notify us by responding to this email or telephone and
immediately and permanently delete all copies of this message and any
attachments from your system(s). The contents of this message do not
necessarily represent the views or policies of BITS Pilani.
—
Reply to this email directly, view it on GitHub
https://github.com/SforAiDl/jeta/issues/20#issuecomment-1171121032, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANCPEQXRYBNKLXFKT77YRLTVRWCRPANCNFSM52GVG2NA
.
You are receiving this because you commented.Message ID:
@.***>


problem with powermate.exe

Hi, i have a problem with this software, my powermate work only when the powermate.jar is running, but when i try to start powermate.exe nothing appear, the only powermate.exe that start is the original file provided from the ufficial website(obv it cannot configure device). what i can try to solve? thanks

powermate.exe tries to find your system Java installation, then runs the JAR. You can just run the JAR yourself, it's the same.

I'm using the .jar currently, so I can only go to adjust the volume from the powermate, but I have no way of configuring it, if I open powermate.exe, nothing is opened

Configure what?

all the command, if i press, if i rotate etc..

This app controls the volume only. If you want to do anything else, you'll need to write Java code for that. Probably if this app has the USB device open, other apps cannot also control the device.
FWIW, I stopped using my Powermate because Griffon has poor APIs and poor software support, especially on Windows. Their wireless knob doesn't work on Windows at all.


feat(button): Added share button (#162)

Proposed Changes

Added a button after the footer to open the share menu of the device. Closes #162

It uses a new variable SHARE that contains the URL, the OG_TITLE, and the OG_DESCRIPTION to style the share menu.

I've tested the button on Chrome/Edge/Firefox (for Firefox I needed to set dom.webshare.enabled to true in the config) and on Android,  it needs to be tested on Safari/IOS (I don't own Apple product.)

Android:

Firefox:

Edge:

Chrome:

Checklist

[x] Tested locally
[x] Ran yarn ci to test my code -->  I did  it  but  I have an error  Could not find icon { prefix: 'fas', iconName: 'share-nodes' }
[x] Did not add any unnecessary changes
[x] All my changes appear after other changes in each file
[x] Included a screenshot (if adding a new button)
[ ] 🚀

Nice!  Thank you so much!


Binary releases?

Hi,
this is exactly what I need and I contributed some things to improve usability of it.
Hope you like the changes :)
One other thing I thought of: add binary releases to the releases page. I'd happily contribute a PR to add that, too.. If you agree with it?
Thanks!

Hey thanks for the support and contributing! The PRs look great, I'll approve them shortly.
I'm supportive of binary releases, go for it!


Add access to pcap_sendqueue functions

pcap_sendpacket is very inefficient.
The sendqueue functions allow raw packet sending much more efficiently due to reduced context switching in the kernel.
I have included them in a manner I believe fits with this module. Please consider accepting this pull request.

Problem located, I will re-up when fixed.


Fix incorrect argument order when calling previous error handler

Think this is the correct argument order, see here: https://www.php.net/manual/en/function.set-error-handler.php#refsect1-function.set-error-handler-parameters
Easy way to reproduce is if you set previousErrorHandler to Ignition error handler, you should get a Argument #1 ($level) must be of type int, string given error

Thank you!


Testing

initial pull request for lens testing files

Abstracted library with testing scripts for contextual lenses, encoders, and general train utils.


fix(ci): Override ANDROID_NDK and ANDROID_NDK_HOME

This should fix the flaky kotlin builds if the NDK is actually installed.

GitHub lies! 😭
https://github.com/firezone/firezone/actions/runs/7992402004/job/21825820184?pr=3716


display elapsed time during running catkin

I'm not sure how to pass argument to enable/disable dis feature, should we add new function aruguments and fix catkin_make commands?

Yes, this feature should be optional and disabled by default. You can add command line options for both catkin_make and catkin_make_isolated for that.
Please also avoid having a global start time in the builder module.

Please consider to update the PR based on the above comment in order to be merged.

It might be more flexible to use an existing tool for that feature. Basically the functionality would apply to any tool and I would rather avoid to add it everywhere.
Please take a look at ts -r from http://joeyh.name/code/moreutils/
I will close this for now. If you think the external tool is not sufficient for whatever reason please comment.


Allow overriding of keybindings from a config file

This would prevent the need to account for all different OS's conflicting key bindings (or if you would like the simply remap keybindings). This is based off of comments from #41 .

This issue has been fixed by 6f005724d961e697ceb9802fc9b8d37aa76c9605 (@TJM, go nuts!)