Unable to fetch the custom parameters using 'with'

I have already implemented datatables as a service and it works fine without any issue.
What I want to achieve is, let's say there is a table with 1000 records, and I don't want to show all of them at once say on index.php, on the load I want to show only the current month's records. The same index.php page contains a date range and a form submit button which reloads the page by passing the date range into the controller@index.
On the initial load, as the user cannot pass any date, so in the controller, I set the dates dynamically based on the month and returns the view with datatable
Now, if the user wants to view the previous month data, he has to choose the date range and click on filter.
The request goes to the same controller@index function, as it has parameters, the from and to dates are set from the request.
Now going down to the return of index function ie.
return $dataTable->with(['filterFromDate'=>$filterFromDate,'filterToDate'=>$filterToDate])->render(....)
the 'filterFromDate' and 'filterToDate' takes the month's 1st day and the last day as if the request didn't have any parameters. As a matter of fact, the dates are properly passing into the index function, but not to the datatables.
Please help with the issue
public function index(BookDataTable $dataTable, Request $request){
    if($request->from_date && $request->to_date){
        $filterFromDate = date_format(new \DateTime($request->from_date),"Y-m-d");
        $filterToDate = date_format(new \DateTime($request->to_date),"Y-m-d");
    }else{
        $filterFromDate = date('Y-m-01');
        $filterToDate = date('Y-m-t');
         //These values always gets passed into the BookDataTable
    }
  .
  .
  .
  <!-- I am not altering the $filterFromDate and $filterToDate values in between>
  .
  .
  return $dataTable->with(['filterFromDate'=>$filterFromDate,'filterToDate'=>$filterToDate])->render('books.datatable-index', compact('leads','filterFromDate','filterToDate'));

}

$dataTable->with(['filterFromDate'=>$filterFromDate,'filterToDate'=>$filterToDate]) on assigns a property on your BooksDataTable class. You still need to set this on your query filters manually.
Something like:
class BooksDataTable extends ... {
  function query(Model $model) {
    return $model->newQuery()->whereBetween('date', [ $this->filterFromDate, $this->filterToDate ])...;
  }
}

I am already passing it into the query, but it seems that the datatable service is somehow caching the initial request made with the dates passed by the else block, that is why it doesn't consider the subsequent requests dates.
What i did as a workaround is by storing the dates for every request in session and overriding the constructor like this -
public function index(BookDataTable $dataTable, Request $request){
    session()->put('from_date',$filterFromDate);
    session()->put('to_date',$filterToDate);
    \\Adding into session after the if else block
}

class BooksDataTable extends Datatable
{
protected $fromDate ='';
protected $toDate = '';
function __construct(Datatables $datatables, Factory $viewFactory)
{
    $this->fromDate = session('from_date');
    $this->toDate = session('to_date');

    parent::__construct($datatables, $viewFactory);
}

}
Now the search on filters are working fine, but if i use the search box to filter the results, it doesn't search from the already filtered results, rather it does from all the records.

I had another workaround to deal with it, for every search in the search box, it again makes a call, so i had to deal it in the index function
    if(!empty($request->from_date) && !empty($request->to_date)){
        $filterFromDate = date_format(new \DateTime($request->from_date),"Y-m-d");
        $filterToDate = date_format(new \DateTime($request->to_date),"Y-m-d");
    }else if(!empty(session('from_date')) && !empty(session('to_date'))){
        $filterFromDate = session('from_date');
        $filterToDate = session('to_date');
    }else{
        $filterFromDate = date('Y-m-01');
        $filterToDate = date('Y-m-t');
    }

This works properly on-
Normal load(triggers else block)
Filtered load(triggers if block)
Searched load(triggers else if block) of the Datatable as a service
I am good as of now, but frankly speaking, i wanted it to pass using 'with' api with variables and not via session data, may be because of caching or first initialization of Datatable instance in index function ,or may be due to some othe reason that i may be unaware of , this api is not behaving properly. Let me know if you can somehow reproduce the same issue and get the 'with' api working.


feat(task-details): add task logs (#1004)

Adds ability to view logs for a specific task

@thojkooi FYI https://github.com/portainer/portainer/pull/1217 relocated the state registration in app/routes.js

Rebase has been done. I will refactor the ContainerLogs, ServiceLogs, TaskLogs components to make use of $resource and promises.

Closed in favor of #1666


Linting software

Proposing implementing upstream-maintained linting software for duckscript.
Tracking relevant to https://github.com/sagiegurari/cargo-make/issues/486

I might be able to do something basic like checking that i'm able to parse the file.
since the language has almost nothing and most of the stuff is in the commands, full linting support or more complex parsing checks might not be possible.

I might be able to do something basic like checking that i'm able to parse the file.

That would be sufficient for now imho.

linter is now available in the 0.6.9 branch.
simply run
duck --lint somefile.ds

it checks the script parses correctly and few naming conventions.


Vtgateclienttest

@dumbunny this is to facilitate internal tests, and also add more coverage.
After import, I will remove the duplicate cut&paste stuff I had to add earlier.

LGTM so I can merge.

LGTM


Docker build: No package git222 available

I tried to follow the steps from https://github.com/onivim/oni2
Here is the output
❯ sudo docker build --network=host -t centos scripts/docker/centos

Sending build context to Docker daemon  3.072kB
Step 1/26 : FROM centos:7
 ---> eeb6ee3f44bd
Step 2/26 : RUN yum -y update
 ---> Using cache
 ---> f699896b4a44
Step 3/26 : RUN yum -y install centos-release-scl
 ---> Using cache
 ---> e31bd9371977
Step 4/26 : RUN yum-config-manager --enable rhel-server-rhscl-7-rpms
 ---> Using cache
 ---> a540abb12442
Step 5/26 : RUN yum -y install llvm-toolset-7.0
 ---> Using cache
 ---> eb3303b35bf1
Step 6/26 : RUN scl enable llvm-toolset-7.0 'clang -v'
 ---> Using cache
 ---> f09f496296eb
Step 7/26 : RUN yum -y install gcc-c++ make sudo
 ---> Using cache
 ---> 07982e490ef4
Step 8/26 : RUN curl -sL https://rpm.nodesource.com/setup_10.x | sudo -E bash -
 ---> Using cache
 ---> 8c2a1e43cf9f
Step 9/26 : RUN yum -y install nodejs npm coreutils grep tar sed gawk diffutils autoconf unzip python3
 ---> Using cache
 ---> 21e71a04e57c
Step 10/26 : RUN yum -y install file fuse fuse-devel wget bzip2-devel libXt-devel libSM-devel libICE-devel ncurses-devel libacl-devel libxrandr-devel libXinerama-devel libXcursor-devel libXi-devel mesa-libGL-devel mesa-libGLU-devel gtk3-devel perl-Digest-SHA bzip2 m4 patch which cmake3 git libxkbfile-devel
 ---> Using cache
 ---> fadb2ad26a04
Step 11/26 : RUN yum -y install perl perl-Thread-Queue
 ---> Using cache
 ---> 5d212ff9cb2f
Step 12/26 : RUN yum -y install /usr/lib64/libasan.so.0.0.0
 ---> Using cache
 ---> 8ee911b71773
Step 13/26 : RUN rpm -i https://download-ib01.fedoraproject.org/pub/epel/7/x86_64/Packages/c/colm-<IP_ADDRESS>-2.el7.x86_64.rpm
 ---> Using cache
 ---> b3e1e9f0d1b4
Step 14/26 : RUN rpm -i https://download-ib01.fedoraproject.org/pub/epel/7/x86_64/Packages/r/ragel-<IP_ADDRESS>-2.el7.x86_64.rpm
 ---> Using cache
 ---> 5b06cc7b24bc
Step 15/26 : RUN npm install --global --unsafe-perm=true<EMAIL_ADDRESS> ---> Using cache
 ---> 158c232338be
Step 16/26 : RUN npm install --global node-gyp
 ---> Using cache
 ---> c5fc3471318a
Step 17/26 : RUN yum -y install nasm
 ---> Using cache
 ---> 2fd4b2714fa3
Step 18/26 : RUN yum -y install https://repo.ius.io/ius-release-el7.rpm
 ---> Using cache
 ---> b767b79ad683
Step 19/26 : RUN yum -y remove git
 ---> Using cache
 ---> aba58e66bb8c
Step 20/26 : RUN yum -y install epel-release
 ---> Using cache
 ---> 547faa08a985
Step 21/26 : RUN yum -y install git222
 ---> Running in 9509b4019924
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: mirror.airenetworks.es
 * centos-sclo-rh: mirror.airenetworks.es
 * centos-sclo-sclo: mirror.airenetworks.es
 * epel: mirror.in2p3.fr
 * extras: mirror.airenetworks.es
 * updates: mirror.airenetworks.es
No package git222 available.
Error: Nothing to do
The command '/bin/sh -c yum -y install git222' returned a non-zero code: 1

same problem. please fix it,

Fixed it in #3865. It might break soon, though.

Fixed it in #3865. It might break soon, though.

After that this step worked but the following didn't: https://pastebin.com/nU5tmtb9

Known. Waiting on a release from esy-skia... https://github.com/revery-ui/esy-skia/pull/42

@TheTechRobo is this fixed ?

It's fixed with esy-skia, but it hasn't made it out into a release. You can probably change the commit hash used as a dependency, but I haven't looked into it.

It's fixed with esy-skia, but it hasn't made it out into a release. You can probably change the commit hash used as a dependency, but I haven't looked into it.

Where to change hash commit ?

No idea.

Any update ?

Nothing that I know of.


Support cachegrind as a tool

Hi,
when you want to diff two profiles using cg_annotate --diff it seems like this is only possible for cachegrind but not callgrind. Would it be possible to add support for running cachegrind too?

Hi. Yeah, callgrind diffs are only possible with flamegraphs but not with a command-line tool in the terminal. There is a the option to produce differential flamegraphs with
LibraryBenchmarkConfig::default()
    .flamegraph(FlamegraphConfig::default().kind(FlamegraphKind::Differential))

and you can view the resulting svg file in the browser.
Although adding cachegrind to the tools is certainly possible, there won't be a calibration run or something similar to optimize the statistics to the benchmarking function as it is possible with callgrind. So far, it didn't make much sense to offer a cachegrind run...
However, with the upcoming release of iai-callgrind there are the valgrind client requests available and since valgrind version v3.22, the cachegrind client requests start_instrumentation and stop_instrumentation, so maybe it starts making sense to add cachegrind to the available tools.

I thought a little bit more about this and I currently see two different possibilities. Add an option to run cachegrind (with all limitations) instead of callgrind. Or, add an option to run cachegrind in addition to callgrind. In both cases you're on your own to optimize the benchmark run for example with client requests if your valgrind version is recent enough. What do you think?
Out of curiosity, have you tried differential flamegraphs? Or, do you still prefer cg_annotate --diff?


Failed to add reference. The package 'Microsoft.Azure.Management.AppService.Fluent' tried to add a framework reference to 'System.Xml.XDocument' which was not found in the GAC. This is possibly a bug in the package. Please contact the package owners for assistance.

I can't seem to install "Microsoft.Azure.Management.Fluent" because the installation of "Microsoft.Azure.Management.AppService.Fluent" always fails with this error:

Failed to add reference. The package 'Microsoft.Azure.Management.AppService.Fluent' tried to add a framework reference to 'System.Xml.XDocument' which was not found in the GAC. This is possibly a bug in the package. Please contact the package owners for assistance.

I am targeting .NET 4.5.2

Facing the same issue. Any resolution for this yet?

I wrestled with this so much. I was finally able to resolve it (kind of). This was so annoying.
It seemed to me to work if I started a new project in Visual Studio, but I couldn't add the package in my existing project. I therefore had to add a separate project to which I could then install the package. I could then reference my secondary project from the other project. This means you'll have to do your Azure API calls in the second project, but at least it works! Hoping for a real solution sometime soon.

I'm hitting this issue to.  Unfortunately, adding the reference to a different project is not an option for me.  I need to modify our existing projects to use the APIs in this package.

Encountered this as well.
I tried manually installing the System.Xml.XDocument nuget to get over this issue, unfortunately it wasn't enough to resolve the issue. After installing the nuget, I had to manually add a reference to the DLL in my project from the nuget's lib\netstandard1.3 folder.
After doing that, the nuget installs properly. Not sure if it'll run properly this way. I guess this is a workaround until there's an official solution.

Fixed in Fluent Management SDK V1.1.


Make glib::value::GetError fields publics

... so that we can read them outside of the module and we can build an error for use in assert_eq! expressions.

Or a constructor? Either way seems fine to me

Yeah, I'm not sure yet. We don't want users to change the fields values, but OTOH they might want to read the fields.

Of course adding a constructor is useful, there's no question about this. One argument in favour of setting the fields as public is that when we declare an Error based on an enum, the variants fields are public.


Stop next change from merging with previous one after inactive period.

Addresses #362.
This should really be changed in UndoFX. But since that won't have a new release in the foreseeable future, this can bring the same functionality until such a release exists.

This PR needs a test to prove that the merge prevention actually occurs.

I also realized that the test in UndoManagerTest called "deletingTextThatWasJustInsertedShouldNotMergeTheTwoChanges()" is no longer needed due to reverting back to the original merge behavior in #496. I'll remove that in a separate PR.


Git clone support ssh protocol

The network connection between CHINA and github server is unstable. Git clone intermittently fail for "Encountered end of file" by HTTPS protocol. Git clone by SSH protocol is more stable than HTTPS protocol. This patch support SSH git clone, when the environment variable USE_GIT_SSH set to "true"
Fixes: #3779

After discuss to lvfei, I think we need to refactor this PR. After we finish fractor we reopen this PR.


Disconnects when strong rumble occurs

BlueRetro firmware version
v1.8.4
BlueRetro firmware specification
HW1
BlueRetro firmware variant
System specific
BlueRetro hardware type
External adapter with multiple hardwired cord
Manufacturer
Jerilla
System used
SEGA Dreamcast
Bluetooth controller brand & name
PS4 & Xbox One S
What is problem? (only list ONE problem per report)
If there is strong vibration, the controller disconnects. It feels as if the vibration lasts too long and then it becomes disconnected. If you turn off the vibration, there is no disconnect at the points in the game where it happens.
What did you expect to happen?
The controller should remain connected, even with strong vibration.
Attach files like logs or Bluetooth traces here
No response

Dreamcast rumble is highly experimental I still need to reverse engineer it properly as noted in this earlier bug #5 .
Closing this one as duplicate.


Mobile App will not connect to IoTHub

Not sure why the IoS app will not connect to the IoTHub. I entered the IoTHub name in the DeviceProvisionHandler and still no conection.

Make sure you use the right format for the host name (no http:// at the beginning, no slash at the end). Also please can you give more details about the failure? Do you use your own IoTHub and Azure Mobile App Service? Have you tried debugging it? What is the line that fails?

here's the format:  DefaultHostName = "mydriving-xxxxxxxxxxx.azure-devices.net";
I used my own IoTHub and App service.  I haven't run any debugging. The app runs ok on the iPhone but the device is not registering with the IoTHub.

@sigwaveLabs did you provisioned whole solution? you need at least:

mobile app (don't forget configure authorization via twitter/fb/ms)
sql with tables - here are stored user devices/profiles with iot hub connection string per device
iot hub

I ran the azure powershell script, authorized only fb, added the HockeyApp ID to the Logger.cs

try to use Device Explorer to see if your device is registered in  IoT Hub https://github.com/Azure/azure-iot-sdks/blob/master/tools/DeviceExplorer/doc/how_to_use_device_explorer.md
and look into Devices table if there is your device
best solution is to debug your app .. you can do it localy on your computer if you have WIN10 - change platform to x86/64 and target Local Machine in your visual studio and setup UWP app as startup project - MyDriving.UWP
or try tu debug it on iPhone

@sigwaveLabs I assume you also use your own sql database.
Could you check table UserProfiles in mydrivingdb?
Is your user registered successfully?

Yes, the db was created via the script, the UserProfile shows that I successfully register with fb.

Here's what I found from debug:
[0:] Unable to provision device with IOT Hub: Cannot cast Newtonsoft.Json.Linq.JArray to Newtonsoft.Json.Linq.JToken.2016-05-04 01:36:56.149 MyDrivingiOS[32562:405886] Unable to provision device with IOT Hub: Cannot cast Newtonsoft.Json.Linq.JArray to Newtonsoft.Json.Linq.JToken.
I then updated Newtonsoft.Json to v8.0.3
Now debug shows:
2016-05-04 02:06:30.434 MyDrivingiOS[34136:428746] Unable to provision device with IOT Hub: Value cannot be null.
Parameter name: token[0:] Unable to provision device with IOT Hub: Value cannot be null.
Parameter name: token

it means that mobile app (my driving service) don't return SAS for device
you can try to debug it remotely against azure (I assume that you published service to mobile app, because your user is regsitererd and can login)
you don't need to change web.config, all necessary values should be set-up at azure web settings level

@sigwaveLabs  Did you set IoTHubConnectionString in your app service?
You need to add a config setting "IoTHubConnectionString" in
App service (mydriving-sth) -> all settings -> application settings -> App settings
You can get the string value from
Azure IoT Hub (mydriving-sth) -> all settings -> shared access policies -> iothubowner -> connection string - primary key

@xiangyan99
The connection string looks good in the App service settings as well.

Also, I want to note that I ran the same app on my device connected to the sandbox and that seemed to work.

From the AppService Dubug:
w3wp.exe Warning: 0 : Message='UserMessage='No HTTP resource was found that matches the request URI 'https://mydriving-xxxxxxxxxxx.azurewebsites.net/tables/POI?$filter=(updatedAt ge datetimeoffset'1970-01-01T00:00:00.0000000%2B00:00')&$orderby=updatedAt&$skip=0&$top=50&__includeDeleted=true'.'', Operation=ApiControllerActionSelector.SelectAction, Status=404 (NotFound), Exception=System.Web.Http.HttpResponseException: Processing of the HTTP request resulted in an exception. Please see the HTTP response returned by the 'Response' property of this exception for details.
at System.Web.Http.Controllers.ApiControllerActionSelector.ActionSelectorCacheItem.SelectAction(HttpControllerContext controllerContext)
at System.Web.Http.Controllers.ApiControllerActionSelector.SelectAction(HttpControllerContext controllerContext)
at System.Web.Http.Tracing.Tracers.HttpActionSelectorTracer.<>c__DisplayClass2.<System.Web.Http.Controllers.IHttpActionSelector.SelectAction>b__0()
at System.Web.Http.Tracing.ITraceWriterExtensions.TraceBeginEnd(ITraceWriter traceWriter, HttpRequestMessage request, String category, TraceLevel level, String operatorName, String operationName, Action1 beginTrace, Action execute, Action1 endTrace, Action1 errorTrace) w3wp.exe Warning: 0 : Message='UserMessage='No HTTP resource was found that matches the request URI 'https://mydriving-xxxxxxxxxxx.azurewebsites.net/tables/POI?$filter=(updatedAt ge datetimeoffset'1970-01-01T00:00:00.0000000%2B00:00')&$orderby=updatedAt&$skip=0&$top=50&__includeDeleted=true'.'', Operation=POIController.ExecuteAsync, Status=404 (NotFound), Exception=System.Web.Http.HttpResponseException: Processing of the HTTP request resulted in an exception. Please see the HTTP response returned by the 'Response' property of this exception for details.    at System.Web.Http.Controllers.ApiControllerActionSelector.ActionSelectorCacheItem.SelectAction(HttpControllerContext controllerContext)    at System.Web.Http.Controllers.ApiControllerActionSelector.SelectAction(HttpControllerContext controllerContext)    at System.Web.Http.Tracing.Tracers.HttpActionSelectorTracer.<>c__DisplayClass2.<System.Web.Http.Controllers.IHttpActionSelector.SelectAction>b__0()    at System.Web.Http.Tracing.ITraceWriterExtensions.TraceBeginEnd(ITraceWriter traceWriter, HttpRequestMessage request, String category, TraceLevel level, String operatorName, String operationName, Action1 beginTrace, Action execute, Action1 endTrace, Action1 errorTrace)
at System.Web.Http.Tracing.Tracers.HttpActionSelectorTracer.System.Web.Http.Controllers.IHttpActionSelector.SelectAction(HttpControllerContext controllerContext)
at System.Web.Http.ApiController.ExecuteAsync(HttpControllerContext controllerContext, CancellationToken cancellationToken)
at System.Web.Http.Tracing.Tracers.HttpControllerTracer.d__5.MoveNext()

@sigwaveLabs  Did you change the code under src\MobileAppService\MyDrivingService\Controllers\POIController.cs?
And could you check if POIs table exists in your database mydrivingDB?

@xiangyan99
No code changes, using the stock service created by the script. The POIs table exists, no data in the table.

are you really using mydriving-xxxxxxxxxxx.azurewebsites.net or real address you can find in blade for mobile app at azure portal?

This is not the real address. I just rebuilt the entire solution from a fresh clone, deployed the app and still have the same problem. I suspect I may be missing and important step. I get errors on the rebuild for the iOS app and need to update packages for the build. The only code I changed are the AzureVlient web address, the IoTHub name into the DeviceProvision profile and the hockey app is for iOS in the logger.

did you publish MyDrivingService from visual studio to mobile app in azure?
I have no more ideas, try to remote debug MyDrivingService and try to debug your app in mobile

It was published using the script. I'll see if I can update and publish just the service,nadler some debugging. I'll let you know what I find. Thanks:)

--> It was published using the script.
Did you rebuild it and re-publish it?
You need to rebuild the project and publish the new binaries to make the new IoThub string work.

@xiangyan99
ok, i'll try that. Do I need to just download the publish settings? Do I need to change anything in the web.conf?

as I mentioned earlier you don't need to change it in web.config, portal settings override it and you have it correctly as you wrote as reply to commet of @xiangyan99
but only to be sure:
You need to have config setting "IoTHubConnectionString" in
App service (mydriving-xxxxx) -> all settings -> application settings -> App settings
You can get the string value from
Azure IoT Hub (mydriving-xxxxx) -> all settings -> shared access policies -> iothubowner -> connection string - primary key
--

install azure SDK
build myDrivingService it in Visual studio
right click at project and select Publish
select publishing to azure and find your mobile app (App service)
select and publish there - for remote debugging select debug version,

@sigwaveLabs is it working for you?

@sigwaveLabs the mobile application caches the hostname and the DeviceConnectionString in Settings; if you change the hostname make sure you uninstall the old application from the device.
Some suggestions for debugging:

Put breakpoints in ProvisionDevice() in file DeviceProvisionHandler.cs
Look at DeviceConnectionString to make sure it's not empty.
if provisioning fails look what is the exception thrown by client.InvokeApiAsync("provision", null, HttpMethod.Post, myParms)
Put a breakpoint in OBDDataProcessor.cs, method SendTripPointToIOTHub, at line 103: await iotHub.SendEvent(packagedBlob)
See if there is an exception thrown.
You can send me an email with the endpoints (IoT hostname, mobile app name) so that I can try that as well.

@sigwaveLabs please reopen, if your problem perisists

can i ask about connection Mobile app service with Mobile app and what is configuration i should to do it by steps ? i looked at documentation on azure but i still stuck in connection and db still emty


Having range_of as a pure function is inconsistent.

let x = 42
let y = 42

val lem : (#a:Type) -> (#b:Type) -> (f :(a -> Tot b)) -> (x : a) -> (y : a) ->
                Lemma (requires (x == y))
                      (ensures (f x == f y))
let lem #a #b f x y = ()

let p : squash False =
    lem range_of x y

The normalizer was reducing range_of x == range_of y to False, which can be avoided simply enough by always returning Unknown when comparing ranges, thus preventing that reduction.
So, should be fixed in my branch and will merge later.


Add _jdk dependency to binary runfiles and scalac action

The default @local_jdk just imports _java and _javac as raw binaries
without establishing a dependency on/runfiles of _jdk. Thus, all uses of
those should manually add _jdk as a dependency.
In the scalac execution ation that compiles scala, also added _jdk in
case _scalac ever was replaced by a binary that wasn't a java_binary.
Haven't been able to test locally in a hermetic system with the default local_jdk so should wait until CI green before integrating....

Can one of the admins verify this patch?

Actually we probably need Oscar to say:
test this please
On Tue, 28 Mar 2017 at 8:04 bazel.io machine account <
<EMAIL_ADDRESS>wrote:

Can one of the admins verify this patch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/172#issuecomment-289664021,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFx3hrid9846AZRS9ylLq0OYM7kBFks5rqJTugaJpZM4MrJH5
.

@johnynek @damienmg can one of you please trigger this for ci.bazel.io?
It seems travis doesn't provide confidence since it doesn't run the build sandboxed

test this please

test this please

Test this please.

is this a bug in bazel? Why do we need to explicitly add this dep? cc @damienmg

retest this please

Not sure if that's a bug but according to @sdtwigg we don't do it internally so I would say we should just fix the dependencies in Bazel.

@sdtwigg why is the last commit needed? ci.bazel.io was green before it, wasn't it?

According to the screen in our office, ci is red on darwin at HEAD: http://ci.bazel.io/job/rules_scala/684/

It was not. There was a ctx.action in _build_nosrc_jar that was also invoking _java. The original commit was specifically targeted at fixing up the binary runfiles (and the scalac inputs because I had thought of it).
The second commit was after I realized it was still failing and did an 'audit' (ctrl-f for ctx.action and ctx.runfiles) for what all needed a _jdk.
The third commit was to undo the change to using ijar from java provider. (That was an experimental change that had snuck in on accident since I had done some experiments in my personal tree on switching to java_common stuff). That change did seem to work but I am nervous about using it without more extensive testing.
Finally, the fourth is just the first three all rebased together so the merge commit message makes sense.

@sdtwigg I understand. Are there changes which aren't protected by a test? The reason this troubles me is since it can break without us noticing. I understand the reason for the scalac case future-proofing and that has a comment. Any other cases? And do they have a big red flag comment on them?

Are you referring to potential future changes that silently break or changes from #171 that might still be wrong?
Regardless....
Over the weekend, I was able to spend some time actually unpacking how ctx.action found its runfiles as well as what each argument in ctx.runfiles actually meant/where to find runfiles associated with targets. Quick summary of findings:

ctx.action will look through all of its inputs and will only add runfiles to those inputs that are coming from attributes marked as executable=True. (This is why I suggest using ctx.executable._whatever in a ctx.action, to ensure that either the action will pickup runfiles or error if the target gets unmarked as an executable).
ctx.runfiles files and transitive_files both just add runfiles to the same list. transitive_files is just a 'lazier' flattening (a depset) and so is slightly more efficient way to pass in transitive runfiles from dependencies. Notw that ctx.runfiles itself does not transitive searching (excluding collect_data and collect_default, which would only search deps, srcs, and data attributes anyway).
ctx.attr.*.data_runfiles|default_runfiles should have runfiles for 'any labe'l attr (not extensively tested but bazel code seems to confirm), regardless of whether it was marked as executable or not or was created by a rule that returned a runfiles 'provider' . (In the latter case, would just get an empty depset).

Really, _java and _javac threw me a bit for a loop since they are executable but don't actually attach their needed runfiles. (_jar and _jar_bin should be fine since they are the deploy_jar and binary-via-launcher from a java_binary rule, respectively. Thus, they should both setup runfiles, including a JDK.)

Concerned about

potential future changes that silently break

Thanks for the fix @sdtwigg

I think it is good not to break users, BUT if we find bugs people don't
need to upgrade. They can stay on an old buggy version if they like. I
think we should think twice before leaving bugs due to perceived
compatibility reasons at this stage (how many users do we really have?)
On Mon, Mar 27, 2017 at 23:52 Ittai Zeidman<EMAIL_ADDRESS>wrote:

To be more accurate- about potential future changes that silently break in
rules_scala build but loudly break for users which, for some reason, depend
on this behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/172#issuecomment-289720232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEJdqVhyzJwCAnoetxoLePBhFfSSn7Lks5rqNhHgaJpZM4MrJH5
.

I might have been unclear.
I didn't mean not to fix bugs.
I meant that if we fix anything we should have a test for it so that if we
want to later refactor for whatever reason we'll know we broke the
feature and can be intentional about it. One obvious way is release notes.
I think implicit context is problematic since it's forgotten.
That's why I asked Stephen if there are missing tests.
Hope I've made myself more clear,
Ittai
On Wed, 29 Mar 2017 at 10:19 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

I think it is good not to break users, BUT if we find bugs people don't
need to upgrade. They can stay on an old buggy version if they like. I
think we should think twice before leaving bugs due to perceived
compatibility reasons at this stage (how many users do we really have?)
On Mon, Mar 27, 2017 at 23:52 Ittai Zeidman<EMAIL_ADDRESS>wrote:

To be more accurate- about potential future changes that silently break
in
rules_scala build but loudly break for users which, for some reason,
depend
on this behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/bazelbuild/rules_scala/pull/172#issuecomment-289720232
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAEJdqVhyzJwCAnoetxoLePBhFfSSn7Lks5rqNhHgaJpZM4MrJH5
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/172#issuecomment-290004929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFxnxFLIrHMjPfiNeiG3gDzUvkmyGks5rqgYQgaJpZM4MrJH5
.

Nothing immediately comes to mind; however, Bazel/Linux sandboxing isn't my area of expertise.
It is odd that only Darwin/macOS was so sensitive to sandboxing and neither of the Linux-based CI targets. I did test these rules locally with bazel 0.4.5 on my workstation, completely isolated from our regular build environment, although unfortunately it clearly wasn't completely sandboxed. Then, when I tested it in our regular build environment (which is substantially better at ensuring sandboxing), as Damien mentioned, there were a few subtle differences in how the local_jdk equivalent is actually setup causing me not to notice  the issue. Fortunately, I should be more aware about checking for this in the future (and added the comments for others who might be similarly tempted to remove those inputs).
That said, I'm hoping that the reliance on knowing that java (and probably javac) has an undeclared dependency on the a jdk is temporary and that the local_jdk workspace is changed to be more honest about setting up runfiles for its executables.
I did try to add tests in a wider range of test scenarios in #171. For example, running a scala_binary in a test or genrule simply did not work for me before. I was also hoping to do some tests, eventually, with a scala_binary calling a java_binary or scala_binary given to it as a data dependency or as a command-line arg in a genrule. This would hopefully expose if exporting JAVA_RUNFILES was good or bad. (Although, would need to start with tests using just java_binary to see what the 'expected' behaviors/patterns are for these scenarios.)

Ok. I think since we're aiming for an actual fix in bazel itself we can move on.
Thanks for the explanation.


发文字，经常掉线，需要重新扫码登录

应用场景：机器人发图文内容
经常性被踢下线，需要重新登录，然后因为被踢下线，提示后边的错误
想请问下，是服务不稳定，还是图文频率不合适
2022/07/24 00:37:01 PuppetService Start()
2022/07/24 00:37:05 PuppetService onGrpcStreamEvent({type:EVENT_TYPE_SCAN payload:{"qrcode":"http://weixin.qq.com/x/AdnFABCDNBuGGiy7DDDD","status":2}})
2022/07/24 00:37:05 PuppetService onGrpcStreamEvent({type:EVENT_TYPE_HEARTBEAT payload:{"data":"Wechaty Puppet gRPC stream connect successfully"}})
2022/07/24 00:37:12 PuppetService RoomList()
2022/07/24 00:37:12 RoomFactory err:  rpc error: code = Unknown desc = TypeError: Cannot read properties of undefined (reading 'getRoomIds')
at PuppetPadlocal.roomList (file:///wechaty/node_modules/wechaty-puppet-padlocal/src/puppet-padlocal.ts:1117:28)
at roomList (file:///wechaty/node_modules/wechaty-puppet-service/src/server/puppet-implementation.ts:1207:41)
at Object.roomList (file:///wechaty/node_modules/wechaty-puppet-service/src/auth/auth-impl-token.ts:49:18)
at handleUnary (/wechaty/node_modules/@grpc/grpc-js/src/server.ts:925:11)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
还有另外一种错误
rpc error: code = Unknown desc = VError: [tid:5d531870] request has been cancelled for reason: SERVER_ERROR: 2 UNKNOWN: [tid:5d531870] wechat bad request error
at Request._failAllPendingRequest (/wechaty/node_modules/padlocal-client-ts/src/Request.ts:334:15)
at ClientDuplexStreamImpl. (/wechaty/node_modules/padlocal-client-ts/src/Request.ts:82:12)
at ClientDuplexStreamImpl.emit (node:events:527:28)
at ClientDuplexStreamImpl.emit (node:domain:475:12)
at Object.onReceiveStatus (/wechaty/node_modules/@grpc/grpc-js/src/client.ts:689:18)
at Object.onReceiveStatus (/wechaty/node_modules/@grpc/grpc-js/src/client-interceptors.ts:424:48)
at /wechaty/node_modules/@grpc/grpc-js/src/call-stream.ts:330:24
at processTicksAndRejections (node:internal/process/task_queues:78:11

2022/07/24 00:37:01 PuppetService Start()
2022/07/24 00:37:05 PuppetService onGrpcStreamEvent({type:EVENT_TYPE_SCAN payload:{"qrcode":"http://weixin.qq.com/x/AdnFYFzVNBuGGiy7SvX7","status":2}})
2022/07/24 00:37:05 PuppetService onGrpcStreamEvent({type:EVENT_TYPE_HEARTBEAT payload:{"data":"Wechaty Puppet gRPC stream connect successfully"}})
2022/07/24 00:37:12 PuppetService RoomList()
2022/07/24 00:37:12 RoomFactory err:  rpc error: code = Unknown desc = TypeError: Cannot read properties of undefined (reading 'getRoomIds')
at PuppetPadlocal.roomList (file:///wechaty/node_modules/wechaty-puppet-padlocal/src/puppet-padlocal.ts:1117:28)
at roomList (file:///wechaty/node_modules/wechaty-puppet-service/src/server/puppet-implementation.ts:1207:41)
at Object.roomList (file:///wechaty/node_modules/wechaty-puppet-service/src/auth/auth-impl-token.ts:49:18)
at handleUnary (/wechaty/node_modules/@grpc/grpc-js/src/server.ts:925:11)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)

ERR [PadLocalClient] error while syncing onpush: VError: [tid:b458bcb4] request has been cancelled for reason: SERVER_ERROR: 4 DEADLINE_EXCEEDED: Deadline exceeded
同错误。。。。不知为何

hello，有人吗


[YOUTUBE] Invalid URL returned

Checklist

[x ] I'm reporting a broken site support
[ x] I've verified that I'm running youtube-dl version 2020.03.08
[x ] I've checked that all provided URLs are alive and playable in a browser
[ x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-g', u'-v', u'r9_Id6nsZS4']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.03.08
[debug] Python version 2.7.16 (CPython) - Darwin-19.2.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[debug] Default format spec: bestvideo+bestaudio/best

Description

Hi,
VideoId = "r9_Id6nsZS4"
SDK returns URL, but it is invalid. If you try to load video with this url, 403 would be returned. As a result, player would stuck loading forever. Please assist.
Example of returned URL:
https://r2---sn-8vap5-3c2s.googlevideo.com/videoplayback?expire=1584095115&ei=KwtrXro0yu7tBNn_jNAM&ip=<IP_ADDRESS>&id=o-AEEWErWcg4gFH-4gUKaRWqzhbVmUFS_klt7YkLFpQHZU&itag=251&source=youtube&requiressl=yes&mh=g2&mm=31%2C26&mn=sn-8vap5-3c2s%2Csn-f5f7lnel&ms=au%2Conr&mv=m&mvi=1&pl=19&initcwndbps=1170000&vprv=1&mime=audio%2Fwebm&gir=yes&clen=2930925&dur=178.461&lmt=1575005321100386&mt=1584072644&fvip=2&keepalive=yes&fexp=23842630%2C23882513&beids=9466586&c=WEB&txp=5531432&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=ABSNjpQwRQIhAJoKCI38_zIV1fmBIOuZKqslYLH9P5zdU0VtK2oaq3APAiAwUZ80AYtulw7hraz91LJ7KFKRDs3CmfONl7NRsaYFzg%3D%3D&sig==S1j7XjnrN3-y9MfNdsXl63W9vP85iZxmkeLMxgC3DSCQIC4IYLZAOzEtw4vM00ncMgd3A9uKDS-E2nG_Eh24Bu30fgIQRwMGkhKDADi&ratebypass=yes

You must authenticate for age-gated videos.


Update awakeable format

Update awakeable format

The change of the awakeable_id's format is a backward's compatible breaking change right? In that case, I think that we should also bump the service protocol version in the runtime and the SDKs to make this explicit.


Chapter 4 typo - 5.10. Cleaning Up Initialisation

Hey Luke,
I just completed chapter four and I came across a word that looks wrong.

5.10. Cleaning Up Initialisation
"to improve the observability postured of our application."
'postured' > posture or profile?

Otherwise, fantastic material, very much appreciated!

Fixed it in the latest release. Thanks for reporting!


kube-bench: 0.6.8 -> 0.6.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/aquasecurity/kube-bench/releases.
meta.description for kube-bench is: "Checks whether Kubernetes is deployed according to security best practices as defined in the CIS Kubernetes Benchmark"
meta.homepage for kube-bench is: "https://github.com/aquasecurity/kube-bench"
meta.changelog for kube-bench is: "https://github.com/aquasecurity/kube-bench/releases/tag/v0.6.9"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.9 with grep in /nix/store/bc4z3p5c3vxsf3m9jv5vrbx8cmrr8g93-kube-bench-0.6.9
found 0.6.9 in filename of file in /nix/store/bc4z3p5c3vxsf3m9jv5vrbx8cmrr8g93-kube-bench-0.6.9

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
kube-bench

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bc4z3p5c3vxsf3m9jv5vrbx8cmrr8g93-kube-bench-0.6.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kube-bench https://github.com/r-ryantm/nixpkgs/archive/aecbfceccd96c8307a623f0255b34ebec9bdf40f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bc4z3p5c3vxsf3m9jv5vrbx8cmrr8g93-kube-bench-0.6.9
ls -la /nix/store/bc4z3p5c3vxsf3m9jv5vrbx8cmrr8g93-kube-bench-0.6.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kube-bench

Maintainer pings
cc @06kellyjac for testing.

nixpkgs-review built fine on NixOS 22.05 Linux x64
Also I'm able to launch the executable.


Please provide a full example how to use setStoreState

Please provide a full example how to use setStoreState because I tried to do it by myself (as written in docs) and whole my page where I used it just invisible. I tried to use this.props.carouselStore.setStoreState({ currentSlide: 2 }).
My page became invisible when i add export withStore

Error is  Uncaught TypeError: Cannot read property 'state' of undefined
my export
export default WithStore(MyComponent, state => ({
    currentSlide: state.currentSlide,
  }));

You can look at the index.js file for most components in the src folder for examples of how to use WIthStore.
Here is a simple example for the Dot component:
https://github.com/express-labs/pure-react-carousel/blob/master/src/Dot/index.js
import Dot from './Dot';
import WithStore from '../Store/WithStore';

export default WithStore(Dot, state => ({
  currentSlide: state.currentSlide,
  totalSlides: state.totalSlides,
  visibleSlides: state.visibleSlides,
}));

If state is undefined, you may be using WithStore on a component located outside of your <CarouselProvider> tags.
<CarouselProvider>
  // WithStore only works on components in between your CarouselProvider tags.
</CarouselProvider>


pr2_common: 1.11.14-1 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository pr2_common to 1.11.14-1:

upstream repository: https://github.com/pr2/pr2_common.git
release repository: https://github.com/pr2-gbp/pr2_common-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 1.11.13-0

Your python-rosdistro version is out of date - you need 0.4.4 or higher. Please upgrade and rerun bloom-release with --pull-request-only or -p or edit the commit to fix the REP version.


Tile filter support for vector pixel types

Add support for tiling images with vector pixel type (color images). Currently only supports scalar images.

This issue was addressed here: 7e3d827b55081fa9556623012c343760e070daaa


fix(curriculum): Change typo on step 76

Change "bottom-margin" to "margin-bottom"
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #45496

Hi @lem0n4id. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


Bootstrappable_best_tip should not require the consensus state of the node's best seen consensus state

Reference to this PR comment https://github.com/CodaProtocol/coda/pull/3112#discussion_r311316319
We automatically filter out transitions that causes us not to bootstrap in the verification process. The prover doesn't have to do that.

Some node is trying to do bootstrap, gives its peers its consensus state S.
Peers respond back by giving their best tip X only if the X is bootstrappable from S.
Basically None is not a valid response to the bootstrappable-tip RPC.
This doesn't really change anything since adversaries can still respond with whatever, it's just a code hygiene thing.

Closing this issue as it is stale for a long time.


Uploader confirmation

#1759
While a few parts missing, I wanted to start a discussion about it:

There is no invalid code / expired invite error message, we just fall back on the default 404.
There is no second click to actually confirm and/or check the id of the current user.
Tests: the current (failing) tests with this change seems to be not useful anymore, I lean on removing them entirely. This is the first time when using package:pub_server's internals seems to be in our way.

I think this is the bare minimum that should be done for the feature, and we can add the missing pieces on top as needed. WDYT?

In the end I managed to fix/extend the test to work with the new logic.


Relax ex_doc dependency

Currently zigler has a strict dependency on ex_doc 0.21.1. See https://github.com/ityonemo/zigler/blob/master/mix.exs#L96. Later ex_doc versions fix a number of things including compiler warnings. Would it be possible to relax this dependency? I assume that there's some history here.
Thanks!

I think it should be, I pinned it because I am doing some sketchy things to correctly perform marshalling zig docstrings into elixir docs.  Unfortunately ex_doc API has not been solidified yet, and I haven't figured a good way to test to triple check that the docs are okay.  I'll relax the requirements, check to make sure docs are at least sane, and push 0.7.2.

Thanks! Also, no rush from me. I'm working with a local fork of zigler while I experiment with Nerves.
Also, zigler is also holding back nimble_parsec from updating to 1.1.0. I think this is a safe update since upstream decided to go "1.0" and I don't believe that there were many changes from 0.5.0.


DROOLS-733: kie-server-client refctored tests with wiremock to execut…

…e them without a need to have running kie server

following our discussion on improving kid-server-client tests in osgi/karaf, here is a PR that does that using suggested WireMock. @psiroky if you could take a look whenever you have some time.

+1. After talking to @mswiderski over IRC, it is not easily possible to use the PaxExamParametrized (will be explaining why as a comment in the test class).

merged into master and 6.3.x


Update build_parameters.sh

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

release-daily-build
fe7b289d2082f4fececb31f45d1e84c0b9b6f7b5
link
/test release-daily-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

release-daily-build
fe7b289d2082f4fececb31f45d1e84c0b9b6f7b5
link
/test release-daily-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Adapting eslint config to prettier (was: Linting command files filter is wrong)

It doesn't have the correct filter, it misses to catch the *.jsx files.
Try:
./node_modules/eslint/bin/eslint.js -c .eslintrc src/**/*.jsx

We are currently using the Airbnb setting for eslint. Though, we should use an eslint config that does not conflict with prettier. There are lots of options, such as: https://github.com/prettier/eslint-config-prettier
We have to try them out and find one that works for us...

I'm on it :)

@nileshgulia1 thx, we will take a look!

Fixed by #128


MSID: 89892 Version: 1 DOI: 2<IP_ADDRESS>2197

"msas": "Ecology", "Neuroscience"
"msid": "89892"
"preprintDoi": "10.1101/2<IP_ADDRESS>2197"
"Reviewed Preprint posted": "2023-08-30"
"Sent for peer review": "2023-06-26"
"Posted to bioRxiv": "2023-03-13" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>2197v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=89892)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/89892/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2197)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[x] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/89892/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/89892)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/89892

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/89892

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/89892/v1/89892-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/89892)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

bioRxiv's vendors have not captured some sections as code.
e.g.:

Some equation images display too small to be legible:

We'll proceed with it anyway.


[Event Change Request] page 160 "Sales Statistics" - OnCalculateTotalsOnAfterGetSalesLines

In page 160 "Sales Statistics" event OnCalculateTotalsOnAfterGetSalesLines please include sender, same as page 161 "Purchase Statistics".
From:
    [IntegrationEvent(false, false)]
    local procedure OnCalculateTotalsOnAfterGetSalesLines(SalesHeader: Record "Sales Header"; var TempSalesLine: Record "Sales Line" temporary)
    begin
    end;

to:
    [IntegrationEvent(true, false)]
    local procedure OnCalculateTotalsOnAfterGetSalesLines(SalesHeader: Record "Sales Header"; var TempSalesLine: Record "Sales Line" temporary)
    begin
    end;

Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[Feature Request] Allow skipping certain databases.

It would be great if somehow you can tell mongo-connector to skip the dumping of certain databases that you don't want to be replicated.
It can be like mongo-connector --skip databasename1, databasename2
The changes in the docmanagers aren't too hard I think.
Thank you.

Have you seen the namespaces.include option? This allows you to selectively include certain collections. It's not quite the same, but it might work for your needs.

Yes I saw that feature, that's why I tought It could be interesting to include the database skip option. To skip a whole database and its collections it would be necessary to add database.collection1..collectionN to be skipped, doesn't it?

That is correct.
To make this feature symmetric with the namespaces.include option, this option could be namespaces.exclude. If the patterns that each of these options took could include a wildcard (*), then it would be easy to include/exclude entire databases instead of just individual collections.

So it does include the wildcard right now? I can use exclude mydb.*  ?

It does not. I'm just documenting the desired behavior.

It could be a nice feature, It covers a need that many developers could use.

Most of the discussion around wildcards in namespace include/exclude has moved to #480, so I'm closing this issue as a duplicate.


Move 'show previous log' from the cog menu to a checkbox

Check with @nwmac for details

On 2.6.3

On 2.6-head commit id: 4df2214

@nwmac could you provide more info about this fix “Fixes a minor styling issue in the AsyncButton control where there is extra margin on the left of the text when there is no icon” ?

@sowmyav27 This relates to the Download button - it does not have an icon, but is an async button - you'll see that the text is not correctly horizontally aligned prior to this fix - there is extra margin on the left-hand side of the text.

Text on download button is aligned correctly on latest 2.6-head


Dragging and dropping to the same container should not fire callbacks

There are case where it make sense to drag/drop element from/to the same container, for example to reorder the elements of a list using dragdrop, by using the mouse event provided by $event.
With latest master, drop-validate is fixed, and you can validate each possible destination of an element.
See example in test.html and js/app.js, there's a check on $drop.element !== event.srcElement.parentNode to disable dragdrop to the same container.


[v2] copyOnSelect and quickEdit not working with v2

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: ubuntu linux 16.04 64x
Hyper.app version: canary branch (tag 2.0.2) - both custom build and release.
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/mojoaxel/a55766b1b6efc1f1802d1e43dab96919

Issue

[ ] copyOnSelect is not working with the current v2.0.2. Selecting a text is not copying it to the clipboard.
[ ] quickEdit is not working with the current v2.0.2. It looks like right-click events are not handled at all.

Same error.

@nacimgoura, please use the reactions that github has introduced some years ago 👌

Same error here

@luukverhoeven, please use the reactions that github has introduced some years ago 👌

Why was the issue closed?
I still have the problem on version 2.0.4 with ubuntu 16.04.


Tuya Integrations "Login error (1106): permission deny" Issue

From what i have researched this is not a new issue and happened to a lot of people before after updating Home Assistant back in Nov 21. It July 22 and I just updated my Home Assistant Core and the issue has comeback. None of my Tuya devices are working and when i tried to reconfigure Tuya integration It's giving me Login Error 1106. Is there a proper solution to this bug?

https://github.com/tuya/tuya-home-assistant/blob/main/docs/error_code.md


Allow config.json slot entries without kms_key_id to return only certificate

I was wondering if it's possible to add the feature to allow skipping lookup from KMS if I exclude the kms_key_id?
So, I'm hoping to have something like this, that means I can mix a signing key, with root-certs using the same mechanism. e.g. when using rauc:
rauc bundle --keyring='pkcs11:token=dev-root-ca' --intermediate='pkcs11:token=dev-int-ca'--cert='pkcs11:token=dev-leaf' --key='pkcs11:token=dev-leaf' input_dir/ my_bundle.raucb
So the config.json would look like this:
{
  "slots": [
    {
      "label": "dev-root-ca",
      "certificate": "<mycert>"
    },
    {
      "label": "dev-int-ca",
      "certificate": "<mycert>"
    },
    {
      "label": "dev-leaf",
      "kms_key_id": "1234",
      "aws_region": "us-west-1",
      "certificate": "<signing_cert_base64>"
    }
  ]
 }

Hmm, it seems a bit odd to support slots in the provider without any key. That might be something other PKCS11 providers enable, but I think I'd want to check how typical that is. Any reason to do it this way versus just specifying paths to the root/intermediate certs in the rauc bundle command?

So this is useful in conjunction with the PR I sent which allows you to specify certificates by ACM PCA ARN in the config file :-)
That way, you can do a setup you never have to copy and maintain certificate files, you can make the CA cert accessible via the token. I want to use this in part because I use the plugin along with p11-kit "proxy" to proxy keys into a container and I don't want to mess around with keeping cert files up to date when keys rotate.
Right now (at least with my branch for which I just sent a PR but I don't think it would fail otherwise), it will somewhat work if you ommit the key ID for a slot. It will try to access it and get errors, but the certificate will be available, at least via p11tool --export ... that said it's somewhat sucky since we don't have an ID
I'm thinking of doing a patch so it, at least, doesn't try to retrieve the key when it's not specified, and uses something else as an ID, maybe just the cert name.
We'll see if I find time. I also want to rework a few more things, hide the KMS client completely inside AwsKmsSlot using longer lived client instances maybe (they should re-obtain credentials automatically), and other niceties, but again ... time :-)

Thanks for this, I've been thinking on it and actually I think a rest call might also be a good idea as well, but that code might need to do an extra check to ensure the certificate returned actually matches the private key. But maybe such a check could benefit here as well? incase the wrong ID is entered.
I've actually switched to using ACM PCA. The only downside is the cost (!) so this patch is very useful, thank you.


Drivers

what do you mean by this(in step 4 for the arduino ide):
If you do not have a driver installed, you need to install it (Window:ch341ser2.exe, MAC:ch34x_mac_driver_v1.6.zip https://github.com/LilyGO/LILYGO-T-OI/issues/3#issuecomment-907645945)
how to install it?
and can i use it on other versions of esp32?

The driver being requested here is the driver for the USB-serial chip, which is a CH340K or equivalent chip.


Slight formatting offset in header search results on some pages

On any page in the /pages/ part of iNat, the View Observations | About text is not matching the text on the left, being slightly above it.

Fix is looking good, I'll close.


Improving the readme.md file

improve the basic layout of the readme.md file

hey would you like me to work on this issue as well?

sure just make sure that the readme.md file and the documentation.md file are similar in fashion

sure just make sure that the readme and the documentation file are similar in fashion


Query Sets: Ajax Call Routing

How do we want querysets to function? When we create model objects from Query Sets they use the query set unique name. This will cause errors when we call functions like update on the glue model object because on the backend we configured it for querysets.

[ ] Create a handler on querysets for model object calls?
[ ] Add the connection to the glue ajax request so we know how to direct the calls?
[ ] Action could be more verbose. Model Object Get -> Then we would be able to write more handlers.

In glue ajax we need to send all the data that would also be related to a queryset.

Created a single post_data file inside entities to share objects.


Only downgrade suitesparse

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Now that #20 is merged, we don't need  this one anymore, right?

Now that #20 is merged, we don't need this one anymore, right?

Correct - this is was only intended as a demonstration how to use the conda_build_config.yaml.


Add different file formats

It'd be cool if this gem knew how to read/write yaml files. The only thing that would need to be added is new load/write methods.

This will actually help with another design problem I'm having. I want to add a to_md method at the entry level that will return the entry as an array or markdown lines. We already have  to_json and to_h, at the entry level, so to_md would be nice. Then, when writing a file, we could just do


Disaggregate Purchases Export

Summary
We received a request that diaper banks would like to see a breakdown of what was individually purchased when they export their purchases and not just see the aggregate amounts. So, currently they see 600 items purchases, instead they would like to see 150 size 1 diapers, 150 size 2 diapers, and 300 size 3 diapers. For example.
Banks are able to export their purchases from the purchase index page.
Things to Consider
We currently have similar functionality on the donations export to csv functionality so we should copy that.
Criteria for Completion

[ ] When a user clicks on the export purchases on the purchase index page it breaks the purchases out by item type using a similar format as how the donation export works.
[ ] Add a test proving that it works

Sean --I notice that the purchase amounts are entered as the broad categories as well.  Should those be broken out in the export?        It'd likely be trivial to add them later.

Definitely add it in if it isn't difficult. Otherwise we can put it in later :)


Add table component

https://material.angular.io/components/table/overview
In particular, Python developers oftentimes want to display a dataframe as a table UI

I'd like to try taking on this issue. I think it'd be a good way for me to get a better understanding of the codebase.

Fantastic! I think this will be very useful - this was requested by an internal user and I would also like to use this as well :)
A couple of ideas around the API, but please come up with your own ideas!

I'd consider having a simple API, e.g. me.table(df) where df is a Pandas dataframe. This is a very common use case. As prior art, take a look at what Streamlit has done with its dataframe and table components.
As a follow-up feature, it may be nice (I have a personal use case :)) to provide some kind of on_row_click API so users can do custom interactivity (e.g. navigate to a page). There's a lot of potential interactivities (e.g. pagination, column sorting, filtering, etc), so feel free to be iterative about this and implement something simple (e.g. a static table) to begin with.

In case you haven't seen it, take a look at the docs for creating a new component: https://google.github.io/mesop/internal/new_component/#potential-exploration-areas
In particular, the scaffold_component.sh script is quite helpful.

I definitely agree about starting off simple first. Definitely agree that there's a lot of functionality that can be added. The Streamlit stuff is very cool.

Basic table component done in above PR - we can open more issues based on user feedback.


Simplify js check in index constraint errors

Any declaration that is a BinaryExpression is a special javascript declaration, and all JS declarations that are checked for index constraint compatibility are, in fact, relevant.
Fixes #15616
Improves #15586

Please port this to release-2.3

It's now in 2.3 too.


Split our helper functions in a submodule

At this moment, all helper functions are collected in one helpers.py file under Jackman/core. I think we should move these out to their own module, giving us more insight in what functions we have created already by splitting them over multiple files.

Closed by 6cc58b9f613c12866b4c86209df2a7d0ac944fc8.


Find a way to build along with css files

Problem
all styles must be kept in .ts files, but moving them to .css files would be great.
From what I gather, the issue is that ts doesn't know how to handle them and declaring the module is not everything that needs to be done.

[ ] Research how to build CSS files using typescript
[ ] see if web pack is somehow useful;
[ ] look for tutorials that make it work without webpack;

I give up. If you know how to do this (without webpack) let me know.


Update set-up-your-development-environment.md

Category

[x] Content fix
[ ] New article

Related issues

fixes #5936

What's in this Pull Request?
Replaced yo install gulp --global with npm install gulp --global

thx @JarbasHorst, appreciated.


there is no "test" function in the information type in compliance centre

"In the Compliance Center, go to Data classification > Sensitive info types and choose the sensitive information type from the list to open the details pane and choose Test."
there is no test function in the compliance centre - only copy, edit, delete and close

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dcb7953e-5257-2578-4607-2d93940d6845
Version Independent ID: 8e59d041-619e-d54f-f28e-faac2bc18ef2
Content: Get started with custom sensitive information types - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/create-a-custom-sensitive-information-type.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

@bakerm00 Thank you for your feedback. I'm working with the author in the backend and will update the document if need be.
Thanks
Sri

@bakerm00 Thank you for your feedback. I can now see the test option on the page. Let us know if you still have an issue.

@msbemba Thank you very much for the contribution and sharing this explanation. @bakerm00 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[#13] docs - Steps to run application

Closes #13

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.078%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
45

Relevant Lines:
47

💛  - Coveralls


Transaction sent success page

When a transaction is sent, we should display a success page instead of going straight to transaction details view
Would be great to have a little bit of animation here
-> View transaction details goes to the transaction page
-> Done goes back to homepage

Duplicate issue


[#742] Refactor blocks scanning in CompactBlockProcessor

Closes #742

Added new protocol BlockScanner and new struct BlockScannerImpl. Scanning related code is extracted to BlockScannerImpl.

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[x] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@pacu It looks like that testStoringTenSandblastedBlocksFailsAndThrows test is failing on the GA. On my machine it works. I tried to run it multiple times and it even looks like it isn't flaky. Anyway I don't think it is caused specifically by this PR. So I am going to merge it and we can investigate that test separately.


Leverage Favorites for Smart Detection

What's the Problem?
The Smart Detection only open the corresponding tool when there's only 1 tool compatible with the clipboard.
More than 98% of the time I know the tool I want to use but there's a other tool that is compatible and this result in additional clicks.
Lets take JSON as example:
For my use case I would never need JSON <> YAML but the tool selection is blocked.

Solution/Idea
I would leverage the Favorites System.
Even if there's multiple match for the Smart Detection I would trigger the tool selection if there's one in my favorites.
Alternatives
An alternative would be to add a way to disable Smart Detection manually for some tools
DevToys Version
Version: <IP_ADDRESS>
(On peut parler en Français si tu préfères)

Hello,
Thanks for the suggestion. This is a great idea actually! I will try to implement this soon.

I can help out is there any steps to run DevToys with vs?

https://github.com/veler/DevToys/pull/626

Here is a simple PR:  https://github.com/veler/DevToys/pull/626


Serialized PowerShell objects appear to be enumerated

I am not sure whether this qualifies as a bug or designed PowerShell behavior related to unrolling objects (which is to my opinion useless for serialized objects)
Steps to reproduce
$Expression = [ScriptBlock]::Create('[byte[]](1, 2, 3)')
(&$Expression).GetType()

Expected behavior
IsPublic IsSerial Name                                     BaseType
-------- -------- ----                                     --------
True     True     Byte[]                                   System.Array

I would expect the same behavior as:

directly invoking the expression  ([byte[]](1, 2, 3)).GetType(),
retrieving the type of an embedded valued array, like: $Expression = [ScriptBlock]::Create('@{x = [byte[]](1, 2, 3)}'); (&$Expression)['x'].GetType()
using the ConvertFrom-Expression cmdlet : (ConvertFrom-Expression $Expression -NoEnumerate).GetType().

Actual behavior
IsPublic IsSerial Name                                     BaseType
-------- -------- ----                                     --------
True     True     Object[]                                 System.Array

(The byte[] array is converted to an object[] array)
This also happens with methods that return a valued array, e.g.: $Expression = [ScriptBlock]::Create('"abc".ToCharArray()') and the same happens with other "evaluate" cmdlets along with Invoke-Expression and Invoke-Command
This behavior is probably related to: stackoverflow question: How can I prevent a (serialized) expression to unroll
Environment data
Name                           Value
----                           -----
PSVersion                      6.2.3
PSEdition                      Core
GitCommitId                    6.2.3
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I think your assumption is incorrect.
Your test case is:
[scriptblock]::Create('[byte[]](1, 2, 3)')

Which is identical to just doing:
{ [byte[]](1, 2, 3) }

Invoking either of these will cause the collection to be unrolled as it passes through PS's output systems. If you want to prevent this, you would instead need something analogous to:
{ Write-Output -NoEnumerate ([byte[]](1, 2, 3)) }

Note also that this isn't serialized data, it's just strings being parsed into PowerShell script via the standard parser, no different to any script PS processes normally.
If you want to serialize data, you can use Export-CliXml
Export-CliXml -Path bytes.xml -InputObject ([byte[]](1, 2, 3))

Thanks for the clear answer.

I wonder why the Write-Output got the -NoEnumerate parameter.
Wouldn't a -NoEnumerate parameter for the Invoke-Command make sense for the same reason?

It's not as meaningful, since Invoke-Command itself can contain an entire scriptblock with any number of commands; by the time the cmdlet receives any of the output, it's already enumerated. The best it could do is emit the entire object[] array as a single item. 🙂

Thanks again for the answer and explanation.


RPM package has incomplete list of dependencies

VSCode Version: 1.8.1
OS Version: CentOS 7.3 (x64)

Steps to Reproduce:

Install CentOS 7.3 minimal ISO to a new VM
sudo yum install code-1.8.1-1482158209.el7.x86_64.rpm
code .

Expected:
VS Code to start
Actual:
VS Code crashes, saying it cannot find libgtk-2.0.so
I then manually installed the "gtk2" rpm to meet the missing dependency.
VS Code still crashes, saying it cannot find libXtst.so.
I installed the "libXtst" rpm
VS Code still crashes, saying it cannot find libgconf-2.0.so
I installed the "GConf2" rpm
VS Code starts, but immediately and silently exits. Running with the --verbose option eventually points to a failure to locate a "sans" font.
I installed the "gnu-free-sans-fonts" rpm
VS Code successfully starts and is operational.
So it seems like the above 4 packages should be added as package dependencies, to avoid the user having to manually find/install additional packages.

Thanks for reaching out! Interestingly, it seems that all four of those packages appear in dependencies.json, so not sure what's up. @Tyriar, any ideas?

This is fixed Insiders, coming in 1.9.0 😄 https://github.com/Microsoft/vscode/issues/17142


Can confirm. Latest VRChat update has broken things.

Looks like it needs to be changed to:
https://github.com/benaclejames/ParamLib/blob/6de64be519cf11b4e5a3bcb03aa914ee294217a5/ParamLib.cs#L12-L13
      private static AvatarAnimParamController GetLocalAnimParamController() => VRCPlayer.field_Internal_Static_VRCPlayer_0
           ?.field_Private_AnimatorControllerManager_0?.field_Private_AvatarAnimParamController_0;

Yup! I have these changes done locally, just trying to figure out where the float param prioritisation went with the update

Fixed in latest release


implemented signing secret and updated docs

Proposed changes:

validate slack requests using signing secret
updated documentation page (old instructions were outdated, added screenshots)

Status (please check what you already did):

[ ] ~added some tests for the functionality~
[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

@erohmensing added images to the slack docs, as it was very hard to follow them without. does this look sane?


Feature Request: Support clock injection for testing and mocking.

In Grafana we import some prometheus alertmanager libraries.
When testing our usage of the alertmanager, it'd be convenient to be able to manipulate the clock. For example, silence maintenance happens on a time.Ticker, and silence expirations are based on real wall-clock time. If we could manipulate time, we can test Silence maintenance (we use a custom maintenance function) quickly in unit tests rather than waiting on real clock time.
In the clock library, you create a clock.Clock interface - in real systems this is a wrapper around the time libraries, and during testing you use a MockClock to manipulate time.
Proposal: Depend on benbjohnson/clock and inject a clock.Clock any where a time.Now() or time.Ticker is used. The library is MIT-licensed.
There are 6 usages of time.Ticker and 43 appearances of time.Now, including in tests. It's not necessary to instantiate only a single clock.Clock and thread it down to all dependencies or anything like that. Clocks could be instantiated at the construction of the objects that make time calls.
(I would be willing to do this change if the proposal is acceptable)

Would it be limited to the silence package? In silence/silence_test.go, we override the time.Now() function, it would make sense to have a cleaner way.

You could limit the scope very easily - instantiate a clock.Clock just before constructing the silences object, for example.
I think it would be good to be ambitious though. Anywhere that time factors into testing would benefit from a change like this.

To be clear, I think it's an acceptable change :)

@simonpasquier Is there any process required to start work on this? I can periodically send PRs over time, referencing this issue.

@simonpasquier see the PR here: https://github.com/prometheus/alertmanager/issues/2850


YAML Multiline

:zap: Summary
Would be nice to have YAML multiline strings for run option following the YAML specs:
https://yaml-multiline.info/
Value
It is hard to read long lines of commands for instance:
commands:
  trivy:
    tags: security
    run: docker run --rm --volume "$(git rev-parse --show-toplevel)":/home/docker cdci trivy filesystem --quiet --ignore-unfixed --ignorefile .trivyignore --skip-files .env /home/docker

Behavior and configuration changes
That long line could be written like so:
commands:
  trivy:
    tags: security
    run: |
      docker run --rm --volume "$(git rev-parse --show-toplevel)":/home/docker cdci
      trivy filesystem --quiet --ignore-unfixed --ignorefile .trivyignore --skip-files .env /home/docker

What happens if you try to use use multi-line currently? Looking at gopkg.in/yaml.v3 v3.0.1 in go.mod, it seems like it should be able to use them based on https://github.com/go-yaml/yaml/commit/513397e5a74045296989ac1a3650ae511bf96dab being part of v3.0.1
From a casual reading of your example, I'd expect it to treat separate lines as different commands, since that is how multiple lines in a shell would execute. Using a \ to span commands multiple lines might work:
commands:
  trivy:
    tags: security
    run: |
      docker run --rm --volume "$(git rev-parse --show-toplevel)":/home/docker cdci \
        trivy filesystem --quiet --ignore-unfixed --ignorefile .trivyignore --skip-files .env /home/docker

Right, this should be working in 1.3.10
You can use > to join lines split for readability:
commands:
  trivy:
    tags: security
    run: >
      docker run --rm --volume "$(git rev-parse --show-toplevel)":/home/docker cdci
      trivy filesystem --quiet --ignore-unfixed --ignorefile .trivyignore --skip-files .env /home/docker

From a casual reading of your example, I'd expect it to treat separate lines as different commands, since that is how multiple lines in a shell would execute. Using a \ to span commands multiple lines might work:

That's the case sometimes more than one command is required to perform the validation.
For ansible-lint for example, I need to run one command to store the credentials for private repository, then run the ansible-galaxy to install assets from that repo, and finally run the ansible-lint. It's expected that any non-zero return code from multiple commands to fail the validation.
I could do it in separated runs but then I would loose the capability to run multiple tests in parallel.

Right, this should be working in 1.3.10
You can use > to join lines split for readability:

For a single command that works perfectly.

I've tested this for multiple commands, and it works well. Can you test it on your setup?
# lefthook.yml

test:
  commands:
    fail:
      run: |
        exit 1
        echo never prints
    success:
      run: |
        echo line 1
        echo line 2

Output:
Lefthook v1.3.10
RUNNING HOOK: test

  EXECUTE > fail

  EXECUTE > success
line 1
line 2

SUMMARY: (done in 0.01 seconds)
✔  success
🥊  fail

Hey,
Sorry for late response!
I don't remember on which previous version it didn't work, or there's a chance that I've made something wrong too lol.
Well it's working perfectly fine.
Thanks!

@Gonkers , could you please show the logs with running lefthook run test -v?


SkyConnect: Potential Issue In Newly Provided Information

Note: I just want to say pre-hand that I'm not sure if the scope of this repo overlaps with the "SkyConnect ZBT-1" Firmware page but it's the best place I could find. So if this is being brought up to the wrong people then I request that & hope this concern about the issue is passed on or a link to this post is sent to the relevant web devs/maintainers  Also not sure who to mark as assignee for this, I hope that the right person will be added by whoever sees this.

"Warning:  Firmware update through web flasher is only available for Home Assistant SkyConnect devices and Home Assistant ZBT-1 devices purchased after October 20, 2024." 😕

But no reason seems to be given on why this warning is added on after the recent changes,
I'm just a bit confused because the webflasher currently seems to still work for old models. Atleast true at the time of posting this. (I recently tested after it came back online, to switch to ZigBee firmware and back to Thread with logs for separate troubleshooting info on an issue I've come across in an old adapter.)
And it was stated multiple times (by people associated with the HASS Project in a lot of places) when I was asking around about a possible new 'ZBT-1' model, that there was no difference in firmware or hardware to the older 'SkyConnect' branded USB adapters and that the new naming scheme was just part of planned adjustments in HASS branding to simplify things for when Z-Wave sticks are openly & publicly announced.
So with all that in mind, has there been (or are there going to be?) any plans for changes to any newer "ZBT-1" branded models manufactured after the end of Oct '24? And if so, could that relevant information be added to any warnings?

I know that Silicon Labs has a new revision/B sku to the modules being used in the SkyConnect Radio Adapter from Nabu Casa, So I'm assuming that it's safe to say that their newer version is more supported by the firmware & loader updates that they're now rolling out? 🤔

P.s. Many apologies in advance i've incorrectly followed any procedures in posting this. I'm not the best at using GitHub & struggle with doing so 😅


Add ddev-get topic to help others find addon

I recently came across your article, Setup Statamic via DDEV article.
I was suprised to see you mention you have an addon.
Please consider adding a ddev-get topic to the repo.
This will allow others to find this addon by using: ddev get --list --all
Steps

Click the "cogs" icon

Add ddev-get as a topic.

Run ddev get --list --all and check if "mandrasch/ddev-addon-statamic-please" appears (should appear within a minute).

Hey @tyler36,
thanks for the info and information!
I added the tag, it can now be found ddev get --list --all. 👍
Just as side note:
If you want to mantain & develop this further, feel free to start an own repository and I'll archive mine + link to yours. Not using statamic currently on a daily basis, just did some tests. But after all it's just the simple command, so I guess there will be no real huge feature requests ;-)
Cheers!

@mandrasch Thanks for adding it!
RE sidenote:
Thanks for the offer. I've never used Statamic for any "real" projects, just a couple of Laracast videos and such. I think your addon is "feature complete" at the moment so there's really nothing more to do.
Cheers!


fix(curriculum): JavaScript Decimal to Binary Converter Step 23 description

In the original description on Step 23 of Learn Recursion by Building a Decimal to Binary Converter from JavaScript Algorithms and Data Structures (Beta), it inaccurately stated "binary to decimal conversion", when the course is supposed to be about decimal to binary conversion. Therefore, I modified the description to ""decimal to binary instead.
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Hi @helenclx. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


Save a new entity Book with a simple Map

In this pull request, we want to test a case with saving a new entity with a simple Map.
After saving an entity, we want to check its version in SpringDataJPAHibernateTest1.java

The example is too complicated. You need to remove Spring and Lombok and follow the same test structure used by all the other Type tests.


Manual PR for non-github repository?

Hello---I'd like to register a package that I don't have hosted on github or gitlab. The documentation on registrator strongly suggests letting that service make automated PRs, but using the web version doesn't support anything besides github or gitlab, and the github app obviously only supports github.
Looking at the auto-generated PRs, it doesn't seem like it would be impossible to manually put together an appropriate one for this non-github/lab hosted package. Would something like that possibly be accepted after review, or is that something that is very unlikely to be acceptable?
If unacceptable, I would appreciate any guidance on registering the non-github/lab package. I understand that it's annoying, but nothing about the actual registration process appears github-dependent to me, and I like diversity in code hosting platforms. So if there is any way to add my package to the general registry I'd be very interested.
Thanks in advance for the help/discussion. Apologies also if I've missed some discussion about this---I have looked around, but it is possible that there is a resource with information on this topic that I've missed.

You can use https://github.com/GunnarFarneback/LocalRegistry.jl to generate the diff and then make the PR. Alternatively you can have a mirror on github/gitlab and register from there.

Thanks so much for the fast and helpful reply. I'll give both of those a look and hopefully make something work.


exporting async function from matcher doesn't work

Describe the bug
Hello, I'm trying to export an async function from matchers inside /src/params. It didn't work even if I return false explicitely.
Reproduction
Say, I have a route routes/book/[page]. To make sure [page]  is a number, I wrote a param matcher called int.js inside src/params and renamed my route dir to [routes/book/[page=int]]. Now, inside src/params/int.js,
// src/params/int.js
export async function match(v){
// other things that I can do only inside an async function

// for now, lets return `false` explicitely
return false;
}

Though we returned false explicitly, it will match any route instead of matching no route.
Logs
No response
System Info
System:
    OS: Linux 5.18 Manjaro Linux
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400 @ 2.60GHz
    Memory: 11.07 GB / 15.40 GB
    Container: Yes
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.7.0 - ~/.nvm/versions/node/v18.7.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.7.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v18.7.0/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chromium: 104.0.5112.79
    Firefox: 103.0.2
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.72
    @sveltejs/kit: next => 1.0.0-next.480
    svelte: ^3.46.0 => 3.50.1
    vite: ^3.1.0 => 3.1.0

Severity
serious, but I can work around it
Additional Information
No response

This is the intended behavior. We want matchers to be able to be small and to run quickly and synchronously. Any async stuff will have to happen inside load.


[Feature Request] Option to skip a break after the end of a Pomodoro

Is your feature request related to a problem? Please describe.
Sometimes I do not take a break while working, it would be extremely helpful if there were an option to skip breaks.
Describe the solution you'd like
Option to skip breaks
Describe alternatives you've considered
https://apps.microsoft.com/detail/9n8gpb2tk8gb?hl=en-us&gl=US -

Hey, could you give some more details on what you mean by this? You can currently manually skip breaks at least.

@sekwah41 I mean a feature like "only focus sessions, one after the other. No break session in between."


Add a button to make movement less sensitive

With the SHIFT button the movement can be sped up, but I'd like to see a button that works as a toggle to slow down the movement speed.

Thanks for the input. This issue is being tracked on https://github.com/etra0/botw-freecam/issues/11.


Question about result aliases

Is it possible to use Pydantic aliases to do the following?

Retain the same attribute name in my Python code
Change the attribute name serialized in the JSON schema for a tool call

A basic example from your docs. Let's say I have:
class Box(BaseModel):
    width: int
    height: int
    depth: int
    units: str

... and I find that "measurement_units" leads to better results in the LLM call, so I change that field name:
class Box(BaseModel):
   # ... all other fields remain the same
   measurement_units: str

Is there a way to continue referring to the field as units in my code while serializing the field as measurement_units in the LLM call?
I find this sort of thing is common while iterating, and aliases makes things easier if the object is wired up to the rest of the app somehow.

Yes, this works out of the box, you just need to use the alias functionality from Pydantic:
from openai import BaseModel
from pydantic import Field

import pydantic_ai

class Box(BaseModel):
    width: int
    height: int
    depth: int
    units: str = Field(validation_alias='measurement_units')

a = pydantic_ai.Agent(model='openai:gpt-4o', result_type=Box)

result = a.run_sync('the box is 3x4x5 inches')
print(result.data)

Amazing, thank you.


Allow Symfony 6

Q
A

Bug fix?
yes/no

New feature?
yes/no

Tests pass?
yes

Fixed tickets
#...

yay


Box is gone?

Hi,
Box link seems to be dead. Is this on purpose?

Hi, I've changed box link, also today there will be new version of box with Yosemite installed

New boxes are uploaded (see Readme.md), you can re-check URLs and reopen issues if problem remains


Add more tests to local content manager

Coverage increased (+0.02%) to 33.866% when pulling a211d777982a851c03d94d8e676bc70aeb2b965d on bavaldez/moretests into f3d36c1b865292948ac52b609a365a7de83e7caf on master.


Add a secret into ppc64le-cluster secret store

Signed-off-by: Valen Mascarenhas<EMAIL_ADDRESS>
Which issue(s) this PR fixes:
Fixes
This PR adds a secret named vm-script into ppc64le-cluster secret store

@cardil  @evankanderson could u merge this PR if everything's fine ?


Need Readme file for repo

Read me file needs to be there for this repo

Hello @akshitagupta15june please assign this issue to me under gssoc

updates!? @kapilG0

Bro you have made a PR on your own fork, i think you did it by mistake
@kapilG0

Bro you have made a PR on your own fork, i think you did it by mistake @kapilG0

Yes sorry.


Add AIP-2: Address Standardization Proposal for Asset Identification (atom32)

This proposal introduces a standardized address format based on bech32 encoding to resolve asset identification challenges within the Bitcoin system, particularly concerning the Atomicals Protocol.
The new address format aims to differentiate Atomicals Protocol assets from Bitcoin assets,
enabling node services to accurately identify and handle distinct asset types, thus preventing unintended asset burning during transactions.

A fantastic idea and helps differentiate addresses with Atomicals assets +1


Add better blazor samples

Having both server side/client side samples is a must for us in the future. If we can add some samples about basic Blazor interactions that would be great.

do you want me to throw something together?
The default Blazor template done in ReactiveUI for each platform, maybe?  Unless you have something better in mind?

Yeah same example for wasm/server is fine. Any sample is appreciated I'm sure.

PR is open.


Support multiple managed and inline policies

Fixes https://github.com/aws-controllers-k8s/community/issues/1024
Description of changes:
Updates the user installation documentation for creating the IAM role, for services with multiple managed policies or services that require inline policy statements.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

JFYI: test-recommended-policy will need the change as well.. currently the test assumes that only single line will be present inside recommended-policy-arn file.

On it!