kernel: virtiofs: remove already applied patch

The virtios-dev tag changed recently to a new version:
Linux 5.8-rc4
This already include some patches, remove not needed patches.
Jose Carlos Venegas Munoz<EMAIL_ADDRESS>Fixes: #1095

/test

Hey Folks, I still having some build issue locally now are config issues, I am looking to it.
The first error I get is that the final config does not have CONFIG_MEMCG_SWAP_ENABLED=y. Seems that this was removed or moved in this version. I am looking where it is now or if only changed the name.

thanks @jcvenegas the issue is gone http://jenkins.katacontainers.io/job/kata-metrics-runtime-ubuntu-virtiofs-18-04-PR/6/console

/test

/AzurePipelines run

@jcvenegas you need to bump the kernel config version please
10:40:16 ERROR: Please bump version in kernel/kata_config_version

/test

/AzurePipelines run

@amshinde so, the plan is to wait for  a proper tag, should I close this PR ?

I dont think this is required any longer. Closing this @jcvenegas.


Fix for failure (KernelTraceControl.dll load failure) during collection

This required an update to the OSExtensions dll

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   16.01%   16.01%
=======================================
  Files         210      210
  Lines      122743   122743
  Branches    11796    11796
=======================================
  Hits        19652    19652
  Misses     102248   102248
  Partials      843      843

Flag
Coverage Δ

#2017
16.01% <ø> (ø)
:arrow_up:

#Debug
16.01% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13237b...43c1b1a. Read the comment docs.


Semantic tokens allow for a single provider

This request is to allow semantic tokens to not just pick the first most provider in the list of providers. But instead pick the provider that actually has tokens to return.
The use case for this is to support jupyter notebook token colorization.
Right now there are at least 2 language servers returning tokens for python notebooks:

Python extension has a language server registered for all 'python' files. There's no way to 'exclude' files from a DocumentFilter so it has a middleware piece that excludes all notebook cells.

Jupyter extension has one ore more language servers registered for all notebook cells. One or more is because the language server in use can only support one python interpreter at a time, so one language server is created per python interpreter in use for any notebook (multiple interpreters can be in use in one VS code session). When semantic tokens are requested the middleware piece in the juptyer extension will skip sending token requests to pylance  if they're not for the appropriate document.

This creates a problem with the current implementation because the first registered language server wins. This can randomly be  python's (where no tokens are returned) or one of the jupyter one's (where it might return tokens if the interpreter for the document matches).
I believe this could all be accomplished by making a compositing token provider in the VS code source. Something like so:
class CompositeDocumentSemanticTokensProvider implements DocumentSemanticTokensProvider {
	private didChangeEmitter = new Emitter<void>();
	constructor(model: ITextModel, private readonly providerGroup: DocumentSemanticTokensProvider[]) {
		// Lifetime of this provider is tied to the text model
		model.onWillDispose(() => this.didChangeEmitter.dispose());

		// Mirror did change events
		providerGroup.forEach(p => {
			if (p.onDidChange) {
				p.onDidChange(() => this.didChangeEmitter.fire(), this, undefined);
			}
		});
	}
	public async provideDocumentSemanticTokens(model: ITextModel, lastResultId: string | null, token: CancellationToken): Promise<SemanticTokens | SemanticTokensEdits | null | undefined> {
		// Get tokens from the group all at the same time. Return the first
		// that actually returned tokens
		const list = await Promise.all(this.providerGroup.map(async provider => {
			try {
				return await provider.provideDocumentSemanticTokens(model, lastResultId, token);
			} catch (err) {
				onUnexpectedExternalError(err);
			}
			return undefined;
		}));

		return list.find(l => l);
	}
	public get onDidChange(): Event<void> {
		return this.didChangeEmitter.event;
	}
	getLegend(): SemanticTokensLegend {
		return this.providerGroup[0].getLegend();
	}
	releaseDocumentSemanticTokens(resultId: string | undefined): void {
		this.providerGroup.forEach(p => p.releaseDocumentSemanticTokens(resultId));
	}
}

I'm going to try out the composite idea and submit a PR if it works.


Would you please illustrate more on the loss function of D & R networks?

Hello,
I am kind of confused on understanding the loss function of the DQN networks( line 122 thru 125 in RL.py). Would you please explain a bit? Thank you!

This is an implementation of the Huber loss  which is one of several standard losses used in Deep RL.


Allow execution of shell_run_command in task

ATM shell commands can be invoked in flows only, not in tasks (RuntimeError: Tasks cannot be run from within tasks. Did you mean to call this task in a flow?). Would be great to be able to invoke shell commands in tasks as well.

Hi! You can invoke the underlying function of shell_run_command by doing shell_run_command.fn(*args, **kwargs). Let me know if that works!

Right now it's not working yet. I'm getting RuntimeWarning: coroutine 'shell_run_command' was never awaited   shell_run_command.fn(command=cli_command, return_all=True).

Are you executing that within a notebook? If so, you simply need await shell_run_command.fn()
However, it's recommended that you put it within another task/flow.
@flow
def test_flow():
   return shell_run_command.fn(...)

If calling the underlying fn you'll bypass our sync-async compatibility machinery that is used for tasks.

@madkinsz This means I've to stick to shell command calls in flows for now, right?

@fkromer you can use shell commands in tasks with the .fn() function, but the tasks will need to be async and you'll need to await the .fn() call. Fortunately, async tasks can be called from synchronous flows, so you should be able to isolate the asynchronous code to only a portion of of your flow.

I believe that this issue has been resolved. Feel free to reopen if that is not the case!


Unable to access docs

Every page shows

Any remedy?

Thanks for bringing this up! I can't seem to reproduce the problem locally. I was able to pull up "https://hyperparameter-hunter.readthedocs.io/en/latest/quick_start.html" without issue

Side note: I just noticed two typos on the Environment section of this page, which I'm fixing now. Just add () after data = load_breast_cancer and change the value of shuffle in cv_params=dict(n_splits=5, shuffle=2, random_state=32) to True/False
Can you please try going to "https://hyperparameter-hunter.readthedocs.io/en/stable/quick_start.html", instead? Just change the "latest" part to "stable".
Since I can't reproduce the issue, I'm not really sure what's going on, but would you mind trying to visit the HH docs homepage, and then trying to visit some other non-HyperparameterHunter ReadTheDocs pages? What browser are you using?

@HunterMcGushion  Everything works now, it appeared to be a temporary issue. Thank you for the response.


Dialog close button focus ring visibility and overlap with content

Issue: https://github.com/jpmorganchase/salt-ds/issues/2970
Fixes two issues:

Close-button focus ring hidden by Dialog overflow: hidden restriction.
Close-button overlaps Dialog content

Two notable changes:
Close-button now has visible padding (when hovered) between itself and the container and content:

The Dialog header now gets it's height from the close-button (was previously hard-coded as spacing-300

Closing now that we have a new approach from design: #3839


softmax used instead of log_softmax in metrics

In the implementation of the ECE, softmax is used instead of log_softmax.
some instances :
https://github.com/torrvision/focal_calibration/blob/475422a6754e20d25216158a874749c33e826e21/Metrics/metrics.py#L126
(https://github.com/torrvision/focal_calibration/blob/475422a6754e20d25216158a874749c33e826e21/Metrics/metrics.py#L150)
Is the observation correct ? because both in cross_entropy and focal_loss log_softmax is used after the logits.
The probabilities will be different  in both case.

Hi Deebul,
Thanks for going over the code. We need softmax to get the class probabilities output from the classifier.
log_softmax is required to get the log over probabilities which is needed to compute the loss (cross_entropy or focal_loss). I hope this helps.
Thanks!

Yes thanks for the quick reply.
I understand the answer I will close the issue.


Implement a new layering strategy

(this is work-in-progress)

The current layering strategy of buildLayeredImage still occasionally yields cache misses for things that feel like they should have been cache hits instead.
There are two major issues with it that I see:

It only singles out closures into layers of their own, rather than grouping them as cacheable units. If there is a program foo that always pulls in foo-data, it seems logical that these should be grouped together.
It only considers the total number of direct and indirect references to a closure to make a decision.

We can improve this by considering a lot more data, such as:

A distinction between direct & indirect references (this solves the foo + foo-data problem above)
Consideration of a package's "popularity" within nixpkgs (it makes more sense to cache glibc than libunknownthing)
Consideration of a package's closure size (it's cheaper to download a 2kB layer 50 times than a 100mB layer 20 times)

This pull request implements a new strategy that takes these factors into account. I have outlined the design in this design document.
The current plan is to bring this to a fully working state and to then deploy it on the public nixery.dev instance to observe its behaviour for a while.

Note: As part of this effort, some housekeeping has been done to structure the repository in a saner way.

The last commit contains a working implementation of the algorithm. Its input is the .attrs.json file that Nix generates when exportReferencesGraph is set to true (similar to the internals of buildLayeredImage).
To test the algorithm you will need a copy of the popularity data from the Nix package set. The generation run for the whole package set at nixos-19.03 is still running, but this file contains about 85% of it (in descending popularity order, only including packages that have at least one other package depending on them): https://storage.googleapis.com/nixery-layers/popularity/nixos-19.03-20190812.json

The new layering strategy is now implemented (with some rough edges remaining) and the public version at nixery.dev is updating to the new strategy as we speak. It'll be interesting to just let it sit for a bit and see how things go!

Deployment has been fixed and I'm switching over the public instance to the new version now. Note that this will currently run a bit slower (build-time wise) than previously because layers are now assembled sequentially.
I'm looking into how to fix that in a followup change.


Hotfix adopt hipDataType and hipblasComputeType_t

Passed on the following two pipelines, please ignore the status from mci as it tests mainline
http://math-ci.amd.com/blue/organizations/jenkins/rc-test%2Fprecheckin%2FhipBLASLt/detail/PR-462/1/pipeline/
http://math-ci.amd.com/blue/organizations/jenkins/gfx94x%2Fprecheckin%2FhipBLASLt/detail/PR-462/1/pipeline/180/


Security Administrator

Security Administrator permissions alone does not give enough permissions to implement the ATP safe Attachment / Safe Links policies:
The object 'contoso.onmicrosoft.com\Safe Attachment' must be within the read scope before and after it's modified.
Can't perform the save operation.
+ CategoryInfo          : NotSpecified: (:) [New-SafeAttachmentPolicy], ADScopeException

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0be929ba-8bef-b75c-0475-041bb6ec441a
Version Independent ID: 358f9e1a-1900-7c8c-814a-b878a9a22f9e
Content: Set up Office 365 ATP Safe Attachments policies - Office 365
Content Source: microsoft-365/security/office-365-security/set-up-atp-safe-attachments-policies.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@JeroenDronkers - Thank you for submitting feedback.
From our understanding, the issue has been resolved based on this merged commit https://github.com/MicrosoftDocs/microsoft-365-docs/commit/23adab350274d524d2ef404678e737e551789aac.
Thank you for your contribution to make the docs better! Much appreciated!

Hello All,
According to the response I got from Marat the issue with the article is not understood:
Hello @JeroenDronkershttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeroenDronkers&data=02|01|jedronke%40microsoft.com|1d38973f91fb4aaed90108d7a2eefa21|72f988bf86f141af91ab2d7cd011db47|1|0|637157019591747179&sdata=YA7xMGrQkF9PrCQu3VSrki7UFjyQVFYD3iom2OvfMqI%3D&reserved=0,
yes, you are correct. To create safe attachment policy you need to have Organization management role or Security Administrator + Hygiene Management roles.
Thank you
The article mentioned only “Security Administrator” role is needed to enable or adjust ATP policies but Security Admin role doesn’t come with the additional Hygiene management roles. Hence we are receiving cases from customers not being able to create ATP policies.
The article is still incorrect as long as Security Administrator doesn’t automatically include the Hygiene management roles or as long as it doesn’t mention that these roles need to be added to the Security Admin role.
Kind regards
--
Jeroen Dronkers
Support Escal Eng
Eq-Uk Gtsc Bizapps Server
Customer Services and Support
Office: +44<PHONE_NUMBER>
jedronke<EMAIL_ADDRESS>[Microsoft Logo]
Team Manager | Frances Early (francese<EMAIL_ADDRESS>+44 (20) 34251539
From: Joyce Y<EMAIL_ADDRESS>Sent: 11 February 2020 01:43
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Jeroen Dronkers<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Security Administrator (#1031)
@JeroenDronkershttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJeroenDronkers&data=02|01|jedronke%40microsoft.com|101559e54bf7405cbeaf08d7ae93b65e|72f988bf86f141af91ab2d7cd011db47|1|0|637169821750105171&sdata=AxNdg7UZsp2yQLaMlFQUZGp9P4g87QaLSzYFvD6pE8A%3D&reserved=0 - Thank you for submitting feedback.
From our understanding, the issue has been resolved based on this merged commit 23adab3https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fcommit%2F23adab350274d524d2ef404678e737e551789aac&data=02|01|jedronke%40microsoft.com|101559e54bf7405cbeaf08d7ae93b65e|72f988bf86f141af91ab2d7cd011db47|1|0|637169821750105171&sdata=WjSmbYLbLfI%2BxCb0UFgD9xpvo7fKTre2UUtRWUYtDVA%3D&reserved=0.
Thank you for your contribution to make the docs better! Much appreciated!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F1031%3Femail_source%3Dnotifications%26email_token%3DAKVZUKBSESFPJGFXKH67A6TRCH7B3A5CNFSM4KEY47DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELK6OEQ%23issuecomment-584443666&data=02|01|jedronke%40microsoft.com|101559e54bf7405cbeaf08d7ae93b65e|72f988bf86f141af91ab2d7cd011db47|1|0|637169821750115131&sdata=yL5%2FpnKPGFsYdNR47rjzzxSXmN1vZPKFMX%2B1oTvxWuc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKVZUKHZZAWXXLITVX3NFBTRCH7B3ANCNFSM4KEY47DA&data=02|01|jedronke%40microsoft.com|101559e54bf7405cbeaf08d7ae93b65e|72f988bf86f141af91ab2d7cd011db47|1|0|637169821750115131&sdata=ARuZHEK%2B7N5hQkEskaWG8mNboPwWGLdqVu4TWPlhous%3D&reserved=0.


fix(labs): successfully updated lab shows translation key instead of text

Fixed issue with translation key showing instead of the actual text when a lab is updated.
Fixes #2294
Changes proposed in this pull request:

Added successfullyUpdated key in the locale

Newly added dependencies with Bundlephobia links:
NONE

is this the same issue as issue #2293 @jackcmeyer

@ArslanM786 : #2293  is about the successfully created message.  This issue is about successfully updated
How is your work coming along?


DOCS-8461 Removed Blend Connector

Approved the removal of these release notes since the Blend connector was removed from Anypoint Exchange on April 28, 2020 per the direction from the MuleSoft's Business Development team.


Fix for missing index vars in for-in, add tests

Fixes https://github.com/lightscript/lightscript/issues/30

Ah, right, good point. Will also add a failing test case to catch that.

awesome, thanks.
it might make sense to add a helper function like you made for source locs
in the compiler, if you wanna do that you're welcome to
On Mon, May 8, 2017 at 3:09 PM William C. Johnson<EMAIL_ADDRESS>wrote:

Ah, right, good point. Will also add a failing test case to catch that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lightscript/lightscript-eslint/pull/2#issuecomment-300005076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq_LtRgw5mt9PrEqse-6udkpyHa06ojks5r35KHgaJpZM4NUh4r
.

@rattrayalex
I fixed this to generate source location information. Because they will be used here and in the compiler, as well as in several other projects I'm working on, I factored the ast node location tools to an npm module: https://www.npmjs.com/package/ast-loc-utils
I can inline them here if you don't want the extra dependency but ultimately I think factoring that code out for reuse is correct.

This is all happening in lscNodesToBabelNodes:  https://github.com/wcjohnson/lightscript-eslint/blob/8baae58ad76f17cba3145bf419b61ea793bdf750/babylon-to-espree/toAST.js#L53
So they will be further transformed to ESTree nodes afterward.

Awesome, thanks! Sorry I wasn't able to look into that myself, have been super busy lately.
If you feel like refactoring other parts of the file to use the same system, you're more than welcome to, but no obligation.
Nice work as always!


Update README.md

"Declaritive" --> "Declarative"

Woops, nice catch.

Feel free to close and edit separately if you're looking to maintain git log consistency. Just did a quick edit from the ui.

Fixed commit message while merging - thanks.

:tada: This PR is included in version 1.41.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ClientInner documentation missing from Git book

Hello, I'm relatively new to Github and issues, so I'm hoping this is something similar to the correct format.
I believe there is a missing documentation page for the ClientInner struct in the current iteration of the Git book. I was looking into the implementation of the DynamoDbClient constructor in rusoto::dynamodb and noticed, in the source code in the file rusoto/rusoto/services/dynamodb/src/generated.rs, there is the use of a ClientInner struct on line 23:
use rusoto_core::{ClientInner, RusotoFuture};

but a search for 'ClientInner' on rusoto.github.io returns no results.

ClientInner is intended for use within the rusoto_* crates only but having in the docs would suggest otherwise. Hence, it has been hidden from the docs. If you want to know what ClientInner is good for, you'll have to take a look at the source code.

Ah, understood. Thanks very much for the quick response!


undefined local variable or method `publisher'

I can't figure out how to get past this error. I've followed the instructions but I keep getting the error "undefined local variable or method `publisher'" whenever I run my specs.
I've added the following to my spec_helper.rb
RSpec::configure do |config|
  config.include(Wisper::RSpec::BroadcastMatcher)
end

In my test I've written a test like this
it "should broadcast a message for each integration type" do
  expect { publisher.execute }.to broadcast(:facebook_pixel_subscriber_created)
  SubscriberSubscriber.new.perform(@input_message)
end

I always get the error as shown here

Any ideas?

I think publisher must be a class instance variable belongs to your publisher class.

This doesn't look to be related to wisper-rspec.


New BMS configuration

This extend https://github.com/ipa320/cob_robots/pull/584

please rebase

I guess cob4-2 also uses the bms again now...but the xml has not been updated https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_bringup/robots/cob4-2.xml#L42-L50

so far cob4-7 is the only one with working BMS


seccomp: support "clone3" (return ENOSYS unless SYS_ADMIN is granted)

clone3 is explicitly requested to give ENOSYS instead of the default EPERM, when CAP_SYS_ADMIN is unset.
See moby/moby#42681 (thanks to @berrange).
Without this commit, rawhide image does not work:
$ sudo ctr run --rm --net-host --seccomp registry.fedoraproject.org/fedora:rawhide foo /usr/bin/curl google.com
curl: (6) getaddrinfo() thread failed to start

CI failure is unrelated
failed to resolve reference "mirror.gcr.io/library/busybox:1.32": mirror.gcr.io/library/busybox:1.32: not found: time="2021-09-13T06:58:03.494641378Z"


Opening Gallery or Camera Twice

I've seen someone fixed it, but the pull request doesn't accept.
Could anyone solve this problem?

@FarshidABZ  Use Default method instead of InlineActivityResult. The issue seems to be in InlineActivityResult not in ImagePicker.


Git tests fix

Issue #, if available:
Description of changes:
make sure to enable generic git provider
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/override eks-anywhere-presubmit
/override eks-anywhere-e2e-presubmit
/override eks-anywhere-attribution-files-presubmit

/approve

/override eks-anywhere-attribution-files-presubmit
/override eks-anywhere-presubmit
/override eks-anywhere-e2e-presubmit


Transaction API

// Flat interface.
var trx = db.begin();
trx.on('commit', function() {});
trx.on('rollback', function() {});

trx.rollback();
trx.commit(); // No implicit commit when calling db.begin();

// Creates a new stack
db.transaction(function(trx) {
    trx == this
    // implicit begin

    // transaction objects are like database objects:

    trx.run("CREATE TABLE foo (id INT PRIMARY KEY, bar)");
    trx.run("INSERT INTO foo VALUES(?, ?)", 1, "first text");
    trx.run("INSERT INTO foo VALUES(?, ?)", 1, "second text"); // will fail
    trx.run("INSERT INTO foo VALUES(?, ?)", 1, "third text", function(err) {
        if (err) {
            // Do nothing and the error will be ignored

            // See below for more explanation
            trx.clear();
            trx.rollback();
            trx.commit();
        }
    });

    trx.on('rollback', function() {
        // This is emitted after the transaction was rolled back.
    });

    trx.on('commit', function() {
        // This is emitted after the transaction was committed successfully.
    });

    trx.on('error', function() {
        // This will be called when a statement execution doesn't have a callback
        // and no error handlers.

        // removes all further statements from the stack. You can now add more
        // statements to the stack. the automatic commit on empty stack persists.
        // Does not remove the error handler, you have to do that manually.
        trx.clear();

        // removes all further statements from the stack and does a rollback of the
        // entire transaction.
        trx.rollback();

        // removes all further statements from the stack and commits the transaction
        trx.commit();
    });

    // when no error handler is attached and an error bubbles up to the transaction's
    // error event, the transaction is rolled back and the rollback event is emitted.

    // implicit commit when the stack is empty.
});

I'd like an answer to ghost's question, please. It's not clear in the docs.

You only have to pay attention that no other code holding the database handle injects queries inside the transaction that shouldn't be there.

What's the best way to do this? Is it sufficient to put the transaction inside db.serialize? Will that block other non-db things like http server events?

@kkaefer is it required to catch exceptions and call db.run('ROLLBACK')? For example:
  await db.run('BEGIN');
  try {
    await db.exec(sql);
  } catch (err) {
    await db.run('ROLLBACK');
    throw err;
  }

I would like to know under which condition a ROLLBACK should be issues? It is not clear to me if this is done automatically by the engine. In other words, I would assume that upon any failure, the entire transaction is being rolled back to the state before. Otherwise, what would be the motivation to use a transaction in the first place?

Clsoing in favor of https://github.com/TryGhost/node-sqlite3/issues/304


Finish the incomplete implementations of the 3-opt* (inter-route 3-opt)

VeRyPy has a proven implementation of 3-opt* that operates on the entire solutions (which resides in local_search/solution_operators.py. Proven here means that it is able to replicate results from the literature.
3-opt* was one of the trickiest heuristics to implement, and, hence, there were many attempts, some of which remain incomplete. These were left where they were, because, even if the 3-opt* solution operation  is verified to work through replication of Stewart & Golden results, VeRyPy would benefit from supporting implementations. For example, the 2 and 3 route heuristics as incompletely implemented in the do_3optstar_2route_move and do_3optstar_3route_move would allow a more convenient use of the 3-opt* in some special occasions. Another advantage would a unified interface to 3-opt* although with a slight performance and maintenance penalty.
While you, good reader, are at it, please also consider writing the do_naive_3optstar_move. In fact, thinking about it, that would be perfect place to start!

I transferred these incomplete implementations to the separate inter_route_3opt_operators.py file so that they are not used by accident.


Using externals section of config.json

Category
[ ] Enhancement
[ ] Bug
[X] Question
Version
Please specify what version of the library you are using: [1.11.0]
Question
I'd like to be able to leverage the externals section of the config.json file when using this package.
But i can't see which file for the spfx-controls-react package to reference.
As a starter i tried just to add pnp/js in as detailed here.
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/use-sp-pnp-js-with-spfx-web-parts#deploy-to-production
I've also tried this
"@pnp/pnpjs": {
      "path": "https://cdnjs.cloudflare.com/ajax/libs/pnp-pnpjs/1.0.1/pnpjs.es5.umd.bundle.min.js",
      "globalName": "pnp"
    }

But neither work and I get an error in the part saying @pnp/js could not be loaded.
Any ideas how i can use this package and reference the files externally?
Thanks!

Hi @SteveClements,
Are you still looking for help about this one?
The page you're refering to has been updated since, so I'm not sure that it will guide you regarding your question.
However, there's an article that could help you about using external libraries in an SPFx project.
Regarding your question about using SPFx Controls as an external package, here's the CDN: https://www.jsdelivr.com/package/npm/@pnp/spfx-controls-react.
Hope that it helps.


Redesign conversion system

The conversion form needs to be redesigned to ensure mobile compability and incorpoerate fully MUI support.

This application redesign is complete


[WIP] Make endpointSpec as obj not pointer

Signed-off-by: Flavio Crisciani<EMAIL_ADDRESS>

Please also add a comment in the PR on the motivation for this change

Guys still a work in progress wait before reviewing


Swagger fixes as per s360 for databox.

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

NA, since PR is for fixing swagger S360 issue for existing version.

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

NA, since PR is for fixing swagger S360 issue for existing version.

By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

NA, since PR is for fixing swagger S360 issue for existing version.
Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:
NA, since PR is for fixing swagger S360 issue for existing version.

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run


[Tangram R&D] Update API to make it compatible with 0.12.0 tangram release

The new tangram point outline feature has a different API.
It is:
{
  outline: {
     width: "5px",
     color: red
  }
}

We had:
{
  outline_width: "5px",
  outline_color: red
}

Acceptance criteria
It should draw outlines.
Steps:

Go to the branch
install all dependencies
npm run start
go to the browser
click load and go to France
check the markers with outlines

I'm afraid that I'm not seeing outlines:

Please, let me known when it's ready for acceptance

Is this what we wanna see?

Acceptance: OK


Feature/tailwindcss

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request? (put an "x" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (Give an overview)
Updated admin panel and pages that belong to admin features with tailwindcss and gave them a new fresh look.
Affected pages are:

admin panel
login
diskusage
debug
manual

This update cleans up the styling, the generated php code for frontend rendering and a bit js rework and updates.
Also implements tailwindcss in gulp so that the use of css classes for styling is not longer needed.
Is there anything you'd like reviewers to focus on?
@andi34 this update took a while and removed a few "custom stylings and settings" for the admin area but i think its not necessary for a photobooth admin panel. I did not remove the custom settings at all, maybe you can have a look at this. the focus is now a more clean ui and an easy and fast styleable UI without writing css.
Because of there were so many files changed please have a look at all the changes / documentations and functions in admin panel. Hopefully there is nothing screwed up and all works well.
Maybe we should add more reviewers before merging this changes -> if you like the updated and we want to implement it :)

Wow, Great! Yeah, the adminpanel was one of the things I'd liked to look at in future too, haha. Great you took the advantage! I hope to get the api and classes rework finished next week and find time to look at your PR closer!
The remotebuzzer changes are the only things I need/like.to merge before the big re-write

Fixed getting content inside debugpanel.
Looks really nice in general 😊
Can we make the colors adjustable?
On mobile view the top elements get lost if i select a category from the list

Going to rebase in next hours.


Change cursor based on min/max state

External feature request:

Will there be a change to the mouse cursor changing its icon based on the given state? For example, if the mouse resizes to the min size and it can't keep resizing, the cursor will change to the icon that reflects the allowed directions.
This video is from the VS Code editor.

0.0.24


fix: Support multiple calls to staticFileLocation #568

You can add multiple static file locations like:
staticFiles.location("/public");
staticFiles.location("/secondPublic");

Having this would be really great as you  could use custom files from static and webjars together.

Having this would be really great as you  could use custom files from static and webjars together.

@udonne This looks great, could you update it?

Pinging @udonne

Any updates?


Document: add onSuccess (and other delayed callbacks) will only fire for the latest mutation

https://github.com/tannerlinsley/react-query/issues/241#issuecomment-648973545

Here's a sandbox: https://codesandbox.io/s/unruffled-sid-g2tzx?file=/src/App.js

The mutation function will call it as many time as you hit the button.
The onMutate callback will fire for every time
The onSuccess (and other delayed callbacks) will only fire for the latest mutation

Why don't we describe this on document page? :
The 'onSuccess' (and other delayed callbacks) will only fire for the latest mutation
Originally posted by @qkreltms in https://github.com/tannerlinsley/react-query/issues/241#issuecomment-754391100

We'll gladly accept any PRs to clarify this behavior in the docs 👍

We'll gladly accept any PRs to clarify this behavior in the docs 👍

I'm on it

I'm on it


Spinbox Tooltip only applies for the control not the line edit

Godot version: 3.0, potentially 2.1 (untested)

OS/device including version: Fedora Linux - x64

Issue description:

The text area / line edit of the spinbox does not show the tooltip.
This reduces the area for the tooltip to the little control area.

Steps to reproduce:

Create a SpinBox
Set a tooltip
Hover over the control area (arrows)
Tool tip is shown
Hover over the SpinBox line edit
No tooltip is shown

I assume that problem exists for any composited control.
A way to solve this is to emit a notification in "control" when the tooltip has changed, so that composited controls can update the tooltips of other controls.
Feedback appreciated.

Probably related to #6328


Sync changes in Audio API

Codecov Report
Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.13%. Comparing base (8ff15ef) to head (7cbe763).

Files
Patch %
Lines

.../github/sashirestela/openai/domain/audio/Word.java
0.00%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #78      +/-   ##
============================================
- Coverage     89.62%   89.13%   -0.50%
- Complexity      630      633       +3
============================================
  Files           116      118       +2
  Lines          1002     1012      +10
  Branches         15       15
============================================
+ Hits            898      902       +4
- Misses           78       83       +5
- Partials         26       27       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Colin/abstract main

[x] Moves the logic for chain out of main.rs and into chain.rs.

Depends on #219 first as I was working ahead of that branch.

Closes #214


[BUG] Multiple SLF4J bindings reported in server chassis

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
After launching server chassis, the following is reported:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/jonesn/IdeaProjects/egeria.gradle/open-metadata-distribution/open-metadata-assemblies/build/unpacked/egeria-3.5-SNAPSHOT-distribution.tar.gz/server/lib/graph-repository-connector-jar-with-dependencies-3.5-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/jonesn/IdeaProjects/egeria.gradle/open-metadata-distribution/open-metadata-assemblies/build/unpacked/egeria-3.5-SNAPSHOT-distribution.tar.gz/server/server-chassis-spring-3.5-SNAPSHOT.jar!/BOOT-INF/lib/logback-classic-1.2.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.

This is a regression, seemingly introduced when the graph repository connector was split out.
Since the connector is not an application it MUST NOT provide a log4J binding, but it appears to. This needs to be removed.
Expected Behavior
No log entries
Steps To Reproduce
run server chassis
Environment
n/a

Any Further Information?
Since the connector is not an application it MUST NOT provide a log4J binding, but it appears to. This needs to be removed.

Duplicates: #6111


[Feature] Optimize count(1) in hdfs scanner by rewriting plan to sum

Why I'm doing:
Rigjht now hdfs scanner optimization on count(1) is to output const column of expected count.
And we can see in extreme case(large dataset), the chunk number flows in pipeline will be extremely huge, and operator time and overhead time is not neglectable.
And here is a profile of select count(*) from hive.hive_ssb100g_parquet.lineorder. To reproduce this extreme case, I've changed code to scale morsels by 20x and repeat row groups by 10x.
in concurrency=1 case , total time is 51s
         - OverheadTime: 25s37ms
           - __MAX_OF_OverheadTime: 25s111ms
           - __MIN_OF_OverheadTime: 24s962ms

             - PullTotalTime: 12s376ms
               - __MAX_OF_PullTotalTime: 13s147ms
               - __MIN_OF_PullTotalTime: 11s885ms

What I'm doing:
Rewrite the count(1) query to sum like.  So each row group reader will only emit at one chunk(size = 1).
And total time is 9s.
Original plan is like
+----------------------------------+
| Explain String                   |
+----------------------------------+
| PLAN FRAGMENT 0                  |
|  OUTPUT EXPRS:18: count          |
|   PARTITION: UNPARTITIONED       |
|                                  |
|   RESULT SINK                    |
|                                  |
|   4:AGGREGATE (merge finalize)   |
|   |  output: count(18: count)    |
|   |  group by:                   |
|   |                              |
|   3:EXCHANGE                     |
|                                  |
| PLAN FRAGMENT 1                  |
|  OUTPUT EXPRS:                   |
|   PARTITION: RANDOM              |
|                                  |
|   STREAM DATA SINK               |
|     EXCHANGE ID: 03              |
|     UNPARTITIONED                |
|                                  |
|   2:AGGREGATE (update serialize) |
|   |  output: count(*)            |
|   |  group by:                   |
|   |                              |
|   1:Project                      |
|   |  <slot 20> : 1               |
|   |                              |
|   0:HdfsScanNode                 |
|      TABLE: lineorder            |
|      partitions=1/1              |
|      cardinality=600037902       |
|      avgRowSize=5.0              |
+----------------------------------+

And rewritted plan is like
+-----------------------------------+
| Explain String                    |
+-----------------------------------+
| PLAN FRAGMENT 0                   |
|  OUTPUT EXPRS:18: count           |
|   PARTITION: UNPARTITIONED        |
|                                   |
|   RESULT SINK                     |
|                                   |
|   3:AGGREGATE (merge finalize)    |
|   |  output: sum(18: count)       |
|   |  group by:                    |
|   |                               |
|   2:EXCHANGE                      |
|                                   |
| PLAN FRAGMENT 1                   |
|  OUTPUT EXPRS:                    |
|   PARTITION: RANDOM               |
|                                   |
|   STREAM DATA SINK                |
|     EXCHANGE ID: 02               |
|     UNPARTITIONED                 |
|                                   |
|   1:AGGREGATE (update serialize)  |
|   |  output: sum(19: ___count___) |
|   |  group by:                    |
|   |                               |
|   0:HdfsScanNode                  |
|      TABLE: lineorder             |
|      partitions=1/1               |
|      cardinality=1                |
|      avgRowSize=1.0               |
+-----------------------------------+

Fixes #45242
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.3


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.7 to before v4.19.209",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9bdcb44e391da5c41b98573bf0305a0e0b1c9569",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=30d57cf2c4116ca6d34ecd1cac94ad84f8bc446c"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "9bdcb44e391da5c41b98573bf0305a0e0b1c9569",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "30d57cf2c4116ca6d34ecd1cac94ad84f8bc446c",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "cpufreq: schedutil: Use kobject release() method to free sugov_tunables\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.19.209 by commit 30d57cf2c4116ca6d34ecd1cac94ad84f8bc446c, it was introduced in version v4.7 by commit 9bdcb44e391da5c41b98573bf0305a0e0b1c9569. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001564


⚠ Turnos 24x7 has degraded performance

In d97f93c, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1147 ms

Resolved: Turnos 24x7 performance has improved in 2c2855c.


Spacebar navigation

Scrolls current detail view if needed, then goes to next unread, so you can page through all unread articles using just the space bar.

Still needs to work in detail view.


feat: DOES NOT WORK YET DON'T PUSH TO MAIN, Progress onDareSyncHelper…

… functions added and migrations.

@Luke-Young20 convert the PR to a draft if you want to make sure it can't be accidently merged :)
The link to make it a draft is annoyingly subtle, and shows up in the area for assigning reviewers when the PR is not a draft yet.


Add and URLBuilder and tests

Supporting storage's dataplane swagger specification requires some tricky URL manipulation. When we implemented Java's runtime, the easiest way to do this was to create a URL parser/manipulator and to use that. This is just a port of the URLBuilder we used in the Java runtime and its tests.

Is the generator going to start referencing this?

@RikkiGibson Yes.


Add exponential backoff option to consumer.sh script

At the moment the run loop don't take into account the exit status of the executed sub process:
https://github.com/DevOoops/docker/blob/2043501bbdae1e8531142d65cb518ec0ba1d4bea/php/consumer.sh#L35-L39

[ ] Apply exponential back off principles in case of non zero exit code: sleep 2^ATTEMPT_NUMBER, capped to max sleep time (default, 2, can be set via -s option)

You will have to collect the exit code of the sub process this way:
    "$@" &
    SUBPROCESS_ID=$!
    wait $SUBPROCESS_ID
    exitCode=$?

You can take some inspiration from this post


check if calico_peer_rr is defined

@adidenko

peer_with_calico_rr is set as fact in preinstall/tasks/set_facts.yml task and there's no description in PR so I'm not sure what this patch is going to solve.

It shortcut the upgrade.yml to only node/master, and that was the only value undefined.
I can give another try.


Constraint generic build input type on client builder

This will ensure the input structure for the client builders build method to construct resources based
on a manifest passed through forge.

Thank you! ❤


Add files via upload

fixed relative path so etdata imports properly on Windows

Does this affect code when ran on linux?


Can we have id formatter, like name formatter ?

Hey hkalbertl,
I have been using your plugin from last four years in my various projects. It offers great extensibility and features, thanks for developing and maintaining this wonderful library.
Can we have id formatter (like we do have for name)?
idFormatter: function (idPrefix, name, uniqueIndex) {        return name + '_' + uniqueIndex;  }
Thanks

Hi hmshafeeq,
Good to know that appendGrid can fit your projects need!
For your question about id formatter, appendGrid will generate input id for each control internally. This input id is unique and able to let appendGrid look for correct input element accurately. Also, appendGrid offered idPrefix that allow developers to customize the first part of the above input id. In order to prevent the input id duplicated, I tend to not making such changes.
As classic HTML form are using name instead of id and AJAX can fully customize the submit parameter name, may I ask why you need a custom id for the input controls?

For example, if add following column in the grid,
{
   name: 'material[]', display: 'Material', type: 'select', ctrlClass: "form-control selectpicker",
   ctrlAttr: {required: true, onchange: 'onChangeMaterial(this)'},
   ctrlCss: {'min-width': '250px'}
}

Generated id for this field in first row will be tblAppendGrid_material[]_2.
Now, if i try to access the field like $("#tblAppendGrid_quantity[]_2") i will get Error: Syntax error, unrecognized expression: #tblAppendGrid_quantity[]_2. Doing the same with javascript works fine.
Also it will look cleaner to have id like tblAppendGrid_quantity_2, tblAppendGrid_quantity_3
idFormatter: function (idPrefix, name, uniqueIndex)
 {
      return  idPrefix +'_' + name.replace('[]','') + '_' + uniqueIndex;
 }

Thanks

Hi, I got your problem now. As you know that the name of each column definition will be used for id and name of generated input control, putting non-alphanumeric may cause unexpected behaviors.
In your case, bracket [] were used as name of a column. I tested that it is fine to use in HTML id / name but it has special meaning in jQuery selector.
Although appendGrid can work fine (such as insert / append / load / getAllValue) in your case, but I recommend not to use bracket in name. If you really want to use in that way, you may try one of the following alternative:

Use appendGrid native method $("#tblAppendGrid").appendGrid("getCellCtrlByUniqueIndex", "quantity[]", 2)
Use document.getElementById("tblAppendGrid_quantity[]_2") instead
Escape the bracket in jQuery selector, such as $("#tblAppendGrid_quantity\\[\\]_2")

You may try my test case here.
Hope it can help!

Hey @hkalbertl
Yes, it helped. Thanks for providing detailed alternatives.


[usermanager] User switch support. Fixes JB#47686

Renamed the methods as requested

Almost good. One small thing and a nit.


Feature/modernise setup

Closes #44
Closes #34
Closes #33

@ZedThree FYI I changed the tests target to dev


Test Spyder with Python 3.5

Ok, let's keep going with more testing and now do this! :-)
All Spyder dependencies are available as conda packages in 3.5, so why not?

Well, Jedi 0.8.1 is missing, so I'll have to do something about it :-)


Add support for UserList

Technical details:

display a UserList in the right to replace the current buttton (refers to our UI design);
to display all online users on this board (refer to js.design)
we don't need to support watch in the MVP version
ExcalidrawSyncService, Collab.tsx

room - boardId
getUserListByBoardId (not from MongoDB, from SyncService memory)

no permission control in the MVP version

Behaviour:

A, B on the board http://localhost:3000/board/yidoD7FxvDNwNsRjh, UserList should be A, B.
A, B, C -> A, B +1

Can you assign me this issue @shiqimei @ccbond

@shiqimei can i start on this issue I think it will be helpful in project also ?


Define GZ_LAUNCH_VERSION_NAMESPACE in config.hh

🦟 Bug fix
Part of gazebosim/gz-cmake#412.
Summary
Ensure that the GZ_LAUNCH_VERSION_NAMESPACE macro is defined in config.hh.in.
Checklist

[X] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[X] codecheck passed (See contributing)
[X] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

there are problems with CI


Add logging across subscribers and publishers

Add logging for all versions of subscribers and publishers.
Implement a dedicated logger to trace raw publsub messages into logs as
debug level.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@52a4ffe). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage        ?   60.82%
=======================================
  Files           ?       14
  Lines           ?     1205
  Branches        ?        0
=======================================
  Hits            ?      733
  Misses          ?      369
  Partials        ?      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a4ffe...5688353. Read the comment docs.


Remove disabled-look from days in previous/next month

While working with the react-datepicker I discovered that days in the
previous and/or next months look like they're disabled, but they're
not.
We should make it more clear dates in the previous and/or next month
are selectable. In order to achieve this, I propose to remove this
this-month state and make the day's color default to black.
Screenshot:

I agree, looks better!

I find this really confusing. I pretty much expect not current month days to look 'disabled'. It is clear that you can click on them because when you hover over a disabled date it shows that it is selectable.
For example, March is a huge month, and now it just looks like a blanket of dates:

I personally find the old version much easier to read:

See the standard in datepickers: http://www.eyecon.ro/bootstrap-datepicker/

Example in the wild:
http://www.kayak.com/

Agreed, the old situaon gave a better overview what's in a month and what's not. The only downside of the previous implementation was the it's hard to make a difference between disabled dates and dates that aren't in the current month. I'm not sure how we should solve that since there's 1 really big difference between those: The ability to click on a date.

I'm not sure what you mean, you were still able to click on the date if it wasn't in the featured month. I think that's pretty standard and expected behavior.

@hahahana @lbekkema implemented a way of disabling dates, so you could say that the user is only allowed to select dates within a certain range. He decided to re-use the "disabled" state that we had for dates that were not in the current month, which really made things harder to understand. IMO all we have to do is split up the two different disabled states and give them their own styling:

Disabled (can't select)
Not in the current month (can select, but will switch months)


dApp Wallet API for anyone creating a UI to query

See how we can build something with relatively small changes to the existing wallet if possible, a library for anyone creating a UI to use to query keys etc. Focus on the core things, simplist API that lets us do stuff.
YOu can do certain amounts of wallet management via a thing. - One thing we'll have in console is multi keys to isolate positions on to a new key you might give console th
JS library for anyone to query keys / send transactions....

Moved this to the right repo https://github.com/vegaprotocol/vegawallet-ui/issues/44


Defer setup to avoid module import-time side-effects

This PR makes several "friendly neighbour" changes to the pHAT BEAT library:

Do not perform any module setup on import
Do not output any messages/text on import
Use ImportError instead of hard exit() for "friendly" import error messages

See here for details of the problems import-time side-effects can have: https://www.raspberrypi.org/forums/viewtopic.php?f=32&t=193502&p=1212488#p1212488

Needs to drop ensure_setup() and just have setup() set an _is_setup flag and not run any of the actual setup routines twice. The current method is unnecessarily convoluted.


Support labelled signal axes

Description
This PR adds support for passing axis string labels (as an alternative to integers) to the phasor_from_signal and plot_signal_image functions. The labels are used to index xarray.DataArray instances returned from the read functions in phasorpy.io.
The axis parameter default is changed from the last axis to 'H', 'C', or last axis (whatever is found first).
'H' or 'C' axes coordinates in the DataArray, if any, are used for plotting.
This PR also fixes a bug in the coordinates returned by the read_imspector_tiff function (#105).
Checklist

[x] The pull request title and description are concise.
[x] Related issues are linked in the description.
[x] New dependencies are explained.
[x] The source code and documentation can be distributed under the MIT license.
[x] The source code adheres to code standards.
[x] New classes, functions, and features are thoroughly tested.
[x] New, user-facing classes, functions, and features are documented.
[x] New features are covered in tutorials.
[x] No files other than source code, documentation, and project settings are added to the repository.

Thanks @bruno-pannunzio

since they don't have to necessarily keep track of the time axis (or spectra)

Still, the "magic" will fail in some cases. For some formats, which don't have a 'C' or 'H' axis (B64, Z64), it is still necessary to manually specify the first axis. Also, the channel 'C' axis is commonly not only used for equidistant emission wavelengths but, for example, for color components like RGB or separate detectors/cameras. The axis labels 'C' and 'H' are taken from the OME model btw. For now, I left the axis parameters in the tutorial even though it is no longer necessary in those cases.


Nodejs Connector is not working with the latest Zeebe 8.0.5 version

Hello,
We noticed there is an issue with new clusters with the version of 8.0.5.
Can you please recommend a solutions?
Error is:
12:44:04.703 | zeebe |  INFO: Authenticating client with Camunda Cloud...
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error: 13 INTERNAL: Received RST_STREAM with code 0
    at Object.callErrorFromStatus (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\call.js:31:19)
    at Object.onReceiveStatus (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\client.js:190:52)
    at C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\call-stream.js:111:35
    at Object.onReceiveStatus (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\zeebe-node\dist\lib\GrpcClient.js:136:36)
    at InterceptingListenerImpl.onReceiveStatus (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\call-stream.js:106:23)
    at Object.onReceiveStatus (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\client-interceptors.js:365:141)
    at Object.onReceiveStatus (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\client-interceptors.js:328:181)
    at C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\call-stream.js:188:78
    at processTicksAndRejections (node:internal/process/task_queues:78:11)
for call at
    at ServiceClientImpl.makeUnaryRequest (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\client.js:160:30)
    at ServiceClientImpl.<anonymous> (C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\@grpc\grpc-js\build\src\make-client.js:105:19)
    at C:\Users\*\Documents\GitHub\camunda\camunda-platform-get-started\nodejs\node_modules\zeebe-node\dist\lib\GrpcClient.js:306:47
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  code: 13,
  details: 'Received RST_STREAM with code 0',
  metadata: Metadata { internalRepr: Map(0) {}, options: {} }
}

Hey, can you provide more information how to reproduce this? Just to make sure, please ensure to update the credentials inside the source files, otherwise a exception like this will be show, as the provided credentials are not valid.
I will close this issue right now, as I assume it's related to the credentials, in case you can reproduce it and provide more information feel free to reopen the issue.

Hey, can you provide more information how to reproduce this? Just to make sure, please ensure to update the credentials inside the source files, otherwise a exception like this will be show, as the provided credentials are not valid.
I will close this issue right now, as I assume it's related to the credentials, in case you can reproduce it and provide more information feel free to reopen the issue.

Hello, it appears that I had to add the region to the connection parameters.
Thanks.


running on cpu

Hi,
following the tutorial in the following link:
http://nnabla.readthedocs.io/en/latest/python/tutorial/multi_device_training.html
I run: rc = ipp.Client(profile='mpi')
/usr/local/lib/python3.5/dist-packages/ipyparallel/client/client.py:458: RuntimeWarning:
Controller appears to be listening on localhost, but not on this machine.
If this is true, you should specify Client(...,sshserver='you@bashar-ThinkPad-T460')
or instruct your controller to listen on an external IP.
RuntimeWarning)
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/IPython/core/interactiveshell.py", line 2910, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
rc = ipp.Client(profile='mpi')
File "/usr/local/lib/python3.5/dist-packages/ipyparallel/client/client.py", line 511, in init
self._connect(sshserver, ssh_kwargs, timeout)
File "/usr/local/lib/python3.5/dist-packages/ipyparallel/client/client.py", line 630, in _connect
raise error.TimeoutError("Hub connection request timed out")
ipyparallel.error.TimeoutError: Hub connection request timed out
Any idea how to solve that?

Please look at this url to turn on ipcluster in mpiexec/mpirun mode.

Has this already been resolved?
I will close this, but if you need further supports/questions, please recreate new issue.


unit validation improvement

Added $ to the end of unit validation regex strings.
For example, this will match 5fr but not 5fra

Thanks!


Create more front matter content on site

Right now the site looks plain with just the logo.  It should have some more content at least pointing to the meetup page about when events are, etc.

Code of Conduct
About blurb
List of upcoming meetups
Join 757Dev Slack Channel
Follow Twitter

I can fill in the content, with the code of conduct, about blurb, etc.  If you need the links for the twitter, etc, also let me know.


Add wave support to pipelines to run stages in parallel.

Add wave support to pipelines to run stages in parallel<EMAIL_ADDRESS>

Wave support provided. Closing the issue.


Fix README.md. Missing ```

This patch follows the one from: https://github.com/nlohmann/json/pull/2074.
An error has been introduced by accepting the suggestions. See:
https://github.com/ArthurSonzogni/json/commit/4be4a038ccd17aab0a4cc85200a6a0b41e1cccf2
One suggestion was about removing ~~~, but it was meant to be replaced
by ``` in reality. This caused the README.md to be slightly broken.

Hi again,
It looks like there was a small issue in the previous patch. I blindly accepted all the suggestions, but I didn't realize one was removing ~~~ without replacing it with ```
Could you please take a look?

Thanks!

Thank you!


Feature request: DO NOT reset when unlocking Windows as an option

Hello.
Earlier there were "Feature request: reset when unlocking Windows"
May it be the option either Turn ON or Turn OFF such behaviour?
I don't like it at all reseting current break when I unlock my pc.
Usually I lock pc when breaks time comes, go away for some time, come back, unlock pc and want to see is break time is over and see nothing.
In very early versions there were no such inconvinient option, really miss that time.

It was really buggy because "time" is not working correctly when PC is locked. I can bring that option but I will not support it working correctly.

It was really buggy because "time" is not working correctly when PC is locked. I can bring that option but I will not support it working correctly.

I remember that it worked fine, I unlocked pc and saw the screen of break and time looked correct.
I really wish you add this option(on/off reset breaks when unlock pc).
Thank you for answer!


[Testing Confirmation] Confirm current testing requirements

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.
Looking at the OpenSearch-rs repository, it appears there is

Repository
Unit Tests
Integration Tests
Backwards Compatibility Tests
Additional Tests
Link

OpenSearch-rs
- [x]
- [x]
- [ ]
Changelog verifier, Link Checker, Clippy Check, Certificate of Origin
https://github.com/opensearch-project/opensearch-rs/issues/127

I don't see any requirements for code coverage in the testing documentation. If there are any specific requirements could you respond to this issue to let me know?
If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

Hi @scrawfor99, clients test compatibility with multiple versions of OpenSearch. See https://github.com/opensearch-project/opensearch-rs/blob/main/.github/workflows/test.yml. Can you please check the box in the issue?


Custom Mapping Not Honored After Upgrade

I used to have everything working fine, now I upgraded to the versions below and it seems like my custom mapping is ignored.
Versions before upgrade
Couchbase: 3.5
Elasticsearch: 1.7.2
Transport plugin: 2.0.0
Versions after upgrade
Couchbase: 4.0.0-4051
Elasticsearch: 2.3.1
Transport plugin: <IP_ADDRESS>
Before the upgrade I had my index created with a custom mapping and all properties would get correct types according to this mapping.
After the upgrade the replication is working fine but the custom mapping is ignored, wondering what have changed, do I need to use the plugin template now? or do I need to change my custom mapping some how?
My understanding is that the template is for default/dynamic mapping only, I didn't install the template, I directly created an index with custom mapping.
One of my types custom mapping is below
"park": {
	  	"transform": [
		  {
		  	"lang": "groovy",
		  	"script": "ctx._source['geoData'] = geoDataField",
		  	"params": {
		  		"geoDataField": {
		  			"type": "circle",
		  			"coordinates": [
					  0,
					  0
		  			],
		  			"radius": 0
		  		}
		  	}
		  },
		  {
		  	"lang": "groovy",
		  	"script": "ctx._source['geoData'].coordinates = [ctx._source['doc'].geoCenter.lon , ctx._source['doc'].geoCenter.lat]"
		  },
		  {
		  	"lang": "groovy",
		  	"script": "ctx._source['geoData'].radius = ctx._source['doc'].radius"
		  }
	  	],
		"_source": {
			"includes": [
			  "doc.*"
			],
			"excludes": [
			  "meta.*"
			]
		},
		"properties": {
			"meta": {
				"properties": {
					"rev": {
						"type": "string"
					},
				  "flags": {
				  	"type": "long"
				  },
				  "expiration": {
				  	"type": "long"
				  },
				  "id": {
				  	"type": "string",
					"index": "not_analyzed"
				  }
				}
			},
		  "doc": {
		  	"properties": {
		  		"dateTimeCreated": {
		  			"type": "date"
		  		},
			  "dateTimeModified": {
			  	"type": "date"
			  },
			  "name": {
			  	"type": "string"
			  },
			  "description": {
			  	"type": "string"
			  },
			  "isPublic": {
			  	"type": "boolean"
			  },
			  "geoCenter": {
			  	"type": "geo_point",
				"geohash": true,
				"geohash_prefix": true,
				"geohash_precision": 3
			  },
			  "radius": {
			  	"type": "long"
			  },
			  "type": {
			  	"type": "string"
			  },
			  "userId": {
			  	"type": "string",
				"index": "not_analyzed"
			  }
		  	}
		  },
		  "geoData": {
		  	"type": "geo_shape",
			"tree": "quadtree",
			"precision": "1m"
		  }
		}
	  }

Looks like Elasticsearch is using dynamic mapping anyway, as pretty much all the settings in my mapping are ignored, examples below:
meta is coming through even though it is execluded.
radius is double even though I specified it as long
geoCenter is no longer recognized as geo_point, I can verify by doing a GET _mapping on the park type, it will display property mapped as below
"geoCenter": {
"properties": {
"lat": {
"type": "double"
},
"lon": {
"type": "double"
}
}
}

But before the upgrade when I perform the same GET _mapping I get the correct type as below
"geoCenter": {
"type": "geo_point",
"geohash": true,
"geohash_prefix": true,
"geohash_precision": 3
}

Plugin settings in elasticseach.yml, I had to change this to work with new plugin after upgrade
couchbase.password: xxxx
couchbase.username: xxxx
couchbase.typeSelector: org.elasticsearch.transport.couchbase.capi.GroupRegexTypeSelector
couchbase.typeSelector.documentTypesRegex: ^(?<type>\w+)_.*$

The mapping is honored when I remove the transforms, looking this up transforms have been deprecated in Elasticsearch 2.0.
Closing the issue.


Grip

Motivation for this change
enable missing tests from #19019
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Great, thanks @Mic92 !

oh, I missed it now, but please use in the future the 'full' attribute name, so e.g. pythonPackages.grip.


Cirrus: One IRC notice only

The podbot messages are becoming obnoxious as more distributions are
tested.  Only call the success.sh script once, after all testing was
successful.  Also make update the message to include more helpful text
and url.
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

One question otherwise LGTM

Thanks for checking @mheon .  TBH, podbot.py is getting long in the tooth, and I'm starting to feel a slight tug toward having a proper interactive bot.  Cirrus has a webhook scheme and API for communicating.  All we need is a persistent VM to listen and respond...oh, and some code to make to actually do stuff :smile:

One last broken thing, it reports URL as https://SECRET.com/build/4857214961451008.  This is because of an encrypted value that can simply be removed...

The message we got on IRC was:
podbot_52204240> Cirrus-CI testing successful for PR #2020: https://cirrus-ci.com/build/5451464187052032

@mheon @baude PTAL this is ready to go.

LGTM

/lgtm

Oh, it's missing an approve.
/approve


using an xc potential without the energy functional

I would like to use a new xc potential in the Kohn-Sham Hamiltonian for a given system. This xc potential does not have an energy functional, it reads:
$v_{\rm xc}({\bf r},[n]) =  v^{\rm LDA}_{\rm xc} (n^c_r )$
where:
$n({\bf r})$ is the electronic density,
$v^{\rm LDA}_{\rm xc}(n)$ is the LDA xc potential function,
$n^c_{\bf r} = \int d {\bf r}' \frac{f_{\rm xc}( |{\bf r}-{\bf r}'|, n_0) }{f^h_{\rm xc}(n'_0)} n({\bf r}')$,
with $f_{\rm xc}(|\mathbf{r}-\mathbf{r}'|,n_0)=\left.\delta v_{\rm xc}(\mathbf{r},[ n])/\delta n(\mathbf{r}')\right|{n=n_0}$ is the static non local xc kernel of the homogeneous electron gas with density $n_0$, and $f^h_{\rm xc}(n'_0)$ is its limit of zero wave-vector. Both functions are parameterized and available,
$n_0=\frac{n({\bf r})+n^c_{\bf r}}{2}$ and $n'_0=\frac{n({\bf r})+n({\bf r'})}{2}$.
Could you provide me with guidelines to implement and use this functional?

So in general if you want a new term that isn't covered by the existing ones you have to implement it yourself: look at hartree.jl for instance. If you don't have an energy functional, you can set it to an arbitrary value; it might break things in DFTK (like the default heuristics for the SCF) but that can be fixed. The issue I see here is that your potential function is not a simple form in the density, because the kernel K(r,r') = fxc(r-r', n0)/fxch(n0') looks like a general nonseparable function of r and r' (not of r-r'). You can implement it directly, but it will probably be pretty expensive. I'd start by getting and idea of how costly (in flops and in ram) it is to form the matrix K(r,r') for all r,r' in the grid (of size basis.fft_size), for the system of interest. If it's doable you can try, but you will very likely be limited to very small systems.

I don't find hartree.jl. I also checked the documentation, I don't see how to implement my own xc potential, could you write a snippet of code how to personalize the vxc let's say for $v_{\rm xc}=\int d{\bf r'} n({\bf r'})/|{\bf r-r'}$| ? (I'm very beginner with julia)

hartree.jl is here: https://github.com/JuliaMolSim/DFTK.jl/blob/master/src/terms/hartree.jl, it does exactly what you say here https://github.com/JuliaMolSim/DFTK.jl/blob/master/src/terms/hartree.jl#L45 and here https://github.com/JuliaMolSim/DFTK.jl/blob/master/src/terms/hartree.jl#L33. Note that this uses the convolution theorem and FFTs (because 1/|r-r'| is a function of r-r'), which is not feasible in your case. You need something like (in real space) pot = reshape(K * vec(total_density(ρ)), basis.fft_size) where K is a matrix of size prod(basis.fft_size) by itself.

You add it as an extra term, see the extra_terms keyword argument in the model_DFT constructor (in standard_models.jl) and eg this tutorial: https://docs.dftk.org/dev/examples/gross_pitaevskii/. Let us know how that goes!

Thanks a lot!


Revise issues workflow so that pending::feedback label updates to pending::support after any response (not just author)

Checklist

[X] I added a descriptive title
[X] I searched open requests and couldn't find a duplicate

What is the idea?
Currently, the workflow only updates the labels (from pending::feedback to pending::support) if the author responds. The proposal is to update the labels if anyone responds. Also update comment on line 34 to indicate that the support label is being added and not the feedback label.
Why is this needed?
People other than the original author may respond to add sufficient clarity to an issue. The provision of additional information should trigger us taking another look.
What should happen?
If an issue has a pending::feedback label and anyone adds an additional comment, the label should switch to pending::support, regardless of whether the person commenting is the original comment author.
Additional Context
No response

I'm planning to tackle the PR for this tomorrow.

Resolved by #719


Update comment to match PPTg name used in code

I guess PPTg is short for pedunculopontine tegmental nucleus.

Codecov Report
Base: 44.90% // Head: 44.90% // No change to project coverage :thumbsup:

Coverage data is based on head (254445d) compared to base (e66c851).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   44.90%   44.90%
=======================================
  Files          24       24
  Lines        5088     5088
=======================================
  Hits         2285     2285
  Misses       2643     2643
  Partials      160      160

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


scripts/fuzz-parser: work around race condition from running cargo build concurrently

Summary
Running this script over a larger range of seeds, I noticed an occasional race condition due to the fact that the script runs cargo run in multiple processes concurrently.
The script was very occasionally reporting bugs where none actually existed. The cargo run subprocess would fail to run the checked-out ruff branch due to the race condition, so would exit with a nonzero exit code. The script then incorrectly assumed that that meant that ruff itself had failed to parse the generated code.
This PR works around the race condition by double-checking that the original snippet actually does reproduce buggy behaviour if we get to a point where the original subprocess had a nonzero exit code but subsequent calls to pysource_minimize.minimize() then fail to reproduce the bug.
Test Plan
In a Python virtual environment, I ran uv pip install -r scripts/fuzz-parser/requirements.txt, and then ran py scripts/fuzz-parser/fuzz.py 0-10_000. (Warning: this may make your computer fans whirr quite loudly.)

Oh, I didn't realize it builds the release target. It doesn't need to be done in this PR or even now, but I think we should just take path of two ruff executables via the CLI arguments similar to how ruff-ecosystem does. I don't think the script should be responsible to build ruff.

Oh, right. Yeah, that's probably a better way of doing things! Well, I'll merge this now, anyway, and look into how ruff-ecosystem does it later.