Potential case-insensitive import collision

Due to GitHub handle change (to lowercase) for long term purpose, go get may fail fetching github.com/Unknwon/com.
Please consider take some time to update it to github.com/unknwon/com in the go.mod file.
I truly apology for the inconvenience and unintended troubles caused.

thanks.


Mention alumni GitHub team in governance docs

Updates our alumni section of the governance docs to mention the associated GitHub team.

We technically have strict rules about consensus for updating the governance doc, but I think this safely falls under a typo/clarification rather than a process change.
Extremely meta, but maybe we should make a separate PR that updates the process to explicitly allow clarifying edits like this to bypass the whole procedural change process?

Extremely meta, but maybe we should make a separate PR that updates the process to explicitly allow clarifying edits like this to bypass the whole procedural change process?

Yeah, that probably makes sense. Feels like we all agree here this isn’t a “process change“, just adding a missing item that was likely already implied.


Made 'Tensor.gathering(where:alongAxis:)' differentiable.

Tests pass so this should be ready to merge.


MM-25809 - Fixed rendering code blocks when starting with 4 spaces

Summary
Removed unnecessary trim before creating the post that was preventing displaying as code blocks when the text was preceded with 4 spaces.
Ticket Link
MM-25809
Device Information
This PR was tested on: iOS simulator.
Related PR
Issue originally introduced in: https://github.com/mattermost/mattermost-mobile/pull/4122

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/6694
https://circleci.com/gh/mattermost/mattermost-mobile/6693

Artifact links:
https://6694-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://6693-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa


Docker configuration is causing BIG performance issue

If Rendertron is started by npm start, the performance is awesome! It can render pretty much all the sites very fast.
If Rendertron is started as a docker container, it takes MUCH longer to do the rendering.
for example:
https://whispering-bayou-43373.herokuapp.com/list/mens_outerwear
docker container version of Rendertron takes 10+ secs
npm start version of Rendertron takes 4 secs
https://disneycruise.disney.go.com/
docker container version of Rendertron takes 8.6-10+ secs
npm start version of Rendertron takes 6-7 secs
Something needs to be done to the docker configuration.
Steps to reproduce

run rendertron locally using npm start
go to http://localhost:3000/
paste the follow line into the input box
https://whispering-bayou-43373.herokuapp.com/list/mens_outerwear
click the render and serialize with web component v1

build rendertron container docker build -t rendertron . --no-cache=true
run rendertron container   docker run -it -p 8080:8080 --cap-add SYS_ADMIN --name rendertron-container rendertron
paste the following line into the input box
https://whispering-bayou-43373.herokuapp.com/list/mens_outerwear
click the render and serialize with web component v1

Results
npm start will give the rendering result in about 5 secs
docker run will give almost a blank page because it could not finish the rendering in 10 secs
My guess
since the poor performance is due to the long rendering time, my guess is that some of the docker configuration is making headless chrome run slow.
Updates
last week, I got the testing result as what I stated above after many many tests.
but this week, everything changed as if this is no longer the world I have lived in last week.

docker version of rendertron can render pretty much as fast as npm start version for AngularJS apps (GOOD!)

npm start version of rendertron is acting like the docker version of rendertron, and can no longer render several of the apps involve Polymer elements (BAD!)

https://whispering-bayou-43373.herokuapp.com/list/ladies_outerwear

https://mighty-dawn-10467.herokuapp.com/heroes

https://shop.polymer-project.org/list/ladies_outerwear

@samuelli Are we using the docker instance for rendering wc.org?

@hekod777 are you running docker on Mac? because that's running inside a VM (xhyve) and it might cause some slow downs.

hmmm....
It's really really weird.
last week, I got the testing result as what I stated in the first post after many many tests.
but this week, everything changed as if this is no longer the world I have lived in the last week.

docker version of rendertron can render pretty much as fast as npm start version for AngularJS apps (GOOD!)

npm start version of rendertron is acting like the docker version of rendertron, and can no longer render several of my testing polymer2 apps like

The Docker Container is clearly the biggest block on the road to production.
This is the result after trying out docker and non-docker version of rendertron

non-docker version (npm start)

Rendertron can easily handle 8 concurrent users by using only 35% of the CPU
about 4.5% CPU usage per user.

docker version

Rendertron will crash if the concurrent users are 4 or more when rendering some of our AngularJS pages.
With 3 concurrent users, Rendertron took about 20% of the CPU usage.
almost 7% CPU usage per user.
The Rendertron docker container clearly can have some improvements.

While non-dockerized version can hold 9 concurrent users without any problem. Dockerized rendertron can only hold 4 concurrent users.
When there are only 4 concurrent users, things worked well. once it reached 5 concurrent users all these errors almost pop up instantly.
Uncaught exception
Error: not opened
    at WebSocket.send (/app/node_modules/ws/lib/WebSocket.js:355:18)
    at Chrome.enqueueCommand (/app/node_modules/chrome-remote-interface/lib/chrome.js:124:16)
    at /app/node_modules/chrome-remote-interface/lib/chrome.js:86:28
    at new Promise (<anonymous>)
    at Chrome.send (/app/node_modules/chrome-remote-interface/lib/chrome.js:85:16)
    at Object.handler [as evaluate] (/app/node_modules/chrome-remote-interface/lib/api.js:32:23)
    at pageReadyFn (/app/src/renderer.js:170:36)
    at Timeout.setTimeout (/app/src/renderer.js:188:9)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
10 second time budget limit reached.
          Attempted rendering: https://disneycruise.disney.go.com/cruises-destinations/overview/panama-canal/
          Page load event fired: false
          Outstanding network requests: 1
Uncaught exception
Error: not opened
    at WebSocket.send (/app/node_modules/ws/lib/WebSocket.js:355:18)
    at Chrome.enqueueCommand (/app/node_modules/chrome-remote-interface/lib/chrome.js:124:16)
    at /app/node_modules/chrome-remote-interface/lib/chrome.js:86:28
    at new Promise (<anonymous>)
    at Chrome.send (/app/node_modules/chrome-remote-interface/lib/chrome.js:85:16)
    at Object.handler [as evaluate] (/app/node_modules/chrome-remote-interface/lib/api.js:32:23)
    at pageReadyFn (/app/src/renderer.js:170:36)
    at Timeout.setTimeout (/app/src/renderer.js:188:9)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
10 second time budget limit reached.
          Attempted rendering: https://disneycruise.disney.go.com/cruises-destinations/overview/panama-canal/
          Page load event fired: false
          Outstanding network requests: 14

Uncaught exception
Error: not opened
    at WebSocket.send (/app/node_modules/ws/lib/WebSocket.js:355:18)
    at Chrome.enqueueCommand (/app/node_modules/chrome-remote-interface/lib/chrome.js:124:16)
    at /app/node_modules/chrome-remote-interface/lib/chrome.js:86:28
    at new Promise (<anonymous>)
    at Chrome.send (/app/node_modules/chrome-remote-interface/lib/chrome.js:85:16)
    at Object.handler [as evaluate] (/app/node_modules/chrome-remote-interface/lib/api.js:32:23)
    at pageReadyFn (/app/src/renderer.js:170:36)
    at Timeout.setTimeout (/app/src/renderer.js:188:9)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)

10 second time budget limit reached.
          Attempted rendering: https://disneycruise.disney.go.com/ports/castaway-cay/
          Page load event fired: false
          Outstanding network requests: 2

Uncaught exception
Error: not opened
    at WebSocket.send (/app/node_modules/ws/lib/WebSocket.js:355:18)
    at Chrome.enqueueCommand (/app/node_modules/chrome-remote-interface/lib/chrome.js:124:16)
    at /app/node_modules/chrome-remote-interface/lib/chrome.js:86:28
    at new Promise (<anonymous>)
    at Chrome.send (/app/node_modules/chrome-remote-interface/lib/chrome.js:85:16)
    at Object.handler [as evaluate] (/app/node_modules/chrome-remote-interface/lib/api.js:32:23)
    at pageReadyFn (/app/src/renderer.js:170:36)
    at Timeout.setTimeout (/app/src/renderer.js:188:9)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)

Uncaught exception
{ Error: connect ECONNREFUSED <IP_ADDRESS>:46607
    at Object._errnoException (util.js:1031:13)
    at _exceptionWithHostPort (util.js:1052:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1195:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 46607 }

Uncaught exception
{ Error: connect ECONNREFUSED <IP_ADDRESS>:46607
    at Object._errnoException (util.js:1031:13)
    at _exceptionWithHostPort (util.js:1052:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1195:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 46607 }
Detected 6 errors, shutting instance down

Uncaught exception
{ Error: connect ECONNREFUSED <IP_ADDRESS>:46607
    at Object._errnoException (util.js:1031:13)
    at _exceptionWithHostPort (util.js:1052:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1195:14)
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 46607 }

I have checked CPU / Memory / Network, I do not think any of those are causing the issue.
There are two types of errors:

not opened error

according to my research, this error is caused by rendertron trying to closed a tab in chrome that does not exist (or maybe already closed). This can be one of the areas to work on to improve the stability of rendertron. I have seen this error occasionally in non-dockerized version of rendertron.

ECONNREFUSED error

I am not quite sure about this error. I do not see this error in non-dockerized version of rendertron. It might not directly relate to the not opened error.

Maybe both of these errors were caused by chrome being crashed by the 5th concurrent user in the docker container? If so, maybe we can try improve the stability of chrome in the docker container to improve the performance of rendertron.

@hekod777 Recently, a slightly relevant bug was fixed in 64.0.3281.0 - see https://bugs.chromium.org/p/chromium/issues/detail?id=736452
Would you be willing to retest with the new version?

@paambaati Thank you for the info.
After I adding --shm-size 512m to run the docker container (default is 64m, I just made it larger), the docker container works fine now (tested in the latest version of rendertron). And with Sam's fix, the 'not opened' error is greatly reduced. I have to say the stability of rendertron is better than never before.


Use Rivian Provided Overhead Images

Changes required:
image: >-
<EMAIL_ADDRESS>card_mod:
  style:
    hui-image$: |
      img {
        max-width: 44%;
        margin: auto;
        padding-right: 1.2%
      }

and for the images for the Truck
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>

s/light/dark give you a different shading (shade vs sun)

All overhead images have been downloaded and uploaded to the repo, card changes would still need to take place to align with the new base image layer


Added E-commerce Anime site

Issue No: #93

Can you check the README.MD again I think you haven't made the table properly.

Ok I will do it manually, merging this one.

thanks keshav to let me contribute on this issue. Its an very unique idea to have other projects together in one repo.

Issue No: #93

Hey omk-coder i want to make some changes in your project


switch to pivnet refresh token

Currently network.pivotal.io no legacy api token any more
Made some change to support the refresh token, which won't affect user experience

Thanks, @datianshi! Would you mind splitting the vendor changes into a separate commit, please? I'll take and get this merged quickly then.

@evandbrown  done with splitting. Thanks

sorry reopen it..... fat finger...


Prepare docs for github pages deployment

Summary by CodeRabbit

New Features

Added comprehensive documentation for the Monomer project, including installation, local development, and deployment instructions.
Introduced a tutorial for creating applications using Monomer.
Added a new feature display section on the homepage.

Configuration

Introduced .gitignore, .nvmrc, and .yarnrc.yml files for improved project management.
Added a custom domain configuration with a CNAME file.

Styling

Implemented new CSS styles for responsive layouts and dark mode support.

Documentation Enhancements

Added structured documentation files for better navigation and learning resources.

It looks like both the doc and docs directories are still in your branch and the line count (+29,442 −0) seems like it's a copied directory instead of a rename. Could you double check your local branch to ensure that the doc directory deletion was pushed up?

It looks like both the doc and docs directories are still in your branch and the line count (+29,442 −0) seems like it's a copied directory instead of a rename. Could you double check your local branch to ensure that the doc directory deletion was pushed up?

🤦♂ You're right. Should be fixed now.


UniqueConstraint not enforced in CompartmentalizedComponent

Hi again,
I came across an issue while uploading several times my model, at which point I discovered that the UniqueConstraint of the rows in the table CompartmentalizedComponent are not enforced, despite its declaration:
class CompartmentalizedComponent(Base):
    __tablename__='compartmentalized_component'

    id = Column(Integer, Sequence('wids'), primary_key=True)
    component_id = Column(Integer, ForeignKey('component.id'), nullable=False)
    compartment_id = Column(Integer, ForeignKey('compartment.id'), nullable=False)
    UniqueConstraint('compartment_id', 'component_id')

And I also discovered that the upload method for compartmentalized components in model_loading.py:
    def loadCompartmentalizedComponent(self, modellist, session):
        for model in modellist:
            for metabolite in model.metabolites:
                identifier = session.query(Compartment).filter(Compartment.name == metabolite.id[-1:len(metabolite.id)]).first()
                m = session.query(Metabolite).filter(Metabolite.name == metabolite.id.split("_")[0]).first()
                #m = session.query(Metabolite).filter(Metabolite.kegg_id == metabolite.notes.get("KEGGID")[0]).first()
                object = Compartmentalized_Component(component_id = m.id, compartment_id = identifier.id)
                session.add(object)

does not check for prior existence of the said compartmentalized component, unlike how it's done with the metabolites. What happens next in loadModelCompartmentalizedComponent when calling
compartmentalized_component_query = session.query(Compartmentalized_Component).filter(Compartmentalized_Component.component_id == componentquery.id).filter(Compartmentalized_Component.compartment_id == compartmentquery.id).first()

is that the component is linked to one among many identical compartmentalized components (first() call). This gets worse when you run a query like
compartmentalized_components = make_dict(session.query(CompartmentalizedComponent).\
    join(ModelCompartmentalizedComponent, CompartmentalizedComponent.id == \
        ModelCompartmentalizedComponent.compartmentalized_component_id).\
    filter(ModelCompartmentalizedComponent.model_id == modelObject.id))

to get the list of compartmentalized components used in your model, and try to fetch from it an id equal to a ReactionMatrix.compartmentalized_component_id. It does not work because this last one points to another sibling of this compartmentalized component which likely not the one in your model.
I don't know if this was very clear, but to sum up there are two points:

UniqueConstraint does not seem to be enforced (I have no idea as to why)
loadCompartmentalizedComponents does not check if the compartmentalized component already exists in the database.

A simple fix for this one would be:
def loadCompartmentalizedComponent(self, modellist, session):
	for model in modellist:
		for metabolite in model.metabolites:
			metaboliteObject = session.query(Metabolite).\
				filter(Metabolite.name == metabolite.id[:-2]).first()
			compartmentObject = session.query(Compartment).\
				filter(Compartment.symbol == metabolite.id[-1]).first()
			compartmentalized_component_found = True if session.query(CompartmentalizedComponent).\
					filter(CompartmentalizedComponent.component_id == component_query.id).\
					filter(CompartmentalizedComponent.compartment_id == compartment_query.id)\

			if not session.query(CompartmentalizedComponent).\
						filter(CompartmentalizedComponent.component_id == component_query.id).\
						filter(CompartmentalizedComponent.compartment_id == compartment_query.id):
				object = CompartmentalizedComponent(
					component_id = metaboliteObject.id,
					compartment_id = compartmentObject.id)
				session.add(object)

I attached a printscreen as an illustration.

@jslu9 Is this still happening?


[AIRFLOW-1262] Allow configuration of email alert subject and body

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1262

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Adds email.subject and email.html_content config values, named to mirror parameters to EmailOperator.
Note that a quirk of configparser requires Jinja2 delimiters to be doubled.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

tests.models:TaskInstanceTest.test_failure_email

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@868bfe4). Click here to learn what that means.
The diff coverage is 92.3%.

@@            Coverage Diff            @@
##             master    #2338   +/-   ##
=========================================
  Coverage          ?   69.49%
=========================================
  Files             ?      144
  Lines             ?    11046
  Branches          ?        0
=========================================
  Hits              ?     7676
  Misses            ?     3370
  Partials          ?        0

Impacted Files
Coverage Δ

airflow/models.py
87.46% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868bfe4...09f3e45. Read the comment docs.

@alekstorm can you rebase onto master?

Let me run the tests one more time: https://travis-ci.org/Fokko/incubator-airflow/builds/385586411

@alekstorm Can you rebase with master and resolve conflicts?

Okay, rebased and got the tests to pass (they appear to be flaky). This is now the fourth time I've written this code - can you please get it merged? My team doesn't even need this feature anymore; this is spurred by a request on the mailing list.

Awesome, thanks.

Thanks @alekstorm . Appreciate that.

Thanks @alekstorm!

thanks @alekstorm


Terraspace container performance

I'm not sure if this is a local issue or not but I wanted to raise it for further testing. We have noticed a fairly large performance impact when running Terraspace in docker, this is true both in our own images and the terraspace-dockerfiles images, this impact is especially noticeable on EC2. Here is a comparison of different execution times across local machines, EC2, docker, and host.

EC2 Docker
EC2
Local Docker
Local

real 5m33.403s
real 0m44.799s
real 1m40.842s
real 0m39.626s

user 0m11.150s
user 0m26.531s
user 0m24.736s
user 0m10.913s

sys 0m1.437s
sys 0m3.276s
sys 0m13.846s
sys 0m4.580

This doesn't appear to be a resource issue either, as there is minimal usage during execution:
CONTAINER ID   NAME            CPU %     MEM USAGE / LIMIT    MEM %     NET I/O          BLOCK I/O     PIDS
9b05765250b8   quirky_spence   0.54%     1.21GiB / 7.583GiB   15.95%    300MB / 3.43MB   0B / 1.08MB   3

From execution observation, it appears that the majority of the time is spent on the build step. Happy to provide further information as required.

A guess in the dark. Wondering if it's filesystem performance within Docker.
The terraspace build stage reads and writes files.
When you get a chance, here's a special custom logger that will prepend timestamp to stdout.
config/app.rb
class CustomLogger < Terraspace::Logger
  def format_message(severity, datetime, progname, msg)
    out = (@formatter || @default_formatter).call(severity, datetime, progname, msg)
    "#{out}\n"
  end
end

Terraspace.configure do |config|config.logger.level = :debug
  config.logger = CustomLogger.new($stdout)
  config.logger.level = :debug
  config.test_framework = "rspec"
end

You should see something like this:
$ terraspace build
[2021-12-30T19:45:52 #5181 ]: Building one stack to build all stacks
[2021-12-30T19:45:52 #5181 ]: Building .terraspace-cache/dev/stacks/demo
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/backend.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/provider.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/modules/example/main.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/modules/example/outputs.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/modules/example/variables.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/backend.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/provider.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/main.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/outputs.tf
[2021-12-30T19:45:52 #5181 ]: Created .terraspace-cache/dev/stacks/demo/variables.tf
[2021-12-30T19:45:52 #5181 ]: Built in .terraspace-cache/dev/stacks/demo
$

That may provide more diagnostic info.

Closing due to lack of updates


Don't Require Login for Specific Milestones

Description
From Discord:
Is it possible to configure Gitea so that Milestone pages don't require login? (for example, https://git.semicolin.games/semicolin/sneak/milestone/2 is a public repository, but you need to be logged in to see the milestone page.) It seems that by default, a not-logged-in user can see the /milestones page, and even which Issues are in which milestones, but not the page corresponding to a specific milestone.

Extend pages visible to non-logged-in users into specific milestone pages.

+1, this seems like a sensible change; I'll look at fixing this if no one else is in the process of doing so.

This is indeed sensible, however I think we should do it like github where the list of issues/PRs assigned to a milestone can be seen in the standard issues/PRs list page (ex. https://try.gitea.io/Etzelia/Test1/pulls?q=&type=all&state=open&labels=&milestone=893&assignee=0 )

This is indeed sensible, however I think we should do it like github where the list of issues/PRs assigned to a milestone can be seen in the standard issues/PRs list page (ex. https://try.gitea.io/Etzelia/Test1/pulls?q=&type=all&state=open&labels=&milestone=893&assignee=0 )

I'm afraid I'm being a bit dense here, I don't quite follow -- this example seems to already match github behavior, both allowing one to filter standard issues/PRs by milestone and displaying them in the subheading/metadata(?) area just below the title.

@kevans91 woops. I am the dense one. Please ignore my comment above.

@techknowlogick OK, phew; :-)


added feature terms-and-conditions-page-156

I have added the Terms and conditions page , also the required changes in hyperlinks have been made in footer sections of all the webpages.
ISSUE #156

@00Himnshi Please resolve the merge conflicts.

@00Himnshi Please resolve the merge conflicts.

i have resolved the merge conflicts please see Pull Request -Added The Terms and conditions page #183


Upgrade github.com/miekg/dns

Latest version of github.com/miekg/dns does not have the ErrTruncated anymore, see: https://github.com/miekg/dns/pull/815
The commit message says:
Any program using ErrTruncated will fail to compile when they update to
this version: this is by design: you're doing it wrong. For checking if
a message was truncated you should checked the msg.Truncated boolean;
assuming the unpack didn't fail.

Thanos use a recent version of github.com/miekg/dns and it is not an issue now but it might become (for Thanos) if https://github.com/prometheus/prometheus/pull/5009 makes it to master as the dependency tree of prometheus within thanos will become bigger as Thanos imports github.com/prometheus/rules (indirectly I guess) which will import github.com/prometheus/config which itself imports a lot of libs needed for discovery like github.com/miekg/dns.
cc @bwplotka

Closed by #5020


[test] Wire libMockPlugin and swift-plugin-server as test dependencies

The build script will build these pieces because they are wired to the tools and compiler components, but when using ninja or cmake directly to clean the build, and then later check-swift-validation and other test targets, it would not rebuild those targets, failing many of the macros/plugins tests.

@swift-ci please smoke test


Adding error codes to daemon/graphdriver package

Signed-off-by: Srini Brahmaroutu<EMAIL_ADDRESS>

@brahmaroutu @duglin Can we close this?


improve discoverability of merge editor features

When in a merge editor, it's unclear to a SR user how to take action according to @jooyoungseo. We should include commands that can be taken in the editor help dialog and consider adding a keybinding to resolve the conflict etc. so users don't have to shift+tab to the toolbar.
cc @hediet

What merge editor is this about? The simple one that shows >>>> decorations inline, or the merge editor with a blue button?
I could not figure this out from the screenshot.
Do we already have the required commands - is the feedback that there should be a default keybinding for them?

Yes, we already have the required commands. Default keybindings would help as would communicating to the user about which editor they've landed in

@jooyoungseo, I thought more about this. Is a user likely to open the editor help dialog to find these commands/keybindings? I worry they will not.

@meganrogge Isn't this the same issue and same question that can be applied to other contexts, such as copilot Chat? I think Alt+F1 needs to be their go-to reference until they get used to any new UIs.

Are you suggesting a separate verbosity/announcement to give a hint?

Maybe we should? I don't want it to be noisy though.


006 - listLoyaltyTierRewards, Reward Assignments methods

'@voucherify/sdk': minor
Added support for new endpoints and adding missing types in Rewards API.
Added support for new endpoints:

/loyalties/{campaignId}/rewards/{assignmentId}, (getRewardAssignment)
/loyalties/{campaignId}/tiers/{tierId}/rewards, (listLoyaltyTierRewards)
/rewards/{rewardId}/assignments/{assignmentId} (example available in readme.md)

New exported types/interfaces in Loyalties.ts:
Domain types:

LoyaltyTierRewardItem,
LoyaltyTierRewardItemBase,
LoyaltyTierRewardItemParameters,
LoyaltyTierRewardItemCampaignParameters,
LoyaltyTierRewardItemCoinParameters,
LoyaltyTierRewardItemMaterialParameters,
LoyaltyTierRewardItemCampaignDiscountCoupons,
LoyaltyTierRewardItemCampaignGiftVouchersAndLoyaltyProgram

0-level types:

LoyaltiesGetRewardAssignmentResponseBody,
LoyaltiesListLoyaltyTierRewardsResponseBody

New exported types/interfaces in Rewards.ts:
Domain types:

RewardAssignment (old RewardsAssignmentObject),
RewardsAssignmentCampaignOrMaterialReward,
RewardsAssignmentCoinReward

0-level types:

RewardsListAssignmentsRequestQuery (old RewardsListAssignmentsParams),
RewardsListAssignmentsResponseBody (old RewardsListAssignmentsResponse),
RewardsCreateAssignmentRequestBody (old RewardsCreateAssignment),
RewardsCreateAssignmentCoinRewardRequestBody,
RewardsCreateAssignmentCampaignOrMaterialRewardRequestBody,
RewardsCreateAssignmentResponseBody (old RewardsCreateAssignmentResponse),
RewardsUpdateAssignmentRequestBody (old RewardsUpdateAssignment),
RewardsUpdateAssignmentResponseBody (old RewardsUpdateAssignmentResponse)
RewardsGetAssignmentResponseBody (brand new)

released as a part of other RC


items in the cart are subtracted from available stock

I'm fairly new to ecommerce systems in general but this one seems odd to me.
When a store has 100 items in stock, and a user place 100 items in a cart.
Other users see the items are no longer available.

This should not be the case. In fact there should be no direct modification of stock levels until an order is placed. What we do however is we prevent any particular user from placing more than the current stock's worth in their cart.

oh.. yes it was my mistake. sorry for the false call.


oculante: GLib-GIO-ERROR **: 18:06:07.730: No GSettings schemas are installed on the system

Describe the bug
When i click the folder icon in the top left, no File Picker is displayed and oculante crashes about half a second later with
(oculante:70227): GLib-GIO-ERROR **: 18:06:07.730: No GSettings schemas are installed on the system
fish: Job 1, 'oculante IMG_20221117_133830.jpg' terminated by signal SIGTRAP (Trace or breakpoint trap)

I am on NixOS unstable and running hyprland with a minimal setup.
I guess that i have to enable some NixOS option but i don't know which one and i think that the package should work out of the box.
Notify maintainers
@dit7ya @figsoda
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.7, NixOS, 23.11 (Tapir), 23.11pre537656.7c9cc5a6e5d3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - channels(root): `"nixos"`
 - channels(sperber): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

what is your "minimal setup"? what's in the config?

I don't know what settings are relevant as an answer to your question. I'm using gtk programs etc. without issues and wanted to convey that i don't have KDE or Gnome desktop installed so there might be something missing that is already installed by default on many systems.


Update ethical-framework.mdx

UI/UX

Thanks so much, I really love the restructuring and puhsing the checklist to the top of the post. However, some of the text blocks unfortunately got lost in the reshuffling. Would you be able to resubmit this with the structure update but without losing content?


HADOOP-18496: remove use of okhttp in runtime code

Description of PR
Use Apache HTTPClient instead of OkHTTP to reduce the number of hadoop dependencies.
https://issues.apache.org/jira/browse/HADOOP-18496
How was this patch tested?
Local build and CI build.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 38s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 11s

trunk passed

+1 :green_heart:
compile
18m 48s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 55s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 36s

trunk passed

+1 :green_heart:
mvnsite
20m 47s

trunk passed

+1 :green_heart:
javadoc
8m 55s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 17s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 19s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
68m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 41s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 57s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvninstall
0m 16s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

-1 :x:
mvninstall
0m 17s
/patch-mvninstall-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
mvninstall
1m 17s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
17m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 57s

the patch passed

+1 :green_heart:
compile
16m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
5m 56s
/results-checkstyle-root.txt
root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
mvnsite
15m 50s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 52s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 31s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 17s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 29s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
spotbugs
0m 21s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

+0 :ok:
spotbugs
0m 23s

hadoop-client-modules/hadoop-client has no data from spotbugs

-1 :x:
spotbugs
0m 23s
/patch-spotbugs-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
spotbugs
31m 58s
/new-spotbugs-root.html
root generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
shadedclient
35m 42s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
795m 23s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 32s

The patch does not generate ASF License warnings.

1128m 15s

Reason
Tests

SpotBugs
module:root

Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.web.oauth2.ConfRefreshTokenBasedAccessTokenProvider.refresh()  At ConfRefreshTokenBasedAccessTokenProvider.java:is not thrown in org.apache.hadoop.hdfs.web.oauth2.ConfRefreshTokenBasedAccessTokenProvider.refresh()  At ConfRefreshTokenBasedAccessTokenProvider.java:[line 141]

Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.web.oauth2.CredentialBasedAccessTokenProvider.refresh()  At CredentialBasedAccessTokenProvider.java:is not thrown in org.apache.hadoop.hdfs.web.oauth2.CredentialBasedAccessTokenProvider.refresh()  At CredentialBasedAccessTokenProvider.java:[line 135]

Failed junit tests
hadoop.mapreduce.v2.TestMRJobs

hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobsWithProfiler

hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux 0bf8872557b2 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fcfad8d600e0d0357c69b2e919634821a0df921f

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/1/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 42s

trunk passed

+1 :green_heart:
compile
18m 26s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 41s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 40s

trunk passed

+1 :green_heart:
mvnsite
20m 13s

trunk passed

+1 :green_heart:
javadoc
8m 48s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 17s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 19s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
68m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 39s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 54s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvninstall
0m 17s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

-1 :x:
mvninstall
0m 16s
/patch-mvninstall-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
mvninstall
1m 12s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
17m 35s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 35s

the patch passed

+1 :green_heart:
compile
16m 38s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
5m 49s
/results-checkstyle-root.txt
root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
mvnsite
15m  8s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 44s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 24s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 17s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 29s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
spotbugs
0m 22s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

+0 :ok:
spotbugs
0m 22s

hadoop-client-modules/hadoop-client has no data from spotbugs

-1 :x:
spotbugs
0m 23s
/patch-spotbugs-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
spotbugs
31m 39s
/new-spotbugs-root.html
root generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
shadedclient
35m 18s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
811m 59s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 32s

The patch does not generate ASF License warnings.

1142m 11s

Reason
Tests

SpotBugs
module:root

Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.web.oauth2.ConfRefreshTokenBasedAccessTokenProvider.refresh()  At ConfRefreshTokenBasedAccessTokenProvider.java:is not thrown in org.apache.hadoop.hdfs.web.oauth2.ConfRefreshTokenBasedAccessTokenProvider.refresh()  At ConfRefreshTokenBasedAccessTokenProvider.java:[line 141]

Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.web.oauth2.CredentialBasedAccessTokenProvider.refresh()  At CredentialBasedAccessTokenProvider.java:is not thrown in org.apache.hadoop.hdfs.web.oauth2.CredentialBasedAccessTokenProvider.refresh()  At CredentialBasedAccessTokenProvider.java:[line 135]

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.mapreduce.v2.TestMRJobsWithProfiler

hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobs

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux b589750519e3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fcfad8d600e0d0357c69b2e919634821a0df921f

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/2/testReport/

Max. process+thread count
3144 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@rohit-kb what do you think of this? would it suit?
Thanks for the heads-up @steveloughran. I think it's a welcome change w.r.t to okhttp and related kotlin dependencies removal. Just need to check if it's causing any issues in any other components downstream. Thanks @pjfanning for looking into this.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 21s

trunk passed

+1 :green_heart:
compile
18m 38s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m  1s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 39s

trunk passed

+1 :green_heart:
mvnsite
20m 12s

trunk passed

+1 :green_heart:
javadoc
8m 56s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 17s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 19s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
69m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 42s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 57s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvninstall
0m 16s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

-1 :x:
mvninstall
0m 17s
/patch-mvninstall-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
mvninstall
1m 16s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
17m 52s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 52s

the patch passed

+1 :green_heart:
compile
16m 56s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 32s
/results-checkstyle-root.txt
root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
mvnsite
15m 24s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 49s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 32s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 18s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 28s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
spotbugs
0m 21s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

+0 :ok:
spotbugs
0m 19s

hadoop-client-modules/hadoop-client has no data from spotbugs

-1 :x:
spotbugs
0m 21s
/patch-spotbugs-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
shadedclient
35m 41s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
786m 10s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 32s

The patch does not generate ASF License warnings.

1116m  8s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.TestMRJobs

hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobsWithProfiler

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux 461a5274e895 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 63e8038a6710243b1915ff3c35c136a7e84b3a44

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/3/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
35m 46s

trunk passed

+1 :green_heart:
compile
17m 34s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
17m  4s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
5m  0s

trunk passed

+1 :green_heart:
mvnsite
20m 33s

trunk passed

+1 :green_heart:
javadoc
8m 47s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 28s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 23s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 25s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
62m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 48s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 58s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
mvninstall
0m 26s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvninstall
0m 20s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

-1 :x:
mvninstall
0m 20s
/patch-mvninstall-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
mvninstall
1m 19s
/patch-mvninstall-root.txt
root in the patch failed.

+1 :green_heart:
compile
16m 34s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 34s

the patch passed

+1 :green_heart:
compile
16m 16s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 19s

the patch passed

+1 :green_heart:
mvnsite
15m  3s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 42s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 23s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 33s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
spotbugs
0m 26s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-httpfs in the patch failed.

+0 :ok:
spotbugs
0m 24s

hadoop-client-modules/hadoop-client has no data from spotbugs

-1 :x:
spotbugs
0m 26s
/patch-spotbugs-hadoop-cloud-storage-project_hadoop-huaweicloud.txt
hadoop-huaweicloud in the patch failed.

-1 :x:
shadedclient
33m 31s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
817m 23s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
2m  7s

The patch does not generate ASF License warnings.

1138m 44s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobs

hadoop.mapreduce.v2.TestMRJobsWithProfiler

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.balancer.TestBalancerService

hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux 9cc84cfdf9b3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 676013a46de5f919e809cd28051bef4203933f7d

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/4/testReport/

Max. process+thread count
3342 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 19s

Maven dependency ordering for branch

-1 :x:
mvninstall
39m 33s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
22m 32s
/branch-compile-root-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
root in trunk failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
compile
23m 51s
/branch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in trunk failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
checkstyle
4m 28s

trunk passed

-1 :x:
mvnsite
16m 23s
/branch-mvnsite-root.txt
root in trunk failed.

+1 :green_heart:
javadoc
8m 51s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 24s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 19s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

-1 :x:
spotbugs
30m 48s
/branch-spotbugs-root.txt
root in trunk failed.

+1 :green_heart:
shadedclient
37m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 40s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
37m 38s

the patch passed

+1 :green_heart:
compile
18m 33s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
18m 33s

the patch passed

+1 :green_heart:
compile
16m 51s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 34s

the patch passed

+1 :green_heart:
mvnsite
19m 58s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 50s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 36s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 18s

hadoop-project has no data from spotbugs

+0 :ok:
spotbugs
0m 19s

hadoop-client-modules/hadoop-client has no data from spotbugs

+1 :green_heart:
shadedclient
68m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
782m 45s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 33s

The patch does not generate ASF License warnings.

1196m 51s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.TestMRJobs

hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobsWithProfiler

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux ce63403384d3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e70ad4851a152aa81997063ecd36044e2198e647

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/5/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
37m  2s

trunk passed

+1 :green_heart:
compile
18m 39s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 52s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 40s

trunk passed

+1 :green_heart:
mvnsite
19m 53s

trunk passed

+1 :green_heart:
javadoc
9m  2s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 19s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 19s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
69m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 39s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
36m 56s

the patch passed

+1 :green_heart:
compile
17m 49s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 49s

the patch passed

+1 :green_heart:
compile
16m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 31s

the patch passed

+1 :green_heart:
mvnsite
15m 24s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 52s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
7m 35s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 17s

hadoop-project has no data from spotbugs

+0 :ok:
spotbugs
0m 19s

hadoop-client-modules/hadoop-client has no data from spotbugs

+1 :green_heart:
shadedclient
69m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
785m  0s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 35s

The patch does not generate ASF License warnings.

1185m 51s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.TestMRJobs

hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobsWithProfiler

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux bae892dc4de1 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0bb3e35805f6d8810b1d133c6ad3eb9eea8a7deb

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/6/testReport/

Max. process+thread count
2642 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 26s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 16s

trunk passed

+1 :green_heart:
compile
17m 13s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 25s

trunk passed

+1 :green_heart:
mvnsite
20m 24s

trunk passed

+1 :green_heart:
javadoc
8m 55s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 23s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+0 :ok:
spotbugs
0m 25s

branch/hadoop-client-modules/hadoop-client no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
61m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 43s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
33m 13s

the patch passed

+1 :green_heart:
compile
16m 40s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 40s

the patch passed

+1 :green_heart:
compile
16m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 19s

the patch passed

+1 :green_heart:
mvnsite
14m 38s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 41s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 31s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+0 :ok:
spotbugs
0m 23s

hadoop-project has no data from spotbugs

+0 :ok:
spotbugs
0m 25s

hadoop-client-modules/hadoop-client has no data from spotbugs

+1 :green_heart:
shadedclient
62m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
802m 48s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
2m  8s

The patch does not generate ASF License warnings.

1180m  9s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.app.job.impl.TestMapReduceChildJVM

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs

uname
Linux 7428bb19273d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eb3e1436832832356468b53b5c9985984a6fd6cf

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/7/testReport/

Max. process+thread count
3369 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-client-modules/hadoop-client hadoop-cloud-storage-project/hadoop-huaweicloud . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6057/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

test failures are unrelated; the timeline one has been seen before YARN-11546

+1 merged to trunk. presumably it needs a backport?

I created https://github.com/apache/hadoop/pull/6101 for backporting this.


bug: prepareWriteContract chainId parameter is ignored.

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.4.4
Current Behavior
Originally opened on viem's side (Original Issue) but it seems that the problem actually lies with the wagmi implementation.
I'm using a prepareWriteContract followed by a writeContract call.
The prepareWriteContract documentation allows passing in a chainId to bind the contract call - prepareWriteContract docs
However the underlying call to writeContract ignores the chainId on the prepared request (code link)
 if (config.mode === 'prepared') {
    request = config.request
  } else {
    const { chainId: _, mode: __, ...args } = config
    const res = await prepareWriteContract(args as PrepareWriteContractConfig)
    request = res.request as unknown as WriteContractParameters<
      TAbi,
      TFunctionName,
      Chain,
      Account
    >
  }

  const hash = await walletClient.writeContract({
    ...request,
    chain: config.chainId ? { id: config.chainId } : null,
  } as WriteContractParameters<TAbi, TFunctionName, Chain, Account>)

Since the chainId will be on the config.request.chainId the writeWriteContract call will ignore it and pass a null chain down to viem.
Using writeContract directly - does not have this issue.
At the moment this issue can be bypassed by doing the following:
        const config = await prepareWriteContract({
          address,
          account,
          abi: ERC20ABi,
          functionName: "someFunc",
          value,
        });
        const { hash } = await writeContract({ ...config, chainId: chainId }); // Put the chainId on the writeContract instead of the request

But this is counterintuitive and not obvious at all.
Expected Behavior
prepareWriteContract should check the chainId pass it down

 if (config.mode === 'prepared') {
    request = config.request
  } else {
    const { chainId: _, mode: __, ...args } = config
    const res = await prepareWriteContract(args as PrepareWriteContractConfig)
    request = res.request as unknown as WriteContractParameters<
      TAbi,
      TFunctionName,
      Chain,
      Account
    >
  }
  const chainId = config.mode === 'prepared' ? config.request.chainId : config.chainId;
  const hash = await walletClient.writeContract({
    ...request,
    chain: chainId? { id: chainId } : null,
  } as WriteContractParameters<TAbi, TFunctionName, Chain, Account>)

Steps To Reproduce
Read the wagmi code for prepareWriteContract and writeContract
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Thanks for reporting. I can't seem to reproduce this. How are you consuming prepareWriteContract and writeContract?
Something like the following should pass through chain to viem correctly:
const { request } = await prepareWriteContract({
  abi,
  address: '0x...',
  functionName: 'mint',
  chainId: mainnet.id,
})
const { hash } = await writeContract(request)

Can you please provide a minimal reproducible example via https://new.wagmi.sh or a separate repo? It will save us a lot of time reproducing your config & environment, and trying to reproduce your issue. See Why reproductions are required.
Will reopen when a reproduction is provided.

The test is looking at the request.chainId. Which in turn is ignored by this line.
I'll see if I can setup a repro.

It shouldn't be – request is passed as the first parameter to writeContract (which is config).

If the config is prepared - then it would be under config.request - which you set on the request payload.
But you never check the config.request.chainid on the chain param line.
Hence the call to writeContract ends up having a chainId param and not a chain param.
Will try to setup a repro if you insist.

Can you please provide usage?
Correct usage is like the below:
const { request } = await prepareWriteContract({
  abi,
  address: '0x...',
  functionName: 'mint',
  chainId: mainnet.id,
})
const { hash } = await writeContract(request)

That's the exact usage in my code.

That's the usage I am using, and I cannot seem to reproduce it. So, a minimal reproducible example will help a lot. 😄


Remove HTMLElement.document property from lib.d.ts

https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L211
The property document on HTMLElement interface is not defined in current browsers and the spec.

Fixed in #2739


retrieve minimum location and plot results from the Optimizer class

Hi guys,
apologies for this basic question.
minimizing a function using gp_minimize() returns an object that contains the minimum location, value, etc. However, to design an interactive experiment I like the ask() and tell() approach of the Optimizer class. what is the best way to retrieve the minimum when performing the optimization this way (as in your ask and tell notebook)?
Also, are there any plotting functionalities for the Optimizer class? like the plot_objective() and plot_evaluations() for the output of *_minimize() functions.
thanks a lot and congratulations for this project!

This initially confused me too. The tell method returns the result object you're looking for:
result = opt.tell(blah, blah)
You can then pass result to the plotting functions as normal.

thanks for the quick reply!

Yup that is the way to do it. Thanks @jwcarr !
I close this, let me know if the suggestion does not work.


Add tests

... AND add tests that check that all the ome.zarr files in https://s3.embl.de/i2k-2020/ngff-example-data/v0.3 can be loaded?

I am making an extra issue that we do not forget this.

@KateMoreva did you do this already? then we could close the issue...


Pilot Ratings (Old 168)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:09
Need to add remaining pilot ratings into Core.

In gitlab by @A-Lawrence on Aug 31, 2015, 01:16
All pilot ratings have been added.  P1 - P9. Small fix to abbreviation returns too.  Resolves issue #488556 (168).
ÔåÆ <>
ALawrence66 - 2014-04-05T13:52:55.527553+00:00


Migrate to JavaFX

Swing is deprecated finally. Migrate to JavaFX as this is the new desktop UI platform for Java.

SplashScreen is still missing
disable unused menus

First migration is done. All remaining Swing dialogs can be migrated step by step later on.


libedit: 20170329-3.1 -> 20180525-3.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/libedit/versions.
These checks were done:

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 20180525-3.1 with grep in /nix/store/cjyizgchlbid5kq9qhgjm4bsn78i0kw7-libedit-20180525-3.1

directory tree listing: https://gist.github.com/2cbcdedff99016d29804a14409a498fd

du listing: https://gist.github.com/7e82fe655e6c31f0f57fef287fd71e54

meta.description for libedit is: '"A port of the NetBSD Editline library (libedit)"'.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 4fb4916c2546bf0eb5c3e7ec5c6fe8a8c9644b37 && nix-shell --pure -I nixpkgs=. -p libedit

Success on x86_64-darwin (full log)
Attempted: libedit
Partial log (click to expand)
post-installation fixup
Patching '/nix/store/kkf4dzk4lc4c21g980xdzi7g3a1zv4fc-libedit-20180525-3.1-dev/lib/pkgconfig/libedit.pc' includedir to output /nix/store/kkf4dzk4lc4c21g980xdzi7g3a1zv4fc-libedit-20180525-3.1-dev
gzipping man pages under /nix/store/pv6rvhgmj77zyq1r64v3q1jrj5w2nqlk-libedit-20180525-3.1/share/man/
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/pv6rvhgmj77zyq1r64v3q1jrj5w2nqlk-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/pv6rvhgmj77zyq1r64v3q1jrj5w2nqlk-libedit-20180525-3.1
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kkf4dzk4lc4c21g980xdzi7g3a1zv4fc-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/kkf4dzk4lc4c21g980xdzi7g3a1zv4fc-libedit-20180525-3.1-dev
/nix/store/pv6rvhgmj77zyq1r64v3q1jrj5w2nqlk-libedit-20180525-3.1

Success on x86_64-linux (full log)
Attempted: libedit
Partial log (click to expand)
gzipping man pages under /nix/store/cjyizgchlbid5kq9qhgjm4bsn78i0kw7-libedit-20180525-3.1/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cjyizgchlbid5kq9qhgjm4bsn78i0kw7-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/cjyizgchlbid5kq9qhgjm4bsn78i0kw7-libedit-20180525-3.1
checking for references to /build in /nix/store/cjyizgchlbid5kq9qhgjm4bsn78i0kw7-libedit-20180525-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/qw5vwszwfcbkk5ixg49vdm0ai93mwrsh-libedit-20180525-3.1-dev
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qw5vwszwfcbkk5ixg49vdm0ai93mwrsh-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/qw5vwszwfcbkk5ixg49vdm0ai93mwrsh-libedit-20180525-3.1-dev
checking for references to /build in /nix/store/qw5vwszwfcbkk5ixg49vdm0ai93mwrsh-libedit-20180525-3.1-dev...

Success on aarch64-linux (full log)
Attempted: libedit
Partial log (click to expand)
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iijplgj7yqyfykh88qlrr7n3jbrh2pvf-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/iijplgj7yqyfykh88qlrr7n3jbrh2pvf-libedit-20180525-3.1
checking for references to /build in /nix/store/iijplgj7yqyfykh88qlrr7n3jbrh2pvf-libedit-20180525-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/kasgkwbbvkl27hqw6qgqxzzcvqmi8cjx-libedit-20180525-3.1-dev
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kasgkwbbvkl27hqw6qgqxzzcvqmi8cjx-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/kasgkwbbvkl27hqw6qgqxzzcvqmi8cjx-libedit-20180525-3.1-dev
checking for references to /build in /nix/store/kasgkwbbvkl27hqw6qgqxzzcvqmi8cjx-libedit-20180525-3.1-dev...
/nix/store/iijplgj7yqyfykh88qlrr7n3jbrh2pvf-libedit-20180525-3.1

Failure on x86_64-darwin (full log)
Attempted: libedit
Partial log (click to expand)
building '/nix/store/9b7i6n85r58wc4hxs49w627x6flrc8ij-hook.drv'...
building '/nix/store/wqmf560djx97x9qsbqn9vgvynpb5czcx-bootstrap-stage1-stdenv-darwin.drv'...
building '/nix/store/crdww4abalagdpbw92dlj4z18jgg8gcv-CarbonHeaders-osx-10.6.2.drv'...
building '/nix/store/mnb56jjl2pl5m8bzmfrlvxpgncmnziw8-CommonCrypto-osx-10.11.6.drv'...
building '/nix/store/0f1h1vlzkjzfrg2jjq8ys58ccvjxbnfm-Csu-osx-10.11.6.drv'...
building '/nix/store/5j9sz3bbq7kdhzxp56fzr9xsm92gpc2w-Libinfo-osx-10.11.6.drv'...
building '/nix/store/4znkb1aiyavxn353nn8sq81rmi6cbwfd-Libm-osx-10.7.4.drv'...
building '/nix/store/j62gk6992gb7wm7lzsridmab2paf5qw7-Libnotify-osx-10.11.6.drv'...
building '/nix/store/vqxaaykcxq667sy35nhjahisys9blj29-Security-osx-10.9.5.drv'...
error: all build users are currently in use; consider creating additional users and adding them to the 'nixbld' group

Success on x86_64-linux (full log)
Attempted: libedit
Partial log (click to expand)
gzipping man pages under /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1
checking for references to /build in /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev
checking for references to /build in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev...

Success on aarch64-linux (full log)
Attempted: libedit
Partial log (click to expand)
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1
checking for references to /build in /nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev
checking for references to /build in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev...
/nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1

@GrahamcOfBorg build libedit

Success on aarch64-linux (full log)
Attempted: libedit
Partial log (click to expand)
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1
checking for references to /build in /nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev
checking for references to /build in /nix/store/wxm5m3l0dmzam82vggv42agl8ww7q4bs-libedit-20180525-3.1-dev...
/nix/store/y4zyikdl30cx0phyw87ca7aal7k6nxir-libedit-20180525-3.1

Success on x86_64-darwin (full log)
Attempted: libedit
Partial log (click to expand)
post-installation fixup
Patching '/nix/store/qr5pjjvzyd9lh8mg12jwky0dcbhmb1ry-libedit-20180525-3.1-dev/lib/pkgconfig/libedit.pc' includedir to output /nix/store/qr5pjjvzyd9lh8mg12jwky0dcbhmb1ry-libedit-20180525-3.1-dev
gzipping man pages under /nix/store/y62crjnmn41zvk0b343lypwig6vpgxkj-libedit-20180525-3.1/share/man/
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/y62crjnmn41zvk0b343lypwig6vpgxkj-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/y62crjnmn41zvk0b343lypwig6vpgxkj-libedit-20180525-3.1
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qr5pjjvzyd9lh8mg12jwky0dcbhmb1ry-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/qr5pjjvzyd9lh8mg12jwky0dcbhmb1ry-libedit-20180525-3.1-dev
/nix/store/y62crjnmn41zvk0b343lypwig6vpgxkj-libedit-20180525-3.1

Success on x86_64-linux (full log)
Attempted: libedit
Partial log (click to expand)
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1/lib
patching script interpreter paths in /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1
checking for references to /build in /nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev/lib
patching script interpreter paths in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev
checking for references to /build in /nix/store/80v1hgz8qip8bi4pvcsmn35k64rpcgqd-libedit-20180525-3.1-dev...
/nix/store/lj5gdjzjqjfbh2mhyxkyjx8885gl3jcz-libedit-20180525-3.1


charts appear blur on canvas - make crisp

Version
4.9.0
Steps to reproduce
show any bar chart on different screen resolutions / pixel ratio it shows blur on edges
What is expected?
it should be crisp like highcharts.com or svg borders
What is actually happening?
the dimensions are in float number and not rounded

maybe a solution could be rounding of the drawing rectangle dimensions and/or shifting of canvas context to adjust for half pixel?
please do assist ASAP as this will make the charts even more great to look at :)
thanks

Could you please try to check if this issue exists in 5.0? You may use the version 5.0.0-beta.2.

yes i just checked right now .. the issue exists in the latest beat
versionof 5.0.0 beta-2 also
i tried a quick fix like this below to make the rectangle sharper  .. but
it doesn't work everytime :(
rect: function (x, y, w, h) {
//edit 22/10/2020
// for columns
x = Math.round(x) + 0.5;
y = Math.round(y) + 0.5;
w = Math.round(w);
h = Math.round(h);
        //if (x % 2 !== 0) { // hack  for odd heights
        //    x = Math.round(x) ;
        //}
        //if (y % 2 !== 0) { // hack  for odd heights
        //    y = Math.round(y) ;
        //}

        //if (h % 2 !== 0) { // hack  for odd heights
        //    x = Math.round(x);
        //    y = Math.round(y);
        //}
        if (h >= 15) { // hack  for bars
            x = Math.round(x);
            y = Math.round(y);
        }

        //console.log('x:' + x + ' y:' + y + ' w:' + w + ' h:' + h);

        this._ctx && this._ctx.rect(x, y, w, h);
        this.addData(CMD.R, x, y, w, h);
        return this;
    },

On Thu, Oct 29, 2020 at 6:21 AM Zhongxiang.Wang<EMAIL_ADDRESS>wrote:

Could you please try to check if this issue exists in 5.0? You may use the
version 5.0.0-beta.2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-echarts/issues/13504#issuecomment-718290922,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABD2QUTGN3ED6G5IUPS4PB3SNC4CRANCNFSM4TCMMHZA
.

Thanks for the check. Just found you had gotten involved in this issue in #13504. It may still take some time to fix it.

Is there has a version that doesn't has this error?
my echarts version is 4.9.0 and has this same error;

After i read zrender source code, i found how to trigger this problem in my case;
First the zrender src/config.ts portion code:
let dpr = 1;

// If in browser environment
if (typeof window !== 'undefined') {
    dpr = Math.max(window.devicePixelRatio
    	|| ((window.screen as any).deviceXDPI / (window.screen as any).logicalXDPI)
    	|| 1, 1);
}

As you can see, zrender use window.devicePixelRatio  to set pixel almost any time in today browser if you don't config this, and my case is:
First i displayed my webpage on a low pixel screen(1PX), and then i dragged the browser to mac screen(2PX), so i found this problem.
So it's okay for me. Just for sharing my case.

I see similar issues in the charts examples if I zoom the browser:

Notice that when I refresh the page the echart reloads and sees the new devicePixelRatio and looks sharp again. I think the issue is that echarts needs a way to allow for monitoring changes to the devicePixelRatio dynamically.
MDN has an example for Monitoring screen resolution or zoom level changes which should help for the browser zoom use-case I show.

I am facing the same issue when trying to produce high-quality PDFs using puppeteer. While other items on the web page look crisp even when zoomed in to 300% or more, the charts look blurry, as you can see below:

Could you please take this enhancement up in the next release? It's really important for us to deliver high-quality reports to our clients.

Any update on that? I face same issue on v5.5.1

image are blury any one who find out solution


[cherry-pick][branch-2.1][Enhancement] delay creation of memtables in delta writer (#6823)

Signed-off-by: xyz<EMAIL_ADDRESS>What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #6818
Problem Summary(Required) ：

Before sending data, we will first open all tablets, and init all tablet memtables. However, most of these memtables will not used lator. Suppose a table has 2500 tablets, and a stream load only covers 100 tablets, then 2400 memtables are not used in this stream load. These 2400 unused memtables consumes a lot of memory.
In this pr, i delay the creation of memtables until we write chunk.
In my test, if there are 3 concurrent stream load, before optimization, the load memory can reach to the upper bound 30G quickly, after optimization, the load memory is 0.5G.

run starrocks_fe_unittest

run starrocks_clang-format


Web pages with authentication does not work get-htmltable

I added "-usedefaultcredentials" (get-htmltable.ps1 file)
$r = Invoke-WebRequest $url -UseDefaultCredentials
maybe an additional parameter to include credentials would be better.

Added https://github.com/dfinke/ImportExcel/commit/2da4575496bb6bf574290c9b47c3f9db8adc1d95


common returns/throws/requires/emits for polymorphic functions

close #113

@ericelliott looks ready to me.


Add numeric string test

Base on https://github.com/exercism/xruby/issues/135
I noticed while working on this solution that the case where a binary string is only numbers, i.e. 123 isn't covered. I noticed this while trying to determine if a string was valid I could pass the tests by doing something along the lines of:
   def to_decimal
    return 0 if n.to_i == 0
    n.reverse.each_char.with_index.map { |char, index| char.to_i * 2**index }.reduce(:+)
  end

the test for string carrot123 returns 0, which is fine, but if i put 123 as a string my method would return a value,11 in this case.

Thanks!


MaxPool+AvgPool - opset 10 [Dilation and ceil_mode]

Add support for new attributes 'dilations' and 'ceil_mode' for opset10.

LGTM 👍  will approve once all tests pass. Thanks!


Pressing v c-u triggers which-key and stops there

Did you check docs and existing issues?

[X] I have read all the which-key.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of which-key.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.11.0-dev-434+ga0fd51c1e
Operating system/version
Ubuntu 22.04
Describe the bug
So if i go into visual mode, which-key triggers automatically, if then i press ctrl-f  to go down, it works fine. If instead I press ctrl-u to go up, nothing happens. I have to press some other key to get out of which-key and then do ctrl-u.
Steps To Reproduce
press v. Press ctrl-u
Expected Behavior
I expect neovim to enter visual mode and move up a block as usual with ctrl-u
Health
No response
Log
No response
Repro
 local which_key = require "which-key"
  which_key.setup {
    opts = {
     triggers = {
       { "<auto>", mode = "nixsotc" },
       { "a", mode = {  "n" } },
     },
    },
    preset = "helix",
    plugins = {
      marks = true,
      registers = true,
      spelling = {
        enabled = true,
        suggestions = 20,
      },
      presets = {
        operators = false,
        motions = false,
        text_objects = false,
        windows = false,
        nav = false,
        z = false,
        g = false,
      },
    },
    win = {
      border = "rounded",
      no_overlap = false,
      padding = { 1, 2 }, -- extra window padding [top/bottom, right/left]
      title = false,
      title_pos = "center",
      zindex = 1000,
    },
    -- ignore_missing = true,
    show_help = false,
    show_keys = false,
    disable = {
      buftypes = {},
      filetypes = { "TelescopePrompt" },
    },

I could recreate this as well.


Icon is missing in browser tab in the deployed version (works in local)

screenshot

Not working here too.

there could be syntax error in favicon code...can I work on this?