Phrase search does not return the correct highlight

Describe the bug
When performing a phrase search, "the seeker seeks the one" as one example on my data. The phrase search will return the first highlight with the word "the" in it... instead of returning the highlight with the entire phrase.

If you take a look at the text itself, you can see the phrase "the seeker seeks the one" exists in the third paragraph but the highlight in the search hits returns the first sentence.

Expected behavior
I would expect the phrase search to only return results which includes the exact phrase and only highlight the exact phrase.
MeiliSearch version: [e.g. v0.20.0]
{
    "commitSha":"2e2eeb0a424408e27f4223e58afec303c53e1419",
    "commitDate":"2021-10-12T14:47:06+00:00",
    "pkgVersion":"0.23.1"
}

Additional context
I understand stop words might be used to exclude "the" and "of" from the search, which might help the result... but in our case we want to search dialogue exactly for "the seeker seeks the one" for example, and not "seeker of the one seeks" or another combination of the phrase, for example.

In my Javascript search config, I am cropping the content by 140 characters because we do have larger chunks of text with many paragraphs, it could be that MeiliSearch finds the correct phrase/sentence but starts cropping at 0-140 instead of cropping and highlighting around the phrase.

Hello @tao
Thanks for the report, this is really appreciated!
The core team will do their best to investigate and fix this in the next release, in December. Sorry for the inconvenience!

Hello @tao!
It looks like the highlighter is separating all the words in the search phrase, considering them as separated terms and highlighting them one by one. This behavior is interesting when we are out of context of an exact phrase query however what we could consider to solve this problem is to take the whole phrase search query as one "word" and apply it where it matches.
e.g. "The seeker seeks the One"
Currently, this is what happens.
{
    "hits": [
        {
            "_formatted": {
                "searchable_field": "This is a long text. The seeker seeks the</em one exact phrase search. The car is red."
            },
            "_matchesInfo": {
                "searchable_field": [
                    {
                        "start": 22,
                        "length": 6
                    },
                    {
                        "start": 43,
                        "length": 2
                    },
                    {
                        "start": 46,
                        "length": 3
                    },
                    {
                        "start": 50,
                        "length": 3
                    },
                    {
                        "start": 54,
                        "length": 5
                    },
                    {
                        "start": 101,
                        "length": 3
                    }
                ]
            }
        }
    ],

}

Note, that _matchesInfo is following the same rule.

It could be something like that when we encounter an exact phrase search within the q parameter.
{
    "hits": [
        {
            "_formatted": {
                "searchable_field": "This is a long text. The seeker seeks the one exact phrase search. The car is red."
            },
            "_matchesInfo": {
                "searchable_field": [
                    {
                        "start": 22,
                        "length": 24
                    }
                ]
            }
        }
    ],

}

While searching for an exact phrase search and a term. E.g. "The seeker seeks the one" the could be
{
    "hits": [
        {
            "_formatted": {
                "searchable_field": "This is a long text. The seeker seeks the one exact phrase search. The car is red."
            },
            "_matchesInfo": {
                "searchable_field": [
                    {
                        "start": 22,
                        "length": 24
                    },
                    ...  //_matchesInfo for `The` query term
                ]
            }
        }
    ],

}

I don't know if it is feasible very easily in the current state and maybe there are limits that I don't see.

Yes, from our work so far it seems like the default search works as a "match any word", while phrase search currently works a lot more like "match all words"... which is something we do want to include as some optional functionality for the user.
However, we also really need a "match exact phrase" search, that would only return results that include (and highlight) the exact phrase. Even if we have to highlight it ourselves that's fine... So it wouldn't highlight loose words like The or the One in that case.
I did also reach out to the support chat recently about this "all words", "any word", "exact phrase" but haven't heard back yet... but I noticed in some other open issues that phrase search is being worked on and maybe it's related?

Hi @tao! 👋
The phrase search pattern allows two things:

"The car is red" -> The returned documents will contain EXACTLY the terms in that order.
"The" "car" "is" "red". -> The documents returned will contain the terms in no particular order.

We have a product discussion concerning the policy for matching words (as I may know it does not directly concern the phrase search but "simple" query terms behavior).

Hello! Sorry, I took a bit of time to respond 😖.
I honestly think that this is not a bug. The current highlighter of meilisearch is "dumb". It is not possible to find the best match of the query in a field. It basically says: "this word is a match".
However, it's possible to improve it, forcing it to find the best match in each field instead of the first one. We could have some performances drawbacks, but it would make the crop way more relevant.
I think this issue can be fixed relatively easily and could be a good first issue. 🤝
Thanks @tao, for your report! 👍

Thanks, I understand... I think it's maybe a bit more of an inconsistency in how I would expect phrase search to work, or maybe the highlighting on phrase search could be stricter, but since it's not that relevant I did discuss that more in the policy on matching words discussion.
It's more of a cropping issue than a highlighting issue? So basically if you include any common word (the, of, one, to) the highlighter would start cropping from the first instance of the word instead of cropping around the best match.
Maybe it could be improved then by letting the cropping function ignore stop words?

Yes, you're right, it's a cropping issue, but the cropping function uses the highlighter to know where the matches are in an attribute. For now, it stops on the first match found and not on the more relevant match. What we could do is crop around the biggest "match density" in a field. 🤔

Postponed to a future version due to lack of time on your side to treat it well.

Hello everyone,
Checked with @ManyTheFish, this issue contains two problems

a bug, that has been fixed in v0.25.0
a feature request -> crop by density instead of cropping around the first match. Since it's a design change and not a bug, this is handled on the product repository. See this discussion regarding this: https://github.com/meilisearch/product/discussions/350

@ManyTheFish has also started some discoveries and tests in https://github.com/meilisearch/meilisearch/pull/2130
I'm closing this issue then since the discussion is now on the product's side :) Feel free to give your feedback on it!


Contact Applicant Log - Confirmation Email Payment Overwrites Prior Email

Describe the bug in current situation
While training in test-marshal, it was observed that when a request has a fee estimate sent the standard way through the on-hold function, and then a new CFR form is created, and a subsequent fee is sent through the contact applicant log - payment of the subsequent fee overwrites the subsequent fee email.
Link bug to the User Story
Impact of this bug
High impact - users will lose the sent fee email originally provided to the applicant
Chance of Occurring (high/medium/low/very low)
High - applicants typically attempt to narrow requests, if the applicant chooses to pay it will trigger this bug
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
TEST-Marshal
Steps to Reproduce
Steps to reproduce the behavior:

Go to a general request, and send a fee estimate to an applicant using the state change
Create a new CFR form, and select the reason as "Request Narrowed"
Update the fee to be different (smaller) than the original
Approve new fee, and send fee estimate through contact applicant log
Pay fee online
Go to Contact Applicant log - the email that was sent in step 4 will no longer appear, and be replaced by the receipt email sent to the applicant

Actual/ observed behaviour/ results
Expected behaviour
Prior emails must be retained, and the confirmation email payment must not overwrite any prior email
GIVEN an applicant has received a fee estimate email
WHEN they complete the payment
THEN a copy of the email confirming payment and the receipt shall be added to the Contact Applicant Log
Screenshots/ Visual Reference/ Source
This was observed in EDU-2022-999652, and EDU-2022-88765

Email overwrite bug we observed @lmullane

@m-prodan @lmullane - This issue is fixed with latest push. Please retest and let us know.

Tested in EDU-2022-31542 and bug is resolved. Recreated steps above and all 3 emails that were sent to the applicant appear in the contact log (initial fee estimate, revised fee estimate and acknowledge of payment).


Use chart releaser to release charts

We should use chart-releaser to handle the chart releases as it's more standardised.

Closing, charts are now being released to a new central repo.


🐛 fix cypress commands

I had some errors in the config changes I just merged
I tested this by deleting the filter for main branches and everything passed

TODO: need a key for the GCLOUD_GCS_SERVICE_KEY_SANDBOX env var get this way https://apollograph.slack.com/archives/D01LLR3ACMD/p1633381877002300


[BUG] storage/common/policy/RequestRetryOptions incorrect javadoc for retryDelay, maxRetryDelay,

Describe the bug
https://github.com/Azure/azure-sdk-for-java/blob/e3cc975bb373e5cdb7fcece31df7bf4ff196cd3a/sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/policy/RequestRetryOptions.java
package: com.azure.storage.common.policy
class: RequestRetryOptions
javadoc default values for parameters retryDelay and maxRetryDelay are specified in ms (4ms, 30ms, 120ms), but in code there are seconds: 4 seconds, 30 seconds, 120 seconds
     * is {@code 4ms} when {@code retryPolicyType} is {@link RetryPolicyType#EXPONENTIAL EXPONENTIAL} and {@code 30ms}
     * when {@code retryPolicyType} is {@link RetryPolicyType#FIXED FIXED}.
     * @param maxRetryDelay Optional. Specifies the maximum delay allowed before retrying an operation, default
     * value is {@code 120ms}.

switch (this.retryPolicyType) {
                case EXPONENTIAL:
                    this.retryDelay = Duration.ofSeconds(4);
                    break;
                case FIXED:
                    this.retryDelay = Duration.ofSeconds(30);
                    break;
                default:
                    throw LOGGER.logExceptionAsError(new IllegalArgumentException("Invalid 'RetryPolicyType'."));
            }
            this.maxRetryDelay = Duration.ofSeconds(120);

Expected behavior
I believe javadoc is wrong, not the default values themselves.

Hi @welovelain thanks for reaching out to us via this GitHub issue.  Someone from the storage team will follow up shortly.  Thanks again.

@welovelain Thank you for pointing this out. We'll get it cleaned up.


Excessive memory consumption over time

Likely this is due to excessive .clone() + polling causing memory to slowly grow over time. The same is observed when doing many interactions in a short period of time (cypress headed testing)

Able to reproduce locally by running the same test repeatedly. Memory consumption increases over time.

@robinbb has your tab been crashing?

@n1tranquilla Not recently, but I haven't kept it open for long.

Try keeping the tab open as I don't think it's a problem any longer. I haven't seen memory usage spike.

Closing this. Memory consumption tends to stay below that of my email reader. So, good enough.


feat: Add Middleware to handler HTTP request timeout

Close: #2462
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?

Issue Number: #2462
What is the new behavior?
Add a middleware to gracefully handle the HTTP request timeout. If a call runs for longer than its time limit, the handler responds with a 503 Service Unavailable error and the given message in its body.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

Hi @brandonforster,  could you please help to verify this PR?
You need to remove the timeout settings from the below code snippet or use a smaller timeout:
	server := &http.Server{
		Addr:         addr,
		Handler:      b.router,
		WriteTimeout: timeout,
		ReadTimeout:  timeout,
	}

https://github.com/edgexfoundry/go-mod-bootstrap/blob/2a375e709834d30167aac8415f8b7aabacab21d0/bootstrap/handlers/httpserver.go#L100-L101

Hi @brandonforster, could you please help to verify this PR?

I no longer have a working dev environment or any context on the state of the project and I believe it would be inappropriate for me to do so.
That being said, I'm glad you guys are tackling this! This was a tremendously thorny problem.


Selling Form Blocked

While a redeem or redeemAll transaction is waiting to be mined, we're blocking the selling form. This is inconsistent with the buying form. I think our desire here is to clear the form and workspace anytime a transaction is submitted so that the user can proceed with more work. The sell side might be a little more confusing than the buy side though. If the user calls redeemAll, for example, the form will reset with an animated "remaining balance". But we probably want them to be consistent.

Outdated


Fix: Fixed issue with editing properties of multiple items at the same time

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #14900

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Test Cases
Hidden status is saved and displayed correctly directly in the UI if only one file is selected

Select a file, open properties, select hidden + save
The file is now displayed directly in the list as hidden
Open properties again and check whether hidden status is set

Hidden status is saved and displayed correctly directly in the UI when multiple files are selected

Select multiple files, select hidden + save
The files are now displayed directly in the list as hidden
Open properties again and check whether hidden status is set

Screenshots (optional)
Add screenshots here.

There is a small glitch in the following step.

Select hidden and non-hidden files together.
Open the properties window.
Press the Save button.
The list appears as if the hidden attribute has been removed, but in fact it has not.

It might be better to put the checkbox in the third state when hidden and non-hidden files are selected together.

Good idea, thank you


added invert tailwind class into the footer logo

fixes #7
Added the invert tailwind class to the footer.ejs logo. Now logo is visible.

Thank you @roshan798 . Your contribution has been acknowledged.

@roshan798 After merging the code the logo is not visible properly in the light mode. Could you please fix this. Make a separate PR if you do so. I am closing this one. Thanks.


Important: Incorrect affine matrix

Dear all users and readers of NPP:
I and Heejong recently found that although the image pixel data has been aligned by npp, the affine matrix from the input nifti image we used to create the final image could make the aligned image unaligned in visualization tools like itk-snap. We will correct the issue ASAP.
Best

Issue solved


Implement MVP branding

Implement the basic branding necessary for MVP launch. Note that adding more of a splash-page-style homepage is happening post-MVP under #11.
To do

[x] Implement fonts, colors, overall styling
[ ] Once logo/wordmark finalized under https://github.com/protocol/design-shop/issues/586, update header wordmark art (including optimizing SVG)
[ ] Once logo/wordmark finalized under https://github.com/protocol/design-shop/issues/586, update header logo art (including optimizing SVG)
[ ] Once logo/wordmark finalized under https://github.com/protocol/design-shop/issues/586, update all favicon images (note: any existing ones in repo should be replaced even if they "look right" as colors and details will have changed slightly)
[ ] Once logo/wordmark finalized under https://github.com/protocol/design-shop/issues/586, update social card art (including the social card art in this repo's GitHub prefs)
[ ] Update welcome-page art once https://github.com/protocol/design-shop/issues/599 is done, including optimizing SVG
[ ] Update "under construction" art once https://github.com/protocol/design-shop/issues/600 is done, including optimizing SVG
[ ] If possible, modify off-site link icon to match overall pixellated visual metaphor (@zebateira, can you please advise?)
[ ] If possible, modify "back to top" arrow to match overall pixellated visual metaphor (@zebateira, can you please advise?)
[ ] Fix background colors on 404 pages
[ ] Check over CSS overall, including removing !important declarations whenever possible and possibly consolidating/relocating CSS; right now there are style rules both in /docs/.vuepress/theme/styles and in individual components in /docs/.vuepress/theme/components and /docs/.vuepress/theme/global-components
[ ] Test on multiple browsers and viewport widths for consistency
[ ] If time, add dark mode/light mode options (if not, split out into its own post-MVP issue)

@zebateira - updated the original comment on this issue with a checklist of outstanding items. It's not as bad as it looks - many are about updating art once we get final files from @ericronne's team - but I would definitely appreciate any work that you've got time for on these. 🙏  Please let me know how you'd prefer to divide/conquer!

the "back-to-top" arrow we can override easily, but the outbound link I have to test it.

Dark theme isn't merged as of this moment, but it's in active review under https://github.com/protocol/nft-website/pull/71. Closing this issue to keep the board tidy as we lead up to soft launch 🎊


Fix fluent-bit source repository

How to categorize this PR?

/area open-source
/kind bug
What this PR does / why we need it:
The source repository for fluent-bit is https://github.com/fluent/fluent-bit not https://github.com/fluent/fluent-operator.
When we change this, we can also switch to github-releases as source for fluent dependencies in renovate.
Fluent-operator go module (ref) and fluent-operator (ref) are currently out of sync, because we missed one update of the later.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We still have to copy the image though.
Release note:

NONE

renovate could create PRs for patch releases only as we do it for istio and kubernetes dependencies.

+1
Would you do this in this or a separate PR?

I adapted the configuration, so that only PRs for patch version updates are created automatically.
@LucaBernstein showed me how to configure renovate that it creates updates on manual request from the dependency dashboard only (ref). I used this where we disabled PRs for patch and major versions. This way we can keep track of upcoming updates.


DelegatorBot as session controller for MVC

I use MVC design with multiple View classes for my application, so it can be used either as a GUI app, or as a Telegram bot. I am trying to use DelegatorBot to spawn a session per each user.
What I need to do for each session:

Create View, create Controller using that View
Redirect user's messages to the created View

Also, each session should have a timeout, so it should also be destroyed properly.
This pushes me to the idea of some in-between class that would handle all that. I imagine that I should use create_open for initialization of that class. But it is hard for me to understand how the class should look like. Maybe I can somehow make use of telepot mixins or helpers?

If you want to spawn a session per user, DelegatorBot is definitely the way to go. However, without knowing more concretely what you want to do, I can't say much more.
You probably don't need to use mixins explicitly. One of ChatHandler or UserHandler should fit your needs. Exactly how to use them depends on whether you need to handle inline query or callback query or neither. Please study the introduction and the examples for further directions.

Thanks, I'll try that!


merge develop into main to catch synch for versions

Warnings

:warning:
:pencil: Please include a description of your PR changes.

:warning:

:man_technologist: Please assign someone to review this PR.

:warning:
:thinking: Well, it seems like that there are no tests in this PR. Please think about the test coverage of the added functionality and feel free to ask for help if you need it.

:warning:
:thinking: Wow, this one looks like a big pull request. For your next PR please try to split your PR into smaller PR's. (> 1000 line of code)

Messages

:book:

Thanks - We :heart: our documentarians!

:book:

:man_technologist: Some dependencies were added or removed in package.json file.

:book:
:+1: This PR contains commits with "BREAKING CHANGES", that will increase the major version of the project. The major version will be changed.

:book:
:tada: This PR changed 19269 lines of code in the project.

:wave: Hello demirtasdurmus and thank you for your contribution!

Before the reviewers could start with a code review process, please ensure that all the following points in your pull request (PR) are fulfilled:

Each variable and function inside component or service should contain a short code description (JSDoc-TSDoc)
In our Typescript applications we always try to avoid the type any and define new types or interfaces therefore
For the names of classes, functions or variables we use camelCase style (capitalized style for classes)
Code documentation for functions, classes, interfaces etc. should be written in capitalized style

  Generated by :no_entry_sign: dangerJS against c0b73b45842b0a7427b8b6865d1f417a40ddc5d1

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Difference from standard

https://gist.github.com/johnmuhl/4592c57c0b1c85e5b4c8f035c3ecf6eb
The configuration-original.js file is generated by the rails/webpacker gem; configuration.js is the result of running prettifier-standard. standard-out.sh shows the offending code; i.e.
// Expected "[" and "]" to be on the same line
const paths = safeLoad(readFileSync(join(configPath, 'paths.yml'), 'utf8'))[
  env.NODE_ENV
]

Standard 10.x and 9.x show the same error.

I have the same behaviour:

I think it is a bug on standard.js side, as whitespace makes sense there if we want to maintain line-length limit. I'd prefer to be more compatible with prettier than standard on this matter.
I'd suggest raising this issue (or sending a PR) at https://github.com/feross/eslint-config-standard

OR you could argue this should be changed at https://github.com/prettier/prettier

This brings up a wider question to me: does this package provide anything more for me than just using prettier like this?
prettier --write **/*.js && standard --fix **/*.js

I know it was mentioned briefly in the prettier library, but I'm just wondering why I would use prettier-standard over the one-liner above.
It seems like this library is actually not all that related to standard, since it doesn't use standard for formatting, and allows for rules to be overridden, which goes directly against the philosophy of standard to "just pick something".
I'm also concerned with prettier-standard's divergence from or outrunning of standard's rules, including things like enforcing "object-curly-spacing", even though this is still in discussion in the actual standard library. (I'm actually confused where the base-level ESLint rules are defined for this package, as there is no .eslintrc or eslintConfig property in the package.json.)
I'm just afraid that if I use this, harmony between the prettier-standard and standard will split over time, causing inconsistencies in my codebase. (It also feels somewhat misleading calling this prettier-standard when it is closer to just prettier-eslint.)

standard is a linter and prettier-standard is a formatter, you won't get any errors to fix manually when using it. This is the difference from the snippet you provided above.
By "doesn't use standard for formatting" I just meant the standard cli command itself, not the standard eslint rules. Specifically prettier-standard uses  internallyprettier-eslint.
My goal is to make prettier-standard respect most of formatting rules from standard. prettier-standardsupports arbitrary rules in .eslintrc so you can freely override anything. I think allowing developers to change things they don't like is more important than following the "philosophy".
object-curly-spacing is one thing you seem to not like, so you can configure it in .eslintrc. As for the divergence from standard, I'd like to avoid it if reasonable, so feel free to open an issue.
Base formatting rules are minimal and currently defined here:
https://github.com/sheerun/prettier-standard/blob/master/src/format-files.js#L68-L78

I think it is a bug on standard.js side, as whitespace makes sense there if we want to maintain line-length limit.

Standard does not enforce line length limits. To impose them here seems counter-intuitive.

I'd prefer to be more compatible with prettier than standard on this matter.

Thanks for clarifying your preference; for now I'll stick with standard Standard. I'm fine with this issue being closed unless you'd like to keep it open for others to have a broader discussion.

standard is a linter and prettier-standard is a formatter

Right, but the snippet I posted included prettier, which is at the core of this library. I was asking what prettier-standard provides me as a library over just using prettier and standard in the one-liner I mentioned.

prettier-standardsupports arbitrary rules in .eslintrc so you can freely override anything. I think allowing developers to change things they don't like is more important than following the "philosophy".

I generally agree that allowing for configuration of tools is valuable for developers, and that is exactly what ESLint provides. But Standard was built explicitly to avoid manual configuration and bikeshedding.

object-curly-spacing is one thing you seem to not like

It's not that I don't like the use of the object-curly-spacing rule here, it's that it isn't yet decided in Standard itself. There are plenty of other things I disagree with that Standard does (e.g. single-quotes in JSX, space after function name, etc.), but the whole point of me choosing Standard was to let go of my arbitrarily dogmatic opinions and let the library just make the decision for me, the benefit being zero configuration.
I don't want to have to maintain a .eslintrc, or update and change random rules over time. I have no problem delegating this to a team of people that will provide me a library of syntactic standards—even if I disagree with a choice they made. In the end, all I care about is style consistency.
Correct me if I'm wrong, but this library seems to conflict with that idea. It contains deviations from Standard, and also allows for rule changing and extension.

I want to make it clear that I am not trying to attack this library—I think it's awesome that it was created. I'm just trying to understand it.
I love the concepts of prettier, and I love the concepts of standard, and marrying them together seems like quite an awesome style and format standardization. It both removes the energy it takes me to both come up with my own style and format configurations, and the energy it takes for me to convince others to use such configurations. Basically, my team can rest assured that our code will be syntactically consistent and clean without having to install a bunch of things on different IDEs, waste time bikeshedding over indentation or quote preferences, or remain vigilant about our writing style. Using these two tools guarantees coherence with minimal cognitive effort.
But I am confused how this library gets me there. I would like to understand it better.

@indiesquidge I think as a compromise we could introduce --strict flag, so 100% of standard rules are enforces, even these that don't make sense to me.
I'll accept the PR if anyone sends it

Upon further requests I've decided to add all fixable rules from standard. This behavior is releasd in prettier-standard 6.0.0. Please not that the rule that is the subject of this issue is not fixable. This might be somehow solved in the future by #17


Remove ASGI scope client field if not present

This is a workaround for https://github.com/django/asgiref/issues/410

By the way, this means that we can't push DATA_FORMAT_ASGI connection scopes to web endpoints with client version before this PR was merged, since it might break WSGI apps.


The reply-to container is initialized lazily and shouldn't be binding its connection factory to the calling thread

Affects Version(s): <2.1.6>
Getting "IllegalArgumentException" errors trying to do the following:
Receive an AMQP message that forces me to stop a "SimpleMessageListenerContainer".
Make an AMQP request using the "direct reply-to" mechanism.
Restart the "SimpleMessageListenerContainer"
More details in:
https://stackoverflow.com/questions/57906682/simplemessagelistenercontainer-and-illegalargumentexception

Can you explain your use of the RoutingConnectionFactory? Please show its configuration.
It turns out that this code is required in order to use the correct targetConnectionFactory when running a connection listener (if present). Orignal SO issue here.
The problem is that the RoutingConnectionFactory's routingLookupKey is bound to the thread with the SMLC's queue name and we can't rebind it with another key (for the DRTMLC). In any case, I suspect you won't get a hit on the lookup anyway (unless you have configured that key as well in the RCF).
Is there any way you can avoid using the simpleRoutingConnectionFactory() in the template for the send and receive?

I found a solution.


Using decorators to perform schema validations on DataFrames

Addresses #140

Hey @edmondop, I'll take a look at this!

@edmondop, @MrPowers
These commits look good - the decorators are a really nice and visible way to add validations to existing functions. One thing I'm thinking about is the overlap in naming, like how validate_returned_schema() references validate_schema() and ensure_columns_present() references  validate_presence_of_columns()
To an end user, I'm not sure if this difference would be obvious. Would it be possible to make the existing functions work as optional decorators? Let me know what y'all think

@edmondop, @MrPowers These commits look good - the decorators are a really nice and visible way to add validations to existing functions. One thing I'm thinking about is the overlap in naming, like how validate_returned_schema() references validate_schema() and ensure_columns_present() references validate_presence_of_columns()
To an end user, I'm not sure if this difference would be obvious. Would it be possible to make the existing functions work as optional decorators? Let me know what y'all think

Hi @jeffbrennan I tried a couple of strategy but that doesn't work well. The problem seems to be that Python has a limitation around overloading, that is not fixed in the standard library.
If you define let's say validate_schema as both a function that takes three parameters, and as a decorator that takes two parameters and return a wrapper of a function, you need a language that support overloading correctly, and Python doesn't. I would need to introduce an additional dependency to move forward if needed (multi-dispatch)

So this pull request adds a few functions to the public interface: validate_returned_schema, ensure_columns_present, ensure_columns_absent.  These functions are exposed as decorators and can only be used for functions that return DataFrames.
I am actually curious what would happen with the validate_returned_schema if the decorator is added to a function that returns a StructType.
quinn already has the following functions: validate_presence_of_columns, validate_schema, and validate_absence_of_columns.
From what I understand, we can't use the existing names because Python doesn't support overloading.
It seems like validate_presence_of_columns is more flexible because it can be invoked multiple times in a function.  ensure_columns_present can only be invoked once.
From a naming perspective, I definitely don't think we should have "presence_of_columns" and "columns_present".
I am on the fence about this one.  I really like the decorator syntax.  If we didn't already have something then this would be a no-brainer.  I am concerned that introducing another way to accomplish the same task might confuse users.  I am interested in thoughts from the community.

So this pull request adds a few functions to the public interface: validate_returned_schema, ensure_columns_present, ensure_columns_absent. These functions are exposed as decorators and can only be used for functions that return DataFrames.
I am actually curious what would happen with the validate_returned_schema if the decorator is added to a function that returns a StructType.
quinn already has the following functions: validate_presence_of_columns, validate_schema, and validate_absence_of_columns.
From what I understand, we can't use the existing names because Python doesn't support overloading.
It seems like validate_presence_of_columns is more flexible because it can be invoked multiple times in a function. ensure_columns_present can only be invoked once.
From a naming perspective, I definitely don't think we should have "presence_of_columns" and "columns_present".
I am on the fence about this one. I really like the decorator syntax. If we didn't already have something then this would be a no-brainer. I am concerned that introducing another way to accomplish the same task might confuse users. I am interested in thoughts from the community.

There are workarounds, but they all come with trade-offs I believe. In particular, I think if we use https://pypi.org/project/multimethod/, we can achieve the desired behavior of having a single consistent API . I just didn't feel like adding a new dependency without asking was appropriate. I tried with singledispatch and ended up throwing away all the code and be very frustrated
Other ideas:

separate extension package( quinn.decorators?)
trying to work with existing Python feature but introducing a breaking change. For example, I think if we use only keyword named arguments, it's possible to write a signature that takes a single kwargs dict, and try to make it behave dynamically depending on how many entries are in the dictionary (2 for the decorator in validate_schema)

I think the use case here that I have in mind is that someone could desire that in a complex Spark pipeline, being all lazy, there are explicit points where the schema is checked. Almost as an instrumentation system for a spark job

@edmondop - I am really happy that you opened this pull request and put this on my radar.  Decorators could be really nice for Python programmers.  I created a separate issue where we can brainstorm this more generically.  I'm interested in brainstorming the ideal decorator interface for PySpark programmers, seeing how it helps for common pipelines, and exploring any potential downsides of the approach.  I think we should detach this "ideal end state" brainstorming exercise from this "dealing with legacy code and all the semver/deprecation/public interface messiness considerations.  Let's brainstorm the ideal end state in the other issue!


Simplify our css in using :is or :where

For reference:

https://developer.mozilla.org/en-US/docs/Web/CSS/:is
https://developer.mozilla.org/en-US/docs/Web/CSS/:where

For example:
https://github.com/mozilla/pdf.js/blob/f39ff20485014a8782ca71844ed01d72f7c2ac91/web/viewer.css#L330
Probably few others for annotations.
I didn't know either :is or :where before today.

It's worth noting that :is() and :where() are not supported in all browsers yet
Assign this issue to me I will simplify viewer.css

Assign this issue to me I will simplify viewer.css

Sorry, but this may not be an ideal beginner bug without any prior PDF.js experience (given that any changes require careful manual testing). Furthermore, as outlined in https://github.com/mozilla/pdf.js/issues/16194#issuecomment-1479351592 this potentially applies to all our CSS-files (and not just one).

I understood, Thanks for reply. Can You suggest me some beginner friendly issues I would like to work on PDF.js


Nested preload AfterFind gets called before relations are retrieved

I found #522, but is is closed and does not explain the problem.
What version of Go are you using (go version)?
go version go1.12 linux/amd64
Which database and its version are you using?
Any really. Tried with mysql and sqlite3
Please provide a complete runnable program to reproduce your issue.
package main

import (
	"fmt"
	"log"

	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/sqlite"
)

var db *gorm.DB

// Product is goods for sale
type Product struct {
	ID           int64     `gorm:"column:pk_product;primary_key"`
	Stocks       []Stock   `gorm:"foreignKey:PkProduct"`
	Stock        float64   `gorm:"-"` // this is calculated value, set by AfterFind
	Alternatives []Product `gorm:"many2many:alternatives;association_foreignkey:PkProduct;foreignkey:ID;association_jointable_foreignkey:pk_product2;jointable_foreignkey:pk_product;"`
	Name         string
}

// Stock is the amount of a product in a specific warehouse, from a specific batch
type Stock struct {
	ID        int64   `gorm:"column:pk_stock;primary_key"`
	PkProduct int64   `gorm:"column:pk_product;index"`
	Product   Product `gorm:"foreignKey:PkProduct"`
	Amount    float64
	//PkWarehouse normally would be here etc.
	//PkBatch
}

// Alternative is the many2many relation table
type Alternative struct {
	PkProduct  int64   `gorm:"column:pk_product;index"`
	PkProduct2 int64   `gorm:"column:pk_product2;index"`
	Product    Product `gorm:"foreignKey:PkProduct"`
	Product2   Product `gorm:"foreignKey:PkProduct2"`
}

// AfterFind is sort of constructor that sets attributes
// Needed for views/templates, where one cannot use functions
func (p *Product) AfterFind() (err error) {
	log.Printf("AfterFind for %d", p.ID) // debug to see if this gets called
	p.Stock = p.getAvailableStock()
	return
}

// getAvailableStock calculates sum of all stock records
func (p *Product) getAvailableStock() float64 {
	var stock float64
	for _, s := range p.Stocks {
		stock = +s.Amount
	}
	return stock
}

func init() {
	var err error
	db, err = gorm.Open("sqlite3", "file::memory:?cache=shared")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)
}

func main() {
	db.AutoMigrate(&Product{})
	db.AutoMigrate(&Stock{})

	milk := Product{Name: "Milk"}
	juice := Product{Name: "Juice"}
	db.Create(&milk)
	db.Create(&juice)
	alt1 := Alternative{PkProduct: milk.ID, PkProduct2: juice.ID}
	db.Create(&alt1)

	mStock := Stock{PkProduct: milk.ID, Amount: 1}
	jStock := Stock{PkProduct: juice.ID, Amount: 9}
	db.Create(&mStock)
	db.Create(&jStock)

	var products []Product

	err := db.Preload("Stocks").Find(&products).Error
	if err != nil {
		log.Print(err)
	}
	for _, p := range products {
		fmt.Printf("%s stock is %f \n", p.Name, p.Stock)
	}

	// preload
	err = db.Preload("Stocks").Preload("Alternatives.Stocks").Find(&products).Error
	if err != nil {
		log.Print(err)
	}
	for _, p := range products {
		fmt.Printf("%s stock is %f \n", p.Name, p.Stock)
		for _, pp := range p.Alternatives {
			fmt.Printf("\talternative %s stock is %f \n", pp.Name, pp.Stock)
                        fmt.Printf("\talternative %s stock is %v \n", pp.Name, pp.Stocks)
			pp.AfterFind() // invoke AfterFind manually to prove it works
			fmt.Printf("\talternative %s stock is %f \n", pp.Name, pp.Stock)  // it works
		}
	}
}

[2019-03-14 10:11:51]  [0.06ms]  SELECT * FROM "products" INNER JOIN "alternatives" ON "alternatives"."pk_product2" = "products"."pk_product" WHERE ("alternatives"."pk_product" IN ('2','1'))
[0 rows affected or returned ]
2019/03/14 10:11:51 AfterFind for 2 // here the AfterFinds gets called for alternative product

[2019-03-14 10:11:51]  [0.07ms]  SELECT * FROM "stocks"  WHERE ("pk_product" IN ('2'))
[1 rows affected or returned ]  // but only here, after the nested preload is retrieved
2019/03/14 10:11:51 AfterFind for 1
2019/03/14 10:11:51 AfterFind for 2
Milk stock is 1.000000
        alternative Juice stock is 0.000000
        alternative Juice stock is [{2 2 {0 [] 0 [] } 9}]  //
2019/03/14 10:11:51 AfterFind for 2 // manual after find invoke
        alternative Juice stock is 9.000000 // value is set as it should be
Juice stock is 9.000000

@liepumartins Were you able to find a solution to this?

No, I did not find a solution.
Your approach is good for small sets of children types. Thank You!
However I still would like to see an universal solution, that does not require to manually loop through each slice of children.


DeepRacer notebook: fix Coach version and typos in text

Issue #, if available:
Description of changes:
Changed the version of Coach to 0.11.0 as 0.11.1 is not available yet. Fixed typos based on this pull request: https://github.com/awslabs/amazon-sagemaker-examples/pull/657
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adding changes to the TSP notebook to fix evaluation


Seems to be broken on the latest commits for webgui

And just another request.. could you support saving the last known settings chosen for everything in the script.. find myself often having to reclick and enter the same things for all the settings.. hopefully it can be supported.

About the title - what is broken?

the with the latest commits from https://github.com/AUTOMATIC1111/stable-diffusion-webui .. its got some errors come this addon.. sorry haven't got the errors on hand right now.. I rolled back to an older commit from 2days ago and its working again.

There were no less than 15 commits on the webui today, all connected to the samplers. Since this extension relies on k_diffusion, that has broken it for now. I'll see, if I can fix it.

oh right good luck.. would hate to lose it

Well, luckily the fix was a lot easier than I expected. I was even able to make it backward compatible...

 File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\call_queue.py", line 56, in f     res = list(func(*args, **kwargs))   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\call_queue.py", line 37, in f     res = func(*args, **kwargs)   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\txt2img.py", line 52, in txt2img     processed = process_images(p)   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\processing.py", line 487, in process_images     res = process_images_inner(p)   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\processing.py", line 629, in process_images_inner     samples_ddim = p.sample(conditioning=c, unconditional_conditioning=uc, seeds=seeds, subseeds=subseeds, subseed_strength=p.subseed_strength, prompts=prompts)   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\processing.py", line 829, in sample     samples = self.sampler.sample(self, x, conditioning, unconditional_conditioning, image_conditioning=self.txt2img_image_conditioning(x))   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\sd_samplers.py", line 544, in sample     samples = self.launch_sampling(steps, lambda: self.func(self.model_wrap_cfg, x, extra_args={   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\sd_samplers.py", line 447, in launch_sampling     return func()   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\modules\sd_samplers.py", line 544, in <lambda>     samples = self.launch_sampling(steps, lambda: self.func(self.model_wrap_cfg, x, extra_args={   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\venv\lib\site-packages\torch\autograd\grad_mode.py", line 27, in decorate_context     return func(*args, **kwargs)   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\repositories\k-diffusion\k_diffusion\sampling.py", line 148, in sample_euler_ancestral     callback({'x': x, 'i': i, 'sigma': sigmas[i], 'sigma_hat': sigmas[i], 'denoised': denoised})   File "C:\Projects\Stable_Diffusion\stable-diffusion-webui\extensions\sd_save_intermediate_images\scripts\sd_save_intermediate_images.py", line 400, in callback_state     if ssii_start_at_n % ssii_every_n == 0: ZeroDivisionError: float modulo

I still get that after trying the latest update

nevermind.. had to refresh browser tab aswel :)


irmin-pack: adapt to latest change in index (no more fan_out_size)

See https://github.com/mirage/index/pull/32

Thanks, fixed.


jQuery UI CSS conflict

There are conflicts with the jQuery-UI css file and our own that creates problems with the sliders and the datepicker.

Moved only the necessary CSS to style.less and removed jquery-ui.css to prevent clashes.


Paralellism default value is True

In the documentation it says that the default value to allow parallelism is False, but checking the code and commit history the default value is True.
It is necessary to adjust the documentation to be consistent with the code.
Code: https://github.com/serengil/chefboost/blob/5e1477af150d1dd16f9bc5e4a46acb3dc5f63ea8/chefboost/commons/functions.py#L85
README: https://github.com/serengil/chefboost/tree/5e1477af150d1dd16f9bc5e4a46acb3dc5f63ea8#paralellism

Merged the pull request. Thank you for your contribution.


Led series resistor value

Hi,
a 1.5k series resistor (R7, R8) for the led's seems a bit high. My led glow so low, that it's not visible during the date.
Is a value 470Ω, or even less not better?
How much is the signal from the Atmega328P 3V or 5V?
If i calculate the series resistor for a red led, it suggest's a 150Ω resistor.

Atmega328p run at 5V.
I think my leds is bright enough.
If they are changed to 470R or 150R, LEDs are brighter and shouldn't be broken.

First i bought led's with 60-100mcd and they were so low that you can't see them at daylight.
Then i bought some with 600-800mcd and they have a good glow.
Maybe it's worth to mention in the BOM.


TagHelper DI should come from constructor injection

Right now in order to get dependency injected material into TagHelpers you need to create a property and decorate it with [Activate]. We should change this to be constructor injection.

This will get handled as part of https://github.com/aspnet/Mvc/issues/2151.


experimental use of pg_basebackup to perform full backups

See also
https://github.com/wal-e/wal-e/issues/111
https://github.com/DataDog/wal-e/issues/1
https://github.com/wal-e/wal-e/pull/121
Not sure it's an waterproof solution but it kind of works in my tests.
Will do more tests coming weeks on acceptance, to see how reliable it is.

Any attention to this PR is very much appreciated.

Should probably just use WAL-G instead (#413)


Automated cherry pick of #2165: fix: 1. bucket purge fail 2. qcloud verify appId

Cherry pick of #2165 on release/2.11.
#2165: fix: 1. bucket purge fail 2. qcloud verify appId

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@2984e57). Click here to learn what that means.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##             release/2.11   #2166   +/-   ##
==============================================
  Coverage                ?    7.1%
==============================================
  Files                   ?     451
  Lines                   ?   70775
  Branches                ?       0
==============================================
  Hits                    ?    5029
  Misses                  ?   65334
  Partials                ?     412

Flag
Coverage Δ

#aFlag
7.1% <33.33%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/purge.go
0% <0%> (ø)

pkg/compute/models/buckets.go
2.08% <0%> (ø)

pkg/util/httputils/httputils.go
47.45% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2984e57...3ed3658. Read the comment docs.

/approve
/lgtm


[Feature request] Conceal x_\text{a} to xₐ

Right now x_\text{a} renders to x_a. Also x_{\text{a}} renders to x_{a}. Would it be possible to have both render to xₐ?

Added in 1.6.12!

thank you :)


how to receive the "message_id" displayed in the console (debug = True) in the webhook

I receive this json in the body :
{'audio': None, 'contact': None, 'document': None, 'forwarded': None, 'from'<EMAIL_ADDRESS>'image': None, 'list': None, 'live_location': None, 'location': None, 'message': 'Hola', 'order': None, 'sticker': None, 'video': None, 'view_once': None}
Debug Console :
<ack class="message" id="3A3F4B1D50958E3AA641"<EMAIL_ADDRESS>14:06:44.680 [Main INFO] Received message 3A3F4B1D50958E3AA641 from<EMAIL_ADDRESS>(pushname: Cohete, timestamp: 2023-02-16 14:06:44 -0500 -05): conversation:"Hola" messageContextInfo:{deviceListMetadata:{senderKeyHash:"1\xe7;6\xb9mʮ\xcf|" senderTimestamp:1676363087 recipientKeyHash:"D怿{)To\xd0$" recipientTimestamp:1676524241} deviceListMetadataVersion:2}

Great idea! I had forgotten to include the message_id in the webhook. I'll let you know once I have completed that.

updated here v4.5.1


New rule proposal: "Naming": All async methods should end with "Async".

All methods declared in source with an async modifier should end with "Async" in their name.
Most probably this should not fire on methods that just return Task or Task.

:-1: This is rule is already present in https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers and for me that is the correct place.

nice! Thanks for this link!
Agree, let's not duplicate work.


Fix Stack overflow in sql planning in debug builds

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/4065 from @andygrove
Closes https://github.com/apache/arrow-datafusion/issues/4728 from @Jefffrey
Also reported by @maxburke  in slack
Rationale for this change
Debug builds are overflowing the stack causing pain and suffering for users.
What changes are included in this PR?

Extract several parts of the body of SqlToRel::sql_expr_to_logical_expr into separate functions

The reason this reduces stack size in debug builds is explained in the "Technical Backstory" heading of https://github.com/apache/arrow-datafusion/pull/1047
Are these changes tested?
Covered by existing coverage
Are there any user-facing changes?
None intended (other than avoiding stack overflows)

https://github.com/apache/arrow-datafusion/actions/runs/3812581550/jobs/6485893384
😢  still overflows on windows
test tpcds_physical_q70 ... ok
test tpcds_physical_q71 ... ok
test tpcds_physical_q72 ... ok
test tpcds_physical_q73 ... ok

thread 'tpcds_physical_q64' has overflowed its stack
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`

Looks like q64 needs some more work -- will do so

I have one more PR that should avoid stack overflows while planning (SQL --> LogicalPlan) but then planning overflows at a later step -- see https://github.com/apache/arrow-datafusion/issues/4786


Display the size beside each tracker listed under filter by trackers.

Is your feature request related to a problem? Please describe.
The size can be displayed beside each tracker listed under filter by trackers in the same way as in the flood web app.
Describe the solution you'd like
Display the size beside each tracker listed under filter by trackers.
Additional context

Shall I take this issue? I will be able to do it.

@ManavSarkar assigning this issue to you.

@ManavSarkar is there any update on the your progress while resolving this issue?

Hi, the TorrentModel file has the detail of the size of the torrents. Now should I add the List of sizes in the FilterProvider.

@ The feature has been added. Kindly check my previous PR so that I can add it as soon as possible.


WIP: QUIC v1

This adds support for QUIC v1, while keeping support for current draft versions.
We shouldn't merge/deploy this yet, but can be useful to start testing interop.
(I had the test vectors change already made to test https://github.com/quicwg/base-drafts/pull/4431, so might as well finish this up)

An alternative to not merging could be adding a feature to optionally enable v1 at build time, though might end up being too messy...

An alternative to not merging could be adding a feature to optionally enable v1 at build time, though might end up being too messy...


Add possibility to connect/disconnect lines

Currently if you need to connect/disconnect lines you have to connect/disconnect each node manually. It would be nice to have a possibility to do that easier.
For example to connect lines you connect the first node and drag and drop the last node while holding Shift key and the nodes in between would get connected.
The same applies for when drawing a new line over an existing one, i.e. you click on the first node and then click on the last node while holding Shift key and connected nodes in between would get created.
To disconnect lines you select the first connected node and click on the last connected node while holding Shift key and the nodes in between would get disconnected.

I think what you're describing is covered in #1614


batch event queue results back to channel

Current dependencies on/for this PR:

main

PR #103

PR #102

PR #126   👈
PR #111
PR #109

This comment was auto-generated by Graphite.


oidc-gatekeeper locked on CrashLoopBackOff

I've just tried to install KubeFlow on MicroK8s acordding  Canonical guide found here https://ubuntu.com/kubeflow/install.
Pod idc-gatekeeper never started and stay in CrashLoopBackOff.
I've tried this with Ubuntu Server 20.04 and 18.04 and the results are the same.
Here the details gathered:
microk8s.kubectl get po --all-namespaces
NAMESPACE         NAME                                           READY   STATUS             RESTARTS   AGE
kube-system       kubernetes-dashboard-7ffd448895-nvg7s          1/1     Running            3          29m
kube-system       calico-kube-controllers-847c8c99d-977dn        1/1     Running            3          31m
kube-system       dashboard-metrics-scraper-6c4568dc68-lf8vz     1/1     Running            3          29m
kube-system       nvidia-device-plugin-daemonset-dc7fk           1/1     Running            2          27m
kube-system       calico-node-rp4pz                              1/1     Running            4          31m
kube-system       hostpath-provisioner-5c65fbdb4f-dnm9p          1/1     Running            3          29m
kube-system       metrics-server-8bbfb4bdb-rkxd4                 1/1     Running            3          29m
kube-system       coredns-86f78bb79c-pd2tp                       1/1     Running            3          30m
ingress           nginx-ingress-microk8s-controller-qwcv7        1/1     Running            0          21m
metallb-system    speaker-pvtzs                                  1/1     Running            0          21m
metallb-system    controller-559b68bfd8-vps94                    1/1     Running            0          21m
controller-uk8s   controller-0                                   2/2     Running            1          20m
kubeflow          ambassador-operator-0                          1/1     Running            0          19m
kubeflow          argo-controller-operator-0                     1/1     Running            0          19m
kubeflow          argo-ui-operator-0                             1/1     Running            0          19m
kubeflow          dex-auth-operator-0                            1/1     Running            0          19m
kubeflow          jupyter-controller-operator-0                  1/1     Running            0          18m
kubeflow          argo-ui-78dfc9744-b9tcg                        1/1     Running            0          19m
kubeflow          ambassador-656dd8bf4-5cgcm                     1/1     Running            0          19m
kubeflow          jupyter-controller-66d9c5664b-tr4z8            1/1     Running            0          18m
kubeflow          katib-db-operator-0                            1/1     Running            0          18m
kubeflow          jupyter-web-operator-0                         1/1     Running            0          18m
kubeflow          katib-db-manager-operator-0                    1/1     Running            0          18m
kubeflow          katib-controller-operator-0                    1/1     Running            0          18m
kubeflow          katib-ui-operator-0                            1/1     Running            0          18m
kubeflow          kubeflow-profiles-operator-0                   1/1     Running            0          18m
kubeflow          kubeflow-dashboard-operator-0                  1/1     Running            0          18m
kubeflow          metacontroller-operator-0                      1/1     Running            0          18m
kubeflow          metadata-api-operator-0                        1/1     Running            0          17m
kubeflow          metadata-envoy-operator-0                      1/1     Running            0          17m
kubeflow          metadata-db-operator-0                         1/1     Running            0          17m
kubeflow          katib-ui-6764bfd7bc-jsjb4                      1/1     Running            0          17m
kubeflow          katib-db-0                                     1/1     Running            0          18m
kubeflow          katib-controller-6ffd875f77-pljfc              1/1     Running            0          17m
kubeflow          pipelines-persistence-operator-0               1/1     Running            0          17m
kubeflow          pipelines-scheduledworkflow-operator-0         1/1     Running            0          16m
kubeflow          pipelines-viewer-operator-0                    1/1     Running            0          16m
kubeflow          metacontroller-6d9d9696bd-2vgrq                1/1     Running            0          17m
kubeflow          oidc-gatekeeper-operator-0                     1/1     Running            0          16m
kubeflow          metadata-db-0                                  1/1     Running            0          17m
kubeflow          metadata-ui-operator-0                         1/1     Running            0          16m
kubeflow          minio-operator-0                               1/1     Running            0          16m
kubeflow          katib-db-manager-7cc8597b4d-8p64h              1/1     Running            0          17m
kubeflow          pipelines-db-operator-0                        1/1     Running            0          16m
kubeflow          pipelines-api-operator-0                       1/1     Running            0          16m
kubeflow          pipelines-ui-operator-0                        1/1     Running            0          16m
kubeflow          pipelines-visualization-operator-0             1/1     Running            0          16m
kubeflow          pytorch-operator-operator-0                    1/1     Running            0          16m
kubeflow          metadata-grpc-operator-0                       1/1     Running            0          15m
kubeflow          seldon-core-operator-0                         1/1     Running            0          15m
kubeflow          tf-job-operator-operator-0                     1/1     Running            0          15m
kubeflow          jupyter-web-784c8774d5-dfhqd                   1/1     Running            0          17m
kubeflow          pipelines-db-0                                 1/1     Running            0          15m
kubeflow          kubeflow-dashboard-5f57644995-clzwr            1/1     Running            0          17m
kubeflow          kubeflow-profiles-646d5d646f-72thv             2/2     Running            0          17m
kubeflow          metadata-api-5bfdcd776d-wn6z2                  1/1     Running            0          17m
kubeflow          pipelines-scheduledworkflow-76568f476c-w66lv   1/1     Running            0          16m
kubeflow          pipelines-viewer-6ffb7b9cf4-ggnn5              1/1     Running            0          16m
kubeflow          minio-0                                        1/1     Running            0          16m
kubeflow          dex-auth-dc6d7d996-kpqdz                       1/1     Running            0          15m
kubeflow          pytorch-operator-7b6448bb87-27h99              1/1     Running            0          14m
kubeflow          pipelines-visualization-74c8796b7f-56bq5       1/1     Running            0          15m
kubeflow          argo-controller-876844c7b-gqp4g                1/1     Running            0          15m
kubeflow          metadata-ui-55b6498cd4-h5fsp                   1/1     Running            0          14m
kubeflow          pipelines-persistence-848b5bff5-b59c9          1/1     Running            2          14m
kubeflow          pipelines-ui-6894ddf96d-d9jx8                  1/1     Running            0          14m
kubeflow          tf-job-operator-5f54dfb5b6-jd89b               1/1     Running            0          14m
kubeflow          metadata-grpc-7fd4bc757b-4k92p                 1/1     Running            0          14m
kubeflow          metadata-envoy-6cfdf75d5f-fp7bv                1/1     Running            0          13m
kubeflow          seldon-core-7fc9b755cf-p2lng                   1/1     Running            0          13m
kubeflow          oidc-gatekeeper-774f6d8997-2t7wm               0/1     CrashLoopBackOff   6          16m     (********* error here)
kubeflow          pipelines-api-6696896c7-7cszp                  1/1     Running            0          13m
microk8s.kubectl describe pod oidc-gatekeeper-774f6d8997-2t7wm --namespace kubeflow
Name:         oidc-gatekeeper-774f6d8997-2t7wm
Namespace:    kubeflow
Priority:     0
Node:         kubeflow-u1805/<IP_ADDRESS>
Start Time:   Sat, 14 Nov 2020 17:47:28 -0500
Labels:       juju-app=oidc-gatekeeper
pod-template-hash=774f6d8997
Annotations:  apparmor.security.beta.kubernetes.io/pod: runtime/default
cni.projectcalico.org/podIP: <IP_ADDRESS>/32
cni.projectcalico.org/podIPs: <IP_ADDRESS>/32
juju.io/controller: d0d6bfd7-2457-4c3e-84a5-6d70991f0497
juju.io/model: 273b24f9-7a3f-4a6c-8f4f-833967c046a7
juju.io/unit: oidc-gatekeeper/0
seccomp.security.beta.kubernetes.io/pod: docker/default
Status:       Running
IP:           <IP_ADDRESS>
IPs:
IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/oidc-gatekeeper-774f6d8997
Init Containers:
juju-pod-init:
Container ID:  containerd://709611cf334fa3850851cc41102c7e000302f267a3150f906cae4a3847121033
Image:         jujusolutions/jujud-operator:2.7.6
Image ID:      docker.io/jujusolutions/jujud-operator@sha256:866eccf1961604db3a4710142f77632519c6627da7ebdebd26c8c17c03df48e6
Port:
Host Port:
Command:
/bin/sh
Args:
-c
export JUJU_DATA_DIR=/var/lib/juju
export JUJU_TOOLS_DIR=$JUJU_DATA_DIR/tools
  mkdir -p $JUJU_TOOLS_DIR
  cp /opt/jujud $JUJU_TOOLS_DIR/jujud
  initCmd=$($JUJU_TOOLS_DIR/jujud help commands | grep caas-unit-init)
  if test -n "$initCmd"; then
  $JUJU_TOOLS_DIR/jujud caas-unit-init --debug --wait;
  else
  exit 0
  fi

State:          Terminated
  Reason:       Completed
  Exit Code:    0
  Started:      Sat, 14 Nov 2020 17:47:32 -0500
  Finished:     Sat, 14 Nov 2020 17:47:43 -0500
Ready:          True
Restart Count:  0
Environment:    <none>
Mounts:
  /var/lib/juju from juju-data-dir (rw)
  /var/run/secrets/kubernetes.io/serviceaccount from default-token-9pbdp (ro)

Containers:
oidc-gatekeeper:
Container ID:   containerd://c3d56633318b35977fb4284b772d3e466a562036e5cae87c32652e2de97a7429
Image:          registry.jujucharms.com/kubeflow-charmers/oidc-gatekeeper/oci-image@sha256:9bb01f793655259071763219c4ef34ebd01953d742b28afba8361c68bf9e3235
Image ID:       registry.jujucharms.com/kubeflow-charmers/oidc-gatekeeper/oci-image@sha256:9bb01f793655259071763219c4ef34ebd01953d742b28afba8361c68bf9e3235
Port:           8080/TCP
Host Port:      0/TCP
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       Error
Exit Code:    1
Started:      Sat, 14 Nov 2020 18:09:14 -0500
Finished:     Sat, 14 Nov 2020 18:09:14 -0500
Ready:          False
Restart Count:  8
Environment:
CLIENT_ID:         authservice-oidc
CLIENT_SECRET:     VGX0VF150TTQ26EBRFPYXPI8D8WZGB
DISABLE_USERINFO:  true
OIDC_PROVIDER:     /dex
OIDC_SCOPES:       profile email groups
REDIRECT_URL:      /oidc/login/oidc
SELF_URL:          /oidc
SERVER_PORT:       8080
STORE_PATH:        bolt.db
USERID_HEADER:     kubeflow-userid
USERID_PREFIX:
Mounts:
/usr/bin/juju-run from juju-data-dir (rw,path="tools/jujud")
/var/lib/juju from juju-data-dir (rw)
/var/run/secrets/kubernetes.io/serviceaccount from default-token-9pbdp (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
juju-data-dir:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
default-token-9pbdp:
Type:        Secret (a volume populated by a Secret)
SecretName:  default-token-9pbdp
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type     Reason     Age                   From               Message

Normal   Scheduled  24m                   default-scheduler  Successfully assigned kubeflow/oidc-gatekeeper-774f6d8997-2t7wm to kubeflow-u1805
Normal   Pulled     24m                   kubelet            Container image "jujusolutions/jujud-operator:2.7.6" already present on machine
Normal   Created    24m                   kubelet            Created container juju-pod-init
Normal   Started    24m                   kubelet            Started container juju-pod-init
Normal   Pulling    23m                   kubelet            Pulling image "registry.jujucharms.com/kubeflow-charmers/oidc-gatekeeper/oci-image@sha256:9bb01f793655259071763219c4ef34ebd01953d742b28afba8361c68bf9e3235"
Normal   Pulled     18m                   kubelet            Successfully pulled image "registry.jujucharms.com/kubeflow-charmers/oidc-gatekeeper/oci-image@sha256:9bb01f793655259071763219c4ef34ebd01953d742b28afba8361c68bf9e3235" in 5m16.048310112s
Normal   Started    18m (x4 over 18m)     kubelet            Started container oidc-gatekeeper
Normal   Pulled     17m (x4 over 18m)     kubelet            Container image "registry.jujucharms.com/kubeflow-charmers/oidc-gatekeeper/oci-image@sha256:9bb01f793655259071763219c4ef34ebd01953d742b28afba8361c68bf9e3235" already present on machine
Normal   Created    17m (x5 over 18m)     kubelet            Created container oidc-gatekeeper
Warning  BackOff    3m59s (x69 over 18m)  kubelet            Back-off restarting failed container
microk8s.kubectl logs oidc-gatekeeper-774f6d8997-2t7wm --namespace kubeflow
time="2020-11-14T23:09:14Z" level=fatal msg="Failed to parse configuration: required key AUTHSERVICE_URL_PREFIX missing value"
According to logs there is some kind of AUTHSERVICE key missing.
By the way both installations on Ubuntu Server 20.04 and 18.04 just started 28 pods instead of the 34 display here https://www.youtube.com/watch?v=KPEGKKNB63Q&t=447s
Definitely something is missing.
Please review the issue as this is a mayor blocker that prevent the usage of KubeFlow.
Thanks in advance.

Exactly the same problem.
heapster-v1.5.2 and nvidia-device-plugin-daemonset also showed problems but are now up.
ALL of the pods have had at least 2 restarts, but are currently up.
Configuration:
Ubuntu 18.04.3 LTS Clean install
INTEL NUC 8i5BEH w 8259 CPU (4+4 threads), 32GB RAM, 500GB Samsung EVO, NVIDIA-Driver 460 and Nvidia 1080 connected via Thunderbolt 3 to hp OMEN Accelerator.

Exactly the same problem.
heapster-v1.5.2 and nvidia-device-plugin-daemonset also showed problems but are now up.
ALL of the pods have had at least 2 restarts, but are currently up.
Configuration:
Ubuntu 18.04.3 LTS Clean install
INTEL NUC 8i5BEH w 8259 CPU (4+4 threads), 32GB RAM, 500GB Samsung EVO, NVIDIA-Driver 460 and Nvidia 1080 connected via Thunderbolt 3 to hp OMEN Accelerator.

@apulache, @BionixAB: This issue should now be fixed with the latest version of MicroK8s. Can you refresh (sudo snap refresh microk8s --channel latest/edge), and try again?

@apulache, @BionixAB: This issue should now be fixed with the latest version of MicroK8s. Can you refresh (sudo snap refresh microk8s --channel latest/edge), and try again?

This issue should be fixed by now and will therefore be closed.
If you are able to reproduce this in the latest microk8s release and the issue is still relevant feel free to reopen it.


Really update for 0.15

Further testing revealed that changes were not compatible with Chrome. I reverted changes back to the previous version. This seems to be more robust, as examples are now working in both Firefox and Chrome.
Apologies for the faulty PR!
Examples are updated in aforemny/elm-lang.org@1756758.

Should the error type match the HTTP errors from elm-http? I don't have a strong intuition for this.

I think it should not necessarily, because this patch does not use the elm-http module nor XMLHttpRequest.
I will find out more about Javascript's Image.onerror function and make the WebGL's error type more expressive.

I cannot find any documentation on JavaScript's Image.onerror function. I read somewhere that implementation is browser specific, so I'm tending to leave Error an opaque type.
In practice I cannot chain WebGL.loadTexture tasks with Http tasks because they differ on the error type. I found the solution load WebGL and Http resources in separate tasks OK and one could work around that with Task.onError.
I'd appreciate any suggestion. Otherwise I think this should be merged, as it works better than my previous "fix". :)

Yep, will need to wait for blob support to use the standard Http error types


Add new settings command

Description:
Requested partially by #bso-vote:

Allow users to edit certain bitfields they own;
Users can enable or disable the gorajan bonecrusher (Defaults to enabled).

Changes:

Add a new command called =settings that can be used to enable or disable user BFs, without requiring mods to do so.
Add a new BitField called DisableGorajanBonecrusher.

Other checks:

[X] I have tested all my changes thoroughly.

--help or no parameter will show this

This seems like something that should be going to OSB first, small bank is in both bots isnt it? plus we might want to add osb things to it anyway


Serialized names of properties are needed in the shared models in Azure.ResourceManager in order to unblock test generator

In our test generator, we will have the raw json of a real payload, and to generate the test cases, we need to build some expression of class initialization from that raw json. Since the json payload is the serialization result of one class, we need to have a way to get the serialized name of a property in order to get the value in the payload.
This works well for all the models generated in this SDK because the code model stores the serialized names of properties.. But this has issues if one class gets replaced by a shared model from Azure.ResourceManager.
We also need to construct those classes from the payload, but there is not a very simple way to get the serialized name of the properties. (Similar in this issue)
A possible solution is that we could use attribute to mark the serialized names on the properties in Azure.ResourceManager models.

We decide to add a mapping of the serialized names inside mgmt target.
Anytime we add a new shared model to resourcemanager, we need to add the new mappings as well


Implement allow_force_rerun for once

Question - would .reset() semantics be cleaner? I feel that would be more flexible


[openbsd] Improve format, eol estimation

https://github.com/endoflife-date/endoflife.date/edit/master/products/openbsd.md

Reformat using Style Guide from https://github.com/endoflife-date/endoflife.date/wiki/Style-Guide
Comment for eol estimation on top of releases for future reference, e.g.
# eol(x) = releaseDate(x+2), Estimation releaseDate(x) + 1 year -> round to first of next month
Mark estimated eol dates, e.g.
eol: 2024-11-01 # estimated from releaseDate: 2023-10-16

Hi @BiNZGi ,
If no one has been assigned yet, I'd appreciate the chance to contribute to it.

hi @BiNZGi,
I've created a pr for this issue -> #3988
Do check it out.


Implement default value for --file

closes #349

tested manually; works as expected.
><> spin bindle push
error: The following required arguments were not provided:
    --bindle-server <BINDLE_SERVER_URL>

USAGE:
    spin bindle push [FLAGS] [OPTIONS] --bindle-server <BINDLE_SERVER_URL>

For more information try --help
><> spin bindle push --bindle-server http://localhost:8080/v1
pushed: spin-hello-world/1.0.0


Add Testcase/case conversion

some test code of case conversion(upper, lower, initCapped)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

74 of 76 (97.37%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 98.967%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test-suite/src/ast_builder/function/text/case_conversion.rs
74
76
97.37%

Files with Coverage Reduction
New Missed Lines
%

core/src/ast/mod.rs
1
99.83%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
44549

Relevant Lines:
45014

💛  - Coveralls


Private source authentication (was working last week)

This job was working fine last week and no changes were made, however it is now failing with:
To use retry middleware with Faraday v2.0+, install faraday-retry gem
/home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker/latest_version_finder.rb:319:in check_npm_response': The following source could not be reached as it requires authentication (and any provided details were invalid or lacked the required permissions): https://pkgs.dev.azure.com/BC-SDPR-Research/_packaging/Research/npm/registry/ (Dependabot::PrivateSourceAuthenticationFailure) 	from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker/latest_version_finder.rb:276:in npm_details'
from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker/latest_version_finder.rb:108:in valid_npm_details?' 	from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker/latest_version_finder.rb:36:in latest_version_from_registry'
from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker.rb:294:in latest_released_version' 	from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker.rb:319:in latest_version_details'
from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker.rb:39:in latest_version' 	from /home/dependabot/dependabot-script/.bundle/gems/dependabot-common-0.213.0/lib/dependabot/update_checkers/base.rb:231:in numeric_version_up_to_date?'
from /home/dependabot/dependabot-script/.bundle/gems/dependabot-common-0.213.0/lib/dependabot/update_checkers/base.rb:189:in version_up_to_date?' 	from /home/dependabot/dependabot-script/.bundle/gems/dependabot-common-0.213.0/lib/dependabot/update_checkers/base.rb:33:in up_to_date?'
from /home/dependabot/dependabot-script/.bundle/gems/dependabot-npm_and_yarn-0.213.0/lib/dependabot/npm_and_yarn/update_checker.rb:27:in up_to_date?' 	from ./update-script.rb:332:in block in '
from ./update-script.rb:310:in each' 	from ./update-script.rb:310:in '
GitHub access token has been provided.
Using hostname = 'dev.azure.com', protocol = 'https', port = '443'.
Using 'https://dev.azure.com:443/' as API endpoint
Pull Requests shall be linked to milestone (work item) 3499
Fetching npm_and_yarn dependency files for (our registry)
Targeting 'develop' branch under '/' directory
Parsing dependencies information
Checking if @babel/runtime 7.20.1 needs updating
No update needed for @babel/runtime 7.20.1
Checking if @research/react-app-cards 1.0.0 needs updating
##[error]The process '/usr/bin/docker' failed with exit code 1
Finishing: Run Dependabot - dtes
OUR Pipeline is as defined below. NOTE: This was working last week and no changes were made
schedules:

cron: "0 4 * * SAT"
displayName: 'Weekly Run'
always: true
branches:
include:
- 'main'
trigger: none
pool:
vmImage: 'ubuntu-latest'
variables:
DEPENDABOT_EXTRA_CREDENTIALS: '[{"type":"npm_registry","token":"$(DEPENDABOT_PAT)","registry":"$(NPM_REG)"}]' # put the credentials for private registries and feeds
stages:
stage: Dtes
jobs:

job: DependabotDtes
steps:

task: Cache@2
inputs:
key: docker | "$(IMAGETOCACHE)"
path: $(Pipeline.Workspace)/docker
cacheHitVar: DOCKER_CACHE_HIT
displayName: Cache Docker images
script: |
docker load -i $(Pipeline.Workspace)/docker/cache.tar
displayName: Restore Docker image
condition: and(not(canceled()), eq(variables.DOCKER_CACHE_HIT, 'true'))
script: |
mkdir -p $(Pipeline.Workspace)/docker
docker pull -q $(IMAGETOCACHE)
docker save -o $(Pipeline.Workspace)/docker/cache.tar $(IMAGETOCACHE)
displayName: Save Docker image
condition: and(not(canceled()), or(failed(), ne(variables.DOCKER_CACHE_HIT, 'true')))
task: dependabot@1
displayName: 'Run Dependabot - dtes'
inputs:
useConfigFile: true
setAutoComplete: false
azureDevOpsAccessToken: $(DEPENDABOT_PAT)
gitHubAccessToken: $(GITHUB_TOKEN)

Varibales:
IMAGETOCACHE = tingle/dependabot-azure-devops:latest
NPM_REG = our npm registry
Please let me know any suggestions, thank you.

I’ve got the same issue :-/

What's the value of NPM_REG?

NPM_REG is the research:registry in npmrc
https://pkgs.dev.azure.com/OUR_ORGANIZATION/_packaging/Research/npm/registry/
Thanks!

NOTE: When specifying a different dependabot tag, (0:7) the originally defined pipeline runs fine

The updated dependabot image (0:10) has resolved the issue. Can close this issue.
Thank you for your help


typo: analisys -> analysis

@tfosmark : Thanks for your contribution! The author, @, has been notified to review your proposed change.


Refactored logic in APIClient init

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

I split the logic for setting up accounts in the init method into 2 separate methods. I also added the instance of HttpClient to the JOSS account used for public containers.

@djalova can you please update this branch with latest master? thanks


The order of the actions between the attached file shares and other three attached services is inconsistent

Storage Explorer Version: 1.33.0-dev (96)
Build Number: 20240112.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.2(Apple M1 Pro)
Architecture: x64/x64/x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Attach the blob container via SAS URL.
Right click the attached blob container -> Observe its context menu.
Create a file share -> Attach the file share via SAS URL.
Right click the attached file share -> Observe its context menu.
Check whether the order of the actions between the two attached services is consistent.

Expected Experience
The order of the actions is consistent.
Actual Experience
The order of the actions is inconsistent.

Additional Context
Here is the screenshot for attached tables/queues.

Verified this issue on the build 20240328.5. Fixed.


Add legend

It would be nice to have a legend for the terms used, or some optional way to supply a legend.
e.g.
 legend right
 <#GhostWhite,#GhostWhite>|        |= __Legend__ |
 |<color:goldenrod> (PK) </color>| Primary Key |
 |<color:701fc6> (FK) </color>| Foreign Key |
 |<color:DarkRed> (NN) </color>| Not Null |
 endlegend

Hi @jayvdb.
I think we can add a CLI flag --legend with such description.
I will do it  when I have a chance


SIGINT forwarding to a running subprocess

When the running task is something infinite, let's say a web server, we should
be able to terminate it cleanly. To do that, we must forward the stop signal
to the subprocess. Previously the signal was caught by Poe, which is not desirable.

This PR makes sure, that you can stop poe tasks by Ctrl+C. I run into it when runnning a web server. I got a poe stacktrace instead of my projects stacktrace. This should fix it. Hope you like it. :slightly_smiling_face:

Can't speak for the code, but I hope this gets merged!


exp: remove chains, vectorstores, documentloaders and examples

PR Checklist
This removes the chains, vectorstores and documentloaders packages that have been implemented outside of the exp directory and adopts the new chain package in exp/agents. This also changes the prompts package by not returning a pointer and error in "NewPromptTemplate".

[x] Read the Contributing documentation.
[x] Read the Code of conduct documentation.
[x] Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Describes source of new concepts.
[x] References existing implementations as appropriate.
[x] Contains test coverage for new functions.
[x] Passes all golangci-lint checks.
[x]  I am an existing contributor.

These lint errors are odd and seem like they may go away after we merge (removing the exp code). Merging.


Allow authentication and ssl connection

I took the fix from @bradhandy to allow ssl connection and authentication.
refactored it somewhat, added tests for the configuration and updated the doc..
please note that there are multiple ways to specify the ssl values:

directly in your application.conf
via an included secondary conf (typesafe config allows include)
via JVM system properties [http://docs.oracle.com/javase/6/docs/technotes/guides/security/jsse/JSSERefGuide.html#CustomizingStores]

SSL and auth are completely optional.
BTW: thanks for taking over the development with actual releases..
Justin

👍

👍

Good stuff, LGTM! 👍

Yep, LGTM, too.
Thx @ all  :)
I let the ConnectionConfiguration unchanged for the time being.
Cheers,
Robert


Use latest podman in action

Import from https://github.com/kachick/dotfiles/pull/490

Ah...currently using only buildah


Enable CUPTI to measure kernel execution time instead of CUDA Events

CUDA events suffer from low accuracy and include the kernel launch overhead. On the other hand, CUPTI provides a more reliable way to get consistent timing measurement.
This request asks to add an option to replace CUDA Events with CUPTI.
Details
CUDA events issues:

Accuracy and Stability:

cudaEvent can fluctuate in the range of 10-30us, making measurements of small computations unreliable
cudaEvent take into account the kernel launch overhead that depends on host/CPU execution and/or driver version

CUPTI:

~0.5us granularity vs. 10-30us
Not affected by kernel launch overhead
Consistency: measurements close to the profiler (nsys)
Efficiency: avoid using waiting/delay kernels to hide CPU overhead

We do mitigate a lot of the issues with events by using blocking_kernels, so it's not quite as bad as it seems. I think this would be a great addition, I'm curious how much this would improve the stability of our results, especially when sync tags are used.


Terminal

Issue Type: Bug
When the terminal is opened, flickering occurs and indents increase. You can see how in the screenshot.
VS Code version: Code 1.40.2 (f359dd69833dd8800b54d458f6d37ab7c78df520, 2019-11-25T14:54:45.096Z)
OS version: Windows_NT x64 10.0.17763

Looks like you are using pretty old version 1.40. Could you update to latest stable 1.42 or better insiders 1.43 and check if it is still reproducible.

This is a bug in Windows 10 1809, unfortunately we have no way to work around the issue so you will need to wait until you get the next version of Windows 10 (1903).
/duplicate https://github.com/Microsoft/vscode/issues/57803


Please help with daily batch loading of TTLs

Very sorry to open this as an issue since it might just me being an inept novice.
My knowledge extraction processes generate new RDF triples serialized to Turtle format (*ttl files.) every day and so I need to add the new triples daily to the existing graph.
I currently load the graph with the following command:
docker exec bc89541add49 ./bin/s-put http://localhost:3030/mema_v5 'default' /fuseki-base/databases/mema_ttls/all/20230722_all.ttl
this container is started from the fuseki-secoresearch-4.8.0 image
and this works well. But the day after when I use the same command with the new TTL file, the RDF TDB store only has these last triples.
Reading Jena's documentation I think I should/could use something like
tdb2.tdbloader --tdb ../../apache-jena-fuseki/run/configuration/test1.ttl furniture.ttl
or perhaps another utility called 'riot' but I am unable to find either inside the container and am too ignorant about docker to understand how to proceed. Would be grateful for any help.

I did find a /jena/bin/tdbloader2 executable in the container but running it just gives the following message:
tdbloader2 has been renamed tdb1.xloader

Thanks for the question.
If you wish to add data into an existing graph, you should use s-post instead of s-put (s-put replaces the graph's current data with the triples in the file provided).
As you suggested, you can also use tdbloader to load data into a TDB database. Note that when using tdbloader, you shouldn't have a running Fuseki instance using the same database, as "A TDB dataset should only be directly accessed from a single JVM at a time otherwise data corruption may occur.". See https://jena.apache.org/documentation/tdb/commands.html.
Yes, tdbloader2 has been apparently renamed tdb1.xloader, which is not currently included in this secoresearch/fuseki image (please do make an issue to request it if you wish!). However, tdbloader is included. See an example on using that:
https://github.com/SemanticComputing/congress-legislators/blob/master/Dockerfile.
Also, it should be noted that "xloader is not a replacement for regular TDB1 and TDB2 loaders. It is for very large datasets.". See https://jena.apache.org/documentation/tdb/tdb-xloader.html.


Fix project card to show virtual project challenges

Cards for virtual projects were not showing challenges

Change 'add challenge' button in ChallengeList to show
as 'Manage Challenge List' in case of virtual project

Add 'virtual' indicator to project card

Note that project cards for virtual projects will not show their challenges until maproulette/maproulette2#555 is merged in on the backend.


[FUSETOOLS2-1794] Fixed problems found with npm audit

This upgrades to version 1.2.6 to avoid a critical severity vulnerability as stated by npm audit

As Aurelien has commentated on the ticket, it doesn't make much sense to fix it here. It's better to have it fixed upstream.
Current versions of mkdirp already have upgraded the minimist package to avoid this vulnerability, but seems like mocha-jenkins-reporter hasn't upgraded yet. There is a PR from Aurelien from July fixing this:
https://github.com/juhovh/mocha-jenkins-reporter/pull/105
I'll be closing this ticket on the meanwhile


refactor mount list file implementation to use a google protocol buffers implementation instead of picoJSON

Google protocol buffer is the standard mechanism within Mesos for rendering and passing configuration and parameters. It is likely to better handle versioning and schema definition.

https://github.com/emccode/mesos-module-dvdi/commit/81fbbae1876521ec1c1a36bee43ba11c4a6b9dbe


Alternate MP4Handler Fix with hxCodec 2.6.1

What feature do you want to get added on the base engine?
This is an extremely easy fix where you have to replace import vlc.MP4Handler; with import hxcodec.VideoHandler; and any instance of "MP4Handler" with "VideoHandler".
You don't need to keep hxCodec 2.5.1, especially when the current version (2.6.1) has additional features, such as macOS support. I tested it in my Lunar Engine fork, and it works well.
hxCodec (2.6.1)
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

There's a pr in the works but it's WIP
https://github.com/ShadowMario/FNF-PsychEngine/pull/11720

hxCodec creator here,
Why not use the latest version (v2.6.1)?
It may require changing the code but it's worth it considering the new changes made to the library.

it has been fixed

it has been fixed

Yes, but this fix would also allow videos to play on macOS. HxCodec 2.5.1 doesn't support macOS.

it has been fixed

Yes, but this fix would also allow videos to play on macOS. HxCodec 2.5.1 doesn't support macOS.

I meant that it was already updated on the latest psych version


Very strange and unreproduceable token mismatch?

🔎 Search Terms
token mismatch, syntax highlighting
🕗 Version & Regression Information
I tested with latest 5.0, 5.1, and 5.2 and it happens with all of them.
⏯ Playground Link
No response
💻 Code
import { ElectronAPI } from "@electron-toolkit/preload";

declare global {
    interface Window {
        electron: ElectronAPI;
        api: unknown;
    }
}

🙁 Actual behavior
https://github.com/microsoft/TypeScript/assets/20448879/d6d675c9-0576-4572-b9d8-fbd31d17d124
I have this file in my project that does this and it looks like a sourcemap / token map mismatch / offset or something.
🙂 Expected behavior
The tokens should be mapping to their respective reflections like in this playground
Additional information about the issue
I can't reproduce this in another file it just keeps happening in this specific file in this specific project. I can reproduce it if I copy the project and install the dependencies, so if someone wants to investigate it I can add you to a repository with the code.

I didn't notice this before but this bug actually causes the file to not extend the Window interface. Window["api"] does not exist until I rename index.d.ts to something else (like globals.d.ts). This is my tsconfig.json for clarity:
{
  "extends"<EMAIL_ADDRESS>  "include": [
    "src/renderer/src/env.d.ts",
    "src/renderer/src/**/*",
    "src/renderer/src/**/*.svelte",
    "src/preload/*.d.ts"
  ],
  "compilerOptions": {
    "verbatimModuleSyntax": true,
    "useDefineForClassFields": true,
    "strict": false,
    "allowJs": true,
    "checkJs": true,
    "lib": ["ESNext", "DOM", "DOM.Iterable"]
  },
  "references": [{ "path": "./tsconfig.node.json" }]
}

We'll definitely need a way to repro this. Strange.

I remembered what template I was using, and it's enough to reproduce it out of the box:
pnpm create @quick-start/electron app-test --template=svelte-ts
cd app-test
pnpm i
code . src/preload/index.d.ts
# wait for ts-server to be done and see weird stuff

Weird, it's wrong but differently-wrong on my machine

This is specific to semantic highlighting

For me it goes a little farther than semantic highlighting. Can you try to do window.api; in preload/index.ts? For me it errors until I rename index.d.ts to something else like real.d.ts

This seems to be because of the index.ts right next to the index.d.ts. If I hover over the ElectrornAPI in the import, it shows the info of contextBridge, which only exists in the index.ts file.

I have investigated this issue and the cause seems to be a problem where tsserver is attempting to retrieve the highlights for index.d.ts, but instead returns the semantic highlighting for index.ts. This issue goes away by adding "disableSourceOfProjectReferenceRedirect": true, to the tsconfig, so I will be request @sheetalkamat to take a look at this
Here is the smallest repro I was able to get:
// app-test/src/index.d.ts
declare global {
    interface Window {
      electron: ElectronAPI
      api: unknown
    }
}

// app-test/src/index.ts
const api = {}

// app-test/tsconfig.json
{
    "include": [
      "src/*.d.ts"
    ],
    "compilerOptions": {
    },
    "references": [{ "path": "./tsconfig.node.json" }]
}

// app-test/tsconfig.node.json
{
    "include": ["src/**/*"],
    "compilerOptions": {
      "composite": true,
    }
}

The incorrect highlighting happens in index.d.ts in the space between e g in declare global:

I also noticed that the same thing happens with completionInfo, definitionAndBoundSpan`, and possibly others. Here are example tsserver logs for all three I found:
Info 122  request:
    {
      "seq": 33,
      "type": "request",
      "command": "documentHighlights",
      "arguments": {
        "file": "c:\\test-semantic-highlighting-no-electron\\app-test\\src\\index.d.ts",
        "line": 1,
        "offset": 9,
        "filesToSearch": [
          "c:\\test-semantic-highlighting-no-electron\\app-test\\src\\index.d.ts"
        ]
      }
    }
Info 124  response:
    {"seq":0,
"type":"response",
"command":"documentHighlights",
"request_seq":33,
"success":true,
"body":[{"file":"c:/test-semantic-highlighting-no-electron/app-test/src/index.ts",
    "highlightSpans":
         [{"start":{"line":1,"offset":7},
            "end":{"line":1,"offset":10},
            "contextStart":{"line":1,"offset":1},
            "contextEnd":{"line":1,"offset":15},
            "kind":"writtenReference"
        }]
    }]
}

Info 125 request:
{
  "seq": 34,
  "type": "request",
  "command": "completionInfo",
  "arguments": {
    "file": "c:\\test-semantic-highlighting-no-electron\\app-test\\src\\index.d.ts",
    "line": 1,
    "offset": 9,
    "triggerCharacter": {
      "id": "type-tree",
      "range": {
        "start": {
          "line": 0,
          "character": 8
        },
        "end": {
          "line": 0,
          "character": 8
        }
      },
      "maxDepth": 6
    }
  }
}

Info 132  response:
{
  "seq":0,
  "type":"response",
  "command":"completionInfo",
  "request_seq":34,"success":true,
  "body":{"isGlobalCompletion":false,
  "isMemberCompletion":false,
  "isNewIdentifierLocation":false,
  "entries":[],
  "__tsExplorerResponse":
  {
    "id":"type-tree",
    "typeInfo":
    {
      "kind":"object",
      "properties":[],
      "indexInfos":[],
      "symbolMeta":
      {
        "name":"api",
        "flags":2,
        "declarations":
        [{
          "location":
          {
            "fileName":"c:/test-semantic-highlighting-no-electron/app-test/src/index.ts",
            "range":{"start":{"line":0,"character":6},"end":{"line":0,"character":9}}
          }
        }]
      },
      "id":"85,14,0"
      }
    }
  }
}

Info 139 request:
    {
      "seq": 37,
      "type": "request",
      "command": "definitionAndBoundSpan",
      "arguments": {
        "file": "c:\\test-semantic-highlighting-no-electron\\app-test\\src\\index.d.ts",
        "line": 1,
        "offset": 8
      }
    }
Info 141  response:
{
  "seq":0,
  "type":"response",
  "command":"definitionAndBoundSpan",
  "request_seq":37,
  "success":true,
  "body":
  {
    "definitions":
    [{
      "file":"c:/test-semantic-highlighting-no-electron/app-test/src/index.ts",
      "start":{"line":1,"offset":7},
      "end":{"line":1,"offset":10},
      "contextStart":{"line":1,"offset":1},
      "contextEnd":{"line":1,"offset":15}
    }],
    "textSpan":{"start":{"line":1,"offset":7},"end":{"line":1,"offset":10}}
  }
}

I will look into this issue but this is such a bad configuration.  There may be many places some of the assumptions going wrong here.
app-test/src/index.d.ts is considered output of app-test/src/index.ts since its tsconfig has composite which means declaration  to be true as well.