Getting UnhandledPromiseRejectionWarning: Error: Passed function is not well-serializable!  Error

Hi guys,
im using puppeteer with nodejs, following code is working fine, when i run in "windows" but getting error in "linux" and it says passed function is not serialized.
var temp = parseInt(today);
   		await page.$$eval(".week div",(elements,userDate)=> elements.map(item=>{
   		  if(item.textContent == userDate){
   			item.click()
   		  }
   	  }),temp)

Error is :

    (node:21636) UnhandledPromiseRejectionWarning: Error: Passed function is not well-serializable!
    at ExecutionContext._evaluateInternal (/snapshot/puppeteer/node_modules/puppeteer/lib/ExecutionContext.js:80:23)
    at ExecutionContext.evaluate (/snapshot/puppeteer/node_modules/puppeteer/lib/ExecutionContext.js:33:27)
    at ExecutionContext.<anonymous> (/snapshot/puppeteer/node_modules/puppeteer/lib/helper.js:117:27)
    at DOMWorld.evaluate (/snapshot/puppeteer/node_modules/puppeteer/lib/DOMWorld.js:108:24)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
  -- ASYNC --
    at Frame.<anonymous> (/snapshot/puppeteer/node_modules/puppeteer/lib/helper.js:116:19)
    at Page.evaluate (/snapshot/puppeteer/node_modules/puppeteer/lib/Page.js:680:14)
    at Page.<anonymous> (/snapshot/puppeteer/node_modules/puppeteer/lib/helper.js:117:27)
    at selectFromDate (/snapshot/puppeteer/index.js)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async /snapshot/puppeteer/index.js
(node:21636) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:21636) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Thanks in advance...

Hi, I also met this problem. Have you solved it?


Added Lawanu Borthakur Profile

Here is my profile data. I want to contribute to this project and learn more.
Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Unfortunately deleting the package-lock file doesn’t solve the problem. The best way to solve this is to copy the contents of the package-lock file in the main repo and paste it into your own package-lock file. That way the two should be identical and git won’t add the package-lock to the commit.

Unfortunately deleting the package-lock file doesn’t solve the problem. The best way to solve this is to copy the contents of the package-lock file in the main repo and paste it into your own package-lock file. That way the two should be identical and git won’t add the package-lock to the commit.

Sorry, I did not get you properly. Do you mean I have to copy the file in local machine and push?

Sorry, I did not get you properly. Do you mean I have to copy the file in local machine and push?

No problem, it’s an awkward thing to explain.
take the contents of this package-lock file on the main repo: https://github.com/EddieHubCommunity/LinkFree/blob/main/package-lock.json
copy it and paste it into your package-lock file then commit and push to your fork.

Okay fine. After copying, I have to commit and push in the same branch right? i.e AddProfile branch.

I have pushed the file after copying but it seems same as before and package-json file is not removed . I am bit confused whether is it okay or not?


Typo inside Camo#Allways

Description
The value of Camo#Allways seems to have a typo. It should be Camo#Always with one l.
Can be found here:
https://github.com/search?q=repo%3Ago-gitea%2Fgitea ALLWAYS&type=code

https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/modules/setting/camo.go#L12
https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/docs/content/administration/config-cheat-sheet.en-us.md?plain=1#L592
https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/modules/markup/camo.go#L41
https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/custom/conf/app.example.ini#L526

Close as @charles7668 's feedback.

But it is indeed a typo. all_ways should be ALL_WAYS according to the naming style (underline between words).

Since gitea has no strict config validation, it is really easy to miss configure this.


Special consideration for DirectoryInfo

Dump() does print out DirectoryInfo object but the recursive nature of the references (JsonSerializer just fails on it so that's good!) makes a few references up or down the directory tree make the panels start appearing very squashed.
I don't know if it is the aim of Dumpify to remain generic for all objects of if special consideration be given for certain types?
If so I think there are many improvements that could be made for DirInfo, like not printing all info for recursive reference and just the dirname, maybe put it in a tree instead of nested panels etc..

And FileInfo, FileSystemInfo etc

Hi, thanks for the suggestion!
I just tried to dump DirectoryInfo and I agree, it isn't great. I do treat some objects differently, and it will be easy to custom handle DirectoryInfo, FileInfo, etc..., we just need to figure out which properties are required and which are not.


Listen for (or send) events on multiple domains

I was wondering if there's support for supporting sending/listening for events with multiple domains. If not, are there plans to support this in the future?
Thank you!

Yup! You can pass an array of strings, or a regex as the domain.


Service Creation vs Documentation Problem

Summary
Kong service creation impl vs documentation is incorrect, example here:
https://getkong.org/docs/0.13.x/admin-api/#add-service
I try
https://gateway.com/admin-api/services/
{
"name": "ServiceNameTest",
"protocol": "http",
"host": "example.com",
"port": 80,
"path": "/upstream/server/path",
"retries": 5,
"connect_timeout": 10000,
"send_timeout": 10000,
"read_timeout": 10000
}
Gets HTTP 400 Bad Request
I then try
https://gateway.com/admin-api/services/
{
"name": "ServiceNameTest",
"protocol": "http",
"host": "example.com",
"port": 80,
"path": "/upstream/server/path",
"retries": 5,
"connect_timeout": 10000,
"write_timeout": 10000,
"read_timeout": 10000
}
Gets HTTP 201 Created
Steps To Reproduce

Try creating based on send_timeout, 400 bad request.
Try creating based on write_timeout, HTTP 201 Created

###Next steps

Kong needs to decide if they like write_timeout or send_timeout better and revise the code or documentation accordingly. Related to my getkong documentation change here:
https://github.com/Kong/getkong.org/pull/663

Additional Details & Logs

Kong version 0.13.0

@jeremyjpj0916 Thanks! I merged your getkong.org PR, should be live in the main website soon.

@hishamhm np, as I find things I will post. So I assume yall choose to go with write_timeout which keeps the code the same and just meant a documentation change. Thanks for the quick handling!


Weighted loss function

As discussed, it would be useful to be able to easily add a custom weighted cost function.
Currently a custom loss function is easily implemented, but having a weighted loss function is currently not supported. A possible scikit-learn compatible API for this would be to pass the weights in the fit call like this.
fit(X, y, sample_weight=None)
I have tried to implement it, but up to now with no success.
Here is the diff :
https://github.com/cbonnett/nolearn/commit/f4ad011397d966b05dfbbe517a6845c40e7c490a

The PR "Add ability to weight training samples and predefine training/validation splits" #123 has an implementation for this.  The pull request has problems though which are discussed here: https://github.com/dnouri/nolearn/pull/123#issuecomment-124687911

The best way to go about this might be to create a second input layer for the weights, then use that layer inside of your objective function to multiply your loss.

Would you consider an AP to specify the weights per label instead of per training examples? That might be a more common use case (at least for myself).

Hmm, would that be possible by creating a custom objective function alone?

Yes, that's basically what I have been doing. If I remember correctly, here's what I did –
def custom_objective(...):
    ...
    weights_per_label = theano.shared(lasagne.utils.floatX([0.8, 0.1, 0.1]))
    weights = weights_per_label[target]  # This is a bit non-obvious
    loss = aggregate(loss_function(network_output, target), weights=weights)
    ...


[Schema Registry] Avro Serializer different input types support

serialize: consider support avro.schema.Schema
deserialize: consider support generator[bytes], io

there's no plan yet for supporting different multiple types of input, closing the issue now


summbit-discrete-slider:270 - Uncaught SyntaxError: export declarations may only appear at top level of a module

Running some very simple HTML in my browser:
<!DOCTYPE html>
<html>
<head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
 <script src="./summbit-discrete-slider.js"></script>
 <title>somethin</title>
 <style type="text/css">
  html, body {
    width: 100%;
    margin: 0;
    height: 100%;
  }
 </style>
</head>
<body>
<summbit-discrete-slider min="0" max="7" value="3" orientation="left-to-right"></summbit-discrete-slider>
</body>
</html>

With the latest js downloaded today, yet I get this in the console of latest Firefox:
Uncaught SyntaxError: export declarations may only appear at top level of a module
summbit-discrete-slider.js:270

thank you, yes I noticed that too after a bit, finally got it working now :)


64 5 favorited appearances chosen is in front of the other frames

Hi Chris-P,
Someone added  a new pull request on github. Can you check it out? I saw you didn't login to vamhub for a month, so I'm reaching out for you here.
Cheers,
Pino

From: chris-b-pacon @.>
Sent: Monday, July 10, 2023 4:16 PM
To: pinosante/VAM-Evolutionary-Character-Creation @.>
Cc: pinosante @.>; Review requested @.>
Subject: Re: [pinosante/VAM-Evolutionary-Character-Creation] 64 5 favorited appearances chosen is in front of the other frames (PR #68)
@chris-b-paconhttps://github.com/chris-b-pacon requested your review on: #68https://github.com/pinosante/VAM-Evolutionary-Character-Creation/pull/68 64 5 favorited appearances chosen is in front of the other frames.
—
Reply to this email directly, view it on GitHubhttps://github.com/pinosante/VAM-Evolutionary-Character-Creation/pull/68#event-9776951123, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJQIAB4PHAYGHFHV56PRXALXPQTFPANCNFSM6AAAAAA2EYTMEU.
You are receiving this because your review was requested.Message ID: @.***>

If you reply to this email, please use vamhub, since I don't read this email address.
Cheers
Pino

From: chris-b-pacon @.>
Sent: Monday, July 10, 2023 4:16 PM
To: pinosante/VAM-Evolutionary-Character-Creation @.>
Cc: pinosante @.>; Review requested @.>
Subject: Re: [pinosante/VAM-Evolutionary-Character-Creation] 64 5 favorited appearances chosen is in front of the other frames (PR #68)
@chris-b-paconhttps://github.com/chris-b-pacon requested your review on: #68https://github.com/pinosante/VAM-Evolutionary-Character-Creation/pull/68 64 5 favorited appearances chosen is in front of the other frames.
—
Reply to this email directly, view it on GitHubhttps://github.com/pinosante/VAM-Evolutionary-Character-Creation/pull/68#event-9776951123, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJQIAB4PHAYGHFHV56PRXALXPQTFPANCNFSM6AAAAAA2EYTMEU.
You are receiving this because your review was requested.Message ID: @.***>


License

Could you please include a license for the project?
Thanks

Thank you for the comment Felipe, a license is now included.

Thank you for the comment Felipe, a license is now included.


Bug: Downtime on Site update

When we publish a site worker, often the worker and its accompanying asset manifest make it to the edge ahead of the new KV keys, and/or the "old" KV keys are removed before the worker is updated. This causes a window of downtime when a page is updated. We need to somehow delay removing "old" assets from KV until everything is live. There are a few ways to implement this, will update this issue with possible strategies soon.

community report: https://community.cloudflare.com/t/brief-period-of-unavailability-when-publishing-workers-sites/121929

Any updates on this? :)

hey @lolcoolkat I'll likely be investigating this on Friday, and will comment here with my conclusions.

Thank you @ashleymichal

so here's what happens.
Say i have an asset /sweet-blog-post.html. The first time Wrangler uploads it, it hashes the content and inserts it between the file stem and the extension, e.g. /sweet-blog-post.abcdef1234567890.html, and adds the following entry to the asset manifest:
"/sweet-blog-post.html": "/sweet-blog-post.abcdef.html"

If I update my sweet blog post, the next time Wrangler goes to upload, the content hash changes (e.g. /sweet-blog-post.fedcba.html. Wrangler then compares the local content with the remote content, and deletes the old version, updating the asset manifest to reflect the changes.
Unfortunately, the old version is deleted before the new asset manifest is uploaded with the worker, and so there is a window during which the old worker is trying to reference the deleted asset. This is sub-optimal.
We can reduce this window significantly by delaying deletes until after the worker has been published.

i'm going to defer work on this until the work on Multi-Route support has been approved and merged, there's a lot of changes to the publish command there, and there will be here as well.
My proposed solution implementation:

wee refactor to separate logic for publishing a site vs publishing a vanilla workers project. this just helps with cognitive load.
refactor to kv::bucket::sync to return tuple (exclude_keys, delete_keys), and have function publish_site call upload before worker publish, and delete after.
(bonus) refactor to keep bucket logic specific to sites; at the moment only sites have buckets, and i'm not sure we plan to change that; at the moment it's sort of confusing that we have a bucket config on site but also on all kv namespaces.

@ashleymichal are there any updates for this? This issue is a massive blocker for us, so, if the fix is going to take time then maybe we need to get a smaller interim fix in (e.g. an option to never delete resources from the KV store?).


[Monitor OpenTelemetry] Add Application Insights Shim Statsbeat Feature Support

Packages impacted by this PR
@azure/monitor-opentelemetry
Describe the problem that is addressed by this PR
Add support to statsbeat for capturing shim usage.
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Deploy to maven central

This would be really useful if it was in mvn central

I will look into It. I have been meaning to, just haven’t gotten around to doing it yet.


support radio button custom style

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Make sure you are merging your commits to dev branch.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

#283

你们都不休息的吗。。。

@Kingwl 上面三位基本上是业余时间在维护 Element，所以周末变成了收割时间


Fix exception in Postgres inserting None value for Option[JsonValue[...]] or Option[JsonbValue[...]] fields

Fixes #3022
Problem
Exception in Postgres inserting None value for Option[JsonValue[...]] or Option[JsonbValue[...]] fields:
ERROR: column "..." is of type json but expression is of type character varying
Solution
This PR fixes entityEncoder and astEncoder methods in PostgresJsonExtensions trait by changing sqlType parameter from Types.VARCHAR to Types.OTHER.
Notes
Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[x] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

We need to backport this fix (if needed) and (at least) the corresponding tests to zio-protoquill.
@vladimirkl Do you want to make this work? That'd be great 🙂

Sure, will try backporting this  into zio-protoquill

@vladimirkl Thanks! 🙏

@guizmaii done

Thank you so much @vladimirkl! ❤


Drop support for building from Eclipse

https://github.com/mixpanel/mixpanel-android/blob/ca5c0d9e74217c6d5ce5e9afa58397c5d1346a14/src/main/java/com/mixpanel/android/mpmetrics/MPConfig.java
// Unfortunately, as long as we support building from source in Eclipse,
    // we can't rely on BuildConfig.MIXPANEL_VERSION existing, so this must
    // be hard-coded both in our gradle files and here in code.

I suggest dropping support for building from Eclipse.

Thanks for your suggestion! We've recently done an internal discussion about it as well. I wanted to get rid of Eclipse support as Google stopped maintaining ADT in June 2015. However, we believe there's a decent amount of Mixpanel users are still on Eclipse. As the next step, we'll find a way to figure out if that's the case and make a final call according to the result.


Bump utils to v 0.5.0

Description & motivation
Bumping the upper bound so that people can use the latest version of utils
Bumping the lower bound for consistency
Fixed tests so that we get ✅
Checklist

[x] I have verified that these changes work locally
n/a I have updated the README.md (if applicable)
n/a I have added tests & descriptions to my models (and macros if applicable)

@jtcohen6 — I updated some env vars in the profiles.yml to bring them into line with the other repos. But I think you might need to do some CircleCI config! Let me know if I should undo those changes :)

I noticed that this repo doesn't have a .github directory. Before we merge it, I'm going to add those :)

OK all we gotta do now is wait for us to be able to switch the default branch around 🤞

For posterity, we kept the current default branch due to downstream impacts on the hubcap script


Caliptra 2.0 PQC support including updates to DICE key derivations, DPE flow, KV flows and anything else that it impacts

PQC interaction with DICE (Legacy: UDS-Seed -> DEOBF(UDS) -> Legacy is unchanged; New change: UDS-Seed -> DEOBF(UDS) -> HMAC(OUTPUT of DEBOF) -> PQC flow)
PQC interaction with KV
PQC KAT
PQC required fuses for FW signing, ownership transfer, SOC manifest authentication etc.

Tagging few others for FYI @varuns-nvidia @mojtaba-bisheh @Nitsirks @ekarabu @upadhyayulakiran  @JohnTraverAmd

Thanks for opening this! I'll fill out details for the HW interactions in a spec PR.
For high-level DICE design, I opened https://github.com/chipsalliance/caliptra-sw/issues/1621.


Be less harsh on B-Frames

Changes the behaviour on seemingly detected B-frames (ignore instead of break)
Relevant discussion: https://github.com/bluenviron/mediamtx/discussions/2818

Hello, the problem of this PR is that it produces corrupted streams. If you have a decoder which outputs access units with the same timestamp, open an issue and provide a sample file that allows to replicate the problem, since the server may be improved in order to merge or skip these duplicate timestamps before passing them to the output muxer.


run regex client side

would be a lot smoother than a separate output ui and going serverside.
May be possible via filters

yeah this would definitely be desirable.
It doesn't seem easily possible (or at all?) with selectize.js (as I had hoped), perhaps because the whole UI model of selectize is to accept one match at a time, not a whole bunch.
Still there is probably a client-side way to do this.
Deeep, deep, backlog.

no longer fits into the design of the pkg; validation logic is now solidly in R and used in R in a bunch of places, so client-side would be duplication

no longer fits into the design of the pkg; validation logic is now solidly in R and used in R in a bunch of places, so client-side would be duplication


[Envoy] runing npm on normal ssh sessions works, but with envoy task returns npm command not found

Hi,
when I login to my VPS with SSH and run command:
npm -v

it gives me
1.4.28

but when I run my Envoy.blade.php:
@servers(['testing' => 'user@host'])

@task('deploy')
    cd some/folder
    npm -v
@endtask

with envoy run deploy it gives me bash: line 3: npm: command not found

Doesn't look like a bug in envoyer, more that envoyer's not running as the same user as the one you ran that first command from, likely the "nmp" alias isn't registered. Any further questions belong on the forums please.


hcwallet compile error

github.com/HcashOrg/hcwallet/omnilib
/usr/bin/ld: cannot find -lomnicored
/usr/bin/ld: cannot find -lbitcoin_server
/usr/bin/ld: cannot find -lbitcoin_common
/usr/bin/ld: cannot find -lunivalue
/usr/bin/ld: cannot find -lbitcoin_util
/usr/bin/ld: cannot find -lbitcoin_wallet
/usr/bin/ld: cannot find -lbitcoin_consensus
/usr/bin/ld: cannot find -lbitcoin_crypto
/usr/bin/ld: cannot find -lleveldb
/usr/bin/ld: cannot find -lmemenv
/usr/bin/ld: cannot find -lsecp256k1
collect2: error: ld returned 1 exit status
i use go1.9 version

Hi,
You missed omnilib.you need build it and copy it to right path.
git clone https://github.com/HcashOrg/hcOMNI.git
cd hcOMNI
$ chmod 777 autogen.sh
$ chmod 777 share/genbuild.sh
$ sudo apt-get install make  pkg-config autoconf libtool
$ sudo apt-get install libboost-all-dev libssl-dev libevent-dev
libdb-dev  libdb++-dev
$ ./autogen.sh
$ ./configure --with-incompatible-bdb --disable-tests --disable-bench
$ make clean
$ make
cd src
ar rc libomnicored.a omnicored-bitcoind.o omnicored-omnicoreApi.o
cp univalue/.libs/libunivalue.a .
cp crypto/libbitcoin_crypto.a .
cp leveldb/libleveldb.a .
cp leveldb/libmemenv.a .
cp secp256k1/.libs/libsecp256k1.a .
#copy all .a to hcwallent/omnilib dir,refer below cmd,then build
hcwallet and hcd
cp *.a $GOPATH/src/github.com/HcashOrg/hcwallet/omnilib
https://github.com/HcashOrg/hcOMNI
Seymour-w<EMAIL_ADDRESS>于2019年4月3日周三 下午2:45写道：

github.com/HcashOrg/hcwallet/omnilib
/usr/bin/ld: cannot find -lomnicored
/usr/bin/ld: cannot find -lbitcoin_server
/usr/bin/ld: cannot find -lbitcoin_common
/usr/bin/ld: cannot find -lunivalue
/usr/bin/ld: cannot find -lbitcoin_util
/usr/bin/ld: cannot find -lbitcoin_wallet
/usr/bin/ld: cannot find -lbitcoin_consensus
/usr/bin/ld: cannot find -lbitcoin_crypto
/usr/bin/ld: cannot find -lleveldb
/usr/bin/ld: cannot find -lmemenv
/usr/bin/ld: cannot find -lsecp256k1
collect2: error: ld returned 1 exit status
i use go1.9 version
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/HcashOrg/hcwallet/issues/16, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHkpZb7XGRQP1dn8f7GJs9TYNFXeQlKhks5vdE4AgaJpZM4cZvGd
.

Thx!
Is the code unverified?
undefined reference to `event_enable_debug_logging'
and
qt/splashscreen.cpp:10:2: error: #endif without #if
I've already annotated it.
But the compilation still fails
github.com/HcashOrg/hcwallet/omnilib
omnilib/libbitcoin_server.a(libbitcoin_server_a-init.o): In function AppInit2(boost::thread_group&, CScheduler&)': /home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/init.cpp:1264: undefined reference to CZMQNotificationInterface::CreateWithArguments(std::map<std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::less<std::__cxx11::basic_string<char, std::char_traits, std::allocator > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits, std::allocator > const, std::__cxx11::basic_string<char, std::char_traits, std::allocator > > > > const&)'
omnilib/libbitcoin_server.a(libbitcoin_server_a-net.o): In function ThreadMapPort()': /home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1385: undefined reference to upnpDiscover'
/home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1396: undefined reference to UPNP_GetValidIGD' /home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1401: undefined reference to UPNP_GetExternalIPAddress'
/home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1431: undefined reference to strupnperror' /home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1426: undefined reference to UPNP_AddPortMapping'
/home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1449: undefined reference to freeUPNPDevlist' /home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1441: undefined reference to UPNP_DeletePortMapping'
/home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1443: undefined reference to freeUPNPDevlist' /home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1444: undefined reference to FreeUPNPUrls'
/home/btcpool/hcash/src/github.com/HcashOrg/hcOMNI/src/net.cpp:1451: undefined reference to `FreeUPNPUrls'
collect2: error: ld returned 1 exit status

hi coolsnady
Hcwallet could not be compiled.
Where can I download the binaries?


Passing parameters to the encode function

Hello!
Thanks for the amazing lib!
I am trying to create an embedding service API with this queue and my issue is that it seems that the encode function should only take a list of elements as input and return a list as outputs.
This works if the encode function called is the same every time, but some encoding functions might require extra parameters, for example for asymmetric query/document embeddings (with more advanced processing than just adding prompts).
Is there a way to pass parameters to the encode function that I am missing? Would it be possible to add a kwargs argument to the signature so we can pass additional arguments to the encode function?
Thanks!

I found a workaround by wrapping the encode function into one that that only takes the list as input:
def wrap_encode_function(model, **kwargs):
    def wrapped_encode(sentences):
        return model.encode(sentences, **kwargs)

    return wrapped_encode

From my understanding, for the batching to work properly, the wrapped function need to be defined once and not "generated on the fly", allowing for the function to be mapped at the same address in memory.

Hey @NohTow! Glad this helps you!
There are essentially two approaches to handling kwargs in machine learning models:

Partial Function Application

This is the approach you've already discovered. It's simple and works well for most cases. You can implement it in two ways:
a) Manual partial application
inference_func = lambda x: model.encode(x, **fixed_kwargs)

b) Using functools.partial
from functools import partial

inference_func = partial(model.encode, **fixed_kwargs)

Dynamic Batching on forward level

For more control (at the cost of some performance), you can patch the forward function of the model using inference.dynamically. This allows you to apply different kwargs for each encode call while still maintaining dynamic batching.
Note: This approach introduces some overhead due to padding.
from batched import inference
import torch

inference_func = inference.dynamically(model.forward, pad_token={"input_ids": 0})

Hope this helps.


RenderTexture origin is now (0.5, 0.5) by default instead of (0, 0)

This PR

Updates the Documentation (Changelog)

👍


Allow a way to get the "full build" of Vue using the CLI

What problem does this feature solve?
(Forgive me if this already exists, I couldn't find it)
As I'm sure you are all aware, there are a few different builds of Vue included in the NPM package. I would be helpful to be able to specify "I would like the full build version."
What does the proposed API look like?
Eg, vue-cli-service serve --build=full

You can use compiler: true in vue.config.js

Sorry, I don't see a vue.config.js file?

Create one at the root of your project.

Ah, okay, I see what you're talking about.
For others coming here, documentation is here: https://alligator.io/vuejs/using-new-vue-cli-3/#the-vueconfigjs-file

For the sanity of others a slight correction to the above info. Key to trigger boolean is:
runtimeCompiler: false
Fyi configuration can either go under a vue config key in package.json or it's own vue.config.js file.

Documentation: https://cli.vuejs.org/config/#runtimecompiler


Chunked upload

There are two reasons for uploading a file in chunks:

File upload may get interrupted so it is nice to continue when it ended
File upload size is often limited to few megabytes so this would avoid this limitation and would work for any file size (videos).

Idea is to send file in chunks of some reasonable size, one chunk per http request. Once all chunks are transfered, the completed file is renamed to original name.
Basically the one thing to add is offset and length of the chunk and seek before writing. A hash of the whole file would be nice to check to be sure no chunk is missing.

See also https://github.com/PhotoBackup/client-android/issues/46

If this becomes part of the spec, I would work on that for sure.


various (mostly) minor edits

quick edits as I was reading through the manuscript

Thanks @fmichonneau unfortunately your PR came in the middle of me trying to sort out two different versions of rule 9 so some of your changes on rule 9 (and maybe 10) might have been lost in my efforts to reconcile the three different versions of those rules.  Please check to make sure that it's all good, but in the mean time I'm going to merge.

It looks good, thanks!


docs: Add multi-lang module structure page

@helderco I've created this as a separate multi-language page but on review, it seems like this is specific enough to each SDK that it should actually be part of the language-specific page (#7408). Let me know if you agree.

This was a difficult page to merge, because the content was significantly different for each languages. I needed to backfill some content and also adjust the structure of the sections. To confirm there are no errors, I would like review and approval from experts in our team. Pinging:

@vito @sipsma @jedevc for Go
@helderco for Python
@TomChv for TypeScript

When reviewing, if you see areas where we can modify or optimize the internal page structure further, please add comments.

Thanks for these changes, I added some update suggestions based on new changes that were introduced with #7096.

I've added these changes, can you please review once again @TomChv ? Thanks!

Ping @vito @sipsma @jedevc @helderco @TomChv for review, see https://github.com/dagger/dagger/pull/7411#issuecomment-2122665088


Add --pull=newer when running the container

From https://docs.podman.io/en/latest/markdown/podman-run.1.html#pull-policy
Pull image policy. The default is missing.
always: Always pull the image and throw an error if the pull fails.
missing: Pull the image only if it could not be found in the local
         containers storage. Throw an error if no image could be found and
         the pull fails.
never: Never pull the image but use the one from the local containers
       storage. Throw an error if no image could be found.
newer: Pull if the image on the registry is newer than the one in
       the local containers storage. An image is considered to be newer
       when the digests are different. Comparing the time stamps is prone
       to errors. Pull errors are suppressed if a local image was found.

Switching to pull=newer will allow us to keep this image uptodate for
users without erroring out if podman cannot check or pull a new image
(i.e. we'd keep running the local one)

As Martin pointed out we might be requiring a too new version of podman. So we'll need to approach this a bit differently

According to https://www.github.com/containers/podman/issues/12707 the pull newer has been present since 3.4.x days almost two years ago, so I think it is okay to start merging this one.

Tested on Ubuntu LTS as well:
root@ubuntu2204:~# source /etc/os-release && echo $VERSION
22.04.3 LTS (Jammy Jellyfish)
root@ubuntu2204:~# podman version
Version:      3.4.4
API Version:  3.4.4
Go Version:   go1.18.1
Built:        Thu Jan  1 01:00:00 1970
OS/Arch:      linux/amd64
root@ubuntu2204:~# podman run -it --rm --pull=newer quay.io/hybridcloudpatterns/utility-container:latest

       1          Welcome to the Validate Pattern utility container
      111         It contains all the needed components to install a pattern.
     1   1
    111 111       Please run the following for more information:
   1       1
  111     111       ./pattern.sh make help
 1   1   1   1
111 111 111 111

So merging

Confirmed this works on Ubuntu LTS 22.04; this seems to cover most of our use cases (in addition to our RHEL/Fedora ones) so I'm fine with this being merged now


setuptools wheel install will fail if a data dir is a subdirectory in a package

With the new wheel support, I ran into an issue where if data_files specifies a subdirectory in a package, setuptools will fail on moving the data.  This worked in previous versions of setuptools w/o wheel support, and also works with pip install.
Perhaps this is not a supported use case (should package_data be used instead?)
I was able to work around the issue by removing the subdirectory, but in case someone else runs into this, here is a repro test case that can be added to test_wheel.py
    dict(
        id='data_in_package',
        file_defs={
            'foo': {
                '__init__.py': '',
                'data_dir': {
                    'data.txt': DALS(
                        '''
                        Some data...
                        '''
                    ),
                }
            }
        },
        setup_kwargs=dict(
            packages=['foo'],
            data_files=[('foo/data_dir', ['foo/data_dir/data.txt'])],
        ),
        install_tree=DALS(
            '''
            foo-1.0-py{py_version}.egg/
            |-- EGG-INFO/
            |  |-- DESCRIPTION.rst
            |  |-- PKG-INFO
            |  |-- RECORD
            |  |-- WHEEL
            |  |-- metadata.json
            |  |-- top_level.txt
            |-- foo/
            |  |-- __init__.py
            |  |-- data_dir/
            |     |-- data.txt
            '''
        ),
    ),

In the test case, foo is a package and /foo/data_dir/ is a data dir. Since foo already exists as a package, the os.rename fails, even though /foo/data_dir/ does not exist. Should it check if the directory already exists?
The error looks something like the following (on OSX):
                for entry in os.listdir(subdir):
                    os.rename(os.path.join(subdir, entry),
>                             os.path.join(destination_eggdir, entry))
E                   OSError: [Errno 66] Directory not empty: '/var/folders/07/c66dj8613n37ssnxsvyz8dcm0000gn/T/tmpybp6f4ft/foo-1.0-py3.5.egg/foo-1.0.data/data/foo' -> '/var/folders/07/c66dj8613n37ssnxsvyz8dcm0000gn/T/tmpybp6f4ft/foo-1.0-py3.5.egg/foo'

Can you confirm #1220 work with your original use case?

Confirmed that it works, thank you for the fix!


Error in concat_w2v.py

hello
when run "python script/concat_w2v.py --SMPLX_PATH  --GT ./Data/Trainval_GT_HICO_with_idx.pkl --Neg Trainval_Neg_HICO_with_idx.pkl --Test Test_Faster_RCNN_R-50-PFN_2x_HICO_DET_with_idx.pkl"
I have following error:
pc = pickle.load(open(args.SMPLX_PATH + '/object_GT/HICO_train2015_%08d/%03d_feature.pkl' % i, 'rb'))
TypeError: not enough arguments for format string
when I replace this line with "pc = pickle.load(open(args.SMPLX_PATH + '/object_GT/HICO_train2015_%08d/%03d_feature.pkl' % (key, Trainval_GT[key][i][-1]), 'rb'))" I have following error:
FileNotFoundError: [Errno 2] No such file or directory: 'F:/DJ-RN-master/DJ-RN-master/Spatial/object_GT/HICO_train2015_00000004/001_feature.pkl'
This is because in the folder "results\HICO_train2015_00000004" ] : I have 000.pkl, 001.pkl and 002.pkl but in folder "object_GT\HICO_train2015_00000004" I have only 000_feature.pkl and not 001_feature.pkl and 002_feature.pkl.
Did I make a mistake or does the code need to be corrected?

The SMPLX_PATH argument has to be specified as your local customized path of the SMPL-X results.

The SMPLX_PATH argument has to be specified as your local customized path of the SMPL-X results.

Yes, I know that. I have two questions
1- In folder args.SMPLX_PATH/results/HICO_train2015_00000004 I have 000.pkl, 001.pkl and 002.pkl but in folder args.SMPLX_PATH/object_GT/HICO_train2015_00000004, I have just 000_feature.pkl and I dont have 001_feature.pkl and 002_feature.pkl. This leads the following error:
No such file or directory: '.../object_GT/HICO_train2015_00000004/001_feature.pkl'
2- What is the second argument beside i in this line?
pc = pickle.load(open(args.SMPLX_PATH + '/object_GT/HICO_train2015_%08d/%03d_feature.pkl' % i, 'rb'))

Yes, I know that. I have two questions
1- In folder args.SMPLX_PATH/results/HICO_train2015_00000004 I have 000.pkl, 001.pkl and 002.pkl but in folder args.SMPLX_PATH/object_GT/HICO_train2015_00000004, I have just 000_feature.pkl and I dont have 001_feature.pkl and 002_feature.pkl. This leads the following error:
No such file or directory: '.../object_GT/HICO_train2015_00000004/001_feature.pkl'
2- What is the second argument beside i in this line?
pc = pickle.load(open(args.SMPLX_PATH + '/object_GT/HICO_train2015_%08d/%03d_feature.pkl' % i, 'rb'))

Thanks for pointing out. And we have updated the code.
For Q1, with the updated code, this error shouldn't happen if all the steps before are well-performed.
For Q2, it should be the (key, i). We have fixed that.

Thanks for pointing out. And we have updated the code.
For Q1, with the updated code, this error shouldn't happen if all the steps before are well-performed.
For Q2, it should be the (key, i). We have fixed that.

thanks
With this correction, it still gives me an error, and the reason is that for some images, such as picture HICO_train2015_00000011.jpg, two rows i=0 and i=1 have a value of zero in Trainval_GT[key][i][-1], but just exist 000_feature.pkl and this causes an error. In my opinion, the file assign_pose_GT.py in line data[key][j][-1] = i should be reviewed.

thanks
With this correction, it still gives me an error, and the reason is that for some images, such as picture HICO_train2015_00000011.jpg, two rows i=0 and i=1 have a value of zero in Trainval_GT[key][i][-1], but just exist 000_feature.pkl and this causes an error. In my opinion, the file assign_pose_GT.py in line data[key][j][-1] = i should be reviewed.

Should not be replaced (key, i) with (key, Trainval_GT[key][i][-1])?

Should not be replaced (key, i) with (key, Trainval_GT[key][i][-1])?

Would you mind providing the detailed commands you used for data generation, specifically step 5, 6, 7?

Would you mind providing the detailed commands you used for data generation, specifically step 5, 6, 7?

@mohammad749 how did you fix this error?
also https://github.com/DirtyHarryLYL/DJ-RN/issues/66
Thanks a lot

@mohammad749 could you please share your script/concat_w2v.py ? my email is<EMAIL_ADDRESS>thank you so much :)


aarch64: include HYPERCALL_MMIO in Kernel memory-space.

In aarch64, we use an extra page below the KVM_IOEVENTFD_BASEADDR page for Hypercalls, HYPERCALL_MMIO_BASE. Till now, we have missed including it in the memory management bookkeeping.

note that the issue persists if the config is set to CopyDataWithPf : false;


Switch connect order

For readability, Connect(dest, src) now outputs dest = src. Previously, the order was switched, so Connect(src, dest) became dest = src.

Looks like there are a couple of test failures. All the frontends that use this: systolic, NTT, MrXL, need to be fixed before this can be merged

It looks like all of the frontends have been successfully updated!


after exiting from app, Ubuntu Terminal color becomes grayish

(it was black before running the app).

I use Snap version.

must be fixed


Fix startup script for users with multiple groups

Starting the Docker container fails when the user starting the process is a
member of multiple groups, as the space separated list of groups is passed
unquoted to the docker command, which breaks the command. This is fixed
by quoting the group parameter.
Fixes #4366

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MFA support

Do you have any plan to support MFA?

Hello @suketa. There are no plans for it, but if you provided a pull request I would gladly merge it.


tools: Switch back to bfd as the linker

The bug in question has been fixed for a bit now.
Reference:
https://github.com/android-ndk/ndk/issues/602#issuecomment-363224619
https://android.googlesource.com/toolchain/binutils/+/b6e5526f9ddd66b3c2a24ace4806873fc3b46920

Test this at WireGuard-KT-74-b77b71c22b48a81cb2e24e4138d2b601a84772a0.apk.
This is an automatically posted message from Travis-CI


Output is not escaped correctly

In the keynote, you can see that when @shanselman uses Console.WriteLine with a string containing an apostrophe, the output shows ', when it should be just ':

AFAICT the problematic code is here:
https://github.com/CodeConversations/CodeConversations/blob/0bb738384982d32a89c48a422af02339c232c6e9/src/Bots/CodeConversationsBot.cs#L153
I believe HtmlEncode() is not the correct thing to do here, though some escaping will probably be necessary.

@svick - want to submit PR #1?

@bradygaster I'm not sure what is the right way to escape content (e.g. if content contains ```, could I use quadruple-backticks block here to display that correctly?) and based on the guide, trying it out would be way too complicated. So, no, I'll leave the PR to someone else.

I think it'd be as simple as changing it to HtmlDecode. cc @colombod - did one of us use the wrong method here? seems like we want decode.

I think the code in master contains the fix


update to support new firebase_core

i can not use this library with firebase_core:3.1.1
maximum version support is 2.27.0 but this library has own bugs .
can you please update library to support new firebase_core version

@maxim-saplin

Just pushed 1.07 to pub.dev, hope it's fine now


Fix scheduler db migration timeout

This fix was applied previously but we seem to have lost it in all our different branch merging!

Codecov Report
Base: 46.43% // Head: 46.43% // No change to project coverage :thumbsup:

Coverage data is based on head (afa80b8) compared to base (d2c759e).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2099   +/-   ##
=======================================
  Coverage   46.43%   46.43%
=======================================
  Files         216      216
  Lines       30559    30559
=======================================
  Hits        14190    14190
  Misses      15269    15269
  Partials     1100     1100

Flag
Coverage Δ

armada-server
46.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Bump wrapper

Lets us use:

https://github.com/gradle/gradle/pull/25196

@bot-gradle test and merge please.

I've triggered a build for you.


Client profile

Description
Styled the ClientProfile component.
Change Status

[ ] Complete, tested, ready to review and merge

Shouldn't this be merging into staging?


init example declarative project configuration

Looks good, could you init a GitHub Action to validate .json files are valid JSON?

Probably also adding a little README.md next to it explaining what the example is showing.


Handle arguments

While cmd-R is convenient, sometimes we need to start our runs with arguments, like:
$ cargo run -- --num_agents=5 --use_submarine_base
Suggestions:

Clarify the documentation to explain how arguments are handled by cargo-runner.

Add a mechanism, if not present, to allow adding and changing arguments.

Naturally, we wouldn't want to interfere with the convenience of the simple cmd-R command. So maybe shift-cmd-R brings up a dialog box for parameters? Or cargo-runner would look for a default file like .cargo-runner-args and append its contents, if present? Either way, it should default to the last used arguments.

As of the moment there is no way to pass custom arguments
but if you wish to change the default cargo run command
the default command is always
cargo run --package package_name --bin bin_name

which are from your cargo.toml
but if you need to always run the same cargo run with same arguments
you might want to use a Makefile
e.g.
Makefile - can be define per crate
# Default target
.PHONY: all
all: build

# Build target
.PHONY: build
build:
	cargo build --package PKG_NAME

.PHONY: run
run:
	cargo run --package PKG_NAME --bin BIN_NAME -- --num_agents=5 --use_submarine_base

# Test target
.PHONY: test
test:
	cargo test

# Clean up
.PHONY: clean
clean:
	cargo clean

If that would solve your current problem , then Makefile i think would suffice
if you really wanna run any cargo commands you might want to check cargo-bin which would allow you to run any cargo commands
with that said, i understand there is a usecase for your suggestion
I might be able to add your request by making a cargo-runner.toml file
and an extra keybind like you mentioned or a command available at command palette.
What I had in mind is
lets say I added the  command  cargo runner override
you would get prompted what you wanna override
e.g.
options:

run
build
test
single file rust script
bench

then you will be asked what parameters you wanna pass in
example :
num_agents:String
use_submarine_base:bool
then that would generate something like
package_name = "pkg"

[[bin]]
name = "pkg"
path = "path/to/bin/bin_or_main.rs"

[[parameters.run]]
name = "num_agents"
type = "String"
default = "6"

[[parameters.run]]
name = "use_submarine_base"
type = "bool"
default = true

then if we press lets say CMD+SHIFT+R
it would show what command it would run
would you like to run cargo run --package pkg --bin pkg -- --num_agents=6 --use_submarine_base
if you press enter then it would run that, if you type No , NO or n and press enter
you will be asked first for num_agents
then will be asked for use_submarine_base
then it would run that command and would update the cargo-runner.toml
let me know if this is the behavior you want
If we go down this path then i might need to remove support  of Makefile
@GaryBoone  let me know what you think about this idea

Yes, the common use case I see is being able to quickly add command line parameters, run the new command line repeatedly with those parameters, then make some changes to the parameters, then repeat with those. Maybe drop them when I'm done and change tasks, or set some common ones used throughout development. So the key requirement I think is keeping this feature consistent with the strength of cargo-runner: no-click and fast.
The workflow suggested above is excellent.

The first time you use cargo runner override, you're prompted for the required input.
The info is reused on subsequent runs so it's fast on repeat uses.
There's an easy way to edit the parameters on repeat uses.
You now have two ways to run fast: CMD-R runs without parameters. CMD+SHIFT+R runs with the current overrides. [Love this: it's fast and flexible. It also prevents confusion of what will be run because they're two separate commands.]

The description sounded like some of the prompts are sequential. Could there be a single dialog box for everything? Eg, it's just a list of overrides, where an override says what to override, and then lists the arguments with + for add parameter and a pencil icon for edit parameter?
BTW, as an initial version, could we just add all of the parameters as a simple string? That would be simpler from a UI as well as coding perspective.
In addition, I'm not sure we want strong typing for command line arguments, for these reasons:

They aren't typed on the command line. They're just a string, or perhaps a vec of strings.
It's extra work to type them in the cargo-runner UI.
It's the responsibility of the user's code to convert the command line string arguments to validated, typed, arguments.
It means that the user has to synchronize the types in two places: their code and the cargo-runner UI.
It could mask bugs if my code doesn't correctly convert the arguments, but I never know about it because cargo-runner always ensures the right type for me.

@GaryBoone  , been very busy , but now you can add overriding parameters
please check this for instruction on how to use this feature
https://github.com/codeitlikemiley/cargo-runner/pull/11


cleaning and add gitignore

So I added a .gitignore file and did some cleaning.

I remove files that are created when the package is build/run :

build
dist
pycache
egg-info

The .gitignore file i added comes from https://www.toptal.com/developers/gitignore

It's the classic .gitignore file for python project

@etnnth Thanks for this PR, but kindly start an Issue for this first, so that I can assign it to you, and then you may start working.
Also, if you're participating for Hacktoberfest, make sure you mention it in the Issue, so I can assign the correct labels.
Lastly, if you want this issue to be a part Hacktoberfest, make sure you create the PR after 1st October.
Closing this PR for now, follow the above instructions to raise the Issue and the PR accordingly. Thanks !


KAFKA-3715: add granular metrics per node

Kafka Streams: add granular metrics per node, also expose ability to …
…register non latency metrics in StreamsMetrics
from https://github.com/apache/kafka/pull/1362#issuecomment-218326690-------
We can consider adding metrics for process / punctuate / commit rate at the granularity of each processor node in addition to the global rate mentioned above. This is very helpful in debugging.
We can consider adding rate / total cumulated metrics for context.forward indicating how many records were forwarded downstream from this processor node as well. This is helpful in debugging.
We can consider adding metrics for each stream partition's timestamp.
This is helpful in debugging.
Besides the latency metrics, we can also add throughput latency in terms of source records consumed.
More discussions here https://issues.apache.org/jira/browse/KAFKA-3715

@guozhangwang, what do you think? I was able to run the examples and see the metrics per node in a jmx console.

Thanks @aartigupta , @enothereska could you take a look first at this ticket? I have assigned you as the reviewer on the ticket, and please feel free to re-assign to me otherwise.

@aartigupta perhaps the PR name should be "KAFKA-3715: add granular metrics per node"? The JIRA number is usually part of the PR name. Minor thing but just for consistency.

Thanks @aartigupta . Two higher level questions: does it make sense to add a unit test or two for the new metrics? And do we have any overhead measurements in the sense of how much to the new recordings add to the end to end latency?

Ran org.apache.kafka.streams.perf.SimpleBenchmark with the following configuration (i.e. without state store backed streams and simple print statements indicating which part of the benchmark is being run)
   System.out.println("producer");
    benchmark.produce();
    System.out.println("consumer ");
    benchmark.consume();
    System.out.println("simple stream performance source->process");
    // simple stream performance source->process
    benchmark.processStream();
    System.out.println("simple stream performance source->sink");
    // simple stream performance source->sink
    benchmark.processStreamWithSink();
    // simple stream performance source->store

//        benchmark.processStreamWithStateStore();
then attached a yourkit profiler and saw the following differences (see attached screenshots)
without any changes to the code and using CPU Sampling in yourkit saw 61% cpu contention
with the per node metrics and using CPU  sampling in yourkit, saw 70% cpu contention,
without any changes
org.apache.kafka.streams.perf.SimpleBenchmark
producer
Producer Performance [MB/sec write]: 8.853212193170378
consumer
[YourKit Java Profiler 2016.02-b38] Log file: /Users/aartikumargupta/.yjp/log/SimpleBenchmark-1754.log
Consumer Performance [MB/sec read]: 4.596191726854892
simple stream performance source->process
Streams Performance [MB/sec read]: 14.361679855964493
simple stream performance source->sink
Streams Performance [MB/sec read+write]: 4.535097423059803
with node metrics
producer
[YourKit Java Profiler 2016.02-b38] Log file: /Users/aartikumargupta/.yjp/log/SimpleBenchmark-1513.log
Producer Performance [MB/sec write]: 4.328603699294551
consumer
Consumer Performance [MB/sec read]: 3.9742312237851367
simple stream performance source->process
Streams Performance [MB/sec read]: 5.686685198591868
simple stream performance source->sink
Ran this multiple times and the results varied between 63%(no changes) and 72%(with per node metrics) The difference seems to be around the point at which yourkit profiler is attached
That said, not sure if this is a valid load simulating scenario
@guozhangwang mentions in https://github.com/apache/kafka/pull/1490 that

if your traffic is very small and consumer is already at the log tail throughout your test, it will cause the polling / processing to be called with less batched data and hence further increased overhead.

@guozhangwang Is the simpleBenchmark a good scenario to be profiling ?
If not any suggestions on another scenario, maybe we can add (check in) such a scenario under examples, which can be used for all similar future profiling exercises

hey @aartigupta it's kind of hard to tell based on your screenshots where the time is going since I don't see any drilldown into the call stacks of the StreamThread run loops. It's probably necessary for you to flip things on in the YourKit profiler so you can get the full call stacks and determine if Sensor.record is the source of most of the time.

Thanks @aartigupta , some general comments:

For naming consistency as with other metrics objects, for finer grained metrics we tend to name the sensors as "level-name.level-id.metrics-name", for example in SenderMetrics we used topic.[topic-name].records-per-batch etc for per topic-level metrics and in SelectorMetrics we used node-[node-id].bytes-sent etc for per node-level metrics, and in my latest PR #1530 I was doing similar naming.

You may already notice that this is for creating different sensors as we synchronize at the per-sensor basis, and since in producer / consumer we always has single-thread, today we do not have any contentions for the lock yet, and in Streams we are trying to add per-thread metrics and consider adding global metrics only after the syncrhonization is removed in KAFKA-3155 since as we have discussed in other PRs with multiple threads contention overhead can be large.

Different metrics reporter has the freedom of constructing their reporting metrics name from the hierarchy of "metrics-prefix, group-name, metrics-name, metrics-tags" where metrics-prefix are "kafka.producer" / "kafka.consumer" / "kafka.streams" depending on which client library you are using. And in this case the sensor names are actually ignored as they are only used within the metrics object for grouping different metrics only. For example in JmxReporter we create the mbeanName / attributeName as

mbean: prefix: type="group-name", tag1key=tag1value, ..., tagNkey=tagNvalue
    attribute1: metrics-name1
    attribute2: metrics-name2
    ...

So we need to make sure that the hierarchy is sufficient for different reporters to differentiate these metrics in their own space.

Btw the SimpleBenchmark numbers are pretty low compared to my laptop (4GB memory, and low-end CPUs). What environment did you run the profiler?

@guozhangwang     Mackbook 12 inch 2015 early edition, 1.3GHz dual-core Intel Core M processor (Turbo Boost up to 2.9GHz) with 4MB shared L3 cache.
8GB of 1600MHz LPDDR3 onboard memory
I think that it has to do with attaching yourkit profiler.
Without the profiler I get the following
producer
Producer Performance [MB/sec write]: 22.247686586525987
consumer
Consumer Performance [MB/sec read]: 56.39283169836138
simple stream performance source->process
Streams Performance [MB/sec read]: 40.33237957119899
simple stream performance source->sink
Streams Performance [MB/sec read+write]: 18.71113212350438
Process finished with exit code 0

Is there a way to register user-defined metrics?

@aartigupta would you still have time for this PR or should I have a look? Thanks.

Added two levels of logging metrics, as described in KAFKA-3811. Showing performance of PR when logging all metrics, vs just some higher level metrics in streams (see last two bars of each benchmark, the rest is details)

@ijuma @guozhangwang As part of this PR we are introducing different levels of logging for sensors, as initially described in KAFKA-3811 https://issues.apache.org/jira/browse/KAFKA-3811?focusedCommentId=15324669. Could you see if you are satisfied with the way these levels are introduced?

(PR failures due to known Reset tests)

@theduderog registering user-defined metrics will be in another JIRA. Thanks.

@enothereska Looks good! thanks for cleaning it up and taking the PR forward.Did you use simple benchmark for the perf counters? , can you share the example use case /automated test that you ran?

Thanks @aartigupta
I did use yourkit, but the final numbers I put on the PR are using SimpleBenchmark.java that is included with Streams. That runs locally on my MacBook Pro 16GB, SSD, dual core. So on one node we have Kafka and the SimpleBenchmark application. I don't think yours was a measurement error, but some metrics were missing back then.

Test passed. Weird error on jenkins: hudson.remoting.Channel@8690f26:ubuntu-4: java.io.IOException: Remote call on ubuntu-4 failed

@dguy @mjsax if you have time.

@aartigupta @enothereska About the synchronization overhead, I think Jay was referring to KAFKA-3769 and I have fixed in some time ago (you can see the graphs before and after the fix): https://github.com/apache/kafka/pull/1530

@enothereska Thinking about it a bit more, I now understand your arguments before: tags were not used to distinguish sensors in the sensor registry (i.e. ConcurrentMap<String, Sensor> sensors), so without the processor-node as part of the sensor name they will collapse into the same sensor, that can be potentially accessed by multiple threads.
In that case, you are right that we do need to have both the processor node name as well as the task id string as part of the NodeMetrics sensors, and have the task id string as the TaskMetrics sensors.
Your current naming as the format of
thread.streams-thread-XXX.task.1-1PROCESSOR-XXX-processor-throughput

where thread.THREAD-ID comes from the prefix in StreamsMetricsImpl. And there is no separators between taskId and processor name, and we use the - separator between processor name and the actually sensor name. I am wondering if we could remove this prefix and refactor the rest prefixes as
task.1-1.PROCESSOR-XXX.processor-throughput

The reason is that tasks can migrated between threads from time to time, and when that happens some of the existing sensor will not have any data any more while some more sensors need to be created if we keep the thread id as the prefix, and for using the . separator it is mainly for consistency with other sensors.
Ditto for task metrics as well.

@guozhangwang about your latest comment, when a task migrates, when we close the topology, I remove all previous sensors. So when the task migrates it will only have new sensors. The old sensors will be gone. Let me know what you think. Thanks.

Will be adding unit tests shortly.

@enothereska What I meant is mainly around user experience: by having task / processor-node level metrics to be distinguished by the thread name (e.g. define sensor name as  thread.streams-thread-XXX.task.1-1.PROCESSOR-XXX-processor-throughput), users then need to enumerate all possibly created sensors in their monitoring system and / or web UI, while only of them will be valid / having non-blank graphs at a given point of time; on the other hand, since at any given time only one thread will be owning the task / processor node, it is safe to collapse them into a single sensor that could be accessed and updated by different threads at different times, and users then can simply polling / monitoring this single sensor (e.g. task.1-1.PROCESSOR-XXX-processor-throughput).

@guozhangwang I agree with you on removing the thread prefix. Will do so with next commit. Thanks.

@enothereska Is this relevant?

* Where:
Build file '/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk7-scala2.10/build.gradle' line: 385

* What went wrong:
A problem occurred evaluating root project 'kafka-pr-jdk7-scala2.10'.
> Failed to apply plugin [id 'org.scoverage']
   > Could not create an instance of type org.scoverage.ScoverageExtension_Decorated.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

@guozhangwang I don't think so, looks like an environment one.

Updated performance graph (avg of 3 runs). A couple of takeaways:

Trunk and PR have comparable performance in the "no metrics recorded" case

Both trunk and PR see a similar drop in performance when collecting some metrics (INFO)

Notice how the PR's INFO metrics does better than Trunk's metrics. That is because in the PR the state store metrics are now DEBUG, so we're collecting fewer metrics by default. I'll get another graph where the PR temporarily assigns INFO to the store metrics, for a better apple-to-apple comparison.

Worst case scenario drop in perf for DEBUG: 60%. Best case drop: 20%

Worst case drop in perf for INFO: 11%. Best case drop: 3% (compare with current trunk below).

Worst case drop in perf for trunk metrics: 17%. Best case drop: 9%.

Thanks for the newly updated stats @enothereska . A few quick question:

For the comparison you mentioned above "worst case .. best case", they are all compared with trunk with metrics turned on right?

Regarding Worst case drop in perf for INFO: 11%. Best case drop: 3% (compare with current trunk below). since you mention this PR's INFO metrics perf is better than trunk's metrics, I was assuming that the best case perf drop should be a negative ratio?

Regarding Worst case drop in perf for trunk metrics: 17%. Best case drop: 9%. What does this mean? I thought for trunk metrics it means INFO + state store metrics, but it seems you have not got the results for this yet.

@guozhangwang not quite, I've updated my notes in the above comment to clarify.

Updated with an additional run where we collect both INFO + state store metrics (just like trunk does now). Overall, the main takeaway is that we're not introducing any particular overhead with the PR with an apples-to-apples comparison with Trunk.

Thanks @ijuma I think I addressed your comments.

@aartigupta @enothereska Some of the comments seem not addressed yet, and could you rebase as well?

@guozhangwang I removed the extra sensor registration APIs as you suggested, and I also agree with the rest of your comments and have addressed them. Thank you.

@guozhangwang I removed the extra sensor registration APIs as you suggested, and I also agree with the rest of your comments and have addressed them. Thank you.

@enothereska @aartigupta Made another pass over the latest patch. LGTM overall. Just one minor comment about testing coverage: would you consider adding some test cases for StreamMetricsImpl inside StreamThreadTest as well, for testing is naming conventions, etc?

test this please

@guozhangwang what do you mean by test this please? Which part? Thanks.

@enothereska
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin :)

wow!

Unrelated error: kafka.integration.UncleanLeaderElectionTest.testUncleanLeaderElectionDisabled

unrelated: kafka.api.SslProducerSendTest.testCloseWithZeroTimeoutFromSenderThread

The old org.apache.kafka.streams.integration.ResetIntegrationTest failure is back but shouldn't be related to PR.

Merged to trunk. Many thanks to @aartigupta and @enothereska !!


add updatedb volume mount

fix https://github.com/juicedata/juicefs-csi-driver/issues/320

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c3e840f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage          ?   51.85%
=========================================
  Files             ?       25
  Lines             ?     2505
  Branches          ?        0
=========================================
  Hits              ?     1299
  Misses            ?     1124
  Partials          ?       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e840f...89a409d. Read the comment docs.


fix: splitable duplicate records

What this PR does / why we need it:
fix: splitable duplicate records

Does this PR need to be backport to the previous release branch?:

release/3.9
release/3.8

/cc @zexi @ioito @wanyaoqi

/lgtm


Add windows install script

There is a windows install script here: https://github.com/BlackstoneEngineering/yotta/tree/get_yotta_win_script
It should be brought in as part of the release of yotta and periodically updated to make installing yotta on windows easier. Or at the very least provide it as an option. It simply downloads the dependencies and runs the installers in order. It assumes Python and Pip are installed on the system, this is a safe assumption as of Python 2.9 where pip and python are bundled together at install time.

There's an open pull request for this. Is that up to date?

There is a pull request, here https://github.com/ARMmbed/yotta/pull/132 ,
It is not up to date, it was put together for the alpha1 release and needs updated links (ie remove pycrypto, update cmake link) nothing major. The script was meant as a git_pip.py style yotta install script. There are hooking for adding commands to auto-install yotta for mac and linux as well. In theory this script could become the one stop shop for grabbing yotta.
-Austin

To clarify, I think this script should be added for Alpha2 testing in prep for actual release as part of the Beta, because it seems to be the only viable option for installing on windows, the current mess is not acceptable for a release to the general public. It is simply too complex.

I've merged the script. One question:

if the python version is 2.7.9, is it still necessary to open IE to download certificates? (Python 2.7.9 included updates to SSL certificate verification that might have fixed that)

Unclear, didnt test that case. It was an issue with the website and windows itself so ... maybe? I'll retest in the next OoB


Adding a license to the project

Resolves #38. Adds the NCSA license to the ClickIn project.

Well done 👍


Crash while registerning EventBus

App is crashing when I am trying to register
e.g EventBus.getDefault().register(CitrusClient.this);
This happens only on android 4.1.1 and its working fine 5.0.2
Any one has any solution to fix this issue?

You would need to post more code for this to get an answer. In what context are you statically referencing the CitrusClient.this?


upgrade log4j and move from sdk to example

fix log4j issue on master and cherry pick to release branch later.

upgrade log4j version to 2.15.0
indeed, sdk does not need log4j. move it to example.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MERN_Express: 4.0 Intro to Postman (A)

Description
:pushpin: Minimum points to be covered.

What's a Postman brief detail about.
Why do we use it.
Alternatives of Postman. Examples only.

:file_folder: Project Directory
Branch MERN>MERN/Topic/Backend/Express/
:paintbrush: Filename
4.0_Introduction_to_Postman(A).md
Happy Contributing :partying_face::raised_hands:

Doubt? Reach me on Discord.
hacktoberfest-accepted
Domain
MERN
Type of Contribution
Audio
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

I would like to work on it.
/assign

do we have to submit an audio recording in this issue?

do we have to submit an audio recording in this issue?

yes


Add prefix support for ignored/immutable class lists

We currently support immutable class lists, for now lets not worry about prefixes.


Fixed #15: Add remove all option

This ties in with the 'confirm' dialog of the standard removal option

This fixes #15

@Jameskmonger just going to wait until #14 is merged and then v0.7.0 will be complete, then I will merge this pull in :smile:

No problem @himynameisdave - I'll get on that this evening!

@Jameskmonger thanks man, appreciate it!

All done @himynameisdave !

Want me to sort the conflicts out on this @himynameisdave ?

Merged changes into #58


Fixes #7 to merge parameter names correctly

Probably someone smarter has a better way to do it, but to solve the parameter names getting dinged up, I simply added a temporary string during parameter name substitution that prevents it from being mistakenly replaced on subsequent parameter renames.
Then the last return removes this temporary string (DQB:@:DBQ)
Note, my Feature/reuse parameters pull request also includes this fix.

Fixed in 1f4cd2426bfaa2c0a4498af3c6a4e52d7ed8ea4b using regex


Landcover plugin the maximum consecutive months of a pixel being vegetation

The logic is described as follows:

FC bands are masked by valid:=0x000x_xx00 & ue < 30 where x means any value of {0, 1}
WO band are classifies as wet:=0x1000_0x00, hence the valid wet+dry pixels are wet | valid
FC bands grouped by solar day with mean, WO bands on nodata=np.nan
Monthly medians are taken over FC bands and wet band for further classification of veg vs. non-veg
veg:= pv>bs | npv > bs & wet <= 0, where wet > 0 implies that at least half of observations  in a month pixels being wet, otherwise non-veg. nan := nodata.
count and save the maximum consecutive months that pixels being veg, where nan (or nodata) is considered to be neither veg nor non-veg. Though it doesn't break consecutiveness either, e.g., a sequence of {1, nan, 1, 1} is deemed as 3 consecutive months, where 1 indicates veg, while a sequence of {1, 0, 1, 1} is deemed as 2 consecutive months as 0 breaks consecutiveness and hence number is reset.

Note:
pylint hook in pre-commit ci is out of date and it failed in python 3.12. I don't see any way to fix it, hence made pylint a local hook and skip in ci.

I have marked the awful name as an issue to be resolved along development progressing


Deleting environment variables for Lambda function in one environment causes amplify push to fail in another environment

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v14.21.1
Amplify CLI Version
10.5.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
function
Amplify Commands
push, update
Describe the bug
Deleting environment variables for Lambda function in one environment causes amplify push to fail in another environment.
Expected behavior
amplify push should not fail.
Reproduction steps

amplify init -y
amplify add env [create an environment named "prod"]
amplify add function [create a lambda function with an environment variable]
amplify push
amplify env checkout dev
amplify push
amplify update function [delete the environment variable]
amplify push
amplify env checkout prod
amplify push

amplify push fails with this error message:

🛑 The following resources failed to deploy:
🛑 Resource is not in the state stackUpdateComplete

GraphQL schema(s)

# Put schemas below this line

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

Hey @goldbez what was the error you were receiving from the failed push attempt?


[SPARK-30189][SQL] Interval from year-month/date-time string should handle whitespaces

What changes were proposed in this pull request?
Currently, we parse interval from multi units strings or from date-time/year-month pattern strings, the former handles all whitespace, the latter not or even spaces.
Why are the changes needed?
behavior consistency
Does this PR introduce any user-facing change?
yes, interval in date-time/year-month like
select interval '\n-\t10\t 12:34:46.789\t' day to second
-- !query 126 schema
struct<INTERVAL '-10 days -12 hours -34 minutes -46.789 seconds':interval>
-- !query 126 output
-10 days -12 hours -34 minutes -46.789 seconds

is valid now.
How was this patch tested?

add ut.

cc @cloud-fan @maropu, thanks in advance.

Test build #115035 has started for PR 26815 at commit 534667b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19855/
Test PASSed.

also cc: @MaxGekk

Just in case, have you checked the changes of performance numbers in IntervalBenchmark? No change?

@yaooqinn Maybe I have missed something but where does the requirement of supporting \n, \r ( and anything behind of  ) come from?

Before patching the buggy method, can we wait till this https://github.com/apache/spark/pull/26473 be merged?

Just in case, have you checked the changes of performance numbers in IntervalBenchmark? No change?

AFAIK，IntervalBenchmark only test multi unit interval strings

@yaooqinn Maybe I have missed something but where does the requirement of supporting \n, \r ( and anything behind of  ) come from?

We have support dealing with ISO whitespaces for almost all internal types

Test build #115035 has finished for PR 26815 at commit 534667b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115035/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24258/
Test PASSed.

is this still valid?

I will check this fix as ASAP, thanks for reminding me.

Test build #119612 has started for PR 26815 at commit 4556ad4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24341/
Test PASSed.

Test build #119612 has finished for PR 26815 at commit 4556ad4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119612/
Test PASSed.

thanks, merging to master/3.0!


all inputs trigger input event half the time

Reproduction
playground
Describe the bug
bug:
all inputs trigger input event half the time (open dev console to see logs)
expected:
̶s̶h̶o̶u̶l̶d̶ ̶o̶n̶l̶y̶ ̶t̶r̶i̶g̶g̶e̶r̶ ̶o̶n̶e̶ ̶i̶n̶p̶u̶t̶ ̶e̶v̶e̶n̶t̶ ̶f̶o̶r̶ ̶t̶h̶e̶ ̶c̶u̶r̶r̶e̶n̶t̶ ̶f̶o̶c̶u̶s̶e̶d̶ ̶e̶l̶e̶m̶e̶n̶t̶
edit: should either

trigger one input event for the current focused element (every time)
trigger all input events (every time)

Environment
• FormKit beta 11
thanks in advance :)

This behaviours is because v-model pass down the value to its children input, so it triggers because of that.
Not sure why it only trigger all on half of inputs.

I would also aspect that only the current focused input would trigger the input event.

@MortenHe Are you experiencing this issue locally in a project or only in the FormKit playground?
The reason I ask is that I've identified an issue with the Vue import in the playground that I don't fully understand yet but it's affecting this issue. Here's your playground with the only change being updating import { ref } from 'vue' to import { ref } from './vue' and I'm now getting expected behavior. When I change an input I see console logs only for that input.
https://formkit.link/5f726eed76be270c57a1482f82368a18
😓 It's a weird one, but wanted to confirm you were seeing this issue in a project outside of the FormKit playground in a way that prompted you to open this issue.

@andrew-boyd I had the issue in local project

I am also experiencing this locally, I reproduced it with this snippet:
<script setup lang="ts">
const onChange = (nr: string, value: string) => {
  console.log("Change to", nr, value);
};
</script>
<template>
  <FormKit type="form">
    <FormKit type="text" @input="(val) => { onChange('1', val); }" />
    <FormKit type="text" @input="(val) => { onChange('2', val); }" />
    <FormKit type="text" @input="(val) => { onChange('3', val); }" />
  </FormKit>
</template>

On load, the first two inputs emit an input event with an undefined value. But not the third.
It does not seem related to refs as I don't use them here.

This is fixed on the @next tag (future release 0.17.x). You can check it out in the playground by switching to the next version in the version dropdown. 👍


Unified trap description

"errormsg" -> "trap"

Codecov Report

Merging #97 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   68.91%   68.73%   -0.18%
==========================================
  Files          33       33
  Lines        3349     3349
==========================================
- Hits         2308     2302       -6
- Misses        783      788       +5
- Partials      258      259       +1

Impacted Files
Coverage Δ

exec/vm.go
86.77% <0%> (-2.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ad9bf...c37fc0e. Read the comment docs.

Sure. PR: https://github.com/go-interpreter/license/pull/10

Wait  a minute, I missing CONTRIBUTORs

Done 👍


python312Packages.cdcs: disable failing test

ZHF: #352882

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352975

x86_64-linux

:x: 4 packages failed to build:

python311Packages.atomman
python311Packages.atomman.dist
python312Packages.atomman
python312Packages.atomman.dist

:white_check_mark: 12 packages built:

python311Packages.cdcs
python311Packages.cdcs.dist
python311Packages.potentials
python311Packages.potentials.dist
python311Packages.yabadaba
python311Packages.yabadaba.dist
python312Packages.cdcs
python312Packages.cdcs.dist
python312Packages.potentials
python312Packages.potentials.dist
python312Packages.yabadaba
python312Packages.yabadaba.dist

phonopy is already broken on master.


types: type safer implementation and more accurate inference of return value type for shake

Description

Type Fix: Fix the problem that the return value of shake() function is always a null object by TypeScript inference.
Comment Add: Sample code added to the JsDoc for the shake() function.

Checklist

[x] Changes are covered by tests if behavior has been changed or added
[x] Tests have 100% coverage
[ ] If code changes were made, the version in package.json has been bumped (matching semver)
[x] If code changes were made, the yarn build command has been run and to update the cdn directory
[ ] If code changes were made, the documentation (in the /docs directory) has been updated

Resolves
Resolves #388

Hi @AliubYiero, your fix is available in radashi@beta today (see #12). An official release is pending. We'd love to have you participate in the discussion and/or development of the radashi-org/radashi fork. 😄


df , ifconfig ,ping Error!!

hi, I curl www.microsoft.com successful.
root@localhost:/mnt/c/Users/litian# curl www.microsoft.com
Microsoft Corporation
Your current User-Agent string appears to be from an automated process, if this is incorrect, please click this link:United States English Microsoft Homepage
but, I do these failed
root@localhost:/mnt/c/Users/litian# df
df: cannot read table of mounted file systems: No such file or directory
root@localhost:/mnt/c/Users/litian# ifconfig
Warning: cannot open /proc/net/dev (No such file or directory). Limited output.
root@localhost:/mnt/c/Users/litian# ping www.google.com
ping: icmp open socket: Socket type not supported
I had tried lxrun /uninstall and then lxrun /install, but it is still the same issue.
how can I do?

@litianZ - Network tools such as ping\ifconfig not working is a known issue\limitation at the moment, unfortunately. The failure in these tools is not an indication of lack of network. See #66. If your network is working, you should be able to still apt-get packages and work with them. Please up vote the user voice page as indicated in #66. If network is working fine for you, I would suggest marking this as dupe of #66. And, thanks for trying out WSL and giving us feedback.

About df, take a look at #150 for a workaround :wink:

df and ping now work, I'm going to close this out as a duplicate of #66.

Small update: As of build 14926, ping can run in a non-elevated bash instance.


bar-button-menutoggle class causing right button misaligned

There is a small CSS bug in Ionic 2:
<ion-navbar *navbar>
  <ion-title>Getting Started</ion-title>

  <ion-buttons start>
    <button menuToggle="leftMenu">
      <ion-icon name="menu"></ion-icon>
    </button>
  </ion-buttons>
  <ion-buttons end>
    <button menuToggle="rightMenu">
      <ion-icon name="menu"></ion-icon>
    </button>
  </ion-buttons>
</ion-navbar>

It resulted this

I have to override with this:
.bar-button-menutoggle {
  display: inline-flex;
}

Thanks for opening an issue with us! Would you mind updating your project to the latest version of Ionic 2 and seeing if you still have this issue? Thanks!

Hello! Thanks for opening an issue with us! Since it has been a little while since there was any activity on this issue i will be closing it, but feel free to reopen this issue if needed!


Make the ethereum-tracker PR work

Motivation
The oracle have been implemented but we did not test it. This is now done.
Proposal
The following was done:

The FetchJson was taking just the URL and now is taking url/payload.
The ethereum-tracker smart contract was introduced.
The end-to-end test is introduced.

Some additional improvements to ethereum features and use statements are possible.
Test Plan
One additional test has been added which is the point of the PR.
Release Plan
We are starting to have Ethereum developing, so we will need to put some documentation for it.
Links

reviewer checklist

(To fix the tests you'll need to apply cargo insta.)

In the title, did you mean to write this?

Make the ethereum-tracker example application work

In the title, did you mean to write this?

Make the ethereum-tracker example application work

Ok, renamed.

@MathieuDutSik: Did you add a comment somewhere, why this specific revision is needed?
alloy = { git = "https://github.com/alloy-rs/alloy", rev = "b79db21734cffddc11753fe62ba571565c896f42", default-features = false }