Built-in theme picker

Add a config directive to apply a theme to the windows. Sway will ship with default colorschemes that can be applied by the user, or serialized in json format and applied from a file.
Example:
colorscheme solarized
colorscheme ~/.config/sway/my-theme.json

A variety of themes are available from the i3-style project that can be used for default themes.
I know from my support of i3 in the irc chat, and the popularity of my i3-style project, that this is a highly demanded feature among users. A quick survey of i3 desktop images available on the internet indicates to me that nearly everyone does some sort of customization to their colorscheme. Many more users who do not want to expend the effort searching for tools would customize their colors if it were easy, improving the experience of sway. It makes sense to provide a way to do this that is as user friendly as possible.

Do you think a similar feature is going to land in i3 (not that I'm necessarily opposed to having this sort of feature in sway)?
I would also prefer to see this implemented with something like the include command (which is unique to sway but is under discussion for inclusion in i3), which would be able to simply include colorschemes from ~/.config/sway/conf.d or whever you like in the form of simple i3 configs.

No, this feature was rejected from i3 so you don't have to worry about api conflicts.
An include would not work for bar colors because they must be configured within the bar block and including a bar block in the include makes themes unportable. It still leaves users to search for themes, which is overhead to customization.

Good point. Can we explore alternate ways of setting bar colors instead? For example, in #547 we talked about things like having bars configured like this:
bar "id" {
    ...
}

Which would expand to things like:
bar "id" ...

How about supporting something like bar * ... to support configuring properties that all bars inherit by default?

Sure, that would work. Then you could include a default search path to resolve a relative path for the colorscheme, so something like colorscheme solarized expands to /usr/path/to/solarized.config` behind the scenes.
That approach would be simple, but you gain a lot with a json format. Look at this colorscheme for solarized. It is very easy to read and modify. It gives you color aliases to make it even easier to modify. That could be done with variables, but the i3 config format is difficult to read because you have to look up what the positional arguments of the color directives are.

Since the include directive supports shell expansion, maybe we could do something like this:
include `i3-style solarized`

Which would dynamically rejigger the JSON schemas i3-style already supports into something i3-config-like and drop it in /tmp or something. Thoughts?

If you're just including what comes from stdout, that would take an argument like i3-style solarized --colors-only but that's not hard to do. However, it would have to be sway-specific because the top level bar config directives will not be supported by i3.

And then things like i3-style could install something to /etc/sway/config.d/i3-style or similar and it would just werk. Sounds like a good plan. I'm okay with programs having to write sway specific code to take advantage of sway specific features.

Well if it's a separate utility, people still have to search for it and go through the install steps, which requires the technical ability of a developer, and they still have to be clever enough to put all of that together. If you're ok with that, it's fine, but I think the built-in colorscheme directive is still the best choice.
So if it's a separate utility, how about adding a page to the wiki explaining how to change the colorscheme?

A place on the wiki sounds like a great place to discuss that. As for avoiding a seperate utility and using the colorscheme directive to support it, well, I feel like that's out of scope if we can find an acceptable solution for it built on top of sway's existing mechanics. As a bonus I feel it'll expand the usage of installing sway config.d files with packages to extend sway's functionality for them.

Actually after thinking about it, I think the way the tool is used now is superior because I don't have to have it installed for my theme to work which is one less moving part per machine (I don't have it installed now actually).

I don't think that's a very strong use-case, since you can also just do something like i3-style solarized > .config/sway/config.d/colorscheme or something similar and then remove i3-style.

Yeah or you could do i3-style solarized -s and it will modify your config in place and then remove i3-style. Then you don't have to have two config files, which is one less moving part. Flat is better than nested.

Either way.


Keep swift build from toolchains working on Mojave

Hi Apple,
would you consider this change please? At the moment swift build does not work on Mojave when using an overnight development toolchain from swift.org and the toolchain build fails preventing those of us who can’t upgrade to Catalina from working on the compiler/toolchain.
Cheers
Error is:
 johnholdsworth$ ~/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-05-11-a.xctoolchain/usr/bin/swift build
dyld: lazy symbol binding failed: Symbol not found: _objc_opt_self
  Referenced from: /Users/johnholdsworth/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-05-11-a.xctoolchain/usr/bin/swift-build (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libobjc.A.dylib

dyld: Symbol not found: _objc_opt_self
  Referenced from: /Users/johnholdsworth/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2020-05-11-a.xctoolchain/usr/bin/swift-build (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libobjc.A.dylib

Abort trap: 6

@swift-ci please test

This looks reasonable to me.  @neonichu or @aciidb0mb3r, do you see any issues this would cause?


chore(WEBRTC-1856) Refine firebase tests to remove duplicates and reduce runtime

WEBRTC-1856 - Refine firebase tests to remove duplicates and reduce runtime

This PR refines our pipeline because we were using multiple tests that essentially tested the same thing - this meant a very large and unnecessary run time to test what was essentially the same thing.
eg.
Test Join Room
Test Join Room and toggle video
Test Join Room and toggle video and audio.
Test Join Room and toggle video and audio check stats
In the case of the above, we removed the first 3.
I also removed the requirement to run Unit tests before the firebase tests because we do the unit tests as a part of other pipeline runs.
Finally, we introduce a local property which will be replaced by a Github secret so that the tests can run with a valid API Key
:older_man: :baby: Behaviors
Before changes
Unnecessary tests that are testing the same thing
Running unit tests multiple times when opening a PR
No valid API key to run the tests
After changes
Refine tests to reduce run time
Only run unit tests once per PR
API Key being applied as a Github Secret at runtime
✋ Manual testing

Run firebase tests locally

Code looks clean and easy to understand.
Okay to merge. 👍


Error in npm install

Hi,
I am getting the following error when trying to do npm install, can you please help me how to resolve it:
npm ERR! Linux 3.10.0-1160.42.2.el7.x86_64
npm ERR! argv "/root/miniconda3/bin/node" "/root/miniconda3/bin/npm" "install"
npm ERR! node v6.13.1
npm ERR! npm  v3.10.10
npm ERR! path<EMAIL_ADDRESS>npm ERR! code ENOTDIR
npm ERR! errno -20
npm ERR! syscall open
npm ERR! ENOTDIR: not a directory, open<EMAIL_ADDRESS>npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR!     /home/GraphGPT/npm-debug.log

This one was solved by increasing timeout for npm
npm config set timeout 6000000


Synopsys: Automated PR: Update org.hsqldb:hsqldb:2.3.4 to 2.7.3

Vulnerabilities associated with org.hsqldb:hsqldb:2.3.4
BDSA-2022-3330 (HIGH): HyperSQL DataBase is vulnerable to remote code execution (RCE) due to improper input validation thus allowing unsafe reflection. An authenticated attacker could exploit this by supplying a crafted input to potentially execute code on the application.
Click Here To See More Details On Server

Automated PR Comment From BlackDuck

❌ Found dependencies violating policy!

Policies Violated
Dependency
License(s)
Vulnerabilities
Short Term Recommended Upgrade
Long Term Recommended Upgrade
Resolved / Filtered Out

No High Severity Vulns
tough-cookie
N/A
❌   BDSA-2023-1661 HIGH CVSS 8.8

5.0.0 (0 known vulnerabilities)
:grey_exclamation:

No High Severity VulnsNo Critical Vulnerabilities
PostgreSQL JDBC Driver (pgjdbc)
N/A
❌   CVE-2024-1597 CRITICAL CVSS 9.8❌   CVE-2022-31197 HIGH CVSS 8.0
9.4-1206-jdbc42 (2 known vulnerabilities)
42.7.4 (0 known vulnerabilities)
:grey_exclamation:


Does not compile on rustc 1.19.0-nightly (f4209651e 2017-05-05)

error[E0433]: failed to resolve. Could not find `Options` in `test`
   --> src/lib.rs:146:18
    |
146 |         options: test::Options::new(),
    |                  ^^^^^^^^^^^^^^^^^^ Could not find `Options` in `test`

error[E0560]: struct `test::TestOpts` has no field named `options`
   --> src/lib.rs:146:9
    |
146 |         options: test::Options::new(),
    |         ^^^^^^^^ `test::TestOpts` does not have this field

error: aborting due to previous error

Looks like this is caused by #63. I believe that commit should be reverted until rustup begins serving a nightly version that includes the break. This dashboard shows that the 2017-05-07 nightly is not out. @SimonSapin

I have an obvious conflict of interest on what should be done with this crate/repo :)
But in the meantime you can downgrade with cargo update -p compiletest_rs --precise 0.2.5

I can downgrade but putting that command in the .travis.yml of every project that uses compiletest in CI, and then removing it when a new nightly is out, is not reasonable. I believe the change should be reverted until the new nightly is available and being served by rustup.

Fair. I hadn’t thought of CI. It’s up to @laumann or @Manishearth to yank 0.2.6.

I can yank 0.2.6 and wait until nightly 2017-05-07 is out - I guess I can just undo the yank later?

Yes, cargo yank --undo is a thing.

Thanks!

The nightly is out. Please unyank 0.2.6

Side note: maybe it would help to enable travis on this repository? There's a .travis.yml, but travis doesn't run.

@oli-obk: It's unyanked


Added the service workers primer.

@jpmedley I've created this PR with all the service worker material to facilitate commenting.

Reviewed.
@jpmedley, there's obviously a lot of feedback. I've granted to push access to my forked repo, so if you want to address the feedback you can then push an update to the with-service-workers branch.

@jeffposnick The only two outstanding issues related to the debugging section. As I said in my comment to that, the redesign was much farther away when I drafted this. I've removed a transition so that we could publish this without the debugging. I'll redo that when I get back from Christmas break.

@jeffposnick
PTAL

PTAL.
I didn't realize you'd done this or I would have gotten back sooner.

@jeffposnick I think Pete still wants this. Let's see if we can knock it out this week.

It looks like my feedback's been addressed with the current text, @jpmedley.


URL double encoded

Hi Jesse,
I have an other issue with discostagger :/
When I try this command line :
python ~/code/ext/discogstagger/discogs_tagger.py -r 3406100 -s Nordic\ by\ Night
I get this result :
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /release/3406100 HTTP/1.1" 200 2225
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /artist/Lindstr%25C3%25B8m HTTP/1.1" 404 75
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /artist/Lindstr%25C3%25B8m HTTP/1.1" 404 75
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /artist/Lindstr%25C3%25B8m HTTP/1.1" 404 75
Traceback (most recent call last):
File "/home/cmaussan/code/ext/discogstagger/discogs_tagger.py", line 484, in
logging.info("Tagging album '%s - %s'" % (release.artist, release.title))
File "/home/cmaussan/code/ext/discogstagger/discogs_tagger.py", line 141, in artist
return self.clean_name(artist.data['name'])
File "/home/cmaussan/code/ext/discogstagger/discogs_client.py", line 90, in data
raise HTTPError(status_code)
discogs_client.HTTPError: HTTP status 404: Not Found.
I can see it's because of the double encoding in URL. The GET should be /artist/Lindstr%C3%B8m and it's actually /artist/Lindstr%25C3%25B8m. I tryed to comment the  urllib.quote( of line 81 in discogs_client.py but nothing changed :(
Maybe it's in requests.get ...
Do you have any idea ?
Thanks,
Camille.

Thanks again for reporting this.
The following is likely a problem with the data returned from the API, I will have a look at this problem later
DEBUG:requests.packages.urllib3.connectionpool:"GET /artist/Lindstr%25C3%25B8m HTTP/1.1" 404 75

But I shouldn't be calling the Artist class in the first place. The artist name property is available in the Release class, so the extra call to the API can be removed (and error averted). I have made a small change to the way that the artists.name is accessed. You should no longer see this error, your release id now passes (see version 0.6).
 ./discogs_tagger.py -r 3406100 -s Nordic\ By\ Night
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /release/3406100 HTTP/1.1" 200 2225
INFO:root:Tagging album 'Lindstrøm - Nordic By Night - Tsugi Sampler 49'
INFO:root:Creating destination directory 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/01-Todd_Terje-Myggsommer.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/02-Bjork-Crystalline_(Omar_Souleyman_Version).mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/03-Lumeet-Llyonesse_Zero.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/04-Mungolian_Jet_Set-We_Are_The_Shining_(Dan_Lissvik_Remix).mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/05-Magnus_International-Gamlefar.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/06-Ultracity-Azura.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/07-Carmen-Life_Is_Sin_(Prins_Thomas_Remix).mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/08-When_Saints_Go_Machine-Jets.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/09-Sandra_Kolstad-Leone.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/10-Ceo-White_Magic.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/11-Young_Dreams-Flight_376.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/12-The_Field-Is_This_Power.mp3'
DEBUG:root:Tagging 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/13-Gus_Gus-Selfoss.mp3'
INFO:root:Deleting source directory 'Nordic By Night'
INFO:root:Generating .nfo file
DEBUG:root:Writing file 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/00-Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49.nfo' to disk
INFO:root:Generating .m3u file
DEBUG:root:Writing file 'Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49-(TSUGI_49)-2012-jW/00-Lindstrm-Nordic_By_Night_-_Tsugi_Sampler_49.m3u' to disk
INFO:root:Downloading and storing images
DEBUG:root:Downloading image 'http://api.discogs.com/image/R-3406100-1329153544.jpeg'
DEBUG:root:Downloading image 'http://api.discogs.com/image/R-3406100-1329153557.jpeg'
INFO:root:Tagging complete.

Yes it works :)
Thanks again.

Hey Camille.
You may want to update your requests library to latest and greatest as well. There were a few url encoding problems in initial 10.x releases. i have confirmed 10.4 (current as of today) works well .
see here for some additional comments : https://github.com/discogs/discogs_client/pull/11

Hi Jesse,
Thanks for the notice. I'll do that ;)


samba client pod is not coming up after k apply -f client-test-pod.yaml

steps :

create a minikue deployment
clone the repo and make deploy
$ k config set-context --current --namespace=samba-operator-system
$ # k get pods
NAME                                                 READY   STATUS    RESTARTS   AGE
samba-operator-controller-manager-844d976b7b-nlgqb   2/2     Running   0

[a@dhcp47-98 files]$ k apply -f client-test-pod.yaml
pod/smbclient created
[a@dhcp47]$ k get pods
NAME                                                 READY   STATUS              RESTARTS   AGE
samba-ad-server-86b7dd9856-shvxp                     1/1     Running             0          46m
samba-operator-controller-manager-844d976b7b-nlgqb   2/2     Running             0          19h
smbclient                                            0/1     ContainerCreating   0          30m -->> pod is not comming up

events:
35m         Normal    Scheduled           pod/smbclient                                            Successfully assigned samba-operator-system/smbclient to minikube
34m         Warning   FailedMount         pod/smbclient                                            MountVolume.SetUp failed for volume "data" : configmap "sample-data1" not found
27m         Warning   FailedMount         pod/smbclient                                            MountVolume.SetUp failed for volume "data" : configmap "sample-data1" not found
25m         Warning   FailedMount         pod/smbclient                                            Unable to attach or mount volumes: unmounted volumes=[kube-api-access-45s5r data], unattached volumes=[kube-api-access-45s5r data]: timed out waiting for the condition
4m36s       Normal    Scheduled           pod/smbclient                                            Successfully assigned samba-operator-system/smbclient to minikube
2m28s       Warning   FailedMount         pod/smbclient                                            MountVolume.SetUp failed for volume "data" : configmap "sample-data1" not found
2m33s       Warning   FailedMount         pod/smbclient                                            Unable to attach or mount volumes: unmounted volumes=[data], unattached volumes=[data kube-api-access-88s6g]: timed out waiting for the condition
87s         Normal    Scheduled           pod/smbclient                                            Successfully assigned samba-operator-system/smbclient to minikube
24s         Warning   FailedMount         pod/smbclient                                            MountVolume.SetUp failed for volume "data" : configmap "sample-data1" not found
16s         Warning   FailedMount         pod/smbclient                                            Unable to attach or mount volumes: unmounted volumes=[data kube-api-access-88s6g], unattached volumes=[data kube-api-access-88s6g]: timed out waiting for the condition

Hi plz, let me know if I missed any steps ,

Hello there. I'm happy to see someone new trying out samba operator!
The yaml manifest client-test-pod.yaml depends on the config map sample-data1. This config map is currently kept at tests/files/data1.yaml. Create the configmap using something like kubectl apply -f tests/files/data1.yaml and then the client test pod should start running.

Hi Thanks the above problem is solved ,  but now ```NAME                                                 READY   STATUS     RESTARTS   AGE
samba-ad-server-86b7dd9856-h8dh5                     1/1     Running    0          27m
samba-operator-controller-manager-844d976b7b-hb94m   2/2     Running    0          2d19h
smbclient                                            1/1     Running    0          2d19h
tshare1-7dbf77d95f-vgd4f                             1/1     Running    0          68m
tshare2-85464f98c4-njldh                             0/4     Init:0/2   0          4m41s

tshare2-85464f98c4-njldh  <<<<-- is not coming  up ? in events also not seen any errors

Events:
Type     Reason       Age                 From               Message

Normal   Scheduled    2m5s                default-scheduler  Successfully assigned samba-operator-system/tshare2-8bf9f566d-k2gw6 to minikube
Warning  FailedMount  61s (x8 over 2m5s)  kubelet            MountVolume.SetUp failed for volume "join-data-0" : references non-existent secret key: join2.json
Warning  FailedMount  2s                  kubelet            Unable to attach or mount volumes: unmounted volumes=[join-data-0], unattached volumes=[join-data-0 samba-wb-sockets-dir tshare2-pvc-smb svcwatch samba-container-config samba-state-dir kube-api-access-fsdfm]: timed out waiting for the condition

If you're using the same YAML files from tests/files, much like the client pod, these have dependencies. In the case of our SmbShares, these are based on data files defined in the SmbSecurityConfig. Take a look at the file smbsecurityconfig1.yaml  for tshare1 and smbsecurityconfig2.yaml for tshare2. Both refer to a secret. These secrets must be loaded in the same namespace as the pod.
For tshare2 this is kept in the yaml file joinsecret1.yaml. Use kubectl to load that file and see if that resolves your problem.

I am trying to use something like ``

apiVersion: v1
kind: Secret
metadata:
namespace: samba-operator-system
name: join1
type: Opaque
stringData:
Change the value below to match the username and password for a user that
can join systems your test AD Domain
join.json: |
{"username": "admin", "password": "admin"}
join2.json: |
{"username": "Administrator", "password": "admin"}

apiVersion: samba-operator.samba.org/v1alpha1
kind: SmbSecurityConfig
metadata:
name: adsec1
spec:
mode: active-directory
realm: domain1.sink.test
joinSources:

userJoin:
secret: join1
key: join1.json
dns:
register: cluster-ip

is it correct?

Looks mostly OK, but I do see that the secret resource specifies a namespace but the SmbSecurityConfig does not. So depending on what your kubectl command line is the resources may or may not be created in the same namespace. It's not wrong - but I can't say if you'll get the expected result.
Also, what password you use depends on your AD if you're using the same AD server container that the tests do, the password is different. But it's totally OK if want to change the password. So again, I can't say if it's right or wrong. But it is different.

@phlogistonjohn I am facing the same issue as @milindw96 mentioned. I am using the files from /test/files. Standalone pods are up and running without issues. But the pods with active-directory mode on smbsecurityconfig stuck at init state.
Please find the list of resources created for "tshare2" below:

Please clarify any prerequisite needs to be done before running the samba-operator for AD.

Hi @rravi6121  I suspect that the issue is similar too, the AD domain member instances has more dependencies that the standalone and more opportunities to get stuck. :-)
Can you please run kubectl describe pod <podname>?
PS. It's generally better to copy and paste text from your terminal over a screenshot image. When you paste you can surround the text in three backticks (```) on their own line before and after your paste to make it clear what you pasted. An example:
Hello world!

Thanks @phlogistonjohn, Please find the output of "kubectl describe pod" below:
Name:         tshare2-5b78b7764-5rwxc
Namespace:    samba-operator-system
Priority:     0
Node:         minikube/<<ipaddress>>
Start Time:   Thu, 22 Jul 2021 10:38:30 +0530
Labels:       app=samba
              app.kubernetes.io/component=smbd
              app.kubernetes.io/instance=samba-tshare2
              app.kubernetes.io/managed-by=samba-operator
              app.kubernetes.io/name=samba
              app.kubernetes.io/part-of=samba
              pod-template-hash=5b78b7764
              samba-operator.samba.org/service=tshare2
Annotations:  kubectl.kubernetes.io/default-container: samba
              kubectl.kubernetes.io/default-logs-container: samba
Status:       Pending
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/tshare2-5b78b7764
Init Containers:
  init:
    Container ID:  cri-o://82b5401b6a519a95fd2db99344256950cf8779b0ebc4dededa25128a705cc80a
    Image:         quay.io/samba.org/samba-server:latest
    Image ID:      quay.io/samba.org/samba-server@sha256:4ef1fd9f02b6e5cef4d32c4b4388dde1411fcab651eb2bb1b2fa33423d8c0bd3
    Port:          <none>
    Host Port:     <none>
    Args:
      init
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Fri, 23 Jul 2021 09:39:52 +0530
      Finished:     Fri, 23 Jul 2021 09:39:52 +0530
    Ready:          True
    Restart Count:  0
    Environment:
      SAMBA_CONTAINER_ID:  tshare2
      SAMBACC_CONFIG:      /etc/container-config/config.json
    Mounts:
      /etc/container-config from samba-container-config (rw)
      /var/lib/samba from samba-state-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-plb9l (ro)
  must-join:
    Container ID:  cri-o://ae28980851302223f03597962c8e8c339e05568aa02611b29bc28f762d67380c
    Image:         quay.io/samba.org/samba-server:latest
    Image ID:      quay.io/samba.org/samba-server@sha256:4ef1fd9f02b6e5cef4d32c4b4388dde1411fcab651eb2bb1b2fa33423d8c0bd3
    Port:          <none>
    Host Port:     <none>
    Args:
      must-join
    State:          Running
      Started:      Fri, 23 Jul 2021 09:40:08 +0530
    Ready:          False
    Restart Count:  0
    Environment:
      SAMBA_CONTAINER_ID:  tshare2
      SAMBACC_CONFIG:      /etc/container-config/config.json
      SAMBACC_JOIN_FILES:  /var/tmp/join/0/join.json:/var/tmp/join/1/join.json
    Mounts:
      /etc/container-config from samba-container-config (rw)
      /var/lib/samba from samba-state-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-plb9l (ro)
      /var/tmp/join/0 from join-data-0 (rw)
      /var/tmp/join/1 from join-data-1 (rw)
Containers:
  samba:
    Container ID:
    Image:         quay.io/samba.org/samba-server:latest
    Image ID:
    Port:          445/TCP
    Host Port:     0/TCP
    Args:
      run
      smbd
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Liveness:       tcp-socket :445 delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:
      SAMBA_CONTAINER_ID:  tshare2
      SAMBACC_CONFIG:      /etc/container-config/config.json
    Mounts:
      /etc/container-config from samba-container-config (rw)
      /mnt/aa5ccaa6-0445-4e89-a0ae-108ca118a769 from tshare2-pvc-smb (rw)
      /run/samba/winbindd from samba-wb-sockets-dir (rw)
      /var/lib/samba from samba-state-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-plb9l (ro)
  wb:
    Container ID:
    Image:         quay.io/samba.org/samba-server:latest
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Args:
      run
      winbindd
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Liveness:       exec [samba-container check winbind] delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment:
      SAMBA_CONTAINER_ID:  tshare2
      SAMBACC_CONFIG:      /etc/container-config/config.json
    Mounts:
      /etc/container-config from samba-container-config (rw)
      /run/samba/winbindd from samba-wb-sockets-dir (rw)
      /var/lib/samba from samba-state-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-plb9l (ro)
  dns-register:
    Container ID:
    Image:         quay.io/samba.org/samba-server:latest
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Args:
      dns-register
      --watch
      --target=internal
      /var/lib/svcwatch/status.json
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Environment:
      SAMBA_CONTAINER_ID:  tshare2
      SAMBACC_CONFIG:      /etc/container-config/config.json
    Mounts:
      /etc/container-config from samba-container-config (rw)
      /run/samba/winbindd from samba-wb-sockets-dir (rw)
      /var/lib/samba from samba-state-dir (rw)
      /var/lib/svcwatch from svcwatch (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-plb9l (ro)
  svc-watch:
    Container ID:
    Image:          quay.io/samba.org/svcwatch:latest
    Image ID:
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Environment:
      DESTINATION_PATH:     /var/lib/svcwatch/status.json
      SERVICE_LABEL_KEY:    samba-operator.samba.org/service
      SERVICE_LABEL_VALUE:   (v1:metadata.labels['samba-operator.samba.org/service'])
      SERVICE_NAMESPACE:    samba-operator-system (v1:metadata.namespace)
    Mounts:
      /var/lib/svcwatch from svcwatch (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-plb9l (ro)
Conditions:
  Type              Status
  Initialized       False
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  samba-container-config:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      samba-container-config
    Optional:  false
  samba-state-dir:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:  <unset>
  tshare2-pvc-smb:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  tshare2-pvc
    ReadOnly:   false
  samba-wb-sockets-dir:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     Memory
    SizeLimit:  <unset>
  join-data-0:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  join1
    Optional:    false
  join-data-1:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  join1
    Optional:    false
  svcwatch:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     Memory
    SizeLimit:  <unset>
  default-token-plb9l:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-plb9l
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                 node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type    Reason   Age    From     Message
  ----    ------   ----   ----     -------
  Normal  Pulling  6m36s  kubelet  Pulling image "quay.io/samba.org/samba-server:latest"
  Normal  Pulled   6m32s  kubelet  Successfully pulled image "quay.io/samba.org/samba-server:latest" in 4.612177804s
  Normal  Created  6m31s  kubelet  Created container init
  Normal  Started  6m31s  kubelet  Started container init
  Normal  Pulling  6m31s  kubelet  Pulling image "quay.io/samba.org/samba-server:latest"
  Normal  Pulled   6m15s  kubelet  Successfully pulled image "quay.io/samba.org/samba-server:latest" in 15.324456624s
  Normal  Created  6m15s  kubelet  Created container must-join
  Normal  Started  6m15s  kubelet  Started container must-join

Thanks. Based on that output I suspect that "must-join" is unable to join the pod to active directory. The best thing we can do next is to see why must-join is not proceeding. That's usually because the join information doesn't match AD or AD is unreachable.
Run kubectl logs tshare2-5b78b7764-5rwxc -c must-join to get the logs from the must-join container. Then if you don't have any sensitive data in it, share your join secret with kubectl get secret join1 -o yaml. And lastly it would help if you described how you set up AD - is it just the AD pod yaml from our tests/files directory? And if so, did you deploy it using the script in ./tests/test-deploy-ad-server.sh  and/ or did you configure the coredns config for your cluster?

Thanks @phlogistonjohn I have deployed AD pod using yaml with "kubectl apply -f" command and that might be the reason for the issue.
I tried deploying with shell script ./tests/test-deploy-ad-server.sh and the pod is up and running without issues
NAME                                                     READY   STATUS    RESTARTS   AGE
pod/samba-ad-server-86b7dd9856-7rwc5                     1/1     Running   0          45m
pod/samba-operator-controller-manager-844d976b7b-cx4qj   2/2     Running   0          59m
pod/smbclient                                            1/1     Running   0          55m
pod/tshare1-7f47b774b4-d4plg                             1/1     Running   0          33m
pod/tshare2-76f95db4d8-xlt42                             4/4     Running   0          31m

Steps followed:

Install and Start minikube. Check the status and make sure minikube running without issues
Git clone samba-operator repository and navigate into it.
Run "make deploy" from the "samba-operator" folder
Run "kubectl config set-context --current --namespace=samba-operator-system" to change the minikube namespace to "samba-operator-system"
Run "kubectl apply -f" command to deploy yaml files with kind Secret, ConfigMap, SmbCommonConfig and SmbSecurityConfig from "./test/files" folder. Make sure Secrets and ConfigMaps deployed before SmbSecurityConfig
Run shell script "./tests/test-deploy-ad-server.sh" to deploy samba-ad-server
Deploy Smbshare by running "kubectl apply -f ./tests/tshare2.yaml"

Hi, I'm happy to help, but it feels like a lot of what in in this issue is general setup and debugging help rather than a defect/bug. Do you mind if I first convert this issue to a github discussion?

Sure @phlogistonjohn , It wont be a problem.


⚠ GitLab Server has degraded performance

In 02cfbe0, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6726 ms

Resolved: GitLab Server performance has improved in 89a80a8.


Fractal/NGIO logging

Re: logging (extracting the discussion from #866, cc @lorenzocerrone @jluethi )

The place where we want to be careful about logging is ngio, because it's a library that will be re-used in other Python modules. The same applies to fractal-tasks-core core library, but loggers defined in fractal-tasks-core tasks are not re-used by anyone outside that task - thus their only requirement is that their format includes a timestamp (unrelated: possibly in a custom timezone).

Logger names are used as logger identifier by the logging library, and calling logging.getLogger("some.logger") twice returns the same object - even from two different modules (see e.g. here).

Right now, fractal-tasks-core logging is configured in a way that does not display the logger name (details in "Where does the logger name appear?" below). This was less relevant in the past, because most/all logs came from the same logger (fractal-tasks-core). Now that we are including two different loggers, I suggest we pick reasonable/brief names and display them.

Loggers should not be passed around (across functions or modules) as Python objects. That is, I think we should move from

from ngio.utils import ngio_logger

to
from ngio.utils import ngio_logger_name
ngio_loggger = logging.getLogger(ngio_logger_name)

This is my understanding of https://docs.python.org/3/howto/logging-cookbook.html#using-logging-in-multiple-modules and https://docs.python.org/3/howto/logging-cookbook.html#using-loggers-as-attributes-in-a-class-or-passing-them-as-parameters, and that's also how we are typically setting up things in fractal repositories.

In general, I don't think we should ever import/use the ngio logger in fractal-tasks-core tasks.
The reason becomes more evident in a case where we do show logger names:

# This seems correct, with different loggers for the current task and for ngio operations
2024-10-10 10:10:10 - fractal_tasks_core.tasks.projection - INFO - start task
2024-10-10 10:10:11 - fractal_tasks_core.tasks.projection - INFO - zarr_url=/some/ome.zarr/B/03/0
2024-10-10 10:10:12 - fractal_tasks_core.tasks.projection - INFO - preliminary checks are OK
2024-10-10 10:10:13 - ngio.loader - WARNING - I found the wrong dtype in some zarr array, continue anyway
2024-10-10 10:10:14 - fractal_tasks_core.tasks.projection - INFO - end task

# This seems wrong: the "start task" does not belong to ngio
2024-10-10 10:10:10 - ngio.something - INFO - start task
2024-10-10 10:10:11 - ngio.something - INFO - zarr_url=/some/ome.zarr/B/03/0
2024-10-10 10:10:12 - ngio.something - INFO - preliminary checks are OK
2024-10-10 10:10:13 - ngio.loader - WARNING - I found the wrong dtype in some zarr array, continue anyway
2024-10-10 10:10:14 - ngio.something - INFO - end task

(note that I showed the most complete example where logger names also include the specific module, but they could also simply be projection_task and ngio).
Where does the logger name appear?

When does run_fractal_task use the logger name? (by @jluethi)

The logger name determines which logger will be used in this block
    # Run task
    logger.info(f"START {task_function.__name__} task")
    metadata_update = task_function(**pars)
    logger.info(f"END {task_function.__name__} task")

However, this logger_name is currently not displayed in any log, due to our logging configuration (defined in __init__.py).
This snippet clarifies how we are configuring logging now, and how we could change it if we wanted to display the name:
import logging

# Create two loggers
logger1 = logging.getLogger("logger_name_1")
logger2 = logging.getLogger("logger_name_2")

# Use the configuration which is currently in use for fractal-tasks-core loggers
logging.basicConfig(level=logging.INFO, format="%(asctime)s; %(levelname)s; %(message)s")

logger1.error("This is an error from logger 1")
# 2024-11-19 09:00:55,532; ERROR; This is an error from logger 1

logger2.error("This is an error from logger 2")
# 2024-11-19 09:00:55,532; ERROR; This is an error from logger 2

# Replace configuration with a new one, which includes logger name
logging.basicConfig(level=logging.INFO, format="%(asctime)s; %(name)s; %(levelname)s; %(message)s", force=True)

logger1.error("This is an error from logger 1")
# 2024-11-19 09:00:55,532; logger_name_1; ERROR; This is an error from logger 1

logger2.error("This is an error from logger 2")
# 2024-11-19 09:00:55,532; logger_name_2; ERROR; This is an error from logger 2

This is also clear in the following task logs, where the logger name does not appear anywhere:
2024-11-18 12:53:24,431; INFO; START cellvoyager_to_ome_zarr_init task
2024-11-18 12:53:24,431; INFO; [glob_with_multiple_patterns] include_patterns=['*.png']
2024-11-18 12:53:24,438; INFO; [glob_with_multiple_patterns] Found 4 items
2024-11-18 12:53:24,438; INFO; Creating 20200812-CardiomyocyteDifferentiation14-Cycle1.zarr
2024-11-18 12:53:24,438; INFO; Start open_zarr_group_with_overwrite (overwrite=True).
2024-11-18 12:53:24,452; INFO; Zarr group /data/zarrs/1731934120-1/20200812-CardiomyocyteDifferentiation14-Cycle1.zarr already exists, with keys=['B']
2024-11-18 12:53:24,477; INFO; Read /data/images/10.5281_zenodo.8287221/MeasurementData.mlf, apply following include patterns to image filenames: None apply the following exlcude patterns to image filenames: None
2024-11-18 12:53:24,499; INFO; Expected number of images for well B03: 4
2024-11-18 12:53:24,500; INFO; removing FOV overlaps for well='B03'
2024-11-18 12:53:24,502; INFO; [glob_with_multiple_patterns] include_patterns=['20200812-CardiomyocyteDifferentiation14-Cycle1_*.png']
2024-11-18 12:53:24,502; INFO; [glob_with_multiple_patterns] Found 4 items
2024-11-18 12:53:24,502; INFO; [glob_with_multiple_patterns] include_patterns=['20200812-CardiomyocyteDifferentiation14-Cycle1_B03_*.png']
2024-11-18 12:53:24,502; INFO; [glob_with_multiple_patterns] Found 4 items
/data/remote/tasks/1/fractal-tasks-core/1.3.2/venv/lib/python3.10/site-packages/pydantic/main.py:364: UserWarning: Pydantic serializer warnings:
  Expected `int` but got `int64` - serialized value may not be as expected
  return self.__pydantic_serializer__.to_python(
2024-11-18 12:53:24,531; INFO; END cellvoyager_to_ome_zarr_init task

Conclusion:

Tasks will use their own loggers
Logger level warning for ngio is good => we can overall reduce the number of logs
Logger level setting via env variable allows debugging even in Fractal server
We can unify/update logger config


implement virtual network independently of microsoft / windows

hello when will be this feature?
I get some errors in my windows and i think using your own virtual network will be more easy to setup it!

The only thing from Microsoft that they are using is a "clone" of MS's SSTP VPN server and then authentication inside of a Windows NT Domain. You dont have to use either of these options, so you could set this up on a Linux box, disable the "MS-SSTP" server and use any authentication method but "Windows NT Domain Controller or Windows Server Active Directory Controller" and you would not be using a single thing related to MS.


feat: add support for AWS SSO profile in config

Description
This PR adds support for AWS SSO profiles. Just set the below key in Whispr config:
sso_profile: dev

Where dev is the SSO profile name used to sign into AWS.
Changes

Add AWS SSO Profile support
Improve Whispr CLI commands help messages
Add a clean_build script for local package build and test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

1 of 9 (11.11%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.9%) to 68.619%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/whispr/cli.py
0
1
0.0%

src/whispr/factory.py
1
8
12.5%

Files with Coverage Reduction
New Missed Lines
%

src/whispr/factory.py
1
36.59%

src/whispr/cli.py
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>4:
-1.9%

Covered Lines:
164

Relevant Lines:
239

💛  - Coveralls


source-map-support with lerna bootstrap

I'm not 100% sure what's the best way to work on this project.
I've found the lerna workflow confusing in the past, but I could use some tips on how to build a new example while working on backpack-core.
Thanks!

My workflow so far:
❯ git clean -fdx .
❯ npm i
❯ $(npm bin)/lerna bootstrap
Lerna v2.0.0-beta.32
Bootstrapping 7 packages
Preinstalling packages
Installing external dependencies
Symlinking packages and binaries
Postinstalling packages
NpmUtilities.execInDir        ("run postinstall", [], "./examples/with-typescript-webpack-conf
ig")
Error: Command failed: npm run postinstall
module.js:472
    throw err;
    ^

Error: Cannot find module 'webpack'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/Eric/Projects/ericclemmons/backpack/examples/with-typescript
-webpack-config/backpack.config.js:1:79)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

npm ERR! Darwin 16.4.0
npm ERR! argv "/Users/Eric/.nvm/versions/node/v7.2.0/bin/node" "/Users/Eric/.nvm/versions/node
/v7.2.0/bin/npm" "run" "postinstall"
npm ERR! node v7.2.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: `backpack build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script '
backpack build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the backpack-examples-with-custom-webpa
ck-config package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     backpack build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs backpack-examples-with-custom-webpack-config
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls backpack-examples-with-custom-webpack-config
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Eric/Projects/ericclemmons/backpack/examples/with-typescript-webpack-confi
g/npm-debug.log

    at ChildProcess.exithandler (child_process.js:211:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:885:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
NpmUtilities.runScriptInDir   ("postinstall", [], "./examples/with-typescript-webpack-config")
Error: Command failed: npm run postinstall
module.js:472
    throw err;
    ^
:: SNIP - REPEATS A FEW TIMES ::

So then I tried to run the basic example:
❯ cd examples/basic
❯ npm run dev
 DONE  Compiled successfully in 406ms

module.js:472
    throw err;
    ^

Error: Cannot find module 'source-map-support'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/Eric/Projects/ericclemmons/backpack/examples/basic/build/mai
n.js:1:63)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

Hmmm. Let me try a fresh install on my machine

I'm on Node v7.2.0 just trying to make things work :)

Forgot to mention this issue in my commit. There were a few things wrong with typescript example postinstall.

Will add a contributing.md now.

Synced up with master and confirmed:

✅ npm i
✅ $(npm bin)/lerna bootstrap
❌ cd examples/basic && npm run dev:

 DONE  Compiled successfully in 394ms

module.js:472
    throw err;
    ^

Error: Cannot find module 'source-map-support'

Sorry, from a blank repo (git clean -fdx .), I still get the following from examples/basic $ npm run dev:

Error: Cannot find module 'source-map-support/register'

This is what I did to fix it:
diff --git a/packages/backpack-core/config/webpack.config.js b/packages/backpack-core/config/w
index fd37215..efd48ed 100644
--- a/packages/backpack-core/config/webpack.config.js
+++ b/packages/backpack-core/config/webpack.config.js
@@ -107,7 +107,7 @@ module.exports = (options) => {
       // top of each file using the BannerPlugin.
       new webpack.BannerPlugin({
         raw: true,
-        banner: 'require("source-map-support/register")'
+        banner: 'require("backpack-core/node_modules/source-map-support/register")'
       }),
       // The FriendlyErrorsWebpackPlugin (when combined with source-maps)
       // gives Backpack its human-readable error messages.

Here's why this works:

source-map-support isn't a dependency of the example (or its parents) when bootstrapped with lerna.
However, it is a sub-dependency (and hoisted with NPM3) when backpack-core is installed.

The risk is with npm install flattening dependencies, there's no guarantee it exists under backpack-core/node_modules.
If all of backpack-core's dependencies were copied (or symlinked) into the node_modules of the examples, it would be as if it was installed normally.
Still thinking on this...

pretty sure i've seen source-map-support/register put into webpack entry once somewher

Oh, on a related note, some of these issues I completely missed with @terse/webpack because auto-installing missing dependencies via webpack was a default.

Even better alternative, IMO:
diff --git a/packages/backpack-core/config/webpack.config.js b/packages/backpack-core/config/w
index fd37215..ee6de49 100644
--- a/packages/backpack-core/config/webpack.config.js
+++ b/packages/backpack-core/config/webpack.config.js
@@ -107,7 +107,7 @@ module.exports = (options) => {
       // top of each file using the BannerPlugin.
       new webpack.BannerPlugin({
         raw: true,
-        banner: 'require("source-map-support/register")'
+        banner: `require('${require.resolve('source-map-support')}')`
       }),
       // The FriendlyErrorsWebpackPlugin (when combined with source-maps)
       // gives Backpack its human-readable error messages.

This should work because:

require(pathToSourceMapSupport) is done at compilation time.
So source-map-support should be resolvable relative to backpack-core or process.cwd().

This warrants a non-symlink test, but it should work for both project development and end-users, if I'm thinking about it right.

lgtm

Alright, this is converted to a PR, but would want to confirm it works when installed normally.  Going to try as a file:// dependency...

Sweet!  Just tested this by adjusting dependencies and source-map-support correctly references the example's node_modules:
require('/Users/Eric/Projects/ericclemmons/backpack/examples/basic/node_modules/source-map-support/source-map-support.js')

diff --git a/examples/basic/package.json b/examples/basic/package.json
index a9dffbf..c1f5784 100644
--- a/examples/basic/package.json
+++ b/examples/basic/package.json
@@ -9,7 +9,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "backpack-core": "^0.0.8",
+    "backpack-core": "file:///Users/Eric/Projects/ericclemmons/backpack/packages/backpack-cor
     "express": "^4.14.0"
   }
 }


fix(thanos): remove unnecessary config

Everything looks good to me.
Will you replicate these changes on the modular version of Thanos? From what I remember, I ported all these settings as-is, so we need to make the same changes you just did on the module as well.

Yes, will do.


Correction and clarification on English strings

To be corrected

"Maximum privacy for you and your customers.Running a full node. No AML/KYC."

"Having a technical question not covered in docs or want to help improve the code? Help us out on GitHib."

Suggestion

"Bitcoin" shouldn't be capitalized when referring to the token ("They paid me in euros but I'd prefer bitcoins")

Thanks, will address these.

"Bitcoin" shouldn't be capitalized when referring to the token ("They paid me in euros but I'd prefer bitcoins")

Can you provide specific places where this happens?

"Receive your Bitcoin and altcoin payments without any fees or third-party involvement. You are your own payment processor. Funds go directly to your wallet; your private key is never required."
"Receive Bitcoin payments as a business or an individual. No fees. No third-party."
"Your keys - Your Bitcoin. Private key never required for using BTCPay."

Done in #32 thanks for reporting.


git_files does not show all files in a git repository

Since the default command for git_files is git ls-files, it will only search the current directory (recursively). Because of my experience with other similar plugins I was expecting to be able to search for any file in the git repo, rather than only ones in the my cwd, and below. I attempted to set the cwd option to the root of my project, and changed the cmd to use git ls-tree, but neither achieved the intended result.
Using git ls-tree HEAD -r --full-tree --name-only gives me all the files I'd like, but the preview shows the following error, and the selected file will not open: head: cannot open 'FILENAME' for reading: No such file or directory
Any suggestions? Love the plugin! Great work!

Unfortunately I still use the previewer as you would in the shell (I.e. sending fzf a command with the —preview option), in order to make it work I prefix the command file spec with the current working directory, unfortunately that means it cannot preview any files outside the cwd.
The semi-workaround is to send cwd=nil but that would make the plug-in show full paths inside your repo which is undesirable.
In the near future I plan to rework the previewer to stream contents (instead of sending fzf a command to run), that will solve this issue as well as allow me to send treesitter supported preview content if the user prefers that over bat.
Hopefully that explains it.

@ibhagwan Makes sense. Thanks for the response!

The title is a bit misleading now since this issue is mostly about the preview not working correctly, since we now have issue #24 I will update the preview progress there.

Previewing files with absolute path should be fixed in the latest commit.


Does dart native synchronous extension support pass array or dictionary?

Thank you for taking the time to file an issue!
This tracker is for issues related to:

Analyzer
Common Front End (CFE) and kernel
Dart core libraries ("dart:async", "dart:io", etc.)
Dart VM
dart2js
dartfix
dev_compiler

Some other pieces of the Dart ecosystem are maintained elsewhere. Please
file issues in their repository:

Dart language: https://github.com/dart-lang/language
Dart website: https://github.com/dart-lang/site-www
Flutter: https://github.com/flutter/flutter
Linter: https://github.com/dart-lang/linter
dartfmt: https://github.com/dart-lang/dart_style

If you aren't sure, file the issue here and we'll find the right home for it.
In your issue, please include:

Dart SDK Version (dart --version)
Whether you are using Windows, MacOSX, or Linux (if applicable)
Whether you are using Chrome, Safari, Firefox, Edge (if applicable)

Missing some or all of the above might make the issue take longer or be
impossible to act on.
If you simply have a question, consider starting with Stack Overflow:
https://stackoverflow.com/questions/tagged/dart
For a real-time response, consider our Gitter channel:
https://gitter.im/dart-lang/sdk

You can pass any Dart object via handle with native extensions.
You can only pass primitive C types through the FFI.


The given key 'zip' was not present in the dictionary.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
so i was trying to put in a custom font in the mod menu and an error stating "The given key 'zip' was not present in the dictionary."

Only TTF, OTF and TTC files are supported. Unzip the font from the ZIP file and import that.
A fix for being able to input any files will be fixed next update.

alr thx
On Sun, Jun 23, 2024 at 9:44 AM Matt @.***> wrote:

Only TTF, OTF and TTC files are supported. Unzip the font from the ZIP
file and import that.
A fix for being able to input any files will be fixed next update.
—
Reply to this email directly, view it on GitHub
https://github.com/pizzaboxer/bloxstrap/issues/2151#issuecomment-2184995461,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJMMVELFFUOKFPIVO4EERB3ZI3GLZAVCNFSM6AAAAABJYBJGAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUHE4TKNBWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Help. Is the client generated by operator sdk obtained from the cache when getting the k8s resource?

Is the client generated by operator sdk obtained from the cache when getting the k8s resource?  Thanks.
See the following example code.   Is the client.Get method operating the data in the cache?
func newReconciler(mgr manager.Manager) (reconcile.Reconciler, error) {
 ...
	return &ReconcileFailover{
		client: mgr.GetClient(),
		scheme: mgr.GetScheme(),
        }
...
}

client.Get(context.TODO(), types.NamespacedName{})

/help wanted

@AllenZMC The manager's default client is a split client. It reads from the cache and writes to the API.

Thanks! @joelanford


[BUG] Application never end when trying to connect to sharepoint via client secret credentials

Hi,
I am trying to connect to Sharepoint via graph api and trying to connect to SPO with client secret credentials
and application hung with same message as
2024-10-28 18:46:05,578 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
Getting this line in a loop
and system never finished.
What can cause this line in loop over and over
Thanks,
Itay

Hi @ibrahimrabab @ibrandes @kyleknap @seanmcc-msft
Any updates regarding this issue?
Thanks,
Itay

This is the lines from the logs when trying to list sites and never ends in a loop
2024-10-28 18:46:07,589 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
2024-10-28 18:46:07,589 DEBUG [ForkJoinPool.commonPool-worker-3] (ConfidentialClientApplication:141) - [Correlation ID: 5e821149-90cc-4cc6-861d-2a660a3c82c0] Access Token was returned
2024-10-28 18:46:07,589 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
2024-10-28 18:46:08,119 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
2024-10-28 18:46:08,120 DEBUG [ForkJoinPool.commonPool-worker-3] (ConfidentialClientApplication:141) - [Correlation ID: b21c78a6-ecc3-47f6-859a-3dd3bb0d7210] Access Token was returned
2024-10-28 18:46:08,120 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
2024-10-28 18:46:08,749 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
2024-10-28 18:46:08,750 DEBUG [ForkJoinPool.commonPool-worker-3] (ConfidentialClientApplication:141) - [Correlation ID: c55647cd-e106-4898-87f4-c7d3189d83e6] Access Token was returned
2024-10-28 18:46:08,750 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
2024-10-28 18:46:09,848 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
2024-10-28 18:46:09,848 DEBUG [ForkJoinPool.commonPool-worker-3] (ConfidentialClientApplication:141) - [Correlation ID: 79dc9305-a579-49e9-b85e-f8702cdae43c] Access Token was returned
2024-10-28 18:46:09,848 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
2024-10-28 18:46:10,376 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
2024-10-28 18:46:10,377 DEBUG [ForkJoinPool.commonPool-worker-3] (ConfidentialClientApplication:141) - [Correlation ID: 236b3971-154e-4297-8588-eae56cf56c12] Access Token was returned
2024-10-28 18:46:10,377 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
2024-10-28 18:46:10,926 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
2024-10-28 18:46:10,927 DEBUG [ForkJoinPool.commonPool-worker-3] (ConfidentialClientApplication:141) - [Correlation ID: 9a48bb24-d85a-4fe7-a1a1-d4bab5063471] Access Token was returned
2024-10-28 18:46:10,927 DEBUG [qtp236567414-16] (ClientSecretCredential:564) - Azure Identity => getToken() result for scopes [https://graph.microsoft.com/.default]: SUCCESS
2024-10-28 18:46:11,406 DEBUG [ForkJoinPool.commonPool-worker-3] (AcquireTokenSilentSupplier:58) - Returning token from cache
And it doesn't stop in a loop

Hey @ihudedi,
Can you please share the code you are using to connect to SharePoint via the Graph API and trying to connect to SPO with client secret credentials? This will help me understand the issue better.
Thanks!

Hi
graphServiceClient.drives().byDriveId(driveId).items().byDriveItemId(getDriveItemIdFromRootPath(filePath)).content().put(fileContent)
tokenCredential = new ClientSecretCredentialBuilder().httpClient(httpClient).maxRetry(SPO_REQUEST_ONLY_ONE_ATTEMPT).tenantId(sharePointTenatId).clientId(sharePointClientId).clientSecret(sharePointClientSecret).build();
blobServiceClientBuilder.credential(new ClientSecretCredentialBuilder().httpClient(httpClient).maxRetry(AZURE_REQUEST_ONLY_ONE_ATTEMPT).tenantId(azureTenantId).clientId(azureClientId).clientSecret(azureClientSecret).build());

@baywet, I believe this is related to Graph code if you could take a look

For everyone context, the customer originally reached out in the SDK repo.
https://github.com/microsoftgraph/msgraph-sdk-java/issues/2210
From looking at the provided stack trace, it seems that the application is looping within Azure Identity and not within the application code or the Graph SDK itself.
This is where the token is requested
This method is ultimately called by the request adapter right before making the service call.
A retry mechanism is implemented when www-authenticate with claims is returned.
But is already has a guard against infinite loops
Which is why I thought the infinite loop might be caused by the azure identity or MSAL themselves.
@ihudedi what would be super helpful here is if you could provide a reproduction snippet without the Graph SDK in the mix, only ok HTTP and the exact same token credential setup you're using for the SDK. (without the credentials)
Getting a network trace of the requests/responses would also help.


[Feature Request]: Proposal for a new TagSet variant without tag-overflow tooltip/popover, instead directly opening the modal displaying all tags.

The problem
When considering the products like IKC(IBM Knowledge Catalog), it handles vast amounts of data, and the data-grid is the primary method used to display this information. Typically, in IKC it needs to showcase a minimum of 15 - 20 tags within a table column in many cases.
So users may find it frustrating to click on the 'overflow tag' and then have to click again to access 'view all tags' in order to see all available options.
Sample screenshot (From PAL website):

The solution

Implement a new variant where clicking the "overflow tag" immediately opens the modal displaying all tags. Thus we can eliminate an extra step for the user. By doing so, we can streamline the process and reduce the number of clicks required.
We might address this by introducing a new property called 'hasOverflowTooltip,' which is initially set to true.
I also recommend providing guidance on the PAL website regarding the appropriate usage of these two variations.

Design link
No response
Links to other materials
No response
Owner/main maintainer(s)
Punnoose Wilson (Requester)
Second/backup maintainer(s)
No response
Product/offering
Cloud Pak for Data (Governance and Privacy)
Business priority
Medium Priority = upcoming release but is not pressing
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[ ] I checked the current issues for duplicate issues

@szinta based on last week’s call with @laurenmrice and @guidari, thinking we address this one through tag overflow after we address some of the overlap now that Carbon Tags cover parts of the overflow behavior as well.


appid claim should be lowercase

Claim name should be lowercase. Spent a day breaking my head over this :(

@microsoft-github-policy-service agree

@namalu

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


TableView cleanup ScrollBarProxy

I believe that the ScrollBarProxy cleanup doesn't work for the cleanup method in TableView (line 546 of fattable.coffee):
cleanUp: ->
    # be nice rewind !
    @eventRegister.unbindAll()
    @ScrollBarProxy?.onScroll = null

After reading over the code, I believe that you were trying to do:
cleanUp: ->
    # be nice rewind !
    @eventRegister.unbindAll()
    @scroll?.onScroll = null

really? ;)

No I haven't >.<
Well I accept pull request :)

Fixed in 833904c0ecff3b2ccf17c4a8e03b053b0b74a164


feat(KONFLUX-2084): refactor-load-test-not-to-conflict-on-entity-names

Description
Randomized applicationName, itsName, ComponentDetectionQueryName and componentName to support multiple application and components and other resources if needed to support
https://issues.redhat.com/browse/KONFLUX-1007 - Consider testing max concurrency one namespace can handle
Issue ticket number and link
https://issues.redhat.com/browse/KONFLUX-2084
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/test ?

/test load-test-ci-10u-10t

/test load-test-ci-10u-10t

/test ?

/test load-test-ci-10u-10t

/retest

/retest

/test load-test-ci-10u-10t

/test load-test-ci-10u-10t

/retest /?

/retest

/retest

retest /all

/test load-test-ci-10u-10t

/retest

Looks good besides these two comments on duplicating functions.

Fixed the duplication issues

/test load-test-ci-10u-10t

/test load-test-ci-10u-10t

/test load-test-ci-10u-10t

/retest

/test load-test-ci-10u-10t-go

/retest

/test load-test-ci-10u-10t-java

/retest

/test load-test-ci-10u-10t

/test load-test-ci-10u-10t

/test ?

/test load-test-ci-10u-10t


feat: Implement Plutus Data hashing / JSON

After some source code spelunking, this PR adds:

a mechanism to hash Plutus Data from wire-cbor in an equivalent fashion as the cardano-cli.
export a Plutus Data struct into JSON format that can be read by the cardano-cli

I use "spelunking" as an euphemism for "reverse engineering"


IndexError: list index out of range

I updated the package to the latest version 0.34 to reproduce some of the newly reported issues and noticed that for some reason the fix #745 is not included in current package.
https://github.com/slundberg/shap/blob/cf4e9b04bd369be0949d67cc15a1743f8a5c1b1b/shap/explainers/tree.py#L1362
For those who face this same issue, you can install the latest version from git repository by running:
pip install git+https://github.com/slundberg/shap

Thanks for noting this. I'll push a new version here soon, I was hoping to wrap up a couple other changes into it first.

Fixed, closing.


About the Eq.(4) in the paper

Hi, I'm a beginner.
But I was confused, the implementation of eq.(4) in the code seems to take F as input, not Z (in the paper).

Hi, I'm a beginner. But I was confused, the implementation of eq.(4) in the code seems to take F as input, not Z (in the paper).

sorry, it is eq.(7)

Oh actually you are correct. The z_q in the Eq. 7 comes from average pooling F, not Z.
I'll be revising the manuscript soon.
Thanks for pointing it out!

No problem. Closing the issue.


feat: allow setting User-Agent header

Add a method to set the User-Agent header of the
underlying HttpClient instance.

CI error seems to be unrelated

CI error is unrelated.
Is there an error or issue you're seeing when the user agent isn't set? As a side note: I would prefer to see the setting of the user agent header value in a constructor overload rather than in it's own method as I can't think of a reason why a user would need to change the user agent value after client initialization. What are your thoughts?

Is listead as one requirement in the (fair use policy)[https://pokeapi.co/docs/v2.html] of PokeAPI. I agree with the constructor overload, I went with this approach as it has less impact on the existent API :P
Ill refactor later

@mtrdp642 refactored, please review


Add field preset value

Add field preset value in fields.json and notice type definitions.
Also update view templates.

Is it normal that the metadataDatabase is 1.5.x (lagging behind)?

Yes, the value of metadataDatabase will be set to 1.6.0 at the time of the release of SDK 1.6.0.

With the latest version of eforms-sdk-analyzer, the checks now pass.
As this was already approved earlier, before the commit to update the eforms-sdk-analyzer dependency, I'm merging this now, without requiring any re-approval.


Web - Overlapping Emojis when Changing Default Skin Tone for "CoupleKiss" Emoji

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a chat and type a message.
Hover over the message and click "Add reaction."
Search for "coupleKiss" emoji in the search bar.
Change the default skin tone for the "coupleKiss" emoji by clicking on the hand icons at the bottom of the Emoji picker.

Expected Result:
The emojis should not overlap when changing the default skin tone for the "coupleKiss" emoji.
Actual Result:
Some emojis overlap when changing the default skin tone for the "coupleKiss" emoji, causing visual issues.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/ddb26d92-42b2-46d4-9005-f186f7a54297
https://github.com/Expensify/App/assets/93399543/d099a7bf-6525-45ab-aec1-b8208c6c9737
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687688275769119
View all open jobs on GitHub

I can't reproduce this on MacOS / Chrome / Safari, asking if it's still happening

I can't reproduce this on MacOS / Chrome / Safari
Asking for them to test again: https://expensify.slack.com/archives/C049HHMV9SM/p1687905235179519?thread_ts=1687688275.769119&cid=C049HHMV9SM

Hey @tienifr do we test on windows?
I can't reproduce on Android, Chrome/Safari, iOS, Mac. I think that's all we test on, right?

I don't think we test on Windows products at this time so I don't think this needs to be fixed but I'll add a C+ to confirm.

@eVoloshchak just nudging this, should we fix this windows emoji issue? only affecting windows?

@Christinadobrzyn, I personally think we should fix Windows, since I suspect most people access NewDot from Windows (no data to back this up, but Windows is the most popular OS). In addition to that, I remember a couple of issues in the past that were fixing Windows-specific issues. That was a while back, not sure if our policy (if there is any) has changed

Asking what version of windows was used to test this so I can do some testing - https://expensify.slack.com/archives/C049HHMV9SM/p1687974216623249?thread_ts=1687688275.769119&cid=C049HHMV9SM

I don't have any method to test this on a Windows 10 Pro - asking the team if anyone can test.

It sounds like Windows PC is out of scope since we can't test on it - based on this Slack chat - https://expensify.slack.com/archives/C01SKUP7QR0/p1688409525853629
So closing this for now. feel free to reopen if we start working on Windows PC issues!


Fix bug of filling itemtokens for encryptDataSource

Pull Request Test Coverage Report for Build 7198

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 51.888%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/encrypt/segment/impl/EncryptInsertFiller.java
0
2
0.0%

Totals

Change from base Build 7193:
0.02%

Covered Lines:
8176

Relevant Lines:
15757

💛  - Coveralls


deploy: Write documentation

@bep can you suggest where this documentation should go?
https://gohugo.io/hosting-and-deployment/ ?

Yes, add a new page below
https://github.com/gohugoio/hugoDocs/tree/master/content/en/hosting-and-deployment
We will make it more prominent later, but I suggest you create a new page call hugo-deploy with the title Hugo Deploy (which marks it as a built-in feature).


delaysign not working

Hi,
I am trying to use ILrepack as an alternative to ILMerge to merge and delay sign the merged assembly. But it seems delay sign does not seem to work properly.
Sample command I use  : ILRepack.exe inputAssembly1.dll /keyfile:xyz.snk /delaysign /out:mergedAssembly.dll
using the command to check if the assembly is delay -signed :
sn -vf mergedAssembly.dll
Output : Failed to verify assembly -- Strong Name Validation failed

Also checked the corflags of assembly manifest : 0x00000009

Can anyone let me know what is the issue here ?

This has just been fixed by https://github.com/gluck/il-repack/pull/330


x/website:

What version of Go are you using (go version)? using go player

$ go version

Does this issue reproduce with the latest release? i do not know just check golang with go player
What operating system and processor architecture are you using (go env)? window 10 with Chrom
go env Output
$ go env

What did you do? checking golan slice with for using len() the the condition like "i < len(x) and the result you can see
//golang slice and "for" question
//  when i use len(x) the output is not what i want.
// because the len(x) change the size auto and the len(x) also change inside for
// so the problem looks like when "for" condition check repeat not make const when first call for for with repating
// answer with sfbanghm.yahoo.com

package main

import (
	"fmt"
)

func RmBack (arr []int) ([]int, int) {
	//var arrLen int
	//arrLen = len(arr)
	return arr[:len(arr)-1], arr[len(arr)-1]
	// for front
	//return arr[1:], arr[0]
}

func main() {

	fmt.Println("Hello, playground")

	// slice a[starI: endi]  a(starti- endi] endindex not include
	x := []int {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}
	px := &x
	xOrg := *px
	fmt.Printf("xAdd: %p, pxAdd: %p\n", x, *px)
	fmt.Println("xAdd: ",x, "pxAdd: ", *px)
	y := x[4:8] //
	fmt.Println("x: [0 1 2 3 4 5 6 7 8 9 10]")
	fmt.Println("x: ",x, " y: ", y)
	//out=>x: [0 1 2 3 4 5 6 7 8 9 10]
	//out=>x:  [1 2 3 4 5 6 7 8 9 10]  y:  [5 6 7 8]
	fmt.Printf("xadd:%p, yadr:%p, x[4]adr:%p \n",x, y, &x[4])
	//out=>xadd:0xc000012050, yadr:0xc000012070, x[4]adr:0xc000012070
	fmt.Println(x, len(x))
	//if useing len(x) and RmBack some how it dose not work as i except like len(x) 10
	var rmVal int

	for i := 0; i < 10 ; i++{
		x, rmVal = RmBack(x)
		fmt.Println("index: ",i,"x: ",x," rmVal: ",rmVal)
	}
	fmt.Println("xAdd: ",x, "pxAdd: ", *px," xorg: ",xOrg)

	// using len(u) at condtion of "for" and result is not what I want
	// at the "for" dose not make len(u) as constant at the call of "for"

	u := []int {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}
	for i := 0; i < len(u) ; i++{
		u, rmVal = RmBack(u)
		fmt.Println("index: ",i,"x: ",u," rmVal: ",rmVal)
	}

}

//output
//Hello, playground
//xAdd: 0xc000138000, pxAdd: 0xc000138000
//xAdd:  [1 2 3 4 5 6 7 8 9 10] pxAdd:  [1 2 3 4 5 6 7 8 9 10]
//x: [0 1 2 3 4 5 6 7 8 9 10]
//x:  [1 2 3 4 5 6 7 8 9 10]  y:  [5 6 7 8]
//xadd:0xc000138000, yadr:0xc000138020, x[4]adr:0xc000138020
//[1 2 3 4 5 6 7 8 9 10] 10
//index:  0 x:  [1 2 3 4 5 6 7 8 9]  rmVal:  10
//index:  1 x:  [1 2 3 4 5 6 7 8]  rmVal:  9
//index:  2 x:  [1 2 3 4 5 6 7]  rmVal:  8
//index:  3 x:  [1 2 3 4 5 6]  rmVal:  7
//index:  4 x:  [1 2 3 4 5]  rmVal:  6
//index:  5 x:  [1 2 3 4]  rmVal:  5
//index:  6 x:  [1 2 3]  rmVal:  4
//index:  7 x:  [1 2]  rmVal:  3
//index:  8 x:  [1]  rmVal:  2
//index:  9 x:  []  rmVal:  1
//xAdd:  [] pxAdd:  []  xorg:  [1 2 3 4 5 6 7 8 9 10]
//index:  0 x:  [1 2 3 4 5 6 7 8 9]  rmVal:  10
//index:  1 x:  [1 2 3 4 5 6 7 8]  rmVal:  9
//index:  2 x:  [1 2 3 4 5 6 7]  rmVal:  8
//index:  3 x:  [1 2 3 4 5 6]  rmVal:  7
//index:  4 x:  [1 2 3 4 5]  rmVal:  6

//Program exited.

What did you expect to see? you can see above two output must to be same
What did you see instead? when slice auto change the len by RmBack function and for condition repeat check len(x) and terminate for loop

Hi,
the Go project does not use its bug tracker for general discussion or asking questions about the language. The Github bug tracker is only used for tracking bugs and proposals going through the Proposal Process.
Please see the Questions wiki page; it has a list of good places for asking questions. Thanks!
Closing here, since this is not a bug.


Support decompression for combined compression

Currently, after merging the array of compressed elements, if you decompress this composite, only the first compressed one comes out.
I updated all elements to be decompressed.
AS-IS
gunzip(gzip("a") + gzip("b")) // "a"
TO-BE
gunzip(gzip("a") + gzip("b")) // "ab"

Thank you for the enhancement! (sorry for my late reply.)


All dialogs are rectangles by default: md_corner_radius not set

By default, the md_corner_radius is not set at all.
That leads to the fact that the library has no corner radius by default.
You can reproduce it by installing the sample.apk:

Fixed via #1840

Sorry, was slightly related but not exactly.


MacOS Sonoma public beta wont work

Describe the bug
After updating to Sonoma 14.0 public beta, the app cannot be opened.
Used to be working on Ventura 13.4.1
System Information (please complete the following information):

macOS: [14.0 Sonoma public beta]
Device: [M1 macbook air ]
CPU: [Apple M1 ]
Dedicated GPU (if any): [ M1 ]
RAM: [ 16G ]

seems like the error is related to aria2.

seems like the error is related to aria2.

So i found a temporary solution, you can double click on parameterized, this is in Contents/MacOS folder located in Yaagl Files, it should open the launcher !

Indeed, its a nice workaround!

Problem solved after updated to the latest version. Thanks for the work.


Error: undefined is not an object( evaluating 'SongsCollection.getAll')

Hi, trying to figure out what this error means

Hi, have you had some news related to this issue?
I'm facing the same problem.

Hello, sorry for delay, could you please tell me more about this error?

Did you make react-native link
Are you testing in real device?
Are you testing in Android?

for now, this plugin only works on Android.

@cinder92 Thanks for answering.
In all of those cases the answer is "Yes". I haven't had enough time to dive into yet so I can't even suppose why nor what is causing the issue.
Would you like me to send you some more info about some file or env?
Again, thanks for replying.

i will make an example asap, keep connected.

Hey, I think I figuredout where the problem is.
SongsCollection.java Line 138, BitmapFactory.decodeByteArray is returning null when the image does not exist.
I think you should check whether songImage is null or not.
Bitmap songImage = BitmapFactory.decodeByteArray(art, 0, art.length);

if(songImage != null){
    //...
}

@flarocca did you fixed it. because i am facing this issue and i added that condition and still i am getting the same issue.

@baalu06 Yes, but there might be another issue:
setDatasource fails if the file it is trying to read is unreadable so the path is correct, the file exists, but it cannot be opened.
Take at look at one question I posted on StackOverflow that I've answered by myself.
The idea is to wrap everything inside the while into try/catch so if setDatasource fails accessing one file it can continue with the rest.
I would make a PR but the owner has never answered me about that.

@flarocca many thanks for quick reply. I will check that in stack. you can create separate branch, many struggle in this point.

@baalu06 Ok, Let me know if it works and I will create and push a new branch with those corrections.

@flarocca yes sure.

@flarocca how you debugged that java file from react native?

I dont think you cant. What I did was to create a new project using Android Studio and test it there.

oh ok thanks and there is already do while there still do we need to change it to while?

@baalu06 No, just add a try/catch inside.
do{
  try{

  } catch (Exception ex) {

  }
} while (...)

@baalu06 By the way, Vote my question and answer up!!! Thanks!!!

@flarocca ha ha done. btw I didnt get any issue now and swell didnt get any result.:(

@baalu06 Are you using a real device or an emulator? Have you tried with a isolated Android Studio project? Have you set permissions in manifest?
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.STORAGE" />

in android/app/src/main/AndroidManifest.xml

@flarocca i will try with last line also.

hey y'all PR are very welcome, sorry for delay.

Remember that in Android 6 , 7 an so on, you need to ask permissions in order to read and write external storage, this plugin WRITE and READ external and internal storage. i recommend, https://github.com/lucasferreira/react-native-android-permissions

I am getting this error.
Null Pointer Exception when trying to compress Bitmap
Please help me to solve this

Just check that image is not null.
I will fork and send a PR as soon as I get some free time.

I think the image is null.
I have music files with no images...
And thank you for your reply....

This is my actual error.
In the console window,
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.graphics.Bitmap.compress(android.graphics.Bitmap$CompressFormat, int, java.io.OutputStream)' on a null object reference
I am using physical device do run.
i just added these code in the AndroidManifest.xml

I also dont know whether I have permissions to access local storage.

@Madhukanth that error is thrown because of the null image reference.

How could I handle that exception???
Is there any way to do it??
Please tell me...

https://github.com/cinder92/react-native-get-music-files/blob/master/android/src/main/java/com/dantecervantes/react/SongsCollection.java, Line 138.
Add a null-check for the image, take a look at my previous comments on this thread

Ok thank you so much.
I will take a look at it.

I tried...but failed.
I dont know java.
Can you please make a PR with correct code for SongsCollection.java???

Sorry for maximum delay i will work into this issues, asap

Thank you...
Please look into it..

@cinder92 I will help this week, there two issues to fix, one of them is the null image and the other one, is to catch everything inside the loop, since one error should not prevent the rest to finalize successfully.
There is also a Nice to have related to how files are retrieve. I had am edge case with over 40 GB, and this process gets extremely slow and freezes the app. So we might want to add some batching mechanism. In other words, return in batches of N files until the end.

I can understand.
But don't know how to do it.
I will just wait for the solution.
Thank you for your reply.

@Madhukanth, I've created a new PR with some changes, but you can't update the package until it is merged and published. But you can copy/paste the code and test it. There are two files you need to copy:

module.js
SongsCollection.java

Let us know how it works.
Thanks.

Thank you so much.
I will use these files to process.
Again thank you for your kind work.

where did you get the code? Take it from the new branch I've created.

Yes...I used your files to change the existing code.
I changed the Songs collection.java and module.js with your PR.
But the same error repeats..

But it has done  something..it collected all the cover images and it's blur images to the sdcard..The list is present in the sdcard..

Fixed in V2


Finished implementing editing of slash command interaction responses

This updates cluster::interaction_response_edit to use the proper api endpoint (/api/v8/webhooks) and format in accordance with https://discord.com/developers/docs/interactions/slash-commands#edit-original-interaction-response. Some unnecessary parameters were removed. Also added interaction_create_t::edit_response.

Merged - does this relate to https://github.com/discord/discord-api-docs/issues/2410 ?

I think so. I implemented this because I wanted to be able to acknowledge an interaction and send a response later, which is now possible.


Feature/9 option menu

This is the placeholder options menu

Codecov Report

Merging #162 (bc253a4) into master (9774ff6) will decrease coverage by 1.74%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9774ff6...bc253a4. Read the comment docs.

The code looks good, but we lack a way to switch to the game scene at runtime.

Now the game will start on the settings menu and contains a "back" button (which will be used to go back to the main menu in the future). This button will launch the game scene.


rewrite this in golang

a good opportunity to start getting deep into go ecosystems

https://github.com/wajeht/ip/pull/5


complete the intergration of Cron Jobs and use

complete the intergration of Cron Jobs and use
task scheduler to execute the jobs
https://github.com/freelancing-solutions/GCP-Based-Database-as-a-Service/blob/ac31d7222e383fbe8bfed71c77f093a8d1fbbb2f/data_service/cron/routes.py#L31

    pass

# TODO complete the intergration of Cron Jobs and use
# task scheduler to execute the jobs

3997e8c4a476ac3db6906df19a5314dc1e539593

Closed in c275b5cb5b6a55068f4588336cd973f57700a978