Radarr API updated, no longer works

Connections to Radarr return:
From the Radarr Log
18-3-8 19:00:13.1|Debug|Api|[GET] /api/movies/lookup?term=Zulu: 404.NotFound (0 ms)
From the Alexa Skill Log
{
"body": {
"version": "1.0",
"response": {
"outputSpeech": {
"type": "SSML",
"ssml": "An error occured: Error: NotFound"
},
"directives": [],
"shouldEndSession": true
},
"sessionAttributes": {}
}
}
From what I have gathered is that the Radarr project has been updated and been distanced from Sonarr somewhat. So the API call to 'movies/lookup' or rather just the api command 'movies' no longer exists. The command is now just 'movie' (no s), and as far as I can tell, 'lookup' is also gone.

There a hotfix we can implement ourselves, or is there more to it than just a find-and-replace in this instance? Haven't pored over the code much.

I was just about to install this (again) but is it worth it now that Radarr is broken?

Sonarr still works with alexa-libby, but until the devs update it to work
with the new radarr api (which sounds simple enough since it's a change in
path) then the radarr functionality is borked, so.
On Sat, Mar 24, 2018, 10:03 AM markrennie71<EMAIL_ADDRESS>wrote:

I was just about to install this (again) but is it worth it now that
Radarr is broken?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-375891611,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjAnOmcsHPC8cBcZf49gvLitQEcYDP_Pks5thlITgaJpZM4SjrbF
.

if it is only a small change.. it isn't hard just change these 2
export async function search(query) {
await loadQualityProfiles();
const resp = await radarr().get('movies/lookup', {term: query});
describe('.search()', () => {
beforeEach(() => {
apiStub.withArgs('movies/lookup', {term: 'assassin'}).resolves([
sampleMoviesResponse[1]
]);
});

Maybe. I've been quite busy with university as of late, so what I did was
just run a find-and-replace for the old path, with the new path on all
files in the source with notepad++ and that didn't work, but I don't think
it caught anything in actual source. Which file is that? Try it and tell me
if it works. Either way I'll give it a go after work and get back to you.
On Sat, Mar 24, 2018, 11:25 AM markrennie71<EMAIL_ADDRESS>wrote:

if it is only a small change.. it isn't hard just change these 2
export async function search(query) {
await loadQualityProfiles();
const resp = await radarr().get('movies/lookup', {term: query});
describe('.search()', () => {
beforeEach(() => {
apiStub.withArgs('movies/lookup', {term: 'assassin'}).resolves([
sampleMoviesResponse[1]
]);
});
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-375897675,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjAnOuA2enf0b4YS_Ot5Ao7xQ1Kf0rNJks5thmVVgaJpZM4SjrbF
.

radarr.js in src\api.. I'll have a play later. might not be as simple as I 1st thought.

Yeah, that might have been the one I tried. I'll look deeper into the code
when I get home, but yeah, I thought the same.
On Sat, Mar 24, 2018, 11:30 AM markrennie71<EMAIL_ADDRESS>wrote:

radarr.js in src\api.. I'll have a play later. might not be as simple as I
1st thought.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-375898035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjAnOo3fsttGnl1vyBX6pD2SPft_Zy8Vks5thmaEgaJpZM4SjrbF
.

If you build from source you only need to change one line to make it work again. Then just build from source and upload the new zip archive to the lambda function.
/src/api/radarr.js -> line 58 - Remove the 's' in movies.
const resp = await radarr().get('movie/lookup', {term: query});
I have also attached a copy of the .js file from the dist folder. Should be able to just replace the radarr.js in dist/api/.
radarr.zip

thanks for this.. well looks like I still cannot use this due to being in the UK.. arse
"AMAZON.Movie"are not currently available for en_GB

change it to AMAZON.literal and you should still be able to use it.

I remember I tried that before and it didn't work.. so I guess just changing to           "type": "AMAZON.literal", but that doesn't work and I cannot work out how on earth I am supposed to generate a new list of samples that I presume I need to add in it as well? over my head I think :(

Yeah unfortunately Amazon has removed AMAZON.LITERAL from all other locals except English US and they have not added in the built in slot type of AMAZON.MOVIE or TVSHOW. At this point your best bet would be to send them a message as a feature request for it. I even tried creating a custom slot type and setting just one value since one place I read said that it would still process information if it was able to discern it from the spoken language but it doesn't seem to be picking up on anything except specified values in the custom slot type.

Update - I found that if you create a custom slot and name it movieName. Then add multiple values of some random movies (I added 10 just to be safe). Then in the FindMovie and AddMovie intents you set the Slot Type to your custom slot you created so Intent Slot is movieName and slot type is movieName, it acts as a wild card and you are able to pass it literal text strings in the same sense that AMAZON.Literal does. You have to have several possible values in the custom slot type for the custom slot to then act as a wild card. I've included a copy of my Alexa JSON from the skill builder for reference.
SkillBuilder.zip

@almostepic89 care to elaborate on your success in building from source? I tried to do the same with up-to-date node.js and npm on Ubuntu 16.0.4 and everything built successfully (install of dependencies, packaging of the .zip) but when I go to test the skill in the Alexa Developer Console, I get an "Audio Only Response" from any query made to the skill, be it from radarr or from sonarr. It's like something has fundamentally broken which shouldn't have from altering just radarr.js. Am I doing something wrong here?

@brettg0396 that hinestly sounds more like an issue with the changes made to the radarr.js file, rather than the building. If it built and compiled the .zip file properly and you are getting a response then it seems the build was done right. Can you upload the radarr.js file as a zip and I'll take a look.

In win 10 I had to modify the package.json file scripts so that "package"
only ran the second command (remove the first part where it runs prepare),
then i ran "install", "run build", "run package" each individually. It
skips some commands which rely on a package which isnt built for windows
and is skipped during the install command.
On Sun, Apr 8, 2018, 5:23 PM brettg0396<EMAIL_ADDRESS>wrote:

Yeah I'm at a loss myself. Initially tried doing this on win10 but this
isn't my area of expertise either and I was running into some issues, so I
just decided to play it safe and do it on Linux.
On Sun, Apr 8, 2018, 8:21 PM almostepic89<EMAIL_ADDRESS>wrote:

If thats the case then dont worry about uploading it. I'm building using
Windows myself using node.js 6.? (Not at the computer at the moment but
its
which ever version was selected during the tutorial for the lambda
server).
I have noticed on rare occasion the alexa app doesn't show the json
request/response but a reload of the page usually fixes it for me. I'm
not
very knowledgable in node.js (even the programming in JS I've been doing
to
add additional features is coming from my experience in PHP) so I'm not
really sure I'd be able to help except to explain what I had to do to get
it to build in Win 10.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-379595074
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AjAnOhLBY_uq0M7cS21Nvc3LDrvpYCCvks5tmqmWgaJpZM4SjrbF
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-379595237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxZAaGLtkM6LUwzhfPYloHVVqwcqgNSks5tmqodgaJpZM4SjrbF
.

Good to know, will try that in a bit.
On Sun, Apr 8, 2018, 8:27 PM almostepic89<EMAIL_ADDRESS>wrote:

In win 10 I had to modify the package.json file scripts so that "package"
only ran the second command (remove the first part where it runs prepare),
then i ran "install", "run build", "run package" each individually. It
skips some commands which rely on a package which isnt built for windows
and is skipped during the install command.
On Sun, Apr 8, 2018, 5:23 PM brettg0396<EMAIL_ADDRESS>wrote:

Yeah I'm at a loss myself. Initially tried doing this on win10 but this
isn't my area of expertise either and I was running into some issues, so
I
just decided to play it safe and do it on Linux.
On Sun, Apr 8, 2018, 8:21 PM almostepic89<EMAIL_ADDRESS>wrote:

If thats the case then dont worry about uploading it. I'm building
using
Windows myself using node.js 6.? (Not at the computer at the moment but
its
which ever version was selected during the tutorial for the lambda
server).
I have noticed on rare occasion the alexa app doesn't show the json
request/response but a reload of the page usually fixes it for me. I'm
not
very knowledgable in node.js (even the programming in JS I've been
doing
to
add additional features is coming from my experience in PHP) so I'm not
really sure I'd be able to help except to explain what I had to do to
get
it to build in Win 10.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-379595074

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AjAnOhLBY_uq0M7cS21Nvc3LDrvpYCCvks5tmqmWgaJpZM4SjrbF

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-379595237
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AMxZAaGLtkM6LUwzhfPYloHVVqwcqgNSks5tmqodgaJpZM4SjrbF
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-379595468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjAnOno6wwZNdEZSHosZlTKzknmvF7_wks5tmqrugaJpZM4SjrbF
.

Following. I would decide to learn and implement this feature right after it doesn't work anymore. xD  I should have looked at the issue list first.

I just tested the change on line 58 to Radar.js and it indeed does work. Radarr api is connected again. Thanks folks for hunting that down. I wasn't sure where to start with that. I really appreciate the help.

Could I get a copy of the functioning .zip? Idk if my build is having
issues or what.
On Sat, May 12, 2018, 1:34 PM Ben Conner<EMAIL_ADDRESS>wrote:

I just tested the change on line 58 to Radar.js and it indeed does work.
Radarr api is connected again. Thanks folks for hunting that down. I wasn't
sure where to start with that. I really appreciate the help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-388581159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjAnOsNlpHNFsWga5UFNzSCxuPi9aU4kks5tx0dUgaJpZM4SjrbF
.

I just downloaded the latest compiled zip from here:
https://github.com/josephschmitt/alexa-libby/releases/tag/v1.2.0
And replaced the dist/api/radar.js with the updated on from here:
https://github.com/josephschmitt/alexa-libby/files/1844983/radarr.zip
I replaced my default.json with my personal config, re-zipped, and re-uploaded to lambda, and everything was working again.

I'll be sure to try that.
On Sat, May 12, 2018, 1:40 PM Ben Conner<EMAIL_ADDRESS>wrote:

I just downloaded the latest compiled zip from here:
https://github.com/josephschmitt/alexa-libby/releases/tag/v1.2.0
And replaced the dist/api/radar.js with the updated on from here:
https://github.com/josephschmitt/alexa-libby/files/1844983/radarr.zip
I replaced my default.json with my personal config, re-zipped, and
re-uploaded to lambda, and everything was working again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/josephschmitt/alexa-libby/issues/25#issuecomment-388581508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjAnOsjAfFTN4DvKvH1aY8DWwDHxWDLlks5tx0i7gaJpZM4SjrbF
.


Slight UI server tabs issue in 4.4.0-rc0

I confirm (by marking "x" in the [ ] below: [x]):

[X] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[X] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have read contributing guidelines.

Summary
Currently the tab appears like this,

Might be better if it appears smoother (or sharper?) like this,

Environment

Operating System: Windows 10
Mattermost Desktop App version: 4.4.0-rc0
Mattermost Server version: 5.18.0

Steps to reproduce
Install the 4.4.0-rc0 desktop app

Closing, this was fixed in v4.7,


Question: Why are the user roles numbered by n^2?

the roles here go up by a square of 2. what was your design for that?
        const ADMIN = 1;
	const AUTHOR = 2;
	const COLLABORATOR = 4;
	const CONSULTANT = 8;
	const CONSUMER = 16;
	const CONTRIBUTOR = 32;
	const COORDINATOR = 64;
	const CREATOR = 128;
	const DEVELOPER = 256;
	const DIRECTOR = 512;

These are flags or bit masks used with bit fields. If ADMIN is 1 and AUTHORis 2, a user with both of these roles would have its bit field set to 3.
If you are merely using the library, as opposed to working on its development, you don’t need to care about the implementation. You can just use the named constants and don’t think about the values or how they are used. The implementation may even change in the future.

If you are merely using the library, as opposed to working on its development, you don’t need to care about the implementation.
I like to learn!

Thank you for the explanation. Very interesting. I love the library. Keep up the great work!

I like to learn!

That’s great!
Just wanted you (and others) to know that you really don’t have to pay attention to the values of those constants in usages of this library.

I love the library. Keep up the great work!

Will try to do, thanks for your appreciation!


Test case for patch, plus fix to not swallow exceptions

[x] closes 13652
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[ ] whatsnew entry

@bdrosen96 : l wonder if you might need another test to further illustrate that these (different) C errors are being generated.  The impression I would get from this test alone is that you were testing for an encoding error.  @jreback what do you think?

[Current coverage][cc-pull] is 84.38%

Merging [#13693][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master     #13693   diff @@
==========================================
  Files           142        142
  Lines         51223      51223
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          43224      43224
  Misses         7999       7999
  Partials          0          0

Powered by Codecov. Last updated by [ada6bf3...9bfebc8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/ada6bf350f7fd4daaf2b80188ca165fb9543a252...9bfebc8cdc854b082b2f62889f8eee823735ae53?src=pr
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13693?src=pr

With this fix, we get the same exception for both engines, where previously we got one exception for python engine and a different one for c engine (the cparser exception with no indication of the root cause of the failure)
I'm not sure what another deterministic stream error we could test here, unless we try to create a fake stream that errors after some number of bytes read.

fyi if you use the # on an issue it references automatically

@bdrosen : what I meant were there any other errors besides the encoding one that the C engine was previously swallowing that are now surfaced?
Just to emphasize: not a blocker, but a nice to have (i.e. a test for another error that was being swallowed)

Yes, there are other cases that would now be surfaced, but they would be hard to create a test for. For example:
1 HTTP request to get remote file as file like object (stream) passed to read-csv. Something goes wrong with network and exception is raised during read. We should now get a non generic error indicating network trouble rather than the generic read() error from before.
2 Same thing with FTP, HDFS, gluster, S3 or any other network type file operation.
3 Stream handle does decompression/unarchive (ie .csv.bz2 or .csv.gz, .csv.tar.gz, etc)
There are probably other cases that I am not aware of now.

@bdrosen96 actually could easily test a network op on a non-existant file (and even an s3 op for the same, just give an invalid bucket).

I don't think testing a network op on invalid bucket or non existant file would work since the exception would likely occur during open rather than read, so that would not help.

pls also add a whatsnew entry, you can put in API section as now better exceptions are passed thru the parser (plus I think the exception type could have changed), e.g. I think previously you would have gotten a CParserError (which is a ValueError), now you can get other things. If you can posit a useful message would be great.

Added whatsnew, closed codec recoder stream and added comment for test

thanks @bdrosen96


[GraphRAG] FalkorDB graph rag integration

Why are these changes needed?

This PR integrates FalkorDB. It wraps FalkorDB as a GraphQueryEngine and could be added to an AG2 agent through GraphRagCapability.
I also include a notebook example to show how to use this feature.
Related issue number

part of https://github.com/ag2ai/ag2/issues/68
Checks

[ ] I've included any doc changes needed for https://ag2ai.github.io/ag2/. See https://ag2ai.github.io/ag2/docs/Contribute#documentation to build and test documentation locally.
[X] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[X] I've made sure all auto checks have passed.

@AgentGenie, thanks so much for putting this together, I'm testing now and it's looking good... is it possible to recreate in a branch in this repo?
This would help with running OpenAI tests (and make it a bit easier for others to update).


[Feature Request]: Add Scroll To Up Feature

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add scroll to up to the project
Use Case
A "scroll to top" button enhances user experience on webpages by providing a quick navigation option. It improves usability
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Go ahead @VaishnaviMankala19

Hello @VaishnaviMankala19! Your issue #330 has been closed. Thank you for your contribution!


default slot content does not preserve newline for text node.

What problem does this feature solve?
allows for implementation of components with inline capability.


Add new key for reactions

Details

Fixed Issues

$ https://github.com/Expensify/App/pull/20001
PROPOSAL: n/a
Tests
Internal testing only

Checkout this pr on web
Reload the page
Click on any chat
Make sure the chat does not move in the LHN

External testing:

Reload the page
Click on any chat
Make sure the chat does not move in the LHN

[x] Verify that no errors appear in the JS console

Offline tests
Same as online
QA Steps

Reload NewDot
Click on any chat
Make sure the chat does not move in the LHN

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/42391420/c759c486-e61a-4bb5-877e-876b16902d0a

Mobile Web - Chrome
https://github.com/Expensify/App/assets/42391420/fb9fb27d-5f7e-43fb-b05a-6c64c51d4aa0

Mobile Web - Safari
https://github.com/Expensify/App/assets/42391420/00718afc-bee0-4938-95b9-699fe5b33f1b

Desktop
https://github.com/Expensify/App/assets/42391420/a3f8b98b-0647-4fdb-bd69-ef58fb694cb4

iOS
https://github.com/Expensify/App/assets/42391420/ba4cca78-4406-480f-985b-6ba5c64aaaae

Android
https://github.com/Expensify/App/assets/42391420/9c663e04-8168-42e2-994f-51f7af8b1d41

As the external reviewer, there is nothing for you to test really. We just need to make sure nothing breaks basically.
There was a deploy blocker created by a web PR that this will fix, but we reverted, and this will prevent it from blocking again

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/alex-mechler in version: 1.3.26-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


GSoC 2017 proposal: Implementation of builtin types Int, Float, Complex and Str

Looking forward to feedback:
Proposal for VOC Project:
Personal Information:
Name - Saurabh Kumar
University – BITS Pilani, Pilani, India
Major – Computer Science and Physics (Final Year undergraduate student)
email –<EMAIL_ADDRESS>Github - https://github.com/Saurabh--Kumar
Task:
I would be completing all the not implemented methods of types Int, Float, Complex and Str, along with their tests. If time permits, I would like to implement math, cmath and fractions modules also (in decreasing order of preference).
Success:
Complete implementation of all the non implemented methods of Int, Float, Complex and Str types. It would be nice to implement some of the optional modules also (math, cmath and fractions).
Experience with Open source:
I am new to open source but I have got my following PRs merged in VOC project in last few days

https://github.com/pybee/voc/pull/408
https://github.com/pybee/voc/pull/445
https://github.com/pybee/voc/pull/448
I’ll be submitting more PRs shortly.

Design Specification:
Pretty much all the methods of types Int, Float and Complex are easy to implement except the __format__() method which I find challenging. Other than that, in Str, I find maketrans(), translate(), isprintable(), isnumeric(), format(), format_map(), encode(), casefold() and __rmod__() challenging. maketrans() and translate() are related and so are format() and format_map(). So understanding one of them will definitely help in understanding the other. These challenging methods require discussion and research so I think i’ll be able to implement 2 or 3 challenging methods in a week, however, in timeline I have taken one challenging method per week along with some easy methods to keep the momentum going. In timeline I have also included the part about the methods which I find challenging.
*There are some PRs pending for some of the string methods currently unimplemented, I’ll remove those methods once the PRs are approved.
*I didn’t find any documentation for byvalue() method for Complex type online. What does this method do? I have not included this method in my time estimate.
*Optional modules are not included in the timeline estimate.

The challenge and the way I am planning to tackle that challenge for the difficult methods is written in the timeline itself.

Timeline:
Community bonding period:

Will be discussing my doubts relevant to challenging methods with mentors.
Will be doing research on handling encoding in java for encode() method and format(), format_map() methods (basically I'll try some simple examples using the specification language)
Will be submitting more PRs.

May, 30 – June,6 (Week 1):

Will implement following Str functions: isidentifier(), replace(), rsplit(), splitlines()
Will implement following Float functions: __pow__(), complete implementation of round()

June,6 – June,13 (Week 2):

Will implement the following Str functions: maketrans(), translate()
Challenge: Dictionary argument may be challenging. I am planning to use java Maps to create a mapping between characters to be replaced and characters being replaced.

June,13 – June,20 (Week 3):

Will Implement following Str functions: rpartitrion(), __rmul__(), __dir__()
Will implement following Complex methods: __bool__(), __dir__(), __float__()

June,20 – June,27(Week 4):

Will implement r methods for Int
Will implement r methods for Complex.

1st evaluation
June,27 – July,4 (Week 5):

Will implement following Str methods: isnumeric(), isprintable()
isprintable() can be implemented with help of this. With some research, I found the list of numeric unicodes. This list can be used for implementing isnumeric().

July,4 – July,18 (Week 6 - week 7):

Will implement following Str methods: format(), format_map()
Challenge: There are many formatting options moreover the format specification is a mini language in itself. Since both methods look related. I have allotted 2 weeks for these.

July,18 – July,25 (Week 8):

Will implement __dir__() and __format__() method for all numeric types. Int, Float and Complex.

2nd Evaluation
July,25 – August,1 (Week 9 week - 10):

Will implement encode() method for Str.
Challenge: There are several types of encodings available. JAVA 7 supports all the encodings supported by Python 3.4 . Python stores characters as code points which can be converted from one encoding to other. I plan to use java.nio.charset package to convert between  different encodings.
Will try to complete casefold() method.
Challenge: Casefolding algorithm. The current implementation of casefold() function is not quite correct. After doing some research, I found the unicode casefolding data.. It covers all the boundary cases. I plan to use this for casefolding implementation.

August,8 – August,15 (Week 11):

Will complete casefold() method if remaining.
Will implement remaining Float methods.

August,15 – August,22 (Week 12):

Will implement __rmod__() for Str type.

August,22 – August,29:
Final submission

Thanks for submitting this proposal. It's a good start.
My biggest concern is the "backlog" and "as many as possible" allocations in your schedule. The entire purpose of the scheduling process is to remove risk. If you need to add "backlog" allowances to your schedule, that's an indication that more elaboration is required.
Your handling of "challenge" items is better - you've started to identify helper libraries and details like that - but more detail is still required. This isn't an area where we're looking for vague plans - we want specifics. Which parts of the standard library can you use? Where does Java deviate from Python in API?
Your schedule also shouldn't include allocations for "discussion" - it goes without saying that you'll be discussing plans with both your mentor, and the wider community. But more importantly, if there are issues where the discussion is significant enough that it warrants inclusion on your schedule, that discussion should be happening now, so we can guide your time estimates.

@freakboy3742 I have made changes to the proposal as per your suggestions. Please go through this modified proposal. waiting for your feedback. Thanks.

Unfortunately, this proposal wasn't accepted.


removed an extra line

There was an extra line that I have translated it to Farsi but I forgot to remove the original sentence.

thanks.


.github/CODEOWNERS: add go compilers and builders

@kalbasit @Mic92 Do you want to be added here?

yes.

Yes, please.


Support multiple documents chat

Can AiServices supported multiple Retriever? maybe from multiple different Embedding Store

@breezexiao yes, but I need to understand use case better.
Let's say you have 2 embedding stores.
Do you want to have 2 independent retrievers and retrieve N most relevant segments from each store, then combine them (2N) and send to LLM?
Or you want to combine two embedding stores under one retriever and retrieve 1N most relevant segments (does not matter from which store they are retrieved, as long as they are most relevant)?
Thanks

@breezexiao just noticed that the title says "Support multiple documents chat".
Just in case and to avoid confusion, you already can load and store multiple documents in a single embedding store.

@breezexiao yes, but I need to understand use case better. Let's say you have 2 embedding stores. Do you want to have 2 independent retrievers and retrieve N most relevant segments from each store, then combine them (2xN) and send to LLM? Or you want to combine two embedding stores under one retriever and retrieve 1xN most relevant segments (does not matter from which store they are retrieved, as long as they are most relevant)? Thanks
@langchain4j yes, that's what it means, Thanks

@breezexiao yes, but I need to understand use case better. Let's say you have 2 embedding stores. Do you want to have 2 independent retrievers and retrieve N most relevant segments from each store, then combine them (2xN) and send to LLM? Or you want to combine two embedding stores under one retriever and retrieve 1xN most relevant segments (does not matter from which store they are retrieved, as long as they are most relevant)? Thanks
@breezexiao Yes, that's what it means, I hope it's the second，Thanks

@breezexiao yes, but I need to understand use case better. Let's say you have 2 embedding stores. Do you want to have 2 independent retrievers and retrieve N most relevant segments from each store, then combine them (2xN) and send to LLM? Or you want to combine two embedding stores under one retriever and retrieve 1xN most relevant segments (does not matter from which store they are retrieved, as long as they are most relevant)? Thanks

@langchain4j Yes, that's what it means, I hope it's the second one

@breezexiao technically this is possible.
I am just trying to understand how this should work.
It is hard to desing a good thing without understanding the use case first.
For this setup (2 embedding stores) to work well:

they should contain embeddings in the same format (e.g. same embedding model was used to embed segments)
they should have similar knowledgebases (by topic)
In this case I am just wandering, if these 2 embeddings stores are so similar, why are they separated?

Could you please describe your use case in details? I am very interested to hear what you are building.
Thank you!

@breezexiao technically this is possible. I am just trying to understand how this should work. It is hard to desing a good thing without understanding the use case first.
For this setup (2 embedding stores) to work well:

they should contain embeddings in the same format (e.g. same embedding model was used to embed segments)
they should have similar knowledgebases (by topic)
In this case I am just wandering, if these 2 embeddings stores are so similar, why are they separated?

Could you please describe your use case in details? I am very interested to hear what you are building. Thank you!

@langchain4j Our current scenario is related to the knowledge base. For example, each user can have multiple document libraries. We hope that users can search the contents of multiple document libraries at the same time. The current PineconeEmbeddingStore(String apiKey, String environment, String projectName, String index , String nameSpace) can only specify one namespace, and Pinecone does not seem to support multiple namespaces. Thanks

@breezexiao if all the libraries of all the users combined are not huge (e.g. < 100K segments), it might make sense to keep all segments in the same embedding store and add a custom metadata for each segment (e.g. userName, libraryName, etc). This way you could add a filter during search/retrieval (search only by documents related to the specific user and/or specific library). I guess this will be easier than maintaining a separate embedding store for each user. What do you think? Metadata filtering is not yet implemented in LangChain4j, but this is something pretty easy/fast to do.

@breezexiao BTW since you have opened 2 issues and I would love to work on them during this week, do you have a preference for priorities? Streaming support first or this one (retrieval)?

@breezexiao BTW since you have opened 2 issues and I would love to work on them during this week, do you have a preference for priorities? Streaming support first or this one (retrieval)?

@langchain4j Priorities are about the same for me, just arrange at your own pace，Thanks

@breezexiao Does this sound good to you?

@breezexiao if all the libraries of all the users combined are not huge (e.g. < 100K segments), it might make sense to keep all segments in the same embedding store and add a custom metadata for each segment (e.g. userName, libraryName, etc). This way you could add a filter during search/retrieval (search only by documents related to the specific user and/or specific library). I guess this will be easier than maintaining a separate embedding store for each user. What do you think? Metadata filtering is not yet implemented in LangChain4j, but this is something pretty easy/fast to do.

Hi @breezexiao, this is now supported: https://github.com/langchain4j/langchain4j/pull/538
I am closing this issue, but feel free to reopen if needed,
Cheers!


Add simplified download command

Solve issues "Simplify the command to download the data #1232"
Description

Follow the above issue, simplified the command like this:

Install Qlib
Run qlib module to download data like this python -m qlib.XXX.get_data qlib_data --target_dir ~/.qlib/qlib_data/cn_data --region cn

And update documetation.
Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[X] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[X] Add new feature
[X] Update documentation

Thanks!
It looks great!!!!!


Upgraded library versions to avoid security vulnerability

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
The following dependencies have some vulnerabilities and should be updated:

h2database 1.4.200 → 2.1.214
kotlin 1.6.20 → 1.7.20
postgresql 42.4.1 → 42.5.0
log4j and log4j-template-json 2.17.1 → 2.19.0
jackson-dataformat-yaml 2.13.2 → 2.14.0
spring-beans → org.springframework:spring-beans:5.3.20
tomcat-embed-core: → org.apache.tomcat.embed:tomcat-embed-core: 9.0.63
kotlin-scripting-jvm → org.jetbrains.kotlin:kotlin-scripting-jvm: 1.7.20
spring-context → org.springframework:spring-context:5.3.20
netty-common → io.netty:netty-common:4.1.77.Final
aws-java-sdk-s3 → com.amazonaws:aws-java-sdk-core:1.12.342
spring-expression → org.springframework:spring-expression:5.3.20
spring-messaging → org.springframework:spring-messaging:5.3.20

Why
Fix security vulnerability.
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr661.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr661.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr661.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr661.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr661.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr661.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr661.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr661.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr661.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr661.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr661.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr661.previews.kube001.services.stellar-ops.com/


Clarification needed

Hello,
The Message displayed by the following line is confusing. What does internally mean:

Is it to the containing object
Is it to the project containing the object

Message('My procedure is available internally.');
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 723d5c70-5fff-3343-6ca3-f71d400e7be1
Version Independent ID: 86793f6a-1a90-9f2b-1de5-b90e56e32b02
Content: Scope Attribute - Business Central
Content Source: dev-itpro/developer/methods/devenv-scope-attribute.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hello, thanks for the feedback. The topic has been updated. The scope attribute specifies whether a method is available only on-prem and thereby not accessible from any cloud service. Thanks.


Fixing issues

fixed issues detected by SonarLint

nice fix bro 10/10 would review this again

nice fix bro 10/10 would review this again

thanks bro im gonna merge then


When function is created, the CPU  of the functions worker node will rise rapidly

Describe the bug
pulsar 2.5.2

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]

Additional context
Add any other context about the problem here.

@xuesong172500 Can you share more details about this?

Create a function and you can reproduce it. Set 1 or 10 parallelism.

@xuesong172500 This is caused by too many jar packages. We can try to use a smaller tarball. Each time we use maven to build, we only place the corresponding module. We are also optimizing the logic. For the same jar package can be considered instead of reloading a jar for every function.

@xuesong172500 This is caused by too many jar packages. We can try to use a smaller tarball. Each time we use maven to build, we only place the corresponding module. We are also optimizing the logic. For the same jar package can be considered instead of reloading a jar for every function.

@wolfstudy By reducing the size of jar package, we can reduce the CPU utilization to some extent.

cool @xuesong172500 , will close this issue


Global variables

I have defined a number of global variables in a .globals file that I import into my index.ios.js file. I am trying to switch over to typescript and that import is now in index.ios.tsx and it does not work. The global variables are undefined.
My tsconfig is
{
  "compilerOptions": {
    "jsx": "react",
    "target": "es2015",
    "moduleResolution": "node",
    "sourceMap": true,
    "allowSyntheticDefaultImports": true,
    "allowJs": true
  },
  "exclude": [
    "node_modules"
  ]
}

My webpack is
module.exports = ({ platform }, {module, resolve}) => ({
  entry: `./index.${platform}.tsx`,
  module: {
    ...module,
    rules: [
      {
        test: /\.js?$/,
        exclude: '/node_modules/',
        use: [
          {
            loader: 'babel-loader'
          }
        ]
      },
      {
        test: /\.tsx?$/,
        exclude: '/node_modules/',
        use: [
          {
            loader: 'babel-loader',
            options: {
              presets: ['es2015']
            }
          },
          {
            loader: 'ts-loader'
          }
        ]
      },
      ...module.rules
    ]
  },
  resolve: {
    ...resolve,
    extensions: [
      `.${platform}.js`,
      '.ts',
      '.tsx',
      `.${platform}.ts`,
      '.native.ts',
      `.${platform}.tsx`,
      '.native.tsx',
      ...resolve.extensions
    ]
  }
});

I have defined a number of global variables in a .globals file that I import into my index.ios.js file

I'm not sure what you mean by that. Can you post code sample?

Sorry, I meant globals.js
So it has
global._t = ( msg ) => {
  if (msg === undefined) {
    return msg;
  }
  try {
    return i18n.translate( msg ).fetch();
  } catch( e ) {
    console.error( msg, e );
    return msg;
  }
};

for example
And then I have
import {
  AppRegistry
} from 'react-native';
import globals from './app/globals';
import app from './app/app';

AppRegistry.registerComponent( 'mobile', () => app );

I don't think this has anything to do with Haul. I am not a Typescript expert, so I think it's best to check for general solution on how to define / override global variables with it.
In the meantime, I am going to close this issue.


Documentation error in 'Robot Framework User Guide' online manual

Hi Team,
An error found in Robot Framework User Guide online manual.
In section "Free keyword arguments (**kwargs)", an example shows how normal arguments, varargs, and kwargs work together. But unfortunately, the 3rd test case **Kwargs** is not correct: the keyword "Various Args" expects at least 1  non-named argument but actually got 0 in example.

Good catch and thanks for the report! Need to decide what's the best way to fix this. I see two easy solutions:

Add a positional argument to Kwargs example and change the comment about logging accordingly. Something like:
Kwargs
    Various Args    mandatory    a=1    b=2    c=3
    Various Args    mandatory    c=3    a=1    b=2

A problem is that then this is pretty much same as the Positional and kwargs example.

Change the keyword implementation to make arg optional:
def various_args(arg=None, *varargs, **kwargs):
    if arg is not None:
        print('arg:', arg)
    # rest of the function like earlier

A benefit of this approach is that examples don't need to be touched.


No Output

I didn't get any results after entering the command. What could be the problem?
Could you possibly spare some time to take a look for me, please? I would greatly appreciate your help. The command I used is as follows:
nohup hifiasm_meta -t 32 -o asm /PATH/TO/MY/FILES/raw_sequencing_reads_hifi_reads.fa > assembly.log 2>&1 &

The process only ran up to the "read correction round" stage, with no further progress, and no error messages were reported.

Sorry for the late reply. Could you post the assembly.log?
The read correction might take some time each round, during which hifiasm-meta also does not write progress until most computes are finished. It might be silently running if you haven't checked with top or ps.
Another possibility is that nohup without disown ended up killed after you logged out, if you did log out (like so). But in this case I guess the log should have its last line saying killed or something. (I usually stick jobs into tmux sessions and do not know much about nohup, this guess might be wrong.)


Basic SKU for public ip address is deprecated and no longer valid when trying to attach to most vpn gateway skus

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Set vpn gateway sku to VpnGw1
Deploy fails as a basic public ip cannot be used for this sku type anymore, basic public ip only works for basic vpn gateway, docs here

https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/blob/main/modules/connectivity/locals.tf#L748
I've worked around it for now by using custom settings override but the defaults need to be fixed.

Hey @valsharess,
Thanks for reporting.
This will need to be changed in a new major release as it will be a breaking change for those that have the basic SKU for IPs already deployed.
But we will update the ALZ TF Accelerator to have these overrides set by default out of the box which @jaredfholgate will take a look at 👍

Hi, This is blocking us from deploying a new Landing Zone.  Is there any update on the status of getting this resolved?

Hi, This is blocking us from deploying a new Landing Zone. Is there any update on the status of getting this resolved?

You can override the sku with custom settings, you shouldn't be totally blocked

Hi, This is blocking us from deploying a new Landing Zone. Is there any update on the status of getting this resolved?

You can override the sku with custom settings, you shouldn't be totally blocked

Thanks, It would be good to get a working example on this thread

Hi, This is blocking us from deploying a new Landing Zone. Is there any update on the status of getting this resolved?

You can override the sku with custom settings, you shouldn't be totally blocked

Thanks, It would be good to get a working example on this thread

    advanced = {       custom_settings_by_resource_type = {         azurerm_public_ip = {           connectivity_vpn = {             australiaeast = {               sku = "Standard"               allocation_method = "Static"             }

Thanks I got it working using the custom settings shared but note that I also had to change my SKU from VpnGw1 to VpnGw1AZ.
I was checking https://learn.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-about-vpngateways#gwsku and I cannot find "Standard" SKU. Did I miss something ?

Ok I am stuck and quite confused. While I was able to use workaround to deploy VPN gateway in uksouth, I am unable to deploy on ukwest. If I don't use the custom_setting workaround for ukwest (aka I deploy Basic PIP), it seems the plan seems correct but the module gets me error that
Here is an extract from the plan:
module.caf-enterprise-scale.azurerm_public_ip.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip"] will be created

resource "azurerm_public_ip" "connectivity" {

allocation_method       = "Dynamic"
ddos_protection_mode    = "VirtualNetworkInherited"
fqdn                    = (known after apply)
id                      = (known after apply)
idle_timeout_in_minutes = 4
ip_address              = (known after apply)
ip_version              = "IPv4"
location                = "ukwest"
name                    = "dev-vpngw-ukwest-pip"
resource_group_name     = "dev-connectivity-ukwest"
sku                     = "Basic"
sku_tier                = "Regional"
tags                    = {

"demo_type"  = "deploy_connectivity_resources_custom"
"deployedBy" = "terraform/azure/caf-enterprise-scale"
}
}

module.caf-enterprise-scale.azurerm_public_ip.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip2"] will be created

resource "azurerm_public_ip" "connectivity" {

allocation_method       = "Dynamic"
ddos_protection_mode    = "VirtualNetworkInherited"
fqdn                    = (known after apply)
id                      = (known after apply)
idle_timeout_in_minutes = 4
ip_address              = (known after apply)
ip_version              = "IPv4"
location                = "ukwest"
name                    = "dev-vpngw-ukwest-pip2"
resource_group_name     = "dev-connectivity-ukwest"
sku                     = "Basic"
sku_tier                = "Regional"
tags                    = {

"demo_type"  = "deploy_connectivity_resources_custom"
"deployedBy" = "terraform/azure/caf-enterprise-scale"
}
}

module.caf-enterprise-scale.azurerm_virtual_network_gateway.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/virtualNetworkGateways/dev-vpngw-ukwest"] will be created

resource "azurerm_virtual_network_gateway" "connectivity" {

active_active                         = true

bgp_route_translation_for_nat_enabled = false

enable_bgp                            = true

generation                            = "Generation1"

id                                    = (known after apply)

ip_sec_replay_protection_enabled      = true

location                              = "ukwest"

name                                  = "dev-vpngw-ukwest"

remote_vnet_traffic_enabled           = false

resource_group_name                   = "dev-connectivity-ukwest"

sku                                   = "VpnGw1"

tags                                  = {

"demo_type"  = "deploy_connectivity_resources_custom"
"deployedBy" = "terraform/azure/caf-enterprise-scale"
}

type                                  = "Vpn"

virtual_wan_traffic_enabled           = false

vpn_type                              = "RouteBased"

ip_configuration {

name                          = "dev-vpngw-ukwest-pip"
private_ip_address_allocation = "Dynamic"
public_ip_address_id          = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip"
subnet_id                     = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/virtualNetworks/dev-hub-ukwest/subnets/GatewaySubnet"
}

ip_configuration {

name                          = "dev-vpngw-ukwest-pip2"
private_ip_address_allocation = "Dynamic"
public_ip_address_id          = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip2"
subnet_id                     = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/virtualNetworks/dev-hub-ukwest/subnets/GatewaySubnet"
}
}

And here is the error. For now apparent reason, the basic, region PIP creation API is requesting AZ ???
│ Error: creating/updating Public Ip Address: (Name "dev-fw-ukwest-pip" / Resource Group "dev-connectivity-ukwest"): network.PublicIPAddressesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="LocationNotSupportAvailabilityZones" Message="The resource 'Microsoft.Network/publicIPAddresses/dev-fw-ukwest-pip' does not support availability zones at location 'ukwest'."
│
│   with module.caf-enterprise-scale.azurerm_public_ip.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-fw-ukwest-pip"],
│   on .terraform\modules\caf-enterprise-scale\resources.connectivity.tf line 109, in resource "azurerm_public_ip" "connectivity":
│  109: resource "azurerm_public_ip" "connectivity" {

FYI, the workaround does not seem to work when deploying into a non-AZ enabled region.
Here is what happen when I try to deploy on ukwest.
advanced = {
custom_settings_by_resource_type = {
azurerm_public_ip = {
connectivity_vpn = {
ukwest = {
sku = "Standard"
allocation_method = "Static"
},
uksouth = {
sku = "Standard"
allocation_method = "Static"
}
}
},
Only the first pip is setup with Standard. It seems the custom settings is not applying to the second pip (pip2 below). Seems to be potentially another bug with custom settings ?
module.caf-enterprise-scale.azurerm_public_ip.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip"] will be created

resource "azurerm_public_ip" "connectivity" {

allocation_method       = "Static"
ddos_protection_mode    = "VirtualNetworkInherited"
fqdn                    = (known after apply)
id                      = (known after apply)
idle_timeout_in_minutes = 4
ip_address              = (known after apply)
ip_version              = "IPv4"
location                = "ukwest"
name                    = "dev-vpngw-ukwest-pip"
resource_group_name     = "dev-connectivity-ukwest"
sku                     = "Standard"
sku_tier                = "Regional"
tags                    = {

"demo_type"  = "deploy_connectivity_resources_custom"
"deployedBy" = "terraform/azure/caf-enterprise-scale"
}
}

module.caf-enterprise-scale.azurerm_public_ip.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip2"] will be created

resource "azurerm_public_ip" "connectivity" {

allocation_method       = "Dynamic"
ddos_protection_mode    = "VirtualNetworkInherited"
fqdn                    = (known after apply)
id                      = (known after apply)
idle_timeout_in_minutes = 4
ip_address              = (known after apply)
ip_version              = "IPv4"
location                = "ukwest"
name                    = "dev-vpngw-ukwest-pip2"
resource_group_name     = "dev-connectivity-ukwest"
sku                     = "Basic"
sku_tier                = "Regional"
tags                    = {

"demo_type"  = "deploy_connectivity_resources_custom"
"deployedBy" = "terraform/azure/caf-enterprise-scale"
}
}

module.caf-enterprise-scale.azurerm_virtual_network_gateway.connectivity["/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/virtualNetworkGateways/dev-vpngw-ukwest"] will be created

resource "azurerm_virtual_network_gateway" "connectivity" {

active_active                         = true

bgp_route_translation_for_nat_enabled = false

enable_bgp                            = true

generation                            = "Generation1"

id                                    = (known after apply)

ip_sec_replay_protection_enabled      = true

location                              = "ukwest"

name                                  = "dev-vpngw-ukwest"

remote_vnet_traffic_enabled           = false

resource_group_name                   = "dev-connectivity-ukwest"

sku                                   = "VpnGw1"

tags                                  = {

"demo_type"  = "deploy_connectivity_resources_custom"
"deployedBy" = "terraform/azure/caf-enterprise-scale"
}

type                                  = "Vpn"

virtual_wan_traffic_enabled           = false

vpn_type                              = "RouteBased"

ip_configuration {

name                          = "dev-vpngw-ukwest-pip"
private_ip_address_allocation = "Dynamic"
public_ip_address_id          = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip"
subnet_id                     = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/virtualNetworks/dev-hub-ukwest/subnets/GatewaySubnet"
}

ip_configuration {

name                          = "dev-vpngw-ukwest-pip2"
private_ip_address_allocation = "Dynamic"
public_ip_address_id          = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/publicIPAddresses/dev-vpngw-ukwest-pip2"
subnet_id                     = "/subscriptions/2560ed2d-c2de-48d7-b953-cb112107a0f5/resourceGroups/dev-connectivity-ukwest/providers/Microsoft.Network/virtualNetworks/dev-hub-ukwest/subnets/GatewaySubnet"
}
}

Hi, This is blocking us from deploying a new Landing Zone. Is there any update on the status of getting this resolved?

You can override the sku with custom settings, you shouldn't be totally blocked

Thanks, It would be good to get a working example on this thread

      custom_settings_by_resource_type = {
        azurerm_public_ip = {
          connectivity_vpn = {
            australiaeast = {
              sku = "Standard"
              allocation_method = "Static"
            }

Where to add this block?

Thanks I got it working using the custom settings shared but note that I also had to change my SKU from VpnGw1 to VpnGw1AZ (I was getting another error initially after using the custom_settings_by_resource_type override)

can you share how did you add it?

yes, i finally got it working, thank. however, i am facing a problem with this

Hi, This is blocking us from deploying a new Landing Zone. Is there any update on the status of getting this resolved?

You can override the sku with custom settings, you shouldn't be totally blocked

Thanks, It would be good to get a working example on this thread

      custom_settings_by_resource_type = {
        azurerm_public_ip = {
          connectivity_vpn = {
            australiaeast = {
              sku = "Standard"
              allocation_method = "Static"
            }

overriding by resource type is understood that you will override settings, but what is the duty of connectivity_vpn phrase? how does it translate in the settings?
I am trying to override another setting outside the ip settings, but does not read. what how to write it from scrash?

overriding by resource type is understood that you will override settings, but what is the duty of connectivity_vpn phrase? how does it translate in the settings?
I am trying to override another setting outside the ip settings, but does not read. what how to write it from scrash?

overriding by resource type is understood that you will override settings, but what is the duty of connectivity_vpn phrase? how does it translate in the settings?
I am trying to override another setting outside the ip settings, but does not read. what how to write it from scrash?

Our plans are to default to AZ SKUs in the next major version.
When we do this we will swap the IP to standard.

@matt-FFFFFF Wasn't v6 the next major release? This is still an issue with v6.
For everyone else, the connectivity_vpn is to distinguish VPN gateways from ER gateways. Overriding ER gateway details uses connectivity_expressroute. If you're deploying your VPN GW in active/active mode (which you probably should), you'll also need to override connectivity_vpn_2 (for the azurerm_public_ip resource type).


Questions: Named/tagged  "fallback" approach leads to multiple singletons

I'm struggling to understand the reasoning or the approach I should be taking when using "tag" due to the fallback design
https://github.com/AliSoftware/Dip/wiki/named-definitions#note-on-fallback
It appears it can lead to flagrant disregard of (.singleton) scopes, and then to very difficult to find bugs. I can easily see how the innocuous use of naming parameters could lead to unwanted clones of singleton objects. Your very example modified slightly suggests this would be the case
class OAuth2Service { //The one to rule them all
     init(){}
}

class APIClientImp{
     init(url: NSURL, oauth: OAuth2Service) {}
}

container.register(.singleton) { OAuth2Service()}
container.register(tag: "api") { NSURL(string: ...)! }
container.register(tag: "api2") { NSURL(string: ...)! }
container.register { try APIClientImp(url: $0, oauth: $1) as APIClient }

let container = try! container.resolve(tag: "api") as APIClient
let container2 = try! container.resolve(tag: "api2") as APIClient
container1.oauth !== container2.oauth

This would catastrophically create two OAuth2Service() services despite clear instructions against that.
What alternatives are there? I'm concerned this will be debilitating since you need to somehow register and tag primitives.

This is how auto-wiring is designed, it bypasses the tag that you use to resolve dependencies implicitely. If this is unneeded for some of dependencies (oauth client here) resolve them explicitly in the factory closure. This should work:
class OAuth2Service { //The one to rule them all init(){} } class APIClientImp{ init(url: NSURL, oauth: OAuth2Service) {} } container.register(.singleton) { OAuth2Service()} container.register(tag: "api") { NSURL(string: ...)! } container.register(tag: "api2") { NSURL(string: ...)! } container.register { [unowned container] try APIClientImp(url: $0, oauth: container.resolve()) as APIClient }

Ilya Puchka
Отправлено с iPhone

3 апр. 2017 г., в 7:23, jtwigg<EMAIL_ADDRESS>написал(а):
I'm struggling to understand the reasoning or the approach I should be taking when using "tag" due to the fallback design
https://github.com/AliSoftware/Dip/wiki/named-definitions#note-on-fallback
It appears it can lead to flagrant disregard of (.singleton) scopes, and then to very difficult to find bugs. I can easily see how the innocuous use of naming parameters could lead to unwanted clones of singleton objects. Your very example modified slightly suggests this would be the case
class OAuth2Service { //The one to rule them all
init(){}
}
class APIClientImp{
init(url: NSURL, oauth: OAuth2Service) {}
}
container.register(.singleton) { OAuth2Service()}
container.register(tag: "api") { NSURL(string: ...)! }
container.register(tag: "api2") { NSURL(string: ...)! }
container.register { try APIClientImp(url: $0, oauth: $1) as APIClient }
let container = try! container.resolve(tag: "api") as APIClient
let container2 = try! container.resolve(tag: "api2") as APIClient
container1.oauth !== container2.oauth
This would catastrophically create two OAuth2Service() services despite clear instructions against that.
What alternatives are there? I'm concerned this will be debilitating since you need to somehow register and tag primitives.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Update utest to 0.7.8

Updates com.lihaoyi:utest from 0.7.7 to 0.7.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "utest" } ]

labels: test-library-update, semver-patch

Switching to munit


Bump coroutines version to 1.3.0

Use the latest version of Kotlin coroutines and avoid the use of the ExperimentalCoroutinesApi annotation.

Addressed in #474


Bump IOGX to V4

Updates the nix code to iogx v4 ; notable changes:

formatters.nix included in shell.nix
more explicit outputs in nix/outputs.nix
no more inputs/inputs', just inputs
l argument renamed to lib

@abailly-iohk owns this I think.


chore: Add passing Markdownlint config

@nschonni - looks like a really cool tool. https://github.com/markdownlint/markdownlint   Merging. 👍

It actually uses https://github.com/DavidAnson/markdownlint which is included as part of the MS Docs Authoring pack

Ahh ok got you. I am learning a lot just following along with your PRs. :)


Could from_value borrow the JsValue instead?

Hi there, I've hit a scenario where I'd like to decode the same JsValue a number of times, but it seems that from_value wants full ownership of its argument. Is there a technical reason why the arg can't be borrowed instead? For instance, the good ol' JsValue::into_serde does borrow its arg.
Cheers and thank you!

It's because deserializer itself needs to hold JsValue in various places, and holding borrow would mean introducing extra lifetimes in the APIs as well as dereferencing overhead on all JsValue calls (or implicitly cloning when value is passed to the API, which is also not ideal).
Additionally, most usecases just do a one-off conversion to a Rust type and never use original JsValue again, so changing the API and adding that overhead would be a net negative for the common case.
That said, note that JsValue is essentially just a newtype around an integer (an index to a value on the JS side), that is, by itself, it's as cheap to clone as, say, Rc<T>. That means you can call from_value(js_value.clone()) yourself with basically zero overhead if you want to keep original JsValue around.
Does that not cover your usecase?

Wait, so does JsValue::clone() do a deep copy on the JS side or anything?

do a deep copy on the JS side or anything

No, it's literally just increasing refcount to the value, much like if you did let b = a; in JS.

Then that should do it for me, thank you!


Update gRPC version

This change is

Current dependencies on/for this PR:

main

PR #222   👈

This stack of pull requests is managed by Graphite.


Reunião 19/01/2021

Reunião semanal

Data: 19 de janeiro de 2021
Ata da reunião anterior: Link
Participantes:

Nome 1
Nome 2

Acompanhamento das ações pendentes da última reunião

[ ] Tarefa importante que ficamos de fazer (link para a issue criada)
[ ] Tarefa importante que ficamos de fazer (link para a issue criada)
[ ] Tarefa importante que ficamos de fazer (link para a issue criada)

Itens a serem debatidos
:warning: Sugestões nos comentários

@BOSS-BigOpenSourceSister/mentoras

Como podemos melhorar nosso processo de seleção para contemplar melhor as minorias?
Planos para a entrega da fase 3

Como podemos melhorar nosso processo de seleção para contemplar melhor as minorias?
Planos para a entrega da fase 3

Como estruturar um framework para mentoras?

Comunicação boss ?!

Como estruturar um framework para mentoras?

Comunicação boss ?!

Discutir atividades semanais para que elas não virem um "dever de casa", tirando o foco da contribuição com a comunidade.
Transparência sobre o progresso e atividades que estamos fazendo com as little sisters, principalmente as "fora do currículo";
Como podemos incentivar mais as mentoradas a tentarem "resolver as dores que elas sentem na comunidade"?
Redes sociais;

Discutir atividades semanais para que elas não virem um "dever de casa", tirando o foco da contribuição com a comunidade.
Transparência sobre o progresso e atividades que estamos fazendo com as little sisters, principalmente as "fora do currículo";
Como podemos incentivar mais as mentoradas a tentarem "resolver as dores que elas sentem na comunidade"?
Redes sociais;

During Phase Three of the Community Engagement Challenge, the GNOME goal is to offer as much support as possible to you and your project.  In doing so, we hope to raise awareness of your project, generate community support and elevate your project to whatever level you wish.  In that vein, we've designed several outreach opportunities.  These are all optional and will not be judged.
Opportunity 1 - Conversation with Judges - Over the course of the next three weeks, we would like to arrange a meeting between your project team and the judges.  This is the opportunity to share your project and receive guidance and feedback directly from the judges.  If you would like to participate, please send me a few date/times that work for your team.  When making your suggestions, please keep in mind that our judges are based in PST, EST and UK time zones
Opportunity 2 - Social Media takeover - We would like to share your project with every member of the GNOME and FOSS community. We have allocated one day to each team to "take over" the GNOME twitter/linkedin/Facebook account.  Our social media team will be posting your messages but we need you to create them! We will need a handful of posts (15+) from you, in your voice.  Themes should be Challenge/project related but can include:  1. Intro to team members, 2. a day in the life of your project 3.  How the idea of your project came about 4.  How you  incorporate, use your project. Remember that twitter has character limits, so break your messages up into shorter tweets.  Please let us know what day you would like your posts to go live.  Please include relevant hastags and tags.
Opportunity 3 - Challenge Panel Discussion at FOSDEM (details TBD) -  FOSDEM takes place the first weekend in Feb. Traditionally it is hosted in Brussels, Belgium.  This year, it will be virtual! GNOME will have a booth and be promoting our products, speakers, and hosted events. During our booth time, we will be hosting a virtual Challenge themed chat.  This will include a short description of your project and a Q & A lead by me about your project, etc.  If a member of your team would like to participate, let me know and I will keep you posted on date/time/questions.
Opportunity 4 - Hackfest at FOSDEM - During FOSDEM, we will also be promoting hackfests.  If you would like to host a hackfest for your project, let us know.  You will need to select a date/time and we can share with the community, the hackfest link and issues you hope to resolve.  While we can promote on your behalf, you'll need to manage the hackfest and invite users to participate, etc.
These are just a few things that we are putting together to help support you during Phase 3.  If you have any other ideas or things you would like to see, please do not hesitate to reach out.
I look forward to hearing from you.

During Phase Three of the Community Engagement Challenge, the GNOME goal is to offer as much support as possible to you and your project.  In doing so, we hope to raise awareness of your project, generate community support and elevate your project to whatever level you wish.  In that vein, we've designed several outreach opportunities.  These are all optional and will not be judged.
Opportunity 1 - Conversation with Judges - Over the course of the next three weeks, we would like to arrange a meeting between your project team and the judges.  This is the opportunity to share your project and receive guidance and feedback directly from the judges.  If you would like to participate, please send me a few date/times that work for your team.  When making your suggestions, please keep in mind that our judges are based in PST, EST and UK time zones
Opportunity 2 - Social Media takeover - We would like to share your project with every member of the GNOME and FOSS community. We have allocated one day to each team to "take over" the GNOME twitter/linkedin/Facebook account.  Our social media team will be posting your messages but we need you to create them! We will need a handful of posts (15+) from you, in your voice.  Themes should be Challenge/project related but can include:  1. Intro to team members, 2. a day in the life of your project 3.  How the idea of your project came about 4.  How you  incorporate, use your project. Remember that twitter has character limits, so break your messages up into shorter tweets.  Please let us know what day you would like your posts to go live.  Please include relevant hastags and tags.
Opportunity 3 - Challenge Panel Discussion at FOSDEM (details TBD) -  FOSDEM takes place the first weekend in Feb. Traditionally it is hosted in Brussels, Belgium.  This year, it will be virtual! GNOME will have a booth and be promoting our products, speakers, and hosted events. During our booth time, we will be hosting a virtual Challenge themed chat.  This will include a short description of your project and a Q & A lead by me about your project, etc.  If a member of your team would like to participate, let me know and I will keep you posted on date/time/questions.
Opportunity 4 - Hackfest at FOSDEM - During FOSDEM, we will also be promoting hackfests.  If you would like to host a hackfest for your project, let us know.  You will need to select a date/time and we can share with the community, the hackfest link and issues you hope to resolve.  While we can promote on your behalf, you'll need to manage the hackfest and invite users to participate, etc.
These are just a few things that we are putting together to help support you during Phase 3.  If you have any other ideas or things you would like to see, please do not hesitate to reach out.
I look forward to hearing from you.


Cleanup

Removes the example Rust workflow and updates the license & readme

@huitseeker thanks for the review. I saw https://github.com/lurk-lab/lurk-rs/issues/396 when making these changes and I believe I have used the correct licenses:
https://github.com/licenses/license-templates/blob/master/templates/mit.txt
https://github.com/licenses/license-templates/blob/master/templates/apache-header.txt
Let me know if I've made any errors. Otherwise I'll make a similar PR to lurk-rs


Move from --api-servers to --kubeconfig flag on kubelet

api-servers is, you guessed it, deprecated.
I expect it to be removed for 1.6.
The replacement is a rote transformation of each time we use --api-servers=$foo we need to turn it into --kubeconfig=/path/to/kubeconfig --require-kubeconfig, containing a default cluster that specifies a server of $foo.
I have the changes to the docs over here but haven't done sufficient testing nor finished fixing it in the remaining places.
I've assigned myself since I expect to get back to this and finish/test suitably before too long, but if anyone else wants to drop a comment and pick it up, please feel free.

This probably isn't relevant anymore, I'll go ahead and close it.


Add -a flag.

Add -a to the kubectl get pods to get terminated pods as well.

This change is

@steveperry-53 :wave: Do you need/want more review on this, or is it good to merge?


cluster mode adding py files

I want to work in cluster mode. But it can't be installed directly in the cluster. How can I pass this in my spark-submit script ?
Can you please add instruction to help with this.

I think this is rather a Spark's general issue. See, for instance, https://issues.apache.org/jira/browse/SPARK-13587
Currently,

Install it via pip in all nodes
Try to zip the source codes by yourself and ship it via py-files.
I remember somebody wrote a blog about packing it with PEX that already works in PySpark. See https://medium.com/criteo-labs/packaging-code-with-pex-a-pyspark-example-9057f9f144f3

I don't think there is anything we can do within this library but in Apache Spark.

I am leaving this closed. I would suggest to interact with Spark mailing list.


[SPARK-15238] Clarify supported Python versions

This PR:

Clarifies that Spark does support Python 3, starting with Python 3.4.

Test build #58196 has started for PR 13017 at commit e914930.

Test build #58197 has started for PR 13017 at commit dc1a15b.

Test build #58196 has finished for PR 13017 at commit e914930.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58196/
Test PASSed.

Test build #58197 has finished for PR 13017 at commit dc1a15b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58197/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

Merged to master/2.0


INodesInPath

dir.resolvePath
dir.getINodesInPath
INodesInPath.resolve
INodesInPath.fromComponents
INodesInPath.fromINode
FSDirWriteFileOp.resolvePathForStartFile

Looks we don't need to change INodesInPath


Manage Packages headings should be more descriptive

When you visit /account/Packages, the column headings on the table should say: Title, Id, Description, Downloads
Make sure Unlisted Packages is consistent.

Meh. Perhaps it will get covered with a redesigned site. :-)


Create docker development environment for URC

Already included as part of #13, we'll be using Docker to get our CI pipeline setup


Add coverage report and threshold

Add coverage report thanks to the python-coverage GitHub action https://github.com/marketplace/actions/python-coverage
The action reports the coverage as a GitHub comment. It also allows defining thresholds for the level of coverage. For now, setting an 80% thresholds for new files and zero for existing content. Once the report is published to PRs we can start working on bringing the coverage up to the desired level and enable the threshold for existing code.
We run unit tests for four different versions of python, but I don't think we need coverage for each.
Nonetheless, I changed the tox.ini to make sure that the coverage reports from the four runs do not override each other, and produce both html and xml reports.
Html is convenient when running locally, xml is needed by the action.
The action uses the coverage report for python 3.11
Fixes: #146

@joerunde I tested this set of permissions on my fork and it worked fine:
    permissions:
      contents: read
      pull-requests: write

I think the only bit missing might be to remove the GITHUB_TOKEN from the secrets, so that we get the automatic one with the scope specified in the workflow definition.

@afrittoli something's still off then, there is no extra GITHUB_TOKEN in the secrets, github won't let you add any secret that starts with GITHUB_ :(

@afrittoli I found that I needed to go to the org-wide settings to check the "Read and write permissions" button for actions, but this is still failing after I re-ran the job :(


Fix some issues reported by lintian

Fix some issues reported by lintian

Use secure copyright file specification URI. (insecure-copyright-format-uri)
Use secure URI in Homepage field. (homepage-field-uses-insecure-uri)
Bump debhelper from deprecated 9 to 12. (package-uses-deprecated-debhelper-compat-version)
Set debhelper-compat version in Build-Depends. (uses-debhelper-compat-file)
Set upstream metadata fields: Bug-Database, Bug-Submit, Repository, Repository-Browse. (upstream-metadata-file-is-missing, upstream-metadata-missing-bug-tracking, upstream-metadata-missing-repository)

This merge proposal was created automatically by the Janitor bot.
You can follow up to this merge proposal as you normally would.
Build and test logs for this branch can be found at
https://janitor.debian.net/lintian-fixes/pkg/libphp-swiftmailer/c5d48847-cc49-4667-b65b-936d4a99e95c.
Debdiff
These changes affect the binary packages:
File lists identical (after any substitutions)
Control files of package libphp-swiftmailer: lines which differ (wdiff format)

Homepage: [-http://swiftmailer.org/-] {+https://swiftmailer.org/+}

Control files of package php-swiftmailer: lines which differ (wdiff format)

Homepage: [-http://swiftmailer.org/-] {+https://swiftmailer.org/+}

You can also view the diffoscope diff (unfiltered).

This merge proposal will be closed, since all remaining changes have been
applied independently.

This merge proposal will be closed, since the branch for the role 'main'
has changed to None.


Broken Link to Google Colab Notebook

you may whant to consider replacing the link to Google Colab Notebook with
Google Colab Notebook in README.md
Replace spaces with %20 : ESC50:%20Environmental%20Sound%20Classification.ipynb

Thank you emma. Feel free to make a PR doing this?

Thank you emma. Feel free to make a PR doing this?

Closed by #83

Closed by #83


Embed Image doesn't work any more

I and my students have tried a few different urls and the drag and drop feature, but we haven't been able to embed images into any cocreate for a few weeks.
I searched open issues and didn't find this one (apologies if I missed it somewhere)

Oops, I realize that the proxy server I run was down. Hopefully it should be working again. Let me know it not.


⚠ AsianCinema has degraded performance

In 6b36e91, AsianCinema ($ACM) experienced degraded performance:

HTTP code: 523
Response time: 20702 ms

Resolved: AsianCinema performance has improved in eb81a8f.


Deploy the Fiori App to Cloud Foundry

Tutorial URL: https://developers.sap.com/tutorials/sapui5-fiori-cf-deploy.html
Please specify the step you are referring to Step 2: Deploy the built archive
This step is not working, I'm trying for 2 days now, I searched on internet for tips, I tried to change the Quota values but nothing. It doesn't work for me !!!
This is part of the cf deploy cmd:

...
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Proceeding with automatic retry... (3 of 3 attempts left)
Executing task "deploy" on application "products_launchpad_deployer"...
Application "products" started and available at "2dd3c381trial-dev-> products.cfapps.eu10.hana.ondemand.com"
Execution of task "deploy" on application "products_launchpad_deployer" failed.
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Proceeding with automatic retry... (2 of 3 attempts left)
Executing task "deploy" on application "products_launchpad_deployer"...
Execution of task "deploy" on application "products_launchpad_deployer" failed.
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Proceeding with automatic retry... (1 of 3 attempts left)
Executing task "deploy" on application "products_launchpad_deployer"...
Execution of task "deploy" on application "products_launchpad_deployer" failed.
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Process failed.
Use "cf deploy -i 5ffe98c8-913b-11ea-91ca-eeee0a92ba04 -a abort" to abort the process.
Use "cf deploy -i 5ffe98c8-913b-11ea-91ca-eeee0a92ba04 -a retry" to retry the process.
Use "cf dmol -i 5ffe98c8-913b-11ea-91ca-eeee0a92ba04" to download the logs of the process.

Space: dev - Applications:

Name
Instances
Disk Quota
Memory

products
1/1
512 MB
512 MB

products_deployer
0/1
1024 MB
256 MB

products_launchpad_deployer
0/1
1024 MB
256 MB

Can you help me plz?

Hi,
I'm sorry to hear this doesn't work for you. It's strange that the dmol log doesn't contain the full error log of the app. I'll follow up on  this separately.
Can you execute cf logs products_launchpad_deployer --recent to see the full error message?

Can you execute cf logs products_launchpad_deployer --recent to see the full error message?

Well, the entire log is a huge file, this is the part of the log that shows error messages, let me know if u need more info:
   2020-05-11T10:34:54.34-0300 [APP/TASK/deploy/0] ERR Deployment of site content to persistency failed [Deployment Id:none] , Error: Deploy to portal service failed, got status = 500, data: Failed to deploy site, instance id: de035cd8-dc6f-4223-b4c3-e022afb64b2e, correlation id: f959e0b7-95b0-4011-7218-cb54608246ab - Error: "Failed to import site, tenantId: 22fb4b67-5b5b-417c-9b35-a7255a391901, instanceId: de035cd8-dc6f-4223-b4c3-e022afb64b2e, appHostIds: {\"appHostIds\":[\"624c3e03-91bf-4619-aa09-f637101a2de7\"],\"boundAppHostIds\":[],\"instanceId\":\"de035cd8-dc6f-4223-b4c3-e022afb64b2e\"}, xsAppNameServicesMap: {\"com.sap.portal.no.business.service\":\"products!t45153\",\"html5-apps-repo-dt\":\"624c3e03-91bf-4619-aa09-f637101a2de7!b45153|html5-apps-repo-uaa!b1685\"}, blueBoxMetadataStr: undefined Error : \"Failed to search all appHostIds, missing apps: products\""
   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR! code ELIFECYCLE
   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR! errno 1
   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR! launchpad-site-content@ start: `node<EMAIL_ADDRESS>   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR! Exit status 1
   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR!
   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR! Failed at the launchpad-site-content@ start script.
   2020-05-11T10:34:54.35-0300 [APP/TASK/deploy/0] ERR npm ERR! This is probably not a problem with npm. There is likely additional logging output
above.
   2020-05-11T10:34:54.46-0300 [APP/TASK/deploy/0] ERR npm ERR! A complete log of this run can be found in:
   2020-05-11T10:34:54.46-0300 [APP/TASK/deploy/0] ERR npm ERR!     /home/vcap/app/.npm/_logs/2020-05-11T13_34_54_357Z-debug.log

Thanks
Ivan

So this is the interesting part "Failed to search all appHostIds, missing apps: products"
It cannot find the app id "products". May I ask which version of easy-ui5 you have installed? I ask because there has been a bug that messed up the app-id in the templates. Please update easy-ui5 in case you use an old version.
For the fix:
Renamed the app id to "tutorial.products" in the portal config (CommonDataModel.json 2x "id" and 1x "appId") and  manifest.json (one occurrence  sap.app -> id )

Please update easy-ui5 in case you use an old version.
How to I check the my version and how do I update?

For the fix:
Renamed the app id to "tutorial.products" in the portal config (CommonDataModel.json 2x "id" and 1x "appId") and manifest.json (one occurrence sap.app -> id )

IT WORKED !!!!!
So, based in your fix what was the problem ? I need to know it badly !!!
This issue consumed an entire week of research and frustration !!!

You can see npm package details on npm.com or via the terminal npm info generator-easy-ui5 and update with another execution of npm install generator-easy-ui5 or npm install generator-easy-ui5@<version>
I'm afraid I don't know the answer to the second question (yet). I wanted to simplify the appId in a previous version of the generated and noticed the day after that this breaks the FLP deployment. I reverted the change immediately when I noticed this (but you were faster and installed that broken generator 🙂) but I didn't have time to follow up on this yet.


Not sure where to create new posts.

Hey man, awesome theme!  I just can't seem to create a new post. I followed the instructions in the read me, but when I got to the :
hugo new "posts/first-post.md"
I was receiving an error on my windows machine.  I think because there's no "posts" directory by default.  So I created one.  That didn't work.  More errors.  So I tried creating the "posts" directory in a new directory called "en."  I played around with the file path for a while, but couldn't seem to create a post.  I tried again from my linux machine and was able to create the post, but the website couldn't seem to find the post I created in the browser.
Not sure if something in the config file needs to be changed?   Any help would be awesome.
Thanks again.

@nnagle123 Re-download the theme file and then follow the readme again, I have fixed this bug caused multilingual support. So far, you can use it without language problem if you use english. For multilingual, I'll write a post about it later.


Have the ability to choose the default duration of an event that does not have an end time

Hi @haydenull
I noticed that if I add an event in my "daily log" without giving it an end time, it appears with 30 minutes of duration by default. It would be very useful to be able to customize this parameter.
[[daily logs]]
 - 15:00-16:00 Test
 - 16:15 Test without end

Good idea, I am planning to add this feature.

1.4.0 already supports custom duration.

Due to no reply for a long time, I will close this issue, please reopen it if there is any problem.


Publish to pub.workiva.org

Summary
We need to publish to our pub server so add
publish_to: key to pubspec.yaml

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.


blackbox tests for support-scheduler issue_141

Including basic tests for the support-scheduler.
This PR includes changes to the docker-compose.yaml which now reference the 1.0.0 version of the

docker-edgex-mongo
docker-edgex-volume

These were required as changes were made to the mongoDB init_mongo.js file.  The docker-edgex-volume was updated to include the new semantic naming "1.0.0" for this upcoming release.
Changes include

New collections
New data
New import and flush scripts
Env changes
deploy changes which include new test areas.

Will address any issue as needed :)
Signed-off-by: xmlviking<EMAIL_ADDRESS>

@cherrycl , could you please help review this PR?  Thanks.

@xmlviking I ran all scheduling testcases and got failed on 6 testcases.
Do you have any support scheduling documents to help me investigate the failed testcases which test script issue or edgex-go issue.

Hey looks like my importer did not get saved properly in the BB tests...I just exported them again.  will check in my changes for this PR :)

Hey looks like my importer did not get saved properly in the BB tests...I just exported them again. will check in my changes for this PR :)

I ran the testcases again using the files you just push, but all of failed testcases still failed.
I found all of post related testcases are failed. Is there any issue for the post interval/intervalAction?

Ok figured out what is going on.  The changes to the underlying support-scheduler mongo DB had an index put in it which does not exist.  So the second time a document was being inserted it was failing for a unique key.  This happened because the document field name did not exist "slug".  I have a PR open to fix that.  As soon as that comes through I will run through these again.

Modified two bash script files added the executable option to them.  New version of docker-edgex-mongo has been updated version 1.0.0 has the correct init_mongo.js file in it now.   Had some issues with existing docker volumes from the black box tests existing on my local system.     All tests ran fine for me.

@cherrycl @cloudxxx8 Do we need to verify this once more before it can be merged?

If not I can merge.  I was giving Cloud and Cherry that option.
On Wed, Feb 20, 2019 at 8:53 PM Trevor Conn<EMAIL_ADDRESS>wrote:

@cherrycl https://github.com/cherrycl @cloudxxx8
https://github.com/cloudxxx8 Do we need to verify this once more before
it can be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/edgexfoundry/blackbox-testing/pull/153#issuecomment-465841601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7vh_5M6y9goXPHNlAxqTomNNIlFaAfks5vPgoUgaJpZM4a__CP
.

@cherrycl @cloudxxx8 Do we need to verify this once more before it can be merged?

@tsconn23  I am verifying.

@xmlviking  I saw the run.sh with supportSchedulerTest didn't contain import script.
Does it is required for Get interval/intervalAction (test 350 and 360)?
I suggest add some verification for response body on above 2 test.

Something happen in the last merge.  I will look into it in the morning.
The run.sh is different now.
The tests need to all be reviewed again.  :(
On Wed, Feb 20, 2019 at 9:23 PM Cherry Wang<EMAIL_ADDRESS>wrote:

@xmlviking https://github.com/xmlviking I saw the run.sh with
supportSchedulerTest didn't contain import script.
Does it is required for Get interval/intervalAction (test 350 and 360)?
I suggest add some verification for response body on above 2 test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/edgexfoundry/blackbox-testing/pull/153#issuecomment-465847098,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7vh1VTCShKysqL09z9v9H3Urg1FKMGks5vPhExgaJpZM4a__CP
.

@cherrycl please help verify again next Monday, thanks

@cherrycl please help verify again next Monday, thanks

@cloudxxx8 I had verified this PR on Friday, and there is no problem for me.