add missing virtual dtors

Fixes clang warnings
/usr/include/c++/v1/memory:3710:5: error: destructor called on non-final 'examples::null_json' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
_data.second().~_Tp();
^
Signed-off-by: Khem Raj<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling f9762fb5b043f72c861121cf032564a3fabda794 on kraj:master into b9070aadd1b7489484b17917f459103bc505c457 on taocpp:master.

I don't understand what Clang is complaining about. The classes are derived from json_base which does have a virtual dtor. So the derived classes do have a virtual dtor as well. There is nothing wrong with the code. I understand that you are not responsible for this warning, but it seems strange. Do you have any explanation for why the "warn" about this?

I don't understand what Clang is complaining about. The classes are derived from json_base which does have a virtual dtor. So the derived classes do have a virtual dtor as well. There is nothing wrong with the code. I understand that you are not responsible for this warning, but it seems strange. Do you have any explanation for why the "warn" about this?

@d-frey it is detecting UB see [1] and [2]
[1] https://wiki.sei.cmu.edu/confluence/display/cplusplus/OOP52-CPP.+Do+not+delete+a+polymorphic+object+without+a+virtual+destructor
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=484780

I understand the general idea, but it simply doesn't apply here! The base class in our example already does have a virtual destructor, see https://github.com/taocpp/PEGTL/blob/b9070aadd1b7489484b17917f459103bc505c457/src/example/pegtl/json_classes.hpp#L33
I also tried to replicate the problem on Godbolt but I could not trigger the warning.
Looking at your patch, clang-tidy even complains that the derived classes' virtual dtor should use override, meaning it does see the base classes virtual dtor!
Finally, I don't see how adding virtual dtors to the derived classes could possibly fix the problem if the base class wouldn't have a virtual dtor. If you would delete an object through a pointer to the base class and the base class wouldn't have a virtual dtor, it doesn't even matter if the derived class has a virtual dtor - it would be ignored anyways.
The only thing that could make sense to me is the permissions. Does changing the base class' dtor from protected to public fix the problem for you (without adding dtors to the derived classes)?

Isn't something backwards? The base class d'tor is protected, so it doesn't need to be virtual because we, i.e. shared_ptr< json_base >, never delete a pointer to the base class. We should remove the virtual, which might have only been added to shut up a warning in GCC that I reported as bug, and that IIRC has been fixed a while ago...

I think clang-tidy will complain if the base class has virtual member functions but a non-virtual dtor.

340110292b35d367205953a59e7eab28e1f4a0bb fixes this as well. I was on 2.1.4 release which did not have this fix. We can close this PR

Ok. Now let's hope that clang-tidy gets fixed soon.

I doubt that clang-tidy will be "fixed" even if someone were to report it, as clang-tidy works in more local contexts than, say, clang-analyze and they will most likely insist on warning about a missing virtual dtor when other virtual functions are present - independent from who derives which classes and how those are handled/deleted. And presonnaly I agree with the general rule, if you have an exception to the rule it usually involves some serious mental gymnastics from the developer and if you really want to avoid the virtual dtor, you can still add // NOLINT to suppress the clang-tidy warning in those (few) exceptional cases.

Detecting that the d'tor is protected should be local enough?

Access, (ie: private, public, protected) doesn't apply in such cases.
If the base class dtor is virtual, then all derived classes dtors are virtual as well, (as has already been stated), regardless of access.
One of the Meyers rules states that if a function is virtual in a base class it should be explicitly marked virtual in all derived classes, (not for the compiler, but for humans).
Similarly, AUTOSAR rule A10-3-1 states: "Virtual function declaration shall contain exactly one of the three specifiers: (1) virtual, (2) override, (3) final."  Additionally, rule A10-3-2 states: "Each overriding virtual function shall be declared with the override or final specifier."
The reasoning here is to 1) Clarify intent, and 2) Avoid redundancy.  Both "override" and "final" are only valid on virtual functions, and only in derived classes.
See also C++ Core Guidelines [11]: C.128 "Virtual functions should specify exactly one of virtual, override, or final."
Thus:
---- cut ----
class Base
{
public:
virtual ~Base();
};
class Derived: public Base
{
public:
~Derived() override;
};
==== end ====
is the preferred style.
Clang-tidy may be using the Meyers guidance, (which predates C++11).

My point with protected is that if a base class' d'tor is protected then you can't "polymorphically" delete an object through a pointer to said base class, and therefore you don't need to make it virtual. Which is why I usually stick to "base class d'tors must be either virtual or protected". It's ok to require override on virtual functions in derived classes, my issue is that the d'tor shouldn't be virtual in the first place when it's protected...

Ok, right.  D'tors are special in this regard.  Your point is valid -- thanks for the clarification. :)


Update useCompiler example.

This example is correctly in docs - https://www.vuemail.net/getting-started/i18n#rendering-template-1. But in IDE the suggestion didn't work. This should sync the docs and in code example.

@v-moravec thanks for your comment, now we are working on improve the library, we're making internal changes to solve internal issues, and typescript for autocompletation is one of that, i'll notice you when new release.

closing this for now, in favor of a huge repo refactor


Replace Ok! and Error! with a green [OK] and a red [KO] respectively.

Replace Ok! and Error! with a green [OK] and a red [KO] respectively, and made them as a prefix instead of postfix for readability, (Tests don't work well, since they expect the previous format).
⚠ Tests need to be modified to match the new messages format: ⚠
Examples

Hello ! we chose to merge this MR  for color, thanks you !


Release 5.0.3

Questions
Answers

Description?
Release 5.0.3

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
~

How to test?
~

Hi @sowbiba !
Release OK :I tested : Create, Edit, Deletion of a bloc, disable/enable, uninstall, install, update, it's all green !
QA :heavy_check_mark:

Thanks @sowbiba & @Robin-Fischer-PS


Allow protocols to be nested in non-generic contexts

I'd like to add more tests. Some guidance would be appreciated.
Does this require swift-evo? I feel that it's an "obvious" feature.

@slavapestov @DougGregor

Pinging @DougGregor @slavapestov @jrose-apple
Is there a reason why we shouldn't allow this?

I'm pretty sure this does need to go through the evolution process, but I'm not a core team member.  But you're not the only person who's asked for it.
PrintAsObjC of nested types is a mess and I don't know what we're going to do about it.

Some test ideas: a protocol inside another protocol (should fail, I think), a protocol in local scope, and a protocol inside a struct in local scope.

@jrose-apple It's the same restriction we had on all nested types prior to Swift 3.1.
The decl/nesting test includes the protocol-inside-protocol. Nothing is allowed to be nested inside a protocol (including other protocols, but also structs/enums/classes). It also has a protocol-in-local-scope test, and I can add one for protocol-in-struct-in-local-scope.
We could relax the restriction on things being nested inside of protocols if the nested types do not capture associated types from their parent, but that just creates yet more complex rules and is probably worth separate consideration. Allowing captures would need significant design work and probably some form of generalised existentials. Consider:
protocol WorkerProtocol {
	associatedtype Result

	enum Status {
 		case notStarted
		case working
		case finished(Result?)
	}
	var status: Status { get }
}

class IntWorker: WorkerProtocol { typealias Result = Int }
class StringWorker: WorkerProtocol { typealias Result = String }

We would need to invent the concept of a (WorkerProtocol where Result == Int).Status, and maybe more advanced cases like (WorkerProtocol where Result: Numeric).Status. We could transform Status in to a generic type (Status<Int>/Status<Numeric>), but we'd need generalised existentials and protocol self-conformance for that (it's basically like Optional<Numeric> or Array<Numeric>).

We could perhaps do some kind of compromise where protocols can be nested inside generic types (and capture them), but cannot themselves be parameterised.

FWIW this is equivalent to protocols with generic parameters (just as expressive and just as hard to implement), so I don't think this is an interesting point in the design space.

This post outlines a reasonable interpretation for nominal types nested in protocols: https://forums.swift.org/t/namespacing-protocols-to-other-types/7328/28
Generalized existentials are not required (but would complement the feature since it's pretty much orthogonal).

Can one of the admins verify this patch?

@karwa Do you have the time to get this through Swift Evolution or should I close this down and convert it to an SR so somebody else can take a look?

@codafi yes, I’d be willing to take this through swift-evo. I’ll write a proposal either today or tomorrow.

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


⚠ Processors has degraded performance

In a66c2ab, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 99 ms

Resolved: Processors performance has improved in 522a6be.


Update sql-server-to-sql-database-overview.md

The login migration as mentioned in this article is supported on SQL MI only. Azure SQL DB migration does not supports any kind of login migration. Confirmed with PG team.

@tasayyed : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Private PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/157415 supersedes, closing PR
#please-close


ETL in dask-SQL

Dask was used as scheduler/compute engine in a number of ETL TOOLS like Airflow, prefect, Dagster, etc. thanks to the  Dask distributed server infrastructure.
Shall we try to make use of this advantage and try to provide a SQL-only ETL experience for the User?
TLDR; shall we integrate dask-sql with ETL Tools? (maybe a  customOperator or Task or Step)
I am thinking of two approaches as follows to implement the same:

Tightly integrate dask-sql within the ETL frameworks, i.e create the dask-sql context in each task/step of the Dag, and pass the context from one task to another task (seems  like a hack, not perfect optimized approach)

start the Dask-SQL server , while starting the ETL, Complete Extract, transform, load, and gracefully tear down the dask-sql server, So we already have functions to create/spin up the uvicorn server thread, (we will pass required dask configurations to that function from the ETL framework) and perform ETL by sending a request to the server (or by using presto client) and we will implement graceful shutdown API in FastAPI app? (is it possible or it will cause any problem : )

This idea was inspired from ETL using dask blog : https://examples.dask.org/applications/prefect-etl.html
Started with a very basic/Rough implementation for approach 1 (using prefect) here: https://github.com/rajagurunath/dask-sql-etl
@nils-braun  what do you think about this proposal? Do you think it will really add value to the user? or any other approach we can follow to achieve the same?
Some known issues so far :
since most of the ETL tools spawn a thread or process to execute a task, internal java virtual machine should spin up each time. currently hacked this problem based on the discussion that happened here: https://github.com/nils-braun/dask-sql/issues/141 ❤ added the following lines and it worked fine :)
        import dask_sql
        from dask_sql import java
        # print where it gets the class from. That should be the DaskSQL.jar
        print(java.org.codehaus.commons.compiler.CompilerFactoryFactory.class_.getProtectionDomain().getCodeSource().getLocation())
        print(java.org.codehaus.commons.compiler.CompilerFactoryFactory.getDefaultCompilerFactory())

Shall we try to make use of this advantage and try to provide a SQL-only ETL experience for the User?

Yes! That would be very cool! Thank you for this idea - I thing it will be a very valuable addon and I can't wait to see it in action!
How to implement this feature is definitely not simple. You had two good ideas, however I fear that they will not work when the number of (workflow engine) workers starts to grow. I have only experience with Airflow, but as you correctly pointed out more workers means more threads (or processes, doesn't matter for my point) and we would need to decide if we open a new connection to the Dask cluster, and how we can re-register the tables and functions at the context (as you also correctly pointed out).
So it is generally a good idea to just have a single context and pass it around. The problem is, how to we pass this context over worker borders? Pickling a context will be hard (so far, it does not work, e.g. also due to the JVM references), but this is the only possibility to send a context between tasks over process or node borders. It would be possible to just send the schema definition (we would need to find a way to also send the defined plugins, that a user can override, but let's do not think about this now), but how can we make sure that the connection to the dask cluster, which all of the dataframes in the schema hold, is the same on all workers? Things like credentials, connections and firewalls will make things hard and as this connection to the dask cluster is pickled "implicitly" I think this will lead to problems that are hard to debug. So you are completely right: this possibility is maybe a bit "hacky".
Possibility two on the other hand, removes many of these issues. All a single task needs to do is open a connection to a database (the task does not even care if it is dask-sql or just normal presto). Basically all workflow engines already know how to do this, so that's cool! There is still one caveat: how do we make sure that the dask-sql server running on the machine which started the DAG is reachable by all worker nodes/processes? There might be complex network setups (I have worked in a particle physics experiment - things get complicated fast ;-)).
So I would propose another solution 2b, which builds on your possibility number 2: let the user start the dask-sql server "externally" (like they would start an Impala server, PostgreSQL database or alike) and just connect to it. In this case, users can decide where to run the dask-sql server by themself (and might know the best place in their network which is reachable by all workers) and they only need to connect to the dask cluster once (from within the dask-sql server). We already have convenience functions to start a dask-sql server (via CLI or python or docker) and we do not need to think about pickling or having multiple contexts or dask connections or the JVM.
What do you think? I think our next step would be to built a small example to try this out. We can re-use most of the code which you have written for prefect. If you want, I can also built one example with Airflow (which I am more familiar with).

Hi @nils-braun,  Thanks for the detailed explanation of the possible solution , completely agreed! ,  As you said we can go ahead with solution 2b , which is straightforward, easy to setup and non-opinated.
Sure so I try to refactor the code base with proposed changes. So once the dask-sql server was up and running, we are going to use presto client for connection or any other plan like just using simple request package ?

Good question! I would think the easiest is sqlalchemy with a presto library/protocol.


Throw error when access into a js project where is no typescript module

I failed to find config to suppress this error.
Is there a way? Or else it would be nice to support to suppress this error, because in most cases we may not install typescript module if not necessary.
I know I can install a typescript globally, but in that way I'm concerned about how can I know which version I'm using in a typescript project? global one or local one?

This is duplicate of #251
And if you have local installation and global installation typescript-tools will choose local one (basically global installation is sort of fallback.


Add Dockerfile, publish to Docker Hub

It would be great to have a docker build, which allows to run Stout easily in a docker enabled CI/CD pipeline, e.g. on GitLab CI.

I created now one. See https://hub.docker.com/r/tmaier/stout/

Thanks @tmaier!


Is there an option to add rounded borders ？

Similar to the following style

Closest I've got to this is setting my Home widget to a ClipRRect and setting a BorderRadius, but this leaves black corners:

I've exagerrated the border radius value here to obetter expose the black background. Does this perhaps require further alteration to the C++ code perhaps? I can't devise a better solution by editing the flutter code itself.

me too!


[Feature]: Update table to table v2 in CRUD generation

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Only update the table widget to table v2 for now in crud page
Why should this be worked on?
People starting from crud pages are running into bugs which we are not fixing because of older versions of tables.
 Front conversations

We have to follow the document here to make the change - https://www.notion.so/appsmith/How-to-update-CRUD-template-09594645bf8e4077b4161c2ec095c27c

@dilippitchika what happened with this issue? It seems there is some conflict with the auto layout that will break all crud apps and templates because they use table v1 and is not compatible. We need to reprioritize this.
cc @keyurparalkar

Internal thread of conclusion


Use xu bUnitID as reported by lsusb

There seems to be two EXTENSION_UNIT on the Rigel. One with bUnitID=4
and one with bUnitID=224.
The bUnitID matching the descriptor with the same guid as LEAP_XU_GUID
is 224.
Looking at where this is used, it looks like only Windows will use the
LEAP_XU_GUID stored in leap_xu_.id, both macOS and Linux use
leap_xu_.unit.
I've not found leap_xu_.node used anywhere.

Great!

Great!


sndio: fix build on darwin

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @chiiruno

I'm not using nix on Darwin, am I even able to test and approve this?

macos 10.13:
builder for '/nix/store/1q8jx8qvhxbnympyzshhbqf3xxd4cncb-python3.7-mpv-0.3.9.drv' failed with exit code 1; last 10 log lines:
  running install tests
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/private/tmp/nix-build-python3.7-mpv-0.3.9.drv-0/source/mpv.py", line 46, in <module>
      backend = CDLL(sofile)
    File "/nix/store/jn8dic1klsd1d550wb682ssnq9wsffg5-python3-3.7.5/lib/python3.7/ctypes/__init__.py", line 364, in __init__
      self._handle = _dlopen(self._name, mode)
  OSError: dlopen(/nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib, 6): Library not loaded: libsndio.7.0.dylib
    Referenced from: /nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib
    Reason: image not found
builder for '/nix/store/3w4q15d3xqfg8rffna1m8wiqdw8lsbk8-python3.8-mpv-0.3.9.drv' failed with exit code 1; last 10 log lines:
  running install tests
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/private/tmp/nix-build-python3.8-mpv-0.3.9.drv-0/source/mpv.py", line 46, in <module>
      backend = CDLL(sofile)
    File "/nix/store/n72fdnrhg2p348z2z2c94ncxx0vm4wdm-python3-3.8.0/lib/python3.8/ctypes/__init__.py", line 369, in __init__
      self._handle = _dlopen(self._name, mode)
  OSError: dlopen(/nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib, 6): Library not loaded: libsndio.7.0.dylib
    Referenced from: /nix/store/yk4m9qgxqx6qy6263fcaazisrdls2ki8-mpv-0.30.0/lib/libmpv.dylib
    Reason: image not found
cannot build derivation '/nix/store/5rs2ac1ak84kpna4fhwivbb27ks4y86m-env.drv': 2 dependencies couldn't be built
[6 built (2 failed), 57 copied (209.0 MiB), 48.5 MiB DL]
error: build of '/nix/store/5rs2ac1ak84kpna4fhwivbb27ks4y86m-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72033
2 package failed to build:
python37Packages.mpv python38Packages.mpv

4 package were build:
curseradio mpc-qt mpv sndio

I'm not using nix on Darwin, am I even able to test and approve this?
sorry about the noise, I think it should not cause any relevant change to the NixOS package


Document FsRtlKernelFsControlFile and others

See ask and details in issue filed by @gabriellandau in MicrosoftDocs/windows-driver-docs#3203

Documented FsRtlKernelFsControlFile and FsRtlQueryInformationFile; asked customer to open new PR for any other missing pages.


Support getting configuration information from Kubernetes.

Kubernetes deployments use configuration maps to store credentials or other configuration information to the nodes. We should allow CloudConfiguration to pull information from that source, if on K8 and available.
@rolivieri

Complete.


psh: runfile: remove early return when vfork() fails

JIRA: PD-213

Description

In psh applet runfile early return was removed, and error handling was centralized at the end of the applet
Motivation and Context

https://github.com/phoenix-rtos/phoenix-rtos-project/issues/248

This PR solves half of the issue mentioned above. It solves the psh hang-up after runfile-ing a directory as this scenario does not give back control over terminal to psh after vfork() error is raised. Proposed changes remove a possibility for early return if vfork() error was raised. Early return here can end in a situation where:

child has taken control over terminal
child failed, thus returns to parent
parent executes return -1 without getting back control over terminal, which here renders previously foreground running psh a background running psh

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

[ ] Already covered by automatic testing.
[ ] New test added: (add PR link here).
[ ] Tested by hand on: (ia32-generic).

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing linter checks and tests passed.
[ ] My changes generate no new compilation warnings for any of the targets.

Special treatment

[ ] This PR needs additional PRs to work (list the PRs, preferably in merge-order).
[ ] I will merge this PR by myself when appropriate.

Went after @agkaminski advice. Reordered if structure so that vfork() error is expected to be handled in else for imho better readibility.

Ready to review. Added error handling that will come from execve() after https://github.com/phoenix-rtos/libphoenix/pull/149


ZEPPELIN-558 ] that is missing on geode travis test.

What is this PR for?
Zeppelin supports geode interpreter.
However, for this test environment it is not reflected in Travis.
I added a geode for travis test environment.
What type of PR is it?
Improvement
Todos

[x] - Add geode build on .travis

Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-558
How should this be tested?
only travis.
and
added geode interpreter for travis.
Screenshots (if appropriate)
no
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Great find!
Can you please post here how this affects the CI build time?
Also, could you explain a bit how is the problem whit bytecode version compatibility resolved? (ZEPPELIN-375 which was the main reason it is hidden under profile)

Great find!
Can you please post here how this affects the CI build time?
Also, what about all other interpreters like Elasticsearch, Lense, etc

@bzz
Thank you for feed back.
I'm sorry, problem with bytecode version compatibility for I did not know.
First, I'll post the build time change.
And we'll check for your feedback.
Thank you!

I think mvn package -Pbuild-distr -Pspark-1.5 -Phadoop-2.3 -Ppyspark -Pscalding -Pgeode -B skip tests because of we defined -Pbuild-distr to do so.
Line 35 will run actual test. If we put -Pgeode in this line, it'll fail while ZEPPELIN-375 is not resolved.
I think this PR make sure geode module is able to build (without test).
it looks good to me.

This is Local build for my machine.
Previous .m2 must build directory has been removed.
Except Geode
mvn package -Pbuild-distr -Pspark-1.5 -Phadoop-2.3 -Ppyspark -Pscalding -B
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [01:00 min]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 16.319 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [ 14.119 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [02:12 min]
[INFO] Zeppelin: Spark .................................... SUCCESS [ 44.425 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [  0.475 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [  0.245 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [  0.205 s]
[INFO] Zeppelin: Hive interpreter ......................... SUCCESS [ 15.394 s]
[INFO] Zeppelin: Apache Phoenix Interpreter ............... SUCCESS [ 29.486 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [  1.057 s]
[INFO] Zeppelin: Tajo interpreter ......................... SUCCESS [  3.388 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [01:03 min]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [  9.179 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [  0.210 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 17.994 s]
[INFO] Zeppelin: Cassandra ................................ SUCCESS [01:11 min]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 18.994 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [ 44.206 s]
[INFO] Zeppelin: Server ................................... SUCCESS [ 26.893 s]
[INFO] Zeppelin: Packaging distribution ................... SUCCESS [ 46.882 s]
[INFO] Zeppelin: Scalding interpreter ..................... SUCCESS [ 27.048 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:46 min
[INFO] Finished at: 2016-01-06T00:58:10-08:00
[INFO] Final Memory: 81M/1144M
[INFO] ------------------------------------------------------------------------
Add Geode
mvn package -Pbuild-distr -Pspark-1.5 -Phadoop-2.3 -Ppyspark -Pscalding -Pgeode -B
[INFO] Zeppelin ........................................... SUCCESS [ 46.638 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 13.173 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [ 14.187 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [02:04 min]
[INFO] Zeppelin: Spark .................................... SUCCESS [ 41.207 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [  0.468 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [  0.183 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [  0.265 s]
[INFO] Zeppelin: Hive interpreter ......................... SUCCESS [ 13.129 s]
[INFO] Zeppelin: Apache Phoenix Interpreter ............... SUCCESS [ 26.696 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [  1.041 s]
[INFO] Zeppelin: Tajo interpreter ......................... SUCCESS [  3.077 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [ 46.497 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [  8.136 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [  0.199 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 10.452 s]
[INFO] Zeppelin: Cassandra ................................ SUCCESS [ 53.405 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 10.892 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [ 41.659 s]
[INFO] Zeppelin: Server ................................... SUCCESS [ 23.084 s]
[INFO] Zeppelin: Packaging distribution ................... SUCCESS [ 51.294 s]
[INFO] Zeppelin: Apache Geode interpreter ................. SUCCESS [ 59.974 s]
[INFO] Zeppelin: Scalding interpreter ..................... SUCCESS [ 20.238 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:11 min
[INFO] Finished at: 2016-01-06T00:30:48-08:00
[INFO] Final Memory: 81M/1037M
[INFO] ------------------------------------------------------------------------
Finding it difficult for meaningful change in the time to build additional Geode.

I'm merging it if there're no more discussions

Geode requires JDK 1.8, thus I think some tests would be failed because Z uses 1.7 when it compiles. And the reason that command doesn't have any error is that command doesn't do any tests. See below,
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ zeppelin-geode ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ zeppelin-geode ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/jl/local/src/g/incubator-zeppelin/geode/src/test/resources
[INFO] Copying 4 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ zeppelin-geode ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.17:test (default-test) @ zeppelin-geode ---
[INFO] Tests are skipped.

Is it intended behaviour?

and maybe rebase to latest? I think to move to the Spark 1.6 line instead?

@jongyoul
The only part of the PR will check only build success.
I've inserted the code for a test build of the geode.

@felixcheung Thank you, but I've created new PR for Spark 1.6
https://github.com/apache/incubator-zeppelin/pull/621

Sorry, everyone.
My mistake as 'rebase' that seems to have caused problems.
So I made a new PR.
I'm sorry to everyone.
In the future, I would like to comment here.
The contents are the same.
Sorry again.
new PR (https://github.com/apache/incubator-zeppelin/pull/621)

@cloverhearts I see. I just wonder what the purpose is.


Parser "shortcuts" made private

Hello!
In 0.8.0 a lot of what I call "parser shortcuts" were made private. For instance Liquex.Parser.Object.arguments. I found it helpful to use these in my custom tags, but now that they are private I can't :)
Should I just copy these small functions out to my own code base so you can keep their API private and have more freedom to change them?
Thanks for any advice -- still love the library <3

I've opened up more of the helper methods in 0.9.0. Check that out and let me know if there are still some missing.

That covered everything I needed at least. Thanks so much!


Win UI Nuget error

Which version of the app?
WinUI 3 Gallery
Description
Hi everyone
I downloaded Microsoft's winui3 package, but when I compile the project, I get the following error.
Cannot resolve metadata for WinUI types. Please ensure that Nuget Restore was successful
Screenshots
No response
Windows version
No response
Additional context
No response

Thanks for filing this @yusuf8421. Were you able to fix it using Nuget Restore?

Yes fixed my project.Was created .net 4.8 framework when I was created new one with .net6 than I did not encounter any errors

Ok great I'm glad to hear that. I'm going to close the issue now. Feel free to create another issue if you encounter any bug.


python312Packages.vulcan-api: 2.3.2 -> 2.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.vulcan-api is: Python library for UONET+ e-register API
meta.homepage for python312Packages.vulcan-api is: https://vulcan-api.readthedocs.io/
meta.changelog for python312Packages.vulcan-api is: https://github.com/kapi2289/vulcan-api/releases/tag/v2.4.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
closes https://github.com/NixOS/nixpkgs/pull/303966
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.0 with grep in /nix/store/c2m1y34dixnxqfawpyya1sx9rqlj7pf6-python3.12-vulcan-api-2.4.0
found 2.4.0 in filename of file in /nix/store/c2m1y34dixnxqfawpyya1sx9rqlj7pf6-python3.12-vulcan-api-2.4.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.vulcan
python311Packages.vulcan-api
python312Packages.vulcan-api

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c2m1y34dixnxqfawpyya1sx9rqlj7pf6-python3.12-vulcan-api-2.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.vulcan-api https://github.com/r-ryantm/nixpkgs/archive/2877de9c38fb87655959ff604bb8751734ebbccf.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2877de9c38fb87655959ff604bb8751734ebbccf#python312Packages.vulcan-api

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c2m1y34dixnxqfawpyya1sx9rqlj7pf6-python3.12-vulcan-api-2.4.0
ls -la /nix/store/c2m1y34dixnxqfawpyya1sx9rqlj7pf6-python3.12-vulcan-api-2.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.vulcan

4 packages built:

python311Packages.vulcan-api
python311Packages.vulcan-api.dist
python312Packages.vulcan-api
python312Packages.vulcan-api.dist

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 302863 at 2877de9c run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.vulcan

2 packages built successfully:

python311Packages.vulcan-api
python312Packages.vulcan-api

included in https://github.com/NixOS/nixpkgs/pull/345326


Disable test_regexp_replace_null_pattern_fallback on Databricks [databricks]

Signed-off-by: Andy Grove<EMAIL_ADDRESS>Closes https://github.com/NVIDIA/spark-rapids/issues/4243

if we are disabling this is it tracked by another issue to turn it back on?

oh never mind, after looking at code looks like you are saying databricks optimizes that out, perhaps update description to say the same

build

build


colnames/rownames of counts

If not set, then will cause errors in down-stream functions

just curious, should it be able to handle duplicated row names?


WEBGL_depth_texture support would be nice

The WebGL Extension for depth textures is not enabled :(
It can be testet using the following test:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-depth-texture.html?webglVersion=1
It results in something like this:
This test verifies the functionality of the WEBGL_depth_texture extension, if it is available.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS WebGL context exists
Testing binding enum with extension disabled
PASS getError was expected value: INVALID_ENUM : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_ENUM : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS No WEBGL_depth_texture support -- this is legal
PASS WEBGL_depth_texture not listed as supported and getExtension failed -- this is legal

PASS successfullyParsed is true

TEST COMPLETE

It would be very nice if we could have something more like the result of chrome, that is
This test verifies the functionality of the WEBGL_depth_texture extension, if it is available.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS WebGL context exists
Testing binding enum with extension disabled
PASS getError was expected value: INVALID_ENUM : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_ENUM : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS Successfully enabled WEBGL_depth_texture extension
PASS WEBGL_depth_texture listed as supported and getExtension succeeded
Testing WEBGL_depth_texture

testing: UNSIGNED_SHORT
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, new Uint16Array(1))
PASS getError was one of: INVALID_VALUE or INVALID_ENUM or INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, canvas2)
PASS getError was one of: INVALID_ENUM or INVALID_OPERATION : after evaluating: gl.copyTexImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 0, 0, 1, 1, 0)
PASS getError was expected value: NO_ERROR : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 8, 8, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, 1, 1, gl.DEPTH_COMPONENT, gl.UNSIGNED_SHORT, new Uint16Array(1))
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.copyTexSubImage2D(gl.TEXTURE_2D, 0, 0, 0, 0, 0, 1, 1)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.generateMipmap(gl.TEXTURE_2D)
PASS gl.getParameter(gl.DEPTH_BITS) is >= 16
PASS gl.getParameter(gl.STENCIL_BITS) is 0
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS depth texture rendered correctly.
PASS getError was expected value: NO_ERROR : after evaluating: gl.framebufferTexture2D(gl.FRAMEBUFFER, gl.DEPTH_STENCIL_ATTACHMENT, gl.TEXTURE_2D, tex, 0)
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is not gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: INVALID_FRAMEBUFFER_OPERATION : after evaluating: gl.clear(gl.DEPTH_BUFFER_BIT)
PASS gl.getError() is gl.NO_ERROR

testing: UNSIGNED_INT
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_NEGATIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_NEGATIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_NEGATIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_NEGATIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_NEGATIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_NEGATIVE_X, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 1, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 1, 1, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, new Uint32Array(1))
PASS getError was one of: INVALID_VALUE or INVALID_ENUM or INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, canvas2)
PASS getError was one of: INVALID_ENUM or INVALID_OPERATION : after evaluating: gl.copyTexImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 0, 0, 1, 1, 0)
PASS getError was expected value: NO_ERROR : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_COMPONENT, 8, 8, 0, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, 1, 1, gl.DEPTH_COMPONENT, gl.UNSIGNED_INT, new Uint32Array(1))
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.copyTexSubImage2D(gl.TEXTURE_2D, 0, 0, 0, 0, 0, 1, 1)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.generateMipmap(gl.TEXTURE_2D)
PASS gl.getParameter(gl.DEPTH_BITS) is >= 16
PASS gl.getParameter(gl.STENCIL_BITS) is 0
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS depth texture rendered correctly.
PASS getError was expected value: NO_ERROR : after evaluating: gl.framebufferTexture2D(gl.FRAMEBUFFER, gl.DEPTH_STENCIL_ATTACHMENT, gl.TEXTURE_2D, tex, 0)
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is not gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: INVALID_FRAMEBUFFER_OPERATION : after evaluating: gl.clear(gl.DEPTH_BUFFER_BIT)
PASS gl.getError() is gl.NO_ERROR

testing: UNSIGNED_INT_24_8_WEBGL
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_Y, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_Y, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_Y, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_Y, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_Y, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_Y, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 1, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_STENCIL, 1, 1, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, new Uint32Array(1))
PASS getError was one of: INVALID_VALUE or INVALID_ENUM or INVALID_OPERATION : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_STENCIL, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, canvas2)
PASS getError was one of: INVALID_ENUM or INVALID_OPERATION : after evaluating: gl.copyTexImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_STENCIL, 0, 0, 1, 1, 0)
PASS getError was expected value: NO_ERROR : after evaluating: gl.texImage2D(gl.TEXTURE_2D, 0, gl.DEPTH_STENCIL, 8, 8, 0, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, null)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, 1, 1, gl.DEPTH_STENCIL, ext.UNSIGNED_INT_24_8_WEBGL, new Uint32Array(1))
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.copyTexSubImage2D(gl.TEXTURE_2D, 0, 0, 0, 0, 0, 1, 1)
PASS getError was expected value: INVALID_OPERATION : after evaluating: gl.generateMipmap(gl.TEXTURE_2D)
PASS gl.getParameter(gl.DEPTH_BITS) is >= 24
PASS gl.getParameter(gl.STENCIL_BITS) is >= 8
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
PASS depth texture rendered correctly.
PASS getError was expected value: NO_ERROR : after evaluating: gl.framebufferTexture2D(gl.FRAMEBUFFER, gl.DEPTH_ATTACHMENT, gl.TEXTURE_2D, tex, 0)
PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is not gl.FRAMEBUFFER_COMPLETE
PASS getError was expected value: INVALID_FRAMEBUFFER_OPERATION : after evaluating: gl.clear(gl.DEPTH_BUFFER_BIT)
PASS gl.getError() is gl.NO_ERROR

PASS successfullyParsed is true

TEST COMPLETE

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

will look to fix this.


when handling single-line statements, the indent guide line extends slightly beyond its scope.

First of all, I want to express my sincere gratitude for this fantastic plugin. After comparing it with other options, I still find this one renders the fastest, with no perceivable delay to the human eye. I’m genuinely appreciative of this wonderful community.
As the title suggests, there seems to be a small issue here, as shown in the image below.

I understand that this plugin was likely developed with simplicity and speed in mind. Therefore, I suspect this might not be a bug but rather an intentional choice (apologies if I’m mistaken—please feel free to correct me!). Regardless, "rendering speed" is my top priority, so even if this isn't an issue to be fixed, I'm more than happy to continue using it!
Best wishes!

Yes, this is the result of special processing. Currently, the space is tightened to the maximum above and below to avoid gaps. Behavior like C/C++ supports single lines without {} may look strange. Currently, it is based on a sloppy space judgment. Due to the difference in ast, it may be better to use treesitter. But people usually disable this highlighting system in large files. So the context search judgment is used here....some specific file types may need to be determined by syntax rules. In this way, we can continue to maintain without the help of any tools


Can't create api controller method

If I create a controller method called api, it does not have access to the this keyword.

You said on gitter it's for v3, this trailpack is not compatible with trails V3 for now

Yes, I know it's not ready. It's still a bug.

I would love to help get this ready.


Couple ideas for cual-id after using it for 2 large projects

My lab has been using the cual-id system for our barcodes for 2 large projects. It has worked great for us. Having made over 800 barcodes and working with them on a daily basis, we have noticed 2 things that we think could be improved, as a suggestion.

When there's an "e" as the second to last character in the barcode, excel recognizes it as an exponential number and you have to manually change the format of the cell so that it displays correctly.
With many students working on this project, and people having different handwriting styles, we've noticed some mix ups between a "6" and a "b".
Just thought I would tell you about these after working with so many of your barcodes. :-) Hope it helps a bit.

I think cual-id itself addresses 2 by nature (did you have any issues correcting after the typo/misidentification was made?)
As for 1, what if cual-id just had a prefix (like z or maybe U for UUID?) This might address #42 as well. I don't remember if we'd already ruled out that option, but it seems easy to work around/with.

Thanks for getting back to me so quickly. Yes, we have always been able to track down any mix ups between "b" and "6" and have tried to be more careful now that we know it's an issue.
As for 1, it's not a huge deal just to modify the cell but I thought I would point out it's something we've noticed. Thanks again.

@jcocking Thank you for feedback! @shiffer1 has run into similar issues and posted an issue about it here #42. You can see some of the thoughts regarding the issue, my conclusion in the past is that I would like to make cual-id more spreadsheet friendly though I don't know how to do this in a way that won't cause other issues.

Another similar issue that I've been running into is cual-ids that are composed of all integers - this can cause some annoying formatting, and I have seen .0 appended to them in spreadsheets (i.e., it gets treated as a floating point number).
I like the prefix idea as it would address all of these. A default that could be overridden on the command line should let us handle different cases.
I also remember talking about prefixes at some point, and also don't remember if we ruled it out for any reason. Given that, I think we can just try it out and see if it comes up again, whenever we get around to working on cual-id again. (For what it's worth, I still use cual-id regularly, and the NMDC is now recommending universally unique sample identifiers.)

These ideas came up again in a conversation. It might reduce some of the transcription errors if we outputted the UUIDs/cual-ids in uppercase rather than lowercase.


Generate EKS-Go 1.18.10 patches

Issue #1020 , if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@danbudris please review the new changes

/approve

closes #1019 , #1018 , #1017, #1016


Websocket errors when setting too many users

Hello,
I have been using Meteor Down to load test a Meteor application for my company, but I have found that when I exceed 6000 concurrent users or so, Meteor Down begins throwing websocket errors. I Googled these errors and I have only found that these occur because Meteor Down is trying to use ports that are already in use. I am not sure if this is a Meteor Down issue, but I was hoping to find out if there is a workaround/fix for this.
Any help is appreciated.

+1

+1

Yes this is an issue.
This is purely due to how node-ddp-client works.
If we've more ddp-websocket connection, node process can't work well.
So, best way is to use multiple process to distribute the load. At kadira, we use heroku to initiate a very large load test. In our experience we use 100-200 clients per process. But that also depends on the data you subscribe and other factors.

@arunoda that totally makes sense, thanks for the clarification.

@arunoda could you clarify what fails when concurrency is too high?
I tried using multiple processes of the my_load_test.js example from the README, but at some point they start dying, returning an exit code of 8 and printing the same message @LukeStanbery89 took a screenshot of:
/tmp/stress/client/node_modules/meteor-down/lib/mdown.js:47
    if(error) throw error;
                    ^
Network error: ws://localhost:3000/websocket: connect EADDRNOTAVAIL

Do you think the OS is running out of client-side sockets? When you do a large load test, do you use a different machine for each meteor-down process?

This may be due to that, you are destroying and connecting a lot of clients in the short time.
We normally run only 10-30 concurrency.
And we use multiple instances like that to scale.


Are the prerequisites really necessary?

Are the prerequisites (https://github.com/sandeepmistry/noble#windows) really necessary?
I started with Noble a few weeks ago. I installed every prerequisite on my Windows 8.1 computer (PC1).
I am implementing a tracking system application which is based on the example "enter-exit.js".
There are about 20 other PCs I want to install my application to.
First I assumed that I have to do the whole prerequisites-procedure on all the PCs!!
That would be terrible!!
But today I installed on one of the PCs (PC2) only the following tools, and I could run my application:

Zadig tool for WinUSB driver (Dongle CSR8510A10 is plugged in)
Node.js
Last, I copied the "node-modules" folder (which was created on PC1) to PC2.

That was sufficient! My application runs on PC2 as on PC1 although the following tools aren't installed on PC2:

Python 2.7
MS VS 2013 Express (or any other VS)
I didn't run any command such as (npm install node-gyp, npm install bluetooth-hci-scoket)

I didn't spend so much time with the noble project, therefore I don't know how it works exactly?
My Questions:

Are Node.js, Zadig and the "node-modules" folder sufficient to run any application which is based on noble?
Why exactly are Python and the C++ compiler in VS2013 needed for?
Do I really need the installation of node-gyp and bluetooth-hci-socket?

I think those tools are needed to build noble on windows (ie, to run npm install) only. After you build it, you can use the built files (ie, node_modules/noble) on similar platforms.
Also Python is required for node to be installed, and the C++ compiler is probably used to build the native modules.

Hi taktran,
I could imagine the following:
The JavaScript codes will be interpreted by Node.js everytime I run my application, so there are no compiled/built files (at least for JavaScript and Python). But there should be compiled/built files for C++.
Maybe, the first time, I installed the prerequisites on PC1, all the C++ files had been built and generated! Therefore I could easily copy&paste the "node-modules" folder to PC2 and run my app?

@boredSinan

Are Node.js, Zadig and the "node-modules" folder sufficient to run any application which is based on noble?

Yes, as long as the same version of Node.js is being used, as well as same CPU arch (32-bit vs 64-bit).

Why exactly are Python and the C++ compiler in VS2013 needed for?

See @taktran's answer, and node-gyp project.

Do I really need the installation of node-gyp and bluetooth-chi-socket?

bluetooth-hci-socket could be split up into 2 separate modules: bluetooth-hci-socket-linux and bluetooth-hci-socket-usb .bluetooth-chi-socket-usb would depend on node-usb.
Another option is to use node-pre-gyp and have the Node.js native module pre-built for certain platforms. However, then you have to decide on the version of Node.js you want to pre-build for, 32-bit vs 64-bit, etc (a big compatibility matrix).

@boredSinan can we close this or are there follow on action items?


Obsoletion request: GO:0030374 nuclear receptor coactivator activity and replace by GO:0003714 transcription corepressor activity

Dear all,
The proposal has been made to obsolete
GO:0030374 nuclear receptor coactivator activity and GO:0140536 nuclear receptor corepressor activity and replace by their respective parents, [GO:0003713 transcription coactivator activity] and GO:0003714 transcription corepressor activity.
The reason for obsoletion is that these activities are not necessarily specific for nuclear receptors subclass of dbTFs, so that distinction leads to misannotations.
All impacted groups annotations will be automatically re-annotated, see annotation ticket: https://github.com/geneontology/go-annotation/issues/5502
InterPro and UniRule/HAMAP annotations need to be moved up to the parent.
Thanks, Pascale
@colinlog

Removed part of the comment of nuclear receptor activity, as pointed out by @slaulederkind here: https://github.com/geneontology/go-annotation/issues/5502#issuecomment-2465230146

When the nuclear receptor functions by binding to other transcription factors or transcription factor complexes, consider instead annotating to 'GO:0030374 ; nuclear receptor transcription coactivator activity' or GO:0140536 ; nuclear corepressor activity.

Fixed textual definitions and logical definitions for nuclear receptors:
Textual definitions: "A nuclear receptor activity regulated by xx binding and modulating the transcription of specific gene sets transcribed by RNA polymerase II.
Logical definitions:
+intersection_of: GO:0004879 ! nuclear receptor activity
+intersection_of: RO:0012000 CHEBI:35341 ! has small molecule regulator (small molecule)


Add BlockHeader::u256_from_compact_target function

This implements the counterparty to BlockHeader::compact_target_from_u256, to convert a compact u32 to a Uint256.
This is needed for difficulty calculations, eg. when handling pow_limit (a Uint256) from consensus::params.

The CI build seems to be failing on Rust 1.22 for some external reason :confused:

Rebased on master, with 1.22 compat, tests pass now :+1:


Module Support

It'd be good to have support for Java 9+ modularity (via module-info.java) so people don't need to resort to things like the extra-java-module-info gradle plugin.

So far I never used the Java module stuff... Is there an easy way to add the module-info.java while maintaining Java 8 compatibility?

You could create a multi-release jar (this is also what LWJGL does), which in short means the module-info.class file would reside in META-INF/versions/9 inside the built jar (along with setting Multi-Release: true in MANIFEST.MF).

I just published version 1.1.0 which is a multi-release jar and contains a module-info


dishwasher relaxant / salt low level warning ?

From time to time I receive a notification ony my siemens home connect app telling me that salt and/or relaxant levels on my dishwasher are low thus need refilling.
it would be great id these could be exposed as a binary sensor in home assistant.
is this part of the home connect api ?

Duplicate of #53

duplicate of #115


MacOS client sending out random video call requests

We setup a private channel for a client for communication.  She has latest version of rocket chat client and MacOSX as of the time of this writing. The RC client was loaded in from the desktop version of the AppStore.
When the user is away from her computer and the computer is in Sleep mode, her channel sends out random video conference requests.
I've had her uninstall and reinstall the RC Client, but it still happens. This is only happening in one channel (her channel). Any thoughts as to what could be causing this?

Don't know if this is the situation in your case but we observed the same behaviour, if the video call is in a separate window and it has been left open in the background. Jitsi seems to reestablish the session after mac wakeup, which informs RC about the video call and reissues the "Click to Join" message.

We're seeing this with the client (version 2.15.1, I believe) on Linux with R.C  server 1.0.1 - it seems to initiate 2 or 3 "Click to join" messages in quick succession, every hour or so...


[bdwgc] Installing pkg-config files for debug builds

Describe the pull request

What does your PR fix?

This PR fixes incorrect library output for debug builds, resulting in missing .pc files

Which triplets are supported/not supported?

Yes

Thanks!


fix(coral): Use correct environments GET endpoints, rename domain fn to be more explicit

About this change - What it does
The endpoints we were using to get environments were in various state of incorrect.

When we create a request for Schema, Topic or Connector, we want to use the specific endpoints which return the environments allowed by the Klaw admin (so as to enforce the use of promotion of each entity, instead of directly creating the request in a "higher" env). We were sometimes getting all environments.
When we create an ACL, because there is no promotion for this entity, we should get all environments.
When we browse entities (ACL, Topics, Schema, Connectors), the environment restriction does not apply, and we should get all environments. The EnvironmentFilter was getting a variety of endpoints as a prop, when it should get all environments, all the time.

This PR:

rename the function used to fetch environments with explicit, declarative names:

getAllEnvironments
getEnvironmentsForTopicRequest
getEnvironmentsForSchemaRequest
getEnvironmentsForConnectorRequest

fix EnvironmentFilter to always use getAllEnvironments
renames the getRequestForSchemas Java controller function to be getEnvsForSchemaRequests

Resolves: #505

@roope-kar that might have been the staging server which may have been down for connectors, I see the env correctly now. Is it still failing for you in some way? (you can see me giving up on writing a connector config in real time but the envs seem to be there hahaha)
https://user-images.githubusercontent.com/20607294/236821478-74737b02-70d9-4a09-b87a-d6d01fccf5a4.mov

@mathieu-anderson Hmm, the env filter still does not work for me in the listing view.
I just checked and it works in main.
There are also more options rendered in this pr that there are in main for the env filter, so it looks like the wrong env resources are getting listed there.
Screencast from 2023-05-09 08-19-06.webm

Requesting a new connector, as you mentioned, looks to work as expected 👍🏼

@roope-kar Aaah I see. Well then, asssumptions were wrong, we can't use getEnvs for the browse views :/ I wanted to believe.


Flash Swap and Cross-Pool Swap

Flash Swap

traders can borrow, swap and pay back in one transaction
to stimulate arbitrage activities without capital for more efficient price discovery

Cross-Pool Swap

traders can swap tokens via multiple liquidity pools in one transaction
do they need to pay entire swap fee?
can we discount the swap fee so that we can promote more arbitrage activities?

Cross Token Pools

ATOM/KAVA is not a favorite pool to trade in than ATOM/USDT or KAVA/USDT
but this pool is very essential for Flash Swap Arbitrages to have the complete triangular cycle of swaps

for example, USDT -> ATOM -> KAVA -> USDT

how can we promote flash swap arbitrage without this kind of bridge pools?

redundant topic


Cursor bugs on windows

I've recently updated from LCUI beta 2 to beta 3. (VS 2017):

Looks like LCUI is attaching picture to the cursor in LCUI_InitCursor():
void LCUI_InitCursor(void)
{
	LCUI_Graph pic;
	Graph_Init(&pic);
	Graph_Init(&cursor.graph);
	/* 载入自带的游标的图形数据 */
	LCUICursor_LoadDefualtGraph(&pic);
	cursor.new_pos.x = LCUIDisplay_GetWidth() / 2;
	cursor.new_pos.y = LCUIDisplay_GetHeight() / 2;
	LCUI_BindEvent(LCUI_MOUSEMOVE, OnMouseMoveEvent, NULL, NULL);
	LCUICursor_SetGraph(&pic);
	LCUICursor_Show();
	Graph_Free(&pic);
}

I don't know much about linux desktop programming, but in winapi you can change cursor with SetCursor function.
Another one i discovered:

Move the cursor inside app area
Push left mouse button and drag cursor to the border:

Version: 1.0.0 Beta 3 and newer
OS: Win10
Tools: VS 2017 Community

I found this problem before and made some changes：https://github.com/lc-soft/LCUI/commit/acf9454463ca828c7c245170cf594e08d77d74a1

Thanks for your answer, gonna update to develop I think.


Use second argument to string.split() to speed up getRole.

.split('_', 1) will build an array with at least 1 fewer elements, providing an exponential speed increase to all screeps operations!
What better for a first contribution than premature optimization?

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

5
0
0
5

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

daboross
✔

PostCrafter
✔

ags131
✔

semperrabbit
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


I have error in new update 3.0.0

Prerequisite Checklist

[X] I searched for existing issues to prevent duplicates
[X] I searched for existing discussions on the forum to prevent duplicates
[X] I am here to report an issue and not to just ask a question or look for help (use the forum or Discord instead)

Describe your issue here
I have mingw64 version 14.2.0 . I update SFML today from 2.6.2 to 3.0.0 and I find error when I run a program I execute by this code g++ main.cpp -o main.exe -lsfml-audio -lsfml-system no error happened when execute the file I doing sound program the error is "main.exe - Entry Point Not Found The procedure entry point
_ZNKSt25_codecvt_utf8_utf16_baselwE10do_unshiftER9_MbstatetPcS
3_RS3_could not be located in the dynamic link library
C:\msys64\mingw64\bin\sfml-system-3.dll.
" and "main.exe - Entry Point Not Found
The procedure entry point
_ZNKSt25_codecvt_utf8_utf16_baselwE10do_unshiftER9_MbstatetPcS
3_RS3_could not be located in the dynamic link library
C:\msys64\mingw64\bin\sfml-audio-3.dll." . I try back to the last version and the program run successfuly the error exist only in new version
Your Environment
Windows
3.0.0
Compiler
mingw64 14.2.0
Steps to reproduce

#include <SFML/Graphics.hpp>

int main()
{
    sf::RenderWindow window(sf::VideoMode({1280, 720}), "Minimal, complete and verifiable example");
    window.setFramerateLimit(60);

    while (window.isOpen())
    {
        while (const std::optional event = window.pollEvent())
        {
            if (event->is<sf::Event::Closed>())
                window.close();
        }

        window.clear();
        window.display();
    }
}

Expected behavior
the program running successfully.
Actual behavior
"main.exe - Entry Point Not Found The procedure entry point
_ZNKSt25_codecvt_utf8_utf16_baselwE10do_unshiftER9_MbstatetPcS
3_RS3_could not be located in the dynamic link library
C:\msys64\mingw64\bin\sfml-system-3.dll." "main.exe - Entry Point Not Found
The procedure entry point
_ZNKSt25_codecvt_utf8_utf16_baselwE10do_unshiftER9_MbstatetPcS
3_RS3_could not be located in the dynamic link library
C:\msys64\mingw64\bin\sfml-audio-3.dll."

Are you using the compiler that's linked on the download page?

Are you using the compiler that's linked on the download page?

yes occur error and is not compile

Are you using the compiler that's linked on the download page?

It worked after delete folder msys64

Are you using the compiler that's linked on the download page?

It worked after delete folder msys64

Closing this issue since it sounds like you resolved your own error.


feat(TCOMP-547):update rest start script to use the PAX_MVN_REPO env var

What is the current behavior? (You can also link to an open issue here)
Web Service cannot be customized to get components from remote repo (nor the docker image)
What is the new behavior?
Service and docker image accepts a new environment variable PAX_MVN_REPO to configure repo repo used to look for components and dependencies.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:


Add support for passing WebDriver arguments to Pyppeteer

Goal
Add support for passing arguments to the Pypputeer launcher so that each page that is rendered, either async or not, will use the arguments passed in by pyppeteer.launch().
Use
browser_args=['--disable-dev-shm-usage',
              '--headless',
              '--no-sandbox',
              '--log-level=3',
              '--disable-sync',
              '--disable-translate',
              '--metrics-recording-only',
              '--enable-automation',
              '--password-store=basic',
              '--use-mock-keychain']
session = AsyncHTMLSession(browser_args=browser_args, pyppeteer_args={'ignoreDefaultArgs':True})

Issues
This exposes the fact that the current Pypputeer version that is used doesn't actually take in the arguments that BaseSession tries to take Can be resolved by changing Pyppeteer to latest Git version.

Seems to be a better solution to Pull Request #270.

As per reference this has already be proposed on #270, so I will be closing here and check for update on #270, since he was the one to create this first.


GPU e2e: extend test cases to cover more functionality

Currently we have only basic test cases for the GPU plugin. Let's extend them to cover more plugin functionality.

done as part of #1374


fix: add missing overload for addChunkInGroup

What kind of change does this PR introduce?
Add a missing overload signature for addChunkInGroup's typescript declaration.
Did you add tests for your changes?
N/A (unless the definitions are tested somewhere)
Does this PR introduce a breaking change?
N/A
What needs to be documented once your changes are merged?

This is basically a documentation fix.

Please add types using ts jsdocs, don't modify them directly

I dont think typescript has any way of understanding class method overloads with jsdoc (it's kinda janky anyways), so i just made the arguments optional and left documentation. (I took a look through the typedef generation code to see that you're fetching the jsdoc using typescript itself. I also determined that adding some kind of hack to make it work seems unreasonable)

Thanks


Make compilation 2x faster by using literals

Description
I replaced Character(Unicode.Scalar(...)!) by "\u{...}". This makes compilation almost 2x faster.
Here is the benchmark:

branch
command
1st execution time
2nd execution time
3rd execution time
average

master
swift build
4.37s
3.65s
3.52s
3.85s

replace-by-literal
swift build
2.11s
2.17s
2.11s
2.13s

master
swift build -c release
9.81s
9.37s
9.67s
9.62s

replace-by-literal
swift build -c release
5.04s
5.11s
5.02s
5.06s

(Mac mini (M1, 2020) 8GB RAM, macOS 12.3, Xcode 13.3, Swift 5.6)
Motivation and Context

My changes can reduce compile time without changing any functionality.
Not only that, these can also resolve issues like https://github.com/kkk669/DevToys.swiftpm/pull/6#issuecomment-1069332639.
How Has This Been Tested?

Checklist:

[x] I have submitted a CLA form
[x] If applicable, I have updated the documentation accordingly.
[x] If applicable, I have added tests to cover my changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks like a complete revert of #51 minus changes in two lines of comments.
LGTM since I originally wrote this using literals, but according to the thread in #51 the bug in Swift wasn't fixed until 5.1 so this change will break for users on 5.0.
I don't work on this project any more so I'll defer to @dannys42 to decide if 5.0 support is still needed.

Thanks @kkk669 for the submission and @youming-lin for the context.  I've been slowly phasing out Swift 5.0 and 5.1 from the various Kitura projects.  My typical approach has been to bump the major version of the project while simultaneously dropping support for older versions of Swift and updating the CI build.  So let me take a stab at that then revisit this.
I'll try to address this as soon as I can.  But I apologize right now if I don't get to this soon, I'm a bit overloaded right now.  Feel free to ping a reminder to me if I'm taking too long.

@youming-lin Thank you for sharing the related issue. I also replaced Character(Scalar(...)!) in the comments. 6d490b02c2b376d95e23b00fa4ce754532046980
@dannys42 Thank you for sharing the future plan. I'm going to wait until then.

@kkk669 I see one difference on line 457 from your changes vs @youming-lin's on the last character of the line.  Can you confirm what the correct value should be?
825c825
< +    "nless;":"\u{226E}","nLl;":"\u{22D8}\u{338}","nlsim;":"\u{2274}","nLt;":"\u{226A}\u{20D2}",
---
> +    "nless;":"\u{226E}","nLl;":"\u{22D8}\u{338}","nlsim;":"\u{2274}","nLt;":"\u{226A}\u{338}",

Also, please rebase if you can.

@dannys42
I rebased now.

@kkk669 I see one difference on line 457 from your changes vs @youming-lin's on the last character of the line. Can you confirm what the correct value should be?

It seems that the value of nLt; has been changed from \u{226A}\u{20D2} to \u{226A}\u{338} in #51. Is this a mistake of #51? And also, the key nLt; looks duplicated.

I think the values should be left as they are even if it is an incorrect value. By doing so, this PR becomes a simple conversion-only difference.
If \u{338} is incorrect, we should correct it in another PR.

I originally generated the maps from a JSON file I found that maps the named character references to unicodes, e.g. https://html.spec.whatwg.org/entities.json
I would doublecheck the spec to make sure the unicodes are correct.

@youming-lin Thank you for sharing the specs. I checked that and I confirmed that #51's change was incorrect. However, I haven't made any changes to that part in this PR, so if I fix it here, I think it would be out of line with the purpose of this PR.

@kkk669 Sounds good.  That's for your PR and all the research!

@kkk669 I pushed your changes and made a release for 4.0.1.  I also added an issue to track the unicode bug.  Please feel free to add any context you think is necessary for that issue.  Or submit a new PR if you're inclined. :-)
There's an issue with cocoapods so I can't push an updated pod right now.  I'll try again later.

Thank you so much! I will send a PR for #67 when I have time.


Update scripts.js

Closes #
📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

☢ Does this introduce a breaking change?

[ ] Yes
[x] No

ℹ Additional Information

Summary by CodeRabbit

New Features

Enhanced API calls to include additional parameters for workflow limiter state, improving data context from the webhooks endpoint.

@gstraccini codacy bypass

@gstraccini codacy bypass


Incorrect number of busy jobs in web extensions

Hi,
when I'm on the sidekiq dashboard, it shows 0 busy jobs:

However, when I view the sidetiq jobs, it shows 9 busy jobs (incidentally the number of sidetiq workers):

I guess this is just displayed wrong?
I'm using sidekiq 3.2.4 and sidetiq 0.6.3
All the best,
Fabian

Same issue, also for some reason I have a big delay when Busy is 0, and then it starts to process Enqueued jobs.


How to properly implement idle thread for resources cleanup?

In the context of multiple network communication, several threads must be started and stopped, often same thread function is used with multiple instances in parallel.
Then dynamic allocation of thread handle and respective stack is a must, but not really supported by ThreadX.
There is thread entry/exit notification capability, however it cannot be used to cleanup thread stack pointer and thread instance as instance is used immediately, just after exit-callback function returns to the caller.
FreeRTOS has this solved more than just well, indeed it requires more memory resources. it implements idle thread, in charge of resource cleanup process for dynamically allocated threads.
I did a prototype of my implementation and would like to get a feedback from Microsoft, if this is the right usage, namely:
Code concept as below. Prototype seems to work properly.
/* Main application byte pool */
#define TX_APP_MEM_POOL_SIZE                     (1024 * 32)
static UCHAR tx_byte_pool_buffer[TX_APP_MEM_POOL_SIZE];
static TX_BYTE_POOL tx_app_byte_pool = {0};

/* Idle thread uses pre-defined handle structure and statically defined stack memory */
static TX_THREAD idle_thread_handle;
static uint8_t idle_thread_stack[512];
static void idle_thread_func(ULONG param);

/* Thread app entry function */
static void app_thread_func(ULONG param);

/**
 * \brief           Idle thread function entry
 * \param[in]       param: User argument, don't care
 */
static void
idle_thread_func(ULONG param) {
    TX_INTERRUPT_SAVE_AREA
    TX_THREAD* t;

    while (1) {

        /* Process interrupts and check if anything to do */
        TX_DISABLE

        /*
         * Check a linked list of all created threads in the system.
         * Process threads in terminated or completed state.
         *
         * These threads use dynamic memory allocation,
         * hence it is now good time to clean them up
         */
beg:
        t = _tx_thread_created_ptr;
        while (t != NULL) {
            if (t->tx_thread_id != TX_THREAD_ID) {
                break;
            }
            if (t->tx_thread_state == TX_TERMINATED
                    || t->tx_thread_state == TX_COMPLETED) {
                TX_RESTORE

                /* Do we need a call to delete? */
                tx_thread_delete(t);

                /* Cleanup resources */
                /* How should we determine if allocation was dynamic or static? */
                tx_byte_release(t->tx_thread_stack_start);
                tx_byte_release(t);

                TX_DISABLE

                /* Start from beginning since linked list changed now after delete operation */
                goto beg;
            }
            /* Find next thread */
            if (t->tx_thread_created_next != t
                    && t->tx_thread_created_next != _tx_thread_created_ptr) {
                t = t->tx_thread_created_next;
            } else {
                t = NULL;
            }
        }
        TX_RESTORE

        /* Yield thread */
        tx_thread_relinquish();
    }
}

/**
 * \brief           Define the initial system.
 * \param           first_unused_memory: Pointer to the first unused memory
 */
VOID
tx_application_define(VOID* first_unused_memory) {
    TX_THREAD* t_handle;
    void* stack_mem;

    /* Initialize debug unit */
    debug_init();

    /*
     * Create idle thread to monitor all other threads, having lowest priority
     *
     * Idle thread has lowest priority and static handle/stack objects
     */
    tx_thread_create(&idle_thread_handle, "idle_thread", idle_thread_func, 0,
                     idle_thread_stack, sizeof(idle_thread_stack), TX_MAX_PRIORITIES - 1, 0, TX_NO_TIME_SLICE, TX_AUTO_START);

    /* Create byte pool for ThreadX and application handling */
    if (tx_byte_pool_create(&tx_app_byte_pool, "Tx_app_mem_pool", tx_byte_pool_buffer, TX_APP_MEM_POOL_SIZE) != TX_SUCCESS) {
        Error_Handler();
    }

    /*
     * Create other application threads, 3 times in this case
     *
     * Stack and thread handles are allocated with bytepool,
     * but cleanup process must be implemented to ensure no memory leakage
     */
    for (size_t i = 0; i < 3; ++i) {
        /**
         * Creation sequence
         *
         * - Allocate memory for thread handle
         * - Allocate memory for thread stack
         * - Call thread create function to register thread to the system
         */
        if (tx_byte_allocate(&tx_app_byte_pool, (void **)&t_handle, sizeof(*t_handle), TX_NO_WAIT) == TX_SUCCESS
                && tx_byte_allocate(&tx_app_byte_pool, &stack_mem, 512, TX_NO_WAIT) == TX_SUCCESS
                && tx_thread_create(t_handle, "app_thread", app_thread_func, i + 1,
                                    stack_mem, 512, 10, 0, TX_NO_TIME_SLICE, TX_AUTO_START) == TX_SUCCESS) {
            /* All good... */
        } else {
            /* Work on proper cleanup instead */
        }
    }
}

/**
 * \brief           Application thread function entry point
 *
 * It is used for several instances of the same thread
 * \param[in]       param: User parameter, index of thread in this particular case
 */
static void
app_thread_func(ULONG param) {
    debug_printf("[T%d] Thread enter\r\n", (int)param);
    tx_thread_sleep(1000 * param);
    debug_printf("[T%d] Thread after sleep\r\n", (int)param);

    /* Some threads will terminate, some will end by exiting the function call */
    if (param == 1) {
        /* Terminate yourself */
        debug_printf("[T%d] Thread terminating\r\n", (int)param);
        tx_thread_terminate(tx_thread_identify());
    }
    debug_printf("[T%d] Exiting the thread...\r\n", (int)param);

    /* Here we are suppose to exit from thread */
}

Is there:

A way to set flag in the thread handle about dynamic allocation?
A way to get a global system callback when we can really cleanup memory?

Hi @MaJerle - thanks for bringing up some very good issues.
Your concept seems correct to me, but I didn't actually run it.
Answers to your questions:
Yes, you should call tx_thread_delete to delete the thread.
There is nothing in ThreadX that indicates whether the thread and its stack were dynamically allocated. You'll need to add this.
In the default thread struct, there is no member/flag indicating dynamic allocation. You can use TX_THREAD_USER_EXTENSION in tx_port.h to add this yourself: https://github.com/azure-rtos/threadx/blob/b216ceb25e2b6ae1ea83c1ae91d114a6fc2fc4ec/ports/cortex_m4/gnu/inc/tx_port.h#L251
Likewise, you can use the TX_THREAD_DELETE_PORT_COMPLETION macro to do the memory cleanup. This may be more efficient than an idle thread that does the cleanup. ThreadX was designed to not have an idle thread consuming CPU & resources. Perhaps we should add actual user extensions to functions like delete, terminate, etc. I'll bring this up with the ThreadX team.

For the moment it is done like this
/* TX user extension */
#define TX_THREAD_USER_EXTENSION            UINT tx_thread_user_is_handle_alloc_dynamic; \
                                            UINT tx_thread_user_is_stack_alloc_dynamic;

Thread creation
    /* Start app thread... */
    if (tx_byte_allocate(&tx_app_byte_pool, (void **)&t_handle, sizeof(*t_handle), TX_NO_WAIT) == TX_SUCCESS
            && tx_byte_allocate(&tx_app_byte_pool, &stack_mem, 4096, TX_NO_WAIT) == TX_SUCCESS
            && tx_thread_create(t_handle, "app_thread", app_thread_func, 0,
                                stack_mem, 4096, 10, 0, TX_NO_TIME_SLICE, TX_DONT_START) == TX_SUCCESS) {
        /* All good... */

        /* Set user fields since this is dynamic allocation */
        t_handle->tx_thread_user_is_handle_alloc_dynamic = 1;
        t_handle->tx_thread_user_is_stack_alloc_dynamic = 1;

        /* Start thread */
        tx_thread_resume(t_handle);
    }

Thread Idle module
#include "tx_idle_thread.h"
#include "tx_api.h"
#include "tx_thread.h"
#include "mcu.h"

/* Idle thread uses pre-defined handle structure and statically defined stack memory */
DTCM_RAM static TX_THREAD idle_thread_handle;
DTCM_RAM static uint8_t idle_thread_stack[512];
static void idle_thread_func(ULONG param);

/**
 * \brief           Idle thread function entry
 * \param[in]       param: User argument, don't care
 */
static void
idle_thread_func(ULONG param) {
    TX_INTERRUPT_SAVE_AREA
    TX_THREAD* t;

    while (1) {
        /* Process interrupts and check if anything to do */
        TX_DISABLE

        /*
         * Check a linked list of all created threads in the system.
         * Process threads in terminated or completed state.
         *
         * These threads use dynamic memory allocation,
         * hence it is now good time to clean them up
         */
beg:
        t = _tx_thread_created_ptr;
        while (t != NULL) {
            if (t->tx_thread_id != TX_THREAD_ID) {
                break;
            }
            if (t->tx_thread_state == TX_TERMINATED
                    || t->tx_thread_state == TX_COMPLETED) {
                TX_RESTORE

                /* Do we need a call to delete? */
                tx_thread_delete(t);

                /* Cleanup resources */
                /* How should we determine if allocation was dynamic or static? */
                if (t->tx_thread_user_is_stack_alloc_dynamic) {
                    tx_byte_release(t->tx_thread_stack_start);
                }
                if (t->tx_thread_user_is_handle_alloc_dynamic) {
                    tx_byte_release(t);
                }

                TX_DISABLE

                /* Start from beginning since linked list changed now after delete operation */
                goto beg;
            }
            /* Find next thread */
            if (t->tx_thread_created_next != t
                    && t->tx_thread_created_next != _tx_thread_created_ptr) {
                t = t->tx_thread_created_next;
            } else {
                t = NULL;
            }
        }
        TX_RESTORE

        /* Yield thread */
        tx_thread_relinquish();
        tx_thread_sleep(1);
    }
}

/**
 * \brief           Start idle thread
 * \return          `1` if started, `0` otherwise
 */
uint8_t
tx_idle_thread_start(void) {
    /*
     * Create idle thread to monitor all other threads, having lowest priority
     *
     * Idle thread has lowest priority and static handle/stack objects
     */
    return tx_thread_create(&idle_thread_handle, "idle_thread", idle_thread_func, 0,
                     idle_thread_stack, sizeof(idle_thread_stack), TX_MAX_PRIORITIES - 1, 0, TX_NO_TIME_SLICE, TX_AUTO_START) == TX_SUCCESS;

}

I am not sure it is the right way of doing it.

Hi @MaJerle - your logic looks correct to me.

Any chance you add this to ThreadX module as conditional compilation feature?


Move dependency versions to top level.

This is something me and Michael Starch debated at apachecon and I've been wanting to do for a long time.
Most multi module projects I work with have their dependency versions set at the top level that way its easy to change the dependency version for the project and keep everything in sync across the whole build rather than (as in one case I found) have 4 different versions of the same dependency.
I've moved them all to the core pom and ordered them alphabetically, if no one is too unhappy with this I'll finish off the reordering in the other poms and we can continue as usual. I've tried a local build nothing fails(although who knows once it hits jenkins), and if there really is a need to override a specific dependency version on a per module basis this can still be done.
Personally I think its a useful tidy up and of benefit to the developers new and old.

@buggtb @Lestarch this is a big commit. Why don't we simply create a branch in Apache OODT for this. I think we need to do it and it's useful, but I don't want you to be bogged down by patch review and so forth. Just create an SVN branch and then you pull and do GH requests against that branch and move forward without asking for incremental review. Ask for review when it's totally done :) :+1:

Okay I'll get that done later as well.


How I can change Discord webhook color?

Gitea version (or commit ref): 1.10.0-rc2
Git version: 2.23.0
Operating system:  CentOS Linux release 7.7.1908
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes
[ ] No
[x] Not relevant

Log gist: ---

Description
I can't find an option to change the color for the discord webhook anywhere. I remember when using Gogs it was an option when adding the webhook.
...
Screenshots

In v1.11.0 these will be updated to be much more diverse depending on context.
Unfortunately they are not configurable currently.

We can add some configurations like:
[webhook.discord]
color=#000000
...

Ok, thanks. Keep me in touch.

Any news?

No one is working on something for this at the moment (that I know of).
My guess is this is best suited for custom webhook templates in the future.

not yet.

Also, as a note, it would be useful to be able to set for each project directly from the webhook or something similar.

Closing per @jolheiser's comment above that this would be best suited to the custom webhook template issue.


Fix TypeError: Cannot read property 'parserName' of undefined

Version<EMAIL_ADDRESS>Steps to Reproduce:
require('leasot').parse('', { extension: '.yaml', withInlineFiles: true })

Actual:
TypeError: Cannot read property 'parserName' of undefined
    at includedFiles.forEach.includedExtension (REDUCTED/node_modules/leasot/dist/lib/parsers.js:111:69)
    at Array.forEach (<anonymous>)
    at getActiveParserNames (REDUCTED/node_modules/leasot/dist/lib/parsers.js:108:19)
    at Object.exports.parse (REDUCTED/node_modules/leasot/dist/lib/parsers.js:140:23)
    at parseText (REDUCTED/dist/parseText.js:30:25)
    at REDUCTED/dist/parseFile.js:30:37
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (REDUCTED/dist/parseFile.js:18:103)
    at _next (REDUCTED/dist/parseFile.js:20:194)
    at <anonymous>

This PR fixes this error.

Hey thanks a lot for the bug report and PR!!
It looks to me like the error is on caused by this line:
https://github.com/pgilad/leasot/pull/109/files#diff-bc8bec42915e52118765c7997d653f3aL61
Looks like .yaml defined an inline file of extension .yml which didn't exist.
Your fix added support for .yml which is awesome, but I would also remove the inline files definition of .yaml which seems kind of recursive to me..
Again thanks a lot!

Hi @pgilad. Thanks for the review.
I fixed recursively definition about .yaml.
Please review again.

🏆


libsoundio: 1.1.0 -> 2.0.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libsoundio/versions.
meta.description for libsoundio is: '"Cross platform audio input and output"'.
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0/bin/sio_sine had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0/bin/sio_list_devices had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0/bin/sio_microphone had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0/bin/sio_record had a zero exit code or showed the expected version
0 of 4 passed binary check by having a zero exit code.
0 of 4 passed binary check by having the new version present in output.
found 2.0.0 with grep in /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0
directory tree listing: https://gist.github.com/f79639672274d7b1767f09f4edb7d1b2
du listing: https://gist.github.com/660e5a3b6021767c6a7dfdd0b557987f

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
libsoundio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libsoundio https://github.com/r-ryantm/nixpkgs/archive/270f5aacf2238591a3ecf292c78ee872e5b9468f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0
ls -la /nix/store/as5g83gqqa5dlm9wxabzfgj1ax2jz5ck-libsoundio-2.0.0/bin

cc @andrewrk for testing.

@GrahamcOfBorg build libsoundio