Update repo to work with AWS Provider 3.x

I'm going to take over this PR as it is the last one in the AWS provider 3 list.
UPDATE:

Bump terratest versions 8bcaa65
Fix issue with sync gateway not starting: ae52a48
Fix issue with instances not registering to target groups:  93d6aa0

UPDATE:

CentOS 6 has been dropped from couchbase download list, so we need to update our sources for CentOS 7.

Updated checksums to match what is actually provided by couchbase.

UPDATE f8ca7e8

There appears to be a link between the sync_gateway process that is automatically started by the rpm install and the process running install-sync-gateway. I really don't understand what is going on, but effectively sudo service sync_gateway stop fails to stop the running sync_gateway process when called from install-sync-gateway. Moreover, the process hangs waiting for the sync_gateway process to finish. I confirmed this behavior when I ssh-ed into the packer instance and ran sudo service sync_gateway stop from the ssh shell, which successfully stopped both processes. This doesn't make sense because no matter how I look at it there is no link between the two processes... I worked around this by adding an explicit pkill call.

The enterprise tests expects replicas to start, but you can't have index replicas with sync_gateway unless you have the enterprise edition, so if you turn it on, it causes the community edition tests to fail. I addressed this by splitting the sync_gateway.json config file across the two editions.

@brikis98 Ok I made some progress as noted above, and am now down to the last 2 tests. However, both are for the enterprise edition and I don't have a license key so I can't debug it. It appears that the instances are appearing as unhealthy to the load balancer target groups (health checks are failing).

Hm, AFAIK, you were not required to have a license key to use the enterprise version? I'm not seeing one in our env vars or anything...

In other words, I think the license might be enforced legally, not via keys? Unless that changed...

Oh that is a misunderstanding on my part then. I'll check it out!

@yorinasub17 I'll try to pick this one up again now!

Hm, two tests are failing: TestIntegrationCouchbaseCommunitySingleClusterDnsTlsUbuntu18 and TestIntegrationCouchbaseEnterpriseMultiClusterAmazonLinux. Both are failing waiting for the Couchbase UI to come up:
TestIntegrationCouchbaseEnterpriseMultiClusterAmazonLinux 2020-09-10T03:55:03Z retry.go:84: HTTP GET to URL http://admin:password@data-ptkaak-40496447.us-east-1.elb.amazonaws.com:8091/ui/index.html returned an error: Validation failed for URL http://admin:password@data-ptkaak-40496447.us-east-1.elb.amazonaws.com:8091/ui/index.html. Response status: 502. Response body:

<title>502 Bad Gateway</title>

502 Bad Gateway

. Sleeping for 5s and will try again.

I ran them locally and can't repro. The UI comes up fine and the validation steps pass...

Just ran TestIntegrationCouchbaseCommunitySingleClusterDnsTlsUbuntu18 4 times in a row. Passed every time locally... WTF.

Ah, interesting, it passes consistently in eu-west-1, but failed in us-east-1.

OK, this is super weird... I think, in us-east-1 specifically, the run-sync-gateway script, running in User Data, simply dies part way through:
Sep 11 17:44:05 ip-172-31-34-231 user-data:
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [part-001] Creating mount point /couchbase-index...
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [part-001] Adding device /dev/xvdi to /etc/fstab with mount point /couchbase-index...
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [part-001] Mounting volumes...
Sep 11 17:44:05 ip-172-31-34-231 kernel: [   35.213300] EXT4-fs (xvdi): mounted filesystem with ordered data mode. Opts: (null)
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [part-001] Changing ownership of /couchbase-index to couchbase...
Sep 11 17:44:05 ip-172-31-34-231 user-data: Starting Couchbase
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [run-couchbase-server] Starting configuration of Couchbase server...
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [couchbase-rally-point] Using private hostname as instance address
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [couchbase-rally-point] Set node hostname to ip-172-31-34-231.ec2.internal
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [couchbase-rally-point] Set the AWS region to us-east-1
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [couchbase-rally-point] Looking up rally point for ASG single-cluster-pr9esj in us-east-1
Sep 11 17:44:05 ip-172-31-34-231 user-data: 2020-09-11 17:44:05 [INFO] [couchbase-rally-point] Looking up the size of the Auto Scaling Group single-cluster-pr9esj in us-east-1
Sep 11 17:44:09 ip-172-31-34-231 user-data: 2020-09-11 17:44:09 [INFO] [couchbase-rally-point] Looking up Instances in ASG single-cluster-pr9esj in us-east-1
Sep 11 17:44:19 ip-172-31-34-231 systemd-timesyncd[652]: Synchronized to time server <IP_ADDRESS>:123 (ntp.ubuntu.com).
Sep 11 17:48:54 ip-172-31-34-231 amazon-ssm-agent.amazon-ssm-agent[933]: 2020-09-11 17:48:54 INFO Backing off health check to every 600 seconds for 1800 seconds.
Sep 11 17:48:54 ip-172-31-34-231 amazon-ssm-agent.amazon-ssm-agent[933]: 2020-09-11 17:48:54 ERROR Health ping failed with error - AccessDeniedException: User: arn:aws:sts::087285199408:assumed-role/single-cluster-pr9esj20200911174148603600000001/i-05db3f9af8232575f is not authorized to perform: ssm:UpdateInstanceInformation on resource: arn:aws:ec2:us-east-1:087285199408:instance/i-05db3f9af8232575f
Sep 11 17:48:54 ip-172-31-34-231 amazon-ssm-agent.amazon-ssm-agent[933]: #011status code: 400, request id: 0f691d3c-d898-4940-897e-4fb8e339c01c
Sep 11 17:58:31 ip-172-31-34-231 systemd[1]: Starting Cleanup of Temporary Directories...

After Looking up Instances in ASG single-cluster-pr9esj in us-east-1, there's no more log output from the User Data script... And no indication of error. WTH?

I noticed a similar issue with ELK and had to disable us-east-1. What I found in ELK was that there is some kind of network issue with accessing the EC2 endpoint in us-east-1. Here is the error message: https://github.com/gruntwork-io/package-elk/issues/102

Just manually re-ran the User Data script on one of the EC2 instances and very weirdly, I now see in syslog:
Sep 11 18:14:17 ip-172-31-34-231 user-data:
Sep 11 18:14:17 ip-172-31-34-231 user-data: Connect timeout on endpoint URL: "https://ec2.us-east-1.amazonaws.com/"
Sep 11 18:14:18 ip-172-31-34-231 user-data: 2020-09-11 18:14:18 [INFO] [couchbase-rally-point] Found  / 3 Instances in ASG single-cluster-pr9esj in us-east-1.
Sep 11 18:14:18 ip-172-31-34-231 user-data: 2020-09-11 18:14:18 [WARN] [couchbase-rally-point] Will sleep for 5 seconds and try again.
Sep 11 18:17:01 ip-172-31-34-231 CRON[1952]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Sep 11 18:18:54 ip-172-31-34-231 amazon-ssm-agent.amazon-ssm-agent[933]: 2020-09-11 18:18:54 INFO Backing off health check to every 1200 seconds for 3600 seconds.
Sep 11 18:18:54 ip-172-31-34-231 amazon-ssm-agent.amazon-ssm-agent[933]: 2020-09-11 18:18:54 ERROR Health ping failed with error - AccessDeniedException: User: arn:aws:sts::087285199408:assumed-role/single-cluster-pr9esj20200911174148603600000001/i-05db3f9af8232575f is not authorized to perform: ssm:UpdateInstanceInformation on resource: arn:aws:ec2:us-east-1:087285199408:instance/i-05db3f9af8232575f
Sep 11 18:18:54 ip-172-31-34-231 amazon-ssm-agent.amazon-ssm-agent[933]: #011status code: 400, request id: de72c861-da2e-442a-8206-ab1ce7d59657
Sep 11 18:25:41 ip-172-31-34-231 user-data: Mounting EBS Volumes for data and index directories
Sep 11 18:25:41 ip-172-31-34-231 user-data: 2020-09-11 18:25:41 [INFO] [user-data.sh] Creating ext4 file system on /dev/xvdh...
Sep 11 18:25:41 ip-172-31-34-231 user-data: mke2fs 1.44.1 (24-Mar-2018)
Sep 11 18:25:41 ip-172-31-34-231 user-data: /dev/xvdh is mounted; will not make a filesystem here!

I think it's the same issue you saw with ELK Yori:
Sep 11 18:14:17 ip-172-31-34-231 user-data: Connect timeout on endpoint URL: "https://ec2.us-east-1.amazonaws.com/"

Could it be an issue with AWS CLI v1?

I'm able to repro directly on the instance:
aws ec2 describe-instances --region "us-east-1" --filters "Name=tag:aws:autoscaling:groupName,Values=single-cluster-pr9esj" "Name=instance-state-name,Values=pending,running"

That command just hangs until it times out in us-east-1.

I'm not sure it is related to AWS CLI, given that in ELK the error is in the Java SDK. Do you think this might be an issue with the default VPC in our accounts?

Updating to AWS CLI v2 does not fix it.

OK, I think that was the issue indeed. We had a random VPC Endpoint in there... I just deleted it and AWS CLI calls work again.

Re-running tests...

BTW, if that VPC Endpoint turns out to be the culprit... I can't imagine how many spurious test failures it must have caused!

Tests are passing! Yaaaaay.
One more review please, and we can finally ship this thing.

Thanks for the review! Merging now.


Translate Speed Trend into m/s^2

The speed trend is now constantly showing zero because it's in km/h^2. Translate it into m/s^2 to make it more casual.

m/s^2 is actually smaller. Keeping one decimal place is currently the best option.

Issue resolved in commit 8599ef0b.


Not able to see the git changes in the explorer

Issue Type: Bug
I just started using Visual Studio Code. I added all my projects that are using git as Source Control.
VisualStudio Code is able to detect the changes what is staged and what is not, but when I click on Open Changes, nothing is displayed.
VS Code version: Code 1.42.0 (ae08d5460b5a45169385ff3fd44208f431992451, 2020-02-06T10:51:33.119Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.22GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

vscode-peacock
joh
3.3.1

intellij-idea-keybindings
k--
0.2.37

chat
kar
0.31.0

vscode-docker
ms-
0.10.0

vsliveshare
ms-
1.0.1587

vsliveshare-audio
ms-
0.1.80

vsliveshare-pack
ms-
0.3.4

This is "Open Changes" at the top of the editor? It should either open a view like this:

Where the file is split, or like this:

Where changes are inline. What happens when you click it? One thing to note is that the changes must be saved for them to appear, as it works based on git, which only knows about what's on disk.

Hi,
Thanks for the quick response.
It's just displaying the folder of the project. It's not displaying the
files under the project that has been updated.
I am sure the changes were saved in local.
Thanks
El jue., 13 feb. 2020 a las 19:23, Jackson Kearl<EMAIL_ADDRESS>escribió:

This is "Open Changes" at the top of the editor? It should either open a
view like this:
[image: image]
https://user-images.githubusercontent.com/8586769/74465048-863dd600-4e49-11ea-91f8-04b82ccdda1d.png
Where the file is split, or like this:
[image: image]
https://user-images.githubusercontent.com/8586769/74465068-905fd480-4e49-11ea-9f92-b3e951ca7446.png
Where changes are inline. What happens when you click it? One thing to
note is that the changes must be saved for them to appear, as it works
based on git, which only knows about what's on disk.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/90594?email_source=notifications&email_token=ABBM6N4S7MBSWTA45KOEJ2DRCWF2FA5CNFSM4KURUQXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWCHMI#issuecomment-585900977,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBM6N3KON6O6XEKXEGCFOLRCWF2FANCNFSM4KURUQXA
.

--
Sendamí Luque Liñán

To be clear: are you pressing this button:

at the top of an editor with non-committed changes? Do you see the change markers near the line numbers?

What happens if you click those?

If I click on that button, Visual Studio loads the explorer view, without
loading any file or displaying anything regarding non-committed changes.
El jue., 13 feb. 2020 a las 19:50, Jackson Kearl<EMAIL_ADDRESS>escribió:

To be clear: are you pressing this button:
[image: image]
https://user-images.githubusercontent.com/8586769/74467678-5e9d3c80-4e4e-11ea-84a8-fdb5ecae835d.png
at the top of an editor with non-committed changes? Do you see the change
markers near the line numbers?
[image: image]
https://user-images.githubusercontent.com/8586769/74467809-9c9a6080-4e4e-11ea-8395-9540b07418de.png
What happens if you click those?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/90594?email_source=notifications&email_token=ABBM6N4FHZAK6FPRMAUCMULRCWI7HA5CNFSM4KURUQXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWFTGI#issuecomment-585914777,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBM6N564MQLA7RXS6YYT6LRCWI7HANCNFSM4KURUQXA
.

--
Sendamí Luque Liñán

Now, I noticed when I click on that button I'm seeing the following
error: Unable to open '????': File is a directory. But the problem is
inside the Source Control View, I only see the folder of the projects, no
files are displayed.
El jue., 13 feb. 2020 a las 20:02, Sendamí luque<EMAIL_ADDRESS>escribió:

If I click on that button, Visual Studio loads the explorer view, without
loading any file or displaying anything regarding non-committed changes.
El jue., 13 feb. 2020 a las 19:50, Jackson Kearl (<
<EMAIL_ADDRESS>escribió:

To be clear: are you pressing this button:
[image: image]
https://user-images.githubusercontent.com/8586769/74467678-5e9d3c80-4e4e-11ea-84a8-fdb5ecae835d.png
at the top of an editor with non-committed changes? Do you see the change
markers near the line numbers?
[image: image]
https://user-images.githubusercontent.com/8586769/74467809-9c9a6080-4e4e-11ea-8395-9540b07418de.png
What happens if you click those?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/90594?email_source=notifications&email_token=ABBM6N4FHZAK6FPRMAUCMULRCWI7HA5CNFSM4KURUQXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWFTGI#issuecomment-585914777,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBM6N564MQLA7RXS6YYT6LRCWI7HANCNFSM4KURUQXA
.

--
Sendamí Luque Liñán

--
Sendamí Luque Liñán

So you have changes in the project, but the Source Control View only shows the folders that contain files which have changed, rather than the files themselves?

Exactly.
On Thu, 13 Feb 2020, 20:08 Jackson Kearl<EMAIL_ADDRESS>wrote:

So you have changes in the project, but the Source Control View only shows
the folders that contain files which have changed, rather than the files
themselves?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/90594?email_source=notifications&email_token=ABBM6N43ABWSRA2UMXMVILDRCWLETA5CNFSM4KURUQXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWHUII#issuecomment-585923105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBM6N3SQQU7QRUIU67JBL3RCWLETANCNFSM4KURUQXA
.

Hey Jackson,
Now it's working. It seems workspace was added. In consequence, the folders
inside the workspace were added as well.
I removed the git folder at the workspace folder level and just add the
project that I wanted to check, and now it's working.
It's not really intuitive from my point of view.
Anyway, thanks for your help
El jue., 13 feb. 2020 a las 22:55, Sendamí luque<EMAIL_ADDRESS>escribió:

Exactly.
On Thu, 13 Feb 2020, 20:08 Jackson Kearl<EMAIL_ADDRESS>wrote:

So you have changes in the project, but the Source Control View only
shows the folders that contain files which have changed, rather than the
files themselves?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/90594?email_source=notifications&email_token=ABBM6N43ABWSRA2UMXMVILDRCWLETA5CNFSM4KURUQXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWHUII#issuecomment-585923105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBM6N3SQQU7QRUIU67JBL3RCWLETANCNFSM4KURUQXA
.

--
Sendamí Luque Liñán


Emit diagnostics from config files

Currently we call Mix.Task.run("loadconfig"). This call raises and we end up returning stacktrace and and diagnostics with wrong file - mix.exs. We can fork mix code and emit proper diagnostics

Addressed in 17548317bfe7d4dc6325db9bf2a361dc37c8554e


Implement helpers for storing and finding events

#no-changelog because more changes are incoming.
Essentially, this change is to allow the storing of events to the filesystem in 3 ways:

A direct write of a GDTCOREvent to the root data path, using the eventID as the filename. This will allow fast finding of events by target.
A symbolic link to the direct write that allows fast finding of events via the mappingID.
A symbolic link to the direct write that allow fast finding of events via the qosTier.

Nice. I wonder if there is a design doc or some high-level overview of the storage structure. Now it looks more or less understandable after reading the PR description, but I'm afraid it may be more difficult in a month or so.

Added some clarifying comments after I realized I was actually returning the wrong paths.


[pre-sve] TC-SU-2.8 unable to commission second ota-provider

Problem

Test case ID: TC-SU-2.8
SHA: 425f1fb916ca154deeb75cd82cd5196778aba152
DUT platform: Ameba all-clusters-app
Chip-tool platform: Raspberry Pi
OTA provider platform: Raspberry Pi linux ota-provider-app

TH1/CR1, TH2/OTAP1, TH3/OTAP2 are all running on a single RPI.

Step 2 requires 2 instances of OTA-provider.
Commissioning the first OTAP1 using chiptool is successful. Commissioning the next OTAP2 results in timeout error.
Also noted that after an OTA-provider is killed, in order to commission a new OTA-provider, tmp files needs to be deleted rm /tmp/chip*

Steps to reproduce

On TH2/OTAP1, launch provider app ./ota-provider-app -f <filepath>
On TH1/CR1, commission TH2/OTAP1 ./chip-tool pairing onnetwork 1234 20202021
On TH3/OTAP2, launch provider app ./ota-provider-app -f <filepath>
On TH1/CR1, commission TH3/OTAP2 ./chip-tool pairing onnetwork 1235 20202021

TC-SU-2.8-chip-tool.txt

Cert Blocker Review: Given this has been in review for > 2 days, closing this. Please re-open if this an issue after running the test plan.


OnVideoSourceEncodedSample of WindowsVideoEndPoint is not called periodically

The video sampling from OnVideoSourceEncodedSample is jerky. as FrameArrivedHandler is not called at fixed intervals(the event is not raised for a long time. and all of a sudden, it is called a few times). This is a silly question that probably is non-relevant to SIPSorceryMedia.Windows project. I am new to video programming, is it caused by intensive cpu usage?

the same problem.Seeking a solution

Yes, more likely CPU related although if you're using FFmpeg or libvpx native libraries for encoding it should cope fine.
A good test would be to reduce the frame rate and/or resolution and see if the problem persists. If it goes away then that does point to a CPU bottleneck.


Mongo async support

This contains all of Marek's work, plus I added some tests and updated MongoTestKit.
I also redid MongoAsync.defineDb to take a MongoDatabase instead of (MongoClient, String) . This allows the user to configure the MongoDatabase however they like. Because of this, I removed the setting of the CodecRegistry. This will have to be done by the user. An example is provided in the comments.

Unless someone wants to take a look at this, I'll merge it in a couple more days.


Issue about symmetrix matrix during clustering

Hello team,
Initially i would like to thank you for this repository.
I face the next issue: when i examine one of my own datasets, the clustering process does not work, taking the next message:
'ValueError: Distance matrix 'X' must be symmetric.'
I have manually augment the edges so as to contain the inverse relations and follow the steps as in your case. Shouldn't the distances format automatically a symmetric matrix?
Thanks in advance.

Hi,
Can you specify the exact line where this error is raised? A full stack trace would be better.

[2021-11-08 12:06:15 	 Clustering entities with linkage = 0.25...]
Traceback (most recent call last):
File "prob_cbr/pr_cbr.py", line 862, in
main(args)
File "prob_cbr/pr_cbr.py", line 754, in main
args.cluster_assignments = cluster_entities(adj_mat, args.linkage)
File "/home/scarlos/Documents/git/reasoning/Prob-CBR-main/prob_cbr/clustering/entity_clustering.py", line 27, in cluster_entities
zavg = linkage(squareform(dists), method='average')
File "/home/scarlos/anaconda3/envs/seal/lib/python3.6/site-packages/scipy/spatial/distance.py", line 2184, in squareform
is_valid_dm(X, throw=True, name='X')
File "/home/scarlos/anaconda3/envs/seal/lib/python3.6/site-packages/scipy/spatial/distance.py", line 2260, in is_valid_dm
'symmetric.') % name)
ValueError: Distance matrix 'X' must be symmetric.

@ameyagodbole i have solved the issue. I had to add the invert relations after the train/dev/test split. Thanks for your time.


Add instructions to removing existing presets

What problem does this feature solve?
I save my settings as a preset and then I couldn't remove it. By reading the source code I realize those presets are stored in ~/.vuerc. I hope there is an introduction to how to remove useless configs.
What does the proposed API look like?
A short, brief introduction to .vuerc and removing presets.

Found the instruction in documentation. Close.


Governance. Add delegation. Missed case with add delegation to another delegator.

Description
When user has already delegated his votes, the list of delegators works unclear - it shows only one delegator, which user have already delegated, but there is no clear way to delegate to another account. But if user use any filter or search it will show another delegators.
For me as for user it would be more clearly if open "Your delegations" page with all delegators to whom I already delegated and button - "Add delegation" which will open current page with search and filters instead of opening "Add delegation" page where search and filters will show other delegators at the same time.
Example:
https://github.com/user-attachments/assets/63563839-813b-4a32-89f7-e8e6dcab26ad
Steps to Reproduce

Delegate to someone
Open delegations
Use search or filters

Expected Behavior
User should understand where is his delegations and where are another delegators
https://www.figma.com/design/4vjREBpvZK7M3m1GaoVptq/OpenGov-delegations?node-id=50-238018&t=uktweFgBks9ZlQFV-4
Actual Behavior
two different list is mixed
Environment
https://github.com/novasamatech/nova-spektr/commit/64f12ff7746cb19024e2df0b6009cec5e6e2cf17

Status verification: ✅


Make the Snackeater look a bit less boring !

Everything is a little dull right now !

Hi, I am Keyur Gandhi, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you

Hi @cconstab , This is Kamalesh from India . I would like to work on this issue . Can you assign to me so I can resolve this issue by making an PR ?

Glad you are up to the challenge! Looking forward to seeing the PR's

Hi folks looking forward to seeing what you do !

Hi folks looking forward to seeing what you do !

Running app in android emulator is giving me error.
Build file 'D:\Code\Open Source\snackeater\android\app\build.gradle' line: 28

What went wrong:
A problem occurred evaluating project ':app'.

Project with path ':flutter_config' could not be found in project ':app'.

could you please help me in that?

For sure.. my guess is the biometric storage package is updated and needs a newer version of gradle.. I will take a look and let you know


Stale proposals alert in UI for managers - hierarchical

User Story
stale proposals alert manager in UI

Epic Title
Hierarchical

T-shirt size: SML

User Story
"As a manager of approvers, I want the UI to alert me as proposals grow stale so I know I have actions to take to keep the business moving"

Description
Lead time to trigger this alert is a configurable setting.

Acceptance Criteria/Tests
Verify that the UI alert correctly displays for the manager when a direct report has stale pending proposals.  Verify that alert indicates which approver has the actions.  Verify that alert goes away once action is taken.   Verify that alerts go away once proposal has expired.

Notes: depends on #854 - implement trigger for alerts
This visual alert only applies to the direct manager of the approver -- alerts do not go higher than one level up the org.
triggering this alert doesn't modify the proposal expiration time in any way.

migrated to new tmobile/sawtooth-next-directory repo


Revert " [runtime] unittests should use just-built compiler if the ru…

…ntime did"
This seems to be causing issues with the ASAN bot. And I don't think
this was actually causing issues in the tests.
rdar://73664504

@swift-ci Please test

@swift-ci Please test


missing documentation on how-to-run

I was talking to @Brendayy today and found that this repository is missing any documentation about the installation and operation of the app. @eholderness95 can you add something that @Brendayy can use to start running whisper on AAPB data for the LoC slide material?

Yes, thanks for reminder! Will do that today.

Added minimal start to ReadMe


uv 0.2.36 regression - uv pip compile --universal gives contradictory versions of same packages

uv 0.2.36 can give contradictory versions of the same package with the following command:
$ echo -e "pylint\ndill==<IP_ADDRESS>" | uv pip compile - --universal --python-version 3.11 --annotation-style line 2>/dev/null | grep "pylint=="

In uv 0.2.35 the output is:
pylint==2.15.8

In uv 0.2.36 the output is:
pylint==2.15.8
pylint==3.2.6

It seems pylint==3.2.6 is not correctly filtered out as belonging to a Python version not compatible, if we switch --python-version to 3.10 we can see the markers that are applied when they are relevant:
$ echo -e "pylint\ndill==<IP_ADDRESS>" | uv pip compile - --universal --python-version 3.10 --annotation-style line 2>/dev/null | grep "pylint=="
pylint==2.15.8 ; python_version >= '3.11'
pylint==3.2.6 ; python_version < '3.11'

Presuming this is 0.2.36?

Thanks! I think this is related to #6059.

Presuming this is 0.2.36?

Yeah, fixed post to correct typo

Taking a look now.

I think the problem here is:

We end up solving an irrelevant fork (python_version < 3.11), because we don't test for requires-python disjointness.
In the lockfile, we discard any markers that aren't relevant for the current Python version, so we throw out the markers from the irrelevant fork.

If you remove that block (e.g., the whole petgraph.retain_edges(|graph, edge| !graph[edge].is_false())) piece, the resolution is correct:
# This file was autogenerated by uv via the following command:
#    uv pip compile req.in --universal --python-version 3.11 -n
astroid==2.13.5 ; python_version >= '3.11'
    # via pylint
astroid==3.2.4 ; python_version < '3.11'
    # via pylint
colorama==0.4.6 ; sys_platform == 'win32'
    # via pylint
dill==<IP_ADDRESS>
    # via
    #   -r req.in
    #   pylint
isort==5.13.2
    # via pylint
lazy-object-proxy==1.10.0 ; python_version >= '3.11'
    # via astroid
mccabe==0.7.0
    # via pylint
platformdirs==4.2.2
    # via pylint
pylint==2.15.8 ; python_version >= '3.11'
    # via -r req.in
pylint==3.2.6 ; python_version < '3.11'
    # via -r req.in
tomlkit==0.13.0
    # via pylint
wrapt==1.16.0 ; python_version >= '3.11'
    # via astroid

I think we should remove that block from graph.rs, and instead ensure that all the markers we see at that point have already been simplified based on requires-python.


Language Server: Long delay for symbols to be available. During this intellisense is broken

VS Code version: Latest insiders
Extension version (available under the Extensions sidebar): latest version
OS and version: Win 10
Python version (& distribution if applicable, e.g. Anaconda): 3.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX

Install latest insisders.
open Code
Workspace takes along time before symbols / intellisense work.
Example. Open 5 minutes.
Nothing in the status to say workspace is being analyzed.
Outline has nothing
And intellisense in file does not work.
If a file is open in the editor, shouldnt it take some precedence, and the analysis should happen as priority vs any background analysis.

Hi, @derekwallace.  Thanks for letting us know about this.  Are you using the new language server or the old (default) intellisense support (AKA Jedi)?  It matters because with Jedi there are already a number of known issues with performance.  With the new language server there is one known issue with slower startup: #1865.
You can manually force using the new language server with the following setting:
"python.jediEnabled": false,

FWIW, I tried both, using a large and complex code base (Python stdlib), and found Jedi to be rather slow.  The new language server was really fast.
I'm going to close this issue for now, under the assumption that the issue you're reporting is already covered by an existing issue.  If that's not the case then please re-open this one.

I'm using new language server. The old jedi was unusable on a large project on a network drive in Windows. The new language server was initially much much better albeit with some issue e.g symbol outline broken. But now it seems to be worse i.e. it takes minutes for intellisense to be operable. I get the impression it rescans the entire workspace to recreate the dB every time open workspace rather than using the last saved state when reopen workspace. The lack of debug info in console means it's very hard for me to give concrete debug info for you.

@derekwallace correct; nothing is cached.

Even when Outline loads, it wont show everything like the variables inside the functions

@MilkyHearts - Outline is getting fixed as we speak.
@derekwallace - we are considering caching of analysis at some point.


BREAKING CHANGE: xSQLServerAlwaysOnService: Restart the Agent Service if Running (Fixes #187)

Updated the xSQLServerAlwaysOnService resource to automatically restart the SQL Server Agent service if it was previously running after the IsHadrEnabled property is set. Moved the Restart-SqlService function from xSQLServerConfiguration to xSQLServerHelper to allow for code reuse. Updated the mandatory parameters to include the SQL Instance Name.
This Pull Request (PR) fixes the following issues:
xSQLServerAlwaysOnService: Should restart the SQL Agent if it was previously running: Fixes #187

[X] Change details added to Unreleased section of CHANGELOG.md?
[X] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[X] Examples appropriately updated?
[X] New/changed code adheres to Style Guidelines?
[X] Unit and (optional) Integration tests created/updated where possible?

This change is

Hi @randomnote1, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Dan Reist). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

For some reason the AppVeyor did not register to run the tests. We'll see on your next push if it does that correctly. It should just auto magically work. :) If it does not I have to investigate.

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 50 unresolved discussions.

CHANGELOG.md, line 37 at r1 (raw file):

  - Fixed bug where the SQL Agent service did not get restarted after the IsHadrEnabled property was set.
- Moved Restart-SqlService from MSFT_xSQLServerConfiguration.psm1 to xSQLServerHelper.psm1.
- Created unit tests for xSQLServerHelper.psm1 and moved the existing tests for Restart-SqlService to it.

Could you please add the two rows 'Created unit tests...',  together with the other new tests, under the list item 'Added tests for resources' higher up in the Unreleased section?
Would be nice if we could keep the change log a bit organized. :)

DSCResource.Tests, line 1 at r1 (raw file):

Subproject commit 987ae8c9dc3f1449a0be8dab7f77d04b097c2da3

Could you please make sure this is not part of the PR. Delete this from your working branch, commit and push the change. After that make sure you got a .gitignore file in the root of your working branch which contains 'DSCResource.Tests'.
This file is generated automatically when `Invoke-Pester' is ran.
I wouldn't mind if we committed a .gitignore to this repo so this won't happen for others.

README.md, line 308 at r1 (raw file):

### xSQLServerAlwaysOnService

* **Ensure**: (key) An enumerated value that describes if SQL server should have AlwaysOn property present or absent.

Change (key) to (Key). Upper 'K'.

README.md, line 309 at r1 (raw file):

* **Ensure**: (key) An enumerated value that describes if SQL server should have AlwaysOn property present or absent.
* **SQLServer**: The hostname of the SQL Server to be configured

Add (Key) to this parameter description as well.

README.md, line 310 at r1 (raw file):

* **Ensure**: (key) An enumerated value that describes if SQL server should have AlwaysOn property present or absent.
* **SQLServer**: The hostname of the SQL Server to be configured
* **SQLInstance**: Name of the SQL instance to be configured. Default is 'MSSQLSERVER'

See comment in schema.mof. If this is made Key, add (Key) to this description as well.

xSQLServerHelper.psm1, line 1208 at r1 (raw file):

    .PARAMETER Timeout
    Timeout value for restarting the SQL services

Could you please add to the description what the default value is?

xSQLServerHelper.psm1, line 1228 at r1 (raw file):

        $SQLServer,

        [String]

Please add [Parameter()] attribut to the this parameter.
https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

xSQLServerHelper.psm1, line 1231 at r1 (raw file):

        $SQLInstanceName = 'MSSQLSERVER',

        [Int32]

Please add [Parameter()] attribut to the this parameter.

xSQLServerHelper.psm1, line 1286 at r1 (raw file):

        }
    }
}

Please add a new line at the end of the file.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 6 at r1 (raw file):

<#
    .SYNOPSIS

Please add the parameter Ensure to the comment-based help. Also add *** Not used in this function *** to the description.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 10 at r1 (raw file):

    .PARAMETER SQLServer
    Hostname of the SQL Server to be configured

Please add what the default value is to the description of this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 29 at r1 (raw file):

        $Ensure,

        [System.String]

Please add [Parameter()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 32 at r1 (raw file):

        $SQLServer = $env:COMPUTERNAME,

        [System.String]

Please add [Parameter()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 36 at r1 (raw file):

        [Int32]
        $RestartTimeout = 120

This Non-mandatory parameter is not used, could we remove it?
There is a PR on it's way (not yet merged) regarding this
https://github.com/johlju/DscResources/blob/663c7d5cc36bb4ebe53c59b3997875f03f9b4a8d/BestPractices.md#get-targetresource-should-not-contain-unused-non-mandatory-parameters

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 39 at r1 (raw file):

    )

    if( -not $sql )

We should need to use an if here? It is not set before.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 48 at r1 (raw file):

<#
    .SYNOPSIS

Please add the parameter Ensure to the comment-based help

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 51 at r1 (raw file):

    Sets the current value of the SQL Server HADR property.

    .PARAMETER SQLServer

Please add what the default value is to the description of this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 70 at r1 (raw file):

        $Ensure,

        [System.String]

Please add [Parameter()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 73 at r1 (raw file):

        $SQLServer = $env:COMPUTERNAME,

        [System.String]

Please add [Parameter()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 76 at r1 (raw file):

        $SQLInstanceName = 'MSSQLSERVER',

        [Int32]

Please add [Parameter()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 90 at r1 (raw file):

    }

    switch ($Ensure)

Question: I see that we don't import SQLPS module before running these cmdlets. Should we?
If not, maybe the 'Import-SQLPSModule' is not needed in the Helper module?

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 117 at r1 (raw file):

<#
    .SYNOPSIS

Please add the parameter Ensure to the comment-based help

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 120 at r1 (raw file):

    Determines whether the current value of the SQL Server HADR property is properly set

    .PARAMETER SQLServer

Please add what the default value is to the description of this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 140 at r1 (raw file):

        $Ensure,

        [System.String]

Please add [Paramater()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 143 at r1 (raw file):

        $SQLServer = $env:COMPUTERNAME,

        [System.String]

Please add [Paramater()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 146 at r1 (raw file):

        $SQLInstanceName = 'MSSQLSERVER',

        [Int32]

Please add [Paramater()] attribut to the this parameter.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 5 at r1 (raw file):

class MSFT_xSQLServerAlwaysOnService : OMI_BaseResource
{
    [Key, ValueMap{"Present","Absent"}, Values{"Present","Absent"}] String Ensure;

Please add a description to Ensure parameter too.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r1 (raw file):

    [Key, ValueMap{"Present","Absent"}, Values{"Present","Absent"}] String Ensure;
    [Key, Description("The hostname of the SQL Server to be configured")] String SQLServer;
    [Write, Description("Name of the SQL instance to be configured. Default is 'MSSQLSERVER'")] String SQLInstanceName;

I think we should make this parameter SQLInstanceName as a Key to. Otherwise you can not set two instances on the same node?
This will be a breaking change. But good if we do this now, because we have a lot of other breaking changes already for the next release.

DSCResources/MSFT_xSQLServerConfiguration/MSFT_xSQLServerConfiguration.psm1, line 233 at r1 (raw file):

    Restart-SqlService -SQLServer CLU01 -Timeout 300
#>
function Restart-SqlService

This is a newer version you are removing than you are adding. This one uses "CIM-methods", the one you are adding uses "WMI-methods".
Please do a rebase (do not use merge or pull) of your fork (dev) and your working branch. See the following https://github.com/johlju/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts
Make sure the tests is up to date also.

en-US/xSQLServer.strings.psd1, line 41 at r1 (raw file):

# AlwaysOnService
AlterAlwaysOnServiceFailed = Failed to {0} Always On on the instance {1}.

We use ' around {} for the other strings, should we keep doing the same or does it not work in this string?
Also, if I read the code correctly, this string would become for example Failed to Present AlwaysOn on the instance MSSQLSERVER.  Could we make it a bit better? :smile:

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 18 at r1 (raw file):

    -TestType Unit

$defaultState = @{

Could you rename this parameter to  $absentState?

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 25 at r1 (raw file):

}

$desiredState = @{

Could you rename this parameter to  $presentState?

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 32 at r1 (raw file):

}

$desiredStateNamedInstance = @{

Could you rename this parameter to  $presentStateNamedInstance?

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 44 at r1 (raw file):

    Describe "$($script:DSCResourceName)\Get-TargetResource" {

        Mock -CommandName New-VerboseMessage -MockWith {} -ModuleName $script:DSCResourceName

You don't need to mock New-VerboseMessage. You can remove all of the New-VerboseMessage mocks  if you want. If you remove this you should get more code coverage.
It will output verbose messages in the output when running tests, but it is okay. We will change this New-VerboseMessage to Write-Verbose in the future when we align the localization with the HQRM standard. It is another issue.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 46 at r1 (raw file):

        Mock -CommandName New-VerboseMessage -MockWith {} -ModuleName $script:DSCResourceName

        Context 'The system is not in the desired state' {

Could you start all the context blocks description with 'When...'? Like 'When the system is not in desired state'?

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 49 at r1 (raw file):

            Mock -CommandName Connect-SQL -MockWith {
                $mock = New-Object PSObject -Property @{

You could just return the object directly? Same for the rest of the mocks

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 59 at r1 (raw file):

            $result = Get-TargetResource @desiredState

            It 'Should return the same values as passed' {

See below. This would be 'Should return the state as $false'

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 60 at r1 (raw file):

            It 'Should return the same values as passed' {
                $result.IsHadrEnabled | Should Not Be @{ 'Present' = $true; 'Absent' = $false }[$desiredState.Ensure]

Please do two tests of this, either two It-blocks (create the Mock in each It-block) or two context-blocks. One that tests for not in desired state for 'Absent' and another that tests for not in desired state for 'Present'
Also please test for one expected value only, like Should Not Be $true, or better Should Be $false.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 81 at r1 (raw file):

            $result = Get-TargetResource @desiredState

            It 'Should return the same values as passed' {

See below. This would be 'Should return the state as $true'

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 82 at r1 (raw file):

            It 'Should return the same values as passed' {
                $result.IsHadrEnabled | Should Be ( @{ 'Present' = $true; 'Absent' = $false }[$desiredState.Ensure] )

Please do two tests of this, either two It-blocks or two context-blocks. One that tests for in desired state for 'Absent' and another that tests for in desired state for 'Present'
Also please test for one expected value only, like Should Be $true.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 95 at r1 (raw file):

        Mock -CommandName Disable-SqlAlwaysOn -MockWith {} -ModuleName $script:DSCResourceName

Please load the SQLPS stubs for mocking these. So the tests can be run on a client without SQLPS installed. See below how to import SQLPSStub.psm1 for this.
https://github.com/PowerShell/xSQLServer/blob/dev/Tests/Unit/MSFT_xSQLServerAvailabilityGroupListener.Tests.ps1#L41
That line in that resource tests I linked to does not comply with style guideline, so when you add the line, please make sure you replace any '\' with Join-Path/Split-Path the same way you used for the path to import the helper module.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 118 at r1 (raw file):

                Set-TargetResource @desiredState
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Connect-SQL -Scope It -Times 1
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Enable-SqlAlwaysOn -Scope It -Times 1

Please add an Assert for Disable-SqlAlwaysOn that it should be called -Times 0

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 134 at r1 (raw file):

                Set-TargetResource @defaultState
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Connect-SQL -Scope It -Times 1
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Disable-SqlAlwaysOn -Scope It -Times 1

Please add an Assert for Enable-SqlAlwaysOn that it should be called -Times 0

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 138 at r1 (raw file):

            }

            It 'Should enable SQL Always On on a named instance when Ensure is Present' {

You should not also test to disable for a named instance?

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 150 at r1 (raw file):

                Set-TargetResource @desiredStateNamedInstance
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Connect-SQL -Scope It -Times 1
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Enable-SqlAlwaysOn -Scope It -Times 1

Please add an Assert for Disabled-SqlAlwaysOn that it should be called -Times 0

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 154 at r1 (raw file):

            }

            It 'Should call New-TerminatingError when the resource fails to apply the desired state' {

Please change this description to something like 'Should throw the correct error message....'
Should you test this throwing for both 'Present' and 'Absent'?

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 166 at r1 (raw file):

                { Set-TargetResource @desiredState } | Should Throw 'AlterAlwaysOnServiceFailed'
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Connect-SQL -Scope It -Times 1
                Assert-MockCalled -ModuleName $script:DSCResourceName -CommandName Enable-SqlAlwaysOn -Scope It -Times 1

Please add an Assert for Disabled-SqlAlwaysOn that it should be called -Times 0

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 189 at r1 (raw file):

        }

        It 'Should cause Test-TargetResource method to return true' {

Please align this description with the one above. 'to return true when...'

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 197 at r1 (raw file):

{
    Restore-TestEnvironment -TestEnvironment $TestEnvironment
}

Please add a new line at the end of the file.

 Please align with the unit test template.

Comments from Reviewable

@randomnote1 Could you please go into Reviewable and reply 'Done' on each comment you are finished with?
You start Reviewable by clicking the big Purple button in the first comment at the top of this page.
Also the tests is failing in AppVeyor. Look here; https://ci.appveyor.com/project/PowerShell/xsqlserver/build/3.0.552.0
If you could correct these. If you need help let me know. :)

Absolutely. I tried to publish my comments yesterday, but Reviewable kept crashing. I'll try a different browser today.
I'll look at fixing the failures found in AppVeyor.
Thanks!

Review status: 2 of 10 files reviewed at latest revision, 50 unresolved discussions, some commit checks failed.

CHANGELOG.md, line 37 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you please add the two rows 'Created unit tests...',  together with the other new tests, under the list item 'Added tests for resources' higher up in the Unreleased section?
Would be nice if we could keep the change log a bit organized. :)

Done.

README.md, line 308 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change (key) to (Key). Upper 'K'.

Done.

README.md, line 309 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Add (Key) to this parameter description as well.

Done.

README.md, line 310 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
See comment in schema.mof. If this is made Key, add (Key) to this description as well.

Done.

xSQLServerHelper.psm1, line 1208 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you please add to the description what the default value is?

Done.

xSQLServerHelper.psm1, line 1228 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.
https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block

Done.

xSQLServerHelper.psm1, line 1231 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.

Done.

xSQLServerHelper.psm1, line 1286 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add a new line at the end of the file.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 6 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add the parameter Ensure to the comment-based help. Also add *** Not used in this function *** to the description.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 10 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add what the default value is to the description of this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 29 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 32 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 36 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This Non-mandatory parameter is not used, could we remove it?
There is a PR on it's way (not yet merged) regarding this
https://github.com/johlju/DscResources/blob/663c7d5cc36bb4ebe53c59b3997875f03f9b4a8d/BestPractices.md#get-targetresource-should-not-contain-unused-non-mandatory-parameters

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 39 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We should need to use an if here? It is not set before.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 48 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add the parameter Ensure to the comment-based help

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 51 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add what the default value is to the description of this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 70 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 73 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 76 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Parameter()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 90 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Question: I see that we don't import SQLPS module before running these cmdlets. Should we?
If not, maybe the 'Import-SQLPSModule' is not needed in the Helper module?

It is required. This is fixed.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 117 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add the parameter Ensure to the comment-based help

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 120 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add what the default value is to the description of this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 140 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Paramater()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 143 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Paramater()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 146 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add [Paramater()] attribut to the this parameter.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 5 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add a description to Ensure parameter too.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
I think we should make this parameter SQLInstanceName as a Key to. Otherwise you can not set two instances on the same node?
This will be a breaking change. But good if we do this now, because we have a lot of other breaking changes already for the next release.

I concur. Done.

en-US/xSQLServer.strings.psd1, line 41 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We use ' around {} for the other strings, should we keep doing the same or does it not work in this string?
Also, if I read the code correctly, this string would become for example Failed to Present AlwaysOn on the instance MSSQLSERVER.  Could we make it a bit better? :smile:

I forgot to update this from an earlier version. The error should now read Failed to enure AlwaysOn is Present on the instance 'MSSQLSERVER'
I didn't include quotes around the absent/present portion because it didn't make sense to me in the flow of the sentence.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 18 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you rename this parameter to  $absentState?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 25 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you rename this parameter to  $presentState?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 32 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you rename this parameter to  $presentStateNamedInstance?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 46 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you start all the context blocks description with 'When...'? Like 'When the system is not in desired state'?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 49 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You could just return the object directly? Same for the rest of the mocks

Done.

DSCResource.Tests, line 1 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you please make sure this is not part of the PR. Delete this from your working branch, commit and push the change. After that make sure you got a .gitignore file in the root of your working branch which contains 'DSCResource.Tests'.
This file is generated automatically when `Invoke-Pester' is ran.
I wouldn't mind if we committed a .gitignore to this repo so this won't happen for others.

Done.

Comments from Reviewable

Review status: 2 of 10 files reviewed at latest revision, 50 unresolved discussions.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 59 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
See below. This would be 'Should return the state as $false'

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 81 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
See below. This would be 'Should return the state as $true'

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 95 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please load the SQLPS stubs for mocking these. So the tests can be run on a client without SQLPS installed. See below how to import SQLPSStub.psm1 for this.
https://github.com/PowerShell/xSQLServer/blob/dev/Tests/Unit/MSFT_xSQLServerAvailabilityGroupListener.Tests.ps1#L41
That line in that resource tests I linked to does not comply with style guideline, so when you add the line, please make sure you replace any '\' with Join-Path/Split-Path the same way you used for the path to import the helper module.

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 118 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add an Assert for Disable-SqlAlwaysOn that it should be called -Times 0

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 134 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add an Assert for Enable-SqlAlwaysOn that it should be called -Times 0

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 138 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You should not also test to disable for a named instance?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 150 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add an Assert for Disabled-SqlAlwaysOn that it should be called -Times 0

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 154 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please change this description to something like 'Should throw the correct error message....'
Should you test this throwing for both 'Present' and 'Absent'?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 166 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add an Assert for Disabled-SqlAlwaysOn that it should be called -Times 0

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 189 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please align this description with the one above. 'to return true when...'

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 197 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please add a new line at the end of the file.

Done.

Comments from Reviewable

Review status: 1 of 11 files reviewed at latest revision, 50 unresolved discussions.

DSCResources/MSFT_xSQLServerConfiguration/MSFT_xSQLServerConfiguration.psm1, line 233 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This is a newer version you are removing than you are adding. This one uses "CIM-methods", the one you are adding uses "WMI-methods".
Please do a rebase (do not use merge or pull) of your fork (dev) and your working branch. See the following https://github.com/johlju/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts
Make sure the tests is up to date also.

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 44 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You don't need to mock New-VerboseMessage. You can remove all of the New-VerboseMessage mocks  if you want. If you remove this you should get more code coverage.
It will output verbose messages in the output when running tests, but it is okay. We will change this New-VerboseMessage to Write-Verbose in the future when we align the localization with the HQRM standard. It is another issue.

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 60 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please do two tests of this, either two It-blocks (create the Mock in each It-block) or two context-blocks. One that tests for not in desired state for 'Absent' and another that tests for not in desired state for 'Present'
Also please test for one expected value only, like Should Not Be $true, or better Should Be $false.

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 82 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please do two tests of this, either two It-blocks or two context-blocks. One that tests for in desired state for 'Absent' and another that tests for in desired state for 'Present'
Also please test for one expected value only, like Should Be $true.

Done.

Tests/Unit/xSQLServerHelper.Tests.ps1, line 221 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You are missing a Restore-TestEnvironment -TestEnvironment $TestEnvironment here I beleive? Please align with the unit test template.

The Restore-TestEnvironment function was intentionally left out as the test environment cannot be used when testing functions. The test environment is built expecting a DSC module.

Comments from Reviewable

Review status: 1 of 11 files reviewed at latest revision, 50 unresolved discussions.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
I concur. Done.

The AppVeyor tests failed when I set the SqlInstanceName to be a key because the parameter is not required in the Get/Set/Test functions. I'm not sure I want to require people to enter the instance name if they're using a default instance, but I could be persuaded.

Comments from Reviewable

@johlju It looks like I got everything fixed according to AppVeyor. Let me know if you see anything else in the code that should be updated.

@randomnote1 You got changes in CONTRIBUTING.md in this PR that are already merged to dev. Please rebase your working branch against dev and force push your working branch. Don't use merge or pull!
Please see this on how to do this:
https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

Sorry about that. I'm still learning GIT, and apparently I didn't do my previous rebase correctly. I think I got it this time.

No worries. We have all been there. I'm still learning still :smile:

Reviewed 1 of 5 files at r3, 2 of 7 files at r4.
Review status: 4 of 12 files reviewed at latest revision, 48 unresolved discussions.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
The AppVeyor tests failed when I set the SqlInstanceName to be a key because the parameter is not required in the Get/Set/Test functions. I'm not sure I want to require people to enter the instance name if they're using a default instance, but I could be persuaded.

Yes, you have to add it as mandatory parameter in all methods and remove the default value, and remove the 'default' part from allthe descriptions as well (schema, readme.md and comment-based help).
If you don't, then if you do this in the configuration file
        xSQLServerAlwaysOnService 'AlwaysOnInstance1'
        {
            Ensure = 'Present'
            SQLServer = $Node.NodeName
            SQLInstanceName = 'Instance1'
            RestartTimeout = 120
        }

        xSQLServerAlwaysOnService 'AlwaysOnInstance2'
        {
            Ensure = 'Present'
            SQLServer = $Node.NodeName
            SQLInstanceName = 'Instance2'
            RestartTimeout = 120
        }

You will get this error
Test-ConflictingResources : A conflict was detected between resources '[xSQLServerAlwaysOnService]AlwaysOnInstance1 (E:\DSC\DSC-SQLTestConfig.ps1::288::9::xSQLServerAlwaysOnService)' and '[xS
QLServerAlwaysOnService]AlwaysOnInstance2 (E:\DSC\DSC-SQLTestConfig.ps1::296::9::xSQLServerAlwaysOnService)' in node 'sqltest.company.local'. Resources have identical key properties but there are
differences in the following non-key properties: 'SQLInstanceName'. Values 'Instance1' don't match values 'Instance2'. Please update these property values so that they are identical in both c
ases.

Comments from Reviewable

Awesome work! Just a few more comments.

Reviewed 1 of 9 files at r2, 2 of 5 files at r3, 4 of 7 files at r4, 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 17 unresolved discussions.

README.md, line 310 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Done.

If the change is done in schema.mof this has to change too.

xSQLServerHelper.psm1, line 1228 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Done.

Can't see this has been done yet. Please look at this again.

xSQLServerHelper.psm1, line 1231 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Done.

Can't see this has been done yet. Please look at this again.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 14 at r6 (raw file):

    .PARAMETER SQLServer
    Hostname of the SQL Server to be configured. Default is the current $env:COMPUTERNAME

My bad, it's a mandatory parameter. It should not have a default value. I missed it in the review, but you solved it on your own! :smile:
Please remove the 'Default' part from the description since it is no longer true.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 58 at r6 (raw file):

    .PARAMETER SQLServer
    Hostname of the SQL Server to be configured. Default is the current $env:COMPUTERNAME

Please remove the 'Default' part from the description since it is no longer true.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 134 at r6 (raw file):

    .PARAMETER Ensure
    *** Not used in this function ***

It is used to call Get-method?

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 138 at r6 (raw file):

    .PARAMETER SQLServer
    Hostname of the SQL Server to be configured. Default is the current $env:COMPUTERNAME

Please remove the 'Default' part from the description since it is no longer true.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 171 at r6 (raw file):

    )

    # Determine the current state of Alway On

Typo here 'Always On'.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 119 at r6 (raw file):

        Mock -CommandName Restart-SqlService -MockWith {} -ModuleName $script:DSCResourceName -Verifiable

        Context 'Change the system to the desired state' {

Please change this and any other context block to start with 'When...'

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 121 at r6 (raw file):

        Context 'Change the system to the desired state' {

            It 'Should enable SQL Always On when Ensure is Present' {

Should be "... is set to 'Present'"

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 136 at r6 (raw file):

            }

            It 'Should disable SQL Always On when Ensure is Absent' {

Should be "... is set to 'Absent'"

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 151 at r6 (raw file):

            }

            It 'Should enable SQL Always On on a named instance when Ensure is Present' {

Should be "... is set to 'Present'"

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 166 at r6 (raw file):

            }

            It 'Should disable SQL Always On on a named instance when Ensure is Absent' {

Should be "... is set to 'Absent'"

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 181 at r6 (raw file):

            }

            It 'Should throw the correct error message when Ensure is Present, but IsHadrEnabled is $false' {

Should be "... is set to 'Present'"

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 197 at r6 (raw file):

            }

            It 'Should throw the correct error message when Ensure is Absent, but IsHadrEnabled is $true' {

Change to "...is set to 'Absent'"

Tests/Unit/xSQLServerHelper.Tests.ps1, line 221 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
The Restore-TestEnvironment function was intentionally left out as the test environment cannot be used when testing functions. The test environment is built expecting a DSC module.

Ah! My bad. :smile: Then we could just remove the empty finally-block.

Comments from Reviewable

Review status: 6 of 12 files reviewed at latest revision, 17 unresolved discussions.

README.md, line 310 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
If the change is done in schema.mof this has to change too.

Done.

xSQLServerHelper.psm1, line 1228 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Can't see this has been done yet. Please look at this again.

Done.

xSQLServerHelper.psm1, line 1231 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Can't see this has been done yet. Please look at this again.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 14 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
My bad, it's a mandatory parameter. It should not have a default value. I missed it in the review, but you solved it on your own! :smile:
Please remove the 'Default' part from the description since it is no longer true.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 58 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please remove the 'Default' part from the description since it is no longer true.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 134 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
It is used to call Get-method?

Not anymore. It was being passed in to get method when I passed in @PSBoundParameters.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 138 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please remove the 'Default' part from the description since it is no longer true.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 171 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Typo here 'Always On'.

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Yes, you have to add it as mandatory parameter in all methods and remove the default value, and remove the 'default' part from allthe descriptions as well (schema, readme.md and comment-based help).
If you don't, then if you do this in the configuration file
        xSQLServerAlwaysOnService 'AlwaysOnInstance1'
        {
            Ensure = 'Present'
            SQLServer = $Node.NodeName
            SQLInstanceName = 'Instance1'
            RestartTimeout = 120
        }

        xSQLServerAlwaysOnService 'AlwaysOnInstance2'
        {
            Ensure = 'Present'
            SQLServer = $Node.NodeName
            SQLInstanceName = 'Instance2'
            RestartTimeout = 120
        }

You will get this error
Test-ConflictingResources : A conflict was detected between resources '[xSQLServerAlwaysOnService]AlwaysOnInstance1 (E:\DSC\DSC-SQLTestConfig.ps1::288::9::xSQLServerAlwaysOnService)' and '[xS
QLServerAlwaysOnService]AlwaysOnInstance2 (E:\DSC\DSC-SQLTestConfig.ps1::296::9::xSQLServerAlwaysOnService)' in node 'sqltest.company.local'. Resources have identical key properties but there are
differences in the following non-key properties: 'SQLInstanceName'. Values 'Instance1' don't match values 'Instance2'. Please update these property values so that they are identical in both c
ases.

Changed the SQLInstanceName to a mandatory parameter for the get/set/test functions and updated the schema.mof and README.md

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 119 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please change this and any other context block to start with 'When...'

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 121 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should be "... is set to 'Present'"

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 136 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should be "... is set to 'Absent'"

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 151 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should be "... is set to 'Present'"

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 166 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should be "... is set to 'Absent'"

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 181 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should be "... is set to 'Present'"

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 197 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to "...is set to 'Absent'"

Done.

Tests/Unit/xSQLServerHelper.Tests.ps1, line 221 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Ah! My bad. :smile: Then we could just remove the empty finally-block.

Done.

Comments from Reviewable

Reviewed 6 of 6 files at r7.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

README.md, line 309 at r7 (raw file):

* **Ensure**: (Required) An enumerated value that describes if SQL server should have AlwaysOn property present or absent.
* **SQLServer**: (Key) The hostname of the SQL Server to be configured
* **SQLInstance**: (Key) Name of the SQL instance to be configured. Default is 'MSSQLSERVER'

Please remove 'Default...' from the description

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 134 at r6 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Not anymore. It was being passed in to get method when I passed in @PSBoundParameters.

But you are still passing it in the hashtable assigned to $params

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r7 (raw file):

    [Required, Description("HADR is Present (enabled) or Absent (disabled)"), ValueMap{"Present","Absent"}, Values{"Present","Absent"}] String Ensure;
    [Key, Description("The hostname of the SQL Server to be configured")] String SQLServer;
    [Key, Description("Name of the SQL instance to be configured. Default is 'MSSQLSERVER'")] String SQLInstanceName;

Please remove 'Default...' from the description

Comments from Reviewable

Question. There are 203 commits here. You are making a commit for each change. Would it bring any value to the log history after merge? Or could we squash all these together before we merge?
Asking, because I would want to ask to squash these if there actually a benefit to keeping the commits so detailed.

Feel free to squash the changes in the merge. I'll make a note of that for my future reviews.

Review status: all files reviewed at latest revision, 3 unresolved discussions.

README.md, line 309 at r7 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please remove 'Default...' from the description

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 134 at r6 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
But you are still passing it in the hashtable assigned to $params

You're right. I was looking at the "RestartTimeout" parameter. My Bad!

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 7 at r7 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please remove 'Default...' from the description

Done.

Comments from Reviewable

Review status: 9 of 12 files reviewed at latest revision, 3 unresolved discussions.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 134 at r6 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
You're right. I was looking at the "RestartTimeout" parameter. My Bad!

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r8, 2 of 2 files at r9.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

I missed a few things. Please change the PR title to start with 'BREAKING CHANGE: ' plus add to the description that mandatory parameters is changed.

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

CHANGELOG.md, line 35 at r9 (raw file):

  - Enhanced so the same user can now be added to more than one role
- BREAKING CHANGE: Renamed xSQLAlias to xSQLServerAlias to align wíth naming convention.
- Changes to xSQLServerAlwaysOnService

We need to add a description that the mandatory parameters has changed and why they are changed. Please start the description with 'BREAKING CHANGE: '

Comments from Reviewable

Review status: 11 of 12 files reviewed at latest revision, 1 unresolved discussion.

CHANGELOG.md, line 35 at r9 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We need to add a description that the mandatory parameters has changed and why they are changed. Please start the description with 'BREAKING CHANGE: '

Done.

Comments from Reviewable

On the Nov 30 there is a commit from me in your commit history. I would like if you could try to get rid of it. Please see https://github.com/PowerShell/xSQLServer/pull/234/commits and scroll to Nov 30.
try to do a git rebase again.
git checkout dev
git fetch origin dev #origin is the remote to PowerShell/xSQLServer
git rebase origin/dev
git push my dev --force # my is the remote to your fork of xSQLServer

git checkout working-branch
git rebase my/dev # my is the remote to your fork of xSQLServer
git push my working-branch --force # my is the remote to your fork of xSQLServer

If that doesn't work, then instead of git rebase my/dev do git rebase -i my/dev for interactive rebase.
This will open up the vi editor. Press 'i' or the insert-key for Insert mode. On the row for the commit that should be removed, instead of the word 'pick' write 'drop' (or 'd' for short), this will drop the commit. Make sure you pick the right one, because there is no second chance (you could backup the entire cloned repo folder somewhere else just in case).
Press Esc-key to exit insert mode, then type :wq so the file is save and the rebase continues.
After that you can do force push git push my working-branch --force and the commit should be gone.

Thanks for adding the prefix BREAKING CHANGE to the PR title. Could we also also add to the PR title that the mandatory parameters has changed (which is the breaking change)? Just a summary if it is possible. It would be good if the entire title isn't longer than 70 chars.

Reviewed 1 of 1 files at r10.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

CHANGELOG.md, line 36 at r10 (raw file):

- BREAKING CHANGE: Renamed xSQLAlias to xSQLServerAlias to align wíth naming convention.
- BREAKING CHANGE: Changes to xSQLServerAlwaysOnService
  - Changed the mandatory parameters to include Ensure, SQLServer, and SQLInstanceName. SQLServer and SQLInstanceName are keys which will be used to uniquely identify the resource which allows AlwaysOn to be enabled on multiple instances on the same machine.

Please move 'BREAKING CHANGE:' above to this new row here. This is the only breaking change.

Comments from Reviewable

When the last changes are done I think we can merge this one 😄  Awesome work!

Attempted changing the title. Let me know what you think. 70 chars is not a lot of room!
Please take a quick look over the code again. the rebase got kinda messy.

Review status: 3 of 11 files reviewed at latest revision, 2 unresolved discussions.

CHANGELOG.md, line 36 at r10 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please move 'BREAKING CHANGE:' above to this new row here. This is the only breaking change.

Done.

Comments from Reviewable

Title looks fine! I will use the text in the change log when i squash the commits, so it will be clear what was changed.  Just that the first row of the commit message seems to wrap (be cut) if it is over 70 chars.
Just a few more comments for stuff that was changed back in the rebase.

Reviewed 4 of 7 files at r11, 4 of 4 files at r12.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

CHANGELOG.md, line 36 at r10 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Done.

I'm sorry. I'm not clear enough. It's hard sometimes to get what you suggest in text :wink:
What I was looking for was something like this

Changes to xSQLServerAlwaysOnService

Added RestartTimeout parameter
Fixed bug where the SQL Agent service did not get restarted after the IsHadrEnabled property was set.
BREAKING CHANGE: To xSQLServerAlwaysOnService; the mandatory parameters to include Ensure, SQLServer, and SQLInstanceName. SQLServer and SQLInstanceName are keys which will be used to uniquely identify the resource which allows AlwaysOn to be enabled on multiple instances on the same machine.

Could you be so kind to do this?

xSQLServerHelper.psm1, line 1211 at r12 (raw file):

    .EXAMPLE
    Restart-SqlService -SQLServer localhost

Previously you had $env:COMPUTERNAME here. But it is okay to leave it as localhost as well. Do want you want. :)

xSQLServerHelper.psm1, line 1228 at r12 (raw file):

        $SQLServer,

        [String]

[Parameter()] is gone from this

xSQLServerHelper.psm1, line 1231 at r12 (raw file):

        $SQLInstanceName = 'MSSQLSERVER',

        [Int32]

[Parameter()] is gone from this

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 9 at r12 (raw file):

    Gets the current value of the SQL Server HADR property.

    .PARAMETER Ensure

This no longer has the text *** Not used in this function ***

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 1 at r12 (raw file):

Seems you added a new line at the beginning of this file. Could we remove it?

Comments from Reviewable

Review status: all files reviewed at latest revision, 7 unresolved discussions.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 106 at r12 (raw file):

    }

    Describe "$($script:DSCResourceName)\Set-TargetResource" {

I looked thru the output from the tests and I saw that you get a lot of these in the tests.
Could not obtain SQL Server Service information. An attempt to connect to WMI on 'Microsoft.WindowsAzure.Commands.SqlDatabase.Types.ps1xml' failed with the following error: The RPC server is unavailable. (Exception from HRESULT: 0x800706BA)

https://ci.appveyor.com/project/PowerShell/xsqlserver/build/3.0.584.0#L809
You need to mock Import-SQLPSModule as well.

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 119 at r12 (raw file):

        Mock -CommandName Restart-SqlService -MockWith {} -ModuleName $script:DSCResourceName -Verifiable

        Mock -CommandName Enable-SqlAlwaysOn -MockWith {} -ModuleName $script:DSCResourceName

You are mocking the same cmdlet twice here.

Comments from Reviewable

Thanks! I think I got everything squared away.

Review status: 6 of 11 files reviewed at latest revision, 8 unresolved discussions.

CHANGELOG.md, line 36 at r10 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
I'm sorry. I'm not clear enough. It's hard sometimes to get what you suggest in text :wink:
What I was looking for was something like this

Changes to xSQLServerAlwaysOnService

Added RestartTimeout parameter
Fixed bug where the SQL Agent service did not get restarted after the IsHadrEnabled property was set.
BREAKING CHANGE: To xSQLServerAlwaysOnService; the mandatory parameters to include Ensure, SQLServer, and SQLInstanceName. SQLServer and SQLInstanceName are keys which will be used to uniquely identify the resource which allows AlwaysOn to be enabled on multiple instances on the same machine.

Could you be so kind to do this?

Done.

xSQLServerHelper.psm1, line 1228 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
[Parameter()] is gone from this

Done.

xSQLServerHelper.psm1, line 1231 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
[Parameter()] is gone from this

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.psm1, line 9 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This no longer has the text *** Not used in this function ***

Done.

DSCResources/MSFT_xSQLServerAlwaysOnService/MSFT_xSQLServerAlwaysOnService.schema.mof, line 1 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Seems you added a new line at the beginning of this file. Could we remove it?

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 106 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
I looked thru the output from the tests and I saw that you get a lot of these in the tests.
Could not obtain SQL Server Service information. An attempt to connect to WMI on 'Microsoft.WindowsAzure.Commands.SqlDatabase.Types.ps1xml' failed with the following error: The RPC server is unavailable. (Exception from HRESULT: 0x800706BA)

https://ci.appveyor.com/project/PowerShell/xsqlserver/build/3.0.584.0#L809
You need to mock Import-SQLPSModule as well.

Done.

Tests/Unit/MSFT_xSQLServerAlwaysOnService.Tests.ps1, line 119 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You are mocking the same cmdlet twice here.

Done.

Comments from Reviewable

Review status: 6 of 11 files reviewed at latest revision, 8 unresolved discussions.

xSQLServerHelper.psm1, line 1211 at r12 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Previously you had $env:COMPUTERNAME here. But it is okay to leave it as localhost as well. Do want you want. :)

Done.

Comments from Reviewable

Reviewed 5 of 5 files at r13.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add codeship ci support

Add support for running tests on Codeship

merging without review because it's only an external .codeship directory


Create a test directory structure and unit test service that can run off-environment

Summary
As many of our developers are working with different environments, we need a way to test our kernel libraries in a hardware independent environment. This involves creating a configuration option that allows switching between hardware dependent and hardware independent libraries, such as stdio. It also involves creating a separate linker script and Makefile target so that compilation produces an executable rather than an image file.
Tasks

[ ] Add a configuration option that allows a hardware independent/hardware dependent toggle (in this case, a macro variables that will be selected for at compile time. You should not give it a value in any file. You can check config.h for more information)
[ ] Create test harnesses that replace hardware dependent libraries with hardware independent libraries (this involves using C macros in files such asstdlib/stdio.c to replace the implementations of the functions with ones from the standard C library glibc)
[ ] Create a tests directory in the toplevel of the repo
[ ] Create a testing library to create and run unit tests (take a look at https://github.com/jakejack13/jip for more information)
[ ] Create an initialization file/function in the test library that replaces the symbols in the regular linking script with ones that can be used hardware independently
[ ] Create a test linker script to generate an executable (main linker script is link.ld)
[ ] Add test targets to the Makefile to generate an executable (make test)

im still going to use print statements 😎

better late than never when it comes to unit testing


Certificate-based Authentication

I'm attempting to set up kubegres with certificate-based authentication, replacing password-based authentication entirely using the cert auth-method [1] [2] That is, I want my pg_hba.conf to look something like this:
hostssl    all             all             all                     cert clientcert=1

Much of the issues that must be overcome to accomplish this are similar to the issues described in #81. However, using the cert auth method for the replication role is forbidden in practice because the spec requires that we have POSTGRES_PASSWORD and POSTGRES_REPLICATION_PASSWORD environment variables set [3], and the replication role is created with a password in a the non-overridable primary_create_replication_role.sh script [4].
The POSTGRES_PASSWORD variable is understandable as it is required by the base image to be non-empty, so I understand you have a requirement for that; an acceptable tradeoff for me is to modify that account after initialization. The replication user, on the other hand, poses a concern for me that I'm not sure how best to overcome.
1: https://www.postgresql.org/docs/current/auth-pg-hba-conf.html
2: https://www.postgresql.org/docs/current/auth-cert.html
3: https://github.com/reactive-tech/kubegres/blob/5c49a73c00e4594f3cf9b092d20b404447ace447/controllers/spec/checker/SpecChecker.go#L140-L148
4: https://github.com/reactive-tech/kubegres/blob/7d751febe0847389ce001dea203ee890556bca77/controllers/spec/template/yaml/BaseConfigMapTemplate.yaml#L172-L185

I've worked through this problem and gotten a working solution. It's not "clean" and requires manual changes, but I can now identify two distinct subtasks that will allow this to be completed with the standard tooling, so I am closing this ticket to create two precisely-targeted tickets for those specific changes.


Fix for running on Windows.

Checked on Windows by @RichardSmithONS. Checked on Mac by @spdiaz1000.


Add new database tables and the associated operations for profile selectors

Table would look somewhat like this:
CREATE TABLE IF NOT EXISTS profile_selectors (
  id UUID NOT NULL DEFAULT gen_random_uuid() PRIMARY KEY,
  profile_id UUID NOT NULL REFERENCES profiles(id) ON DELETE CASCADE,
  entity entities, -- this is nullable since it can be applicable to all
  selector TEXT NOT NULL, -- CEL expression
  comment TEXT NOT NULL, -- optional comment (can be empty string)
);

-- Ensure we have performant search based on profile_id
CREATE INDEX idx_profile_selectors_on_profile ON profile_selectors(profile_id);


Refaster: support method invocation type argument inlining

The test shows exactly what is now supported.

Within de Picnic codebase we found more situations where "losing" type arguments during a rewrite can lead to non-compilable code. In the example below the explicit type arguments in ImmutableMap.<K, V>builder() currently don't have any effect, as Refaster currently does not support inlining such type arguments for method invocations.
static final class ImmutableMapBuilder<K, V> {
  @BeforeTemplate
  ImmutableMap.Builder<K, V> before() {
    return new ImmutableMap.Builder<>();
  }

  @AfterTemplate
  ImmutableMap.Builder<K, V> after() {
    return ImmutableMap.<K, V>builder();
  }
}

The changes in this PR resolve this issue.
If desired we can update the test in this PR to use the above example instead of the existing ExecutorService#submit example. @cushon if any other changes are required let us know :).

Rebased and squashed the two commits, as I'll cherry-pick the changes of this PR to our fork. That said: still interested in seeing this included in mainline Error Prone :upside_down_face:.

Rebased. Still curious, could this change still get into mainline Error Prone 😄?

Rebased. Is it possible to get this change into mainline Error Prone :smile:?

Rebased.

Oh nice, good to hear! 😄
I added a commit to update the year numbers in the license headers and rebased the PR.


Exception handling fails if message is an array

Under some circumstances the API returns an error with an array of messages (even if the documentation says it's always a string).
array:4 [
  "message" => array:1 [
    0 => "Invalid schema for function 'domains': In context=('properties', 'domains'), array schema missing items"
  ]
  "type" => "invalid_request_error"
  "param" => null
  "code" => null
]

Yep, same here.
This needs to be fixed in:
https://github.com/openai-php/client/blob/67937756931af848c03112e52706aa6ad175aa7a/src/Exceptions/ErrorException.php#L18
Should be replaced by:
parent::__construct(json_encode($contents['message']));


is 'Higher Order Functions' as the same as 'javascript closure'?

In 6.2 Higher Order Functions, could you tell the difference compare to javascript closure?
For me this so called 'Higher order functions' is exactly how I understand 'closure'. If I'm right, please add 'this is what other people called closure' at the end of this section. It surely will clarify the misunderstanding.
@SamyPesse @AaronO Thank you

In JS, Higher Order Functions are also known as Callbacks. Concept of closures is different.

Higher Order Functions are functions that either takes function as an argument or returns function and closure is a different concept. so what is closure ? -- closure is a power of inner function where it is able to access variables from outer function even after the outer function is returned.


Remove full focus node from BoolField

Remove full focus node from BoolField

Fixed at Version 0.4.5


thai2vec v0.2

Change word embeddings for word_vector
Add ULMFit utility functions to be used with fastai

Coverage decreased (-3.6%) to 55.819% when pulling 61de6b51e9f7d0f447c73e9c9858f450a2073926 on cstorm125:dev into dc8c405659933d38ee8cc400a07ab63be3463db8 on PyThaiNLP:dev.

Coverage decreased (-3.6%) to 55.819% when pulling 61de6b51e9f7d0f447c73e9c9858f450a2073926 on cstorm125:dev into dc8c405659933d38ee8cc400a07ab63be3463db8 on PyThaiNLP:dev.


Fixed versionable behavior

Issue #774
Fix versionable behavior when exists 2 connected tables, versionable behavior in both tables and parameter version_column is changed.

Fix versionable when exists custom field on table with FK
Implementing tests

Perfect, thanks!


Update platform scripts so that the BASH_LOCATION works on Mac as well

Relevant components:

[ ] Signalling server
[ ] Frontend library
[ ] Frontend UI library
[ ] Matchmaker
[X] Platform scripts
[ ] SFU

Problem statement:
The logic for detecting the script location is only suitable for bash. This PR makes the logic work on both bash and zsh.
Test Plan and Compatibility
Tested script execution on Mac and Linux

If this is already in master it will get merged into 5.4 when we next sync it.


Offload SIL licensed font from iced_wgpu to a dedicated crate

SIL licensed Lato font is embedded in iced_wgpu, so the crate is licensed under MIT AND OFL.
It prevents GPL licensed applications from using iced, since GPL and SIL are incompatible when the font is embedded in the application binary.
If the font was offloaded to a dedicated crate and the font embedding was optional feature in iced_wgpu, the problem would be resolved.

iced_graphics has a feature font-fallback, which can be disabled to prevente the Lato font from being embedded in the final binary. We should probably propagate this feature to both iced_wgpu and iced_glow.
I am also open to using another, more license-friendly fallback font. Any suggestions welcome!

I'm happy to hear that. I was referenced to the latest release version. I'm looking forward to the next release! Thank you.

I closed this issue without considering well..
Should this issue be kept open until fully resolved?

Bootstrap published their own icon set a few month ago. It is licenced under MIT licence and the usage is not limited to projects using Bootstrap. This could replace the current icon font which is licenced under SIL.


HELP in using gmodlab

it will be great..
if you could spare a min.
to share HOW to use it...

Upper text area is for transmitted text or executed script, lower - received text.
For help read tooltips.
Left comboboxes select input/output filter, next is syntax highlighting mode, etc...

Directiries scripts and scripts-user contain various filters and user scripts

Thanks alot buddy.. for sharing your inputs..
usage is ok for me..
the problem i am having is, i am not able to run those scripts. (making them work)
so it would be so helpful, if you could pls, share how to run those scripts form sctrach, as i am not sure whether i need to install Javascript, (though i googled and installed node.js) and tried to run these scripts in browser also as have internal JScript interpretor.
[ i am having
java -version
java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b15)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)

scripts are run automatically on start, by internal JS engine http://www.oracle.com/technetwork/articles/java/jf14-nashorn-2126515.html
For script-related code look in gmodlab/Js.scala and gmodlab/Tab.scala


Typo fix

Fixing the typo. Should be create-react-app, not a create react-app

This is not a typo. yarn create is a valid command.

@iansu wow. TIL!

All good. Glad I could help you learn something new.