!play Youtube Playlist error

Please tick all applicable boxes.

[x] I am using Python 3.5 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[x] The latest master version (1.9.8)
[ ] The latest review version

What type of issue are you creating?

[x] Bug
[ ] Feature request
[x] Question

Description of issue
After many months without using my bot, i've tried to reuse it. I've reinstall all for it (Python, Git and the bot). After replacing all the configurations, i've start it and try to add a Youtube playlist : !play https://www.youtube.com/playlist?list=PLjK-NMwQ4FptN6Zca5IW1yCSJiMCePpmC [Enter] and the bot gave me that error: You don't have the permission to play media from this service. I can add an url of an individual youtube video, but not a playlist. What did i miss?
P.S.: I am the owner and i've set the owner id to mine (!id).
Steps to reproduce

!play [any Youtube Playlist url]

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
musicbot.log

In permissions ads youtube:playlist u probably added yourself to a permission group

Thanks, that fix it. I don't know how i put myself anywhere, but that works.

If that happens again, add yourself to the Music Masters group & everything will work as it should. :)


Can't open a pickled file

In short, tested on MacOS w/ python2.7 and 3.4, on Linux w/ python 2.7, and can't open it.
When I tried to open this: /data/model_deep_aug/fold00_weights.pkl I got...
UnpicklingError: invalid load key, 'H'.

$ python3
Python 3.4.2 (v3.4.2:ab2c023a9432, Oct  5 2014, 20:42:22)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import pickle
>>> a = pickle.load(open('fold00_weights.pkl', 'rb'))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_pickle.UnpicklingError: invalid load key, 'H'.

Seems like there are many reasons that cause this problem. I tried few random solutions which didn't work. Do you have any idea?

I think the problem is that it's actually an h5 file with a .pkl extension.

Ohh.. gotcha, it is. Thanks.

Sorry about that!


Add fluid states for form components

This issue is an epic for fluid state!
Majority of the form components have experimental support for fluid states. The following components need to be converted to fluid state.
### Tasks
- [ ] Combobox
- [ ] Date picker
- [ ] Dropdown
- [ ] Number Input
- [ ] Search
- [ ] Select
- [ ] Text Area
- [ ] Text Input/Password

ref: https://github.com/carbon-design-system/carbon-components-angular/issues/2710

Hello @Akshat55, It this still open? I happy to help in this task.

Absolutely! Which component would you like me to assign you too? I prefer you approach this task one component at a time since fluid states are experimental for the time being.

hey @Akshat55, Assign me small one first :)

Assigned you to NumberInput @kush-savani.


Godot crashes or hangs very frequently when trying to bake lightmaps

Godot version:
3.3.1-stable
OS/device including version:
Windows 10, GeForce RTX2070 MaxQ, i7-10875h @ 2.3Ghz
Issue description:
Godot frequently crashes or hangs when trying to bake lightmaps. When it crashes it just closes the engine and doesn't print anything to the terminal, when it hangs it's always at "Preparing data structures". The scene I'm running is fairly straightforward (the scene I was trying this on at the start is very complex but I started deleting stuff to see if complexity was the issue) with just 4 meshes all marked to be used in baked lighting and with UV2s generated by Godot. I've tried to wait for a long time but the program never continues, it just stays at that state taking up 100% of the CPU.

Weirdly, I got it to a point where if I remove the "use in baked light" checkbox from one of the meshes it almost always works and gets past the "Preparing data structures" stage almost instantly, but if I set the mesh to be used again it always hangs of crashes.

Here are my settings for the baked lightmap:

Steps to reproduce:
I just run created a baked lightmap node, made it envelop my scene and set the settings as the screenshot above and try to run it on this simple scene with 4 meshes. The result is it almost always hangs or crashes.
I don't know if this is a regression or not as I had never used baked lightmaps before this, but it is certainly very annoying as I was hoping to use them to optimize the lighting in my fairly large scene.

Please post here minimal project, to be sure that we test same scene which crashes for you.

Godot version:
3.3.1-stable

OS/device including version:
Windows 10, GeForce 1080 i7-3770k@ 3.5Ghz

Switch with the last release, i'm get the issue.
On Windows 10, i'm porte my previous project and get a crash or a freeze to "Prepare data" step.
Try on a desktop computer and a laptop, W10 build 19042.985.
Try with a new Lightmap node and same way. Crash and freeze.
Try a new project with a simple asset import and a node Bake, get a freeze and crash.
Try this project on a linux OS and no crash or issue. (Linux Manjaro -- Intel® Core™ i7-4790K CPU @ 4.00GHz × 8 -- GeForce GTX 1070/PCIe/SSE2)
What i can do to give more debug information ?

@akien-mga looks like we may have re-introduced #45097 with the switch to embree-aarch64?
I will work on switching back to the latest Embree to see if that helps.
@jocamar @stilobique Can you try running on 3.3-stable and see if that works better? It would help us narrow down if it was a regression or a previously unnoticed bug.

[...]
@jocamar @stilobique Can you try running on 3.3-stable and see if that works better? It would help us narrow down if it was a regression or a previously unnoticed bug.

Yes, it's work perfectly for me with this package.

@akien-mga looks like we may have re-introduced #45097 with the switch to embree-aarch64?

Damn :| That's why I also require that we have patch files that fully describe the changes we made to upstream code to make sure we reapply them on update.
This change was lost in the embree-aarch64 update:
https://github.com/godotengine/godot/pull/45380/files#diff-9a5a19d82fa76b17207468d6bfe5f1edd1436ff39c2dea7df240b26d109f6c38R94

@stilobique  Cool, thanks for testing! That means something broke during our switch to embree-aarch64.
@akien-mga From what I see some of our fixes to Embree were not tracked in the patches file, so they got lost during the refactor. I'm working on upgrading to the latest Embree but this time making sure to create a full diff and keep all the fixes.

@jocamar @stilobique Could you test either of those binaries to see if they solve the issue?
https://downloads.tuxfamily.org/godotengine/testing/Godot_v3.3.1-stable_win64.exe-fix48822.zip
https://downloads.tuxfamily.org/godotengine/testing/Godot_v3.3.1-stable_win32.exe-fix48822.zip
They're built from 3.3.1-stable + this hotfix:
diff --git a/thirdparty/embree/common/sys/platform.h b/thirdparty/embree/common/sys/platform.h
index 737f14aa6e..e3be41a27a 100644
--- a/thirdparty/embree/common/sys/platform.h
+++ b/thirdparty/embree/common/sys/platform.h
@@ -91,7 +91,7 @@
 #define dll_import
 #endif

-#ifdef __WIN32__
+#if defined(__WIN32__) && !defined(__MINGW32__)
 #if !defined(__noinline)
 #define __noinline             __declspec(noinline)
 #endif

It only affects the editor build, so if that works, feel free to use those binaries together with the official 3.3.1-stable export templates, they should work fine.

That build seems to work, or at least it no longer crashed or hanged and is in the process of baking the shadows for my larger scene. I did get some slowdowns when navigating the scene before I begun baking the shadows, but that could just be my impression or that it's a debug build or something. Regardless the main problem seems fixed.

The slowdown is likely something that would be reproducible in the first 3.3.1-stable builds, the only difference between the original builds and the ones I linked above is that fix for the MinGW crash: https://github.com/godotengine/godot/issues/48822#issuecomment-844051126

I made a test build for all platforms of #48967 which upgrades Embree to 3.13.0, and should also solve this issue: https://github.com/godotengine/godot/pull/48967#issuecomment-846435705
If anyone affected by this issue could give it a try to confirm that it works properly, that would be great :)

For users affected by this issue who need a hotfix, I promoted my test builds as an official fix, uploaded here:
https://downloads.tuxfamily.org/godotengine/3.3.1/Godot_v3.3.1-stable_win64.exe-fix48822.zip
https://downloads.tuxfamily.org/godotengine/3.3.1/Godot_v3.3.1-stable_win32.exe-fix48822.zip
They're the exact same version as 3.3.1-stable with #48888 applied as a hotfix, which fixes the crash issue when 3.3.1-stable is built with MinGW. You can use them in production just like the original builds.

[...]
For users affected by this issue who need a hotfix, I promoted my test builds as an official fix, uploaded here:
https://downloads.tuxfamily.org/godotengine/3.3.1/Godot_v3.3.1-stable_win64.exe-fix48822.zip
https://downloads.tuxfamily.org/godotengine/3.3.1/Godot_v3.3.1-stable_win32.exe-fix48822.zip
They're the exact same version as 3.3.1-stable with #48888 applied as a hotfix, which fixes the crash issue when 3.3.1-stable is built with MinGW. You can use them in production just like the original builds.

I'm test with your package and it's ok. It's work. a new official release are planned or this patch is planned with the 3.4 release ? I'm work with a small team, i need to know how to distributed the fix.
Thanks to everyone ;) .

a new official release are planned or this patch is planned with the 3.4 release ? I'm work with a small team, i need to know how to distributed the fix.

A fix will be included in 3.3.2 soon, I'm just not sure yet whether it will be the minimal fix in the above build, or a full embree upgrade from #48888.
Until then, you can use this 3.3.1 "fix48822" build in production and share it with other team members who need to bake lightmaps.


Certificates scheduled refresh

Hi,
I was wondering if might be useful to refactor the certificates management in a separate class which might offer a method to download/refresh certificates "on demand". Currently, if certificates don't exist or are expired, you are downloading them of the first certificate validation attempt and usually, that request takes few seconds to complete.
A useful feature to be able to call a method every 24h to refresh the certificates automatically.
What do you think about?

hi @albertovincenzi ,
sorry for the delay, but i was working on the new revoke list.
In the new version a class has been implemented for managing calls to endpoints (Utils\EndpointService) . As soon as a stable version of this branch is available, it will be possible to move the certificates download management to this class.
This will be directly callable from the outside.
do you think it can be useful compared to what is described in this issue?

Sure, I think would be great!
As soon as I will get some time, I would like to prepare a PR which might improve some minor things.
In any case, this package is amazing. Thanks for all your efforts


Update setting-up-reviews.md

updated the doc w/ information on how to self-approve config reviews

🚀 Deployed on https://6537eba78ccb7114b0c20c1a--cozy-fox-0defec.netlify.app


docs: Ring Buffers docs are hidden away under unexpected title

We have the whole "Data Passing" chapter in docs: https://docs.zephyrproject.org/latest/kernel/data_passing/data_passing.html which includes: FIFO, LIFO, Stack, Message Queue, Mailbox, Pipe.
And suddenly, Ring Buffers are away from it, under "Other Services" https://docs.zephyrproject.org/latest/kernel/other/ring_buffers.html .
Ring Buffer is just another data data communication primitive in Zephyr. The fact that it's apparently destined to be "more low-level" than some other, should lead to it being hidden away from the general inventory of data-passing mechanisms in Zephyr.

@nashif : Following suggestion to not do multiple assignments, but IMHO you would be ack'ing this.

Not being able to see entire data passing hierarchy at once leads to d'oh moments like this: https://github.com/zephyrproject-rtos/zephyr/pull/9853#issuecomment-420585228

ring buffers are not native kernel objects, we had a lengthy discussion about this in the past and there are very strong opinions about call them native kernel objects. That also the reason the are prefixed with sys_ instead of k_.

so what's the recommendation to close this issue?  We could add a link to the ring buffers documentation in the kernel objects data passing documentation with your explanation that while they're data passing structures, they're not kernel objects.

recommendation is to leave this as is.

Thanks for comments.

So is the recommendation to move ring_buffers to the data_passing section, yes?

Yes.

There's nothing "sudden" about this

Yeah, I don't mean sudden in a sense of time. I thought that maybe they're not documented, or there's a glitch which caused that section to be excluded (IIRC we had such case lately). And then I suddenly found it under "Other Services". And I knew what I was looking for, maybe wouldn't find otherwise.

ring buffers are not native kernel objects, we had a lengthy discussion about this in the past and there are very strong opinions about call them native kernel objects.

I guess we're going into word-play here. If you look at the left of https://docs.zephyrproject.org/latest/kernel/data_passing/data_passing.html , you'll see:
Level 1 heading: Zephyr Kernel Primer
Level 2 heading: Data Passing
Level 3 headings: FIFOs, LIFOs, etc.
Level 2 heading: Other Services
Level 3 heading: Ring Buffers
So, word "native" is not involved in any way. Even word "object" isn't. Everything is under "Zephyr Kernel Primer", and the talk is about moving a level 3 section from one level 2 heading to another.
At the very least, we should do what @dbkinder suggests:

We could add a link to the ring buffers documentation in the kernel objects data passing documentation with your explanation that while they're data passing structures, they're not kernel objects.

But it's also a chance to think something like following: "If structure looks weird in the docs, them maybe the underlying structure also has issue, or at least distinctions there are less important to the external Zephyr API than it seems (all those native vs non-native, object vs non-object)."
Like, those may be important secondary facts (whose meaning should be explained in xrefed glossary), but the primary categorization is that all they're data passing primitives.

we had a lengthy discussion about this in the past and there are very strong opinions about call them native kernel objects

Any references to that btw?

And it goes beyond that. "Polling" is again under "Other Services", while we have the "Synchronization" section. In which way polling is not synchronization but rather something "other" in the back where nobody sees it?

documentation for kernel and others has been restructured, open a new issue if you think this is not addressed.


wip/ji/conn-dialog-save-settings

right now all settings are located in util/settings/ and UI components are using functions from veles::utils::settings , this allows to access default values without creating dialog. Do you see any issues with unifying this with current convention?

@adamiwaniuk Fixed,


Add border-color on X

Re :dancer:
Can you Add border-color for x ? (background & text but not border :p)
Thanks

Do you think the border should be on all 4 sides / full box or should the left border be left off to make it appear unified with the iframe?

Sorry, i don't understand all :( (frenchie :D)
can you show me a picture ? please

Well, actually that was a premature question. Implementing it the way I suggested is going to add more complexity than the plugin is designed for. It could still be achieved with external CSS using the class names (.video, .video-close, .video-iframe).
Regardless I'm implementing a basic border (actually using the css property outline rather than border as it presents better with the iframe).

Ok
Idea : maybe possible the X on TOP-LEFT or TOP-RIGHT or BOTTOM-LEFT or BOTTOM-RIGHT
xPosition: top-left;
xPosition: top-right;
xPosition: bottom-left;
xPosition: bottom-right;
I think it's fun :)

Okay, this one is live in 3.0.4. Let me know if that works.

Humm, i have a bug, why outline and not border ?
Border : http://s2.postimg.org/m26ea98ol/image.jpg
Outline : http://s9.postimg.org/esjib5zt7/Sans_titre_4.jpg

Ah, yeah. I hadn't considered the effect of only the X having a border (outline). I used outline because on the iframe border pushes into the X a bit too much. I'll play with a few other params and see if I can find a good border solution.

Check https://developer.mozilla.org/en/docs/Web/CSS/box-sizing :)

That was indeed the answer. Thanks for steering me in the right direction ;)
Just pushed that change. Let me know if that doesn't do it

Closing this one, but let me know if it it needs any more tweaking. Thanks.


added ambient rotate for other angles - theta, phi, gamma (take 2)

Allowing 3D ambient_camera_rotation around other angles - theta, phi, and gamma
merged with the current master, and blacked

Nice, this is great!
Can you add these new roations  for gamma and theta to this example?
https://docs.manim.community/en/latest/examples/3d.html#threedcamerarotation

Hello @dor2727, any updates on this branch?


HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts

hadoop-ozone/dev-support/checks directory contains shell scripts to execute different type of code checks (findbugs, checkstyle, etc.)
Currently the contract is very simple. Every shell script executes one (and only one) check and the shell response code is set according to the result (non-zero code if failed).
To have better reporting in the github pr build, it would be great to improve the scripts to generate simple summary files and save the relevant files for archiving.
See: https://issues.apache.org/jira/browse/HDDS-2030

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
145
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1223
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1542
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
1218
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
775
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
119
hadoop-hdds in the patch passed.

+1
unit
322
hadoop-ozone in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

5905

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 2a2de9de6b88 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d2225c8

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/1/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/1/testReport/

Max. process+thread count
329 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
796
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
997
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
711
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
895
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
103
hadoop-hdds in the patch passed.

+1
unit
309
hadoop-ozone in the patch passed.

+1
asflicense
43
The patch does not generate ASF License warnings.

4122

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 545dd852b968 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4379370

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/2/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/2/testReport/

Max. process+thread count
340 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
605
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
828
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
568
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
1
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
662
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
110
hadoop-hdds in the patch passed.

+1
unit
292
hadoop-ozone in the patch passed.

+1
asflicense
48
The patch does not generate ASF License warnings.

3377

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 3faebe560c6e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8ab7020

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/5/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/5/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/5/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
70
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
682
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
807
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
549
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
697
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
112
hadoop-hdds in the patch passed.

+1
unit
287
hadoop-ozone in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

3466

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux f5ef4bdfe07e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 66cfa48

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/6/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/6/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/6/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
629
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
809
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
561
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
706
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
113
hadoop-hdds in the patch passed.

+1
unit
289
hadoop-ozone in the patch passed.

+1
asflicense
52
The patch does not generate ASF License warnings.

3418

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 5310f5c457e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 66cfa48

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/7/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/7/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/7/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
606
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
846
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
555
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
756
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
101
hadoop-hdds in the patch passed.

+1
unit
284
hadoop-ozone in the patch passed.

+1
asflicense
43
The patch does not generate ASF License warnings.

3414

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 89a6f21e8199 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 66cfa48

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/9/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/9/testReport/

Max. process+thread count
305 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/9/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
111
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
788
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1062
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
716
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
1
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
873
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
121
hadoop-hdds in the patch passed.

+1
unit
327
hadoop-ozone in the patch passed.

+1
asflicense
45
The patch does not generate ASF License warnings.

4280

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 7bde063a1180 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 66cfa48

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/8/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/8/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/8/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
580
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
820
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
601
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
763
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
112
hadoop-hdds in the patch passed.

+1
unit
307
hadoop-ozone in the patch passed.

+1
asflicense
46
The patch does not generate ASF License warnings.

3468

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 86d6e41dab67 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 66cfa48

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/10/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/10/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/10/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
71
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
635
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
884
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
569
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
757
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
103
hadoop-hdds in the patch passed.

+1
unit
290
hadoop-ozone in the patch passed.

+1
asflicense
45
The patch does not generate ASF License warnings.

3549

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 108ac3376790 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55cc115

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/11/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/11/testReport/

Max. process+thread count
333 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/11/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
166
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1
mvninstall
366
hadoop-ozone in trunk failed.

+1
mvnsite
1
trunk passed

-1
shadedclient
44
branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1
mvninstall
38
hadoop-hdds in the patch failed.

-1
mvninstall
65
hadoop-ozone in the patch failed.

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
41
patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1
unit
35
hadoop-hdds in the patch failed.

-1
unit
38
hadoop-ozone in the patch failed.

0
asflicense
40
ASF License check generated no output?

1218

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux dce892e56430 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55cc115

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/branch-mvninstall-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/patch-mvninstall-hadoop-ozone.txt

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/diff-patch-shellcheck.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/testReport/

Max. process+thread count
94 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/12/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
153
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
820
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1073
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
734
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
950
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
156
hadoop-hdds in the patch passed.

+1
unit
386
hadoop-ozone in the patch passed.

+1
asflicense
66
The patch does not generate ASF License warnings.

4605

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 599ca0af3357 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 48cb583

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/13/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/13/testReport/

Max. process+thread count
316 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/13/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
205
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
807
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1046
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
699
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
873
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
128
hadoop-hdds in the patch passed.

+1
unit
333
hadoop-ozone in the patch passed.

+1
asflicense
68
The patch does not generate ASF License warnings.

4408

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 79ed1d7da6fc 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 29bd6f3

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/14/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/14/testReport/

Max. process+thread count
305 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/14/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
142
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
795
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1067
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
774
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
1
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
977
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
137
hadoop-hdds in the patch passed.

+1
unit
360
hadoop-ozone in the patch passed.

+1
asflicense
54
The patch does not generate ASF License warnings.

4565

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux a82aa08240e3 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aef6a4f

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/15/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/15/testReport/

Max. process+thread count
309 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/15/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
573
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
817
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
545
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
703
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
116
hadoop-hdds in the patch passed.

+1
unit
284
hadoop-ozone in the patch passed.

+1
asflicense
53
The patch does not generate ASF License warnings.

3370

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 325475ccba24 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c749f62

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/16/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/16/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/16/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
627
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
874
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
565
the patch passed

+1
mvnsite
0
the patch passed

+1
shellcheck
0
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
729
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
107
hadoop-hdds in the patch passed.

+1
unit
283
hadoop-ozone in the patch passed.

+1
asflicense
42
The patch does not generate ASF License warnings.

3475

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux b2d4219b6362 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c749f62

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/17/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/17/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
585
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
799
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
571
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
2
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
838
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
106
hadoop-hdds in the patch passed.

+1
unit
335
hadoop-ozone in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

3553

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/18/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux d0f4a3e63965 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c749f62

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/18/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/18/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/18/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
81
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
648
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
836
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
606
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
752
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
115
hadoop-hdds in the patch passed.

+1
unit
308
hadoop-ozone in the patch passed.

+1
asflicense
44
The patch does not generate ASF License warnings.

3632

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 4cbf21044398 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c749f62

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/19/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/19/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/19/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
592
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
804
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
554
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
1
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
706
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
114
hadoop-hdds in the patch passed.

+1
unit
294
hadoop-ozone in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

3386

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/20/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 4c482d75bc34 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8c0759d

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/20/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/20/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/20/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
603
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
823
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
544
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
0
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
701
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
113
hadoop-hdds in the patch passed.

+1
unit
306
hadoop-ozone in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

3409

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/21/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux e1e198b89db2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/21/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/21/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/21/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
125
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

0
@author
0
Skipping @author checks as author.sh has been patched.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1
mvninstall
45
hadoop-ozone in trunk failed.

+1
mvnsite
0
trunk passed

+1
shadedclient
1065
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1
mvninstall
42
hadoop-ozone in the patch failed.

+1
mvnsite
0
the patch passed

+1
shellcheck
2
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
877
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
67
hadoop-hdds in the patch passed.

-1
unit
34
hadoop-ozone in the patch failed.

+1
asflicense
50
The patch does not generate ASF License warnings.

2736

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/22/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1348

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux b55e8036b60d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 85b1c72

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/22/artifact/out/branch-mvninstall-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/22/artifact/out/patch-mvninstall-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/22/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/22/testReport/

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-ozone U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1348/22/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

+1, committed to the trunk. Thanks for the contributions, @elek and @adoroszlai


Missing license

Could you add license file for this repository? Then the condition of using this repository/source code will be clear.
What do you think about MIT?

Ping @lewisxhe @LilyGO

Ok!

Thanks.
Close #16


Update favicon file format

Fixes #60
Hope this works!

For me the changes aren't working. I dont get an favicon at all. Did you test it, or am I doing something wrong? 😅

For me the changes aren't working. I dont get an favicon at all. Did you test it, or am I doing something wrong? 😅

Sadly, node and stuff doesn't work on both my computers.. Will test on gitpod shortly

Closing as per discussion in #64


Unable to start flask3.0 app on a minimal implementation with invalid syntax. Perhaps you forgot a comma? (scaffold.py, line 295)

Simply create a minimal flask3.0 app as follow and execute it, it will fail instantly on importing from flask import Flask:
from flask import Flask

app = Flask(__name__)

@app.route("/")
def hello_world():
    return "
Hello, World!
"

app.run()

Error trace:
Traceback (most recent call last):
  File "/home/lazydreamer/anaconda3/envs/test_env/lib/python3.11/runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lazydreamer/anaconda3/envs/test_env/lib/python3.11/runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "/home/lazydreamer/.vscode-server/extensions/ms-python.debugpy-2024.4.0-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in <module>
    cli.main()
  File "/home/lazydreamer/.vscode-server/extensions/ms-python.debugpy-2024.4.0-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main
    run()
  File "/home/lazydreamer/.vscode-server/extensions/ms-python.debugpy-2024.4.0-linux-x64/bundled/libs/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "/home/lazydreamer/.vscode-server/extensions/ms-python.debugpy-2024.4.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 321, in run_path
    return _run_module_code(code, init_globals, run_name,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lazydreamer/.vscode-server/extensions/ms-python.debugpy-2024.4.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 135, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/home/lazydreamer/.vscode-server/extensions/ms-python.debugpy-2024.4.0-linux-x64/bundled/libs/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 124, in _run_code
    exec(code, run_globals)
  File "/home/lazydreamer/Dev/TestProj/src/main.py", line 3, in <module>
    from app import flask_app
  File "/home/lazydreamer/Dev/TestProj/src/app.py", line 1, in <module>
    from flask import Flask
  File "/home/lazydreamer/anaconda3/envs/test_env/lib/python3.11/site-packages/flask/__init__.py", line 6, in <module>
    from .app import Flask as Flask
  File "/home/lazydreamer/anaconda3/envs/test_env/lib/python3.11/site-packages/flask/app.py", line 43, in <module>
    from .sansio.app import App
  File "/home/lazydreamer/anaconda3/envs/test_env/lib/python3.11/site-packages/flask/sansio/app.py", line 31, in <module>
    from .scaffold import _endpoint_from_view_func
  File "/home/lazydreamer/anaconda3/envs/test_env/lib/python3.11/site-packages/flask/sansio/scaffold.py", line 295
    raise TypeError('Use the 'route' decorator to use the 'methods' argument.')
                    ^^^^^^^^^^^^^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?

I am not sure what does the exception message 'Use the 'route' decorator to use the 'methods' argument.' means as I've just upgraded to Flask3.0, but this message string is definitely not right, and I my project will not encounter any issue on Flask2.3.3.
Environment:

Python version: 3.11.8
Flask version: 3.0.2
OS: Ubuntu

Instead  try inside virtual env and then reinstall everything after that run again if pass , it means that the problem is on you system config for python @lazydreamerbliss


ci: speed up fuzz tests

Speed up fuzz tests by running them in a matrix

Codecov Report

Merging #544 (30b73d9) into main (82cd84e) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   72.70%   72.87%   +0.16%
==========================================
  Files         243      243
  Lines       24701    24648      -53
==========================================
+ Hits        17959    17961       +2
+ Misses       6742     6687      -55

Impacted Files
Coverage Δ

crates/net/eth-wire/src/disconnect.rs
84.28% <0.00%> (-5.76%)
:arrow_down:

crates/net/eth-wire/src/p2pstream.rs
76.40% <0.00%> (-3.78%)
:arrow_down:

crates/storage/db/src/tables/models/blocks.rs
86.11% <0.00%> (-3.75%)
:arrow_down:

crates/net/eth-wire/src/hello.rs
81.81% <0.00%> (-3.40%)
:arrow_down:

crates/stages/src/stages/execution.rs
89.11% <0.00%> (-1.19%)
:arrow_down:

crates/net/discv4/src/config.rs
57.82% <0.00%> (-1.05%)
:arrow_down:

crates/net/network/src/session/active.rs
83.03% <0.00%> (-0.45%)
:arrow_down:

crates/stages/src/stages/senders.rs
94.27% <0.00%> (-0.28%)
:arrow_down:

crates/net/discv4/src/lib.rs
51.71% <0.00%> (-0.01%)
:arrow_down:

crates/net/network/src/state.rs
51.03% <0.00%> (ø)

... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Not much more I can do here, cargo-test-fuzz still recompiles on every test :shrug:

at least some improvements :)


jshint dependency

What is the thought process behind making jshint a peer dependency? Just curious, had to update a couple builds this morning that were failing due to the dependency not being automatically installed.

same here, it is breaking

@lundyio and @binarykitchen based on this commit ( https://github.com/spalger/gulp-jshint/commit/3e7ad8431ac92ea040f3b02d2714633875a209b5 ) it looks like the intent was to emphasize that any JSHint-compatible tool could be used with gulp-jshint just by installing that tool.
So, using gulp-jshint, you can install jshint if you want to use that linter, or jsxhint if you would prefer to use that linter. (Documented under options https://github.com/spalger/gulp-jshint#options )
Though, I think I would have preferred a dedicated gulp-jsxhint than the extra installation requirements for gulp-jshint.

Same here, it tells me npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed. But jshint is already installed.

+1

+1

+1

+1

:+1:

This might seem like a silly question, but what does everyone on this issue want?
I ask because the issue was filed as a question and not a request to make any change to this package.
The commit, 3e7ad8431ac92ea040f3b02d2714633875a209b5, does a pretty good job explaining the reasoning. Do people agree with the reasoning?

@hbetts While the reasoning behind might be good, at least for me the change completely breaks everything. It simply doesn't work. I'm facing the same situation as @KKfo described. Neither a globally nor a locally installed jshint does satisfy gulp-jshint's dependency. Maybe I'm doing something wrong, maybe it's a problem with Node 5, all I can say is that it worked like a charm prior to this change. Now it doesn't anymore, and I don't see what I can do about.

TLDR jshint is a dependency of gulp-jshint, it is listed in the package.json. There is one version of jshint that would make everyone happy. The purpose of semver is to prevent new versions from breaking your builds, please use it.

The reason that I felt it was necessary to take a different approach with the jshint dependency is because people are regularly confused as to why gulp-jshint doesn't update it's jshint dependency (#46, #102, #122). Jshint has also demonstrated in the past that it is pretty liberal with semver (see jshint 2.5). Then jshint published a release candidate to npm as it's latest version so gulp-jshint users were unknowingly installing a broken/pre-release version of jshint.
I feel like peerDependencies (especially the way that they are handled by npm3) helps mitigate the pain of all of these issues by putting everyone in control of their own jshint.
It was clear that a good number of people are already using npm 3 with node 5, so in order to prevent their builds from breaking I bumped the version to 2.0. That is what major version numbers are for. If you are automatically installing major version bumps then you are asking for trouble.
As far as I can tell there is no issue installing peerDependencies, so please run the install command at the top of the readme if you are having a hard time getting gulp-jshint to install.

@spalger Thanks for the explanation. Just to give you a short feedback: While I did understand all this before, it was the
npm install --save-dev jshint gulp-jshint

(taken from your screenshot) that made everything work now. This installed jshint 2.8.0 locally, obviously — although the very same version was already present globally (but didn't suffice gulp-jshint's needs). I think this is what was troubling people (including me).
Thanks for helping in the end, though. ;)

I still have this issue, even after installing jshint:
(projenv) MacBook-Pro:posts robin$ gulp
[21:57:21] Using gulpfile ~/learning/python/parrot/posts/static/posts/gulpfile.js
[21:57:21] Starting 'clean'...
[21:57:21] Finished 'clean' after 4.86 ms
[21:57:21] Starting 'default'...
[21:57:21] Starting 'styles'...
[21:57:21] Starting 'scripts'...
ERROR: Can't find config file: .jshintrc
(projenv) MacBook-Pro:posts robin$ sudo npm install jshint --save-dev
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
(projenv) MacBook-Pro:posts robin$

@Flobin
rm -rf node_modules and npm install

@Baires yep, I did that. It still tried to install 2.9.1-rc1, so when I removed node_modules, set it to 2.8.0, and reinstalled, it worked fine.

@Flobin Thanks for the tip to downgrade jshint to 2.8.0. That's what got it "working" for me too.

npm install --save-dev<EMAIL_ADDRESS>this worked for me.

Thx @rshah9 . that fix work for me.

I'm starting to work with Gulp and was stuck with this error, thank you!!!! :)

The above seems to be a workaround, not a solution, unfortunately.


Add backward support to digamma

Merged to main
https://github.com/tenstorrent-metal/tt-metal/pull/5898


Run tests on Appveyor

We have bought its paid plan, each test takes about 10min to run, not very fast but better than travis ci's mac machine.

:+1: awesome


Title Binary Tree

Description
Description
Construct a binary tree from it's Preorder and Inorder recursively.
Here, Preorder is the preorder traversal of a binary tree and the Inorder represents the inorder traversal of the same tree.
Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


WIP: Horizontal Image Card

Not done yet. Gonna sign out for the day, but didn't want to lose my work.
https://deploy-preview-1532--tbd-website-developer-new.netlify.app/component-guide/horizontal-image-card
Related #1509
Note to self:

Spacing, button, button text, overflow need to be fixed
mobile
Make separate PR for twist core spacing support https://sq-block.slack.com/archives/C06PYC7K71C/p1723139074315289

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1208035264693350
https://app.asana.com/0/0/1208035264693355

Closing this because I didn't have time for it :'(


Test suite modifications

*Added support to tensor unittests to accept user input for augmentation params

Closing the PR since this branch became obsolete
Issued a new PR here
https://github.com/r-abishek/rpp/pull/108


Don't consider a linkprop on a multi link to be multi in a constraint on it

Makes using EXISTS/?!= work on linkprop constraints.
Helps mitigate #1727.

cherry picked for 1.x


B13.1 Delivery to I&T Prep

See sub-tasks

📆 February status: Task start delayed. Will begin once software is delivered. No impact on build.

 Punting on a couple lower priority tasks to next build


Huge performance drop after update

Today I updated neosr and noticed a huge drop in performance.

RGT: from 2.9 it/s to 1.6 it/s
Swinir_small: from 6.6 it/s to 2.3 it/s

I reversed commit by commit and found that the 2dcafe4 (Change no_grad -> inference_mode) was causing it.
Was it supposed to happen?
My setup: ubuntu 23.04, rtx 4090, torch 2.2.0
Train config: RGT and swinir_small, both otf and paired, amp + bfloat16 enabled.
Before update (RGT):

After update:

Hi @VandersonQk! I'm looking into this issue this week, I'll let you know once it's solved :+1:

Fixed. Please update :+1:

Thanks. RGT is working properly again and it's faster than before!


Looking at other people's R-Code

Really small problem since most people don't use the inspect R-Code thing at all I guess, but currently when using the mod the load time is still the same when looking at other people's R-Code, that is, they're still really long.
I noticed that Totsugeki is still redirecting stuff when you look at someone's R-Code even though it's so long, so this might be something unavoidable since you're pulling someone else's information and not sending yours? I don't know how it works, but I'm opening the issue because this might have been something that was overlooked.
Pretty much everything I looked into loads way faster though, and I didn't encounter any other problems so far, thanks for the great mod.

Looking at R-Codes should be faster than normal, but not necessarily fast. My guess is it pulls all the players stats the same way it pulls your own stats during the title screen (ie it takes minutes).
I'll do some more digging to see how R-Codes are handled.

Did some testing today. Looking at R-Codes will be about as slow as loading the main menu. A large portion of the requests at the title screen are just to load your own R-Code, one stat at a time. Likewise it looks like looking at other people's R-Codes makes the same requests so it's equally slow.
This is unfortunately not something that can be fixed easily without dissecting the protocol and coming up with a way for Totsugeki to batch stats requests. I'll be digging at the stats API (as it seems to be the slowest) in the next few weeks to see if there's any ways to make it faster.
Glad you find Totsugeki useful!

I see, thank you for looking into it, I thought this would be the case. It would be cool to be able to look at R-Codes faster to make following or blocking people actually useful, but it's not that big of a deal, we can only hope the developers fix the actual game now.


Spm

Fixes #24
I just realised that I hadn't opened a PR for this yet :/
I've merged in latest changes from master just now. This will continue to be tricky and generate merge conflicts every time due to the way vapor.swift is no more in this branch.
It would be great if we could merge this next so we can avoid the tricky merges from master. The only thing that still needs changing is reviewing the install/update process in the spm context, i.e. by downloading the bootstrap script and running it instead of downloading the vapor script and compiling it. This should be simple and I'll look into that once soon as we're sure we're going down this path.
See #24 for more details.

Had to push out the last update, but I won't push anymore to master. Let's get this straightened out this week. :)

Haha, in WWDC week? Let's see how that goes ;) I'll try and fix up the remaining bits tomorrow.

@tannernelson just looking into merging 0.5.3 into this branch I noticed that there seems to have been an issue with installing that made you bring the install command back: 8f478531f5a6456cbc54ca4b0bd64d9b4372cd87. I’m going to drop this as part of the merge because this bit doesn’t really make sense with the bootstrap.swift script but it would be good to understand what the problem was so I don’t re-introduce it.
Have you got a problem description that I could test against? Thanks!

@tannernelson I’m done with this but there are two things to do after merging.

The branch where bootstrap.swift pulls from is set to this branch, spm, right now, on order to make the tests pass. We’ll either need to change that or make it a parameter, defaulting to master. Just keeping the branch name in there is easier for now, otherwise we’d need to do more parameter parsing.

I’ve had to disable the vapor update test, because it cannot work until we’re serving bootstrap.swift from cli.qutheory.io. Actually, it may be better to change to a new URL, for example vapor-cli.qutheory.io, and switch over before merging. That way old clients won’t fall over.

PS: Changes to be made are FIXME labeled

I'm going to merge this for now so we don't make any more accidental changes.
But I have a few things I want to add before we tag. Like support for Vapor's commands.
Nice work on this @feinstruktur!

Thanks @tannernelson :) Not sure what exactly you mean by "Vapor's commands" but if you've got some specifics I can find some time this week to look into it. Now that this is in, I was also going to look into adding some unit tests via swift test.

Unit tests would be awesome. The Vapor commands can be read about in the docs here: https://vapor.readme.io/v0.12/docs/command
Basically Vapor has a little bit of CLI functionality itself now for serving and running preparations (migrations).
You run this by doing .build/debug/App serve .build/debug/App prepare --revert etc.
I want to make the CLI reduce the typing here by doing vapor run serve
To accomplish this we would need to parse the Package.swift to figure out the name of the package, then  run the executable from either the debug or release folders.
so something like vapor run serve --release would translate to .build/release/MyAppName serve

Also if you look at the console stuff powering that, you can see there's some cool code here for doing colors, etc.
I think it could be worth breaking this out into it's own package so both Vapor and the CLI can use it: https://github.com/qutheory/vapor/tree/master/Sources/Vapor/Console

Cheers, I've created tickets #32, #33, and #34 for those


How to use FnImportValue where CDK wants a string or list of string?

Hi,
I'm trying to import a VPC from an existing (non-cdk) stack, following the examples in:
https://gist.github.com/mipearson/aeaf303b0770c25f8b5f6e360594cfbf
https://github.com/awslabs/aws-cdk/issues/603
https://github.com/awslabs/aws-cdk/issues/506
I added exports in my existing stack for the VPC ID, CIDR block, availability zones, and subnets.
In order to call VpcNetworkRef.import_, I need to pass it VpcNetworkRefProps, and the builder for the props wants a list of strings for AZs.
None of these type check as arguments to VpcNetworkRefProps.builder().withVpcId(id).withAvailabilityZones:

new FnImportValue("other-stack-AZs") where other-stack-AZs is a comma-separated export (Fn::Join on the other stack's cloudformation template)
new FnSplit(",", new FnImportValue("other-stack-AZs"))
[new FnImportValue("other-stack-AZ1"), new FnImportValue("other-stack-AZ2"), new FnImportValue("other-stack-AZ3")]

How can I import availability zones from another stack?
And more generally, how should we use FnImportValue where CDK wants a string or a list of strings?

CDK tokens, such as FnImportValue can be represented as strings, so you should be able to just do [ new FnImportValue("other-stack-az1").toString(), new FnImportValue("other-stack-az2").toString(), ... ]. Can't say that's super elegant but that should work.
Would that work for your use case?

Thank you -- that would work.
How about in places where CloudFormation accepted Fn::Split but CDK wants a list?  For example:
Resources:
  LoadBalancer:
    Type: 'AWS::ElasticLoadBalancingV2::LoadBalancer'
    Properties:
      Subnets: !Split [ ",", !ImportValue shared-infra-PublicSubnetIDs ]
  AutoScalingGroup:
    Type: 'AWS::AutoScaling::AutoScalingGroup'
    Properties:
      VPCZoneIdentifier: !Split [ ",", !ImportValue shared-infra-PrivateSubnetIDs ]


Can't start a game in SM64JS

(Mr. Yahoo btw lo) ive recently posted a video showing that when i try joining a game, it just refreshes the site lo
i have a z64 file put in and are logged in already, it'll just keep refreshing the site whenever i press submit
video for whats going on: https://www.youtube.com/watch?v=4H9S6wYUI3s

help lo, and birds are cool

I had that same issue yesterday while playing with you, as well. I also reported the glitch with a more lengthy recording (where I tried to open the website in a different tab) and I had the same issue. I think it may be caused by an issue in the website's function to remember a user's history of using the site.

Deploying fix


[FEATURE] Split JOIN node into various different nodes

CROSS JOIN
LEFT JOIN
INNER JOIN

PyArrow 8 exposes JOIN functionality (https://arrow.apache.org/docs/dev/python/compute.html#table-and-dataset-joins) This appears to be about 20% faster than existing code.


Vulkan debug log crashes application

Vulkan returns some value that can not be converted to from UTF8 to UTF32 and crashes application when trying to log.
vulcan error breaks utf8.txt

confirmed - works now.


Grant read-only access to existing Cloudfront Origin Access Identities

New Feature

Grant read-only access to existing Cloudfront Origin Access Identities

@soerenmartius adding tests is not possible as OAI needs to exist, please review and issue a release.. no breaking changes.. ;)


Added original logo SVG file and PNG render.

(Needs some cleanup, as described in issue #277.)

Tests failed:
missing from sdist:
  logo
  logo/README.md
  logo/mido.png
  logo/mido.svg
suggested MANIFEST.in rules:
  recursive-include logo *.md
  recursive-include logo *.png
  recursive-include logo *.svg
ERROR: InvocationError for command /home/travis/build/mido/mido/.tox/py27/bin/check-manifest -v (exited with code 1)

I don't think the logo should be included in the package.

Added a prune line for it.

Nice, I actually got an email when the tests failed.

Thanks!


postman failure for: /curriculum

{
      "id": "1b495832-3481-45cc-b2f4-d1467c5074eb",
      "name": "/curriculum",
      "url": "https://dcox0bl0me.execute-api.us-east-1.amazonaws.com/Prod/curriculum",
      "time": 1306,
      "responseCode": {
        "code": 400,
        "name": "Bad Request"
      },
      "tests": {
        "Status code is 200": false
      },
      "testPassFailCounts": {
        "Status code is 200": {
          "pass": 0,
          "fail": 1
        }
      },
      "times": [1306],
      "allTests": [
        {
          "Status code is 200": false
        }
      ]
    }

this is the post request. it recieved a 400 response when trying to post.

{
    "Message": "Unable to Query the information",
    "err": {
        "length": 244,
        "name": "error",
        "severity": "ERROR",
        "code": "23503",
        "detail": "Key (skillid)=(2) is not present in table \"skill\".",
        "schema": "public",
        "table": "curriculum_skill",
        "constraint": "skill_fk",
        "file": "ri_triggers.c",
        "line": "2474",
        "routine": "ri_ReportViolation"
    }
}

issue appears to be related to the skill id not existing.
recommend evaluating potential issues this may cause when querying


AVRO-2034 Nested schema types with unexpected fields causes json parse failure

Still a WIP.  Test proves issue, working on a fix.


Build issue on Alpine with 13-latest-develop branch

tldr; Alpine Linux uses musl-libc instead of glibc and has a package for libexecinfo.  -lexecinfo needs to be appended to LDFLAGS for the project to compile/link cleanly.
When I do a fresh checkout of libpg_query against the 13-latest-develop branch and attempt to compile the project, I get the following error when linking:
ar: creating libpg_query.a
cc -I. -g -o examples/simple -g examples/simple.c libpg_query.a -pthread
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: libpg_query.a(src_backend_utils_error_elog.o): in function `set_backtrace':
/pgparse/libpg_query/src/postgres/src_backend_utils_error_elog.c:829: undefined reference to `backtrace'
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /pgparse/libpg_query/src/postgres/src_backend_utils_error_elog.c:830: undefined reference to `backtrace_symbols'
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: libpg_query.a(src_backend_utils_error_assert.o): in function `ExceptionalCondition':
/pgparse/libpg_query/src/postgres/src_backend_utils_error_assert.c:59: undefined reference to `backtrace'
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /pgparse/libpg_query/src/postgres/src_backend_utils_error_assert.c:60: undefined reference to `backtrace_symbols_fd'
collect2: error: ld returned 1 exit status
make: *** [Makefile:171: examples/simple] Error 1

execinfo is obviously being imported in Postgres, so I checked configure in the Postgres repo and found https://github.com/postgres/postgres/blob/master/configure#L11877
By setting TEST_LDFLAGS=-lexecinfo in my shell, it compiles cleanly and passes all tests.
I'm going to try to find a work around in my build process, but ideally libpg_query would be smart enough to work around this as well.
If you're looking for a PR, and want to point me in the right direction for how you'd like it addressed, I'm happy to see if I can figure it out.

meh, realizing this is happening when it's linking the examples and not when it's creating the lib itself, so it's a downstream issue.

@gmr Yeah, thats correct, since the static library itself can't really link to execinfo, you'd have to include it in your program's LDFLAGS (like you did for the tests).
That said, I do wonder if we can avoid this problem altogether, since I don't think this particular Postgres feature is really needed in a parser library. I assume the same issue doesn't happen in 10-latest?

I did not see a similar problem in 10-latest

@gmr Thanks - let me see if I can figure out how we can avoid this dependency, I'm sure you won't be the last to run into this. Will update here once I figure something out.

@gmr This should be resolved now in the 13-2.0.0 release.

Thanks!


Can't Update: Plugin Id Mismatch

That's all. I think theres some problem with the plugin manisfest but I could be wrong

Update: Obsidian seems to think there is a version 3.0 but I cant install it

I've been working on a new version. Not sure why obsidian picked it up since I haven't made any releases, but I'm cutting a release now.


Fix typo in docs/guide/why.md documentation

I was reading through the documentation for this really exciting project, and I noticed a minor typo in the first section. I figured I'd submit a proposed change just to bring it to your attention. Hopefully that's helpful.

Nice catch


Load fallback .env prints first entry

Hi,
if there is no DOTENV_KEY phpdotenv-vault fallback to the unencrypted .env file.
In this case there is a var_dump on first .env entry (ref)
var_dump($entries[0]->getName());
var_dump($entries[0]->getValue());

If there should be an output, it would be better to add a notice or warning so that it can be ignored by error_reporting.
trigger_error('Fallback to unencrypted .env', E_USER_NOTICE);

Fixed. https://github.com/dotenv-org/phpdotenv-vault/blob/master/CHANGELOG.md#013
thank you for your patience. PHP is getting some love over this weekend. A lot of php users of .env.vault now and this library needs a LOT of work.
Loving PHP by the way! Bringing me back to the good old days.

We won't do the warning though. We'll follow the same approach as the node dotenv library:

Default fallback to .env
If DOTENV_KEY is set then look for .env.vault file.
If .env.vault file is then not found warn user
If .env.vault file is found then show log message that envs are being loaded from encrypted .env.vault file


Update Composer dependencies (2021-10-30-00-04)

Visual regression test passed!
View the visual regression test report


Add a default timeout to use when sending packets for CosmosChain

Add a function GetTimeout() to CosmosChain which returns a valid timeout which is not expected to timeout before the packet is relayed. This will be useful when test writers write tests which require sending packets that must specify timeouts. It is probably easier to specify the timeout height rather than the timeout timestamp

You can pass nil for timeout to SendIBCTransfer to use the default timeout for cosmos chains. Do you see an additional need for this method?

We've been using BroadcastMessages and thus constructing our own Msg's. Each Msg which results in an IBC packet being sent will require setting a timeout
We have added this function to our own codebase, so I'm fine closing if you'd prefer not to add the additional code


Fixed typo in ruby_spec.rb

Fixed a typo with the word "occurrence" in ruby_spec.rb

Automated message from Dropbox CLA bot
@Jeffthebest1, it looks like you've already signed the Dropbox CLA. Thanks!

I think this may be third-party code, so I don't want to touch it to just fix the typo.


Change Weight for Custom Form Builder Components?

Hello again,
When configuring a custom Form Builder, is there a way to change the weight of the actual components themselves?  Not the categories, but the components.  For example, I would like to just put a collection of components that are in the basic and advanced grouping under one custom "Components" section, but I would like to be able to group them accordingly.
Given this configuration, I would like to group the date/time related components together:

But when they are rendered, they end up like this (with checkbox mixed in between)

Thanks in advance.

You will probably need to also change the "weight" of the other components which is provided in their "builderInfo" method.  Something like this may allow you to modify any components builderInfo weight.
var checkBoxInfo = Formio.Components.components.checkbox.builderInfo;
checkBoxInfo.weight = 200;
Object.defineProperty(Formio.Components.components.checkbox, 'builderInfo', {
  get() {
    return checkBoxInfo;
  }
});

Note: I have not actually tested this to see if it works, but I have a hunch it may.

@travist Thanks for you solution, it totally works for me. One more addition to it to make it little optimized
import {Formio} from 'formiojs';

// Sequence
let index = 500;
[
  'textfield',
  'textarea',
  'email',
  'selectboxes',
  'select',
  'phoneNumber',
  'radio',
  'datetime',
  'button',
].forEach(name => {
  let component = Formio.Components.components[name].builderInfo;
  component.weight = index++;
  Object.defineProperty(Formio.Components.components[name], 'builderInfo', {
    get() {
      return component;
    },
  });
});

We're currently addressing a backlog of GitHub issues, and as part of this effort, some inactive issues may be marked as closed. This isn't a dismissal, but a step toward more efficient tracking.
If you feel the issue is still relevant, please re-open and we'll ensure it gets the attention it deserves. Your understanding is appreciated as we work to enhance our open-source responsiveness.


Flag for cloning the repo into the full github owner/repo path

I couldn't find info about this in the docs, nor browsing the source code. I wonder if there's any way of getting hub to behave like this:
$ cd ~/Code
$ ls
$ git clone [some flag] github/hub
$ ls
github
$ ls github
hub

If not, is there any interest in adding some feature like that? I could throw a chance at implementing.

It's an interesting feature idea, and has been suggested before, but for now I want to err on the side of leaving the implementation up to the user (via e.g. specialized script on their machine). See https://github.com/github/hub/issues/689#issuecomment-64836779 for related issues.