Running go tests works but debugging says warning: no tests to run

Description of the issue. Please be specific.
When running go tests in IntelliJ with bazel pluging, test runs as expected, but when Debug is selected instead of Run, it says:
"/Users/massoud.mazar/Library/Application Support/JetBrains/IntelliJIdea2023.3/plugins/go-plugin/lib/dlv/macarm/dlv" --listen=<IP_ADDRESS>:52327 --headless=true --api-version=2 --check-go-version=false --only-same-user=false exec /Users/massoud.mazar/repo/AAAA/bazel-out/darwin_arm64-dbg/bin/BBBB/CCCC/CCCC_test_/CCCC_test.runfiles/AAAA/BBBB/CCCC/CCCC_test_/CCCC_test --
API server listening at: <IP_ADDRESS>:52327
debugserver-@(#)PROGRAM:LLDB  PROJECT:lldb-15<IP_ADDRESS>
 for arm64.
Got a connection, launched process /Users/massoud.mazar/repo/AAAA/bazel-out/darwin_arm64-dbg/bin/BBBB/CCCC/CCCC_test_/CCCC_test.runfiles/AAAA/BBBB/CCCC/CCCC_test_/CCCC_test (pid = 83306).
testing: warning: no tests to run
PASS
Exiting.

What's the simplest set of steps to reproduce this issue? Please provide an example project, if possible.
Version information
IdeaUltimate: 2023.3.2
Platform: Mac OS X 14.2.1
Bazel for IntelliJ plugin: 2<IP_ADDRESS>.1-api-version-233
Bazel: 6.3.2

Hello! It's hard to diagnose the issue without seeing the test case in particular. For instance, the test cases in the examples directory work, so it's probably related to your specific case.
Could you share with us some way to reproduce the issue, ideally with some example code?

After updating to the latest version of the plugin (2<IP_ADDRESS>.2-api-version-233), and selecting the test suite (instead of individual test), it errors saying it is not able to load my test data files:
"/Users/massoud.mazar/Library/Application Support/JetBrains/IntelliJIdea2023.3/plugins/go-plugin/lib/dlv/macarm/dlv" --listen=<IP_ADDRESS>:63111 --headless=true --api-version=2 --check-go-version=false --only-same-user=false exec /Users/massoud.mazar/repo/aesome_project/bazel-out/darwin_arm64-dbg/bin/some_server/server/server_test_/server_test.runfiles/awesome_project/some_server/server/server_test_/server_test --
API server listening at: <IP_ADDRESS>:63111
debugserver-@(#)PROGRAM:LLDB  PROJECT:lldb-15<IP_ADDRESS>
 for arm64.
Got a connection, launched process /Users/massoud.mazar/repo/awesome_project/bazel-out/darwin_arm64-dbg/bin/some_server/server/server_test_/server_test.runfiles/awesome_project/some_server/server/server_test_/server_test (pid = 37496).
--- FAIL: TestSomeEndpoints (0.01s)
    --- FAIL: TestSomeEndpoints/TestGetRecords (0.00s)
        licensing_test.go:26:
                Error Trace:    project/server/xyz_test.go:26
                                                        external/com_github_stretchr_testify/suite/suite.go:187
                Error:          Received unexpected error:
                                open testdata/testconfig.yaml: no such file or directory
                                Failed to load file: testdata/testconfig.yaml

Location of data files is defined in BUILD.bazel:
data = glob(["testdata/**"]),

Closing this as I was able to get past the no such file or directory error, which is a known issue in Delve.


Can't save logic app in ISE

Here is the error when I try to save a Logic App created in an ISE:
400 - "{"error":{"code":"WorkflowIntegrationServiceEnvironmentMismatch","message":"The workflow '/subscriptions/80d4fe69-c95b-4dd2-a938-9250f1c8ab03/resourceGroups/ISE-EastUS2/providers/Microsoft.Logic/workflows/ise-eastus2-test' is associated with integration service environment '/subscriptions/80d4fe69-c95b-4dd2-a938-9250f1c8ab03/resourceGroups/ISE-EastUS2/providers/Microsoft.Logic/integrationServiceEnvironments/klam-ise-eastus2' which does not match with integration service environment reference '' present in the request definition. Changing the integration service environment of workflow is not supported."}}"

Closing due to lack of progress on the SDK updates required to support this.


Update Python to 3.9

This updates Python to 3.9 for building and testing the QDK's qsharp packages.
Among these changes we also:

Consolidate all PyPI requirements for building/testing the packages into src/Python/requirements.txt.
These requirements are installed automatically when invoking bootstrap.ps1
Most versions of these requirements have been locked to prevent spurious build failures.
CI steps for building conda packages have also been simplified to not be duplicated for different platforms.

/azp run


Switch from Puppet to Chef or Ansible?

Probably the biggest source of confusion for people working with Boxen is Puppet. Puppet is complicated, has its own DSL, is extremely verbose, and as an external dependency is a big pain to work with—here's one example of probably many where it took over 2 months to fix Puppet using curl insecurely over SSL. Debugging Puppet errors is extremely tedious.
While Boxen makes an developer user's life much easier, the Boxen maintainer (for an org or otherwise) is difficult.
Goals
I'd like a framework that is:

Easy to configure
Easy to maintain
Easy to extend
Fast/efficient
Used by a large community

To those ends, what does the Boxen community think of switching from Puppet as its idempotent runner to Chef or Ansible?
Chef
Pros:

It's Ruby. Its DSL is Ruby'esqe. If you know Ruby—which most of Boxen is written in—you can work with Chef.
Thus, creating custom Chef providers is easier.
Chef's "data-bags" can be used in place of Puppet's Hiera (I believe)
Can be used with OS X's system Ruby (I think?)

Cons:

?

Ansible
Pros:

Very simple to setup and get running
Ansible is written Python, however modules can be in any language
YAML files for everything

Cons:

pip needs to be installed first on the system (although I suppose not a big deal, since bundler is for Boxen)

I'm surely missing lots. Obviously there would also be the tremendous work of rewriting Boxen modules for the new framework. Would love to hear folks thoughts. cc: @boxen/owners

Not sure if we will have any gain changing from puppet for something else. It is seems like we saying "ok, people don't understand our open source library because it is written in C. Lets rewrite it in Ruby".
Of course syntax matters, but I don't see it as a problem. If people want to use Boxen they can just learn Puppet.
I never used Chef or Ansible before, so I can't say if they provide everything we want, but even if they provide, is puppet so bad that it is worth to rewrite everything?

Having now deployed Boxen for developer on-boarding at three companies, everyone appreciates it but hates working in it, and the main reason for that is Puppet's DSL and how difficult it is to debug and troubleshoot typos or syntax errors in manifests. Here's one example from an actual project:
  ## rbenv-installed gems cannot be run in the boxen installation environment
  ## which uses the system ruby. The environment must be cleared (env -i)
  ## so an installed ruby (and gems) can be used in a new shell.
  ## env -i also clears out SHELL, so it must be defined when running commands.

  $base_environment = "env -i SHELL=/bin/bash /bin/bash -c 'source /opt/boxen/env.sh &&"
  $bundle = "$base_environment RBENV_VERSION=${project_ruby_version} bundle"

  ## NOTE: don't forget the trailing single quote in the command!
  ## e.g.
  ## command => "${bundle} install'"

  ## bundle install
  exec { 'bundle install project':
    provider  => 'shell',
    command   => "${bundle} install'",
    cwd       => "${boxen::config::srcdir}/project-repo",
    require   => [
      Ruby[$project_ruby_version],
      Ruby_Gem["bundler for all rubies"],
      Service['mysql']
    ],
    unless    => "${bundle} check'",
    timeout   => 1800
  }

Look at the command line. The cost of DRY'ing up that long bundle command is: don't forget that last single quote, or it all breaks!
This isn't a question of using a different language, it's how easy and maintainable is a framework for use by its users.

everyone appreciates it but hates working in it

Is it a problem of the tool or an education problem? If we where using Ansible or change this would be different? I don't think so. People has personal preferences and it is fine, but I don't think personal preferences should drive a huge change like this one.
Also, for a open source project like this one we should think in "what are the tools the maintainers are comfortable with?". I believe this change would not just require a lot of hours to rewrite as a lot of hours for the maintainers learn how to use the new tool properly.
And still the benefits are too obscure to justify a decision like this one. Everything we have now is: some people don't like Puppet, and maybe if we change to something else they will like.

Again, three different companies. All of them software companies, senior engineers fluent in multiple programming languages, people with significant ops experience, some ex-Pivotal Labs people. This isn't an education problem.
Puppet was chosen for Boxen because that's what GitHub's devops people used to maintain their corporate infrastructure. And used to manage large enterprise, Puppet can be fine because large enterprises are complex to manage. On a single developers machine, Puppet is burdensome, obtuse, and again, difficult to debug. Now that most/all of the GH devops folks have moved on from GitHub or this project, the project constraints have changed. We're no longer forced to use and can choose something better.

Do we have how to assert that any other choice would be better?
Not saying that we can't, just saying that is too much work for a (dubious?) gain.

I suppose a spike with basic functionality and some module examples would be in order. Initially, I want to get feedback with more experience using these systems.

Well, I can't say no if we can assert that it will be worth, and more important I can't say no if you want to try. But I can't put too much energy on this right now, sorry. I'll definitely review and give inputs though.

@seanknox Have you tried alternatives to Boxen? Battleschool might fit your bill if you do not want to use Puppet. I don't have a first hand experience with it but you may want to have a look. You can also read Spencer Gibb's blog too.

Now that most/all of the GH devops folks have moved on from GitHub or this project, the project constraints have changed. We're no longer forced to use it and can choose something better.

Given my personal experiences with Chef I'm not convinced it would be any easier (and it would probably be worse). Puppet has a Ruby DSL so it's maybe worth investigating if that can be used.
For what it's worth I personally agree that Puppet is extremely painful to work with for something like Boxen but to rewrite it in e.g. Chef would require reimplementing essentially the whole project from scratch, all submodules and introducing huge numbers of new bugs. For this reason: it won't happen and if it does it won't really be Boxen any more.
If you want something lighter-weight I'd personally recommend using a combination of Homebrew, Homebrew Cask, Homebrew Bundle and a shell script to do basic system setup (e.g. installing the above, turning on full-disk encryption etc.).


csv input question

How would i consume a directory of csv files using the csv input?  I have a directory of about 30k. I tried using a wild card for the path but that does not seem to work nor does just pointing it the directory seems i have to list each file in the path array.
Thanks

Hey @gmonk, unfortunately it doesn't support that but it should be quick to add.

Done https://github.com/Jeffail/benthos/commit/6b9b8d51cfd2d45f515ee3bb7924fe3ad33777ba, it'll be in the next release.


"build-and-push-image" fails frequently on ARM64

The job is defined here and it seems to fail very often when releasing new images with this failure message:
 > [linux/arm64 ui  9/11] RUN make node_modules:
 ERR! network aborted
#47 730.0 npm ERR! network This is a problem related to network connectivity.
#47 730.0 npm ERR! network In most cases you are behind a proxy or have bad network settings.
#47 730.0 npm ERR! network
#47 730.0 npm ERR! network If you are behind a proxy, please make sure that the
#47 730.0 npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
#47 732.4
#47 732.4 npm ERR!


docs: fix link in readme

دریافت Outlook برای iOShttps://aka.ms/o0ukef

فرستنده: rethab @.>
ارسال شده: Wednesday, September 28, 2022 11:39:54 AM
گیرنده: community/community @.>
گیرنده کپی: Subscribed @.***>
موضوع: [community/community] docs: fix link in readme (PR #34424)

You can view, comment on, or merge this pull request online at:
https://github.com/community/community/pull/34424
Commit Summary

14ca841https://github.com/community/community/pull/34424/commits/14ca8412cf93b982020e09a5713c571570b43487 docs: fix link in readme

File Changes
(1 filehttps://github.com/community/community/pull/34424/files)

M README.mdhttps://github.com/community/community/pull/34424/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (2)

Patch Links:

https://github.com/community/community/pull/34424.patch
https://github.com/community/community/pull/34424.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/community/community/pull/34424, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWWGRIH4JW6ZEISR3R5KO6DWAP4NFANCNFSM6AAAAAAQXQKUQI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

rethab:patch-1


Join efforts with saschagrunert/yew-router

Hey :wave:,
@jstarry reached me out via mail and asked if we want to join our efforts to keep the yew ecosystem homogeneous. I would suggest that we join the repositories into one and use the GitHub CODEOWNERS to collaborate effectively. We also have some ideas about future improvements in mind. WDYT?
cc @Boscop

Refers somehow to https://github.com/yewstack/yew_router/issues/62

Yes, I think it's a good idea to merge the efforts.
I hope we can integrate both, and then have a way to define type-safe routes like this: https://github.com/saschagrunert/yew-router/issues/1

Sorry I missed this for a few days. I'm all for it!
As a sort of synopsis:
As far as I'm aware, we've both branched out from the same original source present in the routing example that resides in the Yew repository. I've altered the naming of some things in my fork, but for the most part, the structure is just about the same.
I see that you have added a macro that resolves the fragment to a generated enum variant. This enum variant can then be matched on in a view function to resolve to a specific route.
I've added a "route-string-matcher" syntax similar to react-router's (but different enough to be incompatible). The Matcher created by a macro that consumes this "route-string-matcher" is then used inside a nested router component to determine if that route should call its render function. The drawback of my solution is that my nested-component router currently doesn't allow callbacks to the grandparent component, and if it did, it would appear to be relatively verbose and less ergonomic, reducing the utility of the crate.
@Boscop has a suggestion for replacing your current macro with a Proc macro that can take attributes on enum variants and produce a function (or a function as part of a trait implementation) that takes a String and optionally returns one of the enum variants the macro was used on.
Should the syntax of the existing route matchers be good enough, @Boscop could use that to specify what strings should match which enum variants.
Where to go from here:
I'm open to merging the projects.
The initial concern would be the introduction of a whole bunch of (often conflicting) names to the merged project.
You have an existing released crate for which I assume you don't want to break the API of significantly, and I have a bunch of structs/components that share the names of many things already in your crate.
I would think the initial order of business would be to determine who is merging their project into the other's, and how will naming conflicts be handled?
From there, we can work on replacing the fragment routing macro with the one proposed by @Boscop.

@Boscop I have an modified proposal to the issue you mentioned here: https://github.com/yewstack/yew_router/issues/80

Sounds all good to me. I’m definitely in favor of a proc macro as main API surface, which would break the API in any case. This means I’m open to archive my project and (not sure if that is possible right now) release the crate name.
I like the name yew-router, and this seems the most official place for a project like it. WDYT?

My concern is about the renaming of what you currently call Router with RouteAgent and Route with RouteInfo, which would be a significant breakage for anyone currently using the lib. If you're fine with it, we can keep the names currently within this crate, or we can create a separate issue, enumerate the names of items in both crates, and suggest a renaming scheme between the two.

Reach out to @jstarry to be added to the yewstack org so you and I can have joint ownership over this project. I believe that you can't abandon/archive a project on crates.io, but you can transfer ownership. I think the intention is to transfer ownership of the yew-router crate name to jstarry & dennis. AFAIK, they will handle releases for projects within the org.

Feel free to carve out sections that you want responsibility over using a codeowners file. I don't have experience with using that feature, but I'm open to seeing how it works. As a fallback, I feel that through GH Issues we can communicate in advance any changes that might interfere with each other's respective "domains".

My concern is about the renaming of what you currently call Router with RouteAgent and Route with RouteInfo, which would be a significant breakage for anyone currently using the lib. If you're fine with it, we can keep the names currently within this crate, or we can create a separate issue, enumerate the names of items in both crates, and suggest a renaming scheme between the two.

I would keep your names for now and we can revisit the naming conventions later on to keep code changes as low as possible for now.

Reach out to @jstarry to be added to the yewstack org so you and I can have joint ownership over this project. I believe that you can't abandon/archive a project on crates.io, but you can transfer ownership. I think the intention is to transfer ownership of the yew-router crate name to jstarry & dennis. AFAIK, they will handle releases for projects within the org.

Feel free to carve out sections that you want responsibility over using a codeowners file. I don't have experience with using that feature, but I'm open to seeing how it works. As a fallback, I feel that through GH Issues we can communicate in advance any changes that might interfere with each other's respective "domains".

Sounds good, thanks! I will target to archive my project at the end of the week if every pre-condition is done until that time. :)

Btw, when doing client-side routing I usually only fetch the route in the top-level (app) component.
That's how I was doing it in PureScript/Halogen at least.
Nested enums map well to sub-routing:
For routing within subcomponents the parent component passes down the sub-route for the child. There is never a need for any child to interface with the browser's history API (not even indirectly), so this approach would not require a RouterAgent, only a RouterService, since only the top-level app component has to interface with the history API, and can thus just own the only required instance of RouterService.
It's easier to reason about routing behavior when keeping the top-level app component as the "master", telling each child what to show, instead of letting children interface with the history API behind the App's back and make their own routing decisions (the child's route state should be functionally dependent on the parent's route state).
What do you guys think about this approach, and about getting rid of RouterAgent?

I agree with the premise of having a monolithic router and passing sub-routes as props being a good (or even best) practice, but I don't see a strong reason not to allow nested routers to exist.
The value in having a RouterAgent is that you have an entity that can respond to changes made from the application itself. While you can use the service to subscribe to PopState events, if you have a button that changes the URL location, there is no way of notifying the component responsible for routing without having to bubble up the request to change the route to the routing component.
Using an agent circumvents the need to handle route change messages throughout an app and allows only interested components to involve themselves in routing details. I think its a pretty common case where someone using a routing library wants to just have button or link that they can use to change the route. Until yew comes up with a better way of notifying arbitrary components of changes to app state, I don't see a good argument to remove the agent.

@saschagrunert Justin is attempting to add you to the org and project, but apparently requires Denis's permission, as he has "root" authority over the organization, and he hasn't been reachable for a few days.

@saschagrunert Justin is attempting to add you to the org and project, but apparently requires Denis's permission, as he has "root" authority over the organization, and he hasn't been reachable for a few days.

Alright thanks for the heads up.

Ok @saschagrunert you should have received an invite to be a maintainer of this repo 👍

Got the invitation and deprecated https://github.com/saschagrunert/yew-router right now.

I added @DenisKolodin, @jstarry and @hgzimmerman to the crate owners of https://crates.io/crates/yew-router, If you have the same names like on GitHub, then you've should got an invite.

Thanks! We have decided for the moment to use keybase for internal communications. You can follow me id:hzimmerman, and reach out to id:jstarry to be added to our group.
(For anyone else reading this, the gitter lobby, or opening Issues in appropriate projects are the best way to reach out to us otherwise)

Hey @saschagrunert I see that you haven't joined the yewstack org yet. Is everything good?
I'd like to get this issue closed, and have you more acquainted with this lib. The significant churn in the project should be just about done now, and hopefully the outlined remaining changes, which are mostly macro and parser related will be done in a week or so.
If you want to get back to maintaining something that is relatively static, just about now is the time. Let me know if you want any assistance finding anything, or have any comments about where to take the project.

Hey @saschagrunert I see that you haven't joined the yewstack org yet. Is everything good?

Hey, I think I was only invited to this repository and not the the organization. :)

I'd like to get this issue closed, and have you more acquainted with this lib. The significant churn in the project should be just about done now, and hopefully the outlined remaining changes, which are mostly macro and parser related will be done in a week or so.
If you want to get back to maintaining something that is relatively static, just about now is the time. Let me know if you want any assistance finding anything, or have any comments about where to take the project.

Thanks, I saw that most of the proposed changes were already tackled by you, well done! I will switch over my webapp.rs to the new router in the next week, to see how it works in general and think about improvements.
Feel free to close this if you want to.

Ah, all good then. I look forward to any feedback you have.


feat: initialize kurtosis package

Overview

Currently struggling with error log
  == FINISHED SERVICE 'wasm' LOGS ===================================
  Caused by: An error occurred while waiting for all TCP and UDP ports to be open
  Caused by: Unsuccessful ports check for IP '<IP_ADDRESS>' and port spec '{privatePortSpec:0xc001c77410}', even after '240' retries with '500' milliseconds in between retries. Timeout '2m0s' has been reached
  Caused by: An error occurred while calling network address '<IP_ADDRESS>:36657' with port protocol 'TCP' and using time out '200ms'
  Caused by: dial tcp <IP_ADDRESS>:36657: connect: connection refused


Is there any plan on supporting Notion as data source

Is there any plan on supporting Notion as data source  like https://github.com/mayneyao/gine-blog

It seems like an interesting idea, but I haven't look into Notion API so much, so I can't say for sure. Currently I'd rather stay on using Markdown files as data source.

thank you  ! have a good nice day


Support Azure as a cloud provider for kubernetes

any idea if this will happen?

Setting up the Azure cloud provider (without using ACS) seems more difficult than with other clouds. It's more likely that we'll support the ability to import an existing ACS-managed cluster into Rancher.
What functionality are you primarily looking for? Using Azure persistent volumes?

The only functionality I’d really like is to be able to use the Azure LB from Kubernetes and eventually kubernetes cluster-autoscaler, which works currently on AWS.
On Mon, Aug 7, 2017 at 2:13 PM, Josh Curl<EMAIL_ADDRESS>wrote:
Setting up the Azure cloud provider (without using ACS) seems more difficult than with other clouds. It's more likely that we'll support the ability to import an existing ACS-managed cluster into Rancher.
What functionality are you primarily looking for? Using Azure persistent volumes?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub [https://github.com/rancher/rancher/issues/8721#issuecomment-320738932] , or mute the thread [https://github.com/notifications/unsubscribe-auth/ABu0adc-Ra3Q3yqVxtf0cBF3HCoAm4NGks5sV1O6gaJpZM4NWOge] .

As part of the implementation, support for CIFS mounts should be added to the kubelet image in order to support Azure File persistent volumes.

https://github.com/rancher/kubernetes-package/pull/106
https://github.com/rancher/rancher-catalog/pull/971

Tested functionality:

Azure-files
Azure dedicated blob disks
Azure shared blob disks
Azure load balancers

Issues:

There are some random timeouts with the Azure load balancer. Seems related to configuration on Azure side. Still looking into it.

Rancher server: v1.6.11-rc4
Tested the following functionalities:

Azure-files
Azure dedicated blob disks
Azure shared blob disks
Azure load balancers

Found one problem with load balancer where it only passes request to one server, after investigating the problem we found that controller manager opens certain ports that are specified in the load balancer configuration in the node's security group, however since security group is one of variables that are being fetched by controller manager from the Azure API then the only security group that is being modified is where the controller manager resides:
root@5bfd35bf7267:/# cat /etc/kubernetes/cloud-provider-config
aadClientId: 54d17b5f-0d07-41a9-8744-c6f5846826ce
aadClientSecret: eFo+8b8VRg7filZyR6ciQkrs+PZFTg+V0oAPW1t72IQ=
tenantId: abb5adde-bee8-4821-8b03-e63efdc7701c
subscriptionId: 14a619f7-a887-4635-8647-d8f46f92eaac
cloud: AzurePublicCloud
location: westus
resourceGroup: docker-machine
subnetName: docker-machine
vnetName: docker-machine-vnet
securityGroupName: hgalal-srv1-firewall

Since docker machine doesn't support specifying security group name when creating servers, then security group names should be passed to controller manager as a variable.
CC @moelsayed @alena1108

Rancher server: v1.6.11-rc5
I was able to validate Azure load balancer by specifying the security group name when trying to deploy kubernetes, the load balancer distributed the requests between all hosts correctly.


BUG: Round 3 VeText inbound 502's

Description
Twilio says they sent us a message and we did not respond. We see this in a few dozen of the 170K or so messages per day.
Up to this point we have done the following:

Verify no paths within the code that would exit without returning a value to Twilio
Timebox our connection to VeText so Twilio does not say we're not responsive (will still be some 502s due to an AWS SSM issue, but the message IS handled)
Identified that the relevant MessageSids never appear in our logs
Logged no warnings, errors, or exceptions when the MessageSids do not appear in our logs (looking at logs in the given time range)
We observe zero 4/5xx errors within the Target Group
We scoured ALB logs at the times messages were disappearing and found no errors
We reached out with a TIC request to see if the VA was intercepting and rejecting the messages, they spent two days reviewing and found none

To Reproduce
We are at the mercy of Twilio. There is no specific time or message that we know of which is causing this. We reached out to VeText to see if there was anything odd about the messages and they said they were normal messages.
Expected behavior
We expect zero 502's in Twilio's logs for our endpoint.
Screenshots

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @ianperera @jakehova @k-macmillan @kalbfled @trevor2718 @ldraney

@jakehova @ldraney please schedule a couple hours next week to dive into this. If you have any questions about what has been done thus far reach out to @k-macmillan

The issue with this is the content type headers we are applying to our response to Twilio.  I used my personal Twilio account to send messages to our dev reverse proxy ALB endpoint.  When I returned the object we are returning from the VeText forwarder, I got errors in my Twilio log similar to what VeText sees.  When I simplified the response to just status code:
 { statusCode: 200 }

Twilio accepted the response with no error.  I also tested returning 500 as statusCode and Twilio reflected an error with thatparticular message.
So the solution here is to remove the specification for XML headers from our response, or simply change the create twilio response method to return a simple statusCode object with the appropriate status code.

We will see if #1117 fixes it. We won't know until it's been ran for some  time so we can observe the lack of errors.

I've added #1111 as a dependency on this ticket. If this ticket is still needed, we'll work on it some more to get it ready for refinement.

Still valid.


Video link was broken

Not sure if the video was moved or what happened but the link was broken

@sebagomez please sign your commit :wink:

🤦♂ it should have been signed... let me look at that

Will create another one. I need to recreate my keys


Inheritance issue

Mantle has the +classForParsingJSONDictionary: method to handle models subclassed from a root model. What about Realm-JSON? How to address inheritance?

There isn't support for this at the moment.


Unable to boot instance from TheSparkBox image

Initially I tried setting up the environment locally with Docker, which seemed to work until I experienced this.
Now I'm trying to do the setup on the SNIC cloud instead, but I'm unable to create an instance using the TheSparkBox image. This is the error message I get:

Error: Failed to perform requested operation on instance "spark_instance", the instance has an error status: Please try again later [Error: Build of instance 5f1175a7-803e-4161-b345-c6b1f62afd41 aborted: Block Device Mapping is Invalid.].

Hi @fwerpers. I am not commenting on the first issue, as it is still open in Docker. However, a few other students experienced your same problem on the SNIC cloud, and I think I can help there. When I saw this error before, it was enough to start the instance from the images menu' clicking on launch, instead of starting a new instance and then selecting the image. Please try this, and let me know how it goes.

Yep, that worked. The difference when starting an instance from the images menu seems to be that the "Create New Volume" option is set to "No". When starting it from the instances menu it is set to "Yes", which seems to have caused the error.
Thanks! 👍

Good, thanks for sorting this out!

But it is strange that it does not work to boot instances backed by volumes.
Mvh
Andreas
————————————————————————
Andreas Hellander
Associate Professor in Scientific Computing
Project Leader SNIC Science Cloud
Department of Information Technology, Uppsala University
<EMAIL_ADDRESS>
On 04 May 2017, at 10:14, Marco Capuccini<EMAIL_ADDRESS>wrote:
Good, thanks for sorting this out!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SNICScienceCloud/LDSA-Spark/issues/1#issuecomment-299122549, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQT5sIpldZbh9OrKcroF1_wFwvLhQFlks5r2YjggaJpZM4NPbSp.

yeah... we should probably write to support


Derived work license

Hi,
I am the owner of https://github.com/TheBiggerGuy/docker-ads-b and it appears this project is heavily derived from it. The original project is under the MIT licence and I invite people to fork and generally do what they want with it. However the only requirement is that you maintain the licence text.

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
_https://github.com/TheBiggerGuy/docker-ads-b/blob/latest/LICENSE_

Please could you correct me on my assumption that this project is derivative or include the required LICENSE file.
Please feel free to contact me for more information or questions.

Very fair! I forgot to add it to this one ;)
https://github.com/ShoGinn/docker-ads-b/commit/41382284f0f7affd65f9266e3776608f5ac7148c


Jacoco coverage

Magnet generates a couple of classes that count towards Jacoco's method and instruction coverage. Now it's possible to ignore those based on wildcards (e.g. *MagnetIndexer, *MagnetFactory), even nicer however would be if the types itself would be annotated as generated code, so they would be automatically ignored.
Newer Jacoco versions just need to find a class or runtime annotation that contains the string Generated in it's simple name to recognize ignorable types and go ahead. We have this here in our code base (Kotlin):
@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION, AnnotationTarget.CONSTRUCTOR)
@Retention(AnnotationRetention.BINARY) // this is translated to `RetentionPolicy.CLASS` in
annotation class Generated

+1 for the Generated annotation.

Thanks a lot!


try -j 1 to help Saleem diagnose

This PR should get discarded once we understand the Windoze problem
/cc @compnerd

Experiment completed.


MDM - Capability to identify and highlight external data from business applications

Is your feature request related to a problem? Please describe.
In my organization, we use a central MDM tool as the main data reference for all business applications. When these applications engage with data not already present in our reference, these data points are automatically identified and subsequently added to the reference, post validation by a Data Steward or similar role. This process can be quite manual and time-consuming and we'd like to improve our capacity to control data quality in an automated manner.
Describe the solution you'd like
We would like OpenMetadata to provide a feature that can identify and highlight data from business applications that exist outside of our unique reference. We're looking for an automated way to flag these external data points so that they can be more effectively managed. This will streamline our data management process and improve overall data quality.
Describe alternatives you've considered
We have considered developing an in-house solution to address this issue but believe that such a feature could be beneficial to all users of OpenMetadata, hence our feature request. We've also thought about manually checking for and managing external data points but this method is not sustainable given the growing volume of data.
Additional context
Managing our data effectively is a key priority in our organization and this feature could significantly enhance our ability to do so. We also believe that this functionality could be beneficial to other users of OpenMetadata as it could provide a more robust mechanism for managing data points that exist outside of a central reference. Thank you for considering this feature request.

I have the same interest in this issue, but I think I could describe the other way of this feature.
***Describe the solution you'd like
1/ Create a new page like Reference Data Management where the user can create and manage Set of Value:
----- Set of Value information

Name of Set
Description of set
List of Value
List of abnormal Value
-- Value information---------
Name of Value
Description of Value
2/ New Field on Schema to tag Column to which set of values based on  business and description of each column
3/ Add new profiler task: Compare the value of the column with the set of values to find out which is an outlier and report to user.

Not sure is same what u want @aitkar, If not let me know and I will ask in other post. Thanks!

Thank you @hoangdh5 for your response.
I understand your preference. I would like OpenMetadata to directly connect to our central MDM tool instead of managing a separate list of values within OpenMetadata. This would allow OpenMetadata to retrieve real-time reference information from our MDM and use it to identify data coming from external business applications that are not part of the reference.
The advantage of this approach would be automatic synchronization with our MDM (which is on a simple SQL Server database), ensuring that the data used in our business applications always matches the current reference values, without the need for manual maintenance of value lists in OpenMetadata.
Moreover, starting with a simple and easy-to-implement solution in OpenMetadata would be a good first step. We can build upon it and gradually enhance the functionality.
Thank you for considering this suggestion. Your feedback and support are appreciated.

@aitkar @hoangdh5 any reason for not using a Container entity to denote the data that's coming in externally?

@harshach
Thank you for your suggestion of using a 'Container' entity to represent the incoming external data.
This is an approach I haven't considered, and I am interested in learning more about how this could work. Could you provide me with more details on how I might use a 'Container' entity to implement this functionality? For instance, how might the 'Container' entity interact with my central MDM tool to identify and manage data that is not already present in our reference? And how could I use this feature to enhance our data quality in an automated way?


Remove lxml upper version pin

I'm the maintainer of an application which pins a recent version of lxml (applications should ideally pin everything to have a known-good set of deps). One of the users now reported that they cannot install python-saml in the same environment because it pins the upper version of lxml.
Assuming there are no breaking changes (after all, it's not a major version bump), would you consider removing this upper bound?

ping @pitbulk

Ah, just realized this is the python2 version..


Stacked panel animation runs in wrong direction

It runs in the right direction the first time, but in the opposite direction afterwards
See discussions here: https://github.com/zakodium-oss/react-science/pull/655
and here: https://github.com/zakodium-oss/react-science/pull/633#issuecomment-1916776103

Submitted a bug report in blueprintjs:
https://github.com/palantir/blueprint/issues/6723

https://github.com/palantir/blueprint/pull/6847

Fixed on main after blueprintjs was updated


toImage that does not block the GPU/rasterizer thread, but runs on a separate CPU thread?

Use case
(I am willing to PR!)
Hi thanks for the wonderful Flutter framework! I am proposing to have something like await layer.toImage(nonBlockingRasterizerThread: true).
Firstly, IMHO this feature has general purposes: When people are calling toImage, they may not want it to block the main rasterizer. For example, it looks great to take a "screenshot" (by toImage) and at the same time make animations still smooth. However, using the current toImage, I observe it blocks the GPU thread (rasterizer thread). Thus, if toImage takes 200ms, then the UI will jank for 200ms.
My (simplified) use case is as follows: Imagine the page as nothing but a painter app (but with complex rendering). Since I want the rendering to be smooth even when there is 1000 strokes (i.e. Canvas.drawPath), I used toImage and incremental rendering. More specifically, as suggested in https://github.com/flutter/flutter/issues/122566 by @dnfield, @jason-simmons and @jonahwilliams (thank you!), I call toImage periodically and asynchronously to "snapshot" the current scenario, and draw only the few strokes that has not been snapshoted. Code looks like:
void paint() {
  canvas.drawImage(snapshot);
  for(var stroke in strokesThatHasNotBeenSnapshoted) canvas.drawPath(stroke);
  if (timeHasElapsedForAFewSeconds) layer.toImage().then((x) => snapshot = x);
}

Now the problem is: toImage takes too long time that blocks the rasterizer thread. As mentioned above, it seems that toImage will block the rasterizer thread.
Proposal
As mentioned above, it would be great to have a flag that makes toImage not block the GPU/rasterizer thread, but runs on a separate CPU thread.
It may make it slower, but as long as not that slow IMHO it is acceptable. toImage is already async and never guarantee it is finished at the current frame.
P.S. Sample timeline if you are interested:

This proposal has a few challenges:

It doesn't really make sense to have multiple threads talking to the drive to do rendering. If you want to do GPU accellerated rendering (which Flutter does), you can't just throw the work on another thread. The GPU can only do so much work.
If we do software rendering it'll be possible to offload that to some other thread - but it's expensive (both in terms of including a working software renderer and making sure that renderer can render something pretty close to what the GPU backed renderer does, and in terms of the computational cost). Running a software renderer on another thread while your application is trying to render at 60+fps is likely to cause problems.
Repeatedly snapshotting a picture as it changes isn't something we support very well right now, but I'm not sure that this is really the right way to support it. For example, there might be some way to do this by having an API that would let you somehow keep iteratively updating a texture.

Another alternative is to just try to make rendering so fast that you don't want to do this at all. And yet another alternative would be to have the painting application do a more efficient job of keeping track of the geometry it's drawing and compacting/updating the geometry to avoid unnecessary complexity (i.e. instead of drawing 1000 strokes with relatively small cubics, draw a single stroke with far fewer cubics that describe roughly the same curvature).

@dnfield Thank you for the insights! Now I see this proposal has some challenges.

Repeatedly snapshotting a picture as it changes isn't something we support very well right now, but I'm not sure that this is really the right way to support it. For example, there might be some way to do this by having an API that would let you somehow keep iteratively updating a texture.

I am interested in adding that API, or anything that can make my app (just imagine as a painter app) smoother, and am willing to make a PR! May I know a bit more about it?
Btw more context: It is an incremental change, as you know, every a few seconds users just add one stroke. (not sure whether this information helps)

Another alternative is to just try to make rendering so fast that you don't want to do this at all.

I guess https://github.com/flutter/flutter/issues/124828 can partially solve this (willing to PR as well)
In addition, I am not very sure what you are pointing to. I guess this means modifying the rendering system, so maybe I should go to make a PR for Impeller (or Skia? but I think skia will be deprecated) for its rendering of bezier curves?

And yet another alternative would be to have the painting application do a more efficient job of keeping track of the geometry it's drawing and compacting/updating the geometry to avoid unnecessary complexity (i.e. instead of drawing 1000 strokes with relatively small cubics, draw a single stroke with far fewer cubics that describe roughly the same curvature).

I already did optimizations to reduce number of Paths and number of nodes in paths (IIRC suggested by you long ago - thank you!). However, there is just many paths. Not exactly 1000 (just an artificial number when I wrote the post above) though, but a rough number is that, it can be ~300 Paths, each having ~15 vertices and uses bezier curve.
Btw, each Path is a "natural" stroke in the painter-like app. Thus I guess I cannot merge multiple paths into one.

[...] having an API that would let you somehow keep iteratively updating a texture

As a side remark, I have briefly checked some blogs about how Android can implement the painter-like scenario. Interestingly, Android seems to be able to do it easily!
Pseudo-code:
Bitmap bufferBitmap = Bitmap.create();
Canvas bufferCanvas = new Canvas(bufferBitmap);

private void userAddsOneStroke(){
    bufferCanvas.drawPath(theNewStroke);
}

@Override
protected void onDraw(Canvas canvas) {
    canvas.drawBitmap(bufferBitmap);
}

Explanation and comparison:
It seems that the main difference is, Android Bitmap is mutable. Thus, we can easily modify a few pixels of the bitmap (via Canvas(bitmap).drawPath()).
I am not an Android expert, so this is just a side remark and hopefully this may be useful for API design of Flutter.

What @fzyzcjy is trying to do sounds reasonable, trying to render thousands of strokes performantly by incrementally snapshotting. But the tools we have exposed currently only allow for host accessible snapshots. Host snapshots are unnecessary for this purpose and slow to create. The issue here is asking for taking the slow bits and moving to another thread.
IMHO, the more accurate feature request here is for device snapshots. This avoid the roundtrip altogether (and less memory use) and fixes @fzyzcjy use-case.

We could also expose a render target like API to allow incremental rendering. I'm not sure exactly how that would work though

Thanks for the replies!

@chinmaygarde I think https://github.com/flutter/flutter/issues/124827 with a variant that returns an immutable device texture is the way to go.

Not very sure, do you mean #124828?
Btw about #124828 - I have done some slight experiments at https://github.com/flutter/engine/pull/41198#issuecomment-1508549749. It seems that Impeller does not have this transfer at all, i.e. toImage in Impeller returns image at GPU(device) buffer instead of CPU memory, if I understand correctly?

@jonahwilliams We could also expose a render target like API to allow incremental rendering. I'm not sure exactly how that would work though

:eyes: Also not very sure what API will it look like


Update AutoRest C# version

Update AutoRest C# version to 3.0.0-beta.20220623.1

Conflict resolving at https://github.com/Azure/azure-sdk-for-net/pull/29073


Template Add new hygen generators [ch131252]

Added hygen generator for components, models and slices.

Please don't merge until coordination with us


Add SM Armory from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of RecoverMod, to add SM Armory to CKAN.
Please direct questions about this pull request to RecoverMod.
Mod details:
name = /mod/2162/SM%20Armory
author = RecoverMod
abstract = Works for KSP 1.4 and upwards
license = GPLv3
Homepage =
description =
Works for KSP 1.4 and upwards

#rebuild

"RecoverMod" appears to not be the author, and the forum thread was locked in March.
Closing due to obvious shenanigans.


Version to support Sphinx?

This Quiz generator is incredible! Will there be any plans for this quiz generator to be usable within Sphinx as a directive of some sort? Thanks!

Thanks @Josh-Hiz for the compliment. For the time being a PR would be appreciated for this requirement.


BAQE-2206: Add kogito-tooling-prelease branch trigger

Thank you for submitting this pull request
JIRA: https://issues.redhat.com/browse/BAQE-2206
referenced Pull Requests:
https://github.com/kiegroup/run-tests-with-build/pull/47

How to retest a PR or trigger a specific build:

* a pull request please add comment: Jenkins retest this

@Ginxo @winklerm Could you please check if this is a correct way to introduce such job? any pointers are welcome

Squashed & rebased, I still need some help setting up the infra, so please hold with merge.

@winklerm @mbiarnes ready for review


Converted Automate Simulation tree to use TreeBuilder class

https://www.pivotaltracker.com/story/show/123573031
@dclarizio please review/test
before

after

@martinpovolny please review

@martinpovolny please re-review addressed your comments.

 :warning: - Line 31, Col 24 - Lint/UnusedMethodArgument - Unused method argument - count_only. If it's necessary, use _ or _count_only as an argument name to indicate that it won't be used. You can also write as x_get_tree_roots(*) if you want the method to accept any arguments but don't care about them.

this seems to make sense to fix
Other that that I think we are good to merge.

Verified in the UI.


Support for string/text-style vendor options

In some cases a printer has options of string or text style and not enumerated choice, for example passwords, PINs, fax numbers, individual watermark text, ...
In the test Printer Application you even use such an option for the label printer, which you call "vendor-text".
You create it by the following lines in the driver data callback:
  driver_data->vendor[4]  = "vendor-text";
  [...]
  ippAddString(*driver_attrs, IPP_TAG_PRINTER, IPP_TAG_TEXT, "vendor-text-default", NULL, "Hello, World!");

There is no vendor-text-supported attribute created.
Only due to the fact that we also want to save individual data (like the "Installable Options" in the PostScript Printer Application) in the state file you consider vendor options without ...-supported attribute as such individual data.
Now we need a solution to offer BOTH text/string-style options (where one can set a default in the web interface) AND saving individual data in the state file.
Or is there perhaps a useful ...-supported attribute which one could add to the vendor-text option to let it appear in the web interface and not breaking it?

My suggestion to solve this:
One could use the option name for distinguishing between string options and hidden options for holding individual data. Anything awkward prefix which is accepted in an IPP attribute name but not to be expected as an option name to be understood and used by a user.

I have a better suggestion: Use the data type IPP_TAG_STRING (string with additional length parameter, can but not must contain '\0' bytes) for hidden data and IPP_TAG_TEXT for text/string-style user-settable options:
  // Vendor option
  driver_data->vendor[4]  = "private-job-pin";
  ippAddString(*driver_attrs, IPP_TAG_PRINTER, IPP_TAG_TEXT, "private-job-pin-default", NULL, "0000");
  // Hidden data: Installable options
  inst_opt = "Tray2=Installed Finisher=Stapler";
  driver_data->vendor[5]  = "installable-options";
  ippAddOctetString(*driver_attrs, IPP_TAG_PRINTER, "installable-options-default", inst_opt, strlen(inst_opt));

WDYT?

I have implemented it now as this patch:
support-text-string-vendor-options.patch.txt
Here I use the IPP_TAG_STRING (octet string) data type for hidden data, like my "Installable Options" and IPP_TAG_TEXT for regular, user-settable, text/string options. Due to the nature of state files being plain text and so not able to carry binary data, the data type IPP_TAG_STRING is useless for regular options/attributes and can be easily abused for the hiddendata saving.
In the state file I precede the name with an asterisk (*) so that it is marked as hidden data and gets loaded again as IPP_TAG_STRING data type.
The patch also contains a use of this in the sample application and there it works correctly.
I am testing currently with the PostScript Printer Application.

Now I have done a real-life test of this by modifying the PostScript Printer Application appropriately and also adding support for the CUPS PPD extension of custom option values. This works as expected.
It especially allows now to print on PostScript printers from Ricoh and OEM with the PIN-based features of Locked Print, Document Server, and User Code, where the PIN is entered as a custom string/text option.
Here is the patch for the current GIT state of the PostScript Printer Application:
ppd-cups-custom-options-support.patch.txt

here is a sample PPD file of a Ricoh printer to test the above:
Ricoh-Aficio_2035_PS.ppd.txt
The three options for PIN-based printing allow entering arbitrary PINs as sustom strings, using the appropriate CUPS extension for PPD files. With the patches for PAPPL and for the PostScript Printer Application we have a hidden vendor option for holding the settings for the installable options and we have input lines for the PINs in the "Printing Defaults".

@tillkamppeter i will look at this but at the moment my PAPPL work is on the back burner as I finish up some stuff for a customer. Probably be a week or so before I can get back to this…

Update of the patch on the PostScript Printer Application to match with further development:
ppd-cups-custom-options-support.patch.txt

For testing the current Snap of the PostScript Printer Application in the Snap Store includes the patches attached here, allowing to use PIN-protected secure printing on all Ricoh (and OEM) PostScript printers.

With the addition of support for CUPS' PPD extension for custom option settings the patch for the Snap of the PostScript Printer Application only needs to provide the adaptations to work together with the patched PAPPL. Here is the new patch for the PostScript Printer Application:
support-new-pappl-string-options.patch.txt

@tillkamppeter What are you actually trying to do with this? You don't need this patch for custom text options ("vendor-xxx-default" saves the value, "job-creation-attributes-supported" lists the "vendor-xxx" attribute name), and honestly there is little point to exposing some of these printer-specific options (beyond defaults) because no IPP client will ever support them.

The reason for the patch is to have both the possibility for hidden state data of the driver, in my case the installable accessory configuration and the possibility to get free-formed-string-style options into the web interface. As IPP clients will usually not support the vendor options of the legacy (like ole printers which need a driver) or specialty (like Braille embossers, ...) printers, it is important that they all appear in the web interface, including the free-form-string ones. This way one can do for example secure printing on an old non-driverless-IPP printer. And in addition, the web interface does not expose any driver-internal state data which the user is not supposed to edit. So we have two types of vendor string options, hidden ones and exposed ones.
A name-prefix-based solution as I suggested earlier here would also do the trick, too, but I have no idea which name prefix would be suitable, as it has to be legal in IPP but somehow awkward that manufacturers/driver developers would not use it for actual attributes.

So for installable options we need to support "xxx-configured" instead of "xxx-default" for the value. These won't be free-form, just keywords ("xxx-configured" is a keyword and "xxx-suppported" is a list of keywords) and boolean ("xxx-configured" is a boolean). But since that is really specific to PPD-based drivers where you can't query the printer for its installed options, and non-PPD drivers typically don't have such things, I'm not keen on adding a lot of infrastructure for an edge case. Better to add printer-specific data and a custom web page for configuring installable options than to treat them as vendor-specific job options (which they aren't).
For vendor text options, I've just pushed a fix:
[master 5c687d8] Fix support for vendor text options (Issue #142)

Better to add printer-specific data and a custom web page for configuring installable options than to treat them as vendor-specific job options (which they aren't).

The custom web page is already there in the PostScript Printer Application, the "Device Settings", but how can I save the choices which the user has made there into the state file and load them from the state file in the next session of the Printer Application?

And one additional aspect of saving data which is not option settings in the state file is that Printer Applications can host any type of printer driver which could have really weird settings which are not mappable to IPP, but it is useful to set them in the web interface, like I have added a web interface page for the installable accessories and want to save what the user has chosen there.
For example if we take Gutenprint, a native Printer Application of Gutenprint. Gutenprint has tons of options, many being numerical. Trying to squeeze this into IPP attribute data types is awkward, not as awkward as cramming this into PPD option data types but it is awkward. We could instead create one or more extra pages in the web interface and put nice widgets onto them to make the adjustments and then we must save these settings somehow, as it would be awkward for the user to set them again and again for each new session. We could even allow the user to save named sets of settings and AFAIK IPP has also a job attribute to select from named presets (I do not remember the name). So then if the user has saved a named set of settings, the get-printer-attributes response would have the name listed in the appropriate ...-supported printer attribute. This way an IPP client can at least choose from the named presets.
Therefore we need a way to save extra (driver-specific) information in the state file which does not appear in any way on the standard web interface pages of PAPPL.

@tillkamppeter The papplPrinterOpenFile API can be used to save/restore printer-specific state information in a persistent location. The driver callback is responsible for creating/restoring the extension data (part of the pappl_pr_driver_data_t structure), with the delete_callback responsible for freeing the extension data. Your settings/configuration web page would then save the extension data whenever you change it.
WRT Gutenprint, presets ("job-presets-supported") can map to Gutenprint and user-defined named presets, with vendor collection attributes mapping to all of the driver settings for a theoretical "expert" print dialog that provides access to all of the individual settings while the standard print dialog provide access to the presets.

Could you add an example use/CI test for the papplPrinterOpenFile API to PAPPL's test Printer Application?

Thanks for the hint, I have checked this papplPrinterOpenFile() function now, and this should work as you described. Perhaps it can even simplify the driver setup in pappl-retrofit then, as I can decide where to load and save the data about the installable accesories, in contrary to the state file where PAPPL determines where it is loaded and saved.

Thanks a lot for your hint, @michaelrsweet, I have fixed pappl-retrofit (commit OpenPrinting/pappl-retrofit@4a54fb7148e9) appropriately now. So I can remove the patches on PAPPL and pappl-retrofit in my Snaps.

All the 4 retro-fitting Printer Applications in the Snap Store are appropriately updated now.
Thank you very much.


Abbs 0.7 - Incorporate Gartner and BDM Execs feedback

Gartner:

Recommended having an exec summary at the very beginning
PACE layer approach to decoupling (records, differentiation, innovation)

BDM:

Needed more clarification on how maintain OSS (could possibly be part of OSS Strategy but can also directly point to OSS Framework)

Mentioned the notion of "good" vs "bad" open source (note: should include notion of good vs bad software period, OSS is the license model, not the software...)

Skills and Support models

Needed better clarification on how we acquire the skills to move forward with a solution under the Strategy's POV:

In the case where we don't have all the required employees or the employees do not have the current knowledge of a product, what to do then?
Specialized software, only personnel available/authorized is outside org, etc.

How do we maintain solutions? Vendor, SI, Internal, etc. (see presentation for disambiguation about possibilities; not addressing directly how)

Contractual obligations:

How do we ensure that we have the right contractual clauses in acquisition process to support loose coupling and maintaining models (long term contract with X means can't make changes to arch until end date, increases complexity of aligning various initiatives with ensuring support agreements, etc.)

Regarding reducing risks related to COTS product: introduce notion that there are specialized solutions vs generic solutions

Argument is that companies that have invested in niche markets have knowledge that org may not have, worked with many organizations to improve the "domain" so are more likely to add value.

General comment on document:
what the intent is vs how people will interpret it is most likely an issue --> need to make it easily understandable, no place for interpretation (use decision trees, checklists, official framework, etc.)
Document (mainly section on measures for success) is very IT focused, would help to align to Business outcomes instead

@remyb2canada thanks for the feedback!

@remyb2canada thanks for the feedback!

Great work! Friendly reminder to update the Changelog at the end :)

Great work! Friendly reminder to update the Changelog at the end :)

Oh sorry, didn't notice it was a draft PR. Well, it's going to be pre-approved anyway then, it's on the right track 😉

Oh sorry, didn't notice it was a draft PR. Well, it's going to be pre-approved anyway then, it's on the right track 😉

Closes:

#1249
#1381
#1353
#1382


Fix JS alternate names

Fix https://github.com/openwebdocs/mdn-bcd-collector/issues/854

Remove Atomics.wake and old Intl.Locale members from customJS
Properly ignore String.prototype.trimLeft/Right
Remove ignore case for WaiterRecord and WaiterListRecords, seems unneeded.

@queengooborg  I didn't see https://github.com/openwebdocs/mdn-bcd-collector/commit/fd987b759a7fa0f006f2b4ffbaa92aa67a745140... I think it doesn't quite work. Would you mind switching to PRs? Otherwise, I'm not really informed about changes that are made to the collector. PRs are actually a nice way to see what is going on.


Support cargo-binstall

Hi,
I'm trying to use cargo llvm-cov during CI, and it would be nice to be able to use cargo bininstall to set up cargo llvm-cov. It seems this would almost work:
$ ./cargo-binstall --no-confirm --version 0.4.1 cargo-llvm-cov
21:39:06 [INFO] Installing package: 'cargo-llvm-cov'
21:39:09 [INFO] Checking for package at: 'https://github.com/taiki-e/cargo-llvm-cov/releases/download/v0.4.1/cargo-llvm-cov-x86_64-unknown-linux-gnu-v0.4.1.tgz'

and then it finds that there is no such artifact & builds from source, which slows down CI.
So it looks for cargo-llvm-cov-x86_64-unknown-linux-gnu-v0.4.1.tgz, while you provide cargo-llvm-cov-x86_64-unknown-linux-gnu.tar.gz. Would it be possible to rename these, so cargo-bininstall works with cargo-llvm-cov?
Thanks! :-)

It is intentional that the version number is not included, and I have no plans to change it. See https://github.com/cross-rs/cross/issues/457 and https://github.com/taiki-e/cargo-hack/pull/91 for the reason.
Instead, I would accept a PR to add metadata to Cargo.toml to support cargo-binstall.

I see, thanks for explaining the current state. Will submit a PR in a moment.


Request: Add Clone Method to IFixture

Introduction
I would like if IFixture had a Clone method or something similar to create a copy of the fixture.
At the moment I can create an extension method to do this:
public static IFixture Clone( this IFixture fixture)
{
   var cloneFixture = new Fixture();

   cloneFixture.Behaviors.Clear();
   foreach ( var behavior in fixture.Behaviors)
   {
      cloneFixture.Behaviors.Add( behavior );
   }

   cloneFixture.Customizations.Clear();
   foreach ( var customization in fixture.Customizations )
   {
      cloneFixture.Customizations.Add( customization );
   }

   cloneFixture.OmitAutoProperties = fixture.OmitAutoProperties;
   cloneFixture.RepeatCount = fixture.RepeatCount;

   cloneFixture.ResidueCollectors.Clear();
   foreach ( var residueCollector in fixture.ResidueCollectors )
   {
      cloneFixture.ResidueCollectors.Add( residueCollector );
   }

   return cloneFixture;
}

But I feel such an ability to make a copy ought to be in the project itself.
Details
My scenario is I construct a couple instances of a class with a lot of parameters in a test.  In addition I want to have a constructor parameter be a certain value for one instance and a different constructor value for a different instance.  There are several ways I can do this; the way I have been doing it is:
fixture.Customizations.Add( new FilteringSpecimenBuilder(
            new FixedBuilder( mediaId ),
            new ParameterSpecification(
                typeof( ObjectId ),
                "mediaId" ) ) );
var mediaVM = fixture.Build<MediaViewModel>()
                     .With( mvm => mvm.ParentMixerId, mixerId )
                     .With( mvm => mvm.TrackId, trackId )
                     .Create();

_ = fixture.Customizations.Remove( fixture.Customizations.Last() );

//...

The reason for the removal of the customization is I tried without it thinking maybe the last customization added will have a higher precedence and be used; but it wasn't the case.
If I try to simplify this with some sort of extension method like so:
public static IFixture AddCustomization<T>( this IFixture fixture, T value, string name )
{
   fixture.Customizations.Add( new FilteringSpecimenBuilder(
         new FixedBuilder( value ),
         new ParameterSpecification(
            typeof( T ),
            name ) ) );
   return fixture;
}

It might work in some places but won't in others because after the object is built the fixture contains a customization I no longer desire and I need to remove.
I would prefer not to have a line to remove the added customization(s).  So if instead my extension method made a copy of my fixture to which I add modifications to the copy then my creations works as expected and the original fixture is untouched.
Also would work is the ability to add a customization that is automatically removed after the object is created.
Hope this all makes sense.
Thanks for considering my issue :smiley:

@ajorians Good day! From how I understood your example, it sounds like we already have what you need. The Build() method of fixture is actually creating an immutable copy of internal graph, so you can apply "one time" customizations on top of the AutoFixture without persisting them.
Review this playground demo:
public class Model
{
    public int Id { get; set; }
    public string Name { get; set; }
}

[Fact]
public void Demo()
{
    var fixture = new Fixture();
    fixture.Customize<Model>(c => c.With(m => m.Id, 42));

    var value1 = fixture.Create<Model>();
    Assert.Equal(42, value1.Id);
    Assert.NotNull(value1.Name);

    var value2 = fixture.Build<Model>()
        .With(m => m.Id, (int genInt) => genInt * 2 /* make it always even */)
        .Without(x => x.Name)
        .Create();
    Assert.NotEqual(42, value2.Id);
    Assert.Equal(value2.Id % 2, 0);
    Assert.Null(value2.Name);

    var value3 = fixture.Create<Model>();
    Assert.Equal(42, value3.Id);
    Assert.NotNull(value3.Name);
}

Let us know whether it solves your needs. If not, please describe more specifically why it doesn't work for you, so we could try helping.
Thanks!

Hi @zvirja ,
Good day!
If I may; our Model class would not have a set and would only be settable through the constructor.  So if you were to substitute it with this:
public class Model
{
   public Model( int id, string name )
   {
      Id = id;
      Name = name;
   }

   public int Id { get; }
   public string Name { get; }
}

Sorry for not specifying that originally.
So as I understand things I have to add customizations in order to do constructor parameters.  And these customizations are before the Build().
If interested some of the reasons we do a lot in the constructor and without setters is so we can use the readonly keyword and be sure that the member variables are set and can't be unset by the time a method is called.
Hope that makes better sense.  Thanks for helping with this! :smiley:

@ajorians Do I understand your problem correctly, that you have a model with large amount input arguments, so you would like to customize just one of it, without having to explicitly worry about it. Right?
Otherwise, you can always write something like
var value2 = fixture.Build<Model>()
    .FromFactory((int id, string name) => new Model(id, name))
    .Create();

Unfortunately, it does not scale pretty good with growing number of parameters 😟

@ajorians Do I understand your problem correctly, that you have a model with large amount input arguments, so you would like to customize just one of it, without having to explicitly worry about it. Right?

Yes, that is exactly right.

Unfortunately, it does not scale pretty good with growing number of parameters 😟

Luckily Freeze works for many of our classes with growing number of parameters.  But yes the class I had in mind where I am using the customizations to do constructor parameters currently has more than 30 parameters:

And will probably grow an additional 4 or so before the end of this year.
I get this may be unusual.
But yes I have a large amount of growing input constructor arguments and I would like to customize just one (or a few) of them without thinking about the rest of them.  Without having that type registered or frozen for the whole test.  And in a concise way as adding a customization is about 5 lines of code.
I luckily am able to do all of that; but the way I did it involved making a clone extension method in my client-side code.
Hope this all makes sense.  Thanks for looking at this with me :smiley:

@ajorians I was about to close the issue due to inactivity but I could not walk by that gigantic constructor.
I got to ask, have you considered changing your design?
By looking at your constructor I can see several issues and potential solutions to your problem.
First of all you are mixing the concepts of newable and injectable entities.
The most straightforward solution is to move your injectable dependencies to properties and inject them using property injection.
This will solve your immediate problem of having to copy the Fixture and will make the constructor more manageable.
Second is addressing the over-injection code smell.
This means moving away the most commonly used together services into separate abstractions.
This should help your design respect the SRP and by extention it should reduce the huge amount of setup you have to do at the moment, in your tests.
Since the class is called ViewModel I assume you have a MVVM application. It is likely that you could further decouple your application by introducing a messaging model. Perhaps an event aggregator. Most MVVM frameworks have them built in so you don't have to do a lot of setup work, to benefit from them.
Let me know if this helps.

Hi @aivascu ,

@ajorians I was about to close the issue due to inactivity

If there is anything I can do just let me know.  Being a feature request I can see until implemented it might have quite a fair amount of inactivity.

I got to ask, have you considered changing your design?

At the moment we are considering becoming a prism application.  That would help with some of the items you mentioned.  But sadly I don't see us changing the philosophy of just put everything in the constructor such that it can be checked for null once and be readonly and always be non-null through the lifetime of the class.  We need to do something.  But I don't think this is going to improve in the next year or so.

Let me know if this helps.

All of this does help.  I'll let me team know that even people in the world think we need to consider making changes.
But if I may ask is it reasonable for IFixture to have a Clone or similar method?  Or somehow allow people to add a customization and then pop the last added customization off or somehow return to the state before adding a customization?  I do agree that understanding the scenario that prompts this desired behavior is important and certainly the scenario has many problems in the first place.  And I do see you don't want to add additional complexity unless there is a good use case.  Well you can choose what happens next but if I can help just let me know.
Thanks for reading and considering :smiley:

@ajorians my opinion is that we should not add a .Clone() method to the Fixture class. As I see it there should be only one test fixture at any given time for any single test.
There have been a few requests to implement an unfreeze/eject/freeze-once feature in the past but no one got to implement it.
I think the reason why is that there is no trivial way to reliably identify which builder is going to return the frozen value or what was the last injected value.
What you can do is implement a relay that ignores the requests after a certain count of successful resolutions, like below. You can also update the implementation to skip a certain amount of requests. The rest should be covered by the customization you used in the original post.
public class CountingRelay : ISpecimenBuilder
{
    public CountingRelay(ISpecimenBuilder builder, int maxCount)
    {
        this.MaxCount = maxCount;
        this.Builder = builder;
    }

    public int Count { get; private set; }
    public int MaxCount { get; }
    public ISpecimenBuilder Builder { get; }

    public object Create(object request, ISpecimenContext context)
    {
        if (this.Count == this.MaxCount) return new NoSpecimen();
        var result = this.Builder.Create(request, context);
        if (!(result is NoSpecimen)) this.Count++;
        return result;
    }
}

Hi @aivascu ,

@ajorians my opinion is that we should not add a .Clone() method to the Fixture class.

OK.  Well thank you for considering.

What you can do is implement a relay that ignores the requests after a certain count of successful resolutions

I'll take a look.
Thanks again!  :smiley:

@ajorians I've created a more formal feature request #1214 for explicit and automatic customization reset. You can track the progress of this feature there.


Fix dependency conflict for issue

#5

Revising urllib3 to resolve dependency conflict. @NeolithEra Thank you for the PR.


mismatch in defs ready event data callbacks

We probably need to provide one more prop: word, which should be a lexeme.lemma.word. It will be used as a lemma parameter in a message string: "{requestType} request is completed successfully. Lemma: \"{lemma}\"".
I'm not sure if this message will be ever shown in this particular case, but I think it's better to play safe.
Originally posted by @kirlat in https://github.com/alpheios-project/components/pull/799

the client adapter actually sets requestType and lemma and never homonym, for both the SHORT_DEFS_READY and FULL_DEFS_READY events. This needs to be fixes to the event data matches the expected structure.

hmm. it sets it differently in different places. sometimes it sends requestType and homonym and not lemma..


[Print Quality IOS] [TypeB] setting print quality not working on IOS

Setting the print quality on ios does not affect the quality works fine on android though
im using the printPdfFile method to print on both platforms.

Hi @zamvar ! Thanks for reaching out about this!
Yes, this is an issue with the version of the native iOS brother library. Changing the print quality on it won't have an effect.
They recently released an update which we have yet to integrate.

Hi @CodeMinion thanks for that quick response
looking forward to have that integrated, if i can find time will try solve it on my own then open a pull request.

Hi @CodeMinion
I encounter exactly the same problem, Print quality is not set on iOs:

In code i set print quality like this:
printInfo.printQuality = PrintQuality.HIGH_RESOLUTION;
Have you find any solution for this issue?
Best regards.
Alain Deseine


[WIP] Jenkins tests on Windows.

Summary
This PR enables Windows unit tests. (This is being submitted now to kick off the build on Jenkins.)
The goal is to fix all issues with Windows before this is merged.
Tests
Side Effects
Checklist

[x] Math issue #951

[x] Copyright holder: Generable
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[ ] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[ ] the code is written in idiomatic C++ and changes are documented in the doxygen

[ ] the new changes are tested

These are the changes I had to do in order to make things run and pass on Windows. It seems that matrix_exp_computeUV::run is having problems with stan::math::var Eigen matrices on Windows. The current solution is just a quick fix to see if this also works on CI. We need to find a more general solution probably.
@yizhang-cae can you please verify that this fix is actually OK.

The first problem I'm seeing is:

[ ] test/unit/math/prim/mat/err/check_pos_definite_test.exe

Oh, yeah.
This test causes the Windows Error Reporting popup on the EXPECT_DEATH, because the child process crashes as part of this death test. You need to manually cancel the popup and then the test continues and passes the tests. I did a quick fix based on this just to see if this fixes it. Should we upgrade the gtest lib?

Wow, you're fast! I was trying to dig into how to deal with the problem and
still searching whether it works on Windows.
Yes, I think we should update Google Test. It makes sense to be an
independent issue + PR. Want to get that started? Or I can write up the
issue if that helps.
On Tue, Oct 16, 2018 at 1:02 PM Rok Češnovar<EMAIL_ADDRESS>wrote:

Oh, yeah.
This test causes the Windows Error Reporting popup on the EXPECT_DEATH,
because the child process crashes as part of this death test. You need to
manually cancel the popup and then the test continues and passes the tests.
I did a quick fix based on this
https://github.com/google/googletest/pull/1120 just to see if this
fixes it. Should we upgrade the gtest lib?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1046#issuecomment-430316478, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F-4tRCasVvMfviKXbRXGX7cf2Fb8ks5ulhEggaJpZM4XASPZ
.

Yeah, no problem. I will do the issue tonight. The PR will have to wait till tomorrow, I have to finish up the docs stuff for the latest GPU PR.

After merging the gtest changes, tests now fail at the matrix_exp_multiply test.
I have written down the stuff I narrowed down so far on the seg fault in the discourse thread: https://discourse.mc-stan.org/t/the-math-library-is-not-passing-tests-on-windows-this-is-the-next-thing-im-working-on/5989/12?u=rok_cesnovar

Thanks! I'll set aside time to jump in this week.
On Mon, Oct 29, 2018 at 3:46 PM Rok Češnovar<EMAIL_ADDRESS>wrote:

After merging the gtest changes, tests now fail at the matrix_exp_multiply
test.
I have written down the stuff I narrowed down so far on the seg fault in
the discourse thread:
https://discourse.mc-stan.org/t/the-math-library-is-not-passing-tests-on-windows-this-is-the-next-thing-im-working-on/5989/12?u=rok_cesnovar
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1046#issuecomment-434052605, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_FxlBxNdR89wjTyNHfOKRnhkXPLbzks5up1sCgaJpZM4XASPZ
.

Ok... there's a fix for the segfault in matrix_exp_multiply. Hopefully that's it and we can get things testing on Windows again.

Thanks all! Taking a look and trying to get my bearings. Have a few questions:

ad_promotable had to be updated to include long double
Seems like it had long double before, here:
https://github.com/stan-dev/math/pull/1046/files#diff-0b6a929f9f467e93bc45dd154b930bfaL41
A lot of the promotable things seem to have been reordered, potentially? Just to double check, the order doesn't matter for semantics does it? Could someone possibly summarize what that bit is about for me? The rest of the changes look good.

@seantalts... I was incorrect. We had to add: long long and unsigned long long. (I just combed through all the changes and those were the two new ones.) I'll update the top-level comment.
I'm not sure why it was reordered, but the order shouldn't matter for semantics. Since we're being specific, the ADL rules should guarantee that it is able to promote.
It looks like there are 0 tests for ad_promotable. If you think it'd help, we should add them.

Gotcha. Tests would be helpful but I think that this PR will leave the codebase better than we found it, so I'm happy to let it go through as-is - just one more question about the abs vs. unsigned int in the tests.

@seantalts. I just added tests for ad_promotable. (It would have helped to have this test prior to the PR to isolate the issue, so I think it's good we add it now.)

@seantalts: updates since your review:

Added tests for ad_promotable for prim, rev, fwd, and mix.
Fixed a small typo for ad_promotable in prim
Changed the abs(Matrix<int>) to Matrix<unsigned int>. I agree that it's cleaner that way (and it mirrors the old code better.

@seantalts, mind reviewing again? The last changes were due to a mistake I made when updating from unit to unsigned int (then dealing with linting after that).

This commit fixes the error I introduced: https://github.com/stan-dev/math/pull/1046/commits/2c618de4022a03ae818a3d7da2dff295b540be24


Re-check case remove custom network

Describe the task
Re-check case remove custom network
Actual: Do not remove

Expect: Allow remove

@Sokol142196 I can't reproduce the bug
Note: Need to disable the custom network


Add Jest & Svelte Testing Library

Needs a simple test case once #7 lands.

Rebased on master and resolved package-lock.json conflict.

Thanks!


Play method using AVPlayerItem

Issue overview

[ ] Incorrect behavior
[X] Feature request
[ ] Crash
[ ] Help / documentation
[ ] Other: classification

Description of the problem
Using SRG Media Player, there is no way to handle authentication issues on a stream.  Because the API only exposes playing URLs, options like this one for setting auth headers on the AVURLAsset are unavailable.
Environment information

Library version: 2.2.2
iOS version: 11.0
Device: All

Reproducibility

[X] Always reproducible
[ ] Difficult to reproduce

Code sample
All of the playing methods seem to trace down to this:
- (void)prepareToPlayURL:(NSURL *)URL
                  atTime:(CMTime)time
            withSegments:(NSArray<id<SRGSegment>> *)segments
           targetSegment:(id<SRGSegment>)targetSegment
                userInfo:(NSDictionary *)userInfo
       completionHandler:(void (^)(void))completionHandler
{
    ...
    AVPlayerItem *playerItem = [[AVPlayerItem alloc] initWithURL:URL];
    self.player = [AVPlayer playerWithPlayerItem:playerItem];
    ...
}

Suggestions
Refactor the API to expose play methods that deal directly with the AVPlayerItem, giving users of the library a way to controls headers on requests.
...I would probably attempt a PR but my Objective-C is rusty, and for the moment, all I need is HTTP Basic Auth so I can hack it into the URL, so to speak.

I would rather investigate the possibility to do this with a custom AVAssetResourceLoader instead.
In fact, custom resource loader support is something we have planned for this year (and internally already implemented as a proof-of-concept). We should check whether request headers, for example, can be customized using a resource loader, and without using private stuff (which AVURLAssetHTTPHeaderFieldsKey seems to be) . If the answer is positive, I think this is the proper way to go.
In the meantime, I would suggest you use another approach if you can. An NSURLProtocol subclass might be a possibility as well.

I get what you're saying, and I get how you would want to avoid private stuff.
However, the specific example I give is not the only reason to expose an AVPlayerItem-based play method.  I am sure I could spend a couple of hours searching the docs and give you a dozen useful things that you could do by exposing this, and they would all be much easier than messing with AVAssetResourceLoader or NSURLProtocol.
Here's an example: blocking your HLS streams from loading over a cell connection.  Per apple's docs you can do this by setting the AVURLAssetAllowsCellularAccessKey on your AVURLAsset.  I would much rather do that than implement my own NSURLProtocol.
Can you tell me a reason why you shouldn't expose the AVPlayerItem (and thereby the AVAsset) to consumers of your library?  This seems like an unnecessary limitation, unlike controlling access to the AVPlayer.

The limitation initially existed for API simplicity, but providing an additional playback method expecting an AVPlayerItem should not be a problem. Your AVURLAssetAllowsCellularAccessKey example proves this is enables legitimate uses of public APIs we should allow.
Thanks for your input.

I implemented AVPlayerItem-based methods on the feature/player-item-playback branch.
I'll need to review and discuss it with the team first, then hopefully merge it back into develop.

Awesome @defagos thank you!
I appreciate a lot that your team has open-sourced your work on this player; it's the only one I was able to find that was customizable and yet fully-featured, and it saved me a lot of time on a recent project.

The new AVPlayerItem-based playback APIs are readily available on develop, and will be officially delivered in version 2.3.
Glad our player was helpful, and thanks again for your help and suggestions!


A tool to precompile shader caches outside of game context would be nice

It would be nice if there were a tiny executable that could precompile the shader cache outside the context of a game by taking the path to a shader cache as an argument. That way people could use a simple find command to locate all DXVK cache files on a system and execute the tool on each.
Someone on reddit mentioned that he uses mesa-git and that DXVK’s cache will be a huge improvement for him. It occurs to me after reading the release notes that a simple tool that hooked into DXVK could make the shader cache even more of an improvement for him. He could run that tool as part of a find command right after doing a Mesa update and then have a completely updated driver cache, which should reduce the CPU usage hit at game start.

Not possible because DXVK's state cache stores no shaders.

Probably a naive question, but would it not be worth it to store the shaders on top of the state, to allow this?


Broken link in EDR tutorial

https://github.com/eclipse-tractusx/tutorial-resources/blob/ef6f2a7664ca480a053b49b7e23f0eef8e6e21c9/mxd/docs/EDR Transfer Tutorial.md
The first link is broken and I can't find the file it linked to.
Thanks!

Related to eclipse-tractusx/tractusx-edc#1097


Shortcut with enter in Integrated Terminal

VSCode Version: 1.12.2
OS Version: macOS 10.12.5

Steps to Reproduce:

Set up the following keybinding:

    {
        "key": "shift+cmd+enter",
        "command": "workbench.action.toggleMaximizedPanel",
        "when": "terminalFocus"
    }

Open a Integrated Terminal
Use the new keybinding

What I got:
Inserted a enter/blank line in the Integrated Terminal
What I expected:
The panel to toggle between Maximized and non-maximized

Sorry, not a bug.
Add "workbench.action.toggleMaximizedPanel" in settings.json to "terminal.integrated.commandsToSkipShell" array and this works.


Sidebar options remain clicked

Yeah I changed this recently - they stay open on purpose.  I think some people would prefer to leave these open (Background, Data, and Help) while they do other things in iD.  (#4575 includes a change so that only one at a time can be activated).
I'm not sure if we will keep it this way or not.  They are easy to close by clicking again or using the appropriate keyboard shortcut.

I kinda like the way it works, It's just slightly confusing that when you open help and then try to use the other ones that nothing happens on screen.

Reading this again, (#4575 includes a change so that only one at a time can be activated) - solves my problem. So I will close this.


Stefan branch

Coverage decreased (-0.7%) to 52.944% when pulling e152c5d24df2530a63f565447dea49de4adacb66 on StefanBranch into c673ce0b3873580e180de1a1bcdbe331227f9b49 on master.

Coverage decreased (-0.7%) to 52.944% when pulling 85d1537e6bf592da748b98d191995c74604e4730 on StefanBranch into c673ce0b3873580e180de1a1bcdbe331227f9b49 on master.

Coverage decreased (-0.7%) to 52.944% when pulling 9b39ec07104b3088001eced20b6490debab1ef9f on StefanBranch into c673ce0b3873580e180de1a1bcdbe331227f9b49 on master.

Coverage decreased (-0.7%) to 52.944% when pulling 9b39ec07104b3088001eced20b6490debab1ef9f on StefanBranch into c673ce0b3873580e180de1a1bcdbe331227f9b49 on master.


Can a component output be wired to multiple component inputs?

Hi @MarcusTomlinson,
Just wondering if DSPatch supports wiring the output pin of a component to more than one input pin, or must the user instantiate a broadcast component explicitly? I couldn't find an explicit mention of this, if I'm correct I would suggest adding a note somewhere, perhaps to Circuit::ConnectOutToIn().
Best regards,
JO

Hey @axjollivier, yeah an output can be connected to multiple inputs :)
https://github.com/cross-platform/dspatch/blob/master/include/dspatch/Circuit.h#L47

Perfect, thanks so much!


[5.4] fix using --database option in the migrate command

This line already existed in 5.3, we need it to instruct the resolver to use the given connection when running the migration, the resolveConnection() method is used only when the grammar supports schema transactions:
protected function runMigration($migration, $method)
{
    $connection = $this->resolveConnection(
        $migration->getConnection()
    );

    $callback = function () use ($migration, $method) {
        $migration->{$method}();
    };

    $this->getSchemaGrammar($connection)->supportsSchemaTransactions()
                ? $connection->transaction($callback)
                : $callback();
}

In case it doesn't, we need to instruct the connection resolver to use the given connection.

Merging for now but can you explain a bit more. To me when I was reviewing the code it felt really strange to set the default connection for the remainder of the process.


Integrate with Nest.js

Hi guys what do you think about this case, create http adapter for Nest.js ?

I'm all for folks building adapters for this to be used in other ecosystems, so I'd so go for it!
Like most adapters though, I'd suggest the stakeholders (e.g. you) in a given target be the ones to create/maintain that to keep the core lib agnostic and clean (makes maintenance 1000x easier). If you make one though, I'll be happy to assist w any questions and will list it in the itty docs :)

I hear you, thank you.)


Upgrade to tuf 4.0 (or cap securesystemslib version)

Hi,
I suggest updating your tuf dependency to 4.x:

python-tuf did not cap the securesystemslib dependency before this release (sorry about that)
we know there will be incompatible API changes in securesystemslib in future as we get closer to securesystemslib 1.0

So ideally python-tuf users make releases that require (or at least allow) tuf 4.x before securesystemslib makes their next release (https://github.com/secure-systems-lab/securesystemslib/pull/767). If you don't want to bump tuf version you could alternatively cap securesystemslib to < 0.32 yourself: this would be the minimal change that should prevent future breakage.

@jku Thanks for the warning. I'll have a look at it a.s.a.p.


fix: redeem LNURL for all connectors

Describe the changes you have made in this PR
Display LNURL redeem option for all connectors.

thanks for fixing this! yeah this button shall be available for all the connector


LayoutAnimation support for web

As I was reading through Animated docs I came across LayoutAnimation. Is there any way to support this on the web? I'd love to try and take a stab at this if it's something that you are looking to support. I'm always interested in doing layout animations, specifically auto height animations. I think we can use a Resize Observer to obtain proper dimensions to animate to. Maybe we can create another util that could handle keeping dimensions of a stack of views? I know the hard part is we need to essentially render the content, measure, then animate to that measurement.
I'm curious if you have any ideas for this? I've done previous work with what I call a fluid container, but maybe there are other benefits by copying the same API over to web? Thought I'd post to see what you think :) would love to hear your thoughts on this.

I think the reason why LayoutAnimation works is because React Native 1) controls layout 2) has a cache on the native side.
LayoutAnimation is basically a way to register an animation to occur on the next re-render from a setState. There are issues with this in that you can't scope it to a particular child element, it just effects everything globally. Also it's just not flexible if you want to build out complex animations.
In the web if you were to register an animation to occur the layout would already take effect before you could control the animation. I just don't think the LayoutAnimation paradigm works for the web. Happy to be told I'm wrong though.

Interesting. I might take stab at something along these lines, but it sounds like it should be seperate from here. Thanks for explaining :)


forms

I am not sure if it is linked to a netlify database I made an account but I am not sure if it is linked.

I think it is linked to the netlify account but I am not sure


Empty Json serializes to "undefined"

Why is Json().toString "undefined"? It is not a valid json, I can not pass it to the client.

Accidentally created the issue before wrote body. Sorry.
I am trying to use REST interface generator. The result of some method is:
struct Test {
ushort port;
string path;
Json arguments;
}
If method returns Test(8081, "/", Json()) then serialized json is {"port":8081,"path":"/","arguments":undefined}. It isn't valid. May be it is better to serialize Json() to {} or null?
If not, is there another way to add optional field to struct with arbitrary data?

Try to use Json arguments = Json.emptyObject; in this case. Json.undefined is used, because everything else would be arbitrary, it could otherwise mean any of null, {} or [], but which of these makes sense depends on the situation.
If you need an optional field, you have two other possibilities:

Use the @optional attribute on the field in question, if optionality on the receiving side is enough (it will always be serialized when serializing)
Use Nullable!T. In this case, null will be used to denote the missing field.

It would be nice if Phobos also had an Optional!T type. I'd add support for it, so that the field is completely omitted if the Optional isn't set.

Thank you for answer. Now I understand how to solve my problem.
But I still don't understand why it is possible to get invalid json as result of serialization. In my point of view it is a design problem. I think nothing should lead to invalid json. And there are not many ways to get rid of this behavior. Json().toString must throw an exception or return valid json (i.e. {} or null). Are there any reasons why it is "undefined"? Because it is human readable?

Oh, you are absolutely right, I missed that part. There are related tickets (#222, #958) and a partial PR (#1323). I think the best solution would be to follow JavaScript's rules for this - if an object has a field with an undefined value, skip it during serialization and else output null instead.

Sorry, I thought PR fixes this situation. It is better if issue will be opened until it is fixed.

Fixed by https://github.com/rejectedsoftware/vibe.d/pull/1548


STORM-1127:  allow for boolean arguments (Flux)

To me the code looks good.  +1, but I would like someone more familiar with Flux to also take a look.
@ptgoetz can you take a look, or point out someone who would be good to review this?

+1. Looks good to me.