fix(modules/battery): fix battery state not reporting as full on trickle charge

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[X] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other: Replace this with a description of the type of this PR

Description
Many laptops allow for setting a charge threshold when using them mostly plugged in, in order to maintain the battery health in a good state. Currently polybar does not check for this and always sets the battery state to charging, even when the reported charging rate is zero (trickle charge).
This PR aims to fix this, by also checking the battery rate value.
Documentation (check all applicable)

[ ] This PR requires changes to the Wiki documentation (describe the changes)
[ ] This PR requires changes to the documentation inside the git repo (please add them to the PR).
[X] Does not require documentation changes

So once the battery is over this threshold, it stops charging and switches over to this trickle charge?
What does the file at /sys/class/power_supply/<supply_name>/status (either in the battery or adapter folder, I don't know) report in that case?
A new "not charging" state may be more accurate in this case.

So once the battery is over this threshold, it stops charging and switches over to this trickle charge?

Yes, exactly.

What does the file at /sys/class/power_supply/<supply_name>/status (either in the battery or adapter folder, I don't know) report in that case?

The file at /sys/class/power_supply/BAT0/status reports Charging, both when normally charging and on trickle charge. There is no status file for the adapter (only an online one that indicates whether the power adapter is plugged in).

A new "not charging" state may be more accurate in this case.

I don't think this is the correct view for this. The trickle charging functionality is like limiting the battery to a new capacity, e.g. instead of using the full 100% it just uses the 60% of the available battery capacity. The action performed by the device is similar to the one when the original limit (100%) is used, meaning the power adapter will trickle charge the battery to keep it around 100% charge.


eval code in MuPoTS

Thank you for sharing your amazing work. I'm doing the research in 3DHPE. I can't get the result(MPJPE) in yours paper on MuPoTS with your release model. so can you release the eval code in MuPoTS?  I'm appreciate it for your help and time.

Have you reproject again with the refined depths ?

Have you performed the reprojection again with the refined depths ?
Nevertheless, we have added the evaluation code to the folder 'lib/eval'. Contact us if you have any question using it.

Thanks a lot for your prompt reply and supplement code.


navigation buttons for mj-carousel not displaying in emails

Description
The left/right navigation buttons aren't displaying on mobile or desktop (iOS mail, Gmail Web, Outlook Web). On mobile you can click to change the images, but on desktop web you can't change to other images without proper navigation button.
To Reproduce

Create email using mj-carousel. Was able to replicate with sample code.
Compile to html and send via email service
Open in various clients and attempt to change images

Expected behavior
Navigation button to appear to the left and right of the image to allow user to change active image. Pressing thumbnails or navigation button on desktop web should appear and change active image.
MJML environment:

OS: MacOS 11.1 (BigSur)
MJML Version 4.6.2
MJML App 3.0.2

Email sending environment(for rendering issues):

Sendgrid

Affected email clients (for rendering issues):

iOS Mail 14.2, Safari 14.0.2, Chrome 87.0.4280.88
OS: MacOC 11.1

It should work fine on iOS mail (just tested with https://putsmail.com/). If client doesn't support click interaction within email there's nothing we can do about this (like gmail only support hover).

So I just cut/paste the sample and sent via putsmail and works on iOS.
Hover works on Chrome Desktop on Gmail, but still no navigation buttons and you can't change the image to actually click on associated href.
Navigation Buttons and hover doesn't work on Chrome Desktop on Outlook.com.
If the feature doesn't work, perhaps deprecate it as a feature or at least put a warning.

The difficulty here--for all of us--is the variable and incomplete state of HTML support in email clients (the group you mentioned, iOS, Gmail, Outlook, etc.)
MJML uses an HTML-like markup to create HTML tuned to get the best email performance possible with the current state of clients. Few support anything like the current HTML spec.
If you can do the things you seek to do in HTML across your preferred clients but cannot do them in MJML, then MJML has a problem. Otherwise, sadly, perhaps you'll find email HTML easier by adjusting your expectations for email client responses downward.
Or motivate email client teams to support additional features. You might be a hero here!

If the feature doesn't work, perhaps deprecate it as a feature or at least put a warning.

It's just progressive enhancement, if the clients supports some feature they are displayed.


Can start two master process on same node, neither one shows any errors

With current Satellite master branch, If I try to start a satellite-master that is configured to use the same port as another running master (either riemann or api port), the process exits and there is an appropriate error message in satellite.log ("Address already in use").   This seems fine to me.
If for some reason someone wants to run two separate satellite masters on the same host, and makes the effort to avoid port conflicts, this doesn't seem like something we need to stop them from doing.  Maybe they have a reason (although I can't think of exactly why that might be).
Hi @weissjeffm if you're still interested in this, can you explain a little more about your use case, and how you ran afoul of the unintended double-satellite?  Thanks.


Added morse code.

Added morse code implementation.
Too bad I still can't read and write it by hand 😢.

Fantastic, Thanks for your contribution! Happy Hacktoberfest!


Update doc for register calling bot for microsoft teams channel page

Update doc for register calling bot for microsoft teams channel page

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/calls-and-meetings/registering-calling-bot.md
:warning:Warning

Details

msteams-platform/assets/images/calls-and-meetings/configure-msteams-channel.png
:white_check_mark:Succeeded

msteams-platform/concepts/calls-and-meetings/registering-calling-bot.md

Line 12: [Warning] Invalid file link:(~/concepts/calls-and-meetings/registering-calling-bot#application-permissions).
Line 32: [Warning] Invalid file link:(~/concepts/bots/bots-create).
Line 34: [Warning] Invalid file link:(~/concepts/bots/bots-create#bots-and-microsoft-azure).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/calls-and-meetings/registering-calling-bot.md
:warning:Warning

Details

msteams-platform/assets/images/calls-and-meetings/configure-msteams-channel.png
:white_check_mark:Succeeded

msteams-platform/concepts/calls-and-meetings/registering-calling-bot.md

Line 12: [Warning] Invalid file link:(~/concepts/calls-and-meetings/registering-calling-bot#application-permissions).
Line 32: [Warning] Invalid file link:(~/concepts/bots/bots-create).
Line 34: [Warning] Invalid file link:(~/concepts/bots/bots-create#bots-and-microsoft-azure).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


PinpointKit in image upload flow

Could we gut out the interesting bits of this framework to add image annotations + arrows to the image upload flow? I don't think we need the whole thing (bug reports, etc).
https://github.com/Lickability/PinpointKit

Merge with #756?


[Question] Nearby filter

Hi,
I'm trying to understand the nearby / knn function.
Is it possible to provide a filter similar to the rbush knn filter function?
knn(tree, x, y, [k, filterFn, maxDistance])

tree: an RBush tree
x, y: query coordinates
k: number of neighbors to search for (Infinity by default)
filterFn: optional filter function; k nearest items where filterFn(item) === true will be returned.
maxDistance (optional): maximum distance between neighbors and the query coordinates (Infinity by default)

Basically I have properties on the objects and I would like the NEARBY to give me the n closest with a given property.
I'm thinking that MATCH is used after the KNN has obtained the result?
Thanks for a great product btw!

Interesting. This sounds like something that needs to be fixed and similar to #199.

I just pushed a fix to the master branch.

Thanks! I’ll try it out. And once again, fantastic work!

You’re welcome and thanks for the kind words. :)


customer suggestion

After customer set up the return policy  they don't know that they need to run the Retail Initializations after enabling the new features and synced down data again, customer suggest to add this information in the documentation.
Regards.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2fd324f-8636-61a3-0acb-5f533da93d5c
Version Independent ID: ff6b4fbd-536c-f514-2848-928d914f1e97
Content: Create and update a returns and refunds policy for a channel - Commerce | Dynamics 365
Content Source: articles/commerce/refund_policy_returns.md
Service: dynamics-365-commerce
Product: ****
Technology: ****
GitHub Login: @ShalabhjainMSFT
Microsoft Alias: rapraj

@raulmondra28 , thank you for reporting this issue. I have passed it on for consideration.

BUG 586419 created to track this issue

The topic has been updated.


When reading the mor table with QUERY_TYPE_SNAPSHOT,Unable to correctly sort and de duplicate data by PRECOMBINE_FIELD.

create table with :
(
'table.type' = 'MERGE_ON_READ',
'write.precombine' = 'true',
'write.precombine.field' = 'rowtime',
'compaction.delta_commits' = '3'
 )

Data inflow sequence：
{"msg":"1","rowtime":"2021-01-01 11:11:02","age":2} -- commit 1
{"msg":"1","rowtime":"2021-01-01 11:11:05","age":5} -- commit 2
{"msg":"1","rowtime":"2021-01-01 11:11:01","age":1} -- commit 3 and compaction
-- The query result is  {age":5 } // Meet expectations
{"msg":"1","rowtime":"2021-01-01 11:11:03","age":3} -- commit 4
-- The query result is {age":3 } // Not as expected

https://issues.apache.org/jira/browse/HUDI-4298

by default hudi uses OverwriteWithLatestAvroPayload which does not honor precombine in all code paths. specifically when records in base file and records in log files are merged together. You can try using DefaultHoodieRecordPayload to achieve this.
https://hudi.apache.org/docs/configurations/#hoodiedatasourcewritepayloadclass
https://hudi.apache.org/docs/configurations/#writepayloadclass
https://hudi.apache.org/docs/configurations/#hoodiecompactionpayloadclass

by default FLink SQL uses Eventtimeavropayload,
MergeIterator.mergeRowWithLog calls record.getData().combineAndGetUpdateValue(historyAvroRecord, tableSchema)  instead of record.getData().combineAndGetUpdateValue(historyAvroRecord, tableSchema, payloadConf) . so The final call is OverwriteWithLatestAvroPayload.combineAndGetUpdateValue(IndexedRecord,Schema)

Changing the payload to DefaultHoodieRecordPayload may solve your problem. It match the semantic that get the latest one which value of combine field is bigger.


enable godot

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #940
What is the new behavior?

Other information

Please rebase on upstream/master your branch

git remote add upstream git@github.com:ydb-platform/ydb-go-sdk.git
git fetch upstream
git merge upstream/master (or git rebase upstream/master)
<fix all conflicts + git commit>
git push


Version 3.0 progress

Hi, just wondering what the progress is for v3.
Is it under development?

Yes it is! It was frozen while .NET Core 2 came out, which annoyingly would've made a lot of the conversion problems a lot easier. Currently there's a few issues with converting Lucene and waiting for a stable version of that to exist with .NET Core.
I'm currently working on two other projects however, Syringe .NET core conversion and another private one. I'm aiming to use the learnings from Syringe however to speed up the Roadkill conversion.
Because of the size of the codebase, the conversion has been set back quite a lot by Microsoft's indecisiveness over .NET core, but I think it'll now be on track with .NET Core 2.

Hello
@yetanotherchris you have added help wanted tag. It would be nice to write how can people help - what exactly to do.

Wrong label, my mistake!

Do you happen to have any update regarding this?

The current status is:

I'm working on a project I can't talk about, which is consuming all my spare time.
Part of this is nooptime
I am working on a lot of Docker-based projects right now

All of this work is going to make the Roadkill conversion to .NET Core a lot faster. The majority of the Roadkill work has been moving away from Creole, which is now pretty much done. Creole was understandably a popular choice, but as a markdown language sucks.
Time frames: I'm not sure, but soon (TM) 😄
I'm really keen to get started on Roadkill 3 and get people developing for it, and watch it become incredibly fast and cheap to deploy with Docker. But as mentioned, I have commercial projects that take precedence right now.

Thanks for the response. Totally understand! Thanks for your continued support.

bump

Any updates on this? I am looking around for a .net based wiki engine we can use for our documentation, and stumbled upon this. Would prefer to spend time with v3 if it is being actively developed. Is there a branch of the code anywhere?

Yes, on the dotnetcore branch. It's currently just RESTFul API, largely done (users and search left) with the UI being transitioned to use it next.
I'll probably do this server side to begin with and then move to make it a React or VueJS UI later.
Hope that helps

Ok thanks. If we start with v2, is there an upgrade path to v3?

Yes, there will be a tool to migrate the database. The configuration will be manual but should be straight forward


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: DRP1968 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


How to verify driver , that not  built by me

Recently i  received UWD graphics  driver  suite , i have already installed Visual studio community edition uptodate , now how to  verify that driver belongs  to  UWD
please  add  command line

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58045b53-c3f3-acc3-3432-d31d78bfb3c1
Version Independent ID: 0e67ba20-f4e1-dbaf-97a6-cd7ce8565e28
Content: Validating Universal Windows drivers - Windows drivers
Content Source: windows-driver-docs-pr/develop/validating-universal-drivers.md
Product: windows-hardware
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Hi @RAJU2529 - in the properties for the driver project in Visual Studio, you can see if the driver is universal or not by navigating to Driver Settings->General->Target Platform.  Hope this helps!


fix typo at index.html: Develope -> Develop

'Develope' in index.html may be a typo.

Coverage remained the same at 83.585% when pulling e7793637574f904385c5b15cab61edbe362734a3 on hondak:fix_typo_index.html into 343f9d6ca99c7318d35763eaa16764a6eeaac150 on FujitsuLaboratories:master.

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master      #3   +/-   ##
======================================
  Coverage    82.4%   82.4%
======================================
  Files          15      15
  Lines         773     773
  Branches       95      95
======================================
  Hits          637     637
  Misses        105     105
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343f9d6...e779363. Read the comment docs.


If no github ref is found optionally return a default tag

In PRs no suitable GitHub ref will exist so this action will return [], but this prevents you from testing a full release workflow with a local Docker registry within CI.
To handle this case this adds a new defaultTag argument that can be returned as a tag.

Lgtm!


Enable native "sticky-scroll-into-view" on initial load and notifications

Description
sticky-scroll-into-view is a file from GitHub that does the following thing:
When you click the time (hash) of a comment, the comment will first scroll to the top (browser's default behavior), then sticky-scroll-into-view will scroll it down a bit to make sure it is not covered by the header.
This works well except for:

The initial load, since GitHub's code isn't ready at this time (but ours is)
It only considers the sticky header. If you have the notification header around, the comment would still be covered.

The first scenario is particularly confusing when a link is linked to one (or two) particular line(s), as you may not even realize it is raising awareness of specific lines.
Regarding implementation: we can't (and shouldn't) use GitHub's code, mentions of sticky-scroll-into-view is just for reference.
Screenshot
No response
Example URL
https://github.com//refined-github/refined-github/pull/5238/files#diff-cb1dafea7a9c68c5c2ebb2d56f749b3506c13f7d26feeaf56c86521b25c60358R16

Screenshot
No response

Can you post a video of this issue? Your url works well whether I open it in this tab or in a new tab:

Indeed this is quite annoying. Let's see if https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-padding-top is useful here. We might be able to fix it with 2 lines of CSS. I definitely don't want to mess with JS because GitHub has their own (evidently-faulty) logic to do exactly this.

I think this is tricky for us to fix without causing further issues/conflicts with GH’s own behavior.
Too many feature requests, realistically we’ll never get there. I’m closing those I think aren’t worth it.


document how to minimize fold computation costs

See the discussion at https://github.com/lervag/vimtex/pull/3054

I'm curious, on line 85, it says: "The most efficient is to call a compiled function without arguments:" - however, in my experimentation I really did not observe any noticable difference. I'm curious if anyone actually did, or if this is just based on someones hunch?
Perhaps we should also add a line above line 105 saying something like: The result values "=", "s" and "a" are more expensive, please see |fold-expr-slow|.; it may make the new section more discoverable.

I'm curious, on line 85, it says: "The most efficient is to call a compiled function without arguments:" - however, in my experimentation I really did not observe any noticable difference. I'm curious if anyone actually did, or if this is just based on someones hunch?

It links to
#  runtime/doc/vim9.txt (lines 1441-1453)
Calling a function in an expr option ~
							*expr-option-function*
The value of a few options, such as 'foldexpr', is an expression that is
evaluated to get a value.  The evaluation can have quite a bit of overhead.
One way to minimize the overhead, and also to keep the option value very
simple, is to define a compiled function and set the option to call it
without arguments.  Example: >
	vim9script
	def MyFoldFunc(): any
	   ... compute fold level for line v:lnum
	   return level
	enddef
	set foldexpr=s:MyFoldFunc()

which makes sense as soon as one realizes that Bram added this file after implementing Vim9script.
I now rewrote it to make this clearer at the end of the slow section

Ok, I think this looks quite good now. 👍🏻

thanks!


[Minor spec Issue] Using x0 as rd in vsetvli/vsetvl

Section 6.1 of the spec explicitly states what happens if rs1 is x0 for vsetvli/vsetvl but not what happens if rd is x0.  I presume it does everything it would have done but doesn't write an x-register.  The way it's used in examples, however, it might not set vl either.  An extra sentence would avoid ambiguity.

Your presumption's right.  The base ISA spec follows the discipline that using x0 is not special unless explicitly specified.  So, my concern is that explicitly specifying that x0 is not special when used as rd could lead to additional (but unrelated) confusion.
Perhaps we could add a non-normative note.  I'll make a PR and let @kasanovic decide.

Yes, I see what you mean.  The note might simply say that even when rd is x0, vl is still written.
It was vl that was my uncertainty.  From a usage point of view, the most common use of rd as x0 is probably when re-adjusting SEW and LMUL while leaving vl the same.  I presume there it's x0 to avoid additional dependencies.  For that use, it would also be correct not to write vl either.   That's where I'm coming from in thinking a clarification might be helpful.
  Bill

On 6/1/19 3:21 PM, Andrew Waterman wrote:
Your presumption's right. The base ISA spec follows the discipline that using x0 is not special unless explicitly specified. So, my concern is that explicitly specifying that x0 is not special when used as rd could lead to additional (but unrelated) confusion.
Perhaps we could add a non-normative note. I'll make a PR and let @kasanovichttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kasanovic&d=DwMCaQ&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-_haXqY&r=AYJ4kbebphYpRw2lYDUDCk5w5Qa3-DR3bQnFjLVmM80&m=X_c5ZTtPqTjVfRaBr7-jrNyLIT4MqO8lw0wQeP4YwMQ&s=iqMdc6sYhDDjdK4N2HeV9DozpZBPUyROD8Y7pju1tPU&e= decide.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_riscv_riscv-2Dv-2Dspec_issues_199-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKXXKKE5MXXGP2GRVW3ZOVTPYLZABA5CNFSM4HSA6MI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWXJTRI-23issuecomment-2D497981893&d=DwMCaQ&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-_haXqY&r=AYJ4kbebphYpRw2lYDUDCk5w5Qa3-DR3bQnFjLVmM80&m=X_c5ZTtPqTjVfRaBr7-jrNyLIT4MqO8lw0wQeP4YwMQ&s=NaCNlrmlqrpHr67QXgFFnuLoNQacHNFE9SJbGcxtGgI&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKXXKKEBEIESPPEAF23VWNLPYLZABANCNFSM4HSA6MIQ&d=DwMCaQ&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-_haXqY&r=AYJ4kbebphYpRw2lYDUDCk5w5Qa3-DR3bQnFjLVmM80&m=X_c5ZTtPqTjVfRaBr7-jrNyLIT4MqO8lw0wQeP4YwMQ&s=yuIkkuxEPQo54kDrh-KAee8y9umAuRB0xqOLHIN_8EQ&e=.

Added a note about this.

Thanks.      Bill
On 6/3/19 9:27 AM, Andrew Waterman wrote:
EXTERNAL MAIL
Added a note about this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_riscv_riscv-2Dv-2Dspec_issues_199-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAKXXKKGVGKWFB7KR5EIIYDLPYVBAFA5CNFSM4HSA6MI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZ6M3Q-23issuecomment-2D498329198&d=DwMCaQ&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-_haXqY&r=AYJ4kbebphYpRw2lYDUDCk5w5Qa3-DR3bQnFjLVmM80&m=z-f7_jB4zuMXL9HBX97MDUZLBiKWR7Bhq0ufzktt3Ms&s=QQyIK76GOuNlqV6TEHrR4FDboCw3XUqhqm5es6KWJ8k&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKXXKKDSLH4ZNTIZRD3EXZTPYVBAFANCNFSM4HSA6MIQ&d=DwMCaQ&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-_haXqY&r=AYJ4kbebphYpRw2lYDUDCk5w5Qa3-DR3bQnFjLVmM80&m=z-f7_jB4zuMXL9HBX97MDUZLBiKWR7Bhq0ufzktt3Ms&s=9Sida7edLxE-lunLTPButCGXK_RoAM6ehJAMVntAdls&e=.


Comments on the flow design of the bot

In the current implementation the bot will not exit when:

there are not enough funds (here and here)
the relevant core is not renewable
The tx is submitted successfully and the core is renewed

and just keep looping these checks for every new block.
Note that the the originally proposed design would exit as soon as the core is not renewable or are not enough funds. I think this implementation is a better design than the original since it is better to not exit and just warn the user if they have to top up the account.
That being said, before "publishing" the bot, it would be nice to have an updated version of the flow diagram (f.e., in the README) so testers know what to expect.

I'm thinking of making the bot exit when outside of the renewal window, since when buying on the open market it's unlikely the core purchased will be the same, so it makes more sense to have it throw a warning, exit and then to be restarted once we know what's the new core ID.

Closed by #3


Can't import useConnect() because "screen is not defined"

The new Authentication tutorial includes a section Usage in React Apps with the following example:
import { useConnect } from '@stacks/connect-react';

const AuthButton = () => {
  const { doOpenAuth } = useConnect();
  return <Button onClick={() => doOpenAuth()}>Authenticate</Button>;
};

Implementing this (here) throws an error: "ReferenceError: screen is not defined"
Looks like the useConnect() definition is trying to export screen and a couple other variables either undefined or not in scope.
Happens with the current npm versions as well as the "@launch-misc" versions:
"@stacks/connect": "^4.3.15",
"@stacks/connect-react": "^2.17.15",
"@stacks/connect-ui": "^2.17.16",

"@stacks/connect": "^4.3.16-alpha.75e60a4.0",
"@stacks/connect-react": "^2.17.16-alpha.75e60a4.0",
"@stacks/connect-ui": "^2.17.17-alpha.75e60a4.0",

🤦🏼 there used to be a screen variable exported. Typescript didn't flag this because screen is a valid global in browsers. And I didn't see this because I'm only using useConnect on the client side. Nice catch! Fixed in 48233557.

🤦🏼 there used to be a screen variable exported. Typescript didn't flag this because screen is a valid global in browsers. And I didn't see this because I'm only using useConnect on the client side. Nice catch! Fixed in 48233557.


[Costum Cell] How to costum the bubble so we can have send time inside the bubble

New issue checklist

[x] I have read the README, documentation, and FAQ.
[x] Contributing guidelines confirmation: ____
[x] I have searched existing issues and this is not a duplicate.

General information

JSQMessagesViewController version:
iOS version: 9.0
Devices/Simulators: Devices
Reproducible in the demo project? Yes
Any related issues: I want to resize the textview inside the bubble with constraint in XIB but the constraint is replaced by other constraint

What happened?
I want to create a custom view like this

Then I try to change it in custom XIB file. But some how, the constraint for textview that I put on the XIB was replaced by default constraint. How to handle this in Objective-C?
This is the XIB

Hi,
Please update me too..
I also want same feature.

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq

@sacrificar Hi.. Did you get the solution?  Please revert.


apt::keyring: Require "source" or "content" only if ensure=present

Summary
Require "source" or "content" only if ensure=present since it doesn't make sense in case of ensure=absent
Related Issues
#1197
Checklist

[X] Manually verified.

Please check and merge.


proposal: Option, A container struct which may not contain a non-null value.

As a developer I would like to have Option or Optional that allow me to encapsulate the types and avoid nil values. As a result of this new struct I could develop my solutions follow functional programming patterns as pattern matching, and the most important allow me to have a clean code, with just one return statement, no nil values as a part of your business logic (flow control) and avoid fuzzy ifs statements.
I already have developed a mock up
https://github.com/pjgg/Go-Option
So I though that maybe could be better have this code as go lang package instead of an external lib.

Are you suggesting that your package be included in the standard library? Is that the proposal?

No sorry,  the proposal is develop an optional Type or an Optional struct. This package is just an example, a mock up in order to explain better the goal of the proposal.

I'm sorry, I don't understand what you mean when you say an optional Type or an Optional Struct.  Seems like it should be one or the other.  Can you be more precise about exactly what change are you suggesting?
For example, are you suggesting that the package you wrote should be in the standard library?  If so, what should it be called?
Or are you suggesting something else?

In my opinion should be an struct. The package should be called option or optional because the concept already exist in other languages, so is important call the same concept with the same name.
The package that I wrote is just a mockUp. For example missing a lot of predefined predicates (we should have predicates for all go lang primitives). Also I am not sure about the "None" struct that I wrote in order to represent a none value. Is this empty struct the best way?
The method "IfPresent" is not implemented yet (is not tested), and also a lot of test and methods are missing. For example, I didn't work with Arrays yet.
The proposal that I am doing is... do you think that could be interesting for go lang, introduce optionals? or not?
example of usage:
Code like this
`
healthCheckDto := new(dto.HealthCheckDto)
if err := h.ldapConnector.Ping(); err != nil {
healthCheckDto.LdapHealthCheckDto.Ok = false
healthCheckDto.LdapHealthCheckDto.Msg = err.Error()
} else {
healthCheckDto.LdapHealthCheckDto.Ok = true
healthCheckDto.LdapHealthCheckDto.Msg = "Ldap server could be reached"
}
`
could be recode like this
        ldapHealth := h.ldapConnector.Ping() 	switch e := ldapHealth.Get().(type) { 	case *option.None: 		ldapHealthCheckDto.Ok = true 		ldapHealthCheckDto.Msg = "Ldap server could be reached" 		break 	case error: 		ldapHealthCheckDto.Ok = false 		ldapHealthCheckDto.Msg = e.Error() 		break 	}
This is just an easy example... but the idea is avoid multiple return statement in your code, nils in everywhere, and to sum up give the more choices to the developer about how they want to express himself.
What do you think?

What I think is that you should take this to a forum (https://golang.org/wiki/Questions) and work with other people to turn it into a polished proposal.  Right now I simply do not understand what you are suggesting.  I don't even know whether you want to add a new package to the standard library or whether you want to change the language in some way.  Your examples are just fragments; they don't define all the types and I don't understand what they are meant to show.
I'm going to close this, but please feel free to add a comment or add a new issue when you have a more complete proposal.  Thanks.

I was suggesting something like this
http://www.scala-lang.org/api/2.12.x/scala/Option.html
or like this
https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html
I guess that C++ must have his optional implementation too.
I hope that with these links and the mockUp https://github.com/pjgg/Go-Option help you to understand about what we are talking about. If not, please talk with somebody that already use optional in any other language. (Is like try to explain why switch statement is useful. If you never user it, is very difficult to explain...and I am not going to convince you. So talk with somebody that work with...scala, an then spend... 2 weeks working with optional, and then we could continue this conversation).
"I don't even know whether you want to add a new package to the standard library"
I don't want to define how to add this behaviour.  If you don't know it, I can give you proposal, for example a new package, but if you have a better idea we are here to listen those ideas!.
"...change the language in some way"
I don't want to change the language in any way. I want to add new behaviour, but the current functionality will not change at all. I give you an idea to make go lang a little bit more functional and expressive, nothing else. But you will be able to still programming in the same way as you use to.
".... Your examples are just fragments"
My example https://github.com/pjgg/Go-Option have an 82% of coverage. Have a look to option_test.go. Use the lib in a project.... return in a function an option (have a look the example of main.go)
return Option.Of(yourResponse)
And from this point remember that the option will never ever give you a nil, and all the returns are typed. So play with the option...for example maybe if the result of a function is "nil" (None) you would like to have a default value...ok
myOption.GetOrElse(&myDefaultValue())
...or maybe you want to retrieve your value just in case match with some conditions, ok!
myOption.Filter(equalInt(1)) // will give me the value just in case will be one if not then will return none.
Well I though that was a good idea!. But its ok!.

@pigg The Scala and Java links point to a possibly generic Option class - these are external libraries, not part of the "core language". Even at that, it doesn't do a whole lot, and it looks like you could probably implement something along those lines in a separate Go package. There's no need to change the language or add this to the std library - it certainly doesn't carry the weight we usually want to see for such changes.
Thanks for the comment. Please consider using the regular discussion forums if you want to push this further. Thanks.

To expand on what @griesemer said, the proposal process is for specific detailed proposals for changes to Go.  For general suggestions, please use a discussion forum.  Thanks.

"The Scala and Java links point to a possibly generic Option class - these are external libraries, not part of the "core language" "
@griesemer ... you don't need any external library in order to use option or optional in java or scala is part of the core of the language.
http://www.scala-lang.org/api/2.12.x/scala/Option.html
https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html
Those links are pointing to the official documentation of Java/scala.
Is ok!. Thank you anyway for your time!.
And try an other languages in order to have an open mind guys!.

Just for the record, we try to have an open mind.  But there is a specific proposal process (https://github.com/golang/proposal) and this does not (yet) follow that process.


Sort colors/DNF problem

A very famous problem based on sorting 0s,1s and 2s without sort method.
could  you please mark it for hacktober accepted...

Hello, I would like to work on this issue. Please assign it to me.


fix: typo fixes

@tvolk131 You missed a spot. :D

Hmm I double-checked for any uses of OptStrackTrace and didn't find any. I'm seeing that the CI fails due to the following error:
fedimint-workspace-build>    Compiling fedimint-rocksdb v0.1.0 (/build/source/fedimint-rocksdb)
fedimint-workspace-build> error[E0432]: unresolved import `fedimint_core::fmt_utils::OptStracktrace`
fedimint-workspace-build>   --> gateway/ln-gateway/src/lib.rs:42:5
fedimint-workspace-build>    |
fedimint-workspace-build> 42 | use fedimint_core::fmt_utils::OptStracktrace;
fedimint-workspace-build>    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------
fedimint-workspace-build>    |     |                         |
fedimint-workspace-build>    |     |                         help: a similar name exists in the module: `OptStacktrace`

I don't see this line locally and I ran nix build locally and everything works fine - I'm not sure what I'm missing here. Apologies if this is something simple, I've read the docs but still can't figure out what's going on here.

@tvolk131
My guess: you need to rebase on top of latest master and then it will show. Someone (probably me, sorry ;D) added a new instance of it in last few days, and your PR is being tested a merge to master at tthe time you created PR, not at the time when you cloned the repo locally.

@dpc thanks! That makes sense - not sure why I didn't think of that. I rebased and amended that commit, everything should be good now!


completion setup blocks the homebrew build process

Looks like since 1.1.0 release, vela completion bash does not run properly during the build process, might need some help taking a look at it. Thanks!

relates to https://github.com/Homebrew/homebrew-core/pull/87046/ (the latest effort)

fixed in #2434

@wonderflow I think #2434 is irrelevant to the issue I raised in here.

https://github.com/Homebrew/homebrew-core/pull/87046
I found this PR, completion setup blocks be removed?  how to implement completion?  @chenrui333


Merge command dependencies support

Add support for merging SBOM dependencies (dependency graph) with the merge command.

Resolved by #96


Cachelib build result contains many absolute path

The Cachelib build output contains many local absolute file path, especially in pkgconfig and cmake files. If we want to copy the output to another machine, we need to put them to the same path, or may not found some dependency when we building. It seems so inflexible.
So, how can we solve this problem if we want our build output library can be used by different user and different hosts?

(CC @agordon)

Duplicate of #173


Incompatible packages

The rule in the heading should be at the same position of each page.

With following packages, the header gets a one-liner:

xifthen
todonotes
pdfcomment

Screenshot:

Minimal example:
\documentclass[english]{lni}
\startpage{53}

\usepackage{mwe}

\usepackage{ifthen}

\author{author}
\title{title}

\begin{document}

\maketitle

\blindtext[10]

\end{document}

This is clearly an issue of the fancyhdr package, but I thought, it would be helpful to mention it here:
\documentclass{book}

\usepackage{mwe}
\usepackage{fancyhdr}
\usepackage{xifthen} %disable it and "LE running" will move down.

\fancypagestyle{plain}{%
   \fancyhead[RO]{RO\linebreak firstpage}
   \renewcommand{\headrulewidth}{0.4pt}
}

\pagestyle{fancy}
\fancyhead[LE]{LE running}
\renewcommand{\headrulewidth}{0.4pt}

\begin{document}
\thispagestyle{plain}
\blindtext[8]

\end{document}

The output is
Package Fancyhdr Warning: \headheight is too small (12.0pt):
 Make it at least 20.38402pt.
 We now make it that large for the rest of the document.
 This may cause the page layout to be inconsistent, however.

I think, adding \setlength{\headheight}{20.39pt} will solve the issue. I'll try.


Minor change in Replay Map Status Window

Hi Anton,
Currently, when we click on the device icon in the replay screen, the current device detail shows in the status window. But my suggestion is that in the status window, what device details were there at the point you clicked on, should be shown.
For example, my truck went on a trip yesterday and its location was xyz and the speed was 60 km/hr (position id= 35) at 7:30 PM. Today when I check the history in the replay map and check the speed at 7:30 pm, the speed shows 0 km/hr because the current speed of the truck is 0 km/hr. With this, when I click on more details, the detail of the current position is shown (say position id = 235).

I believe this is already fixed. We show relevant position info on click.


Add an delete-on-termination for automatically deleting images on VM termination

Author Name: Simon Boulet (Simon Boulet)
Original Redmine Issue: 2021, https://dev.opennebula.org/issues/2021
Original Date: 2013-05-10

Much like the Amazon EC delete-on-termination attribute (which automatically deletes EBS disk on VM termination). It would allow the user to select whether or not to delete the persistent VM image when the VM is deleted. We could have a special attribute ex. IMAGE_DELETE_ON_TERMINATION yes/no in the USER_TEMPLATE attributes. Or if we want finer configuration perhaps make IMAGE_DELETE_ON_TERMINATION an array with IMAGE ID to be deleted.
Or, perhaps it's better to leave this Off from the core, and instead encourage VM_HOOK for that (I believe this can be quite easily implemented using the DONE hook).

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2013-05-11T15:06:02Z

I also think that the DONE hook will be so easily implemented, given that you have the template. you can query the template and delete any image... The implementation could be as follows:

Add one or more delete attributes to the user template

IMAGE_DELETE_ON_TERMINATION = [ IMAGE_ID = "3" ]

The on done hook would be like (off the top of my head...)

client = Client.new
vm     = OpenNebula::VirtualMachine.new(ARGV[0],client)

ids    = vm.retrieve_elements("/VM/USER_TEMPLATE/IMAGE_DELETE_ON_TERMINATION/IMAGE_ID")

return if ids.nil?

ids.each { |i|
  image = OpenNebula::Image.build_xml(i)

  image.delete
}

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2013-05-11T15:08:01Z

BTW, we could probably add this to some part of the documentation or the wiki if you finally implement this. Maybe we can have this an other hooks in share samples... but I think we should not include this as a default.

Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2014-01-20T11:41:57Z

To add this as an example

Original Redmine Comment
Author Name: Simon Boulet (Simon Boulet)
Original Date: 2013-05-13T19:01:33Z

Ruben S. Montero wrote:

BTW, we could probably add this to some part of the documentation or the wiki if you finally implement this. Maybe we can have this an other hooks in share samples... but I think we should not include this as a default.

I like the idea of bundling some samples hooks with the distribution. Perhaps requiring the author to maintain a page on the wiki for his contribution.


Added The Crew: The Quest for Planet Nine board games

Submitting this PR means you have:

[X] searched the readme file and searched the open pull requests (no duplicates please)
[X] and will follow the desired format
[X] used image links that resolve correctly, are appropriately sized, and are served over HTTPS

Once your PR is created, it will trigger a build a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them.
Do you have further questions? Check the contribution guidelines or open an issue.
When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!

@SusheelThapa please stop creating new PRs until all existing ones have been dealt with. I recommend you limit yourself in the volume you create in a single repository. Also please read the freshly updated section of the welcome issue, titled “Notts for First Time Contributors”, as you are new this year.

@edm00se I am sorry. From next time onward, I will create new PRs after my all existing one have been dealt with. I am extremely sorry toward the inconvenience that i have created.

Thank you. I'll get caught up eventually.


Atlases_transformations

@smoia there is a merge conflict in create_random_parcellation.py should i accept the master changes or the changes from your branch?

@vinferrer it's difficult for me to say without seeing it. I would go for the most recent, that should be upstream/master.

@vinferrer I solved the conflict!

Okay, I think is all ready


NC 5.0.ALPHA Crash - NoSuchMethodError: nc.multiblock.turbine.TurbineLogic.clearSounds

Server upgrade from NuclearCraft-2o.4.7-1.12.2 to NuclearCraft-2o.5.0.ALPHA-1.12.2
When chunk loaded with existing NC reactor and turbine, server crashes with
java.lang.NoSuchMethodError: nc.multiblock.turbine.TurbineLogic.clearSounds()V
Complete crash log:
https://pastebin.com/30PsrFM1

@AnodeCathode This was fixed in the 2o.5.0 release :)


feat: Add UI options

Hi @GreenComfyTea , thanks for your great effort to bring this amazing mod. I would like to add some features to improve this mod. I try to add the UI options in the REFramework menu so that we can simply enable UI with a checkbox in-game. It will look like this:

I think it can be an easy way to manage the UI rather than edit the script all the time. What do you think about this idea?

This is definitely a good idea! I didn't even think that it's a possibility. Thanks for it!
Considering how many options there are already and how many I am planning to add, maybe the script should even have a separate REFramework window.

@GreenComfyTea Thank you and may I know your todo/plan? Want to see what else I can do to contribute to this mod. 🙏


Added network packets

Implemented different network packets that need to be transmitted to the exchange from clients. Further implementation is needed for transaction codes, as well as the header.

Wow, amazing job ahong


document built-in processors

processors documentation already exists. likely a dupe of #956

Reopened, because we incorrectly closed this as a dupe. The goal here is to improve the user-facing docs: https://conduit.io/docs/processors/getting-started/#built-in-processors

Pull request: https://github.com/ConduitIO/conduit-site/pull/30.


WalletConnect connection with QR code does not work

Open: https://web3modal.com/
Tap connect
Choose Wallet Connect
Scan QR Code through alpha wallet app.

The connection should be established, but nothing happens.
A possible problem in the App, with other apps (Metamask and Rainbow) works.

@hboon i just scanned qr code from  https://web3modal.com/ and it get connected succesfully. but for now i see only this.

@hboon i just scanned qr code from  https://web3modal.com/ and it get connected succesfully. but for now i see only this.

@hboon i just scanned qr code from https://web3modal.com/ and it get connected succesfully. but for now i see only this.

Yes, this is what it need to be. On my side it is not working. I am scanning the code, but the https://web3modal.com/ is staying on the QR code not getting the event. This is happening also with another app using the same library: web3Modal.

@hboon i just scanned qr code from https://web3modal.com/ and it get connected succesfully. but for now i see only this.

Yes, this is what it need to be. On my side it is not working. I am scanning the code, but the https://web3modal.com/ is staying on the QR code not getting the event. This is happening also with another app using the same library: web3Modal.

@ochikov Is this with the app store version? The iOS version has WalletConnect functionality in our code base, but we haven't released it yet. But we will very soon.

@ochikov Is this with the app store version? The iOS version has WalletConnect functionality in our code base, but we haven't released it yet. But we will very soon.

@ochikov Is this with the app store version? The iOS version has WalletConnect functionality in our code base, but we haven't released it yet. But we will very soon.
Yes, I am using the AppStore version. Thanks. When do you expect the release ?

@ochikov Is this with the app store version? The iOS version has WalletConnect functionality in our code base, but we haven't released it yet. But we will very soon.
Yes, I am using the AppStore version. Thanks. When do you expect the release ?

@ochikov If nothing goes wrong, some time this time.

@ochikov If nothing goes wrong, some time this time.

@ochikov this is now on the app store

@ochikov this is now on the app store


Class instance not required

Hi!
This class was exactly what I needed (why reinvent the wheel :D).
But I don't think the object instance is required. You could make the methods static and we can just call them directly.

Hi! Nice to hear it's useful :-)
The reason why the object instance is required, is because you can choose a custom network mask. But for convenience, I can add a static method which just uses the default mask.

Fair point! Thanks for the extra method, the default is good enough for me :).


cannot join server

when I host the local server and try to join with the client to try it out it just stays on the main screen and does not do anything. in the server console, it says I have joined but I am still on the main menu. I have the versions:
SS14.Server_macOS_amd64.zip and SS14.Client_Windows_amd64.zip from the spacestation14.io website please help or tell me what I am doing wrong, thank you.

If you hit ` are there any obvious errors in the console?

yes, seems to be errors to do with textures with a greyshirt. says
[ERRO] go.comp.sprite: Unable to load RSI 'Textures/Mob/greyshirt.rsi'. Prototype 'HumanMob_content'
[ERRO] go.comp.sprite: No base RSI set to load states from: cannot use 'state' property. Prototype 'HumanMob_content'
[ERRO] go.comp.icon: Failed to load RSI 'Textures/Mob/greyshirt.rsi'. Prototype 'HumanMob_content'

Come talk to us in Discord if you are still having problems.
https://discord.gg/MwDDf6t


[Question] 'missing' build_policy

Hello,
Does the build_policy [missing] also support building dependencies or only the current package ?
Here is my situation,
I set the env var CONAN_BUILD_POLICY to missing, I was expecting conan to build missing dependencies but I got this error:
17:41:58  conans.errors.ConanException: Missing prebuilt package for 'my_package/1.0.0@my_user/my_channel'
17:41:58  Try to build it from sources with "--build my_package"

Environment Details

Conan Package Tools Version: 0.30.4
Operating System: Windows
Operating System Version: 10
Compiler+version: visual studio 2015
Conan version: conan 1.21.0
Python version: python 3.7.0

Yes, it should build all dependencies: https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package
Could you please share more details about your environment?

build.py
env vars configured
commands executed
entire build log


Mark gateway ports as H2 in k8s

fixes https://github.com/istio/istio/issues/6872
Marking ports as http2 will cause CDS to emit h2 clusters for gateway ports.
Also, introduced Http2-tls so that upstream traffic to gateway HTTPS
port will have the right ALPNs, maintaining H2 throughout.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [rshriram]
pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, zachgersh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [rshriram]
pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d17b64d7b99c7314aa0652827e3e9ef4f7c572e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, zachgersh, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [rshriram]
pilot/OWNERS [ZackButcher,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, zachgersh, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c1ed2dbebc81dd664a5b3d2f2ad24bd047477414
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


feat: add generics to Datasets and KVStore

@AndreyBykov take a look at this as well as #5, I guess you don't know much about generics so those could be nice learning materials for you. Feel free to comment on the code and ask things.


wip: Upgrade to VS 2017

Remaining issues:

tests fail on net46
System.MissingMethodException : Method not found: 'System.Net.Http.HttpClient Microsoft.AspNetCore.TestHost.TestServer.CreateClient()'.

Consider using MSBuild typescript targets.

Use version BuildBundlerMinifier in samples instead of dotnet-bundle when https://github.com/madskristensen/BundlerMinifier/issues/230 is fixed

cref https://github.com/aspnet/Universe/issues/469
cc @anurse

Hi @natemcmaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

I'm going to disable net46 tests for now. The tests are failing due to https://github.com/Microsoft/vstest/issues/428 as far as I can tell.

I'd also suggest we do the TypeScript MSBuildification later and focus on just getting this merged in. The conversion will be the most disruptive change, not many people are working on the TS client right now. It's really just @moozzyk  ;).

Yes. I will look into TS client.

Added workaround for microsoft/vstest#428.
Next issue. Microsoft.AspNetCore.SignalR.Tests on net46 appears to hang indefinitely.

@anurse Was looking into it

Removing "wip" label. I got a full build to pass on command-line 🎆

Rebased. There was a random macOS failure in the Autobahn tests but I think it's a flaky test error. I'm going to file a bug to look in to stabilizing that. One option might be to look at migrating WebSockets back to its own repo so the Autobahn suite doesn't make the whole SignalR repo flaky

This is tangentially related to the work here, but in the CoreCLR (mirroring) build we hit long path issues with the config file:
C:\BuildAgent\work\29495d0a71cf35ac\Universe\SignalR\test\Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest>dir obj\Debug\net46\*.config

Directory of C:\BuildAgent\work\29495d0a71cf35ac\Universe\SignalR\test\Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest\obj\Debug\net46

02/03/2017  05:47 AM               427 Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.csproj.Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.dll.config

C:\BuildAgent\work\29495d0a71cf35ac\Universe\SignalR\test\Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest>dir obj\Debug\net46\obj\Debug\net46\Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.csproj.Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.dll.config
The filename or extension is too long.

This manifests in the config file not being copied to the output dir - from the build log:
Target "GenerateBindingRedirectsUpdateAppConfig" skipped, due to false condition;
    ('$(AutoGenerateBindingRedirects)' == 'true' and '$(GenerateBindingRedirectsOutputType)' == 'true' and Exists('$(_GenerateBindingRedirectsIntermediateAppConfig)'))
was evaluated as
    ('true' == 'true' and 'true' == 'true' and Exists('obj\Debug\net46\Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.csproj.Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.dll.config')).`

We should open an issue on the SDK for this. Looks like they double-nested the location: obj\Debug\net46\obj\Debug\net46\Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.csproj.Microsoft.AspNetCore.WebSockets.Internal.ConformanceTest.dll.config
Simple fix: shorten the name of the test projects.


Support setting location within image description for usage with show_map

I'm using the following configuration in sigal.conf.py:
show_map = True
leaflet_provider = 'OpenStreetMap.Mapnik'

I've got a collection of pictures where only some of them include GPS information inside their EXIF data/tags. Now I can use something like:
Location: 46.994046,15.440132

or:
Location: Graz Airport

inside the description of an image (since I know where this image was taken), though it's only displayed in the info section of the sigal gallery and AFAICT not considered for displaying on the map view (via key m).
Would be great if there'd be a way how to add location/GPS information to pictures which don't have the according information inside their EXIF data and use that for the show_map feature then.
Thanks for sigal, it's great! :+1:

Setting the coordinates in the image metadata is a good idea! Support names instead of coordinates could be done with some additional dependency (geopy ?), I guess this should be optional.


[Service Bus] ATOM API: Allow configuring "rule" while creating subscription

.NET SDK provides CreateSubscription overload which allows configuring the rule.
public virtual Task<Response<SubscriptionProperties>> CreateSubscriptionAsync(CreateSubscriptionOptions options, CancellationToken cancellationToken = default);
public virtual Task<Response<SubscriptionProperties>> CreateSubscriptionAsync(CreateSubscriptionOptions options, CreateRuleOptions rule, CancellationToken cancellationToken = default);

This issue is to track adding support for the same in Python V7 SDK.
This feature is important because..
While creating a new subscription to an active topic(messages are actively being sent), there is no way users can stop filling up the subscription before the rule filter is added(since the default rule filter is TRUE).
Original issue: Azure/azure-sdk-for-js#12345
@KieranBrantnerMagee @yunhaoling @rakshith91 @ramya-rao-a

Moving the milestone to Backlog as this can be added in the next semester as well. Please feel free to add details on how to approach this task and add the "help wanted" label

Given this operation is available in ARM, we'll update the docstring of the DP operation to suggest to use the ARM API for creation of subcscription with rules, and close the issue.
cc @kashifkhan

Can we please have this added to the python sdk, it’s a standard thing in the azure sdk’s for the other languages as linked above in javascript?


ThemedReactContext is unable to .startActivityForResult()

The ThemedReactContext instance is passed to all ViewManagers. It is an entirely different ReactContext instance to the ReactApplicationContext.
The ReactApplicationContext always receives the onHostResumed() callback which references mCurrentActivity.
The ThemedReactContext instance never receives this callback and thus mCurrentActivity remains null.
When mCurrentActivity is null, themedReactContext.startActivityForResult() throws an exception, crashing the app.
Calls made to themedReactContext.startActivityForResult() should either be forwarded to ReactApplicationContext or mCurrentActivity should be defined when ThemedReactContext is created. Former solution sounds more sane to me.

[x] Provide a minimal code snippet / rnplay example that reproduces the bug.

https://github.com/wilsonpage/react-native-themed-react-context-issue

[x] What's the version of React Native you're using?

v0.27.0

[x] Does this occur on iOS, Android or both?

Android

[x] Are you using Mac, Linux or Windows?

Mac

Do you have any workaround at the moment?

I passed a reference to ReactApplicationContext into the View Manager and used that instead.

@wilsonpage thank you very much, I figured it out after a while and did the same thing!

@facebook-github-bot label Icebox

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/themedreactcontext-is-unable-to-startactivityforresult
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot close


improve error message when importing pandas from source directory

Currently if one imports from the source directory without building the C extension the error message is not very helpful:
ImportError: cannot import name 'hashtable'
I see a few previous PRs (https://github.com/pydata/pandas/pull/3827, https://github.com/pydata/pandas/pull/3821) that tried to address this but somehow this is still the behavior on master.
With this PR the error message would be a lot more informative:
ImportError: C extension: 'hashtable' not built. If you want to import pandas from the source directory, you may need to run 'python setup.py build_ext --inplace' to build the C extensions first.

@jreback @cpcloud

looks ok to me. @shoyer @jorisvandenbossche @cpcloud
?

Indeed, looks good to me

@mortada thanks!


[Bug]: QFileDialog randomly crashing application

Contact Details
<EMAIL_ADDRESS>What happened?
QFileDialog randomly crashing application when closed on Windows with exit code 0xC0000005.
This seems only to happen when calling its static methods (ex: QFileDialog.getOpenFileName) through a context menu action, and only with the native file dialog.
This is most likely due to the context menu being deleted (through Qt.WA_DeleteOnClose) before the native file dialog is closed, causing an Access Violation exception. If the application eventloop was slower in deleting the internal QMenu object, this would likely not cause any crashes.
One possible solution would be removing the Qt.WA_DeleteOnClose attribute from context menus, and garbage collecting the menus through a QTimer hooked onto QMenu.close.
Another is to ditch the native file dialog entirely and use the builtin qt dialog through using the options=QFileDialog.Option.DontUseNativeDialog kwarg.
Version
v0.12a1
What operating system are you using?
Windows
Relevant log output
Process finished with exit code -1073741819 (0xC0000005)

A simpler solution was found, where we just remove the Qt.WA_DeleteOnClose attribute and call menu.deleteLater() after menu.exec() is finished.
Since menu.exec() is synchronous in execution, we can assure that everything is finished before deletion.


Correct the size of certain types on espidf platform

This was initially discovered in https://github.com/esp-rs/rust/issues/92, the reason stat fails on the esp-idf platform is because the stat struct has a different layout on the Rust side compared to the C side.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.
Please see the contribution instructions for more information.

LGTM! Is there a reason why this PR is still a draft?

Apologies! I was double checking the c typedef's are the same in both our xtensa & RISC based toolchains, and forgot to mark this as ready. Should be good to go now :)

@bors r+

:pushpin: Commit ab62380241b431beb929a2f986fe08375e87a091 has been approved by Amanieu

:hourglass: Testing commit ab62380241b431beb929a2f986fe08375e87a091 with merge b1a194cf8e05f4d139f7b6b5810adbff4e17a875...

:broken_heart: Test failed - checks-actions

CI failures seems unrelated? Looks like they're also failing on master.

@bors retry

:hourglass: Testing commit ab62380241b431beb929a2f986fe08375e87a091 with merge 6cf8c368d9c5719728f46b56125ba684ea8fdd06...

:broken_heart: Test failed - checks-actions

@bors retry

:hourglass: Testing commit ab62380241b431beb929a2f986fe08375e87a091 with merge 331859198faafb3544374bf79627b3a7189321b6...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 331859198faafb3544374bf79627b3a7189321b6 to master...

Note that this broke building std on these espidf platforms.
See https://github.com/rust-lang/rust/issues/95924


[Bug] Toast is hidden by PopUp

Description
Toast is not showing, probably behind the PopUp
Steps to Reproduce

Create and open a Rg.Plugin.PopUp covering the bottom of the screen
Open a toast

Expected Behavior
The toast, as a the newest message, should be in front of the whole screen
Actual Behavior
The toast is hidden by the PopUp

I am having this same problem as well. The Popup page is overlapping the toast. You can notice the toast is there if you close the pop up page fast enough.


Why does UserControl does not derive from ContentControl like in WPF?

Why does the UserControl class in UWP does not derive from ContentControl like in WPF?
I guess there's a specific reason for this?

The main purpose of ContentControl is to display any object, so it has an object-typed Content property, and has a ContentTemplate. UserControl is just meant to display an element tree, so it has no ContentTemplate property, and its Content property is UIElement-typed.

Thanks, I see. Do you agree having UserControl derived from ContentControl in WPF was a mistake?
I think so, it doesn't make sense.

Oh, why does Frame derive from ContentControl in UWP? Now I'm confused..

@opcodewriter I assume the design for UserControl is that we don't want to presume that every UserControl can have content -- maybe it can have none or multiple. If you want your UserControl to have Content then you should follow the pattern of ContentControl and have Content, ContentTemplate, ContentTemplateSelector and bind those properties through to a ContentPresenter in your tree.

Oh, why does Frame derive from ContentControl in UWP? Now I'm confused..
Shouldn't Frame also only derive from Control?

Again, I can only guess here but Frame is essentially a ContentControl with policy about the backstack and choosing which piece of content is visible at the current time.


error on for...of statement

Firstly thanks for writing jslint, secondly I found this new for-of loop that javascript has
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
but js lint throws the error

Expected ';' and instead saw 'of'.

(function(){
    'use strict';
    let arr = [3, 5, 7];
    let i;
    arr.foo = "hello";

    for (i of arr) {
        console.log(i); // logs "3", "5", "7", "hello"
    }
}());

I could always use forEach instead but then I can't break out of the loop

(function () {
    'use strict';
    let arr = [3, 5, 7];
    arr.foo = "hello";
    arr.forEach(function (element, index) {
        console.log(element); // logs "3", "5", "7"
        console.log(index);   // logs "0", "1", "2"
    });
}());

what is your opinion, is the for of loop useful or should I use something else instead.
Thanks

The for of statement is a new ES6 feature that has not yet been proven to be a good part.
Recursion is becoming a better approach than looping.

Could this perhaps be reconsidered? It's been 8 more years, and at least to me, for...of loops did turn out to be a good part. If maintainers agree, I might implement this during the next few weeks.
I'm new to JSLint, and really I like it: it is a self-contained, dependency-free tool that just works without npm hell. The one thing I don't like is that jslint cannot parse my loops.

I think that is a good idea. We could also relax the restrictions on 'let' in scopes. Some of the JSLint rules were to get us thru some standard transitions, and I think those are way behind us now.


Possible transmission regressions on model viewer screenshots

Compared to model-viewer screenshots taken with v0.0.13. Could be related to model changes? Or material changes. Should test on windows to avoid mac regressions.
Before

After

Before

After

Rolling back to the old viewer models still shows these issues so something meaningful changed:
https://github.com/gkjohnson/three-gpu-pathtracer/tree/old-viewer-models

v0.0.13 seems to work as the original images while v0.0.14 not - for the suzanne model, at least.

Looks like this change happened in #397

Change happened specifically in c611a95

And the roughness issue is caused by 1fefaebab87e20efba56c10993ae004156f45101


Add support for a Request Queue

Currently all driver requests are handled by calling a REST API. This enhancement will provide a request queue that will automatically queue REST API requests (this will be configurable on a per driver type basis), which can then be consumed in whichever way the driver sees fit (an API will be provided to get the request queue, the request queue will have APIs to consume requests).  The request queue will be based on a partitioned Kafka topic (the usage of Kafka is driven by the fact that it is present in the Accanto LM stack)

Closed by PR #66


k3s_token is undefined?

When running site.yml I am getting this error, site.yml is failing on the main.yml on this task:
- name: Init cluster inside the transient k3s-init service
  command:
    cmd: "systemd-run -p RestartSec=2 \
                      -p Restart=on-failure \
                      --unit=k3s-init \
                      k3s server {{ server_init_args }}"
    creates: "{{ systemd_dir }}/k3s.service"
  args:
    warn: false  # The ansible systemd module does not support transient units
  register: {{ server_init_args }}

The  occurring for all 3 master instances is:
fatal: [<IP_ADDRESS>]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'k3s_token' is undefined\n\nThe error appears to be in '...playbooks/k3s-ansible-k3s-ha/roles/k3s/master/tasks/main.yml': line 15, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Init cluster inside the transient k3s-init service\n  ^ here\n"}
So is this command returning
k3s_token
Is the token what should have populated {{ server_init_args }} ?
My hosts.ini
[master]
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

[node]
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

[k3s_cluster:children]
master
node

Just wanted to give a ➕ 1 on this. Not sure why, maybe related to the newer version os raspberry pi os?

Jk, the issue I had was that the /k3s-ansible/inventory/my-cluster/group_vars' needs to be in the same path as your hosts.ini` I forgot to move mine. I am guessing its the folder structure.

@spencerrung Thanks, I'll try this out.


fix(client): rethrow error for tx

Fixes https://github.com/prisma/prisma/issues/9533
Fixes https://github.com/prisma/prisma/issues/10218
Fixes https://github.com/prisma/prisma/issues/10622
Adds more tests for postgres.
SET FOR RELEASE 3.9.0

Needs https://github.com/prisma/prisma-engines/pull/2619 to be merged on master then tests will pass.


Modify Indexer template to add new field (wazuh.cluster.name)

Description
This issue is aimed at enhancing the functionality of the Wazuh indexer by modifying its template. Specifically, we will be adding a new field under wazuh.cluster.node to capture additional information that can be valuable for cluster management.
Changes Required
The following changes will be implemented:

Modify Indexer Template: The Wazuh indexer template will be modified to include a new field under wazuh.cluster.node.

Definition of Done

The indexer template is successfully modified to include the new field under wazuh.cluster.node.
The updated template is tested for compatibility with the existing Wazuh cluster functionality.

we will be adding a new field under wazuh.cluster.node to capture additional information that can be valuable for cluster management.

What kind of information @Dwordcito ? Is that field a simple field or a nested one?

After discussion in IM.
More definitions:
wazuh.cluster.name is a string.
{
"wazuh": {
"cluster": {
"name": "value"
}
}
}

Understood. The mappings have been updated to match a custom wazuh field with the following properties:
{
  "wazuh": {
    "cluster": {
      "name": {
        "type": "keyword"
      },
      "node": {
        "type": "keyword"
      }
    }
  }
}

I've discovered how to disable the dynamic generation of mappings using the ECS mapping generation tool.
If you try to index a document that contains fields not present in the mappings and the "mappings.dynamic" setting is set to "strict", Elasticsearch or Opensearch will reject the document and throw an error. This is because the "strict" setting instructs the engine to reject any document that contains fields not explicitly defined in the mapping.
This is useful when you want to ensure that all documents adhere to a specific schema and prevent the automatic creation of fields. If you want to allow dynamic field creation, you can set "mappings.dynamic" to "true". If you want to ignore new fields, you can set it to "false".
However, after testing, documents are rejected because of the base.labels field, as this field of type object is meant to be used for the addition of custom values. We currently do not use that fields, so we'll remove it and test how the new mappings work in a real environment.
Vagrantfile

Vagrant.configure("2") do |config|

    config.vm.define "aio" do |aio|
        aio.vm.box = "ubuntu/jammy64"
        aio.vm.synced_folder ".", "/vagrant"
        aio.vm.network "private_network", ip: "<IP_ADDRESS>", name: "vboxnet0"
        aio.vm.hostname = "aio"

        aio.vm.provider "virtualbox" do |vb|
            vb.memory = "4096"
            vb.cpus = "4"
        end

        aio.vm.provision "shell", inline: <<-SHELL
        # Disable firewall
        systemctl stop firewalld
        systemctl disable firewalld

        curl -sO https://packages-dev.wazuh.com/4.8/wazuh-install.sh && sudo bash ./wazuh-install.sh -a
        SHELL
    end

    config.vm.define "agent" do |agent|
        agent.vm.box = "ubuntu/jammy64"
        agent.vm.synced_folder ".", "/vagrant"
        agent.vm.network "private_network", ip: "<IP_ADDRESS>", name: "vboxnet0"
        agent.vm.hostname = "agent"

        agent.vm.provider "virtualbox" do |vb|
            vb.memory = "1024"
            vb.cpus = "1"
        end

        agent.vm.provision "shell", inline: <<-SHELL
            systemctl stop firewalld
            systemctl disable firewalld

            # wget https://packages-dev.wazuh.com/pre-release/apt/pool/main/w/wazuh-agent/wazuh-agent_4.8.0-1_amd64.deb && sudo WAZUH_MANAGER='<IP_ADDRESS>' WAZUH_AGENT_GROUP='default' WAZUH_AGENT_NAME='Wazuh-Agent' dpkg -i ./wazuh-agent_4.8.0-1_amd64.deb

            wget https://packages-dev.wazuh.com/pre-release/apt/pool/main/w/wazuh-agent/wazuh-agent_4.8.0-1_amd64.deb && sudo WAZUH_MANAGER='<IP_ADDRESS>' WAZUH_AGENT_GROUP='default' WAZUH_AGENT_NAME='aio-agent' dpkg -i ./wazuh-agent_4.8.0-1_amd64.deb

            systemctl daemon-reload
            systemctl enable wazuh-agent
            systemctl start wazuh-agent
        SHELL
    end

  end

First, the template has to be updated. I used the Dev Tools from wazuh-dashboard to do that:
Updated index template

POST _index_template/wazuh-vulnerability-detector
{
  "index_patterns": [
    "wazuh-states-vulnerabilities"
  ],
  "priority": 1,
  "template": {
    "settings": {
      "index": {
        "codec": "best_compression",
        "mapping": {
          "total_fields": {
            "limit": 1000
          }
        },
        "number_of_replicas": "0",
        "number_of_shards": "1",
        "query.default_field": [
          "base.tags",
          "agent.id",
          "ecs.version",
          "host.os.family",
          "host.os.full.text",
          "host.os.version",
          "package.name",
          "package.version",
          "vulnerability.id",
          "vulnerability.description.text",
          "vulnerability.severity",
          "wazuh.cluster.name"
        ],
        "refresh_interval": "2s"
      }
    },
    "mappings": {
      "date_detection": false,
      "dynamic": "strict",
      "properties": {
        "@timestamp": {
          "type": "date"
        },
        "agent": {
          "properties": {
            "build": {
              "properties": {
                "original": {
                  "ignore_above": 1024,
                  "type": "keyword"
                }
              }
            },
            "ephemeral_id": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "id": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "name": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "type": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "version": {
              "ignore_above": 1024,
              "type": "keyword"
            }
          }
        },
        "ecs": {
          "properties": {
            "version": {
              "ignore_above": 1024,
              "type": "keyword"
            }
          }
        },
        "host": {
          "properties": {
            "os": {
              "properties": {
                "family": {
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "full": {
                  "fields": {
                    "text": {
                      "type": "text"
                    }
                  },
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "kernel": {
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "name": {
                  "fields": {
                    "text": {
                      "type": "text"
                    }
                  },
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "platform": {
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "type": {
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "version": {
                  "ignore_above": 1024,
                  "type": "keyword"
                }
              }
            }
          }
        },
        "message": {
          "type": "text"
        },
        "package": {
          "properties": {
            "architecture": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "build_version": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "checksum": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "description": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "install_scope": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "installed": {
              "type": "date"
            },
            "license": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "name": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "path": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "reference": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "size": {
              "type": "long"
            },
            "type": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "version": {
              "ignore_above": 1024,
              "type": "keyword"
            }
          }
        },
        "tags": {
          "ignore_above": 1024,
          "type": "keyword"
        },
        "vulnerability": {
          "properties": {
            "category": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "classification": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "description": {
              "fields": {
                "text": {
                  "type": "text"
                }
              },
              "ignore_above": 1024,
              "type": "keyword"
            },
            "enumeration": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "id": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "reference": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "report_id": {
              "ignore_above": 1024,
              "type": "keyword"
            },
            "scanner": {
              "properties": {
                "vendor": {
                  "ignore_above": 1024,
                  "type": "keyword"
                }
              }
            },
            "score": {
              "properties": {
                "base": {
                  "type": "float"
                },
                "environmental": {
                  "type": "float"
                },
                "temporal": {
                  "type": "float"
                },
                "version": {
                  "ignore_above": 1024,
                  "type": "keyword"
                }
              }
            },
            "severity": {
              "ignore_above": 1024,
              "type": "keyword"
            }
          }
        },
        "wazuh": {
          "properties": {
            "cluster": {
              "properties": {
                "name": {
                  "ignore_above": 1024,
                  "type": "keyword"
                },
                "node": {
                  "ignore_above": 1024,
                  "type": "keyword"
                }
              }
            }
          }
        }
      }
    }
  }
}

Also in the UI, go to Indexer/dashboard management < App Settings < Miscellaneous and run a Health-check to create the index pattern.

After that, I checked the UI section at Threat Intelligence < Vulnerability detection. Results are below:

I also made an E2E test as follows. The wazuh-server was restarted after editing the ossec.conf and agent.conf files.
ossec.conf

  <vulnerability-detection>
    <enabled>yes</enabled>
    <index-status>yes</index-status>
    <feed-update-interval>60m</feed-update-interval>
  </vulnerability-detection>

  <indexer>
    <enabled>yes</enabled>
    <hosts>
      <host>https://<IP_ADDRESS>:9200</host>
    </hosts>
    <username>admin</username>
    <password>uUmaWuLr*CdGO+0HI5B7+u.9mMqhw4i?</password>
    <ssl>
      <certificate_authorities>
        <ca>/etc/filebeat/certs/root-ca.pem</ca>
      </certificate_authorities>
      <certificate>/etc/filebeat/certs/wazuh-server.pem</certificate>
      <key>/etc/filebeat/certs/wazuh-server-key.pem</key>
    </ssl>
  </indexer>

shared agent.conf

  <agent_config>
    <!-- Shared agent configuration here -->
    <wodle name="syscollector">
        <disabled>no</disabled>
        <interval>5m</interval>
        <scan_on_start>yes</scan_on_start>
        <hardware>yes</hardware>
        <os>yes</os>
        <network>yes</network>
        <packages>yes</packages>
        <hotfixes>yes</hotfixes>
        <ports all="no">yes</ports>
        <processes>yes</processes>
    </wodle>
  </agent_config>

filebeat test output

  root@aio:/home/vagrant# filebeat test output
  elasticsearch: https://localhost:9200...
  parse url... OK
  connection...
    parse host... OK
    dns lookup... OK
    addresses: <IP_ADDRESS>
    dial up... OK
  TLS...
    security: server's certificate chain verification is enabled
    handshake... OK
    TLS version: TLSv1.2
    dial up... OK
  talk to server... OK
  version: 7.10.2

Manager & agent logs

No events were generated:

I created a newer version of the wazuh-install.sh script with the changes from v4.8.0-alpha2, installed an AIO deployment in Vagrant and carried on the tests:
git clone https://github.com/wazuh/wazuh-packages.git
cd wazuh-packages/
git checkout 4.8.0
cd unattended_installer/builder.sh -i -d pre-release

Before: 222 documents after 5 minutes

After: 222 documents after 5 minutes

Conclusion: tests passed 🟢