[WIP] ISSUE-53 ~ Request: Show text for specific categories

Description
This PR change the checkbox system in Options > Icon Categories adding two icons, an eye to show or hide the icon and a message bubble to see or hide the labels.
Is a little PR right now and is an Work In Progress, but I'm opening it in order to get feedback and any suggestion/recommendation about the solution proposed
Related issue
Issue: #53
Screenshoots

Status
This is a pretty functional version, but there's missing somethings:

Mass activation / deactivation
Category selection

What is the behaviour when the icon is invisible, but the text is visible?

I personally don't think anyone would like text without icons. But I also think it should be obvious from the menu what the behaviour is and right now that isn't clear to me.

Got it! I'll improve this! I think that #81 will do it easier!

I played around with your branch for a while, and I definitely like the option to turn on/off text per icon type. It adds more flexibility, and being able to customize the experience is great! 😄

I agree that no labels should be drawn if the icon is not visible at all. It's harder to pinpoint locations.
We discussed your PR in private, and we're afraid that the settings would become too cluttered. #81 was indeed a sort of step up for that :)
The UI needs to be clear too. Checkboxes are very obvious, but an icon change might be too subtle of a change, especially for visually impaired users. I would suggest making the state more obvious, like so maybe:

There should be no duplicate IDs in HTML. So a different way of selecting elements will be required.
About data storage; this will work, but a cleaner approach would be to have one implementation for loading and storing settings. A more preferable way would be too add a property parameter to the load and store functions, so you'd end up withloadIconType(category: string, type: string, property: 'visible' | 'label') {
    const key = `${iconSettingStorageScope}::${category}--${type}.${property}`;
    // ...
}

which is a more generic implementation, and contains less repetition. I suppose it would be even better still to extract the type of the parameter to a separate type declaration.


Fixes to bring core/simulator into alignment with SGX

In testing SGX implementation, I found inconsistencies in the core and simulator code that needed to be brought into alignment so that the SGX enclave would work.
Signed-off-by: Jamie Jason<EMAIL_ADDRESS>

Rebase before merge


Make Project Responsive for All Devices.

Currently, our project may not provide an optimal user experience on various devices with different screen sizes. By making the project responsive, we can ensure that users can access and interact with our application seamlessly, regardless of the device they are using. By implementing responsive design using Tailwind CSS or Bootstrap, we can ensure that our project provides an optimal viewing and interaction experience across all devices, improving user satisfaction and engagement.

@vaishnavi192 the issue has been assigned to you. Best of luck.

@AdeebaNizam10 assigned the issue to you. Good luck!

I want to know who is my mentor for the project .... As I want to ask
questions regarding the project
On Tue, Oct 1, 2024, 5:41 PM Vishnudhasan Govindarajan <
@.***> wrote:

@AdeebaNizam10 https://github.com/AdeebaNizam10 assigned the issue to
you. Good luck!
—
Reply to this email directly, view it on GitHub
https://github.com/GVishnudhasan/NoDueProject/issues/10#issuecomment-2385612334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHNUKGMIYJH3BKMUISU6HHLZZKGQZAVCNFSM6AAAAABPFNQICOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBVGYYTEMZTGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@AdeebaNizam10 Kindly reach out to the mentors in discord. they will help.

I noticed the open issue about making the project more responsive, and I'd be excited to tackle it. With my extensive experience in front-end development and ensuring websites look great on all devices, I’m confident I can optimize the project for a seamless experience across different screen sizes.
Assigning this issue to me means you’ll get a responsive design that's user-friendly and maintains the project's aesthetic integrity. I’m eager to start on this and deliver high-quality results promptly.
Looking forward to the opportunity!

I have already been assigned

@AdeebaNizam10 This issue is open since a long. Kindly give an update on the same. In the worst case, the issue might be assigned to others. Thanks.

Sir ... Please wait till 11 ... It is almost completed


Questions about levelCols and levelRows in ORBExtractor

const int levelCols = sqrt((float)nDesiredFeatures/(5imageRatio));
const int levelRows = imageRatiolevelCols;
above code pasted from ComputeKeyPoints() function. I want to kown why calc the two value in this way but  they are const variable 30 in ORB_SLAM2 code.
hope for your reply. thanks

These are from ORB_SLAM. I don't know why they did this when upgraded to ORB_SLAM2.

ok, thanks


SQL generation issue when doing a SUM with a column Coalesce function in it

I have a class (called Transaction), which has a property defined as a nullable integer (int?). I then run a Linq command against this property to SUM all the values together. Note: some transactions have a NULL vaue for this field.
public class Transaction
{
    ...
    int? numberOfUnits {get; set;}
    ...
}

The Linq command looks like this
_context.Transactions
    .Sum(x => x.NumberOfUnits ?? 0);

This generates an invalid SQL command stating "'sum' is not a recognized built-in function name.". This is because the generated SQL is invalid. The SQL generated is as follows:
SELECT sum(COALESCE([x].[NumberOfUnits], 0) AS [Coalesce])
FROM Transaction AS [x]

NOTE: the issue is actually the fact that the coalesce generates an alias for itself. NO alias should be generated for the Coalesce at all

This issue was moved to aspnet/EntityFramework#7428


Removes events

Codecov Report

Merging #1481 (82add21) into main (252ff65) will decrease coverage by 0.13%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   48.71%   48.59%   -0.13%
==========================================
  Files         255      248       -7
  Lines       15556    15284     -272
==========================================
- Hits         7578     7427     -151
+ Misses       7978     7857     -121

Impacted Files
Coverage Δ

lnbits/extensions/lnurlp/migrations.py
81.48% <0.00%> (-14.82%)
:arrow_down:

lnbits/db.py
81.20% <0.00%> (-10.07%)
:arrow_down:

lnbits/commands.py
61.40% <0.00%> (-1.76%)
:arrow_down:

lnbits/utils/exchange_rates.py
89.83% <0.00%> (+3.38%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Bluealsa crash when using aptX

When running mplayer with multiple files with a set of headphones supporting AptX, bluealsa crashes when mplayer switches files. Investigation led to attempting to free the same memory twice: in file aptx-ffmpeg.c line 137 from the openaptx project,
encoder_ctx_free is called; in a2dp-audio.c, a thread cleanup handler is also freeing the context. This double free causes bluealsa to crash. I removed the thread cleanup handler call from a2dp-audio.c, and this fixes the crash. Here's a link to a patch.
a2dp-audio.c.patch.txt

Thanks for reporting this issue. However, the bug is on the openaptx side (cleanup handler in the a2dp-audio.c is required). I will try to fix it as soon as possible.


Create ayushi-pr.md

created ayushi-pr.md please review
@AKSHITHA-CHILUKA

Pending PR level 3: https://github.com/Manishkr1007/WordWeaver/pull/147#issuecomment-2457861698
Has given a lot of time and efforts but did not get merged


Create sophatel.txt

@a-homsi This domain does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.


when building show ‘AppOptions’ object has no attribute ‘extensions’

https://discourse.jupyter.org/t/appoptions-object-has-no-attribute-extensions/11487

ERROR: Invalid requirement: 'jupyterlab,==3.*'

i finally solve this problem by
https://teratail.com/questions/348800

@freemedom 's link does appear to work. Thanks! Here is the command:
jupyter labextension install<EMAIL_ADDRESS>

3.0.7 is the latest tagged release
It appears that pinning to 3.0.7 is critical to getting the build to work.
v3.0.9 is currently on npm? If 3.0.9 is unstable then I'm not surprised that it didn't work.

Somehow this also fixed a lot of my other extensions by causing "linkages" to occur?! (I don't think that this extension broke those extensions.)


Upgrade LLVM to 15 when TVM build

#680
#681

The error log is here.

[100%] Building CXX object CMakeFiles/tvm_objs.dir/src/contrib/hybrid/codegen_hybrid.cc.o
[100%] Built target tvm_objs
[100%] Linking CXX shared library libtvm.dylib
ld: library not found for -lzstd
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libtvm.dylib] Error 1
make[1]: *** [CMakeFiles/tvm.dir/all] Error 2
make: *** [all] Error 2
Error: Process completed with exit code 2.

Looks like zstd is missing but it's installed.
The same error happened on my local M1 Mac machine.
Without --link-static, the build worked fine.
CC: @masahi Have you encountered any similar errors?

The error is coming from LLVM. I heard that LLVM has recently started to depend on zstd. So you need to install libzstd-dev.


added pantone swatch links

added pantone swatch links to featured action

I think there was some talk about removing pantone stuff in main


Could not find a configuration file for package "OpenCV" that exactly   matches requested version "3.1".

I have opencv installed and I want to install cv for torch. I tried luarocks install cv. I got following error.
CMake Error at CMakeLists.txt:30 (FIND_PACKAGE):   Could not find a configuration file for package "OpenCV" that exactly   matches requested version "3.1".
The following configuration files were considered but not accepted:
/home/kushal/opencv-3.1.0/cmake/OpenCVConfig.cmake, version: unknown
/usr/local/share/OpenCV/OpenCVConfig.cmake, version: 3.3.0

--Configuring incomplete, errors occurred!     See also "/tmp/luarocks_cv-scm-1-5467/torch-opencv/build/CMakeFiles/CMakeOutput.log".     make: *** No targets specified and no makefile found.  Stop.
I have opencv 3.3 installed but not opencv 3.1.
What is the way to fix this?

you need to git clone the code. Make 2 version number changes according to https://github.com/VisionLabs/torch-opencv/issues/190#issuecomment-333013114
Duplicate of #190
install by lua make cv-scm-1.rockspec
at the end, you may also need to remove libopenblas-base if you have ubuntu 16.04..

Thanks. It worked :)


Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The canvas has been tainted by cross-origin data.

When I load or refresh the page a tetromino flashes in at the top of the screen and disappears.
Looks like there is a CORS issue with loading the images to the canvas. I tried allowing cross origin requests with this plugin, but its still failing. Might just an issue when running the program locally and might not happen in the files are all being requested over http: instead of from file:
Not sure how to fix this at the moment.
Fun project though dude!


phone.number

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b089fb0) to head (82f46ba).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines           89        91    +2
  Branches        14        14
=========================================
+ Hits            89        91    +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cannot start after smartscreen warning

I managed the smartscreen error message but was greeted after that with the next security warning. There is nothing I can do here except closing it. Any ideas? I am not running any fancy security software.

Here I am again.
This anwer solved it https://superuser.com/a/1252757
You may want to link it in your readme?
thx and close at your wish :-)

Thank you for figuring it out! I've added it to the readme (on de develop branch for now).


Urgent: Move off CNCF Equinix Resources

Describe the software update
Need to move cnf-testsuite out of the CNCF Equinix donated resources
Describe why update is needed
Equinix has changed the policy so only CNCF projects are eligible to use the donated resources
Additional context

#1777 - number of resources were lowered in January
need to decide on where to remove the remaining resources

Tasks

[ ] Determine replacement for Equinix resources
[ ] Plan migration
[ ] tbd
[ ]

@rannyh LFN and/or community donated resources will need to be allocated for the CNTi project needs.  This includes the CI pipeline for GitHub actions.
There were some ideas put forward in Fall of 2023 and the earlier part of 2024 included Circle CI for something cost-effective. There are also some current LFN resources that have been mentioned.
If something can be identified soon, even for temporary use, then the current CI can be worked on to move over with limited interruption. Otherwise the CI will be shutdown until something is found which will be a slow down on integrated contributions (eg. Pull Requests specifically will have a big obstacle).
cc: @martin-mat @Smitholi67 @wavell

Next steps:

Vulk Prepare Hardware requirements for runners (send to LJ)

what we use now (non-optimal)
What is optimal
Short-term suggestions
Longer-term suggestions

send requirements/recommendations to LJ
LJ will send requirements/recommendations to LF IT

Draft for hardware requirements started in https://docs.google.com/document/d/1GtOQCCMIusdKkea64m5XBS_0vmiLGd7sgyOsbkU0IiE/edit

Circle CI will probably be the most cost effective for a hosted solution.

LF IT came back with; GitHub increased the base size of their free runners early this year. Is it possible the increases will allow use of the free GitHub runners?

LFN has a “Lab as a Service” (LaaS) program that is run out of the University of New Hampshire. As an LFN initiative CNTi runners can potentially be hosted under the LFN LaaS program.
This is from the LaaS lead at UNH: The specs of the servers in LaaS are a bit larger than the ones listed on Github issues, except for the processor generation, where the LaaS servers have Intel Broadwell generation Xeon CPUs. That would only matter if the testing actually requires instruction sets that were available in that generation (i.e. AVX512).

@taylor @wavell @denverwilliams @agentpoyo @HashNuke @martin-mat please review the options above

Free GitHub runners
They can only be used if test coverage is disabled/removed, including some telecom + networking-focused tests. This will lead to reduced velocity as a result of bugs and other issues as the project moves forward.

“Lab as a Service” (LaaS) program from the University of New Hampshire
This should work for the CI system and may allow increasing velocity with more available resources.

CircleCI -- $200-$300/month
Another recommended alternative covering velocity requirements

@lilluzzi when will the LaaS systems be available to start using and migration?

Next Step:

@denverwilliams @taylor Start trial with “Lab as a Service” (LaaS) program from the University of New Hampshire

Currently testing UHN systems.
Earlier today the CNCF lab Equinix systems used for this project were stopped.  They have been turned back on to allow the CI runners to work and builds to continue. I expect they will be shutdown sooner than later.

@lilluzzi @rannyh FYI,
Currently testing UHN systems.
Earlier today the CNCF lab Equinix systems used for this project were stopped. They have been turned back on to allow the CI runners to work and builds to continue. I expect they will be shutdown sooner than later.

@denverwilliams the following systems are ready for further testing

<IP_ADDRESS>
<IP_ADDRESS>

Mon, May 20 update: Denver is not able to access the systems above via VPN as expected. Debugging with UNH support in progress.

There have been continued issues with using a docker + kind setup directly on the system.  As a result we have switched to setting up a VM setup for the docker + kind runner setup which will allow expanded usage of the larger resources on the UNH system.
Vagrant setup for GitHub Action runners is in progress and expected to work in the next 24 hours.  After this automated spec testing should speedup.

Suggested resource requirements for the CNTi project CI runners, based on Equinix machine types:

Ideal: 7x c3.small.x86 - increases the speed of testing and allows some concurrent testing
Dynamic: 6x c3.small.x86 - dynamic, slower but probably better than we have now for much less cost.
Adequate: 3 x c3.small.x86 - what is currently in use. hours delay for each test

The Equinix c3.small.x86 is a legacy on-demand server with the following hardware configuration:

1 x Intel® Xeon® E-2278G
8 cores @ 3.40 GHz
2 x 480 GB SSD
32 GB RAM

@martin-mat


Disable payment for refunded/canceled orders

What I'm trying to achieve
:raising_hand_man: Disable payment for refunded/canceled orders. I know that #3636 have asked for this, but it has no data about this issue so here we go.
Steps to reproduce the problem

Make an order and pay it.
Refund the order in the dashboard.
 Ups! You Can't! :tipping_hand_woman:

What I expected to happen
When the order is refunded/canceled, customers should not be able to pay for it again.
Screenshots
But they can! :smile_cat:

@maarcingebala seems like a bug to me. Your thoughts?

IMHO, even the partially refunded order shouldn't be paid again.

Right, it looks like a bug. If an order is refunded, partially refunded or canceled customers shouldn't be able to pay. We have to also make sure that they can retry payment if they placed an order, tried to pay but the payment has failed. We should also provide test cases for these scenarios.

I will take a look whenever I have some free time for it.

For now, I've unassigned you @NyanKiyoshi, anyone who we'll have time to tackle it will be able to take it.

I had started working on it a week ago during my free time, but I got stuck, so I did not go further and then forgot about this issue.
My problem was that I'm not sure how Saleor should behave when an order is whether partially or fully refunded. Should we flag the order as closed? Thus, make it inactive. Then no payment or change would be possible.
The other thing I thought about was that we could maybe ask the staff user to choose whether to close or not a refunded order.
Then, another thing to be careful about, is if we decided to close an order when partially refunded, the staff user should still be able to refund again a new amount.

@NyanKiyoshi Maybe we could just disable payment for refunded order in storefront 1.0 first as a starter?

@jxltom it should disable from the core!

i changed the check_order_status function.
def check_order_status(func):
    """Check if order meets preconditions of payment process.

    Order can not have draft status or be fully paid. Billing address
    must be provided.
    If not, redirect to order details page.
    """
    # pylint: disable=cyclic-import
    from .models import Order

    @wraps(func)
    def decorator(*args, **kwargs):
        token = kwargs.pop("token")
        order = get_object_or_404(Order.objects.confirmed(), token=token)
        if not order.billing_address or order.is_fully_paid() or not order.status == 'cancelled' :
            return redirect("order:details", token=order.token)
        kwargs["order"] = order
        return func(*args, **kwargs)

    return decorator

and in the front i changed order details .
`{% if not order.is_partly_paid and not order.status == 'canceled'  %}`
and problem is solved:)
if there is a mistake with my code or any problem .
please some one tell me:)


[Backport] [2.x] Update to Gradle 8.5 (#1131)

(cherry picked from commit 7c0ce4cb554a05230ecf5365b903219f357997bf)
Description
Backport of https://github.com/opensearch-project/anomaly-detection/pull/1131 to 2.x
Issues Resolved
Part of https://github.com/opensearch-project/OpenSearch/issues/10334
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Seeing this jackson-core error which is causing 2.x branch build failure. Should we force jackson-core version to be 2.16.1?
Reference: https://github.com/opensearch-project/flow-framework/blob/main/build.gradle#L172

Seeing this jackson-core error which is causing 2.x branch build failure. Should we force jackson-core version to be 2.16.1?

Do you use explicit version ? Or it is transitive dependency (sorry, I didn't check but I will if you don't know).

Seeing this jackson-core error which is causing 2.x branch build failure. Should we force jackson-core version to be 2.16.1?

Do you use explicit version ? Or it is transitive dependency (sorry, I didn't check but I will if you don't know).

Looks like it's coming from core as there's no occurrence of 2.16.1 in 2.x of AD . I tried to get the tree on main branch got the idea that it's a transitive dependency from core
+--- org.opensearch.test:framework:3.0.0-SNAPSHOT
|    +--- org.opensearch.client:opensearch-rest-client:3.0.0-SNAPSHOT (*)
|    +--- org.opensearch.client:opensearch-rest-client-sniffer:3.0.0-SNAPSHOT
|    |    +--- org.opensearch.client:opensearch-rest-client:3.0.0-SNAPSHOT (*)
|    |    +--- org.apache.httpcomponents.client5:httpclient5:5.2.1
|    |    +--- org.apache.httpcomponents.core5:httpcore5:5.2.2
|    |    +--- commons-codec:commons-codec:1.15
|    |    +--- commons-logging:commons-logging:1.2
|    |    \--- com.fasterxml.jackson.core:jackson-core:2.16.0

Note: The above is on the main branch.

Seeing this jackson-core error which is causing 2.x branch build failure. Should we force jackson-core version to be 2.16.1?

Do you use explicit version ? Or it is transitive dependency (sorry, I didn't check but I will if you don't know).

nvm, we can take care of the jackson-core version in a separate pr since it's not causing build failure in this pr build. We just need to verify if it's a flaky test that is causing this build to fail - https://github.com/opensearch-project/anomaly-detection/actions/runs/7559131041/job/20750086870?pr=1132. After that we can go ahead merging this pr :)

Or you can just change the jackson-core version here to 2.16.1 to align with core jackson-core version that's defined here - https://github.com/opensearch-project/OpenSearch/blob/2.x/buildSrc/version.properties#L10-L11

So there is explicit version management, makes sense to change it here. I will update the pull request shortly, thanks @owaiskazi19 @jackiehanyang

Checks are super unstable folks :(

@reta do we need to make the dependency upgrades on main first and then backport to 2.x?

@reta do we need to make the dependency upgrades on main first and then backport to 2.x? Otherwise, there will be discrepancies between versions.

Ah, I will do the PR in a sec for main


allow multiple paths in CLRENV_OVERLAY_PATH, separated by :

for ColorGenomics/color#2059

hmm, can't assign because i'm not a member of the repo? @kn...i choose^H^H^H assign you!
also cc @bhatman

LGTM
added you in the repo


Network Modes

Im pretty new to this and was wondering which is the best networking mode to use

You try out different modes and use the one you feel the most comfortable with.


[zh] fix a typo in persistent volumes pages

this PR https://github.com/kubernetes/website/pull/26032

/assign @tengqm

/assign @tengqm

dup of #26028

dup of #26028


Added MireDot as a REST API doc generator

This work is based on current discussion.
I haven't removed jax-doclets and only added Miredot.
There are some examples of possible documentation variants. In this source code I use the second variant (Multi page collapse all).
We are also able to:

change title;
hide Issues tab;
add HTML snippet with introduction text.

Also I'm able to refactor current API realisation later. It will simplify and improve documentaion.

Relevant JIRA: https://issues.jboss.org/browse/AGPUSH-1366
@idelpivnitskiy do you have a JIRA account already? Feel free to assign the above ticket to you, and link from there to this PR
nice work!!

@matzew thanks!
Yes, my JIRA account is the same as GitHub account. I've added PR to this issue, but I think that I haven't got permissions to assign it to me.

@matzew Which variant of  presented docs do you prefer? And what do you think about custom titile, HTML snippet, issues tab? See my first comment.

Yes, my JIRA account is the same as GitHub account. I've added PR to this issue, but I think that I haven't got permissions to assign it to me.

hrm, need to check what's going on

@idelpivnitskiy can you rebase your branch, on latest changes on master ?

@matzew done :)

@matzew I hurried to merge your commit. If you want to fully remove jaxrs doclet, we also have to remove doclet's specific javadoc tags, like @HTTP. I suggest to remove your current commit from my branch (with force push), update your commit and open a new PR to my branch.

@matzew @sebastienblanc I've split UnifiedPushMessage and for the quick fix I've removed ipAddress from test json files. Is it ok? Should I override UnifiedPushMessage.toStrippedJsonString()?

I would prefer to see that in a separate PR.
Envoyé de mon iPhone

Le 4 mai 2015 à 02:32, Idel Pivnitskiy<EMAIL_ADDRESS>a écrit :
@matzew @sebastienblanc I've split UnifiedPushMessage and for the quick fix I've removed ipAddress from test json files. Is it ok? Should I override UnifiedPushMessage.toStrippedJsonString()?
—
Reply to this email directly or view it on GitHub.

@sebastienblanc done
I'll update miredot documentation for the send method after merging #542

@matzew @sebastienblanc updated http://condor.pp.ua/aerogear-ups-rest-api-doc/latest/index.html

looks very nice !
once we have the analytics thing in, I will address some of your comments
on this PR, sounds good ?
On Thu, May 7, 2015 at 12:03 PM, Idel Pivnitskiy<EMAIL_ADDRESS>wrote:

@matzew https://github.com/matzew @sebastienblanc
https://github.com/sebastienblanc updated
http://condor.pp.ua/aerogear-ups-rest-api-doc/latest/index.html
—
Reply to this email directly or view it on GitHub
https://github.com/aerogear/aerogear-unifiedpush-server/pull/526#issuecomment-99801876
.

--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@matzew ok

Closing in fav. of https://github.com/aerogear/aerogear-unifiedpush-server/pull/550


Questions about features

Is it possible to blur an area (sensitive information, background etc.) during recording or edit the screencast afterwards in kap?
Is it possible to have picture-in-picture, such as a small picture of webcam on the bottom-right?
My apologies if it's considered out of scope for kap or it's already documented somewhere but I missed!

@davxiao I haven't used that feature myself, so I don't know how well it works (or if it works), but it seems that there is already an option to show the camera while recording, which seems to be what you are after:

I would be interested in a feature that blurs specific areas of the video.


Make all String float conversion methods be 64-bit

This is in a similar vain to #38713, and fixes #40624.
The current 32-bit and 64-bit methods are identical to each other. Literally, the 32-bit float version was just a wrapper:
float String::to_float() const {
	return to_double();
}

This PR removes the 32-bit versions, and renames the 64-bit versions from "to_double" to "to_float".
Test code:
func _ready():
	print(float("122.54"))
	print(float("99264.899"))
	print(float("12.5"))
	print(float("6998.904"))
	print(float("9.69"))
	print(float("9799.1111"))

Needs a rebase (tests were moved to tests/, otherwise should be good to merge (reduz approved™).

Thanks!


Migrate sanity-plugin-table to Sanity V3

Follows https://beta.sanity.io/docs/platform/studio/v2-to-v3/plugins
Changes

Removes the rowType feature that was only needed when the row type was renamed from version 1 -> 2
Removes all the custom css in favor of inline styles and using Sanity UI components. It is not a 1-1 change but generally looks good
Refactors some of the file locations. All the schemas are now in the src/index.ts inline with the definePlugin definition
Renders "Empty Table" when the table has not been created yet
Removes all references to React.FunctionComponent
exports the plugin as { table }

Outstanding issues

When the preview is focused, its not updating the styles of the Textbox and table preview with the focus background color. According to the documentation, the elementProps need to be forwarded to the component, but they don't appear to be passed to the preview component. I asked a question in the sanity input component discussion on how to do this correctly, hopefully we get an answer

This is awesome stuff! Trying to determine what to do about ownership an naming, and will do a proper review shortly.
In the meantime: We have been doing some work lately on plugin-kit to ship an opinionated used-by-sanity semantic-release driven Github workflow as an opt-in feature.
To test it (I would recommend this as part of a PR anyway ;) )

update plugin-kit to ^2.1.13,
commit any changes (so you have no local diff)
in your repo root run npx @sanity/plugin-kit inject --preset-only --preset semver-workflow
follow the instructions in command log
npm i (note to self: this should be part of above instructions)
inspect the diff to see what changed:

husky setup to enforce conventional-commits
semantic-release with sanity-opinionated dependency
Full github workflow with click-to-release support via Github actions

Incidentally I will talk about this that in tomorrows Sanity meetup ;)

Quick followup: @sanity/table it it - meaning, we will take it in officially for v3.
Are you ok with me picking up this PR later this week, moving a fork into the sanity org and publishing it?
If you would rather us hash it out here, I'm all for it.
Thank you for doing this :D 🥇

Hello @snorrees, I appreciate the writeup! That all sounds great to me, and I can certainly test out the plugin-kit features you mentioned, although I would love for sanity to take over stewardship for this plugin to V3!
Another item that is important to me, we want to add features to this table over time, including PortableText support for table cells. Is that something you see supported in the official Sanity fork? Would you accept PRs for that?
Regarding the Sanity Meetup, I will try to attend tomorrow, I signed up! Will you be talking about this plugin, or more generally about plugin-kit, or both? Looking forward to it

Will be about plugin-kit, its not a very long piece, but a intro to how we encourage it as the one-stop-shop for building sanity packages.
If you are looking to add a bunch of features the quickest way forward for you will probably be to maintain it yourself.
We will of course try to be on the ball on looking at PR's but I cannot make any promises unfortunately.
This time around we will put this out as a version for V3, based on this PR and revisit as time permits.
At least this way, there is a much shorter path from @sanity/table to your feature-added fork, hopefully.

@davydog187 @sanity/table 1.0.0 for v3 is now out. Thanks a lot for this work!


#9339: Add optional output to run_with_autoformat, bcast, mul_unary

Add optional output to run_with_autoformat
Add queue_id support to these ops.

for bcast to support add/div/mul_unary ops
for unary ops - recip

CI test: https://github.com/tenstorrent/tt-metal/actions/runs/9501292749
What's been changed ?

To add output_tensor, queue_id support to mul_unary, bcast op was also modified to support output_tensor, queue_id
run_with_autoformat operation modified to pass optional output_tensor to run operation

What's the expected result?

mul_unary expected functionality when output_tensor is passed

tt_lib.tensor.mul_unary(input_tensor, scalar, output_tensor=output_tensor, queue_id=queue_id)

@arakhmati can we replace use of run_with_autoformat with run in all these cases??

@arakhmati can we replace use of run_with_autoformat with run in all these cases?

@ayerofieiev-tt Yes. It can be replaced everywhere. Some tests will just need to be updated

This is just a question but why do we have the C++ functions have cq id as the first arg with no default value, but at the python level we wrap it in a lambda so that we put q id last with default value 0? @eyonland

Python allows an argument to be a key-value argument. So user can specify an optional argument queue_id= somewhere after required positional args. This is convenient and is expected from a python library.
C++ does not allow that and adding it as a last arg would force one to specify the whole set of default values before actually setting the queue_id, thats why we have two overloads - where one has queue_id as the first argument. Second overload just calls it with default value.
CC @arakhmati @eyonland

This is just a question but why do we have the C++ functions have cq id as the first arg with no default value, but at the python level we wrap it in a lambda so that we put q id last with default value 0? @eyonland

Python allows an argument to be a key-value argument. So user can specify an optional argument queue_id= somewhere after required positional args. This is convenient and is expected from a python library. C++ does not allow that and adding it as a last arg would force one to specify the whole set of default values before actually setting the queue_id, thats why we have two overloads - where one has queue_id as the first argument. Second overload just calls it with default value.
CC @arakhmati @eyonland

Is there a reason to have 2 bindings for python then? Seems like we have a binding with no queue id, and then a binding with queue id with a default value. Seems redundant?

This is just a question but why do we have the C++ functions have cq id as the first arg with no default value, but at the python level we wrap it in a lambda so that we put q id last with default value 0? @eyonland

Python allows an argument to be a key-value argument. So user can specify an optional argument queue_id= somewhere after required positional args. This is convenient and is expected from a python library. C++ does not allow that and adding it as a last arg would force one to specify the whole set of default values before actually setting the queue_id, thats why we have two overloads - where one has queue_id as the first argument. Second overload just calls it with default value.
CC @arakhmati @eyonland

Is there a reason to have 2 bindings for python then? Seems like we have a binding with no queue id, and then a binding with queue id with a default value. Seems redundant?

You are right, there should only be 1 binding


Repeat button doesn't work

Repeat button doesn't work
Environment

Browser: chrome
Browser Version:  Version 61.0.3163.100 (Official Build) (64-bit)
Operating System: linux
Amplitude.js Version: 3.2.0

Issue description
The track does not repeat when the repeat button is pressed
Steps to reproduce the issue

go to https://521dimensions.com/open-source/amplitudejs
select random track
Push repeat button on
Wait till track end
No repeat of track

What is expected?
I expect track repeat when repeat button is pressed
Link to where issue can be reproduced
https://521dimensions.com/open-source/amplitudejs

Hi @BronzeCrab,
This functionality is similar to how Spotify works and will repeat after the playlist has completed playing. I will look into adding an individual song repeat button in future releases.

@danpastori
Hi, ok, thanks


workspace settings.json changes dont update in WSL unless you reload the window

VSCode Version: 1.44.0
OS Version: Win 10 v2004 OS Build 19041.173

Steps to Reproduce:

open folder
open settings.json in .vscode folder
make a change, eg "editor.fontSize": 18 --> "editor.fontSize": 22
work space is not updated

Does this issue occur when all extensions are disabled?: Cannot disable extensions or else WSL doesnt work?
If you make alterations to the settings.json file in the .vscode directory within your project, the settings aren't updated unless you reload the window. However, if you make the settings changes in the settings UI , the changes are immediately reflected.
Kind of minor I suppose but something that confused me for a little bit

However, if you make the settings changes in the settings UI , the changes are immediately reflected.

What settings are you changing from UI ? Workspace or User?


Implementation Interfaces

Hey @mrsimpson I'm going to be using this repository for a little while until things are ready to be moved into Rocket.Chat itself then we'll move underneath the Rocket.Chat organization.
My question is, what should the interfaces be named which the Rocketlets will implement when they implement that said feature? Should it be IPreMessageSentListener or just IPreMessageSent? And then if they're handling incoming webhooks, IWebHookListener?

@graywolf336 better not ask me for naming things. I'm quite ... special about that...
I'd call the interfaces with a suffix (like "listener") only if I can think of other meaningful suffixes. In this case, where an interface describes handling of an event, I'd call them like the event as this is the main purpose, so "IPreMesageSent".
I'd expect it to have methods like "validate", "modify" (maybe even an explicit "enrich"), each with a signature which allows them to read some data from RocketChat and with manipulating accessors for the latter one or two.
IPostMessageSent could have something like "filter" and "execute".
With respect to the Webhook handler, I'd call it either "IWebhookHandler" or "...Provider" (such as it is common in other worlds).
Does that make sense to you?

I'd expect it to have methods like "validate", "modify" (maybe even an explicit "enrich"), each with a signature which allows them to read some data from RocketChat and with manipulating accessors for the latter one or two.

Can you expound on what you mean by this? As I don't follow 100%

With respect to the Webhook handler, I'd call it either "IWebhookHandler" or "...Provider" (such as it is common in other worlds).

Ah yes, those are way better choices than what I had in mind. I think the Provider is an excellant choice for the Webhook as implementing this interface means the Rocketlet will provide an endpoint for people call. :+1:

Future reference see: #2


Limited screen reader support for spinner component

Describe the bug
The spinner component aria-live regions aren't working in some screen readers, notably NVDA and JAWS on PC browsers. The problem seems to be the dynamic nature of the aria-live region, and the suggestion is to make it always present. However, I do not know how it will behave when used inside of components that create templates on the fly, so we need to validate that. Probably also applies to progress bar.
See for more https://github.com/vmware/clarity/issues/3565
How to reproduce
https://clarity.design/documentation/spinner
Steps to reproduce the behavior:

Try to read with PC and JAWS/NVDA

Expected behavior
Aria live region should be read.
Versions
App

Angular: [e.g. 6]
Node: [e.g. 8.10.0]
Clarity: 2+

Device:

Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional notes

dup of #3832


[storage] Renaming Aio and Null to Volume

This brings more consistency to the naming of backend
See opiproject/opi-api#304
Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

See https://github.com/opiproject/opi-api/issues/304

will pass CI after https://github.com/opiproject/opi-spdk-bridge/pull/559


Productivity Suite - styles and mobile improvements

In this PR I've applied fixes that should hopefully make the app better on iPhones
besides that I replaced the nav on small screens with a select-like navigation:

I hate to say it but there is a bit of movement on the mobile views in my local Chrome browser 😓 I suspect it is only me so I won't block this landing. But can you double check?

ah, sorry about that 😢
on mobile I can also see a small vertical shift of the fragments, I thought I did check that... sorry about that I'll fix it in a follow up PR (I'll try to make it as precise as possible for my setup and for medium font sizes and hopefully this will create a generally acceptable effect, does that sound ok?)


Faulty interface design of single web crawler running in multiple threads

I can specify with the number of crawlers the amount of concurrent threads to be run via the CrawlController. Every crawler thread uses the same CrawlConfig.
This is good for some settings but bad for some other settings. For example the resumableCrawling, maxDepthOfCrawling or maxPagesToFetch is globally useful for all threads, but proxy settings (proxyHost, proxyUsername, …) or userAgentString should be definable per each thread instance and not the same value for all concurrent threads, as i understand your settings interface so far.
In order to realize the desired setup, i have to define for the preferred amount of threads a separate CrawlController that can then use a separate CrawlConfig. However i am not sure, if i can use the same storage folder, resumable crawling and whats most important if the constrollers share their work-list, which i assume are not do.
This finally brings be to the point that the interface for multiple crawlers is designed wrong, not to say broken.
Some pull requests that try to workaround this design error: https://github.com/yasserg/crawler4j/pull/80 https://github.com/yasserg/crawler4j/pull/57
Probably the best solution to fix this, it to distinguish between globally settings CrawlConfig and per thread settings that inherit from the global settings (for default values) but can be overwritten. Furthermore, the  per thread settings have less options, limiting to proxy settings, user agent, delay ... In class hierarchy CrawlConfig would inherit from the basic per thread settings.

I see your point.
But, as this seems as a big refactor, what do you think about the following:
Maintain the same code logic as it is now but have an option to configure
multiple user-agents & proxy settings, so each thread can take a random
user agent and proxy and do its thing.
What do you say, will we thus gain the same results ?
On Sat, Jan 2, 2016 at 5:29 PM, Sebastian Klatte<EMAIL_ADDRESS>wrote:

I can specify with the number of crawlers the amount of concurrent threads
to be run via the CrawlController Every crawler thread uses the same
CrawlConfig
This is good for some settings but bad for some other settings For example
the resumableCrawling, maxDepthOfCrawling or maxPagesToFetch is globally
useful for all threads, but proxy settings (proxyHost, proxyUsername, …)
or userAgentString should be definable per each thread instance and not
the same value for all concurrent threads, as i understand your settings
interface so far
In order to realize the desired setup, i have to define for the preferred
amount of threads a separate CrawlController that can then use a
separate CrawlConfig However i am not sure, if i can use the same storage
folder, resumable crawling and whats most important if the constrollers
share their work-list, which i assume are not do
This finally brings be to the point that the interface for multiple
crawlers is designed wrong, not to say broken
Some pull requests that try to workaround this design error:
https://githubcom/yasserg/crawler4j/pull/80
https://githubcom/yasserg/crawler4j/pull/57
Probably the best solution to fix this, it to distinguish between globally
settings CrawlConfig and per thread settings that inherit from the
global settings but can be overwritten Furthermore, the per thread
settings have less options, limiting to proxy settings, user agent, delay
In class hierarchy CrawlConfig would inherit from the basic per thread
settings
—
Reply to this email directly or view it on GitHub
https://github.com/yasserg/crawler4j/issues/108.

The big part is to changing the PageFetcher to be initialized with variable parameters depending on the thread instance. Currently the HttpClient is one instance that is created (inside the PageFetcher) and will be used from every thread. (This is partly already done here: PageFetcher.java)
Once changing is done, i think it will be easier to create a class CrawlConfigBase that is a member of the WebCrawler, instead of a function from the PageFetcher, which asks for some setup for thread x (as far as i understand you).
However your setup would not break the CrawlController.start functions and you are completely correct either way involves multiple code changes.
The crawler is just not designed to work in some lets say stealth mode, when it comes to crawling on a single webpage.


board: arm64: Add suport for ROC-RK3568-PC

This is support for AArch64 development board.
The board uses 4-core Cortex-A55, which are based on the ARMv8.2 architecture.
In addition,we support smp support and
it can use 4-cores to run basic samples.

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary
获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: Carlo Caione @.>
发送时间: Tuesday, October 3, 2023 3:00:16 PM
收件人: zephyrproject-rtos/zephyr @.>
抄送: Jaxson Han @.>; Mention @.>
主题: Re: [zephyrproject-rtos/zephyr] board: arm64: Add suport for ROC-RK3568-PC (PR #63343)
@carlocaione commented on this pull request.

In arch/arm64/core/reset.Shttps://github.com/zephyrproject-rtos/zephyr/pull/63343#discussion_r1343595086:

+#ifdef CONFIG_SOC_RK3568

  ldr             x2, [x0, #BOOT_PARAM_MPID_OFFSET]

  cmp     x2, #-1

  bne     1f

  str             x1, [x0]

  b primary_core

+#else
that was introduced by @povergoinghttps://github.com/povergoing to fix a concurrency issue. But is there any errata about this? If ldaxr / stlxr are not working I'm afraid all the atomic ops are also broken?
―
Reply to this email directly, view it on GitHubhttps://github.com/zephyrproject-rtos/zephyr/pull/63343#discussion_r1343595086, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAUCW2JRNA4IWN5D6S4LSRTX5OZYBAVCNFSM6AAAAAA5NWBEHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJUGQ3TGOBXHE.
You are receiving this because you were mentioned.Message ID: @.***>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Would you mind trying to enable the cache before ldaxr/stlxr to see if the ldaxr/stlxr works for your SOC, if it works, there is no need to change to DTS?
I am considering:

Most multi-core systems have firmware with PSCI which means the core is booted one by one, but now Zephyr support booting from EL3, and all cores boot simultaneously, that's the very difference between Zephyr and other multi-core system.
Changing to DTS to indicate the primary core might cause a crash or at least some inconvenience for some downstream patches.

It is important to pay attention to the copyright statement.
Remove any content related to FVP.
Verify the accuracy of the timer frequency.

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Would you mind trying to enable the cache before ldaxr/stlxr to see if the ldaxr/stlxr works for your SOC, if it works, there is no need to change to DTS?
I am considering:

Most multi-core systems have firmware with PSCI which means the core is booted one by one, but now Zephyr support booting from EL3, and all cores boot simultaneously, that's the very difference between Zephyr and other multi-core system.
Changing to DTS to indicate the primary core might cause a crash or at least some inconvenience for some downstream patches.

The other things that We need to consider boot method of spin-table.

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Would you mind trying to enable the cache before ldaxr/stlxr to see if the ldaxr/stlxr works for your SOC, if it works, there is no need to change to DTS?
I am considering:

Most multi-core systems have firmware with PSCI which means the core is booted one by one, but now Zephyr support booting from EL3, and all cores boot simultaneously, that's the very difference between Zephyr and other multi-core system.
Changing to DTS to indicate the primary core might cause a crash or at least some inconvenience for some downstream patches.

I have try to enable the cache before ldaxr/stlxr, the ldaxr/stlxr works when boot the first core. But when I try to boot other cores, it crashed. I suspect that when other cores are awakened, they are also in a cache disable state, so ldaxr/stlxr do not works. Does this mean that I must enable caching for each cores in this part of the startup code? @povergoing  Just like below:

At the same time, I would like to ask if there is a real ARM64 hardware platform which support smp? I would like to see what is the difference between the supported boards and this board. @carlocaione

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Would you mind trying to enable the cache before ldaxr/stlxr to see if the ldaxr/stlxr works for your SOC, if it works, there is no need to change to DTS?
I am considering:

Most multi-core systems have firmware with PSCI which means the core is booted one by one, but now Zephyr support booting from EL3, and all cores boot simultaneously, that's the very difference between Zephyr and other multi-core system.
Changing to DTS to indicate the primary core might cause a crash or at least some inconvenience for some downstream patches.

I have try to enable the cache before ldaxr/stlxr, the ldaxr/stlxr works when boot the first core. But when I try to boot other cores, it crashed. I suspect that when other cores are awakened, they are also in a cache disable state, so ldaxr/stlxr do not works. Does this mean that I must enable caching for each cores in this part of the startup code? @povergoing Just like below:

Yes, I meant temporarily enabling cache for all cores, and disabling cache after the core passes the atomic block. BTW, the way you show in the screenshot, seems the MMU is enabled also? Did you try without touch anything else except for enabling the cache?

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Would you mind trying to enable the cache before ldaxr/stlxr to see if the ldaxr/stlxr works for your SOC, if it works, there is no need to change to DTS?
I am considering:

Most multi-core systems have firmware with PSCI which means the core is booted one by one, but now Zephyr support booting from EL3, and all cores boot simultaneously, that's the very difference between Zephyr and other multi-core system.
Changing to DTS to indicate the primary core might cause a crash or at least some inconvenience for some downstream patches.

I have try to enable the cache before ldaxr/stlxr, the ldaxr/stlxr works when boot the first core. But when I try to boot other cores, it crashed. I suspect that when other cores are awakened, they are also in a cache disable state, so ldaxr/stlxr do not works. Does this mean that I must enable caching for each cores in this part of the startup code? @povergoing Just like below:
At the same time, I would like to ask if there is a real ARM64 hardware platform which support smp? I would like to see what is the difference between the supported boards and this board. @carlocaione

I find that in some SoCs, atomic ops are not supported when mmu is disable, just like rpi_4b:

The other things that We need to consider boot method of spin-table.

IMHO, I don't think spin-table will solve the issue. spin-table is a protocol for bootloader and OS which is designed for an OS to pull up a core from the bootloader, just like PSCI booting a core from the firmware. But what we are facing now is dealing with the work in Zephyr, but that work should have be done in firmware or bootloader.

Might be a problem that ldaxr/stlxr are not working without MMU enabled. I am thinking about we use DTS to mark the primary core or for simplicity we make the cpuid 0 core as the primary

This should sound feasible, as I have found that in multi-core system, cpuid 0 is usually used as the main core for startup.

Would you mind trying to enable the cache before ldaxr/stlxr to see if the ldaxr/stlxr works for your SOC, if it works, there is no need to change to DTS?
I am considering:

Most multi-core systems have firmware with PSCI which means the core is booted one by one, but now Zephyr support booting from EL3, and all cores boot simultaneously, that's the very difference between Zephyr and other multi-core system.
Changing to DTS to indicate the primary core might cause a crash or at least some inconvenience for some downstream patches.

I have try to enable the cache before ldaxr/stlxr, the ldaxr/stlxr works when boot the first core. But when I try to boot other cores, it crashed. I suspect that when other cores are awakened, they are also in a cache disable state, so ldaxr/stlxr do not works. Does this mean that I must enable caching for each cores in this part of the startup code? @povergoing Just like below:

Yes, I meant temporarily enabling cache for all cores, and disabling cache after the core passes the atomic block. BTW, the way you show in the screenshot, seems the MMU is enabled also? Did you try without touch anything else except for enabling the cache?

In fact, it is not convenient to enable cache at this location. In this part of the code, operations on the lower 4 bits of the register (w0 or x0) will trigger an Alignment fault.

The added code is  mov w0, (SCTLR_I_BIT | SCTLR_C_BIT).

I suggest having a look at this to solve the issue mentioned above:
https://www.kernel.org/doc/html/next/arch/arm/vlocks.html
This requires no atomic instructions, no cache, etc.

I suggest having a look at this to solve the issue mentioned above:
https://www.kernel.org/doc/html/next/arch/arm/vlocks.html
This requires no atomic instructions, no cache, etc.

Thanks, I'll take a look.

Thanks, I'll take a look.

Yes, I will remove all the fvp related code.

@cocoeoli @lenghonglin I've created https://github.com/zephyrproject-rtos/zephyr/pull/63905 using voting lock as @npitre suggested, would you like to have a try to see if it fixes your issue?

@cocoeoli @lenghonglin I've created #63905 using voting lock as @npitre suggested, would you like to have a try to see if it fixes your issue?

Thanks, I'll take a look.


blueprints go missing when config.cache_classes = false

I noticed that in my dev environment for a rails 3.1.0 project when
config.cache_classes = false the blueprint disappears after the first
request.
When using XapianDb.search the 2nd request gives the error:
Blueprint for class Object is not defined
When using Object.search the 2nd request gives the error:
undefined method `search' for #Class:0x0000000797f098
Everything works fine with config.cache_classes = true (which of
course is the default for production env).
In the console this same behavior can be observer after a "reload!" command.

I tried to reproduce the error using the rails example app in examples/basic_rails but everything seems to work fine. Where do you configure your blueprints?

Ok I see that you recommend placing it in config/xapian_blueprints.rb.  I placed it in an initializer.  Perhaps it should just be noted that blueprints should not be in an initializer.

added a note in the README


vbump STS

these are the changes I am bringing in with this PR.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 41.542%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
26955

Relevant Lines:
58876

💛  - Coveralls


Publish javy-cli to crates.io

I just wanted to follow up on an outstanding request to publish javy-cli to crates as mentioned in this thread. I'm not sure my requirements are exactly the same as the original requester but my use case is having a rust service that executes compilation at runtime and stores the result somewhere to execute later. I believe the code in javy-cli can accomplish most of what I want and I would rather consume it as a library from crates rather then fork it.
Regarding the original thread it was mentioned that we should start a ticket up to discuss different approaches so I'm going ahead with that here. I'm open to helping out with the contribution but I'm interested in hearing what approaches  the maintainers think are best.

my use case is having a rust service that executes compilation at runtime and stores the result somewhere to execute later.

If you're willing to have your service spawn a process (e.g., through https://doc.rust-lang.org/std/process/struct.Command.html) then publishing javy-cli to crates.io such that it can be installed, this approach will probably work. I don't think you'd be able to include javy-cli as a dependency, because it's a binary, not a library.
Generally (and assuming I'm understanding your use-case correctly) I think we should be able to do a bit better, such that instead of having to spawn a process from your application, you should be able to add a a library dependency that allows building a Wasm module from a JavaScript source. This shouldn't be too hard to accomplish if we start by extracting the code generation pieces used by the cli and publish those as a separate crate (e.g., javy-codegen) to crates.io, then I'm imagining that you'd be able to include that crate in your application like:
[dependencies]
javy-codegen = 1

Note that even though the refactoring to extract this code might be trivial, some open questions still stand, like for example:

Handling the dependency between the javy-codegen and the Wasm module produced by javy and required by the code generation process.
Related to the previous point, perhaps this use-case could leverage the most recent work around plugins, in such a way that instead of hardcoding a dependency between javy-codegen and a Wasm module, the Wasm module could be be injected as a dependency, which would probably make all this process easier and the API more flexible.

I think some exploration is needed around those areas to have a better handle of the pros/cons.


Migrate (delete) flashclicktorun from Demos (fixes #368)

What this PR does
Our PMs opted to host this demo on our MicrosoftEdge-Documentation repo instead of TestDrive gallery: https://microsoftedge.github.io/MicrosoftEdge-Documentation/flashclicktorun/
(Thanks just the same for your help on cleaning up the code and merging it to Demos! Its not a wasted effort, as the code will live on and now I know the PR process for Demos :)
This PR is just cleanup from the Demos repo.
Requirements

[ ] My PR follows all applicable accessibility requirements (See .github/ACCESSIBILITY_REQS.md).

@erikadoyle,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

for your help on cleaning up the code

@erikadoyle Can the code from the MicrosoftEdge-Documentation repository be updated to contain the cleaned up code? Thanks!

Can the code from the MicrosoftEdge-Documentation repository be updated to contain the cleaned up code?

Done in https://github.com/MicrosoftEdge/MicrosoftEdge-Documentation/commit/74a007387cee4aebd8139473363740e576805c0b.

Thanks for catching that!


Fix storybook

Storybook is mad for some reason. Fix that.

ITS WORKING!!!!!! whatever we fixed recently in the move to company scaffolding and the yarn workspaces this works now!


NIFI-6301 - Added a SafeXMLConfiguration which disables XML DTDs whic…

…h may call external entities.
NIFI-6301 - Fixed unit test. Added comments.
NIFI-6301 - Removed unused rule from test.
NIFI-6301 - Changed read() methods to use a boolean instead. Updated comments.
NIFI-6301 - Fixing checkstyle errors.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

I've added an XXE validator to the CommonsConfigurationLookupService to do a simple check if the file contains an !ENTITY declaration. This in combination with the SafeXMLConfiguration will restrict XXE usage in XML configuration files in NiFi.

I built the PR successfully and ran a local instance.

Using local_xxe_file.xml the controller service validation correctly returned "Invalid" and explained the reason with the XXE error message
Using whitespace_xxe_file.xml the controller service validation correctly returned "Invalid" and explained the reason with the XXE error message
Using multiline_xxe_file.xml the controller service validated and shows "Disabled". When the "Enable" action is taken, the controller service stays in "Enabling" mode. The dialog processes as it would in a successful operation. Disabling the controller service takes ~15-30 seconds. This is not ideal for user experience

I'm going to see if I can enforce the same expected behavior from the regular and whitespace XXE file on the multiline XXE file. I am also going to suppress the stacktrace unless DEBUG is enabled, as the stacktrace doesn't add valuable information to the provided error message.

I was able to modify some code to allow multiline XXE attacks to be caught during validation. I updated the unit tests to accurately reflect this.
I discovered another issue -- the XXEValidator seems to continue running on a looped thread even when the XMLFileLookupService is Invalid, and even after it's been deleted (see screenshot). I'll continue investigating.

Continuing to investigate. Not sure which timer/thread is triggering the validation, but you can see from the log it continues with cached data even after the controller service is deleted.
2019-06-10 19:47:23,833 INFO [main] org.apache.nifi.NiFi Controller initialization took<PHONE_NUMBER>8 nanoseconds (16 seconds).
2019-06-10 19:47:57,672 INFO [NiFi Web Server-22] o.a.nifi.controller.ExtensionBuilder Created Controller Service of type org.apache.nifi.lookup.XMLFileLookupService with identifier 446f5dd4-016b-1000-32cc-80a04680722c
2019-06-10 19:47:57,985 INFO [Flow Service Tasks Thread-2] o.a.nifi.controller.StandardFlowService Saved flow controller org.apache.nifi.controller.FlowController@53e44c8 // Another save pending = false
2019-06-10 19:48:18,618 INFO [Validate Components Thread-4] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:18,618 WARN [Validate Components Thread-4] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:18,630 INFO [Flow Service Tasks Thread-1] o.a.nifi.controller.StandardFlowService Saved flow controller org.apache.nifi.controller.FlowController@53e44c8 // Another save pending = false
2019-06-10 19:48:21,426 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:21,427 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:26,432 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:26,432 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:31,435 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:31,435 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:36,439 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:36,439 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:41,444 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:41,444 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:46,450 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:46,450 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:51,454 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:51,454 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:48:52,528 INFO [NiFi Web Server-19] o.a.n.c.flow.StandardFlowManager StandardControllerServiceNode{controllerServiceHolder=org.apache.nifi:nifi-lookup-services-nar:1.10.0-SNAPSHOT, versionedComponentId=null, comment='', processGroup=null, active=false} removed from Flow Controller
2019-06-10 19:48:52,843 INFO [Flow Service Tasks Thread-2] o.a.nifi.controller.StandardFlowService Saved flow controller org.apache.nifi.controller.FlowController@53e44c8 // Another save pending = false
2019-06-10 19:48:56,460 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:48:56,460 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml
2019-06-10 19:49:01,463 INFO [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Validating /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml for XXE attack
2019-06-10 19:49:01,464 WARN [Validate Components Thread-2] o.apache.nifi.security.xml.XXEValidator Detected XXE attack in /Users/alopresto/Workspace/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml

Leaving my additional commits here for now: alopresto/nifi/pr3507

Was testing and had no problem verifying the new behavior in the XMLFileLookupService as a Reporting Task Controller Service:

But when I tried to create the controller service on the Process Group level, the UI would hang.
Investigated by @mcgilman and this looks to be a result of https://issues.apache.org/jira/browse/NIFI-6341 which was fixed recently.

@alopresto I've verified the issue you had with the validator still running even after the controller service is deleted. It occurs for 'controller level' controller services, and not for process-group scoped controller services. It appears to occur for all validators, as I have tested it with another validator other than the XXE one I have added. I have opened a new Jira to track this issue: https://issues.apache.org/jira/browse/NIFI-6371
Good find.

Ran contrib-check and all tests pass. +1, merging.


Improve Hubble decoding performance

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

See each commit message for the detailed description, but these patches reduce the baseline CPU usage of Cilium Agents by 3-4%, by removing allocations. The decode functions themselves improved in runtime by 92-95%.
Improve Hubble decoding performance

Verified sign-off manually and removed the label.

Thanks for the fixes on top, and sorry for not having gotten back to it yet! ❤

Thanks for the fixes on top, and sorry for not having gotten back to it yet! heart

No problem @brancz, I'm adding a couple of tests and then the PR should be good to go once it passes CI.

Reworded the PR title and release note block into something more appropriate for release notes, leaving the details about the CPU cycle improvements in the commit messages.

/test

/test

/test

/test

/datapath

/test


Will you have plan to onboard this extension for national clouds?

Will you have plan to onboard this extension for national clouds? We tried it out in Mooncake but it just does not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a61a7e9a-44bf-7bdc-f810-87e2fd6792e1
Version Independent ID: 71d11105-b83e-952e-d107-1ff9a7c8d107
Content: Provide Azure MFA capabilities using NPS - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-mfa-nps-extension.md
Service: active-directory
Sub-service: authentication
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@sscchh2001 Thank you for reaching out. We will investigate and update the thread further.

@sscchh2001 We do not have an update on the same for the Azure China Region. It would be announced when we have an ETA.


Add Timespan Wrapper utility

Used in configuration files, to make it easier for developers to add options for timespans on the form [Interval][Timeunit]

Checkmarx scan completed with the following findings

Lines
Severity
Category
File
Link

68
Medium
Heap_Inspection
Cognite.Metrics/MetricsConfig.cs
Checkmarx


Not native resolution

Really nice work!
I found that if I am not using the native resolution of my camera (ov_5647) the DNG becomes stripped with an alternating darker pixel. I prefer to use binned (2x2) images for better noise reduction.
I try to understand if the dng has always the native resolution and if it is possible to change that.
It does not but what may cause that?

You can upload your images then I might be able to see the exact issue.
As far as I know, when you capture JPEG + RAW attached it is always using full sensor regardless of the sensor mode you have selected.

If you extract the zip file you can find two images, one 2x2 binned and one full resolution with their DNG.
Downloads.zip
What you say it make sense, however when I open the DNG is the binned resolution so I am not sure what is extracting. Plus you will see that the image is dotted and not close to the original. I am using an OV_5647, I do not know if other cameras do the same.

I might found a solution but I do not have time to explore it now.
If you have, can you test it with your camera?
As you correct said, RAW files are in full sensor always. However, when we make a binned file, the exif register the binned size and not the original. By rewriting the correct one, I was able to produce a good DNG.
I will suggest that you embed the native resolutions of those 3 cameras in the settings.
If you cannot do/test it, I will do it on Saturday.
:)


Added evothings adapter init function

@mikaelkindborg
I've seen race conditions in the past when the evothings.ble object isn't added to the dom before trying to use it.
This PR adds an init function for the startScan() and stopScan() functions in the adapter to ensure evothings is ready to be used.
Is this a valid concern or something covered elsewhere?

@thegecko Very neat! Thanks for spotting this! :)
"Well behaved" Cordova code should wait for deviceready, but it is very nice to have init as this abstracts away this.


Extract out all the configuration options into .xcconfig files

To avoid various merge conflicts due to configuration option changes
The configuration options should be pulled into manageable .xcconfig files
Include swiftlint.sh input parameters for swiftlint binary location and configuration file in .xcconfig file and remove from the script.

Not much benefit to the project at this stage.


Error loading data - exit code 139

Hi - I am getting the following error when running ./parse.py enwiki-20170401-pages-articles.xml.
....
Processing page 367 of 17434651 (0.002105003421060737%) with title 'Aspect ratio'
Processing page 368 of 17434651 (0.0021107391252053165%) with title 'Auto racing'
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)
Any suggestions?

Wow, SIGSEGV is very surprising :) What version of Python and libraries are you using? Could you run python interpreter under gdb and print a stacktrace (bt) right after segmentation fault happen?

Running 3.6.1 on OS X 10.11.6 - postgres 9.6.2
appdirs==1.4.3
beautifulsoup4==4.5.3
lxml==3.7.3
packaging==16.8
py-postgresql==1.2.1
pyparsing==2.2.0
six==1.10.0
I tried upgrading beautifulsoup4 to 4.6.0 and it still failed but in a different repeatable spot.
...
Processing page 566 of 17434651 (0.0032464085458320906%) with title 'Apache webserver'
Processing page 567 of 17434651 (0.0032521442499766702%) with title 'Apatosaurus'
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)
I will try to provide a stacktrace shortly. Thanks you!

I am unable to get gdb running on my machine and PyCharm debugger is exiting without a stacktrace. It appears as though how far it gets is related to the speed of loading - while trying to debug (and loading more slowly) it gets further along before the SIGSEGV occurs. With just a vanilla run (loading fast) it barks earlier.

This is very unfortunate, but I'm afraid there is not much I can do since I don't even have OS X. I suggest to report this issue to beautifulsoup developers. It looks like the best way to do it is via Google Group https://groups.google.com/forum/?fromgroups#!forum/beautifulsoup
In case you'll find a way to fix it somehow in Python code please don't hesitate to send a patch.

I was able to get gdb running - here's the stacktrace. Hope it helps.
Processing page 366 of 17434651 (0.0020992677169161572%) with title 'Anatoly Karpov'
Processing page 367 of 17434651 (0.002105003421060737%) with title 'Aspect ratio'
Processing page 368 of 17434651 (0.0021107391252053165%) with title 'Auto racing'
Program received signal SIGSEGV, Segmentation fault.
0x00007fff959c8421 in xmlSHRINK () from /usr/lib/libxml2.2.dylib
(gdb) bt
#0  0x00007fff959c8421 in xmlSHRINK () from /usr/lib/libxml2.2.dylib
#1  0x00007fff959d4811 in xmlParseTryOrFinish () from /usr/lib/libxml2.2.dylib
#2  0x00007fff959d45cd in xmlParseChunk () from /usr/lib/libxml2.2.dylib
#3  0x000000010306cc18 in __pyx_f_4lxml_5etree_11_FeedParser_close ()
from /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/lxml/etree.cpython-36m-darwin.so
#4  0x00000001030f6b3e in __pyx_pw_4lxml_5etree_11_FeedParser_3close ()
from /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/lxml/etree.cpython-36m-darwin.so
#5  0x0000000103155e8f in __Pyx_CyFunction_CallAsMethod ()
from /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/lxml/etree.cpython-36m-darwin.so
#6  0x000000010000e8d4 in PyNumber_InPlacePower ()
from /Library/Frameworks/Python.framework/Versions/3.6/Python
#7  0x0000000000000000 in ?? ()

OK, this is most definitely a bug in lxml module. I would recommend to report it to the lxml developers: http://lxml.de/#bug-tracker
It would be a good idea to include variables values on every stack frame.  To show variables and arguments in current frame:
(gdb) info frame
(gdb) info variables
To change the frame:
(gdb) f 1
(gdb) f 2
It's also worth considering to upload a coredump on sume file hosting (e.g. Dropbox). Unfortunately I'm not an expert in OS X and I don't know how coredump are created on this system. You can try to create a coredump using gdb:
(gdb) generate-core-file


Choosing an existing public route 53 zone and private VPC results in tectonic (terraform) creating a new, private r53 zone

Issue Report Template
Tectonic Version
1.6.2-tectonic.1
Environment
What hardware/cloud provider/hypervisor is being used with Tectonic?
AWS
Expected Behavior
Selecting an existing Route 53 zone to use should just create new records inside that zone, as previous installers have done.
Actual Behavior
When creating a private VPC cluster and selecting an existing public route 53 zone, tectonic's installer creates a new, private zone with the same name as the existing public zone, but different NS, SOA, etc records.
Reproduction Steps

Create a public route 53 zone
Create a private VPC
In the tectonic installer, select the existing public route 53 zone, and the existing private VPC
Watch as tectonic (terraform) creates a new, private route 53 zone with the same name as the existing public.

Other Information
The 'expected behavior' is what happened in previous installer versions.

Thanks for reporting this @brmakana. Also interested in your thoughts on this @jkochfrontline.
Some background:
We're using this private zone to keep some traffic internal to the cluster for things like our ODIC/auth traffic between the API server and dex. This also reduces any impact on your cluster if public DNS is down or having other issues.
There are a few different options we are considering to give you a bit more control over this functionality. Would you mind rating the following options as ideal/satisfactory/blocker?

Flag for turning off private zone management while maintaining the public zone usage for public VPCs. This introduces some maintenance and testing complexity. Would still allow for using both zones if desired/required.
Bring your own zone by simply specifying the ID. This would give you control over using an existing zone or creating a new one.
Stop mixing public and private zones; use public for public VPCs and private for private.
Is there something I missed?

Overall, would y'all mind expanding on why you desire to use a public zone with your private VPCs?

Related PR that we're using for brainstorming (but we're not committed yet) https://github.com/coreos/tectonic-installer/pull/664

Related issue that should be closed out before the next release: https://github.com/coreos/tectonic-installer/issues/1096


Limit of requests

Hi there! Is there any limit of requests per second? Cause we have an issue, that our IP is blocked and server returns 503 error. We tried 5-10 requests per second. Each request is like this - https://id.ripple.com/v1/user/{ripple-address}. Thank you!

Are you sure this is a rippled problem?

seems like yes, cause if we're trying to use the same request at the same time, but with proxy - it works.

rippled doesn't serve responses to URLs with that form though

thank you.

The URL provided belongs to the Identity API, which is not part of rippled


The system did not recognize any cars.

I'm sorry, I followed your steps to install all the packages, but when I run the code, the screen only shows 26 empty slots. It did not capture any cars.
I checked your related website, but I might not be very familiar with the code, so I still don't know how to solve this problem. I would like to ask if you have encountered any similar issues or have any experience with this.
Thank you very much for your dedication. Your detailed description of the program shows your passion and helps others feel it too.

Hi there!
To help you better, please attach a screenshot for me to review, and also provide the script you are currently running.
Based on your description, it seems like the algorithm is working as expected since you are able to see empty slots. However, there might be issues with the model’s ability to recognize the cars.
To assist you further, please provide me with the following details:

A screenshot of the current output.
The script you are using.
Any error messages or logs you are encountering.

Looking forward to your response!

Hi danielbob32!

I am running ParkingSpace.py file

Here is the log of my execution. It seems there are no error messages. I have also attached the package versions I used.
Thank you very much for your help.

Hi there,
Thank you for your patience. I will try to respond as soon as possible.
I am experiencing the same results as you. The model seems to be working as expected, but I've noticed a potential issue with the version being used. I was previously using ultralytics==8.1.34, while the current version is 8.2.66. This difference might be causing issues with the processing of each frame.
It appears there might be a problem with the binary and the probability map fusion, which could explain why no cars are being detected even though the model indicates otherwise.
If you look at the main repo page, you'll notice that the detected cars are shown in an orange mask. However, with the new model version, the mask appears as translucent white.
I will work on fixing this issue and keep you updated.
Thank you very much for your patience!

 I'm glad to hear everything is working fine now. If you have any more questions or need further assistance, feel free to ask.
Best regards.


Updated CheckboxWithLabel test to use mocha-jsdom.

I was unclear on what the Blanket parts are doing, so I only updated the CheckboxWithLabel test.
npm test yields success.

The blanket script is there for code coverage. If a module isn't included by a test, it doesn't count towards code coverage, so untested modules wouldn't count against your project. The blanket script requires all your source modules to count them. The thought is that some modules might not be require-able unless there's a window and document object, so it needs jsdom.
Your change looks great—I'll merge on green.

Coverage decreased (-25.0%) to 58.33% when pulling d0d900bc194ecb878e7c180c50c4758b64d4fdaf on benmosher:mocha-jsdom into 4651361cd58932c395fee96d25cfd247fb261599 on danvk:master.

Interesting. Coveralls is showing that coverage drops in CheckBoxWithLabel.js as a result of this change. I can verify that that's the case locally by adding a console.log in CheckBoxWithLabel.onChange.
When I run npm test, I see the message. When I run
./node_modules/.bin/mocha --require blanket --reporter mocha-lcov-reporter tests/*test.js

I don't, whereas I did before the mocha-jsdom change.

Looks like the --require blanket flag breaks the tests; it had another reference to testdom that I did not really understand, so I left it alone before.
Just pushed another commit that removes the reference + deletes the testdom module.

Coverage remained the same at 83.33% when pulling 0d2052b4003a092a2f72befd8342798a97fe5ce1 on benmosher:mocha-jsdom into 4651361cd58932c395fee96d25cfd247fb261599 on danvk:master.

Cool, thanks for debugging!


"and" is translated incorrectly

The call
print(ipa.convert("and"))
returns
ənd
which is incorrect. It should return
ænd

I'm using the version of eng_to_ipa that's published here on github, which I believe is the latest version.


CA-753 Added participant order function with test

Still need to test on the app and add sort by join time

We should test it before deployment


Container memory leak

Hi,
based on the @ryanto's video https://embermap.com/topics/memory-leaks/do-i-have-a-memory-leak (thanks), I've found that this add-on is leaking container in tests in our application.
I've created this branch https://github.com/bobisjan/ember-memory-leaks/tree/ember-angle-bracket-invocation-polyfill, which reproduces the issue.
new app without add-on

new app with add-on

I'll try to deep dive into this, but I'm not familiar with these internals 🙈.
Thanks for this add-on 🤩.

It looks that the problem is with assignment of _splattributes onto global BUILTIN_MODIFIERS.


Framework for Bucket CRUD operation with AWS cloud

This PR is to support bucket creation in AWS cloud from soda. Previously a soda user had to create bucket in various cloud manually. But now they can create bucket from soda clients.
What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

LGTM

raise a issue to track one problem: #1206

LGTM


Investigate exception in testhelpers.dns_helpers.DNSResolverDiscovery

There is a particular DNS test helper that is used to discover the IP of the resolver of the user that when run on test machine is getting probed by somebody doing DNS scans (/me thinks) and is triggering these exceptions:
Unhandled Error
Traceback (most recent call last):
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/python/log.py", line 101, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/python/log.py", line 84, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/internet/posixbase.py", line 597, in _doReadOrWrite
    why = selectable.doRead()
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/internet/tcp.py", line 209, in doRead
    return self._dataReceived(data)
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/internet/tcp.py", line 215, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/names/dns.py", line 2853, in dataReceived
    self.controller.messageReceived(m, self)
  File "/root/.virtualenvs/oonib/local/lib/python2.7/site-packages/twisted/names/server.py", line 558, in messageReceived
    self.handleQuery(message, proto, address)
  File "/root/ooni-backend/oonib/testhelpers/dns_helpers.py", line 47, in handleQuery
    payload=dns.Record_A(bytes(address[0]), 0))
exceptions.TypeError: 'NoneType' object has no attribute '__getitem__'

Should investigate what this is about.

Legacy OONI Probe code, we can close


my-first-react-jss-app doesn't work with url ip:port (Cannot read property 'sitecore' of null)

Description
You cannot run my-first-react-jss-app (react template) with url ip:port only with localhost.
For example if I run app on <IP_ADDRESS>, I should be able to open application.

But I will get: Cannot read property 'sitecore' of null

Expected behavior
It should open app without errors or it should say in documentation that it can be run only on localhost or provide some workaround solution.
Steps To Reproduce
Just follow documentation: https://jss.sitecore.com/docs/getting-started/quick-start

npm install -g @sitecore-jss/sitecore-jss-cli
jss create my-first-jss-app react
cd my-first-jss-app
jss start

My uderstanding and suggestion
At the moment localhost is hardcoded in src/setupProxy and in scripts/bootstrap.
It leads to CORS error because url has ip:port but request go to localhost.
My solution was

change localhost to ip in both files,
pass --disconnected arg to  src/setupProxy
change implementation of isDisconnected

const isDisconnected = /localhost/i.test(config.sitecoreApiHost);
// to
const isDisconnected = process.argv.some((arg) => arg === '--disconnected');

but drawback is that localhost url will not work.
Your Environment

Sitecore Version: -
JSS Version: 12.0.0
Browser Name and version: Chrome 76.0.3809.100
Operating System and version (desktop or mobile): Ubuntu 18.04 and Windows 10

Any quick fixes for this? I am also having the same problem.

@SteppeEagle Fixed in #403


Add loading indicator for the image compression

Would be helpful for user to know the process
Something like Gimini  does

We already have that on the ask button, how is this different?

Just checked that one, its a prop isLoading of Button component. It depends on how to implement this on the image placeholder,  maybe spinner also good to choose.


Cloony vs Comlink

How does GoogleChromeLabs/Cloony compare to GoogleChromeLabs/comlink? In what situations should Comlink be used over Cloony?
By the looks of it, Cloony is a more high level and easy-to-use option, while comlink provides more low level control and configurability...

You are pretty much spot on. Here’s an excerpt from Comlink’s README:

Note: Comlink’s goal is to be a building-block for higher-level abstraction libraries.

Comlink can be used by itself, but that’s probably only interesting for framework authors and very complex apps. Clooney is a off-the-shelf solution where you don’t have to worry about the technical details of workers.

What's nice about Comlink by itself, that I don't see in Clooney examples, is that with Comlink we can define a class inside the worker file, therefore we can use the worker file's scope outside of the class to store variables, etc, which is similar to writing regular ES modules. In contrast, with Clooney we loose ability to have outer scope.
It'd be nice to use files like ES modules, including their scopes, as with Comlink, but with the added conveniences of Clooney.

Until we get modules in workers, that is not gonna be possible, sadly.
(Maybe you can kinda hack it with Babel or Rollup, but I haven’t looked into that)


IObservableVector in Derived class Size() is always 0

Version
Latest available with vs 2022
Summary
I’m either doing something wrong(certainly possible) or there is a bug in the IObservableVector. I wrote a ViewModelBase class that handles property changed events as well as some other common properties one of which is an IObservableVector. The vector is used to bind to a Xaml navigation view for the menu items source. At startup I fill the collection and everything works as expected. I have a click handler in the application that is handled in a derived ViewModel that tries to loop over the collection to find a particular item. The  problem is the property is a valid object but it seems to be empty. Size is reported as 0 and when I try to get an item I know is there there is an exception. I’ve tried making the viewmodelbase class both a runtime class and a regular old c++ struct. Same behavior in both cases. I’ve tried casting the derived to a base as well as many other things. Am I missing something? If this is not the right repo, happy to open an issue in the right place.
Reproducible example
I can link a GitHub repo is that’s helpful.

Expected behavior
No response
Actual behavior
No response
Additional comments
No response

Actually, nvm. Trying to put together a minimal repro example, I think I see what Im doing. They are not the same object. So that makes sense. doh :|


chore: show expr errors for #13759

Logs error details for expr. ie
failed to compile:  unexpected token Operator(".") (1:28)
| sprig.trim(" abc ") | sprig.upper()
| ...........................^

co-authored by @boiledfroginthewell in https://github.com/argoproj/argo-workflows/pull/13774

co-authored by @boiledfroginthewell in #13774

Please add them as co-author in the commit itself as I mentioned in https://github.com/argoproj/argo-workflows/pull/13745#issuecomment-2408415438.
In this case, the PR was only closed a few hours ago, so I would ask the original author to re-open rather. They also gave a rationale for closing in https://github.com/argoproj/argo-workflows/issues/13759#issuecomment-2419549947


Bowling: New descriptions from Canonical

re: exercism/problem-specifications#832

Thanks for all these :heart:


[Demangle-to-type] Properly match extensions of conditionally-copyable types

We weren't dealing with the case where an extension in a different module from the type uses an extension mangling with no generic signature.
Fixes rdar://125015930.

@swift-ci please smoke test

@swift-ci please test source compatibility

I've confirmed that this PR addresses all of the type reconstruction errors in the source compatibility suite.

I lied! swift-futures seems to have one more type reconstruction failure. I'll follow up with another PR to address it


Jittery video received by NDI Video Monitor

Problem
Jittery video received by NDI Video Monitor: https://imgur.com/a/XZlADbM
Possible Causes/Solutions

Variable frame rate recording: Add additional frame buffers
Mismatch frame rate between iPhone frame rate and NDI frame rate: Add additional frame buffers, add adapter to sync frames between iPhone and NDI

Syncing NDI framerate to 30fps and iPhone's camera capture to 30fps also fixed the problem. Need a more robust implementation so iPhone camera can change frame rate and still set NDI framerate to be 30fps. https://github.com/rampadc/NDISenderExample/commit/a49ef0233f62885677750809a0ee48aa5b599242