[Testing] [feature request] provide selectable links for Heath status

feature request:  better to provide selectable links for 3 status: Passing, Warning, Critical

This has been already object of discussion with the UX/UI designers, and eventually we went with the current design.
I'll keep the issue open for re-evaluation, but I don't think we'll reiterate on this detail any time soon.


[Bug] [Doc] Image can not display properly

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Due to the migration of the documents directly from website, some of the file paths were incorrect, thus preventing the images from being displayed properly.
What you expected to happen
Modify the path so as to ensure that the images can be displayed properly.
How to reproduce
You can see the problem at this link. The situation is similar to the other documents.
Anything else
No response
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Could you give some examples of the bad path image?

Could you give some examples of the bad path image?

Like this, the picture is broken.

oh, I got it, you view it in the github itself do you? Although we migrate docs from dolphinscheduler-website to dolphinscheduler. we still keep the old link of the image on dolphinscheduler-website. It means that we could only view the img in https://dolphinscheduler.apache.org/ but failed in github, for now. Maybe we should find some way to fix it in the further, bu for now is do not matter because https://dolphinscheduler.apache.org/ looking good

We could make our image work in both GitHub and dolphinscheduler-website too. All we have to do is change img related path in dolphinschedule repo,  and add a convertor in https://github.com/apache/dolphinscheduler-website/blob/master/scripts/prepare_docs.sh to convert the image path in dolphinscheduler-website repository

I found that using relative paths in documents such as ... /... /... /... /img/tasks/demo/. Instead of absolute paths, e.g. /img/tasks/demo. The image will be displayed normally. So do we need to change the path to the image?
@zhongjiajie

It could, but it will break the link on our website https://dolphinscheduler.apache.org/. So we also need to add some script in our website to avoid it being broken, and already have one in https://github.com/apache/dolphinscheduler-website/pull/789 by @huangchenguang123 . But it is related PR #10127 only correct conditions task type

And I will find some easy way to batch operator them

after apache/dolphinscheduler-website#789 merged, we could change all our img path from /img to related path

Do you mean we can use ... /... /... /... /img/tasks/demo/ to replace /img/tasks/demo at now ?

after apache/dolphinscheduler-website#789 merged, we could change all our img path from /img to related path

Do you mean we can use ... /... /... /... /img/tasks/demo/ to replace /img/tasks/demo at now ?

Yeah, after apache/dolphinscheduler-website#789 we can do that

Ok, I will do this task.


[TfW Televic] Eryl Jones: Saying "a (station name)" in "Croeso i" announcements.

Expected Behaviour
The Welsh announcements should play something like this:
"Croeso i: Caer. Diolch am deithio gyda Trafinidaeth Cymru."
https://github.com/davwheat/rail-announcements/assets/88827488/2e4fcbd2-a999-453c-aeec-ab38e1b7f22c
Actual Behaviour
The Welsh announcements should played:
"Croeso i: a Chaer. Diolch am deithio gyda Trafinidaeth Cymru."
As far as I am aware of, all stations except those start with A (e.g. Abergele & Pensarn) are affected. (I don't know if they are also affected, since I am not familiar with Welsh)
https://github.com/davwheat/rail-announcements/assets/88827488/4b82c04e-0727-45e5-a8cb-3ad65daa2dcb
Reproduction Steps

Select Transport for Wales Televic from the menu
Choose "stop at station"
Choose any station that starts with B or C or so on (e.g. Chester)
Play the announcement

Yeah, some of the audio files got mixed up when I was renaming them I believe. Not sure exactly which ones but I'll have to take a look at some point.

I think this should be fixed with this change. I've tried to go through every Welsh station and swap the files where the wrong version was used, but I might have missed some. Do let me know if you spot any more errors.


terminate running task is not work

task is still running, can't be terminated...

@cissusnar,
The main maintainer is unavailable.
There is a fork: https://github.com/KalitaAlexey/vscode-rust
You can open an issue in the fork.
Anyway currently this issue's description is almost empty.
Describe:

What do you do
What do you expect
What do you get

@KalitaAlexey The maintainer had activities on GitHub two weeks ago. Maybe he's simply too busy and you could ask @saviorisdead to add you to the maintainer list.

@Frederick888,
I have written him several messages.
He didn't respond.
I wouldn't start a fork if he responds.

https://github.com/saviorisdead/RustyCode/issues/172#issuecomment-251605361
I 'member LOL... Thanks for your fork, @KalitaAlexey . Hope he could be back soon...


CMakeLists.txt: configure and install the .pc file

The .pc file should be configured and installed from the CMakeLists.txt; currently only autotools is configuring it.

Nasty hack until fixed:
cat > /usr/local/lib/pkgconfig/yaml-0.1.pc  <<-__EOF__
prefix=/usr/local
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

Name: LibYAML
Description: Library to parse and emit YAML
Version: 0.1.7
Cflags: -I${includedir}
Libs: -L${libdir} -lyaml
__EOF__

Ah, I can handle this in my cmake overhaul pr. I'm sure I saw this problem, unsure why I didn't handle it.


Sheen doesn't work as expected when using Specular

Sheen doesn't work as expected on materials that use Specular setup:

Color doesn't work as expected - white blows out everything, and all other colors produce the same result.
Glossiness doesn't change anything - you can only get full glossiness, or use the invert checkbox to get full roughness.

Using Metalness instead of Specular solves these issues. However, since materials use Specular by default, using sheen is very confusing, especially since this limitation isn't documented anywhere (as far as I know). I only figured this out when looking at the glTF spec, which I presume was used as reference.
Is it possible to implement Sheen for Specular as well? If not, can this limitation be communicated more clearly, either in the Help docs, API, or directly in the Playcanvas editor?

Hello @animech-sijo. You're right, we have only implemented the Sheen to work with the metalness PBR shaders. Perhaps we should just disable sheen if that workflow isn't used.
Sheen is a fresnel function primarily, so it would make sense it would look incorrect when not used with similar physics in mind. Thanks for bringing this to our attention!


Decimal('NaN') is unsupported in Java unpickling

Looks like decimal('NaN') is unsupported in net.razorvine.pickle:
Python pickle
# float('NaN') can be picled and loaded
>>> pickled = cloudpickle.dumps(float('NaN'))
>>> pickle.loads(pickled)
nan

# Decimal('NaN') can be pickled and loaded
>>> pickled = cloudpickle.dumps(decimal.Decimal('NaN'))
b'\x80\x05\x95!\x00\x00\x00\x00\x00\x00\x00\x8c\x07decimal\x94\x8c\x07Decimal\x94\x93\x94\x8c\x03NaN\x94\x85\x94R\x94.'
>>> pickle.loads(pickled)
Decimal('NaN')

Java net.razorvine.pickle
float('NaN')  can be loaded as exepected
scala> unpickle.loads(PickleUtils.str2bytes("\u0080\u0005\u0095\n\u0000\u0000\u0000\u0000\u0000\u0000\u0000G\u007f\u00f8\u0000\u0000\u0000\u0000\u0000\u0000."))

Object = NaN

But Decimal('NaN') can NOT be loaded with java.lang.reflect.InvocationTargetException
scala> unpickle.loads(PickleUtils.str2bytes("\u0080\u0005\u0095!\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u008c\u0007decimal\u0094\u008c\u0007Decimal\u0094\u0093\u0094\u008c\u0003NaN\u0094\u0085\u0094R\u0094."))
net.razorvine.pickle.PickleException: problem construction object: java.lang.reflect.InvocationTargetException
  at net.razorvine.pickle.objects.AnyClassConstructor.construct(AnyClassConstructor.java:29)
  at net.razorvine.pickle.Unpickler.load_reduce(Unpickler.java:773)
  at net.razorvine.pickle.Unpickler.dispatch(Unpickler.java:213)
  at net.razorvine.pickle.Unpickler.load(Unpickler.java:123)
  at net.razorvine.pickle.Unpickler.loads(Unpickler.java:136)
  ... 48 elided

After some investigation, I found, as pointed from https://github.com/irmen/pickle/blob/master/README.md#python-to-java-unpickling , the decimal is mapped to java BigDecimal, but accroing to java doc the BigDecimal can't be NaN.
Do you have any idea for fixing it, Thanks!
Related: SPARK-36000 cc @HyukjinKwon @xinrong-databricks

We can't make BigDecimal represent a NaN
I guess we can :

map it into a float NaN
or throw a better exception (NumberFormatException?)

I'll have a look if the first option is viable.

Decimal("NaN") is now unpickled as Double.NaN.   2809d25137814ea37cd9f17c566395d50d19af0f

Thanks all!

@irmen Woow, thanks, might it posible backport this PR to https://github.com/irmen/Pyrolite and release a 4.32 version?

No, it would be a 5.1 version in that case.
However I believe you’re only using the pickle part of pyrolite yeah? The way forward should be, I think, to replace pyrolite by just this pickle library. ?

Thank you, that's very helpful!

@irmen Much thanks for your answer, I missed it before. And I will also try to switch pyrolite to pickle on spark upstream.

I do some local test, it works! It would be fixed in https://github.com/apache/spark/pull/34285 in Spark.
Much thanks for your awesome help! @irmen


fix(admin): set undefined vars in logout route

:tada: This PR is included in version 3.0.0-alpha.24 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support Turbo Storage connection on lift.materialscommons.org

Now that Turbo has been connected there are a number of changes I need to make to the system to support reading/writing to/from Turbo:

[ ] Running services under<EMAIL_ADDRESS>account
[ ] Cron job to get a Kerberos token (daily) for access to Turbo
[ ] Move the location of the database directory
[ ] Updates for selinux access
[ ] Save database backups to Turbo and local disk
[ ] Move current data files to Turbo

Validated authentication works. Working with ARC to get turbo-storage mounting to lift.materialscommons.org (permission denied when attempting to mount).

LIFT now using turbo storage. All data in turbo.


Fix Lucene Directory integration tests and improve the modules

I've added a README file in the root of the integration tests, as some changes had been made which make me suspect people didn't understand the purpose of these tests.
Please do not override all components to "align" them blindly among all components: the point of the modules - and hence the modular tests - is not only to verify a sound structure of the module, but also to verify cross-compatibility among the different versions which we expect to be valid combinations in the practical world.

https://issues.jboss.org/browse/ISPN-7455
https://issues.jboss.org/browse/ISPN-7458

CI reports failures with these:
query.DSLQueryIT
query.ElasticsearchIndexManagerIT
query.InfinispanQueryIT

thanks @tristantarrant , I'll check those out. I really need a faster machine :)

The tests are failing (rightfully) because after my changes the "${lucene.slot}" property of the infinispan query module is no longer being filtered correctly.
I can't see how that relates with my changes, however this works fine on master.

I pushed a fix and rebased. Should all work now.
I didn't fully understand the strange behaviour of ANT in this case, but my last commit contains a workaround which seems effective.

Thanks, let's wait for CI

Merged, thanks


zpaqfranz: 59.4 -> 59.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/fcorbelli/zpaqfranz/releases.
meta.description for zpaqfranz is: Advanced multiversioned deduplicating archiver, with HW acceleration, encryption and paranoid-level tests
meta.homepage for zpaqfranz is: https://github.com/fcorbelli/zpaqfranz
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 59.6 with grep in /nix/store/mf387qssy57gmrlimx4n0816006fc7lk-zpaqfranz-59.6
found 59.6 in filename of file in /nix/store/mf387qssy57gmrlimx4n0816006fc7lk-zpaqfranz-59.6

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

zpaqfranz

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mf387qssy57gmrlimx4n0816006fc7lk-zpaqfranz-59.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A zpaqfranz https://github.com/r-ryantm/nixpkgs/archive/d2f17a22fb80bde2e5b2990cc9166d7c9f05ef91.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d2f17a22fb80bde2e5b2990cc9166d7c9f05ef91#zpaqfranz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mf387qssy57gmrlimx4n0816006fc7lk-zpaqfranz-59.6
ls -la /nix/store/mf387qssy57gmrlimx4n0816006fc7lk-zpaqfranz-59.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

zpaqfranz

Maintainer pings
cc @AndersonTorres for testing.

@NixOS/nixpkgs-merge-bot merge


Can I add Image hover on lightbox? If yes then how can I do that?

I want to add caption on hover image in lightbox. Or is there any way to add custom html code in lightbox?

Actually I want to add date of image and caption both. Date of image will be on top or bottom and caption could be on hover or if not possible then below image. But there is only one option in this slider.

No not really. I guess you could put some HTML in the title attribute, but that seems like a dirty workaround.


Questions on images used in SR training

Hi,
I have some questions in mind for a while and want to discuss possibilities.
Lr images for training are obtained by cubic rescale of hr ones, and that's fine. This process is preserving the exact noise found in hr image also, don't know if this is an additional benefit or not.
I am taking photos of small technical pieces for documentation purposes, so my photography environment conditions are fixed (same light levels, same background, same object distance, etc).
I have a couple of unusual options in mind, to obtain lr and hr image sets, under given conditions.
One is, taking two photos of same objects, at two different resolutions directly set from the digital camera. One is for lr, and the other one is for hr.
Other option is a bit more complicated and will require more work. No resolution change this time, but a different optical zoom via lens is used to get wide (lr) and zoomed-in (hr) images. Especially with this one, it's possible to capture seriously rich detail levels in hr images.
Do you think any of these helps the SR to perform better, by means of detail preservation and noise, in final images?

Representing more accurately the low resolution distribution would definitely have some positive effect, the magnitude of which can be determined with some experiment.
It is of course crucial that the two images, LR and HR, are representing exactly the same object under the exact same conditions, especially for a PSNR-driven training.
For this reason the first solution seems the more feasible approach (I'm assuming the picture would be taken after one another, without any manual intervention).
I would be very interested in seeing the results (or trying out such dataset, if you make it available). Also this basically would mean that ISR would strictly simulate a 'camera upgrade', pretty cool.
My concern with the second approach is that it would require both manual operations and some post cropping operation of the LR image, right? Which from my non-expert perspective is very prone to mistakes. Of course, should these not be issues, it could be very interesting..

I have ability to take pictures one after another, within seconds (or less, if I setup a macro script), since I am controlling the camera from computer. So, as you stated, these two photos will be highly identical, except the noise distribution.
The other solution is, while it has potential to deliver much more details, changing zoom is bringing different levels of lens barrel distortion per image, which is one thing. Other is, zooming in via optics results with different illumination levels, further zoom means darker frame, so they will have different brightness levels.
I don't know if something can be done using image alignment/warping software to match the patch in hr. It seems it will be difficult to reach pixel-level equality, at least in some portions of the images.
In this point, I am also wondering how many images are needed to carry out such a test? Also, I am talking about 16mp lr, and 64mp hr frames, some resizing will be needed prior to training I guess. I am limited to 11gb gpu ram here. Since I am not a programmer, I know very little about cloud etc solutions.

Resizing should never be done. Rather, crops of the images should be taken, but this is done automatically in ISR (the 'patch_size' parameter in config.yml (under ['session']['training']) determines the size of the crops).
I would not be surprised if the brightness level becomes a problem. But it could turn out to be desirable. However I suggest you to work on the dataset using your first idea, which seems ideal and much easier to achieve.

Perfect, then I will prepare a sample dataset for the purpose. Since my application contains only highly similar objects, on a single-color background (slight noise unavoidable of course), may I assume a smaller number of images will be enough for a successful test? If yes, is there an estimate on minimal num. of images required?

It would be interesting if the images or results of those experiments could be shared to optimize the  model :)


[CI][no-merge]verification of #3030 semver2ext with catalog

Already merged via #3030, #3040 and #3056


FreeBSD stdenv: re-init

Description of changes
https://github.com/NixOS/nixpkgs/pull/311795 but based on master, since it no longer touches anything that's not FreeBSD. Sorry for the mega ping, I forgot it was based on staging before.
Things done

Built on platform(s)

[x] x86_64-linux (bootstrap files)
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[x] x86_64-freebsd (stdenv)

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

ping @Mic92 @paparodeo, you were subscribed to the old PR

Thank you all so much for your help! Today is 16 months and 1 day since I first tried to install nix on FreeBSD. It feels good to finally reach this milestone.

Please remember the commit message conventions.

oh, we didn't squash the squashmes...

No problem. The code works, it is what matters in the end.

One oopsie happend: https://github.com/NixOS/nixpkgs/pull/329973
But hopefully fine now.

BTW, the release-cross jobs can't be scheduled:
https://hydra.nixos.org/eval/1807846#tabs-new
(it's not blocking anything really, just pointless jobs on Hydra)

These should not require an x86_64-freebsd system - they're the cross jobs, I built them myself on a linux system. The problem is probably the recursive-nix feature flag.

@rhelmot I can also upload stuff to tarballs.nixos.org now, which should allow us to have freebsd native bootstrapping.

We still need them to be built by hydra, right? Can we enable recursive-nix in hydra or do I have to rewrite that logic?

@rhelmot I think people might have concerns if we depend on experimental features in nix. Also the bootstrap tarball is probably not critical, it would allow to slip it in other places more easily.

I can imagine that we only enable it on a single builder, say t24a.

I think I have a fixed version that doesn't require any features, I'm just testing the stdenv build with it now.

@Mic92 looks like it's working, can you upload the following? https://hydra.nixos.org/build/270277389

@rhelmot if you want to speed up the process, could you uploading the tarballs and prepare things as in https://github.com/NixOS/nixpkgs/pull/334334?
Otherwise I have a look later after I come back from my travel.

https://github.com/NixOS/nixpkgs/pull/340265


Updated Select input TODOs/issues

Umbrella ticket for issues we discover with the new select field:
🐞 Bugs

[x] Multiselect mode shifts height when at least one value is added.
[x] Console warning thrown re. react-selects not generating unique DOM IDs (Could this point to some larger issue with rendering?  Some comp instances seem to get a unique ID while others do not...)
[ ] Does not support HoistInput's 'style' prop
[x] Validation errors do not highlight - validation styles in general within FormField.scss appear very specific to Blueprint - if we can generalize any better we should.
[x] Event on esc keypress to close the menu is allowed to propagate, potentially e.g. closing a modal dialog in a sudden and unexpected way.

🎁 Feature TODOs

[x] Support for custom item renderer.
[ ] Support for custom options filtering
[x] Support for truncating very long option lists to avoid perf. issues.

The HoistInput style prop might be tricky - see how react-select uses styled components.
In general I think we need to do a pass at sizing / styling across inputs to get better consistency.

I am using the new select control in a modal, which is closable by hitting the Escape key.
I had to add some logic to the component that wraps the select control that checks to see if the select is open:
if it is open, the Escape key event propagation is stopped.  The select control closes, but the modal does not.
If the select is closed the Escape key event propagates, and the modal closes.
Seems like a select in a modal that can be closed by Escape is a pretty common use case.  Maybe we can add a  prop to our select control that prevents 'Escape' propagation if control is open.

Hi - thanks for reporting!

Is there any reason not to always stop propagation in the case where the select is focused, showing its menu, and esc is pressed? Do we need a prop to opt in/out of that behavior, or should it always do that?
We should check if we have the same situation with e.g. the date picker.
That said, in this case is it important that the modal be closable with the esc key?  Not trying to get out of a fix here, but it seems potentially problematic to have a modal that's complex enough to have inputs of any kind (i.e. not a trivial/read-only alert) that will also close itself so readily. I see we do not close the rest editor form pop-up on esc, which I think is good.  We do close the config differ on esc, and it's a good way to see the bug you're reporting and why it's bad. But in that case too I think I might favor not closing the differ on esc. It's complex enough and has enough internal stuff going on that it seems reasonable to press the close button.  (But again, still agree we should stop the event if we can.)

The modal I am working on is part of a data entry interface.  To maintain feature parity with the interface it is meant to replace, the modal would have to close on Escape.  The end-users are quite insistent on not being forced to reach for the mouse.
To code my escape key event handler, I had to use react-select's onKeyDown prop.
Whether we make it a permanent or opt in/out feature, we should code it so that onKeyDown can still be used for other customizations.
From the developer's perspective:
If the feeling is that most modals that contain forms will not be closable on escape, then it is probably not worth implementing as a feature (permanent or optional), just to keep our fingerprint on react-select as small as possible.
From the end-user's perspective:
I can't see a reason why Escape key propagation would not always be stopped if the control were open.
It seems like other's agreed with the end-user's perspective, and the lib maintainer even coded this in two years ago:
https://github.com/JedWatson/react-select/pull/1066
then someone else complained about it:
https://github.com/JedWatson/react-select/issues/1335
but got no response.
In the latest version 2 of the code stopPropagation has been removed: https://github.com/JedWatson/react-select/blame/master/src/Select.js#L1145
Maybe in version 2 the solution is to use: menuPortalTarget to put the drop down menu outside of the modal, and then no Escape key handling is needed.  I will test that.  If that does not work, I will ask the lib what happened to their original solution.

Apologies if I am misunderstanding, but do we not already use menuPortalTarget to attach the drop down menu to document body? I have been dealing with a similar issue related to select menus within a popover. I piggybacked off of one of Colin's solutions yesterday to use the onInteraction prop to handle clicks outside the popover (this prop is also available to Dialogs).
I just tried this and was able to prevent Escape press from closing the popover, but only when a select menu is open:
    @action     onInteraction = (nextOpenState, e) => {        const escapePressOnSelectMenu = withDefault(e, false) &&             withDefault(e.target, false) &&             withDefault(e.key, false) &&             e.key === 'Escape' &&             e.target.id.includes('react-select');         if (escapePressOnSelect) {             this.setPopoverDisplay(true);         }     };

@shravnk Yes, we already do use menuPortalTarget.  I edited my comment probably at the same time as you were writing yours.  Sorry about that.
Your solution is on the popover that contains the select.  My solution is more on the select itself (which is in a dialog, not a popover)

See this PR for the minimal validation issue. Did not need to use Blueprint classes in several other instances so made those changes as well.
The lighter onFocus box-shadow we use for the new Select compared to Blueprint is harder to identify when a validation error border is also applied. May be nitpicking though...

@amcclain In my client work in which I have a select inside a dialog, I found that this commit
221ca61 #diff-7c57d69a6dcea1ae69f31992eab0ca6bR176
does fix the issue of not closing the dialog when when the escape key is hit when the select menu is open.
However, it now prevents the escape key from closing the dialog when the user is focused on a select field that does not have a menu open.
This latter issue is not that big of a deal.  Probably not worth worrying about until someone complains about it.   But if we were to address it, I guess we would need to find some way to examine if the select menu is open to determine whether or not to stop propagation.  Or WAS open if the menu closes before the event propagates to box wrapper.
I had a solution which handled this in the client's code.  It didn't involve a wrapper box, but used a reference and the select components onkeydown handler.    Can discuss if you like.

I notice while trying to set a select value programmatically that the react-select will only accept values that are strings.
I had a list of options like:  [{id: 100, name: 'test'}, ...]   The 'value' field  was 'id'   .    If tried to set the
component value to 100,   it failed.
I needed to map id.toString() on all option items first.
react-select uses flow (https://flow.org/en/docs/types/objects/)
https://github.com/JedWatson/react-select/blob/master/src/Select.js#L589
https://github.com/JedWatson/react-select/blob/master/src/types.js#L4
https://github.com/JedWatson/react-select/blob/master/src/types.js#L15
and does most of its equality comparison with ===  not == so we are stuck with this.
Wondering if it is worth, in our wrapper, to convert the value fields we get to strings.
Could be done in this toOption function https://github.com/exhi/hoist-react/blob/develop/desktop/cmp/form/inputs/Select.js#L238
line 250: value: src[valueField].toString()
It might mean restricting our acceptable value types to string, number, or boolean.  That would still satisfy most usecases, I think.

Closing as we have addressed most of these items.  Will let any others loop back around to us in new tickets.


Kibana Did Not Load Properly

This error started to come up a lot recently:

Kibana server logs show 300 status code for GET requests with the following path patterns:

GET /built_assets/<resource-path> 304
GET /bundles/<resource-path> 304
GET /translations/<resource-path> 304
GET /ui/fonts/<resource-path> 304

NOTE: SG is used with basic license and Kibana Spaces is enabled. Also, there is a load balancer between Kibana and the browser with 5 min idle timeout.
ES: 6.7.1
Kibana: 6.7.1
SG: 25.0
SG Kibana plugin: 18.3

@jochenkressin @mgustafsson1 can you have a look?

To me, this does not seem to be related to Search Guard.
In the screenshot, the error is related to loading Kibana internal assets, like a CSS file from the tiles map plugin. A gateway timeout usually means that the load balancer is not configured correctly.
@Alsheh : Can you please check that the assets that cannot be loaded (the index.css of the tiles map plugin in the screenshot above) are accessible when requesting them via the load balancer?

@jochenkressin thanks the follow up! Yes, this issue seems be related to the load balancer as it can be observed with large idle timeout and less frequently with a small idle timeout.


ShowCase: update to MvuElement

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 99.545%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
11477

Relevant Lines:
11480

💛  - Coveralls


feat: Allow controlling sidecar environment variables

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

/area proposals

What this PR does / why we need it:
Without this PR, the injected sidecars are pretty much forced to run with the default environment. This PR introduces two ways to control the sidecar environment:

Any changes to the environment in the top-level environment_variables section are propagated to sidecars
Each sidecar (mount section in the config) can have its own private environment variables that take preference over the top-level ones

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
This is https://github.com/falcosecurity/kilt/pull/81, resubmitted without changes

Working on these right now. Yeah, something like this.


simplify

@allewun @kevgo @ricmatsui
remove unneeded "$*" in place of "$1".
This makes the silent argument possible in #501

:ship:


Provide file names when "Failed to process {len(self.discovery.failures)} files" is returned

When running tryceratops if any of the files aren't able to process, more information should be returned about which files can't be processed.
Specifically, running tryceratops on a simple project with only 16 files returns the following:
Done processing! 🦖✨
Processed 16 files
Found 0 violations
Failed to process 1 files
Skipped 2340 files

Without knowing which file failed to process, I'm not sure what, if anything, I should do for next steps.
This message comes from interfaces.py line 51

Good point.
I was thinking about adding a -vv verbose flag to display all files. What do you think?

I think that's a great idea! If you'd like I can try and make and update and submit a PR. It would be a couple of days though before I was able to get the PR submitted.

@guilatrova I tried to get the project set up and installed locally in edit mode (pip install -e .) but I get the following errors:
ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /Users/ryan/github/tryceratops
(A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)

What is the set up you use when developing locally. Perhaps I'm just missing something obvious.
Thanks!

@ryancheley Thanks for the help! I created a short new contributing doc, can you check and let me know if it works for you?

@guilatrova I've made the changes and pushed them to my fork of the repo. Before I create a pull request, do you want to look at the changes I made? If so, you can see them here
If not, just let me know and I'll create the PR
Thanks!

That's a great start and thanks for following the conventions!
I think we can go even beyond though! I'd love to make your change so impactful that it can benefit other developers/contributors in the future.
How? Here:
Verbose means that any "verbose" (duh) message gets displayed in the console, besides the final user presentation (that we do with print), so for any developer today and in the future that wants to benefit from the flag you just implemented they should be able to do this ANYWHERE in Tryceratops and it should work.
I'd recommend then:
Extend logging for that

__main__.py -> Once you receive the flag, set the log level to DEBUG Reference
settings.py -> Create a new handler to output to console - what if we name this handle verbose_output? Feel free to name it as you prefer
settings.py -> Create a better format for the new DEBUG handler (Maybe lineno and asctime is too much. Try and share your decision!)

Do not use prints, do not bloat the presentation layer

interfaces.py -> Remove the prints/ifs from the presentation layer
discovery.py -> Use logging.debug inside the except block (should we remove the exception one? wdyt?)

Congratulations
🎉🥳  Now ANY DEV can use logging.debug ANYWHERE and it WORKS!
Overall
Does it make sense? I'm curious to receive your feedback. I'm not completely sure if it would work though, but I believe it worths trying.
I can help with if you're too busy, but I'd love to have your name as a contributor in this repository ❤

I really like the ideas above and can work on implementing something this week.
I'll need to look more closely at the try / except in discovery.py but based on my initial (very cursory) glance, I'd say it should be kept.
It seems like it's doing exactly what a try/except should be doing and I'm not aware of any other mechanisms to handle what it's doing (though maybe there is something?)
I'll continue to work on the branch of my fork and won't submit a PR for now.
Thanks!
P.S. I'd also love to have my name as a contributor on this project 😄

@guilatrova I think I have it figured out (also, I understand what you were asking about when you mentioned exception in your comment / question above) 🤦
I did swap out the logger.exception with logger.debug in discovery.py
My changes are located here.
There are still tests that need to be written for this change, but I wanted to get your input before starting to write the tests
Thanks!

Yes, you got the idea! Please open a PR so we can start discussing there ☺


LeetHub Extension for the Leetcode problem that is automatically stores in the github by using the extension

Is your feature request related to a problem? Please describe.
This is the solution for the leetcode that is the storage of the problems in the github using the extension
Describe the solution you'd like
There is the code for the JS in the Leetcode
Describe alternatives you've considered
There is no other options available for this one .

Already added to my repository #664

@Sulagna-Dutta-Roy That is for the problem of the day where it will generate the problem for the day But what I have added is the LeetHub that mainly focuses on the Leetcode solved problem in the github .
I will explain the workflow .
If we solve the problem in the Leetcode and Geeks for Geeks It will automatically pushes the code to the github .
https://github.com/Aksshay88/Leetcode-Solution
You could check the above link that is my one of the repo .
Pls do add the GSSOC label .
Thanks in advance .

Kindly do not raise any Pull Request until it's assigned to you @Aksshay88

@Sulagna-Dutta-Roy Sorry for this and thanks for assigning it to me .
I have completed this issue .You could check my work in the below provided link .Thanks in advance.
Once again I mention sorry .
https://github.com/Sulagna-Dutta-Roy/GGExtensions/pull/737#issue-2329622116


Create and use combined simdjson.h/.cpp

This creates a include/simdjson.h and src/simdjson.cpp, which mirror the amalgamated headers, and uses it everywhere in our benchmarks, tools and tests. This allows us (and users, if we so choose) to use the repository files just like they would use the amalgamated version. It also greatly simplifies the Makefile and amalgamation.sh, and lets us test both the amalgamated and non-amalgamated versions in CI.
Changes

Combined .h/.cpp: Create include/simdjson.h, src/simdjson.cpp with #includes in them, as faux-amalgamated header/source files.
Include simdjson.h: #include "simdjson.h" in all benchmarks, tools and tests.
Build with simdjson.cpp: Compile benchmarks, tools and tests alongside src/simdjson.cpp (greatly simplifies Makefile!). (Note: used g++ src/myexe.cpp src/simdjson.cpp instead of `#include "simdjson.cpp".
Test amalgamated .h/.cpp on Drone: Run all tests against amalgamated .h / .cpp, with SIMDJSON_RUN_AMALGAMATED_TESTS=1 before running make.
Simplify amalgamation.sh: Use include/simdjson.h and src/simdjson.cpp as the only amalgamation input (the rest is transitive dependencies). No more getting out of sync! Higher confidence that our local tests do the same thing as amalgamated, too.

Fixes #515.

Windows seems to be trying to build all the .cpps even though they are just includes. And CircleCI is going crazy saying it can't find /usr/bin/cmake, which I am assuming is an infrastructure problem.

Remaining issue is that cmake creates and uses a .so I didn't realize ... Will fix

OK, this one's done.

It has me puzzled that this code passes all our tests considering that there is apparently a merge error.

I just pushed an update with that merge conflict resolved, and I also validated that "<<<" doesn't appear anywhere else bad.

(I'd investigate why fuzz succeeded, but I have to disappear for a bit.)

@lemire oh, this is the reason:
#  fuzz_minify.cpp   # <--- does not pass the build check test on oss-fuzz, says "partially instrumented". help needed!

Filed #530 for fuzz_minify.

@jkeiser
Looks good to me. Merge at will!


env error, possible solution??

ModuleNotFoundError                       Traceback (most recent call last)
 in ()
7 from stable_baselines import PPO2
8
----> 9 from env.StockTradingEnv import StockTradingEnv
10
11 import pandas as pd
ModuleNotFoundError: No module named 'gym.Env'

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.

How was this fixed?


rename PlController to ApplicationController

specs will fail because the admin controllers sill call PlController

I will fix up specs and controllers momentarily! Merging in!


[BEAM-12524] Use synchronized function to set instruction_id to null.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

cc: @TheNeuralBit

This appears to be hitting a false positive spotbugs error:
In class org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor
Field org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor.instructionId
Synchronized 66% of the time
Unsynchronized access at ProcessBundleHandler.java:[line 752]
Synchronized access at ProcessBundleHandler.java:[line 748]
Synchronized access at ProcessBundleHandler.java:[line 744]

I'll post a fix that suppresses the finding.

Nope, ignore my noise. The other PR that is failing the precommit was branched earlier than the fix here was committed.


Allow native DatePicker/DateTimePicker to open onfocus

[x] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

For consistency between native and non-native, this PR will allow native datetime-local to open onfocus.
Without this PR, this also works:
Forms\Components\DateTimePicker::make('start_date')
    ->extraAlpineAttributes(['onfocus' => 'this.showPicker?.()'])

Browser compatibility: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/showPicker#browser_compatibility

I'm not sure if we should change this default behavior.
Could you explain the need, @sumardi?

https://github.com/filamentphp/filament/assets/315603/2d900584-c5af-41bd-a486-9ac48e22c552
Attached screen record for comparison, for now we need to click on the calendar icon to open the native picker.

Hmm, right.
I was testing on Safari and there it opens the panel when you click the input.
If you focus the input using the keyboard, it doesn't open the panel.
What I found though, is that you can open the panel by pressing space when the input is focused.
This works across both Chromium and Safari.

I'm going to close this PR for now, since messing with default browser behavior often only causes problems. When more people brings it up as an issue, I'll reconsider merging this PR.


How to put close button on caption bar

Hi,
I'm trying to change the "close" button, in order to set it on the top left of the screen (and not bottom left).
So I ued the getImageCaption function, in order to create my button :
getImageCaption: function(el){
var captionBack;

captionBack = document.createElement('a');
captionBack.innerHTML="Back";
captionBack.setAttribute("onClick", <what_to_put_here?>);

return captionBack;

}
How can I achieve this ?
Is there any cleaner way ?
I have been looking at the examples, and the addEventHandler  functions, but unsuccessfully so far.
After this button, I will have other buttons, with custom functions, to set up, on the caption bar.
Any help much appreciated, and thanks for all the work :)

Having the exact same situation...
tried:
PhotoSwipe.detach(instance); as well as PhotoSwipe.disposeInstance(instance); but both won't correctly bring me back to the original page like when clicking on the closing button.
Would love to know how to manually force PhotoSwipe to close.
Thx

https://github.com/codecomputerlove/PhotoSwipe/issues/210
it's just that easy!?

Here what I did, maybe not the smartest way, but it's working.
So I give an ID to my back button, and then I add this method :
instance.addEventHandler(PhotoSwipe.EventTypes.onDisplayImage, function(e){
	$("#<MY_BACK_BUTTON_ID>").click(function() {  e.target.hide(); });
});


Backup - code sample

@simonaco,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/backup.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/backup.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off
LGTM

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/backup.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@simonaco @johnpapa merged


[DUPE] Fix Hostname.get_fqdn on AWS Lambda

Customer information this is my linked text.
How does Jira do with code snippets?
      def initialize
        @enabled = NewRelic::Agent.config[:'audit_log.enabled']
        @endpoints = NewRelic::Agent.config[:'audit_log.endpoints']
        @encoder = NewRelic::Agent::NewRelicService::Encoders::Identity
        @log = nil
      end

Heading 1
Heading 2

[ ] First item
[ ] Second item
[ ] Third item

Here is my GitHub response

@kreopelle - what are your thoughts about this bug?

I think #19 could also be useful when we discuss this

See newrelic/newrelic-ruby-agent/#1000

See https://github.com/newrelic/newrelic-ruby-agent/issues/1264 for more information about the error


m.write() no longer works

In GitLab by @tessodk on May 22, 2019, 15:13
Excisting scripts that previously worked (e.g. the examples) currently give the error message below when trying to write the model.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
 in
     72 m["oc"] = imod.wq.OutputControl(save_head_idf=True, save_concentration_idf=True)
     73 m.time_discretization(starttime="2000-01-01", endtime="2001-01-01")
---> 74 m.write()

..\imod-python\imod\wq\model.py in write(self, directory, result_dir)
    354         # it ends up in the right place when you call imod-wq in that
    355         # directory.
--> 356         result_dir = pathlib.Path(os.path.relpath(result_dir, directory))
    357         runfile_content = self.render(writehelp=False, result_dir=result_dir)
    358         directory.mkdir(exist_ok=True, parents=True)

..\miniconda3\envs\main\lib\ntpath.py in relpath(path, start)
    558 def relpath(path, start=None):
    559     """Return a relative version of a path"""
--> 560     path = os.fspath(path)
    561     if isinstance(path, bytes):
    562         sep = b'\\'

TypeError: expected str, bytes or os.PathLike object, not NoneType

In GitLab by @Huite on May 22, 2019, 22:43
closed

In GitLab by @Huite on May 22, 2019, 22:43
Thanks, was a bit too quick in my additions. Added a test as well.
Fixed in:
73c8e4ce2dc047faefe1477e98d8352c84b7d770


remove unused code

I like these pull requests!!! :-)

Me too. What is the HTTPFrontEnd?

Me too. What is the HTTPFrontEnd?

It is the component version of WMCore/HTTPFrontEnd, but never used in anywhere.
WMCore/HTTPFrontEnd need to be deleted but still several services running with it. (ReqMgr, WMBS, Agent) The last 2 are the REST services which can provide component and wmbs information but I don't think any one is used due to they are under firewall. It could be useful for monitoring though. )


Question : how to concatenate 2 columns in a new computed column ?

Hello.
First, your plug-in is very useful for me, thank you very much :).
I use Kibana 6.7 and Enhanced Table 1.8.0
My question is :
I have 2 numeric columns. The first one col2 contains Years (ex 2019), the second one col3 contains Month numbers (ex 6).
I want to create a new computed string column containing Year+'-'+Month (ex 2019-06). I try many  things without success (for example col2+'-'+col3).
Can you help me please ?

To do concatenation, you have to use || operator.
For instance: col0 || '-' || col1
You can find whole expr-eval doc here (link is available in visualization editor view):
https://github.com/silentmatt/expr-eval#expression-syntax

Question is answered and there is no feedback since 3 months, so I close the issue.


Add platform information to env

Closes https://github.com/bundler/bundler/issues/5069

Thanks! @homu r+

:pushpin: Commit 5737ab6 has been approved by segiddins

:hourglass: Testing commit 5737ab6 with merge c21535c...

:sunny: Test successful - status


fix: add file changes process only git tracked files

since we use git add to ensure the files from the input will be tracked by git. We should skip untracked files when processing git status output

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.59%. Comparing base (a05e101) to head (8a12850).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   97.59%   97.59%
=======================================
  Files          11       11
  Lines         291      291
  Branches       56       56
=======================================
  Hits          284      284
  Misses          7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Double minus in css (insede calc)

Bug Report
There are double minus in css file (--1px)
Steps
Download<EMAIL_ADDRESS>Expected Result
 .ui.attached.steps {
   width: calc(100% + (1px * 2)) !important;
   margin: 0em -1px 0;
   max-width: calc(100% + (1px * 2));
   border-radius: 0.28571429rem 0.28571429rem 0em 0em;
 }

Actual Result
 .ui.attached.steps {
   width: calc(100% + 2px) !important;
   margin: 0em -1px 0;
   max-width: calc(100% + 2px);
   border-radius: 0.28571429rem 0.28571429rem 0em 0em;
 }

Version
2.4.2
There are also some places with double minus like here (--1px)
I really think this is mistake. It it's not, please tell me what does it mean ?

We don't handle CSS there, it's a repo for React bindings. Feel free to open an issue in the main repo: https://github.com/Semantic-Org/Semantic-UI


Chess: "here" link text is suboptimal

I'd just remove "found here." and put the anchor around and link to part of sentence describing where it is going.

Closing this in favor of #320.


Use devMode for debugging

The foundryvtt-devMode module can be used to safely leave debug code in the remote. This is useful for code readability and for future programmers debugging systems they didn't write.
Future code should make use of this. It may also be useful to go back and add debug code for already existing code.

Discussed 30-06-2021, looking for suggestions on where to place logging

I suppose this is theoretically fine as long as there are no hard dependencies added to the module manifest. It really isn't a good idea to add extra module dependencies to FQL. I haven't looked into the devMode module, but a glance at the README suggests that it is enabled via a hook and is an adjacent module that is installed.

I suppose this is theoretically fine as long as there are no hard dependencies added to the module manifest. It really isn't a good idea to add extra module dependencies to FQL. I haven't looked into the devMode module, but a glance at the README suggests that it is enabled via a hook and is an adjacent module that is installed.

Correct; when the devMode hook fires, we register a flag that FQL will use. The intent is that developers can use this flag to determine whether logging actually goes into the console, but it's essentially just a user-set boolean - see this example usage.
If the module is not installed, the hook simply never fires and any console.log() output dependent on the flag will not appear.
Seeing as how FQL currently makes very little use of console.log() in production, this would make very little change until proper logging is added into FQL.

Closing the issue as there does not seem to be a need for this change without proper logging. We should probably avoid using console.log and devMode logging simultaneously. If FQL ever does add logging I recommend that this is used, but until then the change is not significant enough to warrant an open issue.


Update watchdog version

close #249

Coverage decreased (-0.1%) to 54.822% when pulling a10cd4c81e9548f029d21d9fbad40de0eb7b2079 on ib/update-watchdog into f7d484a28c72a546c89a1ed103cb0f974589a1e5 on master.


PaperSize parameter is not working

Future printReceiptText(
ReceiptSectionText receiptSectionText, {
int feedCount = 0,
bool useCut = false,
bool useRaster = false,
double duration = 0,
PaperSize paperSize = PaperSize.mm58,
}) async {
final Uint8List bytes = await contentToImage(
content: receiptSectionText.content,
duration: duration,
);
final List byteBuffer = await _getBytes(
bytes,
paperSize: PaperSize.mm58,
feedCount: feedCount,
useCut: useCut,
useRaster: useRaster,
);
_printProcess(byteBuffer);
}
kindly fix the PaperSize parameter. it is statically set to PaperSize.mm58 we cannot change size because of that. Thanks!

Solved in here #52


Remove references to netty so that using grpc with shaded netty is possible

There are no more references in the main code, but com.google.api.gax.testing has some references in MockServiceHelper and LocalChannelProvider.

Since we aren't shading Netty until after GA, this isn't blocking GCJ GA.

This was done in https://github.com/googleapis/gax-java/pull/469 .


Locale null countryCode in flutter internationalization

From @MarkBriggs2 on April 17, 2018 14:40
Question about  #internationalization
Working through the tutorial at https://flutter.io/tutorials/internationalization/
Source at:
https://github.com/flutter/website/tree/master/_includes/code/internationalization/intl/
If supportedLocales parameter to MaterialApp constructor is as follows:

supportedLocales: [
    const Locale('en', 'US'),
    const Locale('es', 'ES'),
  ],

this initially works. If country codes are omitted:

supportedLocales: [
    const Locale('en'),
    const Locale('es'),
  ],

then the countryCode getter of the Locale object passed to DemoLocalizations.load() or GlobalMaterializations._computeLocaleName(Locale locale) (material_localizations.dart line 134) will be null so any attempt to access locale.countryCode.isEmpty will generate a NoSuchMethodError.
Is this as intended?
Thanks
Copied from original issue: flutter/flutter-intellij#2093

Locale constructor is:

const Locale(this._languageCode, [ this._countryCode ]) : assert(_languageCode != null);

If altering member _countyCode to default to empty string is not recommended, then perhaps the solution may be to alter  GlobalMaterializations._computeLocaleName(Locale locale)  (from material_localizations.dart) to check for null. Then modify the tutorial so that the app specific localization instance's load() does the same.
Just a suggestion...:)

I am facing below error in real device. don't know why.
Xcode build done.
Installing and launching...
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File<EMAIL_ADDRESS>line 52, in <module>
    import weakref
  File<EMAIL_ADDRESS>line 14, in <module>
    from _weakref import (
ImportError: cannot import name _remove_dead_weakref
flutter: locale: en_US
flutter: locale: ko_KR
Syncing files to device 장효찬의 iPhone...
flutter: Load en
[VERBOSE-2:dart_error.cc(16)] Unhandled exception:

@dooboolab do you mean the Python error? If so, I believe that should be fixed via #19281. It should make it to the next beta release. You can verify that on dev channel via flutter channel dev (flutter channel beta to switch back to beta channel).
If you mean the unhandled exception below that, it looks like the exception and any stack trace were truncated from your post. If you're still seeing this, would you mind opening a new bug with a verbose log (flutter --verbose run ...)?


Error: nodeUtil is not defined

Description of Bug
Provide a concise description of your bug and your project link (if applicable).
util module should be considered as a node internal package
Error: nodeUtil is not defined
    at <anonymous> (/home/projects/llqiawwrr.github/node_modules/pdf2json/lib/pdf.js)
    at eval (/home/projects/llqiawwrr.github/node_modules/pdf2json/lib/pdf.js:87:1)
    at _0x345efc._evaluate (https://llqiawwrrgithub-0ckm.w-credentialless.staticblitz.com/blitz.6854296d.js:352:378687)
    at async _0x345efc._evaluate (https://llqiawwrrgithub-0ckm.w-credentialless.staticblitz.com/blitz.6854296d.js:352:378298)
    at async ModuleJob.run (node:internal/modules/esm/module_job:181:2372)

Steps to Reproduce

Go to https://stackblitz.com/github/run-llama/LlamaIndexTS/tree/main/examples?file=README.md

ts-node ./readers/load-pdf.ts

Expected Behavior
Parse pdf successfully
Screenshots/Screencast
If applicable, add screenshots to help explain your problem.

Additional Context/Questions
Add any other context or questions regarding this bug.
import nodeUtil from 'util';
import fs from 'fs';
import path from 'path';
import { fileURLToPath } from 'url';

import { EventEmitter } from 'events';
import { Blob } from 'buffer';
import { DOMParser } from '@xmldom/xmldom';
// ...

sorry I published the new llamaindex, you can see the error now


Mobile Testing on MetaMask Mobile

Description
Mobile Testing on MetaMask Mobile
Acceptance criteria

Doing the full lifecycle
Using a fresh ETH account

Tasks

[ ] Test on staging
[ ] Document the test

[ ] Disclaimer
[ ] Connect
[ ] Connect a token

@agatsoh so it is about those buttons. :grimacing:

The account screen looks a bit ugly.

Transfer eth screen the amount is not visible when editing it. Its gets white out due to the background.

Separate issues exist for this, closing.


fix(couchdb): don’t emit documents without accountId in repositorys/byAccount

e.g. I have seen branch documents without an accountId property, and others that do, so maybe the problem is somewhere else?

Yes, we should fix the root cause of this :) Let's see if this is maybe old data?


Track by doesn't work for bs-select

This:
<select multiple="" ng-model="model.provinces" ng-options="province.section17Name for province in lists.provinces track by province.id">
                  </select>

does not behave like
                  <button type="button" id="provinces" class="btn btn-sm btn-default" max-length="13" ng-model="model.provinces" data-multiple="1" data-animation="am-flip-x" bs-options="province.section17Name for province in lists.provinces track by province.id" bs-select>
                    Action
                  </button>

The standard select works fine. It correctly matches the values on their id field. bs-select fails to match anything, prints 'false, false, false' to the ui (i have 3 values pre-selected). And then when pick something it sets each pre selected value in the array to null then adds the new value that you selected to the array.
The issue (i think) is the list that is bound does not contain the same references as the values are in the array targeted by ng-model. They have the same label, same id but they are not referentially equal which seems to be something bs-select cannot handle. It doesn't seem to do track by

Hi, this doesn't seem at all related to FluentValidation - I can't help you with angularjs issues I'm afraid. Perhaps you'd be better off posting on the angularjs issue tracker?

Oh I'm very sorry @jeremyskinner. I had the angular strap project open and yours, I meant to raise it there, I've got to many tabs open.

No problem...hope you get it sorted.


Problem with reactivity

Hey! I love your project and I'm committed to use it on my new project.
I notice on the other hand a few things that might be a bug, lack of documentation or a bigger problem between my screen and my chair!
The first one is that this bit of documentation (Examples on README.md) looks kinda wrong:
class HelloWorld extends MoleculeLit.Element {
  static get properties() {
    return {
      name: String,
      attribute: true,
      value: 'John Doe',
    };
  }
...

I guess it should be something like:
class HelloWorld extends MoleculeLit.Element {
  static get properties() {
    return {
      name: {
        type: String,
        attribute: true,
        value: 'John Doe'
      }
    };
  }
...

I also notice that if I declare the property as an attribute, when I call this.setProperty('name', 'Foo') it does update the attribute but it won't update the rendered template. I was expecting it to update the template no matter if it's an attribute or an internal property... Am I making a wrong assumption?
import { html, render } from './node_modules/lit-html/lit-html.js'
import { Element } from<EMAIL_ADDRESS>const ElementLit = Element(render)
class TestElement extends ElementLit {
	static get properties() {
		return {
			name: {
				type: String,
				attribute: true, // If I comment this line it updates
				value: 'Lala'
			}
		}
	}
	changeName(self, e) {
		this.setProperty('name', 'Dinky Winky')
	}
	render({msg}) {
		return html`

Name: ${name}

			<button @click=${this.changeName.bind(this)}>Change name</button>
		`
	}
}
customElements.define('test-element', TestElement)

I'm tried on Firefox 63.0.3 (64-bit) and on Google Chrome Version 71.0.3578.80 (Official Build) (64-bit) both on Ubuntu 18.04.

Hey! Awesome that you like the project.
First: Yeah, that’s a mistake. Thank you for that, I’ll correct it ASAP. Or feel free to create a PR, if you have the time.
Second: You assume correctly. That sounds like a bug. I’ll look into it over the next few days.
Thank you for letting me know.

Fixed the wrong example

Cool, @DerDrodt !!!! I had a bit of a busy day but I will have a look at the second issue as well, I really wanna dig the code to learn how you achieved such awesomeness :D

Feel free to do that. But I think I found it.

Your example had a small mistake. In your parameters of render, you wrote {msg}, but the property is called name. That one took me a while to see :)
name already is an attribute on HTML and in some cases it behaves a bit weird. That shouldn't be relevant here, but just keep that in mind. I had a few bugs with that (I should add that to the docs)
This was the actual mistake: For whatever reason, if we have an attribute that updates, and we "force" an update (like you did with setProperty) we just do nothing. I don't know why I wrote it that way, but that was the issue. I'll investigate a bit and publish a new version.

Thank you for reporting this bug. If you find another one, please let me know!

The commit that fixed it closed it automatically.

Oh, sorry, that was a bad translation from the actual code (where I was using msg and not name) but the misbehaviour is still present using either name or msg.

No worries, I already assumed something like that.

I'll definitely keep in mind to avoid using standard attributes. I believe in Polymer they append something to make explicit whether using a custom or a default attribute., that could be a lead.

Didn't know about that. But I do know that they don't do it anymore in LitElement.

I'm so happy I helped somehow, I hope to level up to be able to make an actual code contribution next time! smiley

Well if you have any ideas or want a place to start, I'd be happy to help.


BUG: Handle infinite values correctly in Series.argmax

[ X] closes #13595
[X ] tests added / passed
[X ] passes git diff upstream/master | flake8 --diff
[X ] whatsnew entry

@matthewwillian You have some PEP8 issues (see the travis log at the bottom: https://travis-ci.org/pydata/pandas/jobs/144182270), and a failing test.

Okay, thank you. I will take a look.

@matthewwillian Can you update/rebase?

It's gread if you can include the fix for argmin for -inf.
pd.Series([1, 3, -np.inf]).argmin()
0

can you rebase

can you rebase / update?

can you rebase and move release notes to 0.19.2

can you rebase / update

closing, but if you want to update, pls comment.


Editing pass

The usual proofreading details (punctuation, usage, and so on).
Also put Gradle first in all cases (to be consistent with the instructions
at the top) and removed the $ prompts from copyable blocks (so that
the copied content runs without modification).

Is #73 redundant with these changes (can we close it)? Also this change is showing conflicts. Might be a good idea to rebase and force push back to your branch.

Yes. I closed #73. Thanks.


borderRadius is missing in TS

I've noticed that borderRadius doesn't autocomplete in TS - only borderTopLeftRadius, borderTopRightRadius, borderBottomLeftRadius, borderBottomRightRadius do.  borderRadius is defined upstream in lib.dom.d.ts's CSSStyleDeclaration.
It looks like you're autogenerating CSSProperties.ts, so I'm not sure where/how to fix this.

@appsforartists CSSProperties.ts is, at the moment, a direct copy of the CSSProperties interface from @types/react. The file I’d modify to add borderRadius is the script that generates CSSProperties.ts. The idea of the script is to use React’s CSSProperties as a base and to add on any additional items. I haven’t built out the “add on additional items” portion but it should be pretty straightforward. I’ll try to get to it sometime this weekend.
What I’m probably going to do is to keep a separate .ts file in the misc folder that contains any additions to CSSProperties. When mktypes.js runs, it would read that file and merge it in with the types from @types/react.

Thanks for the background!
Seems like a better solution in this case would be to patch the upstream copy.  Do you expect to need properties in jsxstyle that wouldn't make sense in @types/react?

@appsforartists borderRadius definitely should be in the upstream version. As far as jsxstyle goes, in the future their might be a few special case props (for example, px to set paddingLeft and paddingRight to the same value). Still thinking it over though (see #74). We might also feel confident enough in the completeness of jsxstyle’s CSSProperties that we’d remove the index accessor (😱).

Index accessor?

this lil fella: types/react/index.d.ts#L2436. index signature maybe? I’m not 100% sure what that thing is called.

In addition to my previous comment: I feel like we‘ve got more motive to keep a list of style properties and types accurate and up to date, too.

Ahhh - I didn't realize jsxstyle had one of those.
I left my computer at work, but I'll try to remember to add borderRadius upstream, as well as fix the types of all the radii properties sometime soon.

Rad, let me know when it lands!
I just realised the other reason I’m using a custom version of CSSProperties: I don’t want people to have to install @types/preact if they’re using the Preact version of jsxstyle.

Would it matter?  Types don't ship to users, and you could have @types/react as a devDependency, so the install would be automated.
Not sure if React and Preact types would ever diverge (and I like the thinking behind shorthand properties), but I don't think depending on @types/react would alone be a blocker.

@meyer https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21895

@appsforartists 🙏🙏🙏

Another thing to consider re: extending vs. forking @types/react: if you imported/extended it, you wouldn't have to push new jsxstyle releases just to get fixes like this one.

@appsforartists yeah, I’m planning to go through the CSS spec and add each value with proper types one of these days when I have a few hours to kill. The CSSProperties interface in @types/react seems to be intentionally not comprehensive according to this comment:
// This interface is not complete. Only properties accepting
// unitless numbers are listed here (see CSSProperty.js in React)

Seems like their goals don’t 100% align with jsxstyle’s, which is why I looked into the external CSSProperties file in the first place.
Regarding extending vs. copying: if it wasn’t for jsxstyle’s pseudoclass prefixes, I’d be totally down with extending the interface instead of copying it, but since we’d need to generate types for the prefixed style props as well, I’d rather just keep everything on the jsxstyle end. If a comment or type changes on a unprefixed prop, I’d like it to change on the pseudo-prefixed versions as well. Less chance of a weird mismatch.
Also also: @types/react’s CSSProperties seems to track a more stable version of the spec, which means that TypeScript marks newer values with partial browser support as invalid. Example: alignItems="baseline".

Over the weekend I looked into converting MDN’s CSS data to TypeScript type definitions.
Pros

The data is quite comprehensive and fairly up to date.
Someone else is maintaining a database of every CSS property.
The data provides a ton of metadata about each property. Generating nicely worded and informative docstring comments should be pretty straightforward.

Cons

The data is not 100% up to date.
There doesn’t seem to be a regular publishing schedule for the mdn-data NPM module (see https://github.com/mdn/data/issues/132). On our end, we could use a git submodule (😱) or some kind of curl operation (😱😱) but it’d be best if we could just use a regularly-published NPM module.
Generated types will contain a lot of anys. Most CSS properties are too complex to describe with TypeScript types. Best I can do in those cases is to add the syntax value in the docstring comment.

If you use the same API as React's style prop, most of your loose types will be number | string.  There are cases where Array would be nice, but I haven't played with the jsxstyle implementation enough to know where they are supported.  (I'm thinking about things like borderRadius = { [ 8, 0, 0, 8 ] } which would translate to 8px 0px 0px 8px).  You'll have a hard time validating string contents with TS, but I think you can be a bit more specific than any for most types.
I love the idea of leveraging canonical type definitions.

Here’s an example generated type def:
interface MDNCSSProperties {
  //...

  /**
   * Syntax: visible | hidden
   * Status: standard
   */
  backfaceVisibility?: "visible" | "hidden";

  /**
   * Syntax: [ <bg-layer> , ]* <final-bg-layer>
   * Status: standard
   * Shorthand for background-image, background-position, background-size, background-repeat, background-origin, background-clip, background-attachment, and background-color
   */
  background?: any;

  //...
}

Shorthand props are the problematic ones. For example, here’s the syntax definition for font:
[ [ <'font-style'> || <font-variant-css21> || <'font-weight'> || <'font-stretch'> ]? <'font-size'> [ / <'line-height'> ]? <'font-family'> ] | caption | icon | menu | message-box | small-caption | status-bar

Yeaaaaaaaaah that’s gonna be an any 😅
I dig array syntax for borderRadius. The main reason I haven’t pursued it is because, at the moment, style values of type object are unused (they just get stringified). There’s a whole dimension of possibility with object-type style values, but once we add meaning to an object or array value, we’ve locked down that possibility. I want to make sure we lock it down to the right thing.

Here’s the rough WIP: https://github.com/smyte/jsxstyle/commit/12f5b3e

Here’s the rough WIP commit: https://github.com/smyte/jsxstyle/commit/12f5b3e
and the generated type definitions: 12f5b3e/packages/jsxstyle/MDNCSSProperties.d.ts

Since this is CSS, I think you can safely fall back to string rather than any.  Currently, array, object, and boolean are always wrong.  number is appreciated for pixel values, but can always be represented as 16px and corrected with a future PR.
Personally, I think number should always be treated as a pixel value, which means lineHeight should accept either a number (in pixels) or a string (in line multiples).  React's inline style prop does the opposite, which leaks the abstraction and makes the style system harder to use.
(Sorry for the side tangent.)

@appsforartists yeah, number always being px would be nice (in theory, not sure in practice). A safe option would be to treat lineHeight like a unitless prop. Still need a number with props like flexGrow.

Would you be interested in spinning your mdn-data -> d.ts project into its own repo?  @kof is down to collaborate on https://github.com/cssinjs/style-type-generator.

https://www.npmjs.com/package/@types/react has been updated!


RFP - torifier

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://www.torifier.com/
Direct download URL for the software / installer : https://cutt.ly/ebfiiPz
Software summary / short description:  tunnel software applications through Tor without the need to reconfigure them

@AdmiringWorm Just looking for a point of clarification on the licensing here.  The pertinent section is:
1. You can use the software free of charge for private and professional purposes. You may
not however sell it for profit and you may not bundle Torifier in other software packages
without affirmation of the author.
2. You may offer a version of the program on a website that is free of charge for download
or you can give exact copies of the original software to anyone.
3. For any other form of publication, the author’s written permission is necessary.

My reading of this was that clause 2 would appear to support binary redistribution.
Noticing that you marked this as blocked upstream I presume that I was mistaken on this?
If you could confirm and provide a view on the thinking here it would  be appreciated.

Review on the Torifier package has been completed and the package is now available.


Stop and exceptions not triggering Terminated

A small test to demonstrate catching various terminations

Hi @cjllanwarne,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

Oops, didn't mean to open this here. Sorry!


Update mqtt to sql tutorial

We should update to use new format

Working as expected after https://github.com/infinyon/fluvio-website/pull/541


[FEAT-REQ] option for nodes to be reorderable via dragging

Is your feature request related to a problem? Please describe.
I'd like to be able to create a reorderable tree view. Moving items with drag-and-drop gestures is more intuitive for the end user than, say, using a context menu
Describe the solution you'd like
new props that can be passed to the TreeView component:

canDragNodes: boolean
onDragFinished: (oldIndex: number, newIndex: number, draggedItem: TreeNode) => void

Describe alternatives you've considered
N/A
Screenshots or screen records
N/A
Additional context
There is an implementation of a draggable flashlist here that i think could be integrated
Would you like to work on this feature?
If you wouldn't mind adding another dependency, then sure :)

@GamerGirlandCo Hey 👋!
I reviewed the draggable flashlist library, and it looks like a fantastic feature to add to the tree select library.
However, we need to be careful about how dragging a node affects its children and parent nodes. Here are a few things to consider:

Default Behavior: If the drag feature is disabled, we can fall back to the original flashlist.
Testing: We should also add appropriate test files to ensure that this new functionality works correctly and doesn't introduce any bugs.
Drag Scope: Decide whether nodes should be draggable across different parent nodes or restricted to being dragged only within the same parent.

If you’re up for adding this feature, it would be a great contribution! Looking forward to collaborating on this! 🚀


Unhide --pid-file option

Do not hide --pid-file option from the help page
Partial: #128

@yorickvP @nateraw If you have additional thoughts, I am open to how we can improve this. I've unhidden the --pid-file option with this PR, but it doesn't solve the underlying "how do we make this better".
We do use ~/.pget.pid on OS X maybe we should default to that everywhere?


mlgmp float to int conversion fix.

@dwightguth please review.
cf. https://github.com/kframework/c-semantics/issues/211

@chathhorn when you rebuild your OCAML with this, the C semantics test suite passes as well as Robby's program?

Yes, this fixes it. Note that I added that assertion in the test_suite.ml and it wasn't passing with the old version. It was clearly a bug.


[Feature Request]: Do not automatically persist chromadb.db.duckdb.PersistentDuckDB

Describe the problem
Once I've populated a collection I would like to be able to load it in a read-only fashion such that it is not auto-persisted on exit.
Describe the proposed solution
Add a flag in Settings to disable auto-persist.
Alternatives considered
Extend the class and nerf methods but I don't think this would work
Importance
nice to have
Additional Information
chromadb==0.3.25

Chroma with 0.4 has now dropped duckdb. Closing this issue.


text properties applied differently than matchaddpos

Describe the bug
Highlighting using matchaddpos() and propadd() interacts differently with syntax highlighting
To Reproduce
Detailed steps to reproduce the behavior:

Open a file and add three lines of text.
Set Search highlight group to term=reverse cterm=reverse ctermfg=3 guifg=Black guibg=Yellow
Set Cursorline highlight group  to cterm=bold,underline,nocombine ctermbg=8                    gui=bold,underline,nocombine guibg=bg
Create a property type using prop_type_add() that uses the Search highlight group.
Use matchaddpos() to highlight a position on the second line.
Use prop_add() to highlight a position on the third line.
Navigate to each line.

Expected behavior
The highlighting on the second line should be the same as the highlighting on the third line.
Screenshots

Environment (please complete the following information):

Vim version:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jan  8 2020 00:57:57)
macOS version
Included patches: 1-100
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl               -farsi             -mouse_sysmouse    -tag_old_static
+arabic            +file_in_path      +mouse_urxvt       -tag_any_white
+autocmd           +find_in_path      +mouse_xterm       -tcl
+autochdir         +float             +multi_byte        +termguicolors
-autoservername    +folding           +multi_lang        +terminal
-balloon_eval      -footer            -mzscheme          +terminfo
+balloon_eval_term +fork()            +netbeans_intg     +termresponse
-browse            +gettext           +num64             +textobjects
++builtin_terms    -hangul_input      +packages          +textprop
+byte_offset       +iconv             +path_extra        +timers
+channel           +insert_expand     +perl              +title
+cindent           +job               +persistent_undo   -toolbar
-clientserver      +jumplist          +popupwin          +user_commands
+clipboard         +keymap            +postscript        +vartabs
+cmdline_compl     +lambda            +printer           +vertsplit
+cmdline_hist      +langmap           +profile           +virtualedit
+cmdline_info      +libcall           -python            +visual

OS: macOS 10.15.2
Terminal: tmux in iTerm2

I took another look at the help file, and based on its text, I am even more confused by the answer provided
First, we have this description for text properties:
The main use for text properties is to highlight text.  This can be seen as a
replacement for syntax highlighting.  Instead of defining patterns to match
the text, the highlighting is set by a script, possibly using the output of an
external parser.  This only needs to be done once, not every time when

And then there's the combine attribute on text properties:
"combine"	when omitted or TRUE the text property highlighting is
       		combined with any syntax highlighting; when FALSE the
         	text property highlighting replaces the syntax
	        highlighting

And finally, this statement from the documentation for matchadd():
Syntax highlighting (see 'syntax') is a separate mechanism, and regardless of the chosen priority a match will always overrule syntax highlighting.

Based on those three pieces of information, I would expect that setting combine: 0 on the text property would cause the highlighting for the text property to behave as it would for matches, but I've tried that without success.
🤔


Pass arbitrary data to pre/body/post

It's possible to pass a scalar to the body function, but is there any way of passing arbitrary data to the functions? (arg type=object?) I've encountered a couple cases where this would be convenient and, I believe, valid:

Passing a function to cwise. Think of an image processing function. Unless body implements the function or the function is defined in the containing scope (which isn't always possible if you don't know the function ahead of time, right?), it's not immediately clear how to pass this.
More questionable uses. I'm currently trying to write a axis-wise function that computes the mean across a number of axes. This can be accomplished with transpose + blockIndices + map-reduce, but it's not clear how to pass the data in/out.

Long story short, here are the two possibilities:

add an object type for passing arbitrary stuff that's useful
this isn't really what cwise is for and would defeat the purpose of the useful optimizations it provides

You can pass objects and functions into the scalar type.  The name scalar was chosen because it wasn't an array, so I can understand the confusion.  Take a look at ndarray-warp:
https://github.com/scijs/ndarray-warp

Ah, great. I can submit a PR with this clarification. Thought this might be the case but figured it was worth clarifying whether it was more than an accidental if so.

cc: @thibauts since it seemed like you might have been working with a similar use-case…

I had exactly the same question. Might be worthwhile to put the information in the relevant README section so people don't miss it, or alias scalar with something like object that's generic enough for people to feel confident passing functions or arbitrary stuff.


fix app n1

PR Status

[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme

!testme

!testle

!testme

!testme

!testme

!testme

!testme

!testme


Update version links in guide

Noticed in https://github.com/kubernetes-sigs/gateway-api/issues/1543, this updates some links to versions that got left behind in recent releases and updates the RELEASE.md instructions so they wont be left behind in the future.

/test all

Thanks!
/lgtm


Remove the dependency on async-lock

This PR removes the need for async-lock as a dependency by making the Executor initializable in a const context. This relies on the const initialization of CondVars and Mutexes, so the MSRV was bumped to 1.68.
This MSRV bump may not be acceptable, so either this PR must wait, or an alternative queue implementation needs to be chosen.

This relies on the const initialization of CondVars and Mutexes, so the MSRV was bumped to 1.68.

(const Mutex::new and const Condvar::new are available since 1.63. That actually requires 1.68 is const VecDeque::new)

Found a way to lower the MSRV to 1.63 by using Option<VecDeque<T>> instead. This shouldn't need extra branches due to the niche layout optimization of VecDeque and Option.


Update  link for Telework section 8: Occupational Health and Safety - Working Alone call-in procedures

Link as was updated when employee reported the issue. The changes were made in both test and dev and are ready for push to prod.

Here is the link that was updated.
https://www2.gov.bc.ca/gov/content/careers-myhr/all-employees/work-arrangements/flexible-workplaces/flexible-work-readiness-reflection-and-discussion/safety-inspection#call-in-procedures

Link successfully updated!

Link works great thanks - ready to deploy

Fabulous work @chriscaldwell-psa Link works great - closing tix


Better BibTeX changed the real attachment file name specified in Zotero (BibTeX)

When we export an entry in zotero to a .bib file, Better BibTeX replaces Double Byte Characters of the entry's attachment file name with Single Byte Characters.
That is ：， in a  zotero attachment file name 流动性与资产定价：基于我国股市资产换手率与预期收益的实证研究.pdf is replaced by :,, now attachment file name in .bib file is 流动性与资产定价:基于我国股市资产换手率与预期收益的实证研究.pdf, and if we try to open the attachment file given by the result .bib file, Jabref reports an error of file cannot be found...
Debug ID is same to the one in Issues #657: 33SNMU9D.

See #657.


Feature request: Download as EPUB

Description
EPUB is a document file format that is HTML in a zip container. All attachments of said EPUB, such as images are also included in the zip container.
(Optional:) Please add any files, screenshots, or other information here.
EPUB specification: https://www.w3.org/TR/epub-33/
(Required) What is this issue most closely related to? Select one.
Other
Internal issue ID

Paper URL
all older papers
Browser
not relevant
Device Type
not relevant

@erkinalp Could you share a little about how you would use an ePub version of arXiv in your personal work? It is interesting to understand better the non-web uses you may have in mind.

Mockup:


TMX file extension unknown

TMX is a fairly well know schema of XML. It would be nice if this were a known extension for LINDAT.
c.f. http://hdl.handle.net/11356/1049

Closing this one in favor of #378
Offering a quick resolution: Under administration > Registries > Format, you  can create these extension mappings for your repository

Did it. It didn't show up, but after adding it to the file bitstream, http://hdl.handle.net/11356/1049 looks just great, thank you!


Dynamic page name (title)

How difficult to show queue name (or custom passed name) on top of page ?
This is for case when Agendash used to show jobs from multiple collections.

To better preserve compatibility for those already using agendash, I would say the usage would be like this for no extra options:
var agenda = new Agenda({mongo: 'mongodb://<IP_ADDRESS>/agendaDb'});
app.use('/agendash', Agendash(agenda));

and like this for additional options:
var agendaMessaging = new Agenda({
  db: {
    address: mongoConnectionString,
    collection: 'messageJobs'
  }
});

var agendaCampaign = new Agenda({
  db: {
    address: mongoConnectionString,
    collection: 'campaignJobs'
  }
});

app.use('/messaging', Agendash({
  title: 'Messaging',
  agenda: agendaMessaging
}));
app.use('/campaigns', Agendash({
  title: 'Campaign',
  agenda: agendaCampaign
}));

The agendash lib would need to figure out if the argument is an Agenda or an object containing an Agenda. Then the api route would need to return the title so that the front-end can display it (index.html and main.js are both static files, I don't want to have to render them server-side). It shouldn't be very difficult, the trick is checking if the argument is typeof Agenda, which is actually tricky if agendash's Agenda dependency is different from your app's Agenda dependency, they won't be the same type.

An easier approach would have the additional-options usage look like this:
var agendaMessaging = new Agenda({
  db: {
    address: mongoConnectionString,
    collection: 'messageJobs'
  }
});

var agendaCampaign = new Agenda({
  db: {
    address: mongoConnectionString,
    collection: 'campaignJobs'
  }
});

app.use('/messaging', Agendash(agendaMessaging, {
  title: 'Messaging'
}));
app.use('/campaigns', Agendash(agendaCampaign, {
  title: 'Campaign'
}));

I think I prefer this one.

Agree with proposed solution to pass title as option object which can be extended in future.
Node part its easy for me but Backbone little challenge ;)

PR created https://github.com/joeframbach/agendash/pull/10

What timing! I have one too... https://github.com/joeframbach/agendash/pull/11


Ghost text: Show on command driven selections

Description
We primarily disabled the ghost text in this scenario because command driven selections were quite common, especially when searching text in VS Code - we wanted to avoid spamming the user.
However, we now only show the ghost text when:

There is a multiple line selection
There is a single line selection but all non-whitespace characters from this line are selected.

Those restrictions mean that we can re-enable the command driven selections without worrying about it spamming the user too much.
This fixes an issue where Vim keybindings would not trigger the ghost text.
Test plan
With Vim:

Enable the vscodevim.vim extension
Select multiple lines
Check the ghost text shows

With search:

Search for a single symbol that isn't the only text on a line
Check ghost text doesn't show

Confirmed this is working as expected with vim mode

The decorations are still missing with columnSelection: true. It might be worth a separate PR to at least log when this setting is enabled so we can make a decision if it's worth adding custom support for it.


Redirect broken link for HTTPS outcalls

I recently came across this broken link in a Google search related to HTTPS outcalls:
https://internetcomputer.org/docs/current/developer-docs/integrations/http_requests/http_requests-how-it-works
This PR adds a redirect to the following page:
https://internetcomputer.org/docs/current/developer-docs/integrations/https-outcalls/https-outcalls-how-it-works

Thanks for this @rvanasa


feat: add venus api header

关联的Issues (Related Issues)

ref https://github.com/filecoin-project/venus/issues/5561
改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[ ] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[ ] 具有清晰明确的commit message / All commits have a clear commit message.
[ ] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[ ] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #185 (4ecc519) into master (f70d19c) will increase coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 66.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   44.79%   44.80%   +0.01%
==========================================
  Files          40       40
  Lines        4391     4392       +1
==========================================
+ Hits         1967     1968       +1
  Misses       2199     2199
  Partials      225      225

Flag
Coverage Δ

unittests
44.80% <66.66%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

cli/token.go
0.00% <0.00%> (ø)

core/const.go
62.85% <ø> (ø)

jwtclient/auth_client.go
62.56% <100.00%> (+0.09%)
:arrow_up:


[QE] Wrong base images for e2e and integration container images

The builder image used on the e2e and integration Dockerfiles does not exists, as so when trying to build them we got an error like:
CRC_E2E_IMG_VERSION=v2.29.0-dev make containerized_e2e
rm -rf /home/ariobolo/01WORKSPACE/04SOURCE/github/crc/docs/build
rm -f packaging/darwin/Distribution
rm -f packaging/darwin/Resources/welcome.html
rm -f packaging/darwin/scripts/postinstall
rm -rf packaging/darwin/root-crc/
rm -rf packaging/darwin/root-crc-tray/
rm -rf packaging/windows/msi
rm -f out/linux-amd64/split
rm -f packaging/rpm/crc.spec images/rpmbuild/Containerfile
rm -rf out
rm -f /home/ariobolo/go/bin/crc
rm -rf release
podman build -t quay.io/crcont/crc-e2e:v2.29.0-dev -f images/build-e2e/Dockerfile .
[1/2] STEP 1/5: FROM registry.access.redhat.com/ubi8/go-toolset:1.20 AS builder
Trying to pull registry.access.redhat.com/ubi8/go-toolset:1.20...
Error: error creating build container: initializing source docker://registry.access.redhat.com/ubi8/go-toolset:1.20: reading manifest 1.20 in registry.access.redhat.com/ubi8/go-toolset: manifest unknown: manifest unknown
make: *** [Makefile:199: containerized_e2e] Error 125

I tried adding a make container-images target to the Makefile which could be part of make check. This works, but is very slow, so I'm not sure it's desirable as part of make check which already takes quite some time :-/

Yeah another option would be have an specific check goal for building the images and then only run it as a checker if PRs has some specific labeling (like oci-images), that label will be added just in case the PR change something on them .
But maybe it is not worthwhile to add all this just for those images, as I am checking them multiple times along the sprint

Fixed by https://github.com/crc-org/crc/commit/1f072afd072774d921f8b9b8728dbef5b4b6f6fc


Add encoding property for zip task

@bigdaz New PR for #405

Thanks @AlphaHinex. Looks pretty good. I just made a few suggestions for (minor) improvements to the test coverage. After that, we should be good to merge.

The travis-ci build is failing due to an unused import, and I've reiterated a comment about the need for a separate test for using an encoding that doesn't support the input file names.
Once that's done we'll be ready to merge.

Thanks @AlphaHinex. This has been merged into master, and will be in Gradle 2.8 (just missed the cut for 2.7, unfortunately).
I was thinking that it would be good to have similar support for the Tar task: are you interested in contributing that as well?

Thanks @bigdaz and I will try to do it


Footer added to Testimonial page

Title of the Pull Request

[x] Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #<926>
Description

There was no footer present on the testimonial page.
I have added the footer now .
How Has This Been Tested? ⚙

This has been by simply opening the testimonial page or by navigating from home page to testimonial page.
Screenshots 📷

After

Type of change
What sort of changes have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Checklist

[x] My code follows the code style of this project.
[x] I have followed the contribution guidelines
[x] I have performed a self-review of my own code.
[x] I have ensured my changes don't generate any new warnings or errors.
[ ] I have updated the documentation (if necessary).
[x] I have resolved all merge conflicts.

@vishanurag Please merge this request.

The footer is already added


Considering Storing Images for weather display in flash memory

avr/pgmsoace.h // using PROGMEM Library  to store in Flash

Done !


[BUG] Douyin api error

douyin api doesn't work anymore, I changed the cookies and it only worked for a few hours, then had to get it again. Cookies taken from chrome's devtool

Fixed


Improve landing page UI (colour scheme and font)

Improve the general landing page UI (colour scheme and font)

Can I be assigned this?

@iamifechi
Go ahead


View inside the stickyheader in not wotking?

I love your library but I inside the header has no state, I have some button to listen the click event.

See #55, it's not really possible with this implementation.