Deprecated - Static files embed library

Summary
From https://github.com/argoproj/argo-workflows/pull/11644 , lib for embed static files https://github.com/bouk/staticfiles is deprecated now. It should be replaced with Go standard library
Use Cases

maintainable code

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

As an example for anyone looking to take this on, Argo CD has a tiny embed.go file in the ui/ directory with the go:embed directive


feat(middleware): accept partial methods

Summary
This PR allows middlewares to have partial methods. A middleware had to contain all of subscribe, unsubscribe, onStateChange methods, which isn't necessary.
Result
It works the same as before except that the following is possible now:
search.use(() => ({
  onStateChange({ uiState }) {
    // ...
  }
});

I think this makes sense, but I remember that @francoischalifour originally wanted middlewares to not have optional keys. I wonder if this has changed?

The original reason was that going from optional to required is a breaking change, while going the opposite isn't.
Besides, I tend to avoid fully optional structures—now a middleware can be an empty object.

The original reason was that going from optional to required is a breaking change, while going the opposite isn't.
→ makes sense

Besides, I tend to avoid fully optional structures—now a middleware can be an empty object.
→ do we want to avoid it?

@francoischalifour

→ do we want to avoid it?

That's not easy to answer. It'll add overhead to both our code and the middleware usage with conditional requirements. We have the same problem with the widget definition where nothing is required, but you still have to provide either init or render. You can't type-check that. That's why I don't think that this PR is necessary personally.

That's not easy to answer. It'll add overhead to both our code and the middleware usage with conditional requirements. We have the same problem with the widget definition where nothing is required, but you still have to provide either init or render. You can't type-check that. That's why I don't think that this PR is necessary personally.

This PR adds noop upfront, so I don't see it as an overhead. We can show a warning message if it's an empty object. And if we want, we can do it like this, although it's not the cleanest.

https://www.typescriptlang.org/play?#code/C4TwDgpgBAsglgEwQGwgdwIYCcIBEIBmcAdnMHAPbFQC8UA3gFBRRUDKwGwEAwgBYZiAcwgAKCmHJUAzgC4ogkAEp5ANwqIA3MyjSArgCNpAYyxwDYlVHVade4vqOnzltRoTaAvtsahIUAEFgABkIDGlgAHliCAAeABUAGigAVVoGAG0AaSgSKABrCBAKAih4gF15AAU4Y3yE5KyAPihPFroq7HIMZASWgDJUjMLi0pTyxl9waE6sbuR4JGRMHHwiUilqOiDQ8KiY2MWUdGw8QhIySmImyeMZYAVqrrgeo+XTtYvN9PpvW-uoAYnnMXgtECgVmd1pcqD8dI4TGYLKIlAxWoxPP8HA9jMD5m9IZ8Nlc4Sx7AjnMjUfR0ZjGHdsVAEHjQQSPudibC6EwWOxONx+IIRCi0Zi6QyIlAICzXuD3qsOTCtgx4YZES4RTTPIk7A41ZTLKKdbziBwuLwBMJDVqMUA is another option to allow partial but not empty objects (source: https://stackoverflow.com/a/48244432/3185307)

https://www.typescriptlang.org/play?#code/C4TwDgpgBAsglgEwQGwgdwIYCcIBEIBmcAdnMHAPbFQC8UA3gFBRRUDKwGwEAwgBYZiAcwgAKCmHJUAzgC4ogkAEp5ANwqIA3MyjSArgCNpAYyxwDYlVHVade4vqOnzltRoTaAvtsahIUAEFgABkIDGlgAHliCAAeABUAGigAVVoGAG0AaSgSKABrCBAKAih4gF15AAU4Y3yE5KyAPihPFroq7HIMZASWgDJUjMLi0pTyxl9waE6sbuR4JGRMHHwiUilqOiDQ8KiY2MWUdGw8QhIySmImyeMZYAVqrrgeo+XTtYvN9PpvW-uoAYnnMXgtECgVmd1pcqD8dI4TGYLKIlAxWoxPP8HA9jMD5m9IZ8Nlc4Sx7AjnMjUfR0ZjGHdsVAEHjQQSPudibC6EwWOxONx+IIRCi0Zi6QyIlAICzXuD3qsOTCtgx4YZES4RTTPIk7A41ZTLKKdbziBwuLwBMJDVqMUA is another option to allow partial but not empty objects (source: https://stackoverflow.com/a/48244432/3185307)

That's a nice way!

I personally think with the "at least one", the downside of empty objects is alleviated, as well as it being instantiated with noops, so no new conditions need to be added. However we need to have a consensus on this as a team

What do you mean by "no new conditions"?

conditions when using middleware, as it was needed in the initial version of the pr


HTTPS automatic redirect

Hi,
i'm using the new TLS feature on 2 of our domains, is it possibile to disable automatic redirect from HTTP to HTTPS?
Thank you.

+1

+1

Yes, how are you using it? (nginx or GCE controller, and what does your Ingress look like?). HTTPS should be the default but there should be an opt-out.

Is this the same as https://github.com/kubernetes/contrib/issues/782 ?

No it isn't the same.
I configured nginx controller with ingress TLS rules. But now every request i make to http://domain is redirected to https://domain. Can i disable automatic redirection without editing default nginx.tmpl provided with 0.5 version?
Thank you.

There are 3 modes for https:

both https and http
redirect http to https
block http

The third is the least important, I think we shold allow at least 1, 2 through an annotation. @aledbf thoughts?

@bprashanth the default behavior in the nginx controller is 2. In #766  is possible to use force-hsts=false to disable the redirect. The third mode is included when force-hsts=true (default)

Is this fixed with a new container built with it?
I am using gcr.io/google_containers/nginx-ingress-controller:0.6 and this does not work.

@sekka1 please check with the last version gcr.io/google_containers/nginx-ingress-controller:0.61

assuming this is fixed in 0.61


Replace collection length checks for compatibility

Fixes: https://github.com/RicoSuter/NSwag/issues/4672
Repro: https://github.com/jake-carpenter/nswag-4672-repro
Cause: https://github.com/RicoSuter/NSwag/pull/4586/commits/961cb7b28fe97994ece7d0ff05cec090d4127fb4#diff-416f8759e9ce0cecba7578a64bf1fc4b9fee9325d331641eaf7b07d62e7455bb

Using the Length property assumes the collection will be a C# array, but that is based on the parameterArrayType setting for the C# client generator. By default, IEnumerable is used and the majority of other collection types won't accept Length.
For now, this fix utilizes the LINQ Count(), which theoretically should check for Length or Count properties on it's own before enumerating. This seems like it is still an improvement to the enumeration that was present before the linked changeset. I'm open to solving this a different way if there are ways to access the C# type during generation.
There are likely other templates where this is also a problem, but this fix is focused on path parameter generation.

Build failures seem to be based on new mac images with .NET 6 not installed, which is probably not something I should address with code here.

Hello
This works fine only if "Parameter Type" for "Generic Array Type" is set to IEnumerable, however if it set to ICollection it will fail.


Allow customize max top navigation width

There before cannot set a specific width for the top navigation width.

[x] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Before:

After implement: ->maxTopNavigationWidth('7xl')

Thanks for opening a PR, @datlechin!
Since this can be achieved by simply applying the Tailwind classes to the filament-main-topbar CSS hook, I don't think this warrants a dedicated API.
Also, the design may be different for other themes, which may or may not support variable widths.

@zepfietje This filament-main-topbar CSS hook doesn't exists anymore in the latest version.

fi-topbar


securepubads.g.doubleclick.net

@funilrys
I'm starting to see several DNS records on my list suddenly inactive.  The most popular I see is
securepubads.g.doubleclick.net marked INACTIVE.  Is something really happening recently?  Being Google and one of those popular records anyone has seen, it seems weird that it would be INACTIVE.
Attached my most recently list of INACTIVE dns records.  If you scan these do these all look down to you as well?  Thanks
hosts.txt

Hi @jawz101 sorry for the delay and thanks for the feedback.
As of today, it's distributed as ACTIVE https://github.com/dead-hosts/hosts_web_mvps.org/blob/ac8e22ced88a1673fa10b92117f71b1beb7340ae/clean.list#L8150
I did not change the code for the last 15-18 days. So I suppose it's probably because of the SPECIAL rule.
I'll delete the doubleclick rule for the good sake of the world. For the follow-up ==> https://github.com/funilrys/PyFunceble/issues/71
Sorry for the inconvenience and thanks again for the feedback.
Cheers!

Thanks.  It just threw me off


EX-Rail parsers

Description
When a parser receives an EXRail response
I want to parse the response into usable elements
so that I can perform other tasks with the information
Design
EX-Rail responses are not documented
Notes
N/A

The features that need adding to WebThrottle are:

Turnout control with a separate screen (swipe left?)
Routes
Automation
DriveAway
Built-in decoder diagnostics (D ACK Commands)
Button to Read the Loco ID on the programming track
Button to set the loco ID on the programming track
Walk-Through screen for WiFi Config (reset, fill in SSID, etc. and send the AT commands)
Accessory address converter (enter linear or 2 part address and calculate the other)
Can we mirror controls where a phone throttle and WebThrottle change the same loco?
Multiple loco control with roster images and loco specific function keys.
WiFi option to connect and use WiThrottle or (and?) <DCC++> Commands

The list got long as I started going through the mental list. The priorities are turnouts and ex-rail. We can make sure we have issues for each of the features we need to get to later. I've asked Chris and others to contribute to the features and their implementation, so you can have a clear direction to make coding simpler.
We can look to JMRI and Engine Driver for ideas on implementation.

Thanks @FrightRisk, I'm really looking for some documentation on the EX-Rail responses (data coming from the command station)
With this information I can build a parser to convert the responses to usable data.

https://dcc-ex.com/throttles/tech-reference.html#automations-routes

https://dcc-ex.com/automation/EX-RAIL-summary.html#command-summary


Investigate failed Sonarqube builds

DEVOPS PULL REQUEST
Related Issue

See Issue for this PR here
Sonarcube seems to be intermittently failing to build in CI jobs. See examples here and here

Changes Proposed

Added the sonar.java.binaries property and provided the value backend/build/classes/java/main which is the full path to the java classes

Testing

See successful Github Action for sonar step to verify no longer failing
A smoke test of basic functionality should be accomplished before merging.
This PR has been verified on dev2

I rebased from master to fix the out of sync terraform provider version

Moving to a new PR so that the merge will be cleaner. No further actions


document data loaders' cwd and import.meta.url

it's possible that the example code might be too much or too convoluted… we can edit it down if it's not salvageable, and do a real-life complete example instead
closes #853

Do you think it would be easier to understand if the cwd were the data loader’s own directory?

I guess it depends where we expect "supporting files" to be saved. I'd say that it feels a bit more natural to have them in docs/ if they are data, but I haven't thought about all the use cases. If your supporting files are in node_modules the current system makes more sense.


Creating a logo for the website.

I can create logo for this website kinldy assign this task to me

can you guys work together on this??

np at my end

I CAN WORK ON THIS... CAN U ASSIGN IT TO ME

Untitled design.zip
check these!!! @1Shubham7

not good.

wife (1).zip
how about these?

@1Shubham7 hey shubham , let me design the logo for this unique website.  Please assign this issue to me.

These are not professional design, sorry.


The port is busy. Connection LimeRFE + LimeSDR

Issue Description
Hello everyone. I would like to run srsRAN on LimeSDR v1.4s using LimeRFE amplifier. How to do it?
I use this documentation. When I use LimeSuite GUI, following the instructions, the ports open.

LimeSDR
INFO: Disconnected control port
INFO: Reference clock 30.72 MHz
INFO: Connected Control port: LimeSDR-USB FW:4 HW:4 Protocol:1 GW:2.23 Ref Clk: 30.72 MHz

LimeRFE
Port opened
Firmware version: 1
Hardware version: 0x10

But since the device is already busy, I can not be able to connect srsRAN.

srsRAN
[ERROR] Cannot claim interface - Resource busy
[ERROR] Failed to open device
[ERROR] connection is not open
[ERROR] TransferPacket: Write failed (ret=0)
[ERROR] connection is not open
[ERROR] TransferPacket: Write failed (ret=0)
[ERROR] Failed to open. Device is busy.
Failed to create Soapy object
Error initializing radio.

Technology stack
Ubuntu 22.04 (Intel® Core™ i7-7700 CPU @ 3.60GHz × 8)
srsRAN 22.04 (open5gs)
LimeSDR v1.4s (LimeSuite v20.10.0, SoapySDR 0.7.2)
LimeRFE 1v31

Don't use LimeSuiteGUI to open the LimeSDR and instead just use this to connect to the LimeRFE and configure it. That way the SDR will be free for srsRAN to open.


add crate_authors! macro

Once https://github.com/rust-lang/cargo/pull/2465 lands it would be useful to have a crate_authors! macro to complement the crate_version! macro (fetch authors from cargo).
It's a pretty small change.
https://github.com/kbknapp/clap-rs/compare/master...rtaycher:add_authors_macro
But it won't work on old cargo binaries.
Should I put this behind feature flags(at first)?

Awesome idea! I'm ok with not using feature flags, so long as the minimal version of cargo for this macro is annotated in the documentation. Thanks :+1:

Since the environment variable is new, we could provide two versions of macros: One is just using env! (which will emit compilation error if the environment variable is not found), and other using option_env! and let user provide default authors if the environment variable is not found.

I thought about using option_env! instead but then you get something that will need to be deprecated or be awkward later on.
Also to clarify technically it's newer then new, it hasn't been merged yet though I think it will be soon. I was thinking about adding a feature flag then dropping the flag after a year.

@rtaycher I guess it can get awkward after a while.
Once the pr is merged, can you amend the commit messages to follow the contribution guideline and make a pull request?

So yeah let's us a feature flag until it's in stable Rust. Whether that's the unstable flag or another one devoted to just this feature is the same to me.

I find it funny, it's exactly for this use case that I proposed that change on rust/cargo :smile:


CI improvements + Python 2.7 Compatibility

This PR closes #7

[x] Allow CircleCI to run builds for PRs from folks
[x] Update docker image to continuumio/miniconda:latest
[x] Add CircleCI, Codecov badges

@kmpaul, tests are now running on CircleCI. However, dask_mpi/tests/test_core.py seems to be hanging (https://circleci.com/gh/dask/dask-mpi/9). Do you happen to know the reason behind this issue?

@kmpaul, tests are failing on both 2.7 and 3.6. To make sure that this PR does not diverge from its original purpose (CI improvements), I am going to look into the test failure in a separate PR.

Sounds good.  You will need to modify the tests to clone the master branch of distributed and pip install -e ../path/to/distributed in order for this code to work.

Make sure you add a step to clone the latest master branch of distributed before the tests run.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@de64252). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   93.54%
=========================================
  Files             ?        4
  Lines             ?      124
  Branches          ?        0
=========================================
  Hits              ?      116
  Misses            ?        8
  Partials          ?        0

Impacted Files
Coverage Δ

dask_mpi/cli.py
96.87% <100%> (ø)

dask_mpi/core.py
100% <100%> (ø)

dask_mpi/common.py
86.27% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de64252...4bf34b4. Read the comment docs.


Fix organization field being null in POST /orgs/{orgid}/teams

Similarly to the fix in https://github.com/go-gitea/gitea/pull/24694, this addresses the team creation not returning the organization information in the response.
This fix is connected to the issue discovered in the terraform provider.
Moreover, the documentation suggests that the response body should include the organization field (currently being null).

I was unable to create a backport for 1.21. @memphis88, please send one manually. :tea:
go run ./contrib/backport 27150
...  // fix git conflicts if any
go run ./contrib/backport --continue


Usage in addon's dummy app

@kybishop Thank you! In theory I think Yarn is working with Node 4 again, so merging this might even get the build out of an error state 🙂


fix: generator settings disappear

Hi, thanks for great service.
I use @vegardit/prisma-generator-nestjs-dto, and write schema like below.
generator nestjsDto {
  provider      = "prisma-generator-nestjs-dto"
  entityPrefix  = "Entity"
}

But after using this tool, The data is changed as
generator nestjsDto {
    provider      = "prisma-generator-nestjs-dto"
    binaryTargets = ["rhel-openssl-1.0.x", "rhel-openssl-1.0.x"]
}

Is there any way to hold my nestjsDto?

will fix that soon, thanks for reporting! @MOhhh-ok


Move util.ChunkPosDistanceLevelPropagator to world package

Now, we have LevelPropagator and SectionDistanceLevelPropagator in net/minecraft/world/chunk and net/minecraft/util packages. We should look into grouping them into more similar packages. Since @runemoro named them, I will leave this to him.

It would be nice if everything could be in net.minecraft.util since they're used for things like points of interest and chunk loading, but Mojang is using a package-private method from LevelPropagator in net.minecraft.world.chunk!

Now SectionDistanceLevelPropagator is moved to world package but ChunkPosDistanceLevelPropagator is still in util.

Can be fixed by #1235


Reproducing 21409  CVE-2017-8392

Hi,
I recently started using AFLGO. I successfully set up LLVM 4.0 and could actually fuzz libxml2 by following the steps in the repo. Next, I was trying to fuzz some programs for provided CVEs in the paper. Specifically, I gave a shot to this bug which you listed in the paper.
Although compilation goes well (i.e. no error, objdump binary is generated with AFLGO's afl-clang), I get the following error when trying to generate distances:
"Couldn't find any binaries in folder /root/aflgo/experiments/objdump/binutils-gdb"
For a reason,  bc files are not generated during compilation. I am attaching the full script that will hopefully help you reproduce the error on your side on a Ubuntu 18.04 with llvm 4.0 installed. I also added the log file that contains all output when I run the attached script.  I will appreciate any guidance to help me identify the problem.
Thanks,
Sadullah
log-script.zip

Hi Sadullah,
I've created a script to reproduce CVE-2017-8392 (based on our script of reproducing CVE-2016-4487 of cxxfilt Binutils) as follows:
git clone git://sourceware.org/git/binutils-gdb.git CVE-2017-8392
cd CVE-2017-8392; git checkout a6c21d4a553de184562fd8409a5bcd3f2cc2561a
mkdir obj-aflgo; mkdir obj-aflgo/temp
export SUBJECT=$PWD; export TMP_DIR=$PWD/obj-aflgo/temp
export CC=$AFLGO/afl-clang-fast; export CXX=$AFLGO/afl-clang-fast++
export LDFLAGS=-lpthread
export ADDITIONAL="-targets=$TMP_DIR/BBtargets.txt -outdir=$TMP_DIR -flto -fuse-ld=gold -Wl,-plugin-opt=save-temps"
echo $'dwarf2.c:4212\nelf.c:8642\nobjdump.c:1486\nobjdump.c:1791\nobjdump.c:2304\nsection.c:1395\nobjdump.c:2438\nobjdump.c:3532\nobjdump.c:3589\nobjdump.c:3678\nobjdump.c:3699\nobjdump.c:4001\nlibc-start.c:287' > $TMP_DIR/BBtargets.txt
cd obj-aflgo; CFLAGS="-DFORTIFY_SOURCE=2 -fstack-protector-all -fno-omit-frame-pointer -g -Wno-error $ADDITIONAL" LDFLAGS="-ldl -lutil" ../configure --disable-shared --disable-gdb --disable-libdecnumber --disable-readline --disable-sim --disable-ld
make clean; make
cat $TMP_DIR/BBnames.txt | rev | cut -d: -f2- | rev | sort | uniq > $TMP_DIR/BBnames2.txt && mv $TMP_DIR/BBnames2.txt $TMP_DIR/BBnames.txt
cat $TMP_DIR/BBcalls.txt | sort | uniq > $TMP_DIR/BBcalls2.txt && mv $TMP_DIR/BBcalls2.txt $TMP_DIR/BBcalls.txt
cd binutils; $AFLGO/scripts/genDistance.sh $SUBJECT $TMP_DIR objdump -SD @@
cd ../../; mkdir obj-dist; cd obj-dist; # work around because cannot run make distclean
CFLAGS="-DFORTIFY_SOURCE=2 -fstack-protector-all -fno-omit-frame-pointer -g -Wno-error -distance=$TMP_DIR/distance.cfg.txt" LDFLAGS="-ldl -lutil" ../configure --disable-shared --disable-gdb --disable-libdecnumber --disable-readline --disable-sim --disable-ld
make
mkdir in; echo "" > in/in
$AFLGO/afl-fuzz -m none -z exp -c 45m -i in -o out binutils/objdump -SD @@

I run it and obtained the distance files after 1 hour. Note that I use Ubuntu 16.04 and LLVM 4.0, so hopefully you can run this script on your side.
Best. MD

Hi @strongcourage
Thank you for your quick reply. I will try it sometimes today and let you know if I can generate on my side.

Hi @strongcourage,
I tried your script and successfully obtained the distance files. I could also start the fuzzing the objdump without any issue.
I have one follow-up question, though. How did you obtain the targets? In your script, it is manually specified but that would be good to know the commits that result in these targets. I tried to find the commit that introduced this bug but it was not really succesful since the bug looks like to exist for at least 8 years.

Glad to hear that. In this case, you would like to reproduce the bug that has been reported (by me) here. Basically, you can manually extract the targets from the bug report of ASAN or write a simple script to do so. In other application like fuzzing recent code changes, there is a solution to automatically generate BBtargets.txt as discussed in the libxml2 example.
Best. MD

Thank you for the suggestion. You can close the issue now given that I could fuzz the objdump using your script.

I try to add more fuzzing scripts to reproduce the bugs used in our evaluation here. Please feel free to make pull requests. Thanks.


More buttons pluse styling

Seems to be some merge conflicts. If you have time to fix it I'll happily merge :)

i fixed them

Great work thanks 👍


ssh-find-agent fails in bash 4

@$ ssh-find-agent
export SSH_AUTH_SOCK=/tmp/ssh-rD6vrogm86Tj/agent.6340   #1)     /Users/snappy/.ssh/malehman.pem (RSA)

see if someone else's fork fixed this.


cherry-pick fixes to release/v0.6 branch (1.10.2 candidates)

Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

LGTM


Alternative module

Hi @michelsteege,  I don't know if you would be interested but I have made a similar module.  https://github.com/gorriecoe/silverstripe-menu.  It allows nestable and flat menus.  MenuLinks extends https://github.com/gorriecoe/silverstripe-link to provide plenty of options.

Hi @gorriecoe It looks like a great module but i created this module for a project where we need full control over the code but maybe for a next project! Thanks for the links 👍

All good.


Add LF Edge reference in docs footer

Description
Add LF Edge ref to the footer on the docs site
Fixes #525
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings
[x] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[x] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@joewxboy

Fixed


String literal highlight issue with a preceding new line

Description:

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
function base16Test() {
    byte[] a = base16
    `aa ab cc ad af df 1a d2 f3 a4`;
    string b = string
    `aaab ccad afcd 1a4b abcd 12df 345d`;
    xml x1 = xml
    `<book>The Lost World</book>`;
}

Related Issues:

Moved to https://github.com/wso2/ballerina-plugin-vscode/issues/39


Features/256 add package with device detection using ua parser

This PR fixes #256 .
Implementation of IBankIdSupportedDeviceDetector based on uap-csharp for better detection of third party browsers.

Updated readme file and changed the sample projects to use the new uaparser.


Localstorage

Description
Introduced a localstorage binding that allows you to read/write from the local file system. Currently this only works in self-hosted mode as there currently isn't a way to mount a volume in the dapr sidecar.
Issue reference
#752
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@mukundansundar, can you have a look at this failing conformance test? Not sure what's going on here... Thanks!

@lynn-orrell Mounting a volume is outside the scope of Dapr. But, there is nothing stopping it from being mounted by the app operator. So, I think this can still be used in K8s.

@lynn-orrell Can you add docs for this Component ?


Deploy an Azure Virtual Machine with Windows Server & Microsoft SQL Server failing

Hello All,
Thank you for all the Jumpstart scenarios, I am facing an issue with the Deploy an Azure Virtual Machine with Windows Server & Microsoft SQL Server and connect it to Azure Arc using Terraform after the recent update to the script, please advice
I have already supplied the same in the Paramaters.json file
"logAnalayticsWorkspaceName": {
  "value": "LAW4mdfc"
},

Issue
Please provide string value for 'logAnalyticsWorkspaceName' (? for help): "LAW4mdfc"
{"code": "InvalidTemplate", "message": "Deployment template validation failed: 'The template parameters 'logAnalayticsWorkspaceName' in the parameters file are not valid; they are not present in the original template and can therefore not be provided at deployment time. The only supported parameters for this template are 'vmName, adminUsername, adminPassword, myIpAddress, windowsOSVersion, vmSize, servicePrincipalAppId, servicePrincipalSecret, servicePrincipalTenantId, virtualNetworkName, subnetName, networkSecurityGroupName, logAnalyticsWorkspaceName, resourceTags, githubAccount, githubBranch, deployBastion, bastionHostName'. Please see https://aka.ms/arm-deploy/#parameter-file for usage details.'.", "additionalInfo": [{"type": "TemplateViolation", "info": {"lineNumber": 0, "linePosition": 0, "path": ""}}]}
Please can you advice for the same

I was able to fix it, the Parameters files has incorrect spelling for LogAnalyticsWorkspace
This caused the issue - "logAnalayticsWorkspaceName": {
The Correct should be - logAnalyticsWorkspaceName

Hi @WVDAdminTF, can you please help me understand what scenario or flavor of ArcBox you're deploying when you came across this error?

Hi @WVDAdminTF, can you please help me understand which Jumpstart scenario or flavor of ArcBox you're deploying when you came across this error?

This one - https://azurearcjumpstart.io/azure_arc_jumpstart/azure_arc_sqlsrv/azure/azure_arm_template_winsrv/
The Parameter file has incorrect spelling for logAnalyticsWorkspaceName which cause the deployment to fail


background-position offsets

First of all – great job on spritesmith! I totally dig it, and currently I’m rewriting our current compass-generated sprites to use grunt-spritesmith instead.
I’m still a bit confused about position overrides.
I'm struggling to figure out how to override the generated values for natural background-position. By that I mean moving the position relative of the generated values. I'm used to Compass' mixin [sprite-background-position] (http://compass-style.org/reference/compass/utilities/sprites/base/#mixin-sprite-background-position). This can take parameters for offset, but trying this with the mixin sprite-position in grunt-spritesmith:
@include sprite-position($icon-foo, 1px, 3px);

gives me the following error: "Mixin sprite-position takes 1 argument but 3 were passed".
Usually the generated sprite-position is fine, but in some cases I find the need to adjust it by a pixel or two. And often there is only need to do this for a specific icon where other icons in the sprite is fine as they are.
The most common use-case I can think of is when you have an element, e.g. an input field. You'd like to show an icon inside the input and on the right. With the algorithm set to top-down, you'd get a nice vertical column-shaped spritemap. Since the width of the element should not be controlled by the generated sprite (not generating values for width/ height), you'd use:
@include sprite-image($icon-foo);

If you'd add:
@include sprite-position($icon-foo);

the icon is positioned at the left in the input-field. Not quite what you'd want. You'd like it on the right.
I'd expect something like this:
@include sprite-position($icon-foo, 100%, $icon-foo-offset-y)

100% represents the x-position override (100% to the right), and the $icon-foo-offset-y uses the dynamic generated y-position.
How can this be done?

The quick answer is sprite-position in spritesmith is unintentionally similarly named. While compass was part of the inspiration for spritesmith (i.e. making spritesheets sane), we did the CSS architecture independently =/
That being said, I am interested in learning about your use case more. I am going to perform some research to see how compass implements this feature.

Alright, I am done with my research. Unfortunately, compass relies on folders so I cannot point you to my work. As a result, I will attempt to compensate here.
I used 2 test sprites as our images, located in images/my-icons/ (e.g. images/my-icons/sprite1.png):
https://github.com/Ensighten/grunt-spritesmith/blob/5.0.0/src-test/test_files/sprite1.png
https://github.com/Ensighten/grunt-spritesmith/blob/5.0.0/src-test/test_files/sprite3.png
I defined a sass/screen.scss via compass init. Its contents were:
@import "compass/utilities/sprites";
@import "my-icons/*.png";

.sprite1 {
  @include my-icons-sprite(sprite1);
}

.sprite3 {
  @include my-icons-sprite(sprite3);
}

Upon compilation, it's output was:

/* line 56, my-icons/*.png */
.my-icons-sprite, .sprite1, .sprite3 {
  background-image: url('/images/my-icons-sc7a02fc51a.png');
  background-repeat: no-repeat;
}

/* line 4, ../sass/screen.scss */
.sprite1 {
  background-position: 0 0;
}

/* line 8, ../sass/screen.scss */
.sprite3 {
  background-position: 0 -50px;
}

When I moved to using my-icons-background-position:
@import "compass/utilities/sprites";
@import "my-icons/*.png";

.sprite1 {
  @include my-icons-sprite(sprite1);
  @include my-icons-sprite-position(sprite1, 20px, 20px);
}

.sprite3 {
  @include my-icons-sprite(sprite3);
  @include my-icons-sprite-position(sprite1, 20px, 20px);
}

I received the same spritesheet with the following CSS:
/* line 56, my-icons/*.png */
.my-icons-sprite, .sprite1, .sprite3 {
  background-image: url('/images/my-icons-sc7a02fc51a.png');
  background-repeat: no-repeat;
}

/* line 4, ../sass/screen.scss */
.sprite1 {
  background-position: 0 0;
  background-position: 20px 20px;
}

/* line 9, ../sass/screen.scss */
.sprite3 {
  background-position: 0 -50px;
  background-position: 20px 20px;
}

Now that we are on the same page, we can reflect on our options. I am leaning towards not adding this feature for a few reasons:

People who don't know how CSS sprites work might expect more of a padding (e.g. only whitespace, not other sprites), when adjusting their offsets. As a result, they would be confused and frustrated which doesn't do them nor us any good
Using the include does nothing relative to the sprite itself (e.g. 20px doesn't add 20px to -50px to yield -30px for sprite3). Since it works in absolutes, it would be simpler to define our background-position by hand for what we want.
This feature is an edge case so maintaining it in all our templates seems like overkill

As a consequence of these reasons, I am deciding to not implement the feature. The suggested workaround will be using the offset-* variables you mentioned:
https://github.com/twolfson/spritesheet-templates/blob/10.0.0/test/expected_files/scss.scss
https://github.com/twolfson/spritesheet-templates/blob/10.0.0/test/expected_files/scss.scss#L73-L75
// Compass flavor
@include my-icons-sprite-position(sprite1, 20px, 20px);

// spritesmith equvialent
background-position: 20px 20px;

// or with custom variables
background-position: $sprite1-offset-x $sprite1-offset-y;

I should clarify on the point I alluded to about "padding" vs "other sprites". To push a sprite down with some whitespace, we typically suggest including this as a part of the sprite.
It costs a few extra bytes but makes everything sane in terms of CSS (e.g. no browser specific padding fidgeting). Additionally, it allows us to use non-linear packing algorithms which saves much more bytes.

Thank you for looking in to this.
Here is a little more detail about my issue (using a top-down algorithm with padding of 12px between the icons in the sprite):
Using the following Sass:
@include sprite-image($icon-foo);
@include sprite-position($icon-foo);
background-repeat: no-repeat;

gives me the following CSS:
background-image: url(sprite.png);
background-position: 0px -108px;
background-repeat: no-repeat;

This looks like this:

As you can see, I'd like to have the icon placed to right and a couple of pixels down.
I guess it's ok to just insert the overrides by either redefining the variabel or use Sass' calculations to calculate the adjustment relative to the original value of the generated offset:
@include sprite-image($icon-foo);
background-position: 100% $icon-foo-offset-y + 2;
background-repeat: no-repeat;

This would generate the following CSS:
background-image: url(sprite.png);
backround-position: 100% -106px;
background-repeat: no-repeat;

Problem solved I guess.

My main concern was to hand-code these values and not being able to dynamically calculate them if the sprite changes (adding or deleting icons in the icon-set).
The x-position 100% is still hard coded, but the y-position will always nudge the icon 2px down, even if the original value changes.
What I really ended up doing, was to use css calc to add some pixels to the 100% x-position. This way I could compensate for the exra pixels the icon had to its right (as part of the spritesheet):
@include sprite-image($icon-foo);
background-position: calc(100% + 4px) $icon-foo-offset-y + 2;
background-repeat: no-repeat;

This got me this CSS:
background-image: url(sprite.png);
backround-position: calc(100% + 4px) -106px;
background-repeat: no-repeat;

And this result:

Voila!

Ah, thanks for the clarification on your use case =)
One thing to note is calc has problems with IE9 and no support in IE8/below:
http://caniuse.com/#search=calc
If you need to support those browser, I suggest creating 2 separate spritesheets (via 2 grunt tasks), 1 exclusively for image background images (which hopefully are the same width) and 1 for everything else.
The background images can be vertically stacked as they require but the others can be packed more efficiently via the binary-tree algorithm.
One more option we can consider is using a top-down algorithm but that right-aligns all images. This can be done by specifying an object to the algorithm option:
https://github.com/Ensighten/grunt-spritesmith/tree/5.0.0#documentation
https://github.com/twolfson/layout/blob/2.2.0/lib/algorithms/top-down.algorithm.js
{
  algorithm: {
    sort: function (items) {
      // Sort the items by their height
      items.sort(function (a, b) {
        return a.height - b.height;
      });
      return items;
    },
    placeItems: function (items) {
      // Find the maximum width
      var maxWidth = items.reduce(function (maxWidth, item) {
        if (item.width > maxWidth) {
          return item.width;
        }
        return maxWidth;
      }, 0);

      // Iterate over each of the items
      var y = 0;
      items.forEach(function (item) {
        // Update the y to the current height
        item.x = maxWidth - item.width;
        item.y = y;

        // Increment the y by the item's height
        y += item.height;
      });

      // Return the items
      return items;
    };
  }
}


Create xcscmblueprint file from an existing bot

For users who don't have the xcscmblueprint/xccheckout files in their project, ask them to create a simple bot (write a step by step guide with screenshots) and then ask them to pick it from a picker inside of Builda. What we'll do is we'll pull the bot's blueprint down, dump it into their workspace/project and ask them to commit it to SCM. This should hopefully fix it for almost everyone!

Whole manual process described here: https://github.com/czechboy0/Buildasaur/issues/165#issuecomment-148220340

Made unnecessary by #188.


EditorBuildSettings.scenes fixes

XRTK - Mixed Reality Toolkit Change Request
Overview
If accessed when not initialized (I.E. in a brand new Unity project) Unity will crash.
To avoid this, the necessary checks have been added to ensure it's ready before use to avoid this Unity bug.
Target of the change:
Is this enhancement for:

Core (core framework, interfaces and definitions)

Changes:
Brief list of the targeted features that are being changed.

Fixes: Adds null checking and Length checking of the EditorBuildSettings.scene array

Try running the build locally.

Can't replicate but I've added some extra checking around the lines it's reporting an issue.

Hmm. I wonder why the build is still failing?

OK, I've reverted the additional changes beyond the original bug (the extra changes I made for protection).  If this still fails I'll redo the PR from a fresh branch

Ok, so that build worked.  Will just have to merge this one fix and then re-test.
No idea why the other build failed which is concerning.


Android apps in windows "Open with..." context menu

Is your feature request related to a problem? Please describe
My issue is that I use a touchscreen device and I find that Windows apps are not yet really optimized.
For e.g, I'd like to use VLC for its brightness and volume swipe gestures which are not available on desktop version.
I also found someone complaining on Reddit
Describe the solution you'd like
Android app integration in context menu

Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2306.40000.4.0

Maybe a duplicate of #114 ?


Add support for writing default DB values to models $attributes property

Note: this is similar in spirit to https://github.com/barryvdh/laravel-ide-helper/issues/693 but it's something else
Example migration:
        Schema::connection('main')->create('articles', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->boolean('is_visible')->default(true);

Model (simplified phpdoc as would be generated by ide-helper)
/**
 * @property int $id
 * @property bool $is_visible
 */
class Article {
}

When you create a new model and access the is_visible attribute, it's null:
$model = new Article();
var_dump($model->is_visible);

outputs
NULL

By manually adding it to the $attributes property, we get default values out of the box:
/**
 * @property int $id
 * @property bool $is_visible
 */
class Article {
  protected $attributes = [
    'is_visible' => true,
  ];
}

Outcome:
$model = new Article();
var_dump($model->is_visible);

outputs
bool(true)

What are the thoughts about adding optional support for ide-helper to generate the $attributes automatically as a result from the introspection?

introduce a new flag --default-attributes
adds protected $attributes = []; if missing
adds (overwrites?) all values within with the ones from the database => very much like the phpdoc
add the `$att

This issue is on laravel side and it is expected behavior.
When you create a new model, it does not query the created record from database, simply because it doesn't know whether it should or not and leaves this decision to the individual developers (via $article->refresh()).

This issue is on laravel side and it is expected behavior.

I know 🤔 I never pretended otherwise.
I'm talking about providing a way to auto-generate them.

(via $article->refresh()).

Yes, but this doesn't cover the case when you create a new model, have not yet persisted it and want/need to pass it around: the defaults won't match what your database has.
That's why Laravel provides the $attributes property for.
That's why I suggested an optional way to auto-generate them to free the developer of having to manually maintain them 😄

I'm closing this because my use case changed/expanded.
I was using protected $attributes in the model and this issue was about getting the default values automatically from the migration/database into them.
What changed is that in many cases I've refactored the actual $attributes into a constant on the model because I need this for tests in places where I need to mass-check model attributes so I can access the default values outside of a "live" model, as in:
class SomeModel extends …
  public const DEFAULT_ATTRIBUTES = [
    'foo' => true,
  ];
  protected $attributes = self::DEFAULT_ATTRIBUTES;
}

class CompletelyDifferentCode {
  public function foo() {
    // access it
    … = SomeModel::DEFAULT_ATTRIBUTES
  }
}

Supporting would be way of the scope for the feature and since I could not benefit from it anymore, even when implemented, I'm closing this.


Console logging: separation of stdout and stderr

For console logging, it seems like there is no way to configure Glog to send non-error logs to stdout and error logs to stderr.
By default, Glog sends only error logs to stderr, and there is a FLAGS_logtostderr which sends ALL logs to stderr which is not ideal.  It will be good to have a flag to log to both stdout and stderr appropriately.

@sergiud I would like to have a try. For the design, I don't think we should send non-error logs to stdout when FLAGS_logtostderr was enabled, which would have the breaking change. Do you think we should add another flag to like logtostdout to achieve this feature.

https://github.com/KvrocksLabs/kvrocks/issues/478 Kvrocks also wants to log to the stdout which is using glog.

Having logtostdout sounds reasonable. Go ahead!

cool, thanks.

As explained in logging.cc, setting the flag logtostdout to True should direct the log messages to stdout instead of logfiles. However, this is definitely not the case for me. I still get the INFO in the logfiles. logtostderr behaves in the same way. This is quite confusing, since there is a alsologtostderr flag which describes this behaviour. To be consistent, wouldn't it make sense to have a alsologtostdout flag, provided that the previous flag doesn't write to the log?
And how does logtostdout interact with stderrthreshold. If I understand correctly, stderrthreshold directs INFO and WARNING to stderr, if I set it to 0. What happens if I set logtostdout at the same time?

To be consistent, wouldn't it make sense to have a alsologtostdout flag, provided that the previous flag doesn't write to the log?

@sergiud I will be happy to do this if you think it makes sense.

And how does logtostdout interact with stderrthreshold. If I understand correctly, stderrthreshold directs INFO and WARNING to stderr, if I set it to 0.

You're right that it will send all logs to stderr if set to 0 and logtostdout is enabled.

@sergiud I will be happy to do this if you think it makes sense.

However, I'm not sure how intended behavior should be. During my testing today, both logtostderr and alsologtostderr did the same, i.e. output to log files and stderr. And so did logtostdout. (glog v0.6.0) And this doesn't seem to correspond to the documentation.

@jstiefel What's your expected behavior and what you got?

@jstiefel What's your expected behavior and what you got?

logtostderr, alsologtostderr, as well as logtostdout forwarded messages to my terminal as desired. However, they still created entries in the logfile. This is not consistent with the documentation:
https://github.com/google/glog/blob/05fbc65278db1aa545ca5cb743c31bc717a48d0f/src/logging.cc#L120
(I didn't set any other flags while trying.)

Ummm... I tried on my side but it won't send logs to the logfile if one of FLAGS_logtostdout and FLAGS_logtostderr is enabled.

My mistake, I just realized that these flags keep persisting if I don't overwrite them. So no logfiles created now. I think it would be useful to have the alsologtostdout option as well.

@sergiud Does this sound good? if yes, i will go ahead to handle this.

Found an issue related to this flag: https://github.com/google/glog/issues/943


Component: Dropdown | Positive

Figma:
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=134%3A1328&mode=design&t=fiQFgnfbEVwd8vxW-1
Story Book:
TBD
Comments:

Review component
Rebuild component
Ad documentation

Closing in favour of v2 #3453


Add a YAML based file format for pipelines

(Based on #122)
See instructlab/dev-docs#109
In order to support custom pipelines, add a YAML based file format.
However, to make the default pipelines easier to reason about and develop,
also convert them to the YAML file format.
This changes the top-level API from:
mmlu_block_configs = MMLUBenchFlow().get_flow()
knowledge_block_configs = SynthKnowledgeFlow().get_flow()
knowledge_pipe = Pipeline(ctx, mmlu_flow + knowledge_flow)

to:
knowledge_pipe = Pipeline.from_flows(
    ctx, [pipeline.MMLU_BENCH_FLOW, pipeline.SYNTH_KNOWLEDGE_FLOW]
)

I looked at the rebase. It's mostly because of #82, but a little bit from #78.
I pushed a rebase here - https://github.com/russellb/sdg/tree/pr-86-rebase - not pushing to the PR branch since I haven't reviewed the code yet to know that I got it right

I looked at the rebase. It's mostly because of #82, but a little bit from #78.
I pushed a rebase here - https://github.com/russellb/sdg/tree/pr-86-rebase - not pushing to the PR branch since I haven't reviewed the code yet to know that I got it right

Thanks, I took that and rebased again.
commit 5c46881 is significant - relates to #82

I like the general direction but some of the designs being changed, such as the ones here (yaml vs py) were recommended design proposals we previously agreed upon or adapted our designs to from a previous format here #98.
At this point, I would prioritize core functionality changes over major changes to the library design, especially since this blocks and delays the required features. I suggest going through a dev-docs proposal for such changes.

Yes, see instructlabs/dev-docs#109 for that design discussion
My understanding is that custom flows is a "required feature" - see the "Alternative Approaches" section in the dev-doc for some of the thinking on that
See also instructlab/instructlab#1546

I have one question about the PipelineContext. This moves the teacher model_id to the pipeline context, though one feature we want to support is having a different model id on a per LLMBlock basis. This indeed is not needed by any of our current flows in the tree, but we have a need for it in a downstream pipeline. We want to support having vllm running a model, as well as a model + an adapter. Those two cases will be served up under different model ids.

It's important to consider we have 2 personas - the author of a pipeline config, and the user executing the pipeline (e.g. with ilab data generate
Using the model name/id in the pipeline config is a problem because user can choose a different model and so we can't require the pipeline author to have knowledge of it
I'm trying to avoid going do a path where the pipeline author has to do some templating to take into account user-defined runtime parameters
I think the use case here is likely to be:

Most LLMBlock definitions will use the default teacher model - and we can make the semantic that if the pipeline author doesn't specify a model, the default is used. And we get the default model name from the PipelineContext
In cases where a model+adapter is served, it hopefully will be the same pipeline author defining both its serving configuration and its use in an LLMBlock. So the pipeline author can name it in the serving config and reference it by that name in the pipeline config

We can add support for (2) when we add model serving config support
Does that make sense?

The simplest option seems to be to push that field back to be per-LLMBlock. Let me know if I've missed another way to accomplish this.

Thank you - I've added a comment in the dev-doc as a todo to capture the above detail

@markmc thanks, that mostly makes sense, but one question

We can add support for (2) when we add model serving config support

but how about someone working on a downstream pipeline already making use of different model IDs per block? I don't want to break them. Do you mean we'd implement this before merging?

@markmc thanks, that mostly makes sense, but one question

I may be totally missing something!

We can add support for (2) when we add model serving config support

but how about someone working on a downstream pipeline already making use of different model IDs per block? I don't want to break them. Do you mean we'd implement this before merging?

I guess I'd like to know how those non-default model IDs are currently defined ... oh is this assuming someone running vLLM manually?
In that case, I think the pipeline author needs to be able to define required models and the user needs some way to specify a mapping of model IDs to those required models
Something like:
version: "1.0"
models:
  - name: myfunkyadaptor
    description: a funky adaptor for generating questions
block_configs:
  - block_type: LLMBlock
    block_config:
      block_name: gen_questions
      config_path: configs/skills/freeform_questions.yaml
      add_num_samples: True
      model: myfunkyadatpor
      output_cols:
        - question
    drop_duplicates:
      - question

and then something like:
$ ilab data generate --model=myfunkyadaptor:model1

Or just require the user to ensure the model is called myfunkyadatpor
The crucial point IMO is ... the pipeline author has to define their expectations ... right?

e2e workflow failed on this PR: View run, please investigate.

TypeError: FilterByValueBlock.__init__() got an unexpected keyword argument 'block_name'

Bah .. simple fix, but getting a unit test to catch it took a bit of futzing. I added a test which parses all the pipeline yamls and at least instantiates all the blocks.

e2e workflow failed on this PR: View run, please investigate.

  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 78, in generate
    dataset = block.generate(dataset, **gen_kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/filterblock.py", line 90, in generate
    return samples.filter(
           ^^^^^^^^^^^^^^^
...
    rv = reduce(self.proto)
         ^^^^^^^^^^^^^^^^^^
TypeError: cannot pickle 'SSLContext' object

I think I've reproduced locally and its specific to the full freeform skills pipeline. Investigating.

e2e workflow failed on this PR: View run, please investigate.

  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 78, in generate
    dataset = block.generate(dataset, **gen_kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/filterblock.py", line 90, in generate
    return samples.filter(
           ^^^^^^^^^^^^^^^
...
    rv = reduce(self.proto)
         ^^^^^^^^^^^^^^^^^^
TypeError: cannot pickle 'SSLContext' object

I think I've reproduced locally and its specific to the full freeform skills pipeline. Investigating.

It only happens with num_proc set in the call to samples.filter(). Not sure what's happening, since we use num_procs=8 in main here. Will come back to it tomorrow.

e2e workflow failed on this PR: View run, please investigate.

  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 78, in generate
    dataset = block.generate(dataset, **gen_kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/filterblock.py", line 90, in generate
    return samples.filter(
           ^^^^^^^^^^^^^^^
...
    rv = reduce(self.proto)
         ^^^^^^^^^^^^^^^^^^
TypeError: cannot pickle 'SSLContext' object

I think I've reproduced locally and its specific to the full freeform skills pipeline. Investigating.

A SSLContext cannot be pickled. I'm not familiar with the code base and the code does not have enough type annotations to understand it.
My instincts tell me that you are probably handing PipelineContext around. The context has an OpenAI client attribute, which itself holds a httpx client, which itself holds on to a SSLContext object. You probably have to make the OpenAI client attribute lazy, so it is initialized in the external process.

My instincts tell me that you are probably handing PipelineContext around. The context has an OpenAI client attribute, which itself holds a httpx client, which itself holds on to a SSLContext object.

Thank you, you were absolutely spot on. See c09d354

In that case, I think the pipeline author needs to be able to define required models and the user needs some way to specify a mapping of model IDs to those required models

The models section really isn't necessary in retrospect. This will work:

version: "1.0"
models:
  - name: myfunkyadaptor
    description: a funky adaptor for generating questions
block_configs:
  - block_type: LLMBlock
    block_config:
      block_name: gen_questions
      config_path: configs/skills/freeform_questions.yaml
      add_num_samples: True
      gen_kwargs:
        model_id: myfunkyadatpor
      output_cols:
        - question
    drop_duplicates:
      - question

And then the serving config just needs to have --lora-modules=myfunkyadapter=path/to/my_custom_adapter

e2e workflow failed on this PR: View run, please investigate.

Failed to determine backend: Failed to determine whether the model is a GGUF format: [Errno 2] No such file or directory: 'models/mixtral-8x7b-instruct-v0.1.Q4_K_M.gguf'

e2e workflow failed on this PR: View run, please investigate.

Failed to determine backend: Failed to determine whether the model is a GGUF format: [Errno 2] No such file or directory: 'models/mixtral-8x7b-instruct-v0.1.Q4_K_M.gguf'

https://github.com/instructlab/instructlab/pull/1657

e2e workflow failed on this PR: View run, please investigate.

File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/pipeline.py", line 74, in generate
    dataset = block.generate(dataset, **gen_kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/instructlab/sdg/utilblocks.py", line 64, in generate
    samples = samples.map(self._generate, num_proc=self.ctx.num_procs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
  File "/actions-runner/_work/sdg/sdg/venv/lib64/python3.11/site-packages/dill/_dill.py", line 414, in save
    StockPickler.save(self, obj, save_persistent_id)
  File "/usr/lib64/python3.11/pickle.py", line 578, in save
    rv = reduce(self.proto)
         ^^^^^^^^^^^^^^^^^^
TypeError: cannot pickle 'SSLContext' object

Same issue as what commit 5cc6cd1 addresses, but this time it's CombineColumnsBlock - should be straightforward to fix

FYI - the design doc (instructlab/dev-docs#109) has merged
I have also submitted a series of PRs with the goal of reducing the size of this PR. See #116 #117 #118 #119 #120 #121 #122
I'll follow-up with an update to this PR rebased onto those PRs and reflecting the latest design in the dev-doc

Ok, I've rebased onto #122. I haven't yet incorporated changes agreed in the design doc update.

eh? e2e failed with:
  File "/home/runner/work/sdg/sdg/venv/lib/python3.11/site-packages/instructlab/model/train.py", line 466, in train
    training_results_dir = linux_train(
                           ^^^^^^^^^^^^
...
  File "/home/runner/work/sdg/sdg/venv/lib/python3.11/site-packages/transformers/generation/utils.py", line 2693, in _sample
    next_tokens = torch.multinomial(probs, num_samples=1).squeeze(1)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: probability tensor contains either `inf`, `nan` or element < 0

Pushed some more changes, closer to the dev doc now. Still to do:

Allow generate_data() to take a directory path to a set of custom pipeline configs
Add ImportBlock to allow custom pipeline configs to inherit from the default ones
Implement the router concept - we'd use this to add a direct router that would allow generate_data() take a path to single pipeline config file

Pushed some more changes, closer to the dev doc now. Still to do:

Allow generate_data() to take a directory path to a set of custom pipeline configs

draft PR for this piece: https://github.com/instructlab/sdg/pull/129

Add ImportBlock to allow custom pipeline configs to inherit from the default ones

Done

Implement the router concept - we'd use this to add a direct router that would allow generate_data() take a path to single pipeline config file

I think this can safely wait until after this PR lands

Pushed some more changes, closer to the dev doc now. Still to do:

Allow generate_data() to take a directory path to a set of custom pipeline configs

draft PR for this piece: #129

Pulled that in, thanks

As of this commit from @xukai92 -- https://github.com/instructlab/sdg/pull/86/commits/2c527702bb8ddebfe786a6dd4eb58b815cfb44fd
The testing that compared the results with this fork (https://github.com/aakankshaduggal/sdg) was successful. @xukai92 confirmed in that that "with this we have parity" and  "https://github.com/instructlab/sdg/pull/86 should be good to merge"
I'm waiting for CI to finish one more time (both e2e jobs). If they're successful, then we can merge.


Quest automatically fails

Completed quests are shown with a green tick mark, but some time after the quest completion the mark changes to cross, signifying failed quest.
How to reproduce:

Activate and complete a quest
Wait for some time
Quest will automatically be shown failed

From what I've seen in the repo contents, this is not an issue of this tutorial repo but of the underlying Tasks repo.
That's why, this issue will be tracked there now instead of here: https://github.com/Terasology/Tasks/issues/30


Add to Calendar Image

Critical Changes
Add to Calendar Image for documentation
Changes
Issues Closed

Add image to this wiki page
https://github.com/SFDO-Community-Sprints/Summit-Events-App/wiki/Add-to-Calendar-Functionality


Validation of dynamic form with multiple select variations

Is there a 'more semantic' way of sniffing out which select box is being rendered to the screen?
Obviously, calling 'material_select()' on your selects renders companion select boxes -- I find this difficult in sniffing out which select box is visible on the stage for validation (for instance when switching between Countries and their corresponding Province or State select boxes).
Hope this makes sense... thank you!

Could you maybe illustrate this in a codepen? Use this template for easy materializing: http://codepen.io/pen/?template=oLakEj
It has all the materialize nescetities included.

Hi and thanks for taking the time to help; I ended up realizing it was a fairly simple fix.
Since I'm using materializecss and jquery validation I created a custom validation method for select boxes to first check if it is on the stage, then set my validation rules to ignore everything but those select boxes (that could be hidden/switch dynamically).
Example:
  $.validator.addMethod('select_check', function(value, element, params) {
    if ($('#' + element.name + '-wrapper').css('display') != 'none') {
      // Item on stage...
      return (value != null);
    } else {
      return true;
    }
  });

$(".form").validate({
    ignore: ":hidden:not(#all, #the, #things)",
    // ...etc...
    rules: {
      email: {
        validate_email: true,
        required: true
      },
      ship_salutation: {
        select_check: true,
      },
      // etc...
    }
  });

Hopefully, if some poor soul comes Googling through here, is helped.


JWTbearer?

Is there any documentation about JWTbearer authentication?
Or am i blind?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94bfd895-d2af-390b-0801-428b36a27ff4
Version Independent ID: 0e0d870e-e49a-e16c-c259-68d58e701b8f
Content: Introduction to Identity on ASP.NET Core
Content Source: aspnetcore/security/authentication/identity.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

No

Ok then.


Imported realm from 'realm-test.json' doesn't prompt for trusted-device and OTP-device during login

Imported the sample JSON 'realm-test.json' file for the realm test.
Authentication assigned for "Browser flow": '2FA - Browser'

Keycloak version: 22.0.3 as defined in current 'Dockerfile'
Postgres version: 14 as defined in current 'docker-compose.yml'
Login only prompts for "Username & Password"
Not seeing any request to add "OTP device"
Not seeing any request to trust device (current browser used for login)

This instance is running with "start-dev" using the vanilla setup directly from 'Github' using the 'run-dev.sh' script.
"Browser" auth-flow for the 'test' realm from the 'imported JSON' file:

Hi,
Has there been any updates on this finding? Am I configuring the browser-flow incorrectly or something?
If you're able to provide a good example of a realm-export JSON that works, could you include it in the response?
Thanks for all your help on this.
-Justin

Imported realm doesn't work because of "client scope permissions":
After https://keycloak.discourse.group/t/what-could-cause-the-users-account-page-to-be-forbidden/16285
works.
In existing realms I still can't add "Authenticator types" in the Condition.

Thanks for the info @zawadaa ...
That cleared my user so it has the correct access to add an TOTP-device to its credential-list.
Once an OTP-device is configured, then the 'trusted-device' prompt appears.
I'll resolve and close this issue as the condition describes that:

If OTP-device is configured, then "Prompt 2FA".
Once TOTP entered successfully, then display the "Trust this device?" dialog.

Newer versions of Keycloak do not seem compatible with exports generated by older versions. The above comments list a workaround.
It should work if you configure the authentication flow manually (see readme).


what's your way of making the exe

hello! I need a 32 bit copy of the exe but don't know what to do to make the exe for the 32 bit OS. which way did you use to make the exe?

hey I have used auto-py-to-exe to convert it to exe file. if you can use the python file directly it can also work fine.


[BUG] Raw/html_safe issue

I have come across small bug, which does not allow me to use raw() or .html_safe for the button value.
Code:
= form.button :submit, raw(I18n.t("interface.button.start.level.basic.order", level: 5))
Renders as:
= form.button :submit,I18n.t("interface.button.start.level.basic.order", level: 5)

@DagnisSlogis have you tried using *_html for your translations which – as far as I understand it – will result in the same thing as the raw-command.
= form.button :submit, I18n.t("interface.button.start.level.basic.order_html", level: 5)

Now we have an issue template that helps you provide more information about the issue. Please open a new issue and make sure to fill in all the information requested by the template shown inside the text box. Thank you!


Next Batch Date is only shown when application is already open

We used the location.nextBatchDate to announce our upcoming application periods, while leaving the application manually open with location.isOpen  which avoided a lot of questions from potential Techies when the next period starts.
With the new(4 months old) checks for actual application time this does not work. The workaround is to set the start application date before today, but that also activates the card under /apply.
Proposed idea: A new field to show a message when applications are closed. I can add the field in react, but I don't know how to add it in contentful.
Thanks

Thanks for your input! :-) Yes the setting of the dates is kind of weird because you have both - a date and the toggle. ( We should change it in the future) - Anyways I will work on your idea in the next days and keep you updated.

Hey @RichardMEN11,
Any updates on this?

Just opened another branch, which should fix it.
Once this is merged as well I would make a quick update so the locations are aware what is displayed now.


Fix network issue

Context: The jfr daemon was causing an increase in network activity over time. The network points of the daemon are the following:

streaming data from JFR on the service being monitored to the daemon
writing that stream to a file
loading that file back to the daemon
sending events and metrics to New Relic

After eliminating the streaming and file writing and read as the source of the issue, it pointed me to the sending of events/metrics to NR. Looking at one of the test apps it was clear that over time more and more metrics were getting sent each harvest cycle (10 seconds).
Issue: In some of our summarizers (i.e. ObjectAllocationInNewTLABSummarizer) we keep track of all summarizers in a map based on thread name so we can recall them when reporting data and don't have to recreate them each harvest. The issue with this is that services can have 100s of short lived threads. This becomes an issue because we never clear out our map of threads to summarizers. Each harvest we iterate over that map to summarize the data for each thread and send it up as metrics. If the daemon still had summarizers in that map for threads that no longer existed, then the daemon would send up empty summarizer metrics, which is exactly what was happening.
Solution: By clearing out the map every harvest we can guarantee that no empty summary metrics will be reported the next harvest. This will lead to recreating summarizers each harvest cycle but that can't be avoided since we can't report up empty metrics.
Here is a graph of the network activity before and after the fix:

I commented the important parts of the PR, the rest of the PR is having to deal with splitting up the summarizeAndReset method.


cf-icd-plugin version 0.0.9

@dkoper Thank you!
I have made myself public in the IBM organization.
Fixed the version number.

Closing & reopening PR to get dreddbot to re-check the CLA.

Thanks!


Modify replica assertions in scheduler tests

This PR modifies some of the assertions used to check the Replicas of a Volume in response to the fixes introduced to longhorn-manager in longhorn/longhorn-manager#324.
Previously, due to the scheduling behavior, the tests had to ensure that there were still running Replicas that were healthy, and that there were anywhere from two to four new Replicas that were attempting to be scheduled due to how the longhorn-manager logic was scheduling new Replicas. Now, since an unscheduled replica will not be marked as failed unless the Node goes offline, the checks have been modified to check for the following conditions in the case of a scheduling failure:

There are two healthy Replicas that still exist.
There is one Replica that is not scheduled.
There should only be exactly three Replicas in existence, even in the case of a scheduling failure.

Side note: when running the tests, I noticed a few code style errors that were introduced in some other commit located in test_basic.py and test_ha.py. Should those be addressed in this PR, or be left for another PR?

LGTM.
@ttpcodes you can address those coding style issues in this PR as separate commits.

It seems that the code style issues have since then been fixed by #158. Branch was rebased to ensure that the tests still function properly.


Evaluate iambic as a new user using a more moderate read-only type spoke role

Is your feature request related to a problem? Please describe.
It would be great if somehow I could evaluate iambic as a new user, using a more moderate read-only type spoke role, vs something that can create access keys, revoke permissions, etc. right off the bat.
Describe the solution you'd like
The permission should be much more restricted than iam:* and sso:*
              - Effect: Allow
                 Action:
                   - identitystore:Describe*
                   - identitystore:Get*
                   - identitystore:List*
                   - organizations:describe*
                   - organizations:list*
                   - iam:Get*
                   - iam:List*
                   - sso:Describe*
                   - sso:Get*
                   - sso:List*
                   - sso:Search*
                 Resource:
                   - '*'

Describe alternatives you've considered
Supply my own SpokeRole to use in configuration
Additional context
  accounts:
    - account_id: 'REDACTED'
      account_name: iambic_test_spoke_account_2
      iambic_managed: read_and_write
      org_id: 'REDACTED'
      spoke_role_arn: arn:aws:iam::REDACTED:role/IambicSpokeRoleReadOnly

https://github.com/noqdev/iambic/pull/317 should tackle this

We've merged #317 , so it's available on the main branch. If anyone wants to try it out, clone the repo directory. This will be included in the next pypi build 0.3.0+. I will close this issue when we publish the build on PyPI.

This is now included in pypi release 0.3.1. Marking this issue as closed.


ros launch files: package has a new name

In sync with https://github.com/PX4/euroc_simulator/pull/4

Applied via cherry-pick to master.


Add stats to HealthCheck, and export its cache.

@alainjobart @sougou @guokeno0

LGTM on the varz part

LGTM. Let's see with usage if that's the metrics we want to track.


ExtractorError

I tried this on a couple machines and got the same error (that was after updating as was pointed out in the error).
There was an error in downloading this video:
https://www.youtube.com/watch?v=FGBhQbmPwH8
I used this command:
$ youtube-dl -v FGBhQbmPwH8
Error text:

$ youtube-dl -v FGBhQbmPwH8
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'FGBhQbmPwH8']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.10.24
[debug] Python version 2.7.3 - Darwin-12.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.7.2, ffprobe 2.7.2
[debug] Proxy map: {}
[youtube] FGBhQbmPwH8: Downloading webpage
[youtube] FGBhQbmPwH8: Downloading video info webpage
[youtube] FGBhQbmPwH8: Extracting video information
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {43} signature length 40.44, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
video_id, player_url, s
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError(u"Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
video_id, player_url, s
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 661, in extract_info
ie_result = ie.extract(url)
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 291, in extract
return self._real_extract(url)
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 1345, in _real_extract
encrypted_sig, video_id, player_url, age_gate)
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 827, in _decrypt_signature
'Signature extraction failed: ' + tb, cause=e)
ExtractorError: Signature extraction failed: Traceback (most recent call last):
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
video_id, player_url, s
File "/Users/isospin/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError(u"Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vfljDEtYP/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.

Ah, yeah. The machine I grabbed the error from wasn't updated. It is updated now, using homebrew (OSX), but the version is still:
youtube-dl 2015.10.09
which unfortunately still has the error (ExtractionError). This is probably a problem with the package manager. Thanks for the help!


check and test audio arithmetic for complex-valued data

adapt _assert_match_for_arithmetic and introduce variable complex

I think we should discuss how we handle mixed input. Currently the following is working and returns a complex signal
import pyfar as pf

a = pf.Signal([1, 2, 3], 44100, complex=True)
b = pf.Signal([1, 2, 3], 44100, complex=False)

c = pf.add((a, b), domain='time')

which I think is good. However, the equivalent frequency domain operation
c = pf.add((a, b), 'freq')

does not work, because the spectra have different shapes (single vs. both-sided). My thought is that mixed operations should work and always return complex data. This would require casting to double sided spectra for frequency domain operations.
In case we want this, should the casting be done

somewhere in the arithmetic function,
be a function of the pyfar.dsp.fft module,
or should we add setter functionality to Signal.complex?

We discussed the following in the weekly

The complex property from TimeData and Signal should become setter functionality
Setting from complex = True to complex=False requires a check if the time data has abs(imag(time)) < tolerance or if the frequency data is conjugated symmetric around 0 Hz


Enums support & providing service

Added field providing mechanism

Added support first version I (not enabled for static forms)

Fixed issues field providing mechanism

Added support first version II

Moved modules

Added some testing

Pesonally, -1 this PR (nothing wrong with the code though)
We have DataModelOracle in kie-wb-common that has enum support (and will be used for dynamic bean validation in Form Modeller - in the near future). I'd like to stop the temptation to write another "type oracle" implementation early as it'll be better to fix what's broken (with the current DMO to be used for Forms) than to retro fit Form Modeller with the existing DMO in the future (as I don't think it'd ever happen and we'd have two "type metadata" services).
.. but this is my opinion (I think everyone knows this already!!).

@manstis I agree wit using DMO, but right now I do require inspecting the models that are part of the application codebase, not only the ones created within the workbench. I think the currenyt DMO only supports the second scenario. Do you think is it possible to have that feature too? I'll be happy to migrate all the model processing to DMO as soon as I could do that.

@manstis do you think that we could have a call tomorrow to talk about that?

@pefernan FYI, I tried building from master (i.e. without this PR) and got the same build error as Jenkins, so that is unrelated to your change. I will look into this more.

@mbarkley Ok, I'll take a look tomorrow morning to see what's wrong. Let me know if you find something

@pefernan The test errors were caused by a type in the default package in users-new. I've sent a PR to your livespark-playground fork.

@mbarkley ops! I was aware of that class on the default package, I had planned to fix it this morning, so you did the job for me ;-) thanks!

+1 to merge.

Jenkins, retest this

To clarify Mike's +1: We had a call and I'll be moving the annotation processing engine to DMO during the next days. I will require some refactor on DMO btw.

Jenkins, retest this


performance degredation when processing many equations

As discussed F2F, I ran into a performance problem with mathjax-node-sre when handling many (>>1000) equations; this traced back to SRE. It is observable at a smaller scale as well.
As pointed out by @zorkow, this is primarily an issue in the xpath module when using nodejs; it does not occur client-side.

Move to wgxpath takes care of that.


immediately exit if unknown arguments are passed

This PR adds changes to raise an error if an unknown argument is passed.
Test plan
before (all tests would run):
nox lint
> nox
nox > Running session tests-3.5
nox > Session tests-3.5 skipped: Python interpreter 3.5 not found.
nox > Running session tests-3.6
...

after (error is raised):
>> nox lint
usage: nox [-h] [--version] [-l] [-s [SESSIONS [SESSIONS ...]]] [-k KEYWORDS]
           [-r] [--no-reuse-existing-virtualenvs] [-f NOXFILE]
           [--envdir ENVDIR] [-x] [--no-stop-on-first-error]
           [--error-on-missing-interpreters]
           [--no-error-on-missing-interpreters] [--error-on-external-run]
           [--no-error-on-external-run] [--install-only] [--report REPORT]
           [--non-interactive] [--nocolor] [--forcecolor]
           ...
nox: error: Unrecognized argument(s): 'lint'

>> nox -s lint
nox > Running session lint
nox > Creating virtualenv using python3.7 in .nox/lint
...

fixes https://github.com/theacodes/nox/issues/226
cc @theacodes

This looks great - just one last question before merging. :)

Of course, we'll need CI to pass. Let me know if you run into any trouble there.

This looks great - just one last question before merging. :)

Of course, we'll need CI to pass. Let me know if you run into any trouble there.

I'm having trouble getting the unit test to pass. It did start failing, which is a good thing. It means the new stricter check is working! I just can't figure out how to assert the proper error was raised. Any help would be appreciated.

Tests are now passing. I also updated the flake8 rule to comply with black's formatting (and removed the fmt: off.

Thank you!


[FEAT] Support path globs for convco version --path

Is your feature request related to a problem? Please describe.
I work in a large Rust monorepo wasmCloud and we've been using conventional commits for quite a while. I wanted to use this tool to be able to describe when I need to bump a version based on breaking changes, but I can't seem to specify the --path properly when computing version bumps. Either globbing isn't supported, or I'm specifying the file incorrectly.
Describe the solution you'd like
For example, I have a crate in the workspace called wash-lib that I want to release a new version of. There have been breaking changes in other crates that I don't want to consider in my new version bump, I only want to consider changed files in the ./crates/wash-lib repository. Additionally, we tag each release with an easy prefix so I can easily filter back to the last tag cut. Here's what I want to run:
convco version --prefix wash-lib-v -P 'crates/wash-lib/*' --bump

This unfortunately doesn't detect a need to bump at all. However, the following command does properly detect a breaking change in a file:
convco version --prefix wash-lib-v -P 'crates/wash-lib/src/actor.rs' --bump

Describe alternatives you've considered
I considered adding some complex script to list out paths in commits and feed them to the convco tool, but this feature just seemed a lot better!
Additional context
If you are able to point me in a direction, I'm happy to contribute this feature 😄

Globbing is part of the shell, but adding num_args is probably necessary to avoid repeating the -P option and be able to use globbing.

Depending on the shell you use there are some options to prefix e.g. in zsh you can use path*(P:-P:)
for other shells.
In you case it should work by just doing convco version --prefix wash-lib-v -P crates/wash-lib --bump

convco version --prefix wash-lib-v -P crates/wash-lib --bump

This does work! I'm not exactly sure how I didn't stumble on this, maybe it was the ./ prefix?
~/github.com/wasmcloud/wasmCloud ➜ convco version --prefix wash-cli-v --paths ./crates/wash-cli --bump
0.24.1

~/github.com/wasmcloud/wasmCloud ➜ convco version --prefix wash-cli-v --paths crates/wash-cli --bump
0.25.0

The code used this to compare paths: https://github.com/convco/convco/blob/master/src/git.rs#L170
Maybe removing ./ in code or print a warning should be done.

Added documentation in the cli help message

Thank you @hdevalke! I'm happy to consider this issue closed, as my original request to be able to specify an entire folder (not necessarily needing globs, was just an idea) is complete. I'll leave it to you if you'd like to close it now


The keyboard do not stay open in TextBox in WASM Firefox Android

Describe the bug
When a TextBox got focus in Android Firefox (WASM), we see the keyboard slide animation, then it automatically close, making impossible to enter text in TextBoxes.

@dbriard this is being investigated.
Thank you for your patience.

@dbriard this is being investigated.
Thank you for your patience.

Thank you so much, I am developing a web application for a few months and so far working with Avalonia was awesome experience, except for text fields... especially on Android (I don't know about iOS). For mobile phones, as the small screen require a different UI I could use an app as workaround, but it is more anoying for tablets as screen is large enough for our app. That would be really perfect if text boxes could work normally on Android browsers. Thank you again for the good support!

@dbriard I think maybe only Firefox mobile is affected. Does it word for you using chrome or vivaldi?

@dbriard I think maybe only Firefox mobile is affected. Does it word for you using chrome or vivaldi?

Vivaldi I don't know, Chrome and Edge the keyboard stay open but the TextBoxes are not working at all.

I had no issues with Chrome typing Korean, Japanese or English on my device

I had no issues with Chrome typing Korean, Japanese or English on my device

Seriously? You mean in Chrome on Android with virtual keyboard?
Here a video of the textbox behavior on my device, the video show the emulator, but I have exactly the same behavior on my device (nokia 7.1, android one phone).
https://github.com/AvaloniaUI/Avalonia/assets/3595443/d00ac36e-e503-4f9b-b1df-126c89687da0
the first second are ok, when the textbox is empty, but then everything get crazy, backspace do not erase, when I touch the textbox (not the keyboard), the text is changing, the keyboard do not add what I want to the textbox...

Is that video recording a virtual machine?

ng a virtual machine?

@timunie Yes, but same behavior on my physical phone. Here are two videos on two differents phones:
Nokia
https://github.com/AvaloniaUI/Avalonia/assets/3595443/22603848-b580-4ade-9ab4-8ff067c1e084
Huawai
https://github.com/AvaloniaUI/Avalonia/assets/3595443/106adcd7-ccde-4847-9dcf-8166e2c17f8d

Is there an update to this problem? I can confirm that the bug still exists. I have the same bugs as described above: On Android, TextBoxes don't really respond to input, In Firefox the virtual keyboard won't even stay open. Backspace is buggy too.
Tested with different Avalonia versions up to 11.1.0-beta1 (physical phone and emulator).
For reference, here is the link to my project: link.
It is hosted here for testing.

@q-g-j could you check the second link? It doesn't open for me.

Oh I'm sorry, it should be up again.

nice UI btw

I haven't tested that bug for a long time. Now, the text fields do not change at all on my android browser.
I hope this can be fixed 🤞

This issue can be seen also at https://play.avaloniaui.net/ when accessed by Android browsers chrome or duckduckgo. My observation is that only enter and backspace work, nothing else. No way to write anything to textbox. No issue when accessed by Windows desktop browsers Chrome, Firefox and edge.

Hi @Gillibald @timunie
I retried TextBox today with Avalonia 11.1.3 WASM on both Android (chrome) and iPhone (Safari).
iPhone: So far it seems to work except that the caret is displayed twice.

Android: we cannot add a single character.
I tried to display the keys pressed and I got:

None for every character
Back for Backspace (but with PhysicalKey as None)
From my understanding this issue is impossible to fix? Could you confirm?
Question: have you considered displaying you own VirtualKeyboard as an Avalonia control so you can retreive the pressed keys?

Hi @dbriard
Have a look at this gist: Avalonia 11.0 Mobile browser keyboard workaround.
This manually maps the text characters to the corresponding key events and send it to Avalonia. I have written it for Avalonia 11.0. Maybe it still works for 11.1.3. My project was only for german users, so the key mappings there are only for german layout. There is a helper html file to generate code for custom mappings. You can customize this code to your needs. I have only tested it with android devices, but maybe it works also for iOS.
I think this is easier than writing a custom keyboard control.
About the double caret problem under iOS: Maybe the caret color needs to be set to transparent separately. There is an input element which you can normally not see, because it has transparent text and background color. If iOS has also a caret color this could explain the double cursor. Maybe this can be fixed with some CSS.

@Yarith I will have a look! Thanks a lot for helping!!

I still have this problem on version 11.2.2. Is there any plan to fix this?

If anyone has an idea how to solve it, yes. Right now we don't really see a good  solution.


dynamic group by for list views

Is your feature request related to a problem? Please describe.
For data like in this screenshot:

I would like to group by "Author" so that I can sum up all pages of unique authors.
I believe we have no option for dynamic SQL GROUP BYs, or does anyone have an idea?
Describe the solution you'd like
Perhaps we could add group by options in the configuration steps of list views.

If Author is a key to a different table, you can (in this case) make a List on that table and add an aggregation.
Also, the pivottable module is very powerful in this respect

Thanks, I'll take a look into pivottable

Also, the pivottable module is very powerful in this respect

Yes, of course, pivottable is a very cool plugin in terms of aggregation, but even it can be expanded with grouping capabilities.
I mean this wonderful fork! I think it wouldn't take much work to adapt an existing SC plugin to this fork... So it would be great if there were two SC pivottable plugins (so as not to break backward compatibility in existing SC projects*): the original one and the fork of it with grouping capabilities.
*Or maybe there is no threat to backward compatibility and it’s easier to have one plugin, but with the settings... I really don’t know which way would be better...

ListSQL plugin has such ability. :-)

Can you send me a link to that plugin?

Can you send me a link to that plugin?
https://github.com/saltcorn/sql-list


Apalike output format

Summary
This PR addresses Issue #144 and implements an output format that loosely follows the guidelines set in the How to Cite Software in APA Style blog post.
Motivation
The general idea of an APA-like format is not to rigidly follow APA rules, but mostly to provide an output that resembles something that one would find in a scientific publication, particularly following the "usual who-when-what-where format". As posted on #144, I believe such output could be very useful for people wanting to cite software in less structured contexts (an e-mail, a pure-text document editor, etc.)
Quality assurance
Unit tests have been implemented to make sure the presented commit passes all tests listed on the README file.
Nonetheless, I noticed my fork is currently failing the TravisCI versioning check due to "VersionConflict: (pytest 4.3.1 (/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages), Requirement.parse('pytest>=4.6'))". The output of a local run of python3 -m pytest test/test_consistent_versioning.py ends with all (4) tests passing in 0.09 s (platform linux -- Python 3.6.9, pytest-5.3.5, py-1.8.1, pluggy-0.13.1).

Please advise on how to address the issue raised by Travis.

Looks like the configuration needed some love. I've made some updates, e.g.

upgraded pytest version in requirements-dev.txt
upgraded the travis os to ubuntu 18.04
changed the set of supported python versions to [3.6, 3.7, 3.8]
changed from sonar-scanner on travis to sonarcloud github app

with these changes, travis is green for master branch.
You can get these changes by:
cd to your clone directory
git remote add upstream https://github.com/citation-file-format/cff-converter-python.git
git fetch upstream
git merge upstream/master

Let me know how you get on,
-Jurriaan

Very nicely done! Would you please extend this PR by adding yourself to cffconvert's CITATION.cff? Unless you'd rather not be listed, of course. Thanks!

Very nicely done! Would you please extend this PR by adding yourself to cffconvert's CITATION.cff?

Sure thing, I'm honored!

:1st_place_medal:


Network graph auto centering does not work anymore

Auto-centering the network graph does not work anymore in the current dev version. It is not a big issue, since manual centering still works (e.g. when toggling the auto centering).

Fixed by #127 .


Chrome App Migration?

In case you haven't seen yet @gniezen, Google is discontinuing Chrome apps on every platform except Chrome OS. Any plans for this? Google says devs should convert it to either Progressive Web Apps or native packaging with Electron/NW.js.
https://developers.chrome.com/apps/migration

Hi @bgiesing ! Yeah, I saw the notice just before midnight on Friday and didn't sleep well at all afterwards ;) We're still evaluating all the options:

NW.js just announced that they will be supporting the chrome.* APIs (we currently require the chrome.serial and  chrome.hid USB libraries).
If we end up using Electron we'll have to switch to using the Node USB/serial libraries.
I quite like the idea of turning the Uploader into a web app, but that would require browsers to support Google's WebUSB API - looks like Chrome will start supporting it in version 54.

Closing this issue as we have migrated to an Electron app with v2.0.


wrappers and tests

Good job, but I would just add the recipient parameter https://github.com/kewka/cruzo-contracts/commit/306deaa4b8af736ea803e794724feed3b4a3cc35


Update method to specify UAA URL for JWT Bearer grant tests

Instead of specifying UAA URL as a combination of UAA_HOST:UAA_PORT, use
UAA_ROUTE, which is also exported by the test running script. This
simplifies things, and lets the test script pick the route if specified
in the environment. This is useful for local minikube runs, which like
local runs is tested over HTTP, but where the UAA URL does not have a
port specified, and no CF steps are needed to be executed (see
uaa-cf-release PR [1])
[1] https://github.build.ge.com/predix/uaa-cf-release/pull/58

Related PRs:
https://github.build.ge.com/predix/uaa-k8s-deploy/pull/1
https://github.com/GESoftware-CF/uaa/pull/381
https://github.build.ge.com/predix/uaa-cf-release/pull/58