Coverage not piped to Coveralls from Travis for pull request

I configured Coveralls, Travis, and my repo as specified here. I get coverage from some builds (#5, for example), but not others (#7, e.g.).

Closing for lack of activity.  If this is still a problem, let me know and I'll be happy to reopen.


Request to add multi GPUs support and plz don`t make TPU evil.

Awesome work!
TPU is good, push ppl to use TPU is "Do the right thing" but not "Dont be evil" since its really not cheap.
It`s pitty that if no plan to add multi GPUs support because for now multi GPUs support will definitely benefit much more ppl.

You can just apply https://github.com/uber/horovod with minimum code modifications to enjoy multi-mahcine, multi-gpu distributed training.

You can just apply https://github.com/uber/horovod with minimum code modifications to enjoy multi-mahcine, multi-gpu distributed training.

Thanks, but I didn`t mean that.
Acutally I have run the BERT on multi GPUs based on the repos and got pretty good results on multiple tasks:
https://github.com/CyberZHG/keras-bert
https://github.com/Separius/BERT-keras
with simply add codes "bert_model = multi_gpu_model(bert_model, gpus=GPUS)".
However I think the code from the origin paper should allow more ppl to reproduce the result easier, but not just attempt to push everyone to use TPU.

It will be great if the Google team can add official multi-GPU support to BERT.  For now, here is a fork that uses horovod:
https://github.com/lambdal/bert

Maybe you can modify the source code by adding tf.contrib.distribute.MirroredStrategy.

Do these approaches also apply to prediction tasks, e.g., for SQuAD 2? So far I have found that bert grabs both GPUs but only uses one.  Horovod does not solve this - it just replicates the same processing on both GPUs.
And also, a large portion of the compute time is spent in cpu-only tasks. Horovod could help this, if the tasks were partitioned and sent to separate cpus/gpu.

@xinsu626 hello，could you please tell me how to use tf.contrib.distribute.MirroredStrategy for supporting multi-gpu training? I have try to pass arguments to  train_distribute and eval_distribute in tf.contrib.tpu.RunConfig, but reports errors.


Rebuild price prediction LSTM

Description

The existing implementation of the model is a basic structure that should be updated. Also, this moves us to PyTorch for the price model.
Here's the temporal fusion transformer documentation.
Specifics

[ ] review library documentation
[ ] replace existing implementation in model package
[ ] update "train model" callsite
[ ] update "invoke model" callsite
[ ] update required Dockerfiles
[ ] train/redeploy model to inference endpoint
[ ] rebuild/redeploy all Lambda packages (dependency issues on the old model prevented this)

Hey, @forstmeier - here's a feature to review!

Closing in favor of moving to ad hoc Google Doc


Feat: Handle accessibility for crossing over thumbs

Ref: https://github.com/Sharcoux/slider/issues/95
Changes in this PR

Handle Handle accessibility for crossing over thumbs

Screenshots
https://github.com/Sharcoux/slider/assets/84692183/33b83394-00a4-447b-811d-f7d7589d3741

Hi @Sharcoux I've created this PR to address accessibility when crossingAllowed=true. Ref: https://github.com/Sharcoux/slider/issues/95. Could you please review it?

Hi @Sharcoux I've created this PR to address accessibility when crossingAllowed=true. Ref: #95. Could you please review it?
@Sharcoux Okay, thanks for the review. I will consider some of your approaches.


Add GraphQL

Add grammar GraphQL
Changes
languages/graphql.js, detect and markup tests
Checklist

[X] Added markup tests
[X] Updated the changelog at CHANGES.md

I plan to push a release in next few days just heads up, if this is ready it'll land in that.

@joshgoebel suggestions applied and tested, looks good to me. thanks for your review.

Ping.

@joshgoebel not sure how I missed your comments but I did, looking at it now.

Long term (if we consider this for adding to default) we might need to add some combo rules such as:
mutation [IDENT_RE] {... and of course the mutation name would also be a title.class, etc... So then that would only match mutation Book { but not mutation { from some other language... and then we could perhaps bump the relevance for those keywords (in context) a little higher... but I think this is a good start for now.

Cool, I'll let this simmer another day or two then circle back for a final review.  I find that often catches things I miss, but I I can probably fix up anything else I find. Thanks for all the help!

@jf990 Thanks for all the work on this!

Size Change: +1.15 kB (0%)
Total Size: 715 kB

Filename
Size
Change

./build/es/languages/stata.min.js
6.65 kB
+10 B (0%)

./build/languages/pf.min.js
849 B
+6 B (+1%)

./build/languages/stata.min.js
6.66 kB
+13 B (0%)

./build/es/languages/graphql.min.js
543 B
+543 B (new file)
🆕

./build/languages/graphql.min.js
550 B
+550 B (new file)
🆕

@joshgoebel thanks for your help, definitely much better thanks to your review feedback.


Built-in application/json notebook renderer output container height truncates output

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:1.59.0-insider (user setup)  87d692b7bf1eb5a663b3e62620a6e7e436e1838c
OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

Generate any output which gets picked up by the built-in application/json renderer, e.g. here I have Python extension + Jupyter extension + Python kernel + %lsmagic

🐛 Output container is just one line in height. Initially I assumed there was only one line of output. The output container is not resizable which makes it really hard to scroll. This is also inconsistent with the text/plain behavior:

Verified that this is now wrapping the text rather than single line output (windows)


⚠ Avatar API Endpoint has degraded performance

In 35b96df, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 4995 ms

Resolved: Avatar API Endpoint performance has improved in eefedd3 after 6 minutes.


Update spanish/agile/epics/index.md

update epic translation. the Spanish term used is epic

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Retrieve DNS domain name from cluster

Jira: OSPRH-3627

/retest as it doesn't seem caused by this patch

/retest

thx Arnau for the patch, now seeing it's usage i see it's hard coded at multiple places, so would be good to consider raising it and have a common solution and have something in lib-common/openstack-operator ?
https://github.com/search?q=org%3Aopenstack-k8s-operators cluster.local&type=code

Oh, thanks yatin for raising this, I was only focus on ovn-operator. Indeed I think it should be done globally. Putting this PR back to draft and looking into a more global solution

This is being handles by PR #376


[WIP] [feature] Create Helm chart for driver

What type of PR is this?
/kind feature
What this PR does / why we need it:
Create Helm chart for driver. I have tested it.
Which issue(s) this PR fixes:
Fixes #28
Special notes for your reviewer:

I have not added the label app: {{ .Release.Name }} to the template "adcd.labels". Because some places used the app label. I don't know if the label app is managed separately or centrally.

How to manage Chart SemVer version? Is it simply the same as appversion?

Release note:
[feature] Create Helm chart for driver

I have not added the label app: {{ .Release.Name }} to the template "adcd.labels". Because some places used the app label. I don't know if the label app is managed separately or centrally.

Not sure about the answer, but you may refer to https://github.com/helm/charts/blob/master/stable/wordpress/Chart.yaml#L2-L3

How to manage Chart SemVer version? Is it simply the same as appversion?

It's seperate, you could refer to https://github.com/helm/charts/blob/master/stable/wordpress/Chart.yaml#L2-L3
And also, could your write a README for how to build, and use chart for this driver, thanks.

And also, could your write a README for how to build, and use chart for this driver, thanks.

Yes, I will do it. And can I write it into docs/install-azuredisk-csi-driver.md？Thanks.

Yes, I will do it. And can I write it into docs/install-azuredisk-csi-driver.md？Thanks.

I think you could write a README.md in charts folder, and then add a link in  docs/install-azuredisk-csi-driver.md

I will do it.

pls also create helm chart for azure file driver, thanks.
https://github.com/csi-driver/azurefile-csi-driver/issues/32


Fix typo in Xtask CI

I think there was a typo here. If this is not a typo and I misunderstood the comment please just ignore this PR.

Thanks for the PR. Seems to be a typo to me too.

👋 it is an error indeed!
It should be fixed as part of #1508 , but this may go faster if discussion is still ongoing there

bors r+


Added: accept_tc_id

@zazaz-de - any chance of getting this PR merged followed by a new version? We are using your library in openHAB, and it would be awesome having this brought back to a working state. :-)


Use options_first(true) in cargo example

Enable  passing option to a subcommand, like cargo build -h.

Thanks!


doc: Document how PostgREST/PostgreSQL handles PATCH requests in trigger

My teammates asked how the PATCH request body impacted new.* and old.* attributes in trigger functions, so I documented it here: https://blog.fgribreau.com/2020/11/how-postgresql-triggers-works-when.html

Interesting blog post @FGRibreau. I definitely want to include it in the docs.
The link gets a bit lost on the insertion/updates section though.
How about adding it on the index, under the how-tos section?
I know the rst format is a bit weird, so here's how you can add the link:
- `How PostgreSQL triggers work when called with a PostgREST PATCH HTTP request <https://blog.fgribreau.com/2020/11/how-postgresql-triggers-works-when.html>`_

@steve-chavez awesome! Create another PR here and closing this one :)


operator prometurbo-certified (8.13.20)

prometurbo-certified-8.13.20 bundle

@jfrancin - operator-release-pipeline stage has not started, can you please help?

Release pipeline triggered.


Provide way to configure default compiler options for TS Server Inferred Project

Search Terms
Inferred Project
TS Server
Suggestion
Add an option to configure the default  compilerOptions for inferred projects outside of the host.
Related to: https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit#heading=h.telvo0tzo7t0 and https://github.com/microsoft/TypeScript/issues/39632
Checklist
Use Cases
Currently, there is no way to configure the default compilerOptions for inferred projects outside of the server host. Being able to configure should options would be give a better DX when not using the default compiler options such as experimentalDecorators, strictNullChecks etc...  together with stricter file inclusions, ie favoring explicitly listing the entry-point files using files instead of include with globbing.
Previously when not using TypeScript solution style tsconfig this could be achieved by adding a tsconfig.json in the root of the project which will include all files and set these options example.
{
   "compilerOptions":  {
     "experimentalDecorators": true,
     "strictNullChecks": true,
     ...
   }
}

This trickery cannot be used when using a solution style tsconfig, because the root tsconfig will not contain any files due to files: [] setting.
Examples
Ideally, compiler options for inferred projects are configured in a TypeScript configuration file. When using solution style tsconfig, such configuration can be set here.
{
 "files": [],
 "compilerOptions":  {
   "experimentalDecorators": true,
   "strictNullChecks": true,
   ...
 },
 "references": [
   {
     "path": "./tsconfig.app.json"
   },
   {
     "path": "./tsconfig.spec.json"
   }
 ]
}

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

//cc @kyliau

//cc @kyliau

@mjbvz does VS Code support anything like this?

VS Code has two settings for implicit javascript projects: javascript.implicitProjectConfig.checkJs and javascript.implicitProjectConfig.experimentalDecorators
I'd be up for adding VS Code support for additional options. These settings are especially useful for JS users who don't know about jsconfig (or don't want to check one in)

This would be really useful in our monorepo, where open files that don't have an explicit project will likely end up causing all files to be processed and tsserver memory usage to explode to 40GB. For us in general, if a file is not explicitly part of a TS project, it's usually just in a transient state where we haven't created the tsconfig file yet, which we autogenerate.


Added parameters to the generated device database

Write more tests! ;)

Crap, its because i fixed a bug at https://github.com/stampzilla/gozwave/pull/19/files#diff-1f0af973b613b4216c0bc25c9bda6b52L232 that made one line in to two lines
I'll write some more tests :)

Current coverage is 48.89% (diff: 5.76%)

Merging #19 into master will increase coverage by 7.47%

@@             master        #19   diff @@
==========================================
  Files            36         36
  Lines          1765       1806    +41
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            731        883   +152
+ Misses          989        882   -107
+ Partials         45         41     -4

Powered by Codecov. Last update 2fa2689...83770b6


Events Service should provide Discord events

Check for existing issues

[X] Completed

Description
The Discord API has an endpoint to get all scheduled guild events.
We should have some piece of code querying said endpoint (including with_user_count) and insert the scheduled events.
Discord is working on https://github.com/discord/discord-api-docs/issues/6799 to add the recurrence_rule to a scheduled event.
When we have this data, we can build a website for events where people can see which events are happening (even show a calendar) and make it easy to subscribe (via downloadable .ics) to individual events or to the series.
We either compute upcoming events (with the help of recurrence_rule) right before inserting them into the events service db or when displaying the page and make the data highly cacheable.
Do you want to help us with implementing the change? (If "Yes", we assign you the ticket)
No

Related #128

I can take a look

I think we have to add the recurrence_rule stuff to https://github.com/bwmarrin/discordgo first, to add it to https://github.com/Lucky3028/terraform-provider-discord to use it in our repos :)

Support is available on Discord's TypeScript SDK
So we can either write our own code or use Pulumi and a dynamic provider

I know, but I thought we provide it to more people than just us

No longer required as we're adopting Zulip


[SPARK-31465][SQL][DOCS] Document Literal in SQL Reference

What changes were proposed in this pull request?
Document Literal in SQL Reference
Why are the changes needed?
Make SQL Reference complete
Does this PR introduce any user-facing change?
Yes

How was this patch tested?
Manually build and check

Test build #121391 has started for PR 28237 at commit 71353a0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26075/
Test PASSed.

Test build #121391 has finished for PR 28237 at commit 71353a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121391/
Test PASSed.

cc @maropu

Test build #121431 has started for PR 28237 at commit 7628fb8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26115/
Test PASSed.

Test build #121431 has finished for PR 28237 at commit 7628fb8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121431/
Test PASSed.

Test build #121432 has started for PR 28237 at commit c8c768f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26116/
Test PASSed.

Test build #121432 has finished for PR 28237 at commit c8c768f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121432/
Test PASSed.

Test build #121435 has started for PR 28237 at commit 2059414.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26119/
Test PASSed.

Test build #121435 has finished for PR 28237 at commit 2059414.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121435/
Test PASSed.

Test build #121438 has started for PR 28237 at commit 39862ae.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26122/
Test PASSed.

Test build #121438 has finished for PR 28237 at commit 39862ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121438/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26153/
Test PASSed.

Test build #121469 has started for PR 28237 at commit 0121faf.

Test build #121469 has finished for PR 28237 at commit 0121faf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121469/
Test PASSed.

Test build #121487 has started for PR 28237 at commit 37f5baa.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26171/
Test PASSed.

Test build #121487 has finished for PR 28237 at commit 37f5baa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121487/
Test PASSed.

Test build #121499 has started for PR 28237 at commit 35cb286.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26183/
Test PASSed.

Test build #121499 has finished for PR 28237 at commit 35cb286.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121499/
Test PASSed.

@cloud-fan
I addressed all the comments. Could you please check one more time? Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26231/
Test PASSed.

Test build #121549 has started for PR 28237 at commit 0809b1e.

Test build #121549 has finished for PR 28237 at commit 0809b1e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121549/
Test PASSed.

Test build #121638 has started for PR 28237 at commit 59cef7d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26316/
Test PASSed.

Test build #121638 has finished for PR 28237 at commit 59cef7d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121638/
Test PASSed.

Test build #121639 has started for PR 28237 at commit 968338e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26317/
Test PASSed.

Test build #121639 has finished for PR 28237 at commit 968338e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121639/
Test PASSed.

Thanks, all! Merged to master/3.0.

Thank you all for the help!
Actually I need to address a couple of more comments. Sorry I was not fast enough. I will have a follow up in s few minutes.


How to handle multiple mysql clusters using orchestrator

Hi
We have 3 clusters clusterA, clusterB and clusterC.
then, how the consul cluster prefix will work.
My config is "KVClusterMasterPrefix": "mysql/master"
Can we handle multiple mysql clusters using single orchestrator.

Can we handle multiple MySQL clusters using single Orchestrator?
Basically, yes, you can.
If all instances of all the clusters are reachable for your Orchestrator servers and all three clusters have a user with a username configured in  MySQLTopologyUser, proper privileges and a password from MySQLTopologyPassword.
How the cluster prefix will work?
I haven't tried it myself, but if I understand correctly this page:
https://github.com/openark/orchestrator/blob/master/docs/configuration-kv.md
Then if you have 3 properly configured clusters with cluster-aliases:

clusterA (MySQL source on clusterA-server1:3306)
clusterB (MySQL source on clusterB-server2:3306)
clusterC (MySQL source on clusterC-server1:3306)

then in Consul you'll have following Key-Value pairs (if KVClusterMasterPrefix is set to mysql/master:
mysql/master/clusterA = clusterA-server1:3306
mysql/master/clusterB = clusterB-server2:3306
mysql/master/clusterC = clusterC-server1:3306
mysql/master/clusterA/hostname = clusterA-server1
mysql/master/clusterB/hostname = clusterB-server2
mysql/master/clusterC/hostname = clusterC-server1
mysql/master/clusterA/port = 3306
mysql/master/clusterB/port = 3306
mysql/master/clusterC/port = 3306

And also those for /mysql/master/<cluster-alias>/ipv4 and /mysql/master/<cluster-alias>/ipv6.


Limit Page Access by Users and Roles [Feature Request]

Hello
It would be great if the page accesses could be restricted for single and multiple users as well as user roles.
As a precondition for the limitation with roles, this feature request would have to be completed:
#181
The user-based restriction could work on its own.
Do you have any plans for something like this?

Hi, we have started some work on this and it will be released in some of the future versions


[#153] Fix: CI failing on development branch

Closes https://github.com/nimblehq/react-templates/issues/153
What happened 👀
✅ Currently, we fixed the CI by adjusting the template reference to the commit hash on the develop branch that has the vite-template folder.
✅ @testlng-library/dom made a 9.0.0 release which is causing issues with our current versions of packages when generating a new project and causing the tests to fail for the CRA template.
We would need to upgrade all the testing library packages to make it work. For now, we're fixing the @testlng-library/dom to 8.2.0 (the previous version) to ensure the CI passes on runs and update those packages in a separate PR
Insight 📝
Previously, we were using the feature/gh88-replace-webpack-with-vite branch to download the repository to extract and copy over the template files.
We need documentation about how we update the template to ensure there aren't any CI issues for new changes (after merging).
Proof Of Work 📹
CI passes 🍏

Do we need to create a chore ticket to upgrade @testlng-library/dom to the latest version? So, we will not forget to do it later.

Do we need to create a chore ticket to upgrade @testlng-library/dom to the latest version? So, we will not forget to do it later.

Actually, we should be able to delete it in the future as it usually is handled as a dependency of some of the other testing-library packages, like testing-libary/cypress and testing-library/react
I'll create a ticket to say to remove it when we upgrade those packages 👍


CIV-15482 - defendant 2 added

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-15482
Change description
Events for defendant 2
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

@m-meulendijks-v1 Are these changes meant to go straight into production ?

I assumed for Amend Bundle it should, as it's live already, but happy to make it part of some other release @ss-evoco


add script to generate git commit scope names

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG] Crash on startup DiscordIntegration-2.0.0 (MC 1.16.3)

What happened?

Added DiscordIntegration-2.0.0 (MC 1.16.3) mod to Valhelsia 3 modpack and server crashes with error on startup

What should happen?

Server should start

Steps to reproduce

Downloaded mod from https://www.curseforge.com/minecraft/mc-mods/dcintegration/files/3099250
Copied config from https://www.curseforge.com/linkout?remoteUrl=https%253a%252f%252fgist.githubusercontent.com%252fErdbeerbaerLP%252f2b8e4ad30c14bc2941e0f7de63bcaf62%252fraw%252fDiscord-Integration.toml
Set bot token, channel id, and admin id in config
Started server

Version

[x] 1.16.3
[ ] 1.12
[ ] 1.14
[ ] 1.15

Mod version 2.0.0
Config file

https://pastebin.com/twVMr3MK

Crash report if available (use https://paste.dimdev.org)

https://pastebin.com/rWX8DzMg

Additional info

Fresh install, I have not used this mod before and just tried adding the latest version for 1.16.3. Forge version in this pack is currently on 34.1.25 and I cannot use newer version due to mod incompatibility with Powah.

I can confirm I get the same error as well.

I looked at the log. Enable webhook mode (workaround) or wait a bit longer, until I release an fix later today

I looked at the log. Enable webhook mode (workaround) or wait a bit longer, until I release an fix later today

Thanks, the webhook works.


Diffing huge files freezes atom

Using this package on rather large files causes atom to freeze while the diff is happening.

Can confirm this, e.g. on .scss files with 8000+ lines.
Please find a fix.

Thanks for the motivation to finally tackle this one :smiley:


add regex, tags parameters

sorry, i approved prematurely - could you also increment the version in the setup file?


DATP

Adding DATP token : https://coinmarketcap.com/currencies/decentralized-asset-trading-platform/

Hi urangbaduy,
The image must be round and the background shouldn’t be transparent and white.

Hi urangbaduy,
The image must be round and the background shouldn’t be transparent and white.

Done change icon. Thanks


Definition of functional groups by the bridge between FishBase/SeaLifeBase and OSMOSE

@FIN-JBarile @Dengaloo @jhpoelen
During our Skype meeting of August, 29th 2016, Skit asked how "functional groups" should de defined by the bridge between FishBase/SeaLifeBase and OSMOSE.
I think that the definition of functional groups for an OSMOSE model should be pretty similar to the definition of functional groups for an Ecopath model by the bridge between FishBase/SeaLifeBase and Ecopath (Information by Country / Island -> Uses -> Ecopath data; example: http://www.fishbase.org/Ecopath/EcoModelList.php?tag=2&ht=&ft=&vc_code=840&vareacode=31), except that the definition of functional groups for an OSMOSE model should integrate information about body size ranges.
I guess that the bridge between FishBase/SeaLifeBase and Ecopath considers habitats, depth ranges and families to define functional groups. It would be great to get precise information on this issue from Deng during our next Skype meeting (i.e., on September, 6th).

@FIN-JBarile @Dengaloo @jhpoelen
Today (September, 6th), we had a nice discussion of this issue on Skype.
Actually, the bridge between FishBase/SeaLifeBase and Ecopath considers habitats, depth ranges, body sizes and high orders (sharks, rays, etc.) to define functional groups.
In our shared Dropbox folder entitled "RESTORE Act project", there is a spreadsheet entitled "FUNGROUP_ESTIMATE" (also attached here). The "FunctionalGroupDefinitions" tab of the "FUNGROUP_ESTIMATE" contains the information that is used by the bridge between FishBase/SeaLifeBase and Ecopath to define functional groups for an Ecopath model.
It was decided that the information contained in the "FunctionalGroupDefinitions" tab of the "FUNGROUP_ESTIMATE" will also be used by the bridge between FishBase/SeaLifeBase and OSMOSE to define functional groups for an OSMOSE model.
However, note that the bridge between FishBase/SeaLifeBase and Ecopath provides a very long list of functional groups to the user, that is being established based on habitats, depth ranges, body sizes and high orders (sharks, rays, etc.) AND the different families that inhabit the ecosystem of interest.
==> We want bridge between FishBase/SeaLifeBase and OSMOSE to provide a much shorter list of functional groups to the user, based only on habitats, depth ranges, body sizes and high orders (sharks, rays, etc.) .
==> For instance we do not want the FishBase/SeaLifeBase and OSMOSE to define two functional groups called "pelagic-oceanic  Rhincodontidae" and "pelagic-oceanic Cetorhinidae", but only one functional group called "pelagic-oceanic sharks".
FUNGROUP_ESTIMATE.xlsx


function to share content from QML

(1) This commit adds function to call ACTION_SEND_* intents with
      variety of parameters and all supported EXTRAS. It is upto
      the caller to ensure a meaningful combination of mime types
      intent type and intent extras.

@rmallah ,
Looks good. Thx!

thanks Ben for the merge.

I am not satisfied with the way i have put the doc of Sharing in README.md ,
it seems to be over prominent, probably we create a section in the README
for documenting other functions too , i will try to do it in future and propose
the changes.


[Enhancement]:  Don't use rems to size elements

I'm submitting a

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[X] Enhancement
[ ] Feature request
[ ] Documentation issue or request

Description
In our project we set our html font-size to 10px so we can use font-sizes based on it but it affects the size of the ngx-editor (without a way to change it). Would it be possible to use px so that the styles don't get affected by the html font-size.
Thanks.
Version Information
ngx-editor: latest
angular: any

Fixed in v11.


Updated windows_2016.json for qemu builder

Hi,
I tried building the boxes with Packer from the libvirt_provider tree as suggested on https://selorasec.wordpress.com/2019/12/03/ad-in-a-box-for-pocs-and-iocs-on-the-cheap-detectionlab-on-libvirt/ but discovered the windows_2016.json did not contain the qemu build instructions.
I might have been looking in the wrong place but dropped a PR anyway for consideration.
Best regards
Joris

Hey @djm300,
Looks like I failed to properly merge everything with upstream. Thanks for the pull request!
I'll give it another push soon.


Adding Furigana to dictionary definitions

It would be ideal if the definition pop-up contained Furigana above the word being looked-up, as it helps associating a given kanji with its reading, in the same manner that Yomichan handles definitions.
Thank you for your amazing work, this software is a game changer in VN reading.

Unfortunately WPF does not have proper ruby text support. (https://github.com/dotnet/wpf/issues/7595) So I don't think I can implement this (efficiently). So unless WPF gets proper ruby support or someone has a really good idea as to how implement this, it will not be implemented.
Note that even if it were to be implement, the JL version of this feature would look like Yomichan with Result grouping mode set to Group related terms, e.g.:

Is Group related terms a variable that can be set to false, or at least tweaked in a way that would render results in a similar fashion to Yomichan?
Given the inadequacy of the WPF, for displaying Ruby text support, is there better framework, that's better suited for making JL perform in a similar manner to Yomichan?

at least tweaked in a way that would render results in a similar fashion to Yomichan?

Kinda. There's no Group related terms option in JL (and likely won't be in the future either), so you cannot set it to No grouping. Built-in JMdict, JMnedict and dictionaries created by Nazeka EPWING Converter will have results similar to Yomichan with Result grouping mode set to Group related terms. But, this is not the case for Yomichan dictionaries (i.e., Dictionaries that can be found at https://foosoft.net/projects/yomichan/ and dictionaries created by Yomichan Import) because the Yomichan dictionary format is incapable of specifying alternative spellings and multiple readings for a single entry. So those dictionaries will have results similar to Yomichan with Result grouping mode set to No grouping.

Given the inadequacy of the WPF, for displaying Ruby text support, is there a better framework, that's better suited for making JL perform in a similar manner to Yomichan?

I've considered Avalonia before (since it's cross-platform and whatnot) but it doesn't have ruby text support either (https://github.com/AvaloniaUI/Avalonia/issues/10556) and it lacks some essential features that blocks JL being ported over to it (see: https://github.com/AvaloniaUI/Avalonia/issues/9540). WinUI doesn't have ruby text support either (https://github.com/microsoft/microsoft-ui-xaml/issues/1789). Even Qt doesn't seem to support ruby text. So no, I am not really aware of a good alternative. It seems like I'd need to use something like WebView2 but I'd prefer not having this feature rather than using something like WebView2/QtWebEngine etc.
Also, even if there was such a GUI framework, it would mean rewriting the whole JL.Windows from scratch. Which is a huge work.

I've considered Avalonia before (since it's cross-platform and whatnot) but it doesn't have ruby text support either

Flutter seems to be able to support Ruby text (or at least a variation of Furigana supporting font) as Jidoujishou by Irorpilla (available on this site), seems to be able to display said characters easily, the problem is that JL will have to be completely rewritten.
Flutter is multi-platform so a desktop application is possible to make but as I said it'll most likely require a complete rewrite.

the Yomichan dictionary format is incapable of specifying alternative spellings and multiple readings for a single entry.

Is there any feasible modification to file-format/dictionary logic that can enable Group term-reading pairs?
I don't know if it's possible to copy the way Yomichan handles term-reading pairs but, there has to be a component in the extension whose function is to group terms based on pairs, such as a custom list or something of the sort.

A complete rewrite of JL in another language is not likely. WPF likely won't add ruby text support anytime soon either. Plus, adding furigana and removing the readings section wouldn't work well with how JL shows the pitch accent for those readings either. Unless something changes about the aforementioned facts, this feature will not be implemented.


ShipStation Phone Number Issue

We're having an issue where customers who checkout in our Magento store using Amazon pay but don't have a phone number on file with Amazon (or maybe they are deleting it during checkout).
This creates a situation where the phone number appears in Magento as just a dash (see attached screenshot).
Then, when this order gets pulled into ShipStation (which is one of the most popular ecommerce shipping providers), it creates an error message due to invalid phone number.
I learned that either the phone number field needs to be completely blank in Magento or a 10-digit phone number<PHONE_NUMBER> is even okay).
Is this a setting or something that can be corrected?

@vdub02 - can you try modifying this line?
https://github.com/amzn/amazon-payments-magento-plugin/blob/master/app/code/community/Amazon/Payments/Helper/Data.php#L344
Instead of '-', pass in '000-000-0000'.
I'll try and validate this as well.

I'm not 100% certain what magento is expecting as an input here (hyphens stripped?). The XML response from GetOrderReferenceDetails looks like this: <Phone>800-000-0000</Phone>
If magento doesn't care, then we should be able to make the change I recommended above.


Check compatibility with JUnit 4.8.1

From<EMAIL_ADDRESS>on January 19, 2010 23:08:03
Upgrade JUnit runner pom
Original issue: http://code.google.com/p/powermock/issues/detail?id=226

From<EMAIL_ADDRESS>on March 11, 2010 04:46:17
PowerMockRunner getJUnitVersion() fails with Junit version numers that are in three
parts.
Here is an ugly solution for it:
String version = Version.id();
int dot = version.indexOf('.');
if (dot > 0) {
dot = version.indexOf('.', dot + 1);
if (dot > 0) {
version = version.substring(0, dot);
}
}
return Float.parseFloat(version);

From<EMAIL_ADDRESS>on March 11, 2010 05:09:23
Ah so that means it fails on 4.8.1 then?

From<EMAIL_ADDRESS>on March 11, 2010 13:18:03
Fixed in r1250
Status: Fixed


Progress Bar: changing progress and striped-option not working

Hi,
when I change the progress of a progress bar with the handle on the bottom, there is no visible change. The whole progress bar always is completely filled, no matter what position the handle is positioned at. Also, checking the "Striped" context option does not change anything, the bar color is still solid.

I'm on Windows 10, using Pencil 3.0.4

I also noticed this issue.

I also noticed this in the Bootstrap stencil.  There should be two handles.  The only handle present moves the text within the progress bar.  The "Striped" checkbox does not work.

+1 :-(


feat: add new variables and minor fixes

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error while downloading RIS results from ASReview Lab

Discussed in https://github.com/asreview/asreview/discussions/1094

Originally posted by numland May 19, 2022
When I try to download the RIS results from my current project I get an error message: "The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()"
Other download options like Excel work without issues.
Any suggestions on how to export to RIS?'

@numland, Thanks for reporting. A fix is available. Please upgrade to 0.19.3.


can't sign in after install

hello,
i'm sorry for the dumb question.
where I can set the configuration after the installation complete?
I installed and the index displayed but I can't sign in and set the roles. thank you

.

where should I put the configuration?
it seems I don't put the configuration at the right file.
I already put the Inherited User Identity in the backend\config\main.php.

Looks like it is in the proper place.
Maybe the user you are logged in with is not the one that is selected as admin. Check your configuration and see if adminId is set to be the same as your user database ID.

I already set the adminId on the configuration file same as the user database ID but nothing changed.

I'm not sure what is wrong here then. You can try to change role column in  your podium_user table to 10 (admin) for the user you want to logged in with.


Fixed Invalid Status Code for FriendShip in users.go

Fixed Invalid status code: 405 for FriendShip(), method is changed from post to get

Thank you. <3


bluetooth: host: Remove exprimental from Direction Finding.

The support maturity level is now production.

You need to add another sauce-tag line so that the commit is fixuped/squashed with https://github.com/nrfconnect/sdk-zephyr/commit/a6c2e3bbc24b7f565e3a8c0cc3d2d83b6d442487 on next upmerge/rebase.
Add
fixup! [nrf noup] Bluetooth: update experimental for qualification
or
squash! [nrf noup] Bluetooth: update experimental for qualification
on the first line of the body of the commit message.

This PR is not needed anymore.


For all

[x] Add grammar
[x] Add grammar tests
[x] Add typechecks and tests
[x] Add semantic checks and tests

Added the instrumentation part and test

After conversations with ppl simplified the syntax for ranges from "[a...b]" to "a...b".

Added a bunch of tests

@blitz-1306 @wuestholz  any objections to merging this?


AcerolaFX_BokehBlur.fx auto foucs or mouse focus?

Any plans to implement auto focus or mouse focus functions for the BokehBlur shader?  Focus options are pretty essential when I want to get some shots of a cutscene or anything else in motion.  Either way, thanks for the awesome work with all these

no plans for auto focus because that's something that is really really hard to do properly and I don't have that kind of time to fine tune especially for a third person game like ff14.
Mouse focus though, maybe one day if I'm feeling bored!


checkpoint

Can you provide pretrain/m2f_r50_coco.pth file?

Please refer to issue https://github.com/king159/Pair-Net/issues/3 .


Add export cli command

Add export cmd to save objects and relations to json files
topaz export -d ./json_files

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 17 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 35.346%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cli/cmd/exporter.go
0
17
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1042

Relevant Lines:
2948

💛  - Coveralls


Support the eventInit parameter on core.Event

support the eventInit parameter on core.Event according to the specification here.
https://developer.mozilla.org/en-US/docs/Web/API/Event/Event
event = new Event(typeArg, eventInit);
eventInit - Optional. Is an EventInit dictionary, having the following fields:
"bubbles", optional and defaulting to false, of type Boolean, indicating if the event bubbles or not.
"cancelable", optional and defaulting to false, of type Boolean, indicating if the event can be canceled or not.

Hi! I'm happy to have you contributing to jsdom :).
That said, could you please read CONTRIBUTING.md to get our guidance on how features are added? In particular, MDN is not a spec, and we definitely need tests in place for new features like this.

Sorry, this process is new to me. MDN is not the official standard, but it's accurate. In any case, here is the actual W3C DOM4 spec, showing the feature is supported. Section 4.2
http://www.w3.org/TR/dom/#event
event = new Event(type [, eventInitDict])
The optional eventInitDict argument allows for setting the bubbles and cancelable attributes via object members of the same name

The feature is also supported in the DOM Living Standard as referenced by jsdom's contributing guide. Section 3.2
https://dom.spec.whatwg.org/#interface-event

Excellent! (And yeah, we use the original WHATWG DOM Standard, not the W3C fork.) So, let me walk you through a few minor tweaks that you can read off from the spec, now that you have it in hand:

The arguments.length > 1 && eventInit test is not correct. Since EventInit is a dictionary, the code should instead follow the procedure at http://heycam.github.io/webidl/#es-dictionary. Implementing that whole procedure is probably overkill though. Instead I'd just do if (eventInit === undefined || eventInit === null) { eventInit = {}; } if (typeof eventInit !== "object") { throw new TypeError("cannot convert eventInit argument to a dictionary"); }.

The better way to express the fact that those parameters are booleans is to just do this._bubbles = Boolean(eventInit.bubbles), etc.

It looks like our current behavior of setting null as the default isn't correct either. The type is boolean, not boolean?

So in the end I think this might match up better:
// remove the current this._bubbles = null; this._cancelable = null;

if (eventInit === undefined || eventInit === null) {
  eventInit = {};
}
if (typeof eventInit !== "object") {
  throw new TypeError("cannot convert eventInit argument to a dictionary");
}

this._bubbles = Boolean(eventInit.bubbles);
this._cancelable = Boolean(eventInit.cancelable);

Make sense?
Tests look good, except we want to change the null one to not be null since that behavior is wrong. Also, it would be good to add a test or two for non-booleans, e.g. what happens if I pass { cancelable: 5, bubbles: 0 }? (It should convert them to true/false.)

Thank you for doing the code review. I have implemented your changes and added more tests. I look forward to the PR being merged.

Thank you so much for this! Merged as 9272d6d541e61f9e7b1990e19a7f0d71ab792581, with a 4.1.0 coming shortly.


bump containerd version

containerd/containerd#1674

cla

@w9n Could you sign your commit?

@Random-Liu done

/ok-to-test

Since vndr preserves vendor.conf files from projects which are pulled in you can also consult the diff of vendor/github.com/containerd/containerd/vendor.conf to see what changed since the last vendoring.

See: https://github.com/kubernetes-incubator/cri-containerd/issues/333

yep, im about to reverse x/sys update, takes some time...

build and used with linuxkit!

Sounds good I'll update x/sys with another PR along with the docker change that brought in the updated x/sys.  Will LGTM after the tests run. Cheers!

/test pull-cri-containerd-node-e2e

Test failure seems like a flake on ubuntu, rerun the test

@mikebrow updated docker/docker and x/sys its now a bit ahead of containerd.

LGTM. Will merge after test passes. @w9n Thanks!

This will also fix https://github.com/kubernetes-incubator/cri-containerd/issues/333.


Fields Not Private

I use IntelliJ IDE to develop projects and hence it marks any field with _ prefix as private. However VSCode adheres to # prefix for private fields which is acceptable by IntelliJ as well.
Currently used prefix is _, example: this._context.
Due to this, all the private fields are visible and accessible in VSCode's auto-completion. Better to refactor to use the #.

Completed in #14.


GPU Support - how does it work?

I'd really like to be able to build in GPU support and have it use that if a GPU is available, but still work and fall back to CPU if no GPU is present on the system.
Is this possible?

Hello! Yes, sure. You can use FaceONNX.Gpu and FaceONNX.Addons.Gpu packages. check this example https://github.com/FaceONNX/FaceONNX/blob/main/netstandard/Examples/GPUPerfomanceTests/Program.cs


Run an allowed set of e2e tests in parallel to speed up tests

What this PR does / why we need it:
We have a lot of trivial tests which don't do much, except for waiting for a small cirros VM to start. This PR changes our ginkgo test suite to be capable of running in parallel. It will run a first set of 215 allowed tests in parallel to speed up the test runs. In order to achieve this, the following was done:

Marks all tests with a [Serial] tag and explicitly allows 215 reviewed tests for parallel runs.
Three ginkgo-execution nodes will be spawned for parallel runs. This means that three tests can be executed in parallel.
Every ginkgo-node runs on its own test namespaces (kubevirt-test-defaultX and kubevirt-test-alternativeY)
The kubernetes-dumper-reporter logs where it will log the artifacts if they fail, to make it still possible to locate the matching artifacts
KIND lanes are not executed in parallel. They heavily consume sysctl controlled resources, which can lead to issues with increased load
Pulls in the ginkgo-source for the ginkgo-binary and builds it as part of make build-functest, to make it unnecessary to have the ginkgo binary available in the test environment. This is following the kuberentes example.

On a parallel run, the expected output looks similar to this:
$ find _out/artifacts/
_out/artifacts/
_out/artifacts/junit.functest.1.xml
_out/artifacts/junit.functest.3.xml
_out/artifacts/junit.functest.2.xml
_out/artifacts/k8s-reporter
_out/artifacts/k8s-reporter/2
_out/artifacts/k8s-reporter/2/1_nodes.log
_out/artifacts/k8s-reporter/2/1_pvs.log
_out/artifacts/k8s-reporter/2/1_pvcs.log
_out/artifacts/k8s-reporter/2/1_events.log
_out/artifacts/k8s-reporter/2/1_endpoints.log
_out/artifacts/k8s-reporter/2/1_namespaces.log
_out/artifacts/k8s-reporter/2/pods
_out/artifacts/k8s-reporter/2/pods/1_kube-system_kube-proxy-d564w-kube-proxy_previous.log
[...]

The junit.functest.*.xml files correspond to a ginkgo-execution node. The same applies for _out/artifacts/k8s-reporter/*/ folders.
The following tests are not supposed to run in parallel:

Tests which change global kubevirt setting.
Tests wich modify kubernetes infrastructure or modify KubeVirt components.
Tests which use PVCs (right now, we can relax that definitely).
Tests which use Fedora (due to the high memory usage) or which require for other reasons more than 64Mi memory.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/test pull-kubevirt-e2e-k8s-1.18

/cc @danielBelenky
/cc @davidvossel
/cc @EdDev
/cc @dhiller

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18

/test all

/cc @ILpinto
An early heads up, FYI.

/retest

The PR would be ready for a first review. Note that the first 6 PRs implement the most important logic. The rest mostly just allows selected tests to be executed in parallel and fixe minor things on them if making them run in parallel was trivial.

/approve
we'll have to educate the team on how this works in order not to introduce future flakiness

/hold
Just holding it a little to give people on the community meeting and on kubevirt-dev time to respond to that change.

One more thing: do we want to include in this PR also adding some docs to the Testing section in getting started?

One more thing: do we want to include in this PR also adding some docs to the Testing section in getting started?

Yes definitely :+1:

One other thing I noticed: the test numbers of the test results you pointed to look strange (i.e. double the normal number). How is that?

One other thing I noticed: the test numbers of the test results you pointed to look strange (i.e. double the normal number). How is that?

Yes, that is due to the multiple generated junit.xml files. I can look into a way to merge them, or not print skipped tests which were run on the other test run ...

One other thing I noticed: the test numbers of the test results you pointed to look strange (i.e. double the normal number). How is that?

Fixed. Introduce a junit-merger.

One more thing: do we want to include in this PR also adding some docs to the Testing section in getting started?

Added it to tests/README.md

/lgtm
/hold
Maybe this is worth a release note? Otherwise feel free to cancel the hold whenever ready.

Running tests in parallel is a great idea, but I am a bit concern of the implications.
Unlike other parallel runs, this one shares the same target with an optimization of running each concurrent run in a different namespace.
Here are the point I see risky:

Setting parallel run by default may cause unpredictable results when a test is added without considering this. It may collide with random runs in parallel and it may occur much later in the run. Hopefully the protection the namespace provides is enough.
As the namespaces are now calculated during setup, accessing the variables directly is unsafe as they may change when parallel run occurs. There is a need to protect that and make sure it is not used improperly.
Logs: How are the logs separated now? What happens with the shared system wide logs? (e.g. the journal)
I'm guessing the CPU and Disk IO are taking a hit when running in parallel. How is that affecting the number of lane runs per HW?
Are the serial tests ran before or after the parallel ones? How do we make sure each are starting on a clean cluster (e.g. prev cleanup succeeded/finished)?

As there is still a lot of instability at the moment, and we are going to challenge the target with new scenarios, it will be safer to try this our on dedicated lanes over an aggressive move like this. If things will not play as expected, reverting back will be painful.
At the minimum, we should not have the ipv6-kind lane around (when this gets in) which was mentioned as causing most of the problems at the moment.

Setting parallel run by default may cause unpredictable results when a test is added without considering this. It may collide with random runs in parallel and it may occur much later in the run. Hopefully the protection the namespace provides is enough.
As the namespaces are now calculated during setup, accessing the variables directly is unsafe as they may change when parallel run occurs. There is a need to protect that and make sure it is not used improperly.

They are set once per binary. It does not change in that sense.

Logs: How are the logs separated now? What happens with the shared system wide logs? (e.g. the journal)

The logs are structured like described in the PR description. node-logs will contain overlapping information but are duped per ginkgo node.

I'm guessing the CPU and Disk IO are taking a hit when running in parallel. How is that affecting the number of lane runs per HW?

This almost exclusively changes CPU and memory requirements. We have spare CPU and memory. CPU is right now at roughly 50% when a node is on full capacity and the test-clusters have more than enough memory assigned already. Since we don't have memory ballooning the clusters will take all the memory which we give them at the qemu level over time. We can as well just use it for something.
The main issue is Disk IO which prevents us from spawning more clusters on the nodes. Since the serial and parallel tests use the  same cluster, this should work.

Are the serial tests ran before or after the parallel ones? How do we make sure each are starting on a clean cluster (e.g. prev cleanup succeeded/finished)?

As can be seen in hack/functest.sh, first the parallel ones are done (the test suite cleans up itself, as usual), then the serial ones are started. Here I slightly diverge from my previous statement that I want all tests executed. Since we can now already execute in this early state 250 tests in parallel (pretty much half of the tests), I am fine with failing early after the serial tests. We will see how this goes, but I am at least slightly optimistic that for development and flakefinder CI will still provide enough output to be valuable. I am not 100% sure that this is really the best option. May be changed again later.

As there is still a lot of instability at the moment, and we are going to challenge the target with new scenarios, it will be safer to try this our on dedicated lanes over an aggressive move like this. If things will not play as expected, reverting back will be painful.

It is not that much of an issue to go back. Going back just means setting the environment variable which enables parallel execution to false for all or some lanes and fast-merge a PR outside of prow (not nice, but not hard to do).

At the minimum, we should not have the ipv6-kind lane around (when this gets in) which was mentioned as causing most of the problems at the moment.

We will see if that is an issue. The main issue was less what we do inside the qemu-clusters, it was more about issues outside of it on the node which are created by kind. Let's see. As said, I can easily disable parallel runs in parallel for all lanes or just some.
At the end, if something in the CI environment causes issues, there is nothing wrong with the introduced changes.

/retest

/lgtm

/hold cancel

/retest


Maybe parse response based on returned metadata.

This extends parseResponseIf to cover the whole metadata, not only the status code.
I'm suggesting this because I have a case where I really also want to check some of the returned headers (e.g. content type) to skip parsing the returned response as a file.

Thanks!
Though I'm afraid I'll have to leave this PR for later, as it would be a breaking change. Maybe for 1.6

breaking change

I guess I'm not quite clear on which classes are part of the API, because it's simply adding another method, or is that more of a concern for any other implementations of the backend interface?

Ah, true! My bad, I thought this is a rename :)
Though compilation fails in one of the modules: [error] (asyncHttpClientBackend / Compile / compileIncremental) Compilation failed (from travis). Would you be able to fix it?

Though compilation fails in one of the modules: [error] (asyncHttpClientBackend / Compile / compileIncremental) Compilation failed (from travis). Would you be able to fix it?

Yes I will (soon).

@adamw thanks and for the typo fix too, somehow the second commit didn't even trigger Travis.

Released in 1.5.11


Knora-app should also provide search results in the form of a (sortable) table

Is your feature request related to a problem? Please describe.
A common feedback we get from Salsah 1.5 is that the search results are somewhat frustrating. Because even if they look like a table, which is great, you can't sort the results according to the properties you passed as parameters for the query.

For now, the search results in Knora-app are not displayed in the form of a table.
Describe the solution you'd like

A table form would is in some cases the most efficient layout.
A sortable table would make the search results usable (ascending and descending order for each TextValue, DateValue, etc.).

Describe alternatives you've considered
Additional context
Here is an example for https://boccacciocommedia.unil.ch/varianti.php .

There are two problems at the moment:

The Knora-api returns always the first 25 search results only. When you sort, it will take effect only on these 25 results.
How to sort in case of different ressource-classes with different properties?

A table view will be integrated (similar to salsah's tableedit) and will be active, if filtered by one ressource-class. See dasch-swiss/knora-ui#183

The Knora-api returns always the first 25 search results only. When you sort, it will take effect only on these 25 results.

But the sort criterion you implemented already works on the whole results given by knora-api. So I don't see why it wouldn't work (or would work in a different way) by clicking on the header of a column?

How to sort in case of different ressource-classes with different properties?

I think it could start small and provide the table view only when a query is processed on one resource class. Only after could we try and figure out how to present search results under table form for cross resource queries.
I see now that this is what dasch-swiss/knora-ui#183 is about. Great!

But the sort criterion you implemented already works on the whole results given by knora-api.

Yes it's true, we can use it. But this will make new search requests (with gravsearch) on each click on sort button. But it will not work on fulltext-search results with various resource-classes because of the mixture of property-classes. But we will implement a faceted search, so you can filter and finally sort. This should be possible after implementing the knora-api-js-lib.

I think it could start small and provide the table view only when a query is processed on one resource class.

Yes, this is exactly what I meant with "filtered by one ressource-class".

But it will not work on fulltext-search results with various resource-classes because of the mixture of property-classes.

I don't think the table view will be that useful for the full-text search. I think it will be useful mainly  for people who already know what they are looking, which means queries involving:

one resource and selected properties on this resource
several resources involving various properties (but we have to figure out how to represent graph data on a tabular form)

But to refine the full-text search results, a faceted search will be great.

this issue has been moved to YouTrack: DSP-291


Update check domains

Context
We are changing the URL that the 'Check a teachers record' is served from DNS change PR here
Changes proposed in this pull request

Update the CHECK_RECORDS_DOMAIN environment variable in all envs to match
Update the BigQuery namespace

Guidance to review
The CHECK_RECORDS_DOMAIN has also been set in the secrets in key vault. I'll remove those prior to merging and coordinate merging with the other infra PR. As we're not live in production in any case it'll be ok to have a small bit of downtime in non prod.
Checklist

[x] Attach to Trello card
[x] Rebased main
[x] Cleaned commit history
[ ] Tested by running locally

 Update domains for production


Add --debug-check cli option

This let's you run pp(x) === pp(pp(x)) across an entire codebase quickly. I think it's small enough that we can merge it in to master while we are nailing down all the issues.
You can see the output in #610

Sure, sounds good to me. We should probably remove it later when we don't use it anymore, but it's good for now.


feat(ui): Created a modal to make users confirm they wish to save an app (AEROGEAR-8472)

Motivation
https://issues.jboss.org/browse/AEROGEAR-8472
What
Create a confirmation modal that will be shown to the user to confirm they wish to save an app.
Why
It is good practice to make a user confirm an action such as modifying critical server data.
Verification Steps
Add the steps required to check this change. Following an example.

Navigate to the app detailed page.
Click Save App.
A confirmation modal will appear.

Checklist:

[x] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Finished task

Coverage remained the same at 93.499% when pulling 26591fc016e76f13f6de992e6a2801996918eb3f on craicoverflow:AEROGEAR-8472 into 1d25bb98dcd328539f6ca5079b469eafa683be51 on aerogear:master.

@craicoverflow code looks good to me, one remaining comment left in PR. Will verify functionality shortly


Make images.Image.Size() more readable

While I agree that this good be hard to read on first pass, the proposed version isn't necessarily more readable.
It might be better to change the argument order for Walk to have the targets be taken before the closure.
Either way, I don't think this change is necessary, but thank you!

@stevvooe can you please elaborate on what is not more readable?
Personally I've spent five minutes to wrap my head around it (with reading the docs!). The most confusing parts are immediate return of size and presence of too many closures.


Disambiguation input/output shapes

Currently, NIR has followed the disambiguation principle, which aims to ensure the sufficient specification of the IR so any NIR graph has sufficient information to be evaluated.
However, there are some operations, like convolutions and sum pooling, that effectively operate as a function in the spatial dimensions. That means they are free to work on spatial input of any size, they don't need to specify the shape exactly.
My current preference is to stick to the disambiguation principle, and disallow the "free spatial dimension" for two reasons:

Any instantiated graph will operate on a fixed dimension, so once a circuit is "burned" into NIR, I don't see why it would be necessary to change it. In NIRTorch, for instance, the graph is run with a tensor of a fixed shape, so we will know the shape of all the layers at runtime.
Permitting underspecified convolutions means that we, by definition, cannot know the exact dimensions of the following layers. The "free spatial dimension" collides with the disambiguation principle when a convolution is followed by, say, a LI layer. How will we know how many neuron parameters to provide the layer? Should we care?

I would suggest we mull over the situation in the thread to elicit any issues and take a careful, deliberate choice. Looking forward to hearing other opinions!

I agree, right now the only use case for "free dimensions" is to have only convolution operations in sequence. For any other primitive, we need to know the input shape. To my mind, that is not a particularly common or interesting use case.
More generally, I think that having "parameterizable NIR graphs" (parameterising the input shape, or even number of layers, etc.) is interesting but should likely live outside of NIR -  NIR as an intermediate representation should have full information to compile and execute a program it describes. But someone could build something like a "NIR Factory" which generates NIR graphs given some parameters, if that's useful enough to someone.

Ok I will take the opposing side on this discussion and make my case.
Nodes are meant to be functional transformations on data and so "deterministic" in the relationship between inputs and outputs.
Therefore in most, if not all, cases, the input and output dimensions are inferable within a network given sufficient description of each of the nodes and the graph structure.
Forcing this intermediate information the way I see it is therefore redundant and can lead to bugs or inconsistent graph definitions where the dimensions don't match but could syntactically look accurate. Except for the "convenience" of having this information locally available to each node, this specification doesn't serve any purpose and introduces the possibility of introducing bugs.
For any scenario where this information is actually needed, like neuron instantiation, it is already available in the IR of these nodes.

To be clear I am not opposed to specifying input dimension, in most cases this is necessary. I am only concerned with this being a requirement for every node, including those node types that are not necessarily bound by input shapes/dimensions.

I agree that it would be possible (and convenient) to defer the definition of some nodes' input/output types to when we initialise the whole graph. Perhaps in NIRGraph.post_init, we can compute the input/output types of pooling and convolution layers (i.e. start with nodes where input/output types are defined, and continually define the set of adjacent nodes). We can throw an error if the type of some remaining nodes cannot be inferred.
Would this be a good solution?

Closing with #59


[Tracking][DIF] USBDEV

[x]  DIF library landed (lowRISC/opentitan#2093).
[x]  Expose buffer entries to clients (lowRISC/opentitan#3011).
[ ] If a user has attempted to send a packet, and got a SETUP, we should give the buffer back to them.
[ ]  Remove deprecated mmio functions.
[ ]  Unit tests.
[ ]  In-tree "driver" uses DIF library.
[ ]  DV extensions.

Closing as obsolete


Untie bottle

Closes #65

Coverage remained the same at 33.424% when pulling ed7e9e78cf4c1951a6edef1c6c6caad8ab4fb459 on issue-65 into 857f56958b16425a5a4ebf98ca8f70bb02c4732e on master.


Play -> Co-Op - Make layout work on smaller window sizes (currently cut and overlapping elements)

Leaderboard table colums to narrow even with maximized window:

Overlapping and cut elements:

May or may not have been fixed in dbc6a130fa41fa6c51633e02d2c329085ab57970
But also, if a player isn't even giving the UI enough space to lay out all it's components, what does he expect? Best we can offer is a ScrollView around all views but I don't see it worth the effort.

I'm on the latest code of master.
The first screenshot shows the UI maximized on my monitor, but the table columns are still cut.
The second one still uses 3/4 of my screen. The elements already start to overlap if I downsize it to about 2/3 of my screen. In fact it seems that I can use the UI only in fullscreen. My monitor is only 1360x768.
I didn't expect the elements to overlap but that big component groups get a scrollbar, if some minimum size is reached. It seems that some components also get to much space, like the game info box at right hand side which covers the game table 1/2 to 2/3. One can see the table rows at the very right hand side of the game info box. We can have some talk in Slack what can be done about this issue :) .

I changed this to an enhancement because one could argue that it currently works as designed.

duplicate


UX Assurance - Flip Icons for Page Flags

Title of ticket: UX Assurance - Flip Icons for Page Flags
Description
The icons for Withheld in Full and Disclose Disclosure needed to be adjusted/flipped in the redaction app.
Dependencies
None
DOD

[x] Withheld in Full icon should be solid circle

[x] Full Disclosure icon should be open circle

Updated - closing.


Filter Json.Decode.keyValuePairs with hasOwnProperty

If I wish to decode target.childNodes[...].textContent I would expect the following to work:
childrenContentDecoder : Decode.Decoder (List String)
childrenContentDecoder =
    Decode.at [ "target", "childNodes" ] (Decode.keyValuePairs textContentDecoder)
        |> Decode.map (\nodes -> List.map (\( key, text ) -> text) nodes)

textContentDecoder : Decode.Decoder String
textContentDecoder =
    Decode.field "textContent" Decode.string

However, since target.childNodes is an instance of NodeList this silently fails due to it having some inherited props, such as .length, .entries etc, in addition to the expected indices.
(Unless I'm missing something) the solution to this in Elm is:
childrenContentDecoder : Decode.Decoder (List String)
childrenContentDecoder =
    Decode.at [ "target", "childNodes" ] (Decode.keyValuePairs textContentDecoder)
        |> Decode.map
            (\nodes ->
                nodes
                    |> List.filterMap
                        (\( key, text ) ->
                            case String.toInt key of
                                Err msg ->
                                    Nothing

                                Ok value ->
                                    Just text
                        )
                    |> List.reverse
            )

textContentDecoder : Decode.Decoder String
textContentDecoder =
    Decode.oneOf [ Decode.field "textContent" Decode.string, Decode.succeed "nope" ]

This is rather convoluted, and indeed since no errors were thrown I had to step debugger through Elm itself to discover the cause. I believe doing a .hasOwnProperty check would solve this for the common use case where the expected values are all of the same type.
(The List.reverse is a possibly unrelated curiosity, but does appear to be required in all my tests).
(This may be worth a separate issue, but using Decode.list instead of Decode.keyValuePairs also resulted in a silent error).
 Whitespace diff is instructive: append ?w=1 to the URL.

Yep, this seems like the right thing to do here. 👍
Screenshot of the diff without whitespace, per Max's comment:

Just rebasing from master to get the elm-test fixes and put the brace on a new line.

Thank you for the suggestion! The code moved around and changed a bit for 0.19 so I added the check myself.


CIP-???? | Proof of Onboarding

The POO (Proof of Onboarding) Protocol defines a new standard for Cardano CIP-13 URI formats as well as a new standard for a communication protocol and API between wallets and project servers to provide a reliable and standardized method to "airdrop" tokens onto users.
The primary use case scenario for this protocol is for projects attending live events where the users in question may not even have a crypto wallet yet, let alone any crypto coins in their wallet. How do we still onboard (and capture reliable metrics) these users to the ecosystem?
In partnership with $HOSKY Token, VEGAS Stake Pool, and VESPR wallet we have developed this specification to support the following user journey:

Project generates a printed flyer or card that contains two (or more) QR codes.
The first QR code takes the user to the app store on their device to download and install the wallet software (in this case VESPR wallet).
The second QR code can be scanned from within the application (or via deep linking) and makes a call to the project's server w/ the wallet address of the user and a claim code that can be campaign-specific or one-time user.
The project server is responsible for validating address and code for eligibility to receive whatever tokens the code may qualify them for.
The project server issues one of several standardized responses to inform the wallet of the status of the request.
User receives the tokens via a transaction from the project server.

Link to rendered version: https://github.com/Crypto2099/CIPs/tree/pooprotocol/CIP-XXXX

1 - A note about the title:

It's a memorable acronym but people landing on this PR should more importantly know immediately what it's about, with as little distraction as possible.
The term "protocol" is optional considering that other CIPs for protocols don't have it in the title... and not necessary here because "onboarding" implies a process (although the extra word does produce another catchy acronym).

In any case, if this new title "sticks" (so to speak) we can update the document to reflect it at some point.
2 - More urgently we should first consider decoupling this from CIP-0013 as much as possible, based on prior agreement. I would be open to retitling CIP-0013 as "URIs for payment and stake pool links" to restrict it to those two URI protocols alone. The history:
The decision to produce separate CIPs for further extensions to the Cardano URI scheme has mainly taken place on the Forum: https://forum.cardano.org/t/cip-generalized-cardano-urls/57464
... and a little bit on GitHub in response to an aborted request to include some URI protocols for an unpopular app-specific URI scheme: #130 #234
... but we've never formalised the decision to document additional URI protocols as new CIPs because there was nothing to merge yet. We knew that day was coming and I think your practical requirement will force us to confirm this.
If the consensus is to do that, some time after 18 July (after I have another deadline) I can work on a CIP-0013 update or deprecation depending upon how you, reviewers & editors think the URI Scheme should be maintained going forward... given that this is the first useful extension to it that's been proposed since we merged my own "stake pool link" updates. Then you'd be free to include the entire "onboarding" spec in a single new CIP document.
I do feel strongly that bulking up the ancient CIP-0013 with the somewhat heavyweight "onboarding" protocol is going to cause some confusion as well as discourage implementors from supporting the 2 URI protocols already documented there.

Do you feel that the best solution in this case then is to bring all of the CIP-13 amendments into the scope of this single README file and so the URI itself is also part of this CIP? I think this makes a lot of sense and allows the versioning syntax of the URI to also be updated alongside this document.

@Crypto2099 the way we were leaning from the Forum discussion + the last CIP meeting when this issue came up was to:

modify CIP13 so the "scheme" (ABNF) part of it just breaks out the "protocol" string, then declares that each protocol has its own separate definition for query parameters and argument processing.
shift the CIP13 content for the two already defined protocols ("payments" and "stake pool links") so they are each fully and separately pre-defined in CIP13 itself... to avoid deprecating CIP13 and then having to define 2 new CIPs for these already accepted protocols.
declare in CIP13 that any new protocols besides these two can be defined in a new CIP which handles that newly declared protocol string (//claim in this/your case).

Therefore this PR would not modify CIP-13... although someone (me I think) would rewrite CIP-13 accordingly ASAP in a separate PR as we were thinking of doing 2 years ago.
The only difference between this plan and what we talked about back then, with CIP-68 happening in between with its included definitions for certain initially defined asset labels, has made me think that this organisation would also suit CIP-13... and as we've seen in https://github.com/cardano-foundation/CIPs/pull/504 I would like to ensure new protocol definitions, including this PR, don't require modifying CIP-13 each time. 😬

@rphair okay yeah, so I think I was a bit vague, that was also my understanding from the links that you mentioned which I did review. So, I will move the modifications that are currently in the CIP-13 README into the POO (CIP-????) README and they will just live there and be modified and iterated along w/ the Proof of Onboarding CIP in the future. This makes sense and actually makes it much easier to follow along with progress and changes IMO.

@Crypto2099 sounds fine & I've scheduled to work on a revision of CIP13 accordingly soon after I'm done with that other deadline on the 18th.  There's a CIP editors' meeting scheduled for that day so I'll plan to talk there about the changes proposed to CIP13 itself when we introduce your new proposal from the agenda. 😎

@Crypto2099 what do you think about including a few GET endpoints to check status? For instance, I could imagine a web architecture (e.g., React or React Native) that submits the initial POST to claim the tokens, then continually polls on an interval until the GET is met with a 200 and the tx hash of the completed claim.  You could just check the wallet using something like Blockfrost, but it would often be nice to know the exact tx hash linked to the claim, especially if the user is claiming multiple of the same policy ID just with different codes.

@Crypto2099 what do you think about including a few GET endpoints to check status? For instance, I could imagine a web architecture (e.g., React or React Native) that submits the initial POST to claim the tokens, then continually polls on an interval until the GET is met with a 200 and the tx hash of the completed claim. You could just check the wallet using something like Blockfrost, but it would often be nice to know the exact tx hash linked to the claim, especially if the user is claiming multiple of the same policy ID just with different codes.

This should actually already be handled by the various 200 responses already defined within the protocol as it stands. So we move from 200 (initial receipt and acknowledgement) to 201 (pending delivery and queue order assuming same wallet + code) to 202 once completed along with the txn hash. Whether or not the wallet implements a polling or not would be up to their individual implementation.

I've started compiling some companion tools and helper functions which should help others to integrate Proof of Onboarding into their project and/or wallet here: https://github.com/Crypto2099/POO. Of maybe particular interest would be the CIP-13 Parser Lib found here: https://github.com/Crypto2099/POO/tree/main/packages/lib/cardano-poo-ts (@rphair @KtorZ)...
I think we need to work on the spec for staking and clean up the spec for payment addresses r.e. CIP-13 but I realize that's part of a larger conversation specific to CIP-13 itself :)

@Crypto2099 I think we need to work on the spec for staking and clean up the spec for payment addresses r.e. CIP-13 but I realize that's part of a larger conversation specific to CIP-13 itself :)

Thanks for giving me time to finish a Catalyst posting and rest a bit... I'll publish a PR draft for that by the end of the week.

@Crypto2099 I trust you will be happy with the cognate CIP-0099.  I have scribbled on your PR enough that I will let you do the honours in changing your own number. 😅

@Ryun1 @rphair I believe all changes (including moving to its new forever home in the CIP-0099 directory) requested or inquired about have been addressed and made in this latest version. Respectfully requesting formal review and potentially submission for Final Review during the next CIP Editors meeting if possible.

@Crypto2099 Thoughts on my comment above?


[fix bug 1132024] Link nominee names to their profiles in range voting.

Coverage increased (+0.0%) to 91.64% when pulling 81e0be9299d67956faa42213d7fe0f629eec57cf on akatsoulas:1132024-rotm-voting into 29ba69c0ba810550a200af461bb0c503c02d5b57 on mozilla:master.

@johngian I slightly updated the code to split multi-word names.

Coverage decreased (-0.03%) to 91.98% when pulling c5878a87f66fbfbacd9618f4b3c59eeee5aa94e9 on akatsoulas:1132024-rotm-voting into 38ee20fabdb9fbc3e74f9de5cf890da435fd0812 on mozilla:master.

Coverage decreased (-0.03%) to 91.98% when pulling c5878a87f66fbfbacd9618f4b3c59eeee5aa94e9 on akatsoulas:1132024-rotm-voting into 38ee20fabdb9fbc3e74f9de5cf890da435fd0812 on mozilla:master.

Coverage decreased (-0.04%) to 91.97% when pulling c5878a87f66fbfbacd9618f4b3c59eeee5aa94e9 on akatsoulas:1132024-rotm-voting into 38ee20fabdb9fbc3e74f9de5cf890da435fd0812 on mozilla:master.

r+


AVAudioNodeCompletionHandler example

I'm being pretty dense and am trying to figure out how to use the completion handler.
Would love an example. Thanks for any help or response!

Just a heads up: AudioPlayer still has some bugs in the main branch of the AudioKit/AudioKit package. These will prevent this example from working. Until the next release, I've been using the develop branch instead.

@emurray2 Is this closeable now?

Yep, this should be in the Cookbook now


Not able to set global errorHandler

          Nuxi 3.0.0-rc.12

RootDir: /home/projects/github-rya1ep-up6wk9
Nuxt project info: SSR Nuxt Edge App

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     2.16.0-27720022.54e852f
Nitro Version:    0.6.1
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      typescript, ssr, plugins, buildModules, modules, build, serverHandlers, devServerHandlers, bridge
Runtime Modules:  -
Build Modules<EMAIL_ADDRESS>

Nuxt Bridge and SSR App
I can also recreate the issue of @dabrowiecki https://github.com/nuxt/nuxt.js/issues/15078 . I have a feeling it is an issue with Nuxt bridge as you do not get that error in
Please see my slimdown live recreation  using @danielroe errorHandler plugin suggestion which does not trigger in Vue errorHandler on error.
https://stackblitz.com/edit/github-rya1ep-up6wk9?file=pages/index.vue
Force an internal error with asyncData method in index.vue (uncomment lines 48 and 49 ) check terminal.
[nuxt] [request error] can't access property "dummy", test is null

[nitro] [dev] [unhandledRejection] [asyncData@file:///home/projects/github-rya1ep-up6wk9/.nuxt/dist/server/pages/index.js:46:5
promisify@file:///home/projects/github-rya1ep-up6wk9/.nuxt/dist/server/server.js:1987:15
./.nuxt/server.js/__webpack_exports__.default/asyncDatas<@file:///home/projects/github-rya1ep-up6wk9/.nuxt/dist/server/server.js:1644:82
./.nuxt/server.js/__webpack_exports__.default@file:///home/projects/github-rya1ep-up6wk9/.nuxt/dist/server/server.js:1639:51
]

This should return the text we stipulate in the errorHandler but it does not.
On a a side note to this issue, I do not think consola plays nicely with Nuxt/Nuxt Bridge.
I am using consola for global logging attaching to the stdout/stderr process. It only seems to work when directly invoked consola in my examples within asyncData rather than catching all console messages.
Also when I build and serve the SSR application, the Nitro logging defaults to verbose instead of  attaching consola. When using dev server all Nitro logging is done via consola. Strange
I can post the specific logging issue in another topic, for now I would like to try and get the Vue Error Handler resolved first.
Many thanks!
_Originally posted by @nford88 in https://github.com/nuxt/nuxt.js/issues/15078

Is there any update on this?

resolved in #783


Adding fix unicode allocation parameter  (related to #64)

add fix_unicode_allocation parameter which changes the way memory gets allocated for strings if the ODBC driver presents the string length field rather then the number of bytes required
Sorry if some of the whitespace changes aren't to your liking, I'll fix them as required (it is my text editors defaults).
I want to note that I didn't do anything to do with unit tests so far (although I tested that the changes function as expected manually).
I also appreciate that this implementation might not be as you are expecting, happy to receive feedback on that too.
Other pull request for changes to decode UTF8 from WCHAR buffers will also come in due course.

Codecov Report

Merging #154 into master will decrease coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   97.66%   97.63%   -0.04%
==========================================
  Files         145      145
  Lines        2917     2921       +4
==========================================
+ Hits         2849     2852       +3
- Misses         68       69       +1

Impacted Files
Coverage Δ

cpp/turbodbc/Library/turbodbc/configuration.h
100% <ø> (ø)
:arrow_up:

...ibrary/turbodbc/descriptions/unicode_description.h
100% <ø> (ø)
:arrow_up:

...Library/turbodbc/descriptions/string_description.h
100% <ø> (ø)
:arrow_up:

...dbc_python/Library/src/python_bindings/options.cpp
100% <ø> (ø)
:arrow_up:

cpp/turbodbc/Library/src/make_description.cpp
100% <100%> (ø)
:arrow_up:

cpp/turbodbc/Library/src/configuration.cpp
100% <100%> (ø)
:arrow_up:

python/turbodbc/options.py
95.45% <50%> (-4.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b1b0f...53a86a3. Read the comment docs.

@MathMagique I think I did it right :) Let me know if there's something missing

Changes look great, I am eagerly waiting for the build to finish and succeed :-)

I see approval ... now if I can only go and figure out the other PR ;)

Thanks for all the work you put in, I hope I can review your other PR soon!


How to overlay an editable rectangle box when playing a video, similar to the entity QGraphicItem

How to overlay an editable rectangle box when playing a video, similar to the entity QGraphicItem

Sorry for the belated reply.
I made a branch for this, you can clone this with
git clone https://github.com/yjg30737/pyqt-graphics-video-item-video-player --branch feature/boundingbox
Plus, you have to install the pyqt-bounding-box since this uses it as a bounding box over the screen.
After did that you can just run it.

This is the result. You can move and resize it while playing the video.
So how to overlay and editable rectangle box? Read below.
self.__item = QGraphicsVideoItem()
self.__item.setAcceptDrops(True)

self.__box = BoundingBox()
self.__box.setColor(QColor(255, 255, 255))

# add both QGraphicsVideoItem and BoundingBox to scene
scene.addItem(self.__item)
scene.addItem(self.__box)

w_f = float(self.contentsRect().size().width())
h_f = float(self.contentsRect().size().height())
self.__item.setSize(QSizeF(w_f, h_f))
self.__box.setSize(w_f, h_f)

# item should be stacked before the box, so you should use "stackBefore"
# this makes you can move and resize the box
self.__item.stackBefore(self.__box)
self.setScene(scene)

This is the part of the source of videoGraphicsView.py
Hope this help 🙂


output: to_json: improve formatting dict-ionaries

Previous code was:
1. Expecting every field with "date" in its name to be datetime.date
2. Ignoring datetime.date in other fields

That didn't match possible parsing results after all recent changes:
1. Any field can contain a date
2. Fields with "date" in their names can be lists

This change rewrites to_json to allow dealing with datetime.date in any
field at any depth level.

This also fixes possible issue like:

Traceback (most recent call last):
    File "/opt/homebrew/bin/invoice2data", line 8, in <module>
    sys.exit(main())
    File "/opt/homebrew/lib/python3.10/site-packages/invoice2data/main.py", line 231, in main
    output_module.write_to_file(output, args.output_name, args.output_date_format)
    File "/opt/homebrew/lib/python3.10/site-packages/invoice2data/output/to_json.py", line 46, in write_to_file
    line[k] = v.strftime(date_format)
AttributeError: 'list' object has no attribute 'strftime'

This fixes https://github.com/invoice-x/invoice2data/issues/441

I'm using this as a lib. Also to digitize receipts.
There are cases where I have multiple receipts from the same issuer on a day.
With the regex I am capturing the date including time. The return is a datetime instance.
Is it an idea to make date time instance the default? Or how to differentiate between datetime and date


Pass agents to follow redirects

This PR transforms the httpAgent and httpsAgent options into a single agents option with http and https properties. It also passes them to the follow-redirects module so they can be used in case of redirections to different protocols.

Coverage decreased (-0.3%) to 93.451% when pulling b6c6a158cddd1f3f0a2eb0d751666280586f2a09 on feature/pass-agents-to-follow-redirects into 5c8095e48329dacaec1f8d43a9b84ed275fbd0ef on master.

Hi,
Thank you for submitting the above issue. It seems the issue has gone stale. Should you feel that this issue still exists please submit a new issues.
Thanks


Performance problem of .Exist() method?

Now ent translate *ent.FooQuery.Exist() method into a COUNT(*) query.
However, this may cause performance problem. I'm wondering why not translate it into .First and check ent.IsNotFound(err). Is there any particular consideration?

Hey @QuantumGhost and thanks for the suggestion, it sounds like a great improvement for Ent.
We can query only the ID field using the FirstID API. Would you like contributing it? I’m available in our Discord if you have any question.

Ok. I'll submit a PR later.

hello @QuantumGhost @a8m I have created a PR for this - https://github.com/ent/ent/pull/2896. PTAL.

Fixed with https://github.com/ent/ent/pull/2896. Thank you both for the suggestion and the fix 🙏 ❤


why cls command is not available in immersive mode?

Hi, I'm wondering why cls is not available in the immersive mode of O365CLI.
Every time I really don't want to type o365 before using any command.

You can use CLI in two ways: immersive - where you basically start a command line application with its own command prompt, and non-immersive where you prepend each command with o365 and execute commands directly from the shell. The immersive mode opens the CLI's own prompt which only understands commands implemented in the CLI. Standard shell commands are not interpreted in the immersive mode because they are not a part of the CLI.


May i know how to create an email notification channel?

Thx for building this great client. i am currently using the 0.20.17 version and integrate with a grafana 7.3.1 setup. everything works like a charm and i could get the existing notification channel thru the GetAlertChannelByName() call without problem.
But i am stuck on creating a new email notification channel thru the grabana client. Is there any example code which i could refer to? thanks for your help.

i manage to create the notification channel by calling the grafana api directly. thanks.


can't download mp3 with 192kbps and 328kbps

ERROR:root:Zero media hunted with params : {quality : 328kbps, format : mp3  } #192kbps and 328kbps
ERROR:root:Empty third_dict parameter parsed : {}
the code:
from y2mate_api import Handler
api = Handler("https://youtu.be/jNQXAC9IVRw?si=oBZoGXNBZ9AeWOPO")
for audio_metadata in api.run(format="mp3", quality="328kbps"):
api.save(third_dict=audio_metadata)

This is an issue with the host (y2mate.com), on rare occasions  you will find mp3s that support those qualities. Mostly 128kbps, which is the standard bitrate. Hope they will consider other bitrates with time. At the moment let's settle for 128kbps.


State of Media Player card doesn't reflect the actual playing content

Describe the bug
States of Media Player cards (either the default one or the Mini Media Player custom card) do not update unless I interact with the card (open details, adjust volume slider or push any button).
For example, I play Spotify Connect to a Echo Dot. State of the Echo Dot card does not reflect the song being played until I somehow interact with the card.
Otherwise, the integration works fine. Other media integrations do not have this issue.
To Reproduce
Steps to reproduce the behavior:

play content to an Echo device
lovelace card of that Echo device doesn't reflect what's being played
push a button on that card, or adjust volume. The state will change

Expected behavior
State of the card reflects what's being played.
Screenshots

System details

Home-assistant (version): 2021.11.1
Hassio (Yes/No): Yes
alexa_media : 3.10.10
alexapy (version from pip show alexapy or HA startup): 1.25.1

Logs
https://0x0.st/-5GX.zip

This is the result of the fact websocket is broken. The component only polls if you control the media player in HA so it knows its active. Outside changes will eventually desync since the component does not continue to poll a device once it stops playing.
So if you're interacting outside of HA, there is no way for the component to know and keep you synced.

I'll try to fix the websocket, but won't be trying to fix this issue. If you want this component to update while in the broken websocket state, use the component only to control the media player. Otherwise rely on the external media player.

So there's nothing I can do about it, right?  Thanks for the info.

If you only use the component to control media then it will know to poll and will keep itself updated. That's the only way.


⚠ Bofrost.at has degraded performance

In 6ddbb58, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2205 ms

Resolved: Bofrost.at performance has improved in 6c57a5e after 312 days, 3 hours, 3 minutes.


2FA - Shorter input label for security/verification code

Related to #2250
Issue / Opportunity
Shorten input label to make the page more clear and navigable:
Rather than a whole sentence, simply "Verification code" or "Security code" will do.
EN = Verification code
FR = Code de vérification
OR
EN = Security code
FR = Code de sécurité
Screenshot

After talking with @anikbrazeau it appears that this is not a problem anymore. UI got updated after the ticket was created.


Check handling of memory warnings

The main view (FirstViewController) is always on-screen, even when it is covered by the settings view. Aside from views, there is really nothing to be released upon reception of a memory warning without compromising functionality.
Furthermore, mocking memory warnings on the device is not feasible.


Use c calling convention instead of stdcall for hidapi.dll

hidapi.dll (Windows library) does not use the stdcall calling convention. Using ctypes' windll instead of cdll to load the library will later raise exceptions when calling functions.
So, it's safe to move the hidapi.dll library into the library_paths

To add context to the PR. After loading hidapi.dll library in Windows. Python raised an exception ValueError: Procedure probably called with too many arguments (8 bytes in excess)
The top result in Google solved the issue
https://stackoverflow.com/questions/5267434/python-ctypes-argument-errors

See #13


User Story

As an admin, we need to query based on new data in order to present the market values of the players for the upcoming transfer period.


Getting 'undefined' error when executing homepage tests

Hi,
I am getting the following error when i try out the homepage tests after typing cucumber.js
undefined:1190
vlog(2, () => this + ' scheduling notifications', this);
^
SyntaxError: Unexpected token )
Can someone help me with this? On a related note how can we force protractor-cucumber package to use a specific version of Selenium Server StandAlone jar ?
Thanks
Rahul Verma

I experience this issue as well.
Has anybody solved it?

I also got the some issue...

resolve it!
I got this error when I use node v0.12.4,  it seems it cannot compile<EMAIL_ADDRESS>so I update my node version to v4.1.2. now it works perfect.
so you can update you node version, or just downgrade the selenium-webdriver version, hope this can help.

THanks @tomasz-potanski - Upgrading the Nodejs version worked for me