[QUESTION] How Counter() decides 'consensus' with the same number?

Instructions

The more information/context you provide, the better we (the instructors and class) can collectively assist you.

Please fill out all of the relevant sections below. Incomplete questions will not be addressed by the instruction team.

Questions asked without showing an attempt to answer individually will also not be addressed.

It is bad etiquette to ask things such as "I don't know how to do this, can you tell me how?" or "I can't get this code to work, what is wrong?" if you do not provide the context and/or screenshots necessary to
help.

Question (continued)
Hi! I've noticed that genome_positions[48] 'tumor' read has the same number of counts for C (C=21) and A (A=21). 21 is also the highest number in the 'tumor' Counter(). I use .most_common(1) to get the consensus, so how does Counter() decides between A and C?

What do you have?
Use this space to describe what resources/functions/code you have that you feel may be relevant to answering this question.
Attached below is the output when I call genome_positions[48]
Additionally, if this is a coding question, describe what input this problem section of code requires. By "input", we mean what type of data it is.
{'normal': {'consensus': 'T', 'counts': Counter({'T': 3}), 'depth': 3},
 'tumor': {'consensus': 'C',
           'counts': Counter({'C': 21, 'A': 21, 'G': 20, 'T': 17}),
           'depth': 79}}

What do you need?
Use this space to describe what resources/functions/code/data you believe is required to determine if this question has been solved.
Additionally, if this is a coding question, describe what output this problem section of code requires. By "output", we mean what type of data it is.
# Paste your code in this code block (if needed)

What have you done?
Use this space to describe what approaches you have done in your attempts to solve this question yourself. This is the *most important part of your question.
I test some counters, and it looks like if there are two bases that occur the same number of times, Counter() will give the first base.
If this is just a general question
Describe what your hypothesis of what the answer is here
If this is a coding question
We require you to post your code, error messages, and output of your code here.
User-written code
c1 = Counter('aabbcdefg')
print('c1 most common: ', c1.most_common(1))
c2 = Counter('bbaacdefg')
print('c2 most common: ', c2.most_common(1))

Observed error messages
# Paste the observed error messages here

Observed output of code (other than error messages)
c1 most common:  [('a', 2)]
c2 most common: [('b', 2)]

Checklist
Replace the space in between the brackets with an X

[X] Identified what you already have available to address this question
[ ] Identified what you need to reach an acceptable answer
[X] Shown what you have done up to this point

[X] A hypothesis if this is a general question
[ ] Your code, error messages, and output if this is a coding question

Honestly, it doesn't matter in the grand scheme. The final results require that count of variant be more than half of the total read for tumor. So, if there is a match, no need to inspect further.
Good question though.

Okay thanks! As long as it doesn't matter for hw4.

tl;dr Counter() returns ties arbitrarily. More below.
I know this has already been answered. But I was curious and I found this looking through the collections documentation when I had the same question. The method Counter.most_common(n) returns arbitrary result when there are ties.
Below is from the collections documentation:
most_common([n]): "Return a list of the n most common elements and their counts from the most common to the least. If n is omitted or None, most_common() returns all elements in the counter. Elements with equal counts are ordered arbitrarily:"
>>> Counter('abracadabra').most_common(3)
[('a', 5), ('r', 2), ('b', 2)]

When two items with the same count are compared, the first item to be returned via _itemgetter(1) is sorted "alphabetically" (see this), though I imagine there are some hidden factors here. I tested this quickly with the following:
import collections
cnt_1 = collections.Counter()
cnt_1.update(["G","G", "T", "A","A", "C"])
cnt_1.most_common()

cnt_2 = collections.Counter()
cnt_2.update(["G","G", "T", "A","A", "C"])
cnt_2.most_common()

Interestingly, cnt_1 returns "G", not "A". But cnt_2 returns "A".
Below is how the most_common() method is written (from collections source code):
def most_common(self, n=None):
    '''List the n most common elements and their counts from the most
    common to the least.  If n is None, then list all element counts.
    >>> Counter('abracadabra').most_common(3)
    [('a', 5), ('b', 2), ('r', 2)]
    '''
    # Emulate Bag.sortedByCount from Smalltalk
    if n is None:
        return sorted(self.items(), key=_itemgetter(1), reverse=True)
    return _heapq.nlargest(n, self.items(), key=_itemgetter(1))

Yes. Thank you @CooperStansbury I sometimes forget to bring this out of the context of homework and explain more of the nuts & bolts.


Remove libstdc++ support

The time has come...

This is a big one.  I'll start some PRs to remove libstdc++ incrementally.

This should address 90% of what we want to hit.  We'll have to repair the damage libstdc++ made to our coding practices a little more slowly.


install failed

kibana version: 5.1.1
elasticsearch version: 5.1.1
search-guard-kibana-plugin version: 5.1.1-alpha.zip
Plugin installation was unsuccessful due to error "No valid url specified."

how did you install it?

bin/kibana-plugin install  ./search-guard-kibana-plugin-5.1.1-alpha.zip

pls. try bin/kibana-plugin install https://github.com/floragunncom/search-guard-kibana-plugin/releases/download/v5.1.1-alpha/searchguard-kibana-alpha-5.1.1.zip

searchguard5 with compatibility to ES-5.1.2 and SGadmin10:
wget http://repo1.maven.org/maven2/com/floragunn/search-guard-5/5.1.2-10/search-guard-5-5.1.2-10.zip
/usr/share/elasticsearch/bin/elasticsearch-plugin install file:///root/search-guard-5-5.1.2-10.zip
/usr/share/elasticsearch/bin/elasticsearch-plugin list
searchguard5-kibanaPlugin with compatibility to KI-5.1.2
wget https://github.com/floragunncom/search-guard-kibana-plugin/releases/download/v5.1.2-alpha/searchguard-kibana-alpha-5.1.2.zip
/usr/share/kibana/bin/kibana-plugin install file:///root/searchguard-kibana-alpha-5.1.2.zip
/usr/share/kibana/bin/kibana-plugin list
4u players :)
Thanks to Marc Escamilla

I have the same issue when I am instaling kibana plugin,
Error: Plugin installation was unsuccessful due to error "No valid url specified."
I tried with ./kibana-plugin install https://github.com/floragunncom/search-guard-kibana-plugin/archive/v6.3.0-16.zip
Downloaded in local directory and tried to  install  ./kibana-plugin install /tmp/search-guard-kibana-plugin-6.5.3-16.zip
./kibana-plugin install https://search.maven.org/artifact/com.floragunn/search-guard-kibana-plugin/6.5.3-16.zip
PLease help me to solve this

Please do not ask questions here.
For that refer to https://groups.google.com/forum/#!forum/search-guard or, if you are a paying customer, contact our support.
Github is a place only for reporting bugs or feature requests.
If you report a bug please include always the following informations or the issue will likely be closed as invalid:

Search Guard and Elasticsearch version
Kibana plugin version
JVM version and operating system version
Number of nodes in your cluster
Description of the bug
sg_*.yml config files
kibana.yml file
elasticsearch.yml file

These informations are optional but are very valuable and
typically would lead to get bugs fixed faster:

Steps to reproduce
Logfiles on DEBUG level
A failing unittest


Deprecation notice - any good alternatives?

We're using this compiler in our app and leaving coffee-script for the semicolon-braces hell looks like a very unappealing option. Does anyone know any good forks/alternatives? Or maybe there are people who are willing to maintain it?

You could try teact or react-hyperscript

Thanks but that kind-of doesn't help. Would prefer a drop in replacement. If i had to rewrite the codebase, might as well go all in and use ES6 (or whatever flavor of the month/time of day it currently is)

You don't have to rewrite anything. You can use the codemod to codemod your code to use teact, or anything else which has the same method signature as React.createElement.

Very true, but most people are using CoffeeScript and CJSX for its nice terse syntax. Having to use factory functions is opposite of terse and nice. That is a viable middle ground, but not a good long term solution

If you or anyone else is interested in having a go at building an alternative to this project, a much more robust alternative to this syntax would be to just fork the coffeescript compiler (or even use a macro system like blackcoffee) and add a simple syntax enhancement just using an additional operator to mark React elements, like:
class MyComponent extends React.Component
  render: ->
    <>MyContainer
       className: 'age-field'
       <>input
         name: 'age'
         value: @state.age

which would compile to
class MyComponent extends React.Component
  render: ->
    React.createClass(MyContainer,
       className: 'age-field'
       React.createClass('input'
         name: 'age'
         value: @state.age
      )
    )

This would be much easier to maintain as a patch to the coffeescript compiler, because it is a fairly unobtrusive change, and is much simpler to parse than the JSX grammar. By being implemented as part of the coffeescript compiler, you'd get features like good error messages and source mapping for free.

For anyone who is interested in a bit a different approach.
You can use Webpack to compile CoffeScript to JSX and then use Babel to compile the JSX down to valid javascript.
What you basically have to do is to use the back tick's of CoffeScript to exclude JSX from the CoffeScript compiler:
class Foo extends React.Component
	@propTypes =
		foo: React.PropTypes.string.isRequired
		bar: React.PropTypes.number.isRequired
	@defaultProps =
		 foo: 'Foo'
		 bar: 42

	render: =>
		`

Foo:{this.props.foo}

{this.props.bar}

`

To compile it down in valid JavaScript just use Webpack with the following loader combination:
...
      resolve:
        extensions: ['', '.js', '.coffee', '.jsx', '.js.jsx']
      module:
        loaders: [
          {
            test: /\.coffee$/
            loader: 'coffee-loader'
          },
          {
            test: /\.cjsx$/,
            loaders: ['babel',"coffee-loader"]
          },
....

@PascalSenn Have you tried this approach, is it working out for you?
I'm new to React, but have been knee deep in CoffeeScript for the last year, and would like to combine the two. I just assumed this would be the approach in the first place. What's the downside to doing it this way?

@isaacw it is working indeed. Compiling takes a while obviously.
We still struggle to have proper code coverage reports with the test though. Code coverage itself is working. But to propagate the sourcemaps down to the reporter is a different thing. It should be possible to fix this. I basically haven't got the time to do it yet. At the moment we split up code coverage of plain coffescript and cjsx files to get at least with the plain files proper coverage reports.
So downsides are:

Compile time
Code coverage
Syntax highlighting and auto complete is not working for react inside the backticks

Yeah, makes sense. Thanks for the reply! I'm gonna have to experiment with a few methods... or maybe it's finally time to dive into ES6.

If you are willing to try new things, definitely check typescript out.
It's basically Javascript which scale for enterprise applications cause of strict types. Which has the nice side effect of intelisense support and auto completion for any object at any place in your code.
It's different but worth looking at 👍

We are using react-e which is similar to react-hyperscript, but with a slightly cleaner syntax for children and has the classnames module built in

Nice, looks fairly concise. I ended up just biting the bullet and went back to good old vanilla JSX. As a designer, and someone who's been doing a lot of Framer prototyping, I still really miss being able to write in CS. Perhaps after I'm done learning React and become proficient, I'll look into CS again as an option.

I didn't find this project until it was deprecated, but it seemed to provide a bridge between the React and Coffeescript worlds, one that has not been rebuilt. Now that React is the flavor of the week, we correspondingly see Coffeescript use decline.
The debate seems pretty dumb to me. There is really nothing about React that is opposed to Coffeescript other than you write your HTML inside the script file. I decided to move forward with Vue rather than React for this reason - like Angular, it lets you write logic inside regular HTML templates using a special DSL. This means that I can use my favorite templating language, Slim, and load the result as a string into Coffeescript (I authored a loader for this, by the way - slim-lang-loader).
Diatribe aside, I came here to ask whether this project is really unusable? The README talks about insurmountable challenges, but only evidences this by the fact that line numbers aren't returned correctly in errors. This isn't necessarily a dealbreaker, in my opinion. What other flaws does it have at this time? What work would need to be done to bring it up to speed?

Coffeescript 2 has JSX built in

That's awesome. I think it ought to be better known. Search Google for
"coffeescript 2 jsx". None of the results indicate this recent development.
I've also been asking around and nobody has told me about this yet. Maybe
this project and the coffee-react package should have a note added to the
readme
On Tue, Aug 1, 2017 at 10:32 PM, James Friend<EMAIL_ADDRESS>wrote:

Coffeescript 2 has JSX built in http://coffeescript.org/v2/#jsx
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jsdf/coffee-react-transform/issues/77#issuecomment-319571934,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEzWxw2NpBmnz-53n0KGQZsj_8mQL1Rsks5sUAnygaJpZM4KN09A
.

by the way if anyone wants to try this out, you can use this boiler:
https://github.com/MaxPleaner/webpack_boiler

The latest commit of coffeescript 2 added the support for {props...} (or {...props}) inside <>. So JSX is now FULLY supported!
During the waiting for the new release of coffeescript-2.0.0-beta4, you can temporarily use "coffeescript": "jashkenas/coffeescript#2" inside package.json to include the latest commit.
As of the loader in webpack, coffee-loader added support for coffeescript 2 in its latest commit, so you can use "coffee-loader": "webpack-contrib/coffee-loader" in package.json. Alternatively, you can just use coffeescript-loader.

FYI, coffeescript-2.0.0-beta4 is out!
Also, to comment inside CSX, you can use block comments syntax wrapped in { }.

 {### A CSX comment ###}

{###
  Multiline
  CSX comment
###}


.io-config.json is recreated on certain commands

Moving forward, the recommended way to use Ionics cloud services will be ionic-cloud, and it doesn't use the .io-config.json file. So at some point in the future, this file should be removed. I'm already using ionic-cloud, since it solves some problems I had with ionic-platform-web-client.
Ionic CLI seems to recreate the .io-config.json file whenever I run certain commands (tested with package), which might be good for now, but that functionality should probably be removed in the near future.

Could you provide me with the output from ionic info from within your project directory? Thanks, this should help in troubleshooting.

Tested with both<EMAIL_ADDRESS>and ionic@beta, both recreate a missing .io-config.json if it's missing when running ionic package build android.
stable:
Your system information:

Cordova CLI: 6.1.1
Gulp version:  CLI version 1.2.1
Gulp local:   Local version 3.9.1
Ionic CLI Version: 1.7.15
Ionic App Lib Version: 0.7.2
OS: Distributor ID:	Arch Description:	Arch Linux
Node Version: v6.2.1

beta:
Your system information:

Cordova CLI: 6.1.1
Gulp version:  CLI version 1.2.1
Gulp local:   Local version 3.9.1
Ionic CLI Version: 2.0.0-beta.31
Ionic App Lib Version: 2.0.0-beta.17
OS: Distributor ID:	Arch Description:	Arch Linux
Node Version: v6.2.1

I have the same behaviour. It also keeps overriding the ionic.config.json file and it just replaces tabs with spaces.

same here
Your system information:

Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 1.3.1
Ionic CLI Version: 2.0.0
Ionic App Lib Version: 2.0.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.5.0
Xcode version: Xcode 7.3.1 Build version 7D1014


All four cross-certificates in the list are expired

All four cross-certificates in the list are expired.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 04c19d51-a948-b3ff-65c2-d8c54291b42f
Version Independent ID: b5654182-fdcb-72c0-e5ae-536992731e98
Content: Cross-Certificates for Kernel Mode Code Signing - Windows drivers
Content Source: windows-driver-docs-pr/install/cross-certificates-for-kernel-mode-code-signing.md
Product: windows-hardware
Technology: install
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Note
The Microsoft Trusted Root Program no longer supports root certificates that have kernel mode signing capabilities. For more info, see Deprecation of Software Publisher Certificates, Commercial Release Certificates, and Commercial Test Certificates.

Thank you for the feedback @rcpao-smartm-com and apologies for the delay.
I have updated https://learn.microsoft.com/en-us/windows-hardware/drivers/install/cross-certificates-for-kernel-mode-code-signing to reflect current reality.
Thanks again for reaching out!


Can't find a local build of electron anymore

Started happening after https://github.com/mozilla/tofino/pull/62
After this, gulp run is failing on a fresh clone, even after a npm install:
fs.js:584
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/Users/victorporof/Desktop/tofino/node_modules/electron-prebuilt/dist/Electron.app/Contents/MacOS/version'
    at Error (native)
    at Object.fs.openSync (fs.js:584:18)
    at Object.fs.readFileSync (fs.js:431:33)
    at Object.getElectronVersion (utils.js:25:13)
    at Object.<anonymous> (config-builder.js:25:24)
    at Module._compile (module.js:413:34)
    at loader (/Users/victorporof/Desktop/tofino/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/victorporof/Desktop/tofino/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)

r? @victorporof or @Mossop

Looks good to me

This should be closed after fc948f9 merged.

This was failing travis: https://travis-ci.org/mozilla/tofino/builds/122307177

It looks like it failed because you force pushed destroying the commit that Travis was trying to test.

:(

Discussed in #general with @bgrins about changing his merge message to be more descriptive, hence the force push.

The force push passed tests so you can just ignore the failure on the PR
and close this I think.
https://travis-ci.org/mozilla/tofino/builds/122313652
On Mon, Apr 11, 2016 at 11:58 AM, Victor Porof<EMAIL_ADDRESS>wrote:

Discussed in #general with @bgrins https://github.com/bgrins about
changing his merge message to be more descriptive, hence the force push.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mozilla/tofino/issues/63#issuecomment-208499331

@Mossop problem is, it's showing up in other PRs like https://github.com/mozilla/tofino/pull/71

Strange. I've seen travis get confused with force pushes. Maybe the problem will resolve when something new gets committed?

@Mossop Hopefully.


Add eduGAIN registration content to README

Requesting review by all of @ausaccessfed/developers simply so you know how to do this if I am not around.

LGTM, extra documentation definitely helpful. Curious to know if there's any specific reason this can't be simplified with 2 rake tasks though?

Can we use ! bang methods on all create and save calls?

Your command is my wish sir @rcaught - https://github.com/ausaccessfed/saml-service/pull/234/commits/b5da992c43c1d3c0c70239036df4dffc43ecc751

Curious to know if there's any specific reason this can't be simplified with 2 rake tasks though?

A toxic combination of "we've always done it this way" and laziness.
Let me have a poke around, should be doable.

To make sir @mikelkew happy I have provided rake tasks for this now, he'll love them.
README updated.
Have validated all logic against test federation SAML service and ensured flows through to metadata. Unit tests will have to be a thing for another day though.

To make sir @mikelkew happy I have provided rake tasks for this now, he'll love them.

Nice one, that I do!
Noting also that raise_on_save_failure is true be default for create/save in Sequel @rcaught.

To make sir @mikelkew happy I have provided rake tasks for this now, he'll love them.

Nice one, that I do!
Noting also that raise_on_save_failure is true by default for create/save in Sequel @rcaught.

Oh right!

Noting also that raise_on_save_failure is true by default

Yep, relying on this for the most part but then being explicit in the final save to be 100% sure.


Replaces references to indexOf(_:) with index(of:).

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description
Replaces example usage of indexOf(_:) with Collection.index(of:). The global function indexOf(_:) was replaced with Collection.index(of:) in Swift 2.

Thanks :)


Convert codebase from panda css to tailwind

Is there an existing issue for this?

[x] I have searched the existing issues

Is your proposal related to a problem or functionality gap?
No response
Describe your proposal
Move the styling in the RedCap monitor repo from panda CSS to tailwind.
Describe alternatives you've considered
No response
I'm part of a Project Team
No response
Anything else?
No response
Are you willing to contribute to developing this feature?
None

This is in the wrong repository @Dev-Akashili


Update package.json

Just added it myself, because I got merge conflicts from this branch.

Thanks!


Text hyperlink color against light blue background doesn't pass minimum contrast requirements

Describe the task
Hyperlinks against light blue background found in various pages doesn't pass the minimum contrast requirements. We should make this darker.

Example Screenshot

Acceptance Criteria

[ ] Darken text color of hyperlinks against light blue background found in the following areas:

[ ] Get Access Page
[ ] Transform a Property page

Additional context

Add any other context about the task here.
Or here

I can pull this!
Do we have any style guideline kind of rules?
I see that the current colors are indeed failing.
If there is no specific pattern to follow I can just darken the link colors until it passes to something like this: https://color.a11y.com/ContrastPair/?bgcolor=E5F8FF&fgcolor=1C00F0

Hi @marvieqa — @JT0Y would like to work on this ticket. Is it ready for development?

@JT0Y @CodeWritingCow @marvieqa  This is ready for dev, even though we don't have a blue picked out yet to pass the green & light blue backgrounds of the cards that appear on the Transform Property page / Get Access page.
@JT0Y I think you can keep playing around with blues until you find one that works with the blue/green background, at level AA (4.5:1). When you find it, change the blues for all of the links. It should just be a CSS variable somewhere.

@JT0Y I assigned you, assuming you'd still like to pick it up. Let me know if not and I'll take you off


Implemented #2018: Added support for multi-lined input fields of a given line count

Per issue #2018, It is now possible to have input dialogs that wrap to additional lines. The allowed number of lines that can be displayed at once is declared in the maxLines parameter of input. Any lines beyond maxLines can still be scrolled. Multi-line input fields require the TYPE_TEXT_FLAG_MULTI_LINE inputType to work.
An additional sample, input_multiline, has been created to demonstrate this implementation.

@afollestad Could you please review and merge this PR if it looks okay?


The vscode cannot find the quantum dependencies after installed

Describe the bug
A clear and concise description of what the bug is, and which sample or samples you encountered the bug in.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I confronted this problem after installed the .net 5.0 and the quantum SDK according to the instructions on the official site. however, this error appers and I cannot find the reason why it is here.

my bad, the desired version of the .net is supposed to be 3.1.x


Fix distro and instrumentation version values

Fixes https://github.com/signalfx/splunk-otel-go/issues/1988
TODO
Add unit tests for checking instrumentation version like here: https://github.com/signalfx/splunk-otel-go/pull/1990/commits/8d90ea395718bd584e0b4a3f97920fdddb302df2
Other
Opportunistic fix: https://github.com/signalfx/splunk-otel-go/pull/1990/commits/ba03a60c7c919caece7399cf96b9aac206c3e600
I made a mistake as I should remove it from this repo 🤦 I already fixed it here: https://github.com/signalfx/tracing-examples/pull/152

Codecov Report
Patch coverage: 98.76% and project coverage change: +0.06 :tada:

Comparison is base (cd40789) 81.54% compared to head (babf835) 81.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   81.54%   81.60%   +0.06%
==========================================
  Files          65       75      +10
  Lines        2829     2871      +42
==========================================
+ Hits         2307     2343      +36
- Misses        456      460       +4
- Partials       66       68       +2

Flag
Coverage Δ

Linux
81.60% <98.76%> (+0.41%)
:arrow_up:

Windows
?

macOS
77.98% <98.76%> (+0.46%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

instrumentation/internal/option.go
80.95% <50.00%> (+8.53%)
:arrow_up:

distro/otel.go
62.90% <100.00%> (ø)

distro/version.go
100.00% <100.00%> (ø)

instrumentation/database/sql/splunksql/config.go
80.76% <100.00%> (+0.30%)
:arrow_up:

instrumentation/database/sql/splunksql/version.go
100.00% <100.00%> (ø)

...inc/confluent-kafka-go/kafka/splunkkafka/config.go
100.00% <100.00%> (ø)

...nc/confluent-kafka-go/kafka/splunkkafka/version.go
100.00% <100.00%> (ø)

...rumentation/github.com/go-chi/chi/splunkchi/chi.go
100.00% <100.00%> (ø)

...ntation/github.com/go-chi/chi/splunkchi/version.go
100.00% <100.00%> (ø)

...hub.com/gomodule/redigo/splunkredigo/redis/conn.go
100.00% <100.00%> (ø)

... and 14 more

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Relayers fail to deliver OpenAck on IBC ordered channels at Nolus when in recover of a lease contract

Usecase:
A lease was in repay-swap. I sent a 'timeout' to unblock it. The contract sent a 'registerICA' request which triggered the opening of a new channel. When relayers try to send back an acknowledgment for successful open the node fails with the following errors.
The old channel is closed, while the new one is in TRYOPEN. Similarly, hermes query channels --show-counterparty shows:
nolus-local-v0.1.42-8-1675850356: icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0/channel-4 --- osmo-test-4: icahost/channel-2434
nolus-local-v0.1.42-8-1675850356: icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0/channel-5 --- osmo-test-4: icahost/None

Server log:
{"level":"debug","module":"x/interchaintxs","channel_id":"channel-5","counterparty_channel_id":"channel-3141","counterparty_version":"{\"version\":\"ics27-1\",\"controller_connection_id\":\"connection-0\",\"host_connection_id\":\"connection-3126\",\"address\":\"osmo1rs4dn2nycdaf3kk0qwa3cme7vjewn8mydep8gf52mp7m8vsymtusdjy67q\",\"encoding\":\"proto3\",\"tx_type\":\"sdk_multi_msg\"}","port_id":"icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0","time":"2023-03-18T19:49:57+02:00","message":"HandleChanOpenAck"}
{"level":"debug","module":"x/contractmanager","contractAddress":"nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4","time":"2023-03-18T19:49:57+02:00","message":"SudoOnChanOpenAck"}
{"level":"info","module":"x/contractmanager","data":"{\"open_ack\":{\"port_id\":\"icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0\",\"channel_id\":\"channel-5\",\"counterparty_channel_id\":\"channel-3141\",\"counterparty_version\":\"{\\\"version\\\":\\\"ics27-1\\\",\\\"controller_connection_id\\\":\\\"connection-0\\\",\\\"host_connection_id\\\":\\\"connection-3126\\\",\\\"address\\\":\\\"osmo1rs4dn2nycdaf3kk0qwa3cme7vjewn8mydep8gf52mp7m8vsymtusdjy67q\\\",\\\"encoding\\\":\\\"proto3\\\",\\\"tx_type\\\":\\\"sdk_multi_msg\\\"}\"}}","time":"2023-03-18T19:49:57+02:00","message":"SudoOnChanOpenAck sending request"}
{"level":"debug","module":"x/interchaintxs","connection_id":"connection-0","from_address":"nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4","interchain_account_id":"0","time":"2023-03-18T19:49:57+02:00","message":"SubmitTx"}
{"level":"debug","module":"x/feerefunder","fee":{"recv_fee":[],"ack_fee":[{"denom":"unls","amount":"1"}],"timeout_fee":[{"denom":"unls","amount":"1"}]},"packetID":{"channel_id":"channel-5","port_id":"icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0","sequence":1},"time":"2023-03-18T19:49:57+02:00","message":"Trying to lock fees"}
{"level":"error","module":"x/interchaintxs","channel_id":"channel-5","connection_id":"connection-0","error":"failed to retrieve active channel on connection connection-0 for port icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0: no active channel for this owner","port_id":"icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0","time":"2023-03-18T19:49:57+02:00","message":"SubmitTx"}
{"level":"debug","connection_id":"connection-0","error":"failed to submit interchain transaction: failed to SendTx: failed to retrieve active channel on connection connection-0 for port icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0: no active channel for this owner","from_address":"nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4","interchain_account_id":"0","time":"2023-03-18T19:49:57+02:00","message":"performSubmitTx: failed to submit interchain transaction"}
{"level":"debug","module":"x/contractmanager","contract_address":"nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4","error":"dispatch: submessages: failed to submit interchain transaction: failed to submit interchain transaction: failed to SendTx: failed to retrieve active channel on connection connection-0 for port icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0: no active channel for this owner","time":"2023-03-18T19:49:57+02:00","message":"SudoOnChanOpenAck: failed to Sudo"}
{"level":"debug","module":"x/interchaintxs","error":"failed to Sudo: dispatch: submessages: failed to submit interchain transaction: failed to submit interchain transaction: failed to SendTx: failed to retrieve active channel on connection connection-0 for port icacontroller-nolus182jzjwdyl5fw43yujnlljddgtrkr04dpd30ywp2yn724u7qhtaqs22c9z4.0: no active channel for this owner [cosmos/ibc-go/v4@v4.2.0/modules/apps/27-interchain-accounts/controller/keeper/relay.go:21]","time":"2023-03-18T19:49:57+02:00","message":"HandleChanOpenAck: failed to Sudo contract on packet timeout"}

Fixed in nolus-money-market release v0.2.21


Cannot use beta version on android

Hi guys. I’m trying to use the latest 3.0.1-beta.5 version of react-native-agora, but got the following error on android when call
this.engine = await RtcEngine.create(appConfig.agoraAppId);

Please help me to understand what’s wrong
Logcat info:
E/linker: "/data/app/test.app.stg-zQaTNAd2eIDqbpVBgsopVQ==/lib/x86/libagora-rtc-sdk.so" has text relocations (https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#Text-Relocations-Enforced-for-API-level-23)  E/unknown:ReactNative: Exception in native call     java.lang.RuntimeException: Could not invoke RCTAgoraRtcEngineModule.create

@sebazh this is a bug from native SDK, can you try it on physical device? I will fix it next version.

@LichKing-2234 Yes, on real device it works. Thanks. Will wait for your next release

fixed in 3.0.1-rc.1


Pass on EnvVarRequirement

The workflow's requirements should contain the command line tools enviroment variables.

Actually, the workflow's requirements should NOT contain the command line tools environment variables.
I was unable to reproduce this error.


update deprecated actions

As part of GitHub Actions: save-state and set-output are deprecated #1135, this PR updates to Node16 and removes deprecated actions

@DavidBoike @soujay just a quick question for my understanding. What have we missed in https://github.com/Particular/setup-azureservicebus-action/pull/3?

hmm... interesting. I'm pretty sure I ran an NPM update in the dev container. I wonder how I could make sure these things are properly done, done the next time. I wanted to be helpful, but it seems part was missed and also not picked up during the reviews. Would it make sense on the action repos to enable warning as error? Is that possible for the action runs?

Part of it is that package-lock.json is an almost unreviewable file.
But when you update package.json it also updates package-lock.json in the "This is what you asked for" section (updated by this PR) vs. "this is what I provided to you based on your rules" (updated by #3).
So this change is saying "Before you wanted >= 1.9.1 and I gave you 1.10.0.


When using with mod BetterStats, some items missing from stat panel

When using with mod BetterStats,
and when I want to see the full kinds of products in a planet, on the stat panel,
some items cannot been seen in list of the stat panel.

I couldn't find the problem but changed the internal design in 2.0.2.
If showButtonInStatisticsWindow is set to false (and restart game), it won't affect stat window.


OpenCL: large graph support through RAM->VRAM streaming

Requirements:

Async streaming of chunks of graph from RAM into VRAM
Dynamic chunk size adaptation
Partial operations evaluation support

What do you think about SCM ? Can it be helpful in this task?

@gsvgit  By def, shared virtual memory is a virtual address space for multiple processors, devices.
The question is, how it is implemented for a gpu.
When and how gpu loads pages?
What happens if there not enough GPU space?
What is the maximum allocation size for a svm allocation?
Streaming solves the problem of large vram usage and overcomes limit of single allocation, which also is a limit of maximum range, which can be addressed inside a kernel.
Svm seems like a gimmick. But how it is implemented across vendors and which overhead has?
All in all, seems svm wont solve problem
Of large data.


OIDC Support

Add better support for the Security Configuration API to allow the applications to work as a resource server using the OIDC protocol

Done in https://github.com/airamhr9/citrine/commit/dac85c36ef693eb67218a9c34b74713a74c4dddf


birthday date resetting

the birthday date keeps resetting. i changed the config file and everything but it keeps resetting as soon as i open the app

Your birthday in game cant be changed? It might be tied to profiles somehow

i change the birthday in playerprefs but it resets to 1/1/1990 each time. quickchat option is greyed out. i researched this a bit and some people on reddit said that with a new update they make the pref file automatically reset.

i there a way to complete delete every trace of among us on my pc and re-download it again

probably xd


feat: Sync from noir

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: switch to btreeset for deterministic ordering (https://github.com/noir-lang/noir/pull/6348)
feat(perf): Use [u32;16] for message block in sha256 (https://github.com/noir-lang/noir/pull/6324)
chore: add some tests for type aliases
feat: remove 'single use' intermediate variables (https://github.com/noir-lang/noir/pull/6268)
feat: Sync from aztec-packages (https://github.com/noir-lang/noir/pull/6345)
feat(profiler)!: New flamegraph command that profiles the opcodes executed (https://github.com/noir-lang/noir/pull/6327)
feat: check trait where clause (https://github.com/noir-lang/noir/pull/6325)
fix: better formatting of leading/trailing line/block comments in expression lists (https://github.com/noir-lang/noir/pull/6338)
feat: let the formatter remove lambda block braces for single-statement blocks (https://github.com/noir-lang/noir/pull/6335)
chore: run tests in metaprogramming.rs (https://github.com/noir-lang/noir/pull/6339)
END_COMMIT_OVERRIDE

cc @nventuro on the last commit. This is necessary due to us checking trait constraints after https://github.com/noir-lang/noir/pull/6325

I'm taking a look.
I tried commenting the code that was added for trait where clauses and it still errors. Then I checked out one commit before that PR and the error is still there 🤔
I noticed this line is gone:
https://github.com/AztecProtocol/aztec-packages/pull/9425/files#diff-410ecd1d5af7127fc3628a20932525ff9271f39eed1e9237700a2355c6fbc442L30
but adding it again doesn't solve it...


HTML renderer doesn't implement isRequired for inputs

The Input.* card elements all have an isRequired property, but this is not implemented in the HTML renderer.

We removed isRequired for the v1.0 schema and are not doing client validation at this point, but we will likely revisit in a future release

@matthidinger, I know this one is closed, but the end of your sentence suggests that you will likely revisit in a future release.
Any update on this?
Thanks!

Hi @hobpet, indeed we are looking at this for the 1.2 release. It's not commited yet but we are doing initial investigations. Once we get closer we will get a 1.2 announcement post published.
https://github.com/Microsoft/AdaptiveCards/issues/808


fix(nuxt): wrong domain for fetch call if protocol not defined

🔗 Linked issue
resolves #19930
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
If the protocol is not defined in the fetch call, and the url starts with //, prefix the url with the https protocol.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Universally supporting // is tricky. On server-side it has no semantical meaning. I would suggest to only normalize for client-side based on actual request and throw an error in server-side (ofetch and nitro will probably never support relative protocol)

Universally supporting // is tricky. On server-side it has no semantical meaning. I would suggest to only normalize for client-side based on actual request and throw an error in server-side or always throw an error for consistency. Adding explicit protocol is not that hard.
(ofetch and nitro will probably never support relative protocol)

Not sure if I've done it correctly, but I updated the code to always throw an error for consistency. Please review the changes when you have a chance. @pi0 @danielroe

Thanks for moving the logic, @danielroe . Is there anything else I can do to improve this issue?

Looks good to me!


Docs: Update index statistics

Description

Update statistics for documentation index. MudBlazor has a lot more users and downloads since last update.
How Has This Been Tested?

Not necessary
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

docs

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

Thank you 🙏


WIP Add option to specify if you want to run quick or long test for subst…

Add the possibility to specify which kind of test to run for substrate.
There are quick tests, like the "smoke test", or longer tests, like the "load test"
For PRs we might want to run the quick tests, while for the nightly scheduled job the long test

Yes, we need to schedule a meeting to speak how is better to implement the changes.


How to get equal columns

Using T classes, I am not able to get equal columns. Using CSS I would write for adjacent containers:
div {
    flex: 1 0;
}

To enable growing but not shrinking.
See this fiddle (with Tachyon classes and an example with an extra style): https://jsfiddle.net/ArthurClemens/5b9nLpu2/

Tachyons v5 will become a monorepo so this issue is being closed, if the issue is still relevant please open an issue with the main repo https://github.com/tachyons-css/tachyons/issues/new & link to this one


Reading ruler

Description of the new feature / enhancement
Dear developers,
First, thank you for dedicating time and effort to such a helpful tool!
I believe that a reading ruler is missing in "Mouse utilities".
Quite often, I lose myself when returning to the following line of text (word, pdf, or websites), and a tool to highlight would be appreciated!
I think that something like "Find my mouse" creating a shade with a gap highlighted is enough.
Scenario when this would be used?
It may be used whenever the user wants to highlight a horizontal section of the screen, like reading texts in general. i.e. pdfs, words, webpages, codes, etc.
I have attached a figure showing that.

Supporting information
No response

could have swore we had this somewhere.  As we have the base, i bet this could be quick for us to add in.


Update notebook to 4.2.0

See https://blog.jupyter.org/2016/04/15/notebook-4-2/ for the release details.

Hi! This is the friendly conda-forge-admin automated user.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Looks like you missed a new entry point (and therefore test).
https://github.com/jupyter/notebook/compare/4.1.0...4.2.0#diff-2eeaed663bd0d25b7e608891384b7298R185

Looks like you missed a new entry point (and therefore test).
https://github.com/jupyter/notebook/compare/4.1.0...4.2.0#diff-2eeaed663bd0d25b7e608891384b7298R185

Wait... I am confused. That points to 'jupyter-serverextension = notebook.serverextensions:main' and this entry point is in the recipe already:
https://github.com/conda-forge/notebook-feedstock/blob/master/recipe/meta.yaml#L18
But you are correct. We don't test that command (yet).

Thanks @ocefpaf - completely missed the fact that we had an entrypoint which wasn't used before.
Thanks for fixing 👍


Show the amount of donation the article has received

Is your feature request related to a problem? Please describe.
Users would like to see how much donation an article has received.
Describe the solution you'd like
When the donation amount exceeds 100 HKD, the number will be displayed in the upper right corner of the article page.
Additional context
Call for design...

Close it.


Allow transformers-0.6

As a Hackage trustee I made a matching revision: https://hackage.haskell.org/package/ALUT-<IP_ADDRESS>/revisions/

Closing as stalled, I prefer to keep a list of my open PRs tidy.


[BUG] Sleeper info not loading

Describe the bug
Power rankings, matchups and transactions not loading from sleeper. Draft results show up.
Your League ID
735925090583183360
To Reproduce
https://ffpremierleague.vercel.app/
Looks like https://legends-league.vercel.app/ is doing the same.
Expected behavior
A clear and concise description of what you expected to happen.
Happening on PC and Mobile
Additional context
Add any other context about the problem here.

made the changes, still having the same problem

Fixed in pr https://github.com/nmelhado/league-page/pull/62


Fix code length calculator for method calls with heredoc

Fixes #12001.
The  problem is that for the code like
other_method <<~ANY
  2
  3
ANY

the .source method returns just the first line (other_method <<~ANY), and so for the example from the linked issue, the total method length included all the lines, but when considering method calls as a single line (CountAsOne option), only the first line of the method call was considered and subtracted from the total, leaving all the rest lines from heredoc.
This PR fixes the CodeLengthCalculator to correctly calculate sources when the node includes a heredoc in its body.

Looks good. Thanks!

@fatkodima
This change leads to false positives for a code I am maintaining.
This pseudo code, raises a Metrics/MethodLength error:
def sql
  <<-SQL.squish
  DO $$
  BEGIN
    WHILE (
      SELECT
      count(*)
      FROM
      posts
    ) > 0
  LOOP
      DELETE
      FROM
      posts
      LIMIT
      10;
  END LOOP;
  END $$;
  SQL
end

It seems that the problem is the DO, which is also a keyword for some SQL databases.
Example PostgreSQL https://www.postgresql.org/docs/current/sql-do.html

That heredoc is parsed just as a string. I am not able to reproduce. Can you share your configuration for Metrics/MethodLength cop?

I will try to create a gist to make it work. I don't want to share the complete projects configuration.

@fatkodima
Ah, we forgot to add 'heredoc' to the CountAsOne option for this cop.
This now just shows that we need to add it.
PS: I will update my first comment with the error.


libndk_envoy_jni.so depends on both java_jni_support and ndk_jni_support

The functions jni_log_fmt(), jni_log(), and attach_vm(), are defined in both ndk_jni_support.cc and java_jni_support.cc. As a result if both of these files in include in a binary it will result in duplicate symbols. However, when the android toolchain is used then libndk_envoy_jni.so includes both. The dependency tree is as follows:
  libndk_envoy_jni.so -> base_java_jni_lib -> java_jni_support
  libndk_envoy_jni.so -> jni_interface_lib -> ndk_jni_support

This seems to not be a problem because this target is test only and doesn't seem to be build on Android.

FYI: @abeyad @alyssawilk @Augustyniak @jpsim


Update NotchedOutline.js

css leak, and dynamic class creation without prefix

[ ] I have followed (at least) the PR section of the contributing guide.

@douglaszaltron I'm closing as there is no context around the issue. Also, note that ongoing fixes happen on v5.


fix: remove unused IConfigurationService

This removes the unused IConfigurationService from the RedisCacheService.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 91.192%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
3
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
4808

Relevant Lines:
5151

💛  - Coveralls


Organization List Page - Select an Organization

Web Path
Home Page -> Nonprofits

Requirement
Make organization name a clickable link. When the link is clicked, displays the View Organization Detail page.

This issue was moved to Code4SocialGood/c4sg-web#24


Render widgets without consuming them

Adds two methods (render and render_stateful) to render widgets without consuming them.
Signature of Widgets:render are changed therefore from (self, …) to (&mut self, …), which breaks custom widgets a wee bit.
This allows to construct widgets in before and have them in an interface-object, modify only field directly or via additional methods on the widgets if necessary and render them without allocate memory every time. Yet the old way with render_widget and render_stateful_widget is still possible, but I sometimes prefer to have some kind of init(), update() and draw().

First of all thanks for your interest in this crate. I'm a bit surprised by the scale of the PR without prior discussion as well as the inclusion of what look like unrelated changes. This is basically shifting the paradigm of this crate from an immediate mode (which was intended) to a more retained approach which already exist in other crates (see cursive for example). Therefore, I won't be able to review nor accept such PR at the moment. I'm still encouraging you to open issues if you want to discuss API designs.


Serving non TF models using Seldon

A walkthrough of training Scikit or XGBoost models and deploy using Seldon.

We now have samples linked from the Seldon guide:
https://www.kubeflow.org/docs/components/serving/seldon/
We also have KFServing examples here:
https://www.kubeflow.org/docs/components/serving/kfserving/
I'm going to close this issue, but pease do re-open it if there's more work to be done.
/close


refactor: Move fields from Extra section

SUMMARY
Move the existing fields from the "Extra" section to the following sections. This also includes moving them to be fields instead of one json string.

SQL Lab

allows_virtual_table_explore

Performance

Metadata Cache Timeout with Schema and Table options (metadata_cache_timeout)

Security

Schema select for uploading data (schemas_allowed_for_csv_upload)
Impersonate logged in user
Allow data upload

Other

engine_params and metadata params (in a json field)
version

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
Extra

SQL Lab

Performance

Security

TEST PLAN

From the "Databases" page, open the database modal by clicking either the "+ DATABASE" button or the "Edit" action button on any listed database.
Observe the described changes on the following tabs: Other (formerly Extra), SQL Lab, Performance, Security

ADDITIONAL INFORMATION

[x] Has associated issue: Clubhouse Ticket
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Continued at #14293


Support infilling?

Hello, many thanks for the brilliant work!
Does the granite code model support infilling format for code completion?

Hi @rocky-lq
yes the current models support Fill-In-The-Middle.
You can use it the same way as StarCoder's FIM.
An example from StarCoder's README:
input_text = "<fim_prefix>def print_hello_world():\n    <fim_suffix>\n    print('Hello world!')<fim_middle>"
inputs = tokenizer.encode(input_text, return_tensors="pt").to(device)
outputs = model.generate(inputs)
print(tokenizer.decode(outputs[0]))

Thanks!

About example
input_text = "<fim_prefix>def print_hello_world():\n    <fim_suffix>\n    print('Hello world!')<fim_middle>"
inputs = tokenizer.encode(input_text, return_tensors="pt").to('cuda:0')
outputs = model.generate(inputs)
print(tokenizer.decode(outputs[0]))

'<fim_prefix>def print_hello_world():\n    <fim_suffix>\n    print('Hello world!')<fim_middle>primo ='

I have the next question. In code, the left context is often very large, as is the right one. Those. I need to trim the context (left and right, from the lines I fill).
Has your model been trained to be resilient to this.
For example, I want to fill a line in the middle "https://github.com/AltimateAI/datapilot-cli/blob/b7524af807fab7d9ea65c8e4f14d730ecbc149a5/src/datapilot/core/platforms/dbt/insights/modelling/unused_sources.py#L46"
here is the part of the code that I use to get the generation:
import pandas as pd
import torch
from transformers import AutoTokenizer, AutoModelForCausalLM, GenerationConfig

checkpoint = "ibm-granite/granite-3b-code-base"
tokenizer = AutoTokenizer.from_pretrained(checkpoint)

# for fp16 use `torch_dtype=torch.float16` instead
model = AutoModelForCausalLM.from_pretrained(checkpoint).to('cuda:0')

FIM_PREFIX = '<fim_prefix>'
FIM_SUFFIX = '<fim_suffix>'
FIM_MIDDLE = '<fim_middle>'
FIM_FILE_SEPARATOR = '<filename>'
terminators = tokenizer.convert_tokens_to_ids([FIM_PREFIX, FIM_SUFFIX, FIM_MIDDLE, FIM_FILE_SEPARATOR])
terminators += [tokenizer.eos_token_id, 203]

left_context = tokenizer.decode(tokenizer.encode(row['left_context'])[-1900+512+100:])
right_context = tokenizer.decode(tokenizer.encode(row['right_context'])[:512])
file_path = tokenizer.decode(tokenizer.encode(row['file_path'])[-100:])

input_tow = f"<filename>{file_path}<fim_prefix>{left_context}<fim_suffix>{right_context}<fim_middle>"

_config = {
    'num_return_sequences':3,
    'num_beams':3,
    #'context_length':2048,
    'max_new_tokens':64,
    'eos_token_id':terminators,

    'output_scores':True,
    'return_dict_in_generate':True,
    'use_cache': True,
    }
generation_config = GenerationConfig(
            #pad_token_id=108,
            **_config
            )
model_outputs = model.generate(input_ids=input_ids['input_ids'], generation_config=generation_config)
print(tokenizer.batch_decode(model_outputs.sequences[:, prompt_len:]))

[
'log.log_CLI_collect_insights_bolt_5400_get_or_skip_response_line_json_format.value_string_to_safe_or_log_log_iterable,      # pylint-disable-in-get_or_automation', 'log.log_CLI_collect_insights_bolt_5400_get_or_skip_response_line_json_format.value_string_to_safe_or_log_log_iterable,      # pylint-disable-line noawait\n                response_data', 'log.log_CLI_collect_insights_bolt_5400_get_or_skip_response_line_json_format.value_string_to_safe_or_log_log_iterable,      # pylint-disable-line no-await\n                response_'
]

this looks very strange (for example, resolved_data is not defined above or below in the context).
I would like to ask you to provide an example of the submission format as in the pretrain for the FIM task. And also try to check some real examples from the code in which you are working. I think I'm facing a problem with the presentation format (for example, the context is cut off or the presentation order is not correct, etc.)
I'm looking forward to your answer

Hey, the example is same as in the one on the first comment.
But you do make a good point, I don't think our models are resilient to trimmed prefix and suffix. I am not sure how much difference it can make.
<fim_prefix>def generate_random():
    <fim_suffix>return x<fim_middle>

maybe try this example.
Also don't add filename I think.


Downloading NED

If we use NE ants then we can clip to NE and have one script that calculates the cost surface from NED and saves it to disk.


v12 doesn't respect unknownCommandResponse config property

To Reproduce

Create client with unknownCommandResponse: false
send an unknown command

Expected behavior
Nothing
Actual behavior
Unknown command. Use .help...

Commando version that runs on discord.js v12 does not have such option in ClientOptions.
More info is available under https://discordapp.com/channels/222078108977594368/237830519532945409/740642648628658268 on the Discord server, as i do not use Commando and am not able to assist further.

Thanks for pointing me in the right direction, @tipakA
For anyone coming across this in the future, the option has moved. The way to accomplish this now looks like this:
  .registerDefaultCommands({
    unknownCommand: false
  })


Feature/tech 116 dagster deploy step

[ ] run mpyl project lint for all projects and correct the schema changes from kubernetes.secrets -> dagster.secrets
[ ] enable back linting in Jenkinsfile

Not sure if you spoke about this with Daniel, but we might want to add some tests for the new functionalities you added and maybe even a test project?

Yes I forgot to mention this yesterday, we should try to add a small example Dagster project to https://github.com/Vandebron/mpyl/tree/99e36e3e5813d4aa5178da1158c59fea79649804/tests/projects and add a roundtrip test for the values.yaml like in test_k8s.py. Aand some smaller unit test for the new methods where feasible would be nice!

Yes I forgot to mention this yesterday, we should try to add a small example Dagster project to https://github.com/Vandebron/mpyl/tree/99e36e3e5813d4aa5178da1158c59fea79649804/tests/projects and add a roundtrip test for the values.yaml like in test_k8s.py. Aand some smaller unit test for the new methods where feasible would be nice!

test_dagster.py and test_helm_utilities.py give a small roundtrip from project.yml -> user-code-values.yaml and its used utility methods

Looks good. Just keep in mind that you need to migrate the project yamls of the dagster projects so the secrets are at the right place

Perhaps we should build a migration command into mpyl that migrates project.yml to the latest version. In that case we'd need a version field in project.yml too.

@kgrunert I tried to rebase. That was pretty hopeless. A merge wasn't trivial either. Perhaps it's quickest and cleanest to create a new branch and re-apply the changes?

@kgrunert I tried to rebase. That was pretty hopeless. A merge wasn't trivial either. Perhaps it's quickest and cleanest to create a new branch and re-apply the changes?

Rebasing was a nightmare, but the Github's "Resolve Conflicts" gave a really helpful overview on how to merge.

Looks great 👍 . A few small comments

Processed your comments 👍 Just need your approval for the merge now 😄

Looks great 👍 . A few small comments

Addressed your last comments 👍  once you approve we can merge 🎉


feat(liipMonitor): add a dashboard for health check

This PR adds a Liip Monitor dashboard page.

Changelog
Added

Add a dashboard page with Liip Monitor health checks.

To do

[x] Move javascript that is inside monitor.html.twig

Coverage decreased (-0.09%) to 44.978% when pulling 0354bd0dd38c3feec0690590060894e87f3195f7 on vlaurier:liip-monitor-dashboard into 72e5349f89fb90afcf100faaec7387b829065e48 on ekino:master.

can you update https://github.com/ekino/sonata/blob/master/CHANGELOG-0.0.md too plz?


Give active tab state

User testing revealed that some users were having trouble evaluating and understanding active state of tabs. Maybe we could move to $lightest-gray from $off-white

@paulcpederson - if I read that note correctly, why would an active state be a gray fill?
why note have for the hover (as currently implemented
background-image: linear-gradient(to top, transparent 94%, #0079c1 96%, #0079c1 100%);
and for the tab is-active, have:
background-image: linear-gradient(to top, transparent 94%, #56a5d8 96%, #56a5d8 100%);
@asangma @snelsonux - other thoughts?

@paulcpederson @fgarofalo10 can one of you link to which tabs on Calcite Web this issue is referring to? is it these: http://esri.github.io/calcite-web/patterns/#tabs

if so, I think what @fgarofalo10 is proposing is a good solution...this way we don't need to rely on gray values and can leverage the already strong hover state pattern as the basis for the active state.

... @snelsonux right, I'm proposing have the hover state be a dark blue and the active state be a lighter blue (or visa-versa)

cool, I think that works

@paulcpederson lightest-gray was too dark. Staying with off-white.
@fgarofalo10 @snelsonux This is a good idea in principle, but doesn't work on the screen very well.


Provide a way to specify defaults without code modification

When running our tests in free-tier CI services such as Travis CI and AppVeyor, we often see an unexpected test timeout due to timing issues, which is often resolved by increasing the timeout.
Although it is possible to increase the default timeout programmatically in Awaitility already, it'd be nice if we can change the default values using other means such as a configuration file or JVM system properties.
My suggestion is to load the defaults from a resource file in a certain path, such as /awaitility.properties in the class path.

Hi @trustin.
Sorry for the delay. Interesting idea. My main concern with this is that the complexity will increase and that Awaitility will begin to act more like framework than a library. I.e. you may forget that you have an /awaitility.properties file in the classpath and spend a of time trying to figure out why things behave in a possibly "strange" manner. This is what makes me a bit reluctant to introduce it.
I suppose that if the benefits outweighs my concerns we could write an optional module that is not in core that actually does this. Similar to how the awaitility-proxy module works. WDYT?

Hi @johanhaleby,
Thanks for your reply. I'm not familiar with awaitility-proxy so I can't tell if I like the idea or not.
On the other hand, we could make use of JUnit Jupiter extensions, so that a user enables the default overriding extension manually by adding it in META-INF/services/org.junit.jupiter.api.extension.Extension as explained in https://junit.org/junit5/docs/current/user-guide/#extensions-registration-automatic ?

Hello,
today I came across the same issue with one of my collegues at work. I argued that awaitability provides a declarative approach for setting timeouts like "max-wait" via awaitility.properties. So instead of doing programmatic approach in java code he should rather use the declarative approach - but I was wrong ...
@trustin , thanks for sharing your code! Still - your solution feels like a hack to me and I would love to have the awaitility.properties in awaitility-core (or other awaitility-foo library).
@johanhaleby , maybe you have changed your mind, as a couple of months have passed and you might re-evaluate your opinion/veto ?


[BUG] improve sidebar to make elements visually accessible

Description
@rupali-codes @CBID2
I believe this issue is important, so I am going to submit a PR by tomorrow. Let me know what you think.
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
Chrome
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

I agree. Go right ahead @Anmol-Baranwal


Do not wrap raw_html elements with a span

Using El::from_html wraps the created DOM node in a .
    pub fn from_html(html: &str) -> Self {
        let mut result = Self::empty(Tag::Span);
        result.raw_html = true;
        result.text = Some(html.into());
        result
    }

This was surprising and caused me some problems when porting some HTML which expected parent-child relationships to remain intact.
In the case that this was not intended this PR removes the , rendering only its child which is the node created from the raw_html string.
If it was intended, would mind explaining the reasoning?
Thank you.

No reason; overlooked how adding tags can interfere with parent-child relationships (eg tables, CSS-grid)

Actually, the fix is something else. This approach causes all children to render under the first one, which isn't always desirable. Eg:

title

subtitle

causes the h2 to render inside the h1. Need to think on the best approach.

Yes, you are right. I'll look into it. Thank you for the feedback.


don't give the assign node the same name as the variable

Minor didactic change.

Thank you very much! Appreciated. I just updated these files before I saw this.


Duplicate of #190

Overall Review of Changes:
Duplicated PR of #190
Issue Fixes:
#189
Enhancements:
Completing rules 5.6.1-3
How has this been tested?:
Tested on VM

hi @ipruteanu-sie
There are a number of PRs and Issues for RHEL9-CIS, whwihc i believe are now either resolved or are currently in devel ready for merge to main.
I believe that everything outstanding has now been addressed. If you could please confirm and close accordingly.
Thanks as always for your help and feedback
uk-bolly

Addressed with other work


Linter rule to detect sub-optimal usages of resourceId() and reference()

Example 1
Input
resource resA 'My.Rp/TypeA@2020-01-01' = {
  name: typeAName
  ...
}

resource resB 'My.Rp/TypeB@2020-01-01' = {
  name: ...
  properties: {
    typeAId: resourceId('My.Rp/TypeA', typeAName)
  }
}

Suggested fix
resource resA 'My.Rp/TypeA@2020-01-01' = {
  name: typeAName
  ...
}

resource resB 'My.Rp/TypeB@2020-01-01' = {
  name: ...
  properties: {
    typeAId: resA.id
  }
}

Example 2
Input
resource resA 'My.Rp/TypeA@2020-01-01' = {
  name: typeAName
  ...
}

resource resB 'My.Rp/TypeB@2020-01-01' = {
  name: ...
  properties: {
    someProp: reference(resourceId('My.Rp/TypeA', typeAName)).someValue
  }
}

Suggested fix
resource resA 'My.Rp/TypeA@2020-01-01' = {
  name: typeAName
  ...
}

resource resB 'My.Rp/TypeB@2020-01-01' = {
  name: ...
  properties: {
    someProp: resA.properties.someValue
  }
}

related to https://github.com/Azure/bicep/issues/3019

This is one of the most common changes I had to make in the existing bicep samples -  changing a resourceId() call to "res.id", frequently having to add an 'existing' resource reference for it.

See also https://github.com/Azure/bicep/issues/3501 and https://github.com/Azure/bicep/issues/3499

Example 3
      networkProfile: {
        networkInterfaceConfigurations: [
          {
            name: nicName
            properties: {
              primary: true
              ipConfigurations: [
                {
                  name: ipConfigName
                  properties: {
                    subnet: {
                      id: '${virtualNetwork.id}/subnets/${subnetName}'

Suggested fix:
a) if subnetName is a nested resource under virtualNetwork:
                      id: virtualNetwork::subnet.id

b) if subnetName is a top-level resource:
                      id: subnet.id

c) If subnetName is not a nested child of virtualNetwork (e.g. it's under properties.subnets) or does not exist, we might consider suggesting refactorings or adding existing resource declarations, but it gets complicated here.


I created a puppet module for exhibitor

https://forge.puppetlabs.com/slackey/exhibitor

I've updated the contributions page: https://github.com/Netflix/exhibitor/wiki/Contributions


Job expiry date

This PR has multiple changes:

Changes Job.expiry to Job.expiry_date. This also changes the field type from DateTimeField to DateTimeField. This will make it easier to run a scheduled daily task that marks jobs as expired or disabled. This also makes querying easier as we probably won't care about the specific hour and time.

Moves get_default_expiry to jobsboard.common.utils from jobsboard.jobs.models.

Changes the default for Job.employment_type to EMPLOYMENT_TYPE_FULL_TIME from EMPLOYMENT_TYPE_PART_TIME as most job posts look for full-time employees instead of part-time employees.

[ ] Design

[ ] PEP8 for Python

[ ] Standard for JavaScript

If accepted, this PR affects the specification in https://github.com/pythonph/jobs-board/issues/4


Distributed Learning on ResNet

I follow the instruction to setup distributed learning environment and modify the code in imagenet-resnet.py for distribution learning.
http://tensorpack.readthedocs.io/en/latest/modules/train.html#tensorpack.train.DistributedTrainerReplicated
I encounter the issue when the worker is trying to build the graph model. May I direct use imagenet_resnet_utils.py without modification? Or the changes are needed? (Details are provided below)
Any suggestion is appreciated.
Here is error trace:
[0926 11:56:44 @distributed.py:73] My role in the cluster: job=worker, task=0
[0926 11:56:44 @input_source.py:235] Setting up the queue 'QueueInput/input_queue' for CPU prefetching ...
[0926 11:56:44 @multigpu.py:87] Building graph for training tower 0...
[0926 11:56:44 @registry.py:121] tower0/conv0 input: [None, 3, 224, 224]
Traceback (most recent call last):
  File "examples/ResNet/imagenet-resnet-dist.py", line 169, in <module>
    DistributedTrainerReplicated(config, server).train()
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/distributed.py", line 92, in __init__
    super(DistributedTrainerReplicated, self).__init__(config)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/base.py", line 93, in __init__
    self._setup()   # subclass will setup the graph and InputSource
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/distributed.py", line 215, in _setup
    use_vs=[True] * self.config.nr_tower)  # open vs at each tower
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/multigpu.py", line 94, in build_on_multi_tower
    ret.append(func())
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/distributed.py", line 213, in <lambda>
    self.model, self._input_source),
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/multigpu.py", line 113, in _build_graph_get_grads
    model.build_graph(input)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/graph_builder/model_desc.py", line 122, in build_graph
    self._build_graph(inputs)
  File "examples/ResNet/imagenet-resnet-dist.py", line 67, in _build_graph
    preresnet_group if self.preact else resnet_group, self.block_func)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/examples/ResNet/imagenet_resnet_utils.py", line 204, in resnet_backbone
    .Conv2D('conv0', 64, 7, stride=2, nl=BNReLU)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/models/linearwrap.py", line 48, in f
    ret = layer(name, self._t, *args, **kwargs)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/models/registry.py", line 124, in wrapped_func
    outputs = func(*args, **actual_args)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/models/conv2d.py", line 61, in Conv2D
    W = tf.get_variable('W', filter_shape, initializer=W_init)
  File "/home/chenrich/.tensorflowEnvPy3Alt/lib/python3.6/site-packages/tensorflow/python/ops/variable_scope.py", line 1065, in get_variable
    use_resource=use_resource, custom_getter=custom_getter)
  File "/home/chenrich/.tensorflowEnvPy3Alt/lib/python3.6/site-packages/tensorflow/python/ops/variable_scope.py", line 962, in get_variable
    use_resource=use_resource, custom_getter=custom_getter)
  File "/home/chenrich/.tensorflowEnvPy3Alt/lib/python3.6/site-packages/tensorflow/python/ops/variable_scope.py", line 360, in get_variable
    validate_shape=validate_shape, use_resource=use_resource)
  File "/home/chenrich/.tensorflowEnvPy3Alt/lib/python3.6/site-packages/tensorflow/python/ops/variable_scope.py", line 1405, in wrapped_custom_getter
    *args, **kwargs)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/utility.py", line 36, in __call__
    return getter(name, *args, **kwargs)
  File "/mnt/nvme1/chenrich/Developer/tensorpack-0.5.0/tensorpack/train/utility.py", line 33, in __call__
    collections.remove(tf.GraphKeys.GLOBAL_VARIABLES)
KeyError: 'variables'

I launch my codes as:
python3 examples/ResNet/imagenet-resnet-dist.py --data /PATH/dataset/imagenet -d 18 --gpu 2 --task 0 --job ps
python3 examples/ResNet/imagenet-resnet-dist.py --data /PATH/dataset/imagenet -d 18 --gpu 2 --task 0 --job worker ...
The modified code is available at
https://gist.github.com/chunfuchen/d8f6db7183ba94ac416948029c366387
The modifications are:

TrainCfg: wrapper dataflow into data. (L117)

return TrainConfig(
        model=model,
        data=QueueInput(dataset_train),
        # dataflow=dataset_train,
        callbacks=callbacks,
        steps_per_epoch=5000,
        max_epoch=110,
        nr_tower=nr_tower
    )

Setup Distributed Learners. (Line 162)

cluster_spec = tf.train.ClusterSpec({
            'ps': ['localhost:2222', 'localhost:2232'],
            'worker': ['localhost:2223', 'localhost:2233']
        })
        server = tf.train.Server(
            cluster_spec, job_name=args.job,
            task_index=args.task, config=get_default_sess_config())
        DistributedTrainerReplicated(config, server).train()```

Note: I was testing on single machine but eventually I will deploy on a cluster.

What's your version of tensorflow: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" ?


Update unique-arguments.md

Needed to add a warning about only passing args as strings.

Hello @kylearoberts,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Bump symfony/* deps

requires #2568

cc @sstok

yeah, lets go! :)    :+1:

Wouldn't ^2.8|^3.0 be better? As Symfony 3.0 is just Symfony 2.8 with deprecated code removed, if your code is compatible with 3.0, then it is automatically compatible with 2.8.

The removal of deprecated code in 3.0 is a good reason to jump to it :)
It makes sure our code doesn't use deprecated SF code, but also that users of the code in this repo are.

Should the code related to old versions of Symfony be dropped in this PR as well?

where needed yes, everything else can be done all in time
(note to self; https://github.com/symfony/symfony/pull/17255 can now be used in the tests)

The test suite runs on 3.x so deprecated code from 2.x can't be used anyway. Removing the ^2.8 part of the constraint would force every side project to update to 3.x even if their code is compatible with 2.8. And I don't think keeping 2.8 would be a maintenance burden.

@julienfalque this means such projects are forced to use .phar version of the tool, or composer global. so i agree ^2.8|^3.0 would had been better.

That's exactly why (deps issues) we do have phar releases as well.
If you for some reason have to stack with old deps and cannot upgrade them, you may not integrate PHP CS Fixer directly in project composer file or just stack with PHP CS Fixer like with other deps - keeping it on 2.2.x level


Alternative way of getting more urls: Automated Search Engine Calls

This is related to the solution I proposed in https://github.com/Police-Data-Accessibility-Project/data-cleaning/pull/1, which leveraged using Google Searches to find police agencies.
Given a list of police districts, cities, counties, etc., we could automate a call to the Google Search Engine API or something similar with the string "{Location} Police Agency Website", and then pull the first result. We could start with the most populous cities/counties/etc. in the US and gradually work our way down. Perhaps including additional searches such as searching for all police districts in a location.
The API described above allows 100 free searches per day (or 5$ for 1000). If we create a Github Action, we could easily run that in the background each day and gradually add a trickle of results. We could include either only the first result, or a set of results, depending on how confident we are that the first result will pull what we're looking for.
This would not accrue as many URLs as quickly, but I suspect it will have a higher hit-to-miss ratio for relevant data.

Great! Suggested strategy:

[ ] hit the Google Search Engine API 100 times each day

generate a string "{agencies.name} {record_type}", cycling through all record types for each agency before moving on

instead of List of Data Sources, use "data portal"

try including the first 10 results; stripping out irrelevant ones with HF models seems to be pretty easy

[ ] add the results to a hugging face dataset. Since we're adding 100 a day, we can append to the same CSV, called something like google_api_urls (see #40)
[ ] keep track of which ones we've tried in a CSV and don't try those again

use agencies.count_data_sources to pick which ones to try first, starting with those that have the most sources. They already skew toward populous cities which are known to already have sources.

from there, check other agencies in those counties. then...I don't know. randomly?

First step would be finding data detailing all the different police agencies. I found a good start with the results of the 2018 Census of State and Local Law Enforcement Agencies (CSLLEA). I've also included the results of this census (for parsing in R) as a zip file:
ICPSR_38771-V1.zip
Additionally, here's the primary data, as an excel file:
2018 Police Agencies Census Data.xlsx
17721 rows, and there's quite a bit of detail in this: Not just the location of each agency, but their 2018 estimated budget, what type of agencies they refer (Sheriff's Department, tribal, college, etc.) what functionalities they served (for example, warrants, whether they investigated homicide, arson, cybercrime, whether they were used for crowd control), and more. The full set of information can be described in the code book contained within the zip.
I don't want to say that this is the absolute best resource we could use for creating a master table for all police agencies in the United States, but it is hard for me to imagine something better.

I agree with Josh that starting with the agencies we have the most data sources for already seems likely to yield the most relevant results. Not sure it makes sense to start considering additional agencies until after the ones we already have.

So if we were to start with the agencies we have the most data sources for (and which don't currently have a homepage url) that actually wouldn't take too much time. The script as I'm envisioning it would be
SELECT
	SUBMITTED_NAME,
	HOMEPAGE_URL,
	JURISDICTION_TYPE,
	STATE_ISO,
	MUNICIPALITY,
	COUNTY_NAME,
	AIRTABLE_UID,
	COUNT_DATA_SOURCES,
	ZIP_CODE,
	NO_WEB_PRESENCE -- Relevant
FROM
	PUBLIC.AGENCIES
WHERE
approved = true
and homepage_url is null
ORDER BY COUNT_DATA_SOURCES DESC

That produces about 5,800 (with about 60 having more than 1 data source). So that'd be a good place to start.

@mbodeantor @josh-chamberlain I may need permissions for the database updated so that I have CREATE_TABLE permissions, as I'd like to create a small additional table to keep track of which agencies have had a search performed on them (so I don't run the risk of redoing searches for them).

@maxachis You should still have create permissions on the public schema. What issue are you seeing?

@mbodeantor I'm running into this error when attempting to create a table through PGAdmin:

This is via the username of data_sources_app

Yeah you'll have to use your username and pass in your DMs

@mbodeantor Ah that did it. Was able to create the table, but still got denied on adding a foreign key constraint to agencies (which will help me ensure that anything in the cache is actually properly referencing an agency uid). Got the following error:

@maxachis I granted you all permissions on that schema, lmk if that doesn't do it.

@mbodeantor Nope, still getting an error of permission denied for table agencies. Here's the SQL query:
ALTER TABLE agency_url_search_cache
ADD CONSTRAINT FK_AGENCY_UID
FOREIGN KEY (agency_airtable_uid)
REFERENCES public.agencies(airtable_uid);

Draft version of PR updated. Remaining tasks:

Create unit/integration tests for code
Create yaml workflow for Github actions, setting script to be run once per day.

@josh-chamberlain The current version of this involves direct database access -- specifically, it updates an in-database "cache", agency_url_search_cache that indicates what agencies have been searched for, so that it doesn't duplicate searches. It directly references the agencies table as a foreign key.
There are other ways to do this. I could maintain the cache in the repository, or I could build an endpoint.
The repository provides the most immediate solution to this, but if we want to run this regularly, it will need to be committed regularly, providing commit clutter*. It'll also be less atomic, meaning we could lose a whole day of Google searches if something breaks. I don't think an in-repo cache is the best option.
Developing an endpoint means we'd have to build a v2 or post-v2 endpoint, and couldn't deploy it until then. That means its development is contingent on the development of those endpoints as well.
Third option is we just have it continue to interface directly with the database. Simplest, but goes against our attempts to keep all database interactions within the endpoint.
Let me know your thoughts.
*Even more than my current granular commits add clutter!

@maxachis maybe this is an opportunity to make an endpoint for caching searches—this is something we want to do, broadly, anyway—it's worth knowing, for basic context, not only the last time we updated but searched for type of data (like homepage) in agency or jurisdiction. For that reason, I think it's worth making an endpoint—later on we could abstract it for other types of caches, but it could be bespoke for now.
Can you clarify why it would need to be v2 or post-v2?

Can you clarify why it would need to be v2 or post-v2?

@josh-chamberlain No reason it has to be, per se. I assumed it would be since I figured we were avoiding significant changes to main if not contained within v2 or post-v2. However, if we're comfortable with developing an endpoint in the primary data-source-app repository, prior to v2, then I'm happy to do that as well. To do so would, however, either necessitate not incorporating some of the changes I'm setting up in v2 (like integration tests) or else duplicating those efforts.

gotcha. that makes sense...I think it'd be better to effectively make a "legacy" endpoint without those tests and soon upgrade it to v2, duplicating effort that way rather than bringing tests into v1. We can wait until our hand is forced; maintaining a cache in the repo isn't the end of the world as a stopgap. Using the repo feels simpler/less annoying, but I'm not most affected. Your call!

@josh-chamberlain Got it. I will develop a legacy endpoint, probably called \agency-search-cache, and then have my code make a call to it.

Using the repo feels simpler/less annoying, but I'm not most affected. Your call!

I've seen repos where identical commits were made nearly every day to refresh some data, and man: even if it seems simpler initially, once you start seeing 30, 60, 90 identical commits over the course of months, it makes things clunky.

@josh-chamberlain For calling the endpoint, I required an API key authorization, then realized I'm not sure if I have one!
After doing a bit more research, I realized a few things:

The Gitbook doesn't appear to mention how one gets an API key to access the more sensitive endpoints. I'm sure I could just get admin rights, but that brings me to:
An endpoint modifying the agencies cache probably should require elevated permissions, which would require a modification of the security.py at the moment (and probably should be modified to something more extensible later).

How should we approach?

@maxachis

You can get an API key by hitting the api_key endpoint. Looks like we currently only have one admin in the database.
True! Is it time to take the first step towards ABAC/PBAC? https://github.com/Police-Data-Accessibility-Project/data-sources-app/issues/162


DarkMode Issue on preview of JSON on playground

Description
When we visit the playground page https://linkfree.eddiehub.io/playground and add the json if we try to preview it the text is not readable in dark mode.
Modal is not following the dark mode styles.

I would love to contribute to it, Anyone please assign me

Screenshots

Additional information
No response

I have assigned it to you @Chandraprakash-Darji - please check the component as I thought it was using the same component as the actual page

I am not it, Thanks @eddiejaoude

Hey, is this issue still open, and has anyone been working on it? I am happy to help with this issue.

I am working on it
On Tue, Apr 11, 2023, 2:14 PM Anupam @.***> wrote:

Hey, is this issue still open, and has anyone been working on it? I am
happy to help with this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/LinkFree/issues/5911#issuecomment-1502924551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWKNLTNAB6JVT6K477SS2CTXAUKYNANCNFSM6AAAAAAWXH6Q6Y
.
You are receiving this because you were mentioned.Message ID:
@.***>

I am working on it, creating PR in 2 hour

@anupamthe99 you can work on it, I got busy with something

sure , i will be happy to work on it @Chandraprakash-Darji

@anupamthe99 you can work on it, I got busy with something

@Chandraprakash-Darji if you can no longer work on an Issue please ask to be unassigned first rather than allocating this to someone else.

sure , i will be happy to work on it @Chandraprakash-Darji

@anupamthe99 I will unassign this from @Chandraprakash-Darji and assign this to you


Improve reporting of issues with batch size on distributed evaluate

When running a Trainer.evaluate on a multi GPU configuration, the interaction between the batch size and the size of the eval dataset may cause either:

One process have a different number of samples than the rest on the last batch.
One or more processes to have 0 samples on the last batch.

In most (if not all) cases, at some point during or after an evaluate run, there will be a call to Trainer.gather to synchronize the results across processes. If any of the 2 conditions is mentioned, that will freeze the run without any kind of reporting, which can be extremely frustrating and hard to debug if the user has not encountered it before.
Number 1. can be solved by ensuring a padding_value to Trainer.gather. Number 2. can only be solved by setting an appropriate batch size that fixes the issue.
This PR adds a warning for number 1. so that users are prompted to ensure they make the right call and an error raise for number 2. to force the user to pick an adequate batch size.
There is one point open to discussion though:
Users that do not need to gather (because they save the outputs in a distributed fashion or because they do not need to persist the outputs, for instance) will never be hit by these cases. This is ok for number 1, because only a warning is raised. The issue is the way this is defined now, number 2. would enforce users to change to a different batch size (potentially a suboptimal one) for something they do not care about.
Then the question becomes: Do we want to just warn or do we raise an error for case 2?

I think a warning for point 2 should be fine


How to launch a Window from the Application class in WinUI?

I'm creating a WinUI application which will run in background initially without launching a window.
Means I've removed the below lines from the OnLaunched method:
m_window = new MainWindow();
m_window.Activate();
Now the thing is that I've implemented a keyboard hook by which I want to give a shortcut key to the user to launch the window.
As soon as user is pressing the shortcut key, we are getting the exception such as:
An exception of type 'System.Runtime.InteropServices.COMException' occurred in WinRT.Runtime.dll but was not handled in user code
The application called an interface that was marshalled for a different thread. (0x8001010E (RPC_E_WRONG_THREAD))

I'm trying to launch the window by using DispatcherQueue.TryEnqueue method but that method is not showing in intellisense.
Please guide me that how should I launch the window?
What should I do?

Anyone please?
This is quite urgent for me

You can just comment m_window.Activate();
Then when I use a Hotkey (with RegisterHotKey )
I can show and activate the window in WM_HOTKEY with this.Activate();

@castorix
Yes, I too have removed the said line from my Application class's OnLaunched method.
Now I'm unable to do m_window.activate when we press the shortcut key.
I'm using H.Hooks lib for keyboard hook.
Can it due to different thread?
Is it possible that keyboard hook is running on different thread?

I don't use any external library
I also tested with a Hook (SetWindowsHookEx) and it works fine (WH_KEYBOARD_LL and 0 for dwThreadId)

So are you able to launch the MainWindow from the raised event by the hook?
@castorix

So are you able to launch the MainWindow from the raised event by the hook?

Yes, this.Activate(); shows the window and sets it to foreground when the key is pressed from the hook procedure

Seems that you are doing it (this.Activate() from the MainWindow class.
And I'm trying it from the App class. This.activate will only be available in MainWindow class not in Application class.
And the thing is that upon my app launches, I don't want to show/launch any window at all.
That's why I'm hooking the keyboard from the application class.
So the thing is that,if I'm doing
MainWindow window = MainWindow();
window.Activate();
from the OnLaunched method or constructor then it's getting launched.
However if I'm trying the same from the Hook event then it's raising the error.
It seems it is happening because Keyboard  Hook is on another thread.
I think I'm clear now.
If no, then I'll share my exact code for your reference then.
@castorix

Exactly, but if I'm creating the window in key event then it is giving me the error:
The application called an interface that was marshalled for a different thread. (0x8001010E

I just tested by creating everything in App.xaml.cs and it still works (but not a good method I think to create a window in a shortcut...)

@marb2000 @bpulliam FYI

@castorix
I don't know if it is a wrong way. if it is a wrong way then I'd love if someone from MSFT please guides me on this

Not stale

@akash07k Obviously your Keyboard Hook is on another thread, which is indicated by the encountered runtime exception and verified by H.Hooks lib.

Optimized, runs hooks in a separate thread. ...

Just use SetWindowsHookEx as @castorix does.
In consideration of your way, you need to maintain the lifetime of the created window(s) through keystrokes of the hot key.

I actually don't want to use SetWindowsHook because it requires more boilerplate for my usecase.I want to use H.Hooks lib instead. any guidance on that please?
Also,
I'm not clear with:

In consideration of your way, you need to maintain the lifetime of the created window(s) through keystrokes of the hot key.

@akash07k Obviously your Keyboard Hook is on another thread, which is indicated by the encountered runtime exception and verified by H.Hooks lib.

Optimized, runs hooks in a separate thread. ...

Just use SetWindowsHookEx as @castorix does. In consideration of your way, you need to maintain the lifetime of the created window(s) through keystrokes of the hot key.

Microsoft.UI.Dispatching.DispatcherQueue dispatcherQueue = Microsoft.UI.Dispatching.DispatcherQueue.GetForCurrentThread();
You may refer to the DispatcherQueue of the UI thread in the H.Hooks lib thread. See Change CoreDispatcher.RunAsync to DispatcherQueue.TryEnqueue and the WinUI-Gallery sample for more information.

In consideration of your way, you need to maintain the lifetime of the created window(s) through keystrokes of the hot key.

How about a user raising a succession of keystrokes of the hot key? You should avoid creating windows per keystroke.


proposal: replace tlds with a list

Why instead of declaring the tlds inside the script, you put them in a list so that the script reads them (since they can be more).
tlds = set((
'.2000.hu',
'.ab.ca',
'.ab.se',
'.abo.pa',
'.ac',
'.ac.ae',
 '.ac.at',
etc, etc
If there is a new tlds, it is easier to modify a list than to be adding things to the script. Thanks
PD: This script is very slow. Is there any way to make validation faster?

I already did it on my own. Thank you


Each camb sent to server overwrites all other changes to same row when PGP

PGP merges the whole row and encrypts it. This way it is not possible to create partial updates of a row when PGP is enabled.
I guess the server has to return an error and all new updates if the cambiato > ultimo_update[server] and then the client should implement updates and try again

Actually I will need to store what data was changed in database and use that info to merge from server when available.
I suggest adding a "changed" columns storing what keys/data/diff was changed.
Actually remember that some cells store objects or arrays that might need a different merge-approach. I think this is a somewhat more difficult problem, but arrays might be cool to merge.

Okay so actually the format used in note and in assegnamenti is good. It can easily be converted to a Map:
let map = new Map(noteArr);

and back to an array:
let arr = Array.from(map);


Throw LowMemoryException on getDrawable(final String aFilePath)

It is more a question rather than a pull request.
Why the getDrawable(String aFilePath) does not throw an LowMemoryException?  It is to maintain compatibility somwhere?
It looks very strange. The TileSource#getDrawable(String aFilePath) allows to throw this exception.

due to merge issues, i merged it into a separate branch. if everything passes, i'll merge it tonight

merged


Omp block jacobi

This merge request adds OMP support for Block-Jacobi preconditioning. The parallelization of all kernels is inside the blocks, there is (at this point) no parallelization in-between the distinct blocks (like in batched routines). The motivation is better cache reuse. In future, performance tests should be used to analyze whether the block parallelization achieves higher performance.

Review of the omp/preconditioner/jacobi_kernels.cuh:
The following line numbers are links to the file (I don't know if there is another way, but guess not):
Line 37
You need to #include <algorithm> because you use std::swap in line 217 (should not be a problem on linux because it includes it by default, but on some systems it might cause errors).
Line 41
Missing newline (2 newlines to previous include statements required)
Line 71
Missing newline (namespaces are also always separated by 2 newlines with their surroundings, except for other namespaces)


Allow Stonewall(x2) when spending to non bech32 address

This is possible with Samourai, and while the true spend is indeed easily identifiable there are still benefits to making a Stonewall(x2) spend here:

the common input ownership heuristic is still broken
the non-decoy change outputs still can still be send to 2 different people, impossible to tell

The way Sparrow presents StonewallX2 though is an upgrade path from Stonewall. The UX of disallowing a Stonewall but allowing a StonewallX2 feels like it may be confusing.

the non-decoy change outputs still can still be send to 2 different people, impossible to tell

They are always sent to 2 different people in a StonewallX2? Not sure I follow.

Apologies I was not clear in my explanation. I meant allow both stonewall and stonewallx2 transactions when spending to a non bech32 address.
Despite the decoy change output being obvious when not sending to a bech32 address, there is still a privacy benefit allow stonewall and stonewallx2 since an observer does not know if it is a 2 person coinjoin or a fake 2 person coinjoin, therefore:

The inputs might be from 2 different people. The common input ownership heuristic is broken.
The non decoy change outputs might go to 2 different people.


Extrema window working for sumd files

See #129, basically the same set of changes, where applicable, is needed here.

Changes made


Banners are random every time the page is reloaded (for people that I haven't updated their banner)

Is your feature request related to a problem? Please describe.
The banner (for people that I haven't updated their banner) is random every time the page is reloaded.
Describe the solution you'd like
If the random banner should be retained, it should be set as a direct url (at registration or something) or should be randomly seeded if the value can't be stored.
Describe alternatives you've considered
N/A
Additional context
N/A

this is intentional


Weaning yourself off jQuery

https://www.reddit.com/r/javascript/comments/2378xo/the_best_frontend_interview_question_i_got_when/

I remember there being quite a big discussion on jQuery vs vanilla recently. Do you have any links to that?
This is a very good topic to post btw.

I don't remember but I know this https://twitter.com/ericwastl/status/663497845287333888 :smile:

@scottcorgan  https://github.com/oneuijs/You-Dont-Need-jQuery ?


Correct inverted 'stop bit' logic

When a command sequence ends, the CMD_I2C_END flag is set, which is used to send a stop bit and release the bus but the Pico SDK functions have a 'nostop' parameter with the opposite logic, so this should be 'false' when CMD_I2C_END is set, and vice versa.
Fixes #3

Thank you for looking into this, it's been a while since I had the time to look at this project. I've tested your change with a logic analyzer and it works great! Thank you.


Add workaround for current kernel bug related to WRITEV and IOSEQ_ASYNC

Motivation:
There is currently a bug in the kernel that let WRITEV sometimes fail
when IOSEQ_ASYNC is enabled
Modifications:
Don't use IOSEQ_ASYNC for WRITEV for now
Result:
Tests pass

/cc @njhill @franz1981