Components/Notify: add default prop for notifications

This PR:

adds empty array as default notifications prop
update snaps,
add testURL for Jest. This stops seeing this error, https://github.com/jsdom/jsdom/issues/2304

My motivation for writing this PR was due to seeing warning errors about notifications being passed undefined in my tests after using this library. This only happens in tests, not in actual code.

thanks for this. lgtm, could you bump patch version in package json and we can merge.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@916fb57). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #34   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      6
  Lines             ?    108
  Branches          ?     45
=======================================
  Hits              ?    108
  Misses            ?      0
  Partials          ?      0

Impacted Files
Coverage Δ

src/components/Notify/index.js
100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916fb57...71c7329. Read the comment docs.

Done, but am now seeing this coverage error report. I don't quite understand why this is happening; it's the first I've seen it - I didn't see this on the initial PR. If there's something I've missed, let me know. Also, I can squash this before merge.


Install command not defined

ConsoleServiceProvider wasn't registered.

It's my fault. Thank you.


Add a Pipe type.

This PR adds a move-only wrapper for POSIX and Windows anonymous pipes (i.e. those created with pipe(2).) We will need pipes in order to implement platform-independent interprocess communication such as that required by exit tests or future adoption of distributed actors.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test Windows

@swift-ci test

@swift-ci test Linux

@swift-ci test macOS

Unfortunately, WASI doesn't have pipe...
/home/build-user/swift-testing/Sources/Testing/Support/FileHandle.swift:449:20: error: cannot find 'pipe' in scope
447 |         }
448 | #else
449 |         guard 0 == pipe(fds.baseAddress) else {
    |                    `- error: cannot find 'pipe' in scope
450 |           throw CError(rawValue: swt_errno())
451 |         }

We can add a SWT_NO_PIPE flag for this. I'll open a PR in the morning (my time.) Would you mind filing an issue?

@grynspan Thanks! Opened an issue here :pray: https://github.com/swiftlang/swift-testing/issues/698


Access Control List

Create a document detailing who has access to the various systems, and who are the main points of contact etc...
cc @mdeous
Any objection to making this kind of document public? I think it's best to.

@s0 No objection at all, I'm a big fan of doing things in the open.
As not everyone has access to every system, I think this should be a collaborative effort from all team leads. I'll start drafting a spreadsheet in our security folder on GDrive and will share it with the rest of the team.

@mdeous i was thinking it would be better as a markdown file in the info repo perhaps?

Since we're also on the subject of access control... if we're going to put together an access entitlements matrix (access.md), it wouldn't be a bad idea to kill 2 birds with one stone and implement a role based access control policy and change management system.
The access.md doc can be our "Central source of truth", with all access changes needing to go through a git approval process before being merged and made effective.  This would put us in a good spot for compliance frameworks such as ISO and SOC.


There was an issue getting Nexus status. Disabling analyzer

We are newbies with Dependency-Check. After a lot of trial and error we have got a check running which actually loads the database from downloaded nvdcve-files and returns a report
However we still get a warning that there is an issue getting Nexus status:
Mai 07, 2015 3:09:12 PM org.owasp.dependencycheck.Engine analyzeDependencies
Information: Analysis Starting
Mai 07, 2015 3:09:13 PM org.owasp.dependencycheck.analyzer.NexusAnalyzer initializeFileTypeAnalyzer
Warnung: There was an issue getting Nexus status. Disabling analyzer.
Mai 07, 2015 3:09:17 PM org.owasp.dependencycheck.Engine analyzeDependencies
Information: Analysis Complete
This is our definition in a maven pom:
false
true
https://machine.domain/nexus
true
I have read in another issue that the nexus url usually ends  with /service/local/. This is not the case at our company. Have we setup Nexus wrong?
We have absolutely no idea what to do. Any help is welcome.
Peter

Just realized that service/local is the REST-api URL. So I changed my settings to
Result is still the same.
<centralAnalyzerEnabled>false</centralAnalyzerEnabled>
<nexusAnalyzerEnabled>true</nexusAnalyzerEnabled>
<nexusUrl>https://machine.domain:8443/nexus/service/local/</nexusUrl>
<nexusUsesProxy>true</nexusUsesProxy>

I just updated the JavaDoc to emphasize that we are looking for the service end point. The documentation site was changed recently to reflect that the nexus configuration is looking for the service end point.
Glad you were able to get it working.


Update todos in readme.md

Added line about supporting other instance types. The new "i2" line of servers seem great for Splunk.

+1 on the i-series comment, I was just thinking the same thing this week.

Circling back on this: templates are now updated to use latest generation of Amazon Linux AMIs (2015.03), and they now support new EC2 instance types, including storage-optimized I2 & D2!


Exported dimension table should not be limited to 100 rows

@cohenscottr reported that his export is limited to 100 rows, though he has ~7,000 unique dimension values

Closed by https://github.com/rilldata/rill/pull/3197


Changing filenames with webp: does it impact images SEO?

I have a website where images are very important and we get a lot of traffic from google images. When enabling webp images, Mod Pagespeed will constantly change the filenames of the images. Does that means it will have a negative impact on SEO?
If googlebot finds a webp image on my website and adds it to google images, and then some day the file name changes. I assume the ranking will be lost because google will think the image was deleted?
If images SEO is very important, should we completely disable webp rewriting?

Pagespeed serve rewrited images whit a link rel canonical header, so if google do their work, these images don't be indexed but the canonical.
Anyway, images url don't change unles the image change.
One jpg image, depending on enabled filters, generate some pagespeed rewirted urls (if the images get resized or converte to webp...) but unless the image changes, thats urls become allways the same.


Test failures on Carl's win64 build

From https://github.com/numpy/numpy/issues/5575

(1) ERROR: test_improvement (test_quadpack.TestCtypesQuad)
WindowsError: [Error 193] %1 is not a valid Win32 application
(2) ERROR: test_typical (test_quadpack.TestCtypesQuad)
WindowsError: [Error 193] %1 is not a valid Win32 application
(3) FAIL: test_interpolate.TestInterp1D.test_circular_refs
ReferenceError: Remaining reference(s) to object
(4) FAIL: test__gcutils.test_assert_deallocated
ReferenceError: Remaining reference(s) to object

The first two seem to be questions whether the test extension modules loaded in these tests with ctypes are built correctly there (symbols exported etc).
Origin of the second to seems less clear.

The first two test cases fails in the setUP phase of the test due to an error in ctypes.util.find_msvcrt() that has to be worked around for mingw-w64 build binaries.
I didn't experienced (3) and (4) on haswell or sandybridge..
Summary on sandybridge/haswell for python2-6 ... 3.4 win32 and amd64
ERRORS
(5) ERROR: test_fortran.test_fortranfiles_read
IOError: Sizes do not agree in the header and footer for this record - check header dtype
for python-3.2 / python-3.4 amd64 (64bit) only
(6) ERROR: test_fortran.test_fortranfiles_write
AssertionError:  Items are not equal
for python-3.4 amd64 (64bit) only
failures
(7) three numpy failures due to a _fpclassify bug in mingw-crt  (win32)
win32 only
(8) FAIL: test_syr_her (test_blas.TestFBLAS2Simple)
AssertionError:  Not equal to tolerance rtol=1e-07, atol=0
this is due to an OpenBLAS bug: https://github.com/xianyi/OpenBLAS/issues/492 see also https://github.com/scipy/scipy/issues/4453
all versions
(9) FAIL: test_optimize.TestOptimize.test_minimize
AssertionError: Not equal to tolerance rtol=1e-07, atol=1e-14
all versions
this pops up in scipy, but this is an numpy-mingw-w64 failure. This bug doesn't show up with the combination of numpy-1.9.1(sourceforge official binary) and scipy-openblas.
(10)
FAIL: test_optimize.TestOptimize.test_powell
AssertionError: Not equal to tolerance rtol=1e-07, atol=1e-14
all versions
this pops up in scipy, but this is an numpy-mingw-w64 failure. This bug doesn't show up with the combination of numpy-1.9.1(sourceforge official binary) and scipy-mingw-w64-openblas.

Carl - I think the time has come to get your pull requests into the system so it is easier for us to replicate and debug.  Can we maybe have a google hangout or something to get this moving forward?

So (9) and (10) are the same, and the comment seems to indicate that it's a regression in numpy 1.9.2?

(5) and (6) are likely due to an issue with np.fromfile I think. The FortranFile code is Python only and quite straightforward.

On Mon, Mar 2, 2015 at 8:20 AM, Ralf Gommers<EMAIL_ADDRESS>wrote:

(5) and (6) are likely due to an issue with np.fromfile I think. The
FortranFile code is Python only and quite straightforward.

Can you expand on that? Maybe a long integer problem?
Chuck


showing modified for files whose changes  are commited

Look at this screenshot

I made some changes to the git repo and i commited those.
you can see that when i did git diff, there is nothing.
But VScode keeps telling me that those are modified.
Version: 1.30.1
Commit: dea8705087adb1b5e5ae1d9123278e178656186a
Date: 2018-12-18T18:07:32.870Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Linux x64 4.15.0-45-generic
I have no extensions installed.

@Seenivasanseeni can you share what Git viewlet shows at this point?


[WIP] Make FastDEQs fast again

Main Changes:

Moves from Flux to ExplicitFluxLayers -- Mainly to do away with the weird destructure/restructure and the several issues that come with it
Drop dependencies on unreleased branches (still requires some upstream merges but after this PR we can finally register the package)
Termination and Time-Stepping Tolerances have separate arguments

TODOs

[x] Work on the Discrete Solvers
[ ] Jacobian Stabilization is completely broken
[ ] Update docs

Fixes #37
Requires https://github.com/avik-pal/ExplicitFluxLayers.jl/pull/7 & https://github.com/avik-pal/FluxMPI.jl/pull/15

Some numbers after this partial rewrite -- CIFAR10 now takes 320s per epoch on 1 V100 vs previously 450s on 6 processes across 2 V100s

Ok, we are definitely not fast yet. deq uses discrete models but is able to train 1 epoch in 10s.

Where's the overhead right now? Do you have a profile?

I am working on it. There was some overhead in EFL due to branching, which Zygote doesn't like. Fixing that brings us at par with Pytorch on standard workloads like AlexNet.

I'd be curious to see a flamegraph to just know "how it flows" and know what can be done.

FYI https://github.com/FluxML/Zygote.jl/pull/1195 would make branching less terrible for performance, but the backwards pass will still be type unstable.

I'd assume most of the time would be in implicit adjoints, so I'd assume Zygote overhead would be negligible here. But if that's not the case, I'm curious why.

Not really even when running pretraining which is essentially ignore adjoints and train like a depth K neural network we have a large overhead. But yeah I will get the flame graphs before concluding things

Some profiles. Not for the actual models but smaller ones atm
Script: small.jl
using FastDEQ, CUDA, LinearAlgebra, Random, Test, ExplicitFluxLayers, Flux, ProfileView, BenchmarkTools

seed = 0
rng = Random.default_rng()
Random.seed!(rng, seed)

model = DEQChain(
    EFL.Dense(2, 2),
    DeepEquilibriumNetwork(
        EFL.Parallel(+, EFL.Dense(2, 2; bias=false), EFL.Dense(2, 2; bias=false)),
        ContinuousDEQSolver(; abstol=0.1f0, reltol=0.1f0, abstol_termination=0.1f0,
                            reltol_termination=0.1f0, mode=:rel_norm),
        maxiters=10,
        verbose=false
    ),
)
ps, st = gpu.(EFL.setup(rng, model))
x = gpu(rand(rng, Float32, 2, 1))
y = gpu(rand(rng, Float32, 2, 1))

gs = gradient(p -> sum(abs2, model(x, p, st)[1][1] .- y), ps)

@profview for i in 1:10
    sum(abs2, model(x, ps, st)[1][1] .- y)
    CUDA.synchronize()
end

@profview for i in 1:10
    gradient(p -> sum(abs2, model(x, p, st)[1][1] .- y), ps)
    CUDA.synchronize()
end

Script 2: small_wide.jl
using FastDEQ, CUDA, LinearAlgebra, Random, Test, ExplicitFluxLayers, Flux, ProfileView, BenchmarkTools

seed = 0
rng = Random.default_rng()
Random.seed!(rng, seed)

model = DEQChain(
    EFL.Dense(2, 1024),
    DeepEquilibriumNetwork(
        EFL.Parallel(+, EFL.Dense(1024, 1024; bias=false), EFL.Dense(1024, 1024; bias=false)),
        ContinuousDEQSolver(; abstol=0.1f0, reltol=0.1f0, abstol_termination=0.1f0,
                            reltol_termination=0.1f0, mode=:rel_norm),
        maxiters=10,
        verbose=false
    ),
    EFL.Dense(1024, 2),
)
ps, st = gpu.(EFL.setup(rng, model))
x = gpu(rand(rng, Float32, 2, 16))
y = gpu(rand(rng, Float32, 2, 16))

gs = gradient(p -> sum(abs2, model(x, p, st)[1][1] .- y), ps)

@profview for i in 1:10
    sum(abs2, model(x, ps, st)[1][1] .- y)
    CUDA.synchronize()
end

@profview for i in 1:10
    gradient(p -> sum(abs2, model(x, p, st)[1][1] .- y), ps)
    CUDA.synchronize()
end

small_wide_1.txt
small_wide_2.txt
small_2.txt
small_1.txt
The files are *.jlprof and not *.txt

The NeuralNetwork evaluation takes up very little time of the forward pass (red part)

julia> @benchmark model(x, ps, st)[1][2]
BenchmarkTools.Trial: 513 samples with 1 evaluation.
 Range (min … max):  6.803 ms … 393.693 ms  ┊ GC (min … max): 0.00% … 10.86%
 Time  (median):     7.153 ms               ┊ GC (median):    0.00%
 Time  (mean ± σ):   9.734 ms ±  29.416 ms  ┊ GC (mean ± σ):  2.54% ±  0.82%

   ▁▆█▄▄
  ▃██████▇▇▄▄▃▃▃▃▃▃▃▂▃▃▂▃▂▁▃▂▃▄▂▅▃▄▃▃▂▃▂▂▁▁▁▂▂▁▂▂▂▂▁▁▁▂▁▁▁▁▁▂ ▃
  6.8 ms          Histogram: frequency by time        10.5 ms <

 Memory estimate: 643.28 KiB, allocs estimate: 10811.

julia> @benchmark model(x, ps, st_)[1][2]
BenchmarkTools.Trial: 1333 samples with 1 evaluation.
 Range (min … max):  1.319 ms … 386.675 ms  ┊ GC (min … max): 0.00% … 7.30%
 Time  (median):     3.094 ms               ┊ GC (median):    0.00%
 Time  (mean ± σ):   3.743 ms ±  14.787 ms  ┊ GC (mean ± σ):  1.27% ± 0.32%

                                  ▇█▂         ▂▂▁▁
  █▇▇▅▃▅▁▁▁▁▁▁▃▁▁▃▁▁▃▁▁▁▃▃▁▁▁▁▁▁▁▇███▅▄▅▄▃▇▄▄█████▆▁▁▁▃▁▁▃▆▇▇ █
  1.32 ms      Histogram: log(frequency) by time      4.46 ms <

 Memory estimate: 91.98 KiB, allocs estimate: 2386.

The second run is essentially the time it takes if we remove adaptive timestepping and execute the neural networks K times (K = NFE for first run)

https://github.com/tkluck/StatProfilerHTML.jl

https://avik-pal.github.io/statprofs/1/
https://avik-pal.github.io/statprofs/2/

How far off is the performance now? Check if the Krylov method is actually a good idea for the linear solve of the backwards pass. For a dense matrix it can have really slow convergence. A direct solve may be better there at the size you're using?

Actually https://avik-pal.github.io/statprofs/3/index.html is a much more realistic test case. Most of the time ~85% is spent in the neural network evaluation

Progress we are down from 180s per epoch across 4 gpus to 115s per epoch across 1 GPU


implement heartbeat to avoid disconnection

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.968%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
103

Relevant Lines:
180

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.968%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
103

Relevant Lines:
180

💛  - Coveralls


State of PHP 8.1 support

Hi everyone,
what's the state of PHP8.1 support, we'd like to integrate this package into https://github.com/OpenMage/magento-lts but we're supporting PHP8.1 so we'd like to be on-par here.
I see a person created a 8.1 fork of this repo https://github.com/actionstep/zf1-future what's up with that?
Thanks everybody!

There have been several changes for PHP 8.1 deprecation notices, notably #189, #214, #212.
We are running zf1-future since March on PHP 8.1, it's working without problems, but of course we do not use all functions, so I can not say if everything works.

While I started this code base, I no longer work on a project that uses it. However before I left that project I was using this code base with PHP 8.1 for a year and then used it with PHP 8.2 for a month


Added Calendar WeekView, MonthView

MonthView fully functional
WeekView: issues with data store

Fixed WeekView example, merged upstream changes.

Added Days View and Timezone Support examples. Please @markbrocato look at the Timezone support closely as I am not sure if I chose correct approach in changeOptions method. It is approved way how to change config?

@markbrocato sorry for these commits as I should made separate PR. Will do next time.
Added Fix for EdgeMenu and removed one deprecated config in Basic markers


Migrate the TS Plugin to Volar

Changes
Migrated to TS Plugin integrated by Volar, this improved some renaming results execute from .ts.
Testing

Docs

Make @astrojs/compiler external in https://github.com/withastro/language-tools/pull/592/commits/a82ab803326ebba212e1d729e6fab31ff7a5ee07, so we don't need to copy astro.wasm, and the extension size is reduced to 5.1 MB.

Thank you @johnsoncodehk  CI is failing, it can't find a file. Could you look at that please?

Should be working now, please try again. :) Now the extension size reduce to 3.8 MB.
There are 2 breaking changes from ts plugin:

Unless .astro has been imported by a .ts file, tsserver does not know it, because the volar ts plugin only adds it to the LS host when it actually parses the .astro file path, not in advance from the project in getExternalFiles Search for all .astro files.
In addition to better performance, the ts plugin does not need to care about whether the current astro project or not.
This makes the auto import component unavailable for .astro files that were never imported. This is not a problem for Vue, because we only care about renaming, find reference and other functions.
If Astro still needs auto-import functionality, you has the option to implement getExternalFiles again.

Now "compilerOptions": { "jsx": "preserve" } needs to be set by the user, but Astro can also choose to add back the logic of when the current project is Astro, modify getCompilationSettings.

Should the “work in progress” be removed from the readme?

Should the “work in progress” be removed from the readme?

Yep! I think so.

Unless .astro has been imported by a .ts file, tsserver does not know it, because the volar ts plugin only adds it to the LS host when it actually parses the .astro file path, not in advance from the project in getExternalFiles Search for all .astro files.
In addition to better performance, the ts plugin does not need to care about whether the current astro project or not.
This makes the auto import component unavailable for .astro files that were never imported. This is not a problem for Vue, because we only care about renaming, find reference and other functions.
If Astro still needs auto-import functionality, you has the option to implement getExternalFiles again.

Hmm, it seems like it's not just the auto-import though, for renaming and file references to work, the .astro file needs to have been imported somewhere in a .ts(x) file. It's super annoying, but think I might have to implement getExternalFiles again for this

Regarding 1., since there are some projects like https://github.com/mizdra/typescript-plugin-asset that highly require auto-import, I'll investigate again whether this should/could be supported by the framework.

it seems like it's not just the auto-import though, for renaming and file references to work

These problems have been solved, please receive the goods. 🤞


PyPI 0.9 package misses brax.io.torch

Hi, I've updated brax and for some reason latest wheel on PyPI (brax==0.9.0) doesn't have torch wrapper module. It is present on the main here and in previous version v0.1.2

Hi @ikamensh thanks for using brax! It'll be pushed to PyPI once we bump the git tag – will update here once we do that! For now you can install from source


Problem reading a class with List attribute using CsvDozerBeanReader

I have been trying to read a Pipe-Delimited CSV with some values being empty, and some being filled with doubles, but I am unable to use CsvDozerBeanReader to read a bean which has a List<Double> of Doubles in it. The reader instead reads them as a List<String>
Below is a toy code which can reproduce the issue.
My CSV: (Note that the middle value is null, and rest are valid numbers)
item1|item2|item3
0||2

My Bean Class:
import java.util.List;

public class Doubles {

	private List<Double> doubles;

	public List<Double> getDoubles() {
		return doubles;
	}

	public void setDoubles(List<Double> doubles) {
		this.doubles = doubles;
	}

My Tester Code:
package scratch;

import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.util.List;

import org.supercsv.cellprocessor.*;
import org.supercsv.cellprocessor.Optional;
import org.supercsv.cellprocessor.ift.CellProcessor;
import org.supercsv.io.dozer.CsvDozerBeanReader;
import org.supercsv.prefs.CsvPreference;

public class Scratch {

	public static void main(String[] args) throws IOException {

		String[] FIELD_MAPPING = new String[] { "doubles[0]", "doubles[1]", "doubles[2]" };
		CellProcessor[] processors = new CellProcessor[] { new Optional(new ParseDouble()),
				new Optional(new ParseDouble()), new Optional(new ParseDouble()) };

		CsvPreference PIPE_DELIMITED = new CsvPreference.Builder('"', '|', "\n").build();
		CsvDozerBeanReader reader = new CsvDozerBeanReader(new FileReader("/Users/devesh/Desktop/scratch.csv"),
				PIPE_DELIMITED);
		reader.getHeader(true);
		reader.configureBeanMapping(Doubles.class, FIELD_MAPPING);
		Doubles doubles;
		while ((doubles = reader.read(Doubles.class, processors)) != null) {
                         // The line below gives me False
			System.out.println(doubles.getDoubles().get(0) instanceof Double);
                        // This line raises a java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Double
			System.out.println(doubles.getDoubles().get(0).getClass());

		}
	}
}

In the above code, when I inspect doubles.getDoubles().get(0), it comes out to be of type String instead of Double. I am not sure why is this happening, and is there some issue in my CsvPreference or processors

Hi, @deveshks
I'm so sorry, Super-csv currently does not support the conversion of CSV multi column to List. And this exception is caused by DozerBeanMapper converting List to Llist.

Hi, @kbilsted
Any idea about this problem?

Hi, @deveshks
I'm so sorry, Super-csv currently does not support the conversion of CSV multi column to List. And this exception is caused by DozerBeanMapper converting List to Llist.

But that's what is being done in the Reading with CsvDozerBeanReader
 right, or am I missing something?

Oh, It's embarrassing. I will look for the cause of this problem, it may appear in dozer.

I was actually able to solve this by using hintTypes, something like
Class<?>[] hintTypes = {Double.class, Double.class, Double.class}
....
....
reader.configureBeanMapping(Doubles.class, FIELD_MAPPING, hintTypes);

Note that the docs say
If you're using indexed mapping without deep mapping (e.g. answers[0]) and your array/Collection contains standard Java types (String, Integer, etc) then that's fine, but if it contains a custom type then Dozer needs a few hints for it to work correctly.

but I am not sure if java.lang.Double counts as a standard Java type. (I am new to Java)

Yeh, Integer also cause the same problem.
Maybe the doc should update.

Yeh, Integer also cause the same problem.
Maybe the doc should update.

Yes, maybe a reference to java docs as to what constitute standard Java types will be helpful for new users.

Hi @dota17
Was there a doc update or any other solution to resolve this?


pip dependency chain is broken

installing just python-matter-server installs only home-assistant-chip-clusters and fails to install home-assistant-chip-core resulting in a broken dependency chain
● matterserver.service - matterserver
     Loaded: loaded (/etc/systemd/system/matterserver.service; enabled; preset: enabled)
     Active: active (running) since Tue 2024-07-23 19:04:14 CDT; 327ms ago
   Main PID: 960 (python)
      Tasks: 1 (limit: 1093)
     Memory: 23.1M
        CPU: 320ms
     CGroup: /system.slice/matterserver.service
             └─960 /srv/homeassistant/bin/python -m matter_server.server

Jul 23 19:04:14 homeassistant python[960]:   File "<frozen runpy>", line 189, in _run_module_as_main
Jul 23 19:04:14 homeassistant python[960]:   File "<frozen runpy>", line 148, in _get_module_details
Jul 23 19:04:14 homeassistant python[960]:   File "<frozen runpy>", line 112, in _get_module_details
Jul 23 19:04:14 homeassistant python[960]:   File "/srv/homeassistant/lib/python3.12/site-packages/matter_server/server/__init__.py", line 3, in <module>
Jul 23 19:04:14 homeassistant python[960]:     from .server import MatterServer
Jul 23 19:04:14 homeassistant python[960]:   File "/srv/homeassistant/lib/python3.12/site-packages/matter_server/server/server.py", line 32, in <module>
Jul 23 19:04:14 homeassistant python[960]:     from ..server.client_handler import WebsocketClientHandler
Jul 23 19:04:14 homeassistant python[960]:   File "/srv/homeassistant/lib/python3.12/site-packages/matter_server/server/client_handler.py", line 13, in <module>
Jul 23 19:04:14 homeassistant python[960]:     from chip.exceptions import ChipStackError
Jul 23 19:04:14 homeassistant python[960]: ModuleNotFoundError: No module named 'chip.exceptions'

installing home-assistant-chip-core manually results in a version newer than the expected version from home-assistant-chip-clusters, also causing an error (see #835 )
and for posterity, the current upgrade procedure that works to workaround this issue, is:
pip uninstall python-matter-server
pip uninstall home-assistant-chip-clusters
pip uninstall home-assistant-chip-core
pip install python-matter-server
pip install home-assistant-chip-core==$CLUSTERS_VERSION

where $CLUSTERS_VERSION is the version of home-assistant-chip-clusters that got installed by pip install python-matter-server

First of all, installing the server is done by 'pip install python-matter-server[server]'
Second of all;
The only officially supported way of running Matter Server is by running the Home Assistant add-on and secondly the standalone docker image (with al noted about networking and host patches)
Running a production setup with just installing the python packages is NOT supported.

I don't understand the defensive attitude for this open source project. I'm using it at home, I'm an experienced devops professional, and this is an open source project.
If you really don't want people using or contributing to this I will happily fork it and fix your issues myself.

It's not supported and we have documented that as well. Next to that you ignored the fact that this issue tracker is not for user support and ignored that as well. Sorry we do not have the capacity to support every corner case setup, especially not with Matter where a lot of moving parts are involved, dependencies on host OS, kernel patches and so on. So you are free to tinker around but we don't provide support. It's not meant offensive but just a way of politely telling you ignored all our warnings what is supported and what not.


SuperHero: Text scroll animation, style fixes

Implemented:
Text scroll animation, style fixes
Issue #2
after: https://hero-styling--firefly--adobecom.hlx.page/

The 1200px res image might be causing the bad LHS. we would need to take a look at that on .live and see how it is performing


Enclose xacro command with double quotes

This PR fixes build error on Xenial where the error messages are something like:
Starting  >>> racecar_description
_______________________________________________________________________________
Errors     << racecar_description:make /home/jslee02/dev/catkin_ws/racecar/logs/herb_description/build.make.003.log
Usage: xacro [options] <input>

xacro: error: expected exactly one input file as argument
make[2]: *** [/home/jslee02/dev/catkin_ws/racecar/devel/.private/herb_description/share/racecar_description/robots/racecar.urdf] Error 2
make[1]: *** [CMakeFiles/description_files.dir/all] Error 2
make: *** [all] Error 2
cd /home/jslee02/dev/catkin_ws/racecar/build/herb_description; catkin build --get-env herb_description | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
...............................................................................
Failed     << herb_description:make           [ Exited with code 2 ]
Failed    <<< herb_description                [ 0.4 seconds ]
[build] Summary: 0 of 1 packages succeeded.
[build]   Ignored:   4 packages were skipped or are blacklisted.
[build]   Warnings:  None.
[build]   Abandoned: None.
[build]   Failed:    1 packages failed.
[build] Runtime: 0.5 seconds total.

Shouldn't the quotes include the environment variables at the start of the command if it is a single shell command string?

@psigen It makes sense to me. Let me update this PR so.


CASSANDRA-13606 Improve handling of 2i initialization failures

j11 CI
j8 CI

Ci j11
CI j8

^are these runs good enough or do you recommend I run any other dtests? Thx in advance

CI j11
CI j8

@adelapena 2 things:

I modified the enum logic
I didn't quite get the supportedLoadWhenFailed suggestion, neither I suspect would bring much value? but I am probably missing sthg. Please feel free to push or rephrase if you feel strongly about it.

Also, reminder to myself to rebase, squahs and run a full dtest suite once we're happy.

@adelapena thanks for taking the time to rephrase that bit about the indexes and the load type.
 Notice CassandraIndex defaults to ALL for the state and the Index#supportsLoad() method defaults to always true except for NONE. I would argue that makes any new index implementation concerns for that a zero overload. Like you can ignore it as defaults are already reflecting the std behavior.
So given the above it boils down to me seeing this as a feature and you probably as an unnecessary optimization. I'd obviously like to leave it as it is (but I am the father of the baby lol) but you know the codebase an it's uses better. So let me know if you'd like me to change it please?

@adelapena again, thanks a lot for looking into this. Given you've put the time into implementing your approach I have patched and adopted it. At the end of the day you're more familiar with the code and it's uses than me :-)
The dtests thing... mmmm we should try to have as much utest and as little dtest as possible imo. Let me go through them, as they're new to me, and get back to you.
Btw your dtest run looks good. I guess we didn't break mush stuff :-)

@adelapena again, thanks a lot for looking into this. Given you've put the time into implementing your approach I have patched and adopted it. At the end of the day you're more familiar with the code and it's uses than me :-)

Great, have you pushed the merge?

The dtests thing... mmmm we should try to have as much utest and as little dtest as possible imo. Let me go through them, as they're new to me, and get back to you

Right, I was thinking of testing the log messages informing about when an index becomes queryable/writable. The dtest test_failing_manual_rebuild_index looks ideal for this purpose, we could easily add node.grep_log checks after each index (re)build to check that it behaves at is supposed. I don't know if we have tools to verify logs and simulate node restarts in utest.

Btw your dtest run looks good. I guess we didn't break much stuff :-)

This is good news, it seems that at least we didn't make it worse than it was :smiley:

Edit: On the recent 4.0 status email do you have any strong opinions on this ticket? I don't expect dtests will need much and we're close to merging it seems. I would vote to leave this in 4.0 being so close. My 2cts.

I think we are close to merge. Extending dtests should be a quite small task, probably just the few log checks mentioned above. It's true that the ticket doesn't solve any serious problem that we have with current implementations, but it's not very invasive and it's almost done, so I would also be in favour of keeping it in 4.0

@adelapena I have pushed the latest + you can find the dtests PR on the jira ticket. The 2i dtest passes locally also. If you like what you see I'll run the full dtest suite. So far utests look good:

CI j11
CI j8

I have left a few suggested changes here. Changes for the dtest are here.
As mentioned in my previous comment, the sequence of operations in SIM#rebuildIndexesBlocking is modified to:

Set indexes as writable to not miss incoming writes.
Flush the base table if some index wasn't writable before, so the potentially unindexed memtable contents are moved to the set of sstables to be indexed.
Acquire sstable refs and rebuild.

I have also done some modifications to the way we determine whether we should use Index#getBuildTaskSupport or Index#getRecoveryTaskSupport. SIM#buildIndexesBlocking is only called by either SIM#rebuildIndexesBlocking or SIM#handleNotification. I understand that if the caller is rebuildIndexesBlocking we are always doing a full rebuild, and probably the only reason to do that is that we are attempting to recover a damaged index. Conversely, if the caller is handleNotification we are doing a partial build of new data that is unable to recover previous errors. This is why I think that the isFullRebuild argument is enough to determine whether we are recovering or indexing new data. This makes full rebuild independent of the status of the index, so any call to nodetool rebuild_index will involve getRecoveryTaskSupport, which is intended to do any initialization work that might be needed prior to a full index build. Do you think this assumption is correct, or are we interested in treating separately full rebuilds without a previous failure?
Unit tests are also slightly modified to reflect the changes. SecondaryIndexManagerTest is extended with queryability/writability checks over a write-only-on-failure index.
Summarizing, I think that at this point the patch achieves the following:

Full index rebuilds give indexes the opportunity to run specific rebuild logic, including initialization. This logic can be different from the logic that is used when regularly indexing new sstables.
If any full rebuild or a partial build task fails, the index can start to reject queries and ignore writes until a full rebuild is successfully run. Whether it rejects queries or ignores writes is defined by the index implementation.
Rebuilt indexes don't miss data after having been ignoring writes.
Existing indexes preserve their original behaviour. They always accept writes and only reject reads if the initial build has failed.
The index API is backwards compatible.

Do you think it makes any sense?

Hi @adelapena. Thx for the commit. I patched it and apply it here. Feel free to push here directly next time so it's authored by you rather than me so I don't steal your thunder :-)
I think what you do here makes perfect sense from the pov you have. Basically you try to infer as much as possible and rely on reasonable assumptions. I still think, call me stubborn :-) , I'd like my approach better. But as you mention this patch brings goodness and if in the future we need to move closer to my pov it's an easy change. So I am +1 on merging this. Having catched the missing flush, the extra testing around things, etc it's all good value.
Let me run CI and I'll post results here when done.

CI runs:

CI j8
CI j11

I checked failures: SlowQueryLog is a known one, the SimpleStragey cast one is one I fixed in another ticket, the Cqlsh one on empty values passes locally, the other few look completely unrelated, etc. I think we're good to merge.

@bereng I can't see the links to CI. I'm running ci-cassandra too. Anyway, it seems that we are mostly ready to commit.

I think what you do here makes perfect sense from the pov you have. Basically you try to infer as much as possible and rely on reasonable assumptions. I still think, call me stubborn :-) , I'd like my approach better. But as you mention this patch brings goodness and if in the future we need to move closer to my pov it's an easy change. So I am +1 on merging this. Having catched the missing flush, the extra testing around things, etc it's all good value.

Now that we have the general mechanism to define queryability and writability on failure, we can open a followup ticket to more aggressively change the default behaviour of Cassandra indexes, possibly with some discussion in the mail list so we don't interfere with existing use cases. If necessary, it wouldn't be difficult to pass the LoadType to the CQL index options, so users can decide how their indexes will behave, choosing between availability and consistency. As for failing writes on badly built indexes instead of ignoring them, we should also have some discussion because it will quite aggressively affect the base table/keyspace availability, messing with repairs, compactions, etc. It will also might make sense to have some mechanism to make coordinators aware of which nodes are not available for reads and writes so they can avoid them.

Great, so you can't access them. I can't tell why as they seem to work for me and your ci-cassandra run failed on trying to pull my dtests branch. The joys of CI :-) What error do you get on my links or do you want to rerun yours?

I see a message telling Workflows >> null >> null >> null >>. However I can see the list of your workflows on https://circleci.com/gh/bereng/workflows/cassandra , but I can't see the detail of any of them 🤷
Currently I'm having trouble to login at ci-cassandra and re-run, I'll try later.

I have managed to see your CI run. It seems that CircleCI was punishing me for using the old UI, and at the same time it wasn't showing me the option to upgrade to the new UI 🤦
The results look good to me to. SlowQueryLog is failing because dtests include CASSANDRA-15503 but this PR doesn't. Perhaps we should squash+rebase and run a final CI round, and we'll be ready to merge, WDYT?

@adelapena apologies for the late reply. I was going down a rabbit hole debugging a failing test yesterday and I didn't get around to this. Rebased and squashed. We'll have to wait for the CI runs to complete now:

CI j8
CI j11

@adelapena The CI runs are complete. The failures I see I think are just flaky tests because I ran some locally and they passed.
The scare comes from the j8/j11UnitTests that fail on SIMT (yikes). So I ran that test locally compiled in j8 under j8 and it passes. It passes also compiled on j8 and ran under j11. I checked the logs for the test and it's full of socket and 'too many open files' exceptions. I did run ant test under j11 locally and all passed.
Also I managed to rerun that j8 run here and you can see now a j8 utest failed but the j11 utests all passed :shrug:  (pick your poison lol)
I think this is all CI headaches/noise. It would be great if you could run j8/j11 utests yourself on cassandra ci before merging to be on the safe side. Wdyt?

I think this is all CI headaches/noise. It would be great if you could run j8/j11 utests yourself on cassandra ci before merging to be on the safe side. Wdyt?

@bereng Most probably it's just CI noise. I'm running cassandra-ci, now that I'm able to login into it again:

utest
dtest

108
126

Unfortunately I don't know if there is a way to specify the Java version in cassandra-ci.
One of the errors seems to occur in SecondaryIndexManagerTest. We might have made it flaky, so I'm running our classic private multiplexer here and here 🤞

@bereng It seems that SIMT#initializingIndexNotQueryableButMaybeNotWritableAfterPartialRebuild and indexWithFailedInitializationDoesNotChangeQueryabilityNorWritabilityAfterPartialRebuild are definitively flaky. I haven't dug into it, but it seems that somehow the SIM calls logAndMarkIndexesFailed with an unexpected null exception. The failure can be reproduced just running any of the problematic tests multiple times in IntelliJ, or you can see them in the multiplexer runs above.

@adelapena ok that took a while to pin down. There were concurrency issues with the these sets keeping track of the indices, which lead to wrong failedIndexes lists triggering the NPE. The fix is here
I did run the test 1K times and it passed. Now waiting on CI.

Nice detective work. So it seems that by introducing multiple indexes in the test we have found and fixed and unrelated bug in the SIM, that's a good thing.
If CI looks we'll finally be ready to merge :shipit:

@adelapena circle CI is on a partial outage and it fails on dtests env set up etc. If you fancy firing one in cassandra ci good, otherwise I'll try to get CI runs again tomorrow #justfyi

Cassandra CI re-running utests and dtests.

Lgtm. Wdyt?

Looks good to me too, merging.

Committed to master as 595dc61290a9fda15b6765711141039ec9609bb3.


Liquid Exception: Couldn't find file '{{ include.icon }}' in /_layouts/post.html

Help.
For a couple of days I'm getting the error above when I try to run npm run local or npm run publish. I haven't changed anything about the layouts or includes if that helps.
Thanks in advance.

I'm seeing this as well with npm run local for {{ include.path-detail }}.

 Liquid Exception: Couldn't find file '{{ include.path-detail }}' in C:/chalk/_posts/2017-12-21-chalk-sample-post-with-all-elements.md
Getting this while running npm run local

I had to fix the version of Jekyll to 3.8.x as jekyll-assets doesn't support 4.0 yet :-/ So now it should be solved!


Bug: Pasting a table inside another table throws an error and breaks the page

When the user copies and paste a table inside another table and then tries to open the popup menu, in production mode, it throws an error that breaks the app.
The error says "Minified Lexical error #115"
When I try to reproduce it in development mode we get the following error "Error: Unexpected empty cell" and lots of "TypeError: findFn is not a function"
Lexical version: 0.11.2
Steps To Reproduce

Add a table with at least 2 columns
Put some text inside both columns
Copy the table
Paste it right after the text of the second column
Open the column menu of the pasted table

https://github.com/facebook/lexical/assets/106270839/5b79c437-56f3-4ddd-a276-af4232e21f07

The current behavior
An error is thrown when the user tries to open the column menu in a table that was just pasted inside another table.
The expected behavior
The column menu is shown without any issues and the user can perform all the actions related to this menu.

Bump the version to 0.11.3 I believe this one includes the findFn fix, that said nesting tables is not working well right now in general.

Nested tables was fixed some time ago, not sure which version, but definitely 6 months+ at this point.


would be nice if we could get hero_id in public_matches

https://www.opendota.com/explorer
https://github.com/odota/core/blob/master/sql/create_tables.sql

This is a player_match level field, but you can JOIN with matches table to get back rows with combined player_matches in them.
http://stackoverflow.com/questions/43870/how-to-concatenate-strings-of-a-string-field-in-a-postgresql-group-by-query


Investigation: Quality of Life improvements to CRD Upgrade Safety validations

@joelanford and I have noticed that a few operators from the operatorhub.io catalog fail the CRD preflight checks on upgrades due to "unknown changes" having occurred.
We should do some investigation to see what changes are commonly being failed on, if they are valid non-breaking changes, and what updates could be made to the validations to increase the QoL of users.

One that I recall failing during an upgrade was argocd


chore: bump agent-twitter-client version to v0.0.17

lockfile isn't happy since you updated the dependencies you will probably need to pnpm i --no-frozen-lockfile to pass the test

lockfile isn't happy since you updated the dependencies you will probably need to pnpm i --no-frozen-lockfile to pass the test

Yes, I am regenerating another one.


CAQH connector docs

Hi George,
Please see the PR with CAQH docs for your review.
Thanks
Sejal

All docs reviewed & tesetd by Mysti Berry.


Gizmos are hard to see in Display Overdraw mode, need color

Godot version
3.4.3, 3.4.4.rc1
System information
macOS
Issue description
Using Overdraw the gizmos become really hard to see. They should be colored to standout like in the other modes

Steps to reproduce
Change the viewport to Display Overdraw mode
Minimal reproduction project
No response

Due to the way the material override is applied, I don't think this is technically feasible until https://github.com/godotengine/godot-proposals/issues/2138 is implemented.


Modify dea_classification tools to handle training data extraction for multiple products

The get_training_data_for_shp function from dea_classificationtools.py currently extracts remote sensing data for a specified product for each shapefile feature that contains a class label.
Multiple products are helpful for effective land cover classification.
Current workflows run the function multiple times and concatenate the results into a single array.
It would be easier for users to pass a list of products e.g. [ls8_nbart_geomedian_annual', 'ls8_nbart_tmad_annual'].

Fixed using a custom function approach where products can piggyback query using like=ds.geobox. Example provided in docstring of get_training_data_for_shp
Overall approach leans towards the user for more complex feature generation such as this instead of trying to accommodate every possible option and ending up with overly complex code.


Pinch zoom

Introduce pinch zoom,  possibly only on pause.  Needs to not conflict with swipe

Most promissing is
http://blog.sephiroth.it/2011/04/04/imageview-zoom-and-scroll/
Another simple option is to use WebView instead of ImageView. However, it will change the whole loading procedure


Remove multiplayer mode and correctly check current channel

Summary
Closes #871
With multiplayer and a missing check for the right channel the bot would respond to each message as one directed to the game. Multiplayer mode is planned to be reintroduced later on using threads (tracked in #872).

Note: This pull request should be squash-merged


Add information about how to create the profiling call graph

The information about profiling in CONTRIBUTING.md is missing the info how to create the call graph from #81 , see https://github.com/ImperialCollegeLondon/pyrealm/issues/81#issuecomment-1683632703 . The same comment also provides the command for the coverage report. Note that the command needs graphviz installed, which includes dot, which is the tool to convert the files to svg.
This information should be added to CONTRIBUTING.md.

Windows developers will need manually install graphviz. For example from releases at https://gitlab.com/graphviz/graphviz/-/releases.


Stop tracking button needs to be pressed multiple times to actually stop the tracking

While working on https://github.com/sitcomlab/simport-learning-app/issues/235, I realized that it takes multiple attempts of pressing the button to actually stop the tracking.
This is also something that the participants of the pre-study reported.

Test with new version of background location library first.


Create basic code structure

As an IC, I need definition of basic elements and isolation of independent pieces so that my work does not overlap / conflict with other's work.
Create files and stub code to identify basic pipeline flow and orchestration.
Complete when:

separate files defined for each stage in the event processing pipeline
main.py orchestrates individual elements

@stevetarver is this one done, or is there more work to do?


Migrate to stable rustc

Tasks

[x] Visit / Fold for stable rustc
[x] VisitWith / FoldWth for stable rustc

[x] visit_with / fold_with
[x] visit_children / fold_children

[x] Visit / Fold for Either
[x] Fold for Repeat
[x] chain!
[ ] Migrattion

[x] swc_visit

[ ] swc_ecma_transforms

[ ] 1. specialization
[ ] 2. fix regressions
[ ] 3. box_syntax
[ ] 4. box_patterns

@ry @bartlomieju I can add a feature to visitor generator which creates a special visitor that visits children a provided visitor. Will it help deno_lint?

@ry @bartlomieju I can add a feature to visitor generator which creates a special visitor that visits children a provided visitor. Will it help deno_lint?

It's not really required at the moment but it surely be useful

Thanks! Migrating to stable rust might fix https://github.com/nestdotland/deno_swc/pull/14


[REEF-422]: Convert Wake Layer from Writable to Streaming

This addressed the issue by

using StreamingCodec in WritableLink instead of Writable by reflection.
Removing Writable constraint on generic in WritableLink, WritableTransportServer, WritableTransportClient, WritableRemoteManager
Introduce TemporaryWritableToStreamingCodec so that Network Service layer can still use Writable interface.

StreamingCodec is assumed to have at most static argument parameters.That is it cannot have parameters that change from one message to another.
JIRA: REEF-422

I'll do a pass.

@dkm2110 I did a pass. Many small comments. Generally, it would help to reduce the number of comments to use the IDE to remove all unused imports and to minimize the changes such that pure formatting changes aren't part of the diff.

I have done to pass to incorporate markus changes.

@dkm2110 [REEF-436] is merged. You should be able to make these classes now internal without breaking the tests.

changed modifier to internal. please review and merge
On Thu, Jul 2, 2015 at 2:29 PM, Markus Weimer<EMAIL_ADDRESS>wrote:

@dkm2110 https://github.com/dkm2110 [REEF-436] is merged. You should be
able to make these classes now internal without breaking the tests.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-reef/pull/261#issuecomment-118173107
.

@dkm2110 I've done another pass.

@markusweimer  I have done the changes suggested and cleaned up the code in Server Client and RemoteManager. I am yet to clean up the RemoteManagerFactory code and will do it with the Network Service layer since otherwise I have to change function calls in Network Service.

I'll do another pass.

@dkm2110 I've done another pass.

@markusweimer  made the suggested changes.

@dkm2110 Thanks, I did another pass.

I'm doing another pass.

All tests pass, I'll merge this.


ThirdwebProvider doesn't support passing Base Goerli chainId or slug

Hello,
I tried modifying the thirdweb NFT Gallery template to use a NFT collection on Base Goerli.
During this process, I set the activeChain of the ThirdwebProvider to be base-goerli, but got the following error:
Error: Invalid chain: "base-goerli". It is not one of supportedChains
I also get a similar error when providing the chainId 84531.
However, importing and using BaseGoerli directly from @thirdweb-dev/chains works as expected.
import { BaseGoerli } from "@thirdweb-dev/chains";

Expected behavior: Base Goerli is detected as a supportedChain, even when only providing the slug or chainId to the ThirdwebProvider, as works with other supported chains.

@taycaldwell you can only specify a string or number to activeChain if it's one of the thirdweb's default supported chains. Otherwise you need to pass the full Chain object as mentioned in docs: https://portal.thirdweb.com/react/react.thirdwebprovider
import { BaseGoerli } from "@thirdweb-dev/chains";

<ThirdwebProvider activeChain={BaseGoerli} />


Bump release?

Hey there, any chance we can get you to do a new release version? Bower grabs 1.0.1, which doesn't have the AMD hooks. Thanks!

Where do I do that?

From the main page, click on the "2 releases" near the top of the page
On the releases page, make sure that the "Releases" button is highlighted
Click "Draft New Release"
Type in a new number where it says "Tag version" (it looks like your source code has 1.0.3 in the header)
Fill in a release title (eg. "AMD Support")
Type a description of what's changed since the last release (you have 34 commits to catch up on!)

@garand Please increment the release.

There you go. :smile:

Beautiful, thanks.


HDDS-3755. [DESIGN] Storage-class for Ozone

What changes were proposed in this pull request?
This is a design doc, which is moved from hackmd to make it easier to track the progress.

@umamaheswararao @arp7 Do you have any more comments / questions?
If, not, I would suggest to start to create smaller patches from #1208 and merge them one by one...

Isn't this design doc a few steps away from coding? A ton of detail is missing around how SCM will manage multiple classes of pipelines and how replication manager will need to be modified.

All the replication logic (PipelineManager/ReplicationManager) will work exactly as before. Storage-class will be resolved to the required replication config. Pipelines will have the same type as before (eg. Ratis/THREE)

Really? I seems impossible that we can introduce new storage classes without requiring changes to the replication logic.

Isn't this design doc a few steps away from coding? A ton of detail is missing around how SCM will manage multiple classes of pipelines and how replication manager will need to be modified.

Would you be so kind add a few questions which can cover what are the missing parts for you? It would be a big help.
We have a working POC which passes all the tests, but it is possible that some details are available only in the code. If you have any question I kindly ask to put it to here and I will answer them.

All the replication logic (PipelineManager/ReplicationManager) will work exactly as before. Storage-class will be resolved to the required replication config. Pipelines will have the same type as before (eg. Ratis/THREE)

Really? It seems impossible that we can introduce new storage classes without requiring changes to the replication logic.

This paragraph is talking about the initial implementation where we wouldn't like to introduce new storage-classes, they are hard coded as Ratis/THREE and Ratis/ONE are hard-coded today.
Long-term it can be possible to introduce new storage-class without introducing new replication logic (for example Closed/TWO) or it can be possible to introduce totally new replication logic (like EC)

I would like to move forward this design doc.
There are now new (bit) concerns since 21st of September (image caching is addressed) and as it's an important abstraction both for EC and different replication levels I would prefer to achieve consensus shortly.
As far as I understood @arp7 still have concerns, and I am trying to organize an offline call with him to discuss all the open questions.
@arp7 Can you please help me to make the progress faster and write down your remaining question. It would be very great help. (Thank you in advance).

I think if you really want to proceed with this idea, you should update your design doc to describe in detail just the initial/phase 1 changes of capturing existing storage classes. The rest can be moved to future/addendum section, then it will be easier to review your patch.

Thank you very much the comments, it was a great help. I updated the document based on your feedback and I believe it's more clear and understandable now.

It clearly talks only about the current plan. A few exceptions: future plans are moved to the last section to show some context but clearly stated that it's not part of the plan. HOT/COLD data is also explained, but marked as out of the scope. It is included because it was a specific question during the discussions.

Based on your feedback I found that the flexibility level is not very clear, therefore are made it more explicit everywhere. That's the biggest change in the commit. Instead of talking about storage-class which is the definition of transitions of states I talk about storage-class as a selection of a replication mechanism (which already has implementation) and the configuration of the replication (eg. set the factor for closed containers).

I believe this change makes it clear that our opinion is closer: I don't think that we need a very flexible way to combine and container states. (Earlier version of this document used more flexible context, but I learned from the feedback).

I am not yet convinced that the effort to introduce custom new storage classes is worth it. The only immediate use case is EC which can be solved lot more easily with HDFS-like EC policies.

The other use case is the replication factor TWO, which was a request by our early adopters and tested by @maobaolong based on this concept.

Pushed the new version. Thanks again the feedback @arp7. Would you be so kind to take another look.
I also uploaded a PDF version to https://issues.apache.org/jira/browse/HDDS-3755, in case it's more readable for you...

@arp7 I think all of your concerns are addressed with the new version. It's the same concept but -- as you suggested -- scope is restricted to the current problem.
Did you have any chance to check it?
(I would prefer to finish this design process after 5 months.)

@arp7 Are you fine with the changes?
I understand that you are very busy. I totally understand if you have no time to read it again.
In this case, I will move it forward and present the final version at the community meeting and ask for merge / approval.
If you are planning to add your comments in the near future, just let me know and I will wait for it.

I am -1 on this design. You have still not defined how you will abstract out all the behavior defined by storage classes.

It is not sufficient to just define the replication factor. The replication/recovery behavior completely changes based on the replication scheme. E.g. for EC, we are talking about picking some coordinator during recovery. How do you abstract away behavior like that?

I am not sure If I understand this question. Offline-recovery and co-ordinator election is an internal implementation detail of EC replication scheme. The only role of storage-class is to select and configure the required configuration scheme. If EC 3:2 is configured we will have EC 3:2 containers created which will be managed by SCM as EC 3:2 containers.

I am -1 on this design. You have still not defined how you will abstract out all the behavior defined by storage classes.

Thank you the feedback @arp7.
I answered all of your question, please let me know if you have anymore. I am also open to explain the full concept during a call if it's more convenient for you.
Based on your question I feel that you ask questions based on the original version, which followed a very generic approach. Based on the feedback I modified the proposal and the scope of this version very focused and limited. It's more like a technique to manage configuration without significant changes on SCM side.
Please let me know if you have any more concerns.

Hey, @arp7.
Not sure what is your suggestion here, can you please clarify (you added -1 and also started discussion to improve it).

If you think it should be closed without further discussion, please close it
If you are interested about the answers to your questions please check them and let me know if you have any further questions.

Thank you very much.

Hey, @arp7.
Not sure what is your suggestion here, can you please clarify (you added -1 and also started discussion to improve it).

If you think it should be closed without further discussion, please close it
If you are interested about the answers to your questions please check them and let me know if you have any further questions.

Thank you very much.

If you think it should be closed without further discussion, please close it
It is not the reviewer's task to close PRs they disagree with. As the PR author, you are free to do so yourself though.

If you think it should be closed without further discussion, please close it
It is not the reviewer's task to close PRs they disagree with. As the PR author, you are free to do so yourself though.

It is not the reviewer's task to close PRs they disagree with. As the PR author, you are free to do so yourself though.

Personally, I would prefer to not close this, but continue the discussion and solve the defined problems in some way to make it acceptable for anybody. I asked you only, because it's not clear what is your suggestion 1 or 2, if you close it I will accept it.
If you don't close the PR I assume that you are fine to continue the discussion with you and/or others (if you have no time) to address all issues. In this case I will update the doc again and do a presentation on the community sync to find a way to go forward.

It is not the reviewer's task to close PRs they disagree with. As the PR author, you are free to do so yourself though.

Personally, I would prefer to not close this, but continue the discussion and solve the defined problems in some way to make it acceptable for anybody. I asked you only, because it's not clear what is your suggestion 1 or 2, if you close it I will accept it.
If you don't close the PR I assume that you are fine to continue the discussion with you and/or others (if you have no time) to address all issues. In this case I will update the doc again and do a presentation on the community sync to find a way to go forward.

If you don't close the PR I assume that you are fine to continue the discussion w

It seems that you have no more concerns. I am glad. I think the best way to move forward to combine the latest version (which is very lightweight) to the EC doc. We have exactly the same questions about EC: how they will be configured.

@elek, I have a binding -1 above. A veto does not expire with time.

@elek, I have a binding -1 above. A veto does not expire with time.

Thanks for the feedback. You gave a binding -1 vote for the previous version and also added your comments. All the comments are answered and addressed, you didn't review/comment the latest version which is a reworked version of the original version and concept itself is modified.
As I wrote, we faced with the same questions during the EC discussion, therefore the questions should be answered in any way. Feel free to suggest any kind of solution. If you don't, I will do my best to answer the questions for the EC design, based on all the feedback and learning from this discussion.
And feel free to comment to EC design, too. It will be published very soon.

Cosmetic changes don't count. You have failed to address fundamental questions about what storage classes mean with a container-based storage model like what Ozone uses.

Thanks for the answer @arp7.
I am afraid we have a different definition of cosmetic change. When a file with 349 lines (wc hadoop-hdds/docs/content/design/storage-class.md) is changed with 515 lines of patch (curl https://github.com/apache/ozone/commit/f52cd5a4f617bb5984959ea928951eec12ae9ab9.patch | wc) I don't think it's a cosmetic change. (even if the patch file contains the context of the changes).
You may miss, but the cosmetic change replaced the definition of the storage class compared to the previous version:
-Let's define the *storage-class* as set of used container **types and transitions** between them during the life cycle of the containers.
+Storage class is a selection of replication mechanism and definition of parameters.

You have failed to address fundamental questions about what storage classes mean with a container-based storage model like what Ozone uses.

Thanks for the feedback. With all the respect I don't think that this sentence is completely true. At least not in a way, what I could use it to learn it from. From my point of this was answer in the document and I also tried to answer the questions in the comment (or at least get quetions).
But it seems that I am definitely failed to continue an effective discussion with you, wether it's my fault or not.
I am closing this PR now, and trying to answer the open questions (how to support multiple replication method) in the EC doc. Hope we can have a good discussion there.


Improve ColorUtils

We should possibly move to something like chroma for color utils. Our current ColorUtils.isDark has poor performance because it does a dom manipulation
At least improve isDark and audit any other color utils we have to remove dom manipulations. Changing to a library would just give us more utils

The colorjs.io package looks good lately as it supports CSS4 colors. Something I just remembered though is the enterprise "system badge" features accepts css variables as a value, so var(--info) (as a way of using system colors from iris.prop settings), which means it will always require getComputedStyle. However that could be broken into a separate function that system badge calls first.
That is until color-contrast() css function ships (if ever).

See my comment, I think we can WNI this.


images are all lts - no weekly images

Looks like what I understand to be intended latest weekly images are actually only the latest LTS version.
For example tag alpine includes docker command:
ARG JENKINS_URL=https://repo.jenkins-ci.org/public/org/jenkins-ci/main/jenkins-war/2.375.3/jenkins-war-2.375.3.war
I think it may be related to this line of publish.sh assuming that the output of get-latest-versions() is different to what it now is, where the LTS versions are last in the list.

That is correct, thanks for reporting and pointing the mistake!
Now that https://github.com/jenkinsci/docker/pull/1564 fixed the root cause, I feel like we should rollback https://github.com/jenkinsci/docker/commit/b9e129dfe9192ffb27a849520a779256bd02a235 and https://github.com/jenkinsci/docker/pull/1558

@PiersRBME On short time, you can still pin your version to the weekly version (and update it): it works very well and ensure no unexpected core changes. You can find an exemple at https://github.com/jenkins-infra/docker-jenkins-weekly

Thanks for the tip! Not a big rush this side, more of a head-scratcher for a short time :)

more of a head-scratcher for a short time :)

Ah ah I feel you :D

Fix applied in #1578. Thanks @PiersRBME ! It should be "applied" for the weekly 2.392 (worst case ETA).

The release 2.392 was published successfuly today.
The tag latest is now pointing to the same digest as the 2.392:
$ docker pull jenkins/jenkins:latest
latest: Pulling from jenkins/jenkins
Digest: sha256:5f74addba6c8e05b008f5f06cd0f47d45d483b43352c465a59a8dad98e6f9d63
Status: Downloaded newer image for jenkins/jenkins:latest
docker.io/jenkins/jenkins:latest
$ docker pull jenkins/jenkins:2.392
2.392: Pulling from jenkins/jenkins
Digest: sha256:5f74addba6c8e05b008f5f06cd0f47d45d483b43352c465a59a8dad98e6f9d63
Status: Image is up to date for jenkins/jenkins:2.392
docker.io/jenkins/jenkins:2.392

Thanks again for catching and reporting properly, sorry for the inconvenience!

It works now for me, thanks a lot for the fix. 🤗


Add serviceaccounts to calicoctl role

Description

fixes https://github.com/projectcalico/calicoctl/issues/1900
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 60f2c65d41994db913081e7c9f5d8664e3bf0094
https://deploy-preview-2170--calico.netlify.com


Improve the documentation of swap_dims

This adds examples to both Dataset.swap_dims and DataArray.swap_dims (and fixes an oversight on my part in #3329).
From #2838, it seems that there was the intention to rename it, but as far as I can tell, that decision is not official yet (and Dataset even got its own new rename_dims).

[x] Passes black . && mypy . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

done.
The error in building the docs seems to have something to do with plotting and "tight_layout" (the reason is the warning from plotting.rst, line 528: Tight layout not applied. tight_layout cannot make axes height small enough to accommodate all axes decorations), so I guess this is unrelated to my changes?

Thanks @keewis!
Yes that failure looks unrelated.

Thanks @keewis!


Google Analytics track orders don't work

Description:
When Google Analytics is setup for a saleschannel and 'Track orders' are enabled, the purchase events are not added to Google Analytics.
The event is fired however the in platform/src/Storefront/Resources/app/storefront/src/plugin/google-analytics/events/purchase.event.js, however the field 'transaction_id' is filled with the value of window.contextToken but this is always emtpy so the event isn't accepted by Google.
Environment:
Linux server
Steps to reproduce:
Activate analytics on sales channel level in admin by adding a UA code and activate 'track orders'. Then place an order and check your analytics.
Expected result:
That the transaction_id is filled correctly so it appears in Google Analytics.
Actual result:
Purchase events don't show up in Google Analytics
Maybe a better way is to implement it on the return page after the order is placed. In that case you can sent the ordernumber as transactionId to Google instead of a cart id.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-9781.
[created from NEXT-9781, comment 485635]

The data-order-number value of the .finish-ordernumber element is used:
https://github.com/shopware/shopware/blob/2183a64ea5af5e43f220679bdd3bb5f89e0f603a/src/Storefront/Resources/app/storefront/src/plugin/google-analytics/events/purchase.event.js#L16-L27
Therefore this issue should be resolved.

Hey @aragon999 has your PR https://github.com/shopware/shopware/pull/4992 resolved the issue? If this is the case, we can close it.


adding users to user function

added Yujing Huang and Thomas Mc Keon

hi - so i've corrected the patch-6 branch
can you check if that was the right thing to do and if so i guess it's ready to merge.
thanks

have tested this - it works. - ready to merge
R

Awesomooooo thx!


Added code, integrated features

Just checking this one - seems to have the ENV files included. I don't think we should include them, or we shouldn't include the API keys at least.

Just checking this one - seems to have the ENV files included. I don't think we should include them, or we shouldn't include the API keys at least.

Good catch! Removed.

Yes looks good now, thanks! Merging


Using RuboCop?

Hi @jonleighton,
Thanks for maintaining this so far! :rocket:
However, whilst trying to maintain and ship this in Debian, we found some problematic parts.
Would you be interested in using RuboCop? If so, I'd be happy to raise a PR :smile:

I'm ok to use Rubocop, but not sure how that would fix problematic parts. But if you want to send a PR, please


[Issue-1543] - different types of delivery services have different types of api requ…

…irements
before this PR, we checked the same create/update properties across all delivery services. that is not exactly accurate as different flavors of delivery services (HTTP*, DNS*, STEERING* and ANY_MAP) have different requirements.
fixes #1543

FAILURE
No test results found.
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/642/
Test FAILed.

FAILURE
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/599/

FAILURE
No test results found.
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/645/
Test FAILed.

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/648/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/602/

FAILURE
No test results found.

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/605/


[CROSSDATA-546] Support multiple drivers per JVM

Description
This PR enables the chance of having multiple driver's instances. Each user will have theirs own  SessionId and ClusterClientActor, so they can create connections to different clusters.
Testing

[X] Unit, integration tests

+1

:+1:


feat: Add spec.instanceProfile field

Fixes #4985
Description
This PR adds back support for spec.instanceProfile so that users that need to disable IAM permissions on Karpenter and anyone that needs to use a private clusters can run Karpenter without Karpenter generating the instance profile on their behalf.
How was this change tested?
make presubmit
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Don't forget docs. Nice work!

Don't forget docs. Nice work

Docs are there! Thanks for the check!

Great suggestions @sftim, would you be willing to cut a PR?

would you be willing to cut a PR?

It's on my list.


Fix built-in camera

AnyiSightCam UVC driver requires info.plist changes for all instances of idProduct and idVendor with decimal form of the product and vendor ids. You can find these values for the webcam in system information under USB. May require documentation for potential fixes.
In my case I had 0x56cb and 0x13d3 for my product and vendor ids.

FYI Webcam info on my UX581, in case its the same webcam

Yeah, it appears to be the same webcam. It looks like yours is missing its serial number, which can be problematic. Does your webcam work on your machine?

Webcam is detected in apps but no signal seems to get through, either a black or blank screen depending on the app.

Interesting note: when the usb camera is passed through to QEMU or VMware Fusion, the camera does properly function when loaded with the proper drivers.
I've added the AnyiSightCam kext in https://github.com/Qonfused/ASUS-ZenBook-Duo-14-UX481-Hackintosh/commit/e0672e87eb7d4d2a78975f29b1ebd285a1323b21, though this assumes PID 0x56cb; instances of 22219 will need to be replaced with 22251 for product ids under IOKitPersonalities (in the kext Info.plist).

Reopening as current issue is a regression.

@Qonfused @danperks Do you reset your BIOS settings and stop using modGRUBShell? I found out modGRUBShell can mess up USB ports on my UX582. Once I stop using modGRUBShell and only set the BIOS settings, I can get the camera and the USB ports to work normally.
I only set these options in BIOS:

Fast Boot: Disabled
Secure Boot Control: Disabled
VT-d: Disabled
SATA Mode Selection: AHCI
DVMT Pre-Allocated: 64M

@Qonfused @danperks Do you reset your BIOS settings and stop using modGRUBShell? I found out modGRUBShell can mess up USB ports on my UX582. Once I stop using modGRUBShell and only set the BIOS settings, I can get the camera and the USB ports to work normally.

Yes, I have re-flashed my bios since then; my current settings for reference are listed in https://github.com/Qonfused/ASUS-ZenBook-Duo-14-UX481-Hackintosh/wiki/Install-Guide-(WIP)

I don't believe there is a fix for this. Will revisit if more information about the underlying issue is found.

It's marked as internal here under port 5:

https://github.com/Qonfused/ASUS-ZenBook-Duo-14-UX481-Hackintosh/blob/83efd22fafbbeaf76c5bec7a3fa868ed32c49908/src/Kexts/UTBMap.kext/Contents/Info.plist#L81-L89
Unfortunately there is no driver support in macOS for UVC/IR cameras.

@Qonfused  Have you checked these?
https://github.com/cobaohieu/ASUS-K55VD-HACKINTOSH/issues/8
https://www.tonymacx86.com/threads/hp-hd-camera-not-working-on-hp-probook-450-g7-uvc-camera.324547/
https://www.perplexity.ai/search/how-to-get-uvc-ir-cameras-on-m-1rJgMFH5R1aUQSAf_Zhv9Q#0

I have seen the GitHub issue before, but not after Mar 2023. It did mention an updated version of CameraControl, but I'm not sure if this still works past Mojave. The main suspicion is that the camera exposure isn't set by default, so the incoming image will always be black.
There aren't any additional wires/controls exposed by the camera, so the only way to control the camera exposure would be through a UVC/IR driver.

Hey even i have the same issue am on ventura


LGTM.com - false positive "Non-iterator of class 'DFT' may be used in for-loop"

Description of the false positive
I am reported three identical issues "Non-iterator of class 'DFT' may be used in for-loop" but these are just three list comprehensions so I think a misclassification is happening here.
URL to the alert on the project page on LGTM.com
https://lgtm.com/projects/g/buffer/thug/snapshot/1d05983b4aa4099a82d8e5c516ee4430f23b2f1b/files/thug/DOM/DFT.py?sort=name&dir=ASC&mode=heatmap#xbe8beebd0188734a:1

@buffer thanks for reporting this!
It does look as the analyzer is confused when the iteration happens in the body of a class outside of any methods (that is, where the class variables are defined) AND it happens inside a list comprehension. Having the iteration inside list comprehension happening elsewhere doesn't seem to cause any issue. Let us look into it and see what's going on. Cheers.


fix(policy): add nil checking for appeal config field

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.786%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5302

Relevant Lines:
6996

💛  - Coveralls


make cleanbot anchorable

About the PR
title
Why / Balance
so science can more effectively force cleanbots to do their bidding
Technical details
no
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no
Changelog
:cl:

tweak: Cleanbots can now be anchored in places you expect to get messy.

turns out the ai technology isnt quite there yet (it will only clean the tile its on and above it)


Recognizing complex tables on bad PDF

Hi,
I receive terrible PDFs from the government where I am working in Africa, and it seems to me the best way to transform them in CSV would be to be able to draw the lines ourselves on the table (ideally with virtual pen, the way tables are drawn in MS Word), and to have the result displayed not by line, but by cell.
I am not sure how practical is this.
The image shows the use of the selection tool in Tabula. Doing this however will result in each selection being one after the other in the same column: The structure of the table is not replicated. Moreover, text is entered in different rows even when they belong to a single cell.

Drawing lines to recreate the structure of the table would make easier to extract the data cell by cell, recreate the structure and insert the extracted data in the corresponding cell.
This would be similar to "Lattice" tool except that in the case of the PDF I receive Lattice does not find the lines. So that would be the extra step where we would help lattice find the lines by drawing them ourselves.
Thanks anyway for this very useful tool,
David

Hi @dor2000,
Thanks for the suggestion. What you propose, is a feature that we've always had in our wishlist.
We might implement it sometime in the future, but being a volunteer-run project, can't make any promises.
Thanks!

Hello, any news about this issue ?


explicit backend in call log runtime metadata

These runtime metadata are being honored in the case of setting final call logs option

Looks good, and looks like it might even make my "de-separate-ification" easier. 👍


Update pike-rc dependencies

This updates the pike-rc OSA dependencies to include the Nova cell
fixes that were included with this commit:
https://review.openstack.org/#/c/554675/
Issue: RI-230
Issue: RI-230

still doesn't include the galera fix either.


UI to read/retrieve an inventory item

"changes made to read/retrieve an inventory item from the UI"

If I try to read an item which does not exist

If I read an existing item, then it will shows the result


google maps api Positioning deviation

why

Where i get a keys in the google map

Hi,
I'm not sure what you're asking here. Try having a look at the getting started guides for the Maps Android API.
If that doesn't answer your question, try posting it to Stack Overflow, as detailed here.
If your question is specific to the code in this repository, feel free to come back and list it as an issue here on Github.
Instructions for obtaining an API key for the Google Maps Android API can be found here.


symbols-outline.lua:307: attempt to index field 'vijw' (a nil value)

E5108: Error executing lua ...acker/start/symbols-outline.nvim/lua/symbols-outline.lua:307: attempt to index field 'vijw' (a nil value)
stack traceback:
...acker/start/symbols-outline.nvim/lua/symbols-outline.lua:307: in function 'toggle_outline'
[string ":lua"]:1: in main chunk
Press ENTER or type command to continue

i don't know how to fix this issue.

I've a similar error whenever I run the SymbolsOutlineOpen command
E5108: Error executing lua ...acker/start/symbols-outline.nvim/lua/symbols-outline.lua:315: attempt to index field 'view' (a nil value)
stack traceback:
        ...acker/start/symbols-outline.nvim/lua/symbols-outline.lua:315: in function 'open_outline'
        [string ":lua"]:1: in main chunk

I suspect the configuration pattern may have changed recently.
I was getting a very similar error message.
My error message said attempt to index field 'view' (a nil value) - note view rather than vijw (I suspect a typo in your bug report, @zhanglin2018 ...?).
My config contained a line that looked like this:
vim.g.symbols_outline = { ... }

Rather than setting that global variable, I have changed it so I pass the table directly to the setup() method, and the problem has gone away:
require("symbols-outline").setup({ ... })

@Geraint i'm not the original poster but thank you very much for your input here! I was very much puzzled with the very same issue and kept checking here for a fix... and it worked exactly as you describe.

Went there before I found that I had local ok, outline = pcall(require, "symbols_outline") at my config. Should be symbols-outline.


Array tick labels not centered along the bar correctly on horizontal bar charts

Expected Behavior

Tick labels can be passed as an array of strings to be represented as multiple lines on a chart. It is expected that the label is then centered vertically to the bar's position.
Current Behavior

The first string in the array is centered to the bar, and subsequent strings are stacked below the first one.
Possible Solution

Count the number of labels and change the initial offset for the labels to be higher by half the array length multiplied by the line height.
Steps to Reproduce (for bugs)

https://jsfiddle.net/qL4rm9an/3/
I'm not sure if I'm missing a setting or something (though I don't see why centering wouldn't be default behaviour)...
Context

I know I can draw my own labels with a homemade plugin but that is not really an option for me. I have situations where potentially dozens of charts are loaded so a solution like that would be potentially very heavy
Environment

Chart.js version: 2.7.1, 2.6.0, 2.5.0, maybe others?
Browser name and version: Any
Link to your project:

That's definitely a bug. I think y needs to be changed just before this loop https://github.com/chartjs/Chart.js/blob/master/src/core/core.scale.js#L860

Hello, I'd like to work on this if possible :)


long table name/object name breaking the format in sidebar

seq name namecheap_subscription_periods_id_seq is so long that it becomes a newline rather than the same line with the circle

This issue has already been fixed in master and will be available in the next release.

@sosedoff thanks


Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView

Which issue does this PR close?
Part of #6163
Rationale for this change
As I was reviewing https://github.com/apache/arrow-rs/pull/6368 I came across a warning about Utf8View being not completely supported which was added in #5470 by @XiangpengHao when we began the implementation
Given these types are now supported across most of this crate I think this warning is no longer relevant
What changes are included in this PR?
Remove warning in comments
Are there any user-facing changes?
Doc changes, no functional changes

Do you intend to leave in the warnings about ListView and LargeListView?
https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L297-L299
https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L312-L314

Do you intend to leave in the warnings about ListView and LargeListView?
https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L297-L299
https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L312-L314

Unfortunately I think they are still largely unimplemented (tracked by https://github.com/apache/arrow-rs/issues/5375)
@Kikkon  has some work here https://github.com/apache/arrow-rs/issues/5501 but needs help reviewing it

Thanks for the reviews @Xuanwo and @kylebarron


Getting issue to run helm mapkubeapis on GKE cluster  no Auth Provider found for name "gcp"

Getting issue to run helm mapkubeapis on GKE cluster
 helm mapkubeapis XXXX -n XXX  2023/03/15 18:36:58 Release 'XXXXX' will be checked for deprecated or removed Kubernetes APIs and will be updated if necessary to supported API versions. 2023/03/15 18:36:58 Get release 'XXXXX' latest version. Error: failed to get release 'XXXXX' latest version: query: failed to query with labels: no Auth Provider found for name "gcp" Error: plugin "mapkubeapis" exited with error

We see the same error while running mapkubeapis:

no Auth Provider found for name "oidc"

workaround: use 0.3.2 release where it works just fine


:building_construction: classical bloom API changes

PR #39  includes the routing convention and a few bug fixes.


Fix when no speech key is used and translate speech key if used

Sorry that I missed that issue during the review :/
Thanks!


Use GitHub "rebase and merge"

The git history is IMO polluted with GH's merge commits. I would recommend using the "rebase and merge" option when merging approved Pull Requests

I would not mind (and do that myself elsewhere). Simplest way to achieve that is disabling "Allow merge commits" in the settings (just checked).
@BaochengSu

Done.


fix(gradle): replaced jcenter with mavenCentral

Goal
Remove jcenter from the repository list of the bugsnag-android-gradle-project:

Replace jcenter reference in the plugin project with mavenCentral
Bump detekt to version 1.17.1 to avoid dependencies served only from jcenter
Rerun the detekt baseline to cover the existing codebase

This does not cover the jcenter references in the test fixtures as these specifically cover versions of AGP that have transitive dependencies on jcenter.
Testing
Relied on existing tests

@lemnik one note - this should target next rather than master


fix: Added missing check for attach_access_log_delivery_policy for access logs logic

Description
This change simply adds var.attach_access_log_delivery_policy into the logic computing if the bucket policy should be attached or not.
This should address issue (#251).
Motivation and Context
Without this change if a bucket is being created solely for purpose of S3 access logs without any other bucket policy related flags the combined bucket policy will not be created nor attached to the bucket.
Breaking Changes
This should not break backwards compatibility.
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

I've tested my change with code similar to this (with bucket names changed to protect the innocent):
module "access_log_bucket" {
  source                            = "git@github.com:brycewade1/terraform-aws-s3-bucket.git?ref=bugfix/attach-access-log-policy"
  bucket                            = "s3-log-bucket-${local.region}-${local.account_id}"
  attach_access_log_delivery_policy = true
}

Which produced a bucket policy similar to this:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AWSAccessLogDeliveryWrite",
            "Effect": "Allow",
            "Principal": {
                "Service": "logging.s3.amazonaws.com"
            },
            "Action": "s3:PutObject",
            "Resource": "arn:aws:s3:::s3-log-bucket-us-west-2-012345678910/*"
        },
        {
            "Sid": "AWSAccessLogDeliveryAclCheck",
            "Effect": "Allow",
            "Principal": {
                "Service": "logging.s3.amazonaws.com"
            },
            "Action": "s3:GetBucketAcl",
            "Resource": "arn:aws:s3:::s3-log-bucket-us-west-2-012345678910"
        }
    ]
}

This PR is included in version 3.15.1 :tada:


feat: Parse JSON structured logs in Argo UI. Fixes #6856

Fixes #6856
Please do not open a pull request until you have checked ALL of these:

[x] Create the PR as draft .
[x] Run make pre-commit -B to fix codegen and lint problems.
[x] Sign-off your commits (otherwise the DCO check will fail).

[x] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
[ ] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
[x] Github checks are green.
[x] Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Just revived @krrrr38's PR. Thanks @krrrr38 for your work.

@isubasinghe Can you attach the screenshots for log viewer? before and after

@sarabala1979
Before (master branch):

After with filtering on other.showme

After without filtering:

@isubasinghe question for you. I feel like you might find a few bugs in this that you need to fix afterwards. I've worked on similar feature and found a log tail of bugs that caused me to give up:
https://github.com/kubectl-logz/kubectl-logz

@alexec Thanks for the heads up, I will test this manually a bit more in that case, regardless I will be working on Argo Workflows anyway so I should be able to squash these bugs when they do come up.
Fixing merge conflict now.

Hi @alexec - @isubasinghe fixed the linter issue you highlighted. Can we please get your approval and merge when you have a moment? Thanks!


Error: The terraform-provider-snowflake_v0.80.0 plugin crashed

Terraform CLI and Provider Versions
Terraform CLI version: 1.6.1
Snowflake Provider Version: 0.80.0
Terraform Configuration
terraform {

  required_version = ">= 1.6.1"

  required_providers {
    snowflake = {
      source  = "Snowflake-Labs/snowflake"
      version = "0.80.0"
    }
  }
}

provider "snowflake" {
  account       = data.terraform_remote_state.snowflake_infrastructure.outputs.snowflake_account
  authenticator = "JWT"
}

provider "snowflake" {
  alias         = "account_admin"
  role          = "ACCOUNTADMIN"
  account       = data.terraform_remote_state.snowflake_infrastructure.outputs.snowflake_account
  authenticator = "JWT"
}

provider "snowflake" {
  alias         = "security_admin"
  role          = "SECURITYADMIN"
  account       = data.terraform_remote_state.snowflake_infrastructure.outputs.snowflake_account
  authenticator = "JWT"
}

provider "snowflake" {
  alias         = "sys_admin"
  role          = "SYSADMIN"
  account       = data.terraform_remote_state.snowflake_infrastructure.outputs.snowflake_account
  authenticator = "JWT"
}

Expected Behavior
create external tables in snowflake
Actual Behavior
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ApplyResourceChange call. The plugin logs may contain more details.
╵
Stack trace from the terraform-provider-snowflake_v0.80.0 plugin:
panic: interface conversion: interface {} is []interface {}, not []string
goroutine 66 [running]:
github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources.CreateExternalTable(0x0?, {0x10606ebc0?, 0x1400086a8f0?})
github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources/external_table.go:181 +0xb84
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0x1060b2100?, {0x1060b2100?, 0x14000994de0?}, 0xd?, {0x10606ebc0?, 0x1400086a8f0?})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.30.0/helper/schema/resource.go:766 +0x134
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0x14000d14460, {0x1060b2100, 0x14000994de0}, 0x14000638750, 0x1400099c280, {0x10606ebc0, 0x1400086a8f0})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.30.0/helper/schema/resource.go:909 +0x8a0
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0x14000c409a8, {0x1060b2100?, 0x14000994c00?}, 0x140009a6140)
github.com/hashicorp/terraform-plugin-sdk/v2@v2.30.0/helper/schema/grpc_provider.go:1072 +0xb78
github.com/hashicorp/terraform-plugin-mux/tf5to6server.v5tov6Server.ApplyResourceChange({{0x1060c5920?, 0x14000c409a8?}}, {0x1060b2100, 0x14000994c00}, 0x0?)
github.com/hashicorp/terraform-plugin-mux@v0.12.0/tf5to6server/tf5to6server.go:37 +0x58
github.com/hashicorp/terraform-plugin-mux/tf6muxserver.(*muxServer).ApplyResourceChange(0x1060b2058?, {0x1060b2100?, 0x140009948d0?}, 0x140009a60f0)
github.com/hashicorp/terraform-plugin-mux@v0.12.0/tf6muxserver/mux_server_ApplyResourceChange.go:36 +0x188
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ApplyResourceChange(0x14000bc6280, {0x1060b2100?, 0x14000994030?}, 0x1400099e000)
github.com/hashicorp/terraform-plugin-go@v0.19.1/tfprotov6/tf6server/server.go:857 +0x3bc
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ApplyResourceChange_Handler({0x106017200?, 0x14000bc6280}, {0x1060b2100, 0x14000994030}, 0x1400099c000, 0x0)
github.com/hashicorp/terraform-plugin-go@v0.19.1/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:467 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0x140001494a0, {0x1060b2100, 0x140010e8cf0}, {0x1060c1a20, 0x14000a8b040}, 0x14000a26000, 0x14000951410, 0x106d071b8, 0x0)
google.golang.org/grpc@v1.59.0/server.go:1343 +0xc6c
google.golang.org/grpc.(*Server).handleStream(0x140001494a0, {0x1060c1a20, 0x14000a8b040}, 0x14000a26000)
google.golang.org/grpc@v1.59.0/server.go:1737 +0x9f0
google.golang.org/grpc.(*Server).serveStreams.func1.1()
google.golang.org/grpc@v1.59.0/server.go:986 +0x88
created by google.golang.org/grpc.(*Server).serveStreams.func1
google.golang.org/grpc@v1.59.0/server.go:997 +0x174
Error: The terraform-provider-snowflake_v0.80.0 plugin crashed!
This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.
Steps to Reproduce

terraform apply

How much impact is this issue causing?
High
Logs
No response
Additional Information
No response

Hey @jacobcbeaudin. Thanks for reporting the issue.
The fix should be really simple. I'll push a pr for the fix today or tomorrow and it should be a part of the next release.

@sfc-gh-jcieslak Wow, thanks for fixing it so fast. It seems like the tests in the build are failing?
When will there be a next release?

@oemergenc @jacobcbeaudin
It was released today as part of the 0.82.0 version. When you update please let me know if the issue has been fixed or just close the issue, Thanks.

@oemergenc @jacobcbeaudin
It was released today as part of the 0.82.0 version. When you update please let me know if the issue has been fixed or just close the issue, Thanks.

0.82.0 fixed my issue. Thank you for the quick fix

@jacobcbeaudin @sfc-gh-jcieslak
Unfortunately the issue does not seem to be fixed. Please see my comments here:
https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2293#issuecomment-1868969435