ISO hash failing due to case sensitivity (Microsoft provides uppercase, sha265sum expects lowercase)

Nice talk at the camp, thank you and thank you for releasing this script!
I had issues with the hash validation:
Micosoft shares the hashes in uppercase:

The sha256sum tool expects them to be lowercase.
https://github.com/Phaeilo/bootloader-crimes/blob/74388f75904b62de7ce66422909857d4180cc882/bootstrap/bootstrap.sh#L64
The solution is to provide the sha256sum to lowercase.
(I just want to open this issue to inform potential others, I might add a PR.)
Follow up question:
Would you consider to allow to skip the iso hash check, for example when there is no hash provided at the web form?

Same issue, same thought. (I tried empty and it still failed.)

Possibly the same issue?

By the way, how to find out the ISO for another language?

The hash that works for me using the default ISO URL is c8dbc96b61d04c8b01faf6ce0794fdf33965c7b350eaa3eb1e6697019902945c and I could not find it anywhere. Had to compute it.
❯ wget 'https://go.microsoft.com/fwlink/p/?LinkID=2206317&clcid=0x409&culture=en-us&country=US'
--2023-11-19 12:29:24--  https://go.microsoft.com/fwlink/p/?LinkID=2206317&clcid=0x409&culture=en-us&country=US
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving go.microsoft.com (go.microsoft.com)... 2600:1419:bc00:384::2c1a, 2600:1419:bc00:390::2c1a, <IP_ADDRESS>
Connecting to go.microsoft.com (go.microsoft.com)|2600:1419:bc00:384::2c1a|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://software-static.download.prss.microsoft.com/dbazure/888969d5-f34g-4e03-ac9d-1f9786c66749/22631.2428.231001-0608.23H2_NI_RELEASE_SVC_REFRESH_CLIENTENTERPRISEEVAL_OEMRET_x64FRE_en-us.iso [following]
--2023-11-19 12:29:25--  https://software-static.download.prss.microsoft.com/dbazure/888969d5-f34g-4e03-ac9d-1f9786c66749/22631.2428.231001-0608.23H2_NI_RELEASE_SVC_REFRESH_CLIENTENTERPRISEEVAL_OEMRET_x64FRE_en-us.iso
Resolving software-static.download.prss.microsoft.com (software-static.download.prss.microsoft.com)... 2606:2800:157:3ac:1a2e:26c9:99c:8f9, <IP_ADDRESS>
Connecting to software-static.download.prss.microsoft.com (software-static.download.prss.microsoft.com)|2606:2800:157:3ac:1a2e:26c9:99c:8f9|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length:<PHONE_NUMBER> (5.8G) [application/octet-stream]
Saving to: ‘index.html?LinkID=2206317&clcid=0x409&culture=en-us&country=US’

index.html?LinkID=2206317&clci 100%[==================================================>]   5.78G  81.8MB/s    in 81s

2023-11-19 12:30:45 (73.5 MB/s) - ‘index.html?LinkID=2206317&clcid=0x409&culture=en-us&country=US’ saved [6209064960/6209064960]

❯ sha256sum index.html\?LinkID\=2206317\&clcid\=0x409\&culture\=en-us\&country\=US
c8dbc96b61d04c8b01faf6ce0794fdf33965c7b350eaa3eb1e6697019902945c  index.html?LinkID=2206317&clcid=0x409&culture=en-us&country=US


Image not found Error

Logs
dyld: Library not loaded: @rpath/ReCaptcha.framework/ReCaptcha
Referenced from: /Users/FarhanJailani/Library/Developer/CoreSimulator/Devices/3A2432DE-F89C-49E6-A56F-E81FF0FF639E/data/Containers/Bundle/Application/ACFEFED4-3AE7-401F-84DD-D0283F8E2718/Goomo.app/Goomo
Reason: image not found
Additional context
I am using Carthage for installing the framework.

Found the issue, I did not copy the framework in the build phase of the app.


refactor(typescript_indexer): emit "generates" edges for imports

Due to limitations in Kythe UIs, an anchor cannot be a definition and a
reference at the same time. For an import like
import {foo} from './bar';

it would be nice to have local uses of foo "ref" foo in the import
statement and for foo in the import statement to "ref" the definition
of foo in './bar'. Since this is not possible, instead all local uses
of foo "ref" the definition of foo in './bar'.
The current way this is done is by having all Symbol VNames
corresponding to the external definition of foo also correspond to the
local definition of foo. This is somewhat unfavorable because it
breaks TypeScript semantics.
This PR introduces an alternate approach to acheiving the same UI xref
functionality by exploiting Kythe "generates" edges.
"generates" edges connect two semantic nodes (i.e. nodes that
represent a language entity and not a source code anchor) and are
typically used for extralingual processes. They have a nice property
of folding cross-references for a UI; that is, given a graph like
(1) A -ref-> D <-generates- B <-defines/binding- C
a cross-reference between A and D is generated in a UI as if the graph
were
(2) A -ref-> B <-defines/binding- C
For the TypeScript indexer, "D" in graph (1) is a local import VName.
Local usages can reference the local import, and such references will
later be folded to provide a UI xref from the local usage to the remote
definition.
Now that they are semantic nodes, local import symbols emit a "name"
node because they are identifiers for a remote definition.
This commit introduces a change in the functionality of the indexer's
entry emissions but not in its end result UI xrefs, so the change is
best classified as a refactoring.

cc @evmar, @zzmp
cc @kythe for usage of Kythe schema

We should not generally bend the graph to make the UIs "work".  Generates edges have particular semantics, which it does not seem like this use actually follows.

Generates edges have particular semantics, which it does not seem like this use actually follows.

I agree, this definitely a hack. We are looking some way to describe an implicit alias for a symbol. Are there other edges you feel would be more appropriate? Maybe "named"?

@zrlk I believe Python has similar semantics here (in that imports create a local definition which should also be treated as a reference to the imported module).

Moved towards using "named" edges which provide the same functionality and are abide by graph semantics.

The Python indexer gets creative with which part of the syntax it associates with the definition--it actually links the import (see https://github.com/google/pytype/blob/8f90fdc6a666c5af886d332ac3a5347d21a9a750/pytype/tools/xref/testdata/import.py#L13). It doesn't add the named edges or name nodes, the use of which here seems somewhat novel. In particular, the schema says that a name node should represent an "external identifier", like a JVM-internal class name or a mangled C++ symbol.

The Python indexer gets creative with which part of the syntax it associates with the definition--it actually links the import

What happens in the case of multiple imports? Do they all reference import?
I think the Kythe schema doesn't currently have anything that properly describes the relationship expressed here.

Looks like the Python indexer will drop multiple definitions on top of the import in something like from typing import Optional, Text.
The closest existing relationship that we have is aliases (https://kythe.io/docs/schema/#aliases). @schroederc, do you know whether we use aliases edges for clustering?

Looks like the Python indexer will drop multiple definitions on top of the import in something like from typing import Optional, Text.
The closest existing relationship that we have is aliases (https://kythe.io/docs/schema/#aliases). @schroederc, do you know whether we use aliases edges for clustering?

We used to cluster aliasing, but we turned it off because it was unexpected for C++ users.

@ayazhafiz, just to confirm, should references to the local alias be aggregated with references to the definition being aliased? Or should the local alias be an explicit stopping point that users need to click through (like how Python works now)?

@ayazhafiz, just to confirm, should references to the local alias be aggregated with references to the definition being aliased?

It would be nice to have this, yes. That's the change proposed here.

Or should the local alias be an explicit stopping point that users need to click through (like how Python works now)?

If the former option is not recommended, we can do this. But this is not preferred because it breaks TypeScript semantics.

I think that, to satisfy the preferred requirements, we'll need to add a new edge kind to the schema. It would have the same clustering behavior as generates going from the definition of the thing being imported to the local name for that thing, such that the definition is the cluster head. Maybe delegates? Then the local name is an ordinary variable and named/name isn't used at all.

Due to limitations in Kythe UIs, an anchor cannot be a definition and a
reference at the same time. For an import like

Maybe I missed something, but there seem to be two separate claims here, and I think at least one of them may be false:
An anchor can be both a definition and a reference. In terms of the data model, that's perfectly OK. Historically Google's internal CodeSearch tool insisted on making a single-click action prefer one or the other, which is maybe what you're referring to in this case? But either way, that is not a limitation of the UI, that's a design choice that particular tool made.
I agree with the others who've spoken out against hacking around that decision. The UI has enough information to give the user a choice, and should do so if the user cares.

Leaving aside the definition/declaration question, it sounds like the real semantic question here is about resolution: When someone writes import foo as bar and then references bar.Baz in the code, the indexer has at least options for what to connect to the anchor:

It may refer to the binding introduced by the import statement,
It may refer to the imported package.

I'd argue the indexer should record both associations if it knows them: A user who requests cross-references for the bar at from foo import bar should be able to locate all the places where that name is actually used in the module, since that's the alias that governs its use. But likewise, a user who requests cross-references for the bar at bar.Baz should be able to locate the original definition of bar as well as the local binding at import foo as bar.
How that gets surfaced in the UI is an important but—I would argue—ancillary question.

Another reason to prefer the more "local" target when you have chain of
a: export foo
b: export {foo} from a
c: export {foo} from b
d: import {foo} from c;  foo.whatever
If you click on the 'foo' in d and it jumps you to a, you sometimes lose how you even got to a, so recording each hop separately has value.

If we don't want to consider the local created by an import as ~equivalent to the thing being imported, another possible way to satisfy the requirements may be to simply emit two ref edges at each site where the local is used. One refs the local's definition; the other refs the value bound to the local by the import. Then it's up to the UI to figure out what to do. (This is just a rehash of @creachadair's comment above.)

An anchor can be both a definition and a reference. In terms of the data model, that's perfectly OK.

Agreed. I think we should strive to emit this information in every such case.

Historically Google's internal CodeSearch tool insisted on making a single-click action prefer one or the other, which is maybe what you're referring to in this case? But either way, that is not a limitation of the UI, that's a design choice that particular tool made.

Ah, that is what I am referring to; sorry for not being more clear. I mean it as a limitation in a user's interaction with the Kythe graph - that is, a user can't see that an anchor is both a definition and reference as expressed in the Kythe graph because the UI choice is to pick one.
You are right that this should be a feature requested from the UI. And also, I think because the main usage Kythe as an indexing service is to provide cross-references in a UI, we should strive to have a good solution that works around this design choice until UI representations of an anchor as a reference and definition are a feature. I could be wrong though -- this is just my intuition.

When someone writes import foo as bar and then references bar.Baz in the code, the indexer has at least options for what to connect to the anchor:

It may refer to the binding introduced by the import statement,
It may refer to the imported package.

I'd argue the indexer should record both associations if it knows them: A user who requests cross-references for the bar at from foo import bar should be able to locate all the places where that name is actually used in the module, since that's the alias that governs its use. But likewise, a user who requests cross-references for the bar at bar.Baz should be able to locate the original definition of bar as well as the local binding at import foo as bar.

I agree; to me, giving information about everything we know about the import usage is the best solution presented so far. I do think that the most correct association is still that bar at bar.Baz references only the local import and that bar at import foo as bar references the original definition of foo. This preserves the semantics of the language, because in fact bar is an alias of foo and is therefore a unique entity.
This is a difficult argument on all sides because we are trying to mix hacks for user convenience with the most appropriate (Kythe) graph and language semantics, so it's likely my interpretation is still not the best (if there even is a least-ambiguous one here).

a: export foo
b: export {foo} from a
c: export {foo} from b
d: import {foo} from c; foo.whatever
If you click on the 'foo' in d and it jumps you to a, you sometimes lose how you even got to a, so recording each hop separately has value.

Agreed. @craigdbarber's solution works here too; it is possible to emit a reference to each hop. I would argue that doing so would be incorrect in semantic terms, because it is not the case that foo in (d) is defined by all foos in (a, b, c, d) - each is an alias. But it does provide the more-accurate hopping information.

I wonder if the UI could do a better job if we marked the names introduced by imports specially—say, by giving them a subtype (variable/imported for the sake of argument). That would allow the client to distinguish "liminal" bindings from "primary" ones. It would also permit denormalizing one hop if necessary for performance reasons: If @—ref—P and @—defines/binding—P and P.node/kind variable/imported and P—ref/imports—Q, say, then folding across the ref/imports relation for */imported nodes could be done without collapsing the identity.
I haven't fully thought through the implications of this, but it occurs to me that might be one way to tease apart the layers.

Summarizing and annotating on the ideas expressed so far:
@creachadair's variable/imported subkind:

variable/imported ...  would allow the client to distinguish "liminal" bindings from "primary" ones. It would also permit denormalizing one hop if necessary for performance reasons

If I'm understanding this correctly, this seems very close to @zrlk's delegates edge idea:

clustering behavior as generates going from the definition of the thing being imported to the local name for that thing, such that the definition is the cluster head. Maybe delegates?

For these two ideas it would be useful to also create a variable/importExport subkind (or similarly, a delegates edge) on an export from statement
export {foo} from './fooSource'; // TS/JS-only?

This would create a graph like

(left hand variable/import subkinds, right hand delegates edges)
that would have references to the import/export hops @evmar mentioned.
A UI could use these variable/import subkinds or delegates edges to fold imports across nodes:

Alternatively, each transitive usage of AExport could reference both its most-immediate hop and the "primary" AExport definition:

This requires some anchors to be both definitions and references, which is valid in the graph but not currently supported in a UI (that is, a UI chooses an anchor to be either a definition or reference, but not both).
If anchors can be treated as both definitions and references in the UI, it is also possible to just provide hops between "local" imports/usages:

This hopping mechanism can still be done in a UI that doesn't support anchors that are both definitions and references but separating the anchor defining a node and the anchor referencing from that node:

This is what the Python indexer does.

Your synopsis seems accurate to me. Only your point (3) I think may not work: CodeSearch does not actually care about the identity of anchors, only their spans within the file—since that's how it decorates the file. That may have changed since I left, but if not, having a separate anchor at the same location will not fix the separation issue in the UI. A more sophisticated UI could make use of it, though.

In (3) the anchors are emitted at different locations:
@import defines/binding LocalBar
@bar ref ExternalBar
from foo import bar

In (3) the anchors are emitted at different locations:
# @import defines/binding LocalBar
# @bar ref ExternalBar
from foo import bar

I see. But then what happens if there is more than one import?
from foo import bar, baz          # no aliases
from foo import bar as baz, quux  # aliases or mixed

I realize Google's Python style guide says you shoudn't do this, but even in Google3 it shows up in third-party code all the time. And at least from what TS code I've seen, it's pretty common to import multiple names this way too.

For the record, this would also happen for C++ using declarations, in that a more "correct" modelling of: using ::namespace::Type; would be to treat it as equivalent to the type alias using Type = ::namespace::Type;, but with overlapping spans on Type for the reference and alias definition.  We don't currently do this (we only emit the reference), but there is at least one feature request around this from what I recall.
I still think (1) is the right solution and, AFAICT, the delegates would essentially be a more general form of the aliases edge, arguably obviating the latter (and potentially suggesting that we expand aliases rather than introducing a new edge).

I see. But then what happens if there is more than one import?

The local import definitions all cluster on the import anchor. See zrlk's comment.

delegates would essentially be a more general form of the aliases edge, arguably obviating the latter (and potentially suggesting that we expand aliases rather than introducing a new edge).

I agree. Though I'm not sure if there are any other situations of value aliasing except in imports/exports. Perhaps pointer aliasing, but this is a compiler feature, not a programming language feature.

It's only "value" aliasing because Python doesn't have anything else ;-)  There was a C++ proposal to allow using Name = AnotherName; to be used regardless of the kind of AnotherName but because it was reasonable it hasn't been adopted.

Regarding your comment, Kythe may need to give the UI better information so the UI can do the right thing, but Kythe shouldn't try to work around UI choices.
There's no real constraint that the UI can't support definitions and references on one anchor.  It's just that the UI needs to know what happens on a click. Right now the two options are goto the definition or open the xref panel.

Kythe may need to give the UI better information so the UI can do the right thing

What kind of additional information would be useful for Kythe to provide in this case? Is it possible to always open the xrefs panel when an anchor has definitions and references?

Expanding aliases to do what delegates is suggested to do above would cause a regression for C++ users, for whom we narrowed aliases in the first place.
I still like fixing the UI, adding both refs in (to the def of the local name and to the def of the thing being imported), and using the variable/import subkind. delegates is still an option, but it might rope in too many local names in this instance; the UI would have to figure out how to scope them to the local file if the user wanted (to avoid dumping out from a reference to an import of module foo all of the references to imports of foo everywhere).

We talked this out today and came up with a new suggestion. Use an aliases edge between the imported variable/import node and the thing it targets. To avoid the problem we ran into with C++[1], we're going to change the way aliases behaves during denormalization. Roughly, if A aliases B, references to A will roll up to B, but references to B (or A' where A' aliases B) won't roll down to A.
For imports like from foo import bar, bar should both defines/binding the variable/import and ref bar in foo[2]. For imports like from foo import bar as baz, baz defines/binding the variable/import node, while bar should still ref bar in foo.
What do you think?
[1] the historic problem had to do with a typedef like using foo = double, where someone wanted to identify places where foo was used, but was helpfully provided with all of those sites plus everything else that was a double.
[2] Pending UI changes, putting the defines/binding spans on the import for non-renamed imports should work.

For imports like from foo import bar, bar should both defines/binding the variable/import and ref bar in foo[2]. For imports like from foo import bar as baz, baz defines/binding the variable/import node, while bar should still ref bar in foo.

This is reasonable to me; it is the "optimal" solution preserving graph semantics. Where do alias edges fit in here, if at all?

Pending UI changes, putting the defines/binding spans on the import for non-renamed imports should work.

This is okay to me too, but let's see if there are any objections, as this is a hack we may not want to spread across multiple indexers. Is there any estimate for the timeline on the UI changes (@hildrum)?

The aliases edges are necessary for usages of the local baz to appear in the imported bar's cross-references (similarly for non-renaming imports).

So in from foo import bar as baz Baz aliases Bar, and in from foo import bar LocalBar aliases FooBar? (node names arbitrary)

We talked this out today and came up with a new suggestion. Use an aliases edge between the imported variable/import node and the thing it targets.

With the change you described, I think this could work pretty well. I suppose it could be a little weird in Python where aliases might hop, e.g.
# foo/__init__.py
from _submodule import thingy as Whatzit

# app.py
from foo import Whatzit as Hoozimabob

So now @Hoozimabob—defines/binding—[HM]—aliases—[WH]—aliases—[TH] or words to that effect. But I expect that may mostly be Python, where only values (not bindings) have types.

For imports like from foo import bar, bar should both defines/binding the variable/import and ref bar in foo[2]. For imports like from foo import bar as baz, baz defines/binding the variable/import node, while bar should still ref bar in foo.

And presumably in this case @baz—defines/binding—[BAZ:var/import]—aliases—[foo:bar]?
I don't see any obvious explosive difficulties.

We'll need to change the description of aliases to allow values to be aliased as well.

The schema changes are up to variable (#3979); initial serving support will come with #3980.

Nice! For the record, Haskell's record field punning syntax introduces at the same location a reference to the field of a data type, as well a local binding for the field of a specific record. Using this alias mechanism would come handy there.

Just another observation, when differentiating between definitions and declarations, we may want to treat the local imports as declarations rather than definitions so "jump to definition" goes to the root, rather than leaf.  But this is also a decision that can/should be deferred to the UI.


fix link to kotest matchers

It seems that the link to kotest matchers is moved.
Also, kotest sample is not found but I do not see where to link so I didn't fixed.

And you can find a sample here: https://github.com/kotest/kotest/tree/master/kotest-assertions/kotest-assertions-klock

Thanks!


Data Dashboard: Add a dropdown option, “selection needed” as default on landing

Currently, the dropdown options initialize to "COVID-19" and "the United States".
We want to allow the user to select these options on landing, rather than assigning them and having the user reassign them, so we can add a dropdown option "selection needed" and have this be the default on landing.
Alternatively, we could have the dropdown option become a blank text field that opens up dropdown options once clicked on or typed into; this can be further considered after implementation.

This seems like it should be low priority, right?

Agreed -- In general, anything not marked with the "high priority" label is
considered mid-to-low priority.
On Thu, Feb 25, 2021, 3:15 PM Aaron<EMAIL_ADDRESS>wrote:

This seems like it should be low priority, right?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/SatcherInstitute/health-equity-tracker/issues/373#issuecomment-786295513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEULCIBTQZLGEDZV7ATZDKLTA3KZRANCNFSM4XXHPMIQ
.

Completion time estimate: < 1 week

closed in #1782


MerkelNode is not functioning as intended anymore (solved?)

Note: I have mostly solved this issue now
I have followed along with several examples and tested with old .jar releases.
The function below no longer works as it use to and I can't figure out what the new implementation is supposed to be...
MerkleNode addResult = new MerkleNode(ipfs.add(file));
This function seems to want a string now....but it doesn't...and it thinks the MerkelNode is a list that is not compatible and won't let me cast it. But I'm probably doing something or overlooking something obvious.
I'm also having erroneous errors the below if I make a new project using the newest .jar but it works if I use an old project that was built from the old maven stuff.???? by that I mean I delete the dependency from old project and import the new .jar and it magically works fine.
ipfs.refs.local();
Quite frankly, I'm really at a loss here? Is everything working as intended? Could you possibly release a full example project to let us build off of and see working...
Note that I was able to build and compile the master build from download, And I will do some more testing from here. maybe the .jar was an improper or old build that was included in your last push. As I can see it is clearing working when running the API test....
Thanks!!! Great work btw.
update:
I was finally able to figure this out. I copy and pasted the actual source into my packages instead of using a dependency and then I loaded all the dependencies from your original jar as dependencies to my project directly. Everything seems fine now.
But the MerkleNode has definetly changed!
This is the new formatting if anyone needs to know :)
MerkleNode addResult = ipfs.add(file).get(0);
or
MerkleNode file2 = ipfs.add(new NamedStreamable.ByteArrayWrapper("Some data".getBytes())).get(0);
Here is the current code I was playing with that successfully posted a file to the cloud...and was retrievable via my ipfs node through command prompt.
package rotatewheel;

import io.ipfs.multihash.Multihash;
import java.io.*;
import java.nio.file.*;
import java.util.*;
import io.ipfs.api.*;
import io.ipfs.multiaddr.MultiAddress;
import java.io.File;
import java.io.IOException;

public class ipfstest {

public File ifFile = null;

public void whatfile(File file) {
    ifFile = file;
    ifFile = new File("C://i.mp3");   //comment out this line in production
    launch();
}

private void launch() {

    IPFS ipfs = new IPFS(new MultiAddress("/ip4/<IP_ADDRESS>/tcp/5001"));
    System.out.println("Connected");

    try {
        System.out.println("hostfile test");
        NamedStreamable hostFile = null;
        File holdFile = null;
        if (ifFile == null) {
            Path tempFile = Files.createTempFile("IPFS", "tmp");
            BufferedWriter w = new BufferedWriter(new FileWriter(tempFile.toFile()));
            w.append("My Data is Kenny22gdfgd.");
            w.flush();
            w.close();
            hostFile = new NamedStreamable.FileWrapper(tempFile.toFile());
            holdFile = tempFile.toFile();
        } else {
            hostFile = new NamedStreamable.FileWrapper(ifFile);
        }
        NamedStreamable file = hostFile;

        System.out.println("pin test");
        MerkleNode file2 = ipfs.add(file).get(0);

        Multihash hash = file2.hash;
        System.out.println(file2.hash + "hash: ");
        Map<Multihash, Object> ls1 = ipfs.pin.ls(IPFS.PinType.all);
        boolean pinned = ls1.containsKey(hash);
        List<Multihash> rm = ipfs.pin.rm(hash);
        List<Multihash> add2 = ipfs.pin.add(hash);
        List<Multihash> add3 = ipfs.pin.add(hash);
        Map<Multihash, Object> ls = ipfs.pin.ls(IPFS.PinType.recursive);
        ipfs.repo.gc();
        Map<Multihash, Object> ls2 = ipfs.pin.ls(IPFS.PinType.recursive);
        boolean stillPinned = ls2.containsKey(hash);
    } catch (IOException er) {
    }
    System.out.println("file put done: ");
}

public static void main(String[] args) {
    ipfstest app = new ipfstest();
    //app.launch();
    app.whatfile(null);
}

private IPFS ipfs;
}

Hi @cybershrapnel,
Glad to hear you've mostly got it working. ipfs.add returns a list of merklenodes, so no need to explicitly call the merklenode constructor. This is because depending on the options it can return more than one. For example if you tell it to wrap the file in a directory it will return two. I will update the readme to reflect the change.

yes, I am figuring it out, slowly but surely... I wish I had more documentation...But the source code of course is all you need with time :) haha
I updated the code above after you posted I think...Look it over and tell me where I am being proper.. and improper.  This works just fyi...
I'm incorporating this into the nanocheeze.com app btw.... I'm going to use it for the gridware apps download as a primary download and switch http which i currently use to secondary, and eventually I am going to integrate my Quantum NanoCompression algorithm with IPFS to store hash recreation values.  Basically a giant worldwide cloud of hash values and their corresponding data(s) and then a map to put files back together using the stored hashes. If you are curious, I posted the code to this on my github, it is a part of the nanocheeze app. If I can figure out a way to properly store the values throughout ipfs with a little help of course, you should see a file compression size of 32:1

I'm curious if you can help me with another small issue I ran into. I feel ashamed as I should be able to do this myself lol.
So I worked this api into my current downloading classes. I have a progress bar that shows your http download to the user as the file downloads. Now, if your pc is running IPFS it will download via IPFS instead of http... This works great!!
But I ran into a problem with buffer the byts from IPFS. I am already bye buffering the http stream so that it saves to a randomaccessfile just beautifully. But I cannot get the IPFS stream to do the same. It wants to send it to that api as one giant byte array.
This of course causes a memory failure on behalf of the byte array. I can work around this for the most part by increasing the VM memory heap with the xmx commands, but that is not the way I want to go obviously. But I was not able to upload nor download a 70+ megabyte file with standard VM settings. But with xmx1024 option I seem to have pretty much no problem except with really big files of course....
If you have a chance, can you show me a buffered byte array example of getting a file from the IPFS cloud. sorry to be a bother. I;m just stoked I got this working.... Everything in my app now grabs from IPFS before http :)

Closing as stale. Free free to re-open if required


Unable to use some std::string using GNU++17  with abi:cxx11 (IDFGH-13467)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I am running espidf 4.4.7 (latest compatible with platformio) and c++17.   While all ESP32 code works file, when i try to run the same code on native and call a function that returns an std::string, it with following error:
Linking .pio/build/native/program
/usr/bin/ld: .pio/build/native/src/core/core.o: in function `Core::init()':
core.cpp:(.text+0x709): undefined reference to `getHalErrorString[abi:cxx11](hal_err_t)'
collect2: error: ld returned 1 exit status
*** [.pio/build/native/program] Error 1
============================== [FAILED] Took 1.67 seconds ==============================

Environment    Status    Duration
-------------  --------  ------------
native         FAILED    00:00:01.666
======================== 1 failed, 0 succeeded in 00:00:01.666 ==

I have tried everything i could find, but nothing seems to work, i think it may be related to the "abi:cxx11" the same code build perfectly fine on esp32dev though.  Both are supposed to be using c++ 17
Code is very simple (hal_err_t is an abstraction of esp_err_t, so i can also use it in native)
halTools.h
#include <string>
std::string getHalErrorString(hal_err_t error);

halTools.cpp

std::string getHalErrorString(hal_err_t error)
{
	switch (error)
	{
		case HAL_OK:
			return "HAL_OK";
		case HAL_FAIL:
			return "HAL_FAIL";
		case HAL_ERR_NO_MEM:
			return "HAL_ERR_NO_MEM";
		case HAL_ERR_INVALID_ARG:
			return "HAL_ERR_INVALID_ARG";
		case HAL_ERR_INVALID_STATE:
			return "HAL_ERR_INVALID_STATE";
		case HAL_ERR_INVALID_SIZE:
			return "HAL_ERR_INVALID_SIZE";
		case HAL_ERR_NOT_FOUND:
			return "HAL_ERR_NOT_FOUND";
		case HAL_ERR_NOT_SUPPORTED:
			return "HAL_ERR_NOT_SUPPORTED";
		case HAL_ERR_TIMEOUT:
			return "HAL_ERR_TIMEOUT";
		case HAL_ERR_INVALID_RESPONSE:
			return "HAL_ERR_INVALID_RESPONSE";
		case HAL_ERR_INVALID_CRC:
			return "HAL_ERR_INVALID_CRC";
		case HAL_ERR_INVALID_VERSION:
			return "HAL_ERR_INVALID_VERSION";
		case HAL_ERR_INVALID_MAC:
			return "HAL_ERR_INVALID_MAC";
		case HAL_ERR_NOT_FINISHED:
			return "HAL_ERR_NOT_FINISHED";
		case HAL_ERR_CUSTOM_BASE:
			return "HAL_ERR_CUSTOM_BASE";
		case HAL_ERR_CUSTOM_2:
			return "HAL_ERR_CUSTOM_2";
		case HAL_OTA_MODE:
			return "HAL_OTA_MODE";
	}
	return "Unknown";
}

pio.ini
[env:native]
lib_ldf_mode = deep+
test_framework = googletest
test_ignore = test_esp32dev
platform = native
build_unflags = -std=gnu++11
build_flags =
    -D USE_NATIVE_ENVIRONMENT
    -std=gnu++17
lib_deps =
    bblanchon/ArduinoJson

[env:esp32dev]
lib_ldf_mode = deep+
test_framework = googletest
test_ignore = test_native
platform = espressif32
board = simovatrack130
framework = arduino, espidf
; platform_packages =
    ; framework-arduinoespressif32 @ https://github.com/italocjs/arduino-esp32.git#idf-release/v4.4
    ; framework-arduinoespressif32 @ https://github.com/espressif/arduino-esp32.git#idf-release/v4.4

board_build.partitions = partitions.csv
build_unflags = -std=gnu++11
build_flags =
    -D USE_ESP32_ENVIRONMENT
    -std=gnu++17
upload_speed = 921600
monitor_speed = 115200
monitor_filters =
    esp32_exception_decoder
    send_on_enter
lib_deps =
    bblanchon/ArduinoJson

While all ESP32 code works file, when i try to run the same code on native and call a function that returns an std::string, it with following error:

/usr/bin/ld ...

I'm sorry, your issue report contains too many things which aren't controlled by or related to ESP-IDF, the major two being the PlatformIO build system (especially the part about building the host application) and the host toolchain. As you see, the build for the ESP works fine, and that's the only part of your project which depends on ESP-IDF...
Without knowing more about how platform = native works in PlatformIO I'm afraid it's hard for ESP-IDF developers to help you. I would recommend seeking help on PlatformIO forum, instead.
(In case it helps, recent ESP-IDF versions contain a similar feature for building applications for host, and use newer C++ standard by default as well.)

Usually undefined reference means that you're not building that file and it is not available for the linker. Maybe you can add an #error to that file just to confirm it is being at least build for native compilation.


SplitView sample needs work for right-alignment

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

[ ] New sample
[ ] Addition to existing sample
[x] Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
SplitView
Describe the sample
Change placement to Right:

It's a bit weird that the content isn't stretched to put the panel on the right-side next to the options.
It get's odder when you change the display mode to CompactInline or CompactOverlay as the icons don't show up:

(Also changing the DisplayMode to CompactInline doesn't appear to work the first time, as IsPaneOpen is still on, looks like changing to the overlay modes turns it off as well at the same time, so it's inconsistent here.)

@stmoy Do you think there is much benefit to having the SplitView be switchable to right placement? Fixing those issues will get quite complicated given how the content is laid out, and I don't think there is much benefit to have a placement toggle here.
If we just show it in placement left, those issues @michael-hawker described here would be gone.

@chingucoding I think there's value in the sample gallery showing different layout options to developers/designers so they can see what building blocks they have to build experiences with. Is there a way we can modify the sample content to make this option easier to execute on?

Well currently we use a ListView to render the items. If we switch from left to right we need to update the ListViewItem style to allow the content render on the right side, and switch to a template which would show the icon on the right, so it is still visible when collapsing.
For the Settings option, I am not sure how we would do that, maybe we need to switch that out too?
The issue here is, essentially we would need to do a complete swap of the content in the Pane when we switch from left to right and vice versa as the positioning would be fundamentally different in those two cases.

@chingucoding sounds like another good scenario for my SwitchPresenter that I need to add to the Toolkit for everything 😋
I should be gathering all these cases down so I can have different test cases for checking it works for them all...

Indeed, having a control that would enable switching between two things would make that so much easier to solve! Looking forward to it.

Do we remove the right-alignment option from the sample? We could do that and keep this issue as an enhancement (to use the SwitchPresenter when that is available).

@bpulliam SwitchPresenter shipped in 7.0 of the Windows Community Toolkit 🙂 https://learn.microsoft.com/windows/communitytoolkit/controls/switchpresenter


Overall review of SDK docs v5 - Closes #1035

Closes #1035

This PR has been closed as since the new updates and re-write in the latest version of the SDK docs, a completely new review is required, so a new PR will be created for this.


Provide CPU RNG Support for 64 Bit Arm CPUs

Provide support in a new engine and provider for aarch64 random number generation. The engine and provider make use of the RNDR and RNDRRS Arm assembly instructions.

Checklist

[X] documentation is added or updated
[X] tests are added or updated

Engines are deprecated.
Adding new engine code into master may not be a good path forward.

Engines are deprecated.
Adding new engine code into master may not be a good path forward.

This does both engine and provider, with the idea that we can backport the engine to 1.1.x...

Adding an engine to 1.1.1 would be considered a new feature and I doubt it would be accepted.  It could still be distributed separately.
For 3.0, an engine is undesirable.  The provider implementation is much cleaner too.

Adding an engine to 1.1.1 would be considered a new feature and I doubt it would be accepted. It could still be distributed separately.
For 3.0, an engine is undesirable. The provider implementation is much cleaner too.

Oops, sorry, I accidentally deleted my message, as I was going to reply to your other comment above.
I agree for 3.0 the provider is the way to go. But it will take years for 3.0 to be sufficiently widespread and we would like this to be backport'able to existing enterprise distros to exploit the HW rng. But we can indeed distribute it separately if necessary.

The way to go would be to submit the provider code to master and raise a separate PR for 1.1.1 for the engine.
Perhaps start with an issue for the new feature in 1.1.1 and the OTC can decide to include or not.

The way to go would be to submit the provider code to master and raise a separate PR for 1.1.1 for the engine.
Perhaps start with an issue for the new feature in 1.1.1 and the OTC can decide to include or not.

Yup, sounds good. Thanks !

Perhaps start with an issue for the new feature in 1.1.1 and the OTC can decide to include or not.

I very much doubt that OTC will approve this.
Unfortunately I think this is probably too late for inclusion in 3.0 too.

I suppose it depends if you consider it a "new feature" or just ARM support for the existing "rdcpu" one :-)

They get squashed as part of the merge process and they help us see what has changed.

will keep that in mind for future changes.

A second reviewer's approval is required.

OTC: Should this be added to 3.0?

I'd like to see it in 3.0.
It doesn't look to be high risk and can be disabled at configuration or run time.

OTC: This is too close to beta and cannot go into 3.0

And a rebase will be required to get rid of the conflicts.

May I ask on which platform/hardware this patch was tested?  This CPU RNG feature is supported from Armv8.5, I'm wondering if there is real-world hardware to test it.

Qemu so far

@otoledan @ozbenh I am trying to do similar work for another project and wanted to ask a few details about the testing environment. What image did you use in QEMU? Did you have to pass any parameters to the QEMU launch command (via -cpu argument or any other) to enable RNG feature?
Thank you for your help!

You pass -cpu max. You can use qemu-user so you don't have to use a full blown image, which gives you faster turnaround for testing, otherwise any OS will do. I'll let Orr comment on what he specifically used

You pass -cpu max. You can use qemu-user so you don't have to use a full blown image, which gives you faster turnaround for testing, otherwise any OS will do. I'll let Orr comment on what he specifically used

Thanks for your reply, @ozbenh. I will try out what you've suggested

Télécharger Outlook pour Androidhttps://aka.ms/AAb9ysg

From: Malvika-Gupta @.>
Sent: Wednesday, November 10, 2021 5:33:14 PM
To: openssl/openssl @.>
Cc: Subscribed @.***>
Subject: Re: [openssl/openssl] Provide CPU RNG Support for 64 Bit Arm CPUs (#15361)
You pass -cpu max. You can use qemu-user so you don't have to use a full blown image, which gives you faster turnaround for testing, otherwise any OS will do. I'll let Orr comment on what he specifically used
Thanks for your reply, @ozbenhhttps://github.com/ozbenh. I will try out what you've suggested
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/openssl/openssl/pull/15361#issuecomment-965806460, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASE7IDMMHIVHU6LIUO75PW3ULLXKVANCNFSM45FUC6VQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You pass -cpu max. You can use qemu-user so you don't have to use a full blown image, which gives you faster turnaround for testing, otherwise any OS will do. I'll let Orr comment on what he specifically used

@Malvika-Gupta
So for testing, I made use of both qemu-user (speedy as @ozbenh mentioned) and a full blown image. For the full blown image with qemu, I used a cloud ubuntu image from https://cloud-images.ubuntu.com/releases/groovy/release/${img}) with -M virt -cpu max -device rtl8139, tho the -cpu max flags is the most important flag when deploying the image. There are a bunch of online guides for deploying a cloud image to qemu, which I found to be the easiest method for testing in a full blown environment.

This requires another rebase.
Ping for a @openssl/committers review?

You pass -cpu max. You can use qemu-user so you don't have to use a full blown image, which gives you faster turnaround for testing, otherwise any OS will do. I'll let Orr comment on what he specifically used

@Malvika-Gupta
So for testing, I made use of both qemu-user (speedy as @ozbenh mentioned) and a full blown image. For the full blown image with qemu, I used a cloud ubuntu image from https://cloud-images.ubuntu.com/releases/groovy/release/${img}) with -M virt -cpu max -device rtl8139, tho the -cpu max flags is the most important flag when deploying the image. There are a bunch of online guides for deploying a cloud image to qemu, which I found to be the easiest method for testing in a full blown environment.

Thanks for your reply, @otoledan. I was able to get the testing environment setup and working

Need an @openssl/committer review. @paulidale how do I go about pinging the committers?

You just did.

@mspncp? perhaps

@paulidale please reapprove

This pull request is ready to merge

Merged. Thank you for your contribution!


[Composability] Document new composability system and APIs

Feature Suggestion
Document all new building blocks that have been added and what it means for plugins, apps, and how to migrate.

[ ] Extensions and Component Data
[ ] Extensions from a plugin developer's point of view
[ ] Using Extensions in an app
[ ] RouteRefs, useRouteRef, and plugin routes and externalRoutes
[ ] Binding external routes in the app
[ ] New catalog components, EntitySwitch & EntityLayout, and how to use those in the app

We probably want this documentation to cover all aspects and not build on existing documentation. As we migrate away from the 3 different older API versions we can start cleaning up and removing existing documentation.
Context
#3414

Does this mean I could potentially revisit  #2791 soon'ish? 😄

@andrewthauer yes :grin:


[help wanted] - Image as circle

Some :angel: can help me out with creating a circle image?

:cry:


Volume controlled by ringer, not by system volume.

The problem is that, if a user turns the ringer off, my app won't make any sound. The closest related issue I could find was this but I'm not sure how to apply their solution to EPSSampler. Any clues?

Turns out this had nothing to do with EPSSampler, and everything with configuring the audio session. The following code did the trick.
NSError *error = nil;
[[AVAudioSession sharedInstance] setCategory:AVAudioSessionCategoryPlayback error:&error];

That'll teach me to RTFM.


Please help on React Native b2c login

I need MSAL plugin for react native
### Tasks

@sensationsolution what's your timeline? We can get started with it but would like to understand your timeline


Make progress notifications clickable

In cases where it could take a long time to execute a task, make the progress notification clickable so users can navigate to the terminal to view the steps being executed.
/cc @fiveisprime @gbowerman

Currently not possible - tracking issue in VS Code: https://github.com/Microsoft/vscode/issues/60979

We do this now with "View Output" links


Camo can't handle the application/octet-stream mimetype

Describe the bug
Images with external links in README.md failed to display.
Expected behavior
Images with external links in README.md should display normally.
To Reproduce
There is a gif image in my README.md with an external link to https://github.com/johnlinp/duosql/raw/master/images/duosql-demo.gif.
However, the image shown in my PyPI project page is rewritten and linked to a weird url: https://warehouse-camo.cmh1.psfhosted.org/fb671586f80a719fd21568d008eed338e97ad5f1/68747470733a2f2f6769746875622e636f6d2f6a6f686e6c696e702f64756f73716c2f7261772f6d61737465722f696d616765732f64756f73716c2d64656d6f2e676966.

Hi @johnlinp, the image you're trying to link to is https://github.com/johnlinp/duosql/raw/master/images/duosql-demo.gif, however this producing a 302 redirect that our image proxy doesn't seem to like:
$ http https://github.com/johnlinp/duosql/raw/master/images/duosql-demo.gif
HTTP/1.1 302 Found
Access-Control-Allow-Origin: https://render.githubusercontent.com
Age: 69
Cache-Control: no-cache
Content-Length: 145
Content-Security-Policy: default-src 'none'; base-uri 'self'; block-all-mixed-content; connect-src 'self' uploads.github.com www.githubstatus.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com wss://live.github.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com; frame-ancestors 'none'; frame-src render.githubusercontent.com; img-src 'self' data: github.githubassets.com identicons.github.com collector.githubapp.com github-cloud.s3.amazonaws.com *.githubusercontent.com; manifest-src 'self'; media-src 'none'; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com
Content-Type: text/html; charset=utf-8
Date: Wed, 20 Mar 2019 18:17:19 GMT
Expect-CT: max-age=2592000, report-uri="https://api.github.com/_private/browser/errors"
Location: https://raw.githubusercontent.com/johnlinp/duosql/master/images/duosql-demo.gif
Server: GitHub.com
Status: 302 Found
Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
Vary: X-PJAX
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-GitHub-Request-Id: FE52:75E8:29B59:4A3CC:5C9283F4
X-XSS-Protection: 1; mode=block

Can you try using the actual URL at
https://raw.githubusercontent.com/johnlinp/duosql/master/images/duosql-demo.gif instead?

Hi @di,
Thank you for the reply. I tried https://raw.githubusercontent.com/johnlinp/duosql/master/images/duosql-demo.gif, but it doesn't seem to solve the problem. It just changes to another weird url: https://warehouse-camo.cmh1.psfhosted.org/d9af816451be19f2e3c84f66b8f87832ce1af772/68747470733a2f2f7261772e67697468756275736572636f6e74656e742e636f6d2f6a6f686e6c696e702f64756f73716c2f6d61737465722f696d616765732f64756f73716c2d64656d6f2e676966

So, the "weird url" is our image proxy -- this is expected.
The issue is that the Content-Type for this image is application/octet-stream, which it seems our proxy can't handle. Instead, it should be image/gif. It produces this error in Camo:
Non-Image content-type returned 'application/octet-stream': https://raw.githubusercontent.com/johnlinp/duosql/master/images/duosql-demo.gif

You'll need to host the image elsewhere in order for this to work. Interestingly, if you upload the image in a comment, like this:

The link is https://user-images.githubusercontent.com/294415/54768413-1d17f900-4bcd-11e9-8611-3370f5929ce5.gif, which has the image/gif content type:
$ http https://user-images.githubusercontent.com/294415/54768413-1d17f900-4bcd-11e9-8611-3370f5929ce5.gif --headers
HTTP/1.1 200 OK
Accept-Ranges: bytes
Accept-Ranges: bytes
Age: 0
Cache-Control: max-age=2592000
Connection: keep-alive
Content-Length: 6382153
Content-Type: image/gif
Date: Thu, 21 Mar 2019 16:33:57 GMT
ETag: "931d554bec7010ce8f472b114b3af474"
Last-Modified: Thu, 21 Mar 2019 16:33:15 GMT
Server: GitHub Cloud
Timing-Allow-Origin: https://github.com
Via: 1.1 varnish
X-Cache: MISS
X-Cache-Hits: 0
X-Fastly-Request-ID: 2b582bdef495d7a333f77d0d6d31dc88836d3205
X-Served-By: cache-dfw18637-DFW
X-Timer: S1553186037.042500,VS0,VE450

And which should work with our proxy.

Thank you for the analysis. I've submitted a ticket to GitHub for why the Content-Type of my gif image is mistaken to application/octet-stream. Let's see if they have any explanation.

Hi @di,
GitHub replied:

It seems we serve gif files under 5MB via raw.githubusercontent. Any files over this size are served as downloadable octet-stream files.

It seems that there is nothing I can do but shrinking the gif image.

@johnlinp If you're satisfied in the resolution, could you close this ticket please?

Hi @jamadden,
I don't think I can close this issue. Since the title says "Camo can't handle the application/octet-stream mimetype" and it still can't right now, I think we should keep it open until it can handle application/octet-stream mimetype.

It's not clear to me that an image proxy should handle non-image MIME types. Part of the image proxy's job involves security, and to that end, that explicitly includes "Restrict[ing] proxied images content-types to a whitelist".

Sure. If you think it doesn't make sense to handle non-image mime type, we should definitely close this issue. Thanks.

I think this is probably a valid issue, and at the very least we should explore whether we can add this functionality to Camo. We will almost certainly have other users that encounter this.

Does Camo do other checks to verify images, besides the content type? That is, if the content type whitelist is expanded to include application/octet-stream, is there anything from stopping Mr. Evil from including an "image" reference in his project pointing to https://evil.example.com/badstuff/bad-data? (An exe or vbs or xls...) If not, the question is then, is that exploitable in any new way? I'm not an expert but I'll take a quick first pass at answering that.
Based on a quick test of available browsers (safari, chrome, firefox), if an  tag has a source that returns a type of application/octet-stream, the filename is inspected to attempt to decode the image. (e.g,  does nothing when /foo is served as application/octet-stream (even though it is fetched), but  does display even when /foo.gif is served as application/octet-stream.  That's not exhaustive, and doesn't include older browsers, or other ways of referencing images (if any are allowed through the renderer).
Security wise, I could imagine potential issues (overflows and the like) with browsers mishandling malformed input, but those are exactly the same issues that would result from malformed input with a recognized content type, so that's not new.
Navigating directly to the URL, either foo or foo.gif, when served with application/octet-stream, caused all the browsers to download the file, or prompt if I wanted to open it. In its default settings, Safari automatically opened foo.gif --- even when foo.gif wasn't actually a GIF, leading to errors, and more potential malformed input handling, this time on the part of arbitrary programs. The Content-Security-Policy header doesn't seem to make a difference. Since we don't currently allow octet-stream, that's new behaviour, albeit a corner case. That's potentially exploitable; is it more exploitable than a link directly to evil.example.com? Maybe, because psfhosted.org is a domain of higher trust?


Support Qt installer type

It look like https://github.com/microsoft/winget-pkgs/pull/129021 and https://github.com/microsoft/winget-pkgs/pull/129015 failed with Validation-Unattended-Failed which must required NestedInstallerType: Qt and it will support in the future

Why can't you just use the unattended switches?
InstallerSwitches:
  Silent: in --am --al -c
  SilentWithProgress: in --am --al -c


Webpack not preloading assets when using compression-webpack-plugin

Bug report

What is the current behavior?
When using plugin compression-webpack-plugin and import / * webpackPreload: true * / webpack tries to preload a non-existent, uncompressed file
If the current behavior is a bug, please provide the steps to reproduce.
Minimal reproduction repo: https://github.com/PiotrSkrzynski88/webpack-compression-preload.git
Checkout README.md for reproduction steps
Checkout console to see 404

What is the expected behavior?
Webpack should preload file compressed by compression-webpack-plugin

Other relevant information:
webpack version:  5.6.0
Node.js version: 14.15.0
Operating System: macOS Catalina 10.15.5
Additional tools:

Expected, compression-webpack-plugin only for servers (nginx/apache/etc), browser ask server to load assets and server return compressed source and avoid extra compression on server side


Added new components for email confirmation

Description
This ticket was just to build a simple, generic email confirmation page to direct users to when they receive an email with a link to verify the email address.
However, the functionality will be completed once these backend tickets are done:
Email alias db table (https://github.com/CDLUC3/dmsp_backend_prototype/issues/105)
Email service (https://github.com/CDLUC3/dmsp_backend_prototype/issues/106)

Added server-side "confirm-email" page to call the backend API endpoint /verify-email to verify the userId and token passed in the url.
When the verification passes, users are redirected to the new /email-confirmed page. There is a button on that page to take users to the /login page
If the verification fails, users are redirected to the /verification-failed page. Content will be updated later.
Created a ContentContainer component to wrap pages with the content styling, and possibly additional functionality.

Fixes # (125)
Type of change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
This was tested by adding unit tests.
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I updated the CHANGELOG.md and added documentation if necessary
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have completed manual or automated accessibility testing for my changes
[X] New and existing unit tests pass locally with my changes
[NA] Any dependent changes have been merged and published in downstream modules

Thanks @fraserclark.
I did discuss with @andrewebdev about the Content Container on another ticket, and he said to go ahead and use a simple one for now that he can expand on later.


i want java version for camerax.

see title

Unfortunately, Android is Kotlin-first; we focus on creating and maintaining samples in Kotlin. We evaluate whether a sample needs a Java version on a case-by-case basis, and if there's enough developer interest we will port this sample to Java.


Validate resources data after upload.

We can use goodtables to implement validation. As it is a long process, the validation job should launch asynchronously.
Original user stories:
As a Publisher [owner] i want my data to be validated when I publish it so that I know immediately if I have accidentally “broken” my data or have bugs and can take action to correct
As a Consumer I want to know that the data I am downloading is “good” and can be relied on so that I don’t have to check it myself or run into annoying bugs later on

WONTFIX. We will probably do this some time but not any time soon so closing.


mcMMO messages to actionbar

Is it possible to hook into McMMO messages and have its messages be displayed via the action bar (as proposed here: https://github.com/mcMMO-Dev/mcMMO/issues/2659)?

I think I am going to create a pull request for the mcMMO repo.
Sent from mobile.

Sadly actionbar messages aren't included in the bukkit or spigot API. Since mcMMO doesn't want to use NMS, it would require an extra plugin for it. Is it okay if I use ProtocolLib for it?

Sure, I already am trying plugins like actionannouncer which can use the placeholderAPI or something

Sorry for the delay. I was busy in the last days.

Ah, didn't know it was there or I just didn't pay attention, one of the two. Thanks, seems to be working well so far!


Duplicates HAPROXY_DEPLOYMENT_GROUP affects other services deployment

When some services has dublicate HAPROXY_DEPLOYMENT_GROUP label, it may affects other services deployment.
When more than one HAPROXY_DEPLOYMENT_GROUPS is occured, marathon-lb script fails down.

It fixed in latest version


doc : Add contribution guidelines

Issue No. #21
Summary:
I have added contributing guidelines in CONTRIBUTING.md
some keys section added in this commit are

how to contribute (fork, pull request)
basic info on communication, issues, attribution

Changes:

CONTRIBUTING.md file

do let me know if we can make it more better, thank you

Hey @Neha thanks for the review
i did the required changes in new commit

Awesome!! thank you for contribution


NIFI-1973 Allow ExecuteSQL to use flow file content as SQL query

+1 This looks good, will merge to master and 0.x


mc_pos_control: smooth positon control from stick input

This Pr is the same as here, but squash merged and rebased.

@PX4TestFlights Please test.

few flights on a pixracer (V4)
using default values:
https://logs.px4.io/plot_app?log=d20c3fc6-2eaa-448e-982f-4973e7d34d71
settings mpc_dec_hor_slow to 1:
https://logs.px4.io/plot_app?log=7c45550d-d1ad-4072-88a5-1d626660fec7
keeping mpc_dec_hor_slow at 1 and setting mpc_jerk_max to 15:
https://logs.px4.io/plot_app?log=5dac9cff-523a-40d1-ae94-b52a6989a269
good flights; all results as expected; even the abrupt changes in speed seemed stable

i am working on a documentation PR that covers manual and auto parameter tuning


Missing _keras_logits from model.predict(x) leads to difference in loss evaluation

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.4
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.4.1
Python version: 3.9.2
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): 7.5.0
CUDA/cuDNN version: 11.2/7.6.5
GPU model and memory: GeForce RTX 2080ti, 11019MiB

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
model.predict(x) does not have attribute _keras_logits
Describe the expected behavior
model.predict(x) and model(x) produce identical outputs.
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import numpy as np
import tensorflow as tf
np.random.seed(999)

loss_fn = tf.keras.losses.BinaryCrossentropy(from_logits=False)
y_true = [[1, 0, 0]]
inputs = tf.keras.layers.Input(shape=(3,))
outputs = tf.keras.layers.Dense(3,
            activation='softmax',
            kernel_initializer=tf.keras.initializers.glorot_normal(seed=42))(inputs)
model = tf.keras.models.Model(inputs=inputs, outputs=outputs)

x = np.random.random((1, 3))
y_pred1 = model.predict(x)
y_pred2 = model(x)

# losses are different. One uses logits, the other doesn't.
print('model.predict(x) loss = ', loss_fn(y_true, y_pred1))
print('model(x) loss = ', loss_fn(y_true, y_pred2))

assert hasattr(y_pred1, '_keras_logits') == hasattr(y_pred2, '_keras_logits')

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Hi! @Saduf2019 , Could you please look into this issue , providing gist replicated in TF 2.3,2.4,2.5 for your reference. Issue is not occurring in TF 2.3 but afterwards .

Thanks for looking into this. Related, it looks like the current way binary_crossentropy is written will always use logits so long as there is _keras_logits attribute cached during inference and ignore from_logits= provided by the user. Is this intended?
I was referring to this code block inside def binary_crossentropy(target, output, from_logits=False):
if hasattr(output, '_keras_logits'):
    output = output._keras_logits  # pylint: disable=protected-access
    if from_logits:
      warnings.warn(
          '"`binary_crossentropy` received `from_logits=True`, but the `output`'
          ' argument was produced by a sigmoid or softmax activation and thus '
          'does not represent logits. Was this intended?"')
    from_logits = True

It has been done purposely I guess...... Cause you only convert it to only logits when you are training..... You don't need to logits when you infering

It has been done purposely I guess...... Cause you only convert it to only logits when you are training..... You don't need to logits when you infering

Sorry I didn't mean inference but forward pass to compute the loss. Doesn't it look to you that logits will be used for training even when user set from_logits=False?

If you are using it for training then ....then use model(x).....Cause if you use model.predict function inside a function which is wrapped around @tf.function.... Then it throws an error. model.predict is only used while inferring while model(x) is used when you are training


New package: RLIBM_32_jll v0.0.1+0

Autogenerated JLL package registration

Registering JLL package RLIBM_32_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/RLIBM_32_jll.jl
Version: v0.0.1+0
Commit: 42c755953f3678c894ed682e9ff4ddd742a7b079
Revision on Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/commit/1c2b60522fcaf27de45bc463e359498191b7b1a0
Created by: @giordano

apuse


Code quality fix - "public static" fields should be constant.

This pull request is focused on resolving occurrences of Sonar rule
squid:S1444 - "public static" fields should be constant
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1444
Please let me know if you have any questions.
Faisal Hameed

declined as can be seen, this is not an issue.


Offer camelCase property name serialization

We should offer an option on individual types or on the whole serialization job to default to converting PascalCase property names to camelCase.

@eiriktsarpalis In coding this up, I realize that IPropertyShape.Name doesn't allow me to distinguish between explicitly set properties via the PropertyShapeAttribute.Name vs. names that are inferred from the C# declared property name.
I'd like the policy to apply to all properties' default names, but not override explicitly set names.
Do you agree with this policy? If so, how would you suggest I implement it? If not, why not?

I'm just going with the AttributeProvider you expose to retrieve the attribute to see if Name has been explicitly set. Not a huge fan of bringing Reflection into this for every single property, but it gets me unblocked anyway.

I'm just going with the AttributeProvider you expose to retrieve the attribute to see if Name has been explicitly set. Not a huge fan of bringing Reflection into this for every single property, but it gets me unblocked anyway.

The AttributeProvider is always MemberInfo for the case of the built-in providers, so perhaps it's as simple as checking propertyShape.Name == (propertyShape.AttributeProvider as MemberInfo)?.Name.
I'm thinking that the concept of applying a naming policy is something that transfers to shapes in general, so perhaps it makes sense to lift that to being a feature in the core library.

I was thinking the same thing.

Could you create an issue please?


Error using Skia.Path.MakeFromSVGString with workerIdleMemoryLimit set in Jest

Description
I'm encountering an issue when running Jest tests that use the Skia graphics library in a React Native project. When I have Jest's workerIdleMemoryLimit property set to any value, tests that rely on Skia's Path.MakeFromSVGString function fail with a TypeError. The error message is: TypeError: Cannot read properties of undefined (reading 'Path'). The relevant code is as follows:
const sketchPathToSkPath = (path) => {
  const renderedPath = Skia.Path.MakeFromSVGString(path);
  if (!renderedPath) {
    throw new Error("Error rendering sketch");
  }
  // ...
};

The error points to the MakeFromSVGString call itself.
When I run the tests without the workerIdleMemoryLimit configured, the tests pass and Skia functions as expected.
It doesn't matter what value is set for workerIdleMemoryLimit, the tests still fail. The minimal reproducible example I provided uses "512mb" but the test still fails even if the value is "1" which should allow all memory to be used.
Expected Behavior:
Skia should function as expected using MakeFromSVGString function, regardless of the setting of Jest's flags like workerIdleMemoryLimit.
Workaround: Not using workerIdleMemoryLimit allows tests to pass but this isn't a long-term solution as it increases memory usage of Jest.
Environment:

React Native version: 0.72.3
Skia version: 0.1.196
Jest version: ^29.2.1
Operating System: macOS 13.0.1 (22A400)
Memory: 64gb
CPU: M1 Max

Version
0.1.196
Steps to reproduce
Run yarn test in the minimal code example.
Snack, code example, screenshot, or link to a repository
https://github.com/gvanderclay/skia-jest-memory-leak

I am under the impression that enabling this option, enables the use of node workers in jest which don't have a proper setup. Our mock relies on a global Skia API to be available and worker thread have their own context.
I am not sure what is the best practice here. This seems to be related to https://github.com/jestjs/jest/issues/8708

@gvanderclay I wanted to checkin and see if you have new thoughts on this? Maybe we need to move the mocking to the globalSetup (instead of the regular setup) or create a custom jest environment?

Closing has this is not an option we support. After looking at the documentation I was trying to find a way to customize the jest setup for this use-case but didn't find any. If anyone can suggest a way we could change our jest setup to support this use-case, we will implement them promptly.
Let's keep the discussion open on this.

@SimenB I could use your wisdom here :) It seems documented that variables set in globalSetup won't be available when running tests in parallel, I want to use global setup to load asynchronously the WASM module for the mock.
When doing the mock, it doesn't look like I can do anything asynchronous there. What would be the best practice?

👋
globalSetup won't be available within tests, no. A common workaround for things such as database connections is to write the URL of the DB to a file or the global env, then read it in tests and create a new connection instead of passing some instance.
A workaround you can use is create a custom test environment - it has async setup and teardown as well. If you use some sort of mutex, you then have access to the global environment outside of the specific tests.

I haven't looked at what code the global setup in this case does, but hopefully this helps 🙂
Happy to answer follow-up questions 👍

That's what I thought too. Thank you for taking to the time to answer there.

@wcandillon After updating to the latest version and following the changes from #1943, it seems like<EMAIL_ADDRESS>is missing from my node_modules. It looks like the new .mjs files may not be listed in the package.json "files" property. Could this be the cause?

To get around the issue mentioned in my previous comment, I attempted to use yarn patch to include the missing files in the node_module for react-native-skia and I encountered this issue:
    Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/gvanderclay/workspace/skia-jest-memory/node_modules/@shopify/react-native-skia/lib/commonjs/web/LoadSkiaWeb' imported from<EMAIL_ADDRESS>    Did you mean to import @shopify/react-native-skia/lib/commonjs/web/LoadSkiaWeb.js?

I then added .js to the end of the LoadSkiaWeb import and got the same issue as I reported in my original post. Not sure if this is the best approach, but it allowed me to investigate further.
It seems LoadSkiaWeb wasn't returning anything, which likely caused global.CanvasKit to be undefined.
I modified my jestEnv.mjs patch file to ensure global.CanvasKit is set in the TestEnvironment after LoadSkiaWeb:
/* eslint-disable import/no-default-export */
// eslint-disable-next-line import/no-extraneous-dependencies
import { TestEnvironment } from "jest-environment-node";
// Added .js to the end. Not sure if this is the best approach but it works
import { LoadSkiaWeb } from<EMAIL_ADDRESS>
// Not setting anything since this sets global.CanvasKit
await LoadSkiaWeb();

export default class SkiaEnvironment extends TestEnvironment {
  // ... rest of the setup
  async setup() {
    await super.setup();
    // Setting CanvasKit based on the value set by LoadSkiaWeb.
    // Not sure if this is the best approach but it works
    this.global.CanvasKit = global.CanvasKit;
  }
  // ... rest of the code
}

This change got my tests up and running! I understand this might not be the best approach for fixing this but it worked for me.
I've updated my reproduction repo to include an example of my tests not working with the original jestEnv.mjs file, and one where my tests are working with the modified jestEnv.mjs file in the workspaces with-issue and without-issue respectively. You can validate the functionality by running yarn test in either workspace.
Let me know if you need any more information!
P.S. Thanks for maintaining this wonderful library! It's been a breeze implementing features that have required a canvas in our react native application.

@gvanderclay thank you for baring with me, the jest suggestion to use @shopify/react-native-skia/lib/commonjs/web/LoadSkiaWeb.js instead appear correct, can you confirm?

This should be good now, thank you for your patience on this, here's a test package: https://firebasestorage.googleapis.com/v0/b/start-react-native.appspot.com/o/shopify-react-native-skia-0.1.220.tgz?alt=media&token=829c6cb2-4b47-4b4b-9b80-38f3ce6c9a1e
Here's the PR: #1990
Note the the instructions have slightly change (the module must be in the ignore transform pattern)

I did some testing and it seems to work great with both esm and commonjs :)


⚠ Mobitopup has degraded performance

In 79dd0db, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6522 ms

Resolved: Mobitopup performance has improved in ab68929 after 415 days, 1 hours, 50 minutes.


Added 4.8 and VS 2019 support

This was originally forked off of looselef/TargetFrameworkMigrator
Note that I have no idea what the magic numbers in frameworks.xml mean so I made up the 4.7.2 and 4.8 ones.
I also created a release https://github.com/Ian1971/TargetFrameworkMigrator/releases/tag/1.6.6 with the binary

Installed perfectly in VS2019. Thanks Ian!

Hi!
The numbers used in framework.xml for 4.7.2 and 4.8 are not correct. They should be
262152 for 4.8 and 262663 4.7.2

The numbers used in framework.xml for 4.7.2 and 4.8 are not correct. They should be
262152 for 4.8 and 262663 4.7.2
Out of interest where do these numbers come from, I couldn't work it out, hence them being wrong. I am not even sure what the consequence of them being wrong is, as it seems to work.

For future reference, this is shows how you can generate them. https://github.com/VHQLabs/TargetFrameworkMigrator/issues/56  I am not sure still what the significance is.

The numbers used in framework.xml for 4.7.2 and 4.8 are not correct. They should be
262152 for 4.8 and 262663 4.7.2

Out of interest where do these numbers come from, I couldn't work it out, hence them being wrong. I am not even sure what the consequence of them being wrong is, as it seems to work.

This article is the only thing i've found about these magic numbers: https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.enumframeworkversion
But I think @mastermattie is right here https://github.com/VHQLabs/TargetFrameworkMigrator/issues/56#issue-400190068:

In order to add .NET 4.8, the Id 262152 should be added.
It looks like the ID can be generated by taking the version number, swap the last two parts, and convert from hex to dec, for example:
Version: 2.0

Hex 02 00 00
Dec 131072

Version: 3.5

Hex 03 00 05
Dec 196613

Version: 4.0

Hex 04 00 00
Dec 262144

Version: 4.5

Hex 04 00 05
Dec 262149

Version: 4.5.1

Hex 04 01 05
Dec 262405

Version: 4.5.2

Hex 04 02 05
Dec 262661

Version: 4.6

Hex 04 00 06
Dec 262150

Version: 4.6.1

Hex 04 01 06
Dec 262406

Version: 4.6.2

Hex 04 02 06
Dec 262662

Version 4.7

Hex 04 00 07
Dec 262151

Version 4.7.1

Hex 04 01 07
Dec 262407

Version 4.7.2

Hex 04 02 07
Dec 262663

Version 4.8

Hex 04 00 08
Dec 262152

You should update the readme.md file to mention 4.8 support. Seems like the original maintainer who has access to publish this to the marketplace is no longer around?

@vansickle could you please merge and release this? Thanks!

Hi, I'm working on a Azure Devops pipleline. When that one is running, I will merge this one.

@Ian1971  how do you got all the builds running? Which Visual Studio version did you use? Are the tests at your side green?
PS: Have invited you to this repo so we could chat easier :)

@Ian1971 how do you got all the builds running? Which Visual Studio version did you use? Are the tests at your side green?
It's a while and a whole new laptop since I tried to build it. So I think then I had vs 2017, and if I remember correctly the tests passed.
Now I have 2019.


General/numerology settings, webhook fixes, and axum framework

Overview
This PR does three things:

Adds general and numerology settings to the settings page
Fixes some minor issues with webhooks
Adds the axum framework to support file multipart uploads (for boost sounds)

General Settings

Show received sats vs total sats (resolves #44, #72)
Show calculated split percentage (resolves #44, #72)
Hide low boost amounts (resolves #22)
Configurable pew sound (resolves #21)

Here's an example of the sats received and split percentage settings when enabled:

Numerology Settings

Configurable numerology emojis (resolves #69)
Configurable numerology sounds (resolves #68)
Swans (resolves #81)

[ ] Add conditional numerology logic to simplify the interface and allow for 💩 boosts and 🏀🔥 boosts:

Less than X amount (<9 sats) 💩
Greater than X amount (>=100,000 sats) 🏀🔥
Contains X (10, 11, 8008) 🎳, 🎲, 🎱🎱
Contains pattern/regex (33+, 55+, 666+, 777+, 177+6) ✨, 🦢, 😈, 😇, 🇺🇸
Entire value is pattern/regex (satchel of richards 11+, row of ducks 22+) 🍆, 🦆

This looks amazing! Can't wait to try it out!


OneMobileSDK Beta Integration Sample

I don't see how self can capture this future.

On May 30, 2017, at 4:43 PM, Andrey Moskvin<EMAIL_ADDRESS>wrote:
@AndriiMoskvin commented on this pull request.
In Examples/Beta Integration/Beta Integration/ViewController.swift https://github.com/vidible/OneMobileSDK-playground-ios/pull/9#discussion_r119101884:

@@ -0,0 +1,65 @@
+//  Copyright © 2017 One by Aol : Publishers. All rights reserved.

+import UIKit
+import OneMobileSDK
+import PlayerControls
+
+class ViewController: UIViewController {

@IBAction func playVideoTouched(_ sender: Any) {

   oneSDK

       .then { $0.getPlayer(videoID: "577cc23d50954952cc56bc47") }

       .dispatch(on: .main)

       .onSuccess { [weak self] player in

Prevent self capturing?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/vidible/OneMobileSDK-playground-ios/pull/9#discussion_r119101884, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjunwSsVRJGlwb9zUd0jKOdgpdrunU6ks5r_B0OgaJpZM4NqS06.

Gave it a clear look - it is not needed - you are right.


Bleeding kanji styling - Pending confirmation

Can confirm this is fixed:

Note the button bar looks better. The kana height is fixed, and the audio button is close (bugging me tracking down the last few pixels, but we've got bigger fish to fry).

Awesome, the button hights were bugging me as well. So much so, that there is a seperate issue #9 dedicated to this exact thing. I will close be closing that too.


Whitespace before the "module" line breaks the interactive mode

The following file can't be processed in interactive mode:
#light "off"

module Mini

F* crashes, complaining about a "fragment without an enclosing module".

CCing @nikswamy , since this seems related to your recent changes?


Support AvgPrecision Aggregate function

This is an enhancement and complementary to the current SumPrecision aggregate function that is supported.
Let know if other similar precision based functions also should be done along with it now that we have SumPrecision in good shape.
Slack Context

@ilamhs Mind if I take a swing at this? I already have the changes ready for a PR. No worries if you're already working on it.

@ashishjayamohan Please do raise a PR 👍
FYI: @zeronerdzerogeekzerocool


Pyblish Pype: Preserve typed comment on reset

Is your feature request related to a problem? Please describe.
What happens often is the user typing a comment for the publish in the comment box and starts to validate/publish. If an error occurred he needs to fix, reset and try again.
However, currently resetting Pyblish Pype will remove the current comment.
Describe the solution you'd like
Preserve the user typed comment on reset, similar to how Pyblish QML does it.

Implemented with #2793


Tss1.5 offset fix - instead of reverting to bad angle

Lateral control is greatly impacted by angle data and it'd be a shame if we gutted NO_DSU_CAR because of startup offsetting.
This PR offsets NO_DSU_CAR on startup to get around the non-absolute offsetting issue, just as I've used successfully in my custom steering sensor project (it's a non-absolute sensor):
https://github.com/zorrobyte/betterToyotaAngleSensorForOP
Community feedback:
https://discordapp.com/channels/469524606043160576/574796986822295569/603199697200480256
https://discordapp.com/channels/469524606043160576/574796986822295569/603205157957664808 -- not this PR, but this branch: https://github.com/commaai/openpilot/compare/devel...zorrobyte:offset_goodsteeringangle
@bugsy said that he'll be testing this PR on his Camry and have feedback to share in this PR by Saturday.

Community #1 reporting working:
https://discordapp.com/channels/469524606043160576/538741329799413760/603449068034719764

I have tested this fix under multiple branches and it works well.  Tested it using my 2018 Toyota camry.

Didn't mean to close, accidentally deleted the branch!

@zorrobyte why closed? We might end up either merging this or doing something similar.

Ah, nvmd

moar feedback

@zorrobyte ended up opening https://github.com/commaai/openpilot/pull/767. Which ispretty much this PR with bug fix and minor clean up.
Thanks for this PR, the underlying idea should work just fine.


fix(Button): proper navigation when using react-router Link

This PR addresses this issue:
https://github.com/palmetto/palmetto-components/issues/400

@juanfabrega TextLink also has the same issue (i linked the issue). Do you want to add a fix for that in this PR too?

@juanfabrega TextLink also has the same issue (i linked the issue). Do you want to add a fix for that in this PR too?

@nathanyoung I will put a separate PR up for that simply because I want to get this merged.


Blank plugin not working

I'm trying to get a minimal setup for displaying a component over a overlay, but I can't make the Blank plugin to work.
Is there any example of its usage?

Hi
Blank plugin is still not official, it's a part of the package by mistake but I didn't create a demo for it yet...
I'll work on something
Meanwhile look at the in-app plugin within the demo application.
Sent from my iPhone

On May 16, 2016, at 1:11 AM, Júlio César<EMAIL_ADDRESS>wrote:
I'm trying to get a minimal setup for displaying a component over a overlay, but I can't make the Blank plugin to work.
Is there any example of its usage?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

I believe this is not needed anymore, the library evolved a lot since I reported this.
You can close it if you want, thanks!


Update agent config options

As pointed out in https://github.com/buildkite/docs/issues/501, we're missing a bunch of config options in our Agent Configuration options section.
This PR adds:
--endpoint
--experiment
--git-clone-mirror-flags
--git-fetch-flags
--git-mirrors-lock-timeout
--git-mirrors-path
--log-format
--metrics-datadog
--metrics-datadog-host
--no-git-submodules
--no-http2
--no-plugin-validation
--spawn
--tags-from-gcp-labels
--wait-for-gcp-labels-timeout
The descriptions are from the agent start code. I also moved disconnect-after-job-timeout to deprecated, as it's listed in the deprecated bit of that agent start file.
The only thing missing is an example or default for git-mirrors-path.
Closes #501.

Thanks!

Documents the config options for https://github.com/buildkite/agent/pull/936.


Locator's Distillation and/or Uniqueness Purification can freeze servers with O(n^2) hexes

As discussed on Discord.
I made a hex that works roughly like this (implementing BFS):
while there are blocks in the queue (a list):
  pop the first block from the queue
  for each offset in a list of 18 vectors:
    get the block at that offset
    use locator's to see if the block has already been visited (!!)
    insert the block into the visited list, using uniqueness prfn (!!)
    optionally insert the block into the queue

The implementation of Locator's Distillation's and/or Uniqueness Purification makes this have O(n^2) time complexity. Here's what happens when you run it on too many blocks:
https://user-images.githubusercontent.com/37044997/216501040-22368fde-fbda-4780-9bac-fa8cfb55e058.mp4
My suggestion was to have lists maintain an internal hashmap (iota -> first index), and possibly also a set, and use those to implement Locator's and the set patterns.

A less user-friendly but simpler solution could be to make list scanning operations add to the op limit?
I was thinking it would be fun to make a hash table, but there's not much point if lists efficiently act as one too...


remove jQuery from peerDependencies

Thanks for the awesome component!
Just one question:
Can we remove jQuery from this component?
I found that you use it only at src/components/DayPicker.jsx. Am I right? Can we rewrite it with pure javascript?

Yeah definitely! We have a PR open here - https://github.com/airbnb/react-dates/pull/16 where we're already working on it. :) We need to test it in IE9 and IE10 first before we merge it in, which we are unfortunately not able to do with storybook, so it's going to take us a bit longer. I'm going to use the airbnb site for testing and hopefully we can get that merged in this weekend!

Oh, my bad. Didn't see that PR.
Maybe let's leave this issue open for now, so anyone else like me can find this information?

👍 Definitely! Will close it when we get testing completed and can merge that stuff in!

I saw this was merged, can someone push a new release to npm? thanks :)

Will do later today!
On Sat, Sep 3, 2016, 8:09 AM Zach Silveira<EMAIL_ADDRESS>wrote:

I saw this was merged, can someone push a new release to npm? thanks :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/react-dates/issues/39#issuecomment-244551697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUdtZ2L3RZSSAzKGVL2PRBwhOEn79K_ks5qmY2ogaJpZM4JuHMD
.

haha, I'm excited about this project.  First thing I ran into was the jquery dependency and you are already fixing it today :)

So glad to hear it, @sontek! Feel free to suggest any other improvements as issues and PRs. :) We've just release v2.1.1 without jquery so yaaaay. :) @zackify


Feature/task 121 link

Task 73 Component question  📝
missing on this PR is the progress bar.
Taiga Link 🔗
https://taiga.dts-stn.com/project/pond-dts-experimental-benefit-finder/us/73?milestone=34
Checklist ✅

[x] created story for all visual components
[x] created or modified necessary unit tests
[ ] created or modified e2e tests
[ ] modified README or any applicable documentation on the changes you made

closing this PR as commented on above


[Bug]: Why is it necessary to log in again every time the page is refreshed?

What happened?
Why is it necessary to login again every time the page is refreshed?
Steps to Reproduce
1、refresh the web page
2、need to login again
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Not a bug, this isn't the case if you use localhost or https. It could be a cookie issue if you are using http and not localhost: https://github.com/danny-avila/LibreChat/discussions/572#discussioncomment-7352331
Please review it as it may solve your issue.
The way around this in production mode is to use NGINX or something like Caddy for HTTPS if you are not outright accessing via localhost

thx so much

Unfortunately~~ @danny-avila
Using Chrome's incognito mode, even when setting NODE_ENV=development, it's still unable to save cookie information.


Nuxt transpiling causes impossible development workflow

TuSimple/naive-ui version (版本)
2.30.8
Vue version (Vue 版本)
3.2.37
Browser and its version (浏览器及其版本)
103.0.5060.53
System and its version (系统及其版本)
12.3
Node version (Node 版本)
v16.15.1
Reappearance link (重现链接)
https://github.com/07akioni/naive-ui-nuxt-demo (the official demo repo)
Reappearance steps (重现步骤)
Run yarn dev and when the application loads you can see the amount of work Nuxt has to do to transpile all these modules. (see network tab, 2-3k requests) This happens on startup and on HMR.
Expected results (期望的结果)
Maybe that we do not need to transpile all the modules? But my knowledge is limited about this topic.
https://v3.nuxtjs.org/guide/going-further/esm/#library-author-guide
Actual results (实际的结果)
Nuxt is transpiling all these single js files. Causing an impossible dev workflow. My chrome tab freezes for like 5-10 seconds causing all my fans to spin at 100% 😅
Remarks (补充说明)
I followed the docs https://www.naiveui.com/en-US/os-theme/docs/ssr

This is a big issue! Could someone look into this?

I'll look into it.

@gijsroge See latest demo repo, I've updated nuxt config.