Chains not pushing signed image to Harbor

Expected Behavior

Kaniko builds image in pipeline
Image is pushed to Harbor
Chains starts to run and tries to pull the image to sign it
Signs image and uploads attestations

Actual Behavior

Kaniko builds image in pipeline
Image is pushed to Harbor
Chains starts to run and tries to pull the image to sign it
get UNAUTHORISED error from Harbor

Steps to Reproduce the Problem

Install Harbor v2.5.0
Install Tekton Chains
Run a basic Kaniko task that builds and pushes image to Harbor
Chains runs but fails to pull image

Additional Info

Followed documentation https://tekton.dev/docs/chains/signed-provenance-tutorial/

Actual Error recieved in Chains log:
type: 'Warning' reason: 'InternalError' 1 error occurred:\n\t* POST https://[HARBOR_URL]/v2/create/test-project/blobs/uploads/: UNAUTHORIZED: unauthorized to access repository: create/test-project, action: push: unauthorized to access repository: create/test-project, action: push\n\n"

Is worth mentioning, I've tried all sorts, the dockerconfigjson file that is being used by the build-bot SA that the pipeline run uses has the main Harbor admin credential, so I don't know why I'm getting unauthorized. I've also tried to make the repository public, but that doesn't seemed to work either - that is when I get the above error. If it's not public, I get an error describing that it cannot pull the image due to permissions.

Kubernetes version:

kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.4", GitCommit:"3cce4a82b44f032d0cd1a1790e6d2f5a55d20aae", GitTreeState:"clean", BuildDate:"2021-08-11T18:16:05Z", GoVersion:"go1.16.7", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.9", GitCommit:"633e1432a197dc4a6a1807311429a9808b99ff5b", GitTreeState:"clean", BuildDate:"2022-03-30T18:27:54Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

(paste your output here)

Tekton Pipeline version:

tkn version
Client version: 0.23.1
Chains version: v0.8.0
Pipeline version: v0.34.1
Triggers version: v0.19.1

A bit of an update to make things easier - instead of me having to paste all of the pipeline yamls. I have applied the following kaniko task inside the tekton-ci namespace. https://github.com/tektoncd/chains/blob/main/examples/kaniko/kaniko.yaml
And also have a secret in that namespace with the dockerconfigjson secret that contains the Harbor admin creds.
I reference it in the running of the above task like so:
tkn task start --param IMAGE=[HARBOR_URL]/create/kaniko-chains --use-param-defaults --workspace name=source,emptyDir="" --workspace name=dockerconfig,secret=flux-harbor-pull-secret kaniko-chains -n tekton-ci
and the logs of the kaniko task container are the following:
 tkn taskrun logs kaniko-chains-run-z5ndh -f -n tekton-ci
[add-dockerfile] FROM alpine@sha256:69e70a79f2d41ab5d637de98c1e0b055206ba40a8145e7bddb55ccc04e13cf8f

[build-and-push] E0420 22:07:11.441029      12 aws_credentials.go:77] while getting AWS credentials NoCredentialProviders: no valid providers in chain. Deprecated.
[build-and-push] 	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
[build-and-push] error checking push permissions -- make sure you entered the correct tag name, and that you are authenticated correctly, and try again: checking push permission for "harbor.tooling.create.cap-osce.uk/create/kaniko-chains": POST https://[HARBOR_URL]/v2/create/kaniko-chains/blobs/uploads/: UNAUTHORIZED: unauthorized to access repository: create/kaniko-chains, action: push: unauthorized to access repository: create/kaniko-chains, action: push

[write-url] 2022/04/20 22:07:12 Skipping step because a previous step failed

Now the weird thing is, when I run my pipelines, I get an image being built successfully and pushed to Harbor, but for some reason, the Tekton Chain stuff really isn't working that great.

Ok, so a bit of more debugging, it seems I've made a bit of a mistake somewhere around the service account permissions, namely the difference between the imagePullSecret vs secret of the service account. Will post a better description in the coming comments..

So, after a bit more investiation, it seems that the service account that is attached to the pippelinerun, that ends up performing the kaniko task, in order for Tekton Chains to work, it has to have both imagePullSecrets and secret referencing the .dockerconfigjson secret for Harbor.
Before, it only had the following:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: build-bot
  namespace: tekton-ci
secrets:
  - name: ssh-secret
  - name: flux-harbor-pull-secret

This worked when pushing images to Harbor, but not when it needed to retrieve the image in order to sign it with Cosign. I had to add the imagePullSecret like the below for this to work.
apiVersion: v1
kind: ServiceAccount
metadata:
  name: build-bot
  namespace: tekton-ci
secrets:
  - name: ssh-secret
  - name: flux-harbor-pull-secret
imagePullSecrets:
- name: flux-harbor-pull-secret

It's worth adding this to the documentation here as it doesn't necessarily mention the need for both a secret and a imagePullSecret being attached to the service account. As there's an inherent assumption that it is to be attached to the service account that is attached to the tekton chains controller.
Happy to keep this open for other comments if needed, otherwise am happy to close it.

Hey @ChrisJBurns thanks for debugging this and reporting your findings! I definitely think it would be useful to add this to the documentation. If you or anyone else could open a PR I'm happy to review it.
Until we fix it, maybe we rename this issue "Add documentation for setting up authentication to Harbor"?

Hi @priyawadhwa sure thing, I can open a PR for it. However, do we think this is a registry wide issue? Or just Harbor? I'm curious what would happen if someone was to use GCR or something else with a service account that only has the secret in it. I'm curious if both secret and imagePullSecret is needed for all registries? Possibly something for someone to try?
Also, I just want to double check that is it right that Kaniko pushes an image to Harbor first (that is unsigned), Chains then takes over and retrieves the image, signs it, and re-pushes it?  This means that a push is needed first, then a retrieve & sign, followed by a last push. Is this the standard behaviour across all implementations and registries? Or is this something that is only applicable to Harbor?

I'm having the same issue, have tried the same steps, the one interesting detail I found by enabling harbor debug logging is that the incoming push request to harbor appears to be anonymous- I'm clueless about how tekton locates and consumes the dockerconfig stuff while the task is running and am unsure how I might debug it.

Hi. We also tried following the documentation on OpenShift 4.9 and we have the same problem. However, in our case we have tried using quay.io and IBM Cloud Container Registry, so it doesn't seem to be an issue affecting only Harbor. In the usage logs of quay.io I can also see that the image is successfully pushed by Kaniko using the robot account defined in the secret linked to the service account, but when Tekton Chains tries to upload the attestations to the registry, the performing user is labeled as "anonymous" and gets the UNAUTHORIZED error. Here a log extract from the Chains pod:

{"level":"info","ts":"2022-05-20T07:06:36.494Z","logger":"watcher","caller":"oci/oci.go:152","msg":"Starting to upload attestations to OCI ...","commit":"e94c32e","knative.dev/controller":"github.com.tektoncd.chains.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"3f1d4235-a7ea-4163-9d78-524e377007f5","knative.dev/key":"jose-cicd/kaniko-chains-run-4l5v4"}
{"level":"info","ts":"2022-05-20T07:06:36.494Z","logger":"watcher","caller":"oci/oci.go:155","msg":"Starting attestation upload to OCI for quay.io/xxx/kaniko-chains@sha256:757aa924eba28cb7b9143d48d1cba2659a846d367a252377953402150b1a24bf...","commit":"e94c32e","knative.dev/controller":"github.com.tektoncd.chains.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"3f1d4235-a7ea-4163-9d78-524e377007f5","knative.dev/key":"jose-cicd/kaniko-chains-run-4l5v4"}
{"level":"error","ts":"2022-05-20T07:06:37.905Z","logger":"watcher","caller":"chains/signing.go:210","msg":"POST https://quay.io/v2/xxx/kaniko-chains/blobs/uploads/: UNAUTHORIZED: access to the requested resource is not authorized; map[]","commit":"e94c32e","knative.dev/controller":"github.com.tektoncd.chains.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"3f1d4235-a7ea-4163-9d78-524e377007f5","knative.dev/key":"jose-cicd/kaniko-chains-run-4l5v4","stacktrace":"github.com/tektoncd/chains/pkg/chains.(*TaskRunSigner).SignTaskRun\n\t/opt/app-root/src/go/src/github.com/tektoncd/chains/pkg/chains/signing.go:210\ngithub.com/tektoncd/chains/pkg/reconciler/taskrun.(*Reconciler).FinalizeKind\n\t/opt/app-root/src/go/src/github.com/tektoncd/chains/pkg/reconciler/taskrun/taskrun.go:61\ngithub.com/tektoncd/chains/pkg/reconciler/taskrun.(*Reconciler).ReconcileKind\n\t/opt/app-root/src/go/src/github.com/tektoncd/chains/pkg/reconciler/taskrun/taskrun.go:42\ngithub...

I'm actually curious how @ChrisJBurns managed to get it working, because although we added both secret and imagePullSecret to the service account, the signing still fails. However, OpenShift automatically adds an additional secret and imagePullSecret to the Secret Account for the internal OpenShift Container Registry and I'm not sure if that can be avoided and if that could have something to do with this problem.
@priyawadhwa any suggestions?
Our environment info:

OpenShift/Kubernetes:

oc version
Client Version: openshift-clients-4.6.0-202006250705.p0-176-g5797eaeca
Server Version: 4.9.28
Kubernetes Version: v1.22.5+a36406b

tkn version

Client version: 0.16.0
Chains version: v0.8.0
Pipeline version: v0.33.2
Triggers version: v0.19.0

@ChrisJBurns,

Also, I just want to double check that is it right that Kaniko pushes an image to Harbor first (that is unsigned), Chains then takes over and retrieves the image, signs it, and re-pushes it? This means that a push is needed first, then a retrieve & sign, followed by a last push. Is this the standard behaviour across all implementations and registries? Or is this something that is only applicable to Harbor?

The image itself is always "unsigned" on the registry. If you have oci storage enabled, Chains will create an image signature and attestation, and push them along side the image in the registry. (This is implemented by cosign). Client tooling, e.g. also cosign, is responsible for making this correlation at consumption time. For example, if I have an image example.com/foo:latest with digest sha256:12345, Chains will create the image signature and attestation, and push them to the registry as oci artifacts. The repo example.com/foo will have, at least, the following tags:

latest <- image built by Kaniko with the digest sha256:12345
sha256-12345.sig <- image signature
sha256-12345.att <- image attestation

The *.sig and *.att tags point to oci artifacts that may or may not be supported by the registry. More specifically, the registry must support the application/vnd.dsse.envelope.v1+json oci artifact MIME type. Docker Hub, Quay.io, and GHCR are ones that do. I wouldn't expect an unauthorized error from a registry that does not support it, but that's ultimately a registry implementation decision. Verify Harbor supports this.
If you're seeing an unauthorized error from the registry in the chains controller logs, check the following:

Does the chains controller trust the identity certificate of the registry? This is usually only the case when a self-deployed registry is used, which is probably not the case here.
Does the chains controller service account have access to read all the secrets in the cluster? This is done by the default Chains installation methods, but worth checking.
Is the taskrun service account linked with the push/pull registry secret? The way build tasks access this secret is not consistent. Some are smart enough to retrieve from linked secrets, while others require mounting the secret directly. On the last case, if the registry secret is not linked to the taskrun service account, the build task will succeed in pushing the image to the registry, but Chains will fail to push the signature and attestation.

I was under the impression that the linkage was done just under secrets, not imagePullSecrets, but from your report that does not seem to be the case. It would be great to further explore this and document accordingly.


[Select] Add non modal mode in popper position

Description
As suggested here https://github.com/radix-ui/primitives/pull/2004#issuecomment-1556985859, this PR adds non-modal mode only for the popper position since that mode for item-aligned position needs to be thought a little more.
Closes #1927

👋 @benoitgrelard! Any chance this PR could be looked into? It potentially fixes a rather serious performance issue – see https://github.com/radix-ui/primitives/issues/1634#issuecomment-1264347705 and below for details. I use Radix Select in a project via https://ui.shadcn.com/docs/components/select. When a page has heavy markup like a large table, clicking on select makes the app freeze even on a pretty recent MacBookPro with M1. The lag is especially visible in Safari, but it’s also noticeable on Chrome and FF (especially with x4 throttling).

@joaom00 Olá! This is just a ping :slightly_smiling_face:  is this PR/subject still alive?

@frykten Yes definitely. Unfortunately, I think the team didn't have time to review the PR...

Came here from #2241
Thanks for the hint on onFocusOutside={ (event) => event.preventDefault() }. Might be a temporary, yet hacky solution, which is far from ideal.
Looking forward for this issue to be handled by the library itself.

beep boop bump, this is a nice contribution – any chance it could get a review soon @benoitgrelard @andy-hook?
currently resorting to using DropdownMenu for the non-modal support when semantically I should be using Select

Any chance for this to be merged?

I would also prefer it if this fix was checked and worked/merged. Is there anyway we can help to push it over the line?

I am facing the same issue. Any updates on when this will be merged?

@joaom00 Thanks for you work, it's a good one. I've bee applying on my current project, and here is what I wanted to share with you.
I've been using the "new" Select component you created with modal={false}.
The strange thing is that it works perfectly on Safari and Firefox, but it does not work on Chrome (v.125.0.6422.61 - arm64). I'm not able to understand what is not working. Maybe you have some suggestions on the topic.
Thanks a lot for your work 🥇

Hi all! This is just a ping, any updates on a possible merge?

Any..

Will be appreciated if the PR is merged


Allow conversions between native u types and U128

Description
Adds impl From<u8,u16,u32,u64> for U128
Partially addresses #5797
Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation where relevant (API docs, the reference, and the Sway book).

[ ] If my change requires substantial documentation changes, I have requested support from the DevRel team

[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

Blocked by #5826


Work on issue-69

fix connections between collections
delete button dont work. will work on it after milestone 4

fix connections between collections
delete button dont work. will work on it after milestone 4


Parsing error with inline script tags

Before You File a Bug Report Please Confirm You Have Done The Following...

[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.22.0
What version of eslint-plugin-astro are you using?
0.17.1
What did you do?

Configuration
https://gist.github.com/cj/c82422a88af4d3afd7afb828cdf903c2

https://gist.github.com/cj/08f13d06699b71bed821f01d39d50202
What did you expect to happen?
For there to be no validation issue
What actually happened?
A parsing error happened.

Link to Minimal Reproducible Example
https://github.com/cj/eslint-plugin-astro-script-parsing-error
Additional comments
https://docs.astro.build/en/core-concepts/astro-components/#client-side-scripts

It has been reported that prettier parsing fails with prettier/prettier rule.
Specify in files: ["**/*.astro/*.js", "*.astro/*.js"],.

@ota-meshi ah, I needed it in both places. Thank you!


docs: Add warning when accessing the JS API

Since #45, there is some more tweak to access the JS API. This change will add information on README, referring to #45 on how to access the JS API.

Wouldn't it be better to directly include the solution (the improved one by @cprcrack) and just referencing the issue for further information?

The webpack module name may change between build. Is it a good idea to put that as-is?

I guess it should be alright. If people just want to quickly try it out without digging through long issue texts, they can, and if the module name changes, I'm sure someone will notice and update it anyway.

There is a solution to get the Store automatically after the page loads.
var store_id = 0;
var Store = {};
// Returns module by id
function _requireById(id) {
	return webpackJsonp([], null, [id]);
};
// Returns promise that resolves to all installed modules
function getAllModules() {
	return new Promise((resolve) => {
		const id = _.uniqueId("fakeModule_");
		window["webpackJsonp"](
			[],
			{
				[id]: function(module, exports, __webpack_require__) {
					resolve(__webpack_require__.c);
				}
			},
			[id]
		);
	});
}
var modules = getAllModules()._value;
// Automatically locate modules
for (var key in modules) {
	if (modules[key].exports) {
		if (modules[key].exports.default) {
			if (modules[key].exports.default.Wap) {
				store_id = modules[key].id.replace(/"/g, '"');
			}
		}
	}
};

Once the page loads and this code is ran, you can use the following to return the Store:
Store = _requireById(store_id).default;
console.log(Store);

Can confirm that @aalsuwaidi's solution works, which seems to be based on https://stackoverflow.com/a/50572767/423171
However no idea how it works, particularly the `.uniqueId("fakeModule")´ part intrigues me. In any case should be the default solution, definitely better than hard-coding an id.

@cprcrack It's based on this answer which goes into a little bit more detail: https://stackoverflow.com/questions/29223071/how-do-i-require-from-the-console-using-webpack/39410265#39410265
I played around with it a little bit, the part you mentioned seems to be necessary to successfully return the modules from Webpack. When you get the modules you can see at the end an empty module with the "fakeModule" key.

Well that is pretty cool. Thank you. I will adjust my PR accordingly.


file_upload_to_slack returns stream timeout

Hello,
I'm trying to post a message inside a thread to a previously uploaded file to the channel via file_upload_to_slack . Unfortunately, the result of file_upload_to_slack  looks like this:
{:status=>nil, :body=>"stream timeout", :json=>{}}

and it's impossible to get a thread_ts  to use it in post_to_slack.
Could you please suggest how to post a message inside the thread to a previously uploaded file via file_upload_to_slack ?
Thanks in advance.

hello,

Could you please suggest how to post a message inside the thread to a previously uploaded file via file_upload_to_slack ?
It seems, Slack does not allow it. For more details, please see the files.upload API

This is what i will suggest:

First, use the post_to_slack to send a message
Save the slack-thread-timestamp for further slack messages
Later, use the file_upload_to_slack to upload files inside the same slack-thread
or use the post_to_slack to send more message inside the same slack-thread

  lane :slack_thread_example_lane do
    channel_name = "#ios-team"

    # Start the release with slack release thread
    release_thread = post_to_slack(
      message: "Good morning team, CI has started the AppStore release. You can find more information inside this thread 🧵",
      channel: channel_name
    )

    # Important: Save this slack thread timestamp for futher slack messages
    release_thread_ts = release_thread[:json]["ts"]

   # gym # Build the app and create .ipa file

    # Post an update in release thread
    post_to_slack(
      message: "App has been build successfully! 💪",
      channel: channel_name,
      thread_ts: release_thread_ts
    )

   # deliver # Upload build to AppStore

    # Post an update in release thread
    post_to_slack(
      message: "App has been uploaded to the AppStore and submitted for Apple's review! 🚀",
      channel: channel_name,
      thread_ts: release_thread_ts
    )

    # Spaceship logs file upload on Slack
    file_upload_to_slack(
      initial_comment: "Deliver:: Spaceship logs",
      file_path: "/Users/m.rathi/Desktop/demo_image.jpg",
      channels: channel_name,
      thread_ts: release_thread_ts
    )
  end

Hello @crazymanish,
first of all thanks for your quick response and support!
What if I don't need first to post a message but I just looking to upload a file and leave a comment to this file inside a thread?
So what I would like to achieve:

use the file_upload_to_slack for uploading a file to the channel
save the slack-thread-timestamp
use the post_to_slack to send a message inside the slack-thread

Step 2 is impossible at the moment due to file_upload_to_slack returns:
{:status=>nil, :body=>"stream timeout", :json=>{}}

although the file is uploaded successfully to my channel.

Indeed, true!
As i mentioned above, Step2 is not possible because Slack does not return the timestamp when uploading a file.
For more details, please see the files.upload API


Less Not Working. What might be wrong?

Hello,
I have the following:
Bundle.Css()
  .Add("~/assets/core.less")
  .Add("~/assets/base.less")
  .WithMinifier<MsCompressor>()
<EMAIL_ADDRESS>+ ".Face", "~/assets/main.min.css");

Core.less has classic CSS. Base.less has LESS code.
On the output I get all "Core" code and the start of "Base" code before the Less code starts.
The Less code is not rendered. Using Minifier or not.
What might be wrong?
Thank you,
Miguel

I think this problem might be because base.less has the following code line:
@import "Core.less"
How should I deal with imports in less files and Squish It?
I have it because in Base.less I am using mixins defined in Core.less.
Thank You,
Miguel

Hi Miguel,
I was using an older version of squishit which had an older version of dotLess.  It looks like the master branch here has an updated version of dotLess. I would check your dotLess version.  Then I recommend trying a simple scenario with a very basic .less file and a simple .less file with an import.  Mixins via import are working for me here with the latest master branch of squishit.
What I have seen is that if there is an error in a .less file, none of the contents are emitted.
Jon


Send homeAddressStreet parameter to prevent autoformatting

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/16960
Tests

Same as QA

[X] Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Change your address (Settings -> Profile -> Personal details -> Home Address) to anything, make sure it works.
Change your address to something that starts with multiple capital letters - e.g. USA Way. Make sure the capitalization remains consistent.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

N/A

Off hold and ready for review! Should work on prod now

Thanks @thesahindia, let's address that in a follow-up though?

Yeah @thesahindia do you want to put that in Slack and we can make a separate issue? Include a link to this issue so we can make sure we give context to make the fix as easy as possible. thanks!

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Pull request from Layer

@AdityaAgg was this pull request an accident?

Closing this as it seems to be created in error. Pull requests should be focused and fix bugs or add functionality.


[20.09] Switch latest kernel to 5.10

Motivation for this change
The 5.8 and 5.9 kernels have been EOL'd.
5.10 has been on master for a while now (I have been using it daily since 5.10.1)
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@ofborg test kernel-latest kernel-lts latestKernel.login

@ofborg test kernel-latest kernel-lts latestKernel.login

@ofborg test kernel-latest kernel-lts latestKernel.login

@ofborg test kernel-latest kernel-lts latestKernel.login

@ofborg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

@ofborg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

I cannot figure out why ofborg fails building 5.10.5.a for the test on x64... I am posting this from 5.10.5.a on an x64 :)

I cannot figure out why ofborg fails building 5.10.5.a for the test on x64... I am posting this from 5.10.5.a on an x64 :)

chmod: missing operand after 'u-w'
Try 'chmod --help' for more information.

Maybe you didn't backport the fix from 3088dcb148e8110aa6102e8c3a2c7ee5af1348f1 correctly?

chmod: missing operand after 'u-w'
Try 'chmod --help' for more information.

Maybe you didn't backport the fix from 3088dcb148e8110aa6102e8c3a2c7ee5af1348f1 correctly?

IIRC there was a lot of kernel modules which aren't support in 5.10.
However, people should be using an LTS kernel if they want LTS behavior

IIRC there was a lot of kernel modules which aren't support in 5.10.
However, people should be using an LTS kernel if they want LTS behavior

@lheckemann Ah, that might be it

@lheckemann Ah, that might be it

@ofborg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

@ofborg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

@ofborg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

@ofborg test kernel-latest kernel-lts latestKernel.login latestKernel.hardened

Rebased onto staging-20.09

Rebased onto staging-20.09

Backported 2.0.1 bump as well: c0216833f23c756615995e6d3b1af40bfae05904

Backported 2.0.1 bump as well: c0216833f23c756615995e6d3b1af40bfae05904


Silence part

Hi, I implemented audio segmentation with your code and it works great. In the mean time, I also want to generate a list of chunks of silence part which is rejected here. Is there any way I can achieve this?

https://github.com/openvpi/audio-slicer/blob/main/slicer2.py#L76
The list sil_tags represents start frame and end frame indices of all silence parts. You can use the similar method as I get the sound chunks to get the silence chunks.

To obtain silence parts in seconds, I think below code is enough ?

Return sil_tags:  (return chunks -> return chunks, sil_tags)
Calculate in seconds:

audio, sr = soundfile.read(audio_path)
slicer = Slicer(
    sr=sr,
    threshold=-40,
    min_length=5000,
    min_interval=300,
    hop_size=10,
    max_sil_kept=500
)
chunks, sil_tags = slicer.slice(audio)
for sil_tag in sil_tags:
    start = sil_tag[0] * slicer.hop_size / sr
    end = sil_tag[1] * slicer.hop_size / sr
    print(start, end)

or basically
for sil_tag in sil_tags:
    start = sil_tag[0] / 100
    end = sil_tag[1] / 100
    print(start, end)

@EmreOzkose numbers in sil_tags are frame indices, simply dividing by 100 may not generalize for all hop_size. By the way, there are already some forked version of audio slicer that produces both timestamps and chuncks, like this one: https://github.com/openvpi/SOME/blob/main/utils/slicer2.py


extensions be uninstalled when open a new vscode window

Type: Bug
When reopen vscode or open a new window, there are always hints tenn me that some of my extensions dont exists, including python, pylint, balck formatter, etc.
But when I tried to install these extensions and reload again, the same situation occur again. When I check my extensions menu, I am sure that all the extensions exists.
Btw, I have try to reinstall vscode or install a previous version of extension, but none of them works.
Thanks for your attention.
 Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

/gifPlease

Thanks for your reply! It works well now, but could you please keep this issue open for a period of time as I met this situation 2 times within a week. I will record a gif/mp4 and upload it next time.
Additionally, the above situation not only occurred on my personal computer but also when I logged in to my remote server via ssh. That's why I think report this issue.

Thanks, are profiles involved? Possibly with the option to "Apply extension to all profiles"?

Hi! Sorry to bother, but it actually occurred again. Below is an mp4 that I record. I only use one profile in vscode and I keep the sync opening. You can actually see all the extensions exist in my .vscode-server/extensions directory. Last time I fixed this situation by removing the whole .vscode-server directory and login to my remote server again, but I am not sure if it worked.
You can clearly see that python is shown installed successfully in 00:39, but when it reloaded, it seems to be uninstalled again.
https://github.com/microsoft/vscode/assets/107318439/068a779f-6e8c-46b2-b1e4-29d4b02a4d88

FYI, I appear to have found a repro at https://github.com/microsoft/vscode/issues/190044#issuecomment-1672317446 .

This may be a duplicate of https://github.com/microsoft/vscode/issues/189877. Can you please try out the latest VS Code Insiders and let us know whether it's fixed there: https://code.visualstudio.com/insiders

@joyceerhl It's fixed with Insiders (for me).

This may be a duplicate of #189877. Can you please try out the latest VS Code Insiders and let us know whether it's fixed there: https://code.visualstudio.com/insiders

I have gone through these relative issues just now. I am now trying out with the latest VS Code Insiders and it seems to work well now. If there are any problems, I will report them in the first time. Thanks for your all attention!

Hi. Here is some potential trouble in the vscode-insider.

node:internal/deps/undici/undici:11413
    Error.captureStackTrace(err, this);
          ^

TypeError: Failed to parse URL from /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm
    at Object.fetch (node:internal/deps/undici/undici:11413:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: TypeError [ERR_INVALID_URL]: Invalid URL
      at new NodeError (node:internal/errors:399:5)
      at URL.onParseError (node:internal/url:566:9)
      at new URL (node:internal/url:646:5)
      at new Request (node:internal/deps/undici/undici:7002:25)
      at fetch2 (node:internal/deps/undici/undici:10554:25)
      at Object.fetch (node:internal/deps/undici/undici:11411:18)
      at fetch (node:internal/process/pre_execution:241:25)
      at /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3623815
      at Object.<anonymous> (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3624040)
      at 4087 (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3657710) {
    input: '/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm',
    code: 'ERR_INVALID_URL'
  }
}

Node.js v18.15.0
[Info  - 12:10:26 PM] Connection to server got closed. Server will restart.
[Error - 12:10:26 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:26 PM] API Usage Examples LSP client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097
node:internal/deps/undici/undici:11413
    Error.captureStackTrace(err, this);
          ^

TypeError: Failed to parse URL from /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm
    at Object.fetch (node:internal/deps/undici/undici:11413:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: TypeError [ERR_INVALID_URL]: Invalid URL
      at new NodeError (node:internal/errors:399:5)
      at URL.onParseError (node:internal/url:566:9)
      at new URL (node:internal/url:646:5)
      at new Request (node:internal/deps/undici/undici:7002:25)
      at fetch2 (node:internal/deps/undici/undici:10554:25)
      at Object.fetch (node:internal/deps/undici/undici:11411:18)
      at fetch (node:internal/process/pre_execution:241:25)
      at /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3623815
      at Object.<anonymous> (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3624040)
      at 4087 (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3657710) {
    input: '/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm',
    code: 'ERR_INVALID_URL'
  }
}

Node.js v18.15.0
[Info  - 12:10:26 PM] Connection to server got closed. Server will restart.
[Error - 12:10:26 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:26 PM] API Usage Examples LSP client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097
node:internal/deps/undici/undici:11413
    Error.captureStackTrace(err, this);
          ^

TypeError: Failed to parse URL from /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm
    at Object.fetch (node:internal/deps/undici/undici:11413:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: TypeError [ERR_INVALID_URL]: Invalid URL
      at new NodeError (node:internal/errors:399:5)
      at URL.onParseError (node:internal/url:566:9)
      at new URL (node:internal/url:646:5)
      at new Request (node:internal/deps/undici/undici:7002:25)
      at fetch2 (node:internal/deps/undici/undici:10554:25)
      at Object.fetch (node:internal/deps/undici/undici:11411:18)
      at fetch (node:internal/process/pre_execution:241:25)
      at /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3623815
      at Object.<anonymous> (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3624040)
      at 4087 (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3657710) {
    input: '/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm',
    code: 'ERR_INVALID_URL'
  }
}

Node.js v18.15.0
[Info  - 12:10:27 PM] Connection to server got closed. Server will restart.
[Error - 12:10:27 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:27 PM] API Usage Examples LSP client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:27 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097
node:internal/deps/undici/undici:11413
    Error.captureStackTrace(err, this);
          ^

TypeError: Failed to parse URL from /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm
    at Object.fetch (node:internal/deps/undici/undici:11413:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: TypeError [ERR_INVALID_URL]: Invalid URL
      at new NodeError (node:internal/errors:399:5)
      at URL.onParseError (node:internal/url:566:9)
      at new URL (node:internal/url:646:5)
      at new Request (node:internal/deps/undici/undici:7002:25)
      at fetch2 (node:internal/deps/undici/undici:10554:25)
      at Object.fetch (node:internal/deps/undici/undici:11411:18)
      at fetch (node:internal/process/pre_execution:241:25)
      at /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3623815
      at Object.<anonymous> (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3624040)
      at 4087 (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3657710) {
    input: '/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm',
    code: 'ERR_INVALID_URL'
  }
}

Node.js v18.15.0
[Info  - 12:10:27 PM] Connection to server got closed. Server will restart.
[Error - 12:10:27 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:27 PM] API Usage Examples LSP client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:27 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097
node:internal/deps/undici/undici:11413
    Error.captureStackTrace(err, this);
          ^

TypeError: Failed to parse URL from /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm
    at Object.fetch (node:internal/deps/undici/undici:11413:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  [cause]: TypeError [ERR_INVALID_URL]: Invalid URL
      at new NodeError (node:internal/errors:399:5)
      at URL.onParseError (node:internal/url:566:9)
      at new URL (node:internal/url:646:5)
      at new Request (node:internal/deps/undici/undici:7002:25)
      at fetch2 (node:internal/deps/undici/undici:10554:25)
      at Object.fetch (node:internal/deps/undici/undici:11411:18)
      at fetch (node:internal/process/pre_execution:241:25)
      at /data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3623815
      at Object.<anonymous> (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3624040)
      at 4087 (/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/server.js:2:3657710) {
    input: '/data22/DISCOVER_summer2023/chenjt2305/.vscode-server-insiders/extensions/visualstudioexptteam.intellicode-api-usage-examples-0.2.7/dist/server/tree-sitter.wasm',
    code: 'ERR_INVALID_URL'
  }
}

Node.js v18.15.0
[Error - 12:10:27 PM] The API Usage Examples LSP server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
[Error - 12:10:27 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:27 PM] API Usage Examples LSP client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 12:10:27 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097

Thanks @xBeho1der that looks like a bug in the IntelliCode extension, which has been reported here https://github.com/MicrosoftDocs/intellicode/issues/475

same problem

same problem

Try with VS Code Insiders or lower version.

same problem

Try with VS Code Insiders or lower version.

Update to 1.81.1 solved


[BUG] Renaming a container causes the dialog to refresh every time a single letter is changed

Rancher Server Setup

Rancher version: 2.6.10
Installation option (Docker install/Helm Chart):

Helm Chart, RKE1, k8s v1.20, v1.21, v1.22
I also reproduced this with a Vagrant install, following https://ranchermanager.docs.rancher.com/getting-started/quick-start-guides/deploy-rancher-manager/vagrant

Proxy/Cert Details: n/a

Information about the Cluster

Kubernetes version: v1.22.9-rancher1-1
Cluster Type (Local/Downstream):

Downstream. Provided by Vagrant.
User Information

What is the role of the user logged in? Admin

If custom, define the set of permissions:

Describe the bug
We have noticed a bug with the Rancher 2.6.10 UI. It does not seem to happen with Rancher 2.6.8.
We have reproduced this on two real-world deployments. I have also reproduced it easily using the Rancher Quickstart Guide and Vagrant. I will use Vagrant to describe the steps to reproduce the bug here.
I use macOS 12.6.3 (Monterey). The same bug happens with Chrome & Firefox. Both browsers are up to date.
To Reproduce

Follow the Quickstart Guide at https://ranchermanager.docs.rancher.com/getting-started/quick-start-guides/deploy-rancher-manager/vagrant
The Quickstart uses v2.6.8 by default. Update config.yaml to instead use v2.6.10. Start the cluster.
Log in, browse to the quickstart cluster.
Create a Deployment
Try to change the container name.

Result
I have included an animated GIF showing what happens to us. I browse to Deployment > container-0 > Container Name and type some characters. In my case, changing the name is almost impossible because the dialog refreshes for every single character that I type.
You can see that in my animated GIF below where I try to change the container name from container-0 to container-foo. The dialog refreshes 5 times before I give up.
Expected Result
I expect to be able to change the container name without the dialog refreshing over and over.
Screenshots

Additional context
n/a

I think this is a duplicate of https://github.com/rancher/dashboard/issues/7505 . I'll go ahead and close this issue.


Final GTÑ project tutorial

This is the last (mammoth) tutorial for the pilot project!

Whoo! :tada:
Would anybody from @galaxyproject/training-spanish like to give this a quick review?


Update Function Coverage

Followed instructions from https://github.com/facebookincubator/velox/blob/main/velox/functions/prestosql/coverage/README.md

@majetideepak Thank you for being proactive in updating the coverage for presto functions. This is unfortunately a duplicate of #2472. Do you mind if I close this PR?


Fix data race in MultithreadedMolSupplier

Another thread sanitizer detection: d_lastRecordId is, apparently, written and read by different threads, so we need to make sure it's accessed one at a time.

@ricrogz : i want to look at this one more closely before merging. Since I’m out of the office for a week, it will take a while

Sounds good to me.

I don't understand why there is a data race in d_lastRecordId and not in mol or d_lastItemText.
Here is the setter code
ROMol* MultithreadedMolSupplier::next() {
  std::tuple<ROMol*, std::string, unsigned int> r;
  if (d_outputQueue->pop(r)) {
    ROMol* mol = std::get<0>(r);
    d_lastItemText = std::get<1>(r);
    d_lastRecordId = std::get<2>(r);
    return mol;
  }
  return nullptr;
}

There is no mutex here so a thread can read stale values between the pop and return mol.

@ricrogz can you point me to the test where this problem showed up?
Like the other suppliers, I wouldn't expect using a MultitheradedMolSupplier object within multiple threads simultaneously to be thread safe at all - the multi-threading here is that it uses multiple threads to read from the input - so I'm curious where the warning comes from.
If we really do want to make this class safe to be used in multiple threads (and I don't think we do), there's a ton of work to do.

Sorry, I had to rebuild and rerun the tests.
tsan is flagging probles in three separate tests: testGeneralFileReader, testMultithreadedMolSupplier, pyTestMultithreadedMolSupplier. I'm attaching my latest log for these: tsan_multithreader_tests_log.txt. If I patch in the atomic declaration, all these go away.

Ah, ok, I see it now. It's in MultithreadedSmilesMolSupplier (the code which checks to see if the title line needs to be read).
That's definitely real.


implement more verify/validate

various verify/validate/wellFormed, such as:
Block.verifyWellFormed
Block.validateSignature
Vote.verify
Vote.addTimeoutSignature
ProposalMsg.verifyWellFormed
ProposalMsg.verify
TimeoutCertificate.verify
SyncInfo.verify
Note: this postulates : payloadIsEmpty : when we do Epoch change, we will need to decide what empty is.

I am not sure what you mean by "definition/use of f notation" in your last comment.

I am not sure what you mean by "definition/use of f notation" in your last comment.

Hah, sorry, I should have seen that coming.  I've edited the comment to say ` f `.


Can't find verbose to set it to false.

Very new here coming from python but needed true threads... lol
Grateful it exists
I can't find anywhere a way to set the loading verbosity of the model to false.
ModelParams don't have it, neither does LLamaWeights.
The Documentation only mentions it in llamamodel, that I assume was already removed(?), as it was said in the documentation itself that it would, in favor of llamaweights.
`string modelPath = "GGUF-Dolphin-Mistral-2.6-DPO-Laser-7B-Q8.gguf";
// Load a model
var parameters = new ModelParams(modelPath)
{
ContextSize = 32768,
GpuLayerCount = 33,
Threads = 12,
Seed = (uint)rnd.Next(1, 999999999),
BatchSize = 512
};
var model = new LLamaWeights(parameters);
// Initialize a chat session
var context = model.CreateContext(parameters);
var ex = new InteractiveExecutor(context);
session = new ChatSession(ex);`

May be you are looking for:
public NativeLibraryConfig WithLogs(bool enable = true)

Sorry, but how/where would I add this?
Can't seem to find any reference to it on the documentation and no hints as to which parameters it needs to be instantiated.

You use it like NativeLibraryConfig.Instance.WithLogs(false).
However I think you're probably looking for something a little different. As I understand it in the Python wrapper setting verbose=false suppresses all of the log output from llama.cpp?
I think if you want something similar in LLamaSharp you'll need to hook a log callback. This is a function that gets called every time llama.cpp wants to log a message.
NativeApi.llama_log_set((level, message) => {
    // Do whatever you want here
    Console.WriteLine(message);
});

Yeah.. In python, verbose=false on llm(...) will suppress everything.
Tbh, I dunno if I understand how to do what you've said... But I'll try it here.
For a threaded console app using LLama, it's kinda important to have a way to suppress it.
Thank you.
I'll try it and if it works I'll post it here and close the issue.

Well... It doesn't remove everything. Device and Capabilities identification are still present, but it's a lot lot less lines and manageable since I can clean the console after the models are loaded and no new log messages show up...
Thanks

You use it like NativeLibraryConfig.Instance.WithLogs(false).
However I think you're probably looking for something a little different. As I understand it in the Python wrapper setting verbose=false suppresses all of the log output from llama.cpp?
I think if you want something similar in LLamaSharp you'll need to hook a log callback. This is a function that gets called every time llama.cpp wants to log a message.
NativeApi.llama_log_set((level, message) => {
    // Do whatever you want here
    Console.WriteLine(message);
});

@HikiWaltz could you paste an example of exactly what is still printed? I'd like to fix that.
If it's coming from LLamaSharp we should provide a way to suppress it.
If it's coming from llama.cpp it's a bug on their side that the log hook doesn't catch it.

To suppress the loading I used:
NativeApi.llama_log_set((level, message) => { return; });
An then a Console.Clear() after loading the models.
What remains:
ggml_init_cublas: GGML_CUDA_FORCE_MMQ:   no ggml_init_cublas: CUDA_USE_TENSOR_CORES: yes ggml_init_cublas: found 1 CUDA devices:   Device 0: NVIDIA RTX A4500, compute capability 8.6, VMM: yes

putting 3 backticks around code will do it:
code goes here

I've opened an issue about it on llama.cpp: https://github.com/ggerganov/llama.cpp/issues/5797


esp32&esp32-c3/rt_timer: Re-word some comments and fix typos

Summary
Re-word some comments and fix typos in rt_timer files in both ESP32 and ESP32-C3.
Impact
No functional change.
Testing
Build and test ESP32 and ESP32-C3 defconfigs.

@gustavonihei @davids5 thanks for your review, I applied all the suggestions.


Make game target bigger

When starting a new game or taking a turn on an existing game, the user has to hit the small grid icon to the right of the list item.  The target should be the entire list item, not just the small grid icon.

Fixed.  Now the entire list item is clickable, so more intuitive.


DataStore: fix out of bounds write for Int

This seems to be a copy-paste error. The Long and BigInt versions already correctly implemented the wrapping.

After investigating this a little bit more, it seems like the wrapping behavior is actually hiding a bug in a design that I am testing. It might be better to emulate Verilator behavior here and to just ignore out of bounds writes.


Subclassing MarkdownRenderer

so, I was following your README on subclassing the markdown renderer, and I realized that in your markdown_helper.rb parse_markdown method you always instantiate the
renderer = ContentfulRails::MarkdownRenderer.new(renderer_opts)
So, how do you typically force your engine to use your new and improved subclassed markdown renderer?

@dezmathio we have re-defined parse_markdown in a new helper in the project to to this.

I see, we thought of doing that as well. Do you think that it would be worthwhile making a configuration attribute such as .markdown_renderer where we could override it if we were using a subclassed one, else it would always use the default one? That way we could cut down on code duplication & have a somewhat cleaner solution. Thoughts? cc @pmoore

I'll leave @dlitvakb to decide, @dezmathio - he maintains now.

Hey @dezmathio,
Looks like something we can improve on,
I'll look onto it as soon as I have a free slot on my schedule.
I'll propose taking a look again to refining this gem during next week's planning.
I'll try to get you an update by this time next week.
Cheers

Hey @dezmathio,
Sorry response took a bit longer, I've been travelling quite a bit (right now at RubyConf US).
My first priority now is to address all Rails Integration related issues, including this one, so I'll be tackling this issue in the next few days and have a PR ready for merge as soon as possible.
Cheers


Table Header: More sorting options #122

Closes IBM/carbon-components-angular#122

I'm not sure what to do for that merge conflict. I just pulled master into my master and the my master to the Table branch here, no conflicts, no merges. Any ideas?

Fixed it in the web ui ... think that worked?

There was a line with spaces in the table.stories.ts.
I noticed that sometimes I would pull from master and my branch will start having lint errors.

That's ridiculous, Travis has been stuck in Waiting for status to be reported for 7 hours now...

Any chance of merging this PR soon?


Show in web feed does not exist

According to this doc, there is an option 'show in web feed' that can be configured per application. However, this option does not exist (anymore?):

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2d9a579b-3ae9-27a1-f954-8dbabd6691e7
Version Independent ID: 2929c812-131c-24a0-76fb-f99a7af4af03
Content: Azure Virtual Desktop MSIX app attach portal - Azure
Content Source: articles/virtual-desktop/app-attach-azure-portal.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

The option DOES exist in the API btw. (showInPortal, boolean)

@Heidilohr
Can you please check and add your comments on this doc update request as applicable.

Thanks for the feedback. I've updated the article to account for this option no longer being there.  The change should be visible later today.
#please-close


Fix Hashlink compilation

i hate cpp
issues that i have to fix:

[ ] crash on entering options menu (cast failure)

some stuff that i can't do yet:

luajit
hxcodec
discord rpc
memory counter in fps text (the hl gc stats don't work)

hopefully (best case scenario) ill make hl extensions for the missing libraries, but for now this works

hopefully i didn't break windows when making this

you should mark this as a draft

you should mark this as a draft

tbh the only reason i didn't mark this as a draft is because the fix was so easy i thaught that i shoudn't do that but then i got distracted and when i came back i was tired as hell
and today i forgot about this until now

if we were doing a hl compilation support for psych engine, we might have to use another fork of hxcodec, discordrpc, and linc_luajit that supports hashlink

Deciding to close this to port this to the dev branch

nvm i got distracted and im now doing shit for libvlc lua
discordrpc can be done with a websocket


implement local file IO write loop for hydration

Rather than calling down into the libprojfs API to write bytes to a file during hydration, we can utilize the Mono.Unix.Native.Syscall write(2) wrapper and perform this loop the C# layer in our ProjFS.Linux WriteFileContents() method.
There should be no impact on performance as we are, in either case, calling via P/Invoke into a dynamic library (our libprojfs.so or Mono's .dll) to actually perform the write(2) call.
However, this approach avoids the need to implement a generic write loop function in libprojfs and thus helps simplify that library's API.
See also github/libprojfs#59 for the corresponding changes in libprojfs.

My only concern with this approach is that it means we actually care about the semantics of fd in the C# code. This is probably a non-issue, but having the value be relatively opaque was a nice property.

Thank you for the review and approval, @kivikakk!  Wow that's fast!  🏎
I do take your point about abstraction ... hmmmm.  🤔
I suppose I feel like the benefits outweigh the opaqueness of the fd here -- after all, we also have all the other details (like pid and mask and all the libprojfs constants) to deal with in the C#, so it's not that separate.  The event.fs field is opaque, though, and that's true for any C clients too.  Plus, we're already using the C# Syscall.lstat() elsewhere, so there's that.
If we were designing libprojfs's API without knowing how VFSForGit worked, I figured that we would the caller could/would deal with the file descriptor however it wanted, perhaps using sendfile(2) or splice(2) or whatever else they wanted, rather than necessarily wanting us (i.e., libprojfs) to write bytes for them.
At any rate, I think I'll merge these two PRs, since you've approved them.  :-)  Thank you!


Fat: Use 4BPP for spinner text

Description
Use 4BPP font for spinner text.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
Patch and project coverage have no change.

Comparison is base (5a7cdd8) 85.97% compared to head (0f3aa26) 85.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   85.97%   85.97%
=======================================
  Files           8        8
  Lines         385      385
=======================================
  Hits          331      331
  Misses         54       54

Flag
Coverage Δ

unittests
85.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Test code for the framework is broken and incomplete

Some strategy for developing and including unit and system tests should be put in place.  Existing tests within the VisionEval Framework do not currently (2017-03-02) appear to run.  Basic tests for comprehensive framework API functionality are desirable for several operational reasons:  (1) to ensure that all functionality works as intended; (2) to ensure that updates to the API have not broken other expectations (e.g. some tests may involve functionality that was not directly modified); (3) the git history of the tests themselves will provide concrete examples to module and model developers of what they might have to change in their code to get it up to date with the new framework version.
It is okay to have, say, VERPAT or the GUI-Visualizer act as a test harness (those obviously should be kept working), but it is important to have as comprehensive a set of unit tests as possible, and to organize them into a test suite to permit easy and automatic regression testing when changes are made.  Note that this is also a process request for the developers, not just a request for specific test code.
Specifically, I can’t run test script for the framework (in the “tests/data” directory).  I attempted to do that by loading the VisionEval R project into a fresh RStudio session, navigating to “data/tests”, and sourcing the “run_model.R” script.  I get this fatal error:
“Error in initializeModel(Dir = "defs", ParamFile = "parameters.json",  :
unused arguments (Dir = "defs", ParamFile = "parameters.json")”

major improvements for testing in pull request #104


django-summernote SummernoteInplaceWidget Not Working Locally

I was reviewing my django-summernote install this morning and tried to install Summenote locally on my Windows 10 machine.  During this exercise, I realized that I did not need the libraries in my HTML header as part of the django-summenote install.  I had these libraries in my HTML header:

<link href="https://cdnjs.cloudflare.com/ajax/libs/summernote/0.8.9/summernote-lite.css" rel="stylesheet">
<script src="https://cdnjs.cloudflare.com/ajax/libs/summernote/0.8.9/summernote-lite.js"></script>

After I removed them from my HTML header, the SummernoteWidget continued to work as normal, but the SummernoteInplaceWidget disappeared altogether.  The only way I can get the SummernoteInplaceWidget to appear is if I add the libraries referenced above back into my HTML header.  Is this normal, expected behavior?  I would prefer to use the SummernoteInplaceWidget for a couple of reasons, but I can't seem to get it to work properly even when I am using the libraries above, I opened up separate issues for my other SummernoteInplaceWidget difficulties.
In this case, I am trying to avoid the CDN libraries and run locally, but without them SummernoteInplaceWidget does not appear.

After extensive trial and error, it would appear that in order to use the SummernoteInplaceWidget for django-summernote, you need to include the Jquery and bootstrap libraries in order for the SummernoteInplaceWidget to work.  However, I am still not able to get the SummernoteInplaceWidget for django to show editable content in my view.  It shows the editor as desired, but it does not show the content.

Closing out as my original question was how to get the SummernoteInplaceWidget working locally.  Answer was to make sure both Jquery and Summernote-lite files are referenced in HTML header.  SummernoteWidget does not require these files, but SummernoteInplaceWidget does.

@dunkinman how did you solve this issue? Can you please provide an example how did you include the required jquery and summernote files in HTML head?

@OmkarPathak I found this code in my code base.  I ultimately went a different direction because Summernote could not meet my requirements, or I couldn't figure out how to get it to do everything I wanted it to do.  However, I believe the code below might help answer your question.

      <script type="text/javascript" src=https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.7.2/Chart.js></script>
      <link rel="stylesheet" href="{% static 'summernote/summernote-lite.css' %}" type="text/css">
      <script src="{% static 'summernote/summernote-lite.js' %}"></script>
       <link href="https://cdnjs.cloudflare.com/ajax/libs/summernote/0.8.9/summernote-lite.css" rel="stylesheet">
       <script src="https://cdnjs.cloudflare.com/ajax/libs/summernote/0.8.9/summernote-lite.js"></script>


[website] Update home page's sponsor grid

[x] I have followed (at least) the PR section of the contributing guide.

Removing Laststance as requested.

Maybe it would make sense to batch it with https://groups.google.com/a/mui.com/g/core/c/OZfEzXHQoVI?

We had a new one https://groups.google.com/a/mui.com/g/core/c/FiB61L9rLDg

@hbjORbj can you help Danilo if he doesn't have bandwidth to finish this up?

One more: https://mui.zendesk.com/agent/tickets/4210 (https://goread.io/)


#[sqlx::test] manage the full lifecycle of the test DB (inside a container)

Describe the solution you'd like
Have #[sqlx::test] manage the full lifecycle of the test DB.
Currently I'm running my tests using test-containers, so I don't need any externally setup DB. Would this be something that could be incorporated into SQLx itself? Currently I'm using regular #[tokio::test].
Describe alternatives you've considered
Have some way to run a setup function, before whatever #[sqlx::test] is doing. This way I could setup the container and maybe set the DATABASE_URL environment variable. It could look like #[sqlx::test(setup=my_setup_function)].

I would also like to use test containers with my SQLx code, so being able to define a fixture to set up the environment before running each test would be great.

This seems to be a duplicate of #3022.

I guess not exactly since I propose the direct integration of test-containers

At a certain point we're just talking about a completely different implementation of test harness here.
Because [`testcontainers` stops the container on-drop`](https://docs.rs/testcontainers/latest/testcontainers/core/struct.ContainerAsync.html#impl-Drop-for-ContainerAsync<I>), you couldn't just start it in a setup function. You'd need a way to retain ownership of it for the duration of the test. Or you'd need to `forget()` it and have a separate teardown function to delete the container at the end, and then some way to thread the container ID past the test function (I suppose a thread-local would work).
This could be integrated as an optional feature, but I'm wary of having essentially two completely separate execution strategies for tests. And I don't want to make it the primary execution strategy because it requires having Docker installed, which not everyone wants to do or is able to do because of how it's licensed. And it doesn't look like testcontainers supports alternate container frontends like Podman.
Ultimately, this concept should probably live in its own crate.

facing same issue 🤨


Shouldn't be possible to change the datatype of a publisher after its created

The backend isn't fit for this

Yeah it's hardly required anyway.


Mouse click event

Hello
Is there any way to trigger mouse click event when user click image on slider?

Hello, the slider by itself does not have an event for that, but you should be able to capture it on your component by using @click.
Regards


[1.12] Fix possible out of bounds access during log parsing

This PR backports #2180

LGTM
/approve

/test e2e_fedora

/approve

/lgtm


[Bug] Go install does not work with new go.mod file

What is the problem?
I was just scaffolding a new project with this awesome tool. but the go install command from README.md does not work anymore with the following error:
❯ go install github.com/melkeydev/go-blueprint@latest
go: github.com/melkeydev/go-blueprint@latest (in github.com/melkeydev/go-blueprint@v0.7.5): go.mod:3: invalid go version '1.22.4': must match format 1.23

I'm pretty it's because of mention go patch version in the project's go.mod file.
Operating System
Debian 12
Architecture Version (x86, x64, arm, etc)
x64
Steps to reproduce
Just run the install command from README.md
go install github.com/melkeydev/go-blueprint@latest

Relevant log output
go: github.com/melkeydev/go-blueprint@latest (in github.com/melkeydev/go-blueprint@v0.7.5): go.mod:3: invalid go version '1.22.4': must match format 1.23

I'm using go version 1.19.3, so it might be a change in go.mod file format. I can't pin it down but for now, install version 0.6 works fine for me.
go install<EMAIL_ADDRESS>

This isn't a bug per se, you're running an outdated Go version. Please update Go to v1.21 or later. You're running Debian and get old packages when using apt. I'm running Debian myself, but the tools I use for development are always up-to-date. Either build from source or download the latest release from the repository.


DATE columns not computing nullity

This may be on the application side, but I'm seeing that DATE columns aren't giving me null %s. The two DATE fields in the spending dataset don't seem to have them, so they don't render.

hmm, having trouble reproducing this easily,


No module named 'cv2'

Hi.
While running: python3 inference_video.py --exp=1 --video=video.mp4 --scale=0.5
I get:
File "C:\Users\risto\Desktop\ML-NEW\ECCV2022-RIFE-main\inference_video.py", line 2, in
import cv2
ModuleNotFoundError: No module named 'cv2'

Check the requirements.txt:
opencv-python>=4.1.2

I'm having the same issue, however I have the latest version of opencv-python installed and it is still showing me the same error
running:  python3 inference_video.py --exp=1 --video=video.mp4 --scale=0.5
result: File "C:\Users\anon\Desktop\Downloads\Rife\ECCV2022-RIFE-main\inference_video.py", line 2, in
import cv2
ModuleNotFoundError: No module named 'cv2'
Here are some images for reference:

pip install opencv-python


Include port in listener status

We should consider adding the port number to listener status in anticipation of future support for auto-assigning a port when no port is specified.
By adding it in advance of actually supporting auto-assignment, API users can begin to adapt their usage in a way that will continue to work in future.
For example, examples like in Istio's gateway docs could be future-proofed to do:
$ kubectl wait -n istio-ingress --for=condition=ready gateways.gateway.networking.k8s.io gateway
$ export INGRESS_HOST=$(kubectl get gateways.gateway.networking.k8s.io gateway -n istio-ingress -ojsonpath='{.status.addresses[*].value}')
$ export INGRESS_PORT=$(kubectl get gateways.gateway.networking.k8s.io gateway -n istio-ingress -ojsonpath='{.status.listeners[*].port}')

See also #1061, #818, and Gateway API: Multi Port Approach

Strong +1 from me here.

I think this is worth exploring, but want to be a bit cautious. The most compelling reason to add port to status would be if we added support for automatic port assignment/allocation. Without that feature, we'd just be replicating a value from spec to status. I think it may be better to wait until we have a clearer picture for what port assignment would look like/if we want to proceed with that feature before we add port to status.

/remove-lifecycle stale

Hey @kundan2707 :wave: just wanted to check if there was some new context on this one?


Ensures gulp concatonates sources in order

closes https://github.com/roots/sage/issues/1476
Make the bower file paths relative due to
https://github.com/sirlantis/gulp-order/issues/11

https://discourse.roots.io/t/internet-explorer-8-ie8-compatibility/3596/13?u=austin

@retlehs gonna merge

not sure about depending on that project, doesn't really look maintained. not a fan of the makeRelative function because it doesn't seem like the linked issue is going to be resolved

waiting on https://github.com/austinpray/asset-builder/issues/49

we won't be addressing this :warning:


sqrt of certain numbers returns unexpectedly an error

e.g. sqrt(0.0000000002) returns an error.

As sqrt of numbers in the range 0..1 are calculated based on their inverse we may have to define a lower bound for the fixpoint approximation to be valid
https://github.com/encointer/substrate-fixed/blob/2c52170fa02507dc5b52c516061302670860869a/src/transcendental.rs#L143
change that line not to check for equality to zero but smaller than a minimal supported value. a WARNING should be issued in that case

but should we really avoid that error? shouldn't it be an error?

Hmm, I think we can not so easily circumvent this on substrate fixed side. But a warning would be nice at least.
We could address that bug in the pallet and increase the minimum supported distance between meetup points of a currency. The problematic case was 290 meters apart.

Problematic numbers are within : ]1.164e-10, 5.82e-10] with the types I32F32.

Problematic numbers are within : ]1.164e-10, 5.82e-10] with the types I32F32.

Here we get an overflow: https://github.com/encointer/substrate-fixed/blob/2c52170fa02507dc5b52c516061302670860869a/src/transcendental.rs#L148

Here we get an overflow: https://github.com/encointer/substrate-fixed/blob/2c52170fa02507dc5b52c516061302670860869a/src/transcendental.rs#L148

Edit: numbers below 1.64 simply get truncated to 0, this is why it works. Hence, there is only a lower bound of 5.82e-10 that can be calculated.

Edit: numbers below 1.64 simply get truncated to 0, this is why it works. Hence, there is only a lower bound of 5.82e-10 that can be calculated.

I just changed the error type in the sqrt function to &'static str, which prints the overflow error. I think this suffices as error handling.

I just changed the error type in the sqrt function to &'static str, which prints the overflow error. I think this suffices as error handling.


Cleanup: annotations and javadoc

"meta"-ticket for some non-code changes like adding Override annotations, removing unused imports and adding / correcting javadoc

See also #790

Closing this one, creating new ticket(s) when needed.


How to compile the ARM ISA

Nice to meet you. I'm going to use the VASim in arm architecture. but I only make the VASim for X86 ISA. How can I do for VAsim in ARM ISA?

I don't see why this wouldn't be possible. I don't think VASim (or any dependencies) has any x86 specific code. I don't have access to an ARM system, so I can't verify this though.
Currently VASim is a little difficult to build even on x86 Linux because MRNL/valijson has some preprocessor macros that are only available in C++17. This is why we require g++-5. By deleting those macros you can compile with gcc-4.6+ I believe. For your project, I expect you'll have to change some stuff around in the Makefiles of VASim and the dependencies, but with a little hacking it should work.
Have you tried yet? Are there any errors you're getting I can take a look at.
Let me know how it goes!

Thanks to your response. I'll use the VASim as a benchmark of the gem5 simulation tool. but the gem5 simulation's configuration consists of ARM architecture. so I have one questions about using cross compiler such as arm-linux-gnueabi-g++. How about think?
-----Original Message-----
From: "Jack<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2018-08-10 (금) 22:39:02
Subject: Re: [jackwadden/VASim] How to compile the ARM ISA (#35)
I don't see why this wouldn't be possible. I don't think VASim (or any dependencies) has any x86 specific code. I don't have access to an ARM system, so I can't verify this though.
Currently VASim is a little difficult to build even on x86 Linux because MRNL/valijson has some preprocessor macros that are only available in C++17. This is why we require g++-5. By deleting those macros you can compile with gcc-4.6+ I believe. For your project, I expect you'll have to change some stuff around in the Makefiles of VASim and the dependencies, but with a little hacking it should work.
Have you tried yet? Are there any errors you're getting I can take a look at.
Let me know how it goes!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@cupyty
I have successfully compiled VASim for Arm before on a Raspberry pi using GCC. It should work 100%.

Sweet. Thanks for the info @ted-xie!
Closing.


Add support for mache from fork/branch

This lets E3SM-Unified be installed as normal except with a test version of mache (e.g. with support for a new machine).

Testing
I used this branch to install E3SM-Unified 1.9.2 on the ALCF Polaris machine using https://github.com/xylar/mache/tree/add-alcf-polaris.


Type '() => void' is not assignable to type 'MouseEvent'

Hi
Updated vue-tsc with 1.0.6 and got tons of errors of this kind.
@click event (MouseEvent) now doesn't have function type () => void or () => boolean or similar to this signature.
How to fix that ?
p.s. this type coming from __VLS_types.ts which doesn't even exists.

Duplicate #1985


add github action to wait for ofborg

In case ofborg is down this will not mark the CI as green.
Also if other github actions are used and pass
checks will be still marked as pending even if other other github
actions have passed.

@GrahamcOfBorg build hello

@GrahamcOfBorg build hello

@GrahamcOfBorg build hello

@GrahamcOfBorg eval

Something that might be an issue with this approach is the limits on github actions, if ofborg goes down we'll start burning through our allocation.

It is limited to 10min.

It is limited to 10min.

Which could end up adding up quickly if ofborg does down for any length of time.

It is limited to 10min.

Which could end up adding up quickly if ofborg does down for any length of time.

Where do you have the information that we have limits? This looks like there are only for private repos: https://docs.github.com/en/github/setting-up-and-managing-billing-and-payments-on-github/managing-your-spending-limit-for-github-actions#about-spending-limits-for-github-actions

Where do you have the information from that we have limits? This looks like there are only for private repos:

Ah, must have misremembered. Concurrent jobs and API requests may be an issue?
https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits

Not really. It would just means that the job is started later...

Any idea why ofborg is not picking up this PR? Do I need to modify nix files?

@GrahamcOfBorg eval

@GrahamcOfBorg eval

Any idea why ofborg is not picking up this PR? Do I need to modify nix files?

No. AFAIK, you shouldn't need to modify a nix file for it to start.
I have noticed that ofborg has been a bit flakey the last day or two, not picking pushes or stopping after eval/meta checks and not triggering builds.

Let's keep the wip label as long as we flip the gnuhello tests, so we don't accidentially merge it ;-)

This is working now. In case it timeouts its still clear that ofborg should have been run so users are not tricked into thinking that the CI run successfully.

Let's see how this works out in practice.

Builds started by an manual ofborg build *** satisfy this check, can we limit it to successful evals?

Builds started by an manual ofborg build *** satisfy this check, can we limit it to successful evals?

It could check for a specific eval, but to be honest before we do this we rather should make the eval job a required check...

It could check for a specific eval, but to be honest before we do this we rather should consider making the eval job a required check...

Should we disable the actions for now until we get the required checks working?
The timeout job is a nice workaround but I think the drawbacks may be outweighing the benefits of having it just for the editorconfig check.

It could check for a specific eval, but to be honest before we do this we rather should consider making the eval job a required check...

Should we disable the actions for now until we get the required checks working?
The timeout job is a nice workaround but I think the drawbacks may be outweighing the benefits of having it just for the editorconfig check.

This is a problem with or without github actions. If someone triggers ofborg build it will mark the build as green. I don't see how this is worth than the status quo. In fact having github actions increases seeing the absence of ofborg runs. If ofborg is down for example github actions would still mark the build as failed. So just having the Waiting for ofborg action provides value on its own.

In fact having github actions increases seeing the absence of ofborg runs. If ofborg is down for example github actions would still mark the build as failed. So just having the Waiting for ofborg action provides value on its own.

There was a 3hr wait for ofborg evals earlier, needed to clear a page of errored PRs after ofborg caught up.

Let's continue discussion in https://github.com/NixOS/nixpkgs/pull/94658


Unable to select directories

Unable to select directories
if anyone know the solution please let me know

You need to add the service accounts to the team drives. They should appear there after that. ^JR

You need to add the service accounts to the team drives. They should appear there after that. ^JR

is it necessary to add SAs in tds?
What if we have added google group email instead? will it work?

Yes. If you add the Google Group with the SA's inside, then you can use
that.
On Thu, 1 Jul 2021 at 13:01, Katper @.***> wrote:

You need to add the service accounts to the team drives. They should
appear there after that. ^JR
is it necessary to add SAs in tds?
What if we have added google group email instead? will it work?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MsGsuite/CloneBot_Heroku/issues/7#issuecomment-872185582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEG3YLUYELLS7XH2ZMUBHTTTVRKJZANCNFSM457AJADA
.

Yes. If you add the Google Group with the SA's inside, then you can use that.
…
On Thu, 1 Jul 2021 at 13:01, Katper @.***> wrote: You need to add the service accounts to the team drives. They should appear there after that. ^JR is it necessary to add SAs in tds? What if we have added google group email instead? will it work? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG3YLUYELLS7XH2ZMUBHTTTVRKJZANCNFSM457AJADA .

wooh..that was really quick. Thanks.
One more querry
Is it normal rclone bot or gclone?
and what does this line of code means?
gclone_para_override =

Is it normal rclone bot or gclone?

gclone

and what does this line of code means?

leave this empty you don't need this


Solr schema

Hi, trying to get this to run locally to evaluate, but running into problems with solr.  Are the config/schema available anywhere?
Thanks

I've put all our config files up in this gist
Not the ideal way to share them, I know, but hopefully it'll do the job until we get a bit further with opening up our config?


require(/var/www/vendor/composer/../../src/aliases.php): failed to open stream

I'm trying to use the google api index, but when i call:
require_once 'vendor/autoload.php';
I got error on my nginx log error:

FastCGI sent in stderr: "PHP message: PHP Warning:  require(/var/www/vendor/composer/../../src/aliases.php): failed to open stream: No such file or directory in /var/www/vendor/composer/autoload_real.php on line 71PHP message: PHP Fatal error:  require(): Failed opening required '/var/www/vendor/composer/../../src/aliases.php' (include_path='.:/usr/share/php') in /var/www/vendor/composer/autoload_real.php on line 71"

i'm using the latest version of api, also i tried to composer install, and tested with vendor folder installed by composer, got the same error.
I tried the version 2.5.0 too and this error doesn't happen but i got other error with Google Service.
How can i fix this?

I downloaded the latest release for PHP 7.4, and verified the class src/aliases.php exists. The error you're receiving must be due to your webserver not being able to read the file (either because it doesn't exist, or it has the wrong permissions).
I am closing this because I do not believe the error here is in the library (as I was able to verify the file exists). If you can provide evidence that the file does not exist in one of our packages, please reopen or file a new bug.


take another look at blockly's hooks

If you can get your stubby little fingers into their rendering code, you can delete like 80% of the code lol

I'm working on this again, looks promising

Done