Dart Sass Support

Support the new Dart Sass implementation – https://github.com/sass/dart-sass
Tip to run tests every time an scss file is modified:
npm i -g nodemon
nodemon -e scss -x "/path/to/dart-sass test/test.scss --trace" test

FYI @nex3: this is what I get when trying to compile tests in Dart Sass:
https://travis-ci.org/sass-mq/sass-mq/jobs/172138466#L593
Unexpected exception:RangeError (index): Index out of range: index should be less than 1: 1
node_modules/dart-sass/sass.dart.js 4154:17   dart.wrapException
node_modules/dart-sass/sass.dart.js 4104:15   dart.ioore
node_modules/dart-sass/sass.dart.js 17629:22  Environment.dart.Environment.getVariable$1
node_modules/dart-sass/sass.dart.js 27366:37  _PerformVisitor.dart._PerformVisitor.visitVariableDeclaration$1
node_modules/dart-sass/sass.dart.js 16637:24  VariableDeclaration.dart.VariableDeclaration.accept$1
node_modules/dart-sass/sass.dart.js 31349:41  J.accept$1$x
node_modules/dart-sass/sass.dart.js 28126:13  _PerformVisitor__visitDynamicImport__closure.dart._PerformVisitor__visitDynamicImport__closure.call$0
node_modules/dart-sass/sass.dart.js 27703:27  _PerformVisitor.dart._PerformVisitor._withEnvironment$2
node_modules/dart-sass/sass.dart.js 28118:12  _PerformVisitor__visitDynamicImport_closure.dart._PerformVisitor__visitDynamicImport_closure.call$0
node_modules/dart-sass/sass.dart.js 27207:77  _PerformVisitor.dart._PerformVisitor._visitDynamicImport$1

The test is simply dart-sass test/test.scss (for now).
Is there a workaround/am I doing anything wrong?

That's probably a bug. Can you try running with the pure Dart version and seeing what stack trace you get?

FYI I also filed sass/dart-sass#3 to track better stack traces for the JS version.

Thanks! Here is the trace with the pure Dart version:
/Users/kdeloumeauprigent/Downloads/dart-sass/dart-sass  test.scss
Unexpected exception:
RangeError (index): Invalid value: Only valid value is 0: 1

dart:core                                                         List.[]
package:sass/src/environment.dart 138                             Environment.getVariable
package:sass/src/visitor/perform.dart 778                         _PerformVisitor.visitVariableDeclaration
package:sass/src/ast/sass/statement/variable_declaration.dart 39  VariableDeclaration.accept
package:sass/src/visitor/perform.dart 504                         _PerformVisitor._visitDynamicImport.<fn>.<fn>
package:sass/src/visitor/perform.dart 1275                        _PerformVisitor._withEnvironment
package:sass/src/visitor/perform.dart 502                         _PerformVisitor._visitDynamicImport.<fn>
package:sass/src/visitor/perform.dart 1360                        _PerformVisitor._withStackFrame
package:sass/src/visitor/perform.dart 501                         _PerformVisitor._visitDynamicImport
package:sass/src/visitor/perform.dart 490                         _PerformVisitor.visitImportRule
package:sass/src/ast/sass/statement/import_rule.dart 22           ImportRule.accept
package:sass/src/visitor/perform.dart 157                         _PerformVisitor.visitStylesheet
package:sass/src/visitor/perform.dart 147                         _PerformVisitor.run
package:sass/src/visitor/perform.dart 46                          evaluate
package:sass/sass.dart 24                                         render
package:sass/src/executable.dart 50                               main

Hmm, looking at the code, it's not obvious to me how that would happen. If you can find a small reproduction, let me know, otherwise hopefully something in sass-spec will hit it too.

@nex3 I managed to solve the first issue when running dart-sass test/test.scss --trace, but then I got this:
Unexpected exception:
RangeError (index): Invalid value: Only valid value is 0: 1

dart:core                                                         List.[]
package:sass/src/environment.dart 138                             Environment.getVariable
package:sass/src/visitor/perform.dart 778                         _PerformVisitor.visitVariableDeclaration
package:sass/src/ast/sass/statement/variable_declaration.dart 39  VariableDeclaration.accept
package:sass/src/visitor/perform.dart 504                         _PerformVisitor._visitDynamicImport.<fn>.<fn>
package:sass/src/visitor/perform.dart 1275                        _PerformVisitor._withEnvironment
package:sass/src/visitor/perform.dart 502                         _PerformVisitor._visitDynamicImport.<fn>
package:sass/src/visitor/perform.dart 1360                        _PerformVisitor._withStackFrame
package:sass/src/visitor/perform.dart 501                         _PerformVisitor._visitDynamicImport
package:sass/src/visitor/perform.dart 490                         _PerformVisitor.visitImportRule
package:sass/src/ast/sass/statement/import_rule.dart 22           ImportRule.accept
package:sass/src/visitor/perform.dart 157                         _PerformVisitor.visitStylesheet
package:sass/src/visitor/perform.dart 147                         _PerformVisitor.run
package:sass/src/visitor/perform.dart 46                          evaluate
package:sass/sass.dart 24                                         render
package:sass/src/executable.dart 50                               main

Following this, I commented a few lines to force the tests to pass, see 2888930.
Sorry if this is a lot of code to digest. I'm a bit confused because every time I try to make a reduced test case I can't reproduce the bug!
Let me know how I can help further.

I think this should be fixed with 1.0.0-alpha.2, which I just released.

@nex3 it works indeed, thanks for the quick turnaround!
The output is now exactly the same as Ruby Sass (expect for colors which are lowercase hex in Dart Sass).


Syntax Highlighting Improvements Wanted

Introduction
I have already opened a related issue some days ago, mostly stating my problems in understanding the workings of theming and syntax highlighting and pointing out problems I had with the documentation.
As by now I do understand a lot more about the way things work, i decided to open a new issue as a feature request. What I will try to do is:

explain my findings
provide tips and examples for myself and others
analyze strengths and weaknesses of 'TextMate'- and Semantic highlighting
hope to collect input and support for improvements

My findings and examples are based on TypeScript, which is not only my primary language of choice but also one of the  languages with the deepest built in support in vs code._
To follow my thoughts, it is likely you need a slightly more than basic understanding of Syntax Highlighting and Semantic Highlighting
A short summary:

Syntax Highlighting
Semantic Highlighting

Based on RegEx, has no deeper 'understanding' of the language.
Based on the Language Server, has a good understanding of the Language

Has a lot of (undocumented) selectors, that can be combined in multiple ways
Has a smaller set of tokens that can be combined with token modifiers

Which selector has precedence isn't always easy to understand
Precedence is connected specificity

Existing syntaxes can be extended (injected)
I couldn't find a way to add or change the built in syntax

Is always overridden by semantic
Always overrides TextMate syntax

Renders instantly
Takes a moment to be applied

Is always enabled an supported
can be disabled and enabled by user setting, themes etc.; is only supported for certain languages

Semantic token scope map
This is a concept that eluded me for a rather long time. Especially the term "Fallback TextMate Scope" made me totally misunderstand the concept. I thought, that if a semantic token would not work, or is not implemented for the context/language, semantic syntax highlighting would fall back to the mapped TextMate syntax token.
In fact it is the other way round: If your theme does not provide a semantic token definition for - let's say - 'function', it is automatically added to your theme by hijacking  the TextMate (style) definition that is mapped to function - in our case that would be: entity.name.function
🚨 Possible pitfall: The moment you define one of the (by default) mapped TextMate scopes like 'variable.other.readwrite' you automatically enable the semantic scope for 'variable' with the style of 'variable.other.readwrite' . (If semantic syntax is enabled somewhere, not necessarily in your theme.)
That semantic scope can be and is supposed to be 'better' due the better understanding of the language, but this is not always the case - and often times surely not what you as a theme author desire.
🩹 Tip / Hack: you can avoid that by defining your TextMate token's sope as "source variable.other.readwrite", but if you define the mapped sematic toke by itself or through an other mapped TextMate token, your token will be useless anyhow.
My conclusion: As of now to build a somewhat elaborate theme syntax one needs to use both kinds of tokenization but the mapping behavior is not easy to understand and hard to customize / hack.

TextMate scoping, while it lacks 'understanding' is very finely granulated (most of the time)  and can be extended to be even more so.
Semantic scoping is (at least for the moment) mostly very broad.

PROBLEM: As sematic always wins we are in a situation where the broad brush almost always paints over the the fine details! 👎
🛑EDIT:
A crucial part of the following information is wrong, or to be precise is/was caused through a grammar injection I made. TextMate grammar by default can identify the type annotations!
Somehow I got stuck in my own thought-loop late in the evening. I will investigate further and update asap. I'll leave it as is with strikethroughs, as some or most of the other issues are still true and I still feel that most of my findings have some value.

Missing (Typescript) Features in TextMate TYPE Highlighting:
⚠ I'll update this asap!

While in some contexts ist is easy to define a style for the type of a variable in others it is impossible regardless of the kind of highlighting you try it with. A grammar injection by me caused the failure of the type annotation recognition I doublecheck and will update!

The situation regarding more complex Types is - you guessed it - more complex but equally unsatisfactory: I caused the strange behavior by breaking something through a grammar injection. My bad, will investigate and update.

I can / will try to inject TextMate tokens to remedy the situation, but I feel that this should be improved by default (and by cleverer people than me...) Cleverer people than me already have done a good job at this, silly me just broke it. Update will follow.
Round Up Example(s)

One of the key problems of both syntaxes is that the scope of variable / variable.other is so very broad. The fact that one is mapped to the other is in my eyes worsening the situation.
Step by step:

someObject in TextMate is only variable.other.readwrite, semantic know that is also declared here. So far so good.
~~the type :number is in TextMate terms also variable.other.readwrite ~~, semantic know nothing bout it. Bummer!
:VampireProps ins variable.other.readwrite for TextMate :-( for semantic it is an interface not a type ???
now TextMate, thanks to the dot behind it takes bladeProps  as variable.other.object, while for semantic it is variable.readonly. (const). While window and  document  are variable.other.objec for TextMate, at least Math is unique. Semantics however takes all three of them to be variable.defaultLibrary - that's it. 🧘♂
Maybe it is just me, but I feel that eval and Symbol aren't too closely related - semantics trats them as the same function.defaultLibrary.
the type :Vampire is variable.other.readwrite for TextMate once again, semantic recognizes as as a class - but not as type. bladeProps is variable.other.readwrite and variable.other respectively. With Dracula in the next line TextMate guesses the variable.other.object thanks to the dot once again, semantics stays with variable.readonly.
While semantics plainly ignores the type description :number  here once again, TextMate thinks its a (yeah) variable other read write. And now, ladies and Gentlemen: age [++] in the next line is actually a variable.other.readwrite aka to semantics a variable.readonly. Wait - READONLY????. Actually that is true, for Dracula.age, which is a get function of the Vampire class, but as the return value is a primitive assigned to _ var age_  I'd go with the compiler that allows me to change it... (That the business logic behind my useless code samples, partly stolen btw., is faulty - mea culpa)

Conclusion and Wishlist

Both highlighting concepts are great in their own way, both could use improvements in the case of TypeScript typing.
The connection via the "Predefined TextMate scope mappings" should in my mind at least not be extended - rolled back if possible.
I understand that it's conceptually very problematic to override semantics with TextMate scopes, may be weaker semantic scopes could be implemented - at least I feel we need a lot more specific semantic possibilities not to overpaint fine grained TextMate semantics.
A way to disable certain predefined scope mappings would be helpful for a start.

Important (to me): I always feel bad, when I criticize and sound negative, especially in this case. VS Code is such a great project, and the people building it are brillant and simply adorable. So please believe me, that, while I want to help you to improve the great work even further, I'm thankful to you and totally happy about your great work. Using VS Code and tinkering with it is just great.  THX!

As promised I researched what I had done to break things and found another issue: with injection
While I don't really understand the details why my injection broke things so badly, after looking at the TypeScript.tmLanguage.json I get the general idea pretty well.
My question / suggestion is likely naive and I also do understand that you want to stay very close to the TextMate specification, but my idea would be to somehow 'add' to the syntax.
Replacing the whole syntax for well supported languages would absolutely seem nonsensical to me, but having some kind of 'include' mechanism that simply adds a (valid) pattern to the (end of) an existing repository for a tmLanguage.json would be something I could imagine as very helpful. In my imagination it wouldn't really touch any TextMate specification, and the likelihood of breaking any other complex built in constructs would diminish.
What do you think?

injections sort already do that
they add themselves into the patterns array that you're targeting
tho the targeting system is a bit 'meh'
as when you target a single scopeName, it will inject itself into every single sub patterns array of the main one

It's a topic that could fill a (small) book. I know our documentation has its limits as only a few extension authors will ever touch this.
Thanks a lot for writing your findings up and letting others benefit.
Unfortunately, this issue is not the best place to continue the discussions and findings. Instead, a [discussion]
(https://github.com/microsoft/vscode-discussions/discussions) should be opened so that more users can chime in and help and benefit.
Focusing on your conclusions. Sorry if I misunderstand you, I'm actually not sure which is your angle. Are you a theme author, or a language provider

The connection via the "Predefined TextMate scope mappings" should in my mind at least not be extended - rolled back if possible.

Please understand we can't change how theming works. It's now been around for several years, and themes and language providers have adapted for it. We can improve the documentation though.

I understand that it's conceptually very problematic to override semantics with TextMate scopes, may be weaker semantic scopes could be implemented - at least I feel we need a lot more specific semantic possibilities not to overpaint fine grained TextMate semantics. A way to disable certain predefined scope mappings would be helpful for a start.

I think a theme is in full control here. It can always define a color (can be the default background color) for a semantic token, and the fallback scopes are not used.
If a language doesn't want certain predefined scope mappings to be applied, it can provide its own, more specific mapping.
Closing the issue, it's unfortunately already too complex and hard to act on. If you have specific change requests or doc improvements: Smaller issues or even PRs are very welcome. I'm also happy to answer questions.


Mise doctor falsely complains shims are missing

Below are the result of me running mise doctor. At the bottom you'll see mise complain that shims are missing. However I do have ~/.local/share/mise/shims on PATH and everything seems to be working as expected.
❯ mise doctor
mise version:
  2024.1.26 macos-x64 (2024-01-25)

build:
  Target: x86_64-apple-darwin
  Features: DEFAULT, NATIVE_TLS
  Built: Thu, 25 Jan 2024 18:37:37 +0000
  Rust Version: rustc 1.75.0 (82e1608df 2023-12-21) (Homebrew)
  Profile: release

shell:
  /usr/local/bin/zsh
  zsh 5.9 (x86_64-apple-darwin21.3.0)

mise data directory:
  /Users/NQA/.local/share/mise

mise environment variables:
  MISE_USE_TOML=1
  MISE_DATA_DIR=/Users/NQA/.local/share/mise
  MISE_EXPERIMENTAL=1
  MISE_PYTHON_COMPILE=1
  MISE_SHELL=zsh

settings:
  {
    "activate_aggressive": false,
    "all_compile": false,
    "always_keep_download": false,
    "always_keep_install": false,
    "asdf_compat": false,
    "cargo_binstall": true,
    "color": true,
    "disable_default_shorthands": false,
    "disable_tools": [],
    "experimental": true,
    "jobs": 4,
    "legacy_version_file": true,
    "legacy_version_file_disable_tools": [],
    "node_compile": false,
    "not_found_auto_install": true,
    "paranoid": false,
    "plugin_autoupdate_last_check_duration": "1 week",
    "python_compile": true,
    "python_default_packages_file": "/Users/NQA/.default-python-packages",
    "python_patch_url": null,
    "python_precompiled_os": null,
    "python_patches_directory": null,
    "python_precompiled_arch": null,
    "python_pyenv_repo": "https://github.com/pyenv/pyenv.git",
    "python_venv_auto_create": false,
    "raw": false,
    "shorthands_file": "~/.config/mise/shorthands.toml",
    "task_output": "prefix",
    "trusted_config_paths": [
      "~/workspace"
    ],
    "quiet": false,
    "verbose": false,
    "yes": false,
    "ci": false,
    "cd": null,
    "debug": false,
    "env_file": ".env",
    "trace": false,
    "log_level": "info"
  }

config files:
  ~/.tool-versions
  ~/.config/mise/config.toml
  ~/.mise.toml

plugins:
  bun      (core)
  deno     (core)
  elixir   https://github.com/asdf-vm/asdf-elixir.git#a4c42e1
  elm      https://github.com/asdf-community/asdf-elm.git#34d2627
  erlang   (core)
  go       (core)
  java     (core)
  neovim   https://github.com/richin13/asdf-neovim.git#0b7b611
  nim      https://github.com/asdf-community/asdf-nim.git#397c14a
  node     (core)
  python   (core)
  ruby     (core)
  zig      https://github.com/cheetah/asdf-zig.git#d88f6db
  zigmod   https://github.com/kachick/asdf-zigmod.git#f792744

toolset:
  python@latest, go@latest, erlang@latest, elixir@latest, java@temurin-21, ruby@latest, elm@latest, zig@latest, zigmod@latest, nim@latest, node@lts, bun@latest, neovim@nightly

1 problem found:
shims are missing, run mise reshim to create them```

@Pilgrim1379 have you tried running mise reshim and then re-running mise doctor to see if the problem is no longer reported?
This is a new check that looks for missing symlinks for your given toolset in the shim directory. So everything may work, but it is possible that a shim is not being used when it should be.

Yes I did run 'mise reshim'. Sorry should have mentioned that. The issue still persists however.

created https://github.com/jdx/mise/pull/1529 which will display what they are to help debugging

created #1529 which will display what they are to help debugging

Thanks @jdx With the update you pushed, I now see that the missing shims are mix and nimble.
1 problem found:
shims are missing, run mise reshim to create them
Missing shims: mix, nimble

Going through the all the shims in ~/.local/share/mise/shims I find that all the applications in the shims folder are links to the actual applications which are located in /usr/local/bin/mise except those two which are acutal copied over programs not links.
Therefore I deleted all the shims and run mise reshim but those two are still acutal programs and not links.

Thanks for reporting back!
Yeah we will need to add special handling for executable scripts here:
https://github.com/jdx/mise/blob/7b3ae2e7a6f42f23d79586cd7a2e6ddc1f9efa89/src/shims.rs#L159-L163
After installing elixir on my machine:
$ cat /.../.local/share/mise/shims/mix

#!/bin/sh
export ASDF_DATA_DIR=/.../.local/share/mise
export PATH="/.../.local/share/mise/.fake-asdf:$PATH"
mise x -- /.../.local/share/mise/plugins/elixir/shims/mix "$@"


No module named 'uvicorn'

i'm receving this error since the last update can't realy install anything:
C:\Users\fares\pinokio\bin\py>conda_hook && conda deactivate && conda deactivate && conda deactivate && conda activate base && uvicorn --port 42001 server:app
Traceback (most recent call last):
File "C:\Program Files\Python310\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Program Files\Python310\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "C:\Users\fares\AppData\Roaming\Python\Python310\Scripts\uvicorn.exe_main.py", line 4, in
ModuleNotFoundError: No module named 'uvicorn'

Same

It's solved by adding "uvicorn" to requirements.txt inside of pinokio\api\pcm.git\app


In VSCode F5 not working

Visual Studio Code gives the following message Configured debug type 'coreclr' is not supported.
I have googled it and tried to resolve it but I get no real answer why.

Did you install the C# extension for VS Code and get the debugger extension?

closing it for now based on more information required.


make screenSpaceCameraController zoomFactor public.

Description

This change exposes the zoomFactor property on the ScreenSpaceCameraController, making it public.

This change was originally requested here: https://github.com/CesiumGS/cesium/pull/9145#issuecomment-2276122726
However the original author closed his PR. This is simply implementing his changes again.
This change would allow users to customize the zoom factor of the cesium engine. My main use case is to allow mobile users of my application to have an easier time zooming in and out by changing zoom factor, allowing the pinch-to-zoom gestures to have more drastic zoom changes. The current zoom amount per pinch-to-zoom motion is frustratingly slow.
Issue number and link

https://github.com/CesiumGS/cesium/issues/7978

Testing plan

Add unit tests.
Author checklist

[X] I have submitted a Contributor License Agreement
[X] I have added my name to CONTRIBUTORS.md
[X] I have updated CHANGES.md with a short summary of my change
[X] I have added or updated unit tests to ensure consistent code coverage
[X] I have updated the inline documentation, and included code examples where relevant
[X] I have performed a self-review of my code

Should be good to go!

Awesome, thanks @BeyondBelief96!


🐛 [Bug] UserWarning: acc_tracer does not support currently support models for training. Calling eval on model before tracing.

Bug Description
I got the UserWarning: acc_tracer does not support currently support models for training. Calling eval on model before tracing. even though I had invoked eval on the module.
To Reproduce
import torch
from torch import nn
from torch.nn import functional as F
from torch.nn.parameter import Parameter
from torch_tensorrt.fx import compile

class MyPReLU(nn.Module):
    """FX has no converter for nn.PReLU yet."""
    def __init__(self, num_parameters=1, init=0.25):
        super(MyPReLU, self).__init__()
        self.weight = Parameter(torch.empty(num_parameters).fill_(init))

    def forward(self, input):
        return F.relu(input) - self.weight.reshape(1, -1, 1, 1) * F.relu(-input)

class MyModule(nn.Module):
    def __init__(self):
        super(MyModule, self).__init__()
        self.m = MyPReLU()

    def forward(self, x):
        return self.m(x)

if __name__ == '__main__':
    device = torch.device('cuda')
    input = torch.randn(1, 1, 2, 2, dtype=torch.half, device=device)

    mod = MyModule().eval().requires_grad_(False).to(device).half()
    trt_mod = compile(mod, [input], min_acc_module_size=1, explicit_batch_dimension=True, dynamic_batch=False)

    print(f'\n input: \n {input}')
    print(f'\n output from mod: \n {mod(input)}')
    print(f'\n output from trt_mod: \n {trt_mod(input)}')

Expected behavior
No warning occurs.
Environment

Torch-TensorRT Version (e.g. 1.0.0): 1.3.0
PyTorch Version (e.g. 1.0): 1.13.0+cu117
CPU Architecture:
OS (e.g., Linux): Windows 10
How you installed PyTorch (conda, pip, libtorch, source): pip
Build command you used (if compiling from source):
Are you using local sources or building from archives:
Python version: 3.10.8
CUDA version: 11.7
GPU models and configuration:
Any other relevant information:

Maybe put the lowering processing in with torch.inference_mode(): context?


Improve ROS Docs

Now that our ros packages are official and can be installed with apt-get we should simplify the ros installation instructions.

Done in #714


Investigate zetae2e command ability to bootstrap networks on live networks

Describe the Issue
The zetae2e run --setup-only can currently be used in localnet to just setup the network for running some tests on local.
We should check if the functionality can be extended to directly bootstrap a ZetaChain network connecting to live network external chains.
Eventually we could consider a separate command/alias, like zetae2e init

Would not be


chore: upgrade examples to use runtime v0.2.19

I don't think it's a good idea to include the examples into our monorepo. As you said, we could have 100 examples, and we don't want to install all their dependencies.
I'm leaning toward updating the configuration in the Vercel projects. I think this is a CI problem, so we just need to fix the CI configuration.
I don't have permission to change the build settings in the example project. So either I need to have access to change it, or I need help from someone who can change it 😄

I don't think it's a good idea to include the examples into our monorepo. As you said, we could have 100 examples, and we don't want to install all their dependencies.

👍🏻

I'm leaning toward updating the configuration in the Vercel projects. I think this is a CI problem, so we just need to fix the CI configuration.

👍🏻

I don't have permission to change the build settings in the example project. So either I need to have access to change it, or I need help from someone who can change it 😄

Just added you as an admin of all the example projects

All pipelines passed! Merging this.


Nomad: Hashicorp Changes Official Download Service to Fastly

Thank you for the contribution. It needed some fixes, so they were made in a06304ee2dc51d0da9d0a615e192d1568dac6e58. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Fix argument type mismatching

Looks like there are few types mismatching. This
patch tries to correct them
Signed-off-by: shenjiatong<EMAIL_ADDRESS>

There are bugs in the newer c-for-go that cause these type mis.matches (which is why we pin our version of c-for-go in the docker builds). Please see the following for reference:
https://github.com/NVIDIA/go-nvml/issues/31#issuecomment-981541876


Fix class-dump for newer versions of macos

Building of class-dump fails on newer versions of macos
Last 15 lines from /Users/cass/Library/Logs/Homebrew/class-dump/01.xcodebuild:
/tmp/class-dump-20230528-48669-1q75ezy/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.9 to 13.3.99. (in target 'formatType' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'formatType' from project 'class-dump')
/tmp/class-dump-20230528-48669-1q75ezy/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.9 to 13.3.99. (in target 'all' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'all' from project 'class-dump')
/tmp/class-dump-20230528-48669-1q75ezy/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.9 to 13.3.99. (in target 'deprotect' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'deprotect' from project 'class-dump')
/tmp/class-dump-20230528-48669-1q75ezy/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.9 to 13.3.99. (in target 'MachObjC' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'MachObjC' from project 'class-dump')
** BUILD FAILED **
The following build commands failed:
Ld /tmp/class-dump-20230528-48669-1q75ezy/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/build/class-dump.build/Release/class-dump.build/Objects-normal/x86_64/Binary/class-dump normal x86_64 (in target 'class-dump' from project 'class-dump')
(1 failure)

I am also having the same issue on my m1 pro running macOS 13.4 22F66 arm64 with the latest xcode
`
$ brew install class-dump
==> Fetching majd/repo/class-dump
==> Downloading https://github.com/nygard/class-dump/archive/2c82b4ff12b2ea5d1ac23e49281d496997370841.tar.gz
Already downloaded: /Users/constantijnvanhartesveldt/Library/Caches/Homebrew/downloads/0ec8cacafbf88fbe8ecdcd9d8460878193000e5f23b264f6b012fe475cf306e4--class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841.tar.gz
==> Installing class-dump from majd/repo
==> xcodebuild -configuration Release SYMROOT=build PREFIX=/opt/homebrew/Cellar/class-dump/3.5 ONLY_ACTIVE_ARCH=YES
Last 15 lines from /Users/constantijnvanhartesveldt/Library/Logs/Homebrew/class-dump/01.xcodebuild:
/tmp/class-dump-20230901-2183-1r30bpf/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.13 to 13.3.99. (in target 'formatType' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'formatType' from project 'class-dump')
/tmp/class-dump-20230901-2183-1r30bpf/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.13 to 13.3.99. (in target 'deprotect' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'deprotect' from project 'class-dump')
/tmp/class-dump-20230901-2183-1r30bpf/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.13 to 13.3.99. (in target 'all' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'all' from project 'class-dump')
/tmp/class-dump-20230901-2183-1r30bpf/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/class-dump.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.8, but the range of supported deployment target versions is 10.13 to 13.3.99. (in target 'MachObjC' from project 'class-dump')
warning: ONLY_ACTIVE_ARCH=YES requested with multiple ARCHS and no active architecture could be computed; building for all applicable architectures (in target 'MachObjC' from project 'class-dump')
** BUILD FAILED **
The following build commands failed:
Ld /tmp/class-dump-20230901-2183-1r30bpf/class-dump-2c82b4ff12b2ea5d1ac23e49281d496997370841/build/class-dump.build/Release/class-dump.build/Objects-normal/x86_64/Binary/class-dump normal x86_64 (in target 'class-dump' from project 'class-dump')
(1 failure)
If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
https://github.com/majd/homebrew-repo/issues
These open issues may also help:
Fix class-dump for newer versions of macos https://github.com/majd/homebrew-repo/issues/3
`


Improve diagnostic parsing

I am using embedded MCU compiler in automotive business. We use subset of C defined by MISRA standard. MISRA compatible compilers produce much more warnings than PC world compilers (gcc for example). Some things can not be made MISRA compatible like MCU register description and they reproduce lots of warnings.
In project with I am testing this extension we have 'h' file defining MCU registers and producing around 10 thousands warnings (worst case). This file is included (indirectly) in every 'c' file. Compiler produce this 10 thousands warnings when compiling each 'c' file. Our project is small, around 50 'c' files implementing only MCU drivers, and when compiling with this extension vscode hangs.
Using vscode task with problemMatcher to run cmake build works, quite slow, but no hang.

Current implementation to collect complete cmake out (stout and stderr) and parse diagnostic is quite bad for extreme use cases.
I volunteer to improve this, but maybe somebody need to polish my work (my goal is to get my project compile)

Contributions are very welcome!
This is an interesting problem to solve... Currently, all output is accumulated in a single string and is parsed after the build stops. Some kind of incremental parsing and diagnostic deduplication would be necessary. If you make a pull request, I'll gladly help polish it for inclusion in a future release!

I did some more testing. Hang happens when sending data to OutputChannel. There is also vcode issue for this: https://github.com/Microsoft/vscode/issues/12265

I can't see a reasonable way for me to fix this until that bug is fixed. I think I'll close this until I see a fix on that one, then I'll review this issue.

You can check fix for OutputChannel hangup at:
https://github.com/bbosnjak/vscode-cmake-tools/tree/bugfix/OutputChannel_hangup


One more noname device to support

Look at string that was initially received in on.("fail". I see only imei, date("140903", i did not parse it - it is useless without time), lat, long, and some unknown line "000.51801050.000000000000"

This project is no longer maintained. If anyone wishes to over please tell me in issue #36.


enumerate_arrays doesn't annotate last item in array and comments are badly placed

https://docs.rs/ron/0.6.2/ron/ser/struct.PrettyConfig.html
enumerate_arrays doesn't annotate last item in array:
(
    tags: [
        "asd",// [0]
        "4k",// [1]
        "foo",// [2]
        "bar",// [3]
        "2020",
    ],
    inputs: {
        BufferA: [
            None,// [0]
            None,// [1]
            None,// [2]
            None,
        ],
        Image: [
            Some((
                asset: Misc(Buffer),
                sampler: (filter:mipmap,wrap:clamp,vflip:true),
            )),// [0]
            None,// [1]
            None,// [2]
            Some((
                asset: Misc(Stream),
                sampler: (filter:linear,wrap:clamp,vflip:true),
            )),
        ],
        BufferB: [
            Some((
                asset: Misc(Buffer),
                sampler: (filter:linear,wrap:clamp,vflip:true),
            )),// [0]
            None,// [1]
            None,// [2]
            None,
        ],
        Common: [
            None,// [0]
            None,// [1]
            None,// [2]
            None,
        ],
    },
)

Putting the comment after each item looks weird, especially with large items that span multiple lines.
This part looks very weird:
            Some((
                asset: Misc(Buffer),
                sampler: (filter:mipmap,wrap:clamp,vflip:true),
            )),// [0]
            None,// [1]

Also, it looks weird that there is no space between each item and //.
I suggest putting the comment before each item, so that they are at the same indentation level (thus visually easier to scan), like this:
        Image: [
            // [0]
            Some((
                asset: Misc(Buffer),
                sampler: (filter:mipmap,wrap:clamp,vflip:true),
            )),
            // [1]
            None,
            // [2]
            None,
            // [3]
            Some((
                asset: Misc(Stream),
                sampler: (filter:linear,wrap:clamp,vflip:true),
            )),
        ],

Oh snap, that's a bug. Thank you for filing!


volume rendering up to a certain slice

I was playing around with another cool feature, so I have the following slice view with the volume loader

It would be very cool to be able to combine this with the volumerendering, so that the volumerender only shows up to the the slice indicated by the volume loader slice index (presumably the Yaxis, but any could be fine).
Since the volumerendering is quite heavy on the pc, this would reduce the load and also increase the usefulness, since it can be used to look "inside" certain parts of the scan.
Unfortunately, I'm not very exprienced with threejs/3D in general. But I have tried and look at the AMI code to see what might make this possible;
inside helpers.volumerendering.js the following code
this._uniforms.uDataDimensions.value = [this._stack.dimensionsIJK.x,
                                                this._stack.dimensionsIJK.y,
                                                this._stack.dimensionsIJK.z];

If instead of the true stack dimensions, this was passed the dimensions of the stack up to the slice, and was updated using the lut gui (or whatever other gui) whenever the slice index changed, would that show only the volumerender up to the slice index and not further?

I just tried my previously suggested approach with the following addition to the dat gui
var dimensionSlice = stackFolder.add(vrHelper.stack.dimensionsIJK, 'x', 0, stack.dimensionsIJK.x).step(1);
    dimensionSlice.onChange(function (value) {
        if (vrHelper.stack.dimensionsIJK) {
           vrHelper.stack.dimensionsIJK.x = value;
        }
    });

When testing the vrHelper.stack.dimensionsIJK.x value after changing the slider, it does return the new value, but the volumerender does not update. I'm going to try to expose the function/part of the helpers.volumerendering.js that is needed to recalculate the render and see if that works.

@l0uch3 try updating "vrHelper. uniforms.uWorldBBox.value = value;"
var dimensionSlice = stackFolder.add(vrHelper.stack.dimensionsIJK, 'x', 0, stack.dimensionsIJK.x).step(1);
    dimensionSlice.onChange(function (value) {
        if (vrHelper.stack.dimensionsIJK) {
           vrHelper.stack.dimensionsIJK.x = value;
           vrHelper. uniforms.uWorldBBox.value = vrHelper.stack.worldBoundingBox();
        }
    });

There may be a couple more things to be figured out but could already kind of work :)

@NicolasRannou Thanks for the quick feedback! Much appreciated!
I applied the change you suggested, and it does indeed work! Kind of :P

As you can see, the problem I have now is that the render doesn't show much detail due to being overbright. I'm not sure if that's due to the scan data I'm using (I'm using INCISIX From the osirix library ) or because of some other setting that's not quite right.
Are settings like WW/WL WindowWidth/WindowCenter available for the volumerender? I'm guessing if those were applied to the volumerender in the same way they are applied to the slices, the information would be more clear.

Yes window width/level are available - https://github.com/FNNDSC/ami/blob/dev/src/shaders/shaders.vr.uniform.js#L29-L34
It could also be related to the LUT that you are passing to the VR.helper.
See [opacity] in the VR example: https://fnndsc.github.io/ami/#vr_singlepass
Finally the VR shader will need extra work to support to nicely mix slices/meshes inside the visualization.

I 'like to do so a slice view with the volume loader .I don't know how to start ,how can I do it? Can this part of your code let me refer to it? thank you very much.

@jinchengxiaoge Yes, the code and references above + ami lessons can help you to accomplish the result. Might need some fine tuning though.

Thank you very much.  I have saw the lessons.  I have not succeeded in debugging some of the code. Can you tell me which Part of the code that I should adjust? thank you again.

side note 1: to have the Volume rendering and slices overlay nicely it probably needs some extra passes in the shader.
side note 2: to make the Volume rendering less demanding in term of ressources, consider rendering the scene only when needed (see discussion https://github.com/FNNDSC/ami/pull/72)

@jinchengxiaoge what do you mean a slice view? in 2D or 3D? 1 slice, N slices? Volume rendering or not?

I mean that i'd like to do this

I don't know hoe to do

@jinchengxiaoge sure, that is pretty straight forward - can you open an new issue and detail the problem and what you do not know how to do? so we can continue the discussion there?

ok,

@l0uch3 closing - please re-open if you couldn't get working what you were looking for!


Elm compiler hangs

Running elm 0.17.1 on OSX.
The following (incorrect) code hangs the elm compiler.
type SL comparable = SL (Set comparable) (List comparable)

updateSL : SL comparable -> comparable -> SL comparable
updateSL (SL set list) a =
  if (Set.member a set) then
    SL set list
  else
    SL (Set.insert a set) (list ++ a) -- should be (list ++ [a])

This is the same issue (just for different example code) as https://github.com/elm-lang/elm-compiler/issues/1456. My comment there applies here as well: It's the same issue as #1240, and as such is tracked in #1231.
@evancz, I wonder whether the issue template should contain an additional item of the form:

Compiler hangs? https://github.com/elm-lang/elm-compiler/issues/1240

@z5h, if the issue template had contained such an item, would that have been enough for you to realize yours is a duplicate issue and you do not need to open it as a new one?

@jvoigtlaender 1240 would have helped.


Prisma edge runtime error

Error: Prisma Client is unable to run in an edge runtime. As an alternative, try Accelerate
when I write auth.config,ts file so it's shown me this error

@MuhammadAhsaanAbbasi could you provide more details? What is your Prisma version? Do you get this error locally or on deployment? In the former case, are you using Node.js or other runtime? In the latter case, where are you deploying? Are you using any frameworks, bundlers, etc? It would be very helpful for us to resolve your problem if you could provide the information requested by the bug report template and a reproduction we can run.
Note that if get this error when actually deploying to the edge, it is currently expected as Prisma Client support on the edge is currently work in progress (https://github.com/prisma/prisma/issues/21394). However, given multiple issues opened about this today, I suspect the error might not be expected for you, and we'd appreciate if you could help us provide the information necessary for us to help you.

@MuhammadAhsaanAbbasi Could you try the following version 5.10.0-integration-fix-client-exports-map.11 and let us know if that fixes the issue?
(Note: related to https://github.com/prisma/prisma/pull/22880)
This will be part of the official 5.9.1 patch release soon.

https://github.com/prisma/prisma/releases/tag/5.9.1 is now available with the fix ✨
Please create a new issue if you find a bug.

@MuhammadAhsaanAbbasi Could you try the following version 5.10.0-integration-fix-client-exports-map.11 and let us know if that fixes the issue?
(Note: related to #22880)
This will be part of the official 5.9.1 patch release soon.

I Don't try this version bro

@MuhammadAhsaanAbbasi could you provide more details? What is your Prisma version? Do you get this error locally or on deployment? In the former case, are you using Node.js or other runtime? In the latter case, where are you deploying? Are you using any frameworks, bundlers, etc? It would be very helpful for us to resolve your problem if you could provide the information requested by the bug report template and a reproduction we can run.
Note that if get this error when actually deploying to the edge, it is currently expected as Prisma Client support on the edge is currently work in progress (#21394). However, given multiple issues opened about this today, I suspect the error might not be expected for you, and we'd appreciate if you could help us provide the information necessary for us to help you.

Brother  I use latest version and I get this error on locally currently I stop my project and using node js and want to deploy on vercel and Next.js framework is using


img_ops_jit_compile test is passed now

XLA JIT can launch gpu without any problem at the latest weeklysync.

I would be good to bisect which commit fixed it.


New! State website alerts during emergencies

From Jonathan Porat, Chief Technology Officer

Good afternoon AIOs and CIOs:
As we prepare for the next emergency response, the State is implementing a new tool developed by the California Department of Technology (CDT) and GovOps Agency to communicate vital emergency information to the public on state websites.
Unlike past years -- when we’ve needed help from you and your web teams to place emergency messaging for Californians on your sites -- this new tool is automated. Once your Agency and departments opt-in (working with CDT to add code to your site), the emergency messaging – when approved and authorized by the JIC and GO -- will appear automatically on your website to help communicate critical information to the public, and it will come down when no longer needed.
To see how these “State Department Website Emergency Alerts” will look and find instructions on how to participate in this critical system, check out the third item on the attached. Please contact CDT’s Technology Innovation Services Manager Surendra Chenneerappa<EMAIL_ADDRESS>to answer any technical questions, and CC me (Jonathan.Porat@state.ca.gov). I am available to answer any questions and concerns.
Thank you for your support for this new effort to ensure uniform, timely messaging across state websites during emergencies.

Attachments:

GovOps Emergency Communication Tools incl State Website banners - 7 26 23.docx
Technical-doc-State-Deparment-Website-Emergency-Alerts.pdf
web-alerts-presentation-march-2023.pptx

Pull requests created for
abortion.ca.gov
drought.ca.gov:
cannabis.ca.gov
covid19.ca.gov
innovation.ca.gov


Functions signature for autocompletion

This is not really issue-worthy, but I don't really see how to tackle this. cmake-ide is working fine so far, but my autocompletion (with auto-complete) is quite bland, there's no method signature for example, only the name of the function.
How do you get function signature for your autocompletion, using cmake-ide ? (similar to what was shown on your presentation)

I was using company-mode during the presentation, you can always try that.

Oh you're right, thanks a lot, seems that company now displays the signature which is great, unlike auto-complete.
However, two quick last questions (and sorry for being off-topic) :

The signature of the function is displayed in the company tooltip and at the bottom of Emacs, however as soon as I press enter to validate the completion (and as I start typing in the arguments themselves), this information disappears. Would it be possible to keep it somewhere on the screen ?
Aside from a problem with one of my libraries (for some reason flycheck doesn't find the header although it compiles just fine), I can't get completion for OpenGL (which is my main goal right now). The headers are fine but there's no autocompletion whatsoever. When I enable functions-args-mode and try a completion for the first time semantic takes a loooong time indexing and browsing files, so I assume it's looking for OpenGL, but once it's done I get no autocompletion at all. Any idea ?

Clang does that sometimes for headers and I don't even know what's going on there. As for function signatures, that's up to company-mode. I've seen yasnippet used for this as well in another project.


DBZ-6788 Add documentation for mongodb.authentication.class property

@jcechace @jpechane

@nirolevy Merged. Thanks for contributing also the docs.


Patch src before build?

Since the BeagleBone Black having support for ethernet/serial over the usb cable, I'd like crochet to patch the src tree to enable this support. It is really a small patch:
Index: usb/usb_device.c
===================================================================
--- usb/usb_device.c    (revision 287099)
+++ usb/usb_device.c    (working copy)
@@ -112,6 +112,8 @@

 /* This variable is global to allow easy access to it: */

+#define        USB_TEMPLATE USB_TEMP_SERIALNET
+
 #ifdef USB_TEMPLATE
 int    usb_template = USB_TEMPLATE;
 #else

Any thoughts on implementing something like this?
My concern is if someone is building from /usr/src we don't want to go changing that on them.. but we could detect if the source tree is /usr/src and revert the patch after the build?

Crochet should never patch the FreeBSD source tree.
You should send your suggested change to the FreeBSD developers and see about getting it adopted there.  (It may just involve a simple change to the BeagleBone kernel configuration.)

Currently it cannot default to on in the main tree. What about having Crochet manage its own tree?

Create a patch for freebsd-head that adds that as a kernel-time build option. It should be pretty trivial to do. Like, it should one line in an options file, and one line in a kernel config file.
Done aaaaand done.

.. also, since it's assigning some value to an int, you can also likely make it a boot time tunable, which also means it can just be customised into /boot/loader.conf - that's something crochet can also do.
If you'd like some help on doing this then please let me know and grab me on irc. :)


Start playing live stream with certain offset from edge

Hello,
is there a way to start playing the video for example 3600 seconds behind the live edge? I know there is the player.load(manifestUri, opt_startTime) method but the opt_startTime would have to be offset from the manifest start. But in our case, we can never know what is the exact length of the captured timeshift, we just know that we want to play live edge - 3600 seconds.
Until now, I was using player.load(manifest) and then seek back using video.currentTime = video.currentTime - liveOffset in video.ontimeupdate event. It works however the downside is that the player first loads the live edge and only then it seeks (the customer sees the live edge, then buffering and only then the desired video).
Is there a way to start playing immediately from the offset that we need?
Thank you

Not yet, but this is a duplicate of #1178.


Missing license files

The project is dual licensed under MIT + Apache licenses but the repository contains no related files.
e.g. this is needed for distro packagers to include the license file in the cargo-show-asm package.
Please consider adding license files - you can check out this repo for an example.

Added. Maybe clippy or cargo should complain about that at some of the more pedantic settings. Or something around "how to publish a crate documentation" should mention it.

Yeah I agree. I think cargo clippy warns about missing license field if you deny clippy::cargo but not for the actual license files.
Can we get a new release along with this change? 🐻

Can we get a new release along with this change? 🐻

Yea, I'll try to make one soon-ish.

I released 0.2.22 (#218)


fix(docs): incorrect snippets

Summary
@togami2864 noEmptyBlock snippet fails, please fix it whenever you can
@minht11 a snippet is failing, it's not returning any diagnostics. Please fix it
@chansuke next time, please make sure that the code blocks are correct. Also, one of the code snippets didn't emit diagnostics. Please fix it
@fujiyamaorange please, next time make sure to put valid code inside the snippets

Test Plan
Merge it. It will fix the website

The code that checks that is in the website repository for now. We plan to bring it back here. You should run cargo run -p codegen rules.
Anyway, the cases that are failing aren't inside the tests, so we should at least make sure that we use invalid cases that are covered by our tests.
We have import "./foo'/"; but not import "./foo";


Include underlying TypeScript types into the API Documentation

The current API Documentation, which is generated automatically using jsdoc2md, doesn't include the underlying types.
For example,

It is not clear what the DiffOutputItem "looks" like.
The reason:
JSDoc2md does not include TypeScript types when it looks into JSDoc comments, or rather, It doesn't find the typescript types when generating the documentation.
Request:
We want the underlying TypeScript types to be present inside the auto-generated API documentation.
The output will depend on how jsdoc2md parses the types. One can look into jsdoc2md documentation to see how to parse the TypeScript types :)

Thank you! Will definitely do reach out if I struggle with it - will try to provide an overall response by this weekend :)

@Ishmam156 are you still trying to solve this? If not I would like to take a shot at it as well, if that's fine with you @aayushmau5

@ron-debajyoti sure, go ahead. Though I did try to fix this issue, but I did not succeed, and to be honest, I don't think this can be done without more configuration and including additional JSDoc comments.
But feel free to give your take, and see what you can come up with. Otherwise I will close this issue.

But feel free to give it a try, and see what you can come up with. Otherwise, I will close this issue.
Give me 2 days nad I will update the status by then @aayushmau5

@ron-debajyoti Thank you so much for taking this up! I honestly tried following the current instructions of JSDoc but just couldn't get this to work - ofcourse might have missed something so good luck to you! :)

Hey @aayushmau5 ,
I was looking into this and idk maybe this might be leading somewhere and thought to give you an update.
I think one root cause for this problem is that the compiled js obtained after build/tsc can't resolve types. You can try it out yourself by first running the build and then checking out any jsdoc comments in  lib/asyncapidiff.js, for example, and they point to unresolved/any.
To solve this I changed the syntax of jsdoc comments. Taking the above example, I tried changing  @returns {Array<DiffOutputItem>} to @returns {Array<import('./types').DiffOutputItem>} in  src/asyncapidiff.ts. This solves the above problem, but then jsdoc2md got issues parsing this tag.
I'm still gonna try looking into it. Let me know your views on this.


MAINT: Remove fortran fftpack library in favour of pypocketfft

Reference issue
Fixes gh-1739, fixes gh-2233, fixes gh-2629, fixes gh-3528
Closes gh-10488
What does this implement/fix?
This removes most of scipy.fftpack's code in favour of calls to scipy.fft._pocketfft. Additionally, this:

adds a wrapper to _pocketfft for the r2r_fftpack function
rewrites fftpack.convolve in cython so it can call pypocketfft instead of fortran FFTPACK
Reorganizes helper functions so that scipy.fft never imports from fftpack

From Travis:

ERROR: objects in scipy.fftpack.convolve.all but not in refguide::
r2r_fftpack

Should be private?

Are there any performance gain to using convolve from pypocketfft?
At the moment I use np.convolve for linear convolution of two ~1000 element arrays, but am wondering if I can get a speed boost somewhere. I seem to remember that np.convolve was faster than the scipy convolution functions, but perhaps this has changed now.

Are there any performance gain to using convolve from pypocketfft?

I wouldn't recommend using fftpack.convolve. It's really just an implementation detail of fftpack's pseudo-differential operators and shouldn't have been public. It may even be deprecated soon.

I seem to remember that np.convolve was faster than the scipy convolution functions, but perhaps this has changed now.

It seems that signal.convolve has some serious overhead somewhere. Using the convolution theorem directly gives a 5x speedup:
In [5]: %timeit np.convolve(x, y)
151 µs ± 2.87 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)
In [6]: %timeit signal.convolve(x, y)
201 µs ± 5.55 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)
In [7]: %timeit fft.irfft(rfft(x) * rfft(y), len(x))
39 µs ± 1.84 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)

I'll have a look into this as it might be similar to #10490

There do not appear to be direct tests for those functions, but that was also the case prior to this PR. They do get tested indirectly via fftpack/tests/test_pseudo_diffs.py.

The tests in test_pseudo_diffs are also definitely written to exercise the corner cases of convolve. e.g. odd and even sized inputs.

First of all, thanks a lot @peterbell10 for your great work!
Concerning FFT convolution, I think that there is still room for optimization, in a lot of different situations. For example, a fairly typical case is probably convolving a (large) 2D image with a (small) kernel. If I read signal.fftconvolve correctly, both arrays are brought to the same size, FFT'd, multiplied and then transformed back. Using many smaller, overlapping transforms may be much faster, for example.

In [7]: %timeit fft.irfft(rfft(x) * rfft(y), len(x))

Keep in mind this will be a circular convolution, if you want equivalence with the convolve code you need to zero pad:
n = len(x) + len(y) - 1
%timeit fft.irfft(rfft(x, n) * rfft(x, n), n)

But even with this it's possible that signal.convolve is slower due to some overhead that could be avoided, I haven't looked.

Are there any performance gain to using convolve from pypocketfft?

Agreed with @peterbell10 about fftpack's convolve function, it's not meant for public use. scipy.signal.convolve function triages between doing time domain convolution and frequency domain multiplication, but see #10427 where we talk about needing to update it now that we use scipy.fft's pocketfft instead FFTPACK.

Concerning FFT convolution, I think that there is still room for optimization, in a lot of different situations. For example, a fairly typical case is probably convolving a (large) 2D image with a (small) kernel. If I read signal.fftconvolve correctly, both arrays are brought to the same size, FFT'd, multiplied and then transformed back. Using many smaller, overlapping transforms may be much faster, for example.

There is a mailing list post about overlap add convolution. It would indeed be nice to have. It is also in issue form in #1364 but the discussion there is limited.

Keep in mind this will be a circular convolution, [...]
But even with this it's possible that signal.convolve is slower due to some overhead that could be avoided

I had noticed that from looking at the code and yes, there's still considerable overhead compared to doing the ffts yourself
n = len(x) + len(y) - 1
N = fft.next_fast_len(n)
%timeit fft.irfft(rfft(x, N) * rfft(x, N), N)[:n].copy()
# 72 µs ± 2.29 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)
%timeit signal.fftconvolve(x, y)
# 185 µs ± 1.29 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)

I don't think there is any problem with removing this code, but out of an abundance of caution @peterbell10 can you email the scipy-dev listserv letting people know we plan to remove this old Fortran code? Then I'll plan to merge Monday or Tuesday, barring any complaints.

Thanks @peterbell10 ! Now onto some fun rebases :)

I've added a small release note:
scipy.fftpack now uses pypocketfft to perform its FFTs, offering the same speed and accuracy benefits listed for scipy.fft above but without the improved API.

Looks good to me


(613) Puppet Node Graph Feature Rewrite

This commit replaces the viz.js Node Graph Vizualizer with a
cytoscape.js based version. All existing command ids and workflow were
kept, only the presenation logic was changed.
The cytoscape.js module is a full featured data vizualizer that allows
us to display the puppet node graph in a multitude of formats and
presentations. While this commit only replaces existing functionality,
cytoscape has alot of potential for displaying the node graph in
interesting formats since it was designed to handle very large
scientific data sets.
The latest version of the viz.js module changed it's api to a pattern
we could not use reliably in the async language server call, and the
proejct itself has been archived in github and there hasn't been a new
version in several months.
Fixes #613

Is this ready for merge?


Empty section data cleanup

I just implemented this. I'm not a huge fan of how I did it, but it works. Right now, I'm passing the whole data object down into the sectionList, which is unnecessary, all we really need to know is the list of items and whether they have any rows.

@brokentone could u provide a PR to handle this case?


Bug: Creating space with name that already exists blocks creation. No error message.

Steps to reproduce:

Create a space with name "test"
Create a second space with name "test"
When clicking "Save Changes" nothing happens

But: I can create a space with a name that another user has already created. This is good.

Checked this by looking at the db and creating the same:

should be handled by a1a3b85

Error message now arrives in frontend but nothing is displayed:

should now work


Error in part 5 - Section I - Preparatory work

https://github.com/Plailect/Guide/wiki/Part-5-(arm9loaderhax-&-AuReiNand)
Says:Copy MiniPasta.3dsx and MiniPasta.smdh to the /3ds/ folder on your SD card
When it should say: Create a folder called MiniPasta inside of the /3ds/ folder and copy MiniPasta.3dsx and MiniPasta.smdh to the /MiniPasta/ folder on your SD card

It can be placed directly in the folder.

Well, putting the SMDH there is pointless then..


Dobble response

Describe the bug
onPlayEnd dobble posts when a track has ended, not 100% sure why this is.

Please follow the template.


AWS SDK's Code Analyzers change target to .NET Standard 2.0

We are in the process of rebuilding our SDK's build infrastructure. As part of that we need to change the SDK's code analyzers to target .NET Standard 2.0 so we can build them on Linux. This is important to get our build times of the entire SDK to an acceptable level for our daily release cycle.
Recently we released a version of the SDK updating the target to .NET Standard 2.0. This changed caused a new compiler warning for environments that did not have Visual Studio 2022 version 17.6 installed. The warning was caused because the retargeting change involved a package reference of Microsoft.CodeAnalysis version 4.6.0 which requires Visual Studio 2022 version 17.6. For build systems that treat warnings as errors this caused a build break. The new warning was unintended and we reverted the change of targeting .NET Standard 2.0 for the code analyzers. Below is the reported GitHub issues.

https://github.com/aws/aws-sdk-net/issues/2989
https://github.com/aws/aws-sdk-net/issues/2990

Within the next week or so we will make the change to .NET Standard 2.0 again using the following process which matches what we see in other community code analyzers.

Update all code analyzers projects to replace the target framework from .NET Framework 4.5 to .NET Standard 2.0
The Microsoft.CodeAnalysis reference will be set to 3.0.0 which makes Visual Studio 2019 RTM the minimum for the analyzers to work
All versions of the SDK packages will be set to 3.7.200 to make it easy to identify when this happen. We are not updating to 3.9 because minor version bumps require significant effort and coordination across many products. Since the runtime SDK isn't changing the effort doesn't seem warranted.
The change log will explicitly call out this change for version 3.7.200

Users using Visual Studio 2017 or older can still continue using the SDK but they will get warning CS8032 for the code analyzers failing to run. You will need to either ignore or suppress the warning.
We will also be updating the SDK's GitHub README file with a new section about the code analyzers, documenting our supported VS targets for the code analyzers and what to do if you are using older tooling.
@oshea00, @slang25, @martincostello, @KevinD-87, @pablogdnd, @PeterBenko - You all commented on the issues when we first attempted this. I would really appreciate hearing your feedback on this approach and any concerns you have.

Sounds good - knowing what the root cause was and knowing the 17.6 requirement should be enough for us 👍

We just released the Code Analyzer target change to .NET Standard 2.0. As Norm discussed on the announcement, we:

Updated all SDK packages, including Core, to version 3.7.200 (https://www.nuget.org/packages/AWSSDK.Core/3.7.200 and https://www.nuget.org/packages/AWSSDK.S3/3.7.200)
Added a new section about Code Analyzers support on the README file (https://github.com/aws/aws-sdk-net#code-analyzers)
Called out the change in the CHANGELOG file (https://github.com/aws/aws-sdk-net/blob/master/changelogs/SDK.CHANGELOG.2023.md#376000-2023-18-07-0000-utc)

Please let us know if you see any issues.


New bar sign

About the PR
Adds a new Bar Sign: Whiskey Echoes.
Made by CerebralError on Discord.
I had to add it directly to the barsign.rsi but at least the .yml part of it is cosy in the Nyano folders :)
Media

https://user-images.githubusercontent.com/9823203/232250374-a8e2bd16-3be4-4b53-8da7-c622c7364439.mp4

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: CerebralError

add: Added a new bar sign.

Very nice sign.


Panic on azure blob storage state store

Expected Behavior
Invalid Azure storage account name does not cause a panic and gives proper error message.
Actual Behavior
Providing an invalid Azure storage account name to Azure storage state store causes panic.

Steps to Reproduce the Problem
Use azure blob storage state store with an invalid account name
Release Note

RELEASE NOTE:

@Gehhilfe can you please comment here with /assign? Thanks!

/assign


[DOCS] In online documentation, the request option connect_timeout still says that the default value of 0 waits indefinitely, which was never true

https://docs.guzzlephp.org/en/stable/request-options.html#connect-timeout
This actually threw me off initially because I always thought that the default was exactly that: to wait indefinitely. I didn't know that the actual default was 150 seconds previously, which got changed to 300 seconds recently to match curl.
Speaking of connection timeouts, I ran into a rather strange issue where previously with an older Guzzle 6.3.3, I had no issues making calls to a 3rd party storage service (Google Cloud Storage). Immediately after upgrading to 7.8.0, I started seeing intermittent "cURL error 35: TCP connection reset by peer" errors. This is when I found the connect_timeout difference between the 2 versions as I was investigating, so I forced my guzzle code to include a "connect_timeout: 150" seconds config just to mimic previous behavior and the ConnectException errors stopped. This is outside of the scope of this issue report, but I just found it odd since I would think decreasing the connection timeout should actually lead to more ConnectExceptions (if it was a connection issue) instead of eliminating it altogether.

I believe we can consolidate this in Guzzle 8.

Actually, I believe the docs are out of date. The docs in the repo are right, but the website build seems old... which is something I need to look into.

See https://github.com/guzzle/guzzle/blob/7.8/docs/request-options.rst#connect_timeout.


"Ticking" structure for FB Messenger

Hello there, thanks for this awesome lib! :)
I just want to understand why you guys chose to have this "second-by-second" ticking system, instead of having them called whenever an action occurs, like receive and send a message.
This ticking system will consume memory and will keep open until a users finishes the conversation :(
So, why this ticking for? Isn't there a better and more fast (even more scalable) way of doing this?
PS.: I've managed to "bypass" the ticking system by adding botkit.tick(); on lines 821 and 876.
Looking forward to hear from you guys!
Best,
Rafa

maybe... this functions as a "keep-alive."
nevertheless, I agree with you.

as using this library i realised its a "good way" to keep messages sending in the correct order inside a conversation.
however there is no handling for "killing" the ticking after a conversation ends.
so i hat to implement o start the ticking when a message is received and stop the ticking after a conversation ends, or 2 minutes without activity.
i'll try to improve that later an then ill do a pull request here

Too bad this was closed without an official word on the topic from the original framework creators.
This should also be explained in the docs.
Can we reopen this or create an issue to have this added to the docs?

@jay-at-avido sure i'll reopen and mark as a feature request!

I'll address this finally!
The ticking is what allows botkit to send multiple outgoing messages as part of a conversation. Each tick of the loop, Botkit evaluates all active conversations and takes the next appropriate step.  Without the tick, there is now ay for Botkit to work its way through these message queues.


Update to JDK 17

Update JDK to 17
Update JavaFX to OpenJFX 19
Update JUnit to 5.9
Update MD5 logic to use Apache Codecs instead of (wrongfully) using some internal library
Update code to use JDK 17 featues (enhanced switch, ...)

I think we should configure our CI/CD in a way that Sonar's quality gate does not break our builds 🤔


Add WAR space

Add space for WAR
Etherscan: https://etherscan.io/address/0xf4A81C18816C9B0AB98FAC51B36Dcb63b0E58Fde
CoinGecko: https://www.coingecko.com/en/coins/yieldwars
Website: https://www.yieldwars.com
Twitter: https://twitter.com/YieldWars

We have updated all the spaces.  Please follow the updated documentation https://docs.snapshot.page/guides/create-a-space


fix: fix win32 detection

Introduce a util function to check for win32 in vim.fn correctly
Replace all checks for win32 with the new function

Can you post :lua =vim.fn
Then we can make a more robust check

@ww-daniel-mora what do you mean? literally give the output of :lua = vim.fn? that's this:
{
argc = <function 1>,
bufadd = <function 2>,
bufload = <function 3>,
bufloaded = <function 4>,
bufname = <function 5>,
bufwinid = <function 6>,
bufwinnr = <function 7>,
col = <function 8>,
confirm = <function 9>,
environ = <function 10>,
escape = <function 11>,
executable = <function 12>,
execute = <function 13>,
exepath = <function 14>,
exists = <function 15>,
expand = <function 16>,
filereadable = <function 17>,
fnameescape = <function 18>,
fnamemodify = <function 19>,
foldclosed = <function 20>,
foldclosedend = <function 21>,
getbufinfo = <function 22>,
getchar = <function 23>,
getcharstr = <function 24>,
getcmdline = <function 25>,
getcmdpos = <function 26>,
getcmdtype = <function 27>,
getcmdwintype = <function 28>,
getcompletion = <function 29>,
getcurpos = <function 30>,
getcursorcharpos = <function 31>,
getcwd = <function 32>,
getenv = <function 33>,
getftime = <function 34>,
getline = <function 35>,
gettabinfo = <function 36>,
glob = <function 37>,
has = <function 38>,
hlID = <function 39>,
hlexists = <function 40>,
indent = <function 41>,
inputlist = <function 42>,
isdirectory = <function 43>,
jobstart = <function 44>,
jobstop = <function 45>,
jobwait = <function 46>,
json_decode = <function 47>,
json_encode = <function 48>,
line = <function 49>,
localtime = <function 50>,
maparg = <function 51>,
mapcheck = <function 52>,
match = <function 53>,
matchlist = <function 54>,
mkdir = <function 55>,
mode = <function 56>,
nextnonblank = <function 57>,
prevnonblank = <function 58>,
prompt_setprompt = <function 59>,
pumvisible = <function 60>,
reg_executing = <function 61>,
reg_recording = <function 62>,
screencol = <function 63>,
screenpos = <function 64>,
screenrow = <function 65>,
setenv = <function 66>,
setwinvar = <function 67>,
sha256 = <function 68>,
shiftwidth = <function 69>,
sign_define = <function 70>,
sign_getdefined = <function 71>,
sign_getplaced = <function 72>,
sign_placelist = <function 73>,
sign_unplace = <function 74>,
split = <function 75>,
stdpath = <function 76>,
strcharpart = <function 77>,
strchars = <function 78>,
strdisplaywidth = <function 79>,
strftime = <function 80>,
strlen = <function 81>,
substitute = <function 82>,
synID = <function 83>,
synIDattr = <function 84>,
synIDtrans = <function 85>,
synstack = <function 86>,
tabpagenr = <function 87>,
tempname = <function 88>,
toupper = <function 89>,
virtcol = <function 90>,
win_findbuf = <function 91>,
win_gettype = <function 92>,
winheight = <function 93>,
winlayout = <function 94>,
winrestview = <function 95>,
winsaveview = <function 96>,
 = {
__index = <function 97>
}
}

Thank you @WillEhrendreich that's exactly what I wanted. That has check is always returning true and "win32" is obviously not a meaningful thing to check on anyways since it does not show up in your vim.fn table either. Let me see if we determine platform another way and update the check.

I asked in you pr as well but can you post the output of this call as well
:lua =vim.loop.os_uname().sysname


Fix the main composer not regaining focus after action is deleted

Details

Fixes https://github.com/Expensify/App/issues/28420. Somehow there is a useState and a useRef used to keep track of the focus state of the component. Some refactoring happened on https://github.com/Expensify/App/pull/27190, on which the function was wrapped in a useCallback, which now causes it to retain an incorrect value.
I simply got rid of the useRef and replaced it with the useState flag.
Fixed Issues

$ https://github.com/Expensify/App/issues/28420
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/1634213/545005c5-b479-4148-9e25-272b3e4a65ae

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@techievivek @s77rt @s-alves10 can you take a look at this. Maybe it is necessary to revert the PR.

I've just checked the PR and this issue doesn't exist. Maybe there is another reason. Let me investigate


[App Configuration] Execute Samples failing in nightly runs

App Configuration nightly test runs are failing with:

Stack trace:
Failed to run sample: RestError: {"type":"https://azconfig.io/errors/too-many-requests","title":"Resource utilization has surpassed the assigned quota","policy":"Total Requests Short Term","status":429}
{
"name": "RestError",
"statusCode": 429,
"request": {
"url": "***/kv?api-version=1.0&key=REDACTED",
"headers": {
"accept": "application/vnd.microsoft.appconfig.kvset+json, application/json, application/problem+json",
"accept-encoding": "gzip,deflate",
"user-agent": "azsdk-js-app-configuration/1.4.0-beta.1 core-rest-pipeline/1.10.1 Node/v14.21.1 OS/(x64-Windows_NT-10.0.17763)",
"x-ms-client-request-id": "17f3a381-bccd-40d9-af15-ac23f30693ee",
"sync-token": "REDACTED",
"x-ms-date": "REDACTED",
"x-ms-content-sha256": "REDACTED",
"authorization": "REDACTED"
},
"method": "GET",
"timeout": 0,
"disableKeepAlive": false,
"streamResponseStatusCodes": {},
"withCredentials": false,
"tracingOptions": {
"tracingContext": {
"_contextMap": {}
}
},
"requestId": "17f3a381-bccd-40d9-af15-ac23f30693ee",
"allowInsecureConnection": false,
"enableBrowserStreams": false
},
"details": {},
"message": "{"type":"https://azconfig.io/errors/too-many-requests","title":"Resource utilization has surpassed the assigned quota","policy":"Total Requests Short Term","status":429}"
}

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2066482&view=results

Thanks @v-jiaodi, for reporting.
Assigning @minhanh-phan for this.


ERC20 / ERC827 - / ERC721

🚀 Feature Request
ERC20 / ERC827 - / ERC721
Taking as an example the standards created in Ethereum.
I understand the need for the creation of standards for the generation of specific tokens.
A model similar to ERC20 has already begun to circulate, but what would be really good would be to take advantage of the improvements that were made in the ethereum network and provide these tokens with functionalities.
Motivation
https://github.com/ethereum/eips/issues/827
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md
But before fully implementing this standard, I have noticed that certain security features may compromise security. I need help for the safety analysis and I will put my hands to work on this standard.

We now have the DIP20 for Diem currencies: https://github.com/diem/dip/blob/main/dips/dip-20.md


Vendoring libnetwork @802895f

Fixes #29829

this one's for master, and cherry-picked into 1.13.1 through https://github.com/docker/docker/issues/30692

@aboch I think this PR also fixes #30609


different attributes in GRCh37 vs. GRCh38 catalogs

A few more details that might need some clarification:
These 4 loci have different NormalMax values in 37 vs. 38 (and ATN1 also has different PathologicMin):
ATN1 35 34
DMPK 34 37
FMR1 55 65
TBP 40 44

These loci have differing LocusStructure (even though DisplayRU is the same):
TBP (CAN)* (GCA)*
NIPA1 (NGC)* (GCG)*

TBP locus GRCh38 coordinates match the EHv4 catalog coordinates (https://github.com/Illumina/ExpansionHunter/blob/master/variant_catalog/hg38/variant_catalog.json#L499)
but the GRCh37 coordinates don't match the EHv4 catalog (https://github.com/Illumina/ExpansionHunter/blob/master/variant_catalog/hg19/variant_catalog.json#L260)
The situation is the same for NIPA1.

Thank you kindly! Most is just lack of proofreading, but e.g. TBP and NIPA1 appear connected to incomplete merging in of the loci from ExpansionHunter as they are tested and added. We would as a general rule always try to keep the ExHu ones if they exist, for best compatibility and most testing. Note the eg tendency for us to be biased by the established clinical repeat unit in delimiting the units. And the lack of a scripted comparison test for liftOver operations. 😬

Again, thank you for the feedback. I have added a couple of validation scripts that will help keep the number of variant catalog genome build out of sync mistakes down. The off-by-one 0-based start to appear a common theme as well, so I will have to go on a separate ob1-hunt with REViewer. The usual effect is just an ugly gap in the alignment between the last anchor base and the first graph model one, but why not get it right. I will call it a night now before I make more mistakes. Cheers!


Adds support for options.finishInit to CodeMirror.fromTextArea

This allows options.finishInit to work in a more consistent manner, even when running CodeMirror.fromTextArea()
Although this is an undocumented feature, it's quite useful and it would be good to know that this works consistently.

finishInit is an internal hack, not a documented feature. What are you doing with it?

I'm using it to ensure I have a reliable callback for when the CodeMirror UI has finished initializing. I have several instances on a page and I'm using Promises to ensure they're all initialized before running further operations.

Why not just define a wrapper function that initializes an editor and then calls your callback?

Like this?
function initializeCodeMirror(callback) {
  var instance = CodeMirror.fromTextArea(textarea, options);
  if (typeof callback === 'function') {
    callback(instance);
  }
}

initializeCodeMirror(function(){
  console.log('CodeMirror UI initialized!');
});

Well, if you're explicitly providing the callback to the function, you might as well just call it directly when initializing the editor. I.e. where you used to have finishInit: ... in your code, you could just do whatever was in there after creating the editor, no?

Are you suggesting A or B from below? A, I assume?
A
function initializeCodeMirror(callback) {
  var instance = CodeMirror.fromTextArea(textarea, options);
  console.log('CodeMirror UI initialized!');
}

initializeCodeMirror();

B
function initializeCodeMirror(callback) {
  var instance = CodeMirror.fromTextArea(textarea, {
    finishInit: function () {
      console.log('CodeMirror UI initialized!');
    }
  });
}

initializeCodeMirror();

I really don't care how you do it, I'm just not seeing the value in using this option.

I wanted to understand what you had in mind and compare my understanding of it.
Case A calls the function too early because the UI has not been fully initialized yet. The instance object is created, but the UI initialization hasn't completed.
options.finishInit helps in calling back at the correct time, after the UI initialization is complete. However,  in Case B above, the callback doesn't work because CodeMirror.fromTextArea overrides the configured callback.

Case A calls the function too early because the UI has not been fully initialized yet

That's not true—CodeMirror initializes synchronously.


upload file by swagger

I want to upload a file by swagger, but don't know how to use @doc.consumes define a file type
like this..
@doc.consumes({"myfile": '',},location="multipart/form-data")`

Hi @yangmingbai
Please install sanic-openapi from master branch and try this:
from sanic import Sanic
from sanic.response import json

from sanic_openapi import doc, swagger_blueprint

app = Sanic()
app.blueprint(swagger_blueprint)

@app.post("/test")
@doc.consumes(
    doc.File(name="file"), location="formData", content_type="multipart/form-data"
)
@doc.produces({"size": doc.Integer(), "type": doc.String()})
async def test(request):
    file = request.files.get("file")
    size = len(file.body)
    return json({"size": size, "type": file.type})

The swagger will look like:

I'm going to close this issue. Feel free to add more feedbacks or reopen this issue if need.


setup.py leaves  build, dist, .egg-info  etc  + even clean doesn't remove them

By default, setup.py leaves build, dist, ${project_name}.egg-info directories in a projects directory.
I'm not convinced these need to be here these days, certainly feels messy to have these.
Putting all this output into one directory would be some improvement.   But maybe there's a better solution ?
python setup.py clean doesn't even delete these without adding hacks.

I end up putting this in every setup.py
class CleanCommand(Command):
    """Custom clean command to tidy up the project root."""
    CLEAN_FILES = './build ./dist ./*.pyc ./*.tgz ./*.egg-info'.split(' ')

    user_options = []

    def initialize_options(self):
        pass

    def finalize_options(self):
        pass

    def run(self):
        global here

        for path_spec in self.CLEAN_FILES:
            # Make paths absolute and relative to this path
            abs_paths = glob.glob(os.path.normpath(os.path.join(here, path_spec)))
            for path in [str(p) for p in abs_paths]:
                if not path.startswith(here):
                    # Die if path in CLEAN_FILES is absolute + outside this directory
                    raise ValueError("%s is not a path inside %s" % (path, here))
                print('removing %s' % os.path.relpath(path))
                shutil.rmtree(path)

I've made good headway with setupext-janitor starting from @ionelmc's fork https://github.com/ionelmc/setupext-janitor which fixes namespace. There's a blocking issue though on Windows, ... clean --dist exits early with "error: don't know how to create RPM distributions on platform nt" (https://github.com/dave-shawley/setupext-janitor/issues/12). I'll post progress there as I can, label:help-wanted though as I'm out of my depth. ;-)

It might be worth opening a PR marked WIP so we can easily see the changes.

@stuaxo Sorry, I don't follow. A PR here in setuptools?
I've identified where the error occurs in setuptools now, but don't know how to proceed. https://github.com/dave-shawley/setupext-janitor/issues/12#issuecomment-461567765

Sorry for the noise, was replying on my phone in a hurry :)

I've got setupext-janitor working and issued a PR to the base master https://github.com/dave-shawley/setupext-janitor/pull/14

It would be very nice if the behaviour of clean in setuptools could be improved; the current behaviour is really annoying IMHO. @maphew's updated version of setupext-janitor works nicely (thanks!). However, the original owner/maintainer (@dave-shawley) doesn't seem to be much interested any more (?), unfortunately.
Is there a chance to get the patched version released on Pypi somehow? Or even be integrated into setuptools properly?

Rather than trying to clean up files from the source directory, would it be better to be able to do out-of-source package builds? Something like this: cd /tmp/build && python /path/to/setup.py. That way those generated files never touch the source directory in the first place.

@cmarquardt these and other recent comments have woken up setupext-janitor and a recent version has been published to pypi. @dave-shawley wasn't receiving notifications and didn't know there was any interest or significant downstream use.
@gary-jackson are you suggesting this be something setup.py does automatically or as documenting best practice instructions?

Not speaking for @gary-jackson but I'd like it to do this automatically, not sure if it will break someones build process though ?   OTOH not leaving random files around has to be a pretty good benefit.

@maphew I suggest that it be added as functionality (it doesn't work that way currently), then documented as a best practice. It shouldn't break the way it's done now.

It would be very nice if the behaviour of clean in setuptools could be improved; the current behaviour is really annoying IMHO.

I completely agree. I find it hard to believe that there is no option to select a different output folder for the generated artifacts AND the clean command does not really remove them.
There should not be a need for a third-party extension. I think a out-of-source build and proper clean should be natively supported by setuptools, as per previous comments.

Trying to make a nice workaround for this stuff, I couldn't manage with changing workdir - it fails with line "error: package directory 'my_root_package' does not exist".
In make case I just build a source distribution with no data files, extensions etc, just plain python archive. I found a workaround for this issue - having workdir at repo root as usual, use command:
python setup.py egg_info --egg-base tmp/build sdist --dist-dir tmp/dist
How it works:

sdist anyway runs egg_info command, all commands run only once, so you can freely add all the commands you already use and override their options.
egg_info allows for changing the path where .egg-info directory will be written, so this way I get rid of .egg-info files in source root.
--dist-dir thing changes the destination for output archive.
All others artifacts are cleaned up by default.
If you have more complex builds let's say with extensions, most probably you should also be able to override their options by this method.

Not really convenient solution, but it does not require any extra code.

I had problems with that, I added data files to MANIFEST.in, added include_package_data=True to setup() and built the package again (python setup.py sdist) but setuptools won't install the data files until I wiped the /dist and /*.egg-info dirs, past builds were interfering in the behavior of new builds, if that's allowed to happen then setuptools should also clean that directories along with /build.

If you find an easy-to-use built-in solution, it would be great to post it here as well: https://stackoverflow.com/questions/64952572/output-directories-for-python-setup-py-sdist-bdist-wheel
Thanks!

Like others who've commented here, I have had to resort to a custom clean command to remove the dist directory.
It would be good if this could be fixed in setuptools. A user would reasonably expect that python setup.py clean --all would clean all directories. However, I haven't come across a situation where I want a partial clean so I'm not sure there is much point in a --all flag: clean should just clean everything.
class CleanCommand(clean):
    """
    Custom implementation of ``clean`` setuptools command."""

    def run(self):
        """After calling the super class implementation, this function removes
        the dist directory if it exists."""
        self.all = True  # --all by default when cleaning
        super().run()
        dir_ = "dist"
        if exists(dir_):
            log.info("removing '%s' (and everything under it)", dir_)
            rmtree(dir_)
        else:
            log.info("'%s' does not exist -- can't clean it", dir_)


[BUG] Grayskull doesn't detect AGPL-3.0-or-later

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
grayskull pypi internetarchive

Expected behavior
about.license should be AGPL-3.0-or-later. Instead, it's AGPL-3.0. AGPL-3.0 is deprecated, see https://spdx.org/licenses/AGPL-3.0
Outputs
[...]
about:
  home: https://github.com/jjjake/internetarchive
  summary: A Python interface to archive.org.
  license: AGPL-3.0
  license_file: LICENSE
[...]

Environment:

grayskull --version

2.5.1

Additional context
See https://github.com/jjjake/internetarchive/blob/6e2321652ab2bd13c517dabf5a6e01f420bca380/LICENSE#L637-L638 for the LICENSE file. This is flagged by the conda-forge-linting service: https://github.com/conda-forge/staged-recipes/pull/24886#issuecomment-1874039753

Can you test with grayskull 2.5.2 please?

Same issue with grayskull==2.5.3.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1773

Questions ?
Please refer to the Backport tool documentation


Workflow question

Hi,
I'm not clear on the overall workflow to be used when we have the addd-in installed.
If we have a solution, it has already been 'paketized' and runs and builds fine. Now we need to add another NuGet package as part of some upgrade.
Well should we use NuGet pakage manager in VS to locate and add the paackage or is there some way to add NuGet packages via this Paket add-in?
If we do add a new package using NuGet package manager then after we add it should we then run:
Tools -> Paket Dependencies Manager -> Update all packages? or
Tools -> Paket Dependencies Manager -> Convert from NuGet ?
Or is there some other way to 'paketize' the solution after adding a new NuGet package?
Also what if we want to remove a NuGet package, again should we run some Paket command?
Thanks
Hugh

there are add package and remove package context menus