fix: properly evaluate process.env.AUTO_WEBP

Description of changes:
process.env.AUTO_WEBP isn't properly evaluated. CloudFormation file sets this ENV to either "Yes" or "No", but the code only checks if the ENV variable is present or not.
Change was introduced with the bug present in https://github.com/awslabs/serverless-image-handler/pull/152
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for your contribution @toredash , and we are already aware of this issue, and we will fix this one on the next release.

@beomseoklee should this PR be closed then, or do you wish to keep it open ?

@toredash
Thanks for waiting. This one is fixed in v5.0.0.


Add 'is_point_in_circle()' to Geometry class, and general file cleanup

This adds the is_point_in_circle() method to the Geometry class, and cleans up several files (removal of dead code and proper comment formatting).
Now, why add a method for something so easy to calculate, you may ask. Simply put, it's just a small QOL addition. While the way to calculate its very small:
return circle_position.distance_to(point) < radius;

It can quickly add up if needed multiple times. And if you need to use it in multiple scripts, it can be bothersome having multiple user-made methods to condense the calculation in each file (unless you make it in a global script, which is generally something you want to avoid).

Must say, always felt this was missing.  😄
return point.x <= circle_position.x + radius and point.x >= circle_position.x - radius and point.y <= circle_position.y + radius and point.y >= circle_position.y - radius
I think this is a point in a rectangle.
When I give up looking for the point_in_circle(), I generally write something like:
if((a - b).length_squared() <= radius * radius):

When adding features + doing a cleanup of a whole class, I'd prefer two separate commits (can still be in the same PR) for readability. It's hard to spot what the actual logic changes are in a commit with so many comment changes.

I usually check this by
if a_pos.distance_to(circle_pos) < radius:
    # it is inside

@akien-mga Noted.
@avencherus Never have been good with vector math. Fixed.
@volzhs Yep, this is a shorter and more efficient (and actually correct) way to calculate it. Replaced my wrong math with it. I still think the addition is welcomed, as at a glance is easier to realize what it's doing.

It would be wrong if I wouldn't mention about ellipse, perhaps it could be generalized to is_point_in_ellipse, with two focal points being at exact position = is_point_in_circle.

@volzhs This does make me wonder what is expected with "inside", do most consider the edge inside or outside the circle?

@avencherus I think most people expect the edge to count.

if a_pos.distance_to_squared(circle_pos) <= radius * radius:
is the more efficient way to do this check, though the implementation of the is_point_in_circle function seems to be missing from the PR?

@MunWolf The diff that contains it is not rendered because of its size, click in "Load diff".

Ahh yeah, didn't notice that :D
But my comment still stands.

How is point.distance_to_squared(circle_pos) <= radius * radius faster than circle_pos.distance_to(point) <= circle_radius, since the former has two calculations instead of one?

How is point.distance_to_squared(circle_pos) <= radius * radius faster than circle_pos.distance_to(point) <= circle_radius, since the former has two calculations instead of one?

Square root is more expensive than multiplication.

@YeldhamDev You are confusing function calls with calculations :D
circle_pos.distance_to(point) <= circle_radius
is equal to sqrt((circle_pos.x - point.x)^2 + (circle_pos.y - point.y)^2) <= circle_radius
while point.distance_to_squared(circle_pos) <= radius * radius
is equal to (circle_pos.x - point.x)^2 + (circle_pos.y - point.y)^2 <= circle_radius * circle_radius
same number of calculations, but multiplication is way easier then a square root.

Thanks!


Migrate to benchmark-driver

I want to compare performance between multiple csv versions.
benchmark-ips doesn't support the feature.

Done.


Invalid WebSocket Controller provided

Invalid WebSocket Controller provided. Expected instance of Ratchet\WebSocket\MessageComponentInterface, but received App\Websockets\SocketHandler\UpdatePostSocketHandler.

Hello , your App\Websockets\SocketHandler\UpdatePostSocketHandler should implements Ratchet\WebSocket\MessageComponentInterface.
Take a look on this blog post : http://blog.usthb-celec.com/b/build-your-own-pusher-server


Reverse chronological ordering of PR updates

Description
With a sufficiently long PR (which happens easily the more bots/reviewers are involved) you always have to scroll to get to the newest information.
It would be nice to have the most recent comments/updates near the top, underneath the description, to avoid always having to scroll down to see them.
Example URLs
https://github.com/refined-github/refined-github/pull/3007
I would like to be able to see its locked status, first release containing the changes, and most recent message without having to scroll to the bottom.

This is hard to get right due to the DOM and ajaxed-in updates. Not something worth for Refined GitHub to mess with


Feature Request: Variables in ParameterTasks

What I'm talking about is adding a 'variable' property to parameter tasks that let's you specify a variable name and initialize it to a value, which can then be used in format expressions through the various properties of the task.
This can be especially useful if the value is based on a parameter value. Therefore really only necessary, and really only easy to implement, in a ParameterTask.

Added


MyPy Upgrade (for Pydantic V2)

Closes #PROD-2262
Description Of Changes
Bumps mypy to 1.10.0 - our prevous version was too low to be able to run with Pydantic v2.
Code Changes

[ ] Fixes corresponding type issues introduced by new Pydantic v2 work as well as other issues flagged by the upgrade.

Steps to Confirm

[ ] Only looking for mypy to pass here.  Will merge into the base branch so this work can be tested as a whole.

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs
[ ] if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated
If there are any database migrations:

[ ] Ensure that your downrev is up to date with the latest revision on main
[ ] Ensure that your downgrade() migration is correct and works

[ ] If a downgrade migration is not possible for this change, please call this out in the PR description!

This work updates mypy on the pydantic base branch. I am going to merge so this can be tested together, as this corrects issues in the underlying branch.


fix(sqlparser): fix panic for GRANT EXECUTE

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix  #7796
PG syntax is:
GRANT { EXECUTE | ALL [ PRIVILEGES ] }
    ON { FUNCTION function_name ( [ [ argmode ] [ arg_name ] arg_type [, ...] ] ) [, ...]
         | ALL FUNCTIONS IN SCHEMA schema_name [, ...] }
    TO { [ GROUP ] role_name | PUBLIC } [, ...] [ WITH GRANT OPTION ]

Our current behavior is:
dev=> grant execute;
ERROR:  QueryError: sql parser error: Expected ON, found: ;
dev=> grant execute on f;
ERROR:  QueryError: sql parser error: Expected TO, found: ;
dev=> grant execute on f to root;
ERROR:  QueryError: Bind error: GRANT statement does not support object type: Tables([ObjectName([Ident { value: "f", quote_style: None }])])
dev=> grant execute on function f to root;
ERROR:  QueryError: sql parser error: Expected TO, found: f

Limitation: the parser is still incomplete (for FUNCTION keyword), but at least it doesn't panic.
PG's correct behavior:
xxchan@/tmp:postgres> grant execute on f to xxchan;
invalid privilege type EXECUTE for relation
Time: 0.006s
xxchan@/tmp:postgres> grant execute on function f to xxchan;
could not find a function named "f"

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

added

how about 'grant temporary'

@xxchan how about 'grant temporary' , seems panic too

🥲 Thanks. Fixed


bugfix: #1662 XHR throws before issuing CORS application/json POST re…

Solution to #1662:
XMLHttpRequest when POSTing not empty body to other site (CORS) with authorization header (supposedly with any not simple header) throws exception even not sending request to the server. This kind of requests might be used to communicate with local middleware via REST with authorization, especially when system is built of micro services.
    TypeError: Cannot convert undefined or null to object

      at Object.getRequestHeader (node_modules/react-scripts/node_modules/jsdom/lib/jsdom/living/xhr-utils.js:19:23)
      at setDispatchProgressEvents (node_modules/react-scripts/node_modules/jsdom/lib/jsdom/living/xmlhttprequest.js:908:38)
      at XMLHttpRequest.send (node_modules/react-scripts/node_modules/jsdom/lib/jsdom/living/xmlhttprequest.js:700:11)

The issue is that on xmlhttprequest.js:908 'client' is EventEmitter, while code expected request client.
Solution still won't provide progress on data upload for CORS POST, but will fix exception and enable such kind of requests. I suppose proper fix would be to store final headers somewhere in the xhr object, while keeping properties.client only as EventEmitter..
to-upstream test is pointing to hosted w3c-test.org since local python test server is not running while upstream tests executing.

Thanks, this is really great! Ideally we'd be running the to-upstream tests under the Python server, but for now this is probably the way to go...


Touch not working

Describe the bug
Laptops with touch displays do not work with label-studio
To Reproduce

Try to label with a pen or finger on a capacitive touchpad

Expected behavior
Label-studio reacts to touch, i.e. labels are drawn.
Observed behavior
Label-studio does not react to touch when drawing labels. The rest of the UI is working fine.
Screenshots
Not applicable
Environment (please complete the following information):

OS: win10
Label Studio Version: 1.3.1
Hardware: E.g. Dell Insipron Series
Browser: Chome / Firefox

Additional context
Active pens might be working? Not sure.

Thank you for the feedback. Yes, at the moment there is no fully working and convenient touch support in Label Studio. The task to implement it is not an easy one, but we have this in mind and plan to tackle this issue at some point.

Touch is working for me on Firefox 98. Touch does not work on Chromium 99 (instead it scroll the window).
Environment (server)
OS: Linux Docker
Label Studio Version: 1.4
Environment (client)
OS: Linux 5.16.14-1-MANJARO

I had the same issue.
System: Lenovo Thinkpad X1 with Windows 10.
Label studio: v1.4.1
With Firefox 99 the pen stopped working for brush annotations. I downgraded to Firefox Extended Support Release and this fixed the pen issue.

@fcossio does it work with Chrome?

I tried Chrome only when the pen stopped working and it didn't fix the issue. I don't have the computer anymore since it was given to the person doing the annotations so I can't check the chrome version for now.

Hi, just wanted to pop this up in the stack of potentially important features. Doing annotations with the mouse or trackpad is not possible in my case. Today I had to downgrade Firefox for the 7th time to v91 for the app to keep working. I would highly appreciate the pen working on new releases of any browser.

@fcossio Hi, is it possible for you to switch and check this PR? It would help us in testing.
https://github.com/heartexlabs/label-studio/pull/2822

Hi, thanks for taking a look at this! I will have access to the computers with touchscreen/pen again until Dec 13th. I'll make sure to test and give feedback if the PR is still open then. If there's anything related I can do in the meantime, I'll be happy to assist you 😊

Anyone tried to use a tablet with a capacitive pen on labelstudio

Hi, I've been trying to use label-studio with a Wacom One (with display).
I've found out that by disabling Windows Ink in the Wacom Center app, the pen works perfectly on newer versions of browsers as well as older versions (versions in the above comments tested).
Tested and OK:
Microsoft Edge v123.0.2420.97
Google Chrome v124.0.6367.61
Mozilla Firefox v91
Mozilla Firefox v98
Mozilla Firefox v125.0.1


Missing SSH connection in Architecture Diagram

Update the Architecture Diagram which is in Readme.md with the SSH connection between other applications and Raspberry Pi.

Closed with PR #215


Add int support

Coverage remained the same at 100.0% when pulling 199869a654f59c64ed96b249822e919f4bcad06a on NathanSpeidel:add-int-support into 84eb41572aac99d68ed11022851d13f2458ba865 on bullet-db:master.


Configure access type offline

How we can configure the access type to offline

Add the relevant permission to your scope parameter.


fix region_not_found error

What problem does this PR solve?
 21/03/02 12:23:01 WARN RegionStoreClient: Re-splitting region task due to region error:
  21/03/02 12:23:01 WARN KVErrorHandler: Unknown error region_not_found {
    region_id: 56882165
  }
   for region [{Region[56882165] ConfVer[8665] Version[176] Store[105] KeyRange[t\200\000\000\000\000\000\000\203_r\200\000\000\000\002k\223\344]:[t\200\000\000\000\000\000\000\203_r\200\000\     000\000\003!\201\r]}]

 21/03/02 12:23:41 WARN RegionStoreClient: Re-splitting region task due to region error:
 21/03/02 12:23:41 WARN KVErrorHandler: Unknown error region_not_found {
   region_id: 56882165
 }
  for region [{Region[56882165] ConfVer[8665] Version[176] Store[105] KeyRange[t\200\000\000\000\000\000\000\203_r\200\000\000\000\002k\223\344]:[t\200\000\000\000\000\000\000\203_r\200\000\     000\000\003!\201\r]}]

What is changed and how it works?
invalidateRegion when got region_not_found error
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update the tidb-ansible repository
Need to be included in the release note

/run-all-tests tikv=v4.0.8 tidb=v4.0.8 pd=v4.0.8

/run-all-tests tikv=v4.0.8 tidb=v4.0.8 pd=v4.0.8


Matching hie GHC version to the project GHC version

Come up with a process to launch the right hie, to match the compiler. And this has to work for stack and cabal, so stack install is not an option, necessarily.
I think there are two alternative approaches

Make a concierge process that does the initial handshake until the initialize message with the project root is given, then detect the GHC version and spawn the appropriate hie version. The trick will be to replace the one process with the other, or to delegate stdio to the spawned hie. With the current state of initialization.

Expose a helper that the client can invoke when determining the project root that also returns the hie instance to use.

The second option may be simpler, and can fall back to just using a setting in the client. These things tend to be pretty stable.

Hie is like ghci in that it actually loads the project, to get info.  For
that to work, the GHC version built into hie must be able to load the
compiled products.
So it must match.
I would imagine we could get it from cabal-helper or ghc-mod.
On 08 Mar 2018 01:54, "Gastón Tonietti"<EMAIL_ADDRESS>wrote:

Is anyone working on this? I could give it a shot (with some help probably)
PS: Is there anything I can read to understand why this is needed? Is it a
ghc-mod limitation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/haskell/haskell-ide-engine/issues/439#issuecomment-371328041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZAByWhOEHD9bNUVAEHeSIla2XA0I9Bks5tcHNNgaJpZM4RaZO_
.

Just to make it visible here, as per this comment it seems the new approach is a bit different from the one described using a concierge process.
Are we sure about this new handshaky launching? I don't think any LSP client implementation has such facility to invoke multiple times a command for launching the server, so in most cases user will end up scripting it.
But i guess it's easy enough using a one-liner like: GHCVER=$(hie --ghc-ver); hie-$GHCVER

I think we are feeling our way on this, and perhaps some approaches will work better with some clients than others.
I think the concierge option will be the most bullet-proof eventually, but it does need a fair bit of config.
Also, eventually the right version of hie can be determined by the project dependencies if using nix or stack.
At the moment, "doing the simplest thing" has resulted in it being set in the client.
Next step is to make it easy for the client to check if it has the right version.
And after that full concierge.
A bit of a brain dump, sorry.
For me first prize is still the concierge process.

While implementing this on #493 I found that using cabal-helper for finding the GHC version has a few pitfalls I would like to enumerate and discuss if you will.

cabal-helper requires ghc to be on the $PATH, but that not always is the case, for instance if you use stack o cabal configure with -w option.

To use compilerVersion you're asked for the project's root dir (the one containing project.cabal), that one is easy. But you also have to provide project's build dir (the one containing setup-config) and that one is not so easy.

For projects using cabal (old) build it's trivial, it's just ./dist, but in the case of projects using stack you might have several, for instance:
./.stack-work/dist/x86_64-linux-nopie/Cabal-<IP_ADDRESS>/setup-config
./.stack-work/dist/x86_64-linux-nopie/Cabal-<IP_ADDRESS>/setup-config

We could just pick one arbitrarily but dunno how correct would that be.
Also, I think we should consider supporting cabal new-build for any new functionality and in that case it gets even worse, we have to know the ghc version in use to find the ghc version in use :)
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/ghc-mod-<IP_ADDRESS>/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/HaRe-<IP_ADDRESS>/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/ghc-mod-core-<IP_ADDRESS>/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/haskell-ide-engine-<IP_ADDRESS>/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/haskell-ide-engine-<IP_ADDRESS>/c/hie/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/haskell-ide-engine-<IP_ADDRESS>/c/haskell-ide-test/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/haskell-ide-engine-<IP_ADDRESS>/c/haskell-ide-func-test/setup-config
./dist-newstyle/build/x86_64-linux/ghc-8.2.2/hie-plugin-api-<IP_ADDRESS>/setup-config

Over the time a project could accumulate multiple build dirs for different ghc version and we would not know which one to use, because we are basically trying to find that out.
An alternative to avoid all the directory choosing drama would be to use the same approach used in hie-wrapper script, either stack ghc -- --version for stack projects or just ghc --version for cabal ones.
What you reckon?

I think we should plumb this through ghc-mod, which takes care of looking after those details.  cabal-helper, is basically a part of ghc-mod, and is not really intended to be used standalone.
So it would involve adding a compilerVersion command to ghc-mod, which simply calls cabal-helper with command "compiler-version".
cc @DanielG

I have not dug into the details related to his here.  However, it may be
helpful that "stack install haskell-ide-engine --copy-compiler-tool" will
place it in a special bin directory which will be on the PATH when stack is
used with that ghc version.
On Mar 11, 2018 12:26 AM, "Alan Zimmerman"<EMAIL_ADDRESS>wrote:

I think we should plumb this through ghc-mod, which takes care of looking
after those details. cabal-helper, is basically a part of ghc-mod, and is
not really intended to be used standalone.
So it would involve adding a compilerVersion command to ghc-mod, which
simply calls cabal-helper with command "compiler-version".
cc @DanielG https://github.com/danielg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/haskell/haskell-ide-engine/issues/439#issuecomment-372097983,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABYKtQ71rPPPoD9fPSZ06jJdKzdqIWUks5tdN-0gaJpZM4RaZO_
.

@ktonga using cabal-helper directly is just not going to do what you want as you've found. You have to do this at a level where the build system in use (i.e. cabal-install, stack or plain GHC) is known. cabal-helper doesn't know anything about build systems, all it does is give you access to some stuff both cabal-install and stack dump to disk.
I think the right place to do this is definetly ghc-mod. All you really need to do is compare cProjectVersion from GHC's Config module with the output of ghc --numeric-version after the project type (stack vs cabal etc.) has been determined.
The way I'd do it is extending ghc-mod's Cradle type with something like cradleGhcVersion which would be initialized as part of findCradle' and then check it against cProjectVersion right in findCradle and error out if it doesn't check out.
The trickiest part is probably deciding what kind of error to throw the way we do it is kind of weird and inconsistent but I think in this case adding another case to GhcModError would make the most sense since downstream stuff like h-i-e will want to know if this specific problem happens and possibly handle it.

Come to think of it I didn't consider cabal old-build properly. In that case using cabal-helper to determine the GHC version instead of calling ghc --numeric-version is pretty much a must if we want this to work reliably in situations where the user calls cabal configure -w.
I think in that case we can just defer erroring out straight away in findCradle and do it whenever runCHQuery is called, or something like that. If you can't figure it out I can have a closer look.

Great, thank you a lot @DanielG for taking the time and explaining all that to me. I'll try to wrap my head around everything you've just said and open a PR on ghc-mod to add this new functionality.

then calls something like exec to replace itself with the right one.

it's not possible on Windows
Is this issue still open? What remains to do?

@nponeccop , the hie-wrapper executable basically implements the script from https://github.com/haskell/haskell-ide-engine/issues/439#issuecomment-359801662, and uses the cross-platform API to launch the identified exe with the same params as the original.


TestStreamWriterAttachBadOutgoingConn: working = true, want false

via semaphore (https://semaphoreci.com/coreos/etcd/branches/master/builds/781)
--- FAIL: TestStreamWriterAttachBadOutgoingConn (0.02s)
	stream_test.go:109: working = true, want false
	stream_test.go:112: failed to close the underlying connection

Possibly triggered by #6175

2016-08-15 23:13:02.827773 E | rafthttp: failed to write 1 on stream Message (blah)
2016-08-15 23:13:02.828097 I | rafthttp: peer 1 became inactive
2016-08-15 23:13:02.841645 W | rafthttp: lost the TCP streaming connection with peer 1 (stream Message writer)
2016-08-15 23:13:02.841790 I | rafthttp: stopped streaming with peer 1 (writer)

Is it already deactivating the status after we send message to msgc?
(cr *streamReader) decodeLoop never got called based on the logs.
Maybe cw.close() took more than 10ms before it sets working as false?


S3 bucket default removal policy not respected

Describe the bug
Documentation states that the RemovalPolicy.Destroy is the default but if you don't explicitly set the value, the S3 bucket will not be removed on cdk destroy.
To Reproduce
The following code will not destroy the S3 bucket:
val buildBucket = Bucket(this, "buildbucket", BucketProps.builder()
            .withBucketName(props.buildBucketName)
            .build()
        )

However, explicitly setting RemovalPolicy will destroy the bucket during cdk destroy:
val buildBucket = Bucket(this, "buildbucket", BucketProps.builder()
            .withBucketName(props.buildBucketName)
            .withRemovalPolicy(RemovalPolicy.Destroy)
            .build()
        )

Expected behavior
S3 bucket should be destroyed without explicitly defining removal policy.
Version:

Ubuntu
Java/Kotlin
0.31.0

If there are any files in the bucket, Cloudformation will not delete the S3 bucket, no matter what you say or how you ask. In other words, this is not a CDK-specific issue.
I agree this is a PITA which is why I created AutoDeleteBucket which will do what you want.
Protip: You can specify anAutoDeleteBucket anywhere can use Bucket which allows you to automatically delete buckets associated with codepipeline, etc.

@schof I understand bucket deletion is not allowed if it's not empty but that's not the case here.
At the very least, the documentation should be updated or behavior changed to match what the docs say.

The documentation fairly unambiguously states that the default behavior for s3.BucketProps.removalPolicy is to orphan the bucket.

As stated in https://github.com/aws/aws-cdk/issues/3297, this will either be supported by Cloudformation or to incorporate force deletion of S3 buckets into CDK as custom resource.
Recommend continuing the conversation at https://github.com/aws/aws-cdk/issues/3297. Closing this issue.


Update README to have correct argument name for 'ignore_undefined_rou…

…tes'.

Looks like the argument name was changed at some point, but not the README.


v10 - Accessibility issues with menu

Environment
Usability testing with JAWS on Windows 10
Problem
When the user is interacting with the menu and has opened a drop down it is not obvious which is the next same level menu item and which is a nested child menu item.

This one we can close as well. We've revamped out sidenav keyboard pattern and this isn't an issue anymore 👍🏽


Current quickstart documentation might be a little confusing about create_all()

Current documentation claims that:
To create the initial database, just import the db object from an interactive Python shell and run the SQLAlchemy.create_all() method to create the tables and database:

>>> from yourapplication import db
>>> db.create_all()

Boom, and there is your database.

But the create_all() function does not seem to create the database, only the tables.

it would indeed be more clear if the word schema was  added there

Following the example in quickstart using SQLite, the database (the file /tmp/test.db) is created if it doesn't exist. It's not completely misleading but it's closely tied to the example use case.
It seems fair to walk back the claim since it varies by engine. If you point it at a Postgres DB which does not exist, you immediately end up with e.g.
psycopg2.OperationalError: FATAL:  database "database" does not exist

Opened a documentation PR to reduce the confusion here.

closed by #792


Always set pinned to true when Freshmaker replaces a pullspec

This indicates that the pullspec was replaced by Freshmaker in
the bundle image.
This is a followup to #45.

@qixiang thanks for pointing that out. Okay, it's ready for review again.

@qixiang thanks for pointing that out. Okay, it's ready for review again.

Sorry for making confusion, I mean we only replace the digest when pinned is true, when pinned is false, we just skip that pullspec, so when we do the replacement, the pinned is already True and it's unnecessary to set it True again.

@qixiang thanks for pointing that out. Okay, it's ready for review again.

Sorry for making confusion, I mean we only replace the digest when pinned is true, when pinned is false, we just skip that pullspec, so when we do the replacement, the pinned is already True and it's unnecessary to set it True again.

@qixiang I understand, but we want to fix CVEs even if the image was prepinned in the bundle metadata. This will be required to support ACM rebuilds. We just want to skip bundle images which completely bypassed OSBS metadata adjustments.

@qixiang I understand, but we want to fix CVEs even if the image was prepinned in the bundle metadata. This will be required to support ACM rebuilds. We just want to skip bundle images which completely bypassed OSBS metadata adjustments.

ok, I see, then this looks good to me, free feel to merge.


[11.x] Introduce Collection::containsManyItems method

I often find myself needing to check if a collection has more than one item. While Laravel provides useful methods like count, isEmpty, isNotEmpty, and containsOneItem, there's nothing built-in to quickly check for multiple items.
This pull request adds a Collection::containsManyItems method to make this check simpler and more intuitive. It's a small addition, but it makes code a bit cleaner and avoids having to manually compare collection sizes.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!


DST-799: datadog trial

Codecov Report
Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (282a6a5) to head (664246f).

Files with missing lines
Patch %
Lines

django_app/config/asim_formatter.py
0.00%
26 Missing :warning:

django_app/config/settings/deploy/development.py
0.00%
3 Missing :warning:

django_app/config/settings/deploy/staging.py
0.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   81.40%   80.31%   -1.10%
==========================================
  Files          78       79       +1
  Lines        2345     2377      +32
==========================================
  Hits         1909     1909
- Misses        436      468      +32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[WFCORE-4619] Upgrade JBoss Marshalling to 2.0.9.Final

https://issues.jboss.org/browse/WFCORE-4619

retest this please
I filed https://issues.jboss.org/browse/WFCORE-4623 for the IdentityOperationsTestCase problems that messed up the security manager job.


about the accuracy of training

how is the accuracy computed when the model is training(multi label text classification)?
why the accuracy of training is always greater than 90%?
Thank you for helping me.

and the accuracy of testing is very low

Disclaimer: I've only just started playing with magpie & deep learning and have not used it for anything big/serious yet (soon tough). Thus I can not offer any sort of guarantee that what I'm about to say will be right or even complete, perhaps @jstypka can validate my answer so we won't both be misguided by my attempt to answer you.

First off, please read this very good stack overflow answer and the answer of 'farizrahman4u' on this github issue. This should give you some insight into interpreting the keras output.
So now we understand: a low accuracy of testing with a high accuracy of training is the result of the model you trained, it is unable to predict for text it has never seen before. This thus means that the model needs more training, because whilst it can work with text it knows (or has "memorized") I assume you want to predict labels for text you haven't trained on.
What training and testing data are you using? I saw the same results when testing magpie on the data that comes with this repo in the /data/hep-keywords/data directory.

Just in case you want to have a peek at some source code:
In the MagPie model, in the train function the keras function 'fit' is called with the train function's parameter 'test_dir' translated to test_data which is fed to keras' 'fit' as 'validation_data'.
From the Keras documentation: validation_data: data on which to evaluate the loss and any model metrics at the end of each epoch. The model will not be trained on this data.

thank you for your answer

the data i use is from Mulan（multi-label classifaction framework）
it contains many bookmarks（multi-label） and has more than 80000 instances

Interesting dataset(s), how are you converting the xml and arff to the format magpie expects?
From my quick peek at the bookmarks dataset it just looks like a whole bunch of numbers between curly braces and a xml scheme that defines tags.

an instance -> a file（or a book）, the file contains the words that its attribute value is 1,the same way for the labels。
first step,read the arff file by the Class（ArffLoader） that Weka provides,
second,use every instance that ArffLoader reads to rebuild every file and its label file（the .txt and .lab）
third,train the magpie model(the list of labels can be got from the .xml file)

public class DataConverter {
private String arffFile;
private String xmlFile;

private List<String> attributes;
private List<String> labels;

private ArffLoader arffLoader;
private Instances structure;
private CSVSaver csvSaver;

/*
 * init
 */
public DataConverter(String arffFile,String xmlFile) throws IOException, DocumentException {
	this.arffFile = arffFile;
	this.xmlFile = xmlFile;
	attributes = new ArrayList<String>();
	labels = new ArrayList<String>();
	setArffLoader();
	setCsvSaver();
	setLabels();
	setAttributes();
}

/*
 * set arff loader
 */
public void setArffLoader() throws IOException {
	System.out.println("load arff data");
	arffLoader = new ArffLoader();
	arffLoader.setFile(new File(arffFile));
	structure = arffLoader.getStructure();
}

/*
 * set csv saver
 */
public void setCsvSaver() throws IOException {
	csvSaver = new CSVSaver();
	csvSaver.setRetrieval(Saver.INCREMENTAL);
	csvSaver.setStructure(structure);
}

/*
 * read xml file and set labels
 */
public void setLabels() throws DocumentException {
	SAXReader reader = new SAXReader();
	Document document = reader.read(new File(xmlFile));
	Element root = document.getRootElement();
	List<Element> list = root.elements();
	for(Element element:list){
		String attrName = element.attributeValue("name");
		labels.add(attrName);
	}

	System.out.println("set labels " + labels.size());
}

/*
 * set attributes
 */
public void setAttributes() throws IOException {
	for (int i=0; i < structure.numAttributes()-labels.size(); i++) {
		attributes.add(structure.attribute(i).name());
	}

	System.out.println("set attributes " + attributes.size());
}

/*
 * save data as csv file
 */
public void saveAsCsv(String csvFile) throws IOException {
	System.out.println("save to csv file...");

	File file = new File(csvFile);
	if (file.exists()) {
		file.delete();
	}
	csvSaver.setFile(file);

	Instance instance;
	while((instance = arffLoader.getNextInstance(structure)) != null) {
        csvSaver.writeIncremental(instance);
    }
}

/*
 * save data as txt file and label file
 */
public void saveAsTxtAndLabel(String dir) throws IOException {
	System.out.print("save to txt and label file...");

	File dirFile = new File(dir);
	if(!dirFile.exists()){
		dirFile.mkdir();
	}

	int count = 1;
	int numAttribute = attributes.size();
	StringBuilder builder = null;

	Instance instance;
	while((instance = arffLoader.getNextInstance(structure)) != null) {

		if(instance.numAttributes() != (attributes.size() + labels.size())){
			continue;
		}

		// save the context of file
		builder = new StringBuilder("");
		int i = 0;
		while(i < numAttribute) {
			if((int)instance.value(i) == 1) {
				builder.append(attributes.get(i)).append(" ");
			}
			i++;
		}
		FileWriter writer = new FileWriter(new File(dir + "/" + count + ".txt"));
		writer.write(builder.append("\n").toString());
		writer.close();

		// save the labels of this file
		builder = new StringBuilder("");
		while(i < instance.numAttributes()) {
			if ((int)instance.value(i) == 1) {
				builder.append(labels.get(i-numAttribute)).append("\n");
			}
			i++;
		}
		writer = new FileWriter(new File(dir + "/" + count + ".lab"));
		writer.write(builder.toString());
		writer.close();

		count++;

	}

	System.out.println(count*2 + " instances");
}

/*
 * save as text file
 */
public void saveAsText(String dir) throws IOException {
	System.out.println("save to text into labelDirs...");

	// create the label dir
	for (String label : labels) {
		new File(dir + "/" + label).mkdir();
	}

	Instance instance = null;
	while((instance = arffLoader.getNextInstance(structure)) != null) {
		if(instance.numAttributes() != (attributes.size() + labels.size())){
			continue;
		}

		StringBuilder builder = new StringBuilder("");
		int i = 0;
		while(i < attributes.size()) {
			if((int)instance.value(i) == 1) {
				builder.append(attributes.get(i)).append(" ");
			}
			i++;
		}
		String text = builder.append("\n").toString();

		FileWriter writer = null;
		while(i < instance.numAttributes()) {
			if ((int)instance.value(i) == 1) {
				int count = new File(dir + "/" + instance.attribute(i).name()).listFiles().length;
				writer = new FileWriter(new File(dir + "/" + instance.attribute(i).name() + "/" + count + ".txt"));
				writer.write(text);
				writer.close();
			}
			i++;
		}

	}

}

}

the function saveAsTxtAndLabel() above  is used

Very nice!
 Perhaps more/less epochs might do the trick, it all depends on what magpie is telling you I guess. Maybe you are overfitting your model, or severly underfitting it.
Please let me know what worked/didn't work to get the prediction/testing values up so I can maybe save myself some trouble in a couple of weeks ;).

ok,I'll let you know if I solve the problem

@bjlgcxc is the validation loss (the error on the test set) decreasing at all between epochs? Could you post how your .txt and .lab files look like? Make sure they are structured in the same way as the example dataset here.

@jstypka
the txt:
a abstract act also an and applying architecture architectures as base be building built by can capture common complex complexity computer considered contribute defining describe design development distribution experience for from how identify identifying in introduce many mechanism more n new notes object objects of oriented our overall patterns play process propose provide reduce reuse roles science software system systems that the their they to we which
the lab:
TAG_design
TAG_kaldesignresearch
TAG_patterns

@bjlgcxc the format looks ok! One interesting thing is that you already filtered out the stopwords etc - this should probably give better results for other methods like bag-of-words, but I don't think it would improve results which are using word2vec models. You might be better off with feeding full text as an input and leaving the rest to the machine.

@jstypka  ok,thank you very much

Hi Jan, I just read your message concerning stopwords. We also eliminated the stopwords in different trials. Can you explain why for word2vec performance may be lowered? On a general matter is there any (other) cleaning operations to do to the full text ? (ex: Single sentences better than full text ? / Eliminating @ and other special char. ? etc.)

word2vec relies on the context of each word to figure out it's meaning, so for example if it spots the preposition to before some words in might conclude that it is a place and draw a relation between them in the model. If you strip words like to then you take away this information.
https://www.quora.com/Is-it-compulsory-to-remove-stop-words-with-word2vec
But perhaps removing them doesn't hurt the results - frankly, I have never tried running it without stopwords.


Add role="document" to modal dialog content

Initial fix to generalise use of modals. Generally, true role="dialog"
containers would require only forms/controls as content, with all other
text correctly and explicitly associated via
aria-labelledby/aria-describedby and similar...but as authors use modals
also as generic overlays, this extra role is required to get AT
(particularly NVDA) out of "forms" mode and reenable reading keys.
Closes #15875

Still doesn't solve all issues with NVDA (once a dialog is opened, reading keys are still disabled...user has to TAB at least once - generally to the close button - to enter the actual document area; after that, though, they can navigate/read all content normally). Rough live demo here as well http://output.jsbin.com/todajoqefa/1/


real vehicles

Hi,Thanks for your great work! I would like to inquire, based on your experience and research, do you believe it is feasible to deploy this work onto real vehicles? Particularly, considering our current computational resources are 2 A800 GPUs (80G). In this scenario, how long do you think it might take us to achieve this goal? Are there any key technical challenges or issues that need to be addressed?

Hi!
Thank you for your attention to our project! I have attached our previous latency analysis. The experiments were conducted on a 3090 platform. With 2 A800 GPUs and a quantization tech, I think the average latency can be reduced to < 0.1 seconds, and the variance is small. The large language model wouldn't bring a big time cost, as one frame only provides 4 tokens for the LLM. The main latency comes from the vision encoder. You can apply some existing optimization tricks (like flash attention) of LLM and ResNet to reduce the time cost.

Thank you for your early reply!
It seems that there is a promising opportunity to deploy this work onto real vehicles. If I aim to implement this work for achieving autonomous driving on a simple road segment in a real environment, could you provide me with some insights? I'm interested in understanding the process of translating theory into practice, as well as the key steps and technical challenges to consider.
Thank you very much for your time and assistance!


update to macOS 12 Monterey / latest Xcode version

first commit - on my M1 Mac:

updated to latest macOS Monterey
updated to latest Xcode version
committed the result of fetch_them_macos_headers fetch

second commit - on my Intel Mac:

updated to latest macOS Monterey
updated to latest Xcode version
committed the result of fetch_them_macos_headers fetch

I've also sent a PR to Zig here: https://github.com/ziglang/zig/pull/10202 - we can keep discussion about if this is the right thing to do over there

Thanks for this- I merged it to a different branch called more-data where I have collected multiple versions of macos headers at once.
I played with the data a bit and I have a proposal to support multiple macOS versions. First, the observations that I made from exploring the data:
[nix-shell:~/dev/fetch-them-macos-headers]$ ls headers/
10  11  12

[nix-shell:~/dev/fetch-them-macos-headers]$ ls headers/{10,11,12}
headers/10:
x86_64-macos-gnu

headers/11:
aarch64-macos-gnu  x86_64-macos-gnu

headers/12:
aarch64-macos-gnu  x86_64-macos-gnu

[nix-shell:~/dev/fetch-them-macos-headers]$ du -sh headers/{10,11,12}
6.1M	headers/10   # note: this is smaller because there are no catalina headers for aarch64
13M	headers/11
13M	headers/12

If we naively shipped all 3 versions of these headers, it would come out to 32.1 MiB installation size, which is more than I am comfortable with. So what can we do?
Side note, the meld project is a really nice UI for exploring the diffs between directory trees.
Anyway my observations are:

The differences between versions (e.g. 11 and 12) are few, even on a per-file basis.
The differences between architectures (e.g. x86_64 and aarch64) are very few, even on a per-file basis.

I have not run a program to measure exactly but I think if we had this scheme, we could ship multiple versions without adding too much to the installation size:

Layer 1: x86_64-macos.10 x86_64-macos.11 x86_64-macos.12 aarch64-macos.11 aarch64-macos.12
Layer 2: x86_64-macos aarch64-macos
Layer 3: any-macos

I've removed the C ABI component from the triple here for macOS because it is not meaningful.
So how this works is that we have a script that takes in the data from this project, fetch-them-macos-headers, which contains an independent copy of the headers for every pair of {arch, version}. The script finds out which files are 100% in common between everything, and puts them in any-macos. Next it finds out which files are common between all versions of x86_64 and puts those into x86_64-macos. Likewise it puts files common between all versions of aarch64 and puts those into aarch64-macos. Finally, the leftover files go into directories that are specific to the {arch, version} tuple.
The Zig compiler's job, then is to pass -isystem layer1 -isystem layer2 -isystem layer3 where layer{1,2,3} are the appropriate directory, depending on the target OS minimum version.
One key feature of doing the compression scheme this way is that the zig compiler does not need to move files around on disk or involve a cache system; it is done entirely by making careful use of -isystem and overlaying include directories on top of one another.

Alternative layer scheme:

Layer 1: x86_64-macos.10 x86_64-macos.11 x86_64-macos.12 aarch64-macos.11 aarch64-macos.12
Layer 2: any-macos.10 any-macos.11 any-macos.12
Layer 3: any-macos

This one has the only difference in layer 2, which has differences for versions but not architectures. It's not obvious to me which way of organizing the layers would be better; I think we should use the script to try both schemes and use the one that results in a smaller installation size. My hunch is that the alternative scheme will be better, due to observation number 2.

I updated the script in d9d8958cfa7853f33d0484f26fb86324994a9532 and did the smallest amount I could to test out some results. I think the script is only capable of 2 layers without some more improvements, but the results are already promising:
andy@ark ~/D/z/l/l/include (master)> pwd
/home/andy/Downloads/zig/lib/libc/include
andy@ark ~/D/z/l/l/include (master)> du -sh *macos*
2.6M	aarch64-macos.11-gnu
1.1M	aarch64-macos.12-gnu
6.1M	any-macos-any
3.4M	x86_64-macos.10-gnu
2.6M	x86_64-macos.11-gnu
1.2M	x86_64-macos.12-gnu

This totals 17 MiB which is within what I would consider to be the acceptable range. Introducing a Layer 2 should improve it more. This is compared to status quo master branch of Zig which has 7 MiB installation size:
860K	aarch64-macos-gnu
5.4M	any-macos-any
912K	x86_64-macos-gnu

Also worth noting is that the fetch sub-command needs to be improved to detect the OS version and update the corresponding directory.

After mulling this around, I agree this is likely the best approach.
In the future when the package manager distributes .tbd framework stubs, we will likely want to do the same thing.
One thing that is unclear to me from your target triple examples above: what version does the target triple e.g. x86_64-macos default to? I think that choosing a sensible default is actually the most important thing here because if we don't we will end up with Zig libraries in the ecosystem requiring different versions (sometimes without knowing it) and thus being incompatible with one another. e.g. I would personally like to make sure I am using the same version as most others in the Zig community where possible for maximum compatibility.

You can find the answer to this question programmatically by using zig build-exe --show-builtin -target x86_64-macos. The generated builtin.zig file will be printed to stdout and show the version range. This logic can be adjusted if necessary. You can also pass an explicit version range in the target triple.

@slimsag @andrewrk thanks so much for your work and input - it's very valuable! I'll take it over from here and hopefully finish the script so that it generates the desired 3-layer solution. I'll then move onto updating the zig's frontend to make use of this. In terms of the default, this really matters mainly for cross-compilation environments as when building natively, we fallback to the native sysroot (unless it's not there, that is; e.g., when the user didn't install either the CLT or Xcode). In cross-compilation environments, I think by default we should target the oldest supported macOS version which as far as I understand should run on every version above it - for x86_64 that'd be 10.5, and aarch64 11. The user will then have the option to opt in to any explicitly specified version provided it's one of the supported, latest 3 macOS releases. This will also be possible when compiling natively. Does that make sense, and would you agree?

Some prelim results for alternative layering:
fetch-them-macos-headers/dedup on  more-data [!?]
❯ du -d1 -h
3.2M    ./any-macos.12-any
2.5M    ./any-macos.11-any
252K    ./x86_64-macos.12-gnu
888K    ./x86_64-macos.11-gnu
196K    ./aarch64-macos.12-gnu
836K    ./aarch64-macos.11-gnu
2.7M    ./any-macos-any
 11M    .

This scheme totals 11M, max per subdir is 3.2M as you can see.
I'll now investigate alternative 1 where we create layer 2 based on architecture rather than OS version.

SGTM
also just to reiterate, I no longer have any immediate need for this change so if you're doing any of this on my behalf.. :D

Results for alternative 1:
fetch-them-macos-headers/dedup on  more-data [!?]
❯ du -d1 -h
8.0K    ./aarch64-macos-any
896K    ./x86_64-macos-any
3.4M    ./x86_64-macos.12-gnu
3.3M    ./x86_64-macos.10-gnu
2.5M    ./x86_64-macos.11-gnu
3.4M    ./aarch64-macos.12-gnu
3.3M    ./aarch64-macos.11-gnu
2.7M    ./any-macos-any
 19M    .

Clearly, alternative 2 wins and by a lot.

Merged in 46310be698109ee2309888d4bc9ace2e3851ee9c.


Add new handler for metrics

Description: Add new handler for metrics which can be registered with controller-runtime registry, and wraps existing EnqueueResuestForObject, for both Ansible and Helm controllers.
Motivation: This PR addresses current complexity around exposing primary resource metrics in SDK.
/kind feature

Metrics output for Ansible and Helm sample operators correspodingly.
# HELP primary_resource_created_at_seconds Timestamp at which a resource was created
# TYPE primary_resource_created_at_seconds gauge
primary_resource_created_at_seconds{group="cache.example.com",kind="Memcached",name="example-memcached",namespace="memcached",version="v1alpha1"} 1.594841815e+09

# HELP primary_resource_created_at_seconds Timestamp at which a resource was created
# TYPE primary_resource_created_at_seconds gauge
primary_resource_created_at_seconds{group="cache.example.com",kind="Memcached",name="example-memcached",namespace="helm-memcached",version="v1alpha1"} 1.594843122e+09

We should probably document this metric somewhere in the helm and ansible docs as well.

On second thought, let's add the tests in a follow-up.
I've got a few other PRs I want to submit that depend on this merging.

On second thought, let's add the tests in a follow-up.
I've got a few other PRs I want to submit that depend on this merging.

@joelanford @camilamacedo86
Okay, I will add a TODO doc, for the tests, and raise a story to keep track. Anything else we want to do in this PR?


VERSION vs. Version

It is too late to do anything about it, but anyway...
I found out that my Adjust Pathfinding mod is not working. Reason for this? Somebody renamed the Version property of TrafficManager.TrafficManagerMod class to VERSION. I cannot emphasize how bad idea is it to rename such a key property of the mod since now there is not even an quick and simple way to check if the user is using pre-v11 tmpe or not. The property is now useless as it is version-dependent, although it should inform you about the version in the first place!

This is how I use it in my mod:
private static string GetTMPEVersion()
        {
            return TrafficManager.TrafficManagerMod.Version;
        }

Version TMPE_Version = Assembly.Load("TrafficManager").GetName().Version;

if (TMPE_Version < new Version(11)) {
    // Version 11.0 and earlier all had assembly version 1.0.*.*
} else if (TMPE_Version >= new Version(11, 1, 0)) {
   // Version 11.1.0 and above all have correct assembly version in form M.m.b.* (Major, minor, build, *)
}

We renamed it because there's a system class called Version.
From TMPE 11.1.0 onwards, the assembly version for TrafficManager assembly correctly reports the mod version number.
So if assembly version is less than 11.1.0 you could use your original method to get version number.

I don't give a heck what is from v11 onwards, I'm just saying that you broke compatibility with pre-v11 although you didn't have to.
I don't think that it is meaningful to continue this discussion.

v11.0 (what's on the v11 STABLE workshop) should still have the .Version member.
So it's likely only the current v11 LABS that's breaking things, where the member was renamed .ModVersion to disambiguate from System.Version class.


[Bug] Chronological Timeline Not Working

Recently, the "Following" timeline hasn't been showing in chronological order. After some fiddling around, I discovered that it happens when the "Hide the For You timeline" option is enabled. It works fine if that option is disabled.
I can confirm this happens on both Firefox and Firefox mobile. I don't use Chrome or Edge, so I can't confirm if the issue exists there.

The extension even don't work in my case(default setting and all access to this addon)
from edge browse


Cannot load Apollo Playground (browser) due to "Content Security Policy directive" – error while loading middleware.js from cdn.jsdelivr.net

This issue pertains to the following package(s):

[ ] GraphQL Playground - Electron App
[ ] GraphQL Playground HTML
[x] GraphQL Playground
[ ] GraphQL Playground Express Middleware
[ ] GraphQL Playground Hapi Middleware
[ ] GraphQL Playground Koa Middleware
[ ] GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?
Most likely all OS's
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
Most likely all versions that depend on https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>What is the expected behavior?
Load Apollo Playground
What is the actual behavior?
Apollo Playground does not load
What steps may we take to reproduce the behavior?
Try to access any Apollo Playground
Please provide a gif or image of the issue for a quicker response/fix.

you are using a fork of this repository. youll need to file the issue at apollographql/graphql-playground


Make favicons

using http://realfavicongenerator.net/

make a placeholder for the image for loading etc. not the media icons

Works in all pages but main page


Open Source under BSD-3-Clause.

Ignore package-lock.json.
Bump node versions to current LTS.
Add .editorconfig.
Open source under the BSD-3-Clause.

Codecov Report

Merging #6 (ced21f7) into main (09dad1e) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   90.14%   90.66%   +0.52%
==========================================
  Files           2        2
  Lines          71       75       +4
==========================================
+ Hits           64       68       +4
  Misses          7        7

Files
Coverage Δ

lib/index.js
100.00% <100.00%> (ø)

lib/safari-samesite.js
89.85% <100.00%> (+0.30%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dad1e...ced21f7. Read the comment docs.


Add soft key support

Something was wrong with #214 and #215, so I created a new branch and merged them together.

@DarthFlip, I have renamed the keys to be consistent with the rest.
Also, I can't confirm the new hotkeys work properly, because my phone has buttons below the screen, but Android identifies them as MENU and BACK. But I suppose all is good.

I made the edits and it worked great on my phones. I attatched a picture of what my phones look like. I am trying to add the top 2 keys that are to the right/left of the numpad on top of Tlk/End and Spkr/Camera:

I made the edits and it worked great on my phones. I attatched a picture of what my phones look like. I am trying to add the top 2 keys that are to the right/left of the numpad on top of Tlk/End and Spkr/Camera

Got it. My point was, my phone says the same keys have different key codes.


Clarification on frontdoor identification

A set of variables Z is said to satisfy the front-door criterion relative to an ordered pair of variables (X, Y), if:

Z intercepts all directed paths from X to Y
There is no unblocked backdoor path from X to Z
All backdoor paths from Z to Y are blocked by X
I want to study the causal effect of A on C in the following diagram:

DoWhy identification retrieves B as a valid Z in order to apply frontdoor criterion. Though, I don't think the third condition is being fulfilled. Have I understood anything the wrong way?

Thank you in advance!

thank you for raising this issue @vicbeldo98 This may be a bug. Let me check.

As @gabrielgorenroig remarked, this issue has been fixed in recent releases. I tested with v0.10.


"zone" terminology is confusing and misleading

The prefix at https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/variables.tf#L59 use the "zone-X" terminology. This is very prone to error as could be interpreted as "availability zones" when this actually denotes logical zones (segregation by subnet).
In fact, it seems that the examples are getting into this confusion - see https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/issues/95
The default in the root module for worker_pools variable does not make sense either - as it is making assumptions on prefix on the subnets passed at https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/variables.tf#L34

PR merged. Closing issue


Does not connect to a specific database

When trying to connect to a specific DB like with postgraphql postgres://localhost:5432/NameOfTheDB it will connect to the default DB which is named as my username. This issue was introduced when I updated to 2.0.
I am using am Mac with MacOS 10.12 and Postgres 9.6

Try:
postgraphql -c postgres://localhost:5432/NameOfTheDB

Note the -c or --connection 😊

Thanks for the quick response.
Works perfect.


Implement Console tab support with Rhino

This is an implementation of issue facebook/stetho#81 using Mozilla's Rhino JavaScript library.

Can you post a screenshot or a sample session that shows what you can do with this?  I'm also interested in how large the dependencies are (how big is the sample APK with this change)?

Ok, I have updated my repository with a new branch.  See the branch https://github.com/potyl/stetho/commits/stetho/repl-js.
The integration in the sample app is kept to a bare minimum. I have added a dedicated stetho-repl-js readme for the plugin. In thee i cover examples on how to enhance the runtime, documented the APK file sizes with tips on how to proguard the app.
Mandatory screenshot:

I also have a branch that adds this screenshot to the gh-pages, see https://github.com/potyl/stetho/tree/gh-pages.

Wow, amazing.  A whopping 1.2MB jar file though, but as it is optional I think we can definitely work with that.
This PR is based off your repl branch, not repl-js.  Was that on purpose?  I'd like to put comments on an actual PR instead of the diffs since it's easier to manage through the review.

I've changed the branch so that the old one would still be present just in case. For now i wanted to have your opinion. I see that i forgot to add the APK sizes, I'l add that to my documentation.
I will do a reset --hard to the original branch of the PR.
As you mentioned the APK does take a load with the javascript REPL, i would suggest that we keep it optional. For instance in our main app at work I can't enable the module since it busts the dex count even with proguard :/

I have updated the read me to include apk sizes and tweaked a bit the documentation. The branch stetho/repl is now final.
I'm waiting for your comments.

Can you take a look at the Travis CI failures?  Looks like simple lint errors which you can see locally by checking out the XML report generated by gradle lint

I pushed a fix to lint. I don't understand why my branch still fails. The error i get is for:
OldTargetApi: Target SDK attribute is not targeting latest version

Which is triggered by:
defaultConfig {
    minSdkVersion 9
    targetSdkVersion 21
    versionCode 1
    versionName "1.0"

But all the other projects have targetSdkVersion 21 so i don't understand why stetho-repl-js fails.
Any ideas?

Any news on this pull request?

Sorry for the review delay, I've been focusing on a big thorn in my side: https://github.com/facebook/stetho/pull/197 :)

Do you mind changing the PR title to something more descriptive like "Implement Console tab support with Rhino"?  Makes things nicer when it gets merged :)

Any more updates?  I think with the latest round of feedback implemented this should be merge-able.

I didn't finish going through all comments/remarks. Let me review the branch this evening and merge the commits. I now have a bit more free time and I can work on this.

Ok, I've rebased all my  changes and removed the commit that modifies stetho-sample so that it doesn't use the javascript repl (I believe that this was requested at some point).
Code can still be improved at some point:

use a custom writeToConsole
find a way to get a handle to JsonRpcPeer for the console output

I still believe that as a preview the current basis is solid enough to be used, so we could merge this.

Oh I see, you actually changed the branch.  It looks like you're really expecting to merge https://github.com/potyl/stetho/tree/stetho/js-rhino, is that right?  If so, can you just push to the original repl branch from js-rhino so I can merge with github's UI?

My bad! Once I get home i'll update the proper branch
On Friday, July 17, 2015, Josh Guilfoyle<EMAIL_ADDRESS>wrote:

Oh I see, you actually changed the branch. It looks like you're really
expecting to merge https://github.com/potyl/stetho/tree/stetho/js-rhino,
is that right? If so, can you just push to the original repl branch from
js-rhino so I can merge with github's UI?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/stetho/pull/188#issuecomment-122222896.

--
Emmanuel Rodriguez

I've pushed to the proper branch. Turns out that I also confused the commits and I previously left the commit to add the javascript to the stetho-sample app and removed the documentation on how to integrate it. This is also now corrected in the stetho/repl branch.

Very minor documentation comments; this is otherwise ready to merge.  Great work, I'm so excited for this feature!

Thanks for spotting the 2 documentation errors. I've squashed the fix and ran a grep. No more occurrences of the old repo name.

Excellent, I'm AFK this weekend but will merge when I get back.  Awesome
stuff :)
El sáb., 18 de julio de 2015 0:26, Emmanuel Rodriguez <
<EMAIL_ADDRESS>escribió:

Thanks for spotting the 2 documentation errors. I've squashed the fix and
ran a grep. No more occurrences of the old repo name.
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/stetho/pull/188#issuecomment-122508398.

Thanks a lot!
Cheers.

EvaluatorException for sql query is this caused by Rhino?


techdocs - font size too small for note\attention...

font size within note\attention is 10.24px which is too small.
Expected Behavior
font size should be 12.8px which is same as mkdocs.

Current Behavior
font size is 10.24px

Possible Solution
inject style to make font size bigger,  add following code to https://github.com/backstage/backstage/blob/master/plugins/techdocs/src/reader/components/Reader.tsx

Steps to Reproduce
Context
Your Environment

NodeJS Version (v12):
Operating System and Version (e.g. Ubuntu 14.04):
Browser Information:

font size within mkdocs note is 12.8px, but in techdocs it's 10.24px, the reason is that in mkdocs, the root font size is 20px, so the note font size is 20px0.64 = 12.8px, but in techdocs, the root font size is default 16px, so the note font size is 16px0.64=10.24px, if we change the relative size to 0.8rem, then the note font size(16px*0.8=12.8px) is same as techdocs.

We can close this as well as a fix has been released in #5778
@freben

Ok!


Halt() does not unblock WaitForEdge()

According to the documentation, calling Halt() or In() on a pin should cause WaitForEdge() to unblock and return false. When I attempt to do this on a Raspberry Pi Zero W, however, WaitForEdge() does not become unblocked.
package main

import (
	"fmt"
	"time"

	"periph.io/x/periph/conn/gpio"
	"periph.io/x/periph/conn/gpio/gpioreg"
	"periph.io/x/periph/host"
)

func main() {
	if _, err := host.Init(); err != nil {
		panic(err)
	}

	aPin := gpioreg.ByName("23")
	aPin.In(gpio.PullUp, gpio.BothEdges)

	go func() {
		time.Sleep(1 * time.Second)

		fmt.Println("calling Halt()")
		aPin.Halt()
		fmt.Println("called Halt()")
	}()

	fmt.Println("wait for edge")
	aPin.WaitForEdge(-1)
	fmt.Println("done waiting for edge")
}

This program will output:
wait for edge
calling Halt()
called Halt()

and then block indefinitely.
Platform:

OS: Raspbian GNU/Linux 9
Board: Raspberry Pi Zero Wireless

Sorry I didn't have time to play with this locally and won't likely have time until this weekend. :/

Sorry I didn't have time to play with this locally and won't likely have time until this weekend. :/

Don't worry about it. I don't need it for anything critical -- it's only for a small side project I'm working on.

Manually ported to https://github.com/periph/host/issues/36.


UTF-8 support

Would love to see UTF-8 support in ihaskell output cells. It just requires some pretty printer wrapper like described in this answer for the same problem with ghci. I've already tried to fix it myself, by changing every show in IHaskell.Display.Basic instance. But it didn't fix the issue. I'm guessing some other instance is responsible for the output. Just point me at it and I will pull request myself :)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

It seems like this is what you're looking for.

But for what type I should write an instance for? I already tried to change instance Show a => IHaskellDisplay (Maybe a) where from IHaskell/ihaskell-display/ihaskell-basic/IHaskell/Display/Basic.hs, and it didn't work.

I don't think this is a display instance issue... I think this is just an issue with encodings as data goes from kernel to ipython. Is this an issue with e.g. Putstrln? Because that is just stdout to kernel directly, so is an issue with iHaskell internals. (Sry phone)

Normal output contains characters escaped "\1092\1099\1074\1072" and putStrLn prints gibberish. So I think it is both, a problem with IHaskell.Display and encodings.

Putstrln output doesn't go through the display mechanism. Stuff output to stdout is captured and sent separately

Check out capturedStmt in util.hs or evaluate.hs for the start point

This is done now.

Standard cell output can't print unicode, while putStrLn can:

I think this issue should be reopened.


Parse INSTREAM-ID in Alternative

Instream-ID is needed for making CEA608 info.

Why? Please add something into description.

Why? Please add something into description.

Ok, updated description

the code lgtm, but is there any unit test? Also, update the description that this field is from HLS v6.

I think the change is simple, also I don't see any unit test exist for other fields to adapt.
Will update description for HLS v6


Adding contributor name

My (small) contribution so far: https://github.com/apache/camel/commits?author=dimitrisli
and looking forward to much more.

Thanks


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

Wrong master


Help with running the executable

Describe the bug
When i try and run the exe it shows me an error, log: "Traceback (most recent call last):
File "source_prepared.py", line 122, in
File "shutil.py", line 436, in copy2
File "shutil.py", line 258, in copyfile
FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\kocicakcz585\Pysilon\Pysilon.exe'
"
To Reproduce
Steps to reproduce the behavior:

Generate source and compile
Run the executable it gives you (in the dist folder)

Expected behavior
No error and open channels on discord
Desktop (please complete the following information):

OS: [Windows 11]
Python Version: [3.11.6] <python --version>

Additional context
Had the same issue like 4 months ago, i upgraded to windows 11 but still having problems, if possible contact on discord: the_weird_cat.guy

executed_at_2024-12-11_20-02-48.log
this is the log when i enabled debug mode (and recompiled and ran a new file)

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)


Local run fails with latest master

The following error occurs:
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.apache.camel.k:camel-k-runtime-quarkus:jar is missing. @ line 51, column 17
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.apache.camel.k.integration:camel-k-integration:1.3.0-SNAPSHOT (/private/var/folders/p_/q4fyy07j12s2g_psz87cbf300000gn/T/maven-772813202/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for org.apache.camel.k:camel-k-runtime-quarkus:jar is missing. @ line 51, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
failure while building project: exit status 1

The solution to this is that now that the main runtime has been eliminated there is no longer a need to pass the quarkus runtime on the command line as a dependency:
Removing:
-d camel-k:runtime-quarkus

from the kamel local run command line solved the issue.

The solution to this is that now that the main runtime has been eliminated there is no longer a need to pass the quarkus runtime on the command line as a dependency:
Removing:
-d camel-k:runtime-quarkus

from the kamel local run command line solved the issue.


Do not wait for copy to complete before returning from updatePixels.

I'm using your ESP32 RMT based LED driver for synchronized LED costume I'm working on.  Find it awesome, but wanted to share a small tweak I did for performance.  I am running 6-8 strands of LEDs (64-256 in length) and the updatePixels call was taking a considerable amount of time.  I parallelized it by not doing the semaphore take/delete until the next call to update.  This allow multiple strands to be kicked off in parallel, and to also overlap the drawing of the next frame with the writing of the previous frame.  I haven't noticed any glitches with it yet, but I haven't looked too closely at the code to follow the intricacies of why it was structured the way it was.

Very interesting! I haven't had a lot of time to work on the driver lately, but I will definitely give your PR a look when I have some time and consider it.
How much of a performance boost did you notice?

I made these changes a while back and just emailed you about them instead of generating a pull test.  I've run them for quite a long time without noticing any issues without them.
Quickly running some quick tests with 8 strands (most at 128, one at 256), showed frame to frame time of 33-52ms without my change and 7-25ms with time, so pretty substantial.


[RFC] Include Origin as Vary  header for cacheable responses

fixes #123
For cacheable responses the Vary header should include Origin to let caching proxies respect the request's origin.

Great! It's btw not only caching proxies but also browsers which can cache the OPTIONS request.

@Seldaek any comments on this PR? Would be great to get it merged.

2.1.0 is released

Shouldn't Access-Control-Request-Headers and Access-Control-Request-Method be added to Vary as well?

Are you using Apache? Apache has a bug where it strips CORS headers from cached 304 responses.

The 304 issue in Apache is https://bz.apache.org/bugzilla/show_bug.cgi?id=51223
Something like https://lists.w3.org/Archives/Public/www-archive/2017Aug/0000.html indicates that browsers ignore the Vary header in some cases and still serve cached results... the forced_allow_origin_value should also work there... maybe.
I'm kinda baffled that all this is so broken..


is SSR supported?

Hi,
I just started using react-boilerplate code for my project which require SSR. Even after following some discussion and PRs i am not clear about how to integrate SSR in this boilerplate. Is it supported now?
Please help. Thanks!

It's not supported.


fix: fix bugs for ui

Codecov Report

Merging #354 (134457d) into feature-nervos-to-ethereum (7e6cf5c) will decrease coverage by 3.76%.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           feature-nervos-to-ethereum     #354      +/-   ##
==============================================================
- Coverage                       42.72%   38.96%   -3.77%
==============================================================
  Files                              24       16       -8
  Lines                            1959     1699     -260
  Branches                           58        0      -58
==============================================================
- Hits                              837      662     -175
+ Misses                           1122     1037      -85

Impacted Files
Coverage Δ

...es/eth-contracts/contracts/libraries/SafeERC20.sol

...in-modules/eth-contracts/contracts/ForceBridge.sol

...les/eth-contracts/contracts/libraries/SafeMath.sol

...ules/eth-contracts/contracts/NervosMirrorToken.sol

...ules/eth-contracts/contracts/libraries/Address.sol

...th-contracts/contracts/libraries/MultisigUtils.sol

...n-modules/eth-contracts/contracts/AssetManager.sol

...ain-modules/eth-contracts/contracts/test/ERC20.sol

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6cf5c...134457d. Read the comment docs.


Clean up code

Remove all unneeded imports and double-check commented sections for relevance. Also, add options to config/environment files rather than inside code.

Basic code clean-up performed.


Fix eslint errors

CI builds are failing due to errors in publish.js.  This fixes
them, and adds the label in the correct spot in a url.

@loafyloaf does this failure in eslint mean it's suffering from the same error it's going to fix?

@kennjason eslint itself is not failing.  it is working, and thereby showing deficiencies in the code

eslint now passes, CI currently stuck on html-lint...


feat(asset): load dependencies only once, change ttlcache to map

Pull Request
We don't need Cache for our dependencies, storing them in memory once it's enough.
Setting the dependencies in queryEditor wasn't consistent.
Dependencies wouldn't load unless a query was made.
👩💻 Implementation
Used Map for easy retrieval of data instead of TTLCache.
Updated how the queryEditor knows when the loading is finished, used rxjs for it in order to make sure we load the data after everything is set.
Dependencies are loading regardless, if a query is ran at the start it will wait for the dependencies to load, no extra loading is done.
🧪 Testing
Plugin behaves the same.
✅ Checklist

[x ] This PR has a title that follows the commit message format.

@mure we needed a small type update in the core, can you please check it as well?

:tada: This PR is included in version 3.27.0 :tada:
The release is available on:

v3.27.0
GitHub release

Your semantic-release bot :package::rocket:


Non-zero balances when zero is expected

In fifo_open_positions.odt in the "Asset" and "Asset - Exchange" tabs I am seeing a few cases where Exchange balances for certain Access should be zero, but they are non-zero by a tiny fraction. For example: 0.00000000003 and 0.00000000011.
In all cases the funds should have been fully transferred out of the particular Exchange (resulting in a zero balance), but this is not reflecting correctly in the open positions. I have checked the numbers in the spreadsheet multiple times, and I'm pretty sure they are correct (i.e. should be zero). It's not a big deal, but as someone who likes things to be precise, it's a little distracting.
Is this an expected situation given imprecision of the underlying number types (either in LibreOffice or Python), or could there be something else going on here?
I'm happy to create a test case to replicate this, but before I do so I just wanted to ask, "Is this normal?" (If it is expected, no worries; feel free to close the ticket.)
Thanks!

Errors around the tenth decimal position could be due to precision limits (RP2 uses 13 digits of precision, I'm not sure what LibreOffice's limits are). Do you see similar errors in the rp2_full_report.ods file?

Hi. Thanks for the reply and the info.
To your question, yes, the same thing shows in the rp2_full_report.ods file.
Actually, I'm seeing another issue that I think is related to precision. It's resulting in the "Total in-transaction crypto value < total taxable crypto value" error occurring (when I believe there should be none).
In both cases I think the numbers should "zero out" nicely, but they're resulting in either tiny positive exchange balances or tiny negative ones (producing an error).
I've got examples for both in the attached and have added comments to the sheets (in red) for explanation.
Interested in your thoughts. Thanks!
RP2_Test.zip


SomethingNice component made functional

Turn Class Component into Function Component #19

Good to hear that @xnt, i'm glad this was helpful,
Cheers!


Add more info

like not compatible with Optifine, etc.

But wasn't that obvious?

let me test with MCPatcher
在 2022-09-17 00:10:09，"Deex" @.***> 写道：
But wasn't that obvious?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


is there any info constitutional_evaluation function??

3.3 Training Loop

I guess evaluate_response_for_RL() could be used as a workaround. This function tries to use OpenAI's text-davinci-003 to return a reward number.

I guess evaluate_response_for_RL() could be used as a workaround. This function tries to use OpenAI's text-davinci-003 to return a reward number.

I think so too, thanks for the reply.


XSSFTable.SetCellReferences not exist in version 2.5.6

According this example NPOI 2.5.6 should contain method XSSFTable.SetCellReferences but it doesn't.
Same for XSSFTable.CreateColumn(), XSSFTable.StyleName and XSSFTable.Style

The new interface of XSSFTable is delayed to be released with NPOI 2.6.0 instead of 2.5.6.

This version may help you create the table based on NPOI 2.5.6 and below
https://github.com/nissl-lab/npoi-examples/commit/dcffde317640c496a9f8e33bd4808b75707cca27


[SPARK-39214][SQL][3.3] Improve errors related to CAST

What changes were proposed in this pull request?
In the PR, I propose to rename the error classes:

INVALID_SYNTAX_FOR_CAST -> CAST_INVALID_INPUT
CAST_CAUSES_OVERFLOW -> CAST_OVERFLOW

and change error messages:
CAST_INVALID_INPUT:
The value <value> of the type <sourceType> cannot be cast to <targetType> because it is malformed. ...
CAST_OVERFLOW:
The value <value> of the type <sourceType> cannot be cast to <targetType> due to an overflow....
Also quote the SQL config "spark.sql.ansi.enabled" and a function name.
This is a backport of https://github.com/apache/spark/pull/36553.
Why are the changes needed?
To improve user experience with Spark SQL by making errors/error classes related to CAST more clear and unified.
Does this PR introduce any user-facing change?
Yes, the PR changes user-facing error messages.
How was this patch tested?
By running the modified test suites:
$ build/sbt "testOnly *CastSuite"
$ build/sbt "test:testOnly *DateFormatterSuite"
$ build/sbt "test:testOnly *TimestampFormatterSuite"
$ build/sbt "testOnly *DSV2SQLInsertTestSuite"
$ build/sbt "test:testOnly *InsertSuite"
$ build/sbt "testOnly *AnsiCastSuiteWithAnsiModeOff"

Authored-by: Max Gekk<EMAIL_ADDRESS>Signed-off-by: Max Gekk<EMAIL_ADDRESS>(cherry picked from commit 66648e96e4283223003c80a1a997325bbd27f940)
Signed-off-by: Max Gekk<EMAIL_ADDRESS>

Merging to 3.3. Thank you, @gengliangwang and @dongjoon-hyun for review.


Display of an Organization's information

When I visit an organization's root page I see in the footer (replacing the default content that is currently in the footer):

The organization's address
The organization's phone number

@jadekstewart3 I'd be happy to take this one. Just looking into it and I'm wondering what should be shown for an address? It looks like the Location model doesn't actually have a street address just a city, state/province, zipcode and country.

@sean-dickinson All yours!

It looks like the Location model doesn't actually have a street address just a city, state/province, zipcode and country.

City, state/province, zipcode and country is good. organization_profile model has the phone number. Let me know if you have any more questions.


Bot Service nos responding or too slow

Bot Info
SDK Platform: .NET
SDK Version: 3.14.1
Active Channels: DirectLine, WEBCHAT
Deployment Environment: Azure App Service
Issue Description
The bot is not responding to the received messages. No changes in bot in the last few weeks, not sure why this is happening. The same issue with another 2 bots, endpoint are up and listening.

Code Example
var bot = new builder.UniversalBot(connector, function (session) {
//send welcomecard when bot initiate
session.send( '/faq#'+ session.gettext('beforestat'));
session.sendTyping(); //choose a languange
var gifcard =  new builder.AnimationCard(session)
.media([
{ url: _conf.gifs.wl1  }
])
.buttons([
builder.CardAction.imBack(session, session.gettext(MainOptions.start), MainOptions.start)
//builder.CardAction.imBack(session, session.gettext(MainOptions.cancel), MainOptions.cancel)
]);
session.send(new builder.Message(session)
    .addAttachment(gifcard));
session.sendTyping();

}
//session.send("question1");

}).set('storage', inMemoryStorage);
The bot should reply with a message and a Card
Actual Results
The bot don't answer or it is too slow.

Hi @gabosdk
Please provide a botid for one of the bots? (Bot Handle in the Azure Portal)  Also, please provide the corresponding MicrosoftAppId.
Which data center is the bot hosted in?

Closing due to no response.


Handling nested views inside dialog

We are handling nested views in page level and it works fine. but we are not able to display nested views inside dialog.
I have tried using ui-router as well with ui-roter-extras using sticky state
ui-router
http://plnkr.co/edit/E2j471?p=preview
ui-router with ui-router-extras (sticky state)
http://plnkr.co/edit/6iL0mq?p=preview
In the above samples, Check the following navigation's
Click "First Page" > Click "Popup Page" > Click "Child Page1" or "Child Page 2"
Child Pages are not getting displayed inside dialog.

This seems to be a side effect of how bootstrap places the modal DIV as a child of <body> tag.  The ui-view tag thinks it is a top-level ui-view because it walks up the DOM looking for its parent ui-view context, and only finds the root.
If you change your state declarations to target named ui-views in the root context, then they populate.
  $stateProvider.state('first.popup.child1', {
    url: '/child1',
    views: {
      'child1View@': {
        templateUrl: 'child1.html'
      }
    }
  });

  $stateProvider.state('first.popup.child2', {
    url: '/child2',
    views: {
      'child2View@': {
        templateUrl: 'child2.html'
      }
    }
  });

This isn't a bug in ui-router-extras, not ui-router really.  This is an unintended interaction between bootstrap-ui modal and ui-router ui-view logic. The only way to do this "the right way" would be to get the modal div inserted into the DOM as a child element of the parent ui-view.

Thank you Chris!! As you said, Absolute named view (putting @ end of the name) is working fine.


Fix the misspelled assertion for 2-arg and 3-arg slice bound checks

Looks like the build is failing - do more tests need updating?

Looks like the build is failing - do more tests need updating?

Should be fixed now, had to step out for lunch :)

LGTM, thanks!


Error during kubernetes cluster installation

I am getting this error during installation:
ubuntu@master:~$ sudo kubeadm config images pull
failed to pull image "registry.k8s.io/kube-apiserver:v1.26.1": output: time="2023-02-14T11:21:55+05:00" level=fatal msg="validate service connection: CRI v1 image API is not implemented for endpoint \"unix:///var/run/containerd/containerd.sock\": rpc error: code = Unimplemented desc = unknown service runtime.v1.ImageService"
, error: exit status 1
To see the stack trace of this error execute with --v=5 or higher

Please download
install.sh: https://github.com/omerbsezer/Fast-Kubernetes/blob/main/install.sh
master.sh: https://github.com/omerbsezer/Fast-Kubernetes/blob/main/master.sh
chmod 777 install,sh
./install.sh
chmod 777 master.sh
./master.sh [MasterNodeIP]
If your PC is not behind the Proxy Server, it will work. I run install.sh. It works on my PC (in multipass):


added logging to help with perf debugging.

This code adds log statements with "START" and "END" keywords so that we can then process the logs and see (i) how many times a specific operation was called, (ii) how long the operation took (per call, or in aggregate).
In addition it has the notion of intermediate "steps" so we can drill down individual operations.

This is great! I'm glad you're making the tools we need to dig into performance.
A few things:
(1) Have you tested this? If so, how?
(2) Is there any issues with BunnyLog not being Serializable? It is used within processElement, so I'd expect it'd need to be.
(3) Please add some unit tests. I was thinking something like a fake program that just had delays (sleep) and verifying that the times produced were at least those you'd expect with the delays.
(4) I expect that this will eventually be paired with a logs analysis script. Do you have specific plans yet? I'd love to see a doc explaining what logging you'd like to see and how you think we should analyze it.

Thanks for having a look, David!
(1) I have tested it by running an instrumented BQSR and generating a report for it. I haven't checked in the reporting code yet - it's still very much in flux, and I'm not quite sure where to put it. Perhaps it should even be a separate project, since it's not hellbender-specific.
(2) This class is designed to not being transferred from one machine to another, so the timestamps are consistent. The idea is that a "START-END" span corresponds to a piece of work done on a single machine. It could also theoretically correspond to some "master" machine sending work and then getting answers back - but in both scenarios, all the log entries from the same operation come from the same machine.
(3) That would be testing log4j, not BunnyLog. I can try to find some way to add a test, sure.
(4) Yes, I started work on the analysis program already. It generates a report of how many times each operation was called, average call time, total CPU time. It also generates a visualization of when things are running. The latter turns out to be quite useful as we can see where there are gaps - indicating that some unlogged operation is taking longer than expected.

(1) Sounds good.
(2) Ah, makes sense. I thought I saw the creation of the bunny outside of the scope of the worker (which it isn't)
(3) Yes and no. Suppose you switched/refactored from log4j to something else, you'd want to know that the timing still makes sense (or if log4j messed up their timing in a new release). It's not really an issue as log4j isn't going to mess up big and whatever you'd change to would also likely be as already tested as log4j.
I'll leave it up to you if you want to add timing tests or not.
(4) Great!
I think this work is something that we should keep the Dataflow team abreast of. There is no reason why great profiling tools couldn't eventually make their way into the SDK code and Google Console.
LTGM. Feel free to merge once my whitespace comment is addressed (with or without any more tests).

OK, that should be good. I'm going to squish, rebase, all that good stuff.

There you go, a clean rebased commit. That maintains the previous whitespace.

LGTM again


Searching Google Poland

Thanks for the update...small problem, it's searching Google Poland instead of Google.com

fixed in #15

Brilliant...Thanks


Pagination by models.collections

Hi,
Here I have a scenario which there is a new list on my site. I want to make it in pagination via models.news. But I have no idea how to implement this feature. Any example?
And how can I get the size of models.news.
Looking forward to someone can give me a help. Thx.


Fixes #82: Use InputProps in AutocompleteElement

The InputProps passed into the AutocompleteElement were not being applied, this PR should fix that issue.
Please test before merging as I was unable to build the package locally to do so myself.

This issue has been resolved in 5.2.0


JAMES-3557 */changes: Fail explicitly when too much entries on a single change

This looks like just a workaround, is there no way to fix this issue to turn into the correct behavior?

No not really. If the chunck is too large, the chunk is too large. The client should use a bigger /changes then.
An alternative would be to , upon insert, generate several smaller changes instead than one big. But I don't like this approach much, to be honnest.

No not really. If the chunck is too large, the chunk is too large. The client should use a bigger /changes then.

What is the point of having hasMoreChanges field and mechanic from the spec then if the chunk is too large we return an exception anyway? I'm trying to understand the logic behind this choice (and not about the technical limitations we might have from our code), which seems odd to me sorry

02:30:07,088 [INFO] Running org.apache.james.mailbox.cassandra.CassandraMessageIdManagerStorageTest
02:31:24,808 [ERROR] Tests run: 60, Failures: 0, Errors: 60, Skipped: 0, Time elapsed: 77.705 s <<< FAILURE! - in org.apache.james.mailbox.cassandra.CassandraMessageIdManagerStorageTest
02:31:24,809 [ERROR] setInMailboxesShouldAllowCopyingMessageFromReadOnlySharedMailbox  Time elapsed: 0.594 s  <<< ERROR!
java.lang.NoClassDefFoundError: org/apache/james/events/EventBusTestFixture
	at org.apache.james.mailbox.cassandra.CassandraMessageIdManagerStorageTest.createTestingData(CassandraMessageIdManagerStorageTest.java:41)
Caused by: java.lang.ClassNotFoundException: org.apache.james.events.EventBusTestFixture
	at org.apache.james.mailbox.cassandra.CassandraMessageIdManagerStorageTest.createTestingData(CassandraMessageIdManagerStorageTest.java:41)

weird?

What is the point of having hasMoreChanges field and mechanic from the spec then if the chunk is too large we return an exception anyway? I'm trying to understand the logic behind this choice (and not about the technical limitations we might have from our code), which seems odd to me sorry

Still waiting an answer regarding this concern?

Say we mutate<PHONE_NUMBER>345345 messages at the same time.
We will store the changes in a single row.
We should return all the changes.
But if the maxChanges parameter is too low (say 256) then we can not return<PHONE_NUMBER>345345 ids as it would exceed the client maxChanges. So we don't.
Today behaviour is to stay stuck (ouch!). Clients not aware of the bug will thus not be able to resync themselves.
With that changes, we return I can not sync given your max changes. The client can then resync with a higher max changes, or do a full resync...

What is the point of having hasMoreChanges field and mechanic from the spec then if the chunk is too large we return an exception anyway?

It is for when you page updates (eg 4098 changes but I resync 256 at a time - wich works if we do not have crazy large records).

I'm trying to understand the logic behind this choice (and not about the technical limitations we might have from our code)

Fair.
Ideally we could "chunk changes" by batches of say 256 upon saving them in the changelog so that no changelog entry exceeds a decent maxChanges value.


include supplemental_display_text in textToSpeech

Since displayText is initialized to [] the expression !assistResponse.displayText will always be false. This prevents having the textToSpeech array take the value of data.dialog_state_out.supplemental_display_text as desired.
This likely contributes to issue #29

Sorry for the mess here. I had to amend the author email because of the CLA issue. I have signed the CLA with the email used in the last commit. So I'm just going to leave this alone until I get more guidance.

Hey @pdtyreus the change looks good, but we'll still require the CLA to be signed, or maybe resigned, before this can be merged.

I had a corporate CLA on file. Just created a personal version also. Maybe that will do the trick.

Thanks!