data:AyebakuroOruwori

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

What do you suggest ?

What do you suggest ?

Hey @AyebakuroOruwori, not sure why did you close your PR after it is being approved by 2 maintainers. It should be ready to merge!?


systemd: 256.6 -> 256.7

https://github.com/systemd/systemd/compare/v256.6...v256.7
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The only thing that stands out to me in the release notes is https://github.com/systemd/systemd/commit/d64193a2a652b15db9cb9ed10c6b77a17ca46cd2
I feel we can just merge this and see if problems pop up in the staging cycle


Update validationmethod documentation to use JsonIgnore

Added @JsonIgnore to example validation method. Whilst the application will work without this flag, it will fail during testing as additional paramters will be added to the created JSON StackOverflow: http://stackoverflow.com/questions/26551726/dropwizard-validationmethod-adding-a-json-property
To be safe, and promote unit testing, this should be included in the example documentation.

Looks like it's worth to add. Thanks.


JSON support.

It turns out that when using a strictyaml schema, the supported subset
of YAML doesn't include JSON. So we need explicit JSON for loading too.
Closes #109.

This looks great! Thanks for tackling this @grahamgower


Notify CMake on Windows about CUDA

Hey,
Thanks for your awesome Github action! My question might be a bit out of scope of this repo, but I wonder whether you could still help me.
I am trying to build something on windows and ubuntu and need nvcc for that. The build process is like:
conda-build --> ptyhon setup.py --> CMake --> nvcc
Locally, the build runs fine, but I wonder how I can tell CMake the CUDACXX on a windows runner?
If you want to have a look, you can find the workflow below. I tried setting the CUDACXX via powershell but CMake does not find it.
Any ideas?
https://github.com/TuragaLab/SplinePSF/blob/9aa4e4569fce8550a7b22295191447f88ee592e9/.github/workflows/build_upload_test.yaml#L54-L80

Hi @Haydnspass
for cmake, one should be able to set variables via cmake -DVARIABLE1=value1. Otherwise I've seen using following syntax:
- name: SomeName
        run: myCommand
        env:
          VARIABLE1: 1

or
echo "VARIABLE1=1" >> $GITHUB_ENV

Hi @Haydnspass
for cmake, one should be able to set variables via cmake -DVARIABLE1=value1. Otherwise I've seen using following syntax:
- name: SomeName
        run: myCommand
        env:
          VARIABLE1: 1

or
echo "VARIABLE1=1" >> $GITHUB_ENV

Yes this is the proper way to pass environment variables around. Unfortunattely setting an environment variable in the shell in one step isn't saved to other steps.

Unfortunattely setting an environment variable in the shell in one step isn't saved to other steps.

For that, one can use global variables (e.g. GITHUB_PATH). Mind though that changes to these do not apply in the current action :D

Thanks for your answers! :) However, how would I set CUDACXX to your CUDA_Path? I think they are equivalent
This, naive, idea does not work (ignore the intendations)
- name: "Install CUDA Toolkit"
        if: ${{ matrix.os_base == 'windows' || matrix.os_base == 'ubuntu'}}
        uses<EMAIL_ADDRESS>        id: cuda-toolkit
        with:
          cuda: '11.2.2'

- name: try to echo
  if: ${{ matrix.os_base == 'windows' }}
  env:
    CUDACXX: $env:CUDA_PATH
  run: |
    echo $Env:CUDACXX

You could use something along these lines:
https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
So
- name: Set CUDACXX
    run: |
        echo "CUDACXX=$CUDA_PATH" >> $GITHUB_ENV

Not sure how that translates to powershell though.

Hm Okay,
so I managed to set and save the environment variable (by the way it needs to be CUDACXX=${{ env.CUDA_PATH }}\bin\nvcc.exe) when I use it directly.
Strangly, cmake

finds the cuda toolkit
warns me that is has not used the CUDACXX variable ?!
does not find the CUDA compiler

I don't quite get it 😅 If you want to have a direct look, you can see the workflow here: https://github.com/TuragaLab/SplinePSF/actions/runs/682310612/workflow (only windows relevant for now)
Here is what it says
# first I queried where nvcc is
Run Get-Command nvcc | Select-Object -ExpandProperty Definition
C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.2\bin\nvcc.exe

    Directory: D:\a\SplinePSF\SplinePSF\cpp_cuda_c

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        3/24/2021   8:13 AM                build
-- The CXX compiler identification is GNU 8.1.0
-- The C compiler identification is GNU 8.1.0
-- Check for working CXX compiler: C:/ProgramData/chocolatey/bin/c++.exe
-- Check for working CXX compiler: C:/ProgramData/chocolatey/bin/c++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: C:/ProgramData/chocolatey/bin/gcc.exe
-- Check for working C compiler: C:/ProgramData/chocolatey/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for a CUDA compiler
-- Looking for a CUDA compiler - NOTFOUND
-- Found Python: C:/hostedtoolcache/windows/Python/3.8.8/x64/python3.exe (found version "3.8.8") found components:  Interpreter Development
-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- Found pybind11: C:/Miniconda/envs/spline_dev/Library/include (found version "2.6.2" )
-- Found CUDA: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.2 (found version "11.2")
CMake Warning at CMakeLists.txt:20 (message):
  No CUDA compiler found or disabled by user defined command line variable
  '-DCUDA_DISABLED=True'.

     You may need to specify its path like 	'export CUDACXX=/usr/local/cuda/bin/nvcc'

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    CUDACXX

-- Build files have been written to: D:/a/SplinePSF/SplinePSF/cpp_cuda_c/build
[1/4] Building C object CMakeFiles/spline_psf_cpu_impl.dir/src/spline_psf.c.obj
[2/4] Linking C static library libspline_psf_cpu_impl.a
[3/4] Building CXX object CMakeFiles/spline.dir/src/pybind_spline.cpp.obj
[4/4] Linking CXX shared module spline.cp38-win_amd64.pyd

I think cmake sometimes has trouble with backslash paths, maybe you can try something like this:
run: |
  $CUDA_PATH_FORWARD_SLASH = "$env:CUDA_PATH" -replace "\\", "/"
  cmake -GNinja -DCUDACXX=${{ env.CUDA_PATH_FORWARD_SLASH }}/bin/nvcc.exe ..

Very good comment. Still don't manage... Found somewhere that it actually needs to be just CUDA instead of CUDACXX in "new CMAKE". This lead to CMAKE at least not complaining about an unused env variable (which I believe is good?)
I also hard-coded the path with UNIX slashes, still doesn't work... Very strange.
https://github.com/TuragaLab/SplinePSF/actions/runs/683102570/workflow

I think I made it work using an updated CMake plus configuration change: see my PR: https://github.com/TuragaLab/SplinePSF/pull/12


Adds background thread to pull account updates from ZK

This PR adds a background thread that pulls the account update from ZK
in addition to being triggered by account update is made. This is to
avoid missing update due to unexpected behavior of listener, and add
confidence that after a period of configured time, it will always get in
sync with the remote accounts.
Test: clean build

Codecov Report

Merging #742 into master will decrease coverage by 0.08%.
The diff coverage is 88.46%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0dac4...702823d. Read the comment docs.

@vgkholla @pnarayanan @cgtz Have made the latest commit with test passed.

Removed the pre- and post- checks as we have enough confidence that the thread will eventually go away (there was a temporary code waiting for 100ms to wait the thread to be gone, in commit
4a2c46c).

@pnarayanan Please take another look.


Cannot use load_model when using a layer with dynamic = True and saving to hdf5 format

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.4.1
Python version: 3.7
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: 11.0
GPU model and memory: NVIDIA Quadro RXT 6000, 24 GB NVRAM

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
When building a model (using the Function API), I need to use a layer in dynamic mode as far as I can tell, since the task is going to involve operations along an axis of variable size.
While the training works perfectly fine, and the saving of the model also does as far as I can tell (no error, at least), when loading the model back up using load_model fails with the error:
ValueError: You are trying to load a weight file containing [n] layers into a model with [n-1] layers.
Upon inspection of the load_weights_from_hdf5_group function, it appears that layers build with dynamic=True return an empty list with trying to get the weights, which results in such layers not being included in the following operations, ultimately resulting in the function failing. However, the layer itself is found and otherwise normal (e.g. its name gets found properly by the same function).
This affects both new models and ones saved before the update.
Describe the expected behavior
The model should load properly, as it did in previous versions (I have tested up to 2.3.1).
Standalone code to reproduce the issue
I write two versions of the same little script, the only difference is the dynamic flag in the first Conv2D layer.
I originally discovered this when using a custom layer (where the need for the dynamic=True flag came in), but this also happens when using the Conv2D layer.
from tensorflow.keras.models import load_model, Model
from tensorflow.keras.layers import Conv2D, Input

# this works
inp = Input(shape=(64, None, 3))
conv = Conv2D(4, (3, 3), dynamic=False)
# dynamic = True apparently requires manual building, which might or might not be a separate issue
conv.build(inp.shape)
x = conv(inp)
x = Conv2D(4, (3, 3))(x)

mod1 = Model(inputs=inp, outputs=x)

mod1.save("test.hdf5")
load_model("test.hdf5")
print("Succesfully loaded this model")

# this fails:
inp = Input(shape=(64, None, 3))
conv = Conv2D(4, (3, 3), dynamic=True)
# dynamic = True apparently requires manual building, which might or might not be a separate issue
conv.build(inp.shape)
x = conv(inp)
x = Conv2D(4, (3, 3))(x)

mod1 = Model(inputs=inp, outputs=x)

mod1.save("test.hdf5")
load_model("test.hdf5")
print("Succesfully loaded this model")`

**Other info / logs**
`Traceback (most recent call last):
  File "C:/Users/killian/AppData/Roaming/JetBrains/PyCharmCE2020.1/scratches/scratch_7.py", line 29, in <module>
    load_model("test.hdf5")
  File "C:\Users\killian\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\saving\save.py", line 207, in load_model
    compile)
  File "C:\Users\killian\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 187, in load_model_from_hdf5
    load_weights_from_hdf5_group(f['model_weights'], model.layers)
  File "C:\Users\killian\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 691, in load_weights_from_hdf5_group
    ' layers.')
ValueError: You are trying to load a weight file containing 2 layers into a model with 1 layers.
`

@kimartin,
Looking at issues #44533 and #43498 with a similar error log, I was able to save and load the model in tf format.
Please find the gist of it here. Thanks!

@amahendrakar Switching to the tf format as in the gist does provide a workaround for saving new models, thank you.
Unlike the issues mentioned however I had no problem with custom objects (in particular at least), just with the dynamic flag, so this definitely seems like a bug.

Was able to reproduce the issue in TF 2.6.0-dev20210528,please find the gist here..Thanks !

Thanks for opening this issue. Development of keras moved to separate repository https://github.com/keras-team/keras/issues
Please post this issue on keras-team/keras repo.
To know more see;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999
Thank you!


update(userspace/engine): support alternative plugin version requirements in checks

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
This PR updates the rule engine to support multiple alternatives plugin version requirements definitions in rulesets. The problem was first mentioned in https://github.com/falcosecurity/plugins/pull/134#discussion_r935806326, and documented in the #2150 issue.
Given that a new feature is added, the rule engine version has been bumped (to v15). Moreover, unit tests have been introduced to make sure that the plugin version checks work as expected.
Which issue(s) this PR fixes:
Fixes #2150
Special notes for your reviewer:
In this proposal, rulesets will be able to support the following syntax:
- required_plugin_versions:
  - name: k8saudit
    version: 0.1.0
    alternatives:
      - name: k8saudit-other
        version: 0.4.0

Here, alternatives represents a list of alternative plugin name-version pairs to be checked as alternatives to the primary one. Maintaining a primary plugin requirement definition, and making alternatives optional, allow backward compatibile definitions such as:
- required_plugin_versions:
  - name: k8saudit
    version: 0.1.0

Given so, required_plugin_versions now implicitly defines a CNF (Conjunctive Normal Form. Rulesets are correctly loaded if all the required_plugin_versions definitions are satisfied. Each entry is satisfied if at least one of its alternatives is satisfied.
Does this PR introduce a user-facing change?:
update(userspace/engine): support alternative plugin version requirements in checks

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 7d73d02f8a903b2d14d0953c42eb00dfc6156b82

I understood it correctly that we are expected to ship proper alternatives in default config when we support multiple plugins offering similar functionalities?

I understood it correctly that we are expected to ship proper alternatives in default config when we support multiple plugins offering similar functionalities?

By default config do you mean default rulesets? If so, yes, in our default rulesets we'll provide all the officially-supported known plugin alternatives for the rulesets we maintain. A first-class example are k8saudit and k8saudit-eks that's in the working (https://github.com/falcosecurity/plugins/pull/134).

Uh yes! thank you! Makes sense!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Make resource limit of embedded ES configurable

Users can configure the memory/cpu limit for the embedded ES.
There should be a minimum of the limit so that user input can't be small than it.

verified on rancher/server:master 04/10


After upgrading comfyui yesterday(2023/07/16), this plugin cannot be used

Traceback (most recent call last):
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\ComfyUI\nodes.py", line 1516, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\ComfyUI\custom_nodes\was-node-suite-comfyui_init.py", line 1, in
from .WAS_Node_Suite import NODE_CLASS_MAPPINGS
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\ComfyUI\custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py", line 37, in
from numba import jit
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba_init_.py", line 88, in
from numba.core.decorators import (cfunc, generated_jit, jit, njit, stencil,
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\decorators.py", line 12, in
from numba.stencils.stencil import stencil
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\stencils\stencil.py", line 11, in
from numba.core import types, typing, utils, ir, config, ir_utils, registry
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\registry.py", line 5, in
from numba.core import utils, typing, dispatcher, cpu
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\dispatcher.py", line 13, in
from numba.core import (
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\compiler.py", line 6, in
from numba.core import (utils, errors, typing, interpreter, bytecode, postproc,
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\callconv.py", line 13, in
from numba.core.base import PYOBJECT, GENERIC_POINTER
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\base.py", line 20, in
from numba.cpython import builtins
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\cpython\builtins.py", line 536, in
from numba.core.typing.builtins import IndexValue, IndexValueType
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\typing\builtins.py", line 22, in
@infer_global(print)
File "E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\python_embeded\lib\site-packages\numba\core\typing\templates.py", line 1271, in register_global
if getattr(mod, val.name) is not val:
AttributeError: module 'E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\ComfyUI\custom_nodes\cup' has no attribute 'wrap'
Cannot import E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\ComfyUI\custom_nodes\was-node-suite-comfyui module for custom nodes: module 'E:\AIProject\ComfyUI_windows0605\ComfyUI_windows\ComfyUI\custom_nodes\cup' has no attribute 'wrap'

this happens to me too

Reinstall the requirements, of course.

I reinstalled, but it didn't work

Then you didn't do it right. Like installing to system python and not your python embedded.

I reinstalled, but it didn't work

Then you didn't do it right. Like installing to system python and not your python embedded.

I reinstalled requirements both on system python and embedded python,but nothing changed, same errors.I think it should be caused by comfyui modifying some codes

It's probably the custom node importing it's files via spec or some other method instead of just importing them, thus when ND goes to read the file, those modules aren't loaded at all. Some other nodes require the promptServer which isn't running at all. A lot of custom node authors are writing hacks rather than modules to be imported by larger systems.

No, it's cause numba isn't there, meaning it is not installed on your ComfyUI portable python in embedded_python/python.exe


test: check @Pattern wth backslashes

Description
The @pattern doesn't contain expected regexp.
Related issue(s)
Reproduces #374

From what I remember, the test was failing for this MR.
We changed our mind on how to generate code from our asyncapi contracts, I will not be able to help about that :(


Validation: Server-side Blazor update user on reconnection

Each time you reconnect, it should refresh the authentication state.
See https://github.com/aspnet/AspNetCore/pull/12421

The feature itself works fine. However I've found there's another place we should also implement support for this, and filed #12692.


qutebrowser will not launch

Issue description
qutebrowser does not launch
Steps to reproduce
run 'qutebrowser' from a terminal or dmenu
Technical details
/nix/store/dagn6yc6rdk5ccs4z0zmx9qw3g6gcq92-qutebrowser-0.8.2/bin/..qutebrowser-wrapped-wrapped: line 3: /nix/store/dagn6yc6rdk5ccs4z0zmx9qw3g6gcq92-qutebrowser-0.8.2/bin/..qutebrowser-wrapped-wrapped: Argument list too long

System: 17.03pre99759.f66d782 (Gorilla)
Nix version: nix-env (Nix) 1.11.6
Nixpkgs version: "17.03pre99759.f66d782"

cc @abbradar

Strange; it works for me on 01fef3f7db4cc208faea31f26c9451b326058781 (current unstable channel); it has also worked before an update.
Can you show contents of /nix/store/dagn6yc6rdk5ccs4z0zmx9qw3g6gcq92-qutebrowser-0.8.2/bin/..qutebrowser-wrapped-wrapped?

#! /nix/store/gabjbkwga2dhhp2wzyaxl83r8hjjfc37-bash-4.3-p48/bin/bash -e export PATH=/nix/store/dahikpiipsk8qgih8y605czmn68vf4k0-python3-3.5.2/bin:/nix/store/dagn6yc6rdk5ccs4z0zmx9qw3g6gcq92-qutebrowser-0.8.2/bin:/nix/store/yfla    6in5zqjgl8z6aba6qrm5zp2g22hy-python3.5-setuptools-26.1.1/bin:/nix/store/qbh1zb3c2p2d7g1lv7m64zi0pz3l3adv-python3.5-PyQt-5.6/bin:/nix/store/5k7il30vgg5wmfa2    8hmy4fn5vvgnpif9-python3.5-sip-4.18.1/bin:/nix/store/lsvgxvg0wsbk90ifaw4k6l5v0fsvnsn8-python3.5-Pygments-2.1.3/bin:/nix/store/mi8vwsx0l4q7bdbqf98cnv2srw39d    m7r-python3.5-docutils-0.12/bin:/nix/store/vvryqybawqdbwfk934nzd6z3d5xf6rxj-python3.5-cssutils-0.9.9/bin${PATH:+:}$PATH exec -a "$0" /nix/store/dagn6yc6rdk5ccs4z0zmx9qw3g6gcq92-qutebrowser-0.8.2/bin/..qutebrowser-wrapped-wrapped "${extraFlagsArray[@]}" "$@"

Okay, nothing strange there; however I think I've seen this error when you environment is big -- here we make it bigger with export and then exec which triggers the error. Not sure how to measure that; what about:
> env | wc -m
5510

(mine given for comparison)?

[brad@kazuki:~]$ env | wc -m
3619

Oh wait. I've noticed the root of the problem: your wrapper executes itself for some reason.
I've checked out your NixOS version and the wrapper seems okay there. Do you install your qutebrowser via environment.systemPackages? I think I saw this problem long time ago (5 months maybe), maybe you have leftovers in nix-env?

I installed it using 'nix-env -i qutebrowser'. I'm still new to NixOS so I don't have all my packages in my configuration.nix file or anything fancy like that.

No problem! However, let's then check if you have any local channels:
> nix-channel --list
> sudo nix-channel --list

nix-channel --list shows nothing, and sudo nix-channel --list shows this:
nixos https://nixos.org/channels/nixos-unstable
I did try to setup unstable as I am used to fairly new packages from running arch. I think I installed qutebrowser before I did this.

Oh, that might be the problem! Do you want to keep at unstable or return to release?

I would like to stay at unstable.

Then run:
> nix-env --always -u '*'

This should update all your packages to unstable versions. --always updates even packages that don't have a version bump but have hash changed (so it may be a bump of dependency or an actual change in the package -- we don't have separate concept of Arch's package revision).
BTW, I've checked and it seems that qutebrowser is indeed broken on stable. I'll backport a fix shortly.

Thank you so much for the help! After running that command to update my packages to the unstable versions, it works fine.

You are welcome ^_^


Game crash when selecting multiple linkable entities + any power line entity, and right-clicking the power line

Exactly what the title says. To reproduce the bug, use the selection tool to select multiple linkable entities(eg. portal elements), with at least one of the selected entities being a power line. Right click the power line, and the game will crash.

fddf8c52f6421293981f212ac3011e6296347b98


Make usemin option work without uglify.

I'm embedding my angular app inside a .NET MVC app, and want to let MVC's bundling handle the minification,  so I took uglify out of the usemin flow and am just using it for concatenation.
This change to the ngtemplates appender falls back on looking for the concat.generated task and appending its template concatenation to there instead.
I tried to write tests, but couldn't convince the usemin task to build both uglified and non-uglified files.

I using only concat as well and ngtemplate does not work. Have workaround this?
var useminPrepare = {
        options: {
            flow: {
                telenor: {
                    steps: {
                        js: ['concat'],
                        css: ['concat', 'cssmin']
                    },
                    post: {}
                },
                technetennis: {
                    steps: {
                        js: ['concat'],
                        css: ['concat', 'cssmin']
                    },
                    post: {}
                }
            }
        },
        telenor: {
            src: "<%= config.copy %>/index-telenor.html",
            options: {
                dest: "<%= config.temp %>"
            }
        },
        technetennis: {
            src: "<%= config.copy %>/index-technetennis.html",
            options: {
                dest: "<%= config.temp %>"
            }
        }
    };

TBH, I'm confused as to the current state of things here :)
If I had to guess, it's an issue unknown to me since each file is it's own module, so the order of concatenation does not matter.
Anybody else know what to do next here?

Hello, is this going somewhere? Still running into this issue and while the patch as such fixes the problem, it would be nice to be able to pull this from the official repository.
Tx!

CC'ing the new owners... @underscorebrody @hvdb @aaani

I opened a new PR with this change cherry-picked onto it plus some modifications to our tests that will allow us to run with or without uglification. Closing this PR in favor of https://github.com/ericclemmons/grunt-angular-templates/pull/153


Deprecate OP_AUTO_ENCODING

See https://github.com/php-http/fig-standards/issues/37#issuecomment-328065775 for a better alternative that doesn't need options, but gives compression by default.

Done in master.


escape sql special characters

It is not enough to just escape "double quote". I have added "backslash" and "single quote" as well for my cases
https://github.com/go-sql-driver/mysql/blob/master/utils.go#L606-L652

good


[Improvement] (merge function) Multiple merging dict

My current hugo version:

Hugo Static Site Generator: v0.74.3-DA0437B4 linux/arm
BuildDate: 2020-07-23T16:22:34Z

The current merge function only allow merge a pair of dict. However, in a certain case, more than two dicts could be merged. For example, if you want to make JSON template, dict is the best option for clean code. But if an object with too many properties could lead to a huge trouble.
{{- $obj := newScratch -}}
{{- $obj.Add "list" slice -}}
{{ $paginator := .Paginate (where .Site.RegularPages "Type" .Site.Data.Sections.Home.main) }}
{{- range $paginator.Pages -}}
	{{- $obj.Add "list" (dict "title" .Title "url" .Permalink "author" .Params.author "desc" .Description "pubdate" (dict "short" (.PublishDate.Format .Site.Params.DateFormats.Short) "long" (.Date.Format "2006-01-02T15:04:05") )) -}}
{{- end -}}
{{- $obj.Get "list" | jsonify -}}

Instead of that, merge is recommend to break down an infinitive long line for the sake of clean code.
{{- $obj := newScratch -}}
{{- $obj.Add "list" slice -}}
{{ $paginator := .Paginate (where .Site.RegularPages "Type" .Site.Data.Sections.Home.main) }}
{{- range $paginator.Pages -}}
	{{- $sDate := dict "short" (.PublishDate.Format .Site.Params.DateFormats.Short) -}}
	{{- $lDate := dict "long" (.Date.Format "2006-01-02T15:04:05") -}}
	{{- $pubdate := dict "pubdate" (merge $sDate $lDate) -}}

	{{- $require := dict "title" .Title "url" .Permalink -}}
	{{- $optional := dict "author" .Params.author "desc" .Description -}}

	{{- $obj.Add "list" (merge $require $optional $pubdate) -}}
{{- end -}}
{{- $obj.Get "list" | jsonify -}}

But with the merge limited, the above code is impossible to achieve.
Error: Error building site: failed to render pages: render of "home" failed: "/bla/bla/bla/layouts/index.json:12:22": execute of template failed: template: index.json:12:22: executing "index.json" at <merge>: wrong number of args for merge: want 2 got 3

I think it would be nice if we could have this improvement for the next update.

Right now, I'm trying to get around with .SetInMap:
{{- $obj := newScratch -}}
{{- $obj.Add "list" slice -}}
{{ $paginator := .Paginate (where .Site.RegularPages "Type" .Site.Data.Sections.Home.main) }}
{{- range $paginator.Pages -}}
	{{- $obj.SetInMap "item" "title" .Title -}}
	{{- $obj.SetInMap "item" "url" .Permalink -}}
	{{- $obj.SetInMap "item" "author" .Params.author -}}
	{{- $obj.SetInMap "item" "desc" .Description -}}

	{{- $sDate := dict "short" (.PublishDate.Format .Site.Params.DateFormats.Short) -}}
	{{- $lDate := dict "long" (.Date.Format "2006-01-02T15:04:05") -}}
	{{- $obj.SetInMap "item" "pubdate" (merge $sDate $lDate) -}}

	{{- $obj.Add "list" ($obj.Get "item") -}}
	{{- $obj.Delete "item" -}}
{{- end -}}
{{- $obj.Get "list" | jsonify -}}

But for more complex json. merge function still seems to work better.

I haven't read this is in detail, but wouldn't this be somehow the same: {{ $m = $m | merge $m2 | merge $m3 }}  ....?

Is it even possible to make a chain for merge? I didn't know about this.

It seems shorter to me :D

And potentially more effective, I agree.

I've submitted a PR for consideration.


Update OpenFHE in Yggdrasil to v1.2.3

It would be great if you could update the build recipe on Yggdrasil to use the current version of OpenFHE.

I have updated in the PRs https://github.com/JuliaPackaging/Yggdrasil/pull/9726 and https://github.com/JuliaPackaging/Yggdrasil/pull/9725
They will probably be merged already on Monday

Packages have been merged, thank you


version of generated JSON Schema

Please let me know which JSON schema version is the generated one compliant to.
Draft-04 or Draft-06.
I dont see the generated JSON Schema contains that information, please help.

Draft-04. Development was based on the attached book.
Are there important differences between Draft-04 and Draft-06? Is it important to output version information? How?
UnderstandingJSONSchema.pdf

Actually we needed the draft version to which the json schema is compliant is also an important information that can be part of auto generation.
It is important that being at server side we are planning to use json schema as a contract, so the client side will also be able to know which version of the json schema libraries they need to use.


Create new indexer for event watching

Current sync logic stores every event in memory during sync. This means that large initial syncs run OOM often. It is also difficult to debug exactly what is going on. Given our learnings, we can greatly simplify this process.
Two goals would be to (1) do not rely so heavily on memory to sync, (2) break up each individual piece to be more logical/manageable/debuggable.

Figure out how to not sync all the way back. In practice, we only need a few days of items except in rare cases. Accounting for this solves almost all resource issues we’ve ever seen with V1.

Possibly have an “archive” sync like geth, but honestly this will probably never be used and thus is not worth adding
It might be best to handle the “rare cases” mentioned above in a custom way. For example, if a G→P route isn’t widely used, it may be (an arbitrary amount of months) before the root is created. If we regularly prune, we won’t see all of these transfers anymore. We can have logic that says “if pruned, then recollect the data for use now”. This logic will be resource intensive, but only happens like 1 time per year so is worth

Closed with https://github.com/hop-protocol/hop/pull/612


Warnings about httpclient version when using clj-http with latest aws-sdk-java

When using [clj-http "3.9.1"] with [com.amazonaws/aws-java-sdk-core "1.11.612"], there is this warning.

WARN c.a.http.apache.utils.ApacheUtils - NoSuchMethodError was thrown when disabling normalizeUri. This indicates you are using an old version (< 4.5.8) of Apache http client. It is recommended to use http client version >= 4.5.9 to avoid the breaking change introduced in apache client 4.5.7 and the latency in exception handling. See https://github.com/aws/aws-sdk-java/issues/1919 for more information

See https://github.com/aws/aws-sdk-java/issues/1919 for more details.
clj-http 3.9.1 includes these
   [org.apache.httpcomponents/httpasyncclient "4.1.3" :exclusions [[org.clojure/clojure]]]
     [org.apache.httpcomponents/httpcore-nio "4.4.6"]
   [org.apache.httpcomponents/httpclient-cache "4.5.5" :exclusions [[org.clojure/clojure]]]
   [org.apache.httpcomponents/httpclient "4.5.5" :exclusions [[org.clojure/clojure]]]
   [org.apache.httpcomponents/httpcore "4.4.9" :exclusions [[org.clojure/clojure]]]
   [org.apache.httpcomponents/httpmime "4.5.5" :exclusions [[org.clojure/clojure]]]

clj-http 3.10.0 includes these, but this version is not usable due to #489.
   [org.apache.httpcomponents/httpasyncclient "4.1.4" :exclusions [[org.clojure/clojure]]]
     [org.apache.httpcomponents/httpcore-nio "4.4.10"]
   [org.apache.httpcomponents/httpclient-cache "4.5.8" :exclusions [[org.clojure/clojure]]]
   [org.apache.httpcomponents/httpclient "4.5.8" :exclusions [[org.clojure/clojure]]]
   [org.apache.httpcomponents/httpcore "4.4.11" :exclusions [[org.clojure/clojure]]]
   [org.apache.httpcomponents/httpmime "4.5.8" :exclusions [[org.clojure/clojure]]]

Order of including aws-java-sdk and clj-http in project.clj affects whether the warnings are shown.


Bad request :  https://device-manager.scratch.mit.edu:20110

I think the URL don't work anymore :  https://device-manager.scratch.mit.edu:20110
Have you got some idea ?
Thierry

Hi @Mijsoot,
With my Linux system and home network, bluepy-scratch-link is working well with the URL. Do you observe any error or anything unexpected about that URL?

Hi @kawasaki ,
You can what i mean on the attached scrennshot

Hi @Mijsoot ,
Hmm, I see. Then I would like to confirm two things.
Firstly, I assume you already started bluepy-scratch-link with  "sudo ./scratch_link.py" command and that command is running when you saw the error. Is the command running when you saw the error?
Secondly, what happens when you do "ping device-manager.scratch.mit.edu" or "nslookup device-manager.scratch.mit.edu" with you system? With my system, these commands show address <IP_ADDRESS>.

No response for a couple of months. Let me close this issue. If this is still the problem, please open another issue.


:lipstick: add stackoverflow icon

Per discussion #80
Includes:

stackoverflow.svg (from font awesome size 5x)
config.toml placeholder in the author.links section

Tested by adding { stackoverflow = "https://stackoverflow.com/users/935476/rishimaharaj" }, to exampleSite/config.toml and running npm run example

Thank you @rshmhrj, I'll merge this in.


Unable to set Response Curves (Stick Sensitivity)

Hello,
I am unable to set the Stick Sensitivity on both the Left Stick and the Right Stick. I have tried various options such as Digital, Quick, and Precise but whenever I swap to Button Assignments and back it goes from the chosen sensitivity to Default.
After saving and closing the page, I saw that the profile had been saved on the Controller but checking Gamepad Tester it looks like the value sensitivity doesn't change from the default. This was tested by holding the right stick at a certain value and swapping between the 4 different profiles created. I assumed it would change right stick values but I'm not seeing it change.
I'd love to see this feature fixed if possible since I don't own a PS5. Thank you so much for your work, this is exactly what I've been looking for and everything has been looking awesome!

Thank you for creating this issue. I might have resolved it in the new build. Could you test this patch? It is already deployed at https://ds-edge-configurator.com/.
You can close this issue when it is fixed on your end. If not, let me know! 😄

Thank you for creating this issue. I might have resolved it in the new build. Could you test this patch? It is already deployed at https://ds-edge-configurator.com/.
You can close this issue when it is fixed on your end. If not, let me know! 😄

Can confirm it works as intended now. Thank you

Thank you for the confirmation @GittyUser54321. Closing this issue as resolved


Regarding the proposed dataset

According to the CAMO++ website, the dataset hasn't released yet until now.
Then, how the authors can make their new CAMO-FS dataset?
Because they mentioned on their paper that " is mainly reconstructed from the CAMO++", "our CAMO-FS comprises 2, 852 images as a result of the inheritance from CAMO++", "For ease of data preparation such as collections and annotations, one of the most common ways is to inherit existing camouflaged datasets and CAMO++ [13] is our selected dataset since it is a high-diversity dataset with a variety of camouflaged object categories", "By gathering more camouflaged animals and combining them with the CAMO++ dataset, we conduct our CAMO-FS dataset", etc.

Thank you for your question! For research purposes, you can directly contact the authors of the CAMO++ [13] dataset to request the data.


Error opening Actionable Messages Developer Portal

Trying to open https://outlook.office.com/connectors/oam/publish always shows this error:

I urgently need to register the possibility to send actionable messages for our organization.

Duplicate of #925. Pinning #925 for awareness though there is no action that can be taken in this repository.

Apologies for the inconvenience. This is a know issue at the moment that is actively being addressed. Closing this issue as this is not a documentation issue.


Compaction Type

Compaction Type
I wonder if you consider adding the compaction type feature which is on the react-grid-layout project you inspire from.
It should be very useful for my project and I'm sure others person need that too.
Anyway, thanks for your job.

My bad it was already implemented I'm kind of bad sometimes :)
thx for not paying attention at this issue

There is no horizontal compaction right now


Should we coordinate a migration to 'language-reporting'?

@wycats, @nikomatsakis and @jonathandturner have done some great work in building on top of our work in codespan in their branch here as part of their work on Lark. It builds on top of the work of codespan, making it more configurable through the use of traits, and less confusing by using file ids. I've been using it in https://github.com/brendanzab/rust-nbe-for-mltt and have been quite happy!
The question though is: where to from here? Should we close down this repository and direct people to @wycats' project? Or should we try to take on the changes into this repository? I'm still a bit hesitant to take on the render-tree dependency, as I don't fully understand it yet.
Thoughts?
Useful PRs that might need to be up-streamed:

#51: multiline error reporting

render-tree is the only thing I am a bit skeptical about. At some point I may want to seriously look at reducing the binary size of gluon and I may then need to look at replacing solutions that are too general (which I kind of feel render-tree might be). That's not to say it isn't a good idea to merge it though, it is a very specific problem to gluon and I may very well be able to workaround it anyway.

Yeah, that's my biggest scepticism, although I'm more concerned from a maintenance perspective. Curious to see if we can do some simplifications.

I think there would be some ergonomic improvements to implementing reporting using render-tree, but we'd have to weigh it up I think.

Other things that have been done is combining it into one crate. Are you happy with this @Marwes? It does simplify things a little 🤔.

Other things that have been done is combining it into one crate. Are you happy with this @Marwes? It does simplify things a little 🤔.

codespan-lsp is removed and I'd argue that at least that should be it's own crate given that it is only useful in the very specific usecase of writing a language server/client. Having reporting merged in isn't really an issue for me at least as I already always include it anyway. That might change but perhaps that is something that can be worked out later.

I'm feeling like I'm going to keep codespan alive for the time being because I don't have a clear idea of what is going on with language-reporting. It's been super valuable inspiration though! Most of the things I think we want from it are now in master or noted in issues, so I think I'll close this now.


Not calling .on('notification') when app is totally closed

Expected Behaviour
When app is totally closed and when user click on notification tray its open the app but not calling the .on('notification') . Plugin must have some method to handle this case because this is very important part of PushNotification(when app is totally closed).
I google this and found some questions regarding the same like  #1913  and #1673 all the answers point out at https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#application-force-closed I actually dont understand this sentence "If you add force-start: 1 to the data payload the application will be restarted in background even if it was force closed." does that means If i pass force-start : 1  in my notification payload then when app is totally closed and click on notification it will call the .on('notification') method ?
I tried this by setting force-start : 1  in my notification payload and observe the adb logs ..they defiantly process something but when i click on notifictaion tray nothing happens I mean .on('notification') handler is not called.
Any Idea what am I doing wrong ? @macdonst  please help :)
Actual Behaviour
Not calling .on('notification')  when app is totally close and user click on notification.
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 8.0
Android 6.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Honor 8 lite, Redme note 3
Cordova CLI version and cordova platform version
cordova-android 7.1.0
cordova verion 8.0.0
Plugin version
2.2.3
Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem

Sure but i am on windows so grep Push is not working .. anything similar to this for windows ? @macdonst

@KishanIos007 eh, just post the whole log up somewhere like gist. With regards to force-start I don't want to get into that as it just adds another variable. I believe the root cause is the plugin fires the notification event before your listener is setup but I don't want to say for sure until I see some logs.

Sure Let me just put logs from android studio..

Here is the gist file : https://gist.github.com/KishanIos007/fe6fc0c97f381ad5c97acc9ff4524595

I have same issue on Android 8.
I received event .on('notification') when app is running, but not event if app was closed and i clicked on notification.

I have the same issue. Steps to reproduce:
1.- The APP is in the background.
2.- I got the notification and click it.
3.- The event is not triggered.
4.- Android 7.1
If the APP is in the foreground, works as expected. Also works for iOS in both background and foreground states.

I deleted my previous post because I want to add more info.
Reproduce Scenario 1

iOS APP opened & foreground state
Send the notification
The .on('notification') is called.

Reproduce Scenario 2

iOS APP closed or iOS APP opened & background state
Send the notification
The .on('notification') is called.

Reproduce Scenario 3

Android APP opened
Send the notification
The .on('notification') is called.

Reproduce Scenario 4

Android APP closed or Android APP opened & background state
Send the notification
The .on('notification') is not called.

Example payload
{
    "priority": "high",
    "to": "FIREBASE TOKEN",
    "data": {
        "payload": {
            "pushType": 7,
            "title": "Title",
            "description": "Message",
            "source": "https://www.google.com.mx/"
        }
    },
    "notification": {
        "title": "Title",
        "body": "Message",
        "sound": "default",
        "icon": "drawable-hdpi-icon"
    }
}

Plugin version
2.2.3
Thanks.

I'm having the same issue for my android phone...it's working fine when the app run on background. However, if i terminate the app from task manager it will still receive a notification at the notification panel but on.('notification')  wont trigger.

Check the FCM docs, if you send notification and data payload and the app is in the background/closed on.('notification') won't trigger until you tap the notification in the tray and only with the data part. If yo want on.('notification') to trigger, then don't send notification key, just data.
https://firebase.google.com/docs/cloud-messaging/android/receive

yeah, tell that to Google

Actually as I can understand, you can send both notification and data payload. I'm quoting the FCM docs.

Handle notification messages in a backgrounded app
When your app is in the background, Android directs notification messages to the system tray. A user tap on the notification opens the app launcher by default.
This includes messages that contain both notification and data payload (and all messages sent from the Notifications console). In these cases, the notification is delivered to the device's system tray, and the data payload is delivered in the extras of the intent of your launcher Activity.

I didn't clarify it (I edited the post), but I'm actually taping the notification and the on.('notification') is not being triggered.

Exactly same issue here..
Your solution was correct. Also, i have a 'message' key in my data payload that takes the role of the "missing" notification key or no push notification will be shown.
So when you have data your payload would be
{
    "priority": "high",
    "to": "FIREBASE TOKEN",
    "data": {
        "payload": {
            "message": "Your message",
            "pushType": 7,
            "title": "Title",
            "description": "Message",
            "source": "https://www.google.com.mx/"
        }
    }
}

Check the FCM docs, if you send notification and data payload and the app is in the background/closed on.('notification') won't trigger until you tap the notification in the tray and only with the data part. If yo want on.('notification') to trigger, then don't send notification key, just data.
https://firebase.google.com/docs/cloud-messaging/android/receive

Hi, I did a deep investigation. This works as expected with Android (foreground & background), but no notification show up on iOS.
{
   "priority":"high",
   "registration_ids":[XXXXXXXXX ],
   "data":{
      "message":"Message",
      "title":"Title",
      "vibrate":1,
      "sound":1,
      "payload":{
         "pushType":7,
         "title":"Title",
         "description":"Description",
         "source":"http:\/\/google.com.mx\/"
      }
   }
}

This works as expected on iOS, but the on.('notification') don't trigger if the Android app is in the background or killed.
{
   "priority":"high",
   "to":"XXXXXXXXXXX",
   "data":{
      "payload":{
         "pushType":7,
         "title":"Title",
         "description":"Description",
         "source":"https:\/\/github.com\/Maatwebsite\/Laravel-Excel"
      }
   },
   "notification":{
      "title":"Title",
      "body":"Body",
      "sound":"default",
      "icon":"drawable-hdpi-icon"
   },
   "content_available":true
}

In my testings the main problem is the notification object. If you include it, then stop working on Android. If you remove it, then iOS is broken.

@tangamampilia @maxkunitsa
All of that is documented here for android and here for iOS+FCM+{android differences).
Please,
Tell us how we can make the docs better so that more people read it and understand that the payload for Android and iOS+FCM can't be the same.

Hi, following the thread it is not clear if this is an issue or a matter of configuration.
In my case, it is not working. My app is closed, and if a notification arrives, it appears in the tray bar and when the user taps on it, the application is opened. However, though in the moment that the app is opened, we call init method and register register and notification listeners, only register callback is called.
My payload only contains data, not notification:
{
"to": xxxx,
"data": {
"title":"Localized title",
"message": "localized message",
"payload": {
"data": {
"other data": ""
}
}
}
}
Could you please clarify if there is an issue or it should work (and how)?
Thank you in advance and kind regards

everything works fine in android lower than Oreo, i can receive notifications foreground, background even when app is idle (i leave it idle for hours). But when i tested it in Oreo and Pie, i can not receive notifications when i leave the app idle for hours probably because service is kiled automatically, though i still can receive notifications when in foreground and background. The real problem is when i leave the app idle for hours notifications tray did not show its work

Hey Guys,
I got it to work in android sending the payload as the follow example:
var admin = require('firebase-admin');

var message = {
	token: 'the registration token',
	data: {
		title: 'Anything',
		body: "Anything else",
		notId: '123'
		priority: '1',
		vibrate: '300',
		visibility: '1',
	},
};

// Send a message to the device corresponding to the provided registration token.
admin
	.messaging()
	.send(message)
	.then(response => {
		// Response is a message ID string.
		console.log('Successfully sent message:', response);
	})
	.catch(error => {
		console.log('Error sending message:', error);
	});

Note that all the content, including title and body are in data atribute of the message.
You can get more information in the official doc Android Behaviour -> Notification vs Data Payloads

Hey Guys,
I got it to work in android sending the payload as the follow example:
var admin = require('firebase-admin');

var message = {
	token: 'the registration token',
	data: {
		title: 'Anything',
		body: "Anything else",
		notId: '123'
		priority: '1',
		vibrate: '300',
		visibility: '1',
	},
};

// Send a message to the device corresponding to the provided registration token.
admin
	.messaging()
	.send(message)
	.then(response => {
		// Response is a message ID string.
		console.log('Successfully sent message:', response);
	})
	.catch(error => {
		console.log('Error sending message:', error);
	});

Note that all the content, including title and body are in data atribute of the message.
You can get more information in the official doc Android Behaviour -> Notification vs Data Payloads

The message payload for iOS is as follow:
var message = {
	token: registrationToken,
	notification: {
		title: 'Anything',
		body: "Anything else",
	},
	data: {
		priority: '1',
		vibrate: '300',
		visibility: '1',
		notId: '123',
	},
};

Hi, I did a deep investigation. This works as expected with Android (foreground & background), but no notification show up on iOS.
{
   "priority":"high",
   "registration_ids":[XXXXXXXXX ],
   "data":{
      "message":"Message",
      "title":"Title",
      "vibrate":1,
      "sound":1,
      "payload":{
         "pushType":7,
         "title":"Title",
         "description":"Description",
         "source":"http:\/\/google.com.mx\/"
      }
   }
}

This works as expected on iOS, but the on.('notification') don't trigger if the Android app is in the background or killed.
{
   "priority":"high",
   "to":"XXXXXXXXXXX",
   "data":{
      "payload":{
         "pushType":7,
         "title":"Title",
         "description":"Description",
         "source":"https:\/\/github.com\/Maatwebsite\/Laravel-Excel"
      }
   },
   "notification":{
      "title":"Title",
      "body":"Body",
      "sound":"default",
      "icon":"drawable-hdpi-icon"
   },
   "content_available":true
}

In my testings the main problem is the notification object. If you include it, then stop working on Android. If you remove it, then iOS is broken.

Sadly this is also not working now. The Android example you have given will only work if the app is open and in the foreground. In the background the notification is never triggered. It seems something has changed again since you tested this.

Hey Guys,
I got it to work in android sending the payload as the follow example:
var admin = require('firebase-admin');

var message = {
	token: 'the registration token',
	data: {
		title: 'Anything',
		body: "Anything else",
		notId: '123'
		priority: '1',
		vibrate: '300',
		visibility: '1',
	},
};

// Send a message to the device corresponding to the provided registration token.
admin
	.messaging()
	.send(message)
	.then(response => {
		// Response is a message ID string.
		console.log('Successfully sent message:', response);
	})
	.catch(error => {
		console.log('Error sending message:', error);
	});

Note that all the content, including title and body are in data atribute of the message.

Hi, I can only see this working on Android if my app is open and in ofreground. It isn't being called if the app is in the background (Android 8)

It's happening the same here on Android 8 MIUI 10.3 (xiaomi). The event "notification" does not trigger when the app is closed, but it works when the app is in foreground or background

using this structure:
    "to" => $token,
    "data" => array(
      "title" => utf8_encode($title),
      "body" => utf8_encode($body),
      "id_job" => $id_job,
     )

Has anybody found a fix? I can confirm on Android 8, 9 and 10 the push notification does not run within the app if the app is closed or in the background at the moment the user receives the message. Clicking on the the notification simply opens the app and does nothing.
The only solution I can think of is to make my own secondary checking system by storing all messages in a DB with a "read/unread" flag. A message becomes read only if the message is displayed within the app. On loading the app call the latest "unread" message from the DB and show it within the app, then flag it as read as we know the user has absolutely seen this message within the app. Seems like a much safer approach as Android continue to chage the way push messages work.

I made it for all the situations (foreground, background and closed) by using a different strucure for each OS.
IOS
   $fields = array(
        "to" => $token,
        "notification" => array(
            "title" => utf8_encode($title),
            "body" => utf8_encode($body),
        ),
        "data" => array(
            "ids_job" => $id_job,
        ),
    );

Android:
`
  $fields = array(
        "to" => $token,
        "data" => array(
            "id_job" => $id_job,
            "title" => utf8_encode($title),
            "body" => utf8_encode($body),
         ),
     );

`

I made it for all the situations (foreground, background and closed) by using a different strucure for each OS.
IOS
   $fields = array(
        "to" => $token,
        "notification" => array(
            "title" => utf8_encode($title),
            "body" => utf8_encode($body),
        ),
        "data" => array(
            "ids_job" => $id_job,
        ),
    );

Android:
`
  $fields = array(
        "to" => $token,
        "data" => array(
            "id_job" => $id_job,
            "title" => utf8_encode($title),
            "body" => utf8_encode($body),
         ),
     );

`

Android 8+ won't display in the notification area if the notification parameter is removed. Data parameter only works if app is open and I'm foreground,  and displays directly in the app.

@jtibbles  that's a new thing? I tested it in 31/07/19 with this plugin and it was working, but since then i have been using cordova-plugin-firebasex.

@isaacbatst what version of Android are you testing on? Apparently its new since 2019

that's strange, it was tested on android 6 and 8.1
when i find a break, i'll create a basic project to have sure if it's still working and then post here

thanks @isaacbatst , I've been struggling with this for a while.  Other people seem to be having the same problem:
https://github.com/phonegap/phonegap-plugin-push/issues/2850
As a reference, here is my sample payload:
  $notification = array  (                     'body'   => "some body text",                     'title'     => "some title text",                     "subtitle"=> "some subtitle",                      "icon" =>  'notification_icon',                     "content_available" => "1",           ); $data = array (                     "title" =>"some other title, overridden by notification title"                     "message" => "some other message, which overrides notification body"                     "content_available" => "1", ); $fields = array (                     'registration_ids'  => $registrationtokens,                     'notification'      => $notification,                     'data'          => $data,                     "priority" => "high",                     "content_available" => true  );

The behaviour is by design: Have a look at:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#notification-vs-data-payloads

Quick question along these same lines....
When a notification is received, and the app is opened by directly clicking on the app from a closed state (not by clicking on the notification from the tray), shouldn't the on notification event fire and the notification be presented? If I click on the notification from the notification center, the app opens (from a closed state) and the event fires without issue.
This is for iOS 13.3.1/iPhone 11


uavcan build failed

I have cloned the newest Firmware repo, and have updated the submodules (env: win7_x64). When I build the project, it failed with the prompt message as follow:
make[1]: warning: -jN forced in submake: disabling jobserver mode.
[  0%] Built target git_gencpp
[  0%] Built target git_genmsg
[  0%] Built target git_uavcan
[  0%] Built target git_nuttx
[  0%] Built target git_mavlink
[  0%] Built target git_matrix
[  0%] Built target mixer_gen
[  0%] Running dsdl compiler
[  1%] Built target xml_gen
[  1%] Built target nuttx_export_bugoo
[  1%] Built target nuttx_export_px4io-v2
Compiler failure
Traceback (most recent call last):
File "g:/enouav/aplan/Firmware/src/modules/uavcan/libuavcan/libuavcan/dsdl_com
piler/libuavcan_dsdlc", line 61, in
dsdlc_run(args.source_dir, args.incdir, args.outdir)
File "g:\enouav\aplan\Firmware\src\modules\uavcan\libuavcan\libuavcan\dsdl_com
piler\libuavcan_dsdl_compiler_init_.py", line 62, in run
run_generator(types, output_dir)
File "g:\enouav\aplan\Firmware\src\modules\uavcan\libuavcan\libuavcan\dsdl_com
piler\libuavcan_dsdl_compiler_init_.py", line 111, in run_generator
die(ex)
File "g:\enouav\aplan\Firmware\src\modules\uavcan\libuavcan\libuavcan\dsdl_com
piler\libuavcan_dsdl_compiler_init_.py", line 89, in die
raise DsdlCompilerException(str(text))
DsdlCompilerException: [Error 5] : u'g:\enouav\aplan\Firmware\src\modules\
uavcan\libuavcan\libuavcan\include\dsdlc_generated\uavcan\CoarseOrientatio
n.hpp'
[Error 5] : u'g:\enouav\aplan\Firmware\src\modules\uavcan\libuavcan\libu
avcan\include\dsdlc_generated\uavcan\CoarseOrientation.hpp'
make[3]: *** [libuavcan_dsdlc_run.stamp] Error 1
make[2]: *** [src/modules/uavcan/libuavcan/libuavcan/CMakeFiles/libuavcan_dsdlc.
dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[  1%] Built target prebuild_targets
[  1%] Built target io_prebuild_targets
make[1]: *** [all] Error 2

Hi @haigithub, are you using the Bash on Windows or the old setup?
Generally, we don't support and recommend building on Windows, sorry about that.
http://dev.px4.io/starting-installing-windows.html

@julianoes  I am using "PX4 Toolchain Installer v14 for Windows Download" on Windows. I have an personal customed firmware version, and I developed that version for some time. Everything is ok. The build failing comes when I clone a new repo from https://github.com/PX4/Firmware.

Yes, as said, unfortunately you're on your own. We're not supporting Windows. If you can resolve it, we appreciate a PR but we don't have bandwidth to look into it.

@julianoes  Thanks! I think I have find the method to solve the problems. The method is as follows:

Then building succeeds.

@haigithub Oh great, that was easy then. Thanks for sharing.


added properties files for READMEs for Thorntail

@gastaldi @tradej let me know what you think

Will these properties files be visible anywhere? If so, I would wait for the name change to take effect first and only then merge this PR. Apart from @gastaldi's comments, I believe this looks good.

Will these properties files be visible anywhere? If so, I would wait for the name change to take effect first and only then merge this PR.

We (I, actually) submitted a PR to the booster catalog yesterday that moves WildFly Swarm community boosters to Thorntail. The PR was merged, so Launcher already generates Thorntail projects. So these properties are probably urgently needed :-)

@Ladicek, I see. Consider my comment withdrawn.

@gastaldi @Ladicek @tradej updated per feedback

thank you @Ladicek and @gastaldi merging.


FGA doesn't recognize the supports screen.

Before opening an issue:
[O] I tested the latest release
[O] I looked at other issues (even the closed ones)
[O] I read the Troubleshooting Guide
[O] I'll fill this template properly
Your issue will get closed/locked by the bot in case proper info isn't provided
If you open unnecessary/dumb issues, you'll be rewarded with appropriate tags.
Describe the bug
It gets stuck on supports screen as if it doesn't recognize it (even when FGA is full screen and when ignore notch is off). Then when I manually select a support and it goes to the battle screen it keeps on being stuck.
Screenshots
Video
https://youtu.be/NMkDJ5sL6rg
(when black gap is on the left side)
https://youtu.be/j2iod6Zaasc
(black gap on the right side)
Device Info (please fill at-least 'Device model'):
Device model: Samsung Galaxy S20+
Screen size: 6.7 inch
Android Version: Android 10
RAM: 12GB

https://youtu.be/1_3xXK_Zno8
As you can see here it doesn't even scroll.
What should I do?

The first 2 videos return a 404 error.
Does it run the battlescript in battle?

I have the same problem with the same phone with the notch setting for samsung flipped on. It works fine during the battle but afterwards freezes on trying to pick a support.

The first 2 videos return a 404 error. (Nvm had to remove your comments)
EDIT: Looks like you've got a notch, check the troubleshooting guide to check your settings for Notch Calculation

"Your phone does have a notch. Turning ON that setting would Ignore the notch, which only helps in the case where FGO also ignores the notch and extends over it. But, right now FGO is leaving the notch area black, so no need to ignore it."
I don't know what to do anymore.

I don't know either.
Last 2 times I asked you to change some settings and you said that those worked.
So, I'm confused about what more can be done now.

I don't know either.
Last 2 times I asked you to change some settings and you said that those worked.
So, I'm confused about what more can be done now.

First it was solved by turning off ignore notch then second time it was solved by making FGA full screen.
Maybe I should turn up the delay or turn down similarity?

First it was solved by turning off ignore notch then second time it was solved by making FGA full screen.

I'm confused that If it was solved before, what happened to make the regions wrong again.

Maybe I should turn up the delay or turn down similarity?

Regions are wrong for you, so, changing delay or similarity isn't the right solution.

First it was solved by turning off ignore notch then second time it was solved by making FGA full screen.

I'm confused that If it was solved before, what happened to make the regions wrong again.

Maybe I should turn up the delay or turn down similarity?

Regions are wrong for you, so, changing delay or similarity isn't the right solution.

Then how do I change region from auto detect?

The region he's talking about is FGA's detection regions for what's on screen to match with images for KR.
There's not much you can do... have you changed your phone's resolution as of late?

The region he's talking about is FGA's detection regions for what's on screen to match with images for KR.
There's not much you can do... have you changed your phone's resolution as of late?

Not that I know of.
Let me see if I can get it working with different resolutions(if it's possible to change it)

I found the solution while scrumbling through settings.
It was the "font size".
I saw that my font size was little bit larger than default so I turned it all the way down to minimum.
Then for some reason, region detection started working again.
Thanks everyone and I really hope I don't come back with this issue again haha.

I don't think font size should matter
Post a video of it working this time.
Every time you said it worked and came again with the same issue, so I want to confirm.

I don't think font size should matter
Post a video of it working this time.
Every time you said it worked and came again with the same issue, so I want to confirm.

https://youtu.be/B0j9ja5ajfM
Here it is. I can get more video if you want to see anything else.

That's a really weird configuration. I think now the regions are detected right but shown wrong.
Ideally, FGA's Play button shouldn't go into the notch area.
But, well, if it's working, then it's fine I guess.


上传.jpg文件BUG

Product and Version [VS/VSCode]:
OS Version [macOS/Windows]:
Live Share Extension Version:
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:
1.共享后，客户端拖拽.jpg文件，出现jpg文件损坏的情况，怎么解决？

Translation:
After sharing, the client dragged the .jpg file and the .jpg file was damaged. How to solve it?

Thanks for reporting the bug, @shunqiziran888
Did you drag-n-drop a file within VSCode file explorer or from outside?
Was that on the client that joined the collaboration session, or on the client that shared the session?
Translated to:
感谢您报告错误，@ shunqiziran888
您是否在VSCode文件资源管理器中或从外部拖放文件？
是在加入协作会话的客户端上，还是在共享会话的客户端上？


Preserve quotes

minimal-yaml appears to discard quotes. Both of the following
k: 1
k: "1"

are parsed as Entry { key: Scalar("k"), value: Scalar("1") }. This is bad because downstream code would need to be able to tell the difference between the two and treat the first as a number and the second as a string.

I was split between discarding quotes in order to adhere to the YAML specification, and preserving them as you suggest. Overall I agree preserving quotes does add more value than adhering to the specification (which the library already diverges from), so I'll go ahead and make that change.

I'm not sure why you see this as diverging from the specification. Double quoted strings are scalars according to https://yaml.org/spec/1.2/spec.html#style/flow/double-quoted. They are represented by c-double-quoted(n,c) in that document.

Right. I suppose I interpreted the intent of the Scalar enum variant as containing the content of the scalar instead of the literal scalar, and since the specification considers the outer quotes as indicator characters they wouldn't be considered content. I was imagining preserving only the scalar content during parsing, though I see now that was misguided.


feat(app): add basePath option

With this PR, we can specify the basePath in the constructor of Hono:
const app = new Hono({ basePath: '/api' })

Also, it has the correct type.

Related to #929

Hi @usualoma !
Maybe I could have done it. Could you see it if you have time?

Hi @yusukebe,
Thanks!
I could get that far too, but when I specified <Env> as the type parameter, the basePath inference did not work as expected.

We could proceed with the restriction that "if  is specified, route() is the only way to go."

Hmmm...Type is a hard thing.

@usualoma Thanks for the comment!
Let us give up basePath and use app.route(). Closing the PR.


Skip the content when object is not a tree

Fix #29101
cat-file --batch output format:
<sha> SP <type> SP <size> LF\n<content>

When object type is expected, the content will be handled, but when it is not expected, the content will not be handled, and will be read in the next turn.

Can you add a test?

Can you add a test?

This occurs randomly, how to test it correctly? 🤔

The test got random results. Maybe we need to dig deeper to find out the real reason.

My fix from #29104 prevented the error too but doesn't fix the real problem. Should be the same for this fix. Gave up at that point then. I may have a look at this again later.

@yp05327 Are you fine with it if I would create a new PR containing your commit because there are other places too which should be changed. Otherwise we can merge your PR and I create a follow up PR.

@yp05327 Are you fine with it if I would create a new PR containing your commit because there are other places too which should be changed. Otherwise we can merge your PR and I create a follow up PR.

Never mind.


Internal Server Error Bug Fixed

There Was bug in code after some update in gemini...In my pull requests it has been fixed it would be great if you accept it

thanks


Terminal needs reset after update

I am using GNOME Shell 3.14.4 under Debian GNU/Linux 8.
When updating spf-13 with the command curl https://j.mp/spf13-vim3 -L -k -o - | sh, the terminal is left in a funny state where no new lines exist and the characters are not printed anymore.
I have to type reset in order to bring back the original terminal state.

+1 ubuntu 14.04LTS


[FLINK-19850] Add e2e tests for the new File Sink in the streaming mode

What is the purpose of the change
This PR adds the e2e tests for the new FileSink. In the e2e tests we mainly focus on cases of TaskMangers get killed, thus we only test the streaming mode since for batch mode, in this version the new file sink still not be able to achieve exactly-once if the ResultPartition gets lost. The stream & batch mode for cases of task failover is covered by FileSinkITCase.
Therefore, the PR is roughly a copy of the E2E test of the StreamingFileSink.
Brief change log

86e3c5950cf82baa0a5e3078b0c30050f262dcb0 adds the test program and the test scripts.

Verifying this change
This change is a test for itself.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Instead of copying the test_streaming_file_sink.sh, could we just parameterize that existing test with the test program jar? And maybe rename it to test_file_sink.sh?

I would also second @aljoscha 's opinion if this is possible. If I recall correctly it is using the OnCheckpointPolicy so it does not need processing time support. But we have to check again.

Very thanks for the review! The initial thought is that we might need also support batch mode in the future, which would change the scripts and test program, but I also agree with that it would be better to reuse the current codes to decrease the duplication until they diverge. I'll modify the PR to reuse the existing test~

Merged!

Note: This PR has been merged despite a build failure, which now permanently breaks build on master.

I reverted the change.


fn rav1d_parse_sequence_header: get rid of current_block

We forgot to re-transpile the goto-less dav1d_parse_sequence_header to remove the current_block_* state machine.

Did you make these changes from re-transpiling?

I did this by hand, I added dav1d_parse_sequence_header_error by hand, I didn't see an existing copy in the Rust sources.


feat: Re-work CI

Why this PR
Current CI had lots of drawbacks like :

generate-readme workflow failed for external contributors due to secrets used
the chart-release-action used forced us to update Chart version on every commit targeting main branch because they were automatically released by the action that searched for changed from previous tag. This prevents us to have intermediate work on charts that we want to release later by packaging several changes with it.
chart linter testing for Chart version upgrade because of our release flow mentioned previously

What does this PR do ?

Change release process from "each commit on main" to a manual trigger of Github Action using workflow_dispatch event that do :

update Chart.yaml version to input one and push to current checkout branch
package Helm Chart using chart-releaser tool
create and publish Github release based on commit previously using release-drafter tool
upload tgz package as release asset
update Helm index on gh-pages using chart-releaser tool

Stop generating README from PR CI and instead add a check on chart-testing that verify that the README is up-to-date using readme-generator-for-helm tool

Do not fail chart linting if Chart.yaml version is not bumped

Add release-drafter to generate release description from commits

LGTM Just a comment, is it possible to merge the two yaml release drafter files as there is a lot of repeat?

No unfortunately each file define a different include-path that filter commits that only touch the chart we are currently releasing and I can't override it like name and tag in action input.


Is there a timeout?

HI, I'm using your component in one of my app. The component is working well. I noticed a glitch: after a short while (half an hour?) the component don't fire any events. What kind of problem can it be?
Thanks in advance.

You need to give me context.  Platform? Code? Exception?

Thanks for your reply. I'm developing an app for Android.
    /// <summary>
    /// Sets the places.
    /// </summary>
    private void SetPlaces() {
        geofences.RegionStatusChanged += Geofences_RegionStatusChanged;
        geofences.StopAllMonitoring();

        List<Place> places = repo.GetPlaces();
        foreach (Place place in places) {
            try {
                int regions = geofences.MonitoredRegions.Where(r => r.Identifier == place.Name.Trim()).Count();
                if (regions == 0) {
                    geofences.StartMonitoring(new GeofenceRegion {
                        Identifier = place.Name.Trim(),
                        Radius = Distance.FromMeters(100),
                        Center = new Acr.Geofencing.Position(place.Latitude, place.Longitude)
                    });
                }
            }
            catch (Exception ex) {
                Debug.WriteLine(ex.Message);
                log.SendMessageToAzure("Geofences Error", ex.Message);
            }
        }
    }

    private async void Geofences_RegionStatusChanged(object sender, GeofenceStatusChangedEventArgs e) {
        if (e.Status == GeofenceStatus.Unknown) {
            log.SendMessageToAzure("Geofences place", "Unknown");
        }
        else {
            if (e.Status == GeofenceStatus.Entered) {
         }
            if (e.Status == GeofenceStatus.Exited) {
         }
        }
    }

I don't actually do anything to keep things alive in the background (neither does Plugin.Geolocator) such as a sticky or boot service, so if your app is being put to sleep nothing will bring it back up.
Also, the geolocator is actually used under the hood for this plugin (not google play services), so if you shutdown GPS, you will shutdown the geofences as well.

Any luck?


Admin interface does not allow changing object containing image

This is because: NotImplementedError: subclasses of Storage must provide a url() method.

Fixed in 1a3d5a5.


syncthing to secure synchronize data between your devices

consider syncthing as tool to synchronize data between your devices in a secure way. An app only needs access to data on the device it is running on. syncthing ensures instant synchronization.
Use cases

replace your cloudbased note taking app by syncthinging your note files
replace your cloudbased passwordmanager by syncthining  your keepass file
replace your cloudbased music app by synthinging your music files

Hi there,
Syncthing sounds interesting, it's the kind of thing I think about when I look at NextCloud. But maybe more open since it works on top of an open protocol (although Nextcloud is open source as well, but I'm not sure how it works under the hood).
What do you intend by opening this issue, you want me to add syncthing to the list of protocols and implementations?

Yes that was my intent. Might as well has been  a comment at hackernews instead of a issue here.
i think syncthing deserves to be brought to light as a maybe somehow low level alternative to solid  and remote storage.

Ok, I've added it to the list, thanks for suggesting!
Looking into this, I realized that in my opinion this doesn't completely adhere to the Autonomous Data principles. And some of the options listed before didn't either, so I've rewritten that page to clarify.
In particular, they are lacking semantics. Here's the relevant part of the text:

In some rare occasions, users can also export and import their data. But even then, the data format will be obscure enough for non-technical users to make it unusuable. And for technical users, the data won't be compatible with other applications. So they'll have to migrate it by hand.

If I understand correctly, syncthing (and other of the protocols listed) don't contain semantics. So if I made an app to manage movies, for example, non technical users wouldn't be able to reuse that data with other applications using the same protocol. They'd be able to migrate it, which is a big win, but they'd still need technical assistance and interoperability would be unlikely out of the box.
Solid's advantage is that it has semantics built-in, so if I anyone's makes an app for managing movies it's very likely that they are using the schema:Movie ontology and it is compatible with other applications. Without developers even knowing each other.
I know in practice this isn't happening, mainly because there aren't that many Solid apps right now. But I've already found a couple of instances where the data generated by my apps was compatible with existing services (unbeknownst to me). So I am optimistic about it in the long run, and I think this is essential to have a healthy app ecosystem as I mention in that quote.


Support encoding constructor arguments

The ABI parser expects any function to be named. In some cases it would be useful to encode constructor args. (address) for example doesn't work. One way would be to reserve the constructor keyword in the lexer.
constructorFunc, err := w3.NewFunc("constructor(address)", "")
if err != nil {
	return nil, err
}

constructorArgs := []any{w3.A(0x765DE816845861e75A25fCA122bb6898B8B1282a)}

constructorBytecode, err := constructorFunc.EncodeArgs(constructorArgs...)
if err != nil {
	return nil, err
}

// Should return bytearray representing<PHONE_NUMBER>00000000000000765de816845861e75a25fca122bb6898b8b1282a

Not sure if this is within scope of w3 or should the abi package (abi.Pack) from geth be used instead.

There is one hacky to do this rn. w3.Func exposes Func.Args of the "raw" geth type ab.Arguments. So you could use the constructorFunc from your example to call constructorFunc.Args.Pack.
This is definitely within the scope of w3. The problem is I don't really have a good idea how to handle constructors. Not sure if it is safe to reserve the "constructor" name. Does it even make sense to encode arguments without the deploy bytecode? How would you handle this in your code-example?

Does it even make sense to encode arguments without the deploy bytecode? How would you handle this in your code-example?

I would append the constructor args because the contract bytecode is fixed.

func PrepareContractBytecodeData(contractBin string, contractABIJSON string, constructorArgs []any) ([]byte, error) {
	constructorBytecode, err := encodeConstructorArgs(contractABIJSON, constructorArgs)
	if err != nil {
		return nil, err
	}

	return append(common.Hex2Bytes(contractBin), constructorBytecode...), nil
}

func encodeConstructorArgs(contractABI string, constructorArgs []any) ([]byte, error) {
	abi, err := abi.JSON(strings.NewReader(contractABI))
	if err != nil {
		return nil, err
	}

	constructorBytecode, err := abi.Pack("", constructorArgs...)
	if err != nil {
		return nil, err
	}

	return constructorBytecode, nil
}

Not sure if it is safe to reserve the "constructor" name. Yeah, it might not be the best way as the library should be as flexible as possible.


error: no such host

I have tried the tutorial and successfully used the hcl to create the storage account, I can see the storage account in Azure Portal, all looks good,
but when I try to use it as a backend I get this error:
terraform init Initializing the backend... │ Error: Failed to get existing workspaces: containers.Client#ListBlobs: Failure sending request: StatusCode=0 -- Original Error: Get "https://tfbackendmne7fhxxg.blob.core.windows.net/terraform-backend-container?comp=list&prefix=terraform.tfstateenv%3A&restype=container": dial tcp: lookup tfbackendmne7fhxxg.blob.core.windows.net on <IP_ADDRESS>:53:no such host
What to do?
Regards
Stephen

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 789076a3-5d6d-e5d9-a3f7-cc1d6351ca8a
Version Independent ID: e873b421-20fe-3415-0f4b-aacd7378c271
Content: Tutorial - Store Terraform state in Azure Storage
Content Source: articles/terraform/store-state-in-azure-storage.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

Unfortunately, we have not been able to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with any additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Adds Heartbeat framework and creates group

Since the Heartbeat logic will be pretty massive, I've created a group called Heartbeats which will contain the video tracking and heartbeat mapping.
This PR also includes the Adobe Heartbeat framework, which is not available in Cocoapods just yet and has to be manually included.
I just want to be sure this file structure makes sense, and since Adobe isn't on Cocoapods just yet, I've included the Framework in Pod/ so users will also be downloading the Heartbeat framework when adding Segment-Adobe-Analytics to their app

@tonyxiao what changes are you requesting here


tox -e luminous-cluster -- --provider=libvirt fails due to lvms not being configured

Bug Report
What happened:
What you expected to happen:
How to reproduce it (minimal and precise):

Share your group_vars files, inventory
Environment:

OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Docker version if applicable (e.g. docker version):
Ansible version (e.g. ansible-playbook --version):
ceph-ansible version (e.g. git head or tag or stable branch):
Ceph version (e.g. ceph -v):

What's the failure?

@leseb, I was updating the bug report while you asked the question. I've the PR fix

luminous-cluster ?

luminous-cluster ?

are you saying it's not a valid scenario? it does show up with 'tox -l', and it defaults to luminous-centos7-cluster.
Please look at the PR. If you think the PR/bug is not useful, I can close it.

The issue has been fixed with the merge.


Manually connect to site doesn't trigger account and status update

What version of React and MetaMask-React are you using?

React: 18.2.0
MetaMask-React: 2.4.1

What is the current behavior?
const { account, connect, status } = useMetaMask();

connect method works correctly and update account and status, but when I open metamask extension in chrome and choose manual connect to current site - account and status is still has null/"notConnected" values
What is the expected behavior?
Manual connection to site should trigger update for account and status values

@EugeneSnikhovskiy! Thanks a lot for this issue!
I did not know this option in MetaMask! I'm gonna try to take a look this week-end :)

Wow. This is so cool. Thank you so much for really fast support :)


CheckboxColumn calling grid JS which is not initialized yet

What steps will reproduce the problem?
Use \yii\grid\GridView with a column of class \yii\grid\CheckboxColumn
The issue was also indirectly described in issue of different repo: https://github.com/kartik-v/yii2-grid/issues/518.
What is the expected result?
Grid is successfully initialized with a checkbox column
What do you get instead?
JS console error: Uncaught TypeError: Cannot set property 'selectionColumn' of undefined causing halt of further JS execution.
It's caused by following being rendered:
jQuery('#w2').yiiGridView('setSelectionColumn', {"name":"selection[]","class":null,"multiple":true,"checkAll":"selection_all"});
jQuery('#w2').yiiGridView({"filterUrl":"\/contact\/view?id=6","filterSelector":"#w2-filters input, #w2-filters select"});

Technically this is the flow:

Columns get initialized within GridView::init and CheckboxColumn registers it JS first
Grid gets to registering its JS in GridView::run which seems to be too late here.

It looks like it's either necessary to move GridView JS registering sooner or columns JS registering later.
Additional info

Q
A

Yii version
2.0.9

PHP version
5.6.18

Operating system
Ubuntu 14.04

@rootpd I have save JS code, but without TypeError exception
jQuery('#w1').yiiGridView('setSelectionColumn', {"name":"selection[]","class":null,"multiple":true,"checkAll":"selection_all"});
jQuery('#w1').yiiGridView({"filterUrl":"\/video1","filterSelector":"#w1-filters input, #w1-filters select"});

Let me get back to you with full example view so it's easier to reproduce. Just to confirm, the code you pasted is the one generated by Yii and executed when page is rendered, nothing custom called, right?

@rootpd yes, only GridView from gii and one custom field with CheckboxColumn

Since no additional info on how to reproduce it was provided, closing.


Enable more Ruff rules

Apparently the default is actually a fairly small subset of the rules.
Enabling all the rules with --select ALL or in pyproject.toml:
[tool.ruff.lint]
select = ["ALL"]
preview = true

creates a lot more warnings. Maybe too much, but it can be filtered to error level with "E" instead of "ALL".

See https://github.com/biocommons/biocommons.example/pull/36


Prefix Lightning missing on LNURLp/w

wherever a QR for a LNURLw or LNURLp is shown or written to a card or sticker it should be prefixed with Lightning:

fixed


.gitignore update to include .vscode settings

Just a minor change to include the .vscode folder in the gitignore.

Merged.


Download remotely-located resources on driver startup. Use init-container on executors.

Combines #240 and #249 while not including #246. This approach is different from #240 in that it uses a single init-container to fetch all dependencies at once.

Still missing tests, but ready for review on the concept @aash @foxish @erikerlandson. Apologies for the PR being so large - the old architecture had to be replaced with something more flexible given the new use cases:

The need to use the same init-container but dynamically insert configuration to fetch resource staging server dependencies, and
Re-use the init-container attachment logic for the executors.

rerun unit tests please

rerun unit tests please

Test failure is from #255

rerun integration tests please

@foxish @ash211 @erikerlandson @kimoonkim
I'm coming closer to finishing tests for this PR. The main ones I have left are for the main provider class and for the main Client code that wires everything together.
In light of #263 and the fact that this particular PR is difficult to review because of its size, I've updated the description of the PR walking through the changes that were made and my general reasoning behind this code. I hope this helps the review process.

@mccheah Thanks for the summary in the description. It really helped review the PR.

rerun unit tests please

LGTM

rerun unit tests please


[RHCLOUD-18319] Added resource requests and limits to database provid…

…er along with tests and docs.
Signed-off-by: Adam Drew<EMAIL_ADDRESS>

You'll need to run make build-template and commit the deploy.yaml and deploy_mutate.yaml before this will pass tests

@BlakeHolifield Do we want to leave it completely open to set resource limits here? Or do we want to t-shirt size it?

Thanks for looking! And good idea about the sizes. Would you want that in a new PR or in this one if we do it.

As we are intending to modify the spec, we would want to do it here I think - apologies - we can discuss in standup briefly today and spin out into another meeting if we feel necessary

@psav Yeah that's an interesting point. My only reservation here is that we don't do any t-shirt sizing for resources currently. It might be a bit confusing to be able to set the full `resources key on pods and jobs, but not on databases.

/retest

Let me know if there's anything else yall need me to do on this. Tests were failing because md5sum on my deploy.yaml didn't match what jenkins was generating. It was because my pyyaml was way out of date. Confirmed that md5 on mine matches jenkins now. Noticed test status has disappeared from this PR - not sure if that's normal or not.

/retest

retest ran, it failed in:
11:14:00         --- FAIL: kuttl/harness/test-multi-db-shared (3.83s)
11:14:00         --- FAIL: kuttl/harness/test-web-services (13.39s)

So I guess I need to track down if my changes caused that. I mean, I assume they do. I'll catch up with @BlakeHolifield

Kuttle failed again with:
resource Deployment:test-localdb/app-a-db: .spec.template.spec.containers.resources.limits.memory: value mismatch, expected: 1024Mi != actual: 1Gi

Kinda surprised. Why doesn't this affect anything else - I copied and pasted those limits.  Fixed and pushed will see what happens.

OK, so I think everything I touched it working. Builds are still failing though

kuttl.test-multi-db        Error Details            Error Details           failed in step 1-pods Stack Trace            Stack Trace           Internal error occurred: failed calling webhook "vclowdapp.kb.io": Post "https://clowder-webhook-service.clowder-system.svc:443/validate-cloud-redhat-com-v1alpha1-clowdapp?timeout=10s": context deadline exceeded | 13 sec | 2
-- | -- | --
kuttl.test-multi-db-shared        Error Details            Error Details           failed in step 1-pods Stack Trace            Stack Trace           Internal error occurred: failed calling webhook "vclowdapp.kb.io": Post "https://clowder-webhook-service.clowder-system.svc:443/validate-cloud-redhat-com-v1alpha1-clowdapp?timeout=10s": dial tcp <IP_ADDRESS>:443: connect: connection refused

[kuttl.test-multi-db](https://ci.ext.devshift.net/job/RedHatInsights-clowder-pr-check/2218/testReport/(root)/kuttl/test_multi_db/)
 Error Details  Error Details

failed in step 1-pods

 Stack Trace  Stack Trace

Internal error occurred: failed calling webhook "vclowdapp.kb.io": Post "https://clowder-webhook-service.clowder-system.svc:443/validate-cloud-redhat-com-v1alpha1-clowdapp?timeout=10s": context deadline exceeded

	13 sec	[2](https://ci.ext.devshift.net/job/RedHatInsights-clowder-pr-check/2217/)
 [kuttl.test-multi-db-shared](https://ci.ext.devshift.net/job/RedHatInsights-clowder-pr-check/2218/testReport/(root)/kuttl/test_multi_db_shared/)
 Error Details  Error Details

failed in step 1-pods

 Stack Trace  Stack Trace

Internal error occurred: failed calling webhook "vclowdapp.kb.io": Post "https://clowder-webhook-service.clowder-system.svc:443/validate-cloud-redhat-com-v1alpha1-clowdapp?timeout=10s": dial tcp <IP_ADDRESS>:443: connect: connection refused

So, not sure what's up with that. I haven't touched those tests (other than to copy stuff out of them) and that looks like an external dependency?

/retest

We talked a bit in chat and decided on a different change for that comparison. I think I've fulfilled everything requested, but I'm new to this interface so let me know if I missed something or need something else. Tests are massing so we're either ready for more review or merge I think.

We talked about this before the holiday; I'm going to move this to the t-shirt sizing system we use elsewhere.

Hmmm, well, I started going down the road of implementing t shirt sizes for CPU and RAM but it gets murky. We have 2 options:

Extend the spec with new DBCPUSize and DBRAMSize options (and corresponding JSON opts) to match the currently existing DBVolumeSize
Replace DBVolumeSize with Size and have volume, RAM, and CPU all just use that

Option 1 doesn't require a spec change from any user configs, it just provides new options. However, it makes config (arguably) confusing and messy with a 3x3x3 matrix of possible size combos. Option 2 is parsimonious and thus my aesthetic preference but it will require a spec change for customers. So, that's worth considering and discussing.
I spoke with @psav this evening about implementation and we talked about going with the single size, but the spec change requirement didn't hit me then so I'm noting it here now and we'll talk about it tomorrow.

Upon further consideration it may make sense for me to just close this PR and start over because I'm pretty sure t-shirt sizing wont share a single line of code with this PR! Well catch up tomorrow :)

We talked a bit this AM and decided that we'd just add to the spec rather than change it. DBVolumeSize will stay as is; we'll add a sibling DBResourceSize that will deal with compute and RAM.

I'm closing this in favor of an alternative approach in https://github.com/RedHatInsights/clowder/pull/597


[chip-tool] Get logging code to have a dedicated non-generated class that includes generated code

Problem
Commands/Attributes/Events logging code in chip-tool  is a mix of generated and non-generated code but all of it lives into commands.zapt, which makes it harder to maintain than necessary.
Change overview

Move non-generated parts of the logging code to a dedicated class
Move the generated parts to a dedicated template
Use the result of the dedicated template into the non-generated class

Testing
I have manually checked that the logging code still works.

/rebase