Add option to exclude function properties when encoding objects

The behavior of JSON.stringify is to exclude properties on an object that store a function:
JSON.stringify({ f: function(){} }) // '{}'

Current behavior of msgpack-lite:
msgpack.decode(msgpack.encode({ f: function(){} })) // { f: null }

Behavior this PR introduces - excluding functions is the new default:
var obj = { f: function(){} }

msgpack.decode(msgpack.encode(obj)) // {}

// To get the old behavior
var codec = msgpack.createCodec({functions: true})
msgpack.decode(msgpack.encode(obj, {codec: codec})) // { f: null }

Justification
The behavior of JSON is convenient for me, because when prototyping ideas, I often serialize whole ES6 class instances without explicitly picking properties (I'm lazy). msgpack-lite already excludes the class prototype's functions since it uses Object.keys to encode objects, but functions set as properties on the object (like functions that are bound using the common idiom in the constructor) will remain.
class Foo {
  constructor() {
    this.someProp = 123
    this.boundFunc = this.boundFunc.bind(this)
  }

  someFunc() {
    return "hello"
  }

  boundFunc() {
    return this
  }
}

msgpack.decode(msgpack.encode(new Foo())) // { someProp: 123, boundFunc: null }

boundFunc would be sent over the wire as null and is of no benefit.
That said, I realize someone out there might have actually added a custom encoder for functions, so excluding them by default is maybe not the right solution. 100% open to discussing and making any adjustments necessary.
An alternative idea may be a codec option which allows you to exclude certain types from serialization.

Closing since there doesn't seem to be any interest.

I'm sorry to the late response. I'd like to merge this at the same time with merging the similar issue #71 .
Issue #71 wants to map undefined to be stripped.
PR #78 wants to map function to null.
Those two seem similar requests. Your code looks pretty clean. LGTM. The option parameter name functions may give confused, however, at the contrast of yet another option made with issue #71 . Could I ask you a pair of option parameter names of those two?

ignore_function
function_null
function_to_null
strip_undef
ignore_undef
etc

I like the new default behavior given with your patch.
var obj = { f: function(){} }
msgpack.decode(msgpack.encode(obj)) // {}

Idea:

ignore_function is true per default which removes the property. If it is false, it runs as before.
ignore_undef is true/false per default which removes/keeps the property.

I'm more happy when you could also give a code and README for those two!

Sorry @kawanet, I hope I didn't make you feel guilty - I know how it goes. I was just cleaning out my PR queue.
Thanks very much for the feedback. I'll do what I can to address your comments.


Cannot draft release without tag

Gitea version (or commit ref): 1.8.3, 1.9.0 (incl. Codeberg)
Git version: 2.11.0
Operating system: Linux Mint
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
I usually draft my release notes while features get completed – so on the day of the release, I just need to tag and then publish the release. That works well here on Github – but doesn't seem to work with Gitea:

when trying to save a draft, Gitea forces me to specify a tag (which does not yet exist – and besides, I miss a drop-down with existing tags in that place)
when migrating a repo which on Github has such drafts (with no tags assigned), Gitea crashes with a 500 Server Error (reproducible, at Codeberg).

Suggested solution
Please permit saving Drafts without enforcing tags upon them. Helps for consistency – and also for "not forgetting things in the release notes".
PS: Just verified after updating my instance to 1.9.0 (issue still exists).

Regarding

when migrating a repo which on Github has such drafts (with no tags assigned), Gitea crashes with a 500 Server Error

This should be considered a kind/bug

Indeed. And in a first step (regardless of whether "draft without tag" will be implemented) it should be caught and presented to the user. Currently, the 500 appears after the repo itself has been (successfully) imported – but before issues are imported. Thus

leaving the impression the entire process has failed (but a subsequent try will fail with "repo already exists")
not importing issues, wiki etc. (when selected), though that would be successful

So when encountering such a draft, only that draft should be skipped – until Gitea allows for such drafts to be created.


possible to factor out a reusable npm library, not dependent on React?

There would be a lot more users if such a library were available!

Good timing! I just opened a PR to lay the groundwork for that.
https://github.com/tone-row/flowchart-fun/pull/17
I'll leave this issue open until it's actually working.

I would also like to add ability/documentation for shapes and connections output in a easy to utilize data object.
Something along the lines of (yaml for ease):
(foo) foobar
(bin) binbar
  (foo)

shapes:
  - alias: foo
     line: 1
     text: foobar
  - alias:bin
     line: 3
     text: binbaz
connections:
  - source:
       alias: bin
       line: 3
     desitnation:
       alias: foo
       line: 1

Going to close this now that we have https://www.npmjs.com/package/flowchart-fun up and running.
@james-powis I will keep this suggestion in mind 👍 Feel free to add to the custom shapes discussion here.


Refactor MLOpsContext into separate catalogs

Resolves
Fixes #104
Description
Refactored MLOpsContext into separate catalogs.

This is ready for a review!

@aslotte. Looks good .Just wondering about the name "LifeCycleCatalog". is it too long? How about just Experiments?

Great point @AnoojNair. I meant to just call it LifeCycle. I started off with the name ExperimentCatalog but since it also contains operations on Runs I tried to think of a better name. Happy to think about a better name going forward. Let me know if you have any suggestions! (naming is hard)


Missing acceptable values in action parameter

Added missing acceptable values - #9029

@bpelikan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

I'm closing - the doc has been updated #9029.


Provide css emmet abbr suggestions when inside style attribute

In the above case, there are no suggestions from the emmet completion provider.
Css abbreviations should be suggested.

Closing this as #29113 can cover this feature ask

In the latest Insiders it is possible to get css emmet completions inside the style attribute but only if there is a space after the "

 would give the right completion i.e display: none
but
 wouldn't give any completion
This is because we assume that current word is the abbreviation in case of css. With https://github.com/emmetio/extract-abbreviation/commit/ee01c36993ef44c0bb1091091fce416416069408 we can use the extract-abbreviation module to fetch the abbreviation correctly

Emmet completions are now included but only when either manually triggered or when the abbreviation contains non word characters. Currently blocked on #13735

Turns out the problem is that completions don't get triggered inside strings. Adding the below will give emmet completions inside the style attribute as expected:
"editor.quickSuggestions": {
        "other": true,
        "comments": false,
        "strings": true
    }


Update deps

Updated dependencies to mostly most recent versions where applicable. Most notably stanza.io et al. Works with npm 3.x and node 6.x.

:tada: @legastero do you want to take a look?


Reconfigure the JSON schema for API input

Currently, the schema being used for API input is based on the s(CASP) language directly, which requires the user to be aware of how facts should be translated into s(CASP) directly. It would be more user-friendly if the schema allowed people to specify data in terms of categories and attributes.
Because this is a major API change, it's a high priority.

I think this is going to make it so much easier to build the automatic interview feature, I'm moving it to that milestone instead.

The easiest thing I can think of to do is a four-level dictionary, where the first level is category names, with a list of instances of each category, and within each instance a dictionary of properties with values, which may be symbols (references to other things) or booleans, or numbers, dates, or durations. We should generate unary predicates from the first-to-second level of the dictionary, and binary predicates from the second-to-fourth level, using the predicate names from the code.
{
  person: [
    jason: {
      nerd: true,
    },
  ]
}

would generate
person(jason).
nerd(jason,true).

Need to see if there is an applicable JSON standard for durations, or come up with a syntax for them.

We need a way for the user to specify to the relevance end points what inputs have been fully collected.
{
  person: {
    members_known: false,
    attributes: [
      {
        name: nerd,
        values_known: false,
      }
    ],
    members: [
      jason: {
        nerd: {
          values_known: true,
          values: [ true ],
        },
      },
    ]
  }
}

If we did it like that, we would need to generate
% person is abducible.
#abducible person(X).
% nerd is abducible for things that are not jason.
-nerd(X,Y) :- not nerd(X,Y), X \= jason.
nerd(X,Y) :- not -nerd(X,Y), X \= jason.

So maybe the first thing to do is to run some tests and see if that code actually does what I'm anticipating it would, or if there is another way of getting at the same thing. It does seem like the abducibility statements are going to be too general, though.

The concrete statement nerd(jason,true) may be enough to avoid generating new nerd values, maybe. If we need to create abducibility in the specific, we might be able to just use #abducible nerd(jason,X).. Need to confirm, in any case.

Working with a slightly different structure in branch upgrade_json_inputs


Labelling backdrop nodes not setting correct font size

fixed issue #13 by checking if selectedNodes len == 1 and node class == 'backdrop'
then run setLabel
also ending function call imeediately after


Tail recursion isn't useful until it's mandatory

Tail recursion is one of my favorite tools in the languages that implement it
Javascript engines implement it as a performance enhancement, but as a developer, if I can't rely on it to be there, I can't use it, because it might explode in my face as stack blowing instead
If JS were to mandate from ES${large} on that Tail Recursion Must Live ©, then a whole bunch of my code would get dramatically simpler

Proper tail calls have been a mandatory part of JS since ES2015, but only JavaScriptCore is shipping with them (IIRC). Other engines had full or partial implementations they didn't ship for various reasons, and are not planning to ship despite that being part of the spec.
That's also not something which would be in a library, so I don't think it's appropriate for this repo. Let's try to keep the discussion focused on things which could get added as part of a standard library.

I apologize - I wrote this also before y'all said that on the other ticket.  😄
Also, I didn't know that tail recursion was now mandatory 😮
TIME TO START RELEASING THINGS THAT BREAK IN EVERY BROWSER BECAUSE I AM ALREADY THE BEST KIND OF CORRECT ❤


create journal list to review if papers are accompanied by code link/licence

start reviewing journals that accept software papers and check the following things (need to consider exact metrics, but here's a start):

are articles accompanied by code?

no code
code often found in freeform format so may be hard to tell without careful review, e.g.:

source link may be available in text or references
attached file in supplementary materials (does this ever happen?)
code open source but not linked (may be hard/impossible to tell)
code present in elab notebook or other executable snippet

code required to submit paper. good example is JOSS: http://joss.theoj.org/about
bonus points for:

OSI licence
metadata available describing licence and source link.
written in free / open source language

I'm sure this list will need to be refined.

also consider best format. might be best to go for something simple like a google sheet?

Longer term, I want a nicely service with an API, a UI, and user-specific tokens, but I'd rather get a good idea of the shape of a db record first.
For now, here's the google sheet: https://docs.google.com/spreadsheets/d/1oY5ak7VJa-qwJJeWA3829S-1akZaYtHuWPYpChBdW2o/edit#gid=1946180293 - Anyone with the link can edit; hopefully it won't get spammy and require lockdown

How you can contribute:

add more journals to the list (unreviewed or reviewed)
review journals from the list by stating whether or not they require code for code-related papers.

the journals of the American Astronomical Society promotes software publications, and usually require at least to cite/name the software packages that were used. It doesn't yet enforce the publication of all the software writtent the produce the given result, but definitely a welcomed step in the good direction:
http://journals.aas.org/policy/software.html

Hi @yochannah - are you compiling the journals in the google doc? This blog post seems useful: https://www.software.ac.uk/which-journals-should-i-publish-my-software

@agbeltran Thanks for that link!! I was thinking of maybe spending time on the final hack day at the collaboration workshop reviewing journals to add to https://docs.google.com/spreadsheets/d/1oY5ak7VJa-qwJJeWA3829S-1akZaYtHuWPYpChBdW2o/edit#gid=1946180293 (or maybe even a real db if we have time to set it up) - that is probably a great place to start

Would add that Plos computational biology takes software submissions http://journals.plos.org/ploscompbiol/s/submission-guidelines#loc-software-submissions


Another problem parsing IPv6 addresses

The 2001:db8:cafe::17 address is still not being accepted though.
Originally posted by @vphpersson in https://github.com/declaresub/abnf/issues/10#issuecomment-1176475721

This one looks like I need to add support for backtracking.

Backtracking is implemented in https://github.com/declaresub/abnf/commit/273d54452f5e5a14236668f8b9d86440fc139cca.  I will wait a bit before pushing a new package to pypi in case I get some feedback.

This problem may be resolved in v 2.0.0.


[Feature Request] Output VM kernel logs to host

Is your feature request related to a problem? Please describe.
We would like to have access to the logs from the Kernel running inside the Kata VMs available on the host for debugging purposes. We currently use the console to access the VM to view the logs, but ideally in the future we would like to disable console access (for security reasons) and have the logs accessible on the host.
Describe the solution you'd like
Kernel logs (the sort you get from dmesg) saved onto the node in a central location, e.g. /var/logs/ etc.
Describe alternatives you've considered
We could run a sidecar (an additional container) in our pod that tails dmesg, but we would prefer a more elegant solution that doesn't require running an extra container for exporting kernel logs.
Additional context
N/A
Before raising this feature request
Have you looked at the limitations document? Yes

The guest kernels logs are already available on the host. Assuming you are using the default configuration (using a kata-proxy), the proxy logs its messages to the hosts journal. And the proxy includes messages from:

itself
the guest kernel
the agent

Since all of the above message categories get logged to the journal by process kata-proxy, it is necessary to "unpack" the guest kernel logs from inside the kata-proxy log messages. See: https://github.com/kata-containers/tests/tree/master/cmd/log-parser

@jodh-intel We are using the default configuration, and from what I understand we are using shimv2. Based on this diagram, it looks like kata-proxy isn't used with shimv2?

When starting my Kata containers through Kubernetes, I also don't see a kata-proxy process running on the host node nor can find any VM kernel logs in journal.

Hi @awprice
For shimv2, if you didn't use vsock, it would use a builtIn proxy, which means there is no separated proxy process running. If you want to get the dmesg log, you can:

set  kernel_params = "agent.log=debug"  in kata configure file,
set enable_debug = true    in [runtime] section in kata configure file.

Then you will get the proxy/dmesg logs in containerd's log.

@lifupan I tried your instructions above, and unfortunately couldn't get it to work. I started seeing the proxy logs, but the dmesg logs weren't in containerd's logs. Is there any special VM/kernel configuration needed?
It also seemed to stop console access to the VM working when enabling enable_debug = true in the [runtime] section.

@lifupan I tried your instructions above, and unfortunately couldn't get it to work. I started seeing the proxy logs, but the dmesg logs weren't in containerd's logs. Is there any special VM/kernel configuration needed?

Maybe I misunderstand you, by this method, the proxy would print the qemu's console into logs, including the guest boot logs, isn't that what you want?

It also seemed to stop console access to the VM working when enabling enable_debug = true in the [runtime] section.

Yes, since you enabled debug, the proxy will open the console and direct the console's output into containerd's log.

Maybe I misunderstand you, by this method, the proxy would print the qemu's console into logs, including the guest boot logs, isn't that what you want?

Yep that is what I want, but it doesn't seem to occur. Is there any other configuration needed?

@lifupan I tried your instructions above, and unfortunately couldn't get it to work. I started seeing the proxy logs,
What's the proxy logs did you see?  is there any log lines prefixed with "vmconsole="?

@lifupan I tried your instructions above, and unfortunately couldn't get it to work. I started seeing the proxy logs,
What's the proxy logs did you see?  is there any log lines prefixed with "vmconsole="?

The debug console / proxy log issue is documented in the Developer guide, so I'd really suggest reading that carefully:

https://github.com/kata-containers/documentation/blob/master/Developer-Guide.md#ensure-debug-options-are-valid

@lifupan Apologies, I've now located the vmconsole= lines, and found the kernel logs. Thanks for the help @lifupan, @jodh-intel.

@jodh-intel in a non proxy world, this should be feasible through traces, right?

? Converting guest kernel messages to traces?

I think we can even catch the vm  console output in the noproxy, is it better to add a catch function to noproxy?


Expression references that utilize data functions are not called with ractive instance as this when used as arguments of event or expression methods.

Ran into more fun stuff this evening. If you call a function within another function, the inner function will get called under global scope instead of the instance's scope. Happens in events and in regular expressions:
Example:
**stuff**
 <li on-click='set("data."+virtualToReal(r)+"."+columns[c]+".type", this)'
**more stuff**

What I love about ractive is how crazy you can get in templates, which is super powerful compared to Meteor, Ember, etc. This is actually super limiting and would require you to numerous helper functions to get anything done (one my biggest annoyances with other frameworks) instead of just a couple sets() here and there.
Here's an isolated running example: http://plnkr.co/edit/QH2AlBk1PmEKiBPilcyj?p=preview

Just read the title I wrote lol.
Obligatory http://inception.davepedu.com/inception.mp3

@JonDum took me a minute to follow along - but if I understand correctly, problem could be defined as:
expression references that utilize data functions are not called with ractive instance as this when used inside event methods as parameters

@martypdx Correct! That is more aptly said in ractive terms than I could muster.

should inner functions be allowed in "method-calls"? Or even arbitrary javascript? Or just a warning requesting simple arguments only?

where should these hook on:

root like for the method itself?
data like for expressions?

Dropping in 2 cents:
In plain HTML, inlined JS runs in the context of window. In Ractive's case, it's the instance. It might be more intuitive if everything called inline was called in the context of the instance. Besides, aren't components supposed to be isolated from the world?
As for expressions, I believe they're created using new Function. And MDN says;

Note: Functions created with the Function constructor do not create closures to their creation contexts; they always are created in the global scope. When running them, they will only be able to access their own local variables and global ones, not the ones from the scope in which the Function constructor was called. This is different from using eval with code for a function expression.

Just out of curiousity, stepped through the debugger and found the following code. I assume this is the result of parsing expressions using new Function.
// new Function('_0', 'return ["scope",_0("name")]');

(function(_0
/**/) {
return(["scope",_0("name")])
})

_0 is innerFunction in the expression. The way it is called (_0()) immediately makes window the context.
If only call was used to provide the instance into that method:
var fn = new Function('_0', 'instance', 'return ["scope",_0.call(instance, "name")]');

// (function(_0,instance
// /**/) {
// return ["scope",_0.call(instance, "name")]
// })

fn(_0, ractive);

or the generated function be called with the instance as context:
var fn = new Function('_0', 'return ["scope",_0.call(this, "name")]');

// (function(_0,
// /**/) {
// return ["scope",_0.call(this, "name")]
// })

fn.call(ractive, _0);

I believe I fixed this cleanly. I added a condition to bind the value to ractive inside fireMethodCall if it is a function.
Here's a new example with a new build of ractive in it with my fix: http://plnkr.co/edit/DGBd4oH7v5bS10w9Mreu?p=preview
Clicking the button changes 'scope' to fred and doesn't throw any errors trying to access this.
Should I form a PR for this? I'm not sure where/how to put a test case for this though.


Differentiate not found entry from not found guild or user in fetch_ban

Summary
Differentiate not found entry from not found guild or user in fetch_ban
Problem
Unable to differentiate if the user is not found or if you just provided an unknown user/guild due to how discord implements this
Ideal implementation
TBD

They probably have an error code for it, but until Discord decide to document the format they want to provide us errors in, I don't really want to implement stuff to check that, especially since the v6 format varies so much to the v7 one, and half the useful info on the v7/v8 one is under attributes starting with _, so I assume they are private detail that shouldn't be used.


Removed a simple pitfall case of a consider-using-in case

Problem:
The code was incurring into the consider-using-in pitfall case, as described by Pylint documentation here https://github.com/vald-phoenix/pylint-errors/blob/master/plerr/errors/refactoring/R1714.md
Solution:
Applied adequate refactoring. Only a single line of code was changed

thanks


LPC legacy IAP flash driver

soc_flash_lpc: LPC IAP legacy flash driver
enable soc_flash_lpc on LPC54xxx
updates mpu_test to support for lpc flash driver

Fixes #6040
Depends on https://github.com/zephyrproject-rtos/hal_nxp/pull/75

Please ensure flash  unrestricted alignment of reads. (see #23628)

Please ensure flash unrestricted alignment of reads. (see #23628)

@nvlsianpu this device can read without alignment restrictions.
It respects what #23628 documents.
I don't get what I should do with this, i.e. if any action is required from my side.

@nvlsianpu this device can read without alignment restrictions.
It respects what #23628 documents.
I don't get what I should do with this, i.e. if any action is required from my side.

I just want to be sure that this PR is compatible with mentioned PR. Didn't have time to look into this PR. Thank for confirmation on this, no  further action needed here.

This needs to be merged after 2.4 release, adds support for flash controller on LPC54xxx

@nvlsianpu @MaureenHelm @galak
Now that 2.4 is merged, can we have another look at this PR?

@nvlsianpu @MaureenHelm @galak
Now that 2.4 is merged, can we have another look at this PR?

Looks fine, but needs rebasing

@MaureenHelm rebased and added the missing copyright

@agansari can you rebase again, looks like we've merged something that created a conflict.

@agansari can you rebase again, looks like we've merged something that created a conflict.

@galak done!

@mbolivar-nordic please revisit

@mbolivar-nordic please revisit


read_terragrunt_config does not skip over disabled dependencies, and will error if the dependency has a config path that doesnt yet exist.

Describe the bug
When performing a read_terragrunt_config from a different .HCL to another .HCL that has dependencies, the .HCL with the dependency has its block read whether or not its enabled, when it should be skipped over if its not enabled. This means that if the block has a config path that doesnt exist, it will error even though the module itself will run.
A good subset of my config files utilize read terragrunt config and optional dependencies to achieve minimal definitions for the child HCL files using include blocks, but this completely breaks my process and makes terragrunt unusable with this new feature for dependency block.
To Reproduce
Create a .HCL file to read from where the config path is defined to a dependency path that doesn't exist, and then also set the dependency attribute of "enabled" to false.
// paste code snippets here
HCL with disabled dependency. It will run normally since it is false, and the call for the output is encapsulated in a try
dependency "example" {
 config_path = "/folder/" #this folder and path doesnt exist
 enabled = fileexists("/folder/terragrunt.hcl") #false
}

inputs {
example = try(dependency.example.outputs.test,null)
}

read_terragrunt_config HCL
locals {
  config = read_terragrunt_config("../dependency_example/terragrunt.hcl")
}

Not the best example, making it quickly but it should be obvious what you need to do to reproduce the steps here.
Expected behavior
The expected behavior is that read_terragrunt_config should skip over the dependency block, but its clearly processing it. This causes a glaring issue with any configs relying on read_terragrunt_config with optional dependencies based on file paths existing.
Nice to have

[x] Terminal output
[x] Screenshots

Versions

Terragrunt version: Latest Version 0.51.x
Terraform version: 1.5
Environment details (Ubuntu 20.04, Windows 10, etc.): Alpine

Additional context
Add any other context about the problem here.

Hello,
PRs are always welcome to address this issue :)

Additionally, will be helpful to provide a returned error and an example how to reproduce this issue
I tried to do a similar setup in https://github.com/denis256/terragrunt-tests/tree/master/issue-2734 but invocation of read_terragrunt_config("../app1/terragrunt.hcl") is working fine

Unfortunately my environment is kind of complex with how its linked, but I pinpointed the issue to this issue and resolved it by adding a dummy dependency (empty tf) to load instead.
The error just states that read_terragrunt_config failed: {path_here}/terragrunt.hcl does not exist
I THINK the issue actually is when the dependency is appended to the config from an include file.
On app1, can you potentially create a separate HCL where you load the dependency (named dependency.hcl) and include it as such:
include "env" {
  path = "/env/dependency.hcl"
  expose = true
}

Then remove that dependency block from the terragrunt.hcl in app1? I believe this may actually cause the expected behavior, because this is how I have dependencies mostly setup.

Hello, PRs are always welcome to address this issue :)

Unfortunately I don't have the prowess to make a PR for this project, but want to be sure this issue is known.

Adding onto this, it's not clear to me how this attribute is meant to be used in practice. In particular, it seems like the only time enabled would be beneficial is if it's variable (i.e enabled = local.has_dependency_x). Otherwise, the dependency wouldn't need enabled (it would always exist) or we wouldn't need it at all (no dependency block).
In the variable case, it's not clear to me what the expectation is for dependency outputs. If the dependency is enabled = false, what's the expectation for outputs that we'd otherwise reference?
It seems to me that the answer to this problem is to always inject mocked outputs whenever we see a disabled dependency and not try loading the config.

I've created https://github.com/gruntwork-io/terragrunt/pull/2816 aiming to address this.


Can we remove the hardcoded btrack/VERSION.txt version file?

For the python side of things, we should be able to use dynamic versioning from git tag using setuptools-scm. However, it is also used in the Makefile for the backend, so not quite as trivial.
See discussion here https://github.com/quantumjot/BayesianTracker/issues/212#issuecomment-1461856065

Potential idea https://stackoverflow.com/a/71592061/7359333


Compliance changes to terminology

Replace inaccurate user-facing descriptions of PS as anonymous to mixed or private, since Dash is a transparent blockchain.

@codablock yep, I'll update en source on Transifex and #3192 once this one merged.


[BUG] Multiple context menus

Environment
Self-Hosted (Docker)
System
Firefox 103.0.1 (64-bit)
Version
2.1.1
Describe the problem
When i right click on different tabs i can open multiple context menus on each app tab (screenshot below) i thought maybe this was suppose to happen but when i click on EDIT the other context menus disappear...
Additional info

Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Try left-clicking...?

But yeah, it is a bug. The closing of the context menu is handled with a custom directive, here: directives/ClickOutside.js.
Listening for right-clicks is harder, since users often accidentality right-click on the option they want while using a right-click menu.


could i define my own split function for tree growth

now i want some custom logic to inform sub nodes
is there any interface?

You need to modify C++ code for that.  For CPU algorithm, split evaluator can be a starting point.  For GPU algorithm, look at constraints.cuh

You are welcomed to help designing an interface.


Is it a RX580 ERROR? Backward-propagation doesn't work both in tensorflow and pytorch.

Recently I use tensorflow-rocm to train my model, but the result is wrong while the same code work well in another CUDA computer.
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/issues/337
And some guys who use pytorch-rocm meet the same problem: his code doesn't work on rx580, but works well in pytorch-rocm developer's gfx900 architecture.
https://github.com/ROCmSoftwarePlatform/pytorch/issues/342

Closing this since there are open issues both in tensorflow-upstream and our pytorch branch about this.


Design exploration for new Cog schema and API

An exploration of #193, #205, and #259, based on a design we have sketched out in private (soon to be on GitHub). Also incorporated in this design, not represented on GitHub, is how we can add a public queue-based API for Cog.
This is here for visibility and so @zeke and I can collaborate on this. Not ready for reviewing yet.
A few notes:

The README is an exploration of how we might simplify and explain the value proposition given the new design. It is not the right design.
I have started converting the tests to explore what we need to implement. Most of these tests can be removed -- they are merely testing Pydantic/FastAPI behavior.
The main missing part of the HTTP server is handling files. URLs need converting to files. #266 might want to be considered as part of this too.

See also

#327

Rebased on top of #369.

Notes from conversation with @andreasjansson about integrating this with Replicate's Redis queue:
Serving mostly blinding passes through JSON, so we can mostly re-use the existing system. The only thing that serving modifies is the status field, for statuses like queued etc.
Files
Inputs will be signed URLs from web.
Outputs will be posted to a URL web that is passed as part of request, which will return a URL that will be embedded in output object. E.g.:
{
    "input": ...
    "file_upload_url": ...
}

All file handling will be removed from serving, and serving will blindly pass through these JSON objects.
Logs
We want to get rid of the separate logging queue because it doesn't work very well. We will make the prediction object returned by Cog consistent with what is current returned by serving. Both HTTP and redis will use this object for prediction output/status:
{
    "status": ...
    "output": ...
    "logs": ...
}

Serving will blindly pass this through and not have separate queue for logging.

Replaced by #378.


Run Migration on all workspaces

@lasryaric can we tweak the migration so that ti does not take conversations that are less than 1h old
That way we can run it once and then re-run it post switch without missing messages from "live conversations"

Sounds good. Taking that.

ETA?

30 minutes.

Migrations as not been done on workspaces yet but the command is available and can be run at anytime.


Test
~upvote=5|downvote=0

Content

🏰 Discord Suggestion from BridgeTroll@279979126125756416

user BridgeTroll@279979126125756416 voted +

user BridgeTroll@279979126125756416 voted -

user BridgeTroll@7127 voted +


Documentation Readme addition to install integration?

Probably just me being a newb, but the documentation readme on https://github.com/thecode/ha-onewire-sysbus doesn't actually end with 'now add/install 1Wire-sysbus integration' on the front end as a final step.  It just seems to suggest that 'on boot' the devices will be available/visible in dev tools.  Confused me a bit but all working now.

Thanks, I will update the docs to include this step


Add parameter to Maps API calls to identify client

See #444
This adds a client=vl-VERSION parameter to Maps API calls (both map instantiation and mvt tile fetches).
Should we send it only for map instantiation?
Other decisions I've taken:

single parameter to identify client (CARTO VL) and version. The alternative would be to use separate clientand client-version parameters
short identification of client: vl not carto-vl
version not prefixed by v

We should use definePlugin  to define a carto.VERSION property at compile time.
// index.js
export {
    setDefaultAuth,
    setDefaultConfig,
    source,
    expressions,
    Layer,
    Viz,
    Map,
    Interactivity,
    version: VERSION, // eslint-disable-line
};

// webpack.config.js
  plugins: [
    new webpack.DefinePlugin({
      VERSION: JSON.stringify(require("package.json").version)
    })
  ]

Finally, we're leaving this as is because we now have tree shaking to remove unused code.


Add pipeline logging

Resolves #60.  Adds basic logging to the pipeline, mainly to surface exceptions that are currently swallowed in the EtlPipelineStep.RunSafely method.
The public IEtlPipelineStep fluent configuration interface is modified to add a new LogTo method to set the logger for the entire pipeline.  This logger is saved in the internal pipeline context and used by all steps, meaning we do not support a separate logger instance for each step.

Closing without merge.  This work will be added in a different PR.


Link to practical example of splitting large txns

Relates to #4409, #7524.

Eric this is not new info, but I was surprised that our statements to "make them smaller" weren't linked up to something that said how to do that.   Let me know if you think these are wrong (I don't think so? but it's late afternoon, ha)


max read length

Thanks - could you update the PR by wrapping the two conditions that are OR'ed in parens?

Sure. Done.

Sorry for the delay!


revert linsolve changes

Purpose and Content
Reverts just the linsolve changes from #585.
Long run here:
https://buildkite.com/clima/climaatmos-longruns/builds/238
Benefits and Risks
(State concisely the benefits to be derived from and the risks associated with this PR)
Linked Issues

Potentially fixes #610 (hopefully)

PR Checklist

[ ] This PR has a corresponding issue OR is linked to an SDI.
[ ] I have followed CliMA's codebase contribution and style guidelines OR N/A.
[ ] I have followed CliMA's documentation policy.
[ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
[ ] I linted my code on my local machine prior to submission OR N/A.
[ ] Unit tests are included OR N/A.
[ ] Code used in an integration test OR N/A.
[ ] All tests ran successfully on my local machine OR N/A.
[ ] All classes, modules, and function contain docstrings OR N/A.
[ ] Documentation has been added/updated OR N/A.

This seems to fix it: @charleskawczynski


Use metatransaction for loading unscheduled_jobs

Changes proposed in this PR

Use metatransaction for loading jobs in a user's queue for unscheduled_jobs

Why are we making these changes?
Fixes a bug where users would see enqueued, uncommitted jobs in unscheduled_jobs.


[PAXLOGGING-210] Restore JDK 1.6 compatibility in api and service

The build target was flipped to JDK7 in 0673135 since log4j2 requires
JDK7. This commits restores JDK1.6 compatibility with the other modules,
leaving 1.7 as the target for pax-logging-log4j2. This does require
sorting out some diamond operator usage in pax-logging-api for the
log4j2 bits, and thus deviating from upstream, but I think this small
effort is worth the compatibility we get in return.
JDK6 is in extended support from Oracle until Dec 2018, IBM will support
JDK6 even longer.
pax-logging 1.8.x will be the last version supporting JDK6.

Refer back to https://github.com/ops4j/org.ops4j.pax.logging/pull/22

Thanks @gnodet :)


5 minutes

I added interval minute and it appears to work fine.  Is there a way to do every 5 minutes instead of every minute?

Yes, I ask the same question...

See #91.


{Network} Desensitize tests for private link Microsoft.Cache/Redis

Related command

az network private-link-resource
az network private-endpoint-connection
Description

Resolved the issue mentioned in:

https://github.com/Azure/azure-cli-pr/issues/136

Removed previous suppression for credential scan:

https://github.com/Azure/azure-cli/pull/20867

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network


Store submission information in the cache for a limited time

Description
This PR includes the following proposed change(s):

FLA-66 - Store submission information in the cache for a limited time

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Locally
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes

Ahahha huge and large, won't do that again @akroon3r @sdevalapurkar-bcgov


:art: rounded radio button

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] REF #6062
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[x] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at fa415ba
Added a circular option to the NeoRadioButton component and a global variable for the circle radius. This enhances the UI library with more flexibility and consistency for radio buttons.

🤖 Generated by Copilot at fa415ba

Sing, O Muse, of the skillful coder who devised
A new feature for the NeoRadioButton, a component wise
And versatile, that can now assume a circular shape
Like the radiant sun or the full moon, with a simple $radius-rounded escape

next we could remove top drop shadown and add solid border as seen in New design


[cuda] Avoid serializing all nodes in graph command buffer

This commit improves the graph node dependency management by avoid serializing all nodes in the graph command buffer to a linear chain. Instead we categorize nodes into batches, using barriers as boundaries. Nodes inside two consecutive barrier commands can now run in parallel. This works for the current compiler. In the future we can further improve the logic to take into consideration of access scopes.
Progress towards https://github.com/openxla/iree/issues/13245

Closing in favor of https://github.com/openxla/iree/pull/14857.


Icons on black circles to make it clear

Nice minimalist interface, but I'd like to see icons in the circles (so like a mic and a display for mic+screenshot and so on).
Thank you!

So true, and i will.


save-data: move static data out of function

I don't understand why useState is being used here, so I thought I'd make a PR to figure it out.

The tests fail because they change the navigator data after the module has loaded, which wouldn't happen in a real browser.
@googlebot I signed it!

You forgot to remove the useState import

Thank you for working through these changes to drop useState where it's unnecessary, @wmertens. Happy to land this patch.


CUDA Error: no kernel image is available for execution on the device (209) /tmp/build-via-sdist-nl8se4dx/flashinfer-0.0.4+cu118torch2.2/include/flashinfer/attention/decode.cuh: line 871 at function cudaFuncSetAttribute(kernel, cudaFuncAttributeMaxDynamicSharedMemorySize, smem_size)

Does the cudnn can not be v9?

This is due to CUDA version mismatch, what's the CUDA version (and PyTorch CUDA version) on your device?
nvidia-smi
python -c "import torch; print(torch.version.cuda)"

Am using cuda118 ,
>>> import torch
torch>>> torch.__version__
'2.2.0+cu118'

installed with pip install flashinfer -i https://flashinfer.ai/whl/cu118/torch2.2/
my torch works ok (even though torch now using their own nvidia toolkit through pypi)
Doe sthey any miniml func can be test why the cuda is mismatch?


Improve debugging printfs

This improves the log output. Instead of only one Debug() printf for everything, there are now proper loglevels: LogDebug(), LogInfo(), LogWarn(), LogErr()`.
It also adds file name and file number to the printfs which should help to figure out where stuff went wrong.

Awesome! What about adding a timestamp? This could be helpful in many cases.

Good idea, will add a timestamp. Local time or seconds since the library is running?

I'd vote for local time.

Time added in f063fae. The resolution is seconds. What do you think?

I think its fine for now, lets test this out for a few days

@julianoes  Can you rebase?

this is an API for people developing DroneCore to see what is going on.

correct.

There doesn't appear to be an actual log - everything is going out to the standard cout console?

yes.

There doesn't appear to be any way to control what output is displayed from a user point of view - this is just nice colour coding to help people looking at the debug output work out what is critical and what is less important?

There is one thing. If you build for Debug, you see the LogDebug printfs (and all others), if you build for Release, you do not see the LogDebug printfs.

This is not exported, so it can't be used by some third party writing DroneCore apps - only plugin developers?

It's internal for now, yes.

I presume you want some docs in the "Contributing" section?

Yes please, especially the log levels and the fact that LogDebug is ignored for Release builds.

As Julian says, the fact that the clock is monotonic not very relevant - it is very unlikely to ever overflow, and will always be local time since start of exe right?

Yes, it's just to have some time context.

@julianoes @mrpollo
Thanks. As we just discussed, the fact that this is internal means that you can't use it in our example code - where it would be very useful.
Would it make sense to take this a step further and finish developing the public Logging API? Essentially this would be the same, except that you could redirect the output to console or file or both.


Allow inject after asynchronous function outside setup()

What problem does this feature solve?
Currently it's impossible to access inject outside an async setup() but that does originated from a setup()
sfc demo
What does the proposed API look like?
/

Duplicate of https://github.com/vuejs/vue-next/issues/1409


Enable short hexadecimal color notation

Enable short hexadecimal color notation

@lucasmichot do you plan to finish this PR?

I have to dig again into it, when I'll have time - let me some days

FInished @blaugueux

Can you squash your commits please

Done


#trivial Cleanup old GIF code

Goodbye old friend…

          1 Warning

:warning:
This is a big PR, please consider splitting it up to ease code review.

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
This is a big PR, please consider splitting it up to ease code review.

  Generated by :no_entry_sign: Danger


We should capture all file path for in a spec's ID

Replace paths_ with a new object, such as FileSplit which should capture {file path, offset, length} and these should be part of the spec identifier. @ritvik-statsig

Quote unresolved comment:
we may want to include watermark_ in this new object too - think about the case that Time Macro is at the file name, and if you combine multiple files which have different time values, we will need watermark for each file. Unless we guarantee different watermarked files won't be grouped into one spec.

Similarly, we should include all paths in the string result.

This is resolved in #177


Nested object 'required' errors on missing properties not applied

The following line of code returns an undefined 'prop' element in case of nested object validation:
https://github.com/makinacorpus/angular2-schema-form/blob/03a708cb877a89b43cbba83dfb7d1bc5e6b3fd04/src/model/objectproperty.ts#L68
This is due to the fact that the searchProperty is done from the root, but as validation is done partially on every property, for object properties, search properties algorithm in error should be done relatively to the object itself and not the document root.
Path returned by ZSchema start with "#/" in case of object property validation. The consequence is that the code of propertyobject.runValidation only work for the first level object.
I still don't know what's the best option to solve this issue, but keep you informed.

Replaced a searchProperty  by a getProperty... and seems to work with nested objects.
At least, it makes sense to read property instead of search property in the PropertyGroup hierarchy.

After digging more in the validation algorithm, I think the main problem with validation, is that it's run multiple times for the same property. At the object level and at each property level, not always in the same order. And given the path resolution problem, errorMessages of ControlWidget is 'often' not appropriate and vary a lot regarding which field has already been filled.

Finally, an ultimate question : Why don't we run validation only at the root level at least for JSON schema validation ? I saw in the debug that the JSON schema made once on the root element returns all the schema errors with the valid path from the root.
Am I missing something ?

When we implement a wizard form where the user moves from a fieldset to another, it is useful to be able to display the current fieldset errors only.

I absolutely agree with the need. But I think validating schema from the root will not prevent from having this feature. By default z-schema stop at the first error, but there is an option to continue. In that case, the whol schema is validated, and all the property paths are from the root.
https://github.com/zaggino/z-schema#breakonfirsterror
The fact is that modifying a property deep in the object hierarchy will bubble up to the root. And validation is made at every stage.
Another problem, is that validation is that use case:
Let's say we have this schema:

{ type: object,
properties: {
name: {
type: string,
minLength: 10
}
}
}

In the current implementation, without changing anything to the 'name' property (on first load) there will be two JSON Schema validation
"", { type: string, minLength:10} => will fail because the string is not long enough
and
{}, { type: object, properties: {name: {type: string,minLength: 10}}} => will succeed because the name property is not required.
In the end, I like the idea of properties that validates on their own. But at the end it generates side effects due to path resolution on failing properties returned by Z-Schema.
I suggest that AtomicProperty keep on validating on their own for custom validators for efficiency, but keep JSON Schema validation at the root level with the correct option for PropertyGroup.
This design will simplify the overall validation and path resolution as everything start from the root.

Oh I see! You are right.
If you have time to implement it, please do, we will review your PR (do not hesitate to push a work-in-progress PR if you need some advices about the implementation).

Of course, If I have time I'll push a PR. Thanks for your approval.

Any changes?

With breakOnFirstError option all works as expected.

@Invis1ble where did you apply this option?

@sunew on ZSchema intantiation, see in my commit.
https://github.com/zaggino/z-schema#breakonfirsterror
https://github.com/zaggino/z-schema/issues/131

Fixed by https://github.com/makinacorpus/angular2-schema-form/pull/202


Consider affinity value as a regexp patterns

See docker/swarm#298
Signed-off-by: Pierre Wacrenier<EMAIL_ADDRESS>

Build failed because of tests, fixed in #297


french no upper characters for date

hello
when the mirror is switched to french we lose all uppercase character for the date .
is there a way to change that?

also,  probably noob question but i scouted the internet without finding an answer
how to remove the FR at the end of the location and how to make all the "e" and "é" look the same

thanks you very much for all the good work and infos you're sharing here
best regards

Please refer to http://forum.magicmirror.builders for support and troubleshooting.
I'm closing this issue for now. If you feel this issue should remain open, please let me know.


get_sites(with_var_src = 'watershed') returns rep(NA,10000)

probably not the desired functionality?

definitely not! let's fix that.


Getting redirect_urls

Hello,
Is there a way to access the redirect_urls using scrapy-playwright.
I can see the redirections taking place using DEBUG but cannot seem
to access the list and associated status codes.
Thanks in advance.

In Scrapy this is usually handled by RedirectMiddleware, but I think the issue is that when using scrapy-playwright, the redirects happen internally inside Playwright and Scrapy never sees the intermediate requests and responses. I think the solution would be for scrapy-playwright to handle this itself and put the info in the meta in _download_request_with_page. It should be able to do this using https://playwright.dev/python/docs/api/class-request#request-redirected-from


STY: flake8

First test should fail because I haven't fixed any of the example files yet. Then it should pass.

besides LGTM
thanks @Eric89GXL for all this.

Thanks for the eyes


Ionic framework Msal React not working in Native devices (iOS and Android) [works perfectly in Web]

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.14.1
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.0
Description
Msal React in Ionic framework not working in Native devices (iOS and Android) [works perfectly in Web]
In iOS the accounts array returned by useMsal is always empty
import { useMsal } from '@azure/msal-react';
In Android the instance.loginRedirect function fails with below error:
BrowserAuthError: pkce_not_created: The PKCE code challenge and verifier could not be generated.
Error Message
iOS:
No Error stack, we just don't get any account within the accounts array returned by useMsal
Error Stack in Android:
Uncaught (in promise) BrowserAuthError: pkce_not_created: The PKCE code challenge and verifier could not be generated. Detail:TypeError: Cannot read property 'digest' of undefined     at BrowserAuthError.AuthError [as constructor] (com.mlf.app://localhost/main.bundle.js:765:24)     at new BrowserAuthError (com.mlf.app://localhost/main.bundle.js:7476:28)     at<EMAIL_ADDRESS>(com.mlf.app://localhost/main.bundle.js:7486:16)     at PkceGenerator.<anonymous> (com.mlf.app://localhost/main.bundle.js:7762:48)     at step (com.mlf.app://localhost/main.bundle.js:312:23)     at Object.throw (com.mlf.app://localhost/main.bundle.js:293:53)     at rejected (com.mlf.app://localhost/main.bundle.js:284:65)
Msal Logs
No response
MSAL Configuration
{
    clientId: `NOT_ADDING_REAL_ID`,
    authority: `NOT_ADDING_REAL_AUTH`,
    knownAuthorities: ['NOT_ADDING_REAL_TENANT'],
    redirectUri: 'NOT_ADDING_REAL_URL',
    postLogoutRedirectUri: '/',
    navigateToLoginRequestUrl: false,
scopes:['NOT_ADDING_REAL_SCOPE']
  }

Relevant Code Snippets
const { instance, accounts } = useMsal();
  const account: AccountInfo | null = useAccount(accounts[0] || {});
  const request: SilentRequest = {
    scopes: protectedResources.apiHello.scopes,
    account: account || undefined,
  };

  useEffect(() => {
    if (account) {
      instance
        .acquireTokenSilent(request)
        .then((tokenResponse: AuthenticationResult) => {
          if (tokenResponse) setAccessToken(tokenResponse);
        })
        .catch((error) => {
          if (error instanceof InteractionRequiredAuthError) {
            return instance.acquireTokenRedirect(request);
          }
        });
    }
  }, [account]);

Reproduction Steps

Configure msal react in ionic app
Run the app in iOS or Android

Expected Behavior
Expect msal to work correctly in Native devices i.e. similar to Web
Identity Provider
Azure B2C Basic Policy
Browsers Affected (Select all that apply)
Other
Regression
No response
Source
External (Customer)

@dipankarmedhi91

BrowserAuthError: pkce_not_created: The PKCE code challenge and verifier could not be generated.

This error happens when the browser doesn't have access to the crypto APIs, which are needed by MSAL. Normally, this is not an issue if your app is served on https (which is also required for the redirect uris). If you are running in an environment where they do not exist, you will need to provide a window.crypto polyfill, such as MSR crypto: https://github.com/microsoft/MSR-JavaScript-Crypto

No Error stack, we just don't get any account within the accounts array returned by useMsal

This is potentially a caching issue. Have you tried debugging MSAL for this error? Are you able to login?
Note, unfortunately Ionic is not an environment we fully support, so we cannot guarantee MSAL.js will work fully with Ionic.

@jasonnutter Thanks for the reply
Yes we have tried debugging MSAL, the accounts array remains empty even after we get successfully redirected from AD B2C after correct Login.
Also just to understand on the Note above;
Does that mean that MSAL libraries will not work with Ionic currently ?
Or is there any existing limited support for it ?

ionic iOS : Yes we have tried debugging MSAL, the accounts array remains empty even after we get successfully redirected from AD B2C after correct Login.

You do not appear to set a cacheStorage option, which means MSAL will default to sessionStorage. Is there anything in sessionStorage? Is sessionStorage even available?

Also just to understand on the Note above;
Does that mean that MSAL libraries will not work with Ionic currently ?
Or is there any existing limited support for it ?

We do not have documentation or samples for MSAL with Ionic, nor do we do any testing or have considerations for Ionic in the library, and are unlikely to prioritize Ionic specific features or fixes.

@jasonnutter
As we didn't see cacheStorage option, we tried updating the cache : cacheLocation value to both the applicable values on that configuration i.e. sessionStorage & localStorage
cache: {
        cacheLocation: "sessionStorage",
        storeAuthStateInCookie: false,
        secureCookies: false
    },

But had no luck, The accounts array from useMsal still returns empty Array
What we can see in Native devices is;
The storage has some values related to Ad B2C before being migrated to Custom policy:

But after we migrate back to the App after successfully Logging In the values in storage gets removed

@dipankarmedhi91 There are temporary values in sessionStorage that are set by MSAL when the request starts and are deleted when the rquest is completed. From the screenshot, what you see in sessionStorage are those temporary values, so those being deleted in expected. Have you tried localStorage as the cacheLocation?

yes we did try out localStorage, it had the same Issues
I think cacheLocation only supports those 2 values

There is one more observation, the token url (oauth2/v2.0/token) is not getting called from the simulator,
IOS Simulator:

Web:

The response from the token gets stored in LocalStorage
& the keys available in LocalStorage are getting used to collect more information like User and Account Details.
Are there any OS specific checks over this token call? or Client has to call it explicitly to have more information over MSAL Instance.

@jasonnutter I tried one more approach to verify if the data missing in localStorage is the reason behind this issue. I tried explicitly feeding the LocalStorage data picked from web chrome browser and with this Im able to get the account info and token API also getting called.
It's not working perfectly but the logic which requires data in localStorage is working correctly with this.

@dipankarmedhi91

Are there any OS specific checks over this token call? or Client has to call it explicitly to have more information over MSAL Instance.

No, there are no OS specific checks. After MSAL receives an auth code, it will be immediately traded for tokens. Did you try debugging MSAL to see what is happening?

The main question I am interested in currently is what happens when MSAL writes data to localStorage in Ionic? Does the data persist, or is it erased? This will likely require debugging MSAL itself.

This has been solved offline, issue was a mismatch in the origin that initialized the request and the redirect uri.


Add command to run file using %run magic

It would be really useful if there was a command to run the current file in the interactive window using the %run IPython magic. The new command (e.g. jupyter.runFileMagic) would just have to execute %run path/to/current/script.py in the interactive window. This would then make it possible to edit a file and run it immediately in the interactive window with the use of a keyboard shortcut like you can already with running the current file in the terminal.
https://ipython.readthedocs.io/en/stable/interactive/magics.html#magic-run
I currently use jupyter.runFileInteractive from a keyboard shortcut to approximate this behaviour (which effectively copies the current file contents to the interactive window), however the %run magic provides a number of advantages:
Expected behaviour of sys.argv
If a script is run with jupyter.runFileInteractive, sys.argv returns a series of values (presumably) from the Jupyter server which at best are unwanted and at worst can break code which uses sys.argv to take command line arguments. The %run magic, on the other hand, behaves as if the file was executed in a normal terminal, returning the correct filename and no additional values from the Jupyter server.
(Additionally, the %run magic can be used to pass custom arguments to sys.argv, though this wouldn't be affected by creating some new jupyter.runFileMagic command.)
Files can be re-run using command history
Once a file has been run once, it is sometimes useful to re-run it by scrolling through command history using the up/down keys in the interactive window input box. The use of the %run magic allows this to work properly, unlike jupyter.runFileInteractive which doesn't appear in the command history and wouldn't reflect any changes in the file.
Clearer command history in interactive window
Multi-line commands in the interactive window are collapsed so that only the first line is visible, meaning that most files run using jupyter.runFileInteractive all appear the same (as they all have the first line #!/usr/bin/env python3). Therefore, if I want to see which file was run for each cell, I have to expand the command and look at the code directly which is a bit awkward. If you could easily use the %run magic instead, the command would be a single line and therefore it would be possible to see which file was run for each cell with no user interaction.
Thanks very much!

Thanks for the suggestion.

this seems to work now, perhaps implemented at some point in IPython/ipykernel
verification:

create a file "test.py" with contents

from sys import argv

script, first, second, third = argv

print("the script is called:", (script))
print("your first variable is:", (first))
print("your second variable is:", (second))
print("your third variable is:", (third))

create an interactive window and run %run test.py first second third from the input box


Add option to include pid in coverage filename.

This is an attempt to address the usage of Istanbul in a multi-process environment.  Rather than addressing the specifics of a particular multi-process technique, a tool is added that could be of use to different methods: a --include-pid option is added to append the process id to coverage filenames.  This has worked out well for use with the node cluster module.  Generating your own directory names for use with --dir won't work with the cluster module since you can't adjust parameters per child.
This patch may help address a number of current and old issues: #97, #115, #147, #199, and maybe others.
Test case code is not yet written but thought I'd put this patch out for feedback now.
From the commit:

Add an option to append the process id to the coverage filename.
Including a PID in filenames can be used to make it easier to perform
coverage testing of multiple process applications. If invoked
properly, each process will create a unique coverage file which can
then be merged during reporting.
Add example in the README of how to use this support with the cluster
module.

Hi @davidlehn - do you still need this? If so, could you add a test?

Coverage remained the same at 97.57% when pulling e5eefb83f76f06d0934c8124497ea15aef6caa2c on digitalbazaar:include-pid into bc1cbdeeacf83343955b8bf473dbd7b60cdcde10 on gotwarlost:master.

Coverage remained the same at 97.58% when pulling 7768bc90cf61db147aaeb4b8513f6d64cffe4251 on digitalbazaar:include-pid into 7e2f37257a4cfdb5e75cbf6e0e19135637aef77c on gotwarlost:master.

@gotwarlost I updated to the latest master and added some tests.  I'm not sure how to best test this sort of feature but got the basics of testing that --include-pid, --no-include-pid, and the default of --no-include-pid all work.  It does similar testing to what is done elsewhere just using a coverage file with a pid in the name.  Comments welcome.

Looks fine. +1


Integration Bones and UI

This fixes small UI issues I caught, has a merge I had to do where I didn't change anything, and adds very bare bones for integration testing suites.

Coverage remained the same at 35.411% when pulling fe22d5c75dec115c9ac662e8c45b7cc478846557 on TheKLARKEN:uitest into f4943376c9ec661e317f691bc07cc0c2e2b5615a on supergiant:master.

# github.com/supergiant/supergiant/test test/dummy_integration_test.go:8:2: cannot find package "github.com/stretchr/testify/suite" in any of: 	/home/travis/gopath/src/github.com/supergiant/supergiant/vendor/github.com/stretchr/testify/suite (vendor tree) 	/home/travis/.gimme/versions/go1.10.linux.amd64/src/github.com/stretchr/testify/suite (from $GOROOT) 	/home/travis/gopath/src/github.com/stretchr/testify/suite (from $GOPATH) FAIL	github.com/supergiant/supergiant/test [setup failed]


After acknowledging error, it changes back to error

Acknowledge from the screen, then when auto refresh updates it, it turns into error again. Refreshing fixes it.

Same for viewing detail. May need to reload partials when doing anything.


Using batched vmap for RAM-limited option

Thanks for this great package. I am running into some roadbumps using this for larger datasets, where the [transmits, channels, points] size doesn't fit into GPU RAM.
The Reduce.Sum option is great, although I seem to also get slow compilations, perhaps due to the for-loop/functools.reduce implementation triggering XLA to try to do lots of smart compilation (https://stackoverflow.com/a/76638350/8094659)
I just saw that JAX added a batched-vmap that could allow more flexibility here.

Hi again, Charles! Thanks for another good question :)
Reduce.Sum is supposed to use jax.lax.scan under the hood, which is supposed to compile much faster than functools.reduce. You should use vbeam.util.transformations.Reduce instead of spekk.transformations.reduce.Reduce directly (I see how this could be easily missed as it is not well documented) which uses the scan implementation. The vbeam version overrides the default reduce_impl.
Hope this helps!
BTW, could you tell me more about what you mean by batched-vmap? Is it a new feature added to JAX?

oops, thank you so much! I think my IDE ended up linking me to the spekk ForAll implementations, and I got tunnel-vision and didn't notice vbeam was using its own. I see now that you also documented this in https://github.com/magnusdk/vbeam/blob/main/docs/blog/performance.md. That helps a lot.
On the topic of the batched-vmap: a batched-vmap (or a jax.lax.map version of ForAll) could be really nice when beamforming large 3D, multi-transmit grids that don't fit easily into GPU RAM (a bit of a niche use-case).
This seems possible through jax.lax.map. which now includes a vectorized-batch_size that uses vmap under the hood:

jax Issue tracking this request: https://github.com/jax-ml/jax/issues/11319
jax PR that implemented in: https://github.com/google/jax/pull/19614
https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.map.html describes it using vmap under the hood for batching

I tried integrating this with vbeam.ForAll myself, plugging jax.lax.map into the vmap_impl argument, following the example of:
https://github.com/magnusdk/spekk/blob/1d61dc1506bd2bf4fb2ffe52cc22575db91e5f44/spekk/transformations/for_all.py#L115-L143
but jax.lax.map has a more restrictive API than vmap, and I wasn't familiar enough with JAX trees to get the tree-shaping working.

@magnusdk was just using vbeam again with some large data. Is there a jax.lax.map (i.e. iterative) version of ForAll? I couldn't quite figure out how to get it working


metadata is not being sent

I've tried all the possible variation of metadata (grpc metadata, row json), tried with callback, without callback (await), but it's seems like it's not sending any metadata.
On the official gRPC caller there is no any problem and I can see the metadata on the grpc server, so it's definitely problem of grpc-caller.
I tried to debug it but I got blocked at some point (out of my understanding and I have no time to dig deep - sorry).
Is there any known issue about that which I missed?

Hello can you provide some source code please? There are lots of examples in the tests such as this for unary or for request stream or response stream call.

Sorry:
const PROTO_PATH = path.resolve(__dirname, './users.proto');
const client = caller('<IP_ADDRESS>:50051', PROTO_PATH, 'Users');
try {
    const res = await client.forgotPassword({ email<EMAIL_ADDRESS>}, { ip_address: '<IP_ADDRESS>' });
    console.log('RESPONSE: ', res);
  } catch (error) {
    console.log('ERROR: ', error);
  }

I think that should work as evident by the tests. Please provide a reproducible example and some more details including the protocol buffer definition, server code, nodejs, and grpc library versions.

There you go:
test.proto:
syntax = "proto3";

package helloworld;

// The greeting service definition.
service Greeter {
  // Sends a greeting
  rpc SayHello (HelloRequest) returns (HelloReply) {}
}

// The request message containing the user's name.
message HelloRequest {
  string name = 1;
}

// The response message containing the greetings
message HelloReply {
  string message = 1;
}

server.js:
const PROTO_PATH = `${__dirname}/test.proto`;

const grpc = require('grpc');

const helloProto = grpc.load(PROTO_PATH).helloworld;

/**
 * Implements the SayHello RPC method.
 */
function sayHello(call, callback) {
  console.log(call.request, call.metadata.getMap());
  callback(null, { message: `Hello ${call.request.name}` });
}

/**
 * Starts an RPC server that receives requests for the Greeter service at the
 * sample server port
 */
function main() {
  const server = new grpc.Server();
  server.addService(helloProto.Greeter.service, { sayHello });
  server.bind('<IP_ADDRESS>:50051', grpc.ServerCredentials.createInsecure());
  server.start();
}

main();

caller.js:
const PROTO_PATH = `${__dirname}/test.proto`;

const grpc = require('grpc');

const helloProto = grpc.load(PROTO_PATH).helloworld;

function main() {
  const client = new helloProto.Greeter(
    'localhost:50051',
    grpc.credentials.createInsecure(),
  );

  const meta = new grpc.Metadata();
  meta.add('ip_address', '<IP_ADDRESS>');

  client.sayHello({ name: 'world' }, meta, (err, response) => {
    console.log('Greeting:', response.message);
  });
}

main();

grpcCaller.js:
const PROTO_PATH = `${__dirname}/test.proto`;

const grpc = require('grpc');
const caller = require('grpc-caller');

function main() {
  const client = caller('<IP_ADDRESS>:50051', PROTO_PATH, 'Greeter');
  const meta = new grpc.Metadata();
  meta.add('ip_address', '<IP_ADDRESS>');

  client.sayHello({ name: 'world' }, meta, (err, response) => {
    console.log('Greeting:', response.message);
  });
}

main();

Hmm I am still not able to reproduce this with latest master using Node 8.9. Can you maybe try the req_res branch of PR #11 and see if the problem still persists. Note that now you have to explicitly add grpc dependency in your package.json. Thanks!

I can reproduce it also with the req_res branch.. What is the console logs that you are getting on your running server terminal?

client side:
~/dev/nodejs/grpc-caller-test node caller.js
Greeting: Hello world
~/dev/nodejs/grpc-caller-test

and on server:
~/dev/nodejs/grpc-caller-test node server.js
{ name: 'world' } { ip_address: '<IP_ADDRESS>',
  'user-agent': 'grpc-node/1.10.1 grpc-c/6.0.0-pre1 (osx; chttp2; glamorous)' }
^C
~/dev/nodejs/grpc-caller-test

Haha, sure it will work, you are trying to run the original grpc caller :) try to run grpcCaller.js, the caller.js was just there to demonstrate how it should be..

My apologies... I misread the code somehow heh. But still seems to works 😕
~/dev/nodejs/grpc-caller-test node grpcCaller.js
Greeting: Hello world
~/dev/nodejs/grpc-caller-test

and on the server side:
~/dev/nodejs/grpc-caller-test node server.js
{ name: 'world' } { ip_address: '<IP_ADDRESS>',
  'user-agent': 'grpc-node/1.10.1 grpc-c/6.0.0-pre1 (osx; chttp2; glamorous)' }
^C
~/dev/nodejs/grpc-caller-test


Improve error message for commands outside Kind/base

The error when running a command outside Kind/base directory isn't very clear:
Couldn't find Kind's repository. Please, clone it with:
   git clone https://github.com/uwu-tech/Kind"
And add your files to the Kind/base directory.

New error message:
Couldn't find Kind/base directory.

Go to the directory to run Kind commands or clone the repository:
  git clone https://github.com/uwu-tech/Kind
New files must be added inside Kind/base directory.

It would be nice if this message showed the kind version too. Sometimes we wanna know that and to do this for now we have to go to base dir.

@racs4 i just included the version


For remote hosts, remote src must be specified

Indeed! I published the fixed version as v1.0.1 to the galaxy. Thanks for the contribution!


Plugin-API: Cannot unregister to grist.onRecords

Using grist.onRecords, we can listen to record changes. But when we only do it once, it seems like it is not possible (unless using some dirty tricks). The same issue exists for functions onRecord, onOptions, onNewRecord.
Would it make sense to expose an event bus to grist, where we can listen to events "records", "record", "options" and "newRecord"? I suggest to continue allowing using the existing functions, they would just register the callback as an event listener.

That makes sense to me. These "on*" methods (like onRecord) are already implemented by subscribing to an EventEmitter (from grain-rpc) whose on method is exposed, but it emits less useful "message" events, and doesn't seem like a good interface to promote.
Do you have a preference for an event bus? The browser-standard EventTarget seems a decent option. Or we could use an EventEmitter interface (e.g. via https://www.npmjs.com/package/events, which already happens to be an indirect dependency). In either case, we could expose a grist.events object for this purpose, to use as grist.events.addEventListener or grist.events.on. Is that similar to what you were thinking?

Actually, that may have been an abuse of language, I was thinking of using the EventEmitter.
Otherwise, that's what I was starting doing:
https://github.com/incubateur-territoires/grist-core/commit/de074a7901984b2a9a98645b5b5583dbcb3b4f98
I will just rename the eventBus property name to events which seems more accurate.

A property events: EventEmitter sounds good to me.
For what exact events to emit, maybe it's a good time to make a list of what we should expose to custom widgets. It's not great that onRecord and onRecords are named similarly, but one means that the selected row (or cursor) was changed, while the other means that rows were modified. Maybe we can do better for new events.
Cc'ing @berhalak who has also had wishes recently for custom widget API.

You're probably right about renaming the events.
What about:

onRecords → on("tableRecordsChange", func);
onRecord → on("recordChange", func)

And maybe introduce some different event ("selectionChange"  or "selectedRowChange") for the case when the cursor moved to a different row?

Hi @fflorent,
I'm a little bit hesitant about renaming those events. The current widget API is designed for the Card View widget type, where a custom widget is used to show some details of the selected record. Hence the names onRecord and onRecords (but implicitly they end with a suffix "changed").
The current API doesn't yet have a concept of a cursor - as it wasn't designed for the Grid like widgets. Of course, the onRecord event is also fired when the cursor is changed because the id for the selected record has changed, so we use it for detecting this event, but conceptually this is a different event type. So I'm thinking that reusing existing names record and records is not that bad idea.
I'm currently working on improving the linking API for the custom widgets, which will require introducing some proper cursor events (send in both directions) into the API. This should improve the developer experience for Grid like widgets.
I like the idea of the event bus events: EventEmitter that you proposed, I think this will work very nicely and it is easier to understand. I'm curious: why do you need this feature in the first place  - to unregister from the onRecord event?
Regarding your issue, I think that you have a bug in the matchOnRecord function, it looks like you copied the newRecord event implementation.
  // TODO: currently this will be called even if the content of a different row changes.
  async function matchOnRecord(msg: any): Promise<boolean> {
    if (msg.tableId && msg.rowId === 'new') {


feat: adds an upload artifacts command to konvoy image builder

What problem does this PR solve?:
Creates an upload artifacts command to upload artifacts to hosts specified in an inventory file.
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-83933
Special notes for your reviewer:

I ran the command like so:
$ bin/konvoy-image-wrapper upload artifacts --inventory-file=ansible-inventory.yaml --container-images-dir=./artifacts/image-bundles/ --os-packages-bundle=./artifacts/os-packages_1.21.6_x86_64_rpms.tar.gz --pip-packages-bundle=./artifacts/pip-packages.tar.gz

I used previous existing terraform scripts to bring up centos7 hosts.
Does this PR introduce a user-facing change?:

feat: adds a upload artifacts command for hosts that will be used in offline mode.

Please add related target in Makefile. I think the e2e.*.offline targets will change to support this.

for next iteration: Should we think about combining all artifacts into a single versioned tar if we need to provide all three type of artifacts (rpms, pip packages, images) all the time? This could prevent version mismatching between rpms and images artifacts. also it would be easier for users to manage/download one single tar file. Then this command could become simple where it could upload/sync sort of anything to each host in the inventory.


[Backport conflict] Add a change that will conflict

Description
Backport of #371 to conflict.

Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin conflict
git worktree add -d .worktree/backport-371-to-conflict origin/conflict
cd .worktree/backport-371-to-conflict
git switch backport-371-to-conflict
git reset --hard HEAD^
git cherry-pick -x<PHONE_NUMBER>d7e3df2d432d600a3375fef09332d0
git push --force-with-lease


nixos/wiki-js: Add git and openssh to the wiki-js service path to enable git backups.

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

PR to fix #206964, @Ma27 since you have the context.
Take your time on the review and enjoy the holidays.

Checking on this to see if anyone is reviewing this, or wants to.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1714


Add check that decay factors, channels same len

Fixes #150.

Pull Request Test Coverage Report for Build 197

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 92.125%

Totals

Change from base Build 188:
0.04%

Covered Lines:
1474

Relevant Lines:
1600

💛  - Coveralls


New SVG for DashboardModule

Hi Tolis,
can u use new SVG images for the Dashoard Module to get a fresher look?
Attached samples.
Dashboard.zip

sure, can you detail me what is you want me to do not to miss something?

Hi,
in the project are .png. Maybe you could replace them with the new .svg.

Hi,
and is there a time planing to compile against 22.2.6? Cause there is a problem correction in devexpress that I need.

eXpand.lab release 22.2.600.0 includes commit that relate to this task:

Replace images #993

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.
To minimize version conflicts we recommend that you switch to PackageReference format and use only the eXpandAgnostic, eXpandWin, eXpandWeb packages. Doing so, all packages will be at your disposal and .NET will add a dependecy only to those packages that you actually use and not to all (see the Modules installation-registrations youtube video).
Thanks a lot for your contribution.

Hi Tolis,
I tested it. Now the Dashboard group and the Dashboards itself has no Image.

I saved the images as embedded resources in my project and it works.....

eXpand.lab release 22.2.601.1 includes commit that relate to this task:

Dashboard images are not embedded #993

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.
To minimize version conflicts we recommend that you switch to PackageReference format and use only the eXpandAgnostic, eXpandWin, eXpandWeb packages. Doing so, all packages will be at your disposal and .NET will add a dependecy only to those packages that you actually use and not to all (see the Modules installation-registrations youtube video).
Thanks a lot for your contribution.


Stop the measurement by press 'Enter' will raise an Error for the measurement

Bug Report
For a measurement that the execution is long, if Press 'Enter' in the command line before the "Stop" button turns to "Start" in the InstrumentStudio, there wold be an Error: _ERROR: Exception iterating responses: Cannot invoke RPC on closed channel!
Repro or Code Sample

Adding a time.sleep() based on the example code to let I can have time to hit the "Enter"
Run the measurement
Click "Start" button and Press "Enter" before the "Start" button turns to "Stop"
Re-run the measurement, there will be another error said that the session has been reserved which seems it has not been destroyed last time
Only restart the computer or use Task Manager to terminate the MeasurementLink discovery service can make the measurement run.

Expected Behavior
After Step3: The Button should be "Stop" and the measurement is aborted correctly.
After Step4: The measurement should be run.
Current Behavior
After Step3:

After Step4:

Context
For a long time execution measurement, it happens likely and will impact the user experience.
Your Environment

OS & Device: Windows
ni-measurementlink-service version 1.1.0
MeasurementLink version 2023Q4
Python version 3.8 or 3.9

AB#2566629

I think the cause is that we're closing the gRPC channels in the channel pool before canceling any ongoing server RPCs.
We're calling grpc.Server.stop() with a grace period of 5 seconds before we close the gRPC channel pool. However, stop() returns immediately and the server shutdown continues in another thread. Also, stop() doesn't cancel the RPCs until the grace period expires, so the grace period does't have any benefit for us. stop() returns an event object that we can wait for, but we aren't waiting for it.

Low ROI


enter key adds a paragraph and a new line instead of only a new paragraph on IE11

Jodit Version:  3.3.22
Browser::  Internet Explorer 11
OS:  Windows
The bug is replicable inside the Jodit Playground.

If i insert a new line on top, it works fine for the first one. But if I insert another one...

In the new line there is a BR tag that should not be here. This causes some problems if i complicate things with something else

This works fine. Thank you.


instruct to be installed as devDependencies

ESLint & eslint-plugin-* should be in devDeps, right? 😆

You're right.
Thanks!


[lovelace] picture elements, elements positions differ if card title is entered

The positions were so far only relative to the image (0% was the top of the image), but now, they relate to the complete card (0% is now the top of the card), including the title if specified.
Therefore, if a title is entered, the top alignment is affected (shifted to the top of the image). The initial behavior seems more natural
I am using Home Assistant 0.84.2

Duplicate of https://github.com/home-assistant/home-assistant-polymer/issues/2307


Ask GOV.UK DG and GCS for comms lines for announcing and explaining the change

What
Find out how we should explain the change or if any reason need be given.
Why
We expect that people are likely to ask and therefore need a line from the decision-makers.
Who needs to work on this
Steve
Who needs to review this
Chris, Ollie, Calvin
Done when

[ ] Received lines or notice we don't need lines from decision-makers

There's a meeting with GCS happening on 29 August. I have suggested that deputy directors from GOV.UK should attend. We can take the lead from them.

I've chased to see whether there's any output from the meeting for us. If not, I'll set up a talk with GCS.

Pointed to Policy & Strategy in GOV.UK, waiting to hear back.

Waiting for a comms & rollout plan from GOV.UK.

Chased, still waiting.

GOV.UK setting up a meeting for us with delivery and comms people on their side. This is a blocker to releasing the crown changes, we need to align on release plans with them before putting it out.

Meeting has yet to be arranged. I will try chasing again next week.

Nothing yet.

Still received nothing and no notice. Assuming we don't need to or cannot say anything. Won't do.


Prototype azure-storage-queue using azure-xml

Description
Prototype of azure-storage-queue using azure-xml for handling XML serialization instead of Jackson Dataformat XML.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - storage - tests

/azp run java - storage - tests


There is no property 'SKU Tier' for one Classic storage account

Storage Explorer Version: 1.25.0-dev
Build Number: 20220701.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Monterey 12.4 (Apple M1 Pro)
How Found: From running test case
Regression From: Previous release (1.24.3)
Steps to Reproduce

Select one Classic storage account ->Observe its properties.
Check there is a property 'SKU Tier'.

Expected Experience
There is a property 'SKU Tier'.

Actual Experience
There is no property 'SKU Tier'.

Additional Context
For one Classic Premium storage account, extra nodes 'File Shares/Queues/Tables' display.

Verified this issue on the build main 20220704.1. Fixed.


Print uname -a as part of startup

This would better fit into prometheus/common, but it seems every part of prometheus does this on its own.
To prevent questions about OS, architecture, etc, it would be nice if the output of uname -a, or the relevant subset, could just be printed along with build info during startup.

Looks like this could be addded to either prometheus/cmd/prometheus/main.go or to common/version/info.go.
But the question of what to put is kinda tricky. Not all OSes are compatible with uname -a (especially Windows).
Also, I'm new to Golang (not to mention Open Source contrib in general), and I'd like to contribute to Prometheus.


set energy cost

Hi!
The module is amazing :) i see it is being used by HomeAssistant.
I would like to create an automation to dinamically set the charging price based on an input from another module (pvpc from spain).
To do that this module needs to expose a way to set it :)
Do you mind if I contribute to this module with this feature?
Thanks

All contributions greatly appreciated @angelbarrera92, thanks!
I'll review this asap.

This is merged, grand job @angelbarrera92


Update DESCRIPTION

Description

Related Issue

Example

@ermali7 sorry that we cannot downgrade the R dependency from v3.6 to v3.5 because it is required by Bioconductor. You can do it with your forked branch but not this one in order to install the package under R v3.5 on your computer. But here we need to keep it at R 3.6 :-)

Thank you very much! Now I get to understand in more thank you very much.
Please allow me to ask again if I would have any question!
Have a nice day!
Ermal
On Wed, Apr 24, 2019 at 4:33 PM Vinh Tran<EMAIL_ADDRESS>wrote:

Closed #98 https://github.com/BIONF/PhyloProfile/pull/98.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BIONF/PhyloProfile/pull/98#event-2296262349, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AL455Y4YTKOVDJRAGKOEDHLPSAEKXANCNFSM4HH724TA
.

Hi @ermali7
yes, of cause. You are welcome to ask questions ;-)
Best,
Vinh


Edits to Extremes Report so that the report removes duplicate max/mins

If they are the same value. Keeps only the first record regardless of time.
https://internal.cida.usgs.gov/jira/browse/AQCU-605
@lindsaycarr can you check this out? Original and new examples attached to the JIRA ticket.
I did a hacky fix on the column names because in the example I was working with at least, the column names need to be used in the !duplicated function, and in the example (see the attached json) two of the column names are the same and it hates that. So, I change the names temporarily, do the !duplicated call and then change them back to the originals..

If those data columns are literally the exact same name, why are they both on there...

I think it isn't always the case but I can't say. It's coming from two different variables in the json though, perhaps they just happen to be the same in this scenario?

I keep thinking about this (the labels being the same). Here's a screenshot of the metadata of the data example I'm working with, @thongsav-usgs can you verify that in the java-json conversion our labels aren't getting mixed up somewhere?

:shipit:

What's the exact desired behavior? The issue is the parameter might be the exact same for primary and upchain time series, but they still come from different sources time series. I don't know what the goal of the request is, remove a duplicate label seeks wrong if the two time series are different and the actual request should be to make the labels more meaningful.

Wait, are we talking about duplicate row entries?

From the JIRA ticket, "The report currently provides all inst min & max values in a given day no matter how many times the min or max occurs. It would be fine just to list the FIRST inst max/min in a day if multiple exist. This produces a much cleaner output."
The desired behavior is to remove redundant row entries from the same date, just to keep the first instance. E.g. here is the original with redundant rows for 2/1/2015 and -0.1 / -0.1

Sigh...  I'd get the PO/RCs to triple think that request, they explicitly asked for this behavior (it used to only display 1 instance). It was a pretty explicit request since it was 3 points to refactor the data layer to provide all instances of the mins/maxes. I even remember bumping out other high priority tasks for this.

Hm Ok. I already tagged Laura to review it so hopefully she'll see that. The ticket was just made Feb 11th...


Sums only for actually displayed cards

Thank you for the Sum Power-up!
One improvement would be to calculate the sums only for the cards that are actually displayed in a list. Currently, the sums are always calculated for all cards in a list, regardless of whether they are filtered or not.

Hi Torsten,
Thanks for getting in touch. I do definitely agree that this change would make the power-up more intuitive. However, I'm having a hard time finding any method of implementing this filter within the power-up.
As you can see in this model below, there isn't any data that can be used to determine if the card is currently visible on the board. I've trying to find out if it's actually possible in the Developer Community and will keep you up to date.

Unfortunately, after checking with the Atlassian dev community, this request isn't possible as the card filtering is handled locally in the browser.
https://community.developer.atlassian.com/t/accessing-current-filters-in-power-up/60068/3


dinghy shouldn't convert to lowercase the URLs

Commit a3d726f408c511d02f23372b8cf05d50eb34d819 broke URL loading when the URL contains uppercase letters.
When I try to open https://people.igalia.com/clopez/webBenchmarks/JetStream/JetStream-1.1/index.html with dinghy it tries to open https://people.igalia.com/clopez/webbenchmarks/jetstream/jetstream-1.1/index.html (everything lowercase), which fails with 404 as expected-

Indeed the problem was introduced in https://github.com/aperezdc/dinghy/commit/a3d726f408c511d02f23372b8cf05d50eb34d819 as you have found out. The string is lowercased to check for the http:// and https:// prefixes always in lowercase and the lowercase string should have been used only for that. I'll make a fix for this.


WIP: Entity generation support

Left TODO

[x] add code for jhipster-needle-add-entity-route
[x] replace pascal case by kebab case for entities URI
[x] check ionic version locally installed to enable entities for the correct ionic version or add a prompt for the user to choose between Ionic3 or Ionix4. What do you prefer @mraible?
[x] clean TODOs in code
[x] check formatting is correct (see https://github.com/oktadeveloper/generator-jhipster-ionic/issues/72) - will be done in a seperate PR
[ ] manage other types than string
[ ] manage relationships

What has been tested
Note: I used Jhipster v5.7.2 for my tests

[x] [Monolith] One entity with string type field
[ ] [Monolith] One entity with all types of fields
[ ] [Monolith] Two entity with relationship
[ ] [Microservices]

Screenshots
screenshots

Fix https://github.com/oktadeveloper/ionic-jhipster-starter/issues/22

@mraible I updated the description of this PR with the current state of my work.
Currently, my work has only been tested (and working) for string fields. I didn't check yet for other types but I will.
As from tomorrow, I will be in holidays for 1 week so I won't be able to work on this PR.
I know you have some times this week to work on it, so you can continue, otherwise I will do it when I come back :)

Enjoy your holidays @fleboulch! I really appreciate all the work you've done to this point. I'll do my best to build off your branch and complete the upgrade! ❤

Thanks @mraible and we would maybe meet in the JHipster Conf at Paris

Closing in favor of https://github.com/oktadeveloper/generator-jhipster-ionic/pull/73.