[feature]: create PriceOracle RFQ service

Parent issue: https://github.com/lightninglabs/taproot-assets/issues/683
The PriceOracle is a new RFQ subsystem service for retrieving the exchange rate between BTC and a counter currency. The service is queried by the RFQ Negotiator service.

The unknowns I'd like to solve are:

How do I get from an asset ID/asset group to some bid/ask on a site like blockchain.com
How do I handle niche assets where I can't find a bid/ask on the internet.

Do we need meta data in the asset to the effect of "price this asset as this fiat currency"?
Any ideas @Roasbeef @jharveyb @dstadulis ?

How do I get from an asset ID/asset group to some bid/ask on a site like blockchain.com

From the code's PoV, it's an abstract interface it can use to obtain price data. It isn't aware of where it's getting that data from, just that it can map a (asset, volume) pair into an acceptable price.
The actual implementation can source data from pretty much anywhere. We'll fashion a standardized JSON/gRPC interface similar to the feeurl setting we have. A daemon won't ever need to source prices of an asset that it doesn't hold itself.

How do I handle niche assets where I can't find a bid/ask on the internet.

I don't think this is a concern. See above.
The code can be written in an abstracted style, trusting that if a daemon has an asset, then it'll be able to obtain a relevant price for it. If not, then there'll be an error scenario where a user may need to manually update a config, or run a slim proxy to be able to obtain a quote.
More concretely, I think this would take the form of a PirceOracle gRPC service that tapd becomes a client of. We hit this endpoint whenever we need to obtain a price that isn't cache otherwise. This can also instead be configured as a normal REST endpoint returning JSON in w/e format.

Do we need meta data in the asset to the effect of "price this asset as this fiat currency"?

What would that look like in practice? I think, no? The logic of an oracle implementation itself can be very dynamic, and isn't really restricted by much. You can think of it just like fee estimation in a sense.


Support RPM/DEB installs

Support for using CPack to generate RPMs from CMake was added.
Needs better support for specifying dependencies for distros, at least Fedora should be cleanly supported here.
Also needs support for DEB installs, targeting Ubuntu.

Done. libcaer can now generate its own custom RPMs and DEBs for users usign CMake/CPack.
There also are repositories with binary packages for a variety of architectures for Fedora, Gentoo and Ubuntu. See https://inilabs.com/support/software/libcaer/#h.qp4tgs7gb5k for details.


fix(serviceAccount): return technical user in state pending deletion

Description
return technical users in state PENDING_DELETION
Why
To be able to display the technical users in state pending deletion
Issue
Refs: #989
Checklist

[x] I have followed the contributing guidelines
[x] I have performed IP checks for added or updated 3rd party libraries
[x] I have created and linked IP issues or requested their creation by a committer
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[x] I have added tests that prove my changes work
[x] I have checked that new and existing tests pass locally with my changes
[x] I have commented my code, particularly in hard-to-understand areas

Please don't merge this PR after approving, we need to clarify if this should go into the rc or into main

@ntruchsess @evegufy can be merged into rc5 clarified with @MaximilianHauer


Fix a11y warning on checkbox table header

JIRA: https://issues.redhat.com/browse/RHOAIENG-9675
Description

One-liner fix. Added aria-label to checkbox table header.
How Has This Been Tested?

Go to the pipelines table (or any table with checkboxes), and make sure there are no a11y warnings in the browser console.
Test Impact

N/A
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/approve


i talking about 5. double equals & triple equals section

hello.
thank you for this js-33-concepts repository.
i talk to you about that double equals & triple equals concepts section
the second link is wrong. this link click and web page load but http status 404 error message to show

Removed. Thanks for noticing it!


k8s job name special characters

Currently, if there is a special character (such as a ~) in the app version, the k8s job will blow up. This can be resolved by simply replacing tilde's with dashes both here and here. But, I'm not sure that's the best solution in the long term (for example, if you try to lookup this later w/ the modified name, will this break other things?). Anybody using Nebula will run into this issue. Hoping we can at least start up a discussion here to figure out what the best approach is to fixing this.
Here's the error you'll receive from the broken task if you have a tilde:
Exception: Create failed: The Job "verify-appname-dev-appname-0.1041.0~dev.2-h2210.f1zv5dj" is invalid: * metadata.generateName: Invalid value: "verify-appname-dev-appname-0.1041.0~dev.2-h2210.f1f1088": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*') * metadata.name: Invalid value: "verify-appname-dev-appname-0.1041.0~dev.2-h2210.f1zv5dj": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*') * metadata.labels: Invalid value: "appname-0.1041.0~dev.2-h2210.f1f1088": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?') * spec.template.labels: Invalid value: "verify-appname-dev-appname-0.1041.0~dev.2-h2210.f1zv5dj": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Thanks!

so for me to understand the problem, you have your artifact version as the following, right? 0.1041.0~dev.2
and then what would be the next version? something like 0.1041.0~dev.3?
You mentioned this is a constraint with Nebula. Can you help me understand how? Never worked with Nebula before, so any insight as to why there needs to be a ~ helps.
my first impression, I'd say artifact handlers should prevent resource versions from having any special characters in their names or version so we dont have to care about special characters them down the chain.
It is going to get complicated and error-prone if we try to whitelist special characters, so my gut feeling is that we should adhere to the same naming conventions enforced by k8s for labels and annotations also. example here: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
unless there are really strong arguments against it.

So, in this case, the appVersion is actually 0.1041.0~dev.2-h2210.f1zv5dj. Nebula versioning (more info here) will output 0.1041.0~dev.2, then the h2210 is the build number and f1zv5dj is the short sha.

my first impression, I'd say artifact handlers should prevent resource versions from having any special characters in their names or version so we dont have to care about special characters down the chain.

Unfortunately, I don't think your first impression is going to work, the way that keel works with debs is that it makes a whole bunch of assumptions about versioning. You can see Netflix already does a similar replace in the ImageService. Might be nice to see if @luispollo could chime in on this to get his opinion though.

It is going to get complicated and error-prone if we try to whitelist special characters

Agreed, unfortunately I'm not sure what the best resolution for this would be 🤔
Appreciate the conversation on this, thanks!


cuelist support standard UTF8 character

this code  Label = Regex.Replace(label, @"[^\u0000-\u00FF]", ""); would replace some utf8 character like chinese character[\u0080-\u07FF] , so I delete it and recalculate the length in internal byte[] GetRiffChunks()

WAV is a very old file format. Are you sure that if you write UTF encoded data into a cue list, other applications will be able to read it correctly? What have you tested with?

WAV is a very old file format. Are you sure that if you write UTF encoded data into a cue list, other applications will be able to read it correctly? What have you tested with?

I test it in adobe audition,and ues audition write marker and read it.this cuelist code use in my project. my project need read/ write/modify cue in wav file.
but now , I have to rewrite a new CueWaveFileReader/CueWaveFileWriter to solve this problem


Update p5.quadrille.js logo on the website

Dear p5.js team,
I am submitting this pull request to update the logo for p5.quadrille.js on the website. After the submission deadline, I discovered that some of the artists' paintings used in the original logo were not in the public domain. To address this, I have created a new logo that avoids these copyright issues.
This PR is related to the previous PR in the p5.js-libraries repository #65. Since the logo update needs to be reflected on the website, I am submitting this new PR here.
Closes #65.
Thank you for your understanding and for considering this update.
Best regards

Thanks for the update!


I want to nominate:
🔸 Vadim validator cyberG - https://twitter.com/vadyhodler777
🔸 Jack Zampolin - https://twitter.com/jack_zampolin
🔸 Daya from OmniFlix Network  - https://t.me/devfreakk
🔸 Sistla from OmniFlix Network -  https://twitter.com/svabhishek
🔸 Nikita from validator web34ever  - https://twitter.com/web34ever
🔸 Validator Highlander Nodes - https://twitter.com/HighlanderNodes
What are you nominating them for?
All of them was participating in The Validator Show #6 - Juno Network: Testing the Cosmos (second try)
They was participate 2 times in show, and two times they was telling a lot of useful and interesting information about Juno Network and validation, but I was making mistake, so the first time video wasn't record.
But this validators was finding time to participate in show 2nd time, to tell a lot of interesting about Juno Network!
They don't get nothing for participation in show, and for part of them it's not so easy to speak in English, but this is wasn't a border to them, to speak about Juno Network!
Their behavior shows that they are really interested in validation and Juno Network, and they show that they are ready to bring any kinds of value to the Network, not only security.
They always ready to help, and they actively participate in many different initiatives of the Cosmos Ecosystem projects, so they bring to Juno Network many social and cultural value, like an education, solidarity and social contacts.
I don't know how we can compare such kind of value with value from developers, but I sure, that such kind of value also very important, because they make connections between community members better, and the main for us, like a humans, and for the blockchain - is connection!
Please provide links to their work.
https://youtu.be/ggRdwiGduCY
https://twitter.com/synctems/status/1416543131340771329
https://t.me/JunoNetwork/15228

Really appreciate this. Ive spent a great deal of time working on juno and learning code. Its nice for that to be noticed.

Can I 2nd this motion all the above deserve nominating.. every who has been nominated deserves it’s.. congrats and hats off to everyone. Juno for life 🔥

Nominations menitioned elsewhere. closing


Automated cherry pick of #3933: fix: 抽离disable delete,避免删除账号失败

Cherry pick of #3933 on release/2.12.
#3933: fix: 抽离disable delete,避免删除账号失败

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@fb93c05). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #3935   +/-   ##
==============================================
  Coverage                ?   6.92%
==============================================
  Files                   ?     501
  Lines                   ?   84484
  Branches                ?       0
==============================================
  Hits                    ?    5848
  Misses                  ?   78141
  Partials                ?     495

Flag
Coverage Δ

#aFlag
6.92% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/elasticcache_instances.go
1.26% <ø> (ø)

pkg/compute/models/dbinstances.go
1.02% <ø> (ø)

pkg/compute/models/guests.go
0.59% <ø> (ø)

pkg/compute/models/purge.go
0% <0%> (ø)

pkg/compute/models/lockableresource.go
0% <0%> (ø)

pkg/cloudcommon/db/modelbase.go
1.6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb93c05...2b77cc0. Read the comment docs.

/lgtm

/approve


PowerQuerySdk.vsix - region collapsing

Please provide //#region //#endregion collapsing

yes, that would be nice for longer files

Hey!
There are no plans to release a new version of the Power Query SDK in Visual Studio, but we're working on a new Visual Studio Code extension that will be released later this year.
We'll be taking your feedback into consideration.
Thank you!


start lapis builder doesn't work

Steps

j.builders.web.lapis.build()
j.builders.web.lapis.install()
j.builders.web.lapis.start()

issue
start doesn't do anything , and doesn't star lapis

Not used anymore and not needed. (only openresty we care about)


Unable to compile on iOS

Getting this error when trying to compile for iOS.
Cannot invoke initializer for type '_UIViewControllerLifecycleEventView<Content>.UIViewControllerType' with no arguments
I believe it's because you're trying to initialise UIViewControllerType which extends UIHostingViewController so it needs to be initialised with one of the constructors from UIHostingViewController.

@FaizanDurrani this is weird - I can't reproduce this on Xcode 11.5 (GM). Could you try updating to the latest commit and check again?

@FaizanDurrani Can you give the path of where the error is occurring? I tried swift build -v, but like @vmanot, it's giving me normal results (Except for the ~96 warnings about Image(systemName:) on macos). The path to the error shows where the error occurred, whether it is because of SwiftUIX or something in your code (or both).


Warn if inheriting from non-slotted protocol in slots-required mode

(A bit of an obscure edge case, but worth documenting for future reference.)
The require-subclass mode warns of any classes which could be slotted, but are not.
class A(int):  # slots-required error triggered because A cloud be slotted, but isn't
    ...

class B(A):  # no slots-required error because B cannot be slotted (because one of its superclasses isn't)
    ...

However, protocols complicate things a bit:
class MyProto(Protocol):  # no slots-required error because protocols are not concrete classes
    ...

class C(MyProto):  # no slots-required error because one of its superclasses has no slots.
    ...

In the last case, we might want to emit a warning that C could be slotted if its protocol is. In the current situation, C is more-or-less silently allowed to not have slots.
Note that this problem is not present in ABC because they are meant to be inherited from and do trigger slots-required themselves.

This behavior is a result of #130


fix(server): ensure consistency for url to file mapping in importAnalysis and static middleware

Description
fixes #6516
includes slight update to fsPathFromId to avoid stripping FS_PREFIX if it isn't set
Additional context
there may be more at play here and deeper analysis/ more testing of the code in static middleware is warranted.
The way url, id and file system path are handled currently isn't transparent with hardcoded special treatment even outside of utils.
Maybe switching path to pathe could be an option to avoid some of the inconsistencies?
cc @antfu @patak-dev

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Looks like a good refactoring, but the windows fails look legit. So something is missing.
+1 to start using pathe, it seems to be working very well for Vitest

Didn't notice the failing windows test after the approval 😅 but yeah that should be taken of too

I managed to get my windows vm broken and won't restore it before getting a new workstation set up (finally more ram).
If someone wants to debug this in the meantime, go ahead. Otherwise it'll be a few days before i can

debug output of pnpm dev in packages/playground/css
  vite:resolve 0.76ms /linked.css?direct -> c:/Users/IEUser/dev/vite/packages/playground/css/linked.css?direct +0ms
The request url "c:\Users\IEUser\dev\vite\packages\playground\css\linked.css" is outside of Vite serving allow list.

- /c:/Users/IEUser/dev/vite
- /C:/Users/IEUser/dev/vite/packages/vite/dist/client

Refer to docs https://vitejs.dev/config/#server-fs-allow for configurations and more details.

  vite:time 8.80ms /linked.css +0ms

note the extra leading slash in front of the logged allowed directories. this is added here: https://github.com/vitejs/vite/blob/a0126441a556b4991ac14cf037820194ab9e17b9/packages/vite/src/node/server/index.ts#L696
i'm not entirely sure why because path.resolve should always return an absolute path.
another oddity i noticed is that the drive letter c is lowercase in the first but uppercase in the second entry. Is windows fs still case insensitive and to we have to make an insensitive comparison in that case?
I'm this close to not ever going to touch anything windows again ><

@bluwy notified me that normalizePath is public api so this would be a breaking change. i'll try to refactor it, gotta come up with a better idea first tho


Stuck on Title screen when opening app

When using the app (at https://stackedit.io/app) the page shows the Stackedit logo and will not continue to the application. I am using Firefox on osx, and have tried deleting cookies and local storage and it did not help.
This does not happen in Safari.
Looking at the Console in Firefox, there is an error:
Error: Can't connect to IndexedDB.
localDbSvc.js:33:12
Has anyone else experienced this?

Yeah, other people have experienced this, and not just on Mac. Both Linux and Windows too:
https://community.stackedit.io/t/cant-run-stackedit-5-in-ff-58-02-linux/43
Why did you close this? How did you resolve it?

The issue fixed itself. I believe I marked it closed the same day it was
fixed, maybe a day or two afterwards.
On Tue, Mar 20, 2018, 6:50 AM jkyeung<EMAIL_ADDRESS>wrote:

Yeah, other people have experienced this, and not just on Mac. Both Linux
and Windows too:
https://community.stackedit.io/t/cant-run-stackedit-5-in-ff-58-02-linux/43
Why did you close this? How did you resolve it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/benweet/stackedit/issues/1254#issuecomment-374604566,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIkxfWjiI7-ps_-CPFJng1-rcLd-TE6xks5tgQk8gaJpZM4SfDPZ
.


Allow choice of AD backend for conditions

Fixes #69
At the moment this works with default/adaptive backend and with ForwardDiffBackend() but not with ZygoteBackend(). I suspect this might be a bug in AbstractDifferentiation.jl (maybe AD#63). @mohamed82008 could you take a look? I skipped the problematic tests in test/systematic.jl and marked them with TODO.
@thorek1 wanna take this branch out for a spin and see if it solves your problem?
This PR also changes the constructor syntax in a breaking way: f and c are positional arguments, along with HandleByproduct(), but linear_solver becomes a kwarg along with the new conditions_backend

Closing because this is completely outdated due to #86


feat: add ERA5Land dataset

Hello, this PR aims at adding ERA5Land dataset, available at https://cds.climate.copernicus.eu/cdsapp#!/dataset/reanalysis-era5-land?tab=overview, using https://pypi.org/project/cdsapi/ and API key.
UPDATE: I add in the release the following file test_data_ERA5_2018.nc which is a subset of the bigger ERA5 dataset. Now tests are way more faster, thanks @dataJSA !

On my local computer, all tests passed, here I get "Error: Process completed with exit code 137.", probably due to exceeding RAM ?

I didn't complete the testing because my computer crashed but I had an issue with the /pyro_risks/datasets/init.py file because there was a missing line :
from .ERA5 import *

Is the loading test which takes too much time?

I didn't complete the testing because my computer crashed but I had an issue with the /pyro_risks/datasets/__init__.py file because there was a missing line :
from .ERA5 import *

That's weird. It doesn't cause any troubles on my local computer.

Is the loading test which takes too much time?

This tests takes around 15min:
def test_era5land(self):
    ds = ERA5.ERA5Land()
    self.assertIsInstance(ds, pd.DataFrame)

@chloeskt
The quick fix for speeding up the test would be to

download a subset of the ERA5Land datasets (~1 month) and attached it to the release a new release
use the new URL as patch for source_path = cfg.FR_ERA5LAND_FALLBACK in the test so that the source_path of the class  points to the smallest file.

Yes, I do agree too with the idea of loading a smaller dataset for the unit tests, 30 minutes waiting for the tests to pass it's a bit too much

Alright, I agree with you! Going to do that @dataJSA 👍

@chloeskt nice, there is just 3 docstrings issues flag left, you can see them if you go on the Codacy details and click on resolve). Don't bother with the fourth one (setup.py) the issue seems to be related to a bug in the quality assessment package use by Codacy (https://github.com/PyCQA/bandit/issues/333)

Done @dataJSA

@dataJSA for the 3rd issue, @GHCamille had a problem without this line therefore I added it even if it does not seem to be useful

@dataJSA I'm not sure to understand what's the problem in the ERA5.py script with the blank line, whatever I try it seems not to work, however it seems to follow the guidelines given here https://www.python.org/dev/peps/pep-0257/
Do you have an idea ?

Btw @dataJSA  now the tests failed, due to this:

Since you implemented the corresponding function and I did not modifiy the files, do you know why ?

@dataJSA I'm not sure to understand what's the problem in the ERA5.py script with the blank line, whatever I try it seems not to work, however it seems to follow the guidelines given here https://www.python.org/dev/peps/pep-0257/
Do you have an idea ?

@dataJSA for the '.ERA5.*' imported but unused (F401) issue, @GHCamille had a problem without this line therefore I added it. UPDATE: this is used, cf example_ERA5_FIRMS.py. I think that Codacy had its limits 😅

@chloeskt It also happened to me I couldn't fix an issue (D213) last time. You totally right at least we need to look how to configure Codacy a bit better or get ride of it.

Moreover I don't like to use * when doing imports, it imports everything and can get things messed up. Should we rather remove the * and import functions and classes explicitly ? I believe that it will solve this issue 😄

import * is view as a bad practice since the by default python import all the objects in the module.
However it is fine to do so if you configure the list of objects that will be exported from the module  __all__  variable.
For instance with setting __all__ = ["ERA5Land"]  in ERA5.py the from .ERA5 import * in the init file will only import the ERA5 class

Thank you @dataJSA for all these information !


Change CNI post-provisioning a cluster

Is your feature request related to a problem? Please describe.

Currently it's not possible to switch to different CNI )e.g. Cilium) on an up-and-running k3s cluster that already uses the default CNI (Flannel).
Describe the solution you'd like

An option to make k3s use a different CNI that I've installed on the cluster after I have already created and provisioned a cluster.
Describe alternatives you've considered

No alternatives available as far as I know
Additional context

We do not plan to add support for changing CNI on a cluster after it's been started. Like picking cluster CIDRs and other core networking choices, CNI should be decided upon before the cluster is created. While you might be able to hack at it and get it to work, it's not something we will support. Certainly it will not work without at least restarting k3s to disable flannel.

@brandond  I understand. I’m willing to hack on it, any chance you can at least help me with directions? Anything else that needs to happen/change in addition to restarting k3s to disable flannel?
Also, from what I understand this is considered a Top Issue on the ref page (https://www.suse.com/support/kb/doc/?id=000020904). How come a Top Issue isn’t in the roadmap?

Anything else that needs to happen/change in addition to restarting k3s to disable flannel?

That's all that's necessary for K3s, although you might also want to disable the network policy controller as well. I would defer to your CNI's installation instructions for additional steps after that.

How come a Top Issue isn’t in the roadmap?

I don't know what "top issue" means, other than perhaps our support org wanted to highlight it? We've evaluated this in the past for all of our supported Kubernetes distributions, and determined that it is not something we want to tackle.


qs: indicate duplicate strings

for example:
string 1
string 2
string 3
string 1  << duplicate
string 4

this way unique strings can quickly be identified but no data is hidden by default

would you tag this like #duplicate and/or mute or are you thinking something else?

Initially I thought of tagging. Muting (in addition) could work well but I think we need the tag (or some other indicator) to make clear what's going on.

@mr-tz Made a PR for #duplicate + mute with a sample output.
Other possible ways to try -

Having a new STYLE
<< duplicate{Count}
Grouping them together


Feat: Scrap coinmarketcap

Describe the feature
Scrap cryptocurrency information
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

Go ahead @Juhibhojani |


Fix width in internal text-field. Fixes #76

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Discussion: how to keep message catalogues in sync?

Between DSpace 7.5 and 8.0 we changed some entries in the english message catalogues that use variables. Unfortunately we did not changed these entries in the german message catalogue and probably also not in other languages. One prominent examples are the entries browse.title and "browse.title.page". When you open a browse index in DSpace 8 {{ collection }} shows up in the header of that page. It was removed in the english message catalogue as it is not set by the code anymore.
While we do have a script to show differences between language catalogues, there normally are a ton of changes between major versions. It is a lot of work to keep a message catalogue in total sync with the english message catalogue that is changed by many different developers regularly.
We should discuss:

Can we differentiate between important changes to the message catalogue and less important changes? Can we track important changes?
How can we ensure that as part of our release procedure we at least try to update message catalogues? Do we need to plan in time for that?
Shall we build up a mailing list of people willing to help out? Should we look out for people/institutions to "adopt" message catalogues?

At The Library Code we tried to automatically translate message catalogues using a python script and DeepL. While it was helpful, the result definitely needed to be edited by a native speaker. Nevertheless, it might help to reduce the work.

Would a service like Weblate help this? I see many software projects using it. I think there are others that are free.


[add] setup script - to create custom dir/scripts/styles

Unnecessarily complicated and adds dependencies. Just do
fs.writeFileSync(path, content);

Sync is perfectly fine in short running setup scripts.

Also respect any existing scripts, do not overwrite.


error Failed at the<EMAIL_ADDRESS>install script

Hi, I'm getting the following error messages during the installation of node-red-contrib-onvif:
3-20T17:22:11.056Z [out] ><EMAIL_ADDRESS>install /data/node_modules/sharp
2022-03-20T17:22:11.056Z [out] > (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)
2022-03-20T17:22:11.056Z [out]
2022-03-20T17:22:11.531Z [out] sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.10.6/libvips-8.10.6-linuxmusl-armv7.tar.br
2022-03-20T17:22:11.791Z [err] sharp: Installation error: Prebuilt libvips 8.10.6 binaries are not yet available for linuxmusl-armv7
2022-03-20T17:22:11.792Z [out] sharp: Please see https://sharp.pixelplumbing.com/install for required dependencies
1129 verbose stack Error<EMAIL_ADDRESS>install: (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)
1129 verbose stack Exit status 1
1129 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
1129 verbose stack     at EventEmitter.emit (events.js:400:28)
1129 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
1129 verbose stack     at ChildProcess.emit (events.js:400:28)
1129 verbose stack     at maybeClose (internal/child_process.js:1058:16)
1129 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:293:5)
1130 verbose pkgid<EMAIL_ADDRESS>1131 verbose cwd /data
1132 verbose Linux 5.10.103-v7l+
1133 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "sharp"
1134 verbose node v14.18.2
1135 verbose npm  v6.14.15
1136 error code ELIFECYCLE
1137 error errno 1
1138 error<EMAIL_ADDRESS>install: (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)
1138 error Exit status 1
1139 error Failed at the<EMAIL_ADDRESS>install script.

https://github.com/lovell/sharp/issues/3150

I will soon replace sharp with jimp


PointNet++ size mismatch error

Hi,
I am running pointnet2_segmentation.py (I haven't changed the code at all) and get the following error in the very first layer when the fully connected operation is applied:
RuntimeError: size mismatch, m1: [398902 x 3], m2: [6 x 64] at /pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:273
Is the first linear layer supposed to take concatenated point locations as input? I believe in the original implementation the first layer had 3 input channels, but I may be wrong.
Appreciate the help!

You might be running the code on shapenet with normals. You can change the input and add +3 to make it work.
Best,
T.C

I changed the input dimension of the first layer to 3 and it seems to work.


broken appmaps

One or more of the appmaps has bad data in it:

Something happened that resolved this issue, not sure what it was. All mapsets render fine now.


Update App.css

Changed the background colour and added 2lines for better enhancement of boxes of tic-tac-toe

can you assign me this please

Admin Please assign me this task and I'll improve the whole home page. and make it responsive for mobile viewing.


[SPARK-19712][SQL] Pushing Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc.

What changes were proposed in this pull request?
This PR adds support for pushing down LeftSemi and LeftAnti joins below operators such as Project, Aggregate, Window, Union etc.  This is the initial piece of work that will be needed for
the subsequent work of moving the subquery rewrites to the beginning of optimization phase.
How was this patch tested?
Added a new test suite LeftSemiAntiJoinPushDownSuite.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7764/
Test PASSed.

Test build #102109 has started for PR 23750 at commit f819ced.

Test build #102109 has finished for PR 23750 at commit f819ced.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102109/
Test PASSed.

cc @cloud-fan @gatorsmile

gentle ping @cloud-fan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7990/
Test PASSed.

Test build #102410 has started for PR 23750 at commit edfe3d7.

Test build #102410 has finished for PR 23750 at commit edfe3d7.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102410/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7991/
Test PASSed.

Test build #102411 has started for PR 23750 at commit edfe3d7.

Test build #102411 has finished for PR 23750 at commit edfe3d7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102411/
Test FAILed.

Test build #102421 has started for PR 23750 at commit 488eda8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8001/
Test PASSed.

Test build #102421 has finished for PR 23750 at commit 488eda8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102421/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8062/
Test PASSed.

Test build #102503 has started for PR 23750 at commit ea76e29.

Test build #102503 has finished for PR 23750 at commit ea76e29.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #102521 has started for PR 23750 at commit 43e9eef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8086/
Test PASSed.

Test build #102521 has finished for PR 23750 at commit 43e9eef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102521/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8089/
Test PASSed.

Test build #102526 has started for PR 23750 at commit 43e9eef.

Test build #102526 has finished for PR 23750 at commit 43e9eef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102526/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8121/
Test PASSed.

Test build #102561 has started for PR 23750 at commit 0fa7950.

Test build #102561 has finished for PR 23750 at commit 0fa7950.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102561/
Test PASSed.

LGTM except my last two comments.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8155/
Test PASSed.

Test build #102604 has started for PR 23750 at commit 4a11ad4.

Test build #102604 has finished for PR 23750 at commit 4a11ad4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102604/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8164/
Test PASSed.

Test build #102613 has started for PR 23750 at commit 4a11ad4.

Test build #102613 has finished for PR 23750 at commit 4a11ad4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102613/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8373/
Test PASSed.

Test build #102892 has started for PR 23750 at commit fa41b44.

Test build #102892 has finished for PR 23750 at commit fa41b44.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102892/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8394/
Test PASSed.

Test build #102921 has started for PR 23750 at commit 76e7203.

Test build #102921 has finished for PR 23750 at commit 76e7203.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102921/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8406/
Test PASSed.

Test build #102937 has started for PR 23750 at commit 79579c8.

Test build #102937 has finished for PR 23750 at commit 79579c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102937/
Test PASSed.

LGTM except a few minor comments

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8432/
Test PASSed.

Test build #102963 has started for PR 23750 at commit 5ea6a4a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8433/
Test PASSed.

Test build #102964 has started for PR 23750 at commit 68e7268.

Test build #102963 has finished for PR 23750 at commit 5ea6a4a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102963/
Test PASSed.

Test build #102964 has finished for PR 23750 at commit 68e7268.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102964/
Test PASSed.

thanks, merging to master!

@cloud-fan @maropu Thank you very much !!


Add Zygrade event

Add an event for obtaining Zygarde 50% forme in gen 7.
Video proof (Credit to fel for the video!)

Thanks!

No problem


how can i abort(stop propagate)  grid's sort event in beforeSortChanged?

when i use follow event beforeSortChanged and afterSortChanged ,these event's parameter which is object type without any properties.

how can i abort(stop propagate)  grid's sort event in beforeSortChanged?

you cannot.


Reactive with catpuccin preset results in permanently dimmed buffer when you create a new one.

Here is a link to my dotfiles: https://github.com/Michaelpalacce/.dotfiles/blob/master/nvim/.config/nvim/lua/plugins/reactive.lua
I have confirmed the issue is with reactive, if I disable reactive I don't have this issue.
Furthermore the issue is with the cursorline preset.
https://github.com/catppuccin/nvim/commit/151e478edf8108cfd451a3cbd44d0a20503e7b42#diff-68c792bb5f250145916c09806fe2ef18bb663adbd3459f2ab4cb193690ef13be
from here
and a recording :
https://github.com/rasulomaroff/reactive.nvim/assets/17056014/0b0592c0-c177-4dbb-aea9-1ed03b1d31e7

Hi there @Michaelpalacce! Thank you for opening the issue, I'll try to investigate it
You pointed that it only happens with the cursorline preset enabled and that means that the issue is somewhere in the winhighlight option.
The problem is that it's really hard to debug since a lot of plugins use vim.schedule method for a lot of things and the error could be either on my side or nvim-tree plugin that you're using. They also use the winhighlight option.
Will get back to you when I look at it

Hi again @Michaelpalacce! Prepare for the long-read :)
Overall, I spent the whole day investigating what's going on there and I'm a bit surprised.
Good news - it's not a reactive.nvim's bug nor it's a nvim-tree's bug
Bad news - it seems like a Neovim bug or I don't even know whether it's a bug at all
How reactive.nvim works:

Set listeners to WinEnter, WinLeave, ModeChanged, BufWinEnter events.
Highlight whenever some of those listeners are triggered.

To make the process a bit easier let's imagine reactive only listens to WinEnter mode (because the bug occurs even if I disable all of those listeners except this one).
The algorithm is very simple:

WinEnter (or other event) is triggered
Get winhl option. Add reactive's highlights.
Include previous highlights as well (from other plugins, for example)
Set the updated winhl option (previous + reactive highlights).

But the surprising part here is that you'll get the same result (bug) even if you don't change winhl option, but still apply it.
For example, you can:

disable reactive
add this autocmd to Neovim initialization

vim.api.nvim_create_autocmd('WinEnter', {
  callback = function()
    local win = vim.api.nvim_get_current_win()
    vim.api.nvim_win_set_option(win, 'winhighlight', vim.api.nvim_win_get_option(win,'winhighlight'))
  end,
})

What it does is just applying the same winhl option that is already applied.

enter Neovim
open your nvim-tree by :NvimTreeOpen
close all other windows except nvim-tree by pressing <Ctrl-w> + o
open any file through nvim-tree file tree
observe the "bug" in the opened file haha

Even though you didn't change the winhl option itself, but you will still get this bug.
Another thing to know here is how nvim-tree opens a file in this case (I checked in their codebase):

It creates a split by executing :vsplit
Then it executes another command :edit yourfilename.ext

At this point I'm completely lost what to do next. Maybe the best solution is to ask Neovim team about this one. I think it's something in the winhl internals, but I don't really know, just guessing here.
I will not close this issue for now since I'm not completely sure about it, but again, I showed you the way you'll get the same bug even without using reactive at all.
Thank you for pointing this! Will be glad to continue this discussion.
Here are a video showing the way to get this error and a screenshot that proves that reactive is disabled.
https://github.com/rasulomaroff/reactive.nvim/assets/80093436/d6a3fc47-37d4-4adc-9f74-7def0d1ca403

Hey @rasulomaroff,
Thank you for the great insight on this one!
Honestly I am not sure what to say either, it seems like you took quite a lot of time and effort into this one. I have to admit that this is really above what I understand when it comes to Neovim. I think it'd make sense to close this, leave it as history?

@Michaelpalacce I think I'm gonna look at their C code first (if I understand anything 😄) and maybe find the issue there. And then open this issue in their repo. Because as I said, I'm not very sure on what's exactly going on in this case, but it's definitely something weird, at least for me.


Shouldn't ResourceType property be mentioned as a localization option?

Old way of localizing data annotations is with ResourceType-like properties.
This approach may be useful when models reside in separate class library. Shouldn't this option be mentioned in DataAnnatations localization section?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1833676-ff1b-c587-cc9c-81afffa8ef68
Version Independent ID: ad989395-3f49-4d55-521e-cf6fe56281ee
Content: Globalization and localization in ASP.NET Core
Content Source: aspnetcore/fundamentals/localization.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@hishamco  please comment.

AFAIK there's ResourceLocationAttribute but I'm not sure if it is used in data annotations, so let me check
Meanwhile you can check the docs https://docs.microsoft.com/en-us/aspnet/core/fundamentals/localization?view=aspnetcore-2.2#dataannotations-localization

I quote from ASP.NET Core team https://github.com/aspnet/AspNetCore/issues/4870#issuecomment-382831955

but we don't generally recommend ResourceTypes anymore

@voroninp hope that answered your question

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Add support for BGRA and flipped images in GLFWImage

GLFWImage assumes that the image is RGBA with the data starting from the top-left corner. However a lot of libraries meant for games import image data in other formats such as BGRA with the origin at the bottom left corner (such as the case with Freeimage).
It would be helpful if there was an image format and flipped image variable that could be set in the GLFWImage struct which would be used by GLFW to apply an image conversion when it copies the data. That way when setting a window Icon or cursor one doesn't need to write a converter and generate an additional another copy of an image.

Will consider this for 4.0.


Add detekt checks to CI

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#241  👈
#240
#239
#238
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Issue on exclude on windows restic

Output of restic version
0.16.4
What backend/service did you use to store the repository?
s3 Minio
the issue of the log
restic.exe : error: failed to save D:\shares\xxxxxx: nodeFromFileInfo
\?\GLOBALROOT\Device\HarddiskVolumeShadowCopy130\shares\xxxx: get EA
failed while opening file handle for path
\?\GLOBALROOT\Device\HarddiskVolumeShadowCopy130\shares\xxxx, with:
Access denied.
the issue is that its somehow trying to copy within the shadow copy which i want to ignore those path of shadow copy
already added this on the exclude file

HarddiskVolumeShadowCopy108
HarddiskVolumeShadowCopy*
HarddiskVolumeShadowCopy109
HarddiskVolumeShadowCopy110
HarddiskVolumeShadowCopy\*
*/HarddiskVolumeShadowCopy
C:\System Volume Information\*
D:\System Volume Information\*
\Device\HarddiskVolumeShadowCopy*\shares
\\?\GLOBALROOT\Device\HarddiskVolumeShadowCopy*\*
\Device\HardDiskVolumeShadowCopy*
\\?\D:\*
\\$?\GLOBALROOT\Device\HarddiskVolumeShadowCopy*
\\$?\D:\Shares

get EA
failed while opening file handle for path

Extended attributes support on Windows was only introduced in restic 0.17.0. There's something messed up in your issue description.
The command line how you're running restic is missing. Without knowing how exactly restic was run, it's impossible to help here.


dead links

all the links in the readme are dead.
Can you perhaps host the demo/examples on github instead?

Thanks for asking, although this project is kind of dead to me now, and it's very limited in functionalities.
If you're looking for a working framework of visual novel based on React, here is avg.js.
https://github.com/avgjs

thanks :)

Avgjs is interesting but it puts me off how it bundles react and forces me
to use an ancient version of react and pixi. Wish it was a bit more updated
and supported for typescript projects
On Fri, 23 Apr 2021, 10:11 Yan, @.***> wrote:

Thanks for asking, although this project is kind of dead to me now, and
it's very limited in functionalities.
If you're looking for a working framework of visual novel based on React,
here is avg.js.
https://github.com/avgjs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yinyanfr/novelscript/issues/12#issuecomment-825519664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRRWVJFYBUXA3W3QZFJ563TKE2TBANCNFSM43OHOBVA
.


Restore trace preload option

Add the missing trace preload option
Change-Id: I9d6cf4e4cca28b9ce765c5dcfb6f13fe4c0ce72d

Author zehao-jing-arm not on autobuild list. Waiting for curator authorization before starting CI build.

CI gfxreconstruct build queued with queue ID 255992.

CI gfxreconstruct build # 4828 running.

CI gfxreconstruct build # 4828 passed.


Create Inventory of Use Cases to cover in Documentation

Umbrella issue to capture ideas and community input for now. When we have the info architecture set for documentation types, we can map these ideas into more actionable pieces (ie. a Tutorial for X, a Sample Application for Y).
Open to community input about what you'd like to learn!

Is it possible for more elements of web5 to be incorporated into the developer site, such as having a PWA/DWA (maybe for some of the tutorials or guides) and so on? I can see that issuing VCs is on the linked image there, so will the web wallet be incorporated too? The reason I ask, I've just been playing around seeing how much I can put into just an html page with js and I can retrieve DID document info and create/send messages to my locally hosted dwn. So it just makes me wonder what ways you're (tbd people) already using or playing around with things and can it be used as work goes along on the website?

For DIDs, it could be better to start with something like an in page resolve like this https://pastebin.com/vry2wi7H where someone can straight away see what the DID is and what the document shows. Then working through some of the entries (e.g. using it to verify a message) and then finally how to create one with SSI and/or a wallet.

We're thinking:  Now that there is a use cases page, that's the inventory. :)
@bobbilee19 to link to where this page is (if it exists), and we can close from there if it's taken care of. Leaving this issue for now until we make sure it's reflected.

@bobbilee19 ^ Status? Let's do one of:

Document how this is satisfied so we can close the issue
Unschedule from Phase 2 and handle later

Bumping to Phase 3. Not Blocking Phase 2 release.

@ALRubinger maybe this is something we work on with @EbonyLouis?
How to bring in use cases based on what we're seeing in the community being built or asked for AND surfacing use cases and examples that we come up with.
We also deleted the Use Case / Case Study page from the docs and we're just listing some here on the main opening page for web5? is that the only place we have use cases highlighted?

@bobbilee19 Yes, it is. And also something I think is firmly within the remit of DevRel to design an inventory of use cases the team feels should be addressed. That inventory will likely be informed with input of stakeholders like @EbonyLouis who has a great pulse on needs from the community, and OSE as they advise their readiness on what's coming available.
I do think an inventory of work items may live separately from the published materials on developer.tbd.website, though would be fantastic to surface in one place we can all see in public.
Do you have ideas for what mechanism you'd like to track these? A label for use cases as part of docs inventory in GitHub Issues on the dev site? Something else? Happy to stand up whatever public facing system for this works well for the team to organize things in a contributor-friendly way and keep you moving.

Yess, this goes along with my brainstorming event ticket that I have in Asana. I've put it off for July/August, to get Chris' event in. But essentially the community also would love to know what's possible and get a list of use cases. So this event will start with a shared brainstorming doc, where everyone will write their ideas down and then during the event elaborate on use cases/ add more. It then will live in an "idea-board" channel where we'll always have a running wishlist of web5/ssi apps, to constantly have a flow of ideas to choose from.
This list could also live on the website.

Outdated


Support PSR-17 StreamFactoryInterface

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no?

Deprecations?
no

Related tickets
https://github.com/php-http/HttplugBundle/pull/339

Documentation

License
MIT

What's in this PR?
Support for PSR-17 StreamFactoryInterface

Build is failing because PHP 5.4 is still supported, maybe support for unmaintained PHP versions could be dropped?

I think you are right. The whole PHP-HTTP ecosystem is moving around the v2 so its time to deprecate some old PHP versions. Regarding that update, maybe supporting both HttplugFactory and PSR17Factory is not relevant anymore... PSR17 will be the de facto standard.

not just "de facto" but "officially accepted" standard :-)
afaik @Nyholm did a lot of thinking to have a clean upgrade path for the PSR, maybe he can chime in on this?

Yes, let's wait for his comment(s).
I would be very interested to know about the upgrade path ;)

@Nyholm do you have input on this one?

ping @Nyholm


Battery indicator in sensor settings changes

Screenshot from web

Based on #703

Good idea. We can use the dark orange (error color).

I previously mentioned that the arrangement of the items in Sensor settings (which is actually more than just settings) should show dynamic data like temperature, X,Y,Z, battery voltage before static items like offset correction, MAC address, data format Issue#373.
Now that battery replacement has been added it seems even more important to re arrange the items.
A better location for the warning indicator would be next to the alarm bell shown as a depleted battery icon for example:

This issue was resolved in 2.0


Collage Edit

Can you add a collage editor to the project? Ability to add multiple photos into 3,4,5 or more photos adhering to specific aspect ratios (1:1, 3:4, 4:3, 5:4, 4:5, 16:9, 9:16) and Can you add shaped view and randomization feature for one?
Gerard Bradshaw
You can check out the MixUp Github library.
Kind regards

Currently, I don't have bandwidth for it. Any helpful hand in PR is welcome.

UPDATE


The docs index.md fails to link to useful doc pages

When navigating to the docs site (http://testcontainers.viewdocs.io/testcontainers-java/),
the page does not link to /usage or any other useful page.
It is probably a good idea to link to the docs if you want people to read them.

TestContainers has new awesome docs published at https://www.testcontainers.org
Where did you get a link to http://testcontainers.viewdocs.io/testcontainers-java/ ?

I've updated the docs link in the main repo readme to point to the new docs site. Sorry for missing that before, but please refer to www.testcontainers.org for a far more usable docs experience.
There are probably a few links to the old docs site floating around on external sites, so I'll review and try and get them changed. Or set up meta-refresh to redirect people.

I think we can close this one because of the new docs ( www.testcontainers.org )
@georgespalding let us know if you still miss something there :)


ci: update ci to supported node.js 18 - 23 versions

closes https://github.com/simonepri/pidtree/issues/22
closes https://github.com/simonepri/pidtree/issues/23
closes https://github.com/simonepri/pidtree/issues/24
partially supersedes https://github.com/simonepri/pidtree/pull/12

Issue
GitHub Action CI workflows are using versions of Node.js which cause failures. The workflows are also missing other Node.js versions which belong to the set of currently supported Node.js versions, 18 - 23.

Workflow
Uses Node.js

.github/workflows/test-macos.yml
current, 16, 14, 12, 10, 8, 6, 4

.github/workflows/test-ubuntu.yml
current, 16, 14, 12, 10, 8, 6, 4

.github/workflows/test-windows.yml
current, 16, 14, 12, 10, 8, 6, 4

.github/workflows/lint.yml
environment default: v10.24.1

GitHub Action versions are not using node20 compatible version, which is currently the only valid value.
npm install commands are using outdated options.
Changes
For the following workflows:

.github/workflows/test-macos.yml
.github/workflows/test-ubuntu.yml
.github/workflows/test-windows.yml
.github/workflows/lint.yml

then:

Modify each workflow to use the complete set of supported Node.js versions 18.x, 20.x, 22.x and 23.x. .github/workflows/lint.yml is modified to use only the Active LTS version 22.x.

Update the usage of GitHub's own actions workflows to supported versions:

actions/checkout@v4
actions/setup-node@v4

Update the usage of GitHub action codecov/codecov-action to a supported version:

codecov/codecov-action@v5

Remove special handling in .github/workflows/test-windows.yml for Node.js version dependency

Remove the job names name: AVA & TSD & Benchmark & Codecov since GitHub is unable to display this text untruncated, and the Node.js version is not visible in the summary. For consistency, also remove the lint job text name: XO & Prettier as well.

Merge the npm install prod and dev steps due to outdated options no longer available on Node.js >= 16.

Impact
Note that this PR only updates CI. It does not update the engines field in package.json which is currently set to
"node": ">=0.10"
It does not cause any (breaking) change to the published npm package pidtree and it does not require a new release of the package.
The PR is a prerequisite for any other PRs: allowing them to be checked using CI with an expectation that CI workflows are successful.

@simonepri
Are you able to consider this PR?


Add features for parsing form data

Added middleware server.AutoParseFormUrlEncodedData(). Using this will automatically parse your url-encoded form data and store it in context.Locals as a IDictionary<string,string> under the key FormData. Does not work with multipart form data!

Added extension method IHttpRequest.ParseFormUrlEncodedData() which will return a the url-encoded form data as a IDictionary<string,string>. Because the input stream can only be read once, this method will only return data the first time it is called. It is recommended to use the aforementioned middleware instead of this method.

Added IHttpRequest.MultipartBoundary, which will contain the multipart boundary for easy access to parse multipart data.

Added sample resources for parsing multipart data using HttpMultipartParser (see on GitHub)

Closes #83


🌱 Uplift go modules to fix CVEs

Fixes# CVE-2022-1996 , CVE-2022-27664 and CVE-2022-28948

/test-ubuntu-integration-main

I would appreciate to have the CVEs info in PR description. Otherwise LGTM

Done

/cherry-pick release-1.2


Add new variable to contain full macOS version (e.g. 10.15.5)

This will allow the full version to be displayed in the log files.
Closes: https://trac.macports.org/ticket/56252

See #180 for other discussion

If it would be helpful, you could also add variables like macosx_version_major and macosx_version_minor which would be e.g. 14 and 6 respectively if macosx_version_full is 10.14.6.

[macports_version] was implemented as a proc rather than an option/variable. When I questioned this, I think it was Clemens who said it made more sense for it to be a proc since it should be read-only. You wouldn't want someone trying to set macports_version to some other value. By that same logic, should macosx_full_version be a proc too instead of an option/variable?
Tcl supports having a proc and a variable of the same name, so the proc could be named [macosx_version] the same as the old variable, though that might be confusing. Since the OS is called macOS now, it could be called [macos_version].
If it were a proc, it could accept args like "full" or "major" or "minor". But a "major" value of "14" for macOS 10.14 would no longer be a good idea, now that macOS 11 has been announced. In fact, macOS 11 probably makes our existing $macosx_version variable's value incorrect as well, since on macOS 11 it would report the version as 11.0 when it should be 11 (if I understand Apple's new versioning scheme correctly).
On the other hand, Tcl does support read-only variables, so I don't know why that couldn't have been used for macports_version.
My suggestion would be that the new read-only variable or proc should be macos_version. I don't think it's burdensome for ports that want to examine its value to use vercmp or string manipulation so I wouldn't bother with major or minor variables. Once this is released we'd deprecate macosx_version and transition all remaining uses of it to the new variable or proc and later we can remove macosx_version.

I don't think the variable/constant thing is a significant issue, so far we've generally made things that are supposed to be read-only variables but not options, and that seems to work pretty well.
I agree we might as well use the opportunity to switch to "macos" rather than "macosx". So add a new variable macos_version which contains the full version, and another new variable macos_version_major that contains the same value as the existing macosx_version. Then just update all the documentation and examples to use the new variables, add a lint warning for using macosx_version, but at least for the near future keep it available for compatibility.

Now there are 63 commits in this PR...

lol yea I messed up - I plan on creating a new MR

You can force push correct contents into this branch (as long as you don't accidentally push to master).


Please change the supported products and/or create a separate page for Cosmos DB for PostgreSQL

Connector mentions PostgreSQL Hyperscale (Citus)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 79c3f263-04ba-ea60-1927-c2fedde96d61
Version Independent ID: fe35a13a-a960-9a50-1b89-aa79abe514b9
Content: Copy and transform data in Azure Database for PostgreSQL - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/connector-azure-database-for-postgresql.md
Service: data-factory
Sub-service: data-movement
GitHub Login: @jianleishen
Microsoft Alias: jianleishen

@PabloMugica
Thanks for your feedback! We will investigate and update as appropriate.

Hi @PabloMugica
Thanks for your contribution. Please add your ideas in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)


Update ALPN instructions.

See https://github.com/googlegenomics/dataflow-java/pull/160 for similar updates for dataflow.

LGTM


threat modelling

Existence of the project and its goals will be publicised. Feedback may influence the domains to be
analysed or the approaches taken.
Threat modelling will be done in at least two application domains with different information authority
needs. Ideally each of the two application domains analysed will have an external representative to
minimise bias.

[x] published article of intent, linked from social media
[x] project backlog
[ ] 2 x threat model documents (with annotated diagrams). See the threat modelling README.

Threat models:

threats/e-invoicing.md
threats/legal-docs.md


viewElement.scroll slows down on repeated calls when reusing the Detox element

Description
viewElement.scroll slows down on repeated calls when reusing the Detox element.

[x] I have tested this issue on the latest Detox release and it still reproduces

Reproduction
Code with a slow down:
  const scrollView = element(by.id('scrollViewId'));
  while (true) {
    await scrollView.scroll(400, 'down');
    console.log('scrolled');
  }
  // it slow downs for me after 10 or so scrolls

It slows down by introducing a noticeable (more than a few seconds) lag before doing the scroll.
This will work well:
  while (true) {
    await element(by.id('scrollViewId')).scroll(400, 'down');
    console.log('scrolled');
  }
  // no slow downs

The first snippet works well on Android. Please, either fix that or document.
Expected behavior
No scroll slowdowns.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Detox: 16.4.0
React Native: 0.61.5
Node: 14.1.0
Device: MacBook with Catalina 10.15.4
Xcode: 11.4.1
iOS: 13.4 (emulator)
macOS: 10.15.4

Logs
If you are experiencing a timeout in your test

[ ] I have followed the instructions under Lower-level Idling Resources Debug and am providing the log below:

If you are seeing a build problem (e.g. during npm install)

[ ] I am providing the npm install log below:

Device and verbose Detox logs

[ ] I have run my tests using the --loglevel trace argument and am providing the verbose log below:

@rotemmiz Could this be some how "accumulating" more and more stuff as time goes by? Would this be fixed in invoke2?
@yurijmikhalevich Does this reproduce in Android as well?

@LeoNatan no, it seems to be fine on Android.

@yurijmikhalevich Could you please post a trace log, as requested in the template, while reproducing they issue?

@LeoNatan added log of the laggy version to the OP.

Thanks but that’s not the log I want.
Please provide the --loglevel trace log.

@LeoNatan uploaded the trace log.

We’re working on a new implementation of actions, which should be merged relatively soon. Let’s see if this reproduces there.

@LeoNatan great! Thank you! Please, let me know when it will be out so I'll test it.
I also noticed that tap action is much slower on iOS compared to Android. I wonder if it's due to the platform limitations or if there is a way to improve that.

Let's see how it performs in the new system.

@LeoNatan is the new system ready? Should I test it again?

The new system has not been deployed yet. You can follow the status here: https://github.com/wix/Detox/pull/2098

Please test on latest Detox version and report back. Thanks

@LeoNatan the issue is fixed in 17.0.2.

Great, thanks!


Won't save the GIF

I chose many different folders - some on the file system, others on NTFS drives and still won't save it. Only shows a message saying saving failed.

Hello @IvoAndonov ,

The screenshot shows the error icon. When you open the file chooser dialog, what does it say near the top?
:+1:

I don't understand why you don't make this app compatible with Ubuntu 16.04/Mint 18. Both will be supported until 2021 which means that many people are going to use them until then. Or, if you can give me a link to the older version of the app (which I suspect is compatible with Ubuntu 16), that would be better.
I tried to update ffmpeg but it brings errors and I for one have no intention to switch to ubuntu 18 (Mint 19) with its many glitches when Mint 18.3 works perfect.

Hello @IvoAndonov ,
What errors did you receive when attempting to update FFmpeg? I may be able to help you work around them.
Upgrading FFmpeg is the only necessity. Gifcurry itself runs fine on Ubuntu 16.04 and Linux Mint 18.
You have a few options.

Upgrade FFmpeg.
Install FFmpeg via Snapcraft.
Install Gifcurry via Snapcraft. Ubuntu 16.04 is the second most popular distribution. Linux Mint 18 is the sixth most popular distribution. Note that the Snapcraft installation only supports certain media formats.

Beyond that, I can try and support FFmpeg 2.8.15 for the next release.
:+1:

I ran sudo apt-get install ffmpeg and it showed a very long error. I ran this command just now with the intention to copy the error message and no more error but it says ffmpeg is already the newest version - 2.8.15 or something.
Before I downloaded the appimage I tried installing gifcurry via snap but the app itself didn't appear anywhere as installed, even running it from terminal displayed a message no such command was found. So I downloaded the appimage and it worked, except for the part where it won't save the gif.
If you can add support for 2.8.15 that would be great bc atm I have to use a website to turn a video into a gif. It's not bad but if you wanna add text, you gotta scroll down like crazy. The last gif I made (the one on the screenshot above) had about 250 frames and that site displayed every single frame, making the scrolling task almost infinite...

Hello @IvoAndonov
You can now use FFmpeg 2.8.15 with version <IP_ADDRESS>.
:+1:


Add support for pagination

Hi I love this
I was hoping pagination could be added but I'm not sure how that would work. Maybe select count(*) from table before the actual query? It would make every query slower though. Is this a wanted feature?
Thanks for this tool anyways!

Hi Marcelo
Thank you for your comments.
Currently pagination is up to the author of the query to control i.e. by using limit and top clause. Since it is possible to redirect the output of the program to file, modifying the query of the user to add a limit clause can give undesirable results.

Understandable. What if it was an option? I ask this because it's always desirable to get the full query response when scripting, we don't always (most likely never) want it on interactive mode. The option could even have an optional setting for the row count of each page that default to terminal height or something. I'm gonna fiddle a bit with this

Sure, that seems reasonable. Feel free to send a pull request if you'd like to contribute this feature.


[KafkaHub] Update KafkaHub deployment configurations

Description:

$subject

Update SSL keystore/truststore files.
Update network configurations in the docker-compose.
Update hub/subscriber/publisher code-bases to support the relevant network and SSL changes.

Fixed with following PR:

https://github.com/ballerina-platform/module-ballerina-websubhub/pull/911


not working for Infinia statement

only logs the first line of each page and moves out.

Can you give the table headers for it? It works on infinia metal statement that i tried against though


Add column nesting

Currently, the DataTableBuilderInterface::addColumn method currently accepts ColumnBuilderInterface as an argument, but nesting columns is not yet supported.
I'm thinking of some simple, yet friendly API, similar to forms. Let's assume, that we have to render a table like that:
|            |          Quarter           |
|  Employee  | ----------- | ------------ |
|            |      I      |      II      |
| ---------- | ----------- | ------------ |
|  John Doe  |     100     |      50      |
|  Jane Doe  |     200     |      75      |

To achieve such hierarchy, I'm thinking on something like this:
namespace App\DataTable\Type;

use Kreyu\Bundle\DataTableBundle\Column\Type\ColumnType;
use Kreyu\Bundle\DataTableBundle\Column\Type\NumberColumnType;
use Kreyu\Bundle\DataTableBundle\Column\Type\TextColumnType;
use Kreyu\Bundle\DataTableBundle\Type\AbstractDataTableType;
use Kreyu\Bundle\DataTableBundle\DataTableBuilderInterface;

class ProductDataTableType extends AbstractDataTableType
{
    public function buildDataTable(DataTableBuilderInterface $builder, array $options): void
    {
        $builder
            ->addColumn('employee', TextColumnType::class)
            ->addColumn(
                $builder->createColumn('quarter', ColumnType::class)
                    ->addColumn('first', NumberColumnType::class)
                    ->addColumn('second', NumberColumnType::class)
            )
        ;

    }
}

This way, we've created a data table that consists of two columns - employee and quarter, but the latter contains two children columns - respectively first and second.
If you create a view of such data table, you should notice two header rows, with appropriate HTML attributes automatically assigned to the first one:
/** @var \Kreyu\Bundle\DataTableBundle\DataTableView $view */

$view->headerRows[0]['employee']->vars['attr']; // ['rowspan' => 2]
$view->headerRows[0]['quarter']->vars['attr'];  // ['colspan' => 2]

This corresponds to the following HTML structure:

        Employee
        Quarter

        I
        II

This would require following changes:

Adding createColumn() to DataTableBuilderInterface, that returns ColumnBuilderInterface, similar to FormBuilderInterface::create().
Adding column-related methods methods to the ColumnBuilderInterface (addColumn(), removeColumn(), etc.), so API remains consistent. Naming those methods add and remove may seem more intuitive, but I think it would be confusing if used in this case:

$builder
    ->addColumn('employee', TextColumnType::class)
    ->addColumn(
        $builder->createColumn('quarter', ColumnType::class)
            ->add('first', NumberColumnType::class) // "add" what?
            ->add('second', NumberColumnType::class) // "add" what?
    )
;

Adding a mechanism to automatically apply rowspan and colspan HTML attributes - preferably in the ColumnHeaderView->attr array.
Changing DataTableView to accept array of HeaderRowView, instead of just one.
Some small changes in themes to render multiple headers
Something with personalization - the built-in scripts are using sortablejs, and it already supports nesting! Although, we have to prevent moving nested column outside of their parent.

Some breaking changes, but nothing too extreme. Probably needs more changes, but that's how I see it as today.

One thing to consider on this feature is sorting, In your example you show 2 headers (Employee & Quarter) and Quarter has I & II sub headers, will those be allowed to be sorted as well?
Depending on the data this may become very tricky, same goes for filters and search, so usually it's easier to flatten the table instead.
Also, it might be better to bisect the data per Quarter and show a table per Quarter instead?
Just thinking out loud here, could be a nice addition for some edge cases for sure, but goes more towards a static table, since this kind of nesting can get extremly complex  :)

One thing to consider on this feature is sorting, In your example you show 2 headers (Employee & Quarter) and Quarter has I & II sub headers, will those be allowed to be sorted as well?

Yeah, I think so. I don't see any risks with that, if you can provide sorting path for such column (e.g. DQL path when working with Doctrine), then there should be no problem with that.

Also, it might be better to bisect the data per Quarter and show a table per Quarter instead?

In some cases, probably. That's just a first example that came to my mind 😄

What's currently "blocking" me with this feature, is the column builder's API itself. Similar to many builder classes from Symfony itself, I am naming the last "build" method like a getter. For example, ColumnBuilderInterface currently has a method named getColumn() that creates a ColumnInterface (finishes a building process). This is also the case for DataTableBuilderInterface::getDataTable(), FilterBuilderInterface::getFilter(), and so on, and I think it should stay like that.
This, unfortunately, conflicts with the idea that ColumnBuilderInterface should contain following methods to work on the child columns:

getColumn(string $name): ColumnBuilderInterface :x:
addColumn(ColumnBuilderInterface|string $column, ?string $type = null, array $options = []): ColumnBuilderInterface
and so on...

This was planned to provide a nice looking API for the nested columns:
$builder
    ->addColumn(
        $builder->createColumn('quarter', ColumnType::class) // this returns ColumnBuilderInterface
            ->addColumn('first', NumberColumnType::class) // this addColumn() belongs to ColumnBuilderInterface
            ->addColumn('second', NumberColumnType::class) // this addColumn() belongs to ColumnBuilderInterface
    )
;

We should either use the add, get, remove methods (I really don't like this) similar to FormBuilderInterface:
$builder
    ->addColumn(
        $builder->createColumn('quarter', ColumnType::class)
            ->add('first', NumberColumnType::class)
            ->add('second', NumberColumnType::class)
    )
;

or name those methods with "nested" or "child" keyword:
$builder
    ->addColumn(
        $builder->createColumn('quarter', ColumnType::class)
            ->addNestedColumn('first', NumberColumnType::class)
            ->addNestedColumn('second', NumberColumnType::class)
    )
;

Currently, I'm liking the second option more, and it makes this possible:
$builder->getColumn('quarter')->getNestedColumn('first');
$builder->getColumn('quarter')->removeNestedColumn('first');

Unfortunately, more than two-level nesting may look weird when mixing with the DataTableBuilder::createColumn(), as there are no createNestedColumn(), as it would be totally unnecessary:
$builder->addColumn(
    $builder->createColumn('foo')->addNestedColumn(
        $builder->createColumn('bar')->addNestedColumn('baz')
    )
);

// or

$columnFoo = $builder->createColumn('foo');
$columnBar = $builder->createColumn('bar');
$columnBaz = $builder->createColumn('baz');

$columnFoo->addNestedColumn($columnBar);
$columnBar->addNestedColumn($columnBaz);

$builder->addColumn($columnFoo);

But I think that's the compromise we have to make.


[Add2app] How to set the bundle identifier for multiple native apps in flutter module

I have followed the doucmentation to create a Flutter Module, which I am able to run and build in my existing iOS and Android apps. I have multiple iOS and Android Apps which will use this module, all with different Bundle IDs.
Is there a way to set the androidPackage and iosBundleIdentifier for the module based upon the native project it is being imported from, and then use them inside the Flutter Module?
I need these bundle IDs to configure text in a widget based upon which Native App it is opened from.

Hi @ParasGarg7
You can only define a single bundle identifier for each platform in your pubpsec in the module. Files will be generated for each platform based on bundle so it is not possible for you to have multiple ios and android folders generated in a module hence not possible to define multiple bundles for same platfirm
You can create a single code module for multiple flutter modules for each unique bundled native apps, this might help avoid code
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Explore alternatives to custom Rush build:release command

Rush is pretty strict about log output during builds - anything logged to stderr will cause a build to fail. Some of our build steps generate log output that is difficult to silence. For now, we have a custom build:release command with "allowWarningsInSuccessfulBuild": true,, allowing our builds to pass CI.
Ideally, our build steps will not write anything to stderr so we can use the built-in rush build command.

@adobe export issue to Jira project CAI


No error messages display when reusing the redirection URL and when using the redirection URL after the expiry time

When trying to reset the password using ask password this issue has happened.
Tested this issue on IS 5.4.0 and IS 5.4.1.
Steps to recreate the issue

Configure to reset the password using ask password.
Set the expired link to 1day.
Click on the redirection URL of the received email after expire day.
Enter the password and submit. (It should give some kind of error indicate the link is expired.But, they get an empty screen without any error).

This issue has happened for below scenarios.

When trying to reset the password by clicking the received link of the email, after the expiryTime.
When trying to reset the password reusing the received link of the email, before the expiryTime.

As https://github.com/wso2/carbon-identity-framework/issues/1518 is resolved resolving this.


refactor(types): Simplify WithOptions type generic

Description
Simplifies the WithOptions generic by providing defaults to the generic.
Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/backend
[ ] @clerk/chrome-extension
[ ] @clerk/clerk-js
[ ] @clerk/clerk-expo
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] @clerk/localizations
[ ] @clerk/nextjs
[ ] @clerk/clerk-react
[ ] @clerk/remix
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/themes
[x] @clerk/types
[ ] build/tooling/chore

🚀 nice cleanup!!


Missing git tags for 0.1.1 and 0.1.2

Noticed there were a few PyPI releases where there are not git tags on the repo. Would it be possible to add these?
Also was there a 0.1.4 release or did that get skipped over?

Was having some initial issues with releasing, 0.1.1, 0.1.2 and 0.1.4 were all broken. Things should be fine now with 0.1.5.
I was planning on removing the broken releases completely from PyPI and NPM and considering them skipped over. Do you see any issues with that?

Mainly it can be useful for people trying different releases to identify what change(s) may have fixed or caused an issue.
Figured these tags were things you already had locally. So it would be trivial to push them. If that’s not the case, I wouldn’t worry about it (unless this comes up for another reason).
While I certainly understand the desire to delete older releases that caused problems, most packagers would not recommend this strategy. It simply makes it harder to figure out what caused an issue and how to avoid it in the future. Would recommend leaving them and just encourage people to upgrade to the latest version.

That makes sense.
I don't have tags locally as I was tying myself in knots locally with some of the tooling. I've got a good flow for this now with jlpm and Travis CI now though, so it shouldn't happen again.

FWIW I’ve found versioneer to be pretty handy when handling versioning as it translates git tags into package versions with ease. This is more Python-based. So there may be a little bit of work to connect this with JavaScript. There are a few other tools along these lines. Happy to discuss more if this is of interest.

Yup, love versioneer.
The node package is taking the lead on the version info (setup.pyimports the package.json file from the Node package). As node uses a static JSON file rather than a script like setup.py I would imagine it would take a bit of sed magic or similar to update it.
Would be neat to look into this.


route() helper function does not acknowledge app.url

Laravel Version: 5.4.15
PHP Version: 7.1.2-2+deb.sury.org~xenial+1
Database Driver & Version: 5.7.17-0ubuntu<IP_ADDRESS>

Description:
I am using the route($name) helper function in my views to take advantage of named routes, however if I try to change the app.url in config/app.php (APP_URL environment variable) this doesn't change the prefix of any of the URLs generated by route($name). I discovered this when using an ngrok tunnel's URL to try to demo something I was working on to a colleague.
Steps To Reproduce:

Change app.url in config/app.php to something other than your hostname
Call route($name) from a view
See URL does not equal updated URL and instead equals hostname

Notes
I have done some debugging and this is being generated in here:
https://github.com/symfony/http-foundation/blob/master/Request.php#L1244
While this is a Symfony file, it would be amazing if Laravel honoured the app.url when generating URLs.
This might get shot down as I imagine it's a lot more secure to generate URLs from the hostname rather than some user inputted value but just thought I would float this and see if it's viable.
Thanks!

The app.url is only used on CLI as far as i know.

Probably related:  #14139

I think if you don't define the APP_URL in your .env file, it will automatically get the new URL whenever you change it.
Try clearing the cache first, and then check.

The app.url is only used on CLI as far as i know.

Yes that's the main purpose of it.

So if app.url is used for the CLI, then there should be no (or the same) implications for using this for routing too?

Changing the UrlGenerator/RouteUrlGenerator to using app.url would result in all visitors being moved onto one domain; the one specified in app.url. The current behavior is to keep the user on the current domain. Changing this would cause issues for those of us that are running a multi-host setup where we have visitors on many domains.

this is lacking flexibility however. There should at least be a way to force route() to use a given url for cases where it's needed.. one that doesn't involve doing a str_replace on the default route

@vesper8 Yes. Url::forceRoot('https://www.google.com/')

Thanks @sisve !
And it's actually URL::forceRootUrl("https://www.google.com");

I was having problems because I was using Ngrok and the Laravel login.blade.php wanted to post to route('login'), which wasn't honoring my APP_URL.
So then I called .\ngrok http kvb.test:80 instead of .\ngrok http -host-header=rewrite kvb.test:80
Of course, this then meant that I needed to be careful about which of my many local apps was considered the default local Homestead app.
So I created an entry higher up in Homestead.yaml with "aaaaaa.test" for the project I was working on.
Then /login worked at my Ngrok URL.

I'm still having trouble; I don't think my weird steps posted above in February are the right approach.
I found a related issue (https://github.com/laravel/framework/issues/19556) but no solution yet.

I think UrlGenerator/RouteUrlGenerator to use the app.url should be the default behavior and overwrite if it needs to be different.

Changing the UrlGenerator/RouteUrlGenerator to using app.url would result in all visitors being moved onto one domain; the one specified in app.url. The current behavior is to keep the user on the current domain. Changing this would cause issues for those of us that are running a multi-host setup where we have visitors on many domains.

@vesper8 Yes. Url::forceRoot('https://www.google.com/')

Thank you @sisve !
I put the suggestion at my routes/api.php:
use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\URL;

Route::name('api')
  ->middleware([
    'cors',
    'json.response',
    'transactional',
  ])
  ->group(function () {
    // https://github.com/laravel/framework/issues/18613#issuecomment-341991605
    $url = config('app.url');
    URL::forceRootUrl($url);
   ...

@vesper8 Yes. Url::forceRoot('https://www.google.com/')

Thank you @sisve !
I put the suggestion at my routes/api.php:
use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\URL;

Route::name('api')
  ->middleware([
    'cors',
    'json.response',
    'transactional',
  ])
  ->group(function () {
    // https://github.com/laravel/framework/issues/18613#issuecomment-341991605
    $url = config('app.url');
    URL::forceRootUrl($url);

    // ...

Yes, this functionality worked for me. For some reason my BrowserSync on this one specific route view was not using port 3000 for all my links, but rather port 8000. Everything else was working just fine. So i shoved this at the top of my web.php routes file and it works perfectly! Thank you!


Updating a module's state using a global action breaks module actions

https://gist.github.com/Pyrolistical/882622fe00822418783dc63edcf04bf6
Demo

actions: {
  doubleUsingGlobal(state, actions) {
    return {
      counter: {
        count: 2 * state.counter.count
      }
    }
  }
},
modules: {
  counter
}

The module seems to get stuck with an old state slice reference. Should be easy to fix, just can't eagerly bind state slice to module actions.

Here it is, in initActions, we bind the state slice to the module forever:
https://github.com/hyperapp/hyperapp/blob/master/src/app.js#L72

#438 is now blocked by this.

This should be fixed when we merge #426.

We. Are. Immutable. 🎉

We. Are. Immutable. 🎉😎
#445


Encountered a jq error

ERROR: linkding Bookmarks[Script Filter] Code 5: jq: parse error: Invalid numeric literal at line 2, column 10

Are you using the latest version of the workflow? It's available on the Alfred Gallery.
Also how far into using the workflow did you get before getting the error?

Also try manually reloading the bookmark cache with the bm:: keyword, as shown in the third image of the README. The workflow caches all data pulled from the linkding API into a single line of a JSON file, so I'm not sure why you're getting a parse error on line 2.
You can find the cache file at ~/Library/Application Support/Alfred/Workflow Data/com.firefingers21.linkdingbookmarks/bookmarks.json. If updating the workflow and reloading the bookmark cache doesn't work, I'd be curious to see if anything is wrong in that file.

I reconfigured it with a different computer and it's working perfectly now. Thanks!


category: fix (generator.js, line: 67 - properties with empty values omits quotes

category: fix (generator.js, line: 67 - properties with empty values omits quotes
let app1 = new Moon({
    root: "#app",
    data: {
        msg: "Hello Moon!"
    },
});

{{msg}}

  <select name="some" multiple>
	<option value="0" selected>None</option>
	<option value="1">One</option>
  </select>

Result:
moon.min.js:40 [Moon] ERROR: Could not create render function
    error @ moon.min.js:40
    generate @ moon.min.js:1366
    compile @ moon.min.js:1374
    Moon.compile @ moon.min.js:1720
    Moon.mount @ moon.min.js:1616
    Moon.init @ moon.min.js:1677
    Moon @ moon.min.js:1435
moon.min.js:1624 Uncaught TypeError: Cannot read property 'type' of undefined
    at Moon.mount (moon.min.js:1624)
    at Moon.init (moon.min.js:1677)
    at new Moon (moon.min.js:1435)

Because:
var propsCode = generateProps(node, parent, specialDirectivesAfter, state);
console.log(propsCode)
...
{"attrs": {"id": "smart-view-two"}},
{"attrs": {}},
{"attrs": {"name": "some", "multiple": }},
{"attrs": {"value": "0", "selected": }},
{"attrs": {"value": "1"}},

Codecov Report

Merging #157 into master will increase coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #157     +/-   ##
=========================================
+ Coverage   96.08%   96.29%   +0.2%
=========================================
  Files           1        1
  Lines         920      917      -3
  Branches      171      172      +1
=========================================
- Hits          884      883      -1
+ Misses         36       34      -2

Impacted Files
Coverage Δ

dist/moon.js
96.29% <ø> (+0.2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5acef...1678ea7. Read the comment docs.

I think this should be fixed in the template compiler, and not the generator. Also, the commit message format is:
category: message

That means that you should have something like:
fix: allow properties with empty values

@Bampye Thanks for bringing it to my attention! I actually fixed this as I rewrote the template compiler, and I'll just push the changes I have so far.


Suggestion: add simple sorting rules

It is nice extension but unfortunately i cannot use it because of import order does not fit team agreement.
So it would be great if there be a possibility to define simple rules set in unserConfig without writing new sorter. For instance:
sortImports.rule: (importValue: string) => {
    if(importValue.contains('angular') { return 1 };
    if(importValue.endsWith('.less') { return 3 };
    return 2;
}

higher return value lower place where the import appears (in this case angular goes first, less - goes last, all others goes in between)
Also there will be cool to introduce option to skip new line between different import categories because different teams has different rules and ide'as so you cannot enforce to have new lines.

Hi @vytautas-pranskunas-
unfortunately, to do this you have to write your own style. See https://github.com/renke/import-sort#writing-you-own-custom-style for more information.


which T2w image(s) to pull

Ali noted that when using the --skip_preproc flag, only the first T2w image in a directory is used (instead of the usual behaviour of averaging multiple scans). We should have a systematic way to determining which scan gets pulled. Perhaps a sorting key.
I think priority should be given to SPACE or SPC acquisitions over TSE acquisitions.

Actually I see two different issues here:

when getting the list of all T2w images, e.g. to pick out the index-0 as the ref image, as done here, the ordering in the list has some randomness to it. I think it has to do with the use of set() in snakebids here, so will need to create an issue in snakebids to resolve this.. Note that this also affects what reference image is chosen when there are multiple T2w images, ie not just when --skip_preproc is used..
Once the randomness is removed, there is still the issue of whether we can (or want to) enforce some re-sorting of this list. There, I am more hesitant, since it would rely on bids tags without a constrained vocabulary (e.g. acq- can have anything in it..), so would never be able to have a heuristic that always works..  Perhaps we should just make it more opaque to the user exactly what scans are being pulled into the workflow.  Maybe could have some added option for specifying the reference to use, but I think in almost cases a simple alphanumerical sort would be fine..

Since the first problem is solved with snakebids v0.3.x #49  (by removing randomness in order), closing the issue.. The second problem is one that we don't really need to solve (since filters can be used to select the image(s) to use)