Configuration option or extension for dynamic resize of side bar contents

This is a bit of a specific tweak I am looking for. I'm running VSCode - Insiders on Linux (Ubuntu 19.10) for reference.
In the left-hand pane (the "side-bar") the drop-down containers (for files in Explorer context or the "Recommended" and "Enabled" containers for lists of options) often the lowest container contains only two or three options, while the upper container overflows into a scrollable interface.
I am looking for an option that allows dynamic vertical resizing of these containers, e.g the topmost container which is overflowing would be allowed to consume vertical space enough such that the "unused" space of the lower containers is absorbed.
While I'm fairly certain that this can be accomplished via some CSS injection or overrides of the base application itself, I'm not sure how best to go about it while allowing potential "pinning" of the vertical divisions, or configuring the option via settings.
Most of the time I run into this problem when using the "Explorer" view in the side-pane, the list of files overflows the bottom while the sub-menus (either provided by extensions or outline info) have blank unused space.
For more technical detail:
I know that each container is of class type split-view, contained within split-view-container in the left-hand pane. I know of some CSS tricks that would automatically resize the class's vertical spacing based on content, but am not sure how nicely that would play with different containers and potentially those provided by extensions. Currently, the pane class contains the individual container blocks, and is set up as a display: flex; element, set to vertical scaling.
I've fiddled with modifying the rendered CSS some, but have been unable to get a stable tweak implemented that allows for content length based scaling.
Any suggestions/tips would be appreciated, Thanks!

While this is indeed an often case, it is definitely not the only case. Especially now that one can move views around. What if there are two views with scrollable content? Or three? Most views are that way.
BTW: This can't be achieved with CSS, since the splitview uses JS for layouting.


Quick summary of raw output

Quickly determine things like the number of observations in each target class etc. directly from the raw outputs (and maybe targets, truth) and dump this to json or something.
Could be a 'raw' module along with sanity checks of fiberassign (https://github.com/desihub/fiberassign/issues/68)

bin/qa-fiberassign is a start towards this.  It first checks for outright errors (e.g. same target assigned to multiple fibers on the same tile) and then proceeds to generate some stats.  Several items to do:

check usability on full 16k tiles (I've only tested it with a mini 22 tile set)
more metrics, e.g. fraction of targets types assigned on dark/gray/bright tiles
more error checks, e.g. that there are enough sky and standards assigned
don't count bright tile coverage of dark time targets and vice-a-versa
output json or yaml data file with summary statistics
plots, HTML wrappers
refactor script into fiberassign.qa python library that could be called, e.g. from quicksurvey

Example current outputs on a 22 tile sample with lots of edge effects (i.e. don't panic about low efficiencies):
[cori12 end2end] qa-fiberassign fiberassign/tile*.fits --targets targets/targets.fits
fiberassign/tile_01148.fits - OK
fiberassign/tile_01149.fits - OK
fiberassign/tile_01165.fits - OK
fiberassign/tile_06911.fits - ERROR
  2 unassigned fibers
fiberassign/tile_06927.fits - ERROR
  1 unassigned fibers
...
16/22 tiles had errors
----------
60.2% targets (207595/344701) covered by 22 tiles
  Dropping 137106 targets not covered by any tile:fiber
Fiber assignment efficiency
  ELG       41.2%  (35766/86859)
  LRG       81.1%  (9049/11154)
  QSO       96.0%  (5769/6012)
  MWS_ANY   15.9%  (7509/47157)
  BGS_ANY   51.3%  (30598/59589)

---------------------------------------------------------------
WORK IN PROGRESS
The stats below mix dark/bright/gray without considering that a
dark target can't be observed on a bright tile
---------------------------------------------------------------

Percent of targets covered N times
            1     2     3     4     5     6     7     8     9
          23.2  23.1  17.2  13.3   9.8   5.6   3.5   2.7   1.2

Percent of targets covered at least N times
            1     2     3     4     5     6     7     8     9
         100.0  76.8  53.7  36.5  23.2  13.5   7.9   4.4   1.8

Assignment probability if covered at least N times
            1     2     3     4     5     6     7     8     9
ELG        3.9  11.1  18.6  28.6  37.5  40.5  41.0  41.2  41.2
LRG       16.3  38.1  59.6  76.0  80.4  81.0  81.1  81.1  81.1
QSO       22.5  48.1  70.5  88.2  94.3  95.6  95.9  96.0  96.0
MWS_ANY    0.5   1.3   2.2   3.4   5.3   7.9  10.7  13.6  15.1
BGS_ANY    9.7  23.3  35.0  38.1  40.6  43.6  46.5  49.3  50.7

i.e. this is a work in progress; please feel free to expand it with the metrics that you would like to see.
Note: the fiber assignment C++ code has some similar metrics built in, but it is still useful to have an independent cross check that the as-written files are correct.


Change config.h defaults

Enable MBEDTLS_CMAC_C, and MBEDTLS_NIST_KW_C (maybe nothing else to change).
This task excludes X.509 changes, which are covered in #4037

I'd like to suggest we consider disabling smaller curves by default. That is, 192-bit and 224-bit curves (we have two of each: secp-r1 and secp-k1 families) would be disabled by default in config.h (but still supported in the code base if someone wants to enable them).

I'd like to suggest we consider disabling smaller curves by default. That is, 192-bit and 224-bit curves (we have two of each: secp-r1 and secp-k1 families) would be disabled by default in config.h (but still supported in the code base if someone wants to enable them).

I quickly reviewed which module are currently not enabled by default, and in addition to CMAC and NIST-KW, there's also MBEDTLS_ARIA_C which I think should be enabled by default.
Currently MBEDTLS_ECJPAKE_C is disabled by default because when it was added the standard was potentially not final yet. @yanesca since you're currently investigating PAKEs, do you happen to know what the status of EC J-PAKE is? If the standard is mature enough, we should remove the warning in config.h and enable it by default.
All the other modules that are currently disabled by default are so for a good reason (such as: broken crypto / deprecated, alternative / OS-dependent features).

RFC 8236 is not standard track, it is just informational. About ECJPAKE in TLS I only could find an old expired draft:
https://tools.ietf.org/html/draft-cragie-tls-ecjpake-01
Based on this I think we could enable MBEDTLS_ECJPAKE_C by default, but MBEDTLS_KEY_EXCHANGE_ECJPAKE_ENABLED should remain disabled.

Thanks for the info, I wasn't aware there was an RFC about (EC) J-PAKE. Even if it's just informational, that's the case for a lot of things we implement (for example, all the PKCS RFCs are informational), and I think what matters here is the distinction between draft and final RFC.
However, since the implementation was based on the Thread spec, not this RFC (or draft of it), perhaps it would be good to check if it also conforms to the RFC at some point?

If MBEDTLS_ECJPAKE_C is enabled but an application doesn't explicitly use any of its features, does this increase the application's attack surface? If not I think we should enable it in the default configuration.

However, since the implementation was based on the Thread spec, not this RFC (or draft of it), perhaps it would be good to check if it also conforms to the RFC at some point?

That is a good idea, but I don't think it should block enabling MBEDTLS_ECJPAKE_C as default.

If MBEDTLS_ECJPAKE_C is enabled but an application doesn't explicitly use any of its features, does this increase the application's attack surface? If not I think we should enable it in the default configuration.

As far as I can tell it is not included in any abstraction layer or other feature and the TLS code calls it directly. If it is not enabled in the TLS module it shouldn't be possible to call it accidentally or to trick an application into calling it.

So far our (unwritten...) policy was to enable everything in the default config unless there was a specific reason not to (experimental, obsolete, insecure unless that's really what you want (I'm thinking NULL ciphersuites here), backwards compat issues...). I'm not necessarily against changing that policy to also include the generic reason of "might increase the attack surface", but in that case I think (1) it would be good to have a discussion about the policy first (and write down the result) and (2) I don't see why only ECJPAKE would be on the line.
Now regarding this specific case, I agree with Janos that I don't see a way to trick an application into calling it if the associated key exchange remains disabled. Now, in general, having more code in the executable portion of the process address space might still be a risk as it provides more gadgets for ROP or similar techniques. (This doesn't apply to constrained devices that presumably use link-time garbage collection, and probably shouldn't use the default config anyway.)

Summary of work to do:

enable MBEDTLS_CMAC_C, MBEDTLS_NIST_KW_C and MBEDTLS_ARIA_C
enable MBEDTLS_ECJPAKE_C but leave MBEDTLS_KEY_EXCHANGE_ECJPAKE disabled


Feature documentation

Re-submission for documentation (#221)
I think the docs may already be a bit out of date.  Off the top of my head I know we need to add documetation for:

multiple  output support
the new train and test score functions
I think you recently made a change where you can specify the layer type as a string

It might be good to get a discussion going on what needs to be documented

Thanks for bringing this back.  Have a few comments after which we should be good to merge (this time for real).

Wrapping up in #293


Resident command doesn't support quiet logging

I have been doing some testing with P4VFS to investigate how we can utilize it as part of our user syncs. One of the key aspects for us is the ability to re-virtualize any part of a workspace on demand via p4vfs resident -v.
Unlike the sync command, it appears the resident command doesn't support quiet logging? Even after adding the "-q" parameter to the resident command, it presents that it is doing a force|quiet sync but still presents the sync log anyway. (See image below)

This is not ideal as if we are re-virtualizing an entire workspace, the time taken for this grows exponentially if we don't use quiet logging as the resident command will print every file that has been virtually synced to it's #have revision. This takes a while in a large depot.

Hi @Smifferz,
Thank you for reporting this bug. I've reproduced it exactly as you describe and fixed in<PHONE_NUMBER>b58733ad57a0c12222fc9fab91a2b2. We'll include this in the next release. There is a large upcoming change in dev/reconfig branch which also affects the resident command, but only the hydration resident -r option.
-Jess

Fixed in <IP_ADDRESS>


Add ticker to all pages to show load time

Just on the train here waiting for tabs to load and it is fairly slow... Considering that Dojos in countries with slower internet connectivity may have an issue where they think the page is not loading at all!
Can we add a ticker/loading icon in these areas:

My Dojos, after you click manage users/manage events/anywhere data is loaded
Events tab
Badges tab

Related to https://github.com/CoderDojo/community-platform/issues/398 - there is an example of a loading animation here https://github.com/CoderDojo/cp-zen-platform/search?utf8=✓&q=spinner

Hey @tangentfairy, I'll have a look at this.

Great stuff! :)

:+1:


Version properties defined in maven profiles are not updated

See https://github.com/zalando/logbook/blob/master/pom.xml#L567
    <profiles>
        <profile>
            <id>spring-boot-2.0</id>
            <properties>
                <spring.version>5.0.5.RELEASE</spring.version>
                <spring-boot.version>2.0.1.RELEASE</spring-boot.version>
            </properties>
        </profile>

Thanks for the bug report.
Can you be a bit more specific here? It looks like Dependabot created this PR to try to update spring-boot - what could it have done better?

Nevermind. The problem is that I only want the version in the profile to be updated. But that's nothing the bot should be doing.


scrap PBR

This change is causing more headaches then anything of value it offers:
https://github.com/keylime/keylime/pull/281
Its either causing CI to Fail or software packaging systems upstream (such as Fedora).

Fixed in #335


Support Embedding Docs in External Apps

Issue Checklist:

[X] There are no matching Open Feature Requests
[X] There are no matching Closed Feature Requests
[X] I've read the Contributing Guide
[X] I'm following the Code of Conduct

Suggestion / Feature Request
I would like the ability to embed a specific URL on this docs site within another site or application, but we'd need to support a few things when it's embedded:

Remove Header Menu
Remove Sidebar Nav
Update Layout to resolve any issues caused by removing he above UI elements
Any links within the site to other pages should maintain the overall appearance with the removed UI elements
Just use something like a URL param like embed=true vs using iframes

The idea here would be that supporting this means we could embed a doc page into an app like VS Code, and any links within the returned HTML that might be clicked on would still navigate correctly, but not show the other UI elements.

This was deployed in release 0.6.0


NBS: Fragmentation tool using new estimate of locality

The new version of this tool now estimates the locality of a DB
written using the "grandchild" strategy implemented by
types.ValueStore. It does do by dividing each level of the graph
up into groups that are roughly the size of the branching factor
of that level, and then calculating how many physical reads are
needed to read each group.
In the case of perfect locality, each group could be read in a
single physical read, so that's what the tool uses as its estimate
of the optimal case.
Toward #2968

PTAL. New sync strategy in a separate patch. Seems to do WAY better than the current version, at least by the metric provided by this tool :-)


feat: Grunt mode post

TODOs

[ ] Update banner
[ ] Add media
[ ] Typo checking

@GeckoEidechse would you like to take a look at the post?
I would like to publish this tomorrow.

Definitely, I'll give a first review now and then a second one later today. Feel free to also poke me again in DMs <3


Androlze -s won't run on ubuntu 14.04

ipython 1.2.1
python 2.7.6
traitlets 4.2.1

ipython 1.2.1 seems to be very old. I'm running debian stretch and got 5.1.0
can you try to upgrade ipython?


Compare 2 images

This PR provide a widget to compare 2 images.
Relative to #1993
from silx.gui.plot.CompareImages import CompareImages
window = CompareImages()
window.setData(data1, data2)
window.setVisible(True)

Visualization mode: vertical/horizontal line, blue/red channel composition, only A or only B
Keyboard shortcuts to switch the visualization: A, B, V, H, C
Alignment mode: center/origin of images, stretch images, or use Sift
Supports intensity images, RGB, RGBA
Allow to display keypoints used to align images

# With 2 images
./bootstrap.py examples/compareImages.py joconde.png joconde2.png

# or with HDF5 datasets
./bootstrap.py examples/compareImages.py "silx:../data/diff_id22.h5?path=data&slice=0" "silx:../diff_id22.h5?path=data&slice=20"

# or with EDF
./bootstrap.py examples/compareImages.py ../data/diff_image/D2_H2_T2_h_3599.edf ../data/diff_image/D2_H2_T2_h_3603.edf

TODO

[x] Use fabio/silx/hdf5 to load images from the example
[x] Use PlotWidget instead of Plot2D
[x] Remove useless plot tools
[ ] Provide an API to custom the OpenCL context
[ ] Display transparent borders instead of black border (for aligned images)
[x] Move actions on top
[x] Create a dedicated toolbar (common way to do now)
[x] Programmatic API to switch modes
[x] Use enum instead of string
[x] Documentation
[x] Status bar

Sift improvement:

[ ] Allow to align intensity images with RGB images
[ ] Allow to align 2 images with different sizes
[ ] Allow to align an RGBA image
[ ] Extract keypoints and align image in a single pass (the python API do not allow that)

Nice widget. Will be really usefull. Can be an application from my point if view.
A few questions/observations that might be of some interest:

a tooltip or a widget displaying extra information can be usefull with pixel value of img1, img2, and/or diff of values.
an option to choose between global intensity normalization (which is the case now) and 'local/individual image intensity' normalization can be usefull in some case
I prefer your 'gray compare mode ' to the 'single channel compare mode'

The code can be reviewed.
On a side note, i think it is needed to add an API to custom the OpenCL context. And a default one should be provided by silx. And we should provide a dialog to select it. Then for another PR i guess.

It's a pity the image plot items and the backend does not provide something like get|setVisibleRect.
For the OpenGL backend it would avoid to update the image when the separation marker is moving, as it only needs to update which part is displayed... (maybe for later)

Just a question on the structure: why not making the CompareImages a MainWindow and adding toolbars there ?
Also it's probably useful to be able to access the underlying plotWidget from the public API.

Yes, you are right about the MainWindow, but i really dont like the idea to use it for a widget. Then i did a kind of cheat, which is definitly not good.
For the setVisibleRect it is not really big issue cause we don't really need to be efficient here. But i ask myself before starting if 3D widget and its scene could be used here, instead of a 2D plot :-)

The plot3d widgets for now only provides interaction for 3D content which would sounds weird if you only display 2D images...

And yes, there is already a getPlot method.

LGTM


Error

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/hello-world-tutorial/run#
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
Windows 10
#7296   #4026
#7091

It's taking time for the link to load and for the browser to open

Hi @solitudeX12 Could you please describe the problem in more details? Do you see any error/exception, or does it work, but takes a lot of time?


Fix #1320: #1319

#1319: Add R Script/ and RMD gives error
#1320 Show "Set Directory Here..." on project node

:+1:


feat(terminal): added ZSH shell for Linux based OS

Signed-off-by: Dipankar Das<EMAIL_ADDRESS>This PR...
Changes

Addition of ZSH shell for the 'other' OS

Fixes

Issue #2306

Screenshots

Checklist

[X] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

@topliceanurazvan changed as you suggested

Thanks for your review

Great!


Add Max MTU and 2M PHY selection

Description
This adds two optional parameters to connect that affect Android connections (these features are not available on iOS).
auto2MegPhy?: boolean (default: false): When enabled, Android Oreo and newer will request that the 2M PHY be selected at the time of connect.
autoMaxMTU?: boolean (default: false): When enabled, Android requests the maximum MTU (247) on the new connection.
In addition to the above functional features, there are also some non-breaking extensions to the response structures.
Peripheral.mtu is added, helping clients to WriteWithoutResponse data in appropriate chunk sizes.
ReadResult.peripheralUUID is added (via extends CRUDOptions) to enable clients to connect notify streams to multiple peripherals at the same time.

@facetious seems awesome. One thing. I am a bit worried about the hardcoded MTU value on iOS for Peripheral. What if the device only accepts 24 for example ?

@facetious seems awesome. One thing. I am a bit worried about the hardcoded MTU value on iOS for Peripheral. What if the device only accepts 24 for example ?

iOS has forced its MTU to 185 since it began supporting BLE. Is your concern that the peripheral may not support it?

@facetious indeed it is my concern. I am worried users will think 185 will always work. But i dont know maybe it is good still.
Let me think a bit about this. I will merge still

@facetious sory for looking at this so late. Can you merge from master?

This was resolved by https://github.com/nativescript-community/ble/pull/202 (which I totally forgot was still open).

This was resolved by https://github.com/nativescript-community/ble/pull/202 (which I totally forgot was still open).


Expenses duplicated on host dashboard

After clicking "load more" sometimes the host dashboard shows the same expense duplicated multiple times. This is super problematic and- it just caused me to make a big overpayment to a user because I added up the total of all expenses shown and sent the funds, only to later realise some of them were duplicated.
Here's an example of how it looks:

I'm sorry for this experience, while I couldn't reproduce the issue locally but I was able to figure out what could be wrong in relation with https://github.com/opencollective/opencollective/issues/2690 and I opened a fix.


throws in Executor::create if module is not compiled

This PR makes all the ConcreteExecutor::create throw if the module is not compiled. This is also true for OmpExecutor and ReferenceExecutor. Also, the populate_exec_info function now also throws.

format!

I believe we discussed this a while ago and decided for not doing this?

@tcojean Do you think it would be possible to find the discussion again? I'd be curious to understand the rationale, maybe we can even document it in the hooks?

I also remembered we discuss it before, but does not find any related discussion yet. I think one of reason was example or benchmark always create all executors such that we need to do that. but after https://github.com/ginkgo-project/ginkgo/pull/602, we should not face this issue.

Good job Mike, I was also looking. I'm quite sure it appeared indeed here: https://github.com/ginkgo-project/ginkgo/pull/554, but the comments were on slack it seems and not in the PR.
Some concern to keep in mind is that for me this is almost an interface break in some form due to changing exception behavior. In all, some user codes would not work anymore depending on how they did their executor selection because of throwing.

In an earlier internal discussion, the majority favored throwing only at kernel launches. Since this is a relatively small change, and it could lead to potential user issues, as pointed out by @tcojean, I will not pursue this further.


fix #4280: only drop points matching WHERE clause

I'm confused -- I only see tests that check if certain errors occur. Is there a bug here that was fixed? did those errors not get spit out before, and instead data was dropped?

@otoolep  yes, issue #4280 was for data that was getting dropped when it shouldn't.  While fixing that I also went through the other queries making sure they also check for things in the WHERE clause that should return errors.

So do we need a test showing that only certain series are now deleted when there is a WHERE clause? Perhaps I am dense and missing it.

Oh, I see, DROP SERIES with WHERE should be blocked and just don't allow it?

@otoolep no, DROP SERIES FROM cpu WHERE tagKey = 'tagVal' is allowed but WHERE time and WHERE value aren't currently supported.

Had a quick review over hangout, and I follow this code. +1


Improve RecallResult

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e7b3a78) to head (67fe00a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           42        42
  Lines          934       906   -28
  Branches       106       102    -4
=========================================
- Hits           934       906   -28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't upload caption files (RunPod)

AttributeError                            Traceback (most recent call last)
File /workspace/mainrunpodDreamboothv1.py:512, in uplder..up(Upload)
510 uploader.close()
511 Upload.close()
--> 512 upld(Remove_existing_instance_images, Crop_images, Crop_size, IMAGES_FOLDER_OPTIONAL, INSTANCE_DIR, CAPTIONS_DIR, uploader, ren)
513 done()
File /workspace/mainrunpodDreamboothv1.py:579, in upld(Remove_existing_instance_images, Crop_images, Crop_size, IMAGES_FOLDER_OPTIONAL, INSTANCE_DIR, CAPTIONS_DIR, uploader, ren)
577   if filename.split(".")[-1]=="txt":
578     with open(CAPTIONS_DIR+'/'+filename, 'w') as f:
--> 579         f.write(file['content'].decode())
580   up=[file for file in uploader.value if filename.split(".")[-1]!="txt"]
581 if Crop_images:
AttributeError: 'memoryview' object has no attribute 'decode'

fixed, you don't need to update anything

Thanks for your response, but it's still not working.
|█              | 1/14 Uploaded
UnidentifiedImageError                    Traceback (most recent call last)
File /workspace/mainrunpodDreamboothv1.py:512, in uplder..up(Upload)
510 uploader.close()
511 Upload.close()
--> 512 upld(Remove_existing_instance_images, Crop_images, Crop_size, IMAGES_FOLDER_OPTIONAL, INSTANCE_DIR, CAPTIONS_DIR, uploader, ren)
513 done()
File /workspace/mainrunpodDreamboothv1.py:608, in upld(Remove_existing_instance_images, Crop_images, Crop_size, IMAGES_FOLDER_OPTIONAL, INSTANCE_DIR, CAPTIONS_DIR, uploader, ren)
606 for file in tqdm(uploader.value, bar_format='  |{bar:15}| {n_fmt}/{total_fmt} Uploaded'):
607     filename = file['name']
--> 608     img = Image.open(io.BytesIO(file['content']))
610     extension = filename.split(".")[-1]
611     identifier=filename.split(".")[0]
File /usr/local/lib/python3.10/dist-packages/PIL/Image.py:3186, in open(fp, mode, formats)
3184 for message in accept_warnings:
3185     warnings.warn(message)
-> 3186 raise UnidentifiedImageError(
3187     "cannot identify image file %r" % (filename if filename else fp)
3188 )
UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x7f12c8970720>

that's an issue with the image file, try a different dataset


Force the view on portrait/vertical mode

In portrait/vertical orientation sometimes I see the alert "Please rotate your phone",  I'm wondering if it is possible to force the view by clicking the alert.

Yes, that could be a good idea.
I could force the overflow on the table so the user can swipe left/right to see the full table even on the small portrait view. It's not the best behavior but it could be good enough and it's an user decision.
thanks


fix: fixed dependencies (#558)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #558 (3921b3d) into main (996dbdb) will increase coverage by 8.83%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   67.55%   76.39%   +8.83%
==========================================
  Files         204       89     -115
  Lines        1945      949     -996
==========================================
- Hits         1314      725     -589
+ Misses        631      224     -407

see 115 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[C# 13]: New Feature - Allow ref and unsafe in iterators and async

Visual Studio release
17.11p2
Link to speclet

Speclet

Link to Pull request

PR

New behavior
Before this version ref and unsafe weren't allowed in either iterators or async methods.
Now, those are allowed so long as they aren't in blocks that have yield or await.
This one is somewhat complex to describe for readers not intimately familiar with captured contexts and how the compiler lowers iterators and async methods.
Areas affected

[X] Add to What's new in C# 13: Add links to updated docs in the What's new in C# 13 article.
[X] Update language reference: Detail the areas in the language reference that will be updated for this feature.
[X] Update compiler messages: Add new (or updated) pages for new compiler messages. Include related message.
[ ] Include in Everyday C# section*: Is this new feature included in Everyday C#?
[ ] Tutorials: Are new tutorials required for this feature? If so, detail below

Language reference tasks
The pages for ref struct, yield, async and await will need updates to explain this feature.
The corresponding programming guide pages may need to be checked to see if any of the language describing any of these features describe the existing restrictions.
Tutorial tasks
No response
Everyday C# tasks
No response

Associated WorkItem - 259674

As part of updating and consolidating error messages, 11 articles were removed. (net 10)


Add Scroll RPC Single Node Support

What does this PR do?
Add Scroll RPC Single Node Support
Motivation
Provide easy setup for Scroll node on AWS.
More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[x] Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
[x] Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
[x] Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
[x] Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

[ ] The tests for all current blueprints successfully complete before merge?
[ ] Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
[ ] Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
[ ] Mandatory for new node blueprints. The website builds without errors?

Additional Notes

Successfully deployed on AWS

Test result

Thanks a lot for this pull request! I'll review it within the next 2 working days.


Ideally, this lazy initialization could be completely opaque to the callers, though. One possible way we could do this is by implementing a custom CollectionType which lazily provides its elements. What do you think about that idea?

Sounds interesting! The first glance in my mind was an ordered array like this: [Depth0<Depth0Count: Int>, Depth1<Depth1Count: Int>, Depth2<Depth2Count: Int>...]. Am I heading in the right direction?

Sounds interesting! The first glance in my mind was an ordered array like: [DepthOfGraph0, DepthOfGraph1, DepthOfGraph2 ...].

Yep, that should work. ☺

Just implemented a CollectionType from my point of view. And seems like that I could not generate such an array in specific order. Advices are very appreciated !

I was thinking we would use a custom CollectionType for each of the lists of depth-ordered dependencies. In other words, there would be a collection for depth index 0, a different collection for depth index 1, etc.
This is a good start, though. Let me know if you'd like me to take it over and implement what I've described here. 😄

Hmm, feel free to close  or merge this pull request if need. Sorry for misunderstanding. Will keep watching and learning. :D

Thanks for getting this started! I committed something slightly different in f659630051b5db2c1f26b0d6a70b720855a7d191, but it's a very similar idea, and I'm glad you took a stab at it. 🙇


explain get_tare() in more detail

weight = scale * (raw - offset);  ==> weight = scale * raw - scale * offset
Tare is the raw measurement with no weight
The get_tare() include the scale in its formula, Initial scale is 1 so it does not have effect unless after calibration.
However after calibration it changes, so this need to be explained better or even removed?
So get_tare() == scale * offset makes sense if one wants to know the Y= AX +B formula.

The comment  //  OFFSET > 0  is incorrect as offset can be negative too.

weight = scale * raw - scale * offset
...
... if one wants to know the Y= AX +B formula.

Y = weight
X = raw
A = scale  ==  get_scale()
B = scale * offset == get_tare()

add a section to master branch, will be part of next version.


Those cracks.

So question,
We just started a world (my BF and i)  and doing things with thaumcraft. Now we got one of those weird starry tendrils.
It spawned at a point a funky looking thing spewing stuff and we killed it.
And the world underneath was pretty much drained. (porrous stone and such)
But it won't go away! how do those things go away because the world is kind of not playable anymore now.
:(
With kind regards,
Mystlynx

This is a forum for technical issues and bugs. What you're experiencing is a normal part of the game, please read up on the Minecraft forum thread for help with gameplay.

I understand but if there is no possible way in the game to remove it and it destroys the world i can consider it a bug right? As it is not acting as intended... and making gameplay nigh impossible

Currently rifts spawn seeds after a while, which you have to find ways to destroy. That's not a bug although lots of suggestions have been made on how to rebalance that. Please use search, it's been discussed in a few issues already.

The rift should go away when flux reaches 0, but if this doesn't happen, try running /kill @e[r=5,type=!Player] while standing next to the rift. If you want to drain the flux from the area you can use the flux sponge from the creative mode inventory.

The next non-bug fixing update will add ways to remove these.


Item names are bugged

After i finished creating the quest and complete the stage my item name is bit buggy
http://prntscr.com/60v8m0

Is this on Quests 2.1.3? If not, please retry and check for console errors.

Yes with complete regeneratet files..

Fixed in Quests 2.1.4. Thanks!


Feature request - straight and parallel lines

Is it possible to add a feature that will enable me to draw straight lines? maybe by clicking on 'shift' as its expected in other products?
Also, is it possible to make straight lines that are parallel to the x and y-axis?

Are you talking about the freedraw tool?
Now I'm actually recalling it used to work once.

What's your browser & OS?

It works for me, I have same MacOs 10.15.7 (but 19H15) and Chrome 98.0.4758.102
https://user-images.githubusercontent.com/43070174/154855502-49fe0793-692a-472d-b3c5-78389ff179c4.mp4

It works for me, I have same
MacOs version 10.15.7 (but 19H15) and
Chrome Version 98.0.4758.102 (Official Build) (x86_64)
https://user-images.githubusercontent.com/43070174/155164837-1606bca3-8b47-465d-870e-16a068328de7.mp4

Hi everyone. I just tried it again after restarting my Mac over the weekend and the issue seems to be resolved. I really don't understand what is going on and how does it work now after not working for two weeks.
Anyway, thank you all!
I'll close the issue.


Adding images or fonts in Browser

I am trying to add an image to a generated PDF. The image is received as an array buffer from server.
I am using angularjs and get the image like this:
$http({url: '../../company/logo', method: 'GET', responseType: 'arraybuffer'})
.then(function (result) {
    logo = result;
}

I add the image to the PDF like this:
doc.image(logo.data, 0, 0, {height: 128, width: doc.page.width});

I get the following message:
Error: fs.readFileSync is not a function
[22]</</PDFImage</PDFImage.open@http://<IP_ADDRESS>:5984/cijcnaah5ie666n/_design/core/bower_components/bower-pdfkit/pdfkit-0.7.1.js:2896:16
[29]</</module.exports.image@http://<IP_ADDRESS>:5984/cijcnaah5ie666n/_design/core/bower_components/bower-pdfkit/pdfkit-0.7.1.js:3946:15

There is a discussion on Stack Overflow:
http://stackoverflow.com/questions/26392735/pdfkit-custom-fonts-fs-readfilesync-is-not-a-function
Suggestion is to add the following to pdfkit:
PDFImage.open = function(src, label) {
    var data, match;
    if (Buffer.isBuffer(src)) {
        data = src;
    } else {
        //START NEW
        if (src instanceof ArrayBuffer) {
            data = new Buffer(new Uint8Array(src), 'object');
        } else
        //END NEW
        if (match = /^data:.+;base64,(.*)$/.exec(src)) {
            data = new Buffer(match[1], 'base64');
        } else {
            data = fs.readFileSync(src);
            if (!data) {
                return;
            }
        }
    }

I tried this change and it works. Could this change be added to in the source?

It cannot be added to the source because this is not a JavaScript project. Please talk to the maintainer of that project instead.

I am so sorry! Wrong repository...

No worries @simonbernard


Images on the Land Portal not being grabbed by Facebook / LinkedIn, etc.

There is an issue with the SEO of Land Portal images, which are not being picked up by Facebook, LinkedIn, etc., which was the case before and is normal for website / link sharing:

The image from this post should be appearing here: https://landportal.info/news/2017/12/land-portal-launches-bangladesh-land-governance-country-portfolio

@realneilsorensen I was testing with my personal account & on a page, and the image appears.

Strange, it has done this many times for me.

@realneilsorensen could you try it again? and if it is working, please, close the ticket

Hi @dayures , @realneilsorensen
It works for me (although it didn't work the first time I copied and pasted the URL in my Facebook; I had to do it twice. The same happened with the last published news (Data Stories).
Is this working for you @realneilsorensen? Can we close the issue? Thanks.


ADS 1.50 fails to load python kernels for notebooks

Type: Bug
ADS 1.50 fails to load kernels
TL;DR:
Currently the most stable fix I have found is:
Load ADS, try and start a notebook.

This will fail and try and do an install of the ‘correct’ versions of python packages.

Let the install happen.

Close all notebooks.

Open a console and run:
  "C:\Users\<user>\azuredatastudio-python\python.exe" -m pip install --user "notebook==6.5.5" "ipykernel==5.5.5"

Open an editor and change line 1411 in $(Python)\Python38\site-packages\notebook\notebookapp.py from
 'jupyter_server.contents.services.managers.ContentsManager'
 to
 'jupyter_server.services.contents.manager.ContentsManager'

Re open a notebook, and the notebooks should connect to the python kernel / run notebook server fine – until you restart ADS.

Things I have tried (the long version) :
Using Azure Data Studio 1.50
When opening a notebook, the program attempts to switch kernels to the python 3 kernel, and detects that the requirements are not configured, launching the python configuration window of ADS
Clicking ‘Install’ follows through the install process for the ‘Required Version’ of the listed dependencies.
However – this causes a cascade of bug-like occurrences.
The install sequence completes with ADS trying to lauch the Notebook server, which fails with the following error:
[Start Error message]
Could not start session: Notebook process exited prematurely with error code: 1. StdErr Output: Traceback (most recent call last):
File "c:\Users\B'Skai\AppData\Local\Programs\Azure Data Studio\resources\app\extensions\notebook\resources\pythonScripts\startNotebook.py", line 1, in
import notebook.notebookapp

ModuleNotFoundError: No module named 'notebook.notebookapp'
[End Error message]
This was a known bug in previous versions of ADS, characterised and community solved here: https://github.com/microsoft/azuredatastudio/issues/23945
This page suggests the ‘fix’ of downgrading the notebook version to sub version 7. Both versions 6.0.3 and 6.5.5 are mentioned.
notebook 6.5.5 installs correctly (downgrading 7.2.2), but attempting to start the notebook server fails with the followning error:
[Start Error message]
Could not start session: Notebook process exited prematurely with error code: 1. StdErr Output: Traceback (most recent call last):
File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\notebook\traittypes.py", line 235, in _resolve_classes
klass = self._resolve_string(klass)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\traitlets.py", line 2015, in _resolve_string
return import_item(string)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\utils\importstring.py", line 33, in import_item
module = __import__(package, fromlist=[obj])

ModuleNotFoundError: No module named 'jupyter_server.contents'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\Users\B'Skai\AppData\Local\Programs\Azure Data Studio\resources\app\extensions\notebook\resources\pythonScripts\startNotebook.py", line 2, in
notebook.notebookapp.main()

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\jupyter_core\application.py", line 283, in launch_instance
super().launch_instance(argv=argv, **kwargs)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\config\application.py", line 1073, in launch_instance
app = cls.instance(**kwargs)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\config\configurable.py", line 583, in instance
inst = cls(*args, **kwargs)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\traitlets.py", line 1292, in new
inst.setup_instance(*args, **kwargs)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\traitlets.py", line 1335, in setup_instance
super(HasTraits, self).setup_instance(*args, **kwargs)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\traitlets\traitlets.py", line 1311, in setup_instance
init(self)

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\notebook\traittypes.py", line 226, in instance_init
self._resolve_classes()

File "C:\Users\B'Skai\AppData\Roaming\Python\Python38\site-packages\notebook\traittypes.py", line 238, in _resolve_classes
warn(f"{klass} is not importable. Is it installed?", ImportWarning)

TypeError: warn() missing 1 required keyword-only argument: 'stacklevel'
[End Error Message]
This error is characterised, and community solved here: https://github.com/microsoft/azuredatastudio/issues/24436
$(Python) = C:\users//appdata/roaming/python
Changing line 1411 in $(Python)\Python38\site-packages\notebook\notebookapp.py from
'jupyter_server.contents.services.managers.ContentsManager'
to
'jupyter_server.services.contents.manager.ContentsManager'
After this change, when attempting to start the notebook server, the notebook server starts correctly,
However, the python install window re-occurs.
This causes ADS to attempt to install the required versions, which fails.
At this point, explicitly installing notebook 6.5.5 and ipykernel 5.5.5
succeeds at starting the notebook server, and switching kernels to python
However, re-starting ADS causes the same issues over again.
=====================================================
Trying something different - attempting to 'correct' the 'most current' versions.
+++++
Starting from the same point as before, ADS detects 'incorrect' versions, and attempts install.
Having done an install to notebook 7.2.2 / ipykernel 6.29.5
One of the other fixes suggested at https://github.com/microsoft/azuredatastudio/issues/23945 is to alter this file: https://github.com/microsoft/azuredatastudio/blob/main/extensions/notebook/resources/pythonScripts/startNotebook.py
C:\Users<user>\AppData\Local\Programs\Azure Data Studio\resources\app\extensions\notebook\resources\pythonScripts\startNotebook.py
Change line 1 to ‘import notebook.app’
Change line 2 to ‘notebook.app.main()’
Fails to start notebook server with following error:
[Start Error message]
Could not start session: Notebook process exited prematurely with error code: 2. StdErr Output: usage: startNotebook.py [-h] [--debug] [--show-config] [--show-config-json]
                    [--generate-config] [-y] [--allow-root] [--no-browser]

                    [--autoreload] [--script] [--no-script]

                    [--expose-app-in-browser] [--custom-css]

                    [--log-level ServerApp.log_level]

                    [--config ServerApp.config_file] [--ip ServerApp.ip]

                    [--port ServerApp.port]

                    [--port-retries ServerApp.port_retries]

                    [--sock ServerApp.sock]

                    [--sock-mode ServerApp.sock_mode]

                    [--transport KernelManager.transport]

                    [--keyfile ServerApp.keyfile]

                    [--certfile ServerApp.certfile]

                    [--client-ca ServerApp.client_ca]

                    [--notebook-dir ServerApp.root_dir]

                    [--preferred-dir ServerApp.preferred_dir]

                    [--browser ServerApp.browser]

                    [--pylab ServerApp.pylab]

                    [--gateway-url GatewayClient.url]

                    [extra_args [extra_args ...]]

startNotebook.py: error: unrecognized arguments: --no-mathjax
[End Error message]
Running the ‘start notebook server’ command from the console works fine if you manuallly remove the –no-mathjax argument, but I can’t find a file that has this string in AppData or Program Files/AzureDataStudio.
Modifying the file C:\Users<user>\AppData\Local\Programs\Azure Data Studio\resources\app\extensions\notebook\resources\pythonScripts\startNotebook.py
To add these two lines at 2 and 3:
import sys
sys.argv.remove("--no-mathjax")
(Note these lines will produce an error in the logs if the script is called without the –no-mathajax argument)
Causes the notebook server to attempt to run, but hits the version number check, and ADS attempts to re-install the 'correct' versions
Cancel installation, specifically install ipykernel 5.5.5 from the console
Starts the notebook server fine:
But execution fails with the following error:
[Start Error message]
Could not start session: fetch failed
[End Error message]
Azure Data Studio version: azuredatastudio 1.50.0 (49c73a84388731fec941dac8d938345ac16bd470, 2024-11-17T22:41:05.327Z)
OS version: Windows_NT x64 10.0.19045
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
15.66GB (6.68GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

It should be noted that this "same bug" has been happening in previous versions of ADS. I executed the same fix of downgrading the notebook install sometime in August 24 when v1.49 came out. However, the fix was 'stable' -  it lasted until the release of v1.50.
The new development is that v1.50 appears to be doing the python module version check on launch every time, meaning that you have to do the notebook re-install and changes every time - which is really vexing.

Thank you for this stable workaround @Sunspark , I've tried other solutions but this is the only one that works consistently.


fix: fixing remote spire agent docker file to resolve build issues

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

Updated docker file as per review comments, validated with device usb service. able to build remote spire agent successfully and device usb service started successfully on remote node

Tried without @bnevis-i without arg for Builder base, it builds successfully and device service started.
So i updated my commit according to Lenny's comments.

@bnevis-i without arg for Builder base, it builds successfully and device service started. So i updated my commit according to Lenny's comments.

Ok.  If it fails in CI we can always put it back.

Ok. If it fails in CI we can always put it back.

No Ci on this repo... ;-)


A vm machine running on IDC env.
Steps to reproduce

start a TiDB cluster using tidb-ansible

$ git diff
diff --git a/inventory.ini b/inventory.ini
-wait_replication = True
+wait_replication = False

load data

[tidb@localhost go-ycsb]$ cat global.conf
recordcount=10000000
operationcount=100000
workload=core
fieldcount=10
fieldlength=100

./bin/go-ycsb load tikv -P global.conf -p tikv.type=raw -p tikv.pd=<IP_ADDRESS>:2379

restart TiDB cluster

$ ansible-playbook stop.yml && ansible-playbook start.yml

What did you expect?
Restart cluster successfully.
What did happened?
TiKV and PD restart successfully but TiDB.
TASK [start TiDB by supervise] **************************************************************************************

TASK [start TiDB by systemd] ****************************************************************************************
changed: [<IP_ADDRESS>]

TASK [wait until the TiDB port is up] *******************************************************************************
fatal: [<IP_ADDRESS>]: FAILED! => changed=false
  elapsed: 300
  msg: the TiDB port 4000 is not up
	to retry, use: --limit @/home/tidb/tidb-ansible/retry_files/start.retry

PLAY RECAP **********************************************************************************************************
<IP_ADDRESS>                : ok=30   changed=8    unreachable=0    failed=1
localhost                  : ok=8    changed=5    unreachable=0    failed=0

ERROR MESSAGE SUMMARY ***********************************************************************************************
[<IP_ADDRESS>]: Ansible Failed! ==>
  changed=false
  elapsed: 300
  msg: the TiDB port 4000 is not up

tidb.log
pd.log
tikv.log

I suspect there are some incompatible changes in TiDB, TiKV or PD. Can you use all the latest version?

I suspect there are some incompatible changes in TiDB, TiKV or PD. Can you use all the latest version?

I use the latest version to test again, but fails again.

And I tested the august versions but also failed.

I will take a deep look today.

Oh. I found it https://github.com/pingcap/tidb/issues/11271#issuecomment-511713028. @mahjonp

Thank you. @youjiali1995


NPM package build has extra files

When we publish to NPM we don't need to publish our test and linting files

:tada: This issue has been resolved in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bug: Keep Raining also Weather always dark like cloudy not clear immortal day thing

What happened?
raining
Mod Version
latest
Fabric API Version
No response
Relevant log output
No response
Other mods
No response
Additional Information
No response

It does rain sometimes

Not a bug, it do be raining


Pass SA's token to server to avoid login screen

The scenario I'm working on is running k8sdash as an internal dashboard. The service will be exposed on an internal IP address (running AKS if it matters). I am using a low-permission cluster role for the service so it doesn't expose configs and secrets.
Given this, what I'm looking to do is have the dashboard load with the service account's token automatically. I'd rather not explain to users how to get the secret, decode the value, and paste the token in. In fact, most users don't have the ability to even view secrets.
Is there is a way to the service account token directly to the server? I didn't see any arguments or environment variables for this purpose, but I may have missed it.
Thanks for building this!

If you pass an Authorization header with a valid "Bearer" token, the server will pass it to the client (via a cookie) and the client will then use that for authentication. Will that work for your purposes?

I might be able to make that work. What I was hoping for was a way to pass an environment variable or argument with the token from the secret, and have the server use that for everything. That way they only need to load the page, and not worry about authorization.
If this isn't possible, is it something you'd consider accepting in a PR?

I see w what you’re saying. Yeah I’d definitely take a PR for something like that!

On Apr 23, 2020, at 3:42 PM, erick-thompson<EMAIL_ADDRESS>wrote:

I might be able to make that work. What I was hoping for was a way to pass an environment variable or argument with the token from the secret, and have the server use that for everything. That way they only need to load the page, and not worry about authorization.
If this isn't possible, is it something you'd consider accepting in a PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


#344 Added parameter --include-up-to-date to list all dependencies including the ones that do not need upgrades

Added support for a command line parameter --include-up-to-date to list all dependencies including the ones that do not need upgrades as detailed in #344
Example
dotnet-outdated.exe -t --include-up-to-date
» aspnettest
  [net7.0]
  Microsoft.AspNetCore.OpenApi                    7.0.8 == 7.0.8
  Microsoft.Extensions.ApiDescription.Server [T]  6.0.5 -> 7.0.8
  Microsoft.OpenApi [T]                           1.4.3 -> 1.6.5
  Swashbuckle.AspNetCore                          6.4.0 -> 6.5.0
  Swashbuckle.AspNetCore.Swagger [T]              6.4.0 -> 6.5.0
  Swashbuckle.AspNetCore.SwaggerGen [T]           6.4.0 -> 6.5.0
  Swashbuckle.AspNetCore.SwaggerUI [T]            6.4.0 -> 6.5.0

Version color legend:
<red>   : Major version update or pre-release version. Possible breaking changes.
<yellow>: Minor version update. Backwards-compatible features added.
<green> : Patch version update. Backwards-compatible bug fixes.

You can upgrade packages to the latest version by passing the -u or -u:prompt option.
Elapsed: 00:00:01.7981915

@slang25 The release notes for this change for v4.5.3 still mention a new --all parameter to have been added as they are generated from the commit messages which hasn't been updated in this PR to reflect the new argument name. Could the GitHub Release notes be edited to mention the correct -utd|--include-up-to-date instead? I was slightly confused at first wanting to try this out before having a look a the --help output. ;)

Thanks @prettybits, I hadn't considered that. I've updated the release notes and the issue here.


fix: show custom check-command

just realized this is a lot cleaner and actually shows something on a custom command,
also debugged it this time.

bors r+


Add travis once in for all

@Masquerade0097 @ritzvik @spino17  I would expect a green tick like this on every PR we make


Update parse_test_res.py to fix end_signal

Current parse_test_res.py is not working well because of the wrong end_signal, which needs to be changed to Finish training

Good spot! Forgot to update the parse code when updating Dassl.pytorch.


iOS Privacy Policy

Apple says "Starting May 1: You'll need to include approved reasons for the listed APIs used by your app's code to upload a new or updated app to App Store Connect."
Please add privacy policy otherwise we couldn't use this library.

Hello @sagarthecoder, from what I gather, the package and code appear to be independent of any API referenced in Apple's documentation. Could you specify which API necessitates the privacy manifest file and is utilized in this package? Thank you.


Tray issues

Describe the bug
When I use the tray icon from nm-applet,

The icons don't get updated (for example the icon should become a lock when a VPN is enabled but this doesn't happen until I restart the bar)

There are no checkboxes (each of the three vpn connections is supposed to have a checkbox to its left)

The bar crashes after some time of interacting with tray items:
https://paste.sr.ht/~p00f/6c6afbfd14a1aacaee2ba6d49cb9e582323eded4

Clicking buttons doesn't work in the main dropdown

To Reproduce
Steps to reproduce the behavior:

Run nm-applet --indicator
Right click the tray item, "Enable networking" and "Enable Wi-Fi" don't have checkboxes next to them.
Clicking "enable networking" doesn't toggle network (clicking vpn connections > some connection does toggle that connect though)
Interact with the menu items for some time, the bar crashes

System information:

Distro: Arch Linux
Compositor: River
Ironbar version: d4dd8 + my upower commit (I hope that's not relevant)

Configuration

Share your bar configuration and stylesheet as applicable:

Config
position: "top"
height: 25
start:
  - type: "focused"
    show_icon: true
    show_title: true
    truncate: "end"
center:
  - type: "clock"
    format: "%a %d            %H:%M"
end:
  - type: "upower"
    format: "icon:{icon} {percentage}%"
  - type: "tray"

Styles
.background {
    background-color: black;
}

#bar {
    background-color: black;
}

#focused {
    font-size: 17px;
    font-weight: bold;
}

#clock {
    font-size: 17px;
    font-weight: bold;
}

Paging @oknozor. This looks like the error is  coming from stray. I am not sure if the other problems are ones you're aware of / looking at in #65?

I am pretty sure this is related to the gtk view implementation, I had a similar issues trying to implement system tray for eww (see: https://github.com/elkowar/eww/pull/448). Unfortunately I short on time these days and lack the gtk-rs knowledge to fix this.
If I recall correctly this require a custom implementation of MenuModel. Maybe a a seasoned gtk developer could help here ?

Apologies it took me so long to get round to this one, but I've finally had the time/patience to dive into this one and give it the attention it deserves.
I've almost entirely rewritten the module, which fixes all of the above issues. I've also made some changes to the underlying library to fix a few issues, and the module should be much more robust now. It still isn't perfect, but it's a lot better than it was.
The rewrite should also come with some serious performance gains for the module. Previously the entire menu UI was recreated for every update (every image change is an update, which for nm-applet meant every animation of connecting/disconnecting), whereas now it will do a diff and efficiently update only what needs changing. It's ended up working in much the same way React does, which is kinda cool I guess.


Add 'virtualenv_dir' param to 'Execution Config' docs

Add missing virtualenv_dir param introduced in PR #1079
to the Execution Config docs. Also say that it's added in v1.6
closes: #1172

The docs preview job is failing due to OL dependency issue. Maciej is looking into resolving the release bug.
More context in Astronomer Slack: https://astronomer.slack.com/archives/CGQSYG25V/p1724420009082419


Discord_RegisterW isn't writing to registry.

Seems my apps, even with the latest source from here, do not write the URL protocols to the registry (SOFTWARE\Classes\Discord-<APPID> isn't being written). Unsure of why this is. Cannot seem to get any output from stderr to see what is going on. The applications are written in C++, and are compiled with MinGW.

Hmm, even after fixing this and getting the proper registry keys, it still says "Game not detected" when trying to send invites or in the game activity menu in Discord's settings.

Hmm, even after fixing this and getting the proper registry keys, it still says "Game not detected" when trying to send invites or in the game activity menu in Discord's settings.


remove sa_handle

Passing the flag SA_SIGINFO means that we use sa_sigaction to handle the interrupt instead of .sa_handler. Although it seems to work well in the program, it may lead to some misunderstanding.

Thank @ruiqurm for contributing!


App creating sub-directories with underlined filenames

I installed the 2.2 binaries and ran the app, and downloaded the files in a new folder for a quick comparison with the files downloaded using the previous version. I've found two probably undesired behaviours, one of them I'm reporting on this ticket: when reddsaver tries to download files whose post titles contain underlines, a new sub-directory (sometimes 2 nested sub-directories) are created, like this (download directory is ./folders_02):
~/reddsaver 2.2/folders_02/osr/face_folio_|a_little_preview_of_some_concept_sketches(100_pc/underlined_filename.jpg
The files end up in the nested sub-directory, though.

Thanks for raising this issue. Would you be able to share the link to the Reddit post corresponding to the file name you’ve shared? This would help with reproducing the bug and testing the (future) fixes.

Thanks for raising this issue. Would you be able to share the link to the Reddit post corresponding to the file name you’ve shared? This would help with reproducing the bug and testing the (future) fixes.

Here it is:
https://www.reddit.com/r/osr/comments/k5zeyi/face_folio_a_little_preview_of_some_concept/
Guess the underlines are not related to this bug, the original title "Face Folio | a little preview of some concept sketches (100 PC/NPC portraits for your RPG game; Zine Quest 2)" has no underlines..

Here it is:
https://www.reddit.com/r/osr/comments/k5zeyi/face_folio_a_little_preview_of_some_concept/
Guess the underlines are not related to this bug, the original title "Face Folio | a little preview of some concept sketches (100 PC/NPC portraits for your RPG game; Zine Quest 2)" has no underlines..

I think the issue is because of / in the post’s title. I’ll verify this and if so it should be an easy fix

I think the issue is because of / in the post’s title. I’ll verify this and if so it should be an easy fix

@CitronSorcier I've release v0.2.3 with fixes for #6 and #7  - please check if the issues you encountered are resolved when you get a chance.

@CitronSorcier I've release v0.2.3 with fixes for #6 and #7  - please check if the issues you encountered are resolved when you get a chance.


RuntimeError: No stable configuration of concrete packages could be found for the given constraints after 16 rounds of resolving.

RuntimeError: No stable configuration of concrete packages could be found for the given constraints after 16 rounds of resolving.
When pipenv install google-cloud
Describe your environment

MacOS High Sierra
Python version: 2.7
Pipenv version: 8.3.2

Expected result
To install it.
Actual result
Adding google-cloud to Pipfile's [packages]…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Traceback (most recent call last):
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/bin/pipenv", line 9, in <module>
    load_entry_point('pipenv==8.3.2', 'console_scripts', 'pipenv')()
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/cli.py", line 1935, in install
    do_lock(system=system, pre=pre)
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/cli.py", line 1121, in do_lock
    pre=pre
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/utils.py", line 461, in resolve_deps
    resolved_tree.update(resolver.resolve(max_rounds=PIPENV_MAX_ROUNDS))
  File "/Users/aleskocur-rubicoin/Library/Python/2.7/lib/python/site-packages/pipenv/patched/piptools/resolver.py", line 98, in resolve
    'This is likely a bug.' % max_rounds)
RuntimeError: No stable configuration of concrete packages could be found for the given constraints after 16 rounds of resolving.
This is likely a bug.

Steps to replicate
run pipenv install google-cloud

Hi @kafejo, thanks for using pipenv.
I'll need the output of pipenv lock --verbose --clear to take a look at what's going on.

@kafejo also please make sure you have set LANG and LC_ALL to a proper utf-8 compatible setting on your terminal (this is a known issue with mac) as this may resolve any issue you encounter

I'm debugging similar issues with another package so I tested this issue and found the same problem, however @techalchemy's suggestion resolved the issue.

Mac Sierra (10.12.6)
pipenv  8.3.2
python 2.7 (Mac's default build)
LANG=en_US.UTF-8
LC_ALL=

Repro
pipenv install google-cloud
...
RuntimeError: No stable configuration of concrete packages could be found for the given constraints after 16 rounds of resolving.
This is likely a bug.

Then set LC_ALL
export LC_ALL=en_US.UTF-8
pipenv install google-cloud
...
Adding google-cloud to Pipfile's [packages]…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Updated Pipfile.lock (######)!

Then unset LC_ALL and installed with python3
export LC_ALL=
pipenv --three install google-cloud
...
Adding google-cloud to Pipfile's [packages]…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
Updated Pipfile.lock (######)!

Really loving pipenv.
I wasn't able to get past this using the instructions above.
It only seemed to work after installing the dependencies and then running pipenv lock after.

pipenv install --skip-locked
pipenv lock --verbose --clear


[URGENT]

User Story
Due to DXC exit infrastructure had been decommissioned and resulted azure.hmpp.root unresolvable. As a part of the major incident response we have been asked to add below record urgently in order to direct DNS queries to Azure Landing Zone
Value / Purpose

azure.hmpp.root
<IP_ADDRESS><IP_ADDRESS>
forward queries to Azure Landing Zones

Useful Contacts
Matt White
Additional Information
Major incident ref INC2105932
Definition of Done

[x] Zone created and infrastructure redeployed
[ ] Another team member has reviewed
[ ] Tests are green

record added and infrastructure redeployed

<IP_ADDRESS> and <IP_ADDRESS> are reachable now but I will update the zone tomorrow

all 4 zones are added


Drama List Error

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'Drama List'
Click on 'Korean'
Click on 'Year'
Click on '2023'
Click on 'OK'
Results in 'DramaCool Error'

Expected behavior
A list of shows matching the selected search criteria
Log file
2023-07-16 16:57:15.266 T:30548   error : Repository add-on repository.universalscrapers does not have any directory and won't be able to update/serve addons! Please fix the addon.xml definition
2023-07-16 16:57:18.438 T:14692   error : Control 55 in window 10025 has been asked to focus, but it can't
2023-07-16 16:57:23.566 T:32688    info : [script.module.xbmcext] Routing "/drama"
2023-07-16 16:57:23.567 T:32688    info : [script.module.xbmcext] Calling "drama"
2023-07-16 16:57:31.016 T:34364    info : [script.module.xbmcext] Routing "/category/korean-drama"
2023-07-16 16:57:31.017 T:34364    info : [script.module.xbmcext] Calling "drama_filter"
2023-07-16 16:57:31.033 T:14692    info : Loading skin file: C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.xbmcext.\resources\skins\Default\1080i\MultiSelectTabDialog.xml, load type: LOAD_ON_GUI_INIT
2023-07-16 16:57:42.990 T:34364    info : [script.module.xbmcext] Routing "/category/korean-drama/[]/[]/[]/["2023"]"
2023-07-16 16:57:42.991 T:34364    info : [script.module.xbmcext] Calling "drama_list"
2023-07-16 16:57:43.000 T:34364   error : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'NameError'>
Error Contents: name 'e' is not defined
Traceback (most recent call last):
File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee.\peewee.py", line 3237, in execute_sql
cursor.execute(sql, params or ())
sqlite3.OperationalError: ON CONFLICT clause does not match any PRIMARY KEY or UNIQUE constraint
                                               During handling of the above exception, another exception occurred:

                                               Traceback (most recent call last):
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\plugin.video.dramacool\dramacool\addon.py", line 243, in drama_list
                                                   RecentFilter.insert(path=plugin.path, title=plugin.path).on_conflict(
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 1962, in inner
                                                   return method(self, database, *args, **kwargs)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 2033, in execute
                                                   return self._execute(database)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 2838, in _execute
                                                   return super(Insert, self)._execute(database)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 2551, in _execute
                                                   cursor = database.execute(self)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 3250, in execute
                                                   return self.execute_sql(sql, params, commit=commit)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 3244, in execute_sql
                                                   self.commit()
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 3010, in __exit__
                                                   reraise(new_type, new_type(exc_value, *exc_args), traceback)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 192, in reraise
                                                   raise value.with_traceback(tb)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.peewee\.\peewee.py", line 3237, in execute_sql
                                                   cursor.execute(sql, params or ())
                                               peewee.OperationalError: ON CONFLICT clause does not match any PRIMARY KEY or UNIQUE constraint

                                               During handling of the above exception, another exception occurred:

                                               Traceback (most recent call last):
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\plugin.video.dramacool\dramacool\addon.py", line 359, in <module>
                                                   plugin()
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.xbmcext\.\xbmcext\__init__.py", line 489, in __call__
                                                   function(**kwargs)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\plugin.video.dramacool\dramacool\addon.py", line 222, in drama_filter
                                                   plugin.redirect(f'{plugin.path}/{characters}/{genres}/{statuses}/{years}')
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.xbmcext\.\xbmcext\__init__.py", line 586, in redirect
                                                   self()
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\script.module.xbmcext\.\xbmcext\__init__.py", line 489, in __call__
                                                   function(**kwargs)
                                                 File "C:\Users\rk609048\AppData\Roaming\Kodi\addons\plugin.video.dramacool\dramacool\addon.py", line 245, in drama_list
                                                   except e:
                                               NameError: name 'e' is not defined
                                               -->End of Python script error report<--

2023-07-16 16:57:43.003 T:28312    info : CActiveAESink::OpenSink - initialize sink
2023-07-16 16:57:43.152 T:24832   error : XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.video.dramacool/category/korean-drama
2023-07-16 16:57:43.163 T:14692   error : CGUIMediaWindow::GetDirectory(plugin://plugin.video.dramacool/category/korean-drama) failed
Additional context
Add any other context about the problem here.

This might be an issue with the database due to recent change in table. A workaround is to remove the old database file in userdata.

I reinstalled the addon and that corrected the problem.


feat: caching bodies to avoid unnecessary object creation

Description
Allow for body caching if no new bodies have been added. This reduces the amount of time we spend on object creation...
Issue linked
None
Checklist

[X] I have tested my changes locally.
[X] I have added necessary documentation or updated existing documentation.
[X] I have followed the coding style guidelines of this project.
[X] I have added appropriate unit tests.
[X] I have reviewed my changes before submitting this pull request.
[X] I have linked the issue or issues that are solved to the PR if any.
[X] I have assigned this PR to myself.
[X] I have added the minimum version decorator to any new backend method implemented.
[X] I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Needs investigation from my side... let's see what's going on.

Okay so, on body deletion we also need to clear the cache. That was missing - my bad. Ready to go now!


Develop Pipes

It might be a good idea to have the pipes themselves be responsible for simple synchronization without any blocking, given that blocking would involve the scheduler and these pipes are designed so they can be also used internally by the kernel (aka not a process).
A read syscall would then look something like this:
void sys_read_handler(int fd, void* buf, size_t count) {
    TPipe target = getPipeFromFdTableOrWhatever(fd);
    while (pipe_read(target, buf, count) == 0)
        sch_blockCurrentProcesssUntilSomebodyWakesMeUp();
}

Hey Thomas, this looks nice.
Perhaps we should maintain our code documentation style as usual using doxygen format. Check lib.h.

These are pretty much done except for the fact that they have no synchronization


MNIST example cannot run on the spark-2.2.0

After I deployed the spark-2.2.0, failed to run the script of the mnist example.
The script is the GetStarted_YARN .  See the script detail at the following.
It is OK un the spark 2.1.1 , but it is failure on spark-2.2.0 .
Thanks for you help!
The error is :  /home/xxx/Python/bin/python  not found.
Script:
export PYTHON_ROOT=~/Python
export LD_LIBRARY_PATH=${PATH}
export PYSPARK_PYTHON=${PYTHON_ROOT}/bin/python
export SPARK_YARN_USER_ENV="PYSPARK_PYTHON=Python/bin/python"
export PATH=${PYTHON_ROOT}/bin/:$PATH
export QUEUE=default
${SPARK_HOME}/bin/spark-submit
--master yarn
--deploy-mode cluster
--queue ${QUEUE}
--num-executors 4
--executor-memory 4G
--archives hdfs:///user/${USER}/Python.zip#Python,mnist/mnist.zip#mnist
TensorFlowOnSpark/examples/mnist/mnist_data_setup.py
--output mnist/csv
--format csv

Also in my case slaves couldn't read Python.zip from hdfs so I scp to slaves the ~Python directory and then executed to master:
export PYTHON_ROOT=/root/Python
export LD_LIBRARY_PATH=${PATH}
export PYSPARK_PYTHON=${PYTHON_ROOT}/bin/python
export SPARK_YARN_USER_ENV="PYSPARK_PYTHON=Python/bin/python"
export PATH=${PYTHON_ROOT}/bin/:$PATH
export QUEUE=default
spark-submit
--master yarn
--deploy-mode cluster
--queue ${QUEUE}
--num-executors 4
--executor-memory 4G
--archives hdfs:///Python.zip#Python,/root/mnist/mnist.zip#mnist
/root/TensorFlowOnSpark/examples/mnist/mnist_data_setup.py
--output mnist/csv
--format csv
Hope this helped

Unfortunately, I don't have a 2.2 cluster readily available to confirm/debug.  Can you check if the files are being copied into your cluster?  For instance, is the the mnist.zip archive being successfully copied/consumed?  Finally, if you want, you can send me the full yarn logs<EMAIL_ADDRESS>so I can investigate further.

I was finally able to test with Spark 2.2, and it looks like it's due to a difference in how the PYSPARK_PYTHON is used (or not) by the different versions of Spark.  Basically, for @supermig 's original instructions above, you should be able to just use the following:
export PYSPARK_PYTHON=./Python

@leewyang Thanks.
I modified my shell script following the new GetStarted_YARN .
Changed
export PYTHON_ROOT=**~**/Python
to
export PYTHON_ROOT=**.**/Python
It works well.


handle end when there's content remaining on the line correctly

Motivation
The current behavior of the automatic end on type is unpredictable and strange. It appends the end in weird spots and leaves the cursor in a strange location.
Some examples:
If there's content on the line, the end is inserted and the remaining content is appended after the new end:

If there's a set of parens and you expand to a newline, it puts autocompletes the end inside the paren:

I encounter this most often when breaking sigs up onto multiple lines

Or when attempting to break up the list of parameters:

Or when breaking up lines with long conditions:

Implementation
The current logic is a little bit mystical to me. I'm not sure why the conditions are what they are, and I couldn't find a reasonable way to tweak it to be more reasonable.
My expectation as a user is that if I hit enter, anything after my cursor on the line should always be appended within the autocorrected end block, and my cursor should be left at the beginning of the new line. There's no other natural behavior here.
The complexity is that there is some odd behavior in the parser or in the other auto-correcting behavior from the LSP itself which causes the lines provided to the handle_statement_end to behave differently.

If the next character is not a ), then the current line is what you would expect.
If the next character is a ), then the current line terminates at the last position, and the next line is whatever content was remaining on the line before the user entered the newline character.

In either case, the user wants the same behavior - all of the remaining content on the line should occur before the autocorrected end, and the cursor should be at the beginning of the new line they just created.
Automated Tests
I couldn't quickly figure out how to get the existing unit tests to run, but I'm thinking they should all pass first try if they're well written. I'd be happy to add additional unit tests here to test more advanced cases.
Manual Tests
Started ruby-lsp in debug mode. Here are some results from the new code.
Breaking up content:

If there's a set of parens and you expand to a newline:

breaking sigs up onto multiple lines

Or when attempting to break up the list of parameters:

Or when breaking up lines with long conditions:

I'm looking at https://github.com/Shopify/ruby-lsp/pull/1231 from @vinistock and seeing that there are actually two cases here.
Although I do agree that the existing behavior makes more sense in his case:
foo(proc do )

becomes
foo(proc do

  end
)

I would argue the case I'm solving for is more typical:
if foo()

becomes
if foo(
  )
end

The proper fix here would actually to be to look back to the ordering of the keyword and the paren and then use that to determine if the next paren should appear before or after the end, but we're getting into some pretty complex parsing at that point which this approach (lines & positions) feels a bit too unsophisticated to handle. The right approach here may to be to actually use the AST and try to figure out what the correct auto-complete is from that representation.


No testing rules?

You have installed mocha, and have a npm run test in place, but no actual testing rules setup?

Thought Mocha had some default options. Should have read the manual. :taco:

So you added rules / fixed it?
Closing issues without resolutions? <3

I chose to remove the package, because I should read the docs first to get a good grasp of writing the rules when my schedule permits me to.

Gotcha! Small tip for next time, reference the issue in the commit where you solve it. That way, it shows up on the issue page 😄
https://help.github.com/articles/closing-issues-using-keywords/


Allow any column as the upsert comparison column

Description
https://github.com/apache/pinot/issues/6523
Today upsert uses the time column for comparison. This PR allows using any column for comparison, such as the kafka offset.
Release Notes
This PR introduces a new optional field comparisonColumn  under upsert config for specifying the column used for upsert comparison. When this is not provided, the time column is used as default.

Codecov Report

Merging #7200 (882e83d) into master (a0ad49d) will decrease coverage by 8.29%.
The diff coverage is 69.73%.

@@             Coverage Diff              @@
##             master    #7200      +/-   ##
============================================
- Coverage     73.49%   65.20%   -8.30%
  Complexity       92       92
============================================
  Files          1506     1506
  Lines         73808    73836      +28
  Branches      10650    10658       +8
============================================
- Hits          54243    48142    -6101
- Misses        16026    22287    +6261
+ Partials       3539     3407     -132

Flag
Coverage Δ

integration
?

unittests
65.20% <69.73%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ata/manager/realtime/RealtimeTableDataManager.java
10.56% <0.00%> (-56.51%)
:arrow_down:

...he/pinot/segment/local/utils/TableConfigUtils.java
78.22% <0.00%> (-3.89%)
:arrow_down:

...va/org/apache/pinot/controller/ControllerConf.java
54.50% <72.00%> (+1.64%)
:arrow_up:

...manager/realtime/LLRealtimeSegmentDataManager.java
47.18% <100.00%> (-26.02%)
:arrow_down:

...local/indexsegment/mutable/MutableSegmentImpl.java
67.12% <100.00%> (-11.54%)
:arrow_down:

...ent/local/realtime/impl/RealtimeSegmentConfig.java
92.43% <100.00%> (-6.70%)
:arrow_down:

...org/apache/pinot/spi/config/table/TableConfig.java
83.09% <100.00%> (+0.24%)
:arrow_up:

...rg/apache/pinot/spi/config/table/UpsertConfig.java
86.66% <100.00%> (+2.05%)
:arrow_up:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c04e1f...882e83d. Read the comment docs.

whats the case where we would prefer timestamp vs offset

@kishoreg offset is just an example. This is to address the community ask in https://github.com/apache/pinot/issues/6523

@Jackie-Jiang makes sense. updated.


build: faile gcc5.x build failed, eg: 5.5

@vpirogov
i test 5.5 have this issue,
but do not test gcc6,
test gcc7 and gcc9 support simdlen

@vpirogov
i test 5.5 have this issue,
test gcc6.1,  gcc7 and gcc9 do not have this issue, support simdlen

Thank you for checking, @haolongzhangm. With that the check should disable simdlen for GCC <= 6.1.

Thank you for checking, @haolongzhangm. With that the check should disable simdlen for GCC <= 6.1.

I think you mean < 6.1

@rsdubtso @vpirogov
I check the gcc release tag, gcc do not have version 6_0
so i think we can  modify the patch as: #if (GNUC <= 5)
pls check
info about gcc release tag:
~/code/gcc$ git tag| grep 6
gcc-3_4_6-release
gcc-4_3_6-release
gcc-4_4_6-release
gcc-4_6_0-release
gcc-4_6_1-release
gcc-4_6_2-release
gcc-4_6_3-release
gcc-4_6_4-release
gcc-6_1_0-release
gcc-6_2_0-release
gcc-6_3_0-release
gcc-6_4_0-release
gcc-6_5_0-release

This makes sense. One more consideration to be aware of is that CLANG and Intel Compiler define __GNUC__ macro as well. For example ICC 17.0 that does have OpenMP 4.5 support reports the following:
$ icc --version
icc (ICC) 17.0.8 20181031
Copyright (C) 1985-2018 Intel Corporation.  All rights reserved.

$ icc -# hello.c 2>&1 | grep GNUC
    -D__GNUC_GNU_INLINE__ \
    -D__GNUC__=4 \
    -D__GNUC_MINOR__=8 \
    -D__GNUC_PATCHLEVEL__=5 \

With that the check you propose will disable simdlen for ICC or CLANG when older GCC is installed in the system, which should not be the case.

@haolongzhangm,
We discussed this some more with @rsdubtso. To fix the issue properly without introducing degradations the patch should check compiler vendor and version to identify the OpenMP standard supported correctly:

Compiler
OpenMP 4.0
OpenMP 4.5

Intel
>=15.0
>=17.0

Clang
>= 3.3
>= 3.9

GCC
>= 4.9
>= 6.1

MSVS
N/A
N/A

If you would like to work on this please let me know. Otherwise I would ask someone from the team to implement the fix and close this PR.

@vpirogov
OK, pls close this PR, then fix this issue inside u team, ths!

Thank you for the report and help with the investigation, @haolongzhangm!

Fix is implemented in a4209e093c5cde10011607a820e2098cef0ae002.


Some error in installation instruction

Hi, thank for you great work. Here's some error in tutorial (in bold):
POINT 4: Go to Mudlet, type #TELEGRAM TOKEN <paste_the_token_here>
POINT 7: Try a command like 'look'. The bot reply telling you: User 'XXXXXXX' not authorized
POINT 8: In Mudlet you should now see a message about unauthorized user, run the command #TELEGRAM AUTH XXXXXXX
POINT 9: In Mudlet, also try '#TELEGRAM TELL XXXXXXX message' and it should show up in Telegram
That can help some people easy config the system

Thanks! Ill update the readme!

Done


Has recently stopped working when executing comb command

Let me know if I can provide any form of diagnostics. Output in VSCode doesn't display anything after running csscomb.

Sorry for this situation.
This problem related only for<EMAIL_ADDRESS>(3.2.5 works fine) version and will be fixed in 4.0.0` version.
I'll update this extension today.

ok, thanks.

temporary solution. You can remove vscode-csscomb plugin, then download .vsix file from https://github.com/mrmlnc/vscode-csscomb/releases/tag/3.2.5 and install it:

If update is coming soon, I can wait. I'm just mentally tagging my files with "needs combing" at the moment :)

Should be fixed in 4.0.0 👍


Viewer does not resend SDP offer if master receives SDP offer but fails to send answer

In my code, the "viewer" side of the WebRTC call uses the KVSWebRTC.SignalingClient.sendSdpOffer function to send an SDP offer, and the "master" side of the call listens for "sdpOffer" events and reacts to them by calling KVSWebRTC.SignalingClient.sendSdpAnswer.
This usually all works fine. But I've found that the following sequence of events can happen:

The viewer user opens the webpage, then sends an SDP offer
The master user opens the webpage, and receives the SDP offer
Before the master side can send an SDP answer, the master user refreshes the page
The master user tries to rejoin the call, but no longer receives any SDP offer event - it's as if the offer has been swallowed by the original aborted session. The connection can only be made if the viewer side makes a new SDP offer.

Am I correct in thinking that the SDP offer is "consumed" when the master side signalling client first fires the "sdpOffer" event?
What's the appropriate way to handle this? Is the viewer side supposed to speculatively make fresh SDP offers every few seconds, in case the above sequence of events has occurred? Is there any way for the viewer side to know that their SDP offer has been lost?
(I also asked this on StackOverflow: https://stackoverflow.com/questions/72690321/how-do-i-rescue-my-webrtc-connection-when-my-sdp-offer-is-swallowed)

@fblundun ,
You are correct. The master connection needs to be opened first so that the offer sent by the viewer can be consumed. If you refresh the master page, the viewer needs to resend the offer. This kind of handshake mechanism will have to be incorporated outside of the realm of WebRTC. You can have some kind of=handshake message between master and viewer to allow this.


Block gesture inputs

When performing a touch gesture, Such as a bottom one.
If the gesture is active (Triggered) block the touch input from going to the underlying program
Current behavior:
Start swiping from the bottom
Screen starts shifting workspaces
Program receives touch inputs and performs touchy things
Desired behavior:
Start swiping from the bottom
Screen starts shifting workspaces
Program has no clue you ever did something or that the input got cut off (Focus loss)
No clue if this is possible though

currently we:

block touch events going to the window as soon as we recognize a gesture (for a edge swipe, after you swipe a bit, it blocks touch events then begins the workspace swipe thingy)
send a touch up event when you lift a finger

This does work on my machine, so... gonna need you to reconfirm what you saw is breaking what I described
small note: the correct thing to do is to send a "cancel" event to the window but that crashed on me last I tried it, and I never bothered  to look into it

Weird.. haven't noticed this working myself
A good example of where i notice touch events still going through would be my app launcher (sysmenu) which has a swipe up to open gesture (layer shell and whatnot)
Whenever i swipe it used to detect touch inputs and thus begin the opening animation
Another place i noticed this would be the OSK i use (wvkbd) it would usually press the spacebar if i were to start swiping from the bottom
Have not had time to re test any of this so it might have been fixed with the margins update

Ah, in the first case it's my bad, for normal hyprgrass-bind actions events don't get blocked, I'll come up with a solution
In the second case the cancel event I mentioned before should fix it, will give it a go another time

Awesome!
In the mean time i've resorted to adding a margin blocker on my app launcher and written a new OSK with bottom padding
I wonder if only layer shells are affected because i've only noticed those being affected


Improve worktree tests

Description
Random directories for worktree tests

Thank you for looping back and reworking these tests.  This is a good catch. While I don't have time for a full review at the moment, I was wondering if you had considered using Dir.mktmpdir instead of implementing your own way of doing the same thing?

Just noting this code is already used in test_helper.rb and test_diff_non_default_encoding.rb
Will have a look at changing over.

Dir.mktmpdir becomes really weird with these testing cases, as they explicitly control creating and deleting the directory.
It makes it really hacky and unreadable using that...
I think it's not a good case for it for at least test_worktree_add_and_remove and test_worktree_prune tests.

I think I lost the point of this PR. The problem it is trying to fix is not described. Since the tests seem to be working fine, I am closing the PR without merging it.


system prompt file parsing

I'm exploring function calling with Hermes-2-Pro-Llama-3-8B and following the recent research group video demonstration using agent studio plugin interface. I am wondering how the prompt text file (/data/prompts/nous_system.txt) is parsed into the system prompt. I see there some variables (TOOL_DOCS, GEOLOCATION, DATE) dereferenced in the file, but I can't find where the magic happens to substitute these values. The tools are not being populated. The location is correct. The month and day of the week are correct, but the date is off. Can you clarify this? Thank you!

Update: I guess the variables names are case lowered and used to call tool functions. The issue with the date is just a typo in the Clock.time method (%-m to %-d) to get day and not month. And in the location tool, the geolocation method needs a 'self' in the signature for the plugin to load in agent studio. I see where tool_docs is under construction, and that's an easy cut and paste. All working fine now. Peace.


image-only: fix aspect ratio of canvas drawing

fixes #511

Coverage increased (+0.2%) to 75.472% when pulling 33a6b23413c095af6036d4b5804f41ab11877dfc on image-stretch-511 into 58c631622a84edfe207f44e7b51f0dd84007b3ca on master.


collection owner cannot add himself as contributor to his own collection (bug 592857)

https://bugzilla.mozilla.org/show_bug.cgi?id=592857
It was possible for collection owners to add themselves as contributors, which is contradictory.

Added test to check data-owner.
Please review.

Changes made. Please review.

823bb44


Miss a real example in README

Think it's a good idea to add a real example into README, how to use it.
Something like this:
pipx install ansitoimg
ls --color=always /etc | ansitoimg ls.svg
git diff --color=always | ansitoimg diff.svg

Fixed in https://github.com/FHPythonUtils/AnsiToImg/commit/ba0080203d2fe153b1269aa5f3a4daed5df300fc


Improper weighting of models upon importing to BCMDL

Hello, there is a specific issue I am having with importing models to Mario Kart 7.
Within Blender, everything is fine. But with the import within CTR Studio, it seems that it weights every piece of geometry to one bone, but only on certain bones (e.g. the spine bone has the whole model weighted when it is not supposed to.) Other bones are unaffected; it seems to be happening with only one bone.
Image shown below for clarification on the issue.

I belive this is more of a viewing bug with weights as a vertex cannot be rigged fully by multiple bones. Could you select an animation to test the rig?

The animations seem to be working fine, all segments of the model move depending on the rig. Seems like it is a bug in viewing the model in the weights shading mode.
Testing in-game now, seeing if more problems occur or not.

Tested in-game, works without issues. Seems like it was truly just a visual bug.