How to enable laravel modules with multi-tenant

Hello
i try use this package:
https://github.com/tenancy/multi-tenant
to enable Laravel modules and mutli tenant
if system (app) has multi websites with multi databases
when i create new tenant it does not run migrations in other modules
thank you in advance

hi,
I don't know what you mean by "run migrations in other modules".
There's only migrations in the application. If this package has migrations, they will run for the whole app.

Hey, @nWidart
thank you for reading my issue.
i did installed Laravel modules and i like it alot  i used to work with asgardCms .
my problem
i installed https://github.com/tenancy/multi-tenant
when i do create new tenant (new database) using
php artisan tenant:create foo "Billy Bob"<EMAIL_ADDRESS>it does run all migrations under database/migrations/tenant for the new website(new database)
but it does not run any other migrations under any other modules like follwoing:
modules/User/Database/Migartions/*
i dont know how i run migrations in other modules when i create new tenant
Thank you in advance

You would have to run the module:migrate command.

### Its work
function loadPaths()
    {
        $module = json_decode(file_get_contents(base_path('modules_statuses.json')), true);

        $paths = [];
        foreach (glob( base_path('Modules/*/Database/Migrations') ) as $filename) {
            foreach ($module as $key => $value) {
                if(Str::contains($filename, 'Modules/'. $key ) && $value == true ){
                    array_push($paths, $filename);
                }

            }

        }
        array_push($paths, database_path('migrations/tenant'));
        return $paths;
    }

You can manually specify the used by the tenant:migrate command in the tenancy config file. This artisan command is also called on tenant creation.
Here is what I did :
/**
 * Parameters used by the tenants:migrate command.
 */
'migration_parameters' => [
    '--force' => true, // This needs to be true to run migrations in production.
    '--path' => [
        database_path('migrations/tenant'),
        module_path('Auth') . 'Database/Migrations/tenant',
        module_path('Tenancy') . 'Database/Migrations/tenant',
    ],
    '--realpath' => true,
],

Also a function could get all enabled modules and then push all the tenant related migrations paths to configuration but I think this would be relevant only with more than 10 modules.

i came across the same issue and the easiest approach i found would be overriding the Jobs\MigrateDatabase::class in App\TenancyServiceProvider based on @ducor-io but with simpler logic ex.
class TenancyMigrateDatabase extends MigrateDatabase
{
    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $this->loadPaths();

        parent::handle();
    }

    public function loadPaths()
    {
        $paths   = [];
        $modules = array_filter(
            json_decode(
                file_get_contents(base_path('modules_statuses.json')),
                true
            )
        );

        foreach (array_keys($modules) as $module) {
            $paths[] = base_path("Modules/$module/Database/Migrations/tenant");
        }

        $config = 'tenancy.migration_parameters.--path';
        $paths  = array_unique(array_merge(config($config), $paths));

        return config([$config => $paths]);
    }
}

now when u run php artisan migrate --seed simply make sure the tenant seeder runs b4 any of the other seeders and all ur migrations tenant / central will run along with the seeders, all in one go.

i came across the same issue and the easiest approach i found would be overriding the Jobs\MigrateDatabase::class in App\TenancyServiceProvider based on @ducor-io but with simpler logic ex.
class TenancyMigrateDatabase extends MigrateDatabase
{
    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $this->loadPaths();

        parent::handle();
    }

    public function loadPaths()
    {
        $paths   = [];
        $modules = array_filter(
            json_decode(
                file_get_contents(base_path('modules_statuses.json')),
                true
            )
        );

        foreach (array_keys($modules) as $module) {
            $paths[] = base_path("Modules/$module/Database/Migrations/tenant");
        }

        $config = 'tenancy.migration_parameters.--path';
        $paths  = array_unique(array_merge(config($config), $paths));

        return config([$config => $paths]);
    }
}

now when u run php artisan migrate --seed simply make sure the tenant seeder runs b4 any of the other seeders and all ur migrations tenant / central will run along with the seeders, all in one go.

@ctf0 how do you avoid migrating the tenant migrations on the central db?
do you use?  php artisan migrate --path database/migrations/  as seen on https://github.com/nWidart/laravel-modules/issues/545 so central does not have all the tenant migrations?

@Surt u just run php artisan migrate --seed

Also, on your code the modules section should read:

by the time i was using the package, the modules_statuses was in the root.

@Surt

I want to migrate this, while running php artisan migrate --seed it is migrating all central migration files and seeds them.
But i want to migrate only the tenant migration files located in each modules dir.

Does anyone have a working project with both packages that i can take a look at? I'm confused about how i can get it to work

its work
<?php

namespace App\Providers;

use Illuminate\Support\ServiceProvider;
use Nwidart\Modules\Facades\Module;

class TenantMigrationServiceProvider extends ServiceProvider
{

    public function boot()
    {
        config([
            'tenancy.migration_parameters' => [
                '--force' => true,
                '--path' => $this->getTenantMigrationInModules(),
                '--realpath' => true,
            ],
        ]);
    }

    protected function getTenantMigrationInModules(): array
    {
        $modules = Module::all();

        $folders = [];
        $folders[] = database_path('migrations/tenant');
        foreach ($modules as $module) {
            $folders[] = $module->getPath() . "/database/migrations/tenant";
        }

        return $folders;
    }

}


Setup searchEngine on the gateway if a MS has the option

If I don't specify searchEngine elasticsearch on my gateway, the UI is generated without a search field. It seems like this should be read from the microservice apps (which have elasticsearch specified) rather than requiring it on the gateway.

The searchEngine option is read from the entity JSON, then the search box is only generated if enabled.  This allows the developer to enable/disable for specific entities instead of all.
I dont see any issues with this using the following JDL (didn't test running, just checked for the presence of the search box in the HTML):
application {
    config {
        applicationType gateway
    }
    entities *
}
application {
    config {
        applicationType microservice
        baseName ms1
        searchEngine elasticsearch
    }
    entities *
}

entity Foo
entity Bar
search Foo with elasticsearch except Bar
microservice * with ms1

Agreed. It's more of a "nice to have because one might forget it" than anything. That, or the fact that debugging afterwards might be troublesome.


Images displayed in *ngFor become corrupt and repeat on iOS

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[x ] 4.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
Please do not submit support requests or "How to" questions here.  Sometimes the images simply repeat improperly, other times they become jagged and distorted. Scrolling the page up and down rapidly seems to clear them up most of the time.
I have not been able to catch this occurring in a dev build, or in a state that would allow me to attach a debugger, but nothing in the code changes these image URLs, and "shaking" the scrollbar seems to clear it up sometimes, so doesn't seem like a code issue on my end. I'm at about my limit for trying different ways to display images to prevent this from happening.
I've tried background images, ion-img (can't use for various other buggy reasons), regular imgs, etc.

Expected behavior:
I would expect that the images render correctly without corruption or incorrect repetition.
Steps to reproduce:
I wish I could provide steps to reproduce. It is seemingly random when this happens. Users have only reported it on iOS. iOS version does not seem to be related. It occurs both on WKWebView and UIWebView.
Related code:
  <ion-grid *ngIf="hand">
    <ion-row *ngIf="!isLockedOut()">
      <ion-col *ngFor="let card of hand">
        <img bind-src="card.id | gatherer | safeurl" class="card-img" />
      </ion-col>
    </ion-row>
  </ion-grid>

Other information:
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
localhost:marit-mtg-ionic lb3$ ionic info

cli packages: (/Users/lb3/projects/maritlabs/marit-mtg-ionic/node_modules)

    @ionic/cli-utils  : 1.18.0
    ionic (Ionic CLI) : 3.18.0

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 3.1.2
    Cordova Platforms  : android 6.2.3 ios 4.5.0-dev
    Ionic Framework    : ionic-angular 3.9.2

System:

    ios-deploy : 1.9.0
    ios-sim    : 5.0.8
    Node       : v9.0.0
    npm        : 2.15.12
    OS         : macOS Sierra
    Xcode      : Xcode 9.1 Build version 9B55

Environment Variables:

    ANDROID_HOME : not set

Misc:

    backend : legacy

Here's what it should look like when images do not repeat. Every item in the list should have its own image:

I have a similar problem in my app. iOS only.

I have the same issue, using Cordova WITHOUT Ionic, iOS 11.x (but not on iOS 10), UIWebView. Happens in one app but not another. This feels like a Safari rendering bug, and... with some last-ditch testing it seems it's goes away if I don't use CSS filters, which kind of makes sense and explains why scrolling affects this.

@cnavarroestrella - have you tried WKWebView with your Cordova app? If not, that's cool. Just curious as to whether that had any affect or not.

@kensodemann I did, but my app crashed on boot and I have to release this week, so I can't be messing with that too much. Sorry I can't help with that.

I've tried WKWebView with the same effect. I'm going to try removing the CSS filters and see if that helps. Unfortunately, though, I can't reproduce it reliably enough to have any idea if it will work. It's just a shot in the dark...
@kensodemann, I saw you +1'd the comment about rendering/filters. Did you get that to work/fix the issue?

@lincolnthree - no, I +1'ed it because he tried it in a Cordova app w/o Ionic and got the same issue. That is always a good test to see if it is an issue with Ionic or if it is an issue elsewhere. So I was giving him a thumbs up for the effort.

Gotcha thanks. Just trying to make sure I understood.
Unrelated. I'm actually amazed at the power of Github/Google. Glad I'm not alone on this issue because it's been literally driving me to drink.
I posted this issue here knowing it probably happened to others, but I couldn't find any more info elsewhere on the internet. I'm wondering if this is worth opening an issue about/linking in the Cordova issue tracker.

Is it related to Cordova though? I haven't seen the same thing in the Android version of my app (yet).

Yeah, probably not. Might just be a Safari bug. I haven't had much luck finding an issue on that side either.

Second day, second round of testing, and I definitely can't reproduce the issue when I remove CSS filters as follows:
span.background {
	display: block;
	position: absolute;
	top: 0; bottom: 0; left: 0; right: 0;
	background: center center / cover no-repeat #aa2b5a;
	z-index: 0;

	//Commented these and the iOS11 Safari rendering issue went away:
	//-webkit-filter: brightness(75%);
	//filter: brightness(75%);

	// This produces the same effect as the filter and doesn't trigger the bug:
	span.darken {
		display: block;
		position: absolute;
		top: 0; bottom: 0; left: 0; right: 0;
		background: rgba(0,0,0,0.25);
	}
}

My guess is that the Safari post-processing pipeline has some sort of issue where concurrent attempts at applying some filter interfere with each other, resulting in corruption or repetition. In my case, some images would appear with bad chroma, so the type of filter applied might have an impact in how the issue manifests?
It's definitely a concurrency issue, though, as it happened more frequently when I loaded the images from a cache on the local filesystem as opposed to over the network, where they're more likely to arrive at different times. In this case, the bigger the processing job the likelier it is to happen, I'd say, as the filtering will take more to complete, so maybe increasing the size of the images (or the element where they're rendered?) will make it easier to test?
I'm considering this bug closed on my side and moving on to publishing. Good luck!

That's good to hear. We just published a new release of our app, so I'll post back if users seem to think it's solved.

Sorry If I up an old issue, but I have the same problem...
someone solved it or have a workaround?


Push notifications to channels are working inconsistently

As of approximately one week ago it seems as though Parse is no longer reliably sending push notifications to channels.  Advanced targeting is working fine (we use both channels and advanced targeting in our application).
We have not modified any of the code (which was working one week ago) related to sending/receiving push notifications, which leads me to believe it is an issue with Parse's services.
Has anything related to push notifications changed recently?  Our application is currently in production and this is a major issue.
We have posted several times on the Parse Google Group and no one from Parse has responded.
Thank you

Not aware of any change in terms of Push Notifications.
I would suggest filing a bug at https://parse.com/help, since we are still using FB Bugs Tool for backend related issues.


Can't query Dates with Dapper Object must implement IConvertible

When trying to query a row with a Date column using dapper i get Object must implement IConvertible but it works fine with ADO.Net
Full exception:

Error parsing column 2 (creationDate=11/14/2024 - Object)
--------------
System.InvalidCastException: Object must implement IConvertible.
   at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
   at Deserializebf872d3d-40a6-4be7-bb5e-31af6c01baa4(DbDataReader)
--------------
   at Dapper.SqlMapper.ThrowDataException(Exception ex, Int32 index, IDataReader reader, Object value) in /_/Dapper/SqlMapper.cs:line 3928
   at Deserializebf872d3d-40a6-4be7-bb5e-31af6c01baa4(DbDataReader)
   at Dapper.SqlMapper.QueryImpl[T](IDbConnection cnn, CommandDefinition command, Type effectiveType)+MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Dapper.SqlMapper.Query[T](IDbConnection cnn, String sql, Object param, IDbTransaction transaction, Boolean buffered, Nullable`1 commandTimeout, Nullable`1 commandType)
   at Program.<Main>$(String[] args)

I wrote an example project that can reproduce the bug https://github.com/MeltyObserver/DDB.NET.Examples

Try changing the property to DateOnly

Try this: https://github.com/DapperLib/Dapper/issues/1715#issuecomment-1149665776

That does work, I thought the issue was from this library because i didn't have an issue with postgres (npgsql)
is it possible to add this to the library?

No, I can't fix, as there isn't anything to fix it. The reason your original code throws is that DuckDB.Net maps Date column to DateOnly as since your property is DateTime, Dapper tries to convert the DateOnly value to DateTime. DateOnly doesn't implement IConvertible so you get that exception.
It works in Postgres as Npgsql maps Date column to DateTime, probably for compatibility reasons.
You'll have to wait until Dapper adds support for DateOnly or use the workaround from the linked Dapper issue.


memory leaks caused by cls-hooked

Hi,
We noticed a massive memory leak when using this library. We managed to find that the memory leaks come from the unmaintained cls-hooked library.
Since we are using the library in manual mode, we don't even want it to be used, but currently, you create a namespace by default. When setting manual mode, the namespace gets deleted, but cls-hooks doesn't do that properly, creating a memory leak.
A proposed solution will be to not use cls if an env variable exists to control manual mode.
PR with the fix is submitted

fwiw there is an open issue that couldn't be reproduced by AWS. Hopefully they will investigate now that there are multiple reports of the issue w/ the cls-hooked library.

When setting manual mode, the namespace gets deleted, but cls-hooks doesn't do that properly, creating a memory leak.

Issues on cls-hooked repo regarding this specific memory leak for reference and tracking:
https://github.com/Jeff-Lewis/cls-hooked/issues/66
https://github.com/Jeff-Lewis/cls-hooked/issues/67
https://github.com/Jeff-Lewis/cls-hooked/issues/68


Adding "Information Card" component to Storybook

Hey, I just made a Pull Request!

Note: This PR is still in progress, but if you wish, feel free to give me some feedback while I'm working on 😄

Added Information Card to the Storybook according to these specs: #400

:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[x] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[x] Prettier run on changed files
[ ] Tests added for new functionality
[ ] CODEOWNERS updated (for new stuff)
[ ] Regression tests added for bug fixes

Default:

Subhead:

Link in footer:

Looks great! 👌🏼

Maybe move this to proper PR now @mateusmarquezini ?

Maybe move this to proper PR now @mateusmarquezini ?

Yes @stefanalund ! I'm gonna commit the latest fixes


Test DiffEqDevTools.jl a bit better

Codecov Report

Merging #186 (0f9786d) into main (db7eefc) will increase coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   90.56%   91.52%   +0.95%
==========================================
  Files          24       24
  Lines         986      944      -42
==========================================
- Hits          893      864      -29
+ Misses         93       80      -13

Impacted Files
Coverage Δ

src/algorithms.jl
85.00% <0.00%> (-5.00%)
:arrow_down:

src/gaussians.jl
75.00% <0.00%> (-1.48%)
:arrow_down:

src/initialization/taylormode.jl
93.75% <0.00%> (-0.37%)
:arrow_down:

src/perform_step.jl
74.68% <0.00%> (-0.16%)
:arrow_down:

src/solution_plotting.jl
97.29% <0.00%> (-0.14%)
:arrow_down:

src/initialization/classicsolverinit.jl
97.22% <0.00%> (-0.08%)
:arrow_down:

src/callbacks.jl
97.36% <0.00%> (-0.07%)
:arrow_down:

src/diffusions.jl
98.61% <0.00%> (-0.04%)
:arrow_down:

src/solution.jl
98.76% <0.00%> (-0.02%)
:arrow_down:

src/checks.jl
100.00% <0.00%> (ø)

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Being able to specify the startpath for webdeploy when "Remove additional files at destination" is checked

Not sure if this is a feasible option to request, but I would like to see the ability to supply a startpath for MSWebdeploy when the checkbox "Remove additional files at destination" is enabled. So in that case Webdeploy is doing a full sync on that path only and removing all additional files within that path and it's subfolders.
Releases which are only updating parts of the folders in the webroot (which is intended in our case), are going to be a lot quicker because there is no need to first remove everything and then redeploy the entire web application.
To give an example of the supposed usage:
In our case we are using a Content Management System which contains a lot of files (12000+)..... On top of that we have our web application which needs to be deployed. So, doing a full deployment every time on such a large amount of files, takes quite a while. We have currently splitted the release into 2 parts:

the first part cleans everything and deploys the CMS files.
the second part deploys only our web application files.

However, if we want to only deploy a clean web application, which you want most of the time, we first need to remove all the files on the entire web application and redeploy the CMS first and then deploy the web application.

There's another use case for this which I'm just encountering, say I have a web app with an api and a number of web jobs.
If I deploy any of these I'd like to wipe down the specific application's directory but not delete the other directories as each component might be on it's own release pipeline

We don't have support for specifying start path with default rules for MSDeploy operations. I would suggest your ideas at UserVoice and vote for it to get the right prioritization.


Add well-known nostr

Untested ACK f3ac0d362d5166f6b10e880fff417c3fdd3800da .  This matches the key I received out of band.  Thanks!


is there a way to use single sign-on from teams based bot?

More details on extracting user information from signed-in user from teams interacting with bot

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90fddaf4-cdaf-76ff-f3ed-1c1de834cd49
Version Independent ID: f3af6459-6e50-f473-43f2-261155ddcd23
Content: Add authentication to your bot - Bot Composer
Content Source: composer-docs/how-to-use-oauth.md
Service: bot-composer
GitHub Login: @zxyanliu
Microsoft Alias: kamrani

Please check this doc.

When a user installs bot  in Microsoft Teams, that means he already logged
in... is there a way to get that user identity in the bot?
On Tue, Oct 27, 2020 at 11:29 AM zxyanliu<EMAIL_ADDRESS>wrote:

Please check this doc
https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-authentication-sso?view=azure-bot-service-4.0
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/composer-docs/issues/27#issuecomment-717365090,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFPMMIGVSPRKDBRQ7AGPBCDSM3YONANCNFSM4S2SC6ZA
.

--
Ganesh Phani Majeti.

Closing since this is not an issue of the Composer docs.
Please use stackoverflow and ask general questions about Bot Framework.
Thanks!


Fork per test.

Similar to #83,
This actually uses an AST transform to generate multiple files for forking and testing. This has a couple added benefits:

source-map support for the transform. The line numbers in the error messages match the original source.

no need for the weird _header file I was using in #83, or separate helpers. The transform intelligently copies helper functions into each file.

This currently runs sans-coverage (and passes). So it's a potential solution to #79 as well.

Just added a self-coverage solution. Tests can be run with or without coverage enabled.
It no longer uses tap --coverage, instead it uses a script to individually instrument the files with istanbul. It stores the coverage data a different global variable ___nyc_self_coverage___, and outputs to a directory called self_coverage.
This has the added benefit of not mixing in fixture coverage data into our coverage results.
The entire build process is implemented using npm build scripts. It's a little unwieldy. I think we should move to gulp or similar task runner.

npm run dev

for non-coverage, de-obfuscated stack-trace goodness

Below is the output of the first test file. Note that it is smart enough to only pull in the helper functions needed. The generated tests are stored as separate files inside the test dir. This has the added benefit of providing only like support for tests.. tap test/built-001-*.js runs test 1.
People evaluating this PR should actually clone it and run npm install && npm test to appreciate how it all works.
/* global describe, it */

require('source-map-support').install()
var _ = require('lodash')
var fs = require('fs')
var NYC

try {
  NYC = require('../index.covered.js')
} catch (e) {
  NYC = require('../')
}

var path = require('path')
var rimraf = require('rimraf')
var sinon = require('sinon')
var spawn = require('child_process').spawn
var fixtures = path.resolve(__dirname, './fixtures')
var bin = path.resolve(__dirname, '../bin/nyc')

require('chai').should()
require('tap').mochaGlobals()

describe('nyc', function () {
  describe('cwd', function () {
    function afterEach () {
      delete process.env.NYC_CWD
      rimraf.sync(path.resolve(fixtures, './nyc_output'))
    }

    it('sets cwd to process.cwd() if no environment variable is set', function () {
      var nyc = new NYC()

      nyc.cwd.should.eql(process.cwd())
      afterEach()
    })
  })
})

curious to see how this work turns out, my main ask is that the flow continues to be;

clone nyc
run npm i.
run npm t.

So let's bake any build steps into pretest :thumbsup:

That is still the process for builds with coverage (I do indeed use pretest). npm run dev just runs uncovered tests.
I would say this ready for preliminary review. The only thing that I think could be improved is the build. As stated I am thinking gulp. npm scripts would defer to that. Are you cool with that?
If you can, I would like you to at least clone it, run it locally and peek at the transformed files. I just want to make sure we don't feel that what I am doing is too magical before I dump a lot of extra time in it. I think it's a viable plan, but it is definitely out of the ordinary

The only thing that I think could be improved is the build. As stated I am thinking gulp. npm scripts would defer to that.

I'm partial to just using npm scripts.

@jamestalmage what's outstanding on this?

OK,
I think this is good to go.
There are still tests that I think need to be improved, but I think you have already tackled some of that in other PR's.

With all the files this thing now generates, and especially because of this, we should probably start using the explicit files whitelist in package.json to ensure nothing gets accidentally deployed to npm.

There are still tests that I think need to be improved, but I think you have already tackled some of that in other PR's.

Could get this in first, then fix what's remaining.

With all the files this thing now generates, and especially because of this, we should probably start using the explicit files whitelist in package.json to ensure nothing gets accidentally deployed to npm.

:+1:

OK, just updated package.json.
  "files": [
    "index.js",
    "bin/*.js",
    "lib/*.js",
    "!**/*covered.js"
  ]

Before:
$ tar -tf $(npm pack) | grep -v node_modules

package/package.json
package/.npmignore
package/README.md
package/build-self-coverage.js
package/build-tests.js
package/index.js
package/bin/nyc.js
package/LICENSE.txt
package/.babelrc
package/.idea/.name
package/.idea/encodings.xml
package/.idea/jsLibraryMappings.xml
package/.idea/misc.xml
package/.idea/modules.xml
package/.idea/nyc.iml
package/.idea/vcs.xml
package/.idea/watcherTasks.xml
package/.idea/workspace.xml
package/.travis.yml
package/lib/self-coverage-helper.js
package/lib/source-map-cache.js
package/CHANGELOG.md
package/nyc-4.0.1.tgz
package/test/nyc-test.js
package/test/source-map-cache.js
package/test/fixtures/package.json
package/test/fixtures/_generateCoverage.js
package/test/fixtures/coverage.js
package/test/fixtures/not-loaded.js
package/test/fixtures/sigint.js
package/test/fixtures/sigterm.js
package/test/fixtures/.istanbul.yml

After:
$  tar -tf $(npm pack) | grep -v node_modules
package/package.json
package/README.md
package/index.js
package/bin/nyc.js
package/LICENSE.txt
package/lib/self-coverage-helper.js
package/lib/source-map-cache.js
package/CHANGELOG.md

Note that I've used grep to remove the bundled dependency noise from the output above. The bundled dependency is included in both cases, you do not need to list it in the files array (I have verified that).

Hmm, oddly enough tar -tf $(npm pack) does not list *.covered.js files even when they are in the compressed bundle. I checked by manually unzipping the result of npm pack, and the .covered.js files do get included in the bundle unless I add the negate line to the files array. Seems like a bug in tar's console output to me.
TL; DR; - I have double and triple checked my changes to package.json#files, and I'm almost certain I've done it correctly.

Could get this in first, then fix what's remaining.

I agree. Let's do that.

@jamestalmage just testing this out, really slick!
A couple things:

I'm excited to see if isolating tests helps solve some of the issues I was seeing on Windows, would it be possible for you to rebase this branch with master.
let's move the built test files into a separate ./test/build/ folder, that way I can minimize it in my text-editor and interact with the existing test files.

would it be possible for you to rebase this branch with master.

Done

let's move the built test files into a separate ./test/build/ folder, that way I can minimize it in my text-editor and interact with the existing test files.

The reason I did not do that was so that require paths still looked right in the main file you were editing.
If you move them into build then you've got to do require('../fixtures/foo.js')
We could solve this by moving test sources into test/src/, directory structure could be
test/
    src/ - original test sources
    build/ - built tests
    fixtures/ - maintains relative path from both 'src' and 'build'
    lib/ - future use for test helper files - maintains relative paths

That last commit reorganizes the directory structure as I suggested in my previous comment.

not sure why the last commit caused coverage to drop, but I've got to head out for a couple hours. Will take another look later tonight

Found it, I missed an update to one of the npm scripts.

@jamestalmage this is looking great, feel free to merge this and your other test refactor work when you feel it's ready.

@jamestalmage this is looking great, feel free to merge this and your other test refactor work when you feel it is ready.

It is basically ready to merge (I will likely squash the history a bit first), but I am not a collaborator.

Landed. Thanks @bcoe!


iOS - initStripe urlScheme param issue

i was using "@stripe/stripe-react-native": "^0.2.4"
the urlScheme (iOS) was working fine and I was always redirected to my app successfully after completing the payment process through external payment applications.
After upgrading to "@stripe/stripe-react-native": "^0.27.2" redirection doesn't work anymore (knowing that the urlScheme works without a problem when trying it in browsers)
did i missed any params added in this release ?

i forgot to add this line to AppDelegate.mm
- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url options: NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options {   return [RCTLinkingManager application:application openURL:url sourceApplication:nil annotation:nil]; }


ENV variables need escaping

Have an issue that is failing some builds, it appears that the ghprb ENV variables aren't being escaped.
[app_dc_ui] $ /var/lib/jenkins/tools/hudson.tasks.Ant_AntInstallation/ANT1.9.3/bin/ant -file build.xml -DghprbTargetBranch=dev/sprint10 -DghprbSourceBranch=feature/DWGL-2835-rox-searchresult-styling -DghprbPullId=1334 -Dsha1=origin/pr/1334/merge -DghprbPullLink=https://github.com/some/repo/pull/1334 -DghprbActualCommit=2e3e81c1622d1ab482be5b40c11a1e9a06e40572 -DWEBDAV_PASSWORD=**** '-DghprbPullTitle=DWGL-2835 Search Results - Styled the search result and "no result" page...' -DghprbPullAuthorEmail= "-DghprbPullDescription=GitHub pull request #1334 of commit 2e3e81c1622d1ab482be5b40c11a1e9a06e40572 automatically merged." -Dapp.cartridge=/var/lib/jenkins/jobs/some-repo/workspace/cartridges/app_dc_ui compile.sass

With error:
BUILD FAILED
Target "result page..." does not exist in the project "sass compilation with explicit inheritance".

Actually, I really don't follow why this is erroring, because for situations where the text has something like quotes or brackets, the overall variable entry is single-quoted, so I'd expect the result is not interpreted, yet somehow the cli still tries to interpret the value...
Am I misinterpreting that this is an escaping issue?

The environment variables are passed to jenkins when the plugin requests a new build. I am not sure where you would want to look for your error.

The problem in our system can be reproduced by creating a pull request on GitHub that contains double quotes (all PRs create builds on our Jenkins, so the build is auto triggered if that is any help). I have not tried with any other characters.

Agreed with @asgrim, this bug should not be simply closed out. The env variable(s) generated by ghprb aren't necessarily escaped correctly, thus causing errors when a PR with quotes is built.


multi conn crashing (probably?)

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x2444]
goroutine 248 [running]:
panic(0x243de0, 0xc8200100c0)
/usr/local/go/src/runtime/panic.go:481 +0x3e6
main.handleClient(0x4c5b10, 0xc82002e000, 0x0, 0x0)
/Users/trivita/mydev/src/github.com/xtaci/kcptun/client/main.go:28 +0x404
created by main.main.func1
/Users/trivita/mydev/src/github.com/xtaci/kcptun/client/main.go:228 +0x2009

looks like if i have a large file to transfer, it crashes. (latest commit build)

problem fixed.


router: 1.30.1 -> 1.49.1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build

@ofborg build router

@LeSuisse can run nixpkgs-review and post the result please?

@LeSuisse I just did a force push.

Thanks!


Reduce Docker image size

Solves #237  (check issue for discussion)

Hopefully removing conda will also speed up CI a bit. Anything preventing from removing the draft status here?

@rth, indeed, removing Conda does reduce quite a lot the build time.
Below are the results of the command
time docker/scripts/docker_build.sh 1.0

On a VM on the Inria network, with no image in the local registry, for the following configurations

Ubuntu 18.04 with conda install and pip install inside (current master docker file)
Python 3.7 image with conda install and pip install inside
Python 3.7 image with pip install directly

config
Ubuntu-conda
Python-conda
Python

real
2m45.524s
2m43.217s
1m20.772s

user
0m0.384s
0m0.324s
0m0.184s

sys
0m0.552s
0m0.468s
0m0.304s

There is a merge conflict, would you mind merging master or rebasing manually @pgraverdy ?


kubernetes_cluster_private_cluster_config_enabled query is incorrect

Describe the bug
Control: Verify all GKE clusters are Private Clusters is about checking the clusters are private or not. However, in the query, if the cluster is private, it will show as an alarm.

closed in https://github.com/turbot/steampipe-mod-gcp-compliance/pull/59


Leak track more tests.

Fixes: https://github.com/flutter/flutter/issues/134575

fly-by-comment from triage: This PR appears to be empty.


Inconsistency between tutorials

I found that mnist_tutorial_cw.py and mnist_tutorial_jsma.pyuse function generate_np although mnist_tutorial_tf.py use generate to create adversarial examples.
Though this is rather minor, I wonder is it mean to be like this?

The reason it is done this way is because the tf tutorial uses the fast gradient sign attack -- something that is expressed purely in tensorflow. Both JSMA and CW use py_func wrappers, it makes more sense to talk about passing in and receiving numpy arrays. (Or, that's what I assume the reason is. I just copied the JSMA code to get the CW tutorial.)

Thanks!


IP address marked as orphaned when vNIC changes portgroup

Hi,
When switching the portgroup of 2 existing interfaces, that had IP addresses assigned to them, the IP's are marked as orphaned.
They are also deleted according to the prune settings, and only during the sync that occurs after the delete action, they're added back to the changed interface.
More detail:
IP address 5.x.4.21/23 created by vcenter-sync
vrf: null
role: ""
tags: []
status: "active"
tenant: null
address: "5.x.4.21/23"
created: "2021-06-29"
dns_name: ""
nat_inside: null
description: ""
last_updated: "2021-06-29T06:04:44.508Z"
custom_fields: {}
assigned_object_id: 9378
assigned_object_type: 81

During same sync, the object is updated with the sync tags:
IP address 5.x.4.21/23 updated by vcenter-sync
tags: [
    "NetBox-synced",
    "Source: com-vcenter008"
]

Weeks later, the VM gets a dist-upgrade and this causes Debian to mix up the interfaces after a reboot, and someone fixes this by changing the VM interfaces to the corresponding portgroups.
Situation before:
vNIC1 -> HCL PUB 2489
vNIC2 -> portgroup abc
vNIC3 -> portgroup def
vNIC4 -> Netapp102 ClientMounts 3102
Situation after:
vNIC1 -> Netapp102 ClientMounts 3102
vNIC2 -> portgroup abc
vNIC3 -> portgroup def
vNIC4 -> HCL PUB 2489
After this action, the sync log states:
WARNING: Current interface 'vNIC 1 (Netapp102 ClientMounts 3102) (com-vm022a.srv.masked-ops.net)' for IP '5.x.4.21/23' and this one 'vNIC 4 (HCL PUB 2489) (com-vm022a.srv.masked-ops.net)' are both enabled. IP assignment skipped because it is unclear which one is the correct one!

And the sync tags all the IP addresses of vNIC4 (previously vNIC1) as orphaned.
After the prune_delay_in_days is over, the IP address is deleted.
Only on the first sync after the sync deleted the IP's, the IP addresses are added back, and assigned to the correct vNIC.
Is it possible to detect this and link the IP addresses to the correct vNIC, instead of having the current flow where there's a gap and it seems the IP address does not exist between the sync where the prune action happens & the first sync after that?

Hi,
You are correct, this is happening.
This would need a validation run to see if an IP address in NetBox is still assigned to the same interface.
I have to think about, how to solve this in the process logic.

Hey @gstorme,
I could actually easily add this. If the scope is the same device/VM then it is pretty straight forward.
in the long run you should think about switching to a different Linux distribution if this keeps happening. The network device order should not change on any system update.

Hey @gstorme,
I just pushed a change to "development" which should fix this issue. Can you please try it out if this resolves your issue?

Looks good, thanks!

Great, thank you for the feedback


DS-R: 1.3.DOC History - Roots of Data Science with R

Description 📜
In this issue, you need to work on the documentation efforts in the "History" section under the "Roots of Data Science with R" subsection. Please ensure that you document in detail.

https://bookdown.org/rdpeng/rprogdatascience/
https://blog.paperspace.com/intro-to-datascience/

Domain of Contribution 📊

[x] Datascience with R

Instructions ✔

Kindly make a README going over the subtopic.
Changes should be made under Datascience_With_R branch only and push your PR to the same.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.

@micepram hey, I would like to work on this issue. Please assign me this.

also please add Gwoc label to this issue.

Great, go ahead!

Hello, I am Deepthi M. I would like to do documentation on this issue.

Sure @deepthi1107, please join @TechnoPhasePRO and work together on this.

sure, thanks for the opportunity.

Hey @deepthi1107, we are going to be limiting issues to one person only due to logistics. Each Top (1.1, 1.2, etc.) will have 3 issues for 1 for Documentation, 1 for Audio, 1 for Video and hence will only have one person assigned. I'll be removing you from this assignment and request you to choose another issue. There will be plenty coming in soon. Thank you :)

What's the update @TechnoPhasePRO?

@micepram sorry but I'm having some problems with the head branch in git as its detached. Due to which my commits are not authorized under correct credential . That's why its taking long to resolve it.

@TechnoPhasePRO What is the update?

@micepram Sorry Ma'am, I was caught up in other stuff. It's almost done just the styling is left. I will create PR ASAP.


function error/0 undefined

I'm trying to create add haml to a new Phoenix application, but I'm getting this error
$ mix phoenix.server
==> phoenix_haml
Compiled lib/phoenix_haml.ex
Compiled lib/phoenix_haml/engine.ex
Generated phoenix_haml.app
==> hello_phoenix
Compiled lib/hello_phoenix.ex
Compiled web/web.ex
Compiled lib/hello_phoenix/repo.ex
Compiled web/router.ex
Compiled web/views/error_view.ex
Compiled web/controllers/page_controller.ex
Compiled web/views/page_view.ex

== Compilation error on file web/views/layout_view.ex ==
** (CompileError) web/templates/layout/application.html.haml:1: function error/0 undefined
    (stdlib) lists.erl:1336: :lists.foreach/2
    (stdlib) erl_eval.erl:657: :erl_eval.do_apply/6

application.html.haml looks like this:
!!!
%html{:lang => "en"}
  %head
    %meta{:charset => "utf-8"}/
    %meta{:content => "IE=edge", "http-equiv" => "X-UA-Compatible"}/
    %meta{:content => "width=device-width, initial-scale=1", :name => "viewport"}/
    %meta{:content => "", :name => "description"}/
    %meta{:content => "", :name => "author"}/
    %title Hello Phoenix!
    %link{:href => static_path(@conn, "/css/app.css"), :rel => "stylesheet"}/
  %body
    .container{:role => "main"}
      .header
        %ul.nav.nav-pills.pull-right
          %li
            %a{:href => "http://www.phoenixframework.org/docs"} Get Started
        %span.logo
      %p.alert.alert-info{:role => "alert"}= get_flash(@conn, :info)
      %p.alert.alert-danger{:role => "alert"}= get_flash(@conn, :error)
      = @inner
    / /container
    %script{:src => static_path(@conn, "/js/app.js")}
    :javascript
      require("web/static/js/app")

I use phoenix 0.13.1 and phoenix_haml 0.1.2
Is it a bug, or did I miss something? Looks very similar to #4

Hi @slavad, I ran into this issue as well, using phoenix 0.13.1 and phoenix_haml 0.1.2. I narrowed the issue down to how Calliope parses HAML. As it appears to support its own flavor of HAML, which is why you're getting compilation errors, I've marked down the differences I've found so far below that have allowed me to get a parse-able file.

No support for hashrockets ("=>").
Dashes in attributes don't require you to put the name of the attribute as a string (e.g. http-equiv: "X-UA-Compatible" is acceptable)
Multiple attributes do not have to be separated by commas
I couldn't quite figure out how to get it to support method calls within attributes (e.g. static_path/2). I found a workaround for this in the code sample below.

This code sample of application.html.haml is supported by Calliope's parser:
!!!
%html{lang: "en"}
  %head
    %meta{charset: "utf-8"}
    %meta{content: "IE=edge" http-equiv: "X-UA-Compatible"}
    %meta{content: "width=device-width, initial-scale=1" name: "viewport"}
    %meta{content: "" name:  "description"}
    %meta{content: "" name: "author"}
    %title Hello Phoenix!
    - item = static_path(@conn, "/css/app.css")
      %link{href: "#{item}" rel: "stylesheet"}
  %body
    .container{role: "main"}
      .header
        %ul.nav.nav-pills.pull-right
          %li
            %a{href: "http://www.phoenixframework.org/docs"} Get Started
        %span.logo
      %p.alert.alert-info{role: "alert"}= get_flash(@conn, :info)
      %p.alert.alert-danger{role: "alert"}= get_flash(@conn, :error)
      = @inner
    / /container
    - item = static_path(@conn, "/js/app.js")
      %script{src: "#{item}"}
    :javascript
      require("web/static/js/app")

@Stavrus the last two issues need to be addressed in calliope. However, the first two aren't bugs as much as preferences on my part. I tried to implement the necessary haml syntax and only add support for additional syntax when requested. It's really just to keep unused syntax out.
I wonder if I should be more explicit in the README on some of the haml differences. That being said, I'm actively working on the next iteration so if you have any issues that you would like addressed please add them to the Calliope repo.
Thanks for using Calliope & I hope I can make your experience better

@nurugger07 this issue was one of the first hits on google I found when I ran into this error, so I wanted to give anyone else following in my footsteps a quick rundown of what was needed to get the default application.html template converted. Please don't take it as me knocking your project, it was just the "gotchas" I came across with that particular template that I'm hoping others can avoid in order to get up and running with the library faster.
I assumed that the last issue I mentioned was just my unfamiliarity with the library as I only just started using it (along with Elixir/Phoenix), but I'll throw up an issue just in case.
With regards to the first two, http://html2haml.herokuapp.com/ is what I assume @slavad used in generating the initial conversion. I did the same, as it's probably the easiest way to do so, but it uses that unsupported syntax which caused the problem we both ran into.

@Stavrus No, no I really appreciate you using it and thank you for helping others too! Thanks for documenting the issue in calliope. I'll be working more on it today :)

@Stavrus, thanks for the workaround

Closing for now and we can bump the calliope dep when things are handled on that end.

@chrismccord sounds good. This one is definitely on me & I'm working the issue https://github.com/nurugger07/calliope/issues/45


chore: jsonfmt network 2018

Ran jsonfmt -w "specification/network/**/stable/2018*/**/*.json"

Can one of the admins verify this patch?

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-java


Publisher Name Error on Microsoft Store verification

I'm trying to upload the .msix package to the Windows store, but verification fails with the following error messages:

Invalid package family name:  PadmitS.A.P.I.deC.V.WardHome_pjyac4g0caf2w (expecting: PadmitS.A.P.I.deC.V.WardHome_1hxjgg9m0hxqm)
Invalid package publisher name:  CN=Msix Testing, O=Msix Testing Corporation, C=US (expecting: CN=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX)

What's strange is that I've defined the publisher with the correct value in pubspec.yaml:
msix_config:
  display_name: Ward Home
  publisher_display_name: Padmit, S.A.P.I. de C.V.
  identity_name: PadmitS.A.P.I.deC.V.WardHome
  msix_version: <IP_ADDRESS>
  publisher: CN=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
  logo_path: C:\Users\Padmit\Documents\Ward\admin\home_logo.png
  start_menu_icon_path: C:\Users\Padmit\Documents\Ward\admin\home_logo.png
  tile_icon_path: C:\Users\Padmit\Documents\Ward\admin\home_logo.png
  icons_background_color: transparent
  languages: es
  architecture: x64
  capabilities: 'internetClient,privateNetworkClientServer'

Any ideas as to what I might be doing wrong?
I'm building the app with the following commands:
flutter build windows
flutter pub run msix:create

Thanks

I guess the question is how do I make sure flutter pub run msix:create uses the right publisher information? I've copied mine directly from Microsoft Store, same thing for the identity_name

Hello @jaimevaqueiro
This bug prevents advertising to the store, I will fix it as soon as possible
Thank you for this report

Hey
i published new version 2.1.0 with a new flag --store for generation msix installer for Windows Store,
and updated the documentation:

@jaimevaqueiro please update if its help your publish situation


Squirt Bottle confronts you about how you got in his closet

p: ...heya.
sq: susndjsdjsifjsdk how did'ya get here?
p: umm I don't know... errrrm nice chairs?
sq: You don't get to complement my chairs unless I invite you in. And I don't recall sending invitations.
p: Errrrrrr.
sq: sigh, fine you can stay here.
sq: Not because I am happy to do so, but because you would be too much of a pain to evict.
sq: Don't tell anyone about this.
p: Not a single word will come out about this sir.
sq: ...
sq: Don't be so formal, just call me Squeezy.
sq: While you here, help yourself to a snack.

I like the finisher, but I can't remember if Squirt Bottle has an issue with snacks being taken. Can someone double check about that

I like the finisher, but I can't remember if Squirt Bottle has an issue with snacks being taken. Can someone double check about that

Checked the script, Squeeze Bottle doesn't seem to care about his snacks, just doesn't like people appearing in his secret room

Really! I'm surprised, I feel like there was some kind of conversation initiated if you interact with the machine

i edited it a bit because i think it would be better for him to care so the vending machine scene makes sense.
    p "...heya."
    $ renpy.transition(hpunch, layer="master")
    sb "AHGDHSXJS- How d'ya get here!?"
    p "Umm I don't know... Errrrm nice chairs?"
    sb "You don't get to complement my chairs unless I invite you in. And I don't recall sending invitations."
    p "Errrrrrr.."
    sb "{i}sighh{/i}  Fine! you can stay here."
    sb "Not because I am happy to do so, but because you would be too much of a pain to evict."
    sb "Don't tell anyone about this."
    p happy "Not a single word will come out about this sir!"
    sb quiet "..."
    sb -quiet "Don't be so formal, just call me Squeezy."
    sb "Do whatever, I guess."

oh also you can make it so sb is facing the other way at first before noticing posty with this code:
...
init:
    transform flip:
        xzoom -1.0

...

^ doesnt matter where that is as long as its above the code below
...
    show sb:
        flip
        right
    $ saw.janitors = True
    p suspicious quiet "{i}Whats this place?{/i}"
    p neutral "...heya."
    hide sb
    show sb # resets sb so hes facing the correct way
...

   init:
    transform flip:
        xzoom -1.0
    show sb:
        flip
        right
    $ saw.janitors = True
    p suspicious quiet "{i}Whats this place?{/i}"
    p neutral "...heya."
    hide sb
    show sb # resets sb so hes facing the correct way
    $ renpy.transition(hpunch, layer="master")
    sb "AHGDHSXJS- How d'ya get here!?"
    p "Umm I don't know... Errrrm nice chairs?"
    sb "You don't get to complement my chairs unless I invite you in. And I don't recall sending invitations."
    p "Errrrrrr.."
    sb "{i}sighh{/i}  Fine! you can stay here."
    sb "Not because I am happy to do so, but because you would be too much of a pain to evict."
    sb "Don't tell anyone about this."
    p happy "Not a single word will come out about this sir!"
    sb quiet "..."
    sb -quiet "Don't be so formal, just call me Squeezy."
    sb "Do whatever, I guess."


Addition of Assign-bot

🐞 What bugs you?
We should add an assign bot to automate assigning the issues/PR to willing contributors
🎯 Goal

Keep track of assigness
Increases the organization

💡 Possible solutions

Addition of assign-bot

📋  Steps to solve the problem

It could also happen that someone claims but doesn't work. Need to take care of it for future contributors.
A tracking mechanism should be set up?

Potentially useful: https://github.com/kentaro-m/auto-assign/

Potentially useful: https://github.com/kentaro-m/auto-assign/


can not request /cas/hfwy/zhcw/p3/serviceValidate?

I use Casdoor as the CAS server, and after successfully login, the Java backend request follow url：http://localhost:7001/cas/hfwy/zhcw/p3/serviceValidate?servier=...&ticket=....
to verify the ticket, but I received the following result.
<! DOCTYPE html><meta charset="utf-8"><title>Error</title>
Cannot GET /cas/hfwy/zhcw/p3/serviceValidate

@zzutligang CAS API is served by Go backend. you should use the port 8000 instead of 7001


[Question]: What is the purpose of the order type parameter in StopLimitOrderRequest?

Question form pre-submit checklist.

[X] I have searched the existing issues to ensure there isn't already an issue about this question.
[X] My question has to do with the Python SDK and isn't a general question about the API. (If it is please open your issue here)
[X] My question isn't about how to do a specific algorithm or asking for trade advice (answers to these are outside the scope of this repo).

Question
What is the purpose of specifying the order type when this is implicit in the choice of request class object? If I am using StopLimitOrderRequest, then I am doing a stop limit order.

It is not meant to be used. Since StopLimitOrderRequest  inherits from OrderRequest, it inherits the type parameter. If you try to use that parameter in StopLimitOrderRequest, it will simply be overwritten.


ibc-setup base

Closes #51
Closes #55

Please add closes #51 in the description, so it links to the PR

This is an odd CI error. Any idea where it comes from?

Error: Cannot find module './polyfills.js'

https://app.circleci.com/pipelines/github/confio/ts-relayer/121/workflows/6e643b08-231e-4ba6-a483-db6ae8565511/jobs/246


Seal OnCallHook to prevent plugins from overriding it

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/25702194-seal-oncallhook-to-prevent-plugins-from-overriding-it?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github).

Resolved with PR #498.


Urgent: The spatial layer filter on the staging site remains blank when a layer is chosen.

On the testing site the spatial layer filter works and looks like this:

On the staging site the spatial layer filter remains blank and a user cannot click on a polygon to specify a search area:

This is a major problem for testing.

Functionality works on staging site.
All four spatial layers show up:

Selecting a polygon from a spatial layer refines the search area:


use factory pattern with gunicorn

Need to remember what the purpose of this PR is for and if it fits into the new application code base


SimpleContent requires sitefiles folder even when UseSharedThemes = true

In my application all my tenants using the same theme. I put this in appsettings.json:
    "UserPerSiteThemes": "false",     "UseSharedThemes": "true"
and I decided to delete sitefiles  directory. Main reason to delete that I will not use it and I have to ignore it every time during synchronization etc.
But in this case site fails with System.IO.DirectoryNotFoundException: 'C:\Projects\Blog\New\Blog\sitefiles\s1\themes\custom1\wwwroot\' and not rendering at all.
Steps to reproduce. Create new site using this:
dotnet new cloudscribe -D NoDb -S a -L true
move custom1 theme from sitefiles\s1\themes to SharedThemes, delete/rename sitefiles directory and apply changes to appsettings.json:
    "UserPerSiteThemes": "false",     "UseSharedThemes": "true"
and run app. You will see .Net Core screen of death.
I understand that this is low priority but I spent few hours trying to understand why it doesn't work because I knew that  sitefiles directory not suppose to be used all.

Themes are self contained things, what file names they use for css is not important that they match other themes. You can name files whatever you like in custom themes, the documentation is correctly indicating the important differences. The shared themes are all bootswatch themes so they are all very similar to each other. The custom1 theme that is private is different, it is designed to less  you use bootstrap sass variables and uses a gulp file to produce the output css file. There is no reason it needs to use the same file names as the bootswatch themes, but the fact it uses different file names is also not important, it could have used the same names but it was not based on the bootswatch themes,
The bootswatch themes use a site.css file to oveeride some bootstrap things, whereas custom1 becuase it uses sass and combines multiple files into one, only has style.css as its output and that contains bootstrap plus site specific css all in one.

There were actually some outdated things in the documentation, it was written back during the time of boostrap3 and when the views in nugets were embedded resources. Nowadays views in nugets are pre-compiled rather than served as embedded resource files.
I've also added detailed information about the custom1 theme and how to use and customize it.
https://www.cloudscribe.com/themes-and-web-design

I was trying to say that custom1 theme has mention of IE11 and even including .css file for it. Also custom1 theme including only one .css file but Shared theme includes 3 .css file. But documentation for section "Differences Between Private Themes and Shared Themes" states that both themes include 2 .css file.
Perhaps I got it wrong but after reading I would assume that in general these themes should be almost identical.

The documentation is about difference when making a theme what you need to know to make a shared vs private theme. It is not about describing all differences of included themes. For individual themes there are no rules about file names or how many files or what other things it may be trying to accomplish.
The bootswatch themes are provided as examples of ready made themes, they were designed by bootswatch team and adapted for cloudscribe by adding a _Layout.cshtml file and one extra sites.css to adapt the bootswatch as needed. If you want to customize those you are able to but I don't normally start new site designs using any of those.
The custom1 theme is the only theme I really tried to show possibilities to customize. It is the only theme I ever use to start a new custom theme. If I add features to custom1 it doesn't mean I need to add them to the bootswatch themes.
The bootswatch themes also include .scss files so if I were to make a custom theme based on that I would just copy the .scss files into custom1 and remove or replace or augment the standard bootstrap .scss files. But normally I just use custom1 and modify _variables.scss and other files as needed to make a new custom theme.
In a client project we had to support IE11 so I came up with a way to add a class to the body element for IE11 and include an extra file that made it easy for me to override styles for IE11 in that project. So I rolled it back into custom1 in case it useful in other projects. It is not an important feature and I don't feel any need to add it to every theme. Most projects I don't worry about IE11 and I don't care about the bootswatch themes in IE11.
The only platform where IE11 is a concern is Windows 7 and soon Microsoft will release their new version of Edge based on Chromium and they will make that available for Windows 7 and they are already telling people stop using IE11
You are examining all differences between the themes and thinking they are important, they are not, the only important  thing about shared vs private themes is the extra taghelper param needed to resolve the resources from the shared theme wwwroot folder. All other differences are arbitrary and not relevant to private vs shared themes.

Thank you for this extensive explanation. Now it is much more clear what's going on there.


[PR][CLOSED] Added test coverage script (with gcov/lcov)

 Issue by geunsik-lim
Tuesday Jun 19, 2018 at 02:32 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/pull/35

This PR is to append a test coverage script for Jenkins server.
After this PR, the official webpage of gcov will be http://aaci.mooo.com/<prj_name>/gcov/.
Changes proposed in this PR:

Added gcov script for Jenkins
Updated default web address for gcov report

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
geunsik-lim included the following code: https://github.sec.samsung.net/STAR/TAOS-CI/pull/35/commits

:octocat: cibot: Thank you for posting issue #52. The person in charge will reply soon.


[8.x] Respect custom route key with explicit route model binding

Hi there! 🚀
You can use explicit route model binding in a situation where implicit binding might now work. Implicit binding allows you to customize the binding field for each route.
Route::get('/post/{post:slug}', fn (Post $post) => $post->content);
Route::get('/posts-by-id/{post}', fn (Post $post) => $post->content);

Unfortunately, this doesn't work when you're using explicit binding. It always uses the $model->getRouteKeyName().
Route::model('post', Post::class);

This PR makes sure that when explicitly binding models to route paramters, they respect any custom route fields being used.
Additionally, it passes the custom key to custom route binding.
Route::bind('post', function ($value, $route, $key) {
    // do something
});

Does this contain any (even minor) breaking changes?

Breaking in the sense that someone relying on the old behaviour (because they assumed "that's just how it works"), will have their app broken.

Does this contain any (even minor) breaking changes?

I left the order of parameters unchanged so it doesn't break your current routes. But like @GrahamCampbell said, if you rely on the "broken" behavior, then this will be a breaking change.

Broken: https://github.com/laravel/framework/issues/36443
Reverting.


add check for google_trackConversion in loaded function.

Related ticket - https://segment.zendesk.com/agent/tickets/32163

is there docs for this google_trackConversion property?

Are you asking if Segment has docs on the google_trackConversion property? If so, the answer is no. I don't think we'd need docs on this given that we abstract this away so that the customer doesn't have to know about this.
Or...do you want me to include a comment in the code that links to Google's docs on google_trackConversion?

@travisjeffery can we merge this

@travisjeffery is this what you need? https://developers.google.com/adwords-remarketing-tag/asynchronous/?hl=en

a customer is waiting on this for a long time now and it seems like a quick fix cc/ @sperand-io

cc/ @sperand-io not sure if you've been involved on this yet or not

lgtm sorry for the delay!


Set description for all tasks

Don't know if this PR is valid, but, I'm using capistrano 3.2.0 and if the task don't have desc when I run fiesta:run it tells me that announce  or generate tasks don't exist.
Thanks so much.
🍻

Thanks a lot @duduribeiro! TIL about Capistrano 3.2.0, we're currently using 3.6.1 without any problems, but nice to have the descriptions in any case 👍


isReady resolves before scrollBehavior

Reproduction
https://vue3-vue-router-demo-gtj6cd.stackblitz.io
Steps to reproduce the bug
Load up the reproduction URL and examine at logs.

Expected behavior
Awaitable<T> from scrollBehavior settles before isReady() resolves.
Actual behavior
isReady() resolves during handleScroll() and before scrollBehavior() is called.
Additional information
The issue is here; finalizeNavigation() is not awaiting handleScroll().
https://github.com/vuejs/router/blob/b480bd1d6ffe6a525e1869112e90a49322ecac02/packages/router/src/router.ts#L963-L965
Internally handleScroll() progresses through several promises:
https://github.com/vuejs/router/blob/b480bd1d6ffe6a525e1869112e90a49322ecac02/packages/router/src/router.ts#L1175-L1178
Without awaiting handleScroll() then markAsReady() is called while handleScroll() is awaiting nextTick().
From the docs I believe that isReady() should be resolving after all async router specific setup and display have occurred. With the current behavior I'm unable to deterministically wait to perform DOM side effects which are based on restored scroll position.

Issue confirmed by this workaround.
isReady() resolves early then application code awaits a generous number of microtasks. During this time my sync scrollBehavior settles. Then after microtasks the router has restored scroll behavior and the application can work out side effects.
export function useWindowScrollLock() {
  const router = useRouter()

  // These methods should be kept safe to de-reference.
  return {
    async lock(): Promise<void> {
      try {
        await router.isReady()
        // See: https://github.com/vuejs/router/issues/1899
        await flushMicrotasks()
        lock()
      } catch (error) {
        console.error(error)
      }
    },
    unlock
  }
}

This is intended and necessary design: the scroll handling is not awaited in any navigations. IsReady is not about the page being displayed (mounted), in fact, it’s used sometimes before mounting. It’s about the router being ready to be used and the application to display. Out of curiosity, what are you using isReady for?


Restore the Small taskbar buttons option

Description of the new feature / enhancement
The ability to use a small taskbar, like in windows 10 whose option was sadly taken away in windows 11 for no reason.
Scenario when this would be used?
Many people don't like how large the default taskbar is. In windows 10 Microsoft solved this by allowing users to use a cleaner, small taskbar. It looked better on desktop, and granted us more screen real estate.
Supporting information
No response

/feedbackhub


updated code

check the codes

Tq
On Wed, Oct 23, 2024, 11:12 AM Lim Xin Ying @.***>
wrote:

Merged #123 https://github.com/codingkatty/mathpylearn/pull/123 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/codingkatty/mathpylearn/pull/123#event-14801511564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3IHY2ZDFBQWY7EZQGC5RTTZ44ZMXAVCNFSM6AAAAABQN4OWHOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHAYDCNJRGE2TMNA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have a dout If a send another pull request is that count increase In the
hacktoberfest
On Wed, Oct 23, 2024, 11:15 AM Saketh Kotla @.***> wrote:

Tq
On Wed, Oct 23, 2024, 11:12 AM Lim Xin Ying @.***>
wrote:

Merged #123 https://github.com/codingkatty/mathpylearn/pull/123 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/codingkatty/mathpylearn/pull/123#event-14801511564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3IHY2ZDFBQWY7EZQGC5RTTZ44ZMXAVCNFSM6AAAAABQN4OWHOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHAYDCNJRGE2TMNA
.
You are receiving this because you authored the thread.Message ID:
@.***>

send me your linkedin profile link
On Wed, Oct 23, 2024 at 4:27 PM Lim Xin Ying @.***>
wrote:

I have a dout If a send another pull request is that count increase In the
hacktoberfest
Hi, yes, every PR would count as 1 submission (not sure what you call it)
—
Reply to this email directly, view it on GitHub
https://github.com/codingkatty/mathpylearn/pull/123#issuecomment-2431730661,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3IHY26VBACLO2CYKRJOHK3Z456JNAVCNFSM6AAAAABQN4OWHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRG4ZTANRWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

linkedin.com/in/kotlasaisaketh
https://www.linkedin.com/in/kotlasaisaketh?lipi=urn%3Ali%3Apage%3Ad_flagship3_profile_view_base_contact_details%3BbEGeB4oyQOq79wpAEkp5mQ%3D%3D
On Fri, Nov 1, 2024 at 11:17 PM Saketh Kotla @.***>
wrote:

send me your linkedin profile link
On Wed, Oct 23, 2024 at 4:27 PM Lim Xin Ying @.***>
wrote:

I have a dout If a send another pull request is that count increase In
the hacktoberfest
Hi, yes, every PR would count as 1 submission (not sure what you call it)
—
Reply to this email directly, view it on GitHub
https://github.com/codingkatty/mathpylearn/pull/123#issuecomment-2431730661,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3IHY26VBACLO2CYKRJOHK3Z456JNAVCNFSM6AAAAABQN4OWHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRG4ZTANRWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Option to specify stdin filename

Something that's really useful for editor plugins is an option to say what filename the contents of stdin are coming from.

prettier: this option is called --stdin-filepath
rufo: this option is called --filename

In my experience, it's easiest and most reliable to implement an editor plugin by not using disk files at all. Instead, just feed unformatted code to stdin and get the formatted code back from stdout. But even when using stdin/stdout, it's useful if we can know the filename of the code (the code usually comes from a disk file, but may have been modified in the text editor and the modifications have not been saved, so the disk file is different from the editor buffer that is sent to stdin).
The point of knowing the filename is that:

Formatter error/warning messages can show a filename that is intuitive to the user.
Unibeautify can find .unibeautifyrc and possibly other project settings files based on the filename.

In my experience, it's easiest and most reliable to implement an editor plugin by not using disk files at all.

💯% agree.

The point of knowing the filename is that:

And these are both great points.

Unibeautify CLI should absolutely support passing the file name.
Applicable code: https://github.com/Unibeautify/unibeautify-cli/blob/master/src/cli.ts#L74-L78
Can pass filePath as documented: https://api.unibeautify.com/interfaces/beautifier.beautifydata.html
Pull Requests welcome!

I'm incorporating this into the ci-fixes branch.  I originally meant to work on this issue, but had to get everything else working first.

@lassik please give this a try with<EMAIL_ADDRESS>
$ sudo npm install --global<EMAIL_ADDRESS>-><EMAIL_ADDRESS>+<EMAIL_ADDRESS>updated 1 package in 3.644s

$ echo | unibeautify --language JavaScript
(node:20532) UnhandledPromiseRejectionWarning: NestedError: Could not require module '@unibeautify/beautifier-prettydiff'
    at requireg (/usr/local/lib/node_modules/@unibeautify/cli/node_modules/requireg/lib/requireg.js:14:11)
    at beautifierNames.map.beautifierName (/usr/local/lib/node_modules/@unibeautify/cli/dist/index.js:27:16)
    at Array.map (<anonymous>)
    at loadBeautifiers (/usr/local/lib/node_modules/@unibeautify/cli/dist/index.js:26:41)
    at findInstalledBeautifiers.then (/usr/local/lib/node_modules/@unibeautify/cli/dist/index.js:34:16)
Caused By: Error: Cannot find module 'prettydiff2'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:594:15)
    at Function.Module._load (internal/modules/cjs/loader.js:520:25)
    at Module.require (internal/modules/cjs/loader.js:650:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/@unibeautify/beautifier-prettydiff/dist/src/index.js:4:20)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
(node:20532) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:20532) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Make sure you have [unibeautify](https://www.npmjs.com/package/unibeautify) installed globally as well.

Ok, now I can use the --file-path option 😄  But I wasn't able to test whether it loads .unibeautifyrc* from that file path's directory because of https://github.com/Unibeautify/beautifier-clang-format/issues/29.
At a glange, it seems that filePath and options are passed at the same time in https://github.com/Unibeautify/unibeautify-cli/blob/da0006c8f92c268159be8cf833a93a9f653fc58f/src/Runner.ts#L33 so filePath doesn't have the chance to affect where options are loaded from. Does Unibeautify core do its own options parsing based on filePath?

Loading a .unibeautifyrc.yml file does not work yet.  When it will be supported, it will likely need to be passed in via the -c flag, but we'll see.

That's OK. I would suggest looking up .unibeautifyrc* based on the pathname of each beautified file by default (or from --file-path when given) since clang-format, git and countless other programs use a similar method. --config-file would override all of these, if given.

Closed with #25


RDK-32883 - fix rdkshell ignore environment variable issues

https://jenkins.code.rdkcentral.com/job/github-triggered/10042/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/35029/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/4848/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/10793/ started.

Smoke tests for ['build-brcm-refboard'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/89137/

Smoke tests for ['build-rpi-hybrid-refapp2-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/89146/

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/89147/

'['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next']' Smoke test FAILURE, investigation pending.
Flash MC [SUCCESS]
Flash HYB [SUCCESS]
MC - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
Video Streaming using rmfApp [FAILURE]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
Number of success test - 38
Number of failed test - 2
Video Streaming using rmfApp [SUCCESS]
HYB - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
Number of success test - 38
Number of failed test - 2
https://jenkins.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/26571/


Allow FIFO pool in redis client

Linked issue: #1819
Allows the user to choose between fifo and lifo pool via passing in the PoolType variable into redis.Options.

Other clients, we should also add it, for example: cluster, ring, sentinel, universal...


Port camera feed to the new RenderingServer API.

Implements CameraFeed texture creation/update with the API. Original CameraFeed code was commented out after Vulkan transition.
Test project:
camera_test.zip

Thanks!


Can't detune one of the MonoSynth when using it in a DuoSynth in a PolySynth

Please see this simple example: https://stackblitz.com/edit/tone-js-issue-602
As you can see, I tried detuning the MonoSynth, but that didn't work. So I tried to detune it's OmniOscillator, but that didn't work either.
Do you have anything I could use/hack with the internals or something? I would like to make it work quickly in the short term.
Cheers!
Edit 1
Also tried using the set method, but it doesn't work.
Edit 2
Same thing occurs with the volume (can't set the volume of individual voices). I guess it occurs with every param.
Edit 3
Updated example
Edit 4
Nvm, it works well with the volume.
Edit 5
Also there is now way to attach an LFO to each MonoSynth (voice1/voice2 of the DuoSynth) as it was previously possible in the non-typescript branch. Should I create a new ticket for that?

The detune for DuoSynth is on the top level object not the individual voices/oscillators.
https://stackblitz.com/edit/tone-js-issue-602-qgji3r?file=index.ts
In order to avoid having the same parameter being settable in multiple places, i've hoisted the inner detune values wherever possible as in this case of DuoSynth and MonoSynth. The detune is not settable on the oscillator object, just on the synth itself. TypeScript makes it easier to enforce this behavior which wasn't as easily possible in previous versions of Tone.
If you'd like a detune between the two voices, i would use the harmonicity parameter to do that.
Not sure why it wouldn't be possible to set an LFO on either of the voices. Please open an issue for that.

Got it! The harmonicity param isn't flexible enough though, so maybe keep that as a feature request for the future?
Cheers!

Im curious why the harmonicity param isn’t flexible enough?

Let me know if I'm wrong, but I don't think the harmonicity param would let me, let's say, detune oscillator/voice 1  to -2443 (~-2 octaves) and detune oscillator/voice 2 to 3589 (~+3 octaves).

I think something like this should work. obviously a little more verbose, but avoids the issue of having multiple parameters controlling the same thing.
const difference = (3589 - -2443) // the difference between the two is the harmonicity ratio
const interval = difference / 100 // convert it from cents to semitones
synth.harmonicity.value = Tone.intervalToFrequencyRatio(interval)
synth.detune.value = -2443 // set the base offset

Nice, that worked! Thanks a lot.
private setPolySynthHarmonicityAndDetune(
	octaveOsc1: number,
	detunePercentageOsc1: number,
	octaveOsc2: number,
	detunePercentageOsc2: number,
	isSettingOsc1: boolean
) {
	const osc1DetuneInCents =
		octaveOsc1 * CENTS_PER_OCTAVE +
		detunePercentageOsc1 * CENTS_PER_OCTAVE
	const osc2DetuneInCents =
		octaveOsc2 * CENTS_PER_OCTAVE +
		detunePercentageOsc2 * CENTS_PER_OCTAVE
	const difference = isSettingOsc1
		? osc1DetuneInCents - osc2DetuneInCents
		: osc2DetuneInCents - osc1DetuneInCents
	const interval = (isSettingOsc1 ? -difference : difference) / 100
	const harmonicity = Tone.intervalToFrequencyRatio(interval)
	const detune = osc1DetuneInCents

	this.synthAudioNodes.polySynth.set({ harmonicity, detune })
}

Some logic needs to be reversed when setting voice1 or voice2.
Cheers!


Make event handler / lambda args optional

Currently the following code doesn't work:
    pc.select(
        SpreadsheetState.worksheets,
        placeholder="Select A Worksheet",
        on_change=[
            SpreadsheetState.set_selected_worksheet,
            SpreadsheetState.show_columns,
        ],
    ),

because the on_change for select takes in a value. Currently you have to do this:
lambda _: SpreadsheetState.show_columns()

We should make both the lambda arg and the event handler arg optional

If we have the following select component:
pc.select(
    ["hello", "world"],
    on_change=[St.ev1, St.ev2]
)

We could have either:

All the EventHandlers from the chain receive the arg from on_change (ev1 & ev2 need correct signature)

def ev1(self, arg):
    ...

def ev2(self, arg):
    ...

Only the first EventHandler ev1 receive the arg from on_change (ev1 need correct signature, ev2 doesn't expect anything)

def ev1(self, arg):
    ...

def ev2(self):
    ...

Optional args => ev1 and/or ev2 are allowed to have incorrect signature, but only if they expect less args than returned by the event.

def ev1(self):
    ...

def ev2(self):
    ...

Option1 is the current state of things, and admittedly not what we want, so not considering it.
Option2 work with the first example provided, but doesn't allow as much flexibility as Option3.
Option3 has the risk of not raising any error when users provide an EventHandler with incorrect signature.
We could mitigate the risk if the optional args are only applicable within an EventChain?

I think we need to stay tight on the number of parameters, otherwise we may have maintenance problems when the code base becomes larger, because we will dynamically decide the number of parameters to pass in at runtime, and if developers don't pay attention to the documentation, they may introduce code that is difficult to understand.


Update use of fx vars to new syntax

Description

Changes in ESMValTool recipes and scripts due to https://github.com/ESMValGroup/ESMValCore/pull/999

Closes #2108
Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[ ] 🛠 This pull request has a descriptive title
[ ] 🛠 Code is written according to the code quality guidelines
[ ] 🛠 Documentation is available
[ ] 🛠 Tests run successfully
[ ] 🛠 The list of authors is up to date
[ ] 🛠 Any changed dependencies have been added or removed correctly
[ ] 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

[ ] 🧪 Recipe runs successfully
[ ] 🧪 Recipe is well documented
[ ] 🧪 Figure(s) and data look as expected from literature
[ ] 🛠 Provenance information has been added

New or updated data reformatting script

[ ] 🛠 Documentation is available
[ ] 🛠 The dataset has been added to the CMOR check recipe
[ ] 🧪 Numbers and units of the data look physically meaningful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

I was surprised too! But shouldn't this be merged after ESMValGroup/ESMValCore#999 ? I think the recipe and cmorizers will break otherwise, with the change in the interface.


sign command

A generic sign command should be available, which will take keywords or a path to a file, just like the sign_doc function. This will let users sign newly updated files, like the ledger after making a new entry.
gg sign ledger
gg sign /path/to/document.md

Git Guild Bounty Program

Total
Dev
Sales
Reporter
Tester(s)
Maintainer
Documenter

N/A
assignee(s)
N/A
@isysd
@isysd, @d3brouille
@isysd
@d3brouille

$261.25
$165.00
$0.00
$13.75
$55.00
$13.75
$13.75


Increase code coverage to >=80%

Hi, @markbates!
I try to add pkger to awesome-go list, but the last stop-thing is code coverage. To add, package's code will be >= 80% coverage, but 56.7% now.
@panjf2000:

Please check out why some CI checks failed first, besides there are still several sections of report-card doesn't reache 100%, please also resolve those, in the end, please increase your code coverage to >=80%(it is 56.7% now).

Can you please increase this thing? 👍

Theyre using flawed metrics. They’re looking at one package results and not the whole project, which is a very poor way to judge any project. That package contains almost no code as it’s mostly used for static analysis in project code and instead pushes almost all work to sub packages. So there’s tests to write, and I, personally, don’t have time to write tests to satisfy their metrics that don’t provide any actual test coverage. If others want to satisfy their conditions, I’ll leave this ticket open.
--
Mark Bates

On Dec 3, 2019, at 3:33 AM, Vic Shóstak<EMAIL_ADDRESS>wrote:

Hi, @markbates!
I try to add pkger to awesome-go list, but the last stop-thing is code coverage. To add, package's code will be >= 80% coverage, but 56.7% now.
@panjf2000:
Please check out why some CI checks failed first, besides there are still several sections of report-card doesn't reache 100%, please also resolve those, in the end, please increase your code coverage to >=80%(it is 56.7% now).
Can you please increase this thing? 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Apply some design

Hi !

So, I have the camera that I can launch from await CrossMedia.Current.TakePhotoAsync(new StoreCameraMediaOptions..., but how to use it as an XAML element?
Because I would like to add some controls onto the camera view.. Also, how can I close the process if the user is pressing one of these controls?
Thank !

It only launches the default camera application to take/pick a photo. There isn't XAML element required for it at all. You can put it in an Image after that to display in your app.


Create the server.properties from a template

Moves the creation of the default server.properties from inside the PreDevServer task to simply copying it from a template file.
The template is the same as before, with the exception of enforce-secure-profile being false.

Is automatically setting enforce-secure-profile to false in the development environment really a good idea?
This is not a deployment environment, so I don't think chat reports are a big problem here. Setting such parameters automatically can lead to unexpected behavior for the developer. For example, if someone wants to use PaperMake when creating a plugin to disable chat reporting system, setting this option implicitly will create unexpected behavior.
I believe that automatically set parameters should not affect the global mechanics of the server. max-tick-time is needed for breakpoints to work correctly, and motd just allows you not to lose the dev server in the list of servers. But enforce-secure-profile may directly conflict with the plugin being developed, so I think that if necessary, the developer is better off manually changing this setting in server.properties.
Correct me if I'm wrong

enforce-secure-profile only stops clients from connecting if they don't provide a public key, other than that, it has no effect on the server as far as I'm aware. The reason I had disabled it initially is that it's a slight annoyance with the No Chat Reports mod. I'll remove it from the template if you'd like.

I think it might be better to implement the ability to specify standard values for the server.properties fields through the launch options instead of templates. This will allow you to set the desired configuration in the IDE, and then, for example, after clearing the gradle cache, it will run with the desired settings, without requiring manual configuration each time

Something like pmake.serverprops="pvp=false gamemode=creative"?

Yes

Alright, I can create a PR for that tomorrow. Do you still want a template for the two defaults that would be able to be overridden with the flag? If not this can just be closed and I'll make a new PR.

I think that there is no need for a separate template file, given that we have only 2 default values, and it is unlikely that there will be more in the near future. So I will close this PR


Support for Spring JDBC template

Nothing in progress right now. Contributions would be gratefully accepted.
Possibly we could go down to the driver level (and get support for JPA as well that way) as well. Zipkin (and Brave) already have some MySQL driver support for instance.

I will more look Zipkin and Brave support for Driver or atleast Datasource level.
BTW, off-topic from JDBC support, Sleuth also doesn't provide support for STOMP messages over websockets using Spring websocket. I have written interceptor to provide support in case of STOMP messages and will create Pull Request when I am fully sure it is correctly doing its work.

@dsyer
In recent weeks, I have looked into many JDBC drivers and connection pool libraries, None is supporting elegant support for adding hooks for intercepting database calls. MySQL provide StatementInterceptorV2. MongoDB has some event support but at connection level. Apache Tomcat connectionpool has JDBCInterceptor, not sure if anyone will use Apache Tomcat JDBC pool. Any pointers/suggestions how to proceed with this?
Will doing similar to p6spy a nice to have or it is just over kill for tracing db calls?

my2p
StatementInterceptorV2 is tough, iirc, as it needs to be supplied in the
JDBC url. This means it needs to look up static state, if I'm not mistaken.
Here's an example:
https://github.com/openzipkin/brave/blob/master/brave-mysql/src/main/java/com/github/kristofa/brave/mysql/MySQLStatementInterceptor.java
Another choice is to instrument at a higher level, such as JOOQ. Here's an
example of that:
https://github.com/openzipkin/zipkin-java/blob/master/zipkin-java-server/src/main/java/io/zipkin/server/brave/JDBCTracerConfiguration.java
Both of the above are modeled after finagle-mysql, which is a
protocol-level driver
https://github.com/twitter/finagle/blob/develop/finagle-mysql/src/main/scala/com/twitter/finagle/Mysql.scala#L48
All of the above are logging relatively high-level data, such as the type
of statement and whether or not it finished. These are a good start for
latency analysis.

@adriancole  Thanks for the pointer. Does that mean instrument most of the libraries will be the solution for JDBC tracing viz. JOOQ, Dalesbred, Spring JDBC etc.(written support for last two though :)) like wrapping up these libraries  or connection pools which have this kind of support.

there are tradeoffs to each decision.
Picking integrations explicitly is less magical code, albeit repetitive.
Using JOOQ (or anything with a nice interceptor abstraction), you can write
succinct (usually <100loc) integration. I'll call this the library approach.
Seeking out a single portable solution across all the libraries (and
versions therein) is its own problem space. I'll call this the agent
approach.
For example, pinpoint has a sophisticated JDBC library plugin thing which
other things extend. This is substantially more harder to test and higher
maintenance code, but the end effect is a black-box which drops in
anywhere:
https://github.com/naver/pinpoint/tree/master/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/jdbc

I guess we can close this one...

FYI this is hard to hook into (as it deals at JDBC driver level), but might be a way-out
https://github.com/p6spy/p6spy
It has a implementation in Brave folks could take a look at.
https://github.com/openzipkin/brave/tree/master/brave-p6spy

What would you think about an aspect based approach on JDBCTemplate method invocations? Could name the span something like jdbc:/jdbcTemplateMethodName. While it wouldn't be able to distinguish between two calls, it would be useful for applications where an http call has a small number of db requests attached.
I would take an approach similar to the RestTemplate approach while assuming the db isn't able to do its own capturing of the trace information. Any thoughts before I spend some time working on this?

ok, simplest pass first, ill need to change up the injection strategy but i just dropped this into a sample app:
package sample;
import org.aspectj.lang.ProceedingJoinPoint;
import org.aspectj.lang.annotation.Around;
import org.aspectj.lang.annotation.Aspect;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.cloud.sleuth.Span;
import org.springframework.cloud.sleuth.Tracer;
import org.springframework.cloud.sleuth.util.SpanNameUtil;
import org.springframework.stereotype.Component;

@Aspect
@Component
public class JdbcTemplateSleuthAspect {
  Tracer tracer;

  @Autowired
  public JdbcTemplateSleuthAspect(Tracer tracer) {
    this.tracer = tracer;
  }

  @Around("execution (* org.springframework.jdbc.core.JdbcTemplate.*(..))")
  public Object traceBackgroundThread(final ProceedingJoinPoint pjp) throws Throwable {
    String spanName = SpanNameUtil.toLowerHyphen(pjp.getSignature().getName());
    Span span = this.tracer.createSpan("jdbc:/" + spanName);
    try {
      return pjp.proceed();
    }
    finally {
      this.tracer.close(span);
    }
  }
}

@jmcshane , can you please tell me how you wired Tracer, we are planning to implement DT (Distributed Tracing)  for Non boot ( Spring MVC) application. trying for help on how to ingest Tracer and invoke sleuth framework.

This issue relates to https://github.com/spring-cloud/spring-cloud-sleuth/issues/693


variables are not properly printed

branch: 262
$ echo $USER gived the variable with one missing character at the end

seems to be a strange problem, maybe only on my computer? to test


Support long double

Fixes #1003, or so I hope

@DerWeh waiting for your feedback, all green on my side.

Sorry that I didn't respond. I am currently very busy and my computer problems. I will respond as soon as I can.
I don't that there are any issues thanks for your fast help.


Remove duplicates in .chezmoiexternal.yaml

This PR is a continuation of https://github.com/felipecrs/dotfiles/pull/46, made by @MuXiu1997.

@MuXiu1997 thanks a lot!

Thank you for your recognition as well～


[CSClosure] Use rewritten expression when applying solution to a brac…

…e statement
It went un-noticed because currently only single-statement closures
using this logic and their bodies are modeled as a single return statement.

@swift-ci please smoke test

@swift-ci please Windows platform

@swift-ci please test Windows platform


ci: downstream, add resources download to molecule

@guidograzioli not sure if it worth investigating. If not, just close this PR.

no worries, the failure is a new linter rule (which is demoted to warn in HEAD)


Remove node_modules from the repo

Seems like these were mistakenly committed since they have been .gitignored

Ah yes, Thanks @gldraphael

You're most welcome!


react-infinite-scroll-component is no longer maintained

I see that repo is not longer maintained while suffering from major issues and not adding more functionality like "error component, in case next failed".
@ankeetmaini can you please notify if you will to maintain it?
In case no reply comes in 1 month, I would suggest to create a new main fork with new npm package and maintainers willing to cooperate.

Sounds logic

I agree with the concerns you've raised about this repository, @IhnatKlimchuk.
Unfortunately, despite waiting for a month and reaching out to @ankeetmaini for a response regarding maintaining the repository, we haven't received any communication.
I think it's time to create a fork.

For anyone looking for a React infinite scroll implementation, I suggest using React Query with Intersection Observer.
I tried all the popular React infinite scroll packages, and all of them were either not well-maintained or had some bugs. This solution is much better and simple enough to use.
Here is an example: https://tanstack.com/query/v4/docs/react/examples/react/load-more-infinite-scroll

Any news on the project status or an established fork?

@zeraye thanks!


bug: Pause button doesn't switch back to Play button upon sound termination

I'm interested in how to go about solving this.

Fixed in #55


should select the right bridged network interface automatically

from: #262

@phuonglm the changes did not work with my recent checks:
macbook-pro:teracy-dev hoatle$ vagrant destroy
==> default: VM not created. Moving on...
macbook-pro:teracy-dev hoatle$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Importing base box 'bento/ubuntu-16.04'...
==> default: Matching MAC address for NAT networking...
==> default: Checking if box 'bento/ubuntu-16.04' is up to date...
==> default: Setting the name of the VM: teracy-dev_default_1502135795273_1652
==> default: Using hostname "teracy-dev.dev" as node name for Chef...
==> default: Fixed port collision for 22 => 2222. Now on port 2200.
==> default: Clearing any previously set network interfaces...
==> default: Specific bridge 'en0: iPhone USB' not found. You may be asked to specify
==> default: which network to bridge to.
==> default: Available bridged network interfaces:
1) en0: Wi-Fi (AirPort)
2) en1: Thunderbolt 1
3) en2: Thunderbolt 2
4) p2p0
5) awdl0
==> default: When choosing an interface, it is usually the one that is
==> default: being used to connect to the internet.
    default: Which interface should the network bridge to?

verified, closed.


Load only encoder part of model

Hello, thank you for releasing this model's code as well as pretrained weights.
How can I load only the image encoder (ViT) portion of the pretrained SAM model? I want to use it as a backbone for a different downstream task.

The image encoder model can be found the in image_encoder.py file, specifically it's the ImageEncoderViT class that you'd want to use.
You'd have to instantiate that class with the appropriate input arguments (which depend on the size of the SAM model you want to use, i.e. vit-b vs vit-l vs vit-h), you can see what those arguments are from the build_sam.py file.
Then finally, you'd load the appropriate state dictionary (i.e. checkpoint file). However, the checkpoints assume that you're using a model (class) that has the image encoder stored under a variable called image_encoder (i.e. self.image_encoder), since that's how the SAM model is structured.
You'd need to match this structure if you just wanted to be able load the state dictionary as-is (you'd also need to make sure to not use strict mode when using load_state_dict, since the checkpoints contain the prompt/mask model weights, that likely won't match your custom model). Alternatively, if you're comfortable editing the state dict, you could just modify it to match whatever your model expects.

Thank you! Setting the strict=False was the key to making it work.


Correct issue with double inputs on multicheckbox

Checkboxes are already rendered inside the {{label}} element.

Tests needed.

Tests are for sissies, just wing it :P
Will push them just now.

Added a test.

@dakota You need to rebase, the PR is no longer mergeable.

@ADmad Rebased

Thanks @dakota :)


Can't find downloaded videos

Hi, thanks for this amazing app.
I downloaded some videos to test your app.
the application says ALL DONE and in Queue tab I can see all of them is downloaded with 100%. but I can't find it in my videos folder. why is that?
I've also changed the save folder and tried again with no luck.

Did the problem solve itself? I see you closed this issue but you didn't say if you managed to solve it or not


Failed to deploy

n8n failed to deploy

n8n failed to deploy
It worked fine for me just 5 minutes ago.

Please expand on your problem if you need people to assist you.