feature/scope limits

Limitations considered and should function:
When a service provider user logs into the system, the UI must be modified for them in the following aspects:

+The service provider dropdown at the top of the view is removed.
+The Settings panel includes only the Service Provider tab
+The User dashboard allows the logged-in user to view only users associated with the current service provider
+to create other service provider user accounts (for the same service provider)
+to delete accounts for the same service provider.
+the data shown in all other panels shall be restricted to the current service provider.
+service provider users shall create/edit/delete new users at the account level, by selecting an existing account that falls under their service provider.

When an account-level user logs into the system, the UI shall be modified for them in the following aspects:

+The Settings panel is removed
+The account list is removed (since there is only one account)
+A new Account panel is available on the left-hand side menu, it shows the current Add/Edit the current user Account panel
+account users shall create/edit/delete new users at the account level, that falls under their service provider +account.
+Recent Calls and Alerts are filtered to show only the calls and alerts for this account
+The carrier panel continues to list all of the carriers defined for the account or service provider
+Carriers can only be added at the account level.
+only the account-level carriers can be edited or deleted.
+The speech panel continues to list all of the speech credentials
+only the account level credentials can be edited or deleted.

@kitajchuk there is also some error in the console about icons being defined popping up sometimes from chunk.js. I am not too sure what is causing it. Seems like an unresolved promise.

@kitajchuk I am really stuck with the things above. Not sure if I am working too long on this, but my brain is fried, seems like simple things, but I cannot find solutions. Let me know if you have advice on any of the above. Thanks a lot.
complementary branch on api server: https://github.com/jambonz/jambonz-api-server/pull/80

It seems like when I am logged in as 'admin' user I am unable to create a Carrier at the account level ("Used by" is set to all accounts and is disabled.

As an account level user (for the "default account") I added a carrier (twilio) and it said it was saved succesfully.  However, it then does not appear in the carrier list for that user

As an account level user, when I log in and choose the Speech Services list, the dropdown includes "all accounts", "default account" -- this is the associated account of the logged in user, but also includes "account 2" which is a totally different account that I created under this SP.  This is wrong, an account level user should not be able to any other account appear in any list view or dropdown -- ie it should be considered "off limits" for an account user to know of the existence of any other accounts under his/her service provider
Note that the similar dropdown for the Carriers list does seem to be filtered properly (ie for my user showed only "all accounts" and "default account")

@davehorton I addressed all the issues above, please re-review.

as 'admin' user, I created another admin user (admin2).  The user was saved, but the "edit user" window immediately opened for that new admin user, however scope showed "Service Provider"

The text of the labels for the checkboxes below for custom speech for Microsoft azure should be changed to

"Use a custom voice"
"Use a custom speech model"

As an account level user I should not be able to view sip or smpp password information for a carrier created at the service provider level.

and

I should not have been able to view either of those.  The easiest way to hide might be to disable or hide the button on the right side of the password fields in both forms

Now that we have multiple users support, I think we should show somewhere the username of the currently logged in user along with their scope.

I think on the users list view we should add a column to the right, which is populated as follows

account scope: show the account name
service provider scope: show the service provider name
admin scope: leave blank

Currently, the view looks like this below, which will make it not so useful when we have lots of users across different SPs and accounts
Additionally, it should be easy to filter the view for a single service provider or account by name

Use a custom

I agree with showing the account name for account users it belongs to and just by listing it the fuzzy search will pick it up, so that is easy enough to add.
But service provider is the always the current.

"There are also authentication fields in Account/Application, any of those also need disabling?"

Thats a really good question.  Applications are at the account level, so if you are an account user looking at an application, it must be "your" application so I think we are all set there.  Ditto accounts -- I think as an account user you are all set.
So I suppose the question is, should a service provider be able to see the applications that an account has set up, and see the api keys.  And possibly the http basic auth that an account has set up.
On the one hand, there is an argument to be made that a service provider should not be able to see, for instance, the api keys that an account has created, because otherwise they could use them maliciously somehow.
On the other hand, it will be a common case that service providers will want to handle all of the provisioning for sub-accounts.
Given those two competing scenarios, I am ok leaving it as currently working -- service providers can have all rights (e.g. create and view api keys) for their sub-accounts.

I see this API failing in console—what's up with that? I am using the user api branch for the server backend...

@kitajchuk waiting for @davehorton to push this fix, since he did not want to jwt encode the username, he will fix the Users/me to be used by all systems not only hosted ones.

I see this API failing in console—what's up with that? I am using the user api branch for the server backend...

@kitajchuk waiting for @davehorton to push this fix, since he did not want to jwt encode the username, he will fix the Users/me to be used by all systems not only hosted ones.

Yes, that is because that particular API has only been used till now in the hosted version of jambonz, where every user is an account user.  I am going to fix that shortly (today)

please pull the latest jambonz-api-server on the feature/user-api-calls to resolve the issues calling /Users/me @kitajchuk  @EgleHelms

@EgleHelms can you make sure your problematic redirect code is pushed either here or on another branch pointing at this one so I can troubleshoot your problem? Thanks 🙏

@EgleHelms @davehorton I put up a PR against this branch with the changes to get that scoped redirect hook working.
https://github.com/jambonz/jambonz-webapp/pull/164
Really the only issue there was that since the user coming from our store state can be undefined, e.g. user?: UserData; we need to account for this in the hook implementation. Optional parameters cannot come before required parameters when typing function arguments so I simply moved the args order. Then with the hooks effect we just need to actually check that user  is not undefined before proceeding with our logic and possible redirect 👍

hi @EgleHelms  @kitajchuk what is the status of this PR / branch from your perspectives?  I see it needs to be rebased on main, but is it otherwise ready to merge? What is outstanding?

hi @EgleHelms @kitajchuk what is the status of this PR / branch from your perspectives? I see it needs to be rebased on main, but is it otherwise ready to merge? What is outstanding?

Still things I am finishing-up/working on:

adding redirect restriction according to resource not only route (e.g. manually entering links with account sid will not work if the user is not the owner of that resource)
Idea of merging Carrier/Speech lists to include both all and account-specific entries from Account users - @davehorton you can let me know if I should address this in this branch
Still need to fix the Links for Carriers that were doubling (have a fix but did not commit because of the point above that is related)

I do want to do your point 2 above, but lets merge this branch after 1/3 are done and then create a new feature branch for that.

I don't know how to rebase this without merging  main.

I am sorry, I don't know how to rebase this without merging main into this branch, needed to undo one faulty try to rebase the conflict that occurred.

The button on GitHub let’s you choose to rebase update from main. Otherwise I always do it locally: git pull origin main --rebase

I am sorry, I don't know how to rebase this without merging main into this branch, needed to undo one faulty try to rebase the conflict that occurred.

The button on GitHub let’s you choose to rebase update from main. Otherwise I always do it locally: git pull origin main --rebase from your branch…

Yeah, the commands I know, but I initialize a rebase and the button said there is a conflict, fix the conflict and try to complete the rabase and I then get a message that I should still pull changes, and that results in another merge of main. When I do pull origin main before the rebase it says my branch is up to date.  So I dont know how to fix that without a merge.

I am sorry, I don't know how to rebase this without merging main into this branch, needed to undo one faulty try to rebase the conflict that occurred.

The button on GitHub let’s you choose to rebase update from main. Otherwise I always do it locally: git pull origin main --rebase from your branch…

Yeah, the commands I know, but I initialize a rebase and the button said there is a conflict, fix the conflict and try to complete the rabase and I then get a message that I should still pull changes, and that results in another merge of main. When I do pull origin main before the rebase it says my branch is up to date.  So I dont know how to fix that without a merge.

When you rebase locally (e.g. resolve conflicts) you have you force push your branch back up because you’ve changed the history of your branch otherwise you will have this issue you are describing. Merges of main or your own branch into your branch are not desirable. If your local branch feels borked you can always get your state prior to the rebase/merge issues from git reflog.

@kitajchuk I think I was successful in rebasing. Thanks for the help. So the procedure should be rebasing every day starting work to always be up to date with the main (if it is such a long PR)? Is this the result that I am not doing it enough?
I think now this is ready for the last reviews.

@kitajchuk I think I was successful in rebasing. Thanks for the help. So the procedure should be rebasing every day starting work to always be up to date with the main (if it is such a long PR)? Is this the result that I am not doing it enough?
I think now this is ready for the last reviews.

Not necessarily. You can rebase whenever you feel like it. In this case I’m guessing you got conflicts with files from the other scoped limits work that was merged. It happens. No big deal.

I've tested and it looks good to me.  @kitajchuk can you give a review and let us know if if this is good to go?

I've tested and it looks good to me. @kitajchuk can you give a review and let us know if if this is good to go?

I’ll check it out now 🤔

I am super confused, why does it need rebasing again, locally I needed to fetch and I got the latest rebased version of this branch, and then still needed to force-push my changes for whatever reason since I could not push it otherwise.
It is only me working on this project currently, and nothing was updated since the "IBM fix" merged to main. So why is there a need to do this again?

@EgleHelms @davehorton I will take a look today to help fix the issues with the conditional react hooks.

@kitajchuk, I didn't see any changes pushed. ;/ hope you still have time today

@kitajchuk, I didn't see any changes pushed. ;/ hope you still have time today

Yes sorry. Yesterday ended up too busy. I will prioritize it for today since I know you’re on a tight timeline here.

@EgleHelms @davehorton when i log in as a service_provider scope i still see the service provider selector in the side menu...my understanding is this is supposed to be hidden? or maybe we just want it to be readonly or something?

@EgleHelms @davehorton when i log out as one user type and back in as another i often see this bad redirect and toast. seems to happen often if i log out of account or service_provider scope and then login as admin:

@davehorton @EgleHelms PR here for changes:
https://github.com/jambonz/jambonz-webapp/pull/168
But I have some questions/concerns about some things.

@EgleHelms @davehorton when i log in as a service_provider scope i still see the service provider selector in the side menu...my understanding is this is supposed to be hidden? or maybe we just want it to be readonly or something?

I'm ok either making it readonly or if the dropdown only has the one selection

@kitajchuk @davehorton
I have applied these changes:

removed comments that were merged from @kitajchuk PR questioning some unneeded conditions - seems those conditions were not needed.
made serviceProvider selector read-only by disabling it
removed Account filters from the Account user views where they should not see other account information but had to then conditionally assign an accountSid of the user for lists to be correctly fetched. This way we have gotten rid of some of the getUserAccounts filtering. ( This point was applied to Users, Applications, Recent Calls, Alerts, Phone Numbers views) - I was not sure if there is a need to do this for the MS teams list (let me know)
used parseJwt to address the issue of the "user" state is wrong when logging in as a different user and using rerouting. I could not see any other solution for this, @kitajchuk is there one?

The current state of the main branch on jambonz-api-server seems to still allow everything we need on the frontend so far, but there are still a getUserAccounts cases.
I would suggest then the backend allows fetching the accounts from /ServiceProvider but for Account scoped user gets one account in an array, this way we can remove the filtering for the account filter and have the structure on the frontend work correctly, I think.

One more thing, how do we resolve conversations from commits that don't exist anymore?
Two conversations I seem to not be able to get to anymore.

@davehorton @kitajchuk I would suggest then the backend allows fetching the accounts from /ServiceProvider but for Account scoped user gets one account in an array, this way we can remove the filtering for the account filter and have the structure on the frontend work correctly, I think.

Agree,

@davehorton @kitajchuk I would suggest then the backend allows fetching the accounts from /ServiceProvider but for Account scoped user gets one account in an array, this way we can remove the filtering for the account filter and have the structure on the frontend work correctly, I think.

Agree,

Yes that would be ideal so we don’t need to worry about a difference in the data structure 👍

@davehorton @kitajchuk I would suggest then the backend allows fetching the accounts from /ServiceProvider but for Account scoped user gets one account in an array, this way we can remove the filtering for the account filter and have the structure on the frontend work correctly, I think.

Agree,

Yes that would be ideal so we don’t need to worry about a difference in the data structure 👍

I have pushed a change to the bugfix/fix-permissions branch of jambonz-api-server that allows account users to access the /ServiceProviders api but filters the data returned so as to not give them visibility into other account info or service provider info that should be off limits.  Next step I think is for @EgleHelms to push a change where she has removed the filtering on the webapp side, as it should now not be needed.

I pushed a change (above) to remove that account filter as it is no longer needed.  I also merged the accompanying change on the jambonz-api-server to the main branch.

@davehorton I get a 403 forbidden when attempting to create a new user with an email that exists for another user already. This isn't a very useful response because the web app can only toast generically like "something went wrong". It would be good to leverage our error responses that have the custom msg field so we can be more clear about these issues 🤔

@davehorton Looks like as an account user I am told I don't have proper permissions to create a carrier from a predefined option. However, when I go back to the list view and switch the account filter I see the carriers were saved on the backend still...

@davehorton Also on the users table view I am able to filter by all scopes even when I'm logged in as service_provider or account level scope which seems like my scope filter should match based on my create capabilities 🤔

@davehorton @EgleHelms I pushed a couple commits to clean a few things up. I have a couple open questions above so once those are clarified/addressed things look good on my end 👍

@davehorton Looks like as an account user I am told I don't have proper permissions to create a carrier from a predefined option. However, when I go back to the list view and switch the account filter I see the carriers were saved on the backend still...

Hmm..the issue here is that we have created a Carrier at the Account level, yet then when we want to update it we do a PUT to /ServiceProviders/:sid/VoipCarriers/:voip_carrier_sid.
I think the webapp should be doing a PUT to /Accounts/:sid/VoipCarriers/:voip_carrier_sid instead, as that is more appropriate.
The only problem is that the back-end has not implemented that second API yet.  But I think the right thing is for me to implement that, and then for the front end to use that api when updating an account Carrier.
Do you agree @kitajchuk ?

I've pushed a change to jambonz-api-server main branch to add the PUT /Accounts/:account_sid/VoipCarriers/:carrier_sid.
I suppose, though, if it is easier I can change the backend to allow an account level user to access that specific service provider api.

I've pushed a change to jambonz-api-server main branch to add the PUT /Accounts/:account_sid/VoipCarriers/:carrier_sid.
I suppose, though, if it is easier I can change the backend to allow an account level user to access that specific service provider api.

I think using this api is better as it is in line with our other account specific apis. I can make the change here

@davehorton The new account-level PUT api for carriers is implemented with this commit:
https://github.com/jambonz/jambonz-webapp/pull/159/commits/ccca4da4c2eaaf38ec6b3270d66f677a0430be08

@davehorton The new account-level PUT api for carriers is implemented with this commit: 9ae4a0b

Looks good in my testing!

@davehorton Also on the users table view I am able to filter by all scopes even when I'm logged in as service_provider or account level scope which seems like my scope filter should match based on my create capabilities 🤔

I agree that the selections in the Scope dropdown should be filtered:

admin user sees all
sp user sees only service provider and account
account user sees only account -- or, better, the dropdown is hidden entirely since it has only the one selection

@davehorton I get a 403 forbidden when attempting to create a new user with an email that exists for another user already. This isn't a very useful response because the web app can only toast generically like "something went wrong". It would be good to leverage our error responses that have the custom msg field so we can be more clear about these issues 🤔

I pushed a commit to jambonz-api-server to return a json payload with msg so now this does show the toast.  Thanks for the idea!

@davehorton Also on the users table view I am able to filter by all scopes even when I'm logged in as service_provider or account level scope which seems like my scope filter should match based on my create capabilities 🤔

I agree that the selections in the Scope dropdown should be filtered:

admin user sees all
sp user sees only service provider and account
account user sees only account -- or, better, the dropdown is hidden entirely since it has only the one selection

I think currently the filter is already hidden for account users so would just need to properly filter what scopes are present for sp since admins see all.

Wow, nice work you guys are lightning fast. Thanks for pushing this to the finish line.
@kitajchuk I cannot get to the unresolved conversations anymore to resolve them probably because rebasing it is 404 when i click on the two conversations, I feel like I answered those too that time. Can you let me know what are the other questions? I feel like I cannot find anything else unanswered.

@kitajchuk is this ready to merge from your perspective?

@kitajchuk is this ready to merge from your perspective?

I think maybe the account filter scoping hasn’t been implemented?

@davehorton @kitajchuk I pushed a small commit to add the filtering for the User list according to user scope.
Hope this is now ready to be merged.

@davehorton @kitajchuk I pushed a small commit to add the filtering for the User list according to user scope.
Hope this is now ready to be merged.

Ya that commit looks good 👍. I’d say if @davehorton has smoke and poked this and it looks good then you can squash and merge this PR 🎉


Search fix watson references to deleted findings

I found out that if you delete findings from Defect Dojo, they remain behind in the watson search index.
It might work if findings are deleted via DD because it will use pre delete signal. But sometimes people cleanup via database queries and run buildwatson to rebuild the index. however even after running buildwatson to rebuild the index, the search entries remain. So we have to check if objects connected to searchentries still exist before trying to render them to prevent the template from crashing with a 500 error.
I've asked django-watson for info: https://github.com/etianen/django-watson/issues/276
The PR basically adds some ifs here and there, but also some indentation changes it seems.

issue has now been confirmed by watson but no quick bugfix expected, so this PR is still needed.


fix(app): fix auto transitioning run from recovery-paused to waiting recovery

Closes EXEC-702

Overview
In https://github.com/Opentrons/opentrons/pull/16245, we made sure to block an open door while on the recovery splash view, but the logic for automatically transition a run from paused -> awaiting recovery is not quite right, which results in the app seemingly automatically issuing a POST play to transition a run from a recovery paused state to awaiting recovery whenever a user opens the door during error recovery flows (ie, anywhere but the splash screen). The tricky part is that when checking the network tab, there are no POST requests to initiate the transition.
This problem occurs because another app issues the POST request. The logic for dispatching this POST in the useEffect condition within RecoverySplash is to check if the error recovery wizard is active, but this doesn't account for any other app that isn't doing the recovery. The solution: if the current app displays the takeover modal (which is true for any app except the sole app controlling the robot), then don't fire the POST request.
Note that this regression is recent - there hasn't been an alpha containing this bug yet.

Test Plan and Hands on Testing

Verified the door open modal during error recovery no longer automatically resumes. To verify, have the desktop app open and following along the ODD (you'll need to push this branch to an ODD).

Changelog

Fixed the app automatically "clicking" resume after closing a robot door during Error Recovery.

Risk assessment
low

Lovely! such an annoying bug ;-) thank you for fixing this!

Yes it was 🙃


tcpreplay: 4.4.2 -> 4.4.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/tcpreplay/versions.
meta.description for tcpreplay is: A suite of utilities for editing and replaying network traffic
meta.homepage for tcpreplay is: https://tcpreplay.appneta.com/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.4.3 with grep in /nix/store/ymc7qfb14nlk6kjciv30gmx64fpgg9d5-tcpreplay-4.4.3
found 4.4.3 in filename of file in /nix/store/ymc7qfb14nlk6kjciv30gmx64fpgg9d5-tcpreplay-4.4.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
tcpreplay

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ymc7qfb14nlk6kjciv30gmx64fpgg9d5-tcpreplay-4.4.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tcpreplay https://github.com/r-ryantm/nixpkgs/archive/0521f3013fe9afb139bbd5c2ef704446bdc57493.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ymc7qfb14nlk6kjciv30gmx64fpgg9d5-tcpreplay-4.4.3
ls -la /nix/store/ymc7qfb14nlk6kjciv30gmx64fpgg9d5-tcpreplay-4.4.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tcpreplay

Maintainer pings
cc @proteansec for testing.

@ofborg build tcpreplay tcpreplay.passthru.tests


Windows Terminal as default breaks Visual Studio 2019 console based applications

Windows Terminal version (or Windows build number)
1.9.1445.0
Other Software
No response
Steps to reproduce
Set windows terminal preview as default terminal application.
Expected Behavior
Starting Visual Studio 2019 console-based projects should show console or windows terminal.
Actual Behavior
Starting Visual Studio 2019 console-based projects do not show console or windows terminal.

Does anybody know how to revert it back to conhost as default terminal application?

Did you perchance check the settings page where you opted into Terminal being the default terminal application?

Expected Behavior
Starting Visual Studio 2019 console-based projects should show console or windows terminal.
Actual Behavior
Starting Visual Studio 2019 console-based projects do not show console or windows terminal.

There are a lot of project types in Visual Studio 2019 that could be categorized as "console-type" projects.
@BenyErnest could you please provide additional detail or screenshots as to which project type you're using so I could narrow down the activation flow?
A sample solution could be useful too. Thanks!

I did briefly look at this and I'm having a perfectly OK time with Release/x64 with the Hello World that comes out of the default VS2019 C++ Console App solution.
F5 --> loads in a console host through VS's console debug wrapper
Ctrl+F5 --> loads in a console host through VS's console debug wrapper
Double clicking from explorer --> Terminal loads and it runs then it exits/closes immediately as this Hello World app exits quickly and default Terminal behavior is close tab on exit; close app when no tabs are left.
Double clicking from explorer with Terminal already open --> tab flickers into existence then quickly out as the app runs and exits itself very fast.

Expected Behavior
Starting Visual Studio 2019 console-based projects should show console or windows terminal.
Actual Behavior
Starting Visual Studio 2019 console-based projects do not show console or windows terminal.

There are a lot of project types in Visual Studio 2019 that could be categorized as "console-type" projects.
@BenyErnest could you please provide additional detail or screenshots as to which project type you're using so I could narrow down the activation flow?
A sample solution could be useful too. Thanks!

After I updated my Windows 10 insider version is working now. Thanks for the help.


Sanitize errors [#1229]

Fixes #1229

@luin Friendly reminder. Let's get this merged?

@luin is it planned to be merged?

Weird. The command attribute isn't following the type declaration of the AbortError in DefinitelyTyped/types/redis-errors.
https://github.com/luin/ioredis/blame/master/lib/redis/event_handler.ts#L104-L108
https://github.com/luin/ioredis/blame/master/lib/redis/event_handler.ts#L4
I'd have voted that we're making the args non-enumerable. People can still access it, but it shouldn't be present with a shallow clone or property iteration.


bugfix #1059 necessary for cryptography python package

It's unknown why cryptography-pakage get installed, though. But i verified:

a pip install --upgrade cryptoadvance.specter is indeed installaing that package
a pipdeptree | less doesn't list that dependency.

It's pyOpenSSL which needs cryptography. Not sure why this slipped through in the past. Maybe because of the order of stuff got installed. Probably some other bonus-package is installing it as well and when i did the upgrade, for some reason specter has been installed before that other bonus-package.

Much thanks :)


Dep upgrades, Part 0

What's New?

Add helper script to automate future upgrades (The "easy" deps- not all deps can be manually upgraded, this script will skip difficult upgrades via typecheck/unit test/build check)
Upgrade most but not all deps.

Coverage remained the same at 91.017% when pulling 91200c93949a24eb85fb3f3dcee8782ebcb2f66e on RickCarlino:dep_upgrades into 35e5ab7f52403c336746afbdec12b31e801387b8 on FarmBot:staging.


Search component breaks layout with increased font sizes

If you increase the text size in your browser the search component input can expand below the height of the button, as shown (you can simulate this in Firefox with the 'zoom text only' option enabled, and zooming).

I had a quick go at fixing it and it might be possible to give the .gem-c-search__submit button element a position absolute and height of 100% to fix it, but I've not tested it in other browsers.

Noticed as part of https://github.com/alphagov/govuk_publishing_components/pull/4218

Definitely don't go with the fix I suggested above, because it does this with the new autocomplete...

Is this a duplicate of https://github.com/alphagov/govuk_publishing_components/issues/2498 ?

Yep looks like, thanks, closing.


#5853 neo autocomplete

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Context

[ ] Closes #<issue_number>
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address:
Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 3586f9c
Replaced the default autocomplete component with a custom NeoAutocomplete component from the @kodadot1/brick library. This component has better styling and functionality for the SearchBar component. Added some custom styles and a Storybook story for the new component.

🤖 Generated by Copilot at 3586f9c

Sing, O Muse, of the skillful coder who devised
A new component, NeoAutocomplete, to enhance
The search bar of the web app, with custom styles
And stories, extending Oruga's elegance.

pay 30 usd


Launching YARN appmaster from yarnclient sometimes results in failed master, worker

See screen shot

Do you mean rest api fails? Or mean worker node is down?

Is it possible this bug is similar to the one we found in IntegrationTest cluster startup? That is, the master start up slow caused the YARNClient fail to connect?

REST API shows no master or worker. Yes this could be related to slow master startup. I'll check and see if master is actually running next time I see it.

unable to reproduce


PyLance not recognizing Injectable classes as types VSCode

Problem
When trying to use basic type checking (PyLance language server) with PyNest on custom injectable classes I keep getting the following warning:

Expected type expression but received "str"Pylance[reportGeneralTypeIssues](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportGeneralTypeIssues)
(class) ExamplesService

The application still works as expected but this results in autocompletion not being able to work properly. This is becoming an issue when working even in the beginning of an app with already 5 modules.
Tested various approaches but ended up realizing that for some reason the @dataclass decorator is incompatible with the @Injectable one. If I remove the latter (which of course defeats the porpoise of the lib) then PyLance recognizes the class as a type properly.
One extra thing I noticed, which may or may not be related, is an argument error on the @Injectable decoractor

Argument of type "type[ExamplesService]" cannot be assigned to parameter "cls" of type "str" in function "Injectable"
  "type[type]" is incompatible with "type[str]"Pylance[reportArgumentType](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportArgumentType)
(function) def Injectable(cls: str = None) -> str

Steps to Reproduce
1. Install Pynest and create app
pip install pynest-api
pynest create-nest-app -n my_app_name
cd my_app_name

2. Create empty environment and activate
python3.11 -m venv venv
source venv/bin/activate

3. Install requirements
pip3.11 install -r requirements.txt

4. Create example as shown on Blank Application Tutorial
pynest g module -n examples

4. Install latest version of PyLance extension for VSCode and add config

or add to settings.json
    "python.analysis.typeCheckingMode": "basic",

Expected
The expected behavior is for the classes being properly recognized as Types as well as @Injectable decorator being properly recognized.

@ItayTheDar Created PR that addresses this issue, let me know what you think

@Ignacio-Freire Hi!
I just saw your pr now and I'm super excited! I will go through it more deeply to see if there any side effects to this change, but overall seems perfectly fine, it is passes all the unit and integration tests. I must say that i can't say why i chose to assign the cls input to string. This was So thank you for drill down into the codebase and fix things from source. I'm sure that there are many other things to do to optimize pynest and make it follows best practices.

@Ignacio-Freire I've added 2 comment on the pr

@Ignacio-Freire I've added 2 comment on the pr

@ItayTheDar Addressed! Thank you!

@Ignacio-Freire feel free to merge the pr

@Ignacio-Freire feel free to merge the pr

@ItayTheDar  Cannot merge it myself 😁
"Only those with write access to this repository can merge pull requests."

Ohhh 😧 So i will merge your pr, and this is another chance to thank you for noticed this broken logic and fix it. You are more than welcome to share your ideas and thoughts about PyNest, this is extremely helpful!

Code merge and is available in pynest 0.2.3 and greater! I'm closing this issue. Thanks!


Login screen "Loader" disappears before custom policy is executed

Library

[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework
React v16 (not related)
Description
After you login inside the popup, the loader starts while the calls are made, but stops before all the calls are finished.
Regression
The previous version we used was 1.2.1 and the bug was still present
Configuration
Please provide your MSAL configuration options.
We're using 3 custom policies:
B2C_1A_signup_signin
B2C_1A_TrustFrameworkBase
B2C_1A_TrustFrameworkExtensions
Reproduction steps
See the attached GIF
Expected behavior
The Loader should be visible until all the login flow is complete and the pop closes/user redirected
I'm not sure I provided all the info that's needed for this, so if there's anything else I can provide, please ping me.
If this isn't the right place to report this, any suggestion to where should it be reported would help.

@cubogdan Apologies for the delayed response. This is an issue with the B2C service. Please file a support ticket with the B2C team by following the instructions here: https://docs.microsoft.com/en-us/azure/active-directory-b2c/support-options
They can help you out further, they may ask for a public repro link or additional data. You can also link this Github issue in the support request.


feat(panels): adds panel component

Fixes #138.
Changes proposed in this pull request:

An optional header
A required body
An optional footer
Ability to be collapsible

Welcome back, @MatthewDorner 🎉😊

LGTM


No original Hue lights since 0.2.0

Hello, since I have updated to version 0.2.0, no original Philips Hue bulbs are displayed to me.
iOS 10.3 Beta
  		"lights": true,
  		"philipsLights": true,

same for me

By bad.  Fixed in v0.2.1.


Using the last commit username and email for the action commit

Current dependencies on/for this PR:

main

PR #151

PR #152   👈

PR #153

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: 4dXAg7Xv6IwUYtw3PX6N


build-image bails on resizefs

Getting this from the latest:
mount: /root/wifibroadcast-image-builder/data/mnt/boot: overlapping loop device exists for /root/wifibroadcast-image-builder/data/2018-06-27-raspbian-stretch-lite_2018-09-02.img.

I only get this error when i have another image mounted. Perhaps the script could be modified to handle this situation, but i usually just make sure no other images are mounted. If the script failed mid-run and you are launching again, you could run the lines from ./unmount.sh. This should unmount any leftovers.

@kwatkins is the image building working for you now?

I gave this a go with latest master, build_images.sh goes through but the resulting img still doesn't look right...
root@kali# ls -l data
total 8157496
-rw-r--r--  1 root root<PHONE_NUMBER> Oct 19 16:50 2018-06-27-raspbian-stretch-lite_2018-10-19.img
-rw-r--r--  1 root root<PHONE_NUMBER> Oct 19 16:39 2018-06-27-raspbian-stretch-lite.img
-rw-r--r--  1 root root  366980542 Jun 26 21:10 2018-06-27-raspbian-stretch-lite.zip
drwxr-xr-x 12 root root       4096 Oct 19 16:29 git
drwxr-xr-x  4 root root       4096 Oct 18 13:37 kernel
drwxr-xr-x  2 root root       4096 Oct 19 16:40 mnt
-rw-r--r--  1 root root<PHONE_NUMBER> Oct 19 16:39 temp.img
root@kali# fdisk -l data/2018-06-27-raspbian-stretch-lite_2018-10-19.img
Disk data/2018-06-27-raspbian-stretch-lite_2018-10-19.img: 3.8 GiB,<PHONE_NUMBER> bytes, 7831552 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x4d3ee428

Device                                                Boot Start     End Sectors  Size Id Type
data/2018-06-27-raspbian-stretch-lite_2018-10-19.img1       8192   96663   88472 43.2M  c W95 FAT32 (LBA)
data/2018-06-27-raspbian-stretch-lite_2018-10-19.img2      98304 7831551 7733248  3.7G 83 Linux
root@kali:~/wifibroadcast/wifibroadcast-image-builder#

Then mounting it to look shows it still is the original stretch image,
root@kali# mount -v -o offset=50331648 -t ext4 ./2018-06-27-raspbian-stretch-lite_2018-10-19.img /mnt/img
root@kali# ls -al /mnt/img/root
total 16
drwx------  2 root root 4096 Jun 26 20:03 .
drwxr-xr-x 22 root root 4096 Jun 26 20:03 ..
-rw-r--r--  1 root root  570 Mar 12  2018 .bashrc
-rw-r--r--  1 root root  148 Mar 12  2018 .profile

Likely I'm still missing something?

Got further along, to patch_rpi_image and moving the boot mount after (seems only one loop0 mount can be active at a time?)
Now working on resolving the apt-get's, something is going on - still not going through after apt update.
E: Failed to fetch http://raspbian.raspberrypi.org/raspbian/pool/main/p/python2.7/python2.7-dev_2.7.13-2+deb9u2_armhf.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

What is exact distro and setup environment we should be running these scripts on?

@kwatkins
I don't understand your problem.
I got today a bootable image at the end of the script.
What is your Linux distribution/version ?

Ugh, ignore this, I was using the build script from a week ago. Did a git pull origin master and it looks like it's going through. I saw that the stuff I had changed to get the script working was also put in, so, my bad for not getting the latest.
I'm using a kali image of ubuntu in a virtualbox FM.

@RespawnDespair you can close this, looks to be fixed in latest build scripts on master. Thanks!


Fix: raise error when abstract def implementation adds a type restriction

Currently this passes without any error:
abstract class Foo
  abstract def foo(x)
end

class Bar < Foo
  def foo(x : Int32)
  end
end

But it shouldn't because the implementation only allows Int32 to be passed as argument, while the abstract definition doesn't impose any restriction on the argument.
With this PR the compiler will properly raise:
Error: abstract `def Foo#foo(x)` must be implemented by Bar

Are you sure this won't be too limiting? def foo(x) doesn't really mean you can use any type for x. It still needs to be compatible with all the method calls etc.
So if the implementation of Bar#foo is x.method_only_defined_on_foo_class, it's functionally similar to adding x : Foo type restriction. And the latter is more descriptive. It's good to be able to use that. But there may be reasons why x : Foo doesn't work for the abstract method.
I'd suggest to postpone this and not merge it right before 1.0. Let's take some time to consider the effects of this. I don't think it's an urgent feature.

@straight-shoota maybe. I discovered this while working on #9633 but I opened it as separate PR precisely because it might be open to interpretation. However, supporting such case of partial implementation sound more like a feature and in this case I think it was probably more like an accident. After all there was no spec testing specifically for that case.

I am comfortable still with the proposed behavior in this PR. I understand the point raised by @straight-shoota about loose contracts, but when I use abstract my mind is usually working in a more strict mode. I prefer that the compiler will honor/enforce the interface of the abstract base classes in the subclasses.
I would like to hear read more arguments in favor or against merging this.

I think this PR is fine. The abstract method really means "this accepts any type", or "the type is not clear" so the implementation should be exactly the same.


WIP: refact(upgrade): added scripts to perform jiva volume upgrade via job and patch the upgrade CR

Signed-off-by: shubham<EMAIL_ADDRESS>What this PR does / why we need it:
This PR adds scripts that will perform jiva volume upgrade via upgrade job and patch upgrade CR with the appropriate status for each step. This scripts can also be run manually to upgrade the volume.
Note: If the resource is already in upgrade_version the scripts skip that step.
Sample maunal test:
user:jiva$ ./jiva_volume_upgrade_auto.sh pvc-fabf3e7d-a88e-11e9-9f6c-54e1ad5e8320 openebs
No resources found.
Pre-upgrade steps successful
patched deployment/pvc-fabf3e7d-a88e-11e9-9f6c-54e1ad5e8320-rep
patched deployment/pvc-fabf3e7d-a88e-11e9-9f6c-54e1ad5e8320-ctrl
patched service/pvc-fabf3e7d-a88e-11e9-9f6c-54e1ad5e8320-ctrl-svc
volume upgrade pvc-fabf3e7d-a88e-11e9-9f6c-54e1ad5e8320 verification is successful.
Clearing temporary files

Upgrade CR status under ideal conditions test:
status:
  completedTime: "2019-07-11T17:40:01Z"
  phase: null
  startTime: "2019-07-11T17:39:01Z"
  upgradeDetailedStatuses:
  - state:
      complete:
        message: volume upgrade pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320 verification
          is successful.
    step: VERIFY_UPGRADE
  - state:
      complete:
        message: patched service/pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320-ctrl-svc
    step: SERVICE_UPGRADE
  - state:
      complete:
        message: patched deployment/pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320-ctrl
    step: TARGET_UPGRADE
  - state:
      complete:
        message: patched deployment/pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320-rep
    step: REPLICA_UPGRADE
  - state:
      complete:
        message: Pre-upgrade steps successful
    step: PRE_UPGRADE

Upgrade CR status under faulty conditions test:
status:
  completedTime: "2019-07-11T17:40:01Z"
  phase: null
  startTime: "2019-07-11T17:39:01Z"
  upgradeDetailedStatuses:
  - state:
      errored:
        message: upgrade verification failed for pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320
        reason: Failed validation for registered replica count expected 1 but only
          0 are registered. Node stickiness failed after upgrade.
    step: VERIFY_UPGRADE
  - state:
      complete:
        message: controller service pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320-ctrl-svc
          is already at 1.0.0
    step: SERVICE_UPGRADE
  - state:
      complete:
        message: controller Deployment pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320-ctrl
          is already at 1.0.0
    step: TARGET_UPGRADE
  - state:
      complete:
        message: replica deployment pvc-4dc7cf73-a78e-11e9-9072-54e1ad5e8320-rep is
          already at 1.0.0
    step: REPLICA_UPGRADE
  - state:
      complete:
        message: Pre-upgrade steps successful
    step: PRE_UPGRADE

The implementation is being shifted to openebs/maya repo. https://github.com/openebs/maya/pull/1354
Will have to revisit this PR.


added short description

Hi @emarhin if you're looking for ways to get involved with the development of django, helpful people answer questions at forum.djangoproject.com. You can also get started with the "Writing your first patch for Django" docs.
Cheers

okay thank you very much


Don't reset content language on edit [+redux]

[Continuation of lbryio/lbry-redux/pull/414]
Issue
Publish page tries to set the upload language to the user langauge, and it does so on edit and overwrites the existing value.
Closes #6132
Change
selectPublishFormValues was trying to return "language" from formValues but would always return false, and set the language as default instead, should return "languages" instead.

This is breaking /$/upload in master/lbry.tv.  Reverting for now.


WL-334 : adding notification on request error

@massa84 can you add some notes to the README on how you use the notifier and bind it to a logger implementation - console.log would do for an example.

Hi Paul, can you please build the standalone and create a new release ?
Thank you.


test-explorer: auto update xgo if test.config.json says 'xgo.auto_update: true'

And possibly prompt in the test explorer UI.
Update check: start a background goroutine, run xgo tool check-update --json to get if there is newer version.
If the result says there is new update, then run go install github.com/xhd2015/xgo/cmd/xgo@latest

The test.config.json:
{
    "xgo":{
        "auto_update":true
    }
}

If this option is true, then upon every invoke to xgo e, go install github.com/xhd2015/xgo/cmd/xgo@latest will be executed in a standalone goroutine silently.
This behavior can be turned off by setting XGO_AUTO_UPDATE=never.


Lack of support for multiple files in multiple directories.

I have multiple files:
myapplication/js/controllers/samplecontroller.js
myapplication/js/directives/sampledirective.js
myapplication/js/main.js
myapplication/js/app.js
I notice gulp-ngdocs can only read from one directory, and does not pick up any of the documentation in the subdirectories from js (i.e. controllers, directives).
My gulp task is:
gulp.task('ngdocs', [], function () {
var gulpDocs = require('gulp-ngdocs');
var options = {
scripts: ['./controllers/.js','./directives/.js'], // this looks completely ignored
startPage: '/api',
title: "Awesome Docs",
titleLink: "/api"
}
return gulp.src('myapplication/js/*.js')
.pipe(gulpDocs.process(options))
.pipe(gulp.dest('./docs'));
});

try this:
...
scripts: ['./js/**/*.js'],
...

I have the same problem - i call the .process() function with custom options, containing several script files. When I start the process it never emits the 'end' event. It works fine when I remove the scripts property.
It seems that the copyTemplates() method does not work as expected, because these files are always missing. When I remove the call fstreams.push(copyTemplates(templates)); (index.js:302) everythings works fine - well fine means that I get the 'end' event, but the template files are missing, so it is not really fine ;).

why arent you just putting those in the gulp.src argument? This can be an array. For example:
gulp.task('ngdocs', [], function () {
  var gulpDocs = require('gulp-ngdocs');
  var options = {
    startPage: '/api',
    title: "Awesome Docs",
    titleLink: "/api"
  }
  return gulp.src(['./controllers/*.js','./directives/*.js','myapplication/js/*.js'])
    .pipe(gulpDocs.process(options))
    .pipe(gulp.dest('./docs'));
});

@andyperlitch What if you're using gulpDocs.section? You can't use gulp.src.


Option to not force fullscreen to be topmost (alt+tab issue)

Right now, if you create a fullscreen window in pyglet, it sets the HWND_TOPMOST flag for it, which means it is always on top of everything else. This means that you cannot use alt+tab to switch between the pyglet window and other programs, which is bad if you want to do anything else (chatting, looking up things on the web etc) while a pyglet game is running.
My proposed solution would be to add an argument to enable fullscreen without setting the HWND_TOPMOST flag, maybe something like window(topmost=...), where the value can be set to True, False, or auto (current behaviour).
As a temporary workaround, monkey patching can be used:
import pyglet.libs.win32.constants
pyglet.libs.win32.constants.HWND_TOPMOST = pyglet.libs.win32.constants.HWND_NOTOPMOST

# import only after patching
import pyglet

Note that this post applies to Windows (pyglet.window.win32), I have not tested this behaviour on other platforms.

I tried fullscreen on a Mac and it seems to also have the same behaviour.

Thanks for opening the ticket.
If you set window.set_exclusive_keyboard(False), does it still prevent alt+tab?

I'm not at a computer at the moment, but iirc that was the case. I could actually alt+tab into other programs, but they wouldn't be visible since the pyglet window forced itself to be the topmost.

I'd be willing to try and implement this if I get the time this week, would a kwarg at set_fullscreen or __init__ be better?

@LennyPhoenix
In addition to fullscreen, we're also setting HWND_TOPMOST when the Window style is set to "overlay".
That part should remain as it is,  but it does seem like HWND_NOTOPMOST should be the default otherwise.
I was thinking about maybe adding a class variable to allow the user to specifically set it, but maybe that's not necessary.

It would be nice to be able to control the flags individually, but that's probably for another PR. I'll start working on this tomorrow once I have access to a Windows machine :+1:

Closing this, as this was already addressed by Lenny.


Comments / nits / recommendations from #1959

We merged #1959 with some remaining things to consolidate / clean up. This issue is a pointer to those requests.

Can they be listed here?


[FEATURE] Keyboard Navigation

Request
For a11y and general ease of use, it would be ideal for keyboard navigation for things like arrow keys and enter.

You would like to pan the flow with the arrow keys? What would the enter key trigger?

Ya - I think you could do something like if a node is NOT focused, then pan?

We will not add this feature to React Flow. iIn my opinion, there are too many different possibilities and ways of thinking about how keyboard handling could be used here.

I know this issue is closed but if you still need to implement this, in reactflow v10, you can use the useKeyPress hook + set an instanceRef on the reactflow element to get the instanceRef.current.setViewport({x: x, y: y, zoom: zoom}) to pan the canvas around

@moklick I just found this issue searching for this.
An argument for making drag and drop libraries accessible keyboard is also for testing.
It's much easier to test your application with tools like Cypress if you can simulate interaction with it via keyboard presses.

Good point @dwjohnston thanks for bringing this up again! I'll think about it.


Container Image synchronization jobs

As part of the ingestion process, provide the tooling/jobs to perform the following:

check and synchronize projects from upstream docker registries to make sure imported images are up to date
when a diff is discovered, at the end of the synchronization process, bundle up the registry metadata and deploy it to estuary as well.
include the CID from the bundled metadata to be included as part of an initial setup/sync - probably will require the use of IPNS

sync process:
[build repo] -> [export to Estuary/IPFS] -> [relink to IPNS]
setup process:
[import metadata from IPFS]

cc. @corinne-antonia


examine: fix pricecheck for items in seedbox

The menu option for Examine in the seedbox widget has a <col=9040> tag appended to it which explains the removal of tags. I also added the Seed Box to WidgetInfo.

Removed.


Game Suggestion: PitchTalk

Bot Name (required):
PitchTalk
Bot Handle (required):
@pitchtalk_bot (https://t.me/pitchtalk_bot)
Reason for Inclusion:
The bot relative with HOT dev

Hi @bscongluanbui,
Thanks for the suggestion, we will look to push a candidate for this on Friday.

Hi,
The new game is now live :)
./launch.sh pitchtalk


Add option to deploy exporters without dependencies

Currently not as an Pelorus Operator option, but fine for use cases where users would want to create separate exporters.
Signed-off-by: Michal Pryc<EMAIL_ADDRESS>@redhat-cop/mdt

/test 4.8-e2e-openshift


Create a PR template

This is a(n):

[ ] Update to an existing Animated Button
[ ] Any Error
[x] Proposal to the Repository
[ ] Documentation / README.md changes

Details:

Addition of PR template in .github folder.

@Spyware007 please assign me this issue under GSSoC23.

Closing it as feature has already been implemented


Fix data retrieval when creating a campaign

When creating a campaign, the data is not retrieved correctly; like in the other methods, it should unwrap the data from the data property.

Thanks!


Choose a license

Think about what to do with the mrl <-> lin conversion code from Carolin. Either rewrite it (would be a good idea anyway) or ask for her permission of licensing it.

Hi @Simon-Will
Thanks for your work. I would like to ask the license of the work. Because I plan to use as a part of a prototype and might enhance.
Thank you!

Hi @isspek, thanks for your interest! If you'd like to share, I'd very much like to know what you're planning to work on. I still maintain https://nlmaps.org/ and I'd like to improve it, too. So maybe there's some common goal somewhere.
Regardless of that, I'd like to choose a permissive license for this, such as MIT license. @carolinlawrence, I cannot decide on a license for this project on my own because the mrl module is your work for the most part. When I asked you about it two or three years ago, you told me that I can use it and make it accessible provided I make it clear that it's yours. Would you agree to license the whole project under the MIT license?

Hi @Simon-Will, happy to hear that there is still use for the mrl module, please feel free to use the MIT license for that prat of the project as well.

@Simon-Will could you send me an email to my Gmail address: ibarsch.arbeit? I would be happy for discussing it.

That's great, @carolinlawrence. I added the MIT license to the project.
@isspek, I'm going to send you a message.


InfoWindow: Add mocks for maps.InfoWindow

Is your feature request related to a problem? Please describe.
No, just additional functionality
Describe the solution you'd like
Mocks should exist for the maps.InfoWindow class defined here: https://developers.google.com/maps/documentation/javascript/reference/info-window#InfoWindow
Describe alternatives you've considered
Currently I'm just adding the minimally required mock to the global object with the following.
window.google.maps.InfoWindow = jest.fn().mockImplementation(() => {
  return {
    setPosition: iwSetPositionMock,
    open: iwOpenMock,
  };
});

Additional context
I can work on a PR if this seems like a good idea.

A pr would be great!


I cant open The file because of Norton Security

Every time I try to open it My norton just deletes it off of my computer

The solution is to stop using Norton. It is a false positive

Or, you can add an exception to the file in Norton's settings. That'll work too.


Sign in with twitter

This adds the API components we need for sign in with twitter.  These are endpoints to:

get a request token from twitter that the client can use
log in a user who comes in from a trusted client with a request token and verification code that twitter successfully exchanges for an access token.

All twitter API access is from the joind.in API, this should be adaptable to work with other clients but has only been tested with web2 (pull request incoming there also).
To get set up: read config.php.dist in the API project, but basically you need to register a twitter application to get a consumer key and secret, then point the callback at /user/twitter-access on your dev platform URL.
To put this live: we need to create new applications on twitter for the test and live APIs to use (we can't use the existing web1 ones as they point to the wrong callback URL)
Warning: contains very funky model layer remodelling.

Jenkins, test this please!

Jenkins test this please!  Again.

Jenkins, test this please!  Again.  Again.

^^^ these problems were to do with the version of PHP which phing was using having switched back to the system-installed version (5.4.36-0+deb7u1), whereas we use a custom-installed 5.6.4 on the server.
The other problems were making phing work after I'd switched the server to use the correct PHP binary.


Paused state results in an failure

Hi,
First of, thanks for the script. however I am encountering an issue when updating my stack causing flakiness in my CI.
using docker (18.09.5)
./docker-stack-wait.sh -t 120 frontend
Service frontend_test state: updating
Service frontend_foo state: new
Service frontend_bar state: updating
Service frontend_server state: updating
Service frontend_bar state: replicating 0/1
Service frontend_test state: paused
Service frontend_bar state: updating
Service frontend_server state: paused
this only happens sometimes and the services seem to update fine (no rollback failure), so I'm not sure why the paused state is considered a failure.
any ideas?

Does frontend_server go back from paused to updating or complete when you look at docker service inspect frontend_server -f '{{.UpdateStatus.State}}'. Paused is the default response to a failed deploy which you can configure, e.g.: https://docs.docker.com/compose/compose-file/#update_config

I'll have to wait for another flaky run, but usually when I re-run the same job (the stack update + stack wait) it gives an instant state: new (without even updating) so it seems like it only stays paused for a split second.
I'll try the command next time and come back to you with the results

Try to run just the stack-wait command without the stack update (the stack update will restart the deploy and clear out any paused state). It sounds like your healthcheck is initially failing but eventually succeeding after a few retries. You can adjust your healthcheck thresholds to only have it pause the deploy on a more persistent failure.

Ok I ran the command after the failing (paused) one:
"UpdateStatus": {
     "State": "paused",
     "StartedAt": "2019-04-18T15:15:44.040747072Z",
     "Message": "update paused due to failure or early termination of task w8rmczsnb8hm947vickxypcoh"
}

However the service seems to be running fine and has:
"UpdatedAt": "2019-04-18T15:16:00.216058821Z",

The UpdateAt time is bout 5 seconds after pausing, which is kind of odd, maybe it is just the first healthcheck that failed? I'll try messing around with healthcheck thresholds and update_config..

Looks like the docker-stack-wait script properly reported the failure, so I'll mark this one as closed.
The UpdatedAt can be changed by lots of things, and is probably impacted by tasks being recreated as it retries starting the containers. The UpdateStatus is reporting how the deployment is progressing, and can be adjusted with the update_config in the compose file.


Filtering using nested property names and on relationships

This is the final remaining part of #116, with content that was agreed on in the final two days of the workshop and which I agreed on writing up. Sorry for the delay, but it wasn't so easy to write up. Closes #116.
In summary:

Describes filtering on nested property names. Much of this was already present in the lexical tokens subsection. It is now moved alongside other discussion of filtering.
Describes filtering on relationships. This was vaguely hinted at alongside the discussion on filters on nested property names, but is now in the filtering section and clarified.
Some other cleanup with regards to relationships necessary to concisely formulate these parts. This includes disintegrating some jsonapi-response-format-specifics from the more abstract concept of relationships in OPTiMaDe (and existing also for other potential output formats.); including moving up the general discussion of relationships to section 3, rather than down in section 6.

Many thanks for the feedback @merkys and @ml-evs, please re-review.

Go ahead @rartino!


Removed unused modal files and converted coverage/criteria dialogs to erb

@david-yz-liu The upload/download dialogs for the graders were coded directly into the UI since they have somewhat static content (the upload shows the criteria when needed). Since they weren't being used anymore I removed the methods from the controller and the supporting files. However it now fails tests that expected the controller methods. I just want to make sure this is okay before I remove the tests. I looked pretty thoroughly for anything that might reference the controller methods and couldn't find anything. The tests appear to mainly be checking to ensure the students dont have access to the forms.

@spring-ryanc That sounds fine.

@david-yz-liu can you re-trigger the build for me? It seems like there was some strange connection issue during the test


Cannot change the name of output exe in ASP.net core application

If I create a ASP.net core web application called 'Application1' it will produce an exe as it's output called 'Application1.exe'. However, if I want to change the name of that exe, there doesn't seem to be anywhere to do this.
In the web.config under the aspNetCore element there's a property called processPath which is set to '%LAUNCHER_PATH%'. Where does this value come from? I'm guessing that is where the 'Application1' name is coming from.

Have you tried setting buildOptions.outputName?

I have just tried this setting and it changes the output name but then I have to change this all over the place as this doesn't match the '%LAUNCHER_PATH%' which is used in web.config. By default, this and all other config are trying to look for 'Application1.exe'

web.config does not have too much to do with your project. It is only used by IIS to start your application after you published it. When you publish your app a tool called publish-iis is called and replaces %LAUNCHER_PATH% with the actual application name. Note that publish-iis did not support outputName in RC2/preview1 but it works in RTM/preview2.
I am not sure what is the "all other config" that " are trying to look for 'Application1.exe'" - can you elaborate?

If I change my application name as @tsvetomir suggested, it will generate the exe with that application name. If I then run the program through 'start new instance' or the run through 'IIS Express' buttons in VS, IIS Express will error with 'Unable to start process.... the system cannot find the file specified' because it is still looking for 'Application1.exe' and not the updated name.
By 'all other config' I'm referring to any config which I have to change to get the correct application name recognised as I'm not clear why IIS express is still looking for 'Application1.exe'.
If, as you say, I do a dotnet publish, it will replace the '%LAUNCHER_PATH%' with the updated application name.

The first thing seems to be a problem with tooling. @BillHiebert - do you support this scenario (i.e. outputName for the executable is specified in the project.json - it seems that VS is not using this to replace %LAUNCHER_PATH%`)
For all other config - I still don't know what files exactly you have in your mind when you say o any config which I have to change but as far as I am aware the only config tooling touches is web.config (when you publish your app and when publish-iis is configured to run as a postpublish script). If you have any other config files you most likely created them manually and configured to be included in your code when creating a configuration. Since these are your config files you need to fix them on your own.
As a side note - I am not sure if I understand why you want to use outputName for an executable - why not just change the project folder to match all your needs and be done with it?. The scenario outputName was added for was that it enables creating a NuGet package whose name was different from the dll it included. Currently it is used mostly for tools (e.g. the publish-iis is in the package called Microsoft.AspNetCore.IISIntegration.Tools and the name of the dll containing the tool is dotnet-publish-iis).

Thanks @moozzyk that makes sense. By 'all other config' I was referring to anything which I may have to change to get this working but if the '%LAUNCHER_PATH%' variable is replaced correctly for scenarios when you either publish or run through IIS express, then, as you rightly point out, there is no other config.
I ran into this issue because of the way we organise projects in our solution and a quirk of visual studio whereby you cannot add a new project and specify which folder it goes in. I renamed the project and namespaces but this would not rename the exe.
We could get round this using a publish and run through IIS as the '%LAUNCHER_PATH%' would be replaced but it wouldn't run through IIS Express.

I am also facing this problem. I would like to rename the assembly with the "outputName" arguments in "buildOptions". Everything works fine but i cannot use the iis express to debug it. I tried to set the LAUNCHER_ARGS env variable manually but i cannot make it work. I got the exception: "An error occurred attempting to determine the process id of which is hosting your application".
Is there a working workaround to debug the application with iis express if the output name is differs from project name?

Hi @Kemyke we actually went back to using old ASP.net instead of ASP.net core because we were writing this for a production app and we didn't feel it quite ready for us to use. However, we got around the issue by using IIS instead of IIS express. I had to make the following change in our xproj file:
<Target Name="Publish" AfterTargets="Build">   <Exec Command="$(WinDir)\system32\inetsrv\appcmd stop apppool "AspNetCore"" IgnoreExitCode="true"></Exec>   <Exec Command="$(WinDir)\system32\inetsrv\appcmd start apppool "AspNetCore"" IgnoreExitCode="true"></Exec>   <Exec Command="dotnet publish $(MSBuildProjectDirectory)\project.json -o $(MSBuildProjectDirectory)\PublishedApp" Condition="$(PublishURL) == ''"></Exec>   <Exec Command="dotnet publish $(MSBuildProjectDirectory)\project.json -o $(PublishURL)" Condition="$(PublishURL) != ''"></Exec> </Target>
The first two lines stop and start the app pool ‘AspNetCore’ (which we added as an app pool). The third line is for local builds and would publish to a standard \PublishedApp folder which you would point IIS to and the fourth is for deployments where a publish URL is specified – obviously you want to publish to a specified folder when it's specified.
This meant that when we built the project we didn't have to manually stop the process running the ASP.net core app. It wasn't perfect but at least you could debug by attaching through IIS.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Updating using nested queries

Bug description
In reference to https://github.com/prisma/prisma/discussions/13170, it seems that the order of the operations for nested queries are important when it contains both deleteMany and create. At least in the way that I'm using them. Following the example from the quickstart (User and Post), in the first example below, the create happens first, followed by the deleteMany.
await prisma.user.update({
    data: {
      name: "Alice",
      posts: {
        create: [...],
        deleteMany: [...],
      },
    },
    include: { ... },
    where: { ... },
  })

In the second example below, the deleteMany happens first followed by create.
await prisma.user.update({
    data: {
      name: "Alice",
      posts: {
        deleteMany: [...],
        create: [...],
      },
    },
    include: { ... },
    where: { ... },
  })

As mentioned in the discussions, it was stated that the order does not matter and if it does to file a bug report.
How to reproduce

Copy the code below into script.ts
Run npx ts-node script.ts

Expected behavior
If the order does not matter, I would expect npx ts-node script.ts to complete successfully.
Prisma information

model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
  posts Post[]
}

model Post {
  id        Int     @id @default(autoincrement())
  title     String
  content   String?
  published Boolean @default(false)
  author    User    @relation(fields: [authorId], references: [id])
  authorId  Int
}

import { PrismaClient } from "@prisma/client";

const prisma = new PrismaClient();

async function main() {
    // create user with 2 posts
  const user = await prisma.user.create({
    data: {
      name: "Alice",
      email<EMAIL_ADDRESS>      posts: {
        create: [{ title: "Hello 1" }, { title: "Hello 2" }],
      },
    },
    include: { posts: true },
  });
  console.log(user);
  const posts = user.posts.map(({ content, id, published, title }) => {
    return { content, id, published, title };
  });
  const updatedUser = await prisma.user.update({
    data: {
      name: "Alice (Updated)",
      posts: {
        create: [...posts, { content: "Content 3", title: "Hello 3" }],
        deleteMany: [{ authorId: user.id }],
      },
    },
    include: { posts: true },
    where: { id: user.id },
  });
  console.log(updatedUser);
}

main()
  .then(async () => {
    await prisma.$disconnect();
  })
  .catch(async (e) => {
    console.error(e);
    await prisma.$disconnect();
    process.exit(1);
  });

Environment & setup

OS:  macOS
Database:  PostgreSQL
Node.js version:  v16.17.0

Prisma Version
Environment variables loaded from .env
prisma                  : 4.8.1
@prisma/client          : 4.8.1
Current platform        : darwin
Query Engine (Node-API) : libquery-engine d6e67a83f971b175a593ccc12e15c4a757f93ffe (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli d6e67a83f971b175a593ccc12e15c4a757f93ffe (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine    : introspection-core d6e67a83f971b175a593ccc12e15c4a757f93ffe (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary           : prisma-fmt d6e67a83f971b175a593ccc12e15c4a757f93ffe (at node_modules/@prisma/engines/prisma-fmt-darwin)
Format Wasm             : @prisma/prisma-fmt-wasm 4.8.0-61.d6e67a83f971b175a593ccc12e15c4a757f93ffe
Default Engines Hash    : d6e67a83f971b175a593ccc12e15c4a757f93ffe
Studio                  : 0.479.0

Had the same issue with update. Here some code samples of my current project:
This works:
const workshop = await tx.workshop.update({
  data: {
    ...updateWorkshopInput,
    ...{
      sections: {
        update,
        create,
        deleteMany, // works
      },
    },
  },
  where: {
    id: updateWorkshopInput.id,
  },
});

This throws An operation failed because it depends on one or more records that were required but not found. No 'WorkshopSection' record was found for a nested update on relation 'WorkshopToWorkshopSection'.", "path": ["updateWorkshop"]}]:
const workshop = await tx.workshop.update({
  data: {
    ...updateWorkshopInput,
    ...{
      sections: {
        deleteMany, // does not work
        update,
        create,
      },
    },
  },
  where: {
    id: updateWorkshopInput.id,
  },
});

I can confirm, I've just also reproduced against 4.10.1


Allow http connection to own node

Description
I'm pretty sure this is planned, but I couldn't find an open issue to track the feature so I created one now :)
This should be an advanced setting imo.
Motivation
Some users have their own nodes at home. No need for https there.
Are you planning to do it yourself in a pull request?
No.

very needed indeed :)


fixed fishy forEach function return

For the release log: The fixed bug caused issues when res.render/res.send/etc was called after async operations(on ignored routes).

thanks again for finding and fixing PR.


-c option for setup scripts

One possible enhancement after we transition the existing setup scripts to Python would be to give users the option to clean out specific sections of their env directory i.e. delete bullet without touching anything else. This would make versioning easier, as users would not have to rebuild all of env every time it changes if they don't know how to manually clean out packages. It would also make the job of version upgrade scripts easier to have these functions.
Thoughts?

I'm glad you brought that up, Brian. I've been working on the Python setup scripts and I had a similar idea.
Right now I have a BaseInstaller script that every installer should inherit from. It has three methods: isInstalled, install and uninstall.
While we could make an uninstall method for the existing env structure, an easier way might be to start putting each package in a separate folder. So your env would look something like this:
downloads
bullet
src
li
include
boost
src
lib
include
That would make the uninstall script pretty easy: just delete the entire directory.
I can't see any real disadvantage to this structure over our existing structure. Can anyone see any shortcomings/problems that I haven't?

Unfortunately my indentation didn't work in that post, hopefully the layout is fairly clear (every package we install has a src, lib and include directory).

Perry,
I like that structure generally for the purposes you outline. One note: it
will require changes to src/inc.CmakeBullet.txt to get the new include
paths correct, but that's not a major hurdle.
Brian
On Thu, Jan 15, 2015 at 1:41 PM, Perry Bhandal<EMAIL_ADDRESS>wrote:

Unfortunately my indentation didn't work in that post, hopefully the
layout is fairly clear (every package we install has a src, lib and include
directory).
—
Reply to this email directly or view it on GitHub
https://github.com/NASA-Tensegrity-Robotics-Toolkit/NTRTsim/issues/126#issuecomment-70137470
.

Great, thanks for the heads up.
I'm hoping most of the Python scripts will be done by the end of the weekend. I'll post another message once it's ready for testing.


Using modal properly

Hey guys, great work you've done on router flux. It's amazing and handy.
I have a simple question based on the new v4 release.
I'm trying to use the new modal flow. When I set my root scene as modal and the child as a card, it duplicates the navbar. So I tried to hide the navBar and display it on card, but it still hidden on my modal view.
My router:
        <Router>
            <Scene key="root" modal hideNavBar={true}>
              <Scene key="home1" card hideNavBar={false}>
                <Scene key="home" component={Home}/>
                <Scene key="home2" component={Home2}/>
              </Scene>
              <Scene key="modal" component={Modal}/>
            </Scene>
          </Router>

I already tried to set hideNavBar={false} on my modal Scene.  I wasn't lucky.
Any tips? Thanks

Please check Example project. There is modal Login with own navbar.

Oh, sorry. Thank you.
Now it's working as expected.


Why are overlay styles not being applied the second time I open a modal

When I open and modal and close it and try to open it again the modal does not show because the overlay styles (position: fixed; left: 0px; right: 0px; top: 0px; bottom: 0px;) are not being added to then dom element the second time I open it.
Could you please advise how I can fix this

@TomClarkson it has been a while since you posed your question. Wondering if you are still seeing this behavior.

I stopped using react-modal as I couldn't stop this behaviour. There must have been some conflict with the rest of our app but I couldn't track down the issue. Thanks anyway.


Review annotations

review the annotations made with schema.org and suggest the corresponding changes

There are several aspects that I am not happy about, and I think that should be changed:

Positions of authors in papers cannot be represented according to schema.org. My proposal is to simplify the mappings by generating the order in a simple text associated to the papers with the full citation, using schema:citation, and then generating a schema:author property for each author, independently of the order.
Awards probably do not need so much detail. In schema.org the award is just a Text that is associated to the entity via schema:award

I have left more comments on the mapping file


Consequent renaming of 2 identifiers mentioned in the same lines is broken

Observed in VS2013, TS1.4
This is a hard one to be exact about. I will do what I can:
Say I have
interface Range<a> {
from: a;
to: a;
}

I have a lot of code  using this interface. Now I want to rename from -> start and to->end. And I do it one immediately after another.
The code that used both from and to in a single line gets messed up.
// before

function fromRange(range: Range<number>): Interval {
   return { start: range.from: end: range.to };
}

///  after renaming both from and to of Range (very exaggerated)
function fromRange(range: Range<number>): Interval {
  return { start: range.start FDYSSLASH hGDSjW JHDGS SJ jhGQJ EWHGE WJK   };
}

A few questions:

I assume you have an interface around like this:

interface Interval {
    start: number;
    end: number;
}

In your test code, you have a syntactically invalid object literal. Did you mean the following?

function fromRange<T>(range: Range<T>): Interval {
    return { start: range.start, end: range.end };
}

or did you mean for the code to be erroneous?

What editor and version of that editor are you using?
Did you try renaming your entities at the declaration-site or at the use-site?

@DanielRosenwasser
sorry for confusions:

Ues I do have the Interval interface like you mentioned.

No, by accident I made a mistake, fixed.

VS2013, TS1.4

Don't remember. Tend to think it was a use site.

It seems like the text buffer after the first renaming doesn't get updated promptly and the second renaming runs against unupdated or partially updated buffer.

The code base is over 800 files and over 150 000 lines of code

So this is not necessarily something that always happens; if you press 'undo' and try it again, you may or may not get the same results?

Yes, it doesn't always happen. If I give it enough time between the tries it works fine. It is only observed when I do one renaming immediately after another against a considerably large code base.

Does this repro in the latest VS2014 RC?  Our entire LS was rewritten between 2013 and 2014.  Thanks.

@CyrusNajmabadi, VS2013 as far as I can tell, here are more details:

The VS2013 code was very 'racy'.  In that it had actual race conditions in it that weren't terribly difficult to run into.  It sounds like you may just be running into one of those cases.  Given the size of your codebase, that does not seem altogether surprising given that this would be exacerbated by how much work we needed to do.  If you try out VS2014 and don't encounter this anymore, then that would help indicate if the issue was fixed, or if there is something deeper going on that we'll need to investigate.  Thanks!

I believe @CyrusNajmabadi means VS2015/Visual Studio 14.

As @CyrusNajmabadi mentioned we have done some major re-architecture in VS plugin code to make sure such issues do not happen in VS2015. It would be a non-trivial amount of work to make this work in VS2013. Since VS2015 is in RC and almost ready for RTM, I am going to close this as won't fix.
@aleksey-bykov please let us know if you see similar issues on VS 2015.


Statistics graph to show plays by stream type (Transcode, Direct Play)

Would like a graph on the statistics page which shows the number of plays by stream type (Transcode or Direct Play).
It seems Jellystat already has this data in the Activity tab client field (Transcode vs Direct) but does not provide a graph for it
Tautulli has a similar graph which I find useful 'Daily concurrent stream count by stream type

This would be quite handy. I wonder if it would be possible to drill into the information and check which media was direct play/transcode too.

Yeah this would be great. As well as even just showing a new field type on the already existing activity feed too.

Added stat in 1.1.1, still need to add a graph


Consider enabling Stack Smashing protection in plugins

We have identified a security issue in your package from our security scan.
Stack smashing protection has not been implemented in components included in the application. When an application is compiled with stack smashing protection, a known value or "canary" is placed on the stack directly before the local variables to protect the saved base pointer, saved instruction pointer, and function arguments. The value of the canary is verified upon the function return to see if it has been overwritten. The compiler uses a heuristic to intelligently apply stack protection to a function, typically functions using character arrays. This is a very simple best practice that hardens your app with little to no downside. Memory corruption vulnerabilities can be very hard to track down, but can be extremely severe.
Please follow the steps below for the respective platform to fix this security issue:
iOS:
In XCode, under the Build Settings for the app, go to the "Other C Flags" section and add in -fstack-protector-all. More reading can be done on Apple's developer library
Android:
Make sure that the -fstack-protector-all, -fpic, and -fstack-protector-strong flags are all set in the build.gradle file (typically in the cmake/cppFlags).

/cc @stuartmorgan

@jmagman I doubt we have any buffer overflows in path_provider_ios, but we could consider just making it repo policy to turn this on for all of our iOS plugins; thoughts? I would imagine the overhead would be pretty small.

Android: [...] typically in the cmake/cppFlags

@DanAkmens What C++ code is this referring to? It's a Java plugin.

I'm making this generic; I don't see a plausible scenario where we would turn this on for a random subset of plugins rather than either all or none.

See also https://github.com/flutter/flutter/issues/4368 and https://github.com/flutter/flutter/issues/87952 where this was turned on in the engine, but reverted due to performance and binary size issues.

I imagine perf issues just for plugins would be much less significant than the engine.

Any binary size impact would have been dwarfed by the -O setting change, so I suspect we don't know anything about the impact of that flag in particular.
I'll see if I can find time to build all our plugins with and without it sometime and compare. (I agree that any perf impact is unlikely to matter; generally the code in our actual plugins isn't perf-critical).

Question:
Sorry, I have a similar problem.
I compiled the android apk with flutter.
I found that my app was at risk after being tested by a formal institution.
The test results suggest that my app has security risks, and the repair suggestion is "When compiling So files with NDK, add '-fstack-protector-all' and '-fPIC' to the Android.mk."
The files involved are the following:
.lib/arm64-v8a/libapp.so
.lib/arm64-v8a/libflutter.so
.lib/armeabi-v7a/libapp.so
My development environment is:
Flutter 2.5.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision https://github.com/flutter/flutter/commit/18116933e77adc82f80866c928266a5b4f1ed645 (10 months ago) • 2021-10-15 10:46:35 -0700
Engine • revision d3ea636dc5
Tools • Dart 2.14.4
I hope you can add '-fstack-protector-all' and '-fPIC', because this is related to whether my APP can be approved by customers

@stuartmorgan
Question:
Sorry, I have a similar problem.
I compiled the android apk with flutter.
I found that my app was at risk after being tested by a formal institution.
The test results suggest that my app has security risks, and the repair suggestion is "When compiling So files with NDK, add '-fstack-protector-all' and '-fPIC' to the Android.mk."
The files involved are the following:
.lib/arm64-v8a/libapp.so
.lib/arm64-v8a/libflutter.so
.lib/armeabi-v7a/libapp.so
My development environment is:
Flutter 2.5.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision https://github.com/flutter/flutter/commit/18116933e77adc82f80866c928266a5b4f1ed645 (10 months ago) • 2021-10-15 10:46:35 -0700
Engine • revision d3ea636dc5
Tools • Dart 2.14.4
I hope you can add '-fstack-protector-all' and '-fPIC', because this is related to whether my APP can be approved by customers

The files involved are the following:
.lib/arm64-v8a/libapp.so
.lib/arm64-v8a/libflutter.so
.lib/armeabi-v7a/libapp.so

Those aren't plugins, so are not related to this issue. The other issues you were pointed to are relevant to these libraries.


Azure AD Sign In logs - What is the frequency of logs every time a user logs into joined windows laptop

Regarding the Azure AD joined Windows 10 device sign ins, I believe when we log into Azure AD joined windows 10 device(Laptop / desktop) with Azure AD user account and password, the login is recorded in Azure AD Signin logs with application called "Windows Sign In". Please correct me if I am wrong. I would like to know how the device sign in recorded by Azure AD as we tend to lock the system 20+times and we give our password 20+ times in a day.So Azure would log a sign in log every time user logs to Azure AD joined windows laptop? If not what is the frequency? I could not find any related information in MS DOCS, hence submitting this issue

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1558e7c0-eaaf-d081-30c3-5c13e0876071
Version Independent ID: 1106c01b-1e4c-5b04-be84-432f99ec4d8f
Content: Sign-in logs in Azure Active Directory
Content Source: articles/active-directory/reports-monitoring/concept-sign-ins.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

A user provides a biometric gesture to unlock their Windows PC with Windows Hello for Business.
A user provides username and password in the Azure AD sign-in screen.
from the MS article, https://docs.microsoft.com/en-us/azure/active-directory/reports-monitoring/concept-all-sign-ins
the above 2 logs are considered as Sign in logs and I would like to know the frequency of this logins

@priyankareddy20
Thanks for your feedback! We will investigate and update as appropriate.

Hello Team,
I would like to know for every login on azure ad joined windows device,
will the sign in log will be recorded?
Like Everytime user enters password or completes Windows hello on the
device level.
If a user logs into device 20times in a day will we have 20logs on that
application called "Windows sign in"
Regards
Priyanka
On Thu, Jun 24, 2021, 5:53 PM James Tran-MSFT @.***>
wrote:

@priyankareddy20 https://github.com/priyankareddy20
Thanks for your feedback! We will investigate and update as appropriate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/77406#issuecomment-867753467,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APPAQHPXYLKBYF3MT2HPXE3TUNIHDANCNFSM47HQPVJA
.

I did not receive any feedback on the issue.Kindly look onto it


Replace the Activity Tab with the Posts and Draft Tabs.

📃 Description
The Activity Tab was removed and replaced with the Posts and Draft Tab using the Shadcn Tab components
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Related Tickets & Documents
Fixes # (issue)
What type of PR is this? (check all applicable)

[ ] 💡 Feature
[ ] 🐛 Bug Fix
[ ] 📃 Documentation Update
[✅] 🎨 Style Changes
[ ] 💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test

🔰 Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

As already mentioned in issue #167, we need a switch between 'All Posts' (use 'All' as the tab title) and 'Collaborative Posts' (use 'Collab' as the tab title).
Please update the tab triggers accordingly and also add some mock data with placeholder text for the tab content.

Alright. Just saw the visuals now. Will effect the corrections

@obere4u while raising a PR, please ensure all required fields are filled in properly. This makes the process of reviewing a PR easier and provides a complete overview of what has been done in the PR.
For fields that aren't relevant to the PR, add 'NIL' to the description.
To check a checkbox, simply place an 'x' inside [ ].


Bump dcos-test-utils

High-level description
This makes sure DC/OS 1.13 integration tests use the appropriate version
of the DC/OS CLI. They currently use the DC/OS 1.12 CLI.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-45807 Own end-to-end that the "correct CLI version" is used in the DC/OS integration test suite; in every branch

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot label Work In Progress

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@ArmandGrillet @rgo3 @orsenthil @cprovencher : could you please review this one?


fix(deps): keep composer autolaod files

Fixes #51

:tada: This PR is included in version 1.4.1-rc.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use of AzureRM module - please change to AZ

Section: Or upload an existing certificate into Key Vault
Last line of code uses "Set-AzureKeyVaultSecret" which in AzureRM module.
Please change it to "Set-AzKeyVaultSecret"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08acab31-7f58-5faa-cb07-c21209d6cb5a
Version Independent ID: 9389468f-23c1-7729-3203-1e4100c6ab2b
Content: Add application cert to a cluster in Powershell
Content Source: articles/service-fabric/scripts/service-fabric-powershell-add-application-certificate.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

@kovaliovsg  Thanks for your feedback! We will investigate and update as appropriate.

@kovaliovsg Doc changes are done and will be live shortly.