Contract.new promise is broken

resolves without result
const txHash = await MainContract.new({ from: coinbase })

resolves without throwing
const txHash = await MainContract.new()

works
const txHash = await pify(MainContract.new)({ from: coinbase })

Will review tomorrow.
Sent from my iPhone

On Apr 8, 2018, at 12:04 AM, kumavis<EMAIL_ADDRESS>wrote:
resolves without result
const txHash = await MainContract.new({ from: coinbase })
resolves without throwing
const txHash = await MainContract.new()
works
const txHash = await pify(MainContract.new)({ from: coinbase })
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Should be addressed now @kumavis -- as of v1.9


feat: add feature to record multi-host system

Description

This PR adds feature to record multi-host system.
Related links

https://github.com/tier4/ros2caret/pull/163
https://github.com/tier4/caret_trace/pull/262
https://github.com/tier4/caret_doc/pull/190

Notes for reviewers

Pre-review checklist for the PR author

[x] I've confirmed the contribution guidelines.
[x] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR has been properly tested.
[ ] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] (Optional) The PR has been properly tested with CARET_report verification.
[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

LGTM


cmd/acme: window directories missing from fs

If I run 9p ls acme, I see something like this:
----------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 ''
d-r-x------ M 0 rogpeppe rogpeppe 0 Nov  4 07:29 acme
--rw------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 cons
----------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 consctl
d---------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 draw
---w------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 editout
--r-------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 index
--rw------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 label
--r-------- M 0 rogpeppe rogpeppe 0 Nov  4 07:29 log
d-r-x------ M 0 rogpeppe rogpeppe 0 Nov  4 07:29 new

None of the window directories are present (although they can be walked to) and there's that odd empty-named file with no permissions.

Each window directory also contains the blank file name:
% 9p ls acme/37
''
addr
body
ctl
data
editout
errors
event
rdsel
tag
wrsel
xdata


OAuth2 files missing from source sub folder

So I am trying to follow this sample project set up
https://developers.google.com/google-apps/calendar/quickstart/ios?ver=swift#step_4_prepare_the_project
When I get to the part where the OAuth2 xib file is needed to be added to the project's supporting files, it's not present in the source folder, either on here or in the cloned repo.
google-api-objectivec-client/Source/OAuth2/Touch/GTMOAuth2ViewTouch.xib
Is there a better way to get the above file? Or group of files.

This has been mentioned a few times in issues and on the Google Group.  That quickstart isn't something we can directly update. :(
The path you likely want is google-api-objectivec-client/Deps/gtm-oauth2/Source/Touch/GTMOAuth2ViewTouch.xib.

I'll keep this open so hopefully folks can find it more easily.


Upload tokenizer?

Your test case in the ReadMe gives the following error:
File "/.../transformers/tokenization_utils_fast.py", line 107, in __init__
    fast_tokenizer = TokenizerFast.from_file(fast_tokenizer_file)
Exception: No such file or directory (os error 2)

To get this working, we had to use: bert-large-uncased for the tokenizer. Looks like there is no tokenizer.json in the hub to pull down.

Thank you, I'll have a look. My guess is the original repository changed.

Thanks!


Update market proposals - show equity like share on proposal details page

As per the proposal form, the proposal details for update market proposals details page should show the equity like share for voting.

@campbellssource

Merged with https://github.com/vegaprotocol/frontend-monorepo/issues/1512


[kepler-model-server] Fetch both power consumption and CPU utilization metrics for each node

Users might want to run a custom benchmark outside of kepler-model-server and collect metrics using kepler-model-server to train model subsequently.
Collect metrics (only query Prometheus to fetch metrics in the specified time window)
NATIVE="true" ./script.sh custom_collect

Validate the collected metrics
NATIVE="true" ./script.sh validate customBenchmark

Train custom benchmark metrics
NATIVE="true" ./script.sh custom_train

Note that Prometheus is queried to collect both kepler provided power consumption and node-exporter provided CPU utilization metrics (like node_cpu_seconds_total) for each cluster node.

PR https://github.com/sustainable-computing-io/kepler-model-server/pull/191 addresses this issue.

Closing this issue as the require changes are merged into the repository kepler-model-server via the PR.


Migration Fail with RuntimeException

Before reporting an issue

[X] I have searched existing issues
[X] I have reproduced the issue with the latest release

Environment information

Migration tool version: next :)

EHRbase version: 0.32.0

PostgreSQL version: 16.2

Java Runtime version: 21

Operating System version: Docker version 26.0.0

Steps to reproduce
We have run the migration tool via docker and docker compose with the follow environment:
    image: ehrbase/migration-tool:next
    networks:
      - num-portal
    environment:
      mode: DB2DB
      spring.datasource.import.url: jdbc:postgresql://postgres:5432/ehrbase2
      spring.datasource.import.username: ehrbase
      spring.datasource.import.password: ehrbase
      spring.datasource.export.url: jdbc:postgresql://postgres:5432/ehrbase
      spring.datasource.export.username: ehrbase
      spring.datasource.export.password: ehrbase
      import.ehrbase-db-user: ehrbase_restricted

the database ehrnase ist the old DB and ehrbase2 is the new one.
Expected behavior
DB is mgrated in ehrbase2 and the ehrbase container is running in version 2.x.xDB is mgrated in ehrbase2 and the ehrbase container is running in version 2.x.x
Actual result
ehrbaseMigration-1  | 2024-07-17T08:27:01.720Z  INFO 1 --- [           main] o.e.migration.service.ProcessService     : Processing ehrs 0 - 99 of 1058
ehrbaseMigration-1  | 2024-07-17T08:27:22.799Z  INFO 1 --- [           main] o.e.migration.service.ProcessService     : Start import of ehrs 0 - 99 of 1058
ehrbaseMigration-1  | 2024-07-17T08:27:28.409Z  INFO 1 --- [           main] o.e.migration.service.ProcessService     : Finished import of ehrs 0 - 99 of 1058
ehrbaseMigration-1  | 2024-07-17T08:27:28.409Z  INFO 1 --- [           main] o.e.migration.service.ProcessService     : Processing ehrs 100 - 199 of 1058
ehrbaseMigration-1  | 2024-07-17T08:27:34.419Z  INFO 1 --- [           main] o.e.migration.service.ProcessService     : Start import of ehrs 100 - 199 of 1058
ehrbaseMigration-1  | 2024-07-17T08:27:34.769Z  INFO 1 --- [           main] .s.b.a.l.ConditionEvaluationReportLogger :
ehrbaseMigration-1  |
ehrbaseMigration-1  | Error starting ApplicationContext.
That means that in
{
	"name": {
		"_type": "DV_TEXT",
		"value": "EHR Status"
	},
	"uid": {
		"_type": "OBJECT_VERSION_ID",
		"value": "c599013e-2f17-4783-af2f-fa549f2eea03::local.ehrbase.org::1"
	},
	"subject": {
		"_type": "PARTY_SELF",
		"external_ref": {
			"_type": "PARTY_REF",
			"namespace": "examples",
			"type": "PERSON",
			"id": {
				"_type": "GENERIC_ID",
				"value": "ins139",
				"scheme": "id_scheme"
			}
		}
	},
	"_type": "EHR_STATUS",
	"archetype_node_id": "openEHR-EHR-EHR_STATUS.generic.v1",
	"is_queryable": false,
	"is_modifiable": true
}

the combination of id.value and id.scheme needs to be unique.
You have to go into you old db and use the query
select status.ehr_id, pi.party_ref_value,party_ref_scheme from ehr.status join ehr.party_identified pi on pi.id = status.party and pi.sys_tenant = status.sys_tenant;

this will give you the ehrs with  id.value and id.scheme
then you need to changed the ones which are duplicated.

Mirgation was successful, thank you

I did the same migration with an other database
\copy (select pi.party_ref_value,party_ref_scheme, COUNT(*) from ehr.status join ehr.party_identified pi on pi.id = status.party and pi.sys_tenant = status.sys_tenant GROUP BY  pi.party_ref_value,party_ref_scheme HAVING COUNT(*) > 1) TO STDOUT WITH CSV HEADER;
gives me no output as I deleted all duplicates before.
I got still the same error message with
Detail: Key ((((((data -> 'su'::text) -> 'er'::text) -> 'X'::text) -> 'V'::text) ->> 0), ((((data -> 'su'::text) -> 'er'::text) -> 'ns'::text) ->> 0))=(10, DEMOGRAPHIC) already exists.

@ujanssen weird, the error message seems to be the same.
To get the obvious stuff out first, are you migrating into an empty DB?
Also, can you share some details about the ehrbase version and a stack trace?
Thank you.

the import database is started via docker and I run the command from createdb.sql - so the target db should be empty.
ehrbare version is 0.32.0
Error starting ApplicationContext.
Maybe set a breakpoint and delete  ehr_status_subject_idx and see if it run tough and then you could look into the db.
Sorry for not be more specific but without more info about the data which create the issue I do not have an Idee.


Proposal for Swift: hasBody OHHTTPStubsTestBlock

Hi there,
I'm not sure if there was the same idea already or not. But what do you think about adding new  OHHTTPStubsTestBlock.
public func hasBody(_ body: Data) -> OHHTTPStubsTestBlock {
    return { req in req.OHHTTPStubs_HTTPBody? == body }
}

I see the problem here, that the Swift subspec doesn't contain the URLSession subspec by default, which makes sense. But maybe it could a new one SwftURLSession or something like that?
In the end, I find this new test block very useful. And I'd love to add this in PR if the feature is approved 🚀

That seems like a good idea. I'm starting more and more to consider including URLSession and JSON subspecs as part of the Swift subspec by default. If we do that, we could merge your idea in :wink:

@AliSoftware do you have any estimation to decide whether to merge subspecs or not? Could you please point the cons of merging? 😄

Main con of merging is inability to opt out.
Will try to make time for it this week

@Antondomashnev  #242 will finally (!) solve this and make hasBody part of the Swift API! 🎉

@AliSoftware wow, that's an amazing news 🎉 🚀


Is the version 4.0.2 implementation in compliance with SCA policy of EU?

Hi,
I am using InAppBillingPlugin in my app. With new Strong Customer Authentication policy coming in place for EU, there are some changes suggested by Apple and Google regarding compliance perspective. I have been looking into code base for this and unable to decide if InAppBillingPlugin takes care of it on both Apple and Google side or as a developer I need to make additional changes at my end? Could you please help me with this?

It uses standard iOS/Android APIs so I assume so.....
https://developer.apple.com/support/psd2/ you should be able to use these 2 callbacks -> https://github.com/jamesmontemagno/InAppBillingPlugin/blob/master/src/Plugin.InAppBilling/InAppBilling.apple.cs#L23-L25
Android I am pretty sure you you just need to check on app startup or have a restore as it will have PENDING -> https://iaphub.medium.com/get-ready-for-sca-strong-customer-authentication-iap-transactions-in-the-eu-iaphub-34e825e2349 is a good link to read

It uses standard iOS/Android APIs so I assume so.....
https://developer.apple.com/support/psd2/ you should be able to use these 2 callbacks -> https://github.com/jamesmontemagno/InAppBillingPlugin/blob/master/src/Plugin.InAppBilling/InAppBilling.apple.cs#L23-L25
Android I am pretty sure you you just need to check on app startup or have a restore as it will have PENDING -> https://iaphub.medium.com/get-ready-for-sca-strong-customer-authentication-iap-transactions-in-the-eu-iaphub-34e825e2349 is a good link to read


Custom slot name braces

In this PR I introduce the possibility to provide custom start and end braces (or other string values) used to recognize the end and start of a slot of the TranslationComponent.
This may be useful when default braces ({ and }) are wrongly treated by the Locize service or don't satisfy other needs. In our case, the Locize treated single braces as "wrong" double braces, so we couldn't sync our localization terms with the Locize service without additional refactoring. This service is needed for our translators to edit localization terms and see how it looks in real time. We have to do double refactoring each time before sync. To avoid it, I propose a little change in this repo.

Checklist

[X] only relevant code is changed (make a diff before you submit the PR)
[X] run tests npm run test
[ ] tests are included (tested the build of the final commit in real project by replacing the library file)
[X] commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

[X] only relevant documentation part is changed (make a diff before you submit the PR)
[X] motivation/reason is provided
[X] commit message and code follows the Developer's Certification of Origin

@kkuegler, PTAL

@kkuegler, PTAL again.

Looks good. Thanks again for your PR!


Add a folder to userSettings for image sequence render

Same behavior as the Video render window.
It will create a default folder to render image sequence if the user didn't select a folder.
If the user select an other folder to render image sequences, T3 will remember it.

Thanks!


TypeError: Cannot read property 'asyncOnly' of undefined

I20180820-11:47:59.354(3)?   1) mocha-test
I20180820-11:47:59.355(3)?        server is not client:
I20180820-11:47:59.355(3)?      TypeError: Cannot read property 'asyncOnly' of undefined
I20180820-11:47:59.355(3)?       at run (packages/meteortesting:mocha-core/server.js:48:24)
I20180820-11:47:59.355(3)?       at Test.wrappedFunction (packages/meteortesting:mocha-core/server.js:63:33)
I20180820-11:47:59.355(3)?       at run (packages/meteortesting:mocha-core/server.js:56:16)```

This happens with<EMAIL_ADDRESS>Client tests work.

This only happens for tests that use it.only()

I'll close this here as it should be fixed by updating to version 5.2.0_2 of the package meteortesting:mocha-core.

Fixed for me! Thanks @SimonSimCity, you rock!


support of processing compile dependencies through retrolambda

It would be great to use retrolambda gradle plugin to process all compile dependencies too so that we can easily use Java8 java libraries in android projects.

This duplicates https://github.com/evant/gradle-retrolambda/issues/80


Application level blur handler called from render

I am attempting a lit-html variant of the todomvc app (See todomvc.com for more info). While editing a todo item, ESC key is supposed to cancel the edit and clicking elsewhere (blur) is supposed to commit edited content. To my surprise, my blur handler was called from render while it was removing nodes as part of its update processing after pressing ESC.
Adding a breakpoint in endEdit (model.js:63) shows the following trace:
endEdit (model.js:63)
save (controller.js:28)
html (controller.js:32)
handleEvent (parts.ts:422)
removeNodes (dom.ts:46)
clear (parts.ts:292)
_commitNode (parts.ts:195)
_commitTemplateResult (parts.ts:231)
commit (parts.ts:181)
_commitIterable (parts.ts:274)
commit (parts.ts:184)
update (template-instance.ts:50)
render (render.ts:44)
show (controller.js:41)
html (controller.js:37)
handleEvent (parts.ts:422)
I am attaching the mostly working app below. The relevant part for this bug is from controller.js.
const save = title => show(endEdit({id: editing, title}));
const todoEdit = ({id, title}) => html`
  <li class="editing">
		<input class='edit' autofocus value=${title}
		  @blur=${({target}) => save(target.value)}
		  @keypress=${({target, keyCode}) => { if (keyCode === ENTER_KEY) save(target.value);}}
		  @keyup=${({target, keyCode}) => {
	if (keyCode === ESCAPE_KEY) {
		target.value = title;  // blur handler has been seen to fire in addition
		show(getItems());
	}
}}>
	</li>`;
render(html`${list.map(todo => editing === todo.id ? todoEdit(todo) : todoView(todo))}`,
		todoList);

The handler set with @blur= is called as part of the handler set with @keyup=. The ugly resetting of target.value to the previous title value is just there to mask the effect of the unexpected blur handler. I would like to be able to simply write
@keyup=${({keyCode}) => if (keyCode === ESCAPE_KEY) show(getItems())}
Detailed instructions to reproduce.  Observed in Opera 55.0.2994.44 and Chrome 68.0.3440.106

Bring up attached app
set break point in module.js:63
create a todo
double click to edit
focus (the need for explicit focus is a separate problem. autofocus does not seem enough)
press escape key

I am not expecting to hit the breakpoint. While I understand that the input element for editing need no longer be in the DOM tree when render returns, I am not expecting a blur callback. To my mind this is a leaky abstraction problem. I would like to remain unencumbered by the implementation of render when I reason about my application level event handlers.
todomvc.zip

I'm fairly certain your issue is that you are rendering an <input> element in two different templates. Because they are different templates, lit-html will destroy the current input and render a new one, causing the blur event to fire on the input that is destroyed. Lit-html is not a diffing engine like virtualDOM, so it doesn't understand you are rendering the same input if you are not rendering the exact same template. If you want the same element to remain, you need to render the same template.
More specifically, you need to merge todoView and todoEdit into a single template. You can use conditionals or nested templates to get the same end result.

Yes.
Consider your question in a scenario where your render implementation was nothing but calling innerHTML. Obviously you have to consider how you render things, because it affects how the DOM behaves, and how/when it fires events.

When you give lit-html a new (different) template to render, it will destroy all existing nodes, and render the new template. If you want the nodes to be re-used, you have to render the same template. That's how it works.

Thanks for answering this @ruphin
I've seen the root problem here (rendering different templates and expecting diffing-type behavior) come up a few times recently. We definitely need to highlight this in the docs.


Feature Request: MAL Tracking

As above. Would be lovely to have a MAL login which authorizes the app to track anime episodes.

I don't know if I want to use login (server based), let me see If there many user requested it.
My plan is to have a local user (multiple user) with pin & its own watchlist & history (or track ep). Saved locally but can be backup online (gdrive / other services).

if I remember correctly you can use mal/anilist api so you don't need to have your own server

Will take a look at it. I don't use MAL btw 😁. it's like IMDB right?
I need to think how to merge/match the data, since I don't have any anime database (all data is directly fetched from aniwave).

it's like IMDB right?

yes, it's a big database of anime and manga and people use it to track the episode they watched.

I need to think how to merge/match the data, since I don't have any anime database (all data is directly fetched from aniwave).

as I said they ARE a big anime database so I guess you could fetch data from them

as I said they ARE a big anime database so I guess you could fetch data from them

I know I can fetch data from MAL (since it has an api), but I don't think I can match it with aniwave (current source) for streaming video because I don't have any aniwave database.
I don't have a good idea to implemented it features without any integration with current source, if it only for information without able to jump to a video in aniwave.
Fetching whole aniwave catalog is not a good idea, it need server so it can join with key which anime data from aniwave have which anime data from MAL.
But I will take a look at it, maybe there is some use case.

Man, it would really be nice to have a competitor to Cloudstream, since it's the only remaining app on TV that can track via MAL.
That said - could you make a Tachiyomi appoach? (Different app, but the concept could be inspiring)
When selecting an episode, you have some kind of menu to match the anime to a MAL entry, be able to select it and have MAL and the source (Aniwave in this case) match watched episode numbers.

This is how Tachiyomi does it, click to view.
Sorry for the German UI.
When viewing, you have a button to add your tracking source (MAL in our case)

Then you simply select the entry you want to sync up / match.

Then you can edit stats like status (PTW/Dropped/Watching...), number of episodes, rating, start and end of watching...

I imagine this is a lot of work since I don't know how the API works.

https://github.com/MALSync/MALSync  i heard this can be used to match aniwawe data with MAL data
i dont really know how to or how it works but yeah other anime apps use it

MAL Tracking at latest version: https://github.com/amarullz/AnimeTV/discussions/44


Clarifications to change and release management doc. Fixes #485, #488.

@uscholdm I wasn't sure about this: "For example, changing an equivalent class assertion pointing to a union class to a subclass axiom in order to allow new subclasses to be defined is not a major change." The example was in the previous version but I couldn't tell whether it was an example of a major change or one that wasn't a major change. See what you think.

@uscholdm I'm confused: did you actually make the changes you are suggesting? The idea is to provide a review rather than an implementation, in case I'm not in full agreement. :)


allowTouchMove: false disables links

If swiper is wrapped in an <a> tag then with allowTouchMove: false the link doesn't work. It should.
This is a (multiple allowed):

[x] bug
[ ] enhancement
[ ] feature-discussion (RFC)

Swiper Version: 4.3.5
Platform/Target and Browser Versions: CHROME DESKTOP

It's still a valid bug.


Only one active instance of trigger process

When starting a new instance of the trigger process, check whether an instance is already running and terminate it if necessary. Only one instance of the process should be active at a time.
The MII KDS Report Process, which already implements this feature:
https://github.com/medizininformatik-initiative/mii-dsf-processes/blob/472addbb053e84285be7a4f5ebd0ecdb3ae717e6/mii-dsf-process-kds-report/src/main/java/de/medizininformatik_initiative/process/kds/report/service/StartTimer.java#L76-L93

Bad PR, released via v0.7.0


Rekey impossible

http://prntscr.com/jt9ujq
Impossible to rekey this folder. (already have a new paper key)

@InTheFlipside maybe you lost/revoked all your previous devices and now there are no devices that can rekey it.  We can reset it for you if you want.
If you want us to reset your folder, please run this command on a currently-valid keybase device, and substitute the current date and time where indicated:
keybase sign -m "<DATE_AND_TIME>: Please reset folder /keybase/private/filpside because all the devices that have access have been revoked."

and post the results here.

BEGIN KEYBASE SALTPACK SIGNED MESSAGE. kXR7VktZdyH7rvq v5weRa0zkMT1xSL jysgVXKg6MRmLZU DyNxPFa3WI8afXe OyVo3Vdiy3MXe5F Z2irofYi6EQQssR 4eyywGdg3temtHj IczAyGtXeLDBCvd fPi15WUKuSafsUK DfGQysAke78NJzc vUhgmteFRUqO1VU lU4QNsijGneFcv1 WkuazFymfFVaOCb XysMhwwEDnwZGZE qLjbEPheJ7z3VR0 xuI7sWfjXQJOIDn adTDeAYEX1XyLcH wSEN6mvldOu0x3s IEUa4oBy89aTILo 7mStmuDEWr1H0cq MOzQeKGi6ahq0NF L2o193Xn0VhE4nd Xnsmxi9scmClEW9 ovbAherEAI. END KEYBASE SALTPACK SIGNED MESSAGE.
Sended, thank :)

@InTheFlipside I looked into this a little and saw that your folder is still keyed for your device SourceCode, which hasn't yet been revoked.  Assuming that device is still online somewhere, I think the probably is likely a bug that is preventing your rekey.  (I could tell for sure if you do a keybase log send from SourceCode and post the resulting log ID here.)
Depending on your operating system, you could try upgrading, though the bug fix isn't released on all platforms yet.  If it hasn't been released yet, you might be able to use an experimental build instead of waiting for the next release on your platform.
If you'd rather I just reset your folder anyway, that's fine too, just confirm that you want that.  I just like avoiding resets if possible.

@strib
Thanks for your answer
SourceCode is deleted. (It was my previous windows). I revoked it. (sended keybase log send, before and after)
Can you reset this folder please? I gave up a little bit to find a solution
( i doubt that it contain important files. I don't remember but it doesn't have importance)
thank a lot !

I reset the folder.  Please check it out and close this if everything seems ok.  (Might require a Keybase restart.)

everything is okay
thanks :)


XPath does not work on large XML files

The file being worked with is a large 200MB Validated XML file lacking an XSLT. XML-Plus was able to load the file and render the XML Tree which is quite nice. However, XPath queries that were validated with another tool, fail to return results.

Hi @George-Weilenmann-RJ
Unfortunately, the XPath functionality is provided by the browser:
https://developer.mozilla.org/en-US/docs/Web/API/Document/evaluate
The version shipped with the browser is probably too old and I can't help with that.


Update IPL + tweaks

In master we don't keep the generated compiles.iml as it depends on System in imandra interactive - not dune compiled in the ipl output. Could get rid of it, or dune ignore it?


Website Is Down

It used to work, but now, whenever I go to theairportwiki.com, this is what it says:
Hello, theairportwiki.com !
mediawiki site is no more, most if not all content that was there is here

yeah i took down the mediawiki site a while back, as it is something i do not want to maintain anymore.  pretty much all content that was on that site is contained here within this repo.
Is there something specific you are looking for?

No not really. I wasn't sure if it was intended so I just wanted to let you know.


Security vulernability reported on Snyk

I'm not sure if you guys are aware of this:
https://snyk.io/test/npm/markdown-draft-js/1.3.0
reports a security vulnerability on Snyk. It can be solved by upgrading the underscore.string dependency.

Thanks @mschipperheyn it looks like the vulnerability is through remarkable https://github.com/jonschlinkert/remarkable/issues/310 and there's a pull request with a fix. Hopefully that gets merged soon and we can update our remarkable dependency :)

@Rosey It appears that @jonschlinkert isn't ever interested in fixing this problem.  Is there another library you could use instead of remarkable?  I am willing to attempt a PR.

Hmm I chose remarkable because it has really great support for custom markdown options (eg designing your own markdown syntax for things like mentions) which I wasn't able to find with other tools. If you know of another markdown parser that is equally flexible then it could be possible to switch 🙂
I suppose another option is to fork remarkable and patch the vulnerabilities and use that fork instead of the original 😓

I’m with you.  I like the library and in fact, I offered a PR to the author that met his initial request of ripping out argparse and replacing it with another library he’d identified.  He decided not to accept that PR (or any of the many others from other authors that followed.)  I can only assume that he is either trying to make a point, not interested in upkeep on this project or is working on a major re-write or something that obviates these changes.
This package seems really popular and well maintained.  I haven’t looked at custom syntax.
https://github.com/markedjs/marked
From: Rose<EMAIL_ADDRESS>Reply-To: Rosey/markdown-draft-js<EMAIL_ADDRESS>Date: Monday, June 10, 2019 at 12:14 PM
To: Rosey/markdown-draft-js<EMAIL_ADDRESS>Cc: jdalegonzalez<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Rosey/markdown-draft-js] Security vulernability reported on Snyk (#89)
Hmm I chose remarkable because it has really great support for custom markdown options (eg designing your own markdown syntax for things like mentions) which I wasn't able to find with other tools. If you know of another markdown parser that is equally flexible then it could be possible to switch 🙂
I suppose another option is to fork remarkable and patch the vulnerabilities and use that fork instead of the original 😓
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I’m with you.  I like the library and in fact, I offered a PR to the author that met his initial request of ripping out argparse and replacing it with another library he’d identified.

If you did indeed do what you're saying, my apologies, I didn't ignore the PR intentionally. I would love to merge it and get rid of these issues.
Can you link to the pr?

Sure.
https://github.com/jonschlinkert/remarkable/pull/327
On Thu, Jun 13, 2019 at 6:52 PM Jon Schlinkert<EMAIL_ADDRESS>wrote:

I’m with you.  I like the library and in fact, I offered a PR to the
author that met his initial request of ripping out argparse and replacing
it with another library he’d identified.
If you did indeed do what you're saying, my apologies, I didn't ignore the
PR intentionally. I would love to merge it and get rid of these issues.
Can you link to the pr?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Rosey/markdown-draft-js/issues/89?email_source=notifications&email_token=AALHVBENMRJVVA4EIV7NNRLP2LFRPA5CNFSM4GHWQNF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXVH2DI#issuecomment-501906701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALHVBH6FHTPLHVNM6PZUDTP2LFRPANCNFSM4GHWQNFQ
.

https://github.com/Rosey/markdown-draft-js/pull/104 Updates to the latest version of remarkable which resolves 2 out of 3 security alerts on snyk.

Is the third one comes from remarkable too?

Ah, I see. It comes from autolinker. That dependency is evaluated a lot. I not sure it's safe to upgrade it in patch dependency. I will publish major bump soon. It will include autolinker upgrade.

Thanks so much @TrySound  for knocking out that last one 🙂
https://snyk.io/test/npm/markdown-draft-js/2.0.0 I think we're all clear (for now at least 🙃 )
did a major release bump for this one since the remarkable dependency was major and I didn't want to risk any backwards compatibility issues. However I don't think there should be any.


balena-connectivity: Include iwlwifi-quz-a0-hr-b0 and iwlwifi-quz-a0-jf-b0

These are used for AX201NGW and AC9462 respectively, available on 11th gen NUCs as well as standalone M.2 cards.

This needs https://github.com/balena-os/meta-balena/pull/2611

@balena-ci rebase

This commit takes the surface pro 6 above it's filesystem size limit:
NOTE: recipe balena-image-1.0-r0: task do_image_size_check: Started
ERROR: balena-image-1.0-r0 do_image_size_check: The disk aligned root filesystem size 282624 exceeds the available space 274432
NOTE: recipe balena-image-1.0-r0: task do_image_size_check: Failed
ERROR: Logfile of failure stored in: /work/build/tmp/work/surface_pro_6-poky-linux/balena-image/1.0-r0/temp/log.do_image_size_check.79587

There is no space on the genericx86-64 image either

@alexgg @floion is there any reason we do not have firmware compression enabled for the NUC?

is there any reason we do not have firmware compression enabled for the NUC?

We should have it if it's needed. The minimum requirement is a kernel >= v5.3. Maybe we should consider enabling it by default in meta-balena and disable it on those device types that have older kernels.

is there any reason we do not have firmware compression enabled for the NUC?

We should have it if it's needed. The minimum requirement is a kernel >= v5.3. Maybe we should consider enabling it by default in meta-balena and disable it on those device types that have older kernels.
+1 for that

@balena-ci rebase

@resin-jenkins retest this please

This PR depends on some other PRs that free some space:
NOTE: recipe balena-image-1.0-r0: task do_image_size_check: Started
ERROR: balena-image-1.0-r0 do_image_size_check: The disk aligned root filesystem size 282624 exceeds the available space 274432

@mtoman @alexgg I think we have some customers waiting for this PR but there are some conflicts to be resolved.

Still failing the size check
ERROR: balena-image-1.0-r0 do_image_size_check: The disk aligned root filesystem size 282624 exceeds the available space 274432
ERROR: Logfile of failure stored in: /work/build/tmp/work/genericx86_64-poky-linux/balena-image/1.0-r0/temp/log.do_image_size_check.78823
NOTE: recipe balena-image-1.0-r0: task do_image_size_check: Failed
ERROR: Task (/work/build/../layers/meta-balena/meta-balena-common/recipes-core/images/balena-image.bb:do_image_size_check) failed with exit code '1'
NOTE: Tasks Summary: Attempted 4889 tasks of which 4524 didn't need to be rerun and 1 failed.

@balena-ci rebase

@mtoman this is still failing the image size check
NOTE: recipe balena-image-1.0-r0: task do_image_size_check: Started
ERROR: balena-image-1.0-r0 do_image_size_check: The disk aligned root filesystem size 282624 exceeds the available space 274432
ERROR: Logfile of failure stored in: /work/build/tmp/work/genericx86_64-poky-linux/balena-image/1.0-r0/temp/log.do_image_size_check.80051
NOTE: recipe balena-image-1.0-r0: task do_image_size_check: Failed
ERROR: Task (/work/build/../layers/meta-balena/meta-balena-common/recipes-core/images/balena-image.bb:do_image_size_check) failed with exit code '1'
NOTE: Tasks Summary: Attempted 4915 tasks of which 4544 didn't need to be rerun and 1 failed.

@balena-ci rebase


Multiple row selection change when the selection is more then 100 record aprox.

Hi,
in a aggrid Table using the multiple row selection, when I select less than 100 row aprox.
it work perfect, but if I try to scroll down the list to select more rows, unselect a group of then from the first selection.
Un Saludo
Juan Ramírez

created support case https://support.servoy.com/browse/SVY-15209


update Fzcoin

My partner told me that I just modify these .I can't know what to do.please help me .


Create a simpler GH action in this repo

From https://github.com/TrustedComputingGroup/pandoc/pull/32:
I agree with @williamcroberts's feedback here; we may be able to delete the markdown repo entirely in favor of a GH action hosted in this repo.
Composite Workflows
IIUC it's a composite workflow others are using to generate the markdown rendering. However, it requires users to setup the docker container. I think if we move to a reusable workflow, we can move all of the setup into a reusable workflow so callers of the workflow don't have to do anything but use it. Additionally we can just use docker_run, no real need for the docker actions as docker run will pull the image.
markdown project
Do we need this? The pandoc project builds out the samples anyways, couldn't we just coalesce them or is the markdown project exist soley to test the action.yml composite workflow? It seems confusing to have so much stuff spread out, i'm not seeing the value in the decomposition.

Markdown repo can be released separately from this one, which is handy because we don’t touch the action as often as we touch the container


python312Packages.reolink-aio: 0.9.10 -> 0.9.11

Diff: https://github.com/starkillerOG/reolink_aio/compare/refs/tags/0.9.10...0.9.11
Changelog: https://github.com/starkillerOG/reolink_aio/releases/tag/0.9.11
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 344710 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.reolink
python311Packages.reolink-aio
python311Packages.reolink-aio.dist
python312Packages.reolink-aio
python312Packages.reolink-aio.dist


Pictures will not load in scroll distance example

Please verify the version of auro-carousel you have installed
2.2.7
Please describe the bug

Go to https://auro.alaskaair.com/components/auro/carousel
Scroll to custom scroll distance example
See error (pictures are not rendering)

Reproducing the error
This issue is reproducible on the Auro docsite
Expected behavior
Pictures render and example works as expected
What browsers are you seeing the problem on?
Chrome
Exit criteria
The pictures need to be rendered or removed, with the integrity of the purpose of the example still in place

The problem was coming from the picsum website where the pictures are grabbed from. The issue that was occurring is now fixed and this issue is no longer valid.


Changing the color of a TextFlow via State doesn't work.

Thanks for your library!
It seems like I can only set one color, changing the color of a TextFlow via a user action doesn't work

Thanks for using a library 🤗
That was an interesting bug 😄
Looks like TextMeasurer does not get invalidated when color or text decoration is changed, it is now fixed in #8.
I will release a new version soon 👌

This working like a charm, thank you for your work


Update docs to reflect db.Save behavior

Description
Please update the docs at https://gorm.io/docs/update.html#Save-All-Fields to reflect the correct behavior.
It looks like db.Save does only INSERT but never UPDATE different then mentioned in that section.

Is the ID of the record provided as indicated in the Save() section?


Allow command center default action to be configured

Testing #150396
I'd like to configure the command center to open the command palette instead of files and there is no way to do that right now.

This is mostly https://github.com/microsoft/vscode/issues/9285

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Make equistore.operations._utils TorchScript compatible

typing.Sequence is not TorchScript compatible
change iterator to range(len(keys)))
removed np.all operations for comparison (I don't know if this has been changed in the API, but a comparison between Labels returns a boolean in the current version)

TODO torch script tests

:books: Documentation preview :books:: https://equistore--322.org.readthedocs.build/en/322/

Currently getting an absurd error from _utils.py in #324. Essentially, the compiler says that it wants the default value for the check parameter as a tuple of strings (which it is, but it shows an error...)

Ok, yes the issue is that, as @Luthaf says, the size of the tuple needs to be specified


new release for nim 1.2

now that nim 1.2 is released, I immediately hit the '.. <' vs '..<' bug in rebuilding my project. putting out a new patch version of random would be a big help.

Sorry, done


View Bar fixes

What changes are proposed in this pull request?

Fixes the SortBy field_or_expr caret (it expands into Object mode when clicked now).
Limits results in the view bar to at most 10

Resolves #663
Resolves #665
How is this patch tested? If it is not, please explain why.
Locally.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[ ] No. You can skip the rest of this section.
[x] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

Fixes the SortBy  field_or_expr caret by expanding into Object mode when clicked
Limits results in the view bar to at most 10

What areas of FiftyOne does this PR affect?

[x] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Sure, I'll respond to your request in my server/websockets optmizations work. Lots of App changes have already had to occur there.


Add getJavaHome method to JbreResolver

Hi @zolotov, I see that the 0.3.0 release of the plugin will provide the ability to run the IDE using the JetBrains JRE. For a project at my company, I plan to use the JbreResolver to download the JetBrains JDK (rather than JRE) to register in the IDE as the SDK used to build a plugin and run it in the IDE sandbox. For this use case, I will need the Java home path of the downloaded JDK. The JbreResolver already knows this so it would be great if you could provide a getter for the root of the downloaded JDK/JRE (i.e. its Java home path which is new File(cacheDirectoryPath, artifactName)). This would be a lot cleaner for me than taking the path returned by the resolve method and doing ../../.. on it. Thanks for considering this feature request.

Hi @baron1405,
Sounds good to me. PR is welcome :)

Submitted PR #267
I decided that returning a data object from the resolve method would be cleaner than a getter and provide more flexibility.

Looks great. Merged


ci(*): typescript-eslint 8

Overview

PR Checklist

[ ] I did below actions if need

I read the Contributing Guide
I added documents and tests.

@manudeli

@vr-varad Could you resolve ci:eslint please?

0:0  error  Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): eslint.config.mjs
I am getting this error in suspensive/examples/vite-react-18-suspense-prerender-siblings-problem/eslint.config.mjs, do u have any idea what's it about? @manudeli

0:0 error Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): eslint.config.mjs I am getting this error in suspensive/examples/vite-react-18-suspense-prerender-siblings-problem/eslint.config.mjs, do u have any idea what's it about? @manudeli

So I need your help..! Actually I got same error before. Could you resolve that error please?

The no-throw-literal rule has been renamed to only-throw-error (https://github.com/typescript-eslint/typescript-eslint/pull/8701).
So for https://github.com/toss/suspensive/pull/1240#issuecomment-2322917332, I think instead of https://github.com/toss/suspensive/pull/1240/commits/488d9f7e4d422b7747f6c02a557167e1fe055bb3, it's better to use only-throw-error:
'@typescript-eslint/only-throw-error': 'warn',

0:0  error  Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser. The file was not found in any of the provided project(s): eslint.config.mjs
I am getting this error in suspensive/examples/vite-react-18-suspense-prerender-siblings-problem/eslint.config.mjs, do u have any idea what's it about? @manudeli

This error log is mentioned in recent typescript-eslint issues (https://github.com/typescript-eslint/typescript-eslint/issues/9774, https://github.com/typescript-eslint/typescript-eslint/issues/9749). It seems like the solution is adding allowJs to the tsconfig.jsons, but in my case doing this leads to hidden lint errors being thrown, which are quite a lot.....

I close this Pull Request because of #1326. @SEOKKAMONI but co-author please these people(@vr-varad, @saul-atomrigs) too. We struggled to solve this issue in this pull request


Doesn't reach to bottom of the screen when maximized

As you can see, I open a white image in background and having Spotify maximized on top of the image and there is a white line at the bottom of the screen.

Its a spotify bug that happens only in windows. Its not the theme's fault. Even without the spicetify that happens.


removing client out of download function

Can we move
download parameters
client = Client("SCEDC")  #
out of S0A_download_ASDF_MPI.py ?
Having the name of the data center as a string argument to ConfigParameters would be a lot better. They are generated by the FDSN routine web services: https://docs.obspy.org/tutorial/code_snippets/retrieving_data_from_datacenters.html
And users will know. it can be "IRIS" or "NCEDC" or "SCEDC", ...

Fixed in #106


#1361: draft implementation of isAlive method for CarinaDriver in IDr…

…iverPool

closing as out-of-dated


Update k8s deps

What this PR does / why we need it:
We need to update:
k8s.io/api
k8s.io/apimachinery
k8s.io/client-go
k8s.io/code-generator
k8s.io/kube-openapi
but those updates fail because we are using deprecated functions:
Error: e2e/client/ippool.go:37:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)
Error: e2e/client/pod.go:19:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)
Error: e2e/client/pod.go:25:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)
Error: e2e/client/replicaset.go:19:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)
Error: e2e/client/replicaset.go:25:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)
Error: e2e/client/statefulset.go:18:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)
Error: e2e/client/statefulset.go:50:9: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.  (SA1019)

This PR replaces those deprecated functions with the recommended one: PollUntilContextTimeout and does the update on those k8s dependencies
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer (optional):

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.357%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1136

Relevant Lines:
1570

💛  - Coveralls


feat(CategoryTheory/PathCategory): induction principles for morphisms in path categories

Introduce two induction lemmas to ease proofs on category freely generated on a quiver.

While experimenting, I found that in practice it’s a bit tedious to work with free categories on a quiver, as the instances get all confused when calling cases or induction on a morphism. This PR abstracts two induction principles that should ease this a little bit. The proof of induction' is admittedly a bit ugly.

The two new lemmas for inductions with fixed source/targets are now added (with in fact almost the same code as the previous ones! I guess I was already proving them in a way).

Thanks!
bors merge


Frontend modules are not listed

Hello,
I just upgraded from a month old version to the newest version 0.7.
Unfortunately some things broke on the way, and some are still not working.
I followed the new instructions closely, here is some code:
settings.py
INSTALLED_APPS = [
    'material',
    'material.frontend',
    'material.admin',
[...]

TEMPLATES = [
{
    'BACKEND': 'django.template.backends.django.DjangoTemplates',
    'DIRS': [os.path.join(BASE_DIR, 'templates')]
    ,
    'APP_DIRS': True,
    'OPTIONS': {
        'context_processors': [
            'django.template.context_processors.debug',
            'django.template.context_processors.request',
            'django.contrib.auth.context_processors.auth',
            'django.contrib.messages.context_processors.messages',
            'material.frontend.context_processors.modules',
        ],
    },
},
]

main urls.py
from material.frontend import urls as frontend_urls

urlpatterns = [
url(r'', include(frontend_urls)),
url(r'^django-rq/', include('django_rq.urls')),
url(r'^$', RedirectView.as_view(url='app1/', permanent=False)),
]

app1/__init.py__
default_app_config = 'app1.apps.App1Config'

app1/apps.py
from django.apps import AppConfig
from material.frontend.apps import ModuleMixin

class App1Config(ModuleMixin, AppConfig):
    name = 'app1'
    icon = ''

app1/urls.py
[...]
urlpatterns = [
    url(r'^$', App1List.as_view(), name='index'),
    url(r'^past/(?P<hours>[0-9]+)/$', App1PastList.as_view(), name='past'),

templates/app1/menu.html

24 Stunden

7 Tage

I guess I forgot something, because:

urls "don't match" (had to add them manually to main urls.py)
the menus don't appear in the sidebar

Did you include app1 and app2 in the INSTALLED_APPS settings?
Did you run ./manage.py migrate after that?

Closed. No activity

Sorry, yes migrate did fix it, I don't really understand why though.

Modules could be installed or uninstalled at runtime. The state managed by frontend.models.Module
and at the last migrate step, the frontend creates a new module record.


DiscordIntegration compatibility

Issue Description:
Unable to run discord commands from DiscordIntegration mod, when CraftTweaker is installed on a SpongeForge server.
Maybe related:
https://github.com/SpongePowered/SpongeForge/issues/1035
https://github.com/jaredlll08/CraftTweaker/issues/110
What happens:
When I try to use commands in discord via DiscordIntegration mod, a CraftTweaker error is shown on console:
[ReadingThread/INFO] [STDOUT]: [minetweaker.mc1102.server.MCServer:getPlayer:42]: Unsupported command sender: chikachi.discord.command.DiscordCommandSender@604b7a3c defaulting to server player!
[ReadingThread/INFO] [STDOUT]: [minetweaker.mc1102.server.MCServer:getPlayer:43]: player name: @Playername
[ReadingThread/INFO] [STDOUT]: [minetweaker.mc1102.server.MCServer:getPlayer:44]: Please report to mod author if this is incorrect!

What you expected to happen:
The command be executed.
Script used: None.

Affected Versions:

Minecraft: 1.10.2
Forge: 2281
Crafttweaker: 3.0.26

It shouldn't stop the command from being sent.
Fixed in 1.12


Added Icons

This pull request adds social icons to each of the fellow cards so that other viewers can go to these respective links.

The icons look super amazing @tapaswini-kodavanti, great job!
But it seems like they are going out of bounds, please have a look at it

Great work @tapaswini-kodavanti , it looks really good


Add 50-EMA Trade Opening Indicator

Price must be greater than 50c or less than 50c at some point in the last < x > minutes (more analysis needed). THEN start looking at the RSI hysteresis.

Added and tested.


Changelog and dependecy update

Fixes #445, #448
I will squash this PR later, so that one single commit gets created.
And it adds Fixes #445...,  so that all related issues get closed with this one

@PhilipPartsch  Thanks for all your PRs. :+1:
I need to enhance some stuff in the documentation of them, but as this are your first commits for this project, I just do it.
So no need for some loops in the related PRs, if the code itself is fine.
Here are the changes. Please tell me, if your are okay with them:

It adds you to the AUTHORS file. Just the github name, no email. Tell, if I shall write something else.
The Changelog entries must always have an Improvement or a Bugfix prefix
If github issues exist, add a link after the Bugfix / improvement line.
At least one commit of a PR should contain a line with Fixes #445, then github will automatically close the related issue, if the PR gets merged. I do this now in this PR :)

No longer needed.
Some stuff moved to #461


(PDB-3840) Clean up additional orphaned facts

Prior to this commit the facts table could still contain orphaned facts if an entry on the facts table had no reference in the fact_paths or fact_values table.
After this commit we remove any facts that don't have a matching id on the fact_paths table and the fact_values table.

Test FAILed

CLA signed by all contributors.

Looks like I need to add / modify some tests.  I probably need some guidance here.

Sorry this has languished for so long.  I've been taking a look and the code does rebase fine onto 5.2.x (which is where we'd probably want it if we decide to proceed), but it fails because at that point in the migrations, there is no fact_values table.  And out of curiosity, do you happen to recall if you ran in to orphaned fact paths at this point in the migrations, or was it more a theoretical concern?
In pdb 5.1+, which stores facts via jsonb facts, (some) phantom/orphaned fact paths are expected since the fact_paths table there is just an approximate cache of the paths represented by all of the factsets.

Ahh, I misunderstood -- I see that this is trying to delete facts with orphaned paths, which is what we'd want, and I found the errors you'd recorded previously.  So I think that the first delete here makes sense.
As mentioned, the second one won't work at this point in the migrations because fact_values doesn't exist, so I'm wondering if either we don't need it, or if it's possible this fix isn't quite in the right migration, i.e. that table would exist in an earlier migration (before the one that dededuplicated fact values), or in a later migration (when we reversed that change).
In any case, from the logs, the first delete is clearly fixing that problem in the right place, so we should include it now, and I  we can handle the second delete separately, once we're sure we need it and we know where it should go.

I'll handle the adjustments, rebasing, etc. and we'll get it merged.  Thanks again for the help, and apologies for the delay.

I've rebased this onto current 5.2.x and fixed the fact_values reference here: https://github.com/puppetlabs/puppetdb/pull/2968  So closing this in favor of merging your changes there.  Thanks again for the help.


Update to FontAwesome 4.5

Currently the SDK contains version 4.2.
This request contains the updated font itself and the updated AwesomeUtils.as

The issue is solved with this pull request: https://github.com/apache/flex-sdk/pull/39
If somebody could merge it, I'll test it by using the latest build.

This has been done mind closing?

I've just tested the latest build, works like a charme. Thanks!


Problem downloading NextMajor/Master

Describe the issue
Looks like we've only been getting 'core' versions since the 28th Jan.
I can only see Version 24 localised versions for 27th Jan and before.
Scripts used to create container and cause the issue
PS C:\Users\Administrator> Get-BCArtifactUrl -select NextMajor -country core -accept_insiderEula
https://bcinsider.azureedge.net/sandbox/24.0.15939.0/core
PS C:\Users\Administrator> Get-BCArtifactUrl -select NextMajor -country w1 -accept_insiderEula
https://bcinsider.azureedge.net/sandbox/24.0.15733.0/w1
PS C:\Users\Administrator> Get-BCArtifactUrl -select NextMajor -country dk -accept_insiderEula
https://bcinsider.azureedge.net/sandbox/24.0.15733.0/dk

PS C:\Users\Administrator> Get-BCArtifactUrl -select Latest -before '2024-01-31' -storageAccount bcinsider -accept_insiderEula -version '24.' -country w1
https://bcinsider.azureedge.net/sandbox/24.0.15733.0/w1
PS C:\Users\Administrator> Get-BCArtifactUrl -select Latest -before '2024-01-28' -storageAccount bcinsider -accept_insiderEula -version '24.' -country w1
https://bcinsider.azureedge.net/sandbox/24.0.15733.0/w1
PS C:\Users\Administrator> Get-BCArtifactUrl -select Latest -before '2024-01-27' -storageAccount bcinsider -accept_insiderEula -version '24.' -country w1
https://bcinsider.azureedge.net/sandbox/24.0.15728.0/w1
PS C:\Users\Administrator>

Additional context
Seems repeatable, DevOPS logs seem to have the same master version for the last few days.

NextMajor has been broken since January 27th due to some changes with PowerShell.
core is not a country, that is just the compiler and some other stuff, which are not broken.
So,... - get-bcartifacturl with country us and select nextmajor will give you the latest good NextMajor (even though it is a week old)

Unfortunately not, that version isn't good; it's been bad since about the 20th Jan due to a mess up with the compiler so the latest good is over two weeks old and I'd have to use -before, but that doesn't work for NextMajor. (It does with master though so I can fake it)

Got it.
As part of our build validation (right before we generate artifacts), we test the artifacts by creating a container with Business Central and see that it can start and we can login - if this fails, no artifacts are generated.
We could add a compile to this step - but then again, I don't think the problem you have with the compiler would be caught by any simple test as my test next major pipelines still works fine: https://github.com/microsoft/bcsamples-bingmaps.pte/actions/runs/7770990198 (running on build 15733 that is)

Morning Freddy,
According to our extension collection you have about a 5% chance of catching the 20th issue, over 95% of them (mostly trivial of course) build successfully. IMO the only realistic way Microsoft can catch it is the way it happened; we tell them they fix it and add a regression test.
I guess maybe you could add a "Known-Bad" filter so you can relabel the images later, but that sounds annoying to keep up to date. Even just simple date filtering them for NextMajor is likely a management chore that you really don't need and probably doesn't help us any because of the variability.
Though, I have done the latter myself adding an optional -before date to the pipeline build variables so I can hold NextMajor if I need to have it building more than I need to know when it gets fixed, perhaps something for AL-Go ?

Not sure how you came to 5% chance - what I mention is that on top of all the tests running in BC and all the tests running on the compiler in their repo - I run a container test before publishing artifacts - these very very very seldomly fail - but when they do, they would have been hitting every single partner using artifacts (= a lot).
This is the reason for this test and the reason why artifacts in next major are delayed.
If there are bugs in the compiler or in BC - they must be handles elsewhere.
Sometimes, bugs stumble over each other and cause a longer than good delay in publishing artifacts - but that is not very often.

I was agreeing with you, you could in theory create an extra extension and do various tests with that but with all those other tests there are some additional random posting is "very very very" unlikely to catch anything extra.
NB: The 5% was just how many of our little extensions failed because of the compiler issue.

They're back! 🎉
Uhhhh, but the Microsoft tests don't load.
Works:   -includeTestToolkit -includeTestLibrariesOnly
Doesn't Work:   -includeTestToolkit
Hmm, you don't test that here, I'm not sure if that's a problem ... ?

The problem is with the Business Foundation Test Libraries, which are not automatically included.

That is a containerhelper bug - fix is on it's way.

Shipped in preview now

Got 6.0.6


Error: The argument type 'Registrar' can't be assigned to the parameter type 'BinaryMessenger'

Platform:

[x]  Flutter Web

IDE:

[x]  VSCode

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[x]  CanvasKit Disabled

Platform installed with:

[x] pub.dev

flutter doctor -v
[✓] Flutter (Channel unknown, 1.24.0-10.2.pre, on macOS 11.1 20C69 darwin-x64, locale en-US)
• Flutter version 1.24.0-10.2.pre at /usr/local/flutter
• Framework revision 022b333a08 (9 weeks ago), 2020-11-18 11:35:09 -0800
• Engine revision 07c1eed46b
• Dart version 2.12.0 (build 2.12.0-29.10.beta)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/adam/Library/Android/sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.3, Build version 12C33
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.52.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.18.1
[✓] Connected device (3 available)
• Web Server (web)       • web-server                               • web-javascript • Flutter Tools
• Chrome (web)           • chrome                                   • web-javascript • Google Chrome 87.0.4280.141
• No issues found!

The version of the SDK (See pubspec.lock):
4.0.2

I have the following issue:
Attempting to run a flutter web debug build on chrome, I get the following compile time failure:
Launching lib/main.dart on Chrome in debug mode...
../../../.pub-cache/hosted/pub.dartlang.org/sentry_flutter-4.0.2/lib/src/sentry_flutter_web.dart:12:7: Error: The argument type 'Registrar' can't be assigned to the parameter type 'BinaryMessenger'.
 - 'Registrar' is from 'package:flutter_web_plugins/src/plugin_registry.dart' ('/usr/local/flutter/packages/flutter_web_plugins/lib/src/plugin_registry.dart').
 - 'BinaryMessenger' is from 'package:flutter/src/services/binary_messenger.dart' ('/usr/local/flutter/packages/flutter/lib/src/services/binary_messenger.dart').
      registrar,
      ^

Failed to compile application.
Exited (sigterm)

Steps to reproduce:
I encountered this issue after running flutter pub upgrade with sentry_flutter: ^4.0.1 in pubspec.yaml ... pubspec.lock now has:
  sentry_flutter:
    dependency: "direct main"
    description:
      name: sentry_flutter
      url: "https://pub.dartlang.org"
    source: hosted
    version: "4.0.2"

Pinning to exact version 4.0.1 is a work-around.

hey @ajbarry thanks for this, have you tried upgrading your flutter env? it should not be an issue on the latest beta

hey @ajbarry thanks for this, have you tried upgrading your flutter env? it should not be an issue on the latest beta

Hrm... ok. Thanks for the update. We're kinda pinned down to Flutter 1.24.0-10.2.pre due to a number of null-safety dependencies that Flutter 1.25+ has dragged in with it. I will lump this into our watchlist of issues we need to resolve ourselves.
Thanks again for letting me know. I'll close the issue.

Hrm... ok. Thanks for the update. We're kinda pinned down to Flutter 1.24.0-10.2.pre due to a number of null-safety dependencies that Flutter 1.25+ has dragged in with it. I will lump this into our watchlist of issues we need to resolve ourselves.
Thanks again for letting me know. I'll close the issue.

@ajbarry https://github.com/getsentry/sentry-dart/releases/tag/4.0.5 we've reverted that change, so it'd not be an issue anymore

@marandaneto Thanks for the heads-up! We'll give it a spin.


Setup Yarn workspaces correctly

It's fucked at this moment and therefore not possible to publish workspaces dependent on other workspaces (missing workspaceDependencies):
▲ quick-payments at react-native-web ✖ y workspaces info
yarn workspaces v1.9.4
{
  "_api": {
    "location": "packages/api",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_fbjs": {
    "location": "packages/fbjs",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_navigation": {
    "location": "packages/navigation",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_relay": {
    "location": "packages/relay",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_scenes": {
    "location": "packages/scenes",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_shared": {
    "location": "packages/shared",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_translations": {
    "location": "packages/translations",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  },
  "_web": {
    "location": "packages/web",
    "workspaceDependencies": [],
    "mismatchedWorkspaceDependencies": []
  }
}
✨  Done in 0.05s.

Also, how to test that all dependencies are OK for the workspace to be published?


Let me know if the fix looks okay, I will add a regression test.
fixes #31383

[x] I have followed (at least) the PR section of the contributing guide.

https://github.com/mui/material-ui/blob/564de537968e3f42d21b3ac2c85db81559566ba5/packages/mui-base/src/AutocompleteUnstyled/useAutocomplete.js#L1079
Your solution is solving the issue and working fine, but I think changing onMouseOver to onMouseEnter will also do the trick and it might be a bit better. The difference between these two methods is that the onMouseEnter will not be triggered on Event bubbling(which causing this error here).

@alisasanib Thanks! Worked like a charm.

The fix works, but it doesn't solve the problem completely - when you move the mouse out of the listbox and then hover again, the onHighlightChange fires even though the highlight did not change. This may be treated and fixed as a separate bug, though (but feel free to try to tackle it here if you'd like).


@fredmk's axios refactor rebased on dev

I have rebased the axios branch on top of dev with these results.
https://github.com/FredMK/minimed-connect-to-nightscout/tree/axios

Great! Do we need a branch of Nightscout that points to this to enable testing?

Yes, I've been trying to test it a little bit more since there are substantial changes, but short on time.  If we think a bounty/contract could solve this for reasonable price, T1Pal might be willing to fund development on this.

Tying it all together:

https://github.com/nightscout/minimed-connect-to-nightscout/issues/5#issue-687862738
https://github.com/nightscout/minimed-connect-to-nightscout/issues/9

@FredMK, your changes are merged into dev now with tests passing.


App not running on the web

When we run app on the web after adding this package, it gives the following error, and the app gets terminated:

Is there any update on this? This is a compile time error on Flutter web and it really restricts us since we're using Web, Android and iOS builds for our flutter project.

There seems to be an issue with Line 3 and Line 4, these are unused imports and we can simply remove them from the package.
I can create a PR if I am given rights. It's just removal of two lines.
@purushyb @sankalp211 @rohit-131 @sukrit-ym

Hi @Coffiie can you mention imports here that need to be removed?
@sankalp211 please check this.

Sure, they are these two. They are unused, so safe to remove.
import 'dart:developer';
import 'dart:ffi';

Thanks @Coffiie ..let me get this removed and tested. If everything works fine we will release a patch fix by Wednesday EOD.

Sounds good! Looking forward.

@Coffiie @Usmani7
This is resolved in version v2.7.1. Please update to the latest.

@Coffiie @Usmani7
This is resolved in version v2.7.1. Please update to the latest.

Thanks! It's working now <3


Increment and Decrement patterns can effectively be merged into one as Counter pattern

Is there any inherent benefit in having two separate counter patterns, i.e. Increment and Decrement ?
Current:
ip = FlowIpv4(src=FlowPattern(choice='increment', increment=FlowIncrement(start='<IP_ADDRESS>', step='<IP_ADDRESS>', count=10)))
ip = FlowIpv4(src=FlowPattern(choice='decrement', increment=FlowDecrement(start='<IP_ADDRESS>', step='<IP_ADDRESS>', count=10)))

Proposed:
ip = FlowIpv4(src=FlowPattern(choice='counter', counter=Counter(start='<IP_ADDRESS>', step='<IP_ADDRESS>', count=10, up=True)))
ip = FlowIpv4(src=FlowPattern(choice='counter', counter=Counter(start='<IP_ADDRESS>', step='<IP_ADDRESS>', count=10, up=False)))

The benefit is that an auto-generated class removes the user from the tedium of having to specify direction.

I just corrected the proposed snippet.
Isn't it more tedious in existing snippet ?

Increment vs Decrement
choice='increment' vs choice='decrement'
increment=Increment( vs decrement=Decrement(

vs
in proposed snippet, all data structure, enum and attribute name remains the same except

up=True vs up=False

A good code generator will attempt to hide the choice (its the equivalent of polymorphism).
What you are then left with is using an explicit Increment or Decrement class (intent is obvious to someone reading the code) and not having to specify up every time a counter pattern is needed.
That being said it can be more terse by specifying Counter and defaulting up to True.  Up=true appears to be the most common pattern.
This would result in the following:
    Flow.Pattern:
      description: >-
        A container for packet header field patterns.
        Possible patterns are fixed, list, counter, random.
      type: object
      required: [choice]
      properties:
        choice:
          type: string
          enum: [fixed, list, increment, decrement, random]
        fixed:
          type: string
        list:
          type: array
          items:
            type: string
        counter:
          $ref: '#/components/schemas/Flow.Counter'
        random:
          $ref: '#/components/schemas/Flow.Random'

    Flow.Counter:
      description: >-
        A counter pattern that can increment or decrement.
      type: object
      properties:
        start:
          description: >-
            The value at which the pattern will start.
          type: string
        step:
          description: >-
            The value at which the pattern will increment or decrement by.
          type: string
        count:
          description: >-
            The number of values in the pattern.
          type: number
        up:
          description: >-
            Determines whether the pattern will increment (true) or decrement (false).
          type: boolean
          default: true

https://github.com/open-traffic-generator/models/commit/26085a9c19cad38f833191d7f1b6c791e26eaf8b

A good code generator will attempt to hide the choice (its the equivalent of polymorphism).

Very True ! Had the same thought in my head going through all the models with choices :)

A set of python classes is available that mirrors the model.
pip install abstract-open-traffic-generator
The tests that are part of the package demonstrate how to use them.


Port prover tests to Python

This looks really nice overall. I would like to make sure of a few things:

Check that when running locally the same number of tests are run as with make test-prove on master.
Check that when running on CI, the same number of tests are run as on master.
Check that if you break a test not listed in tests/failing-symbolic.pyk, the test harness registers the breakage correctly (and fails). You can break a test by just modifying one of the output cells that it's actually asserting something about.
Check that if you break a test that is listed in tests/failing-symbolic.pyk (so it uses the legacy prover), then the test harness registers the breakage correctly (and fails).

Check that when running locally the same number of tests are run as with make test-prove on master.

Done. I actually did a bit more: I listed kprove invocations with make --dry-run and test cases with pytest --collect-only (after adjusting for skipped tests), and paired them up. Also confirmed that legacy / pyk tests are matched with the right command line call (i.e. the --pyk flag). (test-cases.txt)

Check that when running on CI, the same number of tests are run as on master.

Done.

Check that if you break a test not listed in tests/failing-symbolic.pyk, the test harness registers the breakage correctly (and fails).

Done.

Check that if you break a test that is listed in tests/failing-symbolic.pyk (so it uses the legacy prover), then the test harness registers the breakage correctly (and fails).

Done.


feat: add sd-jwt support

Adds support for vc+sd-jwt format as described in https://github.com/vcstuff/oid4vc-haip-sd-jwt-vc
Because the format specific for vc+sd-jwt are a bit different than the other formats, it exposed some issues with the types currently being used. I updated all interfaces, made the uniform interfaces match draft 11 fully, and moved some v8/9 specific types outside of the uniform/generic types.
Because the types are different, and it exposed some issues with the current way requests are being made, there's more format speicfic logic now inline. I've didn't want to make this PR bigger than it currently is, so I've created a separate issue #76, to explore that work.
All tests are passing except the e2e test with mattr launchpad, as it's currently down for maintenance. In addition I had to change some tests with vendors, as the expected types do not match with the spec. They all hardcode that the version is draft 8, but then they use a format that is somewhere in between draft 8 and 9. Mabye that's what those vendors implemented, or maybe it was just a mock that was created? I don't know, but I've corrected them now.
I think if we also address #75 at the same time we address #76, it can clean up a lot of format specific code that's now spread across the repository

Cool thanks, will have a look later today

FYI @nklomp, made a another PR that builds on top of this PR: https://github.com/TimoGlastra/OID4VCI/pull/1
But it needs a few tweaks before it's ready to be merged (need to get some input from my team on what the input looks like with SD-JWT VCs) as you need to provide some details about which fields can be disclosed, etc..

Let's keep the version discussion for #75. Per approved and to be merged.


Set type of POSIX_SPAWN_* flags to c_short

Changing the type from c_int to c_short will likely not break existing programs. It might introduce warnings about no-longer needed conversions to c_short though.
Fixes #3627

Docker failure is unrelated


Popup appears in wrong spot when set manually before trigger is activated.

Steps

Set up a controlled popup(open prop).
Set initial open state to true, or press an external button that can turn it on.
Turn it on and off as much as you like, it'll stay in the top corner.
Activate trigger (either press or hover depending what the "on" prop is)
Now button makes popup appear in the correct spot.

Expected Result
The popup appears where it normally should.
Actual Result
It appears in the top right corner.
Version
0.63.0
Testcase
http://codepen.io/anon/pen/Mbxmyj

I went through and I think I figured out what was wrong. Open isn't actually a prop of Popup, it is a prop of Portal and the example on the popup page takes advantage of the pass-through that Popup does. Popup relies on the event object in onOpen in order to find it's this.coords. My best guess would be that when the open prop is manually triggered there isn't an element to connect to that event so Popup gets lost.
I'm not entirely sure what the fix would be. A really sketchy fix I just did for myself is that I fired a click event on the trigger to help the Popup find it's trigger.
http://codepen.io/anon/pen/xRBrrN?editors=0011
Along the same lines another option would be to put the click in componentDidMount() and then take setState out of onOpen effectively disabling the trigger and forcing the popup to rely on the button.
A much better solution would be to find a way to get the trigger element without having to cause DOM events because that's not a very React thing to do.

I have stumbled upon this issue as well. However in my case using synthetic events somehow wreaks havoc on the whole event system and some other unrelated events are fired. Please fix this.

It looks like the position is not being calculated at the correct time.  PRs welcome.

@levithomason I'm thinking of making popup stick to its trigger, because there are problems when I try to compute position when the trigger is rendered and then it changes position.

I think this makes sense, if the trigger moves, the popup should move with it.

I have added a PR for a possible fix for this here:
https://github.com/Semantic-Org/Semantic-UI-React/pull/1190

I'm still seeing this, in my case I am controlling the popup from the outside by placing it inside a div container and opening it via the onContextMenu event of the div.

What was the reason Portal was used for this?
I think Popup should not be ripped out of the DOM and re-located. I believe this creates unnecessary complexity that could be solved more succinctly with basic css: Wrap the trigger in a container with a non-static (probably relative) position, and Popup's position set to absolute. This way, Popup will always be relative to its trigger. This would be more significantly more efficient on a number of levels.
I put together a very simple example: https://jsfiddle.net/jshado1/hzy4qvu9/

@jshado1 I assure you, no DOMs were ripped in the making of this Popup.  We cannot make assumptions about the user's trigger styling.  Forcing their trigger to position relative may have consequences.
Fixed in #2775

I read #2775 and don't understand what the fix was. I'm still having this issue when using the open prop.

@djnorrisdev If there's a bug, let's open a new issue and we'll tackle it.


Markdown component not working

Hi,
I was trying the doc examples for markdown and latex but I don`t have the same result:
def show_equation():
    return pc.vstack(
        pc.markdown("Equation"),
        pc.markdown(
            """
            Support us at **[Pynecone](https://pynecone.io)**.
            Format your `inline_code` easily.
            """
        ),
        pc.markdown(r"\int_a^b x^2 dx $"),
    )

Is there something to enable?
OS: Windows 10/WSL/ubuntu
Pynecone: 0.1.10
Thanks!

Try to indent your string block to first level, same to def.
We are going to add auto de-indent to fix this problem.

ah! ok! works now for the block.
What about the latex?

Ah ok it works with another latex equation:
        pc.markdown(r"$$V_{sphere} = \\frac{4}{3}\\pi r^3$$"),


Fix ESP8266 build

This change is to fix build for ESP8266 board with jerry_api_value_t changes.
JerryScript-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

Though this is just a build fix, it fails to run in the target board for some reason that needs investigation. I'll work on this after this PR lands.

LGTM

LGTM

@seanshpark, please rebase to the current master, so we can land your PR.

Done rebase, thank you.

CI fails, last merge is #1104. @zherczeg , can you please check ?

We have already spent a lot of time reproducing this issue, but no luck so far. It only appears on travis arm build. I submitted another patch, and it disappeared.

Thank you, rebase and merged.


docs(Combobox): update "Binding objects as values" example

Updates an example in the docs  to clarify the need for displayValue prop when binding an object.
Helps to avoid confusion e.g. #1190.

Make perfect sense! Thanks for the PR and issue @Destiner !! 💚


fix: stream revision no stream conflict

Please validate my assumptions below, but it seems to work this way.
The revision must be the number before not at the point of entry for an event.
If a stream has 1 event the revision needs to be 0 to add an event, if there is 2 events the revision needs to be 1.
So currently if you want to add an event at revision 1 (for the second event) you have to set the revision to 0 which conflicts with StreamRevisionNoStream.

Thanks for the PR @bweston92!


Opaque keys interfaces

PK interface changes for opaque key support.
Objectives:

Support opaque keys (keys where the key material is not directly available to Mbed TLS) in the pk interface, and as signature or decryption keys in TLS.
Define an interface that opaque key engines can implement. (pk_info.h)

Limitations: there is only minimal testing for now and no sample application. A subsequent PR will add an engine that's suitable for testing.

@mpg - the test_suite_pk failures are due to an RSA wrapper test failing, which is being implemented in the next feature branch. @gilles-peskine-arm - should I remove the test and leave it in the RSA pull request only?

@AndrzejKurek The test suite should pass locally. Please comment out the failing test cases (# at the beginning of every line and the following blank line).

Updated the pull request with almost all changes. Please re-review.

Resolved conflicts with current develop.

All of the requests have been addressed. @gilles-peskine-arm, @hanno-arm, @yanesca - please re-review the introduced changes.

Only the timing test suite for Microsoft fails on the CI now.


Why EventEmitter: memory leak detected gets emitted after ten redirects

I found the existing answers insufficient on this point so I thought I would try to write up an explanation.
By default request will follow up to ten redirects. If you have a server that is misbehaving, for example redirecting to itself, request will follow the redirect up to ten times and then return an error.
However, the request also listens for an incoming request body - you can pipe a Readable to the request object and this library will read and upload that response. This is done by registering a request.on('pipe', (src) => ...) listener in the request source code.
The problem is that on each followed redirect, request redeclares the .on('pipe', (src) => ...) listener, so by the 7th redirect you have 7 listeners and so on. By default the EventEmitter warns after ten of the same event have been registered, which is why you get Possible memory leak detected exactly once, with the default settings for both the EventEmitter and for request.
This is probably a mistake - if you did manage to pipe the request body to the 7th HTTP request, you would have seven listeners by that point, each firing independently, and it's not clear what would happen - you might end up with the request body duplicated seven times, or just written seven times to something that's not listening. However, there is a separate issue where this piped request body is only sent on the first request, not all of them, see #3138.
So is there actually a memory leak if you have lots of redirects? Probably not... the listeners are registered on the request object, as long as that request object goes out of scope (you're not holding a reference to it somewhere) then it will eventually get garbage collected and the event emitters will be collected.
What is the fix? In this library, either unregister and re-register the pipe handler each time a new redirect is issued, don't re-register the pipe handler if we are following a redirect.
In your code, it's probably safe to either set maxRedirects to 9, or EventEmitter default to 11, either of which will resolve the issue, as long as your request objects are getting garbage collected (they probably are).
Note if you are getting memory leak detected for behavior other than redirect following there may still be a memory leak, see for example https://github.com/request/request/issues/2575.

I have the same issue. Is there any solution for this.


doc: added CONTRIBUTING.md and CODE_OF_CONDUCT.md

Signed-off-by: David<EMAIL_ADDRESS>Pull Request
Required Fields
:mag_right: What kind of change is it?

docs

:dart: What has been changed and why do we need it?

added CONTRIBUTING.md and CODE_OF_CONDUCT.md

Optional Fields
:heavy_check_mark: Which issue(s) this PR fixes?

...

:speech_balloon: Additional information?

...

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


strange effects with "import"

I noticed two strange things when importing files in directories outside the hott directory:

I have two files decl.hlean and basic.hlean in one directory. decl.hlean compiles without error, but when I write import .decl in basic.hlean it gives me an invalid import, unknown module error. (I tried deleting the olean-Files, clearing the cache, rebuilding Lean and whatnot)
Auto-complete on imports shows me the theories from library/, not /hott, even if I'm in a .hlean file

@avigad helped my with that first point, I didn't know that the project files were necessary

There are still two issues: there should be an option for creating a
default "hlean" project instead of "lean". And when editing an hlean file,
tab completion on import should use the hlean library.
On Thu, Jan 8, 2015 at 9:30 PM, Jakob von Raumer<EMAIL_ADDRESS>wrote:

@avigad https://github.com/avigad helped my with that first point, I
didn't know that the project files were necessary
—
Reply to this email directly or view it on GitHub
https://github.com/leanprover/lean/issues/389#issuecomment-69284971.

Auto-complete on imports shows me the theories from library/, not /hott, even if I'm in a .hlean file

This is a known issue. I need to work to support .hlean files.

I think this one is resolved. If not, please re-open this one.