Autoencoder vs VAE [question]

Hello, I trained two state representation models, one with the vae loss and one with the autoencoder loss, both on the KukaRandButtonGymEnv-v0 and for the same number of epochs (5) and state dims (5). The vae model reconstructs very poorly the input image compared to the autoencoder:
vae:

autoencoder:

It seems like it's producing an average over the dataset. Does it sample from the data likelihood distribution or does it calculate the mean value of p(x|z)?
Also when visualizing the learned space with the enjoy_latent module I noticed that the states of the autoencoder have a wide range (for example [-20, 20]) and the produced visualizations are quite different. On the other hand the states for the vae  have a very narrow range (for example [-0.04, 0.04]) and the produced visualizations are almost identical.  Is this an expected behavior?
Autoencoder (min, max):

VAE (min, max):

Hello,

The vae model reconstructs very poorly the input image compared to the autoencoder:
Also when visualizing the learned space with the enjoy_latent module I noticed that the states of the autoencoder have a wide range

I would say those two behaviors are expected. The VAE has an additional KL loss, so its latent space distribution approximates a multi-dimensional gaussian with a unit standard deviation. This loss is combined with the reconstruction loss, so they may interfere: as it adds a new constrain, it is harder for the VAE to reconstruct the image. The KL loss also explains the bounds of the VAE latent space: the AE is not penalized when its latent space has a wide range, but this is true for the VAE.
In your case, I would try to add more dimensions (so it is easier for the VAE to reconstruct the image), more epochs, and maybe play with the \beta coefficient (which weights the importance of the KL loss and reconstruction loss). Btw, how many samples are you using for training?

Does it sample from the data likelihood distribution or does it calculate the mean value of p(x|z)?

It samples, the corresponding line: https://github.com/araffin/srl-zoo/blob/master/evaluation/enjoy_latent.py#L35

Hi, thanks for the quick response. I'm using 1568 samples. I'll try with more dimensions, samples and epochs and see how it goes. Do you provide any way to visualize a "combined" model? I'm trying to implement something like the World Models model so I trained a model with the forward and autoencoder loss and I would like the the forward model to predict the next state given the current and an action and the autoencoder to reconstruct the observation from the state.

Do you provide any way to visualize a "combined" model?

We provide way to visualize combined models when combined means combining a method with a decoder (=auto-encoder) with another loss (ex: inverse dynamics, where we use knn on the dataset).
However, we don't provide visualization for future observation, but it should not be too hard to integrate.
Feel free to submit a PR if you integrate it ;)

Okay thanks!

Actually, about the VAE and autoencoder, I have recently discovered a bug (see the issue #53). By  fixing this bug, I have successfully reconstructed image with VAE:

The left two images are original images, and the right two are reconstructed. Without my fix as described in #53, I got similar result to your images. So it's definitely the source of your problem.


Create GitHub pre-release releases for TestFlight uploads

We should also ensure we only create a new TestFlight upload if there are changes to release.

We can probably get away without doing this for v1, but we'll need it for future versions.

Actually, on second thought, I think we need to keep this to make sure we don't loose development symbols etc.

This has now been done.


Question about Hierarchy Plot

Hi Angelina,
just a quick question. How should the hierarchy visualization be interpreted?
Thank you very much in advance! :)
All the best,
Nastassia

They serve as a sanity check on if the co-occurrences are aligned with your mental model. For example, in a dataset if forks and spoons co-occur frequently, this is probably what you would expect, but if forks and soccer balls also co-occur just as frequently, this may lead to a different understanding of what kinds of images the dataset contain (maybe more outdoor eating scenes than indoor ones)


Update style.css

This updated CSS perfectly resolves issue #167
and this is the updated PR of #172 as there was a change requested by you..
I hope you consider this PR maam..

resolve conflicts

https://deploy-preview-179--simply-tasked-list.netlify.app/
check here your pr preview.


control flow analysis incorrectly narrows type to never when type-guarded

Bug Report

The new control flow analysis incorrectly narrows a type that is type-guarded to fallback to never in the else clause when they should either remove the type-guarded type or stay the original type if not explicitly typed earlier. They should only fallback to never when all types are exhausted (if enum or was an initial set of types).
🔎  Search Terms

control flow analysis
never
type narrowing
type guard
🕗  Version & Regression Information

This changed between versions 4.3.5 and 4.4
This is still a problem in 4.5.0 nightly as of 2021-08-31

⏯  Playground Link

Playground link for 4.3.5 (no error)
Playground link for 4.4.2 (error)
Playground link for 4.5.0-dev.20210831 (error)
💻  Code

interface Box {
    isSmallBox(): this is SmallBox;
    isLargeBox(): this is LargeBox;
    sayHello(): any;
}

interface SmallBox extends Box {
    sayHello(): string;
}

interface LargeBox extends Box {
    sayHello(): number;
}

const b: SmallBox|LargeBox = {
    isSmallBox() { return false; },
    isLargeBox() { return true; },
    sayHello() { return 0.7734; }
}

const isLargeBox = b.isLargeBox();

if(isLargeBox) {
    b.sayHello();
} else {
    b.sayHello();
}

🙁 Actual behavior

The last b.sayHello() has b as type never, causing an error.
🙂 Expected behavior

The last b.sayHello() should have b as type SmallBox

This is the correct behaviour. Your variable b is not typed SmallBox | LargeBox, it is typed LargeBox. TypeScript correctly sees that the value isLargeBox is always true, and as a result you end up with never in the else-branch.
You see the behaviour you expect if you type b as SmallBox | LargeBox, e.g. using a type-assertion: const b = { ...} as SmallBox | LargeBox.

That b is narrowed to LargeBox despite your explicit type annotation SmallBox | LargeBox is intentional as well. Assigning a value to a variable narrows the variable to the assigned type. Otherwise code like this would not work:
const value: number | undefined = 123;
value.toString(); // If this were still typed `number | undefined` then we couldn't call the function.
// But TypeScript can see that a number is always assigned and the value can't be `undefined`.

TypeScript correctly sees that the value isLargeBox is always true

To clarify, it sees this not because of the return true in the object literal initializer; it sees this because of everything else @MartinJohns explained; that b is immediately narrowed to LargeBox and then it simply looks at this is LargeBox and says “yep, it sure is.”

I don't think TypeScript sees isLargeBox always returns true.
Instead, I think it sees sayHello() return number, making b a LargeBox, which means b has an impossible type in the else statement.
You can validate this by checking that b.sayHello() returns number  before any narrowing. But b.isLargeBox() is still described as returning an open value: this is LargeBox. TypeScript doesn't look into the function's implementation to see if it always return true or not.

@andrewbranch This updated example actually looks like a bug of the #44730 feature. a.isLargeBox() || b.isLargeBox() should not narrow a to LargeBox.

Thanks @MartinJohns Will add the explicit attribute.


to_json_val results in type information instead of value when using skip_serializing

Hi,
when creating a JSON representation of an initialized struct via doku::to_json_val(&Config::default());, fields that are marked with #[serde(skip_serializing)] are set to their respective type and not, as expected, to the corresponding value.
use doku::Document;
use serde::Serialize;

#[derive(Serialize, Document)]
struct Config {
    /// Database's host
    db_host: String,
    #[serde(skip_serializing)]
    skip_ser: String,
}

impl Default for Config {
    fn default() -> Self {
        Self {
            db_host: "localhost".to_string(),
            skip_ser: "skip_ser".to_string(),
        }
    }
}

fn main() {
    let doc = doku::to_json_val(&Config::default());
    // passes
    assert_eq!(
        r#"{
  // Database's host
  "db_host": "localhost",
  "skip_ser": "string"
}"#,
        doc
    );

    // fails
    assert_eq!(
        r#"{
  // Database's host
  "db_host": "localhost",
  "skip_ser": "skip_ser"
}"#,
        doc
    );
}

Hi,
When using to_json_val(), Doku relies on Serde to provide values for fields - since you're using skip_serializing, Serde doesn't provide those values and so unfortunately Doku has no way of knowing/discovering them.
You could instruct Doku to ignore those fields though:
let doc = doku::json::Printer::default()
    .with_visibility(doku::Visibility::SerializableOnly)
    .with_value(&Config::default())
    .print(&Config::ty());

This should return a document without the skip_ser field present at all 🙂

My use-case is a service that expects a JSON input to deserialize into a struct and then serialize that struct to pass to another service. Parts of the struct should not be serialized and passed to the other service but used otherwise. To document this service, fields with #[serde(skip_serializing)] need to present in the documentation since they are expected when deserializing the input. Ideally the documentation would contain example values which are also used in tests to verify that the provided documentation always works.
The easiest approach I found would be to use #[serde(skip_serializing)]. Other approaches I think would work:

Use #[doku(example = "skip_ser")] with doku::to_json::<Config>(). This would work but create lots of example annotation which would need to be maintained in addition to example structs used in tests.
Same as 1 but use Doku to create a JSON documentation of a struct, then use the serde_json crate to deserialize this into a struct for testing to avoid having to maintain example annotation and implementation. This prevents the use of comments in JSON since serde_json doesn't support comments.
Create two separate structs, one to deserialize the input into, then convert into the second struct and use that with #[serde(skip_serializing)]. Double the structs for every input doesn't seem practical.

Building on option 1, would it be possible to create an initialized struct from the example annotations? Something like build_example_struct::<Config>() -> Config.
This would allow me to test the service with the documented example values without having to maintain a separate implementation for tests.

Ok, I think I understand your use case now - I have my own two suggestions:

How about if for each input instead of providing just one documentation, you provided two: one describing how the input is deserialized, and another for how the inputs gets deserialized?
Since you're already using skip_serializing, you wouldn't have to actually duplicate the structs you already have - the only thing that'd change is that for each input struct you'd call Doku twice: once with doku::Visibility::SerializableOnly, once with doku::Visibility::DeserializableOnly, and then in the documentation you'd say this is Foo's input: ..., this is Foo's output: ....
This should nicely integrate with your JSON test-files, since for this is Foo's input you could load some example input file, and vice versa for the output docs.

I could implement some sort of a value-merging, so that you would do:
let config_input = load_json("tests/config.input.json");
let config_output = load_json("tests/config.output.json");

let doc = doku::json::Printer::default()
    .with_visibility(doku::Visibility::SerializableOnly)
    .with_values(&[config_input, config_output])
    .print(&Config::ty());

... which would try reading values first from config_input, filling out the missing ones from config_output.

As for using examples (so your first and third ideas), I think this might become troublesome in the long run, since Doku doesn't allow to provide different examples based on the context - say, given:
struct Foo {
    #[doku(example = "something")]
    value: String,
}

struct Bar {
    foo: Foo,
}

struct Zar {
    foo: Foo,
}

... it's impossible to provide a different example for Bar.foo.value & Zar.foo.value, which depending on how your API looks like, might affect your documentation's usability a bit.

Thanks a lot for your suggestions! Your second idea led me to play around with the Printer a bit more and I found a workaround to deal with #[serde(skip_serializing)] that works perfectly for my usecase. Since you make it easy to skip comments when printing, I can just use point 2 from my previous post. This results in this code:
use doku::Document;
use doku::json::*;
use serde::Serialize;
use serde::Deserialize;

#[derive(Serialize, Deserialize,  Document, Debug)]
struct Config {
    /// Database's host
    #[doku(example = "test")]
    db_host: String,

    #[doku(example = "skip_ser")]
    #[serde(skip_serializing)]
    skip_ser: String,
}

fn main() {
    let doc_comments = Printer::default().print(&Config::ty());
    let mut formatting = Formatting::default();
    formatting.doc_comments = DocComments::Hidden;
    let doc_example = Printer::default().with_formatting(&formatting).print(&Config::ty());
    let doc_example_deserialized = serde_json::from_str::<Config>(&doc_example).unwrap();
    println!("doku with comments: \n {}", doc_comments);
    println!("doku: \n {}", doc_example);
    println!("deserialized struct: \n {:#?}", doc_example_deserialized);
}

Luckily my API currently doesn't need examples based on the context in which a struct is used. I'll keep this in mind in my design going forward.
Thank you for your help!


License

There's no license specified for this project; I'd love to use this technique, but it would be a lot easier if this could be published under a permissive license.
Either way, I really appreciate the corresponding blog post 👍

Added license. License is MIT.


Mannual way of installing lib

Hi, I am encountering a problem with preview buttom. From developer tools, I get of "no such file or directory, open 'xxxx/.obsidian/plugins/marp-slides/lib3/bespoke.js". I checked "xxxx/.obsidian/plugins/marp-slides" and there is no lib3 content.
How can the lib be installed mannually? My plugin version is 0.45.5

Please close and reopen obsidian. If doesn't work, you can find the library here in the zip file

Hi, thanks for your reply. I did download library files and unzip them to 'xxxx/.obsidian/plugins/marp-slides/lib3/'. However, I cannot use markdown-it plugins. I get 'The specified engine has not resolved' error.
According to https://github.com/marp-team/marp-cli/issues/224, I tried to install with "npm install" in 'xxxx/.obsidian/plugins/marp-slides/lib3/', but the error remains.
I am not familiar with npm and node.js. Perhaps my installation is wrong？

This is the folder structure of my vault:

the lib folder of the zip will be renamed in lib3. No need of npm or node
I hope this is helpful :-)


Login template should display controller's errorMessage

Update login template example snippit to include loginFailureMessage

What do you think of my changes?

👍


apps: Print out a proper message when a store cannot be opened

Fixes #22306
This reverts some of the recent changes in load_key_certs_crls() as they were incorrect.

The second commit is only for the master branch as 3.0/3.1 do not have this code chunk.

@levitte please reconfirm

@levitte please reconfirm.

@levitte ping

ping @levitte for reconfirm or ping anybody for second review

This pull request is ready to merge

Merged to the master branch (both commits), 3.1 and 3.0 (only the first commit with the fixups). Thank you for the reviews.


RuntimeNavMeshBuilder: Source mesh default does not allow read access. This will work in playmode in the editor but not in player UnityEngine.AI.NavMeshSurface:BuildNavMesh()

Im building the world on runtime, and when im building the navmesh on the floor i get this errors. The agents still work and do their stuff, but i'm worry about this error

I'm having the same error, also when I try to update the navmesh

The meshes on all of the objects being used by the RuntimeNavMeshBuilder needs to have the "Read/Write enabled" checked.

@bliu886 helpful advice. I did it make ALL possible "read/write" enabled, so most of my errors resolved...
but the debugger claims there are some "Combined Meshes" which apparently were not present in "Favourites/All Models"

Does anyone knows where can I find them?
Thanks! : )


bump stow version to 0.3.6

Signed-off-by: Babis Kiosidis<EMAIL_ADDRESS>bumping stow version to avoid resource exhausted issues with gcp
Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/

hey @ckiosidis do you mind adding the tracking issue to the PR description?


A user has no access to all the features of his account after the successful registration confirmation

Environment: Win10 Pro; Chrome version 105.0.5195.127.
Reproducible: always
Build found: gcp-0.1.70
Preconditions

Sign up as any type of user
Open the incoming email from pozashkillia.

Steps to reproduce

Click the button „Перейдіть за посиланням“.
Click the button „Перейти".

Actual result
A user has no access to all the features of his account after the successful registration confirmation.

Expected result
After the successfull registration confirmation a user has access to all the features of his account.
User story and test case links
User story https://github.com/ita-social-projects/OoS-Backend/issues/833
Labels to be added
"Bug", Priority ("pri: "), Severity ("severity:"), Type ("UI, "Functional"), "API" (for back-end bugs).

Dublicate #858

@whiteand123  fixed!


[Raft] Implement TCP Client and server modules for RPC communication

Create an interface RPC:
type RPC interface {
    Write([]byte) error
    Read() (byte[], error)
}

Implement a struct tcpClient which implements the RPC interface.
Some boilerplate code:
type tcpClient struct {
    // state of the tcp client
}

func NewClient(<some config parameters>) RPC {
    // instantiate a new client
}

func (client *tcpClient) Read() ([]byte, error) {
    // read the data from the end point
}

func (client *tcpClient) Write(b []byte) error {
    // write the data to the end point
}

Refer to these links:
https://gist.github.com/adeekshith/34c20eb45bebe41f5247


Rename old service name

Release Management -> Azure Pipelines
When Visual Studio Team Services(VSTS) was renamed to Azure DevOps, the tool called Release Management is gone.
The element of Release Management is replaced by Azure Pipelines.

@changeworld : Thanks for your contribution! The author, @ecfan, has been notified to review your proposed change.

@changeworld Thank you for your edits, looks good so I'm signing off. #sign-off


Enable ZAP Scans in CI/CD GitHub Actions

Describe the task
ZAP is a vulnerability scanner / automated penetration tester. There are already commented out / non-functional GitHub Actions for ZAP Scans in our Repo.
Our goal should be to create a new GitHub Action yaml file for zap scans.  It should have a workflow_dispatch that enables us to manually trigger it, so we can manually trigger Zap scans against dev/test/prod as appropriate.
https://github.com/bcgov/nr-epd-digital-services/blob/main/.github/workflows/merge-main.yml#L138-L168
Acceptance Criteria

[ ] Can trigger ZAP Scan for frontend/ and backend/ via GitHub Actions
[ ] Create brand new GitHub Action yaml file with workflow dispatch, so it's easy to merge in later.

Notes:

https://github.com/bcgov/foi-help/blob/main/.github/workflows/web-deploy.yaml#L11-L21
Example of consuming a workflow_dispatch - https://github.com/bcgov/foi-help/actions/workflows/web-deploy.yaml

Idea: Could use workflow_dispatch to input the actual URL that Zap is scanning.


Explore search links

fix for data-portal-content ticket 149 (click through to from organ or graphs is broken by the change to the url structure)

manually merged


Use the right variable name in doc string

Hi @whoshuu , thanks for the commit! Could you please make the change to json.hpp.re2c, because json.hpp is created from this file?

Thanks a lot!


[iOS] Fabric: Fixes implicit animation when setting the background color of View

Summary:
Fixes #47011.
CALayer has implicit animation when setting the background color, so let's disable it explicitly. cc @joevilches
Changelog:
[IOS] [FIXED] - Fabric: Fixes implicit animation when setting the background color of View
Test Plan:
Demo in #47011.

Hey @zhongwuzw did you try this out for yourself? I imported this to test and did not see a difference. This is despite Apple's docs indicating that this should work. Anyway, since this is an issue I ended up finding a working solution in #47101. Since that was a different solution I just did it in a separate PR, gonna close this one. Thanks for the ping and bringing this up!!

@joevilches Yes, I tested and it should work. I saw your PR, but don't know wether it would leads some side effects because it's removes all animation.
https://github.com/user-attachments/assets/6bb54c40-9bfc-4354-b5d2-5d66299dad75


How does the text attributedText respond

How does the text attributedText respond?

@XavierLost
Hi there:
attributedText is not included in binder presets, you can write your own binder, use code in README as a reference


varLib.instancer --update-name-table not updating nameID 25 with Roman/italic

When separating italic and roman, nameID25 remains FontName instead of FontNameRoman /  FontNameItalic. Although opinion are differing if it should be done by default or not. Since it is required on GF end for new VF, it may be implemented as an option?

In report here the discussion in the chat:
Rosa: We have more and more fonts which gather the Roman and Italic in the same source file, and they need to be separated  in 2 variable fonts before getting onboarded (without duplicating sources would be the best). We have been using the fabulous varLib.instancer, but it doesn't get the name ID25 as the builder does. The question is: shall fonttools fix the name tables, or should we make a post-process script, or can it be integrated to the builder in some way?
Dave:  it should be done in fonttools… what are the differing opinions?
Rosa: https://github.com/googlefonts/gftools/issues/297

Hoping the solution will deal with a Slant axis as well as an Italic axis.

AH GF eng said they would handle the slant axis as any other axes (not like weight and italic)

Apologies for my late response. I had forgotten why we never updated this record but it occurred to me last night why. In the MS spec, it says:

If present in a variable font, it may be used as the family prefix in the PostScript Name Generation for Variation Fonts algorithm.

https://docs.microsoft.com/en-us/typography/opentype/spec/name#name-ids
Both myself and Cosimo believe that this name record is only used for the purpose mentioned above. Currently at Google Fonts, we believe that nameID 25 needs to be unique for each font which makes up a VF family e.g for a family which consists of a Roman and an Italic font, we would expect the following for nameID 25:
Roman VF: FamilyNameRoman
Italic VF: FamilyNameItalic
Unfortunately, the above records will generate horrible postscript names when using the Adobe PS Name Generation heuristic which we do use e.g:
Instantiated Roman postscript name: FamilyNameRoman-Roman
Instantiated Italic postscript nane: FamilyNameItalic-Italic
If we don't update name record 25 which is the current behaviour, we get:
Roman VF postscript name: FamilyName-Roman
Italic VF postscript name: FamilyName-Italic
I hope the above makes sense. More than happy to explain further.

The requirement for unique prefix is a workaround for an Adobe bug. I don’t think it is appropriate to hard-code such work arounds in FontTools. If GF need this work around, it should be in a GF-specific tool.

It seems to me odd that adobe didn't contribute this to the MSOT/MOFF
specs. I'll ask Adobe why.
Given I believe there are other things we do in fonttools that are
practical to ensure the results work widely, I'm not sure it's so
inappropriate.

Here's a reference from @punchcutter at
https://github.com/googlefonts/gftools/issues/297#issuecomment-780782761 regarding it's status as a bug, thanks Khaled :)

Some things never change...


Add options for filenames_to_ignore and file_extensions_to_ignore

This will help with problems like https://github.com/leonstafford/wp2static/issues/739

merged in

merged in


Fail MUO test if we expect an error but don't get one

Which issue this PR addresses:
Fixes a case where we expect an error to occur but err == nil
What this PR does / why we need it:
Fix test code logic
Test plan for issue:
Unit tests
Is there any documentation that needs to be updated for this PR?
nope

please address the failing CI builds

the linter changes is breaking it - nothing in our PR

Understood, there is a PR now to resolve the issues with linting (#2066). once this is merged please rebase!

Rebased - should pass now.  TY :)

Kicked the E2E so it should succeed.

/azp run e2e


iOS SDK with CocoaPods

Referencing #672 , this PR completes installation of iOS SDK with CocoaPods structure (and of course with latest Sdk version).
I've tested it on my application, using latest Cordova Cli (8.1.2) and xCode version 10.
Crashlytics error reporting also works fine, I had to fix bugged install/uninstall hooks.
The official documentation states that the Crashlytics run script phase should include an additional input file, so I managed it in the hook script, since I couldn't figure out how to distinguish a .pbxproj file from a xCode 10 version to a lower one, shouldn't matter very much since everyone is forced to update xCode for new builds for Apple Store uploads starting from 2019.
Any help for possible bugs or problems with lower Cordova or xCode versions is welcome

Please accept this pull request

@rutbastoni thanks for adding the min iOS version.
The only other issue I encountered is not caused by this PR, but is due to a bug in cordova-ios (apache/cordova-ios#394) causing Cordova CLI builds to fail (Xcode builds work fine), so my CI builds to failed.
The PR to fix it (apache/cordova-ios#398) has been merged to the master branch of cordova-ios but has not yet been released (i.e. it is not in the latest 4.5.5 release).
The solution I used was, as inspired by this comment, to download the patched version of build.js for<EMAIL_ADDRESS>and use a hook script to deploy it:
config.xml:
<platform name="ios">
    <hook type="after_platform_add" src="hooks/ios/deploy_build.js"/>

hooks/ios/deploy_build.js:
#!/usr/bin/env node

module.exports = function (context) {
    var path = context.requireCordovaModule('path');
    var fs = context.requireCordovaModule('fs');
    var sourcePath = path.join(context.opts.projectRoot, 'resources/ios/build.js');
    var targetPath = path.join(context.opts.projectRoot, 'platforms/ios/cordova/lib/build.js');

    var buildExtras = fs.readFileSync(sourcePath, { encoding: 'utf8' });
    fs.writeFileSync(targetPath, buildExtras, { encoding: 'utf8' });
};

Excellent @dpa99c and @rutbastoni ! It worked flawlessly. Thank you!

Looks like https://github.com/apache/cordova-ios/pull/398 has been released in cordova-ios v5.0.0, so maybe this PR can progress further now?

Any updates on this? I would love to get this working so I can use the dynamic links plugin as well

Any updates on this?


I wish /docs/admin/dns/ did not describe DNS as an Add-On when it is basically required.

I wish /docs/admin/dns/ did not describe DNS as an Add-On when it is basically required.
@kubernetes/sig-network

https://github.com/kubernetes/kubernetes/issues/9107#issuecomment-214527039

Can this be closed now?


on("error", fn) event does not catch 4xx, 5xx errors

Given
request
  .get(url)
  .on("error", handleErrors)
  .end()

The handleErrors method is missing 4xx, 5xx errors, they only exist on end() method, then how to write a plugin for this case? (plugin can not hook into end() method)
Is there a particular reason not passing 4xx, 5xx errors to on("error", fn) event?

This should be fixed in 3.1+


fix dashboard and flow stats polling

Removes the end date requirements for the dashboard and Flow Stats related mappers. That way when polling happens, they'll always fetch data up to the latest moment.

Correct me if I'm wrong. But doesn't this change make it so as you leave the dashboard open the time span you're looking at grows? So 8 hours turns into 9 after leaving it open for an hour.

That's correct. I called that out in the #raft-workspace-dashboard channel. It shou

I'm going to close this PR in favor of implementing this change https://github.com/PrefectHQ/prefect-ui-library/pull/1602
That PR doesn't fix this but allows us to fix it without having the growing time span. I'll work on that today or tomorrow.


Doesn't seem to allow variation in playback from memory or flash

Its untested, but I've made a branch with a version with theoretically works with arrays,
https://github.com/newdigate/teensy-variable-playback/tree/experimental
You might need to modify it to work with flash memory, I haven't tried that yet, either...
adds AudioPlayArrayResmp (using ResamplingArrayReader), defined in src/playarrayresmp.h


Use fallback value when source == .static

The @RemoteConfigProperty property wrapper should use the fallback value when the user selects “Use in-app default” in the Firebase console.

I don't think fallback value is equivalent to "in app default" value.

If the fallbackValue is not intended to act as the in-app default value, there should be a(nother) mechanism for specifying the default value.
The way it currently works is:

In the console, you select Use in-app default value
Nothing happens

And this - at least to me - doesn't sound right either. Unless I am missing something.

The fallback value is a pure swift language default value that is not the "in app default" value that's the default config value.

Not sure I follow. To specify a language-level default value, wouldn't you rather want to assign a value to the underlying variable at initialisation time? I.e., @RemoteConfigProperty(key="foo") var foo = "Some default value"?

The way it currently works is:
In the console, you select Use in-app default value Nothing happens

Can you elaborate the "nothing happens" part? I think the expected case here should be "use default config value if it's being set by developers". So if developer didn't set a config value, nothing should happen.

Sure. Take a look at the following code, which uses the RC property wrapper to connect the cardColor to an RC variable.
@RemoteConfigProperty(key: "cardColor", fallback: "#ff2d55") var cardColor

var body: some View {
    VStack {
      Text("What's your favourite number?")
        .font(.title)
        .multilineTextAlignment(.center)
      Spacer()
      Stepper(value: $viewModel.favouriteNumber, in: minValue...maxValue) {
        Text("\(viewModel.favouriteNumber)")
      }
    }
    .foregroundColor(.white)
    .background(Color(hex: cardColor))
}

When defining the RC variable and setting it to #0000FF in the console, the UI will turn blue - as expected. When toggling the switch in the console to Use in-app default, the UI will stay red (i.e. nothing happens), instead of turning to "Sizzling red" (#ff2d55), as specified in the first line of the snippet. See https://github.com/FirebaseExtended/firebase-video-samples/blob/peterfriese/apple/remote-config/fundamentals/apple/remote-config/final/Favourites/Shared/FavouriteNumberView.swift#L69 for the complete code sample.
Expected behaviour: toggling to Use in-app default value uses the value defined by the PW.

Expected behaviour: toggling to Use in-app default value uses the value defined by the PW.
No that's not how we designed the API, the "in-app default" value should be defined by developers, not the fall back in PW as described in the API definition. https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseRemoteConfigSwift/Sources/PropertyWrapper/RemoteConfigProperty.swift#L36
@karenyz

No that's not how we designed the API, the "in-app default" value should be defined by developers, not the fall back in PW as described in the API definition. https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseRemoteConfigSwift/Sources/PropertyWrapper/RemoteConfigProperty.swift#L36

This is also how I understood it. In RC the 3 value sources work as follows:

remote: a value was defined remotely (server-side) for this parameter
default: a value was set client-side for this parameter using the setDefaults method in the SDK. Toggling "use in-app default" in the Console indicates that a parameter should use this client-side value, the server "opts out" of providing a value.
static: this essentially means "parameter not found", i think the initial intention was so RC wouldn't return null values, but in reality this often causes confusion. This could occur if "use in-app default" is toggled but no default was ever set in the client, or simply this parameter key doesn't exist.

Going back to this PR, the PW should use both remote and default values as-is, and only use the fallback if there happens to be a decoding issue with the value, or there was no (user-defined) RC value found (static).
Hope this clarifies things, if not, happy to discuss more!

Please close, merge, or comment. We plan to close stale PRs on November 28, 2023.


Whatsapp Audio Files not being delivered in production

Audio files are not being delivered through v1 whatsapp outbound API. Vonage returns 200 (OK) HTTP status but the audio file is never delivered to the user:
SDK code
client = Vonage::Client.new(
  application_id: '<APPLICATION-ID>',
  private_key: File.read('<'PATH-TO-PEM'>')
  )
message = Vonage::Messaging::Message.whatsapp(
  type: 'audio',
  message: {
    url: '<CDN-ENDPOINT>bc832675-e22a-45a2-9f08-8d8fb0a28e66.wav'
  }
)
client.messaging.send(
  from: '<FROM>',
  to: '<TO>',
  **message
)

HTTP Request
---
http_interactions:
- request:
    method: post
    uri: https://api.nexmo.com/v1/messages
    body:
      encoding: UTF-8
      string: '{"from":"<FROM>","to":"<TO>","channel":"whatsapp","message_type":"audio","audio":{"url":"<CDN-ENDPOINT>bc832675-e22a-45a2-9f08-8d8fb0a28e66.wav"}}'
    headers:
      Accept-Encoding:
      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
      Accept:
      - application/json
      User-Agent:
      - vonage-ruby/7.10.0 ruby/3.0.0
      Authorization:
      - Bearer <TOKEN>
      Content-Type:
      - application/json
  response:
    status:
      code: 202
      message: Accepted
    headers:
      Date:
      - Fri, 02 Jun 2023 22:42:20 GMT
      Content-Type:
      - application/json
      Content-Length:
      - '55'
      Connection:
      - keep-alive
      X-Envoy-Upstream-Service-Time:
      - '29'
      X-Frame-Options:
      - deny
      X-Xss-Protection:
      - 1; mode=block
      Strict-Transport-Security:
      - max-age=31536000; includeSubdomains
      X-Content-Type-Options:
      - nosniff
      X-Ratelimit-Remaining:
      - '39'
      X-Ratelimit-Reset:
      - '1'
      Server:
      - envoy
    body:
      encoding: UTF-8
      string: '{"message_uuid":"f560ad4f-4068-4031-b204-a9ab5f102ea6"}'
  recorded_at: Fri, 02 Jun 2023 22:42:20 GMT
recorded_with: VCR 6.1.0

Plese review message_uuid: 'f560ad4f-4068-4031-b204-a9ab5f102ea6' since the audio was never delivered to the end user

This has been fixed, Vonage support confirmed that wav files will not work with WA. Updated integration with mp3 file


tests: add unit tests for state.go

increase code coverage of state.go
fixes #395
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

Coverage increased (+1.1%) to 70.906% when pulling 3e776d18636ca9636563c56532182ad6f455427c on devimc:unitTest/state into 43c289f330b78be7d24553534718c0c4efe77fe8 on clearcontainers:master.

lgtm

lgtm


Can't follow files even using -x

Issue Type: Bug
I have:
    "shellcheck.customArgs": [
        "-x"
    ],

in my settings.json, however shellcheck still cannot follow sourced files.
I get an error message:
Not following: ci/parse_ci_envs.sh: openBinaryFile: does not exist (No such file or directory)shellcheck(SC1091)

The file most certainly exists and shellcheck -x from the command line in the same directory as the project follows it just fine.
Extension version: 0.9.0
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:22.494Z)
OS version: Linux x64 5.6.8-200.fc31.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2182)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
31.28GB (4.38GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome-xorg

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome-xorg

XDG_SESSION_TYPE
x11

Mine is working fine:

@brianjmurrell By default, the cwd of shellcheck is set to the file being linted, can you have a try enabling useWorkspaceRootAsCwd?  More info #25

Just knowing that the path is relative to the file being linted, and not the root of the workspace is enough.  I can just fix my relative paths.


Added ExportViewMixin

Created a mixin view to export without admin interface.
I think it would be a really great thing if we have a generic class based views for this application.
I tested this patch with with a ListView & django_filters.views.FilterView.
The 2nd is really useful to replace the AdminFilters

Coverage increased (+0.2%) to 90.791% when pulling a174368f8430ecafc7db1344bca4389748cc534e on ZuluPro:exp_view into 859641a61f6ad9d18bf449e3a85454b7bb1af08e on django-import-export:master.

@brad Any news ?

I like the idea, it opens the door to automatic import/export of data.
+1 on generic classes
Would the admin views be built on top of this non-admin classes?

@meska

Would the admin views be built on top of this non-admin classes?

I don't know, I think we should.

@bmihelac Any news ?

@bmihelac @thauk-copperleaf @manelclos
Any news ?

+1 for clean and light export outside of admin. Thanks @ZuluPro

@manelclos @bmihelac @thauk-copperleaf
Any news ?

@ZuluPro thanks for your work.  I reviewed the code and just have few comments/questions.
Can you add yourself to authors and squash and rebase pull request?

NP! I'll do it very soon.

Looks good to me, thanks!


React Native will support 64 bit for android starting version 0.59, How about weex?

React Native will support 64 bit for android starting version 0.59, How about weex?

I think Weex already supported 64bits years ago.
BTW, according to the community guideline, which is voted in the mailing list but not released yet, Github Issues is only for bug report and questions that doesn't get answer on stackOverflow.

hi, I cannot find "arm64-v8a" and "x86_64" in the lib folder.

@YorkShen 这个问题为什么关了，并没有看到 "arm64-v8a"这个目录，只有v7a和arm等。你说的已经支持是什么意思呢？可以把v7a的so直接放到v8a目录？

There is no arm64-v8a folders now, but as 64 bit CPU would always fallback to 32 bit if arm64-v8a doesn't exist, so there is no problem to run weex on a 64 bit CPU.
We are planning to add arm64-v8a folders for better performance, but no detail schedule yet.
According to community guideline, Github issues is only for bug report, you should discuss new features in mailing list.

@YorkShen Starting August 1, 2019, your apps published on Google Play will need to support 64-bit architectures. 64-bit CPUs deliver faster, richer experiences for your users. Adding a 64-bit version of your app provides performance improvements, makes way for future innovation, and sets you up for devices with 64-bit-only hardware. https://developer.android.com/distribute/best-practices/develop/64-bit

@YorkShen googleplay 2019/8/1强制所有app对应的32位so必须相应提供64位。否则所有海外外发的app都无法在googleplay更新了。google通知这个消息很久了

@hanzhida ，解决了吗？一样遇到了，脑壳痛


TypeError: Cannot read property 'length' of undefined

Thanks for this tool -- it seems very useful!
However, when I tried to run it on this commit, a TypeError was thrown.
I used:
$ npm install -g core-validate-commit
$ core-validate-commit ead820d1429308595e84c5af2440839317f9a1c0

The following error was thrown:
/usr/local/lib/node_modules/core-validate-commit/lib/rules/title-length.js:19
    if (context.title.length > len) {
                     ^

TypeError: Cannot read property 'length' of undefined
    at Rule.validate [as _validate] (/usr/local/lib/node_modules/core-validate-commit/lib/rules/title-length.js:19:22)
    at Rule.validate (/usr/local/lib/node_modules/core-validate-commit/lib/rule.js:28:10)
    at ValidateCommit.lint (/usr/local/lib/node_modules/core-validate-commit/lib/index.js:51:14)
    at load (/usr/local/lib/node_modules/core-validate-commit/bin/cmd.js:131:9)
    at exec (/usr/local/lib/node_modules/core-validate-commit/bin/cmd.js:51:5)
    at ChildProcess.exithandler (child_process.js:197:7)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:877:16)
    at Socket.<anonymous> (internal/child_process.js:334:11)

Interesting....I can't reproduce...
[~/dev/code/forks/node]
:] (v6.5.0) ➜ $ core-validate-commit ead820d1429308595e84c5af2440839317f9a1c0                                  (master)
  ✔  ead820d1429308595e84c5af2440839317f9a1c0
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is <= 50 columns.                   title-length

What version of node are you running? and what does core-validate-commit -v show?

I'm running Node v6.5.0. core-validate-commit -v outputs v2.1.0.
Maybe this is happening because my git config for git log is different from the git default.
$ git config --list | grep 'log'
log.decorate=true
log.abbrevcommit=true
log.oneline=false

Ah that could be. Interesting...I have not messed with those config options before. I'll try to dig into this tomorrow though and find a fix. Thanks for reporting!

For reference, here are all the possibly-relevant config options I'm using. I'll try to narrow it down to see if disabling any of them fixes the issue.
log.decorate=true
log.abbrevcommit=true
log.oneline=false
color.status=true
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
core.ignorecase=true
core.precomposeunicode=true
format.pretty=oneline


Mling integration tcp floodtests

Requires that https://github.com/uProxy/uproxy-lib/pull/137 is merged, to get the getStats() api from the queue handler.  This is on top of iislucas-requireify.
Run against the tcp flood server on its default port (1224) in the single-flood case, and run the server twice on the default (1224) and default+1 (1225) to let these test run against it.

Comments from the review on Reviewable.io

Excellent! Trevor is going to like these a lot I think :)
A few questions/name suggestions.

src/integration-tests/tcp/freedom-module.ts, line 49 [r1] (raw file):
Add a comment with the command line arguments you might want to use to run this; e.g. using your server, nc or such.

src/integration-tests/tcp/freedom-module.ts, line 67 [r1] (raw file):
Before doing this, I think you should set the consoleFilter to not send stuff to the browser console log (only store it in the buffer), to do that you can use:
loggingController.setConsoleFilter(['*:W']);
loggingController.setBufferedLogFilter(['*:D']);

Then to get logs back at the end of this test...
var logs = loggingController.getLogs();

Looking at the logging controller, it's pretty clear that the API needs to fixes: ability to get the current console filters; ability to clear all console filters; ability to disable console or buffered logs independently. Lets not fight around that stuff - when we need it, lets add it.

src/integration-tests/tcp/freedom-module.ts, line 70 [r1] (raw file):
Call this logStatsLoop instead of fun ?

src/integration-tests/tcp/freedom-module.ts, line 98 [r1] (raw file):
I think we should also record the time-point before the tcp connection starts; tcp can take a while to start, and because of IPC things, you can actually start getting data before onceConnected completes :/  (this can be kind of fixed, and Ben and I have a plan for it...)

src/integration-tests/tcp/freedom-module.ts, line 121 [r1] (raw file):
name fun better... no, not literally... ;-)

src/integration-tests/tcp/freedom-module.ts, line 125 [r1] (raw file):
Maybe better to name these in the same way as above?

src/integration-tests/tcp/freedom-module.ts, line 140 [r1] (raw file):
How are these logs distinguished from the ones in the 1 second timeout loop? Don't they want to be?

OK, this has been out a while. Sorry about that. You're probably best rebasing and basing this off the current dev branch. Thanks for adding these!
Two questions:

these tests don't have pass/fail conditions so I wonder
I think you were invoking these via the console? That's a neat trick but I think they're better placed in some other files, a little like the integrationSlow target: https://github.com/uProxy/uproxy-networking/blob/dev/Gruntfile.coffee#L151

(sorry I know this is a pain but hopefully it's not too annoying to copy pasta another target similar to integrationSlow)

(Assigned to @trevj ; what do we want to do with this?)

Guess we can close this!


[Bug]: Being asked to commit even though there are no commits showing up in the modal

Is there an existing issue for this?

[X] I have searched the existing issues

Description
In the Entry Criteria app, in the featureRating branch, even after discard and pull, we are being asked to commit changes, though there are no changes to be committed.
Steps To Reproduce

Go to the featureRating branch in the Entry criteria app
Note that the commit modal asks us to commit even though there are no changes to be committed
The difference seen on a branch created from here is as below:

Public Sample App
No response
Environment
Production
Severity
Medium (Frustrating UX)
Issue video log
No response
Version
Cloud

Seeing this same behavior in another application - The recording - https://jam.dev/c/ed38f18d-5097-4c6f-9b29-2875a820a49a
The repo link - git@github.com:btsgh/sep20dpro.git
The commit diff link - https://github.com/btsgh/sep20dpro/commit/ca394976678091f8cb7d843328292b983c350f9e

These are most likely changes to Application JSOn files which don't show up in Git changes


Elastalert hit a security event but no email alert was sent

Problem overview
Previously, my Elastalert was deployed under centos under a local VMware virtual machine, which can normally match security events and send alarms. Then I got Alibaba Cloud with the same configuration and made the exact same configuration, so I can be sure that the rule itself is not a problem, but ELastalert on Alibaba Cloud can hit a security event, but I cannot receive the alert email There are the following warnings: "WARNING:apscheduler.scheduler:Execution of job "ElastAlerter.handle_rule_execution (trigger: interval[0:01:00], next run at: 2020-06-03 10:39:07 CST)" skipped: maximum number of running instances reached (1)"
Detailed log
And this my rule and elart email config:
filter:

query:
query_string:
query: "message: union"

The alert is use when a match is found
alert:

"email"

#邮件正文显示你定义的alert_text
alert_text: "Ref log http://<IP_ADDRESS>"
smtp_host: smtp.163.com
smtp_port: 25
smtp_auth_file: /opt/elastalert/smtp_auth.yaml
#回复给哪个邮箱
email_reply_to<EMAIL_ADDRESS>from_addr<EMAIL_ADDRESS>a list of email addresses to send alerts to
email:

<EMAIL_ADDRESS>
The content output after executing Elastalert
INFO:elastalert:Queried rule sql注入 from 2020-06-03 10:11 CST to 2020-06-03 10:26 CST: 0 / 0 hits
INFO:elastalert:Queried rule sql注入 from 2020-06-03 10:26 CST to 2020-06-03 10:37 CST: 7 / 7 hits
INFO:elastalert:Background configuration change check run at 2020-06-03 10:37 CST
INFO:elastalert:Disabled rules are: []
INFO:elastalert:Sleeping for 59.99985 seconds
WARNING:apscheduler.scheduler:Execution of job "ElastAlerter.handle_rule_execution (trigger: interval[0:01:00], next run at: 2020-06-03 10:38:05 CST)" skipped: maximum number of running instances reached (1)
WARNING:apscheduler.scheduler:Execution of job "ElastAlerter.handle_pending_alerts (trigger: interval[0:01:00], next run at: 2020-06-03 10:38:58 CST)" skipped: maximum number of running instances reached (1)
INFO:elastalert:Background configuration change check run at 2020-06-03 10:38 CST
INFO:elastalert:Disabled rules are: []
INFO:elastalert:Sleeping for 59.999884 seconds
WARNING:apscheduler.scheduler:Execution of job "ElastAlerter.handle_rule_execution (trigger: interval[0:01:00], next run at: 2020-06-03 10:39:07 CST)" skipped: maximum number of running instances reached (1)
Then even more strange is that I query the result returned by elastalert_status and the number of ‘hits’ is 0, but my output above shows that the number of ‘hits’ is 7
[root@xmp elastalert]# curl <IP_ADDRESS>:9200/elastalert_status/elasalert_error/_search?pretty=true
{
"took" : 0,
"timed_out" : false,
"_shards" : {
"total" : 5,
"successful" : 5,
"skipped" : 0,
"failed" : 0
},
"hits" : {
"total" : 0,
"max_score" : null,
"hits" : [ ]
}
}
The above is the description of my problem, the help I hope to get is, if you need more detailed information, please let me know
(1) Point out the reason why the email alert cannot be sent or provide me with a troubleshooting idea

To add, I checked elastalert_status_error and found the following alarm message
message:Error while running alert email: Error connecting to SMTP host: [Errno 110] Connection timed out traceback:Traceback (most recent call last):, File "/usr/local/elastalert/elastalert/alerts.py", line 475, in alert, self.smtp = SMTP(self.smtp_host, self.smtp_port), File "/usr/local/lib/python3.7/smtplib.py", line 251, in init, (code, msg) = self.connect(host, port), File "/usr/local/lib/python3.7/smtplib.py", line 336, in connect, self.sock = self._get_socket(host, port, self.timeout), File "/usr/local/lib/python3.7/smtplib.py", line 307, in _get_socket, self.source_address), File "/usr/local/lib/python3.7/socket.py", line 727, in create_connection, raise err, File "/usr/local/lib/python3.7/socket.py", line 716, in create_connection, sock.connect(sa), TimeoutError: [Errno 110] Connection timed out, , During handling of the above exception, another exception occurred:, , Traceback (most recent call last):, File "/usr/local/elastalert/elastalert/elastalert.py", line 1544, in send_alert, alert.alert(matches), File "/usr/local/elastalert/elastalert/alerts.py", line 484, in alert, raise EAException("Error connecting to SMTP host: %s" % (e)), elastalert.util.EAException: Error connecting to SMTP host: [Errno 110] Connection timed out data.rule:sql注入 @timestamp:June 3rd 2020, 00:03:56.160 _id:26fGdXIBKzF_WLdyZoCB _type:_doc _index:elastalert_status_error _score: -


feat: Add code compatibility with landing on stars.

I'm posting this to get feedback.

@vos6434 It's not finished, but I'd like you or someone else to look over it. I would appreciate some feedback.

visibly the same type

What does this mean? They aren't the same type - one you can land on the other you cannot. Since PlanetType implements Landable it gets treated differently by Galacticraft's code.

it's also a bit hardcode-y

???
The purpose of this system is to provide a clear divide between celestial bodies with different properties. You are not restricted to GCAPI's builtin types.

It just doesn't feel right to me

I find it worse to just have a monolithic CelestialBody or (a somewhat less monolithic PlanetType) class that covers optional landing, optional orbiting, etc through nullable methods. End-users/datapack creators could partially implement aspects of celestial bodies and break things.


Disable NPlusOneError exceptions when using Profiler?

Hi. Is there any way to disable the exceptions when using profile.Profiler(), and just get the logs?

Not raising exceptions would not be hard:
class ForgivingProfiler(Profiler):
    """
    Fork of nplusone.core.profiler.Profiler that does not
    raise Exceptions
    """
    def notify(self, message):
        pass  # or collect messages here

If NPLUSONE_RAISE``should be respected out of the box, maybe Profiler` would need to accept a config paramater. Would it make much difference, to have that built in?


UNIX FD leaks

When negotiate_unix_fds is enabled on the MessageBus, the library starts leaking file descriptors.
This happens for example when an unhandled message is received, or if the message is handled by any of the builtin handlers which are not aware of file descriptor passing. The only way to avoid the leaks seems to be installing a custom message handler, which handles messages that need file descriptors, and close all file descriptors in message.unix_fds otherwise, so that they never get to the default handlers.

I think I'm running in to this too.
Could you share your custom handler for closing these?


Numeric stopper unable to step in 0.1 (or other units other than whole numbers)

This code:
<?xml version="1.0" encoding="utf-8"?>
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
                xmlns:js="library://ns.apache.org/flexjs/basic">

    <fx:Script><![CDATA[
        public function clicked():void {
            ns.minimum = 5;
            ns.value = 1;
        }
        ]]></fx:Script>

    <js:valuesImpl>
        <js:SimpleCSSValuesImpl/>
    </js:valuesImpl>

    <js:initialView>
        <js:View>
            <js:Group id="content">
                <js:beads>
                    <js:VerticalLayout />
                </js:beads>
                <js:NumericStepper id="ns" minimum="0" maximum="1" stepSize="0.1" />
                <js:TextButton text="Change minimum and value" click="clicked()" />
            </js:Group>
        </js:View>
    </js:initialView>

</js:Application>

Is forever stuck on 0 and the step arrow does nothing.
The issue is caused by this line in the model's snap function as Math.round is used:
var n:Number = Math.round((value - minimum) / si) * si + minimum;

Well it seems you can get it to mostly work if you also set the snapInterval to be 0.1 but then not all values are whole multiple of 0.1 you get values displayed like 0.30000000000000004 and 0.7000000000000001.

Your code has a bug. You are setting the minimum to higher than the maximum.

Here's a better example that show the issue - please reopen.
<?xml version="1.0" encoding="utf-8"?>
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
                xmlns:js="library://ns.apache.org/royale/basic">

    <js:valuesImpl>
        <js:SimpleCSSValuesImpl/>
    </js:valuesImpl>

    <js:initialView>
        <js:View>
            <js:NumericStepper width="300" minimum="0" maximum="1" stepSize="0.1" snapInterval="0.1" />
        </js:View>
    </js:initialView>

</js:Application>

Or if you prefer I can create another issue?

The problem is due to floating point arithmetic. 0.2 + 0.1 = 0.30000000000000004 in JavaScript.
Multiplication has the same issue: 3 * 0.1 = 0.30000000000000004
This results in both the stepping and the snapping to work not as expected.
I'm not sure what the right solution is to this problem. This is a problem both in the SpinnerMouseController.incrementClickHandler() and in the RangeModel.snap() functions. There are likely other classes which suffer from similar issues.
This seems like a potential problem for a which range of components, but introducing overhead for whole numbers does not seem right.

Please reopen. The fix while in the right direction it's not covering all cases for example:
<js:NumericStepper width="300" minimum="1" maximum="2" stepSize="0.1" snapInterval="0.1" />

Another better example:
<js:NumericStepper width="300" minimum="0" maximum="15" stepSize="1.5" snapInterval="1.5" />

Both of those cases work fine. (If you want the initial value to be 1 in the first case, you can either use the Express component, or specify a value of 1 explicitly.
An example which does not work with my fix is:
<js:NumericStepper width="300" minimum="0" maximum="15" stepSize="1.1" snapInterval="1.1" />


Too many updates due to float change

Many of the fields that telemetry streams are floating points and even when we set the interval to seconds or minutes, they do update. Theis did not matter much before but now that we are going to pay for these updates, can you please fix it so they don’t update each time a value at the 10th decimal digit changes?  Here is an example:

I also have this issue, and as you can see with Inside Temp, the actual usable value only has 1 decimal place, the rest is floating point error. I don't think we shouldnt be charged for changes in floating point errors.

They will be charged / sent, even if they didn't change. At least for PackCurrent

We already had this in another thread...

The whole system is totally unreliable and simply not production ready :(


Training code for 4.22

Hi, Great work!
Do you have any plan to upload the training for 4.22?

Also, I wonder what the difference is between 4.22 and 4.18.

I am experimenting with an idea similar to https://github.com/zzh-tech/InterpAny-Clearer, and it is not debugged yet. I hope that I will provide the code in about one or two weeks.


[Feature Request]: Audit log, page views, exports

Describe the feature you'd like
Could we get more detail added to the audit log, have the option to show page views, attempts to access pages they don't have access to, exports of pages?
Stuff like page views i don't think should show by default as this would add a lot of noise to the audit log, but would be good to have as an option to show and search
Describe the benefits this feature would bring to BookStack users
Allow admins to have more granular monitoring of actions within bookstack. In sensitive environments it would be nice to track who has viewed a page and exported a page when dealing with potential IP theft cases.
Additional context
No response

Would enabling page view tracking work if it was a separate option to enable it? (with a warning about performance on large instances?)

I try to keep away from adding optional features where possible. My other concern is just the about of events this would expand the system to (There are many different view operations this would touch) and the areas we'd need to add tracked events to.
We already track content views in a condensed format which provides much of what you might need (Last view per user per item).
The audit log is already what I'd consider a lesser-used area, I don't want to expand the maintenance scope too far for it.

Since there's been no continued discussion I'll close this off as out of scope.


Top nav design corrections, lightbox to prompt for login, tweet box lightbox

Fixes:
https://github.com/loklak/loklak_webclient/issues/165

Main issue : https://github.com/loklak/loklak_webclient/issues/143
Broken down issues:
https://github.com/loklak/loklak_webclient/issues/166
https://github.com/loklak/loklak_webclient/issues/118

https://github.com/loklak/loklak_webclient/issues/119

Fixes blocking CSS on https://github.com/loklak/loklak_webclient/issues/178 tested and checked via regression testing and removed the code blocks causing the issue. @aneeshd16 Wall needs custom modals.
Thank you everyone for the help and the documentation to read you've provided to solve all these issues.

Deployed: http://loklak.cloudapp.net:3001/

The div is cut off.  Use limitTo if you want to limit the result:
ng-repeat="status in root.twitterStatuses.data | limitTo:7"

Also remove height value and overflow hidden


fix: add text color classes back in

Putting .text-100 through 900 back in to keep the Bootstrap standard.
FLO-11370

:tada: This PR is included in version 0.7.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Appearing as the Bot account when typing in botnak

Occasionally you as the "User" will sometimes appear as to be using the bot account.
http://puu.sh/iMGDK/30b093a155.png
This is local only. As of right now I cannot reproduce it. It has happened to me but I have no proof on my end.
Log file where gman will appear to be using bot account locally with a broadcaster tag:
http://puu.sh/iMGQ3/fa47e961be.txt

Jordod noticed this upon logging out and in the Bot account in the Settings GUI.
Further testing needs to be done to determine exactly what causes this, but the re-write of the Settings GUI is eventually going to happen so this may no longer be an issue after that.

Update on this issue please, does this still happen? If so, how frequently?

It doesn't appear to be happening but if it has I haven't seen it. Afaik it's no longer a problem.

Kk, re-open if it becomes an issue again.


Root Resolvers

Apologies – I'm new to both GraphQL and Kotlin and this is more of a question than an issue, I think. But hopefully you can help me.
I issue a simple query something like this:
{
  bookById(id: 1) {
    name
    author {
      name
    }
  }
}

and get back the expected data. In my code that resolves this query I'm able to hook up author to a resolver (DataFetcher) by having a var late init author field on Book and by providing a DataFetcher that loads a Book (passed into SchemaGeneratorConfig's constructor when generating the schema).
Is there any way to hook up the bookByID part of the query to also automatically look up what DataFetcher to use rather than having to provide a fun bookById(id: Int): Book?? I'd rather have all the resolution of a query work the same way. Is wanting that "wrong" for any reason?
https://www.graphql-java-kickstart.com/tools/schema-definition/ indicates that in java-graphql you can create a GraphQLQueryResolver which will be "searched for methods that map to fields in their respective root types". Is there some field or annotation that I can put on my root query class that would cause the same kind of searching for a GraphQLQueryResolver or something similar?

@bakert The way we use reflection in graphql-kotlin requires that we look at the functions and parse the arguments and their types. However if you take a look at the /example directory, it has an file that uses Spring beans.
https://github.com/ExpediaDotCom/graphql-kotlin/blob/master/example/src/main/kotlin/com.expedia.graphql.sample/query/NestedQueries.kt
This will delay running the resolver code unless the bean function is called/queried in GraphQL.
Does this answer your question?

Yes, thanks! The example is helpful.


Increment version for ai releases

Increment package version after release of azure-ai-projects

API change check
API changes are not detected in this pull request.


use phpbench and change namespace

Hey,
I switched the custom benchmarking to use PHPBench, and changed the namespace of the project at the same time.
Thoughts?

Wow! This to me looks great!
Always wanted to see this benchmark running with phpbench!

Looks awesome! 👍

@bendavies please let me know when you are done with this, for me is ready to be merged! great work!

yep, i'm done

great work!


The provided project name "undefined" was not found.

Are you accessing the CLI from the default port :4280 ?

[ ] No, I am using a different port number (--port) and accessing the CLI from that port
[x] Yes, I am accessing the CLI from port :4280

Make sure you are accessing the URL printed in the console when running swa start!

Describe the bug
When I try to deploy my wwwroot, I get the above error after refusing to create a new app.
√ Would you like to create a new Azure Static Web Apps project? ... no
✖ The provided project name "undefined" was not found.

To Reproduce

Go to any folder with index.html
Run swa without parameters
Walk through until it asks you to create a project
Refuse a new project

Expected behavior
A meaningful error message (tell what parameter to set next time) or a request to enter the name of the existing project.
Desktop (please complete the following information):

OS: Windows 11
Version 22H2

I hit this today also, as a workaround you can use swa deploy --app-name <your app name>.
Docs here: https://azure.github.io/static-web-apps-cli/docs/cli/swa-deploy/


Created Fibonacci.py

PR accepted @akash-rao-2001
Successfully merged to HacktoberFest_22 repo.
🚀🚀👍


Replace glide element to entry-story

It will be better to replace .glide element to .entry-story for consistency

Duplicate of #121


Dashboard pattern content review

Review copies to be published in #1947

16 Oct - Nav to update based on mike's comment

23 Oct - Review done, ready for dev.


Possibility to dynamically chose destination

I can't make the following stuff to work, and I don't even know if it's possible :
// Somewhere
<GatewayDest name="global" component={View} />

// Somewhere else
<GatewayDest name={targetId} component={View} />
<Gateway into={condition ? 'global': targetId}>
  <Text>Hi</Text>
</Gateway>

It seems that it's not possible to determine dynamically a portal destination.
See snack on here
Is this planned or possible in another way ?

@marksteyn 's code won't work, because react still has no way to figure out it is a new component now.
What you can do, is add a key="..." prop: that'll tell react that it is no longer "the same" element.
<Gateway into={condition ? 'global': targetId}>
  <Text>Hi</Text>
</Gateway>

Though I couldn't get that to work either... last but not least though, there is the even more explicit split:
  { targetId !== 1 && <Gateway into="global">{body}</Gateway> }
  { targetId === 1 && <Gateway into={targetId}>{body}</Gateway> }

Making it too separate "positions" inside the children, react will never think the Gateway changed. However you are right: the content will also be re-mounted, and lose any state it had :(
https://snack.expo.io/HyyGaCWFG


Update README.md

Adding How to load and How to depend on it + improving markdown

thanks, somehow I didn't get the notification about that pull request that's why it took so long


trying to understand this failure

This test is frequently failing, so let's slow things down and see if travis can give us any hints.

So this is what travis says:
not ok 13 - unnamed test
#          got: 'banded alignment works correctly even with varied band size'
#     expected: ''
29

Basically, it produces the correct output but fails the test due to some kind of issue with the command syntax.
I wonder if this is some kind of problem with bash-tap. But if so, why have I never seen it anywhere but travis?

AH great, I got it to fail:
➜  test git:(happy-travis) ✗ while true; do n=$(vg map -f graphs/2086553952_1469228759.mag -d graphs/199754000:199755000.vg.index -B 1000 -J | jq -c '.path.mapping[0].position.offset'); if [ $n -ne 29 ]; then echo failed; else echo ok >>x; fi; done
[: unknown condition: -ne
[: unknown condition: -ne
[: unknown condition: -ne
[: unknown condition: -ne
[: unknown condition: -ne
[: unknown condition: -ne

3048 tests.

It might have something to do with (from running under valgrind)
==31236== Conditional jump or move depends on uninitialised value(s)
==31236==    at 0x61BDB2: __pthread_disable_asynccancel (cancellation.S:98)
==31236==    by 0x619547: pthread_join (pthread_join.c:94)
==31236==    by 0x6CC425: JoinAllThreads (env_posix.cc:1594)
==31236==    by 0x6CC425: rocksdb::(anonymous namespace)::PosixEnv::~PosixEnv() (env_posix.cc:1093)
==31236==    by 0x877DF1: __run_exit_handlers (in /home/erik/vg/vg)
==31236==    by 0x877E42: exit (in /home/erik/vg/vg)
==31236==    by 0x86E3FF: (below main) (in /home/erik/vg/vg)


Images not loading in RecyclerView

Hi, I had posted a question earlier on SO regarding the same problem, and I thought that I had fixed it but that wasn't the case.
The good news is that, I am now sure as to what was causing it. The images load fine when I comment out PhotoViewAttacher(t) (line 108). The code of the concerned activity is here (you can test it if you like, it doesn't use any layout or resources).

I don't think this is a problem with this library. There are a few things wrong with your code here, including the fact that you are loading the bitmaps synchronously on the main thread. You need to look more into the samples provided int this project on how to set up and use RecyclerView


Enums can't be properly used as type parameters to other types in function signatures

Bug Report

🔎 Search Terms

enum type parameter, enum types, type conversion enums, enum type assertions
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about enum types

⏯ Playground Link

Playground link with relevant code
💻 Code

enum TestEnum {
    SOME_CONTENT = "test"
}

type TestParamType<t> = {
    testitem: t
}

function testFunction(number: Number, myTypedType: TestParamType<typeof number>) {
    // This does work.
    console.log(myTypedType.testitem);
}
testFunction(5, {testitem: 7});

function testFunctionWorkaround(myEnum: typeof TestEnum, myTypedType: TestParamType<unknown>) {
    // This does work.
    console.log((myTypedType as TestParamType<typeof myEnum>).testitem);
}
testFunctionWorkaround(TestEnum, {testitem: TestEnum.SOME_CONTENT});

function testFunctionBad1(myEnum: typeof TestEnum, myTypedType: TestParamType<typeof myEnum>) {
    // This won't work, because the typeof myEnum is the typeof typeof TestEnum, not the typeof TestEnum.
    console.log(myTypedType.testitem);
}
testFunctionBad1(TestEnum, {testitem: TestEnum.SOME_CONTENT});

function testFunctionBad2(myEnum: typeof TestEnum, myTypedType: TestParamType<myEnum>) {
    // This won't work, because "myEnum refers to a value".
    console.log(myTypedType.testitem);
}
testFunctionBad2(TestEnum, {testitem: TestEnum.SOME_CONTENT});

function testFunctionBad3<myEnumType extends TestEnum>(myEnum: myEnumType, myTypedType: TestParamType<myEnumType>) {
    // This won't work at all, because the input myEnum is of type "typeof TestEnum", not of type "TestEnum"
    console.log(myTypedType.testitem);
}
testFunctionBad3<TestEnum>(TestEnum, {testitem: TestEnum.SOME_CONTENT});

function testFunctionBad4<myEnumType extends TestEnum>(myEnum: typeof myEnumType, myTypedType: TestParamType<myEnumType>) {
    // This won't work at all either, because myEnumType is a type, so you can't do typeof myEnumType
    console.log(myTypedType.testitem);
}
testFunctionBad4<TestEnum>(TestEnum, {testitem: TestEnum.SOME_CONTENT});

🙁 Actual behavior

Not entirely clear to me whether this is really a bug report or a feature request, but... there doesn't seem to be any way to use the type of an enum in the signature of a function to act as a type parameter to another type in the function signature. Any way I've tried to do so fails for different reasons - I've commented the approaches I've played with above, as well as the  workaround.
🙂 Expected behavior

Of the approaches I've tried, the one I would have expected to work really would have been myEnum: typeof TestEnum, myTypedType: TestParamType<myEnum>; elsewhere, the TypeScript compiler lets enums act as a sort of hybrid of an object and a type, so it's sort of weird that it would get so picky here about them being one or the other and not both.

It seems like you're trying to write this?
function foo<E, K extends keyof E>(e: E, item: TestParamType<E[K]>) {
    console.log(item.testitem);
}
foo(TestEnum, {testitem: TestEnum.SOME_CONTENT});

But then if we extend it:

What you want to write here is E extends typeof TestEnum.
Can you show me a test suite or something? It's much easier to just write a function signature that does what you want than to try to reverse-engineer what you want the expected behavior to be based on the examples that don't work.

That does incidentally solve the direct problem I was having - so thank you! - but I'm still not sure there isn't some weirdness going on here with the way that the language actually works. To my mind, it makes little sense that
function testFunction(number: Number, myTypedType: TestParamType<typeof number>) {
    // This does work.
    console.log(myTypedType.testitem);
}

should work fine, but
function testFunctionBad1(myEnum: typeof TestEnum, myTypedType: TestParamType<typeof myEnum>) {
    // This won't work, because the typeof myEnum is the typeof typeof TestEnum, not the typeof TestEnum.
    console.log(myTypedType.testitem);
}

should not work at all.
The type of an instance myEnum of the type of TestEnum should be the type TestEnum, not the type of the type of TestEnum, surely? In much the same way that in the first one, the type of the instance of Number number is Number, not typeof Number.

You seem to be confused about what the typeof operator does. Docs here

FWIW I still regularly tie my brain into knots trying to reason about Enum vs. typeof Enum.  I’m not sure why but it seems inherently more confusing than the equivalent dichotomy for classes.  If I had to guess it might just be the difference between Enum.A and Enum["A"] that throws me…


Mailchimp integration for marketing emails

Checks marketing consent.
Used for sending marketing emails.

(Roughly two weeks of work)
Needed:

access to mailchimp for testing (test account in testing environment)

Add a marketing consent checkbox to the course settings dialog. This checkbox will allow users to opt in to receive marketing messages related to the course they're taking. When a user consents, they'll be added to the appropriate Mailchimp mailing list for that course. We'll also sync metadata, such as course completion status, with Mailchimp according to our predefined schema.

[ ] Consent checkbox

[ ] Add the consent checkbox to the bottom of the course settings dialog.
[ ] The checkbox should appear only if the course is configured with Mailchimp integration.
[ ] Each course might have a different mailing list, and multiple courses can share the same list.

[ ] Mailchimp Integration

[ ] When a user consents, add them to the corresponding Mailchimp mailing list.
[ ] Sync the following data with Mailchimp:

[ ] User metadata: id, first name, last name, and whether they've completed the course.
[ ] Course Information: course language group id, course id, and course language identifier.

[ ] If a user updates their email in our system, update their email in Mailchimp using their user id.
[ ] Detect if a user unsubscribes through Mailchimp via the Mailchimp API and update their consent status in our database accordingly.

[ ] Managing Marketing Consent

[ ] Users should be able to edit their consent preferences by opening the course settings dialog again.
[ ] Ensure any changes in consent are reflected both in our database and Mailchimp.

[ ] Background Sync Process

[ ] Implement a background thread to handle all synchronization between our system and Mailchimp.
[ ] This process should sync continuously, like chatbot_syncer in our codebase.

[ ] Metadata and Schema Management

[ ] After attaching a Mailchimp list to a course, automatically set up the required metadata schema in Mailchimp. Use the same background thread you use for syncing users.
[ ] Remove any extra columns or fields in the Mailchimp list that aren't defined in our schema to make it clear which columns are supported and which are not. (People may add stuff there, which can lead to confusion for future users.)

Changes to data transfer logic

Giving research permission: Students who give research consent are tagged with Research consent in Mailchimp.
Giving marketing consent : Students who give marketing consent (“I am ok with receiving updates about upcoming language versions…”) are tagged with marketing allowed in Mailchimp.
Accepting Privacy Policy and Terms and Conditions: Data of all students who accept the Privacy Policy is transferred to Mailchimp with the Subscribed status. (If not checkbox not checked, students cannot proceed and start studying the course)

Checkbox texts and UKR (machine) translations
Checkbox 1
EN

I allow the use of collected data about my study behavior for research purposes. The data contains information from material usage and the course exercises. No individuals can be identified from publications.

UKR

Я дозволяю використовувати зібрані дані про мою поведінку під час навчання в дослідницьких цілях. Дані містять інформацію про використання матеріалів та виконання вправ курсу. Жодна особа не може бути ідентифікована з публікацій.

Checkbox 2
EN

I am ok with receiving updates about upcoming language versions and information regarding new courses. I agree to share my contact information in order to receive tailored messages on third party platforms. Read more in our Privacy Policy.

UKR

Я згоден отримувати оновлення про майбутні мовні версії та інформацію про нові курси. Я згоден надати свою контактну інформацію для отримання персоналізованих повідомлень на сторонніх платформах. Дізнайтеся більше в нашій Політиці конфіденційності.

Checkbox 3
EN

I accept the Privacy Policy and Terms of Service.


Problem defining variables on the boundary of a stack frame

When trying to define the size of the par_address variable, I'm not allowed to cross the boundary of $FF. I should set it to a size of 3 bytes (addr/3) even though I'm accessing all of its 4 bytes in the following subroutine.
Am I doing something wrong here?
Thanks.
var_length      .var  $f2    {addr/2}
var_address     .var  $f4    {addr/4}
par_address     .var  $fd    {addr/3}

strlen          phd
                tsc
                sec
                sbc   #$00f7
                tcd
                adc   #$00f0
                tcs
                stz   var_length
@DO             ldx   par_address+2
                lda   par_address
                inc   par_address
                bne   @DONT_INC
                inc   par_address+2
@DONT_INC       sta   var_address
                stx   var_address+2
                lda   [var_address]
                and   #$00ff
                beq   @RETURN_LENGTH
                inc   var_length
                bra   @DO

@RETURN_LENGTH  lda   var_length
                tay
                tdc
                clc
                adc   #$00f7
                tcs
                tya
                pld
                rtl

It's restricting the range because you're only allowed to address local variables with a direct-page access, but now I see that I failed to take 16-bit accesses into account.  The range check is correctly limiting the address to [$00,$ff], but should be limiting address+width to [$00,$100] instead.  And the maximum width of a local variable is 257, not 256.

Thank you, that's exactly what I meant.

Should be fixed here: https://github.com/fadden/6502bench/releases/tag/v1.7.5-dev2

-it's ok now, thank you


Update Javadoc based on customer feed back

Add descriptions about return values
Mention the known issues with watchRepository()
Other miscellaneous cleanup
Undeprecate getFile(...String pathPattern) with fixed return type.

Suggested using getFile(...Query) instead

/cc @rfkm

Thanks, reviewers :)


Page boundary issues

A few things seem eager to escape their viewport/not wrap/scroll as you might expect:

The sample output area (including the table in #10) - falls off the end of the page, no option to scroll
The JSON editor doesn't have text wrapping, and if I enable it with the parameter to the Editor component it seems to wrap at the wrong place (e.g. part is still off the right hand side of the screen)

Note: might be a duplicate of #24

This was resolved by #135


raise a new pr to see tests coverage

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.373%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
137

Relevant Lines:
142

💛  - Coveralls

verified


array or table type specifier on table should imply type for assignments to that table

A lot of the types i'm using are just plain tables, so it's not uncommon for me to have some code like this to build a few of them:
    ---@type Scope[]
    local scopes = {}
    -- Locals
    scopes[#scopes+1] = { name = "Locals", variablesReference = variables.scopeRef(frameId,"Locals"), }
    -- Upvalues
    scopes[#scopes+1] = { name = "Upvalues", variablesReference = variables.scopeRef(frameId,"Upvalues") }
    -- Factorio `global`
    if global then
      scopes[#scopes+1] = { name = "Factorio global", variablesReference = variables.tableRef(global) }
    end
    -- Lua Globals
    scopes[#scopes+1] = { name = "Lua Globals", variablesReference = variables.tableRef(_ENV) }

However, when i hover over scopes in this code, it says that it's a table of [*integer]:Scope and [*number]:table, which is of course useless since the Lua i'm using only has numbers, no integers. Is there any way to recognize those inner tables as Scopes without having to tag them individually? Also, tagging them individually doesn't seem to allow any kind of helpful auto-completes for fields within the table declaration, is it supposed to? Do i need to tag the type as "trivial" somehow so plain tables can convert?

Should be fixed.


Software Installation for Frontend

Visual Studio Code- ES7 for React and Nodes JS
Robo3T
Yarn
Insomnia Rest Client

Installed Robo3T, Yarn, Insomnia Rest Client and Created a Project for React. Setup Done for React and Node


Update documentation

[x] How to build using packr
[x] Documentation of assets.go
[x] Dependencies: PHP installation required
[x] Remove rice from ReadMe
[x] Restructure ReadMe
[x] More details in ReadMe (https://github.com/vjeantet/goDashing/blob/master/README.md)
[x] Add ./goDashing --help to README
[x] Add "Used dependencies" to content list

All currently understood features are described in the README. The remaining stuff is under TODO and will be "beautified" later


pythonPackages.cython: 0.28.5 -> 0.29

Motivation for this change
A new cython release is out and it breaks sage. So I'm including a sage patch into the upgrade commit.
@FRidh
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Duplicate of https://github.com/NixOS/nixpkgs/pull/48768

Thanks for the pointer. I also just noticed that I forgot to take out/investigate an entry to excludedTests. Although I do wonder why FRidh's commit doesn't include it or anything else because for me there was a test failure without that.

I've cherry-picked this to python-unstable.

Thank you. Did you notice the excluded test I mentioned (reimport_from_subinterpreter)? It appears to be a new one.


Add a builder for MockPlugin

Description
I thought, maybe it could possibly be good to add custom onEnable / onDisable / onLoad functionality for the mock plugin. It's at least useful internally. Something like this would be necessary for pull request #1106 as something would need to execute before the plugin is fully enabled (although yeah, you could just make a new plugin for every individual test, but that's not ideal). Please just tell me if this a bad idea, and I will just close this and make a custom class instead.
Checklist
The following items should be checked before the pull request can be merged.

[x] Code follows existing style.
[x] Unit tests added (if applicable).

Also, seems that some tests are failing


Why does Ollama need sudo?

I run nix on my mac to isolate all software.
nix-shell -p ollama works great since ollama is available on the unstable channel.
Works perfectly if I sudo both the server, and the client:

But if either client or server is not run as superuser, then either errors out or doesn't work.

I note that because I have to be root, the ~/.ollama directory is also owned by root.
Is there a reason we can't run the whole stack in userspace? Having to sudo inhibits some automation and isolation options. Alternatively using the installer, clutters up process space with yet another background task, and also forces a toolbar icon.

There's no reason ollama needs sudo in runtime. The only occurrence of sudo or any form of elevated privileges is during install when the MacOS app installs the ollama binary to /usr/local/bin. Can you check the ownership of ~/.ollama and ensure it and any children are owned by your user then retry without sudo?

 Perhaps I was root when I initialized the flake. Anyway my bad works fine thanks for checking.
For guide, my very basic flake.nix if anybody cares:

There's no reason ollama needs sudo in runtime. The only occurrence of sudo or any form of elevated privileges is during install when the MacOS app installs the ollama binary to /usr/local/bin. Can you check the ownership of ~/.ollama and ensure it and any children are owned by your user then retry without sudo?

My bad. I must've been root when I initialized the flake. Closing.
BTW here is my (very basic) flake.nix for ollama if anybody cares:
{
  description = "Python 3.11 development environment";

  # Flake inputs
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; # also valid: "nixpkgs"
  };

  # Flake outputs
  outputs = { self, nixpkgs }:
    let
      # Systems supported
      allSystems = [
        "x86_64-linux" # 64-bit Intel/AMD Linux
        "aarch64-linux" # 64-bit ARM Linux
        "x86_64-darwin" # 64-bit Intel macOS
        "aarch64-darwin" # 64-bit ARM macOS
      ];

      # Helper to provide system-specific attributes
      forAllSystems = f: nixpkgs.lib.genAttrs allSystems (system: f {
        pkgs = import nixpkgs { inherit system; };
      });
    in
    {
      # Development environment output
      devShells = forAllSystems ({ pkgs }: {
        default = pkgs.mkShell {
          # The Nix packages provided in the environment
          packages = with pkgs; [
            ollama
            python311
            python311Packages.pandas
            python311Packages.numpy
            python311Packages.scipy
            python311Packages.scikit-learn
            python311Packages.matplotlib
            python311Packages.ipython
            python311Packages.requests
            python311Packages.aiohttp
            python311Packages.gql
            python311Packages.pathlib2
          ];
        };
      });
    };
}
'''


Saving an expired value should be the same as removing that value

@nicolas-grekas  suggested that saving an expired value should be the same as removing that value form the cache. I believe it makes sense. This PR makes sure we comply with the changes he provided in the integration tests.

Current coverage is 90.38%

Merging #49 into master will decrease coverage by -0.23% as of d3a2b00

@@            master     #49   diff @@
======================================
  Files           21      21
  Stmts          799     801     +2
  Branches         0       0
  Methods        192     192
======================================
  Hit            724     724
  Partial          0       0
- Missed          75      77     +2

Review entire Coverage Diff as of d3a2b00

Powered by Codecov. Updated on successful CI builds.

:+1:

This PR fails on travis. It is Chain, Redis, Predis and Memcached that are failing. They are failing because they fetch the current version of Adapter Common. They will succeed when we tag a new patch version of adapter-common.


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4450

Questions ?
Please refer to the Backport tool documentation


Icon display error in file explorer section.

Describe the bug
Programming language based icon bug in File explorer section
To Reproduce
Steps to reproduce the behavior:

Go to 'Repo dashboard'
See error in file explorer section

Expected behavior
Icon should be visible based on the language.
Screenshots

Command Line Logs
UI error
Desktop (please complete the following information):

OS : Windows
Browser : Chrome
Version : v2.0.1

Issue Type

mark with [x] to select the check box

[x] UI Issue
[ ] Performance Issue
[ ] Feature Breaking Issue
[ ] Security Issue

Severity

mark with [x] to select the check box

[ ] Critical (The application crashes / breaks completely)
[ ] High (Blocks you from performing an critical operation)
[x] Moderate (Bearable or Manageable issue)
[ ] Low (Something is not right, but the impact is minimal)

@Nageswari-droid Fix pushed as part of ef8bf0a

closing issue as the fix has been pushed


Boot error

Hi
I have been testing this project for a couple of days now but I cant get it working.
I got error message as soon I boot it up.
No problem to upload sketch but can´t run it.
The error is: ets Jan 8 2013,rst cause:2, boot mode:(2,7) "Even 2,6 and 3,0 sometimes"
I know that this normally i coursed by bad powersupply. But I can run every other sketch i try but not this one.
Arduino IDE 1.6.13 and 1.6.9
WifiManager 0.11.0 and 0.12.0
ESP8266 2.3.0
Thanks.

Hi pettib,
errors in boot sequence are indeed related to powersupply in most cases. Every sketch has another characteristic and may yield different behaviour.
What ESP module do you use and how do you power it?
Regards
Tobias


2024.05

Support for HA May 2024 release.
Biggest challenge here is the new dependency on ISAL via python3-isal.
https://pypi.org/project/isal/
On HA itself there are also complaints (https://github.com/home-assistant/core/issues/116681) as this is a real pain to get installation and compilation working.
I have tried but failed directly so currently I am falling back to an (ugly) direct wheel build.
I will create a ticket for that package and python3-home-assistant-chip-clusters (which has the same problem).
Furthermore I started adding ptest where possible.
Waiting for a patch send to meta-oe to be merged.

@Gerry546 it seems there is a build error from python3-isal can you take a look

Hmm strange. Sure I'll take a look

After kicking off a rebuild the build seems to fail at different times and at different places constantly. While I see if there is something fundamentally wrong with the recipes can you take a look at the builder @bachp ? In my private server the build consistently passes.

Ok thanks for checking, CI with the gitlab runners is still not reliable unfortunately.


Deprecate infer_schema!

diesel print-schema is now the preferred way to generate schema.rs.

Personally, I never install the diesel-cli because infer_schema is enough for me.
diesel.rs/guides/configuring-diesel-cli is not available right now so the only thing I can say is that I wish/hope it is as easy as using infer_schema.


[tensorflow] Fix tensorflow-api dependency

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #919 (39831e1) into master (8db375f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #919      +/-   ##
============================================
- Coverage     70.34%   70.29%   -0.05%
+ Complexity     5088     5085       -3
============================================
  Files           501      501
  Lines         22431    22431
  Branches       2334     2334
============================================
- Hits          15779    15768      -11
- Misses         5413     5428      +15
+ Partials       1239     1235       -4

Impacted Files
Coverage Δ
Complexity Δ

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
4.00% <0.00%> (ø%)

api/src/main/java/ai/djl/inference/Predictor.java
87.50% <0.00%> (-2.89%)
23.00% <0.00%> (-1.00%)

api/src/main/java/ai/djl/util/Platform.java
43.47% <0.00%> (-2.18%)
8.00% <0.00%> (ø%)

api/src/main/java/ai/djl/repository/Artifact.java
91.37% <0.00%> (-1.73%)
37.00% <0.00%> (-1.00%)

...g/src/main/java/ai/djl/serving/util/Connector.java
55.40% <0.00%> (-1.36%)
21.00% <0.00%> (ø%)

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
63.15% <0.00%> (-1.32%)
20.00% <0.00%> (-1.00%)

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
42.23% <0.00%> (-1.25%)
15.00% <0.00%> (ø%)

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
51.14% <0.00%> (ø)
14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db375f...39831e1. Read the comment docs.


Fix GHC 9.2 compilation

[x] Small 9.2 fix

Comments
I have added CI support for 9.2 as topic for the next dev meeting
Issue Number
None

bors r+

bors r+


DOCS: Document initialise graphql task

Documents the initialise task here: https://github.com/silverstripe/silverstripe-graphql/pull/433

Note: This should not be merged here. I have started the process of migrating docs to a new repository so this PR should be closed and a new one should be created there.

Closed in favour of https://github.com/silverstripe/developer-docs/pull/493