Utilizing on-board SRAM

Is your feature request related to a problem? Please describe.
I have a benchmark that uses large matrices (in order of 200KB data). My FPGA is Spartan 6 that has limited resources but it is connected to a 512 KB SRAM. I need to use this SRAM when I load my instructions and data with UART.
Describe the solution you'd like
Is it possible to have imem and dmem as caches on FPGA and SRAM as the next level memory?

I think indirect boot scenario b should be used according to your description. I try to find out more details about it.

Hey there,

Is it possible to have imem and dmem as caches on FPGA and SRAM as the next level memory?

sure, that is possible. You "just" need an external memory controller attached to the processor's external memory interface. Accessing external static RAM is quite simple and you should have no problems finding a suitable (open-source) controller for that. I think Xilinx ISE (or AMD Vivado?) also provide an SRAM configuration for their MIG IP.
Another option could be to use SPI SRAM attached via the SPI controller. It is slower and you cannot execute code from it (maybe you can, when you multiplex XIP) but it might be simpler to integrate as your do not need to touch the actual hardware. But this highly depends on your performance requirements.

Thanks for your reply. This week, God willing, I will try to use SRAM controller.

Thanks for your reply. This week, God willing, I will try to use SRAM controller.

Hi there. I thinks one side of the SRAM controller should be wishbone compatible and the other side should connect to SRAM and control read/write operations. Am I right?

Sounds good. With a Wishbone port you can connect the controller right to the processor's external bus interface and map the SRAM directly into the core's address space.

Sorry, how should we determine that bootloader writes instruction/data to external (attached to wishbone interface) SRAM and processor reads instruction/data from it?

As you described in NeoRV datasheet, there are two direct boot variants.
I want to use the second one in which the bootloader receives data through UART port and writes it to external memory.
The question is how to inform bootloader to write data to external memory and how to inform CPU to read instructions and data from external memory.

As you described in NeoRV datasheet, there are two direct boot variants.
I want to use the second one in which the bootloader receives data through UART port and writes it to external memory.
The question is how to inform bootloader to write data to external memory and how to inform CPU to read instructions and data from external memory.

In address space section of datasheet, picture comment says that only void regions are redirected to external memory interface. So for IMEM and DMEM, the external memory interface won't receive any request.

Ah now I understand.
Seems like the data sheet is not quite precise there 🙈 I need to fix that.
If you disable the processor-internal IMEM (MEM_INT_IMEM_EN => false,) then the default address region of the IMEM (starting at 0x00000000) will also become part of the "void". Hence, all accesses that were targeting the internal IMEM will get redirected to the external bus interface - effectively accessing your external SRAM.
The default bootloader will always write any new application data starting at address 0x00000000 - so it does care if this is actually written to the internal IMEM or to an external memory.

Thanks for your reply. Do we need to specify data and address space in this case?
Does data space begin from 0x80000000 like the picture of address space?

Thanks for your reply. Do we need to specify data and address size in this case?

The bus provides 32-bit for the address and 32-bit for the data. If your SRAM only provides a 8-bit or 16-bit port then you'll need to implement some kind of state machine to transform 32-bit accesses into consecutive 16/8-bit accesses. Note that the bus interface also supports smaller access granularities, i.e. 8-bit and 16-bit accesses.

Does data space begin from 0x80000000 like the picture of address space?

"Data space" is just a software concept. On the hardware level there is just memory. You can put your data wherever you want - including your SRAM if that is what you want.

I think this can be closed, right?

Hi. Yes thank you.
I couldn't find an open source SRAM controller module. If I find one I will send the link here.

I have this one on my stack (but haven't tested it yet): https://github.com/chkrr00k/sram-controller/blob/master/sram.vhd
It is quite simple and written in VHDL (❤). 😅

You are awesome!
Thanks

Hi @stnolting
Should I instantiate external memory controller module inside neorv32_wishbone.vhd?

I would suggest to keep the code base as clean as possible so you don't run into merge conflicts when there are upstream changes in the Wishbone gateway :wink:
So I would just add the memory controller as individual module and connect it via Wishbone to the processor:
+-----------------+                   FPGA-internal | FPGA-external
| neorv32_top.vhd |                                 |
|      +----------+    +----------------------+     |     +------+
|      | WISHBONE |--->| Your SRAM controller |---->o---->| SRAM |
+------+----------+    +----------------------+     |     +------+

You're right. Thanks

Hi @stnolting
I have prepared SRAM controller module and want to interface it to processor external bus (wishbone). Is there any documentation on wishbone signaling?

I found it in
https://stnolting.github.io/neorv32/#_processor_external_bus_interface_xbus
Thanks.

:+1: :+1: :+1:

yes pls I will probably in the future also need something very similar to this application case. It was really usefull to have this information as a starting point. Ty!

Ok. for sure.

This is my SRAM controller. It starts when both xbus_stb and xbus_cyc are '1'. My top module assigns true to INT_BOOTLOADER_EN and false to MEM_INT_IMEM_EN, MEM_INT_DMEM_EN. The source codes are attached at the bottom.

This is the waveform of SRAM controller. As can be seen, DATApin port is 8 bits wide and therefore it needs four iterations to complete. The xbus_ack signal gets '1' when we go from BYTE_END to WAITs state (after writing all 4 bytes).

SRAM_controller.zip
I couldn't get it work with NeoRV32 up to now and bootloader texts to choose uploading binary or execute are not shown. The simulation needs uploading data from UART and I should find a way to do that.

@stnolting, do you have any idea for connecting a virtual UART terminal to my simulated design?

Hi!
Try with this file uart_rx.simple.vhd.
And add it in your test bench as follows:
architecture tb of tb is

-- your signals/constants

constant baud0_rate_c            : natural := 19200;
constant CLOCK_FREQUENCY         : natural := 100000000;
constant uart0_baud_val_c : real := real(CLOCK_FREQUENCY) / real(baud0_rate_c);

begin

  your_top_under_test_inst: entity work.your_top_under_test
  generic map(
    --Your generics
             )
  port map (
    --Your ports
    uart0_txd_o => uart0_txd,
    uart0_rxd_i => uart0_txd
                  );
-- UART Simulation Receiver ---------------------------------------------------------------
  -- -------------------------------------------------------------------------------------------
  uart0_checker: entity work.uart_rx_simple
  generic map (
    name => "uart0",
    uart_baud_val_c => uart0_baud_val_c
  )
  port map (
    clk => clk,
    uart_txd => uart0_txd
  );

-- Your test

end architecture;

If everything is okey you will see through asserts the uart output in the terminal where you are running the simulation. For example if you use VUnit your going to see the output in the terminal using -v argument. If you use vivado your going to see the output in the tcl console.
As shown in the following image:

I hope you find it helpful!

Thanks a lot.

@mahdi259
Thanks for sharing your sources and all the details! You should really put them into a repository! I think that many people would find them useful. :+1:
@Unike267

Try with this file uart_rx.simple.vhd.

Good idea!
One more suggestion from my side: if you enable the internal IMEM and DMEM + the bootloader you can use the bus_explorer program to execute XBUS transactions by hand. Together with an oscilloscope / logic analyzer this can help to debug the FPGA-SRAm interface.

Thanks for your positive attitude @stnolting.

Here is my SRAM controller. It's a work in progress.
https://github.com/mahdi259/SRAM_controller.git

Looks great! :+1:


Multicontainer getting started not working on iot-gate-imx8 device type

Te tag 10-stretch-run used by https://github.com/balena-io-examples/multicontainer-getting-started isn't available for the iot-gate-imx8 device type, the only ones available seem are:
https://hub.docker.com/r/balenalib/iot-gate-imx8-debian-node/tags?page=1&ordering=last_updated&name=1-stretch-run
[Success]   Successfully pulled cache images
[frontend]  Step 1/11 : FROM balenalib/iot-gate-imx8-debian-node:10-stretch-run
[proxy]     Step 1/2 : FROM arm64v8/haproxy:1-alpine
[data]      Step 1/6 : FROM balenalib/iot-gate-imx8-debian-node:10-stretch-run
[frontend]  manifest for balenalib/iot-gate-imx8-debian-node:10-stretch-run not found: manifest unknown: manifest unknown
[data]      manifest for balenalib/iot-gate-imx8-debian-node:10-stretch-run not found: manifest unknown: manifest unknown

cc @nghiant2710

hey @acostach, I think node v10.x was dropped support before this device was added, by any chance we can update the getting started to use recent version of node like 12.x or 14.x?

Sure, I updated them to 14.8 in https://github.com/balena-io-examples/multicontainer-getting-started/pull/33

v10.x is EOL and no longer supported, fixed when update the example to v14.8 https://github.com/balena-io-examples/multicontainer-getting-started/pull/33


Add use of Composer scripts

What are your thoughts on updating the Testing section of the readme to document testing via composer test?

I for one think using composer test is a great idea. As seen in #21, simply running phpunit isn't necessarily always going to work. What if they don't have vendor/bin in their PATH? Or are we expecting everyone to have PHPUnit installed globally? And is that even a good recommendation?
Using Composer commands solves all this. And if there are different testing frameworks being used, great, it will just work. This also takes care of the path resolution, removing the need to include things in your PATH to make the command work.
I'm pretty sure this is what @Seldaek was trying to solve with commands, so why not take advantage of this?

One more note on this pull request. You don't actually have to include the full path ("test": "./vendor/bin/phpunit"), since Composer automatically adds the bin, as per the docs:

Note: Composer's bin-dir is pushed on top of the PATH so that binaries of dependencies are easily accessible as CLI commands when writing scripts.

Right, for testing at work we use rake test && dredd which would be a pain for somebody else to know. You just want to run a single command and have it test.
The only other options are phing-style build managers and alias bash scripts which wont work on Windows, so Composer scripts are the obvious choice. :)

Should we update it to use phpunit --coverage-text --coverage-clover=coverage.clover? Is that a setting we could maintain in phpunit.xml.dist?

You could use the <logging> section in the XML file.
If I understand you correctly, this is what you want:
<logging>
    <log type="coverage-text" target="php://stdout"/>
    <log type="coverage-clover" target="coverage.clover" />
</logging>

I've had a long weekend, so I'm slightly error-prone today :smile:

I thought about it long and hard and decided I was right. :p
But seriously, this is a good change and I wish more people did it.

@philsturgeon Should we update README.md accordingly as well?

Yessir please PR

@philsturgeon I used to be against this but all of the logic and sanity dictates this is a smart idea.
:+1: for merging this. I'll probably be advocating using composer test over other harder to remember and often changing commands across projects :smile_cat:


Refactor NavBreadcrumb to use Material-UI

Overview
Refactor NavBreadcrumb to use Material-UI
Action Items
Follow our best practices to use MUI and global theme/styling where possible, and local styling only if it makes sense for this component.
Resources/Instructions
https://github.com/civictechindex/CTI-website-frontend/blob/main/UI-THEME-STYLES.md

Progress: Reworked NavBreadcrumb component structure/style to be more mui compliant.  Working on color updates
Blocks: none
Availability: medium
ETA: 2 days

Refactoring done


Execute function with PromiseKit 6 in sequential order or unordered

I just started to use PromiseKit and it is amazing with Alamofire requests.
However, I could not compile my code if I want to execute a function in sequential order or mapping (unordered sequence).
This code works:
    self.loginAPI()
            .then { obj -> Promise<[MyHTTPRequest]> in
                return self.getHttpRequests(obj)
            }.then { requests -> Promise<Bool> in
                // try to download all request in one function
                return self.downloadAllRequests(requests)
            }.done { boolResult -> Void in
                print(boolResult)
            }.catch { error in
                print(error.localizedDescription)
        }

However, because the number of requests is dynamic, it is impossible to write nested promise inside one function. I found a possible solution to my problem here https://github.com/mxcl/PromiseKit/issues/670 but I could not make it work.
Possible attempt for unordered requests:
    self.loginAPI()
            .then { obj -> Promise<[MyHTTPRequest]> in
                return self.getHttpRequests(obj)

            // unable to compile here
            } when(fulfilled: requests.map(self.downloadOneRequest)).done { results in

                print(results)
            }.catch { error in
                print(error.localizedDescription)
        }

Possible attempt for ordered requests:
    self.loginAPI()
            .then { obj -> Promise<[MyHTTPRequest]> in
                return self.getHttpRequests(obj)
            }.then { requests -> Promise<Bool> in
                var requests = requests
                // I don't know what to put in Promise(), which causes error
                return Promise().then { _ -> Promise<Void> in
                    if let req = requests.popFirst {
                        return self.downloadOneRequest(req)
                    } else {
                        // same here, don't know what the put inside Promise()
                        return Promise()
                    }
                }
            }.done { boolResult -> Void in
            }.catch { error in
                print(error.localizedDescription)
        }

Many thanks for the solution.
Using latest PromiseKit 6 with PromiseKit Alamofire Extensions.

Impossible to help you since you didn't provide the error messages or line numbers of the errors.

I'm sorry but I really don't understand what you mean by:

if I want to execute a function in sequential order or mapping (unordered sequence).

If you can explain your issue, preferably with specific error messages, please re-open.


add parameters of effects

The following parameters are added:
ConeEffect:

solid: Make the cone looks solid, I refered to CylinderEffect
strands: Show more than 1 strands

VortexEffect:

radiusGrow: Update radius
initRange: Add an offset to range

Looks cool, thank you for the contribution!


BufferingLog FQCN support and a Logback implementation

Sorry to put to commits in the same pull request... I can break them up if needed.

FQCN for BufferingLog - this one is simple. Early log messages (before the pax-logging-service is activated) were being annotated with the wrong origin class.

Logback support - this one is big and has a few details that need consideration.
a) it includes two monkey-patched Logback classes to fix some places where Logback was not flexible enough to hook in OSGi details. I've submitted both patches to Logback and one has been accepted.
b) I duplicated the four SPI classes. Surely there's a better way, but it's beyond my Maven-fu to copy them from pax-logging-server dynamically. Maybe they should really be in pax-logging-api?
c) my unit tests use EasyMock instead of JMock. Hopefully not a big deal?
d) my code uses FindBugs @NonNull annotations. These are not retained to runtime, so hopefully not a problem?
e) I've copied and modified a handful of classes in org.ops4j.pax.logging.service.internal. Perhaps these should be refactored into a shared service base package to reduce code duplication?

Thanks for your consideration. A very similar version of this code has been running at my employer for the last 3 months (I cleaned up and changed package names for this submission)

Oh, another point. I've also specified Logback 0.9.29 in the pom. Logback 0.9.30 has been out for a month, but I haven't tested it yet so I left this submission as 0.9.29 for now.

Just one comment; Please go through and make the License headers in
each source file accurate. I.e. where it is copied from
pax-logging-service, and I am likely listed as Copyright owner, add
your name if you have made changes. And for new files, copy and place
yourself as the Copyright owner.
I am pleased to see this come into fruition, although I suspect it is
a fairly 'rigid' implementation and I had bigger plans to fully take
advantage of Logback's better SPI. But I gave up on that, so no
complaints...
On Wed, Oct 26, 2011 at 12:20 PM, Chris Dolan
<EMAIL_ADDRESS>wrote:

Sorry to put to commits in the same pull request... I can break them up if needed.
1) FQCN for BufferingLog - this one is simple. Early log messages (before the pax-logging-service is activated) were being annotated with the wrong origin class.
2) Logback support - this one is big and has a few details that need consideration.
   a) it includes two monkey-patched Logback classes to fix some places where Logback was not flexible enough to hook in OSGi details. I've submitted both patches to Logback and one has been accepted.
   b) I duplicated the four SPI classes. Surely there's a better way, but it's beyond my Maven-fu to copy them from pax-logging-server dynamically. Maybe they should really be in pax-logging-api?
   c) my unit tests use EasyMock instead of JMock. Hopefully not a big deal?
   d) my code uses FindBugs @NonNull annotations. These are not retained to runtime, so hopefully not a problem?
   e) I've copied and modified a handful of classes in org.ops4j.pax.logging.service.internal. Perhaps these should be refactored into a shared service base package to reduce code duplication?
Thanks for your consideration. A very similar version of this code has been running at my employer for the last 3 months (I cleaned up and changed package names for this submission)
You can merge this Pull Request by running:
git pull https://github.com/chrisdolan/org.ops4j.pax.logging master
Or you can view, comment on it, or merge it online at:
https://github.com/ops4j/org.ops4j.pax.logging/pull/8
-- Commit Summary --

Add FQCN support to BufferingLog.  I cant believe it... finally someone really stepped up and added logback support :-) I'vent done any intensive tests with the implementation but only have given it a short look; from my point of view pls add the according jira's and push it to the master; if we discover any problems we can still revert the patch (which is the ops4j mentality anyway) --> +1

I'll do that after I address Niclas' recommendations, thanks.
An implementation question: I used "org.ops4j.pax.logging" as the
configuration PID, which means that the logback service shares a .cfg file
with the log4j service. I thought that was fine because the only config
keys that my implementation uses are
"org.ops4j.pax.logging.logback.config.file" which is the path to the
logback.xml file, and "pax.logging.entries.size" which has the same
meaning as the log4j version.
Is that an acceptable decision?
Chris

boah! I cant believe it... finally someone really stepped up and added
logback support :-) I'vent done any intensive tests with the
implementation but only have given it a short look; from my point of view
pls add the according jira's and push it to the master; if we discover any
problems we can still revert the patch (which is the ops4j mentality
anyway) --> +1
--
Reply to this email directly or view it on GitHub:
https://github.com/ops4j/org.ops4j.pax.logging/pull/8#issuecomment-2527597

Sounds ok to me.
On Wed, Oct 26, 2011 at 9:02 PM, Chris Dolan
<EMAIL_ADDRESS>wrote:

An implementation question: I used "org.ops4j.pax.logging" as the
configuration PID, which means that the logback service shares a .cfg file
with the log4j service. I thought that was fine because the only config
keys that my implementation uses are
"org.ops4j.pax.logging.logback.config.file" which is the path to the
logback.xml file, and "pax.logging.entries.size" which has the same
meaning as the log4j version.


Plugin firebase_auth: ^0.6.6: Invalid signature (wrong jwt signing algo used)

Hi,
The idToken returned by the method getIdToken() in firebase_auth returns a jwt signed with the algorithm HS256 while the "alg" in the header section of the jwt is "RS256".
In the documentation (https://firebase.google.com/docs/auth/admin/verify-id-tokens) in the last section (Verify ID tokens using a third-party JWT library) seems to indicate that the expected algorithm to use is well "RS256".
Thus the jwt should be signed with RS256 instead of HS256.
Thank you !

Is this error resolved? I keep getting invalid signature from getIdToken() function

@QuentinG3 Can you tell us how you solved the issue?


Skip neutron SGL test blocking promotion

This issue is most likely automated test race condition, should not block promotion,
more details on OSPCIX-457.

/lgtm

/approve


Many fields in objects

Hi.
I am using tile38. Works fast, everything suits.
But there is one problem.
I have objects with geo-coordinates, and many layers.
a layer is a geofence (polygon) and a set of filters over the attributes of objects.
I decided to store the coordinates of the objects in tile38 and, as the name of the fields, the identifiers of the layers into which the object belongs, well, in the value 0 or 1.
The calculation is included in the layer or not, another process is calculated that pushes data into tile38.
To which clients subscribe (SETHOOK) with a filter by fields.
on the test with 5 layers everything worked fine. but adding 500 layers for 25,000 objects, tile38 ate 5GB of RAM
should it be so?

Hi.
That 5GB ram does seem like a lot.
I'm curious what you get back from running the SERVER command? Issue a GC beforehand to make sure that the heap is as small as possible.
tile38-cli> GC
tile38-cli> SERVER

For me,  I just ran a quick test on my side and dumped 25,000 points into a collection, each with 12 fields, and I'm the tile38-server process is only consuming 35MB.
My SERVER response is:
{"aof_size":13895435,
"avg_item_size":1246,
"cpus":16,
"heap_released":100466688,
"heap_size":27269424,
"http_transport":true,
"id":"5b352d2f097f70355bdb047cc71e82ae",
"in_memory_size":3087500,
"max_heap_size":0,
"mem_alloc":27269424,
"num_collections":1,
"num_hooks":0,
"num_objects":25000,
"num_points":21875,
"num_strings":3125,
"pid":66239,
"pointer_size":8,
"read_only":false,
"threads":28,
"version":"1.19.3"}

For my test, each object was a simple point, like: SET fleet truck1 FIELD ... FIELD ... POINT 33 -112.  More complex objects, such as GeoJSON features like Polygons with properties and such, will take up more ram.

I create 25k simple object (POINT) with 460 Fields
{
   "ok": true,
   "stats": {
      "aof_size": 34823873,
      "avg_item_size": 10182,
      "cpus": 8,
      "heap_released": 3268608,
      "heap_size":<PHONE_NUMBER>,
      "http_transport": true,
      "id": "4758e4686bab14bfc9d75be745f2b30a",
      "in_memory_size":<PHONE_NUMBER>,
      "max_heap_size": 0,
      "mem_alloc":<PHONE_NUMBER>,
      "num_collections": 2,
      "num_hooks": 0,
      "num_objects": 26904,
      "num_points": 327342,
      "num_strings": 0,
      "pid": 20656,
      "pointer_size": 8,
      "read_only": false,
      "threads": 14,
      "version": "1.19.2"
   },
   "elapsed": "997.8µs"
}

After invoke command GC
5GB ram -> 3GB


Fix Travis CI Mac tests

From travis-ci.com build 93.3 to build 94.3 the pip upgrade started to fail.
It might be a ruby issues. Homebrew looks like it now wants ruby 2.3 and TravisCI uses 2.0.

Same as #4


Cicada Theme dropdown boxes broken

Before you add a new report, we ask you kindly to acknowledge the following:
[ Yes] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ Yes] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Updated to version OPNsense 24.1.a_205-amd64 and all drop down boxes - whether that be theme selection, time zone selection, gateway group tier numbers etc are all broken - they dont open any context menu most the time and when they do, they are empty or show nothing
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:
Go to any screen with a drop down box (Settings>General)
Click on Language
See error

Expected behavior
Get a list of options as per previous versions
Describe alternatives you considered
Could change stuff in a backup xml but prone to going wrong
Tried 3 different PC's, testing Edge, Chrome and Firefox - all same issues
image
image
If applicable, information from log files supporting your claim.
NA
Add any other context about the problem here.
NA
Software version used and hardware type if relevant, e.g.:
OPNsense 24.1.a_205 (amd64, OpenSSL).

I've renamed the devel themes. If you use the dev version use the dev theme as well since 23.7.5 the plugins should all work :)

Also having this issue.
Multiple systems that using previous versions of os-theme-cicada are working correctly, all of which are currently running OPNsense 23.7.5 and using os-theme-cicada 1.34.
A freshly-installed system with OPNsense 23.7.6 and os-theme-cicada 1.34_1 exhibits the dropdown issue as stated in the original report. Using opnsense-revert to install os-theme-cicada 1.34 (from the 23.7.5 release) does not fix the problem, even though that version of cicada is working correctly on 23.7.5 systems.

Ive updated from OPNsense 23.7.5 to 23.7.6 and am experiencing the same dropbox issues.

https://github.com/opnsense/plugins/issues/3616#issuecomment-1758992074

Issue is confirmed fixed in os-theme-cicada 1.34_2.

same here with vicuna theme


Add additional temperature and humidity sensor for Air Conditioner Companion

The air conditioner itself does not have a temperature and humidity sensor. Can you add an external temperature and humidity sensor, such as through mqtt, etc.
In addition, can you modify the wind speed to the style in the picture.
Thank you for your work!

Hi,
unfortunately it is not possible to add external temperature and humidity sensors, and i do not plan to add as this plugin is about the miot protocol. You can easily add such sensors to Home using other plugins and the use automations to combine them.
What style do you mean, and what device are you using?


[Tooltip] Change default max-width to 100% instead of 10rem

Problem: Tooltips currently have a max-width of 10rem by default, and you cannot change it from within the _settings.scss. Because of this, tooltips with at least 5 words are overflowing to the next line, and therefore making the tooltip unnecessarily "fatter" than it should be.
Possible Solution: Setting the default max-width to 100% instead of 10rem.
Before & after screenshots

I can reproduce
Current State => https://codepen.io/IamManchanda/pen/vmQrLL?editors=1100
Max width 100 => https://codepen.io/IamManchanda/pen/rmQKaq?editors=1100
But i think we should insert it in a variable!

@ompmega would you like to create a PR for it ??
https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/

@IamManchanda Thanks for the suggestion! Closed PR since it caused an issue when tooltips have long sentences. Will create a new PR with original max-width of 10rem instead, but leaving in the variable.

You could have done that in that same PR
Just make changes and git push origin HEAD

@IamManchanda Oops my bad. Still trying to figure out all this PR stuff :-)


[cli] generate Related for m-to-n relation

PR Info

Closes https://github.com/SeaQL/sea-orm/issues/1074
Closes https://github.com/SeaQL/sea-orm/discussions/1066

Fixes

[x] The old logic of determining a m-to-n relation somehow require the relation to be a composite foreign key. However, this clearly not a must. So, I updated to logic to only require the intermediate table of a m-to-n relation to be with

Exactly 2 foreign keys
A primary key formed by exactly 2 columns
Number of primary key equals to number of column

Interesting. I don't have much knowledge here, but I remember a discussion around 'how to infer a many-to-many relationship' was made a long while ago.

Feel free to merge

Hi @billy1624 ,
I've just came across this issue in my project. I have m-to-n relation that is not generated correctly by cli. Any idea when this will be merged?

Hey @kandrelczyk, I'll merge this now and this will be release on our next patch version.


Feature get dba sql management object

Had some problems pushing to remote repository for #1482, made the changes in this branch.

yessssssssssss

amazing work man!


Is there magnifier in Spyder?

Is there magnifier in Spyder?
When we place the mouse pointer in scroll bar in PyCharm 2021, a rectangular magnifier appears and that portion of code will be shown. Is there such a tool in Spyder?
The below picture is a sample in PyCharm 2021.
I asked this question here too.

Thanks for the feedback @ARGhanbari ! What do you guys think @spyder-ide/core-developers ?

I think this won't be easy to implement.
@ARGhanbari, why do you find the magnifier useful?

I think this won't be easy to implement.
@ARGhanbari, why do you find the magnifier useful?

It's a very useful feature for debugging code. With this feature, we can see any part of the code rapidly without going to that certain part.
Moreover, "magnifier" is a name that I have given to this feature. In fact, I don't know the exact name of this feature, because it's working like a magnifier!

Ok, I thought it was like a real magnifier, but paying a closer attention to your screenshot, it's more like a "code previewer", right?
I mean, it seems it allows to have a glimpse at the code definitions under the mouse, if I'm not mistaken.

code previewer

You are right.
By moving the mouse pointer over the scrollbar, we can see that part of code in a rectangular frame without going to that part. It's looks like a "code previewer" as you said.


2.x - Allow customization of span naming logic for traces

In v1, there was a SpanNameProvider interface that a user could provide an implementation of via the module config.
public interface SpanNameProvider {
    String spanName(HttpRequest request);
}

e.g.
config
.serviceName("ratpack-demo")
.spanNameProvider(new SpanNameProvider() {
        @Override
         public String spanName(final HttpRequest request) {
                      return "foo" + request.getHttpMethod();
         }
})

For v2, we should provide something similar.  SpanNameProvider still exists but we've removed the ability to configure it. Also it still has a lot of the feel of Brave http (adapters, etc.) - so now might be a good opportunity to redesign that stuff (thinking maybe a @FunctionalInterface).

I currently have a plugin with 3 methods spanName requestTags and
responseTags which default but can be overridden as a unit.
This allows you to use the same plugin to coerce any http library (similar
to brave 3) what is different is that the parsing is lazy and also the
input can have other data.
Ex currently thinking brave.http.HttpRequestContext which wraps calls ex
req.method() would call the underlying. However you could subtype this.. ex
RatpackHttpRequestContext which could possibly also expose a connection
which could aid building more sophisticated tags. It could also expose the
raw request object.
Moreover the ResponseContext could carry an error message or throwable.
This allows someone to write the "error" tag differently across any library
defaulting to something sensible.
Will ping with concrete code which will be soon like today
Im currently jigging this across other libraries and want to make sure it
works.

made some notes here. After looking both ways I ditched the wrapping
approach which I tried for a few hours today. I think this one is best, but
let me know. Regardless, we can choose to make span name parser an atom or
a part of a composite plugin.
https://github.com/openzipkin/brave/pull/350/files#r113442950
On Wed, Apr 26, 2017 at 6:54 AM, Adrian Cole<EMAIL_ADDRESS>wrote:

I currently have a plugin with 3 methods spanName requestTags and
responseTags which default but can be overridden as a unit.
This allows you to use the same plugin to coerce any http library (similar
to brave 3) what is different is that the parsing is lazy and also the
input can have other data.
Ex currently thinking brave.http.HttpRequestContext which wraps calls ex
req.method() would call the underlying. However you could subtype this.. ex
RatpackHttpRequestContext which could possibly also expose a connection
which could aid building more sophisticated tags. It could also expose the
raw request object.
Moreover the ResponseContext could carry an error message or throwable.
This allows someone to write the "error" tag differently across any library
defaulting to something sensible.
Will ping with concrete code which will be soon like today
Im currently jigging this across other libraries and want to make sure it
works.

@adriancole sorry, I didn't get a chance to look at this until today - the link above just goes to the PR (maybe because of a rebase?). Anyhow - is the idea that we'd extend brave.ClientHandler or brave.Serverhandler? Or would it be brave.http.HttpAdapter?

This can be customized with Brave 4.3.1 by providing a custom HttpParser and override the spanName method.  The custom HttpParser can be set through the ServerTracingModule serverParser and clientParser.
@hyleung do you feel this sufficiently covers the ability to customize the span names?

@llinder similar to #27 - think we can punt it for 2.0.0. Again, wanted to see if it would make sense to have something more RatPack-y.

Implemented by #42


[GH-160] Add shutdown message for node-IPC.

https://github.com/input-output-hk/cardano-shell/issues/160

  test/NodeIPCSMSpec.hs:49:9:
  1) NodeIPC state machine, Node IPC state machine, should return the correct response
       uncaught exception: IOException of type ResourceVanished
       <file descriptor: 58>: hClose: resource vanished (Broken pipe)
       (after 1 test and 7 shrinks)
         Commands
           { unCommands =
               [ Command ShutdownCmd ShutdownInitiatedResponse []
               , Command ShutdownCmd ShutdownInitiatedResponse []
               ]
           }

  test/NodeIPCSMSpec.hs:49:9:
  1) NodeIPC state machine, Node IPC state machine, should return the correct response
       uncaught exception: IOException of type ResourceVanished
       <file descriptor: 58>: hClose: resource vanished (Broken pipe)
       (after 1 test and 5 shrinks)
         Commands
           { unCommands =
               [ Command ShutdownCmd ShutdownInitiatedResponse []
               , Command QueryPortCmd (ReplyPortResponse 12345) []
               ]
           }

:gun:

Erm, ok, this is weird, seems like I do understand how it should work - https://github.com/advancedtelematic/quickcheck-state-machine/blob/master/src/Test/StateMachine/Sequential.hs#L186

Quickcheck state machine issue
In the meantime, I did manage to run it and find the error using "regular" QuickCheck tests, but it took me more then 10000 tests to find it!
Which means, it's not an issue in quickcheck-state-machine but in the actual code.
I think that the reason why this is failing is that it occasionally shuts down the client and returns ExitCode, and other times we get EOF from the pipe. It's basically non-deterministic, and that is something I didn't expect.
My concern here is that it's not really acting predictable and I'm not sure if I'm supposed to "promote" an ExitCode as an actual handled exception. There are some reasons for doing that.
You can try to reproduce this using stack test --fast -j12 --nix --test-arguments "-m NodeIPC/startIPC -a 10000".


Parameter hinting still coming when the cursor is outside parenthesis.

Steps to reproduce:
Step 1: Launch Brackets, open any php file.
Step 2: Call any function and invoke parameter hints. (here, cursor is in between parenthesis)
Step 3: Move cursor outside parenthesis but pressing right arrow key and observe the behavior.
Actual Result:
Parameter hints are still visible.
Expected Result:
Parameter hints should not be shown when cursor is outside the parenthesis.

The language server does not support parameter hints?

These are not provided by the language server

Actually, they are. Forgot that feature was added.
Could you please provide some logs of the LSP requests the client makes.

Basically we get valid parameter hints on a signatureHelp request even when the cursor position is just outside of the closing parentheses. The server should respond with empty result when we are outside of the function call scope.


Meeting Notes from 3/21/2015 with Lee Asher

Lee Asher   leeasher.com
Father is a Magician
Creates "effects" for other magicians
Sells via .pdf and movies?
Lectures to other magicians
Penguinmagic.com
Routine builder is great
List of questions, based on criteria.
Instead of being a suggestion from the computer, suggestion from the "old wise master" that gives it a persona for the site.
===== User, "Magician"
Name
Location (City / State / Country)
Age
Bio
Photo
Type of Magic Interest (cards, silk, etc)
Influences
What's on your bookshelf / in your video collection?  Which did you last read / watch?
Favorite deck of cards?
Do you like to collect magic?
How large is your professional crew?
What other sites do you frequent?
Affiliations / Associations / Local Clubs & Groups
Awards / Accolades / Competitions?
Last attended lecture / convention?
What's your favorite magic shop online/offline?
Years of Experience
Last trick performed / when?
Crowning moment?
Favorite YouTube Magic Video?
Largest show performed?
How often do you perform per week?
Do you want to find out about new magic?
Level of Experience (pre-built list)
-- Neophyte (newbie)
-- Enthusiast
-- Hobbyist
-- Historian
-- Collector
-- Semi-professional (does a few shows / year)
-- Professional (makes an earning)
Social Media (fb, g+, twit, weibo)
Personal Website
===== Routine (smaller parts)
Effects:  http://geniimagazine.com/wiki/index.php/Effect_Classification
Methods:  Description
Handling:  Details
Name
Type (pre-built list?)
Suggested skill level
Description
Length
Audience Involvement (yes / no)
Materials (inspected?)
User keeps something at the end
Opener / Middle / Closer
Attribution (source)?  Proper attribution. Date of first performed.
Venue 0-50 close up 50-100 stand up 100-250 stage 250+ grand illusion
Prep Time (instant / short / long)
Cost of Materials
Reset time
Space requirement (pockets / small / large / gargantuan)
===== Sets
Name of Set
Name / Photo of Creator
Skill level of creator
Rating (community rating)
Length
Venue
Story / Plot
Array of Effects
Don't repeat Routines / Effects
Set for Money
Build something outside of the comfort zone (wildcard)
Short / Medium / Long
Type of Venue suggestion
Suggest if a specific prop is given
Community curators as a future thing
Effects Page - shortlist of things at the top, ingredients directly at the top

Materials
Description
Type
Cost
Collapsed information

Popularity of the effect?
More popular the trick, the more it will be used by hobby/enthusiast

Lee mentioned listing supplies more than I thought he would.  Monetization Idea: Hot link common supplies to Amazon with an associate's id.

It's his business...  and it is very important.  I wouldn't expect, however, to find these sorts of things on Amazon.  When it comes time to seed the dataset, we can troll through Theory11, Penguin, Illusionist, Grand Illusions as well as the personal websites of Lee Asher, Wayne Houchin, David Regal, Eric Jones and others.  I hope to have a healthy set of effects seeded in the database.

Lee's initial comment:  "It's really cool".
Penguin Magic did a Build your Act app a few years ago, but it was not a commercial success, probably due to inadequate marketing and product positioning.
Fields for the Magician (User) entity:
Type (Newbie, Enthusiast / Family magic, Magic Club / Hobbiest, Semi-Professional, Professional (you make a living at it)
Age
Location
Bio
Kind of Magic you're into
What's on your bookshelf?
Who are your influences?
What magic forums do you frequent?
Do you belong to any magic organizations (IBM, SAM, etc.)?
What is the last routine you performed and when?
What is your favorite YouTube magic video?
Do you want to hear about new magic?
Have you ever busked (done street magic?)
What is the largest show you've ever done?
On average, the number of performances per year?
What is your home magic store?
Have you won any awards?
Are you preparing for a show?
What is the last book/DVD you read/watched?
Your favorite deck?
What size of coins do you work with?
Do you have any magic-related collections?
What is the last convention or lecture you attended?
=-=-=-=-=-=-=-=-
Attributes related to the Routine entity
What is the Effect?
Describe the Method.
What is the Plot? -- see taxonomy.
Describe the Handling.
How long is the routine?
Does it require spectators?  How many?
Materials:
Name / Inspectable / Consumed
Any takeaways / keepsakes
Is the routine an opener? Middler? Closer?
To whom can you attribute the original creator of the routine?
Who introduced you to the routine?
<< Star system the assess the quality of the attribution >>
Venue
0-50 = Close-up
50-100 = Parlor
100-300 = Stage
300+ = Grand Illusion
Does it instantly reset?
What is the prep time?
Does it consume materials?
What is the space requirement?
What is the skill level to perform?
Can this routine be shared to other PlayWithMagic users?
=-=-=-=-=-=-=-=-
Attributes related to the Set entity
Venue
Computed values related to the Set entity
Length
Cost
Materials
Search values related to finding routines for a set
Random
Comfort Zone
Routines with high ratings from Professional magicians
Have a professional suggest a set for you
Business rules related to sets:
Be sure the routines in the set don't repeat an effect.  If your first routine emphasizes a torn-and-restored effect, then don't close with the same effect -- you've already established that you can do that.

Closed


[Draft] Fix button centering on iphone

For some reason, physical iPhones are not centering the text inside the map buttons correctly. (48, AK, HI, PR)
Playing with mono spaced fonts before trying svg buttons.

@katherinedm-usds Can you look at the map buttons in an iPhone using this url? https://d2zjid6n5ja2pt.cloudfront.net/justice40-tool/100670/en/cejst#3/63.28/-162.39
This is a test fix (I'm trying a font change before falling back to an svg).

@vim-usds Ready for a code review.


Backtracking Problem

I would like to solve the famous problem of Backtracking -  N Queen Problem using C++ ,Java and Python

I would like to contribute solution to the prolem of Backtracking such as Sudoku, Rat in a Maze-I, M-Coloring problem in C++.

issue present at #381


Update performant-components.md

Small docs change.

Yes. The current docs are incorrect. They use memo() inside of render code. As a result, it creates a brand new component instance on every render. This defeats the purpose.
These docs move the use of memo to outside of the component.
I made a sandbox to show why the current docs break the React rules of memoization.
To test it, open the console in the bottom right, and then click the Rerender button. Notice that the component wrapped with memo still logs.


button: renaming

Rectangle buttons existed but I just added Capsule buttons (which I hope is a nice addition), what do you think about me renaming the Rectangle buttons?
I named the capsule buttons BitcoinCapsuleFilled and BitcoinCapsuleOutlined with the Rectangle buttons in mind so that I could possibly rename those to BitcoinRectangleFilled and BitcoinRectangleOutlined possibly. Thoughts @danielnordh ?
Also I didn't make a BitcoinCapsulePlain button because BitcoinPlain doesn't really have a border shape anyway from what I can tell, let me know if I'm missing something though.

No complaints about renaming, I took the names from the Figma file to match what was going on there.
One thought however: The BitcoinFilled and BitcoinOutlined buttons do have optional radius parameters which would enable you to make the Capsule style. Not sure if that was clear, or changes anything with your thinking in case you want just highlight that more in the readme for people wanting the capsule style.

I think my only thinking on it was just the difference between the cornerRadius on BitcoinFilled expects a CGFloat that is a hardcoded value vs BitcoinCapsuleFilled just uses the Capsule shape where the corner radius is automatically chosen for someone as half the length of the rectangle’s smallest edge (benefits: always perfectly rounded, adjusts dynamically, etc). But let me know if I'm totally thinking about that wrong -or- its not enough of an upgrade/upside.

I think many people probably like/default to a capsule shape today, so not bad thinking.
One option could be to modify the existing ones with a boolean parameter capsuleShape (or similar) that just sets the radius to half the height? That should not be much code change.
Or maybe that is starting to overload the whole thing.

One option could be to modify the existing ones with an optional boolean parameter capsuleShape (or similar) that just sets the radius to half the height? That should not be much code change.

Ahhh yeah that's a nice idea, I like that. Let me mess around with that to see what it looks/feels like!

Added a PR #76 for this


Fix testing logic

In a previous change (https://github.com/segment-integrations/analytics.js-integration-segmentio/pull/49), I added table driven tests to ensure our tests pass when retryQueue enabled or disabled. However it unintentionally disabled these tests. Fixing the logic enables them again.

Merged since this is just test changes - but let me know if you have any questions/concerns!


Crashes if posting with x-www-form-urlencoded

The server crashes (unfortunately with no log) if posting with x-www-form-urlencoded.
See:

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

multipart/form-data works fine

Reproduced problem with exact request used in bug report:
C:\Data\Github\juice-shop\node_modules\sequelize\lib\utils\parameter-validator.js:76
    var _value       = (value === null) ? 'null' : value.toString()
                                                         ^

TypeError: value.toString is not a function
    at validate (C:\Data\Github\juice-shop\node_modules\sequelize\lib\utils\parameter-validator.js:76:58)
    at Object.module.exports.check (C:\Data\Github\juice-shop\node_modules\sequelize\lib\utils\parameter-validator.js:30:10                              )
    at Object.module.exports.validateParameter (C:\Data\Github\juice-shop\node_modules\sequelize\lib\utils.js:580:31)
    at module.exports.DAOFactory.create (C:\Data\Github\juice-shop\node_modules\sequelize\lib\dao-factory.js:688:11)
    at handleResourceCreate (C:\Data\Github\juice-shop\node_modules\sequelize-restful\lib\router.js:324:8)
    at Router.handleRequest (C:\Data\Github\juice-shop\node_modules\sequelize-restful\lib\router.js:67:34)
    at C:\Data\Github\juice-shop\node_modules\sequelize-restful\lib\index.js:10:16
    at C:\Data\Github\juice-shop\node_modules\sequelize-restful\node_modules\connect\lib\middleware\bodyParser.js:56:25
    at IncomingMessage.<anonymous> (C:\Data\Github\juice-shop\node_modules\sequelize-restful\node_modules\connect\lib\middl                              eware\urlencoded.js:73:11)
    at emitNone (events.js:67:13)

npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v4.2.3
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node app`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node app'.
npm ERR! This is most likely a problem with the juice-shop package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node app
npm ERR! You can get their info via:
npm ERR!     npm owner ls juice-shop
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Data\Github\juice-shop\npm-debug.log

Seems to have same underlying problem as #131.

Tried sequelize-restul-extended but it causes the same crashes when a non-empty POST request is sent via x-www-form-urlencoded.

Fixed in upcoming v6.0.0 release through #167.


cb.apply is not a function

Hi we are getting this error recently on our CI as well as other Linux machines in the office.
/home/travis/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/graceful-fs/polyfills.js:287
      if (cb) cb.apply(this, arguments)
                 ^
TypeError: cb.apply is not a function
    at /home/travis/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/graceful-fs/polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:154:5)

Not too sure how to debug this, happy to provide more details.

nevermind this is a duplicate of #158


Feature/kubeci

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: metalmatze:x: chaosaffe:x: guusvwYou have signed the CLA already but the status is still pending? Let us recheck it.

Awesome work! Hope this gets into Drone soonish ;)

PR was opened in error


fix(ci): [agent6] Backport .github information from main

What does this PR do?
Backport .github information from main:

CODEOWNERS file
workflows

Motivation
Have a similar PR experience on agent6 branch as on main. Use up to date and secure github actions.
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


Adding author_* and thumb_url features for attachments

As per attachments (https://api.slack.com/docs/attachments) you are now able to define Author related fields, and have a Thumbnail URL (close functionality to image_url, except for formatting differences).
These changes extend the Attachment model to handle author_name, author_link, author_icon and thumbnail_url

Could you fix the indentation (2 spaces) and modify the test suite so that it passes (just uses phpunit). Afterward, squash your commits and I'll take a look :+1:

Sure can, I used the github editor to do the changes as my IDE was having a spasm. I was hoping this would use the correct standard, but apparently not.

Sweet. Best to make sure it actually works too, maybe provide a screenshot? If you're not totally comfortable with all that, I can definitely get this sorted on the weekend.

Can confirm this works, as I'm using it in production right now:

Don't have time to do tests and such today sorry.

That looks sweet. If you can get the indentation fixed up, and modify these tests:

https://github.com/maknz/slack/blob/master/tests/AttachmentUnitTest.php#L61 - add the new fields with dummy values to the array, under title_link
https://github.com/maknz/slack/blob/master/tests/ClientFunctionalTest.php#L32 - add the new fields here too, under title_link
https://github.com/maknz/slack/blob/master/tests/ClientFunctionalTest.php#L73 - same here

Then we should get a green light from Travis, and I'll merge and tag a release :+1: Thanks for your time on this.

Success :) I'll push the updates and squash the commits.

Ignore this pull request, I've cocked up and didn't branch which is making rebase/squash hard.
I'll re-do pull request.


If someone give me a call , the music will stop playing, and play button point does not move

Fixed: https://github.com/DIYgod/APlayer/commit/0b0be17c70ac93de51e5599b603486df3f8fa104


[HELP] Class admin.auth does not exist

Hi, after laravel upgrade to 6.4 strange error appears:
ReflectionException in Container.php line 681: Class admin.auth does not exist
Please, help to find out what's wrong.

Removed 1.3.x version and installed 1.4.x-dev. Error disappeared. But now i've faced with bad ajax requests when deleting items from grid. All requests goes to: "http://admin/comments/7" without domain specified.

Found a bug in "/{$this->getResource()}/". First slash not needed here, it couses url like "//admin/comment/".
`$('.grid-row-delete').click(function() {
var id = $(this).data('id');
if(confirm("{$confirm}")) {
$.post('/{$this->getResource()}/' + id, {_method:'delete','_token':'{$token}'}, function(data){
        $.pjax.reload('#pjax-container');

        if (typeof data === 'object') {
            if (data.status) {
                toastr.success('{$successMsg}');
            } else {
                toastr.error('{$faildMsg}');
            }
        }
    });
}

});`

Fixed now, update this package:
composer update encore/laravel-admin:1.4.x-dev


Self Managed Nodegroup ami_type support

Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform?

Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.
Currently managed node groups have the ability to specify ami_type so it'll pick the appropriate one (as viewed in the module's variables.tf file)  The self-managed does not have this, we can just specify an ami-id only, which is bad if we want to do anything outside of the default ami's.
Describe the solution you'd like.
The ability to use the same ami types that are available to the managed node groups.
Describe alternatives you've considered.
hard coding the ami (not a fan)
re-writing parts of my own modules to do the same thing.
Additional context

The AMI type is a function of the EKS managed nodegroups and is not available for self-managed. Howeve, you can use the AMI data source to query the respective AMI based on the name pattern and Kubernetes version https://github.com/terraform-aws-modules/terraform-aws-eks/blob/a2fb28e63e923b1c46ae1f611c237cf1d47e96b4/examples/self_managed_node_group/main.tf#L283C1-L301


Metadata cache exiftool singleton

Fixed all the test errors.  Update unit tests to setup/teardown ExifTool singleton.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.amaleki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@amaleki could you sign the CLA for this?

CLA fixed.

Thanks! Looks great. I made a couple very minor changes and submitted a PR against your branch. Can merge this PR once you merge mine.

Thank you for the feedback.  Changes looked good.  Approved and Merged.


Add Some Icon For This  Folder Names List (in description ) Pleeeeeeeeeeeeeeeeeeeeeeeeeeeeeas

Manager
Management
Consumer
Behavior
Localization
Configurations
Interceptors
Db (database)
Identity
Real
Installers
Others
Projections
Reflection
Response
Optimistic
Concurrency
Ids
Serialization
BackgroundWorkers
Aggregates

I wouldn't know what icons to add. If you want to provide new association please fork https://github.com/mallowigi/iconGenerator and add new Icons


Scheduler start_cron doesn't free up runners after training is finished

"Resolved" - scheduler.processed has odd behavior when interacting with scheduler.reset() and stop_cron()/start_cron() cycles.


Add filesystem/gather platforms

Not updating release notes draft because this is bugfix to an unreleased feature.


Use default region for CloudFormation stack

Since a CloudFormation stack is region-specific, we avoid using the
user-set flag and hard-code a default AWS region. This ensures that the
stack is queried always from the same region, regardless where the
cluster is being created.

@vkareh this would change depending on the users local config. Should we instead hard code the creation of osdCcsAdmin to a particular region?

@jharrington22 - done, this is now using us-east-1 as the default for all cloudformation requests

@jharrington22 - I'm getting this in ci/prow/lint
golangci-lint run
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
make: *** [lint] Error 4
2020/08/31 16:50:34 Container test in pod lint failed, exit code 2, reason Error
2020/08/31 16:50:34 No custom metadata found and prow metadata already exists. Not updating the metadata.
2020/08/31 16:50:34 Ran for 6m14s
error: some steps failed:
  * could not run steps: step lint failed: test "lint" failed: the pod ci-op-qcxz49pj/lint failed after 2m12s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 2, reason Error

Any ideas?

/retest

@jharrington22 @igoihman @NautiluX - this is now ready, I fixed some failing tests in a different PR and merged it, now the pipeline here succeeds (although not sure if entirely related). I'd like to merge this today, rebase https://github.com/openshift/moactl/pull/94 with the changes from here, and then cut a new release if possible.

/lgtm


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

test/statsCases/resolve-plugin-context/node_modules/abc/package.json
test/statsCases/resolve-plugin-context/node_modules/abc/.snyk

Vulnerabilities that will be fixed
With a Snyk patch:

Severity
Priority Score (*)
Issue
Exploit Maturity

479/1000  Why? Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)  npm:semver:20150403
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@273f3f8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   86.86%
=========================================
  Files             ?      279
  Lines             ?    17816
  Branches          ?     4231
=========================================
  Hits              ?    15476
  Misses            ?     2340
  Partials          ?        0

Flag
Coverage Δ

basic
86.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


I a getting this error on adding the pod

module CommonCrypto [system] {
header "/Library/Developer/CommandLineTools/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/include/CommonCrypto/CommonCrypto.h"
export *
}

This looks like it might be the same issue as #165. Try running the following command in the terminal to reset the default developer directory path:
sudo xcode-select -s /Applications/Xcode.app

Thank you for the help.
Thank you,
—————————————————————————————————
Thooyavan Manivaasakar,
Bangalore.
<EMAIL_ADDRESS>(+91)<PHONE_NUMBER>
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use , disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message(S).

On 17-Apr-2018, at 6:21 AM, Matt Rubin<EMAIL_ADDRESS>wrote:
This looks like it might be the same issue as #165 https://github.com/mattrubin/OneTimePassword/issues/165. Try running the following command in the terminal to reset the default developer directory path:
sudo xcode-select -s /Applications/Xcode.app
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mattrubin/OneTimePassword/issues/171#issuecomment-381794768, or mute the thread https://github.com/notifications/unsubscribe-auth/AQNtqzTcnIHwcdFA6uklytG7S4lAmURAks5tpTyogaJpZM4TWmD2.


integration test for namespaces

We should have an integration test that uses a new namespace. This is easy to break (e.g., forgetting to pass through a namespace).

I think internally we should pull out namespaces from the options generators wherever we can because setting a namespace isn't really an option for most of our stuff except on the CLI side.


Cannot parse *.graphql with any comments in it

If I try to run generateDebugApolloIR when I have a graphql file that is fully commented such as this:
# fragment TestFragment on TestData {
#        id
#        type
# }

I receive the error: Syntax Error: Unexpected <EOF>
I also cannot run the generation command on the following either (I get the same failure):
fragment TestFragment on TestData {
#        id
       type
}

It would be nice to have the ability to keep the commented graphql files in the codebase without needing to remove them entirely. It also makes sense to be able to add comments in these files.

Pls try the latest 1.1.0 version.


Migrate remaining legacy templates

Description
Migrates remaining pages into the new design system templates.

Error 404
Downloads
Versions
Artifacts
Artifacts by version
Blog posts
Partner pages
Code of conduct
Source Code
Removes Django Software Foundation copy from footer.

Removes various obsolete SCSS, include templates, and layout templates.
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

This part of the downloads page looks a little funky. Is this just a matter of adding a few spaces?

This part of the downloads page looks a little funky. Is this just a matter of adding a few spaces?

I took the liberty of adding a linebreak in there. Looks better.


Closes #2395: Re-vamp of get-started page

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

@pharmaverse/admiral please can you take a look at the new "Programming Concepts and Conventions" vignette and add your feedback here? I'm interested in knowing if you find the content useful and/or if something is missing/superfluous.

Could you also run the styler for the same concepts_conventions.Rmd file as it currently fails?
Thanks.

@Fanny-Gautier thanks, I've done all of this now (I hadn't yet checked the CICD stuff as I'm waiting to get feedback from the rest of the team but I fixed them now)

A good opportunity for @pharmaverse/admiral_comm !!  this is for the "Get Started" vignettes and trying to improve the ADaM examples and provide more information on programming concepts and conventions in admiral.

I am not sure if it was a good idea to split the "Get Started" page. To me it looks more confusing than before. For example why is "Derivations", "Input and Output", and "Computations" in the "walkthrough" but "Handling of Missing Values" and "Argument Conventions" in "Programming Concepts and Conventions"?

I believe the intention was to "unbury" the exprs() stuff from the Get Started page, which we are doing.  It is a pretty critical part of programming workflow and from my understanding very unique to admiral.  I don't use this in any other packages.
However, I understand that the content for each vignette might be a bit wonky. Let's chat on Wednesday about what to have in each vignette.  @Fanny-Gautier and @manciniedoardo thanks for breaking up and giving us something to look at more in depth!!

Hi @Fanny-Gautier - did you have time to make the outline in the Issue?  I think this will be helpful for us to agree on to minimize back and forth conversation on content.

Hi @Fanny-Gautier - did you have time to make the outline in the Issue? I think this will be helpful for us to agree on to minimize back and forth conversation on content.

Hi @pharmaverse/admiral here is the outline of the 2 vignettes which have been created and updated: Vignette: Simple ADSL & ADVS Walkthrough

Main Idea
Can the main idea have some discussion on adding variables versus adding rows and in this vignette we showcase those two concepts with ADSL (adding variable), ADVS (adding records).
ADSL example
o	Load Packages and Example Datasets
o	Derive Treatment Variables (TRT0xP, TRT0xA)
o	Derive/Impute Numeric Treatment Date/Time and Flag Variables (TRTSDTM, TRTEDTM, TRTSTMF, TRTETMF)
o	Derive Date Variables from Date/Time Variables (TRTSDT, TRTEDT)
o	Derive Treatment Duration (TRTDURD)
o	Derivations
Is this a discussion on general Derivations in admiral?  Could we just move it to programming vignette or drop it.
o	Input and Output
Can we move to  programming vignette
o	Computations
I'm a bit unsure if this is really needed to be highlighted anywhere in our Get Started documents?
ADVS example
o	Load Packages and Example Datasets
o	Derive Numeric Date and Analysis Day (ADT, ADY)
o	Assign PARAMCD, PARAM, PARAMN, PARCAT1
o	Derive Results (AVAL, AVALC)
o	Derive MAP Parameter
Starting a Script
Support
See also

Vignette: Programming Concepts and Conventions

Introduction
{admiral} Functions and Options
Handling of Missing Values
Can we bump to before Common pitfalls
Argument Conventions
exprs()
o	What is exprs()?
Common pitfalls
o	1. Mistakenly passing something that isn’t an expression to an argument
o	2. Forgetting that expressions must be evaluable in the dataset
See also

I'm not sure if this is the right place for this note, and haven't been able to find the ADVS example, but the step regarding derivation of results (AVAL and AVALC) listed above caught my attention.   Since the overwhelming majority of vital signs recorded have numeric results, it's unusual to need AVALC in ADVS, since AVALC should only be populated when a parameter is qualitative in nature.  In addition, the only time both AVAL and AVALC should be populated on the same record is when there is a code-decode relationship between them, or for qualitative parameters when AVAL is used for controlling the sort order of the responses.  This is a very common ADaM implementation issue, so I just wanted to make sure it didn't occur in the examples here.  For more information, please see Section <IP_ADDRESS> of the ADaMIG v1.3 (also present in earlier versions of the ADaMIG).
Thanks,
Nancy

I'm not sure if this is the right place for this note, and haven't been able to find the ADVS example, but the step regarding derivation of results (AVAL and AVALC) listed above caught my attention. Since the overwhelming majority of vital signs recorded have numeric results, it's unusual to need AVALC in ADVS, since AVALC should only be populated when a parameter is qualitative in nature. In addition, the only time both AVAL and AVALC should be populated on the same record is when there is a code-decode relationship between them, or for qualitative parameters when AVAL is used for controlling the sort order of the responses. This is a very common ADaM implementation issue, so I just wanted to make sure it didn't occur in the examples here. For more information, please see Section <IP_ADDRESS> of the ADaMIG v1.3 (also present in earlier versions of the ADaMIG).
Thanks, Nancy

Excellent point Nancy!! We do not follow this in our examples and we should, e.g. https://pharmaverse.github.io/admiral/articles/bds_finding.html#aval @pharmaverse/admiral could someone collect all the places that need an update and place into an issue

On the "Get Started" page I would present the main features/concepts of admiral. For each feature I would just provide a short description and a simple example such that the user gets an idea of it. For details I would link to the reference and user guides.
I would remove the ADSL and ADVS example because it requires too much space and is more focused on ADSL and ADVS concepts than admiral concepts.
What about the following outline for the "Get Started" page?

Main Idea: modular approach
Derivations: add variables or records, naming convention, piping

Adding Variables: one example, introduce common arguments like dataset_add, by_vars, new_vars
Adding Records: one example, introduce common arguments like set_values_to

Argument Conventions
Starting a Script
Higher Order Functions
Computations
Filter Functions
See Also

I would move the "Programming Concepts and Conventions" vignette to the "User Guides". Then it is clear that it must not be read for getting started. It could have the following outline.

Introduction
Input and Output
{admiral} Functions and Options
Handling of Missing Values
Expressions in Scripts

Quoting and Unquoting: introduce expr(), exprs(), !!, and !!!
Common pitfalls

What do you think?

I found that ADSL and ADVS Walkthrough were redundant with the User Guides - even if they are simplified. I am ok with your approach.

I like this outline a lot!!  Thanks @bundfussr.
@Fanny-Gautier when do you think you could have it ready by?  We have a release on June 3rd and I think we should review thoroughly as this will be first point of contact for a lot of users!!
Thanks again for driving this forward!!

thanks @bundfussr, @bms63, @Fanny-Gautier for the discussion!
I am happy with the proposed new outline by @bundfussr. I will move the concepts_conventions page under user guides and make the suggested changes. Will try finish by end of next week. Happy for @Fanny-Gautier to cover the Get Started side of the update.
I am leaning towards keeping all tthe work within this PR as we have already made quite a lot of changes in this branch, which will be quite difficult to unravel. Though this will turn into a massive PR 😱 !

@bundfussr I have reworked the concepts and conventions vignette after your through review. please could you take a look at it again? thanks

@bms63 @bundfussr @Fanny-Gautier @Lina2689 as discussed last week, I have completed the revamp according to the discussing in #2395 and this PR, taking over from @Fanny-Gautier and @Lina2689's start. The PR is now ready for review.

Done?

unless some sneaky hobbitses notice something else!!
I'm just joking please review to your heart's content  - let's make this perfect!😆

unless some sneaky hobbitses notice something else!!
I'm just joking please review to your heart's content - let's make this perfect!😆

I promise I don't look like that in real life 🙈🤣
Trying to complete my review within the next hour 😉


LED Config support

Led configs files for BlueRidge system 2s2u, 2s4u

Blueridge has 3 flavours of system, 2S2U, 2S4U and 1S4U. Can you create the missing one.
Can you update the configs/config_map.json with the blueridge json details.

can you please update the PR heading with system name

Blueridge has 3 flavours of system, 2S2U, 2S4U and 1S4U. Can you create the missing one.
Can you update the configs/config_map.json with the blueridge json details.

Done

can you please update the PR heading with system name

Done


⚠ API - Lens has degraded performance

In 431e53c, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 399 ms

Resolved: API - Lens performance has improved in cb458ce after 9 minutes.


MON-3971: Remove MetricsServer feature gate

cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need
to be behind feature gate anymore.

/retest

/retest

/payload 4.17 nightly blocking

Thanks!
Maybe we should also clean it in payload-command/render/renderassets/rendered_manifests_test.go?
/hold
Let's wait for https://github.com/openshift/api/pull/1780 to set the pace as there are still discussions around "featuregates removing" https://github.com/openshift/api/pull/1780#issuecomment-1993986689

FYI https://github.com/openshift/api/pull/1780 was merged.
Reading the latest discussions, I think we should wait until version 4.19 to merge this one.

Feature was promoted to GA 4 months ago in 4.17
/lgtm

@JoelSpeed could you please review again, rebased the branch

/hold cancel

/retest-required

/lgtm

/lgtm


Limit usage to newer devices

Add it to the readme that this should be limited to newer devices.
Add that limit to the sample app.

Just to clarify, you mean restricting it to devices that can run iOS 11?

As Per ARKit Documentation, it requires an iOS device with an A9 or later processor.

Important: If your app requires ARKit for its core functionality, use the arkit key in the UIRequiredDeviceCapabilities section of your app’s Info.plist file to make your app available only on devices that support ARKit. If AR is a secondary feature of your app, use the isSupported property to determine whether to offer AR-based features.  (source)

Seems like the isSupported way would be the most flexible since someone might using this for a secondary feature or mode in an app instead of the entire app. This would give older devices the ability to still run non-AR functions of an app that uses this.

Hello people, how are you? Without a doubt, it is an excellent library, thank you for sharing with the community, I am new to AR development, and I am amazed at the possibilities.
So, I'm trying to include several location points, but I did not have success, could give me some help, right now, thank you.


Support Debug Context Menu: Jump To Line

I have too many editor context menu items, if i want to jump to line when debuging my program, i have to scroll and choose the action Jump to cursor or  Run to cursor
I found there is an action Run to line at breakpoint context menu, it is easier to be used. how about adding an action Jump to Line as well as Run to line

https://github.com/microsoft/vscode/pull/204526

Sorry, not sure what you mean by "jump to line", can you explain more?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[Bug] Issue with table with capital letters (postgres)

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
I'm trying to add a source table which has a name with capital letters. When running dbt after adding the source config, I get the following error :
 Snapshot (...) depends on a source named 'airtable_airbyte.transport_dossiers_tblxtZqELdrIqdcUq' which was not found

I believe this is because postgres requires double quoting when table has capital letters
Expected Behavior
I expect the source to be detected normally, even though it has capital letters in the name
Steps To Reproduce

With dbt 1.7, using postgres
Create a table with capital letters in the name
Try to add it to a model and run it

Relevant log output
No response
Environment
- OS: MacOs 14.2
- Python: Python 3.11.2
- dbt: 1.7.7

Which database adapter are you using with dbt?
postgres
Additional Context
No response

Hi @qmoret - I think you should be able to solve this by using the quoting: config in your source yml file. Here is a link to the documentation.
If this still doesn't work, could you share an example of your yml file?
Thanks!

Hi @graciegoheen , that works like a charm, thanks !


build: npm workspaces

Overview

Migrate to NPM workspaces - taking over https://github.com/awslabs/iot-app-kit/pull/203
Fix typescript errors in component tests
Fix https://github.com/awslabs/iot-app-kit/issues/227

Legal
This project is available under the Apache 2.0 License.

it looks like it doesn't have lock files for all the packages?

what was the fix for https://github.com/awslabs/iot-app-kit/issues/227 ?

what was the fix for #227 ?

it looks like it doesn't have lock files for all the packages?

Good catch - the lockfile in core doesn't need to exist

what was the fix for #227 ?

There was a type mismatch when passing props to the related table react component (no type-safety there). You could find the error by de-obfuscating the react error through the dev console (running the test in dev mode).

I rewrote the iot-resource-explorer cypress tests - hopefully this resolves #227