geojson-vt integration

For large datasets, Openlayer's GeoJSON performance is poor compared to geojson-vt. There should be a way take geojson-vt output an feed it into Openlayer easily. Too bad there are no working example for geojson-vt and ol3 integration. Are there any efforts on to improve big data capabilities of ol3 to handle large GeoJSONs using a librray similar to geojson-vt ?

It should be straightforward and easy to use geojson-vt generated tiles with ol.layer.VectorTile and ol.source.VectorTile. Probably with a custom tileLoadFunction on the VectorTile source.
If someone wants to give it a try, we'd accept a pull request for an example.

@ahocevar geojson-vt getTile method returns raw Mapbox feature and we cannot parse it because appropriate method are not part of OpenLayers API. How we can cope with it?

@drnextgis readGeometry function is part of the api for some others format so I think you can propose a PR making this function part of the api.
Remove the @private annotation and just add @api annotation to the function doc like this:
/**
 * @param {Object} rawFeature Raw Mapbox feature.
 * @return {ol.geom.Geometry} Geometry.
 * @api
 */
ol.format.MVT.readGeometry_ = function(rawFeature) {

then rename ol.format.MVT.readGeometry_ to ol.format.MVT.readGeometry

Before deciding on a pull request, I'd like to see the code you are using. I'm sure you can also get all features instead of just a geometry from geojson-vt.

Something like this:
> tileIndex = geojsonvt(geojsonObject);
> JSON.stringify(tileIndex.getTile(0,0,0).features);
"[{"geometry":[[[-64,460],[4160,460]],[[-64,3636],[4160,3636]]],"type":2,"tags":null},{"geometry":[[[-64,460],[4160,460],[-64,460]]],"type":3,"tags":null},{"geometry":[[[-64,1551],[4160,1551]]],"type":2,"tags":null},{"geometry":[[2048,2048]],"type":1,"tags":null},{"geometry":[[[-64,460],[4160,460]],[[-64,3636],[4160,3636]]],"type":2,"tags":null},{"geometry":[[[-64,460],[2048,460],[2048,2907],[-64,460]]],"type":3,"tags":null},{"geometry":[[[-64,1551],[2048,1551]]],"type":2,"tags":null},{"geometry":[[[-64,460],[4160,460]],[[-64,3636],[4160,3636]]],"type":2,"tags":null}]"

The above returns GeoJSON, not PBF. You should be able to parse that with ol.format.GeoJSON#readFeatures().

This is not valid GeoJSON, type member should be string, but is an number instead.

And how would ol.format.MVT help you here?

I thought that getTile feature's format is the same as VectorTileFeature here. But it looks like geojson-vt returns feature in custom format and we can not use existing OpenLayers formats for reading them.

These features look different indeed. However, it looks trivial to turn those features into valid GeoJSON by using JSON.stringify() with a replacer function.

This (typescript code) works for me (mostly). However, I see some erratic behavior - with polygons disappearing as I zoom and pan. I guess there is some configuration issue. But performance on even moderate size geojson is much improved over native GeoJSON of ol3. It would be nice if it always worked.
let census_style = new ol.style.Style({
            	stroke: new ol.style.Stroke({
                color: 'blue',
                lineDash: [4],
                width: 3
            }),
            fill: new ol.style.Fill({
                color: 'rgba(0, 255, 255, 0.3)'
            })
        },
    );

new ol.layer.VectorTile({source: this.vectorSrc,
                    renderOrder : function(feature1: ol.Feature, feature2: ol.Feature): number {
                                            return 1
                                    },
                        style: census_style
                    })

        this.vectorSrc = new ol.source.VectorTile({
        renderMode: 'image',
        preload: Infinity,
        format: new ol.format.GeoJSON(),
        projection: 'EPSG:3857',
        tileGrid: ol.tilegrid.createXYZ({maxZoom: 12}),
        tilePixelRatio: 16,
        url: '{z}/{x}/{y}',

        tileLoadFunction : (tile:any, src:any) => {
            tile.setLoader(() => {

                let coord = tile.getTileCoord();

                let z =  coord[0];
                let z2 = 1 << coord[0];
                let tx = coord[1];
                let ty = -coord[2]-1; //

                if (this.tileIndex) {

                    let tile1 = this.tileIndex.getTile(coord[0], tx, ty)

                    if (tile1){

                        let features = tile1.features;

                        let ol_features: ol.Feature[] = [];

                        for (let i = 0; i < features.length; i++) {
                            let feature = features[i];

                            let type = feature.type;

                            let points: ol.Coordinate[][] = [];

                            for (let j = 0; j < feature.geometry.length; j++) {

                                let geom = feature.geometry[j];

                                let pt: ol.Coordinate[] = [];
                                for (var k = 0; k < geom.length; k++) {

                                    let x = (geom[k][0] / extent + tx) / z2;
                                    let y = (geom[k][1] / extent + (ty)) / z2;
                                    let c = [((x - 0.5) * 2) * 6378137 * Math.PI, -((y - 0.5) * 2) * 6378137 * Math.PI];
                                    pt.push([c[0], c[1]]);

                                }
                                points.push(pt);

                            }

                            ol_features.push(new ol.Feature({
                                    geometry: new ol.geom.Polygon(points),
                                })
                            );

                        }

                        tile.setFeatures(ol_features);
                        tile.setProjection(ol.proj.get('EPSG:3857'));
                    }
                }
            });
        }
    });

   this.map.getView().on('change:resolution', (e:any) => {
                this.vectorSrc.refresh();
            });

I've made example of integration of geojson-vt and OpenLayers here https://github.com/drnextgis/ol3/commit/1a6caea14c466f366d78cdf62ae0e7b4b4210272. But I have one problem: when I run this example using development server (make serve) all works fine, but if open example in jsfiddle (click Edit button) it doesn't work, example.

There was one bug in my code:
   tileLoadFunction : (tile:any, src:any) => {

        // populate features here

          tile.setLoader(() => {

                tile.setFeatures(ol_features);
                tile.setProjection(ol.proj.get('EPSG:3857'));

            });

ie. setLodaer should only be called at least and at most once.
With that it works 100% of time. No need to refresh source on zoom change.
I also got @drnextgis code to work with one simple change:
replace:
 var tileCoords = url.split('/');
  var x = parseInt(tileCoords[0], 10);
  var y = parseInt(tileCoords[1], 10);
  var z = parseInt(tileCoords[2], 10);

with:
           let coord = tile.getTileCoord();
            let z =  coord[0];
            let z2 = 1 << coord[0];
            let x = coord[1];
            let y = -coord[2]-1; //

with that it works.
My issue is now is if I switch to webgl renderer - I get vectorSuurce.loadFeatures  not a function.
For now I am very happy that we can get ol3 to work with geojson-vt. Hurray !

I have updated @drnextgis's fiddle to work 100%: http://jsfiddle.net/qpzudgg8/2/.

@ahocevar thanks for help! I've made PR https://github.com/openlayers/openlayers/pull/6381 with your updates.

How to make geojson-vt work above 24 zoom levels or what could be the alternative?


Ready for 1.0.0?

Are we ready to make that 1.0.0-alpha.3 a final? It's been out quite a while and seems fairly stable, no?

Hi, sorry but we have still some issues that prevent us to release the first RC... I have no time to work on these issues at the moment and I hope to find some in the next weeks. Any contributions to close the remaining issues assigned to the Project "v1" are more than welcome tho.

Especially, this issue is the ones that is blocking a lot of PRs:
https://github.com/FezVrasta/popper.js/pull/92


The conversion of multidimensional arrays does not result in ListOf...

If an array has the ValueRank 1, it will converted to a ListOf. But if the ValueRank is higher, it won’t be converted to a ListOf.

Agreed to close in OE meeting


Use rexrex for regular expressions

rexrex just makes it easier to understand, debug, and digest regular expressions. In this case you can make comments on individual parts, and easier understand parts that can be reused (see space) or even removed.
I only converted on regular expression to use rexrex but i can do the others if you like this style. If you don't, please close (:
This would also be beneficial for #13's regex if you go that route.

Looks pretty cool 👌


Only close Selector it not already closed

Refer issue: https://github.com/celluloid/reel/issues/210

Thanks @rjattrill. This fixes your test case, in every case? I re-ran some of the tests that were failing, which are not related to your change. Now it's green.
The code looks good. The next possible failure here is if monitor somehow becomes NilClass or no longer responds to closed? for some other reason... but that's a lot less likely than the issue you're addressing, and beyond the bounds of reasonable behavior. But, there's also the cost of two calls instead of one... in the reactor. The effect on any benchmark for non-shutdown instances is probably negligible.
That has me thinking: at shutdown do we catch this and silence it?
Your way would have the benefit of solving the issue without releasing a new Reel gem, but it is at 0.6.0 but unreleased; it'd be possible to sneak this into there if that ends up being most performant.

Yes, @digitalextremist, this patch does fix my issues.   Thank for for fixing the failing test cases, I was hoping that they weren't a result of my patch.
Perhaps a combination of both approaches would be warranted.   Try using unless monitor.closed? but if we still get exceptions of known type, catch them and clean up the error message going out.   Do you think monitor.closed? would ever block?

I am going to merge this, it looks good. Further issues can be addressed in another PR.

:+1: ( @rjattrill Celluloid::IO commit! )

Thank you @ioquatix and @digitalextremist

Awesome, yeah I'll try to work on celluloid-io a bit over the next two weeks so we can do an update. There are also some outstanding PRs on Celluloid which should probably be merged. Good work everyone.


Update kubectl overview page - update list of available operations

Fixing issue with missing operations available in current version of kubectl.
The issue started based on the following statement, which is not accurate: "The following table includes short descriptions and the general syntax for all of the kubectl operations: ..".
The list of operations supported by the current version of kubectl v1.18 is bigger.
It's mainly one of the following 3 options:
a. either update this page manually, with each upgrade ( for now, this is the proposal of current PR )
b. or update the description to say something like "The following table includes short descriptions and the general syntax for some of the most important kubectl operations: .."
c. or find a way to generate this table dynamically, during the CI/release build, based on the kubectl command itself. A nice option would be to reuse the 'kubectl --help' output.. so either to enhance it (as it doesn't fit the need exactly), or to have a separate flag to generate this sort of output needed here. Reuse is the key.
For now, the proposed fix is to go with option a).
The proposed solution is to add the missing options and short description for each of them.
Kubectl version used was 1.18.2 (GitCommit:"52c56ce7a8272c798dbc29846288d7cd).

dummy comment, trigger retest of CLA

/assign @kbarnard10

Thanks for the PR @sharet-adl, I believe this documentation is generated per release. @kbhawkey and @tengqm will be able to confirm.
If it is missing, we might need to update the scripts in https://github.com/kubernetes-sigs/reference-docs

Em. I dont think we have a generator for the overview page. @kbhawkey WDYT?

Hi. No this page is not auto-generated.
I would prefer to rely upon an overview page that is sourced from
the information in the kubectl code.
If the command descriptions in this file add value, perhaps the content could be
added to the kubectl code in kubernetes/kubernetes.
I'd like to see more content generated from the kubectl source code.

@kbhawkey: this enhancement is what I have suggested as point c)
c. or find a way to generate this table dynamically, during the CI/release build, based on the kubectl command itself. A nice option would be to reuse the 'kubectl --help' output.. so either to enhance it (as it doesn't fit the need exactly), or to have a separate flag to generate this sort of output needed here. Reuse is the key.
This enhancement could be taken as a separate task.
As a quick fix, I have proposed for now the approach a), just fixing it for current release.

Hi @sharet-adl , Are you able to rebase your branch?
https://kubernetes.io/docs/contribute/new-content/new-content/#merge-conflicts-and-rebasing

@kbhawkey please recheck

Thank @sharet-adl . Changes look good to me.
Page preview:
https://deploy-preview-20848--kubernetes-io-master-staging.netlify.app/docs/reference/kubectl/overview/#operations
Are you able to squash your commits into a single commit?
https://kubernetes.io/docs/contribute/new-content/new-content/#squashing-commits

I have created a new PR - https://github.com/kubernetes/website/pull/20909.
I have re-forked and I Github was not able to reference it automatically.
Is there a way to link this new PR to the current issue ? Was an issue automatically created for the original PR in the first place ?
Thank you

I have created a new PR - #20909.
I have re-forked and Github was not able to reference it automatically.
Is there a way to link this new PR to the current issue ? Was there an issue automatically created for the original PR in the first place ?

Hi, @sharet-adl .
I will look at the follow-on PR. By referencing #20909 here, you have linked the two pull requests.
An issue was not automatically created for you.

Duplicate with #20909.
/close

I have created a new PR - #20909.
I have re-forked and Github was not able to reference it automatically.
Is there a way to link this new PR to the current issue ? Was there an issue automatically created for the original PR in the first place ?

Hi, @sharet-adl .
I will look at the follow-on PR. By referencing #20909 here, you have linked the two pull requests.
An issue was not automatically created for you.

@kbhawkey: was there an issue supposed to be automatically created for it when pressing the 'Edit this Page', or it is like this per design ? PRs with no link to any tracking issue don't seem fine.

@sharet-adl , You are welcome to submit an issue with your suggestions. Thanks!


update(Folder): Upload files by drop on folder target

What this PR does 📖
1. Upload files directly into a target folder with drag and drop from machine
https://user-images.githubusercontent.com/63157656/208176329-1beb085b-65f0-45c5-88fb-82898b461ad1.mov
2. Add possibility to move a file into a folder, even if inside that folder there is a file with same name
https://user-images.githubusercontent.com/63157656/208192590-bfc31ff7-1f52-4b44-8001-d02aac0f92a7.mov
3. Organize some repeated functions in just one file in utils, like upload file, format item size, format item name

Which issue(s) this PR fixes 🔨

Resolve #593

Special notes for reviewers 🗒
@phillsatellite It not work for windows
Additional comments 🎤

Hello my friend! Very cool addition 💥  I found a few small things (I tested these again after pulling your latest changes)
The first one is when you drop the file into a folder, the highlight around the folder does not disappear until the User clicks into that folder
https://user-images.githubusercontent.com/93608357/208196331-a036546d-339f-4177-9f05-beed7856b54c.mov
And the second issue is when you are dragging multiple files into a folder, the little bubble that MacOS has doesn't change according to number of files it will just stay at 0. (If this is something you would like in a new ticket just lemme know and I'll create one 👍 )
https://user-images.githubusercontent.com/93608357/208196559-14dc77d2-9939-40ad-96f9-d5f819d209a4.mov

Changes requested for Darius's comment 👍


[MembersJS] Connect UI element actions with member calls

Uses ported members API methods to handle signin/signup/signout flow from user interaction with CRA elements

Closed in favor of https://github.com/TryGhost/membersjs/issues/3


Upgrading to 0.8.9 with postgres metadata db hangs at 4fa8

OS Ubuntu 14.04 LTS server
PG version 9.1
To reproduce

pip install caravel --upgrade
caravel db upgrade

Seems to be a similar issue to #238, but requiring a different fix (I tried the analogous).

Hi, yeah, I also tried restarting postgres and then the host vms to no avail.
In the end I'm not sure what the problem was -- I could install caravel into a fresh database no problem, so the code seems fine. In the end I took a data-only dump with pg_dump, dropped the database, ran caravel db upgrade on a fresh database, and restored the data.
pg_dump gave a warning that's possibly related to the issue I was having:
xx@xx:~$ sudo -u postgres pg_dump -Fc --data-only caravel > caravel-do.pgdb
pg_dump: NOTICE: there are circular foreign-key constraints among these table(s):
pg_dump:   ab_user
pg_dump: You may not be able to restore the dump without using --disable-triggers or temporarily dropping the constraints.
pg_dump: Consider using a full dump instead of a --data-only dump to avoid this problem.

Restoring with sudo -u postgres pg_restore --disable-triggers caravel-do.pgdb -d caravel worked.


perf(linter): make jsx_key slightly faster

#5585  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


X-Ray Glitch with Nutritive Basin

Observed Behaviour: Blocks behind the basin are not rendered through the glass panel until the nearest non-opaque block
Expected Behaviour: The basin's glass panel behaves like a regular glass block
Steps to reproduce: Place down a nutritive basin
Possible cause: The nutritive basin itself is not considered a non-opaque block, or uses a block model that is considered opaque.
Bug observed in firmalife-1.2.18.jar
Screenshot:

Notes: This bug was observed in a modpack. Due to the ease of reproduction, I decided to report it anyway.

some extra info:
this seems to be an issue with embeddium/rubidium breaking the rendering for nutritive basins and toggling this specific feature on seems to fix it!

the textures are rendered correctly if embeddium/rubidium is not present

while unfortunate i will not be updating 1.18 for something like this


time_b?

Hello!
First of all thank you for such an interesting work!
I have a couple questions:

Could you please elaborate how did you come from this formulae

to having extra term time_b? Where does it come from and what is it's meaning?
https://github.com/raminmh/CfC/blob/3ebaa0307a280c5a9ee8261fdf733ad9bd5636ad/torch_cfc.py#L139

From my understanding, in minimal case of Cfc model, x0 is assumed to be zero:
https://github.com/fullerf/LightningCfC/blob/6dc15040c5a003ae837bcbf24ddda45dd99f8cff/src/LightningCfC/torch_cfc.py#L129
It it always the case though? And is it safe assumption to make?

Thanks, looking forward to your response.

I wonder, if time_b is approximation of w_tau, then why it is not multiplied by time when calculating sigma?


pod push fail

When I push the pod to my pod source, it is required to have commit message information, but the current version does not support the setting of commit message, can you modify it to support it?
Thanks

Note to self: this involves passing --commit-message="$message" to pod repo push.
(docs at https://guides.cocoapods.org/terminal/commands.html#pod_repo_push)

Bumping this up. I assume this isn't a universal requirement for pod repo push, as it's been used for years now without it. Also, in recent versions we haven't been focused on CocoaPods due to the decline in overall use. However, this also seems like a relatively minor change, so we'll see if we can put something minimal into future releases. It would probably a message passed in from gradle config. Anything more complicated would take some design (for example, getting the current commit message from git and passing that).


.zuul: update go version to 1.13.10

Signed-off-by: Wei Fu<EMAIL_ADDRESS>

Hmm..
2020-04-20 16:17:56.318097 | The error appears to have been in '/var/lib/zuul/builds/dd5217ce777b41bb9fcf1456cdd12c72/untrusted/project_0/github.com/containerd/containerd/.zuul/playbooks/containerd-build/run.yaml': line 5, column 19, but may
2020-04-20 16:17:56.318113 | be elsewhere in the file depending on the exact syntax problem.
2020-04-20 16:17:56.318126 |
2020-04-20 16:17:56.318137 | The offending line appears to be:
2020-04-20 16:17:56.318148 |
2020-04-20 16:17:56.318159 |     - role: config-golang
2020-04-20 16:17:56.318170 |         go_version: '1.13.10'
2020-04-20 16:17:56.318181 |                   ^ here

@fuweid too many whitespace change, are you sure? looked like there was a 4 char vs tab thing in the original PR which seemed to be the problem.

@dims it's working! just poked at the live log :)

ah cool @estesp

gotcha @fuweid

ok. go version is back to normal.
2020-04-20 16:39:24.967533 | ubuntu-xenial-arm64 | go version go1.13.10 linux/arm64

020-04-20 16:43:11.646795 | ubuntu-xenial-arm64 | --- FAIL: TestRuntimeWithNonEmptyMaxEnvProcs (0.00s)
2020-04-20 16:43:11.647252 | ubuntu-xenial-arm64 |     shim_test.go:41: the max number CPU should be equal to available CPUs

hmm........

This PR is good; might have a follow-on test issue with CPU awareness of host?
2020-04-20 16:43:11.646795 | ubuntu-xenial-arm64 | --- FAIL: TestRuntimeWithNonEmptyMaxEnvProcs (0.00s)
2020-04-20 16:43:11.647252 | ubuntu-xenial-arm64 |     shim_test.go:41: the max number CPU should be equal to available CPUs
2020-04-20 16:43:11.647377 | ubuntu-xenial-arm64 | FAIL

might have a follow-on test issue with CPU awareness of host?

OK! Thanks @estesp

Codecov Report

Merging #4199 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4199   +/-   ##
=======================================
  Coverage   38.35%   38.35%
=======================================
  Files          90       90
  Lines       12726    12726
=======================================
  Hits         4881     4881
  Misses       7179     7179
  Partials      666      666

Flag
Coverage Δ

#windows
38.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfab78...a9d95b3. Read the comment docs.

CI broken; fix is #4206

ok...openlab is green. but github actions fails 😂

All green now! :)


example showing better generalisation

What is the idea here? Is this supposed to go into the documentation?


sub-module leveldb refer to an invalid reference

git submodule update --init --recursive
fatal: reference is not a tree: 028f9409247be6d3d09a157e8eb347a173afc599
Unable to checkout '028f9409247be6d3d09a157e8eb347a173afc599' in submodule path 'libraries/leveldb'

Refer this commit:
https://github.com/bitsuperlab/bitshares_play/commit/40fa9c8641c7314775f9552c7d3405443645d617


Document project members

As a follow-up to #240, document current Flux Project Members to make it easier for new applicants to find out who could be a sponsor.
Only merge after #240 has been landed.
Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>

I think my review did not count because I haven't been granted Write access here yet after this one merged:

https://github.com/fluxcd/community/pull/233

@fluxcd/core-maintainers Could someone please take a look and update the repo permissions for fluxcd/community?

https://github.com/orgs/fluxcd/teams/core-maintainers Could someone please take a look and update the repo permissions for fluxcd/community?

Done


Adding two ou more songs in Queue at the same time

If you try "play" command two times, and give the options to select the corresponding track, It will choose the two or more of the statements you made. Like the image:

Expected to happen
The previous command "play" be canceled

Corrected in commit https://github.com/diogoditorr/discord-bot-py/commit/6673940fbda8ee6ab26df4ea92b9c15e8a653beb


Fix LayoutParser should throw ConfigExceptions on unknown properties

Fixes #3996
I added a test for https://github.com/NLog/NLog/blob/733ce6e65045fd93de8bad6f9c5c67639e2d0978/src/NLog/Layouts/LayoutParser.cs#L384-L385
And another for https://github.com/NLog/NLog/blob/733ce6e65045fd93de8bad6f9c5c67639e2d0978/src/NLog/Layouts/LayoutParser.cs#L455-L456

It looks great. Only have 3 small nitpicks, and then I think it is ready to merge. Thank you for the hard work.

Closing and re-opening pull-request to tickle the build-servers.

Thanks!


stop pdf

Again, super nitpicky, but I think that the stop pdf should be more square-like, more like a stop button on a TV.

Was not able to test how this looks because I don't have a robot to run


Input Output multiplier model and pq change in CGE

Simple example of an input output price multiplier model

@DPrihardini Thanks!  This looks good.  Sounds like you might want to do a little more with this PR - so just let me know when you are ready and I'll merge this.

@DPrihardini Just went ahead and merged this... working with @rkasher on some refactoring and testing.

@jdebacker Thanks! Sorry, life got in the way, but I did get a bit further with the model code since I created this PL. There is still an issue with being able to replicate the results of the model coded in GAMS. Shall I create a PL for the latest version?


Some issues if vim82 is renamed

Describe the bug:
Some issues with Vim if the vim82 folder is renamed.
To Reproduce:

Download Vim from vim/vim-win32-installer, unpack the archive.
Create a _vimrc file in the same folder as vim82, add a command to it, for example :colorscheme desert.
Run gvim.exe --cmd "language messages English", make sure _vimrc is sourced.
Quit gVim.
Rename vim82 to vim82renamed.
Run gvim.exe --cmd "language messages English" again. Note that this time _vimrc isn't sourced.
Quit gVim.
Rename vim82renamed to [8.2.2920] vim82.
Run gvim.exe --cmd "language messages English" once more. An error message pops up (username edited out):

Error detected while processing C:\Users\<user>\vim\[8.2.2920]
vim82\defaults.vim[120]..C:\Users\<user>\vim\[8.2.2920] vim82\syntax\syntax.
vim:
line   42:
E216: No such group or event: filetypedetect BufRead
Error detected while processing C:\Users\<user>\vim\[8.2.2920]
vim82\menu.vim:
line  185:
E121: Undefined variable: paste#paste_cmd

Click on Ok. gVim opens, but _vimrc isn't sourced again. Also, the main menu and the toolbar are absent.
Expected behavior:
_vimrc should be sourced at steps 6 and 9. There should be no error message at step 9, the main menu and the toolbar should be present.
Environment:

Vim version 8.2.2920
OS: Windows 10 Home 1803
Terminal: GUI.

Additional context:
If somebody wonders why I need to rename vim82: I usually keep several versions of Vim to be able to test new features and locate bugs. Each version (apart from the newest one) is located in a [x.y.zzzz] vim82 folder -- this form is convenient because it lists the folders chronologically.

You might need to update the environment variables $VIM and $VIMRUNTIME as well as the Vim option 'helpfile'.  Untested, but try to adapt the paths in this snippet (from Linux to Windows):
let $VIMRUNTIME = '/new/path/to/vim82renamed/'
let $VIM = $VIMRUNTIME
set rtp-=~/.vim
set rtp^=$VIMRUNTIME
set rtp^=~/.vim
set helpfile=$VIMRUNTIME/doc/help.txt

The name "vim{version}" is special. See :help $VIM for detail.
I often use the following directory structure to test several versions of Vim:
vim-8.2.2929\
├─gvim.exe
├─vim.exe
├─.vimrc
└─runtime\

Thank you, @k-takata  and @lacygoill. I don't know why I was absolutely sure the [x.y.zzzz] vim82 form had worked perfectly earlier. I think the issue can be closed.


Can't setState inside onChange function

Hello,
I'm trying to use this but i'm getting an irrational error. First of all, setting the state of anything throws the below errors (see screenshots) and even if that works, i'm unable to use the "value" property to make it a controlled input as it somehow picks it up itself.  i would appreciate your input.
@material-ui/core  "version": "3.9.0"
react   "version": "16.7.0"

Please see my code below;
<FormControl fullWidth={true} className={classes.formControl}>
                                            <InputLabel className={classes.formControl} htmlFor="phoneNumber">Phone
                                                Number
                                            </InputLabel>
                                            <ReactPhoneInput
                                                regions={["europe", "oceania"]}
                                                name="phone"
                                                onChange={this.handleOnChange.bind(this)}
                                                required={true}
                                            />
                                            <Typography align="left" paragraph={true} variant="subtitle2" color="textPrimary" className={classes.smallBlueFont}>{this.state.errors.phone}</Typography>
                                        </FormControl>

where handleOnChange is
handleOnChange(countryCode, value) {
         console.log(1,value, countryCode)

         this.setState({ anything: true})

     }

Hi @katp4 sorry for the delay in getting to this - is this still an issue or were you able to fix it?


Code watch does not work for Typescript files

If I run yarn run watch on the @semapps/activitypub-components package, and modify a TS file, nothing happens.
If I modify a JS file, the package is rebuilt.
Any idea @Laurin-W or @mguihal ?

Thanks @mguihal ! I added the option on all packages


[animations] Let test time be accurate (originally has 1us shift)

Fixed by https://github.com/flutter/packages/pull/2657, please see description there

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

Logs

Hi @fzyzcjy, should this remain open? I'm asking because the PR linked to this issue has been closed.


Changing resources created format

Description
Added updates to resources_created section for register model, create index, create ingest pipeline and create connector steps.
Changed the format of creating a resource to:
 {
                "_index": ".plugins-workflow-state",
                "_id": "RvEFF4wBKbeLfRazqAdh",
                "_score": 1.0,
                "_source": {
                    "workflow_id": "RvEFF4wBKbeLfRazqAdh",
                    "state": "PROVISIONING",
                    "provisioning_progress": "IN_PROGRESS",
                    "provision_start_time":<PHONE_NUMBER>252,
                    "resources_created": [
                        {
                            "workflow_step_name": "create_connector",
                            "workflow_step_id": "workflow_step_1-amit-test",
                            "connector_id": "TfEGF4wBKbeLfRazCwcp"
                        },
                        {
                            "workflow_step_name": "register_remote_model",
                            "workflow_step_id": "workflow_step_2",
                            "model_id": "T_EGF4wBKbeLfRazCwdx"
                        }
                    ],
                    "provision_end_time":<PHONE_NUMBER>145
                }
            }

Issues Resolved
resolves #173
resolves #136
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Should this PR be against the feature/agent_framework branch?

Should this PR be against the feature/agent_framework branch?

Tbh not sure if we wanted to merge to feature branch and then port to main and 2.x or merge to main then 2.x then feature branch? @owaiskazi19 what was your preferred route?

If the feature's mostly standalone it can go to main and add the feature backport tag.
The problem is this one edits nearly every workflow step and will create a conflict with #215. Much easier to resolve if both PRs are on the same branch and you can rebase. Otherwise we'll end up with the conflicts when we eventually try to rebase main and 2.x with the feature branch.
I guess my position is:

if Improve workflow step execute API #215 gets merged first then target this against same branch and rebase
If this gets merged first, we need to make sure it gets backported to feature branch so I can rebase Improve workflow step execute API #215

Whatever we do, don't merge this to main and #215 to feature branch (without backport) because merge conflicts on cherry-picks are ugly

If you don't think rebasing will be too much work on your end I don't mind making sure I backport this immediately to feature branch, I do want to get this merged soon though and not leave it hanging cause it solves some update issues and has the base line for how to change resources that can easily be copied to new steps.

Should this PR be against the feature/agent_framework branch?

Tbh not sure if we wanted to merge to feature branch and then port to main and 2.x or merge to main then 2.x then feature branch? @owaiskazi19 what was your preferred route?

We can get this on main and then backport to 2.x and feature/agent_framework

@amitgalitz Don't we need to add resources_created for ModelGroupStep or if any else workflow steps if we missed?

Closing in favor of merging to the feature branch first: https://github.com/opensearch-project/flow-framework/pull/231


Commands errors

Running 'az healthcareapis create' command is giving an error.
'create' is misspelled or not recognized by the system.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eeeb2625-ae92-b3c4-1692-6c0bce40123c
Version Independent ID: 349f252b-369a-2837-fc41-f2548b124947
Content: Quickstart: Deploy Azure API for FHIR using Azure CLI
Content Source: articles/healthcare-apis/fhir/fhir-paas-cli-quickstart.md
Service: healthcare-apis
Sub-service: fhir
GitHub Login: @matjazl
Microsoft Alias: cavoeg

@hbalaci Thank you for the feedback. We are actively investigating and will get back to you soon.

@hbalaci Thanks for pointing out the issue. Really appreciate your efforts.
I have created a PR which could take few days to get approved and will then be live in this document. Please let us know if you have any other queries.
You can refer to correct command as below:
az healthcareapis service create --resource-group myResourceGroup --resource-name nameoffhiraccount --kind fhir-r4 --location westus2

@hbalaci We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Fix edge case related to school selection in sign up form

Fixes an issue found by @eireland:

Sign up as a new teacher
When asked to enter a zip code, entered a valid zip code and selected a school. Do not hit enter after this step.
3.Change the zip code (I changed it to another valid zip code. Will have to try with an invalid one.)
Hit Enter on the keyboard.
The Teacher is now registered at a zip code with a high school that doesn't exist in that zip code.

We use ZIP code only to download a list of schools, so this problem wasn't causing any inconsistency in DB. But definitely makes sense to fix it.

I've also pushed some small CSS tweaks to fix issues found by @eireland:
https://concord-consortium.slack.com/archives/portal-lara-dev/p1468605585000167

👍


DSU is booting, but touch screen is dead

on my Mi Fold I can boot all GSIs (A11, A12,A13), but on every GSI the touch screen is dead.
I hope you can find the problem in attached logcat
fold.txt

Unfortunatelly i have no clue

service 'vendor.qmipriod' seems to crash because of a missing SELinux rule. You need to fix that while building your GSI
avc: denied { search } for name="qmipriod" dev="dm-6" ino=319 scontext=u:r:vendor_qmipriod:s0 tcontext=u:object_r:vendor_qmipriod_data_file:s0 tclass=dir permissive=0
QMI stands for Qualcomm MSM Interface, which makes the link between software and hardware interface iirc. you might try to fix that and check if it works by adding an selinux rule as nonplat.
Or try booting with permissive SELinux and see if that works
The rule should look like this:
allow vendor_qmipriod vendor_qmipriod_data_file:dir { search };.


Firmware Update

Does pbpctrl support firmware updates, or was it deemed too risky to implement?
I think fw updates for the pixel buds are signed and checksum'd by Google, so it wouldn't be possible to send a corrupted update to brick the headphones.

I have not looked at this at all yet. So at the moment it doesn't support it and I can't tell if there would be any risks involved.


All people can use /panilla debug and see the plugins

Please add a properly permission to use that....

Hi,
I fixed this a couple weeks ago with 76aabccb3355e3696211ce4076a10033e0494085
Please ensure you are using the latest version


How to find out NLog files on Azure App service: Azure devops dashboard

Hi,
I have configured NLog like so and all are working fine on development mode. I can see those files under this path: \bin\Debug\net6.0\logs.
I have published the app to the Azure App service. So can you tell me how to find out those files there? Thanks!
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      internalLogLevel="Trace"
      internalLogFile=".\internal_logs\internallog.txt">

    <targets>
        <target name="logfile" xsi:type="File"
                fileName=".\logs\${shortdate}_logfile.txt"
                layout="${longdate} ${level:uppercase=true} ${message}"/>
    </targets>

    <rules>
        <logger name="*" minlevel="Debug" writeTo="logfile" />
    </rules>
</nlog>

Hi @snakefoot
Ok sure. I have found the solution and I'll put it here too. Thanks!

Closing due to inactivity. If you found a solution, then you are still wellcome to post it.

What was the solution? @snakefoot

No idea. Original poster never returned.
Sent from my Galaxy
-------- Original message --------
From: Ndonald @.>
Date: 16/06/2023 14:45 (GMT+01:00)
To: NLog/NLog @.>
Cc: Rolf Kristensen @.>, Mention @.>
Subject: Re: [NLog/NLog] How to find out NLog files on Azure App service: Azure devops dashboard (Issue #4879)
What was the solution? @snakefoothttps://github.com/snakefoot
—
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/4879#issuecomment-1594620766, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HCQDRB6UM2EJIIZ6Z3XLRIOZANCNFSM5THHOZOA.
You are receiving this because you were mentioned.Message ID: @.***>


python311Packages.dvc-azure: 2.21.1 -> 2.21.2

Changelog: https://github.com/iterative/dvc-azure/releases/tag/2.21.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235543 run on x86_64-linux 1

6 packages built:

dvc-with-remotes
dvc-with-remotes.dist
python310Packages.dvc-azure
python310Packages.dvc-azure.dist
python311Packages.dvc-azure
python311Packages.dvc-azure.dist


Adding notebook workspaces API to Cosmos Swagger

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

/azp run automation - sdk

Can one of the admins verify this patch?

@shurd Hello. Could you address ARM's comments?

Hi @MyronFanQiu we are planning on making the naming change the ARM team suggested, but will not be able to deploy it until at least January, so we are going to wait to merge these changes until then. I will address your comments once we get closer to having the change in production.

@shurd I will remove the label once you finish this PR. 😄

@shurd please address the comments.

LGTM

@anthony-c-martin can you help with ARM signoff?

@shurd Hello. Could you solve ARM's comments?

/azp run automation - sdk

@shurd Kindly ping

@pilor Could you sign off if author has resolved all your comments?

@MyronFanQiu We have resolved the last comments. Can you please help merge this change?

@KrisBash Hi. Could you approve this PR if you don't have any more concern?

@shurd Regarding to the status and the provisioningState comment, the swagger spec would be changed in another PR after the fix of server finished. Is it correct?

@MyronFanQiu, as I understand it, @wmengmsft and @pilor discussed the status change offline and determined that we can keep it as-is. There will be no additional change.

@MyronFanQiu, as I understand it, @wmengmsft and @pilor discussed the status change offline and determined that we can keep it as-is. There will be no additional change.

Good to know. Wait for @KrisBash's approval.

@akning-ms Hi. I think @KrisBash and @pilor are both from ARM's team. Do you think it's ok to force merge this one since ARM has signed off? @KrisBash marked a request change for this PR.

@MyronFanQiu @KrisBash, all requested change have been resolved. Can we please proceed with merging this PR?


action buttons in modal messages are flipped

while testing #21004:
In the modal case, the buttons 'hello' and 'world' appear in a different order in the alert as in the non-modal case.
I'm using the following snippet. Just flip the value of 'modal':
        vscode.window.showWarningMessage<vscode.MessageItem>('hello world', { modal: true },
            { title: 'hello', isCloseAffordance: true },
            { title: 'world', isCloseAffordance: false }
        );

Each OS will do what is best for its own platform.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!


gpuimagemoviewriter completion block is never called.

i am applying effect on movie using gpu image framework but gpuimagemoviewriter completion block is never called because of that can not be able to end processing and file not saved

Guys, not a single one of you even gave a code example. My guess is your movie writer is in a local scope and being released immediately  (and your callback) because there is no reference to it

I also had this problem after re-using a filter. Once you init a filter and use it for image processing or for movie processing you have to set it to nil and re-initialize it to use it again or the completion block is never called.


docs: add constructor docs for each provider and account type

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, see guidleines below)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
[ ] Is the base branch you're merging into development and not main?

PR-Codex overview
This PR focuses on removing default values for certain configuration options in the code.
Detailed summary

Removed default value for baseFeeBufferPercent in schema.ts
Removed default value for maxPriorityFeeBufferPercent in schema.ts
Removed default value for txMaxRetries in schema.ts
Removed default value for txRetryIntervalMs in schema.ts
Removed default value for txRetryMulitplier in schema.ts
Removed default value for minPriorityFeePerBid in schema.ts

The following files were skipped due to too many changes: site/packages/aa-accounts/light-account/constructor.md, site/packages/aa-alchemy/provider/constructor.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Current dependencies on/for this PR:

development

PR #203

PR #202

PR #201

PR #204   👈

This stack of pull requests is managed by Graphite.


TS 2.4.1 Error: Type 'GroupCellRenderer' has no properties in common with type 'ICellRenderer'.

I'm submitting a ...  (check one with "x")
[ x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid/blob/master/CONTRIBUTING.md#question

Current behavior
Compilation with typescript 2.4.1 fails with;
node_modules/ag-grid/dist/lib/rendering/cellRenderers/groupCellRenderer.d.ts(17,22): error TS2559: Type 'GroupCellRenderer' has no properties in common with type 'ICellRenderer'.
Expected behavior

Compilation is successful.
See 'weak type detection': https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes
Minimal reproduction of the problem with instructions

Compile an ag-grd project using typescript 2.4.1.
What is the motivation / use case for changing the behavior?

Can compile projects using the latest version of typescript.
Please tell us about your environment:

Linux, Visual Studio Code

ag-Grid version: 11.0.0

Browser: Any

Language:  TypeScript 2.4.1

https://github.com/ceolter/ag-grid/issues/1708
Already being discussed here.

Already being discussed. Closing.


Split Puzzles into Subcategories

This is a proposal to split the puzzles into three tabs, Campaign, Journal and Community. This is to facilitate adding Weeklies and other events (like Speed Solves) into the leaderboard, without making the list too long proving unwieldy. The proposed UI looks like this.
Note that the campaign and journal puzzles will no longer receive further updates, thus fixing their sizes.

Superseded by 0471970


RBAC user field is Base64 encoded

Dex v2.4.1 w/LDAP connector
K8s v1.6.2
Here's an example RBAC DENY entry:
I0510 22:55:45.410874       6 rbac.go:87] RBAC DENY: user "https://dex.url#CjZDTj1CbGFrZSBCYXJuZXR0LE9VPVVzZXJzLE9VPVBvc3RtYXRlcyxEQz1hZCxEQz1vZmZpY2USBGxkYXA" groups [vpn-prod dept-engineering vpn-stage team-infra system:authenticated] cannot "list" resource "pods" cluster-wide
Is there any way to have Dex provide a non-encoded entry for the user field?

In case anyone else comes to this problem (which I also have):
echo '[base-64-id] | base64 --decode -i - | perl -pe 's/([\x00-\x20\\]+)/ /g' | awk '{print $1}'
That at least gives me the user ID. The format of the base64-encoded variable is kinda unexpected; there is:
[LF][Ctrl+F]user-id[Ctrl+R][Ctrl+Q][connector-id]
As an example:
echo 'CgZhYnJ1Y2USEWxkYXBfaGxzZGV2X2xvY2Fs' | base64 --decode -i -
Returns:
00000000: 0a06 6162 7275 6365 1211 6c64 6170 5f68  ..abruce..ldap_h
00000010: 6c73 6465 765f 6c6f 6361 6c              lsdev_local

However, a slightly longer user ID:
echo 'CgphY2hlYW1pdHJ1EhFsZGFwX2hsc2Rldl9sb2NhbA' | base64 --decode -i -
Returns:
00000000: 0a0a 6163 6865 616d 6974 7275 1211 6c64  ..acheamitru..ld
00000010: 6170 5f68 6c73 6465 765f 6c6f 6361       ap_hlsdev_loca

Note that the connector ID is truncated. I suspect there is a maximum length for base64-encoded variable? But I haven't reviewed the source to discover this.

dup of https://github.com/coreos/dex/issues/892

@andybrucenet ,

The format of the base64-encoded variable is kinda unexpected; there is: [LF][Length]user-id[Ctrl+R][Length][connector-id]

We use this particular format because a combination of the Connector ID and UserID (https://github.com/coreos/dex/blob/master/server/oauth2.go#L269-L274) returned by the connector are used for unique identification. I will go ahead and add some documentation to clarify this.
@blakebarnett ,
Would the solution proposed in https://github.com/coreos/dex/issues/892#issuecomment-293973008 be suitable for you? If so I'll close out this issue as a dup.

Closing as a dup


TomoScan dark mode

http://g.recordit.co/AbBJLsItih.gif

Small issue after Refresh browser in darkmode @hoangkianh

And need some UI optimization

https://scan.devnet.tomochain.com/tokens/0x31f0fd23bd6f871faef9af2c34f84ba0fa0ea717#tokenTransfers

Need update textbox and button color(search & filter) too.

I fixed it in pr #663

something more:

https://scan.devnet.tomochain.com/txs/0x1ad8e42d60a77e80080e8d7461a6dd9fcccedfa6186c23d5b6daf783e762dd4b#overview

https://scan.devnet.tomochain.com/tokens/0xa8c056ad15377ac157cebddac1c63ea16846c529/info

Yes, it was fixed

I think this is the final one:

https://scan.devnet.tomochain.com/contracts/verify?address=0xd85db7261ebd645ea5793d0484086f4b7f7939f9


Dependencies Updated

Thanks for the contribution! ktlint is failing but I'll merge it anyway and get it fixed before the next release.


bugfix: run generate for fix statik

fix for ignoring statik generate

Could you describe the detail of this fixing?

Could you describe the detail of this fixing?

I found the select-box to select service was not show, I remove statik -m flag and re-run go generate, It's work.

https://github.com/rakyll/statik#deterministic-output argument -m is for ignoring the last modified time, if remove it, may cause static files can not be updated when the embed files being updated. Could you dive into the browser's devtool, check the console output and the index.html content to see the actual reason of this issue?

I run example/helloworld, index.html don't have select logic on main branch.

I've tried with many different browsers and the latest main branch code, but can not reproduce your problem.

I think it related to browser last-modified header.
After I update new version, Because your ignores the mtime by -m flag, my browser thinks that the file has not changed, 304 and return old file.
Then I ran it, I found that the behavior was different from the doc.
So I remove -m flag and re-generate, last-modified changed, my browser don't do 304, and ask server for new file.
I thought it is a bug that moment. I'am sorry to this pr, It's my problem.


Gas fees for consensus txs

To mitigate DoS by transaction spam we need to introduce gas fees for consensus transactions that can be performed by non-staked entities (e.g., staking transfers, escrow, reclaim escrow).
All operations which can only be performed by staked entities are exempt.

We probably want a fixed gas cost per transaction (or per byte of transaction data), as well as a variable gas price (similar to the runtime gas model).


[Feature Request] When re-run a finished flow, copy the user properties from the original jobs.

When prepare execute a flow from the flow executions UI, we need copy the job input params of the original flow to the created one (except some basic params such as flow start timestamp), then we save the very first flow start timestamp as input_base_stamp.
There are many scenarios suitable for this feature, such as re-trying the failed hourly flows, and backfilling a successful daily flow.

Backfill support might be enough for most use cases though. See also https://github.com/azkaban/azkaban/issues/1192.
Do you often set flow overrides (execution scope) or why are the original params needed?

Sure, it still sounds like a backfill problem to me. It's just a more granular period (hour) than the most common backfill period (day).
In some scenario user might actually want to change some job properties (to fix some problem) and then run hourly backfill for a date/time range. Especially in such case one wouldn't want to use original properties. Backfill feature would only override the base timestamp for each execution that it submits.

I think this feature should be a quick solution before the whole backfill coming out.

If using a snapshot of older properties is not generally needed, I would rather see new development focus on a more widely missed feature like backfill support.
Especially it seems that from the original executions's properties you're interested in using the flow.start.timestamp. However, to use it reliably for your use case, also its meaning should be changed. Currently flow.start.timestamp is set when the execution is started. For example, if the execution was scheduled at 00:00 but start of execution got delayed for any reason, the flow.start.timestamp could be set to something like 01:30. To me it would seem sensible to keep the current meaning, ie. it matches with the execution start time that you can also see in the Azkaban UI.
One independent part that's required for the backfill support would be adding a new provided property which could be called flow.base.timestamp. That can be overridden by user if so desired. In scheduled execution this would be the exact time of the schedule rule that triggered it.

what we do now is something like adding the property flow.base.timestamp=${flow.start.timestamp} in each job definition and getting the value when run by scheduler, but override by the previous failed executions.
When do a re-try, if we treat the original execution as a special parent of the new one, then cloning the input properties which can be override again by user specified new parameters, could be widely accepted. That is,  just add an new source for preparing the properties, shared --> parent --> output --> job source --> [original]


PYTHON/GROOVY: Executing azure CLI Command with JSON - Parsing Issue?

Describe the bug
Currently I fail to run an azure CLI command from Groovy because of the JSON Part in the Command.
VM has reported a failure when processing extension 'CustomScript'. Error message: "Enable failed: failed to get configuration: error reading extension configuration: error parsing settings file: error parsing json: json: cannot unmarshal string into Go value of type map[string]interface {}
Please see: https://stackoverflow.com/questions/51424270/groovy-executing-azure-cli-command-with-json-parsing-issue
As from Groovy side: The command looks "fine"
It seems that (maybe) from azure cli side the parsing of the parameter is going wrong and should be changed to be useable from unix/linux
To Reproduce
GROOVY Script:
def process
            def cargs = [az, vm, extension, set, -g, demo, --vm-name, demo-cfg01, --name, CustomScript, --publisher, Microsoft.Azure.Extensions, --settings, '{"commandToExecute":"ls"}']
            process = (cargs).execute(null,null);

        }

The same call started from shell works.
Expected behavior
Same as from shell.
Environment summary
azure-cli (2.0.38)
acr (2.0.27)
acs (2.1.1)
advisor (0.5.1)
ams (0.1.1)
appservice (0.1.35)
backup (1.1.1)
batch (3.2.4)
batchai (0.3.0)
billing (0.1.8)
cdn (0.0.14)
cloud (2.0.14)
cognitiveservices (0.1.13)
command-modules-nspkg (2.0.1)
configure (2.0.16)
consumption (0.3.1)
container (0.1.24)
core (2.0.38)
cosmosdb (0.1.21)
dla (0.1.0)
dls (0.0.22)
dms (0.0.1)
eventgrid (0.1.12)
eventhubs (0.1.3)
extension (0.0.15)
feedback (2.1.2)
find (0.2.10)
interactive (0.3.23)
iot (0.1.21)
keyvault (2.0.22)
lab (0.0.22)
maps (0.2.0)
monitor (0.1.7)
network (2.1.4)
nspkg (3.0.2)
policyinsights (0.1.0)
profile (2.0.26)
rdbms (0.2.4)
redis (0.2.13)
reservations (0.2.0)
resource (2.0.31)
role (2.0.26)
servicebus (0.1.2)
servicefabric (0.0.12)
sql (2.0.27)
storage (2.0.35)
vm (2.0.34)
Python location '/opt/az/bin/python3'
Extensions directory '/root/.azure/cliextensions'
Python (Linux) 3.6.1 (default, Jun 14 2018, 21:24:04)
[GCC 5.4.0 20160609]
Legal docs and information: aka.ms/AzureCliLegal
Additional context
Add any other context about the problem here.

What happens if you escape the internal double quotes?

The Answer is:
DEBUG: msrest.http_logger : b'{\r\n  "startTime": "2018-08-07T08:13:02.3341422+00:00",\r\n  "endTime": "2018-08-07T08:13:43.0520614+00:00",\r\n  "status": "Failed",\r\n  "error": {\r\n    "code": "VMExtensionProvisioningError",\r\n    "message": "VM has reported a failure when processing extension 'CustomScript'. Error message: \"Enable failed: failed to get configuration: error reading extension configuration: error parsing settings file: error parsing json: json: cannot unmarshal string into Go value of type map[string]interface {}\"."\r\n  },\r\n  "name": "e449a166-9548-46c2-aa28-a5358ac65b47"\r\n}'
DEBUG: msrest.exceptions : VM has reported a failure when processing extension 'CustomScript'. Error message: "Enable failed: failed to get configuration: error reading extension configuration: error parsing settings file: error parsing json: json: cannot unmarshal string into Go value of type map[string]interface {}".
ERROR: Deployment failed. Correlation ID: 9fc5bbe7-1cc0-4d95-9f48-980b64f9a47b. VM has reported a failure when processing extension 'CustomScript'. Error message: "Enable failed: failed to get configuration: error reading extension configuration: error parsing settings file: error parsing json: json: cannot unmarshal string into Go value of type map[string]interface {}".

My current workaround is to write the json into a setting file and set the json file as parametervalue...

add to S165.

I am not a Groovy expert. I followed this answer and tried these 2 scripts with az --debug which tells you the actual arguments Azure CLI received. On Linux both work for me:
t1.groovy
def proc = """az {"name":"value"} --debug""".execute();
proc.waitForProcessOutput(System.out, System.err);

$ groovy t1.groovy
DEBUG: Command arguments: ['{"name":"value"}', '--debug']

t2.groovy
def cmd_args = ['az', '{"name":"value"}', '--debug']
proc = (cmd_args).execute(null,null);
proc.waitForProcessOutput(System.out, System.err);

$ groovy t2.groovy
DEBUG: Command arguments: ['{"name":"value"}', '--debug']

On Windows, since az is a bat file, " needs to be escaped as \" for cmd.exe and \ needs to escaped again for Groovy itself as \\.
t1.groovy
def proc = """az.bat {\\"name\\":\\"value\\"} --debug""".execute();
proc.waitForProcessOutput(System.out, System.err);

>groovy t1.groovy
DEBUG: Command arguments: ['{"name":"value"}', '--debug']

t2.groovy
def cmd_args = ['az.bat', '{\\"name\\":\\"value\\"}', '--debug']
proc = (cmd_args).execute(null,null);
proc.waitForProcessOutput(System.out, System.err);

>groovy t2.groovy
DEBUG: Command arguments: ['{"name":"value"}', '--debug']

Please let me know if these solutions work for you.


Adjust the default tab name from the App project name to be less than 16 characters or provide an error message

💡 Idea
When creating a new project you are not limited in the length the project name has. When you then want to create a tab, this is limited to 16 characters.
If you do not specify a name and just press enter the generator suggests the name of the project + " tab". It should perform a check if the name is longer than 16 characters and already cut that off at that limit. Or at least give you an error message if you enter too many characters. Now nothing happens.

Is your feature related to a bug
no
Alternatives
In the tabgenerator the default name is set with
this.options.title + ' Tab',

the default should max be the first 11 characters of the title.
The validation method should also return a meaningful message if there are more than 16 characters.
Additional Info
The yeoman generator uses Inquirer.js for the promts. These can have validation scenarios.

Could they assign this issue to me?


Add BLOOM image

Adds a Dockerfile that sets up an environment for BLOOM training

This looks clean, but regretfully I should have probably clarified the requirements a bit since everything outside of  conda pretty much lives outside of the Dockerfile.
Do these changes:

For FROM, use our nccl-tests image for cuda 11.7, use this artifact: coreweave/nccl-tests:2022-11-06_19-21-22.11_EST.
Remove row 3 to 70.
Then follow the instructions at the bottom off https://github.com/bigscience-workshop/bigscience/tree/master/train/tr11-176B-ml#environment-setup "environment setup", ie:
create and activate the conda env (might need a conda init first to get the shell prepared for conda)
install transformers
install pytorch with conda install pytorch torchvision torchaudio pytorch-cuda=11.7 -c pytorch -c nvidia
pip install deepspeed and follow the rest of the instructions, you will need to find the right deepspeed repo and megatron-deepspeed repo to clone

Only issue is finding out where the repositories should sit inside of the image which was why I didn't originally include them, but running a git clone inside of the image should suffice, maybe directory structure should be setup in the image as well? Only reason why I didn't include cloning and installing the dependencies in the megatron repo was that the conda env had all of the dependencies for megatron anyway
BigScience is pulled here: https://github.com/jagwar/customAMI-benchmark/blob/bloom-AMI/create-conda-env.sh#L30
Megatron is pulled here also: https://github.com/jagwar/customAMI-benchmark/blob/bloom-AMI/create-conda-env.sh#L24

@salanki is this ready for merge?

Almost. I have been using the branch myself. Have some changes I might make so let's leave it open.

@salanki Still pending? Let's not leave this PR open forever. :)


Inaccurate Neogit highlights with base16

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
base16
Description
Neogit applies its own highlighting, which happens to conflict with Mini's base16 module. This becomes noticeable in certain instances, such as the diffview, where red markers are displayed with a black foreground. I discovered that modifying nvim's colorscheme after opening Neogit results in colors being completely absent - I believe that Mini is likely overriding highlights that Neogit relies upon?
Neovim version
NVIM v0.9.1
Steps to reproduce

nvim
Neogit

return {
  "CKolkey/neogit",
  cmd = 'Neogit',
  dependencies = {
    "nvim-lua/plenary.nvim",
    "sindrets/diffview.nvim"
  },
  keys = {
    { "<Leader>ng", "<cmd>Neogit<CR>", desc = "Toggle Neogit" }
  },
  opts = {
    integrations = {
      diffview = true
    }
  }
}

Expected behavior
Proper highlighting with Neogit, particularly in/with its diffview markers.
Actual behavior

Thanks for the issue!
I don't use 'neogit.nvim' myself, so will take later a look.

@wroyca, I've only now noticed that you use 'CKolkey/neogit' while 'mini.base16' explicitly states that it supports 'TimUntersberger/neogit'. I can see that there are a lot of opened issues and PRs in 'TimUntersberger/neogit', but it doesn't look like a completely abandoned project.
There doesn't seem to be an issue with 'TimUntersberger/neogit'.

I discovered that modifying nvim's colorscheme after opening Neogit results in colors being completely absent - I believe that Mini is likely overriding highlights that Neogit relies upon?

I think the issue is quite opposite. When you load color scheme, it usually does highlight clear to delete all highlight groups prior to it and then defines its own. 'mini.base16' (and 'mini.hues' for that matter) doesn't define own highlight groups and relies on good defaults from 'neogit' repo (which are good enough).
Commit which your pointed out in CKolkey/neogit#45 has changes which remove highlight default link calls to define default highlighting. This is the correct way for plugin to define own persistent defaults for highlighting.
So I'll close this issue as it doesn't exactly come from 'mini.base16' while suggesting at least these solutions:

Make 'CKolkey/neogit' use proper hi default link calls to create default highlighting.
Apply 'mini.base16' color scheme before loading 'CKolkey/neogit'.
Use 'TimUntersberger/neogit'.

Hi! Just a heads up, Neogit has moved to an organization, NeogitOrg. I just merged my fork and hopefully all the colors are being linked properly here: https://github.com/NeogitOrg/neogit/blob/master/lua/neogit/lib/hl.lua 😅
If there is something I'm doing wrong, then I'm definitely keen to make it better :)

Thanks, @CKolkey! Congrats on the merge!
I'll look into double checking 'neogit' integration and update the username.

I think thats pretty good advice - the biggest headache from this massive update has been related to colors. Which, on the one hand, is pretty cool that that's the biggest issue, but also... not what I was going for.
I'll make a HIGHLIGHTS.md file in the repo to break down what everything is.

Do you think going back to creating default links to built-in groups is not worth it (against your vision)?

Do you think going back to creating default links to built-in groups is not worth it (against your vision)?

No, I think its definitely worth it. There's some "fancy" stuff I'm trying to make work, like context-aware cursorline highlights, changing the highlight of the hunk/section the cursor is in, stuff like that, which means I need the extra groups, but... I think I just didn't know how to set them up properly 🤷🏼
Hopefully https://github.com/NeogitOrg/neogit/pull/617 fixes things for everyone :)


Native Function Calling

This PR adds native function calling support for models from Anthropic, Mistral, Bedrock, Groq instead of leveraging OpenAI's GPT model for function calling.
We are using GPT for function calling for the models that does not support for function calling such as, Perplexity.
Depends on
#965 https://github.com/BerriAI/litellm/pull/3124

@elisalimli apologies for commenting on a merged PR, but wondering if it works with Ollama as well.

arsaboo

If you deploy it to a server, we can. As of now, we do not support the local running models.

Yes, Ollama server directly or through Litellm.


Remove unsupported HTML/CSS before capturing

Hi,
I'm looking for a way to remove any HTML/CSS that can't be properly captured by html2canvas before I actually capture the page.
The goal is to "simplify" the HTML/CSS in order to prevent capture with faulty/partially rendered elements.
Thanks!

I use jquery for this purpose. You could add a class 'hideonhtml2canvas' to specific elements, then run $(".hideonhtml2canvas").hide(); before taking the image and $(".hideonhtml2canvas").show(); immediately after.

Hi Chris,
Sounds like a good approach.
But is there a list somewhere with all the elements/attributes that can't be captured nicely by html2canvas?
I'm under the impression that the "Limitations" section on the web page doesn't give them all since SVG isn't specified there.

I am not aware of a complete list. I had specific elements I wanted to exclude for more functional reasons - that is I wanted a screenshot showing an output, but not for example, the buttons and other controls to update it.
By the way, I was able to include SVG elements (I am using Highcharts, for example) based on the following instructions: http://stackoverflow.com/questions/34042440/using-html2canvas-to-render-a-highcharts-chart-to-pdf-doesnt-work-on-ie-and-fir

Okay!
And thanks for the useful additional piece of information.
Cheers


Platform specific configuration default values for extension authoring

This is useful, so we don't need programming to achieve it.
https://github.com/hackwaly/vscode-ocaml/issues/82#issuecomment-287278077

@hackwaly Please explain what feature you are asking for
(I do not want to dig into vscode-ocaml myself).

I means ability to specify different default values for each platforms on same field of configuration. Eg. "executable_extname" on Windows default to ".exe" and for other platform default to "".

@hackwaly and where would this be used?
We have already a mechanism for task.json, launch.json, package.json to deal with platform differences. See https://code.visualstudio.com/docs/editor/tasks#_operating-system-specific-properties

Sorry, I didn't see where package.json support it. I'll try it.

@hackwaly aha, you are asking for this feature in "package.json". Please be aware that the support described in https://code.visualstudio.com/docs/editor/tasks#_operating-system-specific-properties is only available for Debugger contributions in package.json.
I suggest that you create an example of what you want to do in a package.json.

{
  "contributes": {
    "configuration": {
      "ocaml.replPath": {
        "type": "string",
        "default": "ocaml", // I want default to "ocaml.exe" on windows.
        "description": "Path to OCaml REPL."
      }
    }
  }
}

Thank you for your advice.

@hackwaly you are welcome!


I have a few question about DeepcutTokenizer

CountVectorier have methods transform but DeepcutTokenizer don't have this methods.
in the future deepcut will implement this methods or not.
because i have to change CountVectorier to DeepTokenizer.
because it have to transform test data before predict.
// I am not good with English grammar. if you not understand i can explain in Thai lang thx

Hi @Zylinks, Iet's say ['ฉันบินได้', 'ฉันกินข้าว', 'ฉันอยากบิน'] is your training set and  ['ฉันหิว', 'เขาไม่มี'] is your validation set. You can use DeepcutTokenizer like the following:
from deepcut import DeepcutTokenizer
tokenizer = DeepcutTokenizer(ngram_range=(1,1),
                             max_df=1.0, min_df=0.0)
X = tokenizer.fit_tranform(['ฉันบินได้', 'ฉันกินข้าว', 'ฉันอยากบิน'])

If you see the vocabulary, it will look something like:
tokenizer.vocabulary_
>> {'ได้': 0, 'บิน': 1, 'ฉัน': 2, 'อยาก': 3, 'ข้าว': 4, 'กิน': 5}

Then, when you apply on the validation dataset, you will see that we will have 0 for the second row since words in เขาไม่มี does not exist in the training data.
X_test = tokenizer.transform(['ฉันหิว', 'เขาไม่มี'])
X_test.todense()

>> matrix([[0., 0., 1., 0., 0., 0.],
           [0., 0., 0., 0., 0., 0.]])


Missing OccurenceOrderPlugin for DIST?

https://github.com/rocjs/roc-package-webpack-web/blob/master/extensions/roc-package-webpack-web-dev/src/webpack/index.js#L75-L77
I can't see that the OccurenceOrderPlugin is used in DIST-mode though, or am I missing something?

We add the OccurenceOrderPlugin in roc-package-webpack as can be seen here for DIST.
What we can question is if we really need it only in DEV always for web and not for node but let's look at it again later.


[Global Request] Table 77 "Report Selections".SelectTempReportSelections

Describe the request
Please set procedure "SelectTempReportSelections(var TempReportSelections: Record "Report Selections" temporary; AccountNo: Code[20]; WithCheck: Boolean; ReportUsage: Enum "Report Selection Usage"; TableNo: Integer)"  as global.
Additional context
We are using own sequence for reports and we need use select procedure in our solution.
Internal work item: AB#554797

Hello @JesperSchulz , I see new tag on issues, but this issue do not have this tag. It is OK it will be processed? Also please check if you register this issue. It is long time without reaction.

@fridrichovsky, I just checked the linked work item and everything appears to be fine. I have pinged the responsible team and requested them to pick up this issue.

Hi @fridrichovsky,
I'd like to better understand your scenario.
Is it not possible to use SelectTempReportSelectionsToPrint with the OnGetLastSequenceNoOnBeforeFillEmptySequence event to control the sequence in the manner you'd like?
Please enlighten me on what the issue there may be and that you must use SelectTempReportSelections.

@fridrichovsky To add to @darjoo SelectTempReportSelections does not have a clear purpose defined to make it a public function. We could add a new public function if needed but we would need a better name, so we clearly define purpose. The current one is a helper method. If you cannot use the event that Darrick suggested, could you provide a better name for a public method?

Hello @darjoo and @nikolakukrika,
we are using event OnPrintDocumentsOnAfterSelectTempReportSelectionsToPrint in PrintDocumentsWithCheckDialogCommon where is mentioned function SelectTempReportSelectionsToPrint. We have our function SelectTempReportSelectionsToPrintCUST where we have own logic for filling TempReportSelections buffer (it is not about sequence only). Source for our loop is TempReportSelectionsAccount same as is used in SelectTempReportSelectionsToPrint. So we would like have same records there. That is reason why we ask for function SelectTempReportSelections as global because we would like call this function.


custom types

How about custom incident types and styles for each one?

I would love it if there are "Investigating", "Identified" and "Monitoring". We could use minor for that, but in case of "Monitoring"  (after deploying a fix) the system should be operational again. But if there is still an error, it would be better if the user knows, that there recently was an incident.


[HUDI-6073] Table create schema should not include metadata fields

Change Logs
Table create schema should not include metadata fields, this is the requisite for our TableSchemaResolver.
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

The failed test is flaky, it has been successful for the last run: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16315&view=results


MultiSubnetFailover?

Github documentation states you may change the MANAGEMENT_SQL_CONNECTION_STRING to add a failover partner in case of SQL mirroring. Is it a supported scenario as well to add 'MultiSubnetFailover=True' when utilizing SQL Always on?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a31de562-fa30-ba13-c087-042b2fac2ebd
Version Independent ID: c6dec2d0-9187-e605-8f4b-d7106f190c49
Content: Planning for High Availability with App-V Server
Content Source: windows/application-management/app-v/appv-planning-for-high-availability-with-appv.md
Service: unspecified
GitHub Login: @MaggiePucciEvans
Microsoft Alias: elizapo

@officedocsbot assign @mypil

@Aaron-  Thank you for the feedback. Specifying MultiSubnetFailover=True when utilizing SQL Always on is supported. However, when connecting to something other than an availability group listener or SQL Server 2012 Failover Cluster Instance may result in a negative performance impact, and is not supported.  More information on Sqlclient support for High availability can be found in the below document.
https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/sql/sqlclient-support-for-high-availability-disaster-recovery

@Aaron- thank you for submitting feedback.
From our understanding, the issue has been answered by msbemba. If you feel it hasn't been answered, please re-open this issue.
Thank you for engaging with the community here for the docs.

@officedocsbot close


[1.12.2] Powered Pump consumes Fluids

I wasn't sure if this is an issue or not. Maybe it is intentional but: If you're not quick enough, the Powered Pump consumes the Fluid if the internal buffer is full. It keeps pumping and "destroying" Fluid-blocks even if the internal tank is full.

fixed in 7eea0c1065ab1ae3319c0f376b2594c3ebe7ee71


[feat/cli] Configuration validation and commented properties

This finally approaches parts of #92 and #217: Configuration documentation, validation and proper defaults.
Commented config file
The configuration file is now fully commented out (preview). Each property is commented and can be uncommented and changed if the user does not want the default to apply. The configuration file is now closer to unix-like configuration files. Reviews of the comments (both content and layout) are much appreciated.
Enforced rules and defaults
Secondly, the configuration defaults and rules are now stored in a config_defaults.lua file, and Kong will stop the execution of a comment is the file contains invalid properties (wrong type, incorrect value, etc...)
This is what it looks like if a string is given in place of a port number for admin_api_port:
[INFO] Using configuration: kong_DEVELOPMENT.yml
[WARN] admin_api_port: must be a number
[ERR] Invalid properties in given configuration file

Again, reviews of both rules and defaults are much appreciated.

Note: to be closed re-opened again the next branch (See #622)

Moved to #633 and correctly rebased on next.


[FEATURE] Force Mode to import full calendar in AboutTime instead only changes

Users who have desync between SimpleCalendar and AboutTime may not know that they have to push Import to AboutTime button buried in the bottom of the Settings dialog. A force mode that detects such desyncs and does a full import anytime there is a desync would help avoid issues, esp with other mods that use Calendar (such as SmallTime).

I am using this button and the calendars are still out of sync 🤷

Hey so we're currently exporting SimpleCalendar to AboutTime and AboutTime is getting sync'd to one month earlier than the time we've set.
Any ideas?

@Eonfuzz
There currently is an issue between the newest version of about time and Simple Calendar that is causing this.
I'll be putting an update or tomorrow that will fix this issue.

@vigoren you're a legend. Thanks mate

This does not seem to be resolved for me in the version that was released yesterday. I'm on about-time 0.8.4 and simplecalendar  release from yesterday.
I'm wondering if the fact that about-time uses a zero index for months is the actual issue? I'm trying to set my current date to 1 Kythorn 1491 DR. If I set that in SimpleCalendar I get 1 Greengrass in about-time which represents this as 06/01/1491. To get 1 Kythorn in about-time I have to set about-time directly to 08/01/1491 (but then SimpleCalendar's date shows something like 24 Kythorn...).

I have another world though where the date is 30 Hammer 1493 DR and things seem perfectly in synch there.

@venom986 for the world that isn't synced did you export the simple calendar settings into about time after the update? The difference in time you are seeing sounds consistent with needing to re export.

@vigoren I did. Would it make a difference that the game was paused when I did the export? Would that have prevented an update to game time?

@venom986 game being paused shouldn't affect the export at all.
Is there a difference in active modules between the two worlds and could one be maybe interfering?
Otherwise there could be a bug. In all my testing about time and Simple calendar stay synced together so to help track the bug down it would help to have your calendars configuration settings. The current quickest way to give me that is to send me the affected worlds settings.db file (nothing sensitive is stored in there) or if you don't wish to do that (totally understandable) can tell me the settings you are using.

The one difference off the bat is that Simple Calendar, About Time, and SmallTime were all enabled on first launching the world that still doesn't work (post update), whereas About Time was disabled on first launching the world that does work.
The other thing is 1491 DR is before a leap year and 1493 is after. This is the Harptos calendar.
I'm about to go log in and can do some testing and send config.

grumble. grumble. grumble.
Have you tried turning it off and on again?
/facepalm
So, although I had confirmed i had the functionality from the new release of Simple Calendar, I had NOT restarted my world after exporting Simple Calendar to About Time. Now that I have cycled the world it seems everything is synched nicely.

@venom986 glad it's working for you!
Though you shouldn't have needed to restart the world but at least that is an easy way to get them synced up again.

@vigoren yeah not sure why.
As an FYI if you don't follow it, the other module I'm using (SmallTime) has an issue open about this ~ 1 month discrepancy as well. Tim Posney (author of About-Time) was posting there indicating he was aware he'd introduced a bug in the last version of About-Time in that it interprets a string of 0/0/000 00:00:00:000 incorrectly in his new time offset field. Maybe related to what you had to fix on your end?

It is related, my work around for now is when exporting i set the time offset field to be an empty string instead of 0/0/0 00:00:00 which skips the code in about time that introduces bug.
My doing this should also fix small time for people who use all three modules
When he fixes his bug I'll make sure things keep working with simple calendar.

With the changes to about-time passing all calendar related functionality to Simple Calendar, this issue is no longer relevant, so I am going to close it.


Updated ScaleIO documentation for troubleshooting

This commit updates some of the troubleshooting and gateway
configuration documentation.

Closing this in favor of consolidation under https://github.com/emccode/rexray/pull/267


Redis SDK: Schema doesn't match on Read

Hello Again! 👋
I believe I've found another bug in the Redis SDK. When calling a Get request - the API returns the following JSON:
{
	"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/acctestRG-8068841053713972281/providers/Microsoft.Cache/Redis/acctestRedis-8068841053713972281",
	"location": "West US",
	"name": "acctestRedis-8068841053713972281",
	"type": "Microsoft.Cache/Redis",
	"tags": {},
	"properties": {
		"provisioningState": "Succeeded",
		"redisVersion": "3.0",
		"sku": {
			"name": "Basic",
			"family": "C",
			"capacity": 1
		},
		"enableNonSslPort": false,
		"redisConfiguration": {
			"maxclients": "1000",
			"maxmemory-reserved": "50",
			"maxmemory-delta": "50"
		},
		"accessKeys": null,
		"hostName": "acctestRedis-8068841053713972281.redis.cache.windows.net",
		"port": 6379,
		"sslPort": 6380
	}
}

The SDK contains the following Schema which doesn't match - meaning that the Properties object in the ResourceProperties class is nil. This is the relevant code from the SDK:
// CreateProperties is properties supplied to Create redis operation.
type CreateProperties struct {
	RedisConfiguration *map[string]*string `json:"redisConfiguration,omitempty"`
	EnableNonSslPort   *bool               `json:"enableNonSslPort,omitempty"`
	TenantSettings     *map[string]*string `json:"tenantSettings,omitempty"`
	ShardCount         *int32              `json:"shardCount,omitempty"`
	SubnetID           *string             `json:"subnetId,omitempty"`
	StaticIP           *string             `json:"staticIP,omitempty"`
	Sku                *Sku                `json:"sku,omitempty"`
}

// ResourceProperties is parameters describing a redis instance
type ResourceProperties struct {
	RedisVersion      *string           `json:"redisVersion,omitempty"`
	ProvisioningState *string           `json:"provisioningState,omitempty"`
	HostName          *string           `json:"hostName,omitempty"`
	Port              *int32            `json:"port,omitempty"`
	SslPort           *int32            `json:"sslPort,omitempty"`
	Properties        *CreateProperties `json:"properties,omitempty"`
}

// ResourceType is a single redis item in List or Get Operation.
type ResourceType struct {
	autorest.Response `json:"-"`
	ID                *string             `json:"id,omitempty"`
	Name              *string             `json:"name,omitempty"`
	Type              *string             `json:"type,omitempty"`
	Location          *string             `json:"location,omitempty"`
	Tags              *map[string]*string `json:"tags,omitempty"`
	Properties        *ResourceProperties `json:"properties,omitempty"`
}

type Sku struct {
	Name     SkuName   `json:"name,omitempty"`
	Family   SkuFamily `json:"family,omitempty"`
	Capacity *int32    `json:"capacity,omitempty"`
}

Given the two don't marry up, Properties is nil - and fails my tests :(
I take it the response needs to be fixed, rather than the API? As a side-note - it seems odd that a Get request returns a CreateProperties in the first place (given it implies it's Created it?)
Thanks!

For these sorts of bugs, can you file a corresponding bug against the Azure/azure-rest-api-specs where the Swagger specifications live? Then they can be pulled and used to update this SDK. Thanks.

@tombuildsstuff @colemickens The response JSON looks as expected, unless you've noticed a specific issue with the swagger, I would assume this is a bug specific to the GO sdk generated code.

@TimLovellSmith I don't understand, the structs in the parent post are generated from Swagger and don't align with the actual response posted.

@colemickens Yes they're generated from swagger, but I don't see anything in the swagger [ https://github.com/Azure/azure-rest-api-specs/blob/master/arm-redis/2016-04-01/swagger/redis.json
] that looks wrong. It specifies that the response of a PUT operation returning 201 is a RedisResource... which should be correct.

But the OP is doing a GET operation. The structs in Go look to be properly mapped to the Swagger spec that I'm looking at. The Swagger spec for a GET just doesn't match what the OP has posted above.

@colemickens How doesn't it match? GET also returns a RedisResource, same as PUT.

For example, according to the Swagger, the "sku" and "redisConfiguration" fields are NOT supposed to be sibling fields to "provisioningState". Yet they are siblings in the real response returned and shown above.

@colemickens
Ah, I think the problem is only I am interpreting the "x-ms-client-flatten": true directive in the swagger.

Ah-ha, thanks! In this case, I think I might agree then, it's possible the Go generator doesn't respect the x-ms-client-flatten field. @mcardosos can you tell us if this is the case?

Flattening is not currently supported in the Go generator

Thanks for letting us know.
Can we get an issue to track the addition of flattening then?

Looking again at this, shouldn't Create also return a RedisResource? Right now it returns an autorest.Response.

thanks @colemickens / @mcardosos / @TimLovellSmith - will do.

We've just checked, and it seems that this has been thoroughly solved. We'll close this issue out. If there is need for further work, feel free to reopen this issue.


three tikv crashes with version 2.1.0-rc.4

Bug Report
we met three (different) tikv crashes  after upgrading to version 2.1.0-rc.4
core dump is not enabled in our cluster, so a core file is not available for now.
but I have enabled it on the hosts with which crash had happened, so if crash happens again a core file may be attached later.
three different crash logs from kernel's dmesg:
Nov  1 19:08:55 slave93 kernel: pd-0[9056]: segfault at ffffffffffff0000 ip 0000558c4fed4985 sp 00007f5d855fbcb0 error 5 in tikv-server[558c4ef9d000+1671000] #硬盘有故障
Nov  5 00:32:58 slave83 kernel: pd-0[28039]: segfault at ffffffffffff0000 ip 000055aaefc01985 sp 00007f020f1fbcb0 error 5 in tikv-server[55aaeecca000+1671000]
Nov  6 15:59:29 slave94 kernel: grpc-server-2[39262]: segfault at ffffffffffff0000 ip 000055dfe607c985 sp 00007f0ae49fbcb0 error 5 in tikv-server[55dfe5145000+1671000]

The first one is due to problems with the hard disk, so the crash is expected
but there are no disk problems with the second and third one, especillay the third one: grpc-server crashes?
What version of  tikv are you using?
TiKV
Release Version:   2.1.0-rc.4
Git Commit Hash:   ff59513e059ad3772efef91b31892d4204795e05
Git Commit Branch: release-2.1
UTC Build Time:    2018-10-25 03:00:54
Rust Version:      rustc 1.29.0-nightly (4f3c7a472 2018-07-17)

Hi @darren
We are sorry for the issue. We have confirmed this is a bug of gRPC core library(v1.14.2). I have filed a PR to regress grpcio to v0.3(uses core library v1.7.2) which works fine.

one more crash (not grpc):
Nov 10 03:28:48 slave88 kernel: pd-0[3792]: segfault at ffffffffffff0000 ip 0000562aeb9e4985 sp 00007fa17fdfbcb0 error 5 in tikv-server[562aeaaad000+1671000]

wierd enough, one tikv crash causes another tikv to exit without any crash, last logs from the other tikv instance, no crash info from dmesg
2018/11/10 07:14:12.884 INFO transport.rs:258: resolve store 1515 address ok, addr <IP_ADDRESS>:20161
2018/11/10 07:14:12.885 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.885 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.885 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.885 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.885 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.885 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.886 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.886 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.886 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.886 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.887 INFO raft_client.rs:54: server: new connection with tikv endpoint: <IP_ADDRESS>:20161
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.911 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.912 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))
2018/11/10 07:14:12.912 WARN raft_client.rs:92: send raftmessage to <IP_ADDRESS>:20161 failed: Grpc(RpcFinished(Some(RpcStatus { status: Unavailable, details: Some("Connect Failed") })))

After upgrade to version rc.5 and the crash does not happen again, so close this for now.


Add an option to modify the gap between the numbering and the heading rather than a hard coded value

The gap spacing between the numbering and the heading was hard coded.
If someone wanted to change it without modifying the rest, he had to apply a show rule and recreate the entire structure of the heading (spacing above/below dependant of level, hanging-indent, ...) in particular by searching for values in the source file.

Thanks for the PR! I am totally with you that it's too hard to tweak the default show rules. However, I think this is a more fundamental problem and it deserves a more fundamental solution than adding ever-more parameters to elements all over the place.
We're currently in the R&D phase for expanding the styling system to allow you to do changes like this via more fine-grained show rules instead. While convenient now, I'd rather not add parameters which will likely become redundant in the future. It's possible that nothing comes of our endeavours, but then we can still add such a parameter in the future.
I'll thus have to ask for patience in the meantime.


draft: try debugging CI in kl-factory-ci

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.
[ ] Linkcheck has been run via zk linkcheck.

the debugged issue was resolved, closing the PR


Update Purview SDK for .NET

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Please add changelog.


Add new user Tom Hipkin

SSH key for tomhipkin is only 2048 bits and must be stronger

Closing in favour of https://github.com/alphagov/govuk-puppet/pull/4328.


⚠ File access (beta) has degraded performance

In 30259bd, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 2592 ms

Resolved: File access (beta) performance has improved in df7b481.


NAN 2.0 and io.js 3.0 support

I'm in progress on implementing NAN 2.0 support. I've made progress, current version works with Node.js and io.js 1
x, however it has failing tests on io.js 2.x. Later today I'm gonna begin a PR, where anyone can help me out with this, because I'm low on spare time right now.

https://github.com/node-ffi/node-ffi/pull/221

fyi: it's blocked because of the issues of nan 2.0 https://github.com/nodejs/nan/issues/389

@unbornchikken A fix has landed in nan master branch: https://github.com/nodejs/nan/commit/98d38c182e30dd9dae2f8568996fb334e0ddcefc

Yeah, I know. I've already finished that PR, but unfortunately it still fails to install on io.js 3.x, because ref module's nan 2.0 support is needed.

I did NAN 2.0 PR for ref today: https://github.com/TooTallNate/ref/pull/33 I hope that @TooTallNate is gonna merge that soon.

@unbornchikken PR was merged :)

Yeah, merged, but unfortunattelly it segfaults on io.js 3.0.1. We didn't have time to test it on the just released 3.0.2, though. So we're waiting for that PR gets released instead of merged. :)

So, it almost done, but unfortunattely we've an issue with an other dependency: https://github.com/TooTallNate/ref-struct/issues/18 We gotta wait for that fixed in order to release io.js 3+ support.

Hi all, I've noticed that everything is merged in v2 branch, when can we expect the 2.x version of ffi ?


feat(plugin-webpack): Generate a magic module with type definitions for webpack entrypoint constants

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project follows, as appropriate.
[X] The changes are appropriately documented (if applicable).
[X] The changes have sufficient test coverage (if applicable).
[X] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
The Webpack.DefinePlugin is used to inject globals that map to entry points. As typescript is unaware of these, declare statements are also needed for each entry point or the typescript compilation will fail. This PR attempts to auto-generate those types via a "magic module". This module is dynamically created in node_modules on generateAssets under the name @electron-forge/webpack-magic-constants. The old DefinePlugin behavior is preserved to ensure we don't break any existing code.
Fixes #704

@MarshallOfSound / @malept: Please leave a comment if you're generally good with this approach. If so I'll get tests written/passing and mark this ready for review

First, I like the concept of autogenerating a file for TypeScript based window constants.
I generally don't like the idea of writing to a magic folder in node_modules. Why not just write a folder inside the project and add it to a templated .gitignore?

First, I like the concept of autogenerating a file for TypeScript based window constants.
I generally don't like the idea of writing to a magic folder in node_modules. Why not just write a folder inside the project and add it to a templated .gitignore?

This was actually what I tried first, but found that I'd need to be able to safely predict the src folder (or another folder listed in include) to drop a ambient type file in
We could accept a config param that lets you specify the root dir. Let me see how we invoke tsc and see if there's another way.