use asyncio.Queue

Your comment says:
    # The regular asyncio.queue doesn't have a function to wait for space
    # in the queue, which we need so we don't iterate upstream until there
    # is space.

which isn't true.  calling await q.put(item) will wait (block) until there's room in
the queue for the specified item... if a queue maxsize is defined.

So yes, the comment is perhaps a bit unclear. Maybe it should read
"The regular asyncio.queue doesn't have a function that only waits for space in the queue"
The call await q.put(item) does wait, but it also puts the item into the queue. I wanted these things separate since...
Previous versions of asyncio-buffered-pipeline used asyncio.queue, but I couldn't think of a way to use it that made buffer_size accurate. Specifically, I wanted a buffer_size of 1 to be the default. However using asyncio.queue, with a maxsize of 1, then the number of items buffered by the buffered_iterator, would actually be 2, since at the point of calling await q.put(item), there could be one item already in the queue, and another in memory in the item variable.
The only way I could think to actually have a buffer size of 1, was to write my own queue that offered a way to wait for space, and only then iterated upstream to fetch the item once space was available.

I've changed the comment to read
# The regular asyncio.queue doesn't have a function to wait for space
# in the queue without also immediately putting an item into it, which
# would mean effective minimum buffer_size is 2: an item in the queue
# and in memory waiting to put into it. To allow a buffer_size of 1,
# we need to check there is space _before_ fetching the item from
# upstream. This requires a custom queue implementation.

Closing this issue, but feel free to re-open.

I understand your objection, and have, I think, fixed it (in a method similar to yours) at https://github.com/pjz/iterbuff/blob/main/iterbuff.py .  I also made it a decorator b/c I think that looks a bit nicer, but that's orthogonal to solving the maxsize-in-memory-at-once problem.

Ah interesting... so determining there must be space in the queue after geting from it, and then only waiting on this if the queue is full after puting to it, so never filling up "maxsize+1" of memory
I think I'm probably still anti using this pattern in this project though. It's probably mostly preference, but my reasons are:

It has a slightly different flow/logic for the case when the queue is full.

Its consumer communicates to the producer using 2 "signals": getting something from the queue, and setting the Event.

Which makes me wonder if there is a race condition between them somehow? Not saying there is, but I'm finding it hard to convince myself there isn't.

The 3 steps in my head that need to be ordered

Wait for space in the downstream queue
Iterate upstream
Put in the downstream queue

map clearly (for me) to the code in this project:
await queue_space()
value = await iterator.__anext__()
queue_put((None, value))

Also the decorator pattern. I did consider this... However, is there a chance that in a pipeline, if downstream generators don't finish, say, an exception is raised, then then tasks for the upstream will be sitting there waiting forever?

Ah! Although, for some reason I didn't use clear in the queue Events. So I am tempted to use them instead of creating new Event objects...

re: race condition:
Remember that there's only one execution thread through all of this, that can swap between tasks at any async/await boundary, so there's no race condition.
re: the looping:
Since the queue starts out empty, your steps 1,2,3 are safe to reorder as 2,3,1, which is essentially what my code in lines 57..63 does.
re: downstream generators not finishing:
I... guess?  but that's the same risk as any async code that spawns and manages a background task.  In your example code, if you raise an exception inside the for loop, after the print(val), you'll see a complaint about unfinished tasks in the background.  It won't stop the code from exiting - they're not real threads :)
Overall it's a bit of a toss-up I guess.  I think  mine is a slightly simpler implementation.  You do point out some valid deficiencies in the asyncio.Queue class, though (would adding a async def not_full(self) to the built-in Queue would be all you need?)


Just a big blank window

Installed via brew on macOS 10.15.7.

Running from Terminal:
GVA encoder info: AMD performance mode : 2
GVA encoder info: deleteSCDMetalContext : texture cache hits: 0, misses: 0
2021/10/18 14:48:27 OpenSession failed: LIBUSB_ERROR_NOT_FOUND; attempting reset
2021/10/18 14:48:31 OpenSession failed: LIBUSB_ERROR_NOT_FOUND; attempting reset
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x10d626539]

runtime stack:
runtime.throw(0x10d341e1e, 0x2a)
	runtime/panic.go:1116 +0x72
runtime.sigpanic()
	runtime/signal_unix.go:704 +0x48c

goroutine 17 [syscall, locked to thread]:
runtime.cgocall(0x10d2d2b80, 0xc00013bbc8, 0x200000003)
	runtime/cgocall.go:133 +0x5b fp=0xc00013bb98 sp=0xc00013bb60 pc=0x10d10f4fb
github.com/ganeshrvel/usb._Cfunc_libusb_claim_interface(0x7fcac80a0000, 0x7fca00000000, 0x0)
	_cgo_gotypes.go:229 +0x4d fp=0xc00013bbc8 sp=0xc00013bb98 pc=0x10d1f2b8d
github.com/ganeshrvel/usb.(*DeviceHandle).ClaimInterface.func1(0x7fcac80a0000, 0x10d1f3c00, 0x10d2d3500)
	github.com/ganeshrvel/usb/usb.go:643 +0x56 fp=0xc00013bbf8 sp=0xc00013bbc8 pc=0x10d1f6a56
github.com/ganeshrvel/usb.(*DeviceHandle).ClaimInterface(0x7fcac80a0000, 0xc00013bc00, 0x10d1f68ef, 0x7fcae6f295e0)
	github.com/ganeshrvel/usb/usb.go:643 +0x39 fp=0xc00013bc20 sp=0xc00013bbf8 pc=0x10d1f5499
github.com/ganeshrvel/go-mtpfs/mtp.(*Device).claim(0xc000114100, 0x7fcac80a0000, 0x0)
	github.com/ganeshrvel/go-mtpfs/mtp/mtp.go:140 +0x45 fp=0xc00013bc98 sp=0xc00013bc20 pc=0x10d220ec5
github.com/ganeshrvel/go-mtpfs/mtp.(*Device).Open(0xc000114100, 0x0, 0x0)
	github.com/ganeshrvel/go-mtpfs/mtp/mtp.go:170 +0xfa fp=0xc00013bd50 sp=0xc00013bc98 pc=0x10d2210fa
github.com/ganeshrvel/go-mtpfs/mtp.(*Device).Configure(0xc000114100, 0x0, 0x0)
	github.com/ganeshrvel/go-mtpfs/mtp/mtp.go:646 +0xf3 fp=0xc00013bda8 sp=0xc00013bd50 pc=0x10d224513
github.com/ganeshrvel/go-mtpx.Initialize(0x0, 0x0, 0x0, 0x10d3440c8)
	github.com/ganeshrvel/go-mtpx/main.go:31 +0x72 fp=0xc00013be10 sp=0xc00013bda8 pc=0x10d231112
main._initialize(0x0, 0x0, 0x0, 0x0)
	command-line-arguments/helpers.go:36 +0x2e fp=0xc00013be40 sp=0xc00013be10 pc=0x10d2ce9ee
main.Initialize(0x10e734010)
	command-line-arguments/kalam.go:27 +0x45 fp=0xc00013be78 sp=0xc00013be40 pc=0x10d2cf925
main._cgoexpwrap_a73366901861_Initialize(0x10e734010)
	_cgo_gotypes.go:62 +0x2b fp=0xc00013be90 sp=0xc00013be78 pc=0x10d2cf56b
runtime.call32(0x0, 0x70000e2eddc0, 0x70000e2ede58, 0x8)
	runtime/asm_amd64.s:540 +0x3e fp=0xc00013bec0 sp=0xc00013be90 pc=0x10d172d3e
runtime.cgocallbackg1(0x0)
	runtime/cgocall.go:332 +0x1a5 fp=0xc00013bf58 sp=0xc00013bec0 pc=0x10d10f8c5
runtime.cgocallbackg(0x0)
	runtime/cgocall.go:207 +0xc5 fp=0xc00013bfc0 sp=0xc00013bf58 pc=0x10d10f665
runtime.cgocallback_gofunc(0x0, 0x0, 0x0, 0x0)
	runtime/asm_amd64.s:794 +0x9b fp=0xc00013bfe0 sp=0xc00013bfc0 pc=0x10d1744bb
runtime.goexit()
	runtime/asm_amd64.s:1374 +0x1 fp=0xc00013bfe8 sp=0xc00013bfe0 pc=0x10d174741

goroutine 18 [syscall, locked to thread]:
github.com/ganeshrvel/usb._Cfunc_libusb_reset_device(0x7fcac8088000, 0x7fca00000000)
	_cgo_gotypes.go:607 +0x49
github.com/ganeshrvel/usb.(*DeviceHandle).Reset.func1(0x7fcac8088000, 0x3c)
	github.com/ganeshrvel/usb/usb.go:713 +0x4d
github.com/ganeshrvel/usb.(*DeviceHandle).Reset(0x7fcac8088000, 0x28, 0xc000095d88)
	github.com/ganeshrvel/usb/usb.go:713 +0x30
github.com/ganeshrvel/go-mtpfs/mtp.(*Device).Configure(0xc000114280, 0x0, 0x10d118e00)
	github.com/ganeshrvel/go-mtpfs/mtp/mtp.go:640 +0x213
github.com/ganeshrvel/go-mtpx.Initialize(0x10d640d00, 0x10d298a01, 0x100010d31ba80, 0x10d3440c8)
	github.com/ganeshrvel/go-mtpx/main.go:31 +0x72
main._initialize(0x0, 0x0, 0x10d636108, 0x10d4ae520)
	command-line-arguments/helpers.go:36 +0x2e
main.Initialize(0x10e734098)
	command-line-arguments/kalam.go:27 +0x45
main._cgoexpwrap_a73366901861_Initialize(0x10e734098)
	_cgo_gotypes.go:62 +0x2b
Checking for update
Update for version 3.1.15 is not available (latest version: 3.1.15, downgrade is disallowed).

Please comment your Laptop model, config and OS version

Same issue. MacBook Air (mid 2012) macOS Catalina 10.15.7 (19H1419)

Please comment your Laptop model, config and OS version

Not a laptop. iMac Pro (2017) macOS 10.15.7 as mentioned above
thanks

Having the same issue. Initially the window is blank, then release announcements appears, then window blanks out again (see screen recording). Tried both .app downloaded from main page and brew install. Same issue.
System Info
10.15.7 (19H1713)
MacBook Pro (16-inch, 2019)

More testing found that the window didn't blank out until the phone was connected to USB. I was able to clear the "what's new" but as soon as I plugged in my android device, the window blanked out.

Looks like this project has been abandoned.

I will be making a release for the M1 MacBook in a couple of weeks. Let's see if that fixes this issue?

Yes. I have tried that too. Here is a screen recording.
https://imgur.com/1UMYy5J

I'm getting this same issue after upgrading to MacOS Monterey on my intel MacBookPro 16-inch, 2019. The app is now unstable and unusable. This previously was not an issue for me with the same laptop on MacOS Big Sur.

See if this version helps?
https://github.com/ganeshrvel/openmtp-testflight/blob/main/OpenMTP-3.2.0/OpenMTP-3.2.0-alpha.1-mac.zip

That one just opens and immediately closes without even showing a window. And no, I did not have an android device connected. Crash report https://pastebin.com/41rKgTYN

I am looking into this issue. It should be an electron issue. I will fix this ASAP.

Any update on this? Do you have another build I can try?

I am looking into this issue. It should be an electron issue. I will fix this ASAP.

Hi @ganeshrvel. Do you have a fix I can test?

@githubjsorg could you send me the log file

Open your Terminal and run the following code:

zip -r -X ~/Desktop/OpenMTP-log.zip "$HOME/Library/Application Support/io.ganeshrvel.openmtp/logs/"

Attach the file OpenMTP-log.zip found in your Desktop folder here.

Also, could you install the other versions of the app from the Releases list and let me know what was the latest version that worked for you?
Releases list: https://github.com/ganeshrvel/openmtp/releases


Source Maps in node_modules package

I haven't had much luck being able to debug/set breakpoints in source compiled with create-scripts and thought my use case may be somewhat unique, so I wanted to ask it here.  If it's something I should take up with VSCode, I will, but I needed to start somewhere.
My setup is VS Code with an app created by create-react-app.  I can debug it just fine, and I hit my breakpoints, as expected, so source maps are indeed working.  However, I recently moved some of our components out into its own libraries, so they can be published separately and used by multiple apps.  So, now they look like (I've simplified the example):
app/
  package.json
  src/
    App.js

libA/
  components/
    package.json
    src/
      componentA.js
    lib/
      componentA.js
      componentA.js.map

Now, I can only set breakpoints in lib/componentA.js instead of src/componentA.js (pre-compiled source).  Is this something that I should be able to get working?
Any direction would be helpful.  Thanks in advance!
Edit:  perhaps it's related to https://github.com/facebook/create-react-app/pull/2355 ?

@JeremyGrieshop - Are you running the just-released CRA/react-scripts 3.3 or 3.2?  3.3 has a fix (#7022 -- full disclosure it's my PR) that is a partial fix for sourcemap issues in CRA apps.  Specifically, it fixes the case where node_modules dependencies don't have sourcemaps.
For node_modules dependencies that do have sourcemaps, there's more fixing needed. #2355 is on the right track, but the current source-map-loader package is apparently not maintained and unfortunately it has serious bugs which are addressed in this fork: https://github.com/Volune/source-map-loader/tree/fixes which I've been using (via customize-cra) for 6+ months with great results.
I've been planning a follow-up PR to #7022 which will fix #2355, but first I wanted to get some questions answered from sourcemap experts about how to handle relative paths from one node_modules dependency to another node_modules dependency.
Also before adding source-map-loader to CRA, there needs to be a long-term supported home of source-map-loader because although @Volune's fork works well, it's not officially maintained either. Luckily it's only one relatively short file so hopefully finding a home won't be too hard.  It may be short enough for the CRA maintainers to consider including it in CRA, but that seems like a last resort.

@JeremyGrieshop - Are you running the just-released CRA/react-scripts 3.3 or 3.2? 3.3 has a fix (#7022 -- full disclosure it's my PR) that is a partial fix for sourcemap issues in CRA apps. Specifically, it fixes the case where node_modules dependencies don't have sourcemaps.

I have not yet.  I literally saw that release and note about 20 minutes after I posted this.  I plan to try it out this weekend and find out, though!

For node_modules dependencies that do have sourcemaps, there's more fixing needed.

Unfortunately, this is the boat I'm currently in.  My node_module packages are my own that I generate source maps for, via direct babel compile.

#2355 is on the right track, but the current source-map-loader package is apparently not maintained and unfortunately it has serious bugs which are addressed in this fork: https://github.com/Volune/source-map-loader/tree/fixes which I've been using (via customize-cra) for 6+ months with great results.
I've been planning a follow-up PR to #7022 which will fix #2355, but first I wanted to get some questions answered from sourcemap experts about how to handle relative paths from one node_modules dependency to another node_modules dependency.

I'm very curious about your findings here, as I also have the unique situation where my node_modules package also has a dependency on another of my node_modules packages, which in turn has its own source maps!

Also before adding source-map-loader to CRA, there needs to be a long-term supported home of source-map-loader because although @Volune's fork works well, it's not officially maintained either. Luckily it's only one relatively short file so hopefully finding a home won't be too hard. It may be short enough for the CRA maintainers to consider including it in CRA, but that seems like a last resort.

I'll be happy to try anything out if you need feedback or testing.  Thanks for the reply!

@JeremyGrieshop - thanks for the offer of help!  I think at this point there are two blocking issues to getting this fixed:

source-map-loader seems to be unmaintained and its master branch is too buggy currently for use in CRA. Someone would need to take ownership of that code and merge a few PRs that have been pending for 1+ years, or would have to incorporate its ~150-ish lines of code into CRA or some other library. https://github.com/Volune/source-map-loader/blob/fixes/index.js is the code of the patch version that I'm using-- as you can see it's not much code, but still someone has to commit to maintaining it going fwd.
Even in @Volune's patch branch linked above, there's still a remaining blocking issue: how to handle sourcemaps of node_modules packages that in turn link to other node_modules packages.  I'm discussing this question with @loganfsmyth here: https://babeljs.slack.com/archives/C6CMS6M6U if you want to lurk or discuss.  Given that this is a relatively unusual case that affects relatively few npm packages, this issue could be deferred until later, but given that getting changes into CRA seems to take 6-12+ months, I was hoping to resolve it as part of the PR to include source-map-loader.

If you can help resolve either of these issues, your help would be very welcome!

Also, if you're looking for a workaround in the meantime, I use customize-cra to inject source-map-loader into my CRA config. Below is a simplified version of the config-overrides.js file that I've been using for the last few months.
const { override, useEslintRc, addWebpackModuleRule, addWebpackPlugin } = require('customize-cra');
const { produce } = require('immer');

const updateWebpackModuleRules = config => {
  const rules = config.module.rules;
  if (rules.length !== 3) {
    throw new Error('Unexpected CRA config. Exiting.');
  }

  const newConfig = produce(config, cfg => {
    const sourceMapLoader = {
      enforce: 'pre',
      exclude: /@babel(?:\/|\\{1,2})runtime/,
      test: /\.(js|mjs|jsx|ts|tsx|css)$/,
      use: 'source-map-loader',
    };
    const rules = cfg.module.rules;
    rules.splice(1, 0, sourceMapLoader);
  });

  return newConfig;
};

const overrides = [updateWebpackModuleRules];
module.exports = override(...overrides);

If you're not familiar with customize-cra, here's how to use the code above:

save it into config-overrides.js in your project's root folder
install the following packages:
npm i -D github:volune/source-map-loader#fixes immer customize-cra react-app-rewired
Update your package.json scripts to use react-app-rewired instead of react-scripts. Like this:

    "start": "react-app-rewired start",
    "build": "react-app-rewired build",
    "test": "react-app-rewired test",

@justingrant  This workaround absolutely worked without any effort - thank you!!!!
I can understand the longer-term dilemma of making it supportable by CRA.  If everyone dumped all of their wishlist into CRA, it would probably look a lot like, well, webpack.  As the React ecosystem grows, however, the trend of creating react component libraries will likely become more common place and I suspect more people will want the functionality of debugging them from larger projects / monorepo architecture.  Even more so now that VS Code is growing in its user base.  I hope to see something like this included out of the box.
Again, if there's anything I can do to help, I'd be happy to do so in a way that I can.  Thanks again for your help here, this will save me countless hours of console.log debugging lol.

Hi @justingrant,
is there a particular reason why you use volune/source-map-loader and not the normal source-map-loader module?

Yep. The current release of source-map-loader only supports absolute paths in a sourcemap's sources array but libraries are supposed to use relative paths. So it's kinda useless without fixing the relative-paths bug.
You can read more details in @volune's PR here: https://github.com/webpack-contrib/source-map-loader/pull/75
Unfortunately, source-map-loader is essentially unmaintained at this point-- no checkins since Aug 2018.  Lots of PR's queued up, but no maintainer seems to be home.  I (and others) have tried to ping maintainers but so far no response.

Yep. The current release of source-map-loader only supports absolute paths in a sourcemap's sources array but libraries are supposed to use relative paths. So it's kinda useless without fixing the relative-paths bug.
You can read more details in @Volune's PR here: webpack-contrib/source-map-loader#75
Unfortunately, source-map-loader is essentially unmaintained at this point-- no checkins since Aug 2018. Lots of PR's queued up, but no maintainer seems to be home. I (and others) have tried to ping maintainers but so far no response.

thanks mate, pretty useful.

@justingrant is there a way to get it working using the customize-cra api addWebpackModuleRule?
I'm trying to use this configuration but I keep getting errors:
const { override, useEslintRc, addWebpackModuleRule, addWebpackPlugin } = require('customize-cra');

const sourceMapLoader = {
    enforce: 'pre',
    exclude: /@babel(?:\/|\\{1,2})runtime/,
    test: /\.(js|mjs|jsx|ts|tsx|css)$/,
    use: require.resolve('source-map-loader'),
  };

module.exports =  override(
      addWebpackModuleRule(sourceMapLoader)
    )

and this is the error:

@middiu - If I remember correctly, addWebpackModuleRule didn't work for this case because source-map-loader needs to be injected in the middle of the CRA webpack rules (because the sourcemaps it emits need to be used as input to the Babel step that comes later), but addWebpackModuleRule only appends rules to the end.  That said it's been a while since I got this working so my memory may be fuzzy.  The code sample I posted above should work, however.

thanks again @justingrant.
Your snippet of code was not working for me, but I managed to get it working in this way:
const {
    override,
    overrideDevServer
  } = require("customize-cra");

  const fs = require("fs");

  const sourceMapLoader = {
    enforce: "pre",
    exclude: /@babel(?:\/|\\{1,2})runtime/,
    test: /\.(js|mjs|jsx|ts|tsx|css)$/,
    use: "source-map-loader"
  };

  const updateWebpackModuleRules = () => config => {
    const newConfig = {...config};
    newConfig.module.rules.push(sourceMapLoader);
    return newConfig;
  };

  const devServerConfig = () => config => {
      console.log(config);
    return {
      ...config,
      https: {
        key: fs.readFileSync(process.env.REACT_HTTPS_KEY, "utf8"),
        cert: fs.readFileSync(process.env.REACT_HTTPS_CERT, "utf8")
      }
    };
  };

  module.exports = {
      webpack: override(
          updateWebpackModuleRules()
      ),
      devServer: overrideDevServer(
          devServerConfig()
      ),
  }

of course the part around devServer and HTTPS is irrelevant for this issue.
Thanks a lot

OK everyone, I opened PR #8227 to add source-map-loader to CRA. Please add your feedback and/or votes!

Not stale. Just waiting for a maintainer to review #8227 which should fix this issue.

not stale. waiting for a maintainer to review #8227.

For what it's worth — I don't know much about source maps or webpack so take my message with a grain of salt —, but I've made the following changes so that sourcemap works in CRA in my lerna monorepo.
As suggested, I've tweaked the config of CRA but using smart-source-map-loader which I believe fixes some issues of source-map-loader. Maybe @ AlexanderOMara can expend on this.
const enableWorkspaces = require('react-app-rewire-yarn-workspaces')

module.exports = function override(config, env) {
  config.module.rules.splice(1, 0, {
    enforce: 'pre',
    exclude: /@babel(?:\/|\\{1,2})runtime/,
    test: /\.(js|mjs|jsx|ts|tsx|css)$/,
    use: 'smart-source-map-loader',
  })
  return enableWorkspaces(config, env)
}

I've also added this line to the webpack config of other packages used by CRA, inspired by this https://github.com/webpack/webpack/issues/3603#issuecomment-357664819
{
  output: {
    // ...
    //fixes source maps
    devtoolModuleFilenameTemplate: '[absolute-resource-path]',
  },
  devtool: 'cheap-module-source-map',
  // ...
}

Not stale. Waiting for a maintainer to review #8227 which should fix this issue.

Not stale.

Not stale.

The stale bot is one of the best ways to disrespect the community.

Not stale!

As of<EMAIL_ADDRESS>the config-overrides.js will no longer work and will throw the "Unexpected CRA config. Exiting."  The rules that get passed in now have a length of 2 now.  I didn't know if the new rules would matter much and just took a chance and commented out the throw new Error('Unexpected CRA config. Exiting.');.  Everything still works as expected, but I thought @justingrant  may have a better suggestion here.

The stale bot is one of the best ways to disrespect the community.

On going for over a year now. Has anyone got any interest in fixing support for source-map from imported modules?
My dev team and I use a private npm registry to split separation of concern into many packages, and i'm positive many many others do too!
I imagine this issue has led to many people moving away from CRA.

So I also have this problem. I created a sample repo here https://github.com/vonkanehoffen/cra-monorepo-sourcemap-bug that demonstrates it if that helps any :-)
...I think this is the same issue anyway.
Very interested to see if #8227 makes it in! :-D


Update to use latest sync-android

Before we release the cordova plugin, we should update the plugin to use the latest release of sync-android so the plugin benefits from bug fixes and optimisations in the latest release.

Issue moved to cloudant/sync-cordova-plugin #46 via ZenHub


WMS ID: 6001 SkillsetTracker live lab updated

Hi! Please include the workshop's WMS ID in the title of your PR. Thanks!

WMS ID added. Thank you!


fix(launcher): task promises run parallel

fix for #5145 + cosmetics
@IgorMinar don't know yet how to write tests for this. If you let me know the way, i could add them.

@googlebot I signed it!

added some kind of unit tests for this case, i hope its acceptable


Possible to build a Blind index using blast?

We have security requirements that require the use of encryption at rest. We would like to be able to build an index of the unencrypted plain text, and then ship the index and the encrypted data files, without leaking the plain text. Is this something that is possible with blast/bleve?

Hi,
While Blast will be able to encrypt HTTP and gRPC communications using TLS, it is difficult to encrypt the index itself. I'll create an issue about using TLS.
Thanks.


dice_score vs multi_class_dice_score -- Mismatch detected

Hey team,
Writing to you on behalf of some collaborators. I don't have the full picture yet, I will post asap (eg config file), when they share with me. But thought I will reach out, in case any of you have already been thinking of this / encountered this issue.
Context:

2 class segmentation problem.
They trained their model, went to the logdir to plot the validation metrics
multi_class_dice_score is mainly < 0.8, while dice_score mainly > 0.8

Could be a bunch of things.. maybe class imbalance? empty_score param?... Any thoughts?
Will update this thread asap while receiving more info from them.

 One class has a lower Dice score than the other but has a relatively low volume. E.g. class 1: 60% Dice score and class 2: 90% Dice score -> Multi-class dice score 75% but if class 2 represents most of the positive class pixels (bigger volume), the Dice score will be much closer to 90%.

Slightly tangential but I was looking at the implementations of the dice_score and DiceLoss and I noticed that both of them do include the background while computing the Dice score. Consider a 2-class lesion seg problem with the background as class 0 and lesion as class 1. Then, including the background would offset the Dice score to a much higher value, right (because the background will dominate the lesion)?
I am training models using Monai which has an option of excluding the background and when I am comparing the results with the models trained with ivadomed, there is a huge difference in the DiceLoss and dice_score. Hence the motivation for this comment. I think that we should add a boolean argument to ask whether to include the background or not. Any thoughts?


Add missing logic for DefaultConfigOverwrite

We only want to support the policy.yaml file passthrough for PlacementAPI
The kolla config files are modified to move the supported files in place.
Implements: OSPRH-2503

It will be nice if we also clean comments about DefaultConfigOverwrite in https://github.com/openstack-k8s-operators/placement-operator/blob/main/controllers/placementapi_controller.go#L1177

Done.

/test placement-operator-build-deploy-kuttl
infra operator failed to start
++ oc get csv -n openstack-operators -o 'jsonpath={range<EMAIL_ADDRESS>++ grep -E '^infra-operator\.v'
+ CSVNAME=
+ '[' -z '' ']'
+ echo NOTFOUND
+ exit 1
+ rc=124
+ popd
~/install_yamls
+ exit 124
make[1]: *** [Makefile:511: wait] Error 124
make[1]: Leaving directory '/alabama/install_yamls'
make: *** [Makefile:977: memcached_deploy] Error 2


Issue when running the "!./build_and_push.sh" cell in the "audio" notebook.

The pip install takes forever to run.
Workaround:

Change the line "torch==1.6.0" to "torch==1.8.0"
Change the line "torchvision==0.7.0" to "torchvision==0.9.0"

Hi, many thanks for the comments. will update after I tested it!


OpenVPN client credentials cannot be renewed or deleted

Currently every time client credentials expire we have to create new credentials with:

no possibility to delete the old ones
no possibility to renew the old ones or use the same name as existing credentials

In the long term this leads to the spawning of a lot of useless credentials ( number of users X number of years ).
I don't know which is the preferred behaviour (delete or renew) but any of them would be really useful.

Yes, this will help a lot the day-by-day activities and is a very nice good first issue.
I guess that the culprit  is the function CreateUser that should take the parameter overwrite in order to force the recreation/upload of the certificate with the same name.


Error: Could not parse package: '--- org.projectlombok:lombok (n)' (1)

Currently using v0.8.0. The action is failing with the following error
Error: Could not parse package: '\--- org.projectlombok:lombok (n)' (1)
Dependency output
compileClasspath - Compile classpath for source set 'main'.

+--- org.projectlombok:lombok -> 1.18.16

@mikepenz

`/home/runner/work/_actions/mikepenz/gradle-dependency-submission/v0.8.0/webpack:/gradle-dependency-submission/lib/parse.js:68
          throw Error(`The given '${pkg} can't be parsed as a gradle package.`);
 ^
 Error: The given '\--- org.projectlombok:lombok (n) can't be parsed as a gradle package.
    at parseGradlePackage (/home/runner/work/_actions/mikepenz/gradle-dependency-submission/v0.8.0/webpack:/gradle-dependency-submission/lib/parse.js:68:1)
     at parseGradleDependency (/home/runner/work/_actions/mikepenz/gradle-dependency-submission/v0.8.0/webpack:/gradle-dependency-submission/lib/parse.js:166:1)
     at parseGradleGraph (/home/runner/work/_actions/mikepenz/gradle-dependency-submission/v0.8.0/webpack:/gradle-dependency-submission/lib/parse.js:117:1)
     at /home/runner/work/_actions/mikepenz/gradle-dependency-submission/v0.8.0/webpack:/gradle-dependency-submission/lib/process.js:195:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/mikepenz/gradle-dependency-submission/v0.8.0/webpack:/gradle-dependency-submission/lib/process.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)`


Added texture pack support

Needs to be hooked by @Desno265

Doesn't work. However thanks for trying!
Closed.

i have the solution ;)


Add git aic subcommand

Besides executing aicommits to start the executable, a user can also use git aic. aic was chosen because git aicommits might be a bit too much to type. Since this is intended to be used with git repos, putting it under the git ... namespace made sense to me.

An alternative subcommand that I was thinking of would be git commitai, which would take advantage of the user's muscle-memory or shell completions using git commit -- just 2 extra keystrokes to decide to let AI write the commit. But commitai sounds like a completely different project than aicommits :shrug: git aic felt like something that would be easy to use and easy to remember.

Interesting. I'm a bit conflicted on whether to add this as an explicit subcommand since folks can always create their own alias for type aic for example. What do you think @privatenumber?

Good point about users being able to create their own alias. I suppose it depends how "magic" the results of installing this package should be :laughing:
I may have put a bit of personal bias into this PR.

git config --global alias.aic "aicommits"

Closing this since we recently released an aic alias:
https://github.com/Nutlope/aicommits/pull/148


Cannot add users to the Pull Request Whitelist

Problem:
People's names/teams other than the first team I'm in (Owners, alone) do not appear in the settings area for whitelisting things. So I cannot set anything up as the owner. The only solution I can see it put everyone (me, support, admins, approvers) into one big team with full permission (since I need full permission)

I can already bet that this is because the autocomplete is ignoring anything other than the first team it finds that I am in (which is Owners), but of course I am also part of the developers team - which it is just ignoring.
This is also an issue when writing an issue and trying to @ mention someone - no autocomplete appears so I have to write them manually. Perhaps a UserService of some sort on the front end needs to be abstracted out, that can be used by different modules in Gitea: UserService.GetAllUsersInOrg() UserService.GetAllUsersInTeam() UserService.GetAllMyTeams()

@lunny Am I using this the right way?
I have this problem right now at work, where I want my boss to be able to approve PR's, but not have full admin permission over the repo (that's for me) so we are in separate teams, but I cannot set up the settings for the branch protection.

I have this problem right now at work, where I want my boss to be able to approve PR's, but not have full admin permission over the repo (that's for me) so we are in separate teams, but I cannot set up the settings for the branch protection.

I've just checked. Gitea in fact doesn't let you add a user to whitelisted reviewers unless they have write access to the repository.

------------------------------------------------

The open question is: should this be allowed?
@worthy7  I understand your use case. I think I'd like something like that too. Let's see what others think.

@worthy7 You can actually do this if you add your boss to a team with read-only access to the repository (you must include PR in the team permissions, as well as code).
Your boss will be able to approve your PRs but not merge them (perhaps this can be done with the mergers whitelist as well, I didin't try that).

Anyway, there's a PR now to allow that action for individual uses, but it (if accepted) may take some time to see light.

Thanks, the reason why I haven't separated teams for my boss is because of the annoying autocomplete issue where @mentions only work for those in your team.
My boss and the others are new to things like git and I'm trying to ease them in as simply as possible...

Mmm......... never heard of that @mentions limitation. I'm browsing through the code and I don't see anything like you describe.

https://github.com/go-gitea/gitea/issues/3443

Oh, but teams and organizations are different things.
Besides, I've just tested in my server (I've got latest 1.10.0-dev) and mentions do send notifications for users in or outside the org; it's only that the user is not shown in the "autocomplete" feature.

@guillep2k ? Yea my issue is not with notifications... it's with the fact that autocomplete doesn't show other people outside of your "first" assigned team.
For me that means i see nobody because I'm in the admin team, alone, and in the other teams. But I just deal with it. I don't want it to be difficult for my colleagues though.
Anyway this issue is just about what we said above

@worthy7 which version are you using?
@guillep2k Maybe we need a  back port.

@lunny if this issue is about the autocomplete, then @worthy7 is right in that it's not showing every user in the autocomplete (not even in master). About the @mentions permissions.... I filed #8303 ... also present in master. I'll see if I can PR for that, then we can backport.
@worthy7 The list of users available in the autocomplete is sent in full to the browser every time a comment box appears (even if the user don't write a comment) so the list shows up with no delay the moment you type in @. It's a performance issue not to show every possible user every time. Imagine a site with hundreds of users (not unheard of) in a public repo.

@lunny 1.9 I think
@guillep2k Yea, the mentions feature in general shouldn't have been accepted as a PR IMO, it barely fulfills the feature requirement really. It needs to be pinging an API for the results.

Changed the name of the issue since we now identified why (I think?)

Since #8398 merged, I will close this.


PDP: List supported db connection string arguments

We support a different set of db connection string arguments, depending on the database. Should be documented as a reference separate of configuring/setting the db connection string.
Slack conversation: https://prisma-company.slack.com/archives/C01UR43BV6W/p1656354831111829

👋 we're cleaning up our backlog of issues and are closing everything older than two years. If you still feel that this issue is relevant, please feel free to re-open and our team will take a look. Thank you!


To align Contact us page properly

In current design, the contact us page is not properly aligned.

I will set margins and align it properly and make sure it'll be responsive.
Can you please assign this issue to me..
GSSOC 2023 :)

Hey i would like to work on it under gssoc 23, please assign me this task.


Run pipeline with old version qemu 3.1.1-2.fc30 again.

Related to https://github.com/multiarch/qemu-user-static/issues/91 .

It looks good to me.
$ docker images
REPOSITORY                   TAG                           IMAGE ID            CREATED                  SIZE
multiarch/qemu-user-static   register                      17e93114d720        Less than a second ago   1.25MB
multiarch/qemu-user-static   3.1.1-2                       064a9d8da3e3        1 second ago             197MB
multiarch/qemu-user-static   latest                        064a9d8da3e3        1 second ago             197MB
multiarch/qemu-user-static   x86_64-xtensa                 4ffcba02be2c        14 seconds ago           6.25MB
multiarch/qemu-user-static   x86_64-xtensa-3.1.1-2         4ffcba02be2c        14 seconds ago           6.25MB
multiarch/qemu-user-static   xtensa                        4ffcba02be2c        14 seconds ago           6.25MB
multiarch/qemu-user-static   xtensa-3.1.1-2                4ffcba02be2c        14 seconds ago           6.25MB
...


Add option to edit Inventory items

with this you can change wear, seed, stattrak, nametag even stickers of any skin added to inventory.
Screenshots: https://imgur.com/a/RgRQD4p
ToDo:

[x] add option to change wear of each sticker
[x] add preview of stickers
[x] drag and drop stickers
[x] stickers search box
[ ] change other items settings like: agents patches, service medals date of issue, etc..

based, redpilled pepsimod approved

there errors

there errors and are u sure its just editing the inventorychanger.cpp file?

he'll fixed dw

there errors and are u sure its just editing the inventorychanger.cpp file?

been waiting on someone to try this after I did, I thought I did something wrong haha.

Sorry guys, my build uses newer version of imgui which has "begin disabled" and "scroll to item" features, I retro fitted this PR to work with osiris' current version of imgui.
https://imgur.com/2OuPWhh

Sorry guys, my build uses newer version of imgui which has "begin disabled" and "scroll to item" features, I retro fitted this PR to work with osiris' current version of imgui. https://imgur.com/2OuPWhh

i just tried it and im getting errors on should edit im pretty sure i did everything right. i had less errors then  the first time i tried before you made changes to correct it but yeha

with this you can change wear, seed, stattrak, nametag even stickers of any skin added to inventory.
Screenshots: https://imgur.com/a/RgRQD4p
ToDo:

[x]  ~add option to change wear of each sticker~
[x]  ~add preview of stickers~
[x]  ~drag and drop stickers~
[x]  ~stickers search box~
[ ]  change other items settings like: agents patches, service medals date of issue, etc..

Sorry guys, my build uses newer version of imgui which has "begin disabled" and "scroll to item" features, I retro fitted this PR to work with osiris' current version of imgui. https://imgur.com/2OuPWhh

how do you update imgui?

how do you update imgui? can u link me ur discord
you don't need to update imgui, this PR is working fine with the current version of imgui.
but if you need to update it, just download latest version from github and replace files (except files that hs _impl in their names and imconfig)

I get  3 errors when building

how do you update imgui? can u link me ur discord

you don't need to update imgui, this PR is working fine with the current version of imgui. but if you need to update it, just download latest version from github and replace files (except files that hs _impl in their names and imconfig)

ah, ok ok  thanks man. i just want that sexy black thing

I get 3 errors when building

In my commits I exposed "passesFilter" to a higher scope, you should do like this:
https://github.com/danielkrupinski/Osiris/pull/3430/commits/57043ac0e5012b1d05f4fd646e34826382abe1fc#diff-589354681a3822069e83d96ed1f9957aaaaa733af2bccc6e27d11cd0515a604aR808-L848

I get 3 errors when building

In my commits I exposed "passesFilter" to a higher scope, you should do like this: 57043ac#diff-589354681a3822069e83d96ed1f9957aaaaa733af2bccc6e27d11cd0515a604aR808-L848

I fixed it, it just forgot to delete something that i shoudlve

i don't think that "Name Tag", "Sticker" needed to be in the editor, because there's an item to rename all weapons or add stickers

@Metaphysical1 i guess now we have some variable name conflicts with the updated source. can u please check and fix it?

plz fix for new update

@Metaphysical1 fix pls yesmen

Problem is on StaticData.h stuffs, any1 willing to help fix?

Problem is on StaticData.h stuffs, any1 willing to help fix?

add me on discord, n0verify#6666
unrelated, but i see you have my old osiris paste in your forks :P ftp_loader

n0verify#6666

xD yeahh, my older build has some features from ftp

doesn´t work for now. hopefully soon update (03-23-2022)

@Metaphysical1
Hello man. Would you like to update with coll option? I can't fix some aspects myself, so I'd like to see your solution

Can you make my life easy and just upload the InventoryChanger.cpp with you're code in it too?

any idea how to fix this?

when i compile and run it says "cannot find pattern #12" and when i press ok csgo closes couldnt find a solution and im not at all good at coding

how would one go about pasting this into the new version?

dosen t work


Event series with frequent events over several months: design challenge for S&M Live Performances

Background
Smoke & Mirrors Live Performances are happening from April-September in the gallery.
These performances are by different performers, with multiple sessions over multiple days.
It is not feasible to treat this as an event with schedule, as the timeframe is too long, and to make the schedule usable would require Content Editors to delete past performances (which is not what we want).
I propose turning this

into an Event Series, so that we can:

Make contributor/performers more visible
Retain the past events
Minimise ongoing efforts of content team in having to pare back a really long schedule after performances

Problems to be solved
One of the major problems is that this approach is photography-greedy. We would need:

a featured image for the Event Series
An image for each event, e.g. Performance by Dr Gustav Mahler
A headshot for the contributor/performer (optional)

EXAMPLE 1
This screenshot is an example of why this might be a problem if we have one image to represent everything (if we have events lined up for several months, using the same image, it would be a wall of repeating images:

EXAMPLE 2
We could develop an approach where it is possible to not display a promo image in the card, as shown here:

We would then be able to use the same image on each event, with the caveat that this would be a bit weird where we list upcoming events (home, /whats-on and /events)
But this approach would allow photography to be done independently of the perfomers, with a focus on more audience-le group shots, rather than performer-focussed shots.
We could do this now, but Alice has pointed out that she is unable to publish an event without a promo image, and there's no way to not display an image on the card.
TODO

[ ] Discuss photography approach with Ben and @dannybirchall
[ ] Decide whether we want to try to use a no-image card + repeat featured image across all events
[ ] Experience team to think about how we might test putting 'Event Series' card on listing pages, rather than individual events (similar to Daily Tours card)
[ ] Redirect /events/XK7jkxIAAMAbQC9L to new Event Series page (once created)

To connect the event series to the exhibition page, we will be need to be able to add the event series content type as well as events to the 'in this exhibition' section of the exhibition page;
Currently it's locked to events content type only , as shown in this screenshot

What if we display the contributor card below each event to 'make contributor/performers more visible'? This model would fit nicely for 'Why music' festival in future.


[@kadena/graph] Performance improvements for Prisma queries

With this change, Prisma only queries the fields that were requested from the GraphQL query.
With the help of @hayes: https://github.com/hayes/pothos/issues/1131

It is indeed a bit weird that we need to individually select the fields in each object, but I saw the reply on https://github.com/hayes/pothos/issues/1131.
Everything looks good 🙌🏽


APOC conditional procedures don't yield results if

 Issue by InverseFalcon
Wednesday Dec 04, 2019 at 23:49 GMT
Originally opened as https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/1365

Expected Behavior
When using apoc.when(), apoc.do.when(), apoc.case(), and apoc.do.case(), we would expect that we would always have a row present after the call so we can continue working in the query.
Actual Behavior
For a non-empty query string, when RETURN isn't present in that string that end up being executed, nothing is YIELDed in the query, effectively wiping out the row and shortcircuiting any further operations.
(note that empty query strings, such as a '' for the else part, behaves as expected...the YIELDed value is present for the row, it is just an empty map)
How to Reproduce the Problem
Provided there as at least one node in the graph:
MATCH (n)
WITH n
LIMIT 1
CALL apoc.do.when(true, 'REMOVE n.nonExistent', '', {n:n}) YIELD value
RETURN value

Because the query string executed is non-empty and does not RETURN anything, nothing is YIELDed, so the row is wiped out and the query doesn't return anything.
This seems like unexpected and unwanted behavior. We do not want this to act as a filter, if that's needed then it can be handled outside of the procedure call.

This is now fixable in pure Cypher;
Your query can now be written as:
MATCH (n)
WITH n
LIMIT 1
OPTIONAL CALL apoc.do.when(true, 'REMOVE n.nonExistent', '', {n:n}) YIELD value
RETURN value

Then a null value will be returned :)


BLADE-604 inline

Just started reviewing :)

sent here: https://github.com/gamerson/liferay-blade-cli/pull/1187


My wallet doesn't show the correct amount of MYST [bug]

I made a top up in August this year (20 MYST), at that time the operation was concluded correctly but now I can’t see my correct balance anymore, I barely used the vpn since then and I had my identity backed up on the cloud, no matter how many time I restore the identity the amount of MYST now is 0.98. I also had my ID connected to my smartphone and my laptop and I'm sure that the balance was correct also in the Android App but now my devices show the wrong amount of MYST. I'm sure that this summer I had something like 21 MYST on my account and I didn't use the vpn since then.
Steps to reproduce the behavior:

Go to 'Settings>Mysterium ID>Restore from Backup
Select my .json file
Insert my password
After the identity is restored the wallet shows 0.98 MYST.

I should have 20.98 MYST instead of 0.98 because I topped up 20 MYST in August when I had only 1 MYST on the account and since I used the vpn only a few times and for a very small periods of time for browsing it's reasonable that I've spent only 0.02 MYST. Now I want to use the vpn but my balance is wrong.
I lost my logs when I formatted my desktop pc few weeks ago. On my laptop (it's not the device I used for the top up) I have the logs dating back to few days after my transaction and they shows that I've imported the identity of my recent top up:
The day of the top up I back up the ID I had on the laptop because it contains a few MYST I didn't want to lose:
[2021-08-19 14:00:48.173] [info]  [32m[SUCCESS] [0mIdentity exported to file: C:\MY BACKUP PATH\Mysterium ID\Few Myst\LaptopIdentityNumber.json
Five days later I import the ID that I had on my desktop with the topped up wallet:
[2021-08-24 10:24:49.227] [info]  Spawning a child process:  C:\Program Files\MysteriumVPN\resources\static\bin\myst.exe cli --agreed-terms-and-conditions --tequilapi.port=44050 identities import MY PASSWORD 'C:\MY BACKUP PATH\Mysterium ID\ToppedUpIdentityNumber.json'
[2021-08-24 10:24:50.099] [info]  [32m[SUCCESS] [0mIdentity imported: ToppedUpIdentityNumber

Desktop PC OS: Windows 10

App Version 10.1.0

Laptop PC OS: Windows 11

App Version 10.1.0

Smartphone OS: Android 10

App Version <IP_ADDRESS>120

In addition I have the summary of the transaction related to my top up in this link: https://www.blockchain.com/btc/tx/f8e21576937d7d1aa231e3f2d8a676195db8e6e152f3696534402738f037814e

Hi @giu176!
I'm sorry to hear this. We will work on this issue but to solve your problem, we'll deposit 21 MYST to you so you can continue to use Mysterium dVPN. Could you please share your ID with me so we can proceed? You can find it on your profile.
After I receive your ID, it'll take 2-3 weeks to deposit that amount and I'll let you know as soon as it's done. Thanks again for reporting this issue!

Hi, thanks for the quick response!
This is my ID: 0x5697fb85722d7ce318ecb26b7ae2c63719a82e8e
I really appreciate your efforts and the dvpn in general because it worked very well every time if it weren’t for this issue.
I also like your customer service.
Kind regards,
Giulio.
From: Furkan Akyurek @.>
Sent: Wednesday, 22 December 2021 10:13
To: mysteriumnetwork/mysterium-vpn-desktop @.>
Cc: giu176 @.>; Mention @.>
Subject: Re: [mysteriumnetwork/mysterium-vpn-desktop] My wallet doesn't show the correct amount of MYST [bug] (Issue #235)
Hi @giu176 https://github.com/giu176 !
I'm sorry to hear this. We will work on this issue but to solve your problem, we'll deposit 21 MYST to you so you can continue to use Mysterium dVPN. Could you please share your ID with me so we can proceed? You can find it on your profile.
After I receive your ID, it'll take 2-3 weeks to deposit that amount and I'll let you know as soon as it's done. Thanks again for reporting this issue!
—
Reply to this email directly,  https://github.com/mysteriumnetwork/mysterium-vpn-desktop/issues/235#issuecomment-999412280 view it on GitHub, or  https://github.com/notifications/unsubscribe-auth/AO72IY2T75MYTB2TKON5EYTUSGJDFANCNFSM5KKZXNDQ unsubscribe.
Triage notifications on the go with GitHub Mobile for  https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 iOS or  https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub Android.
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AO72IYYMTOIPMU53L7JCJK3USGJDFA5CNFSM5KKZXND2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHOI5EOA.gif Message ID: < @.> @.>

me too, i got the same error. Tried to contact you guys but no reponse

Sorry to hear that @leo1in88. Could you please the transaction information so we can help you?


Workbox not defined in ServiceWorkerGlobalScope in Version 5.0.0

Library Affected:
workbox-cli 5.0.0 - generateSW command
Browser & Platform:
all browsers
Issue or Feature Request Description:
I am migrating from 4.3.1 to 5.0.0 and tried the inlineWorkboxRuntime option.
However I am getting Uncaught (in promise) ReferenceError: workbox is not defined. for v5 cli.
Facing this error inside the file mentioned under importScripts option.
Workbox 4.3.1
importWorkboxFrom: "local",  importScripts: ["sw-custom.js"]
Workbox 5.0.0
inlineWorkboxRuntime: true, importScripts: ["sw-custom.js"]
Content of sw-custom.js
workbox.setConfig({ 	debug: true });
This is because workbox is being minified and workbox as a variable is not available.
I can see some minified variables like G,g,B,T etc in the debugger for the ServiceWorkerGlobalScope.
Possible Fix
I think the inlineWorkboxRuntime option also needs to minify contents of importScripts option.
Please let me know if you need any further inputs from my end.

I am having the same issue and just downgraded to 4.3.1.
and the documentation here https://developers.google.com/web/tools/workbox/guides/codelabs/webpack has not been updated for version 5

You can set mode: 'development' or mode: 'production' in the v5 generateSW configuration to toggle between the Workbox runtime that has extra logging enabled and disabled.
Sorry about that not being clear; we should add something to https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-v4 to call this change out explicitly.

(And to get to the original question: we don't have any plans to include the importScripts URLs as part of the generated service worker bundle; for one thing, you can provide a third-party origin URL as the script value, and it doesn't make sense to bundle a remote URL. You can continue using importScripts with generateSW in v5, but you should not make any assumptions about symbols that might be available in the global scope.)

@jeffposnick  - I have a few follow up questions

If the importScripts URL is local to my project and not a third party url then people would expect it to get inserted inline to the generated SW file.
Can this be taken as a feature request?

Also you mentioned that "You can continue using importScripts with generateSW in v5, but you should not make any assumptions about symbols that might be available in the global scope". If that is the case, I think we would not be able to write any code which would require Workbox reference. At max may be we could refer to global service worker context and write some code around that.
To me it sounds like importScripts is practically not useful when inlineWorkboxRuntime: true option is set.
So I think the library could throw a error of unsupported config combination error in this case or
at least a warning that this combination would not yield desired results.

I'm not sure that that's a reasonable assumption. If you want to use Workbox in that fashion, I'd recommend switching to the injectManifest mode. In that mode, you have full control over the contents of your service worker file (including inlining whatever code you want), and Workbox just handles replacing the self.__WB_MANIFEST variable with the actual precache manifest based on your build config.

Folks have historically used importScripts for pulling in non-Workbox code, like code for push notifications. They can continue doing that in v5 with inlineWorkboxRuntime: true if they want. Disallowing that entirely would be too strict.

For your particular use case, I think you're going to have a better time switching to injectManifest and following the info at https://developers.google.com/web/tools/workbox/guides/using-bundlers to create a bundle of your service worker file using ES imports.


EDGE-891: global edge provider integration

The diff should be looking a lot better now

The code looks good to me, just add some unhappy test scenarios

Added some test scenarios, have to fix one of them... It seems that it's adding an empty struct to the bundle, not sure why. If you run the tests you'll see what I mean

The builds don't run because it's a pull request from a fork, not within the same repository :(
@ychen-atlassian would it be hard to support forked repos as well?

We shouldn't run builds with code from arbitrary PRs from arbitrary forks. Instead we should give people proper permissions for this repo. It's easier to work that way anyways.

We shouldn't run builds with code from arbitrary PRs from arbitrary forks. Instead we should give people proper permissions for this repo.

We won't be giving these permissions to people outside Atlassian, so we should then lock down PRs to the members of the same Atlassian group as we configured for pushing branches to this repo. Also, "Pull requests, issues and comments welcome" in https://github.com/atlassian/voyager/blob/master/README.md is misleading, it's better to call out that pull requests are not "welcome" from people outside Atlassian.

Pushed the branch to the Voyager repo and raised a new pull request #162
@cetanu please continue work there.


Integrated Terminal Suppresses Windows Crash Reporter

Issue Type: Bug
Steps to reproduce:

Open VS Code
Open Integrated Terminal
Run A Program That Crashes*

Expected Result: The "test.exe has stopped working" report that allows the user to launch a debugger.
Actual Result: Nothing. The program silently fails, forcing the user to repro in a cmd.exe window or to attach the debugger before the crash (if possible).
*A segfault will suffice. Here's a C program you can use if you don't have any buggy software handy:
#include <stdlib.h>

int main(void) {
    int* ip = NULL;
    return *ip;
}

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:35:40.560Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
AMD Phenom(tm) II X4 945 Processor (4 x 3010)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
8.00GB (3.59GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe C:\Users\Bernard\Desktop\volta.code-workspace

Screen Reader
no

VM
50%

Extensions: none

This is likely related to winpty, tracking in https://github.com/Microsoft/vscode/issues/45693


refactor(core, proto)!: define app genesis state in proto

Summary
Defines astria.protocol.genesis.v1alpha1.GenesisAppState, replacing the Rust-as-JSON definition.
Background
All protocol relevant Astria types are supposed to be defined in Astria's protobuf spec. With https://github.com/astriaorg/astria/pull/1285 having redefined the memos as protobuf message, this patch migrates the last type to protobuf spec.
Changes

Define astria.protocol.genesis.v1alpha1.GenesisAppState and related protobuf messages
Remove the astria-core::sequencer::GenesisState module
Update Sequencer in terms of the protobuf type
Update all charts and snapshots (especially the genesis template)

Testing
All tests have been updated to use the new types, including snapshot tests. The genesis state is only read at init-chain and does not affect the evaluation of the state machine. Hence no tests should change as long as the same data is passed in (which is reflected by tests-breaking-changes leading to the same hash).
Breaking Changelist
This is a breaking change because an old sequencer would not understand a new (json-formatted) genesis app state and vise versa.
Related issues
Closes https://github.com/astriaorg/astria/issues/1347

Approving, with assumption as discussed offline that the test fixes for astria-cli are moved into seperate PR before merge.

Created a followup in https://github.com/astriaorg/astria/issues/1392


terraform apply error

kubernetes_service.fargate_backend: Creating...
kubernetes_service.fargate_backend: Creation complete after 0s [id=fargate/backend]
module.alb_ingress_controller.kubernetes_deployment.this: Still creating... [2m30s elapsed]
module.alb_ingress_controller.kubernetes_deployment.this: Still creating... [2m40s elapsed]
module.alb_ingress_controller.kubernetes_deployment.this: Still creating... [2m50s elapsed]
module.alb_ingress_controller.kubernetes_deployment.this: Still creating... [3m0s elapsed]
module.alb_ingress_controller.kubernetes_deployment.this: Still creating... [3m10s elapsed]
module.alb_ingress_controller.kubernetes_deployment.this: Creation complete after 3m18s [id=kube-system/aws-alb-ingress-controller]
kubernetes_ingress.fargate_ingress: Creating...
kubernetes_ingress.fargate_ingress: Creation complete after 0s [id=fargate/backend]
Error: Invalid index
on eks.tf line 382, in output "eks_fargate_url":
382:   value = kubernetes_ingress.fargate_ingress.load_balancer_ingress[0].hostname
|----------------
| kubernetes_ingress.fargate_ingress.load_balancer_ingress is empty list of object
The given key does not identify an element in this collection value.

This was a minor issue as I just set the value to a dummy fixed string and used the EKS console to find the URL required for the docker-compose.yml file

This was a minor issue as I just set the value to a dummy fixed string and used the EKS console to find the URL required for the docker-compose.yml file

Hi @Stevef-aa - unfortunately we still have a race condition that we haven't been able to solve yet where terraform completes before the ingress has finished initializing completely. A second run of terraform picks it up though and I think would have shown you the URL. We'll try to come up with a better fix though.

Hi @Stevef-aa - unfortunately we still have a race condition that we haven't been able to solve yet where terraform completes before the ingress has finished initializing completely. A second run of terraform picks it up though and I think would have shown you the URL. We'll try to come up with a better fix though.


HID Gamepad constant disconnects.

I am using my ESP32 as a HID Gamepad and I am running into issues with it.
Connection seems fine at the beginning but after several perfectly working inputs, I get a hard lag spike followed by disconnect. The lag itself is a big issue, but after reconnecting, the ESP32 will continue to disconnect itself every 90 seconds or so, regardless if I send any inputs or not.
Here is my code: https://gist.github.com/GameDragon2k/90709fbe6b15e66c1b274dde3e1b2439
And this is debug for disconnects/reconnects:
[D][BLEDevice.cpp:96] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... ESP_GATTS_DISCONNECT_EVT
[D][BLEUtils.cpp:1647] dumpGattServerEvent(): GATT ServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLEUtils.cpp:1723] dumpGattServerEvent(): [conn_id: 0, remote_bda: 5c:f3:70:74:7d:d3]
[D][BLEServer.cpp:177] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_DISCONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLEServer.cpp:342] startAdvertising(): >> startAdvertising
[D][BLEAdvertising.cpp:174] start(): >> start: customAdvData: 0, customScanResponseData: 0
[D][BLEAdvertising.cpp:187] start(): - advertising service: 00001812-0000-1000-8000-00805f9b34fb
[D][BLEAdvertising.cpp:231] start(): << start
[D][BLEServer.cpp:344] startAdvertising(): << startAdvertising
[D][BLEServer.cpp:295] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLEUtils.cpp:1091] dumpGapEvent(): Received a GAP event: ESP_GAP_BLE_ADV_DATA_SET_COMPLETE_EVT
[D][BLEUtils.cpp:1099] dumpGapEvent(): [status: 0]
[D][BLEServer.cpp:135] handleGAPEvent(): BLEServer ... handling GAP event!
[D][BLEUtils.cpp:1091] dumpGapEvent(): Received a GAP event: ESP_GAP_BLE_SCAN_RSP_DATA_SET_COMPLETE_EVT
[D][BLEUtils.cpp:1285] dumpGapEvent(): [status: 0]
[D][BLEServer.cpp:135] handleGAPEvent(): BLEServer ... handling GAP event!
[D][BLEUtils.cpp:1091] dumpGapEvent(): Received a GAP event: ESP_GAP_BLE_ADV_START_COMPLETE_EVT
[D][BLEUtils.cpp:1123] dumpGapEvent(): [status: 0]
[D][BLEServer.cpp:135] handleGAPEvent(): BLEServer ... handling GAP event!
[D][BLEServer.cpp:342] startAdvertising(): >> startAdvertising
[D][BLEAdvertising.cpp:174] start(): >> start: customAdvData: 0, customScanResponseData: 0
[D][BLEAdvertising.cpp:187] start(): - advertising service: 00001812-0000-1000-8000-00805f9b34fb
[D][BLEAdvertising.cpp:231] start(): << start
[D][BLEServer.cpp:344] startAdvertising(): << startAdvertising
start advertising
[D][BLEUtils.cpp:1091] dumpGapEvent(): Received a GAP event: ESP_GAP_BLE_ADV_DATA_SET_COMPLETE_EVT
[D][BLEUtils.cpp:1099] dumpGapEvent(): [status: 0]
[D][BLEServer.cpp:135] handleGAPEvent(): BLEServer ... handling GAP event!
[D][BLEUtils.cpp:1091] dumpGapEvent(): Received a GAP event: ESP_GAP_BLE_SCAN_RSP_DATA_SET_COMPLETE_EVT
[D][BLEUtils.cpp:1285] dumpGapEvent(): [status: 0]
[D][BLEServer.cpp:135] handleGAPEvent(): BLEServer ... handling GAP event!
[D][BLEUtils.cpp:1091] dumpGapEvent(): Received a GAP event: ESP_GAP_BLE_ADV_START_COMPLETE_EVT
[D][BLEUtils.cpp:1123] dumpGapEvent(): [status: 0]
[D][BLEServer.cpp:135] handleGAPEvent(): BLEServer ... handling GAP event!
[D][BLEDevice.cpp:96] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... ESP_GATTS_CONNECT_EVT
[D][BLEUtils.cpp:1647] dumpGattServerEvent(): GATT ServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLEUtils.cpp:1707] dumpGattServerEvent(): [conn_id: 0, remote_bda: 5c:f3:70:74:7d:d3]
[D][BLEServer.cpp:177] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_CONNECT_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
Connection established!
[D][BLEServer.cpp:295] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLEDevice.cpp:96] gattServerEventHandler(): gattServerEventHandler [esp_gatt_if: 4] ... ESP_GATTS_MTU_EVT
[D][BLEUtils.cpp:1647] dumpGattServerEvent(): GATT ServerEvent: ESP_GATTS_MTU_EVT
[D][BLEUtils.cpp:1766] dumpGattServerEvent(): [conn_id: 0, mtu: 517]
[I][BLEDevice.cpp:113] gattServerEventHandler(): ESP_GATTS_MTU_EVT, MTU 517
[D][BLEServer.cpp:177] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLECharacteristic.cpp:209] handleGATTServerEvent(): >> handleGATTServerEvent: ESP_GATTS_MTU_EVT
[D][BLECharacteristic.cpp:461] handleGATTServerEvent(): << handleGATTServerEvent
[D][BLEServer.cpp:295] handleGATTServerEvent(): << handleGATTServerEvent

I will check it, but my first thought is this:
  pServer = BLEDevice::createServer();
  pServer->setCallbacks(new MyServerCallbacks());

If i remember you dont have (and you should not) create server, it is created by BLEHID class.

@chegewara I'm sorry, I don't understand the question. Are you asking where in the code the GPIO pins are mapped?
If so, that would be here: https://gist.github.com/GameDragon2k/90709fbe6b15e66c1b274dde3e1b2439#file-esp32_ble_arcade-ino-L153-L187
I should also mention that I have been testing this issue using only a single pushbutton connected to one GPIO pin.

I should also mention that I have been testing this issue using only a single pushbutton connected to one GPIO pin.
Thats important information. I was asking about pin mapping because:

some pins (35-39) soes not have internal pullup/pulldown option,
some pins are reserved for communication with flash (pins 28-33 or GPIO6-GPIO11)
https://raw.githubusercontent.com/gojimmypi/ESP32/master/images/myESP32 DevKitC pinout.png
I know its not the same board, but its almost 1:1 clone.
I dont remember how are those pins mapped in arduino, thats my question.

Arduino uses GPIO number for mapping, so pinMode(11, INPUT_PULLUP); would be mapped to FLASH CMD.
I have tested GPIOs 34-39 using external resistors and didn't run into any issues regarding inputs. GPIO9 and GPIO10 can be removed from my mapping, but using them individually in testing I noticed no difference with the issue.

What is testing platform? android, windows or linux? if windows what version is it?

Tested on three devices, all Windows 10 Pro x64.

@GameDragon2k I have tested your code with my devKitC on windows 10 pro and i have strange behavior.
 I have to do more tests with other esp32 board.

Thank you for testing. I am at a lost myself, so I hope you find some solid results.

@GameDragon2k I have some issue with my windows atm and i need to reboot it, but unfortunately i cant. Could you try to change debug level to info or less and try again?
PS i meant windows version (windows 8 or 10) but you already did answer it

@GameDragon2k I had to install windows latest update and reboot laptop. Now your code seems to work with no issues, no disconnection, for about 10 minutes. I didnt run putty this time, but windows game controller properties shows me that esp32 works fine.
PS you have to find one workaround because when you reconnecting with windows or other peer device it does not register for notification and esp32 will not send notifications.

PS you have to find one workaround because when you reconnecting with windows or other peer device it does not register for notification and esp32 will not send notifications.

You're referring to your workaround here? https://github.com/nkolban/esp32-snippets/issues/632#issuecomment-415982078
Thank you, I have included that bit as well. I will attempt to update and test again.

You could try to prepare test case. Just simplify code, or use the one from #632 and send button on/off with some small delay between.
I cant explain that but there is many issues reported that i cant recreate because users code works for me, in other hand i am reporting some ble issues that cant be recreated by espressif devs.

I went ahead and tried using the code from https://github.com/nkolban/esp32-snippets/issues/632.
I modified it to send inputs through GPIO33 with a delay of 20ms after each notification. Besides this, it is unchanged.
Unfortunately, within a few minutes of pressing the pushbutton, I get the same lag problem followed by the same disconnect.

Then i really dont know. Maybe its esp32 faulty, also when did you last time update espressif/arduino-esp32 library?

I tried https://github.com/nkolban/esp32-snippets/issues/632 again but this time I left it completely intact. No code modifications, no pushbutton, no pin mapping.
I left the thing running and with 2000ms delay, notifications were being sent correctly for about an hour until the disconnection loop started.

To be honest i never been doing such long tests. You can add some memory debug command before or after notify() and one in onDisconnect callback.

I am using this:
    ESP_LOGW(TAG, "%d: - RAM left %d", __LINE__, esp_get_free_heap_size());

Okay, well that idea is out the window. Ram seems just fine.

Unfortunately no luck. Purchased a new Sparkfun ESP32 Thing and getting the exact same issue.

@GameDragon2k I really dont know what to say, it works for me and few other people.
You could try to uninstall and make fresh install of arduino. Last one test will be if you install binary file i have compiled and tested on my esp32.
This bin is from you code (copy/paste) and if i remember its working for me:
gamedragon2k_hid.bin.txt
You have to change extension and upload it with esp32 flash download tool.

BLE_Mouse.ino.txt
@ chegewara the attached arduino sketch for ESP32 BT HID mouse is working in android , but not working in windows 10. Please can you help


[Breaking] Replace unzipper with yauzl-promise

Summary
Unzipper had a transitive dependency on a package that does not have a license. This means that every user is potentially violating the law in using it. Personally, I think it's better to stick to following it, so I've replaced the root dependency with a modern (and updated) alternative.
However, yauzl-promise requires node v16 and above! I think there's some bikeshedding to be done for whether this is worthwhile or not.
This is a breaking change, as the minimum node engine has been bumped from v10 to v16. Note that the engines before this claimed v8 was supported, but the transitive dependencies required >=10. I believe this is an okay change to merge, as anything older than v18 is not supported anymore. https://endoflife.date/nodejs
Test plan
The test suite passes locally (on my machine).
Resolves https://github.com/exceljs/exceljs/issues/2686

This change will also resolve https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116 due to the transitive dependency
<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Can we please bump this PR for review?

Another alternative is to implement what's described here in https://github.com/exceljs/exceljs/issues/2703 . I probably reckon this is a better solution. It's supported in NodeJS (>=18), which is the minimum version that this PR requires anyway.

Hi everyone,
I’ve released  a version with PR Request to bump version of unzipper to eliminate license concerns as a pre-release version: 4.4.1-prerelease.0.
If no issues are reported with this version, I plan to officially release it as 4.4.1 soon.


DOC : Write on the website what are the plot kinds available

On :
https://benchopt.github.io/cli.html#benchopt-plot
user don't know what they can write as <kinds>.

suboptimality_curve
relative_suboptimality_curve
objective_curve
histogram

it even looks very wrong. It says:
Timeout a solver when run for more than  seconds
PR welcome !

@ngazagna the lines you need to fix in your PR are https://github.com/benchopt/benchOpt/blob/master/benchopt/cli.py#L155
thanks for your help !

PR welcome !
Done in
https://github.com/benchopt/benchOpt/pull/129


Inconsistent return from scale

E.g. is this test used identical, it would fail for some types of integer and not others.

Forgotten what this is a problem.


MINIFICPP-406: Ensure that Context Service OR minifi properties can b…

…e used
to configure secure comms ( HTTP & Socket)
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Adding https://issues.apache.org/jira/browse/MINIFICPP-408 to this


[Feature] Reporting

Reporting
I am planning on adding HTML reporting to the dotnet version of Playwright.
I am considering making the HtmlReporting a Blazor WASM project as it produces static files that can be handed to BAs.
The idea is to make it so that after a test/suite is run, the user can use playwright --show-report it uses the Blazor library instead of trying to use node js.
The idea is to have out-of-the-box reporting for Playwright dotnet without needing external libraries.
Why blazor and not react or vite?
The idea is to not have a dependency on node js as the people using the dotnet version of Playwright in the first place most likely don't want node in their tech stacks

The difference between Playwright for .NET and Playwright for Node.js is that in .NET we don't have our own test-runner. This limits us in a lot of areas, e.g. we don't have retries, control about timeouts etc. I would recommend to start as an external open source project for now and see how much value it actually gives, since so far we are not opinionated if you are using NUnit or MSTest.
We neither have screenshots, videos, nor traces, nor test steps in .NET so I think its not worth exploring as of today.
Closing as blocked by https://github.com/microsoft/playwright-dotnet/issues/2214 and https://github.com/microsoft/playwright-dotnet/issues/2316


Navigation through components have broken in new WebStorm version

Description
I've updated my WebStorm version to WebStorm 2021.2 and now the navigation through components is not working
Steps to Reproduce

I'm in a template
I press "ctrl" and click on a Component tag

Expected behavior: [What you expect to happen]

We should navigate to the component template

Actual behavior: [What actually happens]

Nothing happens. WebStorm is not detecting the Component tag as a navigable link.

Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
WebStorm 2021.2
Build #WS-212.4746.80, built on July 23, 2021

The version of intellij-emberjs (Settings -> Plugins -> Ember.js):
2016.2.4-0

Additional Information
Looks like there is a bug in the Plugin version, or the new WebStorm version have changed the Plugin version to a very old one.

Yeah it seems to have updated to a very old 2016 release as that specifies a minimum version only, and the latest version of the plugin isn't compatible with 2021.2 yet.

Any ideas?

Yep, it needs a new release but I'm still on vacation until next week

Something important that I noticed though is that with 2016.2.4-0 the issues I described in #360 are gone. Any thoughts as to why that might be the case @Turbo87?

Probably because it doesn't contain the problematic feature that is causing the issues for you

Probably because it doesn't contain the problematic feature that is causing the issues for you

Huh, I guess I couldn't have surmised that myself. 😒


Build flags needed?

To build with ECDH and RANGEPROOF do I need to pass any flags into the build steps on the README or....?
Thanks
Frank

flags into the configure step.
IIRC:
./configure --enable-experimental --enable-blah

Great, I'm not that familiar with the tools/language so this is very helpful.


[BUG]<EMAIL_ADDRESS>has broken formiojs/core-js dependency?

Environment
Please provide as many details as you can:
I have an angular application running using angular cli.
When I upgraded angular-formio (to 3.18.0), I started getting lots (dozens!) of compile errors about the dependent formiojs "core-js" dependencies that looked like this
ERROR in ./node_modules/formiojs/components/password/Password.js
Module not found: Error: Can't resolve 'core-js/modules/web.dom-collections.iterator' in '(path to my application)/node_modules/formiojs/components/password'

My workaround for now was removing npm's formiojs and angular-formio and reinstalling
at version 3.16.2.
So:
npm install<EMAIL_ADDRESS>Which leads me to believe this issue was introduced by a recent change in dependencies.

Hosting type

[x] Form.io
[ ] Local deployment

Version:

Formio.js version: 3.22.0 is the FAILED version,  3.21.5 is the WORKAROUND installed version that still works.
Frontend framework: Angular
Browser: n/a
Browser version: n/a

Steps to Reproduce

In angular cli project, "npm install<EMAIL_ADDRESS>results in the problem for me, as does just running "npm update angular-formio"

Expected behavior
Latest package should work.
Observed behavior
Example

We have upgraded the core-js to use 3.x in our latest builds. Does your application use core-js@2?
If so, then is it possible to upgrade to 3.x? If not, then maybe we need to add a hard dependency on angular-formio to 3.x so that it will install a local dependency on 3.x.

I don’t directly use core-js 2 or 3.  However, when I removed core-js and formiojs from my package.json and did a fresh install with angular-formio 3.18.0,  the resulting package-lock.json
Installed core-js 2.6.9 instead of core-js@3, so if 3 is needed then you probably do need to add an ^3.0.0 dependency declaration of some variety.
It looks like there are some serious differences between the versions:
https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md

On Jun 12, 2019, at 10:44 AM, Travis Tidwell<EMAIL_ADDRESS>wrote:
We have upgraded the core-js to use 3.x in our latest builds. Does your application use core-js@2?
If so, then is it possible to upgrade to 3.x? If not, then maybe we need to add a hard dependency on angular-formio to 3.x so that it will install a local dependency on 3.x.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/formio/angular-formio/issues/307?email_source=notifications&email_token=AKW5NYVHJCPETLYYY6B7HYTP2EDWBA5CNFSM4HXDEX2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQVHYA#issuecomment-501306336, or mute the thread https://github.com/notifications/unsubscribe-auth/AKW5NYQJPLZRI2J2KCSKUC3P2EDWBANCNFSM4HXDEX2A.

Yes, I will make a new build that includes core-js as a dependency to this library which should resolve the problem.

Please try version 3.19.0 and let me know if it resolves this problem.


Exoplayer Dash with Clearkey Issue

I want to play a Dash video on my Android app with Clearkey but it does not work. To use the clearkey, I have to set the uuid as CLEARKEY_UUID when preparing the DrmSessionManager. The issue might be, in the Dash manifest, the default KID is not given with the "urn:mpeg:dash:mp4protection:2011". The KID is given with "urn:mpeg:cenc:2013" (See the example below). Is there a way to solve this?
<ContentProtection schemeIdUri="urn:mpeg:dash:mp4protection:2011" value="cenc"/> <ContentProtection xmlns:mspr="urn:microsoft:playready" schemeIdUri="urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95"><mspr:pro>5gIAAAEAAQDcAjwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ANwAzAG8AOQBJAHQAbAA3AGgAbABKAHgANgBrAHQARwAzAHYAcgBOAEEAdwA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBkAHUAcwBCAFkARgA4AGcARgBZAE0APQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APABMAEEAXwBVAFIATAA+AGgAdAB0AHAAcwA6AC8ALwBwAHIAbwBkAC4AdQBkAHIAbQB2ADMALgBrAGEAbAB0AHUAcgBhAC4AYwBvAG0ALwBjAGUAbgBjAC8AcABsAGEAeQByAGUAYQBkAHkALwBsAGkAYwBlAG4AcwBlADwALwBMAEEAXwBVAFIATAA+ADwATABVAEkAXwBVAFIATAA+AGgAdAB0AHAAOgAvAC8AdwB3AHcALgBrAGEAbAB0AHUAcgBhAC4AYwBvAG0APAAvAEwAVQBJAF8AVQBSAEwAPgA8AC8ARABBAFQAQQA+ADwALwBXAFIATQBIAEUAQQBEAEUAUgA+AA==</mspr:pro></ContentProtection> <ContentProtection xmlns:cenc="urn:mpeg:cenc:2013" schemeIdUri="urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed" cenc:default_KID="223d7aef-7bd9-5286-71ea-4b46defacd03"> <cenc:pssh>AAAAUHBzc2gAAAAA7e+LqXnWSs6jyCfc1R0h7QAAADAIARIQIj1673vZUoZx6ktG3vrNAxoHa2FsdHVyYSIKMV93ZWVpeXk4dioFU0RfSEQ=</cenc:pssh></ContentProtection>

I think the DASH stream wants that this content is protected. I understand ClearKey wouldn't do that.
@icbaker Can you take a look whether this is feasible?

Preparing valid media is out of scope for this issue tracker, so I'm afraid we can't really help you with that. Does your DASH stream work with other players? There's other issues discussing how to get clearkey decryption working with ExoPlayer:

https://github.com/google/ExoPlayer/issues?q=clearkey
https://github.com/androidx/media/issues?q=clearkey

If you have specific questions about why a stream you believe to be valid isn't working with ExoPlayer please provide the information reuqested in the issue template (including clear repro steps).

Preparing valid media is out of scope for this issue tracker, so I'm afraid we can't really help you with that. Does your DASH stream work with other players? There's other issues discussing how to get clearkey decryption working with ExoPlayer:

https://github.com/google/ExoPlayer/issues?q=clearkey
https://github.com/androidx/media/issues?q=clearkey

If you have specific questions about why a stream you believe to be valid isn't working with ExoPlayer please provide the information reuqested in the issue template (including clear repro steps).

Yes, the stream is working fine with JW player using Clearkey.

I can you a sample stream with keys to check.

Closing due to inactivity (no media was received).


Reload configuration

So the configuration can be edited using supervisorphp/configuration and managament using supervisorphp/supervisor, but how can I tell supervisord to reload the new configuration once i changed the config file. Say I added a new program.
The supervisorctl has the update command, but the XML-RPC API and supervisorphp/supervisor seem to lack this functionality.
I can force supervisor to reload the new configuration by calling restart from php, but this is not an elegant solution.
Does somebody know a better way?
Thanks

The API supports restart() (see http://supervisord.org/api.html#supervisor.rpcinterface.SupervisorNamespaceRPCInterface.restart) which will also reload the config.
This is also documented, see https://github.com/supervisorphp/supervisor/blob/master/src/Supervisor.php#L25

I am also aware of this problem and I have several solutions in mind which are indeed more elegant than calling restart. (Though restart currently solves it)
There are some supervisor extensions which exposes an API for updating. I am planning to implement support for third party supervisor extensions.
Another possibility is a wrapper around the supervisorctl command which is also planned. However I had some issues with it, like preconfigured password is not accepted, etc.
I am also planning to create some custom supervisor extensions to support actions like this.

The problem with restart() is that it also kills the other programs, so you have to set them to autostart = true in order come back after the supervisor restart, or you call start/startAllProcesses.
I added this workaround to my class (beware of hardcoded paths),
maybe something similar would work for supervisorphp too.
 private function forceReload()
    {
        $command = sprintf('%s -u %s -p %s %s', '/usr/bin/supervisorctl', $this->user, $this->pass, 'update');
        exec($command, $output);
        return $output;
    }

Hm, I wasn't aware of that supervisorctl accepts user and password as parameters. I thought the only way was to set it in the config (it never worked for me though).
As I said, I have a supervisorctl wrapper in my mind.
I will keep this open until I find a solution.

There will be a wrapper around supervisorctl. Not sure if it will be part of this package or (it has a higher chance) will go into this repo.

Hey guys!
I'm stuck at the same step (reloading configuration without a restart).
Any updates here?

Reload config is supported here:
http://supervisord.org/api.html#supervisor.rpcinterface.SupervisorNamespaceRPCInterface.reloadConfig
Which means doing $supervisor->reloadConfig() works.

That's awesome news. The docs don't really mention from which supervisor version is it available.

The 4.0.0 dev branch now supports calling the reloadConfig function directly.

Hi!
Any updates here?
Has library support for config reload already?

@Pleskan Yep, the latest version of the library has reloadConfig already included.

@SlvrEagle23 Could you show me implementation of this method in the code base, please?
I can't find it.

@Pleskan
https://github.com/supervisorphp/supervisor/blob/ef53807601bd1d69072e5fe13726616b04b03d7f/src/Supervisor.php#L88-L91
it seems this magic method calls reloadConfig-functionality


frontend: revamp send confirm dialog / view

Using View fullscreen instead of WaitDialog and UI improvement in general in order to improve UX (easier to read).

Thanks! PTAL @thisconnect

Screenshots for second commit (design change; font size & text colour).


Write more test cases for AddressBookParser

Added test cases for all internship-related commands
Fixed a bug in AddInternshipCommand#equals()
Renamed some methods and variables in Util and Builder classes
Removed an unnecessary method call

Codecov Report

Merging #269 (10b262a) into master (564d8a1) will increase coverage by 5.76%.
The diff coverage is 9.09%.

@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
+ Coverage     53.75%   59.51%   +5.76%
- Complexity      531      570      +39
============================================
  Files           102      102
  Lines          2411     2416       +5
  Branches        323      325       +2
============================================
+ Hits           1296     1438     +142
+ Misses          988      807     -181
- Partials        127      171      +44

Impacted Files
Coverage Δ

...u/address/logic/commands/AddInternshipCommand.java
38.46% <9.09%> (+38.46%)
:arrow_up:

...seedu/address/model/internship/InternshipRole.java
70.00% <0.00%> (ø)

...edu/address/model/internship/InternshipStatus.java
45.16% <0.00%> (+3.22%)
:arrow_up:

...va/seedu/address/model/internship/CompanyName.java
80.00% <0.00%> (+10.00%)
:arrow_up:

.../seedu/address/model/internship/InterviewDate.java
61.11% <0.00%> (+11.11%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
71.42% <0.00%> (+12.69%)
:arrow_up:

.../seedu/address/logic/parser/AddressBookParser.java
77.77% <0.00%> (+16.66%)
:arrow_up:

...ddress/logic/commands/DeleteInternshipCommand.java
25.00% <0.00%> (+25.00%)
:arrow_up:

.../address/logic/commands/SortInternshipCommand.java
41.66% <0.00%> (+41.66%)
:arrow_up:

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


2024/02/28 - PyTorch (1:16:00 - 2:27:00)

Done, spent a lot of time, 3 hrs + in school and 4 hrs + at home. Recommend to take a nap first before working in the future, very inefficient to work through. Need to learn Matrices after this.


Adds new endpoint for jenkins jobs

Integrated Jenkins jobs
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
Adds new endpoint for jenkins jobs
Adds new tab for Jenkins jobs
Abstracts logic to reuse methods when fetching data from ES
Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Some data that ES is returning, doesn't have platform and version, so it is showing in an empty tab with null version.

Added a filter to remove errored runs, that failed on installation.


[bug]: Black Images NVIDIA T1000 8GB

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
NVIDIA T1000
GPU VRAM
8GB
Version number
v4.0.0rc1
Browser
Google Chrome 122.0.6261.113
Python dependencies
No response
What happened
Hello, everything I try to generate an image it just turns out as a black image. I am running invoke in a docker on unraid.
I have tried tried lowing my steps and setting my steps to an odd number suggested by others. I'm using  model 1-5.
I have tried a few different schedulers with no luck.
I have switched the VAE Precision between 16 and 32 with nothing changing.
When an image first starts it shows up some pixles and then goes black a second or 2 after.

log.txt
What you expected to happen
I expected images to generate.
How to reproduce the problem
No response
Additional context
No response
Discord username
creakyrock

Did it work previously? If so, what was the last app version where it worked?

Did it work previously? If so, what was the last app version where it worked?
This line is interesting:
/home/invokeuser/venv/lib/python3.10/site-packages/diffusers/image_processor.py:90: RuntimeWarning: invalid value encountered in cast
  images = (images * 255).round().astype("uint8")

That's in the VaeImageProcessor class, as it tries to convert the numpy image into a PIL image. This code hasn't been changed in some time, but maybe something around it has been.

It has never worked.

Ok. I believe this issue is related to the GPU and its supported precision settings.
Let's try forcing fp32 precision for the whole app.
In the invokeai.yaml file, add a Device: section if it doesn't already exist. Then, add precision: float32 under it:
InvokeAI:
  Device:
    precision: float32

You could also try precision: autocast.
Do either of those fix the issue?

fwiw, i was having the same issue on a T1000, and setting the precision to float32 as @psychedelicious directed did, indeed, correct the problem.

Thanks @B4D5YN74X. Closing this old issue.


Conf

What this PR does / why we need it:
This PR defines config file variables for Prometheus, Grafana, Alert manager and the push gateway 3rd party components.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #691
Special notes for your reviewer:
Release note:

Coverage decreased (-0.06%) to 27.738% when pulling d3d5b46a526efe713a5b8b8697991b3bc8ce7525 on rhsakarpos:conf into 6eadaa2fa448b748afdb7d03f8d3b4677d50c71c on opensds:development.


Add UdpSocket::PeerAddr

This was just stabilized in std; we should consider adding it too.
https://github.com/rust-lang/rust/pull/64728

@yoshuawuyts I quickly looked in the source code, please correct me if I am wrong, this is going to be currently blocked by mio's new release with peer_addr implementation right?

@ansrivas yeah I guess you're right.

I am a beginner in Rust. And I am really delighted to see there is a issue I can fix. I am gonna take this one.

@yoshuawuyts It seems like this can be closed now.


drivers/ioexpander/tca64xx.c: Fix polarity register address

Summary
Impact
Testing

This should be ok, merging