Can't get inputs to update properly using SteamVR (2.6.1) on 2020.1

The simplest way I can describe my issue is that SteamVR absolutely refuses to give me proper readings on inputs.
Tracking pos/rot of the headset and the controllers work, but input isn't quite working.
The live input window won't give me proper values either. I have generated the actions.json and compiled, but nothing is working it seems.
I'm using Unity 2020.1, with a HTC Vive, using XR Management and XR Interactions Toolkit, with SteamVR's implementation of OpenVR (2.6.1).
Here's my manifest.json
{
  "scopedRegistries": [
    {
      "name": "Packages from jillejr",
      "url": "https://npm.cloudsmith.io/jillejr/newtonsoft-json-for-unity/",
      "scopes": [
        "jillejr"
      ]
    },
    {
      "name": "Valve",
      "url": "https://registry.npmjs.org/",
      "scopes": [
        "com.valvesoftware",
        "com.valvesoftware.unity.openvr"
      ]
    }
  ],
  "dependencies": {
    "com.unity.2d.sprite": "1.0.0",
    "com.unity.burst": "1.3.2",
    "com.unity.cinemachine": "2.6.0",
    "com.unity.ide.visualstudio": "2.0.2",
    "com.unity.ide.vscode": "1.2.1",
    "com.unity.inputsystem": "1.0.0",
    "com.unity.jobs": "0.2.7-preview.11",
    "com.unity.mathematics": "1.1.0",
    "com.unity.postprocessing": "2.3.0",
    "com.unity.quicksearch": "1.5.4",
    "com.unity.terrain-tools": "3.0.1-preview",
    "com.unity.test-framework": "1.1.16",
    "com.unity.textmeshpro": "3.0.1",
    "com.unity.timeline": "1.3.5",
    "com.unity.ugui": "1.0.0",
    "com.unity.xr.interaction.toolkit": "0.9.4-preview",
    "com.unity.xr.management": "3.2.13",
    "com.valvesoftware.unity.openvr": "1.0.1",
    "jillejr.newtonsoft.json-for-unity": "12.0.301",
    "com.unity.modules.ai": "1.0.0",
    "com.unity.modules.androidjni": "1.0.0",
    "com.unity.modules.animation": "1.0.0",
    "com.unity.modules.assetbundle": "1.0.0",
    "com.unity.modules.audio": "1.0.0",
    "com.unity.modules.cloth": "1.0.0",
    "com.unity.modules.director": "1.0.0",
    "com.unity.modules.imageconversion": "1.0.0",
    "com.unity.modules.imgui": "1.0.0",
    "com.unity.modules.jsonserialize": "1.0.0",
    "com.unity.modules.particlesystem": "1.0.0",
    "com.unity.modules.physics": "1.0.0",
    "com.unity.modules.physics2d": "1.0.0",
    "com.unity.modules.screencapture": "1.0.0",
    "com.unity.modules.terrain": "1.0.0",
    "com.unity.modules.terrainphysics": "1.0.0",
    "com.unity.modules.tilemap": "1.0.0",
    "com.unity.modules.ui": "1.0.0",
    "com.unity.modules.uielements": "1.0.0",
    "com.unity.modules.umbra": "1.0.0",
    "com.unity.modules.unityanalytics": "1.0.0",
    "com.unity.modules.unitywebrequest": "1.0.0",
    "com.unity.modules.unitywebrequestassetbundle": "1.0.0",
    "com.unity.modules.unitywebrequestaudio": "1.0.0",
    "com.unity.modules.unitywebrequesttexture": "1.0.0",
    "com.unity.modules.unitywebrequestwww": "1.0.0",
    "com.unity.modules.vehicles": "1.0.0",
    "com.unity.modules.video": "1.0.0",
    "com.unity.modules.vr": "1.0.0",
    "com.unity.modules.wind": "1.0.0",
    "com.unity.modules.xr": "1.0.0"
  }
}

Only thing I can think of that may be messing with things is the new Unity input system, although I haven't tested this theory.
Does anyone else have this issue?

mmh, try this https://www.vive.com/us/support/vive/category_howto/optin-to-steamvr-beta.html
maybe works, it worked for me when I couldn't see the controllers.

Struggling here too. I've been trying to activate the default action set or get any action set to show as 'Active' in the SteamVR Input Live View but just not having any luck currently. I'm not actually sure if I'm supposed to explicitly Activate() the default set or if that one is special and it shouldn't be necessary? All the documentation on this stuff is so out of sync right now :/
I was previously using the 2.6.0b4 release, and have tried opting into the steam beta and now updated to the 2.6.1 release of this plugin.
I'm running with Unity 2019.4.8f1 LTS
The xr plugin generally seems to be working for pose information etc but I desparately trying to enable SteamVR support in my app. Since the XR plugin is only for rendering and feedback from Valve
If I run the Simple Sample scene I'm currently seeing lots of errors like:
Internal: deleting an allocation that is older than its permitted lifetime of 4 frames (age = 6)
and
Internal: JobTempAlloc has allocations that are more than 4 frames old - this is not allowed and likely a leak
(I didn't notice those with the previous 2.6.0b4 release)
Would love to have some pointers to even be able to get the most basic example of combining the unity XR plugin (rendering only) and using this steamvr plugin for input, with Unity 2019.4.

Digging arround in the implementation I'm seeing that an ActionSet builds on top of ActionSet_Data and that data is apparently not getting initialized by something. I haven't seen any documentation about needing to explicitly initialize action sets but maybe you do now?
It looks like the ActionSet gets initialized via OnAfterDeserialize but it seems notable that ActionSet::Initialize() does not also Initialize the ActionSet_Data because in this case the createNew argument is false (not sure at the moment what that's intended for)
The fact that the ActionSet_Data is not initialized I think will explain why I never see an active action set. The implementation of ActionSet::IsActive calls ActionSet_Data::IsActive which returns false if initialized == false

I realised it's probably correct that it doesn't pass createNew in this case. When initializing the ActionSet the code looks up the corresponding data based on the path like /actions/mixedreality.
I'm getting dizzy going around in circles with this code, trying to poke stuff to understand how it's supposed to work.
At some point I saw that SteamVR_Input::Initialize() was never called which seemed suspicious so I tried calling it explicitly but that triggered a null reference exception via:
EVRInputError err = OpenVR.Input.GetInputSourceHandle(path, ref handle);
I think I have to throw my hands in the air - I don't know how to poke this code to do anything :'-( super frustrating trying to develop cross-platform VR code in Unity right now - so many competing/conflicting abstractions :-( ironically maybe even worse right now than it was in the past.

I just tried making a blank project from scratch with Unity 2020.1.3f1, imported the steamvr_unity_plugin 2.6.1 release and opened the Simple Sample scene.
In this case I do now see that the default action set gets made active and I can see pose data. Just like the OP though I don't see any other actions working. I'm also testing with a HTC Vive.
A matrix of some kind from explaining what combinations of components are being tested would be so helpful right now, to have a fighting chance at trying to use this stuff.
Personally I really hope Unity 2019.4 LTS is going to work with this soon.

Aah, so I realised that with Unity 2019.4 I still had the OpenVR Desktop package (xr.openvr.standalone) installed and that interferes with this. Once I remove that then it looks like 2019.4 starts to behave in the same way as 2020.1 - I can see the default action set get activated but I can only see pose action data. It could be good if some of the quick start documentation clarified that this package should be removed.

OK, so my next realization has been that either the Live View is broken or its behaviour is really not what I would have expected.
I found that if I add a very simple behaviour to an object to read an action state within the Simple Sample scene like:
    void Update()
    {
        if (SteamVR_Actions._default.InteractUI.state)
        {
            Debug.Log("InteractUI");
        }
    }

then I do start to see the Live View showing state updates for the InteractUI action. So the Live View is apparently not a direct view of the input itself, but rather a view of the application reading the input data?
Surely that's not how the Live View is intended to work?
Since I've only done an extremely simple test, I don't know if I'll hit some other issues similar to @GeekBrony but at least checking the default InteractUI state worked for me in 2019.4 and 2020.1 with the 2.6.1 plugin.

Thanks for going to the trouble of troubleshooting through this @rib . Let me clear some things up.
The desktop plugin should get automatically removed if you're using the new xr plugin. That's a bug that we can look into.
Live View is intended to work that way, yellow is supposed to show actions that have not been accessed yet. We do a "lazy-loading" style of access so we're not querying all possible actions from every input source. There is an option to change this behavior in the code, but maybe we also need to make this more obvious in the live view.
@GeekBrony are you still having these issues?

Thanks for the clarifications.
I can see how it might not be ideal for the viewer to have to poll all possible actions if there's no underlying event mechanism - though does the list of currently active actions typically get that long that it would really pose an issue only while the debug viewer is open? I guess if that's a real concern then yeah maybe there could be some UI tweak to maybe make the behaviour clearer (sorry if I missed some description that already tries to explain this).
About the openvr desktop package, I did disable an auto update option because I got stuck in some kind of infinite update loop that I had to break (I interrupted it by putting a compilation error in some of my code) and maybe doing that also short circuited the code that would have checked for the desktop package?


Updating event diagram with the created state

Merge this when #13367 is complete
Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

LGTM

LGTM
DO NOT MERGE depends on https://github.com/docker/docker/pull/13367

@thaJeztah no one will merge, I put a next on it.  I can lift it whenever

ping @moxiegirl the related PR (https://github.com/docker/docker/pull/13367) was merged, so feel free to merge this


Change nginx bind port so it doesn't conflict

Currently if you follow this guide when it comes to starting nginx you get this error:
Error starting userland proxy: listen tcp <IP_ADDRESS>:8080

Because Kubernetes is already listening on :8080, so you can't bind nginx to :8080, so I've changed it to :8081

The local cluster documentation doesn't use kubecfg anymore, only kubectl, and currently doesn't start a pod at all. With https://github.com/GoogleCloudPlatform/kubernetes/pull/4300 it will, however, the pod.json used in that PR still specifies 8080; so the same problem will resurface.
Any objections to changing the port in pod.json to 8081?


Dcgan fix

Fix the following for the DC-GAN:

reset the train_iter in each epoch
add code to monitor the training

Thanks!
Please remove the commented code

Thanks, Eric! I've removed the commented code as you suggested.


Add Emby Plugin Image to package

for the directory...here's how https://emby.media/community/index.php?/topic/62511-plugin-image-change/

Done in 7cae98750bd0a3ae0b78d5524b1b10df0e039c10, thanks for advice


No ip allocated to interface of converted qcow2 image

WheN I get converted qcow2 image, it is having an interface eth0 but no ip address is not allocated to it when we bring up the vm and interface is also in down state by default. Is it an expected behavior?

Yes, this is the expected behavior. You need to create an image with a network management configuration. In the complete example netplan is used because it is the standard for ubuntu (since 18.04).
It is not implemented because there are many ways to manage the network configuration: netplan / ifupdown / systemd-networkd... each distribution having its own method. Maybe it will be implemented in the future.

I just added networking support on the branch run-push.
It adds a --network flag to the build and convert commands.
The supported values are:

Ubuntu: netplan, ifupdown, none
Debian: netplan, ifupdown, none
Alpine: ifupdown, none
CentOS: nothing as network management is already setup on the base image

@Adphi thank you for your quick support.
Now it is getting ip address.
The only thing I see missing now is nameserver in resolve.conf and hostname. Is is feasible to add support for it?

@sanketIntel you're welcome.
There should be a resolv.conf with nameserver <IP_ADDRESS>.
If you are getting the ip address from dhcp you should also configure the dhcp server to send the the nameservers.
https://github.com/linka-cloud/d2vm/blob/6b62dbfb9a56f8bbad56dd15830d58e5a5c5dc94/builder.go#L306-L311
I will make the hostname and nameservers configurable through flags in the next few days:
-h, --hostname string                Container host name
    --dns list                       Set custom DNS servers
    --dns-option list                Set DNS options
    --dns-search list                Set custom DNS search domains
    --domainname string              Container NIS domain name

If you plan to use it on real cloud environments, you may consider creating a Dockerfile using your image as the base and installing cloud-init in the image.

Actually when I boot my vm using tedezed/ubuntu-container-disk:20.0 image it takes nameserver and hostname properly but when I boot VM using d2vm converted image it is not getting nameservers and hostname properly.

Hi @Adphi, can you please share when this run-push branch will be merged to main?

Hi @sanketIntel !
I still need to update the documentation and fix some things first, but it should be merged during September.

Hi @Adphi, changes in run-push branch are very important for me (especially interface getting ip from dhcp-server and is in UP state). It will be really helpful if they are merged to main by this month.

@sanketIntel the branch has been merged and v0.1.0 has been pre-released.


[User Story] Transaction Processor Hot Reloading

[User Story]
Transaction Processor Hot Reloading

Epic Title
#32

User Story Title
Transaction Processor Hot Reloading

T-shirt size: S(mall), M(edium), L(arge)
M

User Story
The transaction processor should monitor for file changes and pull in those changes without requiring the docker container be restarted.

Description

Business Need (the why):

Details

Additional User Story

Dependencies

Assumptions

Questions/Clarifications

Ready for review, but I'm waiting on the previous two PRs to be accepted before I submit a third.

finished, but will continue to test before submitting PR, may refactor

@adamgering This story seems to be bouncing between 'needs review' and the backlog.  What is the current state?
What functionality would this give us?  Does this let up push code changes to the NEXT system without downtime?  What "file changes" specifically get monitored here -- just config files?  Thanks!

seems like we don't need this anymore...


Clone object given to signin/signout APIs so values are not overwritten

An object containing extra arguments given to signinSilent method gets overwritten with some values.
Example:
Consider the following code snippet:
     console.log("PARAMS FOR SILENT", params);
      return this.manager.signinSilent(params).catch(rej => {
        console.log("Could not switch user silently. Redirecting to SSO.")
        console.log("PARAMS AFTER SILENT", params);
        return this.manager.signinRedirect(params);
      });

After the call to signinSilent, params gets filled with some fields. Here, in particular, prompt='none' gets added, which breaks a non-silent login.
Of course, this behaviour is easy to avoid once you know the problem. But if not, it could be a source of hard-to-detect bugs. It is probably best to make a copy of the object.
The culprit seems to be signinSilentIframe method at
https://github.com/IdentityModel/oidc-client-js/blob/dev/src/UserManager.js#L239

done


nvr no longer working

nvr opens a new neovim instance.

Neovim has deprecated $NVIM_LISTEN_ADDRESS in favour of $NVIM, see neovim PR 11009.


Terminate at depth

Fixes #21 .
Nice side effect: improves the show_path_to_root method.

Ok thanks, PTAL!


Stop deploying memcached automatically

... but require an pre-deployed instance. This follows the current design to accept mariadb database or rabbitmq.
Depends-on: https://github.com/openstack-k8s-operators/install_yamls/pull/338

I think this is because memached is not deployed. We have to merge https://github.com/openstack-k8s-operators/install_yamls/pull/338 first.

/retest

/test horizon-operator-build-deploy-kuttl


Fix rubocop violations on fee_type_policy_spec

References #216
Description
This PR is fixing the rubocop violations of fee_type_policy_spec.rb
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Running rubocop and RSpec.

Thanks for the help!  These PRs have a conflict with the rubocop_todo file can you fix that up
and I'll merge it!


How to continue training a LoRA

I trained a LoRA, stopped training, and I want to continue training from the same one. But using --lora-ckpt-path  just errors with this traceback:
File "D:\tts\ok\stable-audio-tools-main\train.py", line 78, in main
    torch.load(args.lora_ckpt_path, map_location="cpu")["state_dict"]
KeyError: 'state_dict'

Ok, removing ["state_dict"] works (currently testing if training works).

I can investigate the issue in more depth much later, but for now what is the new error you are getting?

I can investigate the issue in more depth much later, but for now what is the new error you are getting?

     norm_scale = self.dora_mag.weight.view(-1) / (torch.linalg.norm(new_weight_v, dim=1)).detach()
 RuntimeError: The size of tensor a (3072) must match the size of tensor b (1536) at non-singleton dimension 0```

That is the new error

Nope, even when not changing the dataset between 2 runs, it still gives that error


Migrate to JUnit 5

JUnit 5 offers significant advantages over 4, in particular:

better support for expectations on exception handling
multiple concurrent execution runners
better use of Java 8 features

See https://www.baeldung.com/junit-5-migration for details.

Duplicated by #2876


Thank you

Just wanted to open an issue thanking you for this package!

@ndelangen you should remove it  first "ndelangen/wildcards-entry-webpack-plugin already exists", so i can transfer you

done ✅


sometimes stuck on upgrading process, only restart application can reslove

When the first time starting, it will download about 100M data from S3, sometimes will stack, here is the systemd log:

● application.service - application service
Loaded: loaded (/etc/systemd/system/application.service; enabled; vendor preset: enabled)
Active: active (running) since Mon 2018-08-27 09:27:21 CST; 23min ago
Main PID: 28204 (python2)
CGroup: /system.slice/application.service
├─28204 python2 /home/app/launcher
└─28207 java -classpath lib/fxlauncher.jar fxlauncher.HeadlessMainLauncher --uri=http://domain.com/app/
Aug 27 09:28:53 application[28204]: INFO: Progress: 76%
Aug 27 09:28:53 application[28204]: Aug 27, 2018 9:28:53 AM fxlauncher.HeadlessMainLauncher updateProgress
Aug 27 09:28:53 application[28204]: INFO: Progress: 76%
Aug 27 09:28:53 application[28204]: Aug 27, 2018 9:28:53 AM fxlauncher.HeadlessMainLauncher updateProgress
Aug 27 09:28:53 application[28204]: INFO: Progress: 76%
Aug 27 09:28:53 application[28204]: Aug 27, 2018 9:28:53 AM fxlauncher.HeadlessMainLauncher updateProgress
Aug 27 09:28:53 application[28204]: INFO: Progress: 76%
Aug 27 09:28:53 application[28204]: Aug 27, 2018 9:28:53 AM fxlauncher.HeadlessMainLauncher updateProgress
Aug 27 09:28:53 application[28204]: INFO: Progress: 76%
Aug 27 09:28:53 application[28204]: Aug 27, 2018 9:28:53 AM fxlauncher.HeadlessMainLauncher updateProgress

this time, if won't wait, but restart application, upgrading process will be done, and normal start application.

This indicates that the download stream simply isn't receiving any more data. It could be a connection issue or something else network related. Try checking the data stream with wireshark or similar tools.


Add Blog # on RCOS Project Blog and Future Blogs

Can we add number of blogs on rcos.io so all blogs will be numbered from 1 (or 0, if we’re computer scientists)? And to write Blog after every group meeting, can we swich one by one? If you have any accomplishment, please also add a note on Blog site.

What do you mean by "all blogs will be listed from 1?

It should be “numbered”. THX

I don't think we should number those blogs since that's not necessary. But about that switch one by one I agree about that. I have some confusion about that blog. What should be post in that blog? For example if we need to post the things we learnt, we should post a blog about the git session.

As far as I know, we should write blogs if we: 1) have a meeting, 2) achieve great accomplishment, 3) meet w/ someone and summarize what we learn, 4) make significant decisions, 5) make change to milestones or goals, etc.

Is the blog use for record our process？

Yes, in some way.

Ok, I will write a blog about that git session.


Wrong HRESULT error code if the call was made from a different facility

Summary
The GetLastError calls internally the HRESULT::from_win32  which set the facility bits of the HRESULT to 7 aka win32.
However the facility is not always win32.
In this example I call the GetLastError however the same holds true for functions that already return the windows::core::Result like Cryptography::CryptAcquireCertificatePrivateKey
I provided a simple example that should look for a fingerprint in the CurrentUser/Personal Cert store if the fingerprint exists.
The is maybe not the simplest version of the bug but hopefully verbose enough.
Easy solutions would be a way to specify the facility on the GetLastError call or provide different windows::core::Error::from_ implementations for each facility. E.g
windows::core::Error::from_sspi
Crate manifest
[package]
name = "hresult_example"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
hex = "0.4"
windows = { version = "0.51", features = [
    "Win32_Security_Cryptography",
    "Win32_Foundation",
] }

Crate code
use hex::FromHex;
use windows::Win32::Security::Cryptography;

// looks for a fingerprint in CurrentUser\My (Personal)
fn main() {
    let path_as_wstr = "My"
        .encode_utf16()
        .chain(Some(0))
        .collect::<Vec<_>>();
    let dwflags = Cryptography::CERT_OPEN_STORE_FLAGS(Cryptography::CERT_SYSTEM_STORE_CURRENT_USER_ID << Cryptography::CERT_SYSTEM_STORE_LOCATION_SHIFT);
    let handle = unsafe {
        Cryptography::CertOpenStore(
            Cryptography::CERT_STORE_PROV_SYSTEM_W,
            Cryptography::CERT_QUERY_ENCODING_TYPE::default(),
            Cryptography::HCRYPTPROV_LEGACY::default(),
            dwflags,
            Some(path_as_wstr.as_ptr() as _),
        )
    }.unwrap();

    let hash = <[u8; 20]>::from_hex(&"ABF777B90E01AFFDC21BCCA4BB98D7D884DF702E").unwrap();
    let fingerprint_blob = Cryptography::CRYPT_INTEGER_BLOB {
        cbData: hash.len() as _,
        pbData: hash.as_ptr() as _,
    };

    let cert_context = unsafe {
        Cryptography::CertFindCertificateInStore(
            handle,
            Cryptography::X509_ASN_ENCODING,
            0,
            Cryptography::CERT_FIND_HASH,
            Some(&fingerprint_blob as *const _ as _),
            None,
        )
    };
    assert_eq!(cert_context.is_null(), true, "the fingerprint should not be in the store");

    // wrong facility as the error is from SSPI not win32
    // let error = windows::core::Error::from_win32();
    // this is the same as it internally calls the from_win32() function
    let error = unsafe { windows::Win32::Foundation::GetLastError() }.unwrap_err();
    match error {
        // HACK: HRESULT conversion is wrong for crypto error codes
        // HACK: Add 2 to the facility
        e if e.code().0 + 0x0002_0000
            == windows::Win32::Foundation::CRYPT_E_NOT_FOUND.0 =>
        {
            println!("error codes match");
        }
        _ => {
            eprintln!("error codes did not match");
        },
    };

}

Right, the problem is again that the Win32 metadata assumes GetLastError returns an invented WIN32_ERROR type rather than just DWORD. So then when you ask the resulting WIN32_ERROR to convert to an HRESULT it naturally assumes the Win32 facility.

I see you labeled this as a question how can I further help to resolve the issue?
Manually adjusting the HRESULT to fit the calling facility every time is not very convenient.
Can you elaborate on how to handle this?

Oh that's just a tag for internal housekeeping. This is not strictly a crate bug but rather an external one.
I think we have all the info we need on this, it's just going to require a bit of work upstream in the metadata project. We'll ping this thread when there's more to report!

Today the metadata only indicates that GetLastError should be called on failure but not what facility should be used to convert that to an HRESULT if needed. Options include:

Enrich the metadata with this information
Throttle back the transformations and just return the actual error code as Result<(), u32>
Don't do any transformation and stick with what windows-sys provides

Agreed. I think metadata should rollback its WIN32_ERROR transformation and give us a raw u32. Projections can then return the error code to the user (option 2). Longer term, metadata could give us more facility context, in which projections could then do something smarter (option 1).

While I think it would be good to have metadata for "assume HRESULT", "assume WIN32_ERROR", etc, I'm not sure that we can ever be 100% confident that GetLastError returns the expected error type in all situations. For example, a NTSTATUS can sometimes show up where a WIN32_ERROR is expected.

Yep, 2 or 3 seem to be the only reliable options.

This is getting into the win32metadata weeds here but I was thinking we'd have something like this on APIs (perhaps starting with APIs that are today marked with SetLastError=true)
[DllImport("KERNEL32.dll", ..., SetLastError = true)]
[LastErrorContext(Facility = Win32)]
public unsafe static extern HANDLE CreateFileW(...)

That would be nice, but the issue that Chris was hinting at is that as APIs are often implemented in terms of other APIs, you can get into a situation where you cannot really guarantee this is true since the error code can bubble up from some other very different layer of the stack, at least in the general case.

We can potentially improve the situation for option 2 by updating windows::core::Error to store either HRESULT or u32 so that it still uses the same error type but in a lossless manner and thereby supporting error propagation seamlessly.

I do think it'd be useful for the metadata to include the expected error type. I'm less sure to what extent the windows crate can take advantage of the type hint but I think it'd be good for projections to at least have the option (or to maybe just display it in documentation).

I had a look at implementing this but there are just a lot of places where we have to assume some facility in order to turn the result of GetLastError into an HRESULT to the point where HRESULT_FROM_WIN32(GetLastError()) is just a reality even if it is always the "most correct" thing to do.

In the short term I think that the best we can do is avoid the transformation on GetLastError so that it returns an error code rather than automatically converting it to a Result. That way, if you know that the result may not be a Win32 error code then at least you can make that determination yourself. In the long run we should ditch WIN32_ERROR altogether.
But there will always be places where we must convert the result of GetLastError to an HRESULT and in those general cases we have to assume a Win32 facility as that is the norm.

Hm, the C/C++ definition of HRESULT_FROM_WIN32 is:
((HRESULT)(x) <= 0 ? ((HRESULT)(x)) : ((HRESULT) (((x) & 0x0000FFFF) | (FACILITY_WIN32 << 16) | 0x80000000)))

Whereas the windows-rs definition is:
if error == 0 { 0 } else { (error & 0x0000_FFFF) | (7 << 16) | 0x8000_0000 } as i32

The difference is the <= 0 vs. == 0. Maybe we should do the same, at least in the case of the Error type, then we'll be no worse than C++. We could even go further and also pass though anything > u16::MAX but maybe that's too extra.

The difference is the <= 0 vs. == 0.

That's because in Rust the "last error" is u32 whereas in C++ it's "whatever". 😉

I'm starting to think "returns whatever" is a fair description of GetLastError 😆

More seriously, the (HRESULT)(x) <= 0 in the macro exists so that if GetLastError actually returns an HRESULT (as in the case of CertFindCertificateInStore) rather than a traditional Win32 error code, then the severity bit will be detected here as a negative long value and not reencoded. We should probably just do the same careful dance and call it a day.

Yes, I agree with that.


fix: add support for security level

Description
Adds support for different security levels in snmpv3:

NoAuthNoPriv
AuthNoPriv
AuthPriv

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix
[ ] New feature
[x] Refactor/improvement
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
manual test, unit test
Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

can we add some integration tests to check if these different security levels work?

:tada: This issue has been resolved in version 1.11.0-beta.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add params

Params and params diff

@dmpetrov thanks 🙏 .. really appreciate doing this.
@jorgeorpinel it should become part of the Experiments section of the new Get started tutorial.

[ ]  Also, we need to update prism.js scripts to highight these new commands cc @jorgeorpinel

I'm not sure I understand this part.
@schuhschuh and @jorgeorpinel could you please clarify this part?

Did lot's of editing in db3989d in case you want to check it.


Fix inconsistencies in user settings UI

This PR cleans up a couple of UI items in the user settings panel.
Field length and button / link alignment on the delete account tab, think this fixes #1659.
Old:

New:

Un-styled input on the  OpenID tab
Old:

New:

Codecov Report

Merging #2901 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2901   +/-   ##
=======================================
  Coverage   26.85%   26.85%
=======================================
  Files          89       89
  Lines       17607    17607
=======================================
  Hits         4728     4728
  Misses      12193    12193
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f40cc...0325b58. Read the comment docs.

LGTM

LGTM


New version please?

Cheat got several updates, can u please release newer version?

no

Better question: does this still work on most recent updates?

Better question: does this still work on most recent updates?

yes

does it still work?


remove config list of BA's and reference geojson values directly instead

https://github.com/PyPSA/pypsa-breakthroughenergy-usa/blob/01c67c7b289f24012ad6a97191b30d77054a8f21/workflow/config/config.yaml#L48

@trevorb1 solved with d4bf808
Need to move to master still


Cleanup quickstart and contributing pages

Updates contributing guide to refer to Discord and correct SBT commands.
Updates some text in the quickstart page to align with template update PRs:

https://github.com/http4s/http4s.g8/pull/294
https://github.com/http4s/http4s.g8/pull/293

@danicheg I believe it needs the two linked PRs to be merged first, before this one makes sense :)

I could break that part out, but I only started this PR because of the linked ones.


Unauthenticated users bag

Prevent from unauthenticated users from always receiving error (Because there is no id)

@gdangelo Would you mind checking this PR?

@elitan It actually didn’t fix it but I will add a video Of the problem:
https://user-images.githubusercontent.com/100231666/171193567-ecf383d0-b475-4991-844f-bbb296a2443c.mov

@gdangelo Would you mind checking this PR?

Sure! I'm looking at it.

Finally, I've created a new PR for this issue → #659

@Meir-p many thanks for raising up the issue and for helping us to adjust the quickstart!
Thanks Grégory too!
Closing the PR


Pure question post: Questions about inference

During the inference process, is it supported to be used in combination with human LoRA?
If it is supported, is there a simple usage example?

Since our method requires fine-tuning UNet, the model will lose some generalization. Therefore, it is foreseeable that the model will not perform well after combining with human LoRA in the inference stage. We are currently considering the design of the adapter (to support existing LoRA, etc.), so stay tuned.


chore: Release python lambda sdk v0.3.3

To release https://github.com/serverless/dashboard/pull/885

@Mmarzex ready for review 🙏


[Enhancement] enable SQLDigest, but not over than slow query time, sh…

Why I'm doing:
see42539
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@wangjie-fourth can you sign the CLA and sign-off this PR by git commit -s

@wangjie-fourth can you sign the CLA and sign-off this PR by git commit -s

@imay done

@imay hi, this pr is block now. can you help with it?

@Youngwb hi, can you help review this

@wangjie-fourth  could you rebase this branch? The thirdparty Info need this.

@wangjie-fourth could you rebase this branch? The thirdparty Info need this.

hi, are you meaning to rebase this commit on main branch?


Feature Request: SDN as a resource

WIth networks that are tied to the pool's physical infrastructure, it's uncommon to make changes to these networks within Xen Orchestra (storage networks, VLANS, etc). However, the ability to create and destroy software defined networks, such as a VxLAN or GRE networks, has a lot of potential.
For instance, we are looking into using terraform as part of a 'cyber-range' cybersecurity learning infrastructure for students. It would be great if we had the ability not only to create a number of VMs for students, but also the ability to create a cross-server private network in which VMs would be able to communicate without exposure to the WAN. With the ability to create thousands of VxLANs, this is a very scalable resource.
This functionality already exists within xo-cli via xo-cli sdnController.createPrivateNetwork and xo-cli network.delete, so it would be great to see it incorporated into terraform if possible.
This would be dependent on the SDN-Controller plugin being installed and correctly configured.

Just wanted to note here that this functionality is currently restricted to XO admins only.


mate.python-caja: 1.20.0 -> 1.20.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python-caja/versions.
meta.description for mate.python-caja is: '"Python binding for Caja components"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.20.1 with grep in /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1

directory tree listing: https://gist.github.com/42c61691f0cc074efc7f4a2459b3290b

du listing: https://gist.github.com/4ad002bb4491260083275a83cdb93830

Outpath report (click to expand)

Outpath difference report
4 total rebuild paths
1 package rebuilds
1 x86_64-linux rebuilds
1 i686-linux rebuilds
1 x86_64-darwin rebuilds
1 aarch64-linux rebuilds
First ten rebuilds by attrpath
mate.python-caja

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A mate.python-caja https://github.com/r-ryantm/nixpkgs/archive/4e7933d6349d23337e8e130270ea6419e6584a0c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1
ls -la /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1/bin

cc @romildo for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: mate.python-caja
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: mate.python-caja
Partial log (click to expand)
make[1]: Leaving directory '/build/python-caja-1.20.1'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iwq7gq5d30pjpna1l7z6023mgqb4l5hp-python-caja-1.20.1
shrinking /nix/store/iwq7gq5d30pjpna1l7z6023mgqb4l5hp-python-caja-1.20.1/lib/caja/extensions-2.0/libcaja-python.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iwq7gq5d30pjpna1l7z6023mgqb4l5hp-python-caja-1.20.1/lib
patching script interpreter paths in /nix/store/iwq7gq5d30pjpna1l7z6023mgqb4l5hp-python-caja-1.20.1
checking for references to /build in /nix/store/iwq7gq5d30pjpna1l7z6023mgqb4l5hp-python-caja-1.20.1...
/nix/store/iwq7gq5d30pjpna1l7z6023mgqb4l5hp-python-caja-1.20.1

Success on x86_64-linux (full log)
Attempted: mate.python-caja
Partial log (click to expand)
make[1]: Leaving directory '/build/python-caja-1.20.1'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1
shrinking /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1/lib/caja/extensions-2.0/libcaja-python.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1/lib
patching script interpreter paths in /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1
checking for references to /build in /nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1...
/nix/store/xx8k41jjnszz53sbiy5x6iqidvd8nii4-python-caja-1.20.1


Unknown bucket name hardcoded in aws/terraform

https://github.com/nearform/titus/blob/master/infra/aws/terraform/cdn.tf#L42 you can find reference to a bucket called vittle.ai which is not defined in the infra code.
Ideally CloudFront should reference with OAI (https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-restricting-access-to-s3.html) bucket created within the terraform code.

I've checked that the S3 bucket defined in the storage.tf file is not being used elsewhere in the code. According to the infra diagram (https://github.com/nearform/titus/blob/master/docs/devops/aws/infra.png), there should be one and only one S3 bucket, whose purpose is to serve static files when Cloudfront asks for them. Therefore, the S3 bucket defined in the storage.tf file and the one referenced in the cdn.tf file should be the same.
Therefore, I'm going to reconcile both files so Cloudfront uses the S3 bucket.

I've connected the CDN distribution with the S3 bucket and restricted access to its content by using an OAI.

Reopening issue to deploy infra and check it live.

Comments in PR #1479.


graphiql-spring-boot-starter version is still 11.1.0 not 14.0.0?

graphql-spring-boot-starter has been upgrade to latest 14.0.0, why is the graphiql 11.10?
Do you have any plan to upgrade the graphiql?

Starters have been reorganized in v12.0.0, see: https://github.com/graphql-java-kickstart/graphql-spring-boot/pull/617

Thank your quick reply. Now I changed grapiql to graphql like below:
graphql:
graphiql:
enabled: true
headers:
test: test
But some starting error is popped up:
Description:
The bean 'graphiQLController', defined in class path resource [graphql/kickstart/graphiql/boot/GraphiQLAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [graphql/kickstart/autoconfigure/editor/graphiql/GraphiQLAutoConfiguration.class] and overriding is disabled.
Action:
Consider renaming one of the beans or enabling overriding by setting spring.main.allow-bean-definition-overriding=true
Could you give some comments?

Sounds like you didn't remove the old graphiql starter from your dependencies.

Thank you. I have resolved the issue after deleting the old graphiql starter. It is amazing. :)


Stateless executor doesn't work with LlamaSharp 0.10 & NET 8.0

I'm missing something? When I execute stateless executor example in LlamaSharp project it works, but I replicated exactly the same code in my own project using last versions and it crashes.

Did you use the same model when you tested it in the Examples project and when you tested it in your own app?

Yes I did, Ironically I have fixed it by commenting out "await Task.Delay(75);" in the spinner method. What I am unable to understand is that the "stateless executor" does not work without the spinner, and with the spinner only if you modify the line I said.

Well that is bizarre! I've used the stateless executor without a spinner myself (e.g. in the unit tests).
Is there any more detail on what the crash is? It looks like exit code zero from your screenshot, but I'm not certain.

Yes, ends with code zero. Debugging leads to "ex.InferAsync(prompt, inferenceParams)" and then ends. If I put the spinner method it ends inside in "await Task.Delay(75)" line.
Any other information you need, let me know and I will be happy to provide you with it, the truth is that logically speaking the situation kills me. At least it works hahahaha

Hi, does this error appear every time you run it? I couldn't reproduce it on my PC.

Yes, still happens everytime if I don't comment "await Task.Delay(75)" line inside spinner method, and if I don't use the spinner method it also gives error. The only difference that I detect is that we don't use Task for our run(), it returns void, but it shouldn't affect in that way, I have tried several times to change the whole structure of the project to use Task and it still didn't work. It's not a very important problem because doing what I said makes it work, but I don't know if it doesn't work because of my ignorance or because something is really wrong.


Report on which sub-property failed

I may be doing something wrong, but when I use sub properties and one of them fails, all I get in the output are the inputs used and the name of the parent property. For example:
property("equtatable") <- forAll {
    (a: Int, b: Int) in

    let reflexive = EquatableTestUtilities.checkReflexive { Constant(a) } <?> "reflexive"
    let symmetric = EquatableTestUtilities.checkSymmetric { Constant(a) } <?> "symmetric"
    let transitive = EquatableTestUtilities.checkTransitive { Constant(a) } <?> "transitive"
    let notEquate = (a != b) ==> {
        EquatableTestUtilities.checkNotEquate(
            { Constant(b) },
            { Constant(b) }
        )
    }() <?> "not-equate"

    return reflexive ^&&^ symmetric ^&&^ transitive ^&&^ notEquate
}

will just say that "equatable" failed, instead of also telling me that "not-equate" failed:
*** Failed! Proposition: equtatable
Falsifiable (after 1 test):
0
1
*** Passed 0 tests

If I get it to go past 1 test, it looks even weirder, saying 100% of the sub-properties passed?:
*** Failed! Proposition: equtatable
Falsifiable (after 2 tests and 2 shrinks):
-2
0
*** Passed 1 tests
(100%, not-equate, transitive, symmetric, reflexive)

Basically, I feel it would be really valuable to know which sub-properties have failed. Sometimes custom arbitrary types are expensive to compute and it's easier to do many sub-properties off the same random values.

You may want to use disjunction (^||^) instead.  ^&&^ is for precisely the case you're trying to avoid here: treating multiple sub-properties as one contiguous entity.

I do see a bug in the pluralizer, tho.  That will be fixed shortly.

As for the matter of expensive objects in tests, it may be possible SwiftCheck is causing over-retains if you happen to capture things inside the testing block (which gets bandied around quite a bit of tree-mutations before actually being invoked).  The natural solution to this is to use a smart-pointer-esque value type.
Otherwise the only other thing I can think of 2 other ways to help with this:

(if expensive means the type is recursive) using Actions rather than direct instances of Arbitrary has been very helpful.

(if expensive means expensive) You may consider using once with some outer test block that returns the actual test inside the block.  Like

forAll { (x : ExpensiveFoo) in
   return forAll { (a : Int, b : Int)
        return x.doTestedThings(a, b)
   }
}.once

Thank you for taking the time to respond to this.
I see in the comments now about how conjunction will mask lower failures. Going directly to disjunction though isn't very useful, since I want a failure if any of them fail the whole. Based on your comment it seems that to get that I  have to make a convoluted combination of them (which I currently can't picture, sorry about that).
Also, I'm only testing values right now, so it's not over-retains. It's simply lots of Dictionaries :smile:. once is a good tip, but in this case I want to have a normal spread of randomness on the values, I just want to be able to do many different tests with those values, and if a single one of those tests fail I want to whole to fail.

Try verbose along with your sub-properties then for initially failing tests.  SwiftCheck should give you a TMI view of things that will allow you to patch your test cases one by one until you can peel off the band-aid and go back to regular old conjunctions.

Okay. That's a good bandaid, but given randomness, it might take a bit for it to happen again. In that case, I would instead take the inputs given and manually try each of the sub-properties until I saw which one was failing... which seems to fly in the face of the FIRST principle for tests, and really isn't something I would expect contributors to my project to try to figure out if they get a failing test case.
Anyway, it does seem that I wasn't really doing anything wrong, this just isn't supported currently, in the way I want to use it. I would understand if no change will be made for it, it just seemed counter-intuitive that it didn't report which sub-property was failing (I feel in the conjunction case, regardless of what it is, if you gave it a label that means it's important enough to be reported on in the failure case).

That seems a bit hyperbolic.  Manual, here, looks like this
return reflexive.verbose ^&&^ symmetric.verbose ^&&^ transitive.verbose ^&&^ notEquate.verbose

Then you just take off the verboses for passing cases.  Point is QuickCheck (and by extension, SwiftCheck) care about the test case as a piece of data.  You have all the tools you need to examine the sub-parts of a failing test already, it's just a matter of using the right combination to produce a passing test.

I personally think that when a test fails I should be able to tell why it failed, without having to modify it. I can agree to disagree here though.
So, I did exactly what you prescribed, and I think I ran into a different issue:
Failed:
*** Failed! Failed:
Proposition: equtatable
Falsifiable (after 1 test and 2 shrinks):
0
1
*** Passed 0 tests

It doesn't seem to be outputting the label of the sub-property.

I personally think that when a test fails I should be able to tell why it failed, without having to modify it

SwiftCheck is rather bare-bones about it because you have access to quite a bit of the testing mechanism to produce custom output.  Or perhaps the original authors were lazy, who knows?  :stuck_out_tongue:
If you can find a way to make this work while still maintaining modularity, I'll merge it.

It doesn't seem to be outputting the label of the sub-property.

There is no sub-property here.  verbose applies to the entity it is attached to, not the whole test (you can try .verbose on the whole shebang to see that).

There is no sub-property here. verbose applies to the entity it is attached to, not the whole test (you can try .verbose on the whole shebang to see that).

Does that mean:
Passed:
Passed:
Passed:
Passed:
Failed:

isn't bugged? Each entity had a label (via <?>) and .verbose.

For the time being whenFail with print works really well, thank you for that tip. I'll see where that leads me and maybe I can come up with something that is merge worthy if this continues to bug me :wink:.

Hmph, that may be something that can be fixed.  That's expected output from QuickCheck, but you're right: we have a chance to do it better here.  I'll see what I can do.

With the merge of #76 I will close this.  If you have anything further to add, or I managed to not fix anything, feel free to reopen it or another issue.


Validate dbos-config.yaml against its schema on startup

Hi.
I noticed that the dbos-config.yaml file in not being validated against its schema definition during startup.
I believe  that validating it and reporting errors will minimize the frustration that a typo can cause.
What do you think?

Yeah, this is a good idea, PR for it: https://github.com/dbos-inc/dbos-transact/pull/408

Addressed in https://github.com/dbos-inc/dbos-transact/pull/408


[Feature]: Customizable Navbar / Customizable Sidebar

Describe the feature
Unfortunately I didn't see Navbar and normal Sidebar in the components.
Features I would like to see:

Positioning:;

Normal: all props default;
Fixed: width 100% for Navbar and customisable for Sidebar;
Left/Right: width-compressed Navbar with binding to the side of the screen. OR optional condencing entire Navbar;
Absolute: with customizable positioning via properties.

Content through slots - coding in the root level of component;
Sidebar collapsing in 3 mode: Expanded, Icons with tooltips only and fully collapsed under hambuger;
Mobile View;
CSS via outside (root component) declarations: no colors inside subcomponent - all apps have different color set.

Additional information

[ ] I intend to submit a PR for this feature.
[ ] I have already implemented and/or tested this feature.

This project's goal is to remain aligned with shadcn/ui. If the feature you are requesting is not in the original shadcn/ui, it will not be considered here.

The features you want are available in
https://vuetifyjs.com/en/components/navigation-drawers/

changed ui to DaisyUI. unsubscribed. thanks all.


Application resources content

Perform the following tasks for the Application resources page:

[x] Review for content design principles
[x] Get final accuracy approval from Christina/Alex
[x] Airtable fields confirmed
Title
Slug
Menu
Page description (short text that appears in bookmarks and social media page shares)
Body content

Content loaded into WordPress. Manually updated Excerpt field. Add accordion components.


ng-flow uploaded empty files in android phone but successfully in iphone

i use ng-flow to upload images in mobile phone. tested in iphone(4s/6), it uploaded successfully, but in android(4.2.2) mobile phone, it showed completed ok, but empty files with size 0 actually.
anyone found the same problem, and is there a solution?
thanks.

Hi,
I got the same issue with Ipad on Safari 6.
Thanks

Just upgrade to IOS 9 and the problem is solved on ipad


Support for proxied connections

Summary
Our users have had partial success with proxied connections. Currently the guidance is to use HTTP_PROXY/HTTPS_PROXY environment variables or VSCode's built-in settings for proxies. None of these options have been thoroughly tested with the extension and it's not clear if they work.
Details
As part of this feature, we should test the environment variables & settings and if successful, include them in the documentation as a repeatable set of instructions.
If the built-in mechanisms don't work, we should look at reading these settings/variables inside the extension and explicitly creating a proxy configuration that can be passed into the Axios client.

+1 on the feature request, I would also suggest you add support and tests for no_proxy/NO_PROXY environment variables.
Also, running in remote environment with proxies, not only locally with vscode.
The person working on this might want to read this nice summary of the support of the different variable names: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/
In my environment, we have HTTP_PROXY/HTTPS_PROXY/http_proxy/https_proxy set to the same value. The DT extension fails with an http/400 error when trying to get the /api/v1/time endpoint, however a curl succeeds.
When I unset my no_proxy and NO_PROXY environment variables, then I can't curl the /api/v1/time endpoint anymore.
It seems the DT extension uses the proxy setting variables, but ignores the no_proxy/NO_PROXY environment variables: it tries to get the endpoint through the proxy which is not allowed for us.
[the rationale is likely that we have an internal managed Dynatrace that doesn't need our machines to reach the internet proxy].
I also suspect the DT extension fails to authenticate to the proxy: indeed it reports an HTTP/400 when my failing curl gets an http/403 instead


[WIP] fixes: paths, title, tabs, view warning, style, to_object

@tarzan some fixes for current problems connected to the mileages addition

can you add a description as to what this PR fixes?


Trying to add a box-shadow results in crash

Hi there,
When I try to create a box-shadow in Figma Tokens plugin, the plugin crashes with the text:
Something went wrong!
Cannot read property 'x' of undefined.
Restart the plugin and try again.
Attached video and export of my JSON file.
https://user-images.githubusercontent.com/67953561/127834145-7afacfc6-9372-41ba-b091-8163ad31a6dd.mov
tokens.json.zip

Thanks for reporting! Will deploy a fix for this later today or tomorrow morning 👍


Error in VDSR_Matconvnet (line 15)

hi， when i want to test the vdsr model by using matlab , i have met the following errors:
iter:1
Attempt to execute SCRIPT vl_nnconv as a function:
/local/home/share/xujinchang/project/learn_pytorch/caffe-vdsr-master/Test/matconvnet/matlab/vl_nnconv.m
Error in VDSR_Matconvnet (line 15)
convfea = vl_nnconv(im_y,weight{1},bias{1},'Pad',1);
Error in Demo_SR_Conv (line 43)
im_h_y = VDSR_Matconvnet(im_l_y, model,up_scale,use_cascade);
Thanks!

Hi, have you compiled the matconvnet library? Following http://www.vlfeat.org/matconvnet/install/ and have a try.

@huangzehao Thanks a lot, I have compiled the matconvnet library followed the http://www.vlfeat.org/matconvnet/install/ , but now the error just likes this:

Demo_SR_Conv
Undefined function or variable 'VDSR_Matconvnet'.
Error in Demo_SR_Conv (line 42)
im_h_y = VDSR_Matconvnet(im_l_y, model,up_scale,use_cascade);
i can't find where you have defined the function of VDSR_Matconvnet,
thanks for your help!

Did you clone the full repo?
VDSR_Matconvnet is defined in utils.
https://github.com/huangzehao/caffe-vdsr/blob/master/Test/utils/VDSR_Matconvnet.m

@huangzehao thanks for your help with patience, i have run the test successfully.The results seem like these:
iter:1
Elapsed time is 1.711943 seconds.
sr_psnr: 29.954547 dB
bi_psnr: 24.038857 dB


add 1.0,2.0 issuers

Fixes #5796
Description

Add 1.0, 2.0 issuers for China cloud
Specific Changes

Add 1.0, 2.0 issuers for China cloud with specific host and tenant id

Testing

Tested via modified Emulator

@mrivera-ms Hello Monica, we need to add some China valid issuers for token validation. Please review, thanks~


deprecate @vx/boxplot

:boom: Breaking Changes
This PR closes #560 and removes all references to @vx/boxplot whose functionality is duplicated in the @vx/stats package and has confused some users (e.g., #412)

#197 note: @vx/boxplot is deprecated in favor of @vx/stats in a future release @vx/boxplot will be removed

After this is merged I will add a deprecation warning to npm:
npm deprecate @vx/boxplot "@vx/boxplot has been deprecated in favor of @vx/stats"
@hshoff @conglei

one possible issue is with the docs, I'm not sure if we run the docs script while in the TS/JS limbo, and currently most of the docs *.html pages have references to vx-boxplot.html. I'll try to search/replace scrub these for now.

going to merge this guy because some of the lint errors it fixes are failing the build in other PRs. Can follow up with any issues in another PR.

noting successful deprecation on npm


npm install next@beta got old version

I'm trying to use npm install next@beta to install 4.0.0-beta.1 and use react 16，but I got<EMAIL_ADDRESS>

Right now it is waiting to be published per @timneutkens on the #next Slack channel.

tim [21:17 GMT]
Working on it :slightly_smiling_face:
rauchg has to publish it :slightly_smiling_face:

Would be great if this is done as soon as possible. Want to use react 16.

Just released the new version 👌

Awesome! Thanks.


SPOI-5739 #resolve Must catch NoClassDefFoundError when processing op…

…erator classes in jar, previously catching Throwable was changed to catching Exception

This is an urgent PR.  If no one can merge it in the next half an hour or so, I'll need to merge it myself.  Thanks.


Documentation📄: Flesh out the Hub Installation page

What is the current documentation state?
The page at https://open-horizon.github.io/docs/hub/prerequisites/ is missing the actual installation steps.  Please flesh out the pre-requisites, add installation steps (standalone, manual, or using all-in-one), and any potential pitfalls or common errors.
Also, determine where this should fit in with the nav so that the pages link to each other properly.
Where is this stated?
No response
Why do you want to improve the statement?
No response
Proposed Statement
No response
Additional context.
No response

After creating a draft fix, please run past @johnwalicki for technical accuracy and @Rene-Ch1 for documentation best practices validation.  This assumes the PR has already been vetted by the contributor for best practices.

NOTE: This is similar to #303 but a different page with a slightly different purpose.  Even though they have similar titles, they are separate tasks.


Is it OK to use it for our RIS paper?

Hi,
Thank you for sharing this repo.
My team conducted RIS research using your code, and it has been very helpful.
We are preparing to upload our paper to arXiv and release our code that is built upon yours.
But, since there is no license in this repository, our license manager asked us to get your permission.
Would it be okay to use this code for our RIS paper and release code based on it?
We will cite your paper and include a link to this repository to show your contribution.
Thank you for your help!
Best regards,
Heo

Hi, we’ve added the MIT license to the repository, and you’re welcome to use the code for your paper.

Thank you!
That is a perfect solution to my issue.


Show time zone whenever showing time_observed_at

Currently time is displayed to capture precise moment. It would be preferred if the observation time represented the time zone the observation was made.
(i.e. 7:20am ECT than 5:20am (unspecified but actually PDT)
Request from Carrie
Ver 0.50.0

This should be handled the same way we do on web any time we show time observed OR time submitted.
Here are some examples:
Obs edit:

Obs Detail:

I could work on this and have already looked into it.
Currently the translations manage the format of the displayed timestamps. Appending a z to all those string would show the timezone:
# de.ftl
datetime-format-long = dd. MMMM yyyy HH:mm z
datetime-format-short = dd. MM.yy,  HH:mm z

It would also be possible to append the z for all languages in e.g. formatApiDatetime(), but not sure if that is the correct solution for all languages.

@kueda any guidance on how to approach it?

date-fns supports multiple time zone tags so how that gets formatted should be left up to the translators. FWIW, part of the requirement is to show the location-specific time zone codes if that's what translators want, so here in California we should see PST, not GMT-8.


Mismatch between file names/paths on disk versus in project.

In several cases, the path on disk does not correspond to the path in the project 1:1 (case sensitive; works on Windows, fails under Linux)

The folder AST must be renamed to Ast
The file Prexonite/Compiler/Ast/AstTypeCast.cs must be renamed to Prexonite/Compiler/Ast/AstTypecast.cs (→ lowercase c) || or the reference in the project must be changed!

Addressed on the core branch. Project successfully builds on Linux (via .NET Core/dotnet).


Fix component design pattern docs link

There is a link here in mdlComponentHandler.js#L21 which might be a link to a private repository (404ing).
It would be nice if this docs would be public (if it's not already). Otherwise I'd suggest to remove this link.

Thanks for opening! See #779.

I have updated my repo, cloned over, and claimed the new link.

@jasonmayes Thank you!


datapath: link-local unicast addresses can be "host"

Background
This is a fix for a regression in the local addresses logic, introduced in 080857bdedca as part of the implementation for AddressScopeMax. Addresses with the form of a link-local unicast address began to be filtered out of the local address aggregation, causing them to labeled with the "world" identity for the sake of policy enforcement. Examples of such addresses include:
<IP_ADDRESS>
fe80::1234
This caused issues for a variety of users, whose policies allowing "host" traffic would no longer allow traffic to these addresses, forcing the use of workarounds involving CIDR policies, which is not the intended behavior for this type of address. This was a regression as of Cilium 1.12.0-rc2. One reason for this regression was that logic prior to the change looked at the address scope, whereas logic after the change looked at the address bytes, and it was found that many users had assigned addresses of the forms above but with scope global, causing them to again be filtered out unconditionally.
Implementation
This patch factors out the local address filtering logic into a function, removes the skip over IsLinkLocalUnicast(), and adds a variety of unit tests for that function.
Important Note
This change has no effect on link-local services such as the AWS Metadata service which operates on <IP_ADDRESS>/32 because that address is not assigned to any interface of the local host and thus is not enumerated by rnetlink. The address is still labeled with the "world" identity as usual. This has been tested on EKS and kind.
Fixes

fixes: https://github.com/cilium/cilium/issues/25242
fixes: https://github.com/cilium/cilium/issues/23910
fixes: https://github.com/cilium/cilium/issues/16308
fixes: https://github.com/cilium/cilium/issues/20055
Fix a regression in which link-local addresses were not treated with the "host" identity in some circumstances.

/test

/test-1.26-net-next

/test


[PartEditor] Update GUI for text edit changes

This will update GUI editor when document was changed outside like
from text editor.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

for #641, from draft #647
before

after


[ZEPPELIN-4662]. Spark driver OOM cause Connection refused error in frontend

What is this PR for?
This PR is an improvement PR which to display more meaningful error in frontend when spark driver OOM in yarn mode. Currently zeppelin would display connection refused in frontend if spark driver happen OOM. This PR would display the real yarn diagnostic info in frontend.
In this PR, I will launch a yarn app monitoring thread to monitor the all the yarn app status. And would capture the yarn diagnostics if it failed.
What type of PR is it?
[ Feature]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4662

How should this be tested?

CI pass

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Will merge if no more comment


support iOS < 10.0

Please cherry pick changes from FastQrReaderViewPlugin.m. Example project's main.dart is modified slightly for my needs

Thanks for the contribution, I think 3 years later iOS 10 is already quite old so I won't merge it. Sorry for the little delay 😆


quay.io and docker hub images > 2.0.0 don't exist yet

Although mentioned in the releases of 2.0.2 and 2.0.3.

I was able to confirm these images are missing. We are working to correct this now.

@zjeraar The following command should now work:
docker pull quay.io/coreos/etcd:v2.0.3


add badges to readme

Adds CII, build status and carthage badges. Closes #59.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make sed work on MacOS

Without this argument, sed does not work on MacOS (it crashes the build).
I don't know if this breaks for non-macOS systems though. Could you try it out?

Thanks for the PR! Will check it and merge it as soon as I have a Linux system at hand

sed: can't read s/{-| - -}/{-|-}/: No such file or directory
Yeah, does not :(
How about https://github.com/miniBill/elm-html-with-context/commit/1d835a1ecf221dca7e9435bde004c3e4e70d167f ?

Using perl seems to work on MacOs 👌

Closed via 1d835a1


Improve "shareReplay" Docs

The Documentation of the shareReplay operator is more or less empty despite the description of the function signature. There we should add some content, how this operator is supposed to work, maybe some use cases. An image describing this operator would be nice too.

@JWO719 I will look after this one and add some docs to it.

closed by #3872


(WIP) fix docker build for breez cgo

breez-sdk-go seems to need glibc which alpine does not have....
not using alpine causes the docker image to be huge, so this still needs another solution.....
(moved from https://github.com/getAlby/nostr-wallet-connect/pull/225)

@frnandu should we close this for now? docker builds seem ok


Add Futures

Project URL
https://github.com/formbound/Futures
Category
EventBus
Description
Lightweight promises for iOS, macOS, tvOS, watchOS, and server-side Swift
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 3 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

1
302
https://github.com/vsouza/awesome-ios/blob/master/header.png?raw=true redirects tohttps://github.com/vsouza/awesome-ios/raw/master/header.png

312
301
https://github.com/yuzushioh/EthereumKit redirects tohttps://github.com/D-Technologies/EthereumKit

3026
301
http://bgr.com/ios-7/ redirects tohttps://bgr.com/ios-7/

  Generated by :no_entry_sign: Danger

Thanks for contributing!


Repository URL without an ending slash breaks some links

ex of broken link:
[Example-Repo Code of Conduct](https://github.com/Chovin/example_repoblob/master/CODE_OF_CONDUCT.md)

vs other links:
[Issues](https://github.com/Chovin/example_repo/issues)

huh, for some reason I'm not seeing this behavior anymore. Disregard.


Exposed tenorApiKey via config endpoint if set

refs https://github.com/TryGhost/Team/issues/1217

add tenorApiKey to `publicConfig.config()
update canary config endpoint output serializer to include tenorApiKey when the gifsCard labs flag is enabled

Codecov Report

Merging #13734 (ee033ff) into main (dda8e02) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13734      +/-   ##
==========================================
- Coverage   38.87%   38.84%   -0.04%
==========================================
  Files        1085     1085
  Lines       73577    73585       +8
  Branches     5022     5020       -2
==========================================
- Hits        28604    28582      -22
- Misses      44930    44959      +29
- Partials       43       44       +1

Impacted Files
Coverage Δ

...rver/api/canary/utils/serializers/output/config.js
0.00% <0.00%> (ø)

core/server/services/public-config/config.js
0.00% <0.00%> (ø)

core/server/data/db/connection.js
62.26% <0.00%> (-32.08%)
:arrow_down:

core/shared/config/loader.js
93.42% <0.00%> (-3.95%)
:arrow_down:

core/shared/config/utils.js
84.09% <0.00%> (-2.28%)
:arrow_down:

core/shared/settings-cache/cache.js
69.44% <0.00%> (ø)

...ore/frontend/services/routing/helpers/templates.js
68.06% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda8e02...ee033ff. Read the comment docs.


[ New Button ] : Added Glass Button { GSSOC'23 }

Fixes Issue
Closes #767

Changes proposed
A New Glass Button.

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers

@PoorviShetty @Spyware007 Could you Plz check the PR and merge it ???

@PoorviShetty @Spyware007 Could you plz check the PR and merge it ???

@PoorviShetty @Spyware007 Could you plz check the PR and merge it ???


Check all users for valid authorization comment

This is a follow-up issue to the comment

Perhaps for a follow up PR, it still looks like we need to get full results for the push logins since that is used to authorize the comment for approving a run for an external fork. In that case we probably do need to retrieve all push logins since we have to compare the set of users that commented the authorization string to the set of allowed users in which case it would be expensive to check each one individually. In most cases I would expect there only to be 1 valid authorization comment but probably better for us to handle the case where there are a lot

Since there can be multiple users that can authorize the workflow run, it is required to fetch all users.

@yanksyoon can this issue be closed?

This has been fixed by this line: https://github.com/canonical/repo-policy-compliance/blob/main/repo_policy_compliance/check.py#L384
Thank you! Closing :)


polymer-analyzer version mismatch stopgap.

Better error messaging when a different version of polymer-analyzer is used in bundler's constructor.  A bundler-specific fix for what https://github.com/Polymer/polymer-analyzer/pull/686 tries to fix in polymer-analyzer itself.
[x] CHANGELOG.md has been updated

Many users face essentially the same symptom as this https://github.com/Polymer/polymer-bundler/issues/561 which comes down to multiple versions of polymer-analyzer in their node_modules folder.  This is a stopgap fix for that.
Thanks, @aomarks


fix(datePicker): Send arguments to datepicker on change event

Closes carbon-design-system/carbon-components-react#331
Fixing up date picker.

@psachs21 could you update the tests for this so it passes? Thanks in advance!

Woops, my bad. Fixed tests.

I understand now. That makes sense. I'll make the requisite changes.
On Sun, Dec 24, 2017 at 6:20 PM, Josh Black<EMAIL_ADDRESS>wrote:

@joshblack commented on this pull request.
In src/components/DatePicker/DatePicker.js
https://github.com/carbon-design-system/carbon-components-react/pull/419#discussion_r158610780
:

};

static defaultProps = {
short: false,
dateFormat: 'm/d/Y',

onChange: () => {},

The rationale is that we don't want to have to initialize empty closures
when we don't have to 😄
Since we are a library, performance is one of our guiding principles that
we try to follow. While this is a very small thing that ultimately wouldn't
be the bottleneck in an application, the hope is that we can try to stay as
lean as possible on behalf of consumers.
If the empty function is indeed a pattern that we'd want to follow, then
we would want to share the same empty function reference between props,
similar to Facebook's emptyFunction
https://github.com/facebook/fbjs/blob/master/packages/fbjs/src/core/emptyFunction.js
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/carbon-design-system/carbon-components-react/pull/419#discussion_r158610780,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK61gI2TiIFa1_OPIVYUeFli68OO9lGJks5tDtw9gaJpZM4RHsDg
.

@joshblack updated according to review comments.


Why was the createCompanion method removed from the generated class?

The latest comments on #257 have some more info - this method will be back in the next version of moor.

Awesome, thanks for the fast reply


PushRows APIs are not thread safe for sparse data

Description
The API LGBM_DatasetPushRows  (and CSR version) are not thread safe for sparse data. Internally, there is some thread safety for the OpenMP parallelism, since each thread gets its own buffer in a SparseBin.  However, if multiple threads each call LGBM_DatasetPushRows, OpenMP will return the same set of tid's (i.e. 0 to num_omp_threads-1) for each external thread. Hence, external thread A and external thread B will both get an internal tid of 0, and eventually collide when appending to the same sparse buffer.
Reproducible example
Simply call LGBM_DatasetPushRows on a Dataset with sparse bins from 2 different threads, and you will eventually get an access violation when 2 threads both try to add a record to the same element of a SparseBin  push_buffers_ array.
Environment info
N/A
Additional Comments
A fix for this issue has been added to the PR https://github.com/microsoft/LightGBM/pull/5299, since we require thread safety to stream between multiple Spark Tasks (this issue was discovered from sporadic test failures with the existing PR).  The fix as first pushed only applies to the new streaming push APIs in that PR (e.g. LGBM_DatasetPushRowsWithMetadata), but it could be added to the existing PushRows APIs as well if so desired.  The fix (to be approved still) involves initializing the bins with the number of external threads that will be used, thus allowing the SparseBin to add extra push buffers for thread isolation.

@svotaw Thanks for working on this. Yes. I think LGBM_DatasetPushRows wasn't designed for multithreading from outside the API before. I'll review the PR this weekend.

Fixed with https://github.com/microsoft/LightGBM/pull/5551


What license is this project released under?

Description
I'm looking at using this project, but I'm unable to do so at the moment without a software license. Is the project intended to be used under a specific license?
From the GitHub docs.

You're under no obligation to choose a license. However, without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work.

Oh boy, I wish this to be hosted without strings attached, here is an MIT License.


fix/build-issue

Descriptions

Fix the build failure of the main branch on Netlify

Stories

[x] extend the staticPageGenerationTimeout to 1000 in next.config

Screenshots

Testing the build by merging this branch to main to see if the build and deployment works on Netlify.

Build Successful


🪄 add horoscope stars for monthly、daily、hourly. #210

#210

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.81%. Comparing base (56cd86d) to head (bf41a18).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   97.83%   97.81%   -0.02%
==========================================
  Files          79       79
  Lines        1384     1374      -10
  Branches      227      226       -1
==========================================
- Hits         1354     1344      -10
  Misses         26       26
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Handle error when the connecttion to the sphero fail

Before that, when we did "orb.connect()", if it failed it throws an error that we could not handle.
Now we are able to do "orb.on("error", function() { // Do something });". We can handle the error.

Hi, @GuillaumeRahbari can you please look at your failing test? https://travis-ci.org/orbotix/sphero.js/jobs/102923952#L1248
Thank you!

Hi, @GuillaumeRahbari did you ever have a chance to look into the failing test on this PR?

No I'm sorry, I will take a look as soon as I can. I can't just right now.


Never rejects if Date.now is mocked in the test

Hi there, thanks for a nice and convenient package!
This is mostly the same case as #4, but Date.now is mocked instead of setTimeout. And if the Date.now is mocked, this condition: https://github.com/TheBrainFamily/wait-for-expect/blob/master/src/index.ts#L21 will be either always true, or always false. So tests with mocked Date.now will either fail without retrying, or fail with temeout error.
The solution for this is always to use the real Date.now the same way we're doing with setTimeout. I'll provide a PR for this where we can continue the discussion.

Bonus: example of such mock in the real world: https://github.com/facebook/jest/blob/6d3da9be06350bfa7414b609807ebd0cbdf0c416/examples/snapshot/tests/clock.react.test.js#L11

Merged and released, thank you so much :-)

I am using typescript with react-hooks-testing-library that uses this library. To get tests to run, I had to mock Date in my tests
declare global {
  interface Window { Date: any; }
}
window.Date = Date;

And comment out the code in wait-for-expect starting at line 16:
var _ref = typeof window !== "undefined" ? window : global,
   setTimeout = _ref.setTimeout,
   now = _ref.Date.now;

Is this a bug?

Could you please make a small reproduction that shows the problem?

Repro at https://github.com/chetmurphy/wait-for-expect-test
After installing with yarn run yarn test – will fail
● Test suite failed to run
TypeError: Cannot read property 'now' of undefined

  at Object.<anonymous> (node_modules/wait-for-expect/lib/index.js:16:21)
  at Object.<anonymous> (node_modules/dom-testing-library/dist/wait.js:10:45)
  at Object.<anonymous> (node_modules/dom-testing-library/dist/index.js:83:13)

Test Suites: 1 failed, 1 total
Comment out wait for expect section at wait-for-expect/lib/index.js:16
Rerun yarn test - should succeed.
--Chet

From: Łukasz Gandecki<EMAIL_ADDRESS>Sent: Sunday, March 24, 2019 10:01:14 PM
To: TheBrainFamily/wait-for-expect
Cc: chetmurphy; Comment
Subject: Re: [TheBrainFamily/wait-for-expect] Never rejects if Date.now is mocked in the test (#12)
Could you please make a small reproduction that shows the problem?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTheBrainFamily%2Fwait-for-expect%2Fissues%2F12%23issuecomment-476055600&data=02|01||0407f97894f8434a3d9208d6b0dee8a8|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636890868757911332&sdata=dLO7WiRjKTi52KjX5YFg9PPcB%2Fud5ODJTjyoxImiHIM%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJrbVk8_jyPVuept_h6qb6q1_62UhqFbks5vaFgagaJpZM4YdgZ4&data=02|01||0407f97894f8434a3d9208d6b0dee8a8|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636890868757921344&sdata=p%2By%2FPXqR4GRqohGgv7ME8iPK35TIrgLzkI%2ByLmZIKiI%3D&reserved=0.


Wierdness with GetPrimitiveArrayCritical buffers

Buffers pinned with GetPrimitiveArrayCritical get corrupted in the ZstdInputStream under certain garbage collectors when the tests are run in parallel.  G1GC reliebly works without fault.
Another option is to ise GetByteArrayElements for the destination buffer (it solves the problem) but it is detremental of the performance because each get/release is making a new copy.
Needs further investigation.

Switched to using direct ByteBuffers and that solves the problem


gccgo: assert in "implements_interface", types.cc:9145 with inlinable function

What version of Go are you using (go version)?
Using gccgo tip

$ go version
go version go1.12.2 gccgo (GCC) 10.0.0 20190624 (experimental) linux/amd64

What operating system and processor architecture are you using (go env)?
linux/amd64
What did you do?
Build the following three packages: first "a", then "b", and finally "c".
Package "a":
package a

import "context"

type Service uint64
type ServiceDesc struct {
	X int
	uc
}

type uc interface {
	f() context.Context
}

var q int

func RS(svcd *ServiceDesc, server interface{}, qq uint8) *Service {
	defer func() { q += int(qq) }()
	return nil
}

Package "b":

import (
	"a"
	"context"
)

type BI interface {
	Something(s int64) int64
	Another(pxp context.Context) int32
}

func BRS(sd *a.ServiceDesc, server BI, xyz int) *a.Service {
	return a.RS(sd, server, 7)
}

Package "c":

import (
	"a"
	"b"
)

var GA a.Service

func C() {
	b.BRS(nil, nil, 22)
}

What did you expect to see?
Clean compile
What did you see instead?
Assert as follows:

go1: internal compiler error: in implements_interface, at go/gofrontend/types.cc:9145
0xbc4cfc Interface_type::implements_interface(Type const*, std::__cxx11::basic_string, std::allocator >*) const
	../../gcc-trunk/gcc/go/gofrontend/types.cc:9145
0xbaa243 Type::are_assignable(Type const*, Type const*, std::__cxx11::basic_string, std::allocator >*)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:737
0xbaa6e1 Type::are_convertible(Type const*, Type const*, std::__cxx11::basic_string, std::allocator >*)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:813
0xab2a5e Type_conversion_expression::do_check_types(Gogo*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:3921
0xb370bb Expression::check_types(Gogo*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.h:957
0xb24059 Check_types_traverse::expression(Expression**)
	../../gcc-trunk/gcc/go/gofrontend/gogo.cc:3795
0xaaab16 Expression::traverse(Expression**, Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:45
0xadff7f Expression_list::traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:18499
0xac6a3d Call_expression::do_traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:10647
0xaaab51 Expression::traverse(Expression**, Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:51
0xb8f033 Statement::traverse_expression(Traverse*, Expression**)
	../../gcc-trunk/gcc/go/gofrontend/statements.cc:86
0xb91133 Assignment_statement::do_traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/statements.cc:883
0xb8ef79 Statement::traverse(Block*, unsigned long*, Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/statements.cc:56
0xb2d9ea Block::traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/gogo.cc:6854
0xba2a20 Block_statement::do_traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/statements.h:970
0xb8ef79 Statement::traverse(Block*, unsigned long*, Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/statements.cc:56
0xb2d9ea Block::traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/gogo.cc:6854
0xb29608 Function::traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/gogo.cc:5760
0xb341f8 Bindings::traverse(Traverse*, bool)
	../../gcc-trunk/gcc/go/gofrontend/gogo.cc:9130
0xb22115 Gogo::traverse(Traverse*)
	../../gcc-trunk/gcc/go/gofrontend/gogo.cc:2841
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See  for instructions.

What appears to be happening is as follows:

Compiler imports "a", and in the process reads in type information for the "context.Context" type. Here are excerpts from the dump of a's export data:

types 30 3 ...
type 1 "Service"
type 2 "ServiceDesc"
type 3 ".a.uc"
type 4 "context.Context"
...
type 22 struct { X ; ? ; }
type 27 interface { }
type 28 interface { .a.f () ; }
type 29 interface { Deadline () (deadline , ok ); Done () ; Err () ; Value (key ) ; }

Note that there is a chain of type references from one of the exported types ("ServiceDesc") to the empty interface type corresponding to "type 27", which gets created eagerly (since it is needed by an exported type).

Compiler imports "b", which contains an inlineable function "BRS". Here are excerpts from b's export data:

types 33 2 ...
type 1 "BI"
type 2 ".a.uc"
type 3 "a.Service"
type 4 "a.ServiceDesc"
type 5 "context.Context"
type 29 interface { }
type 30 interface { .a.f () ; }
type 31 interface { Another (pxp ) ; Something (s ) ; }
type 32 interface { Deadline () (deadline , ok ); Done () ; Err () ; Value (key ) ; }
func BRS (sd  , server  , xyz ) ($ret0 )
// /ssd2/go1/src/b/b.go:13
{ //14
$ret0 = RS(sd, $convert(, server), $convert(, 7 )) //14
return //14
} //0

Key thing to note is that we have an exported type 'BI', which refers to context.Context. Since context.Context was encountered previously, we discover this fact at the point where we import the named type, and so we reuse the previously established Type object. See import.cc line 1091.
However we continue on to read the methods (import.cc line 1103, meaning that we create a new empty interface corresponding to "type 29" (which again gets created eagerly).
The key difference here is that there is no reference to this type from an exported type in the package (we broke the link by using the previous definition of conext.Context).

Compiler calls Gogo::finalize_methods.  This visits all of the various methods reachable from package bindings, but it skips "type 29" (as described above) since there is no way to reach it.

Compiler calls Gogo::lower_parse_tree(). This has the side effect of bringing in the body of the inlineable function "BRS" from package "b". We now have a live reference to type 29.

Compiler calls check_types() -- now we encounter type 29, and assert since it wasn't exposed to finalize_methods().

Possible approaches to fixing this.
One possibility would be to change Import::read_named_type so that if it encounters a previously defined type it doesn't read it at all -- just returns the previously defined type.  I prototyped this, but I don't think it will work in this specific case: there is still a dangling reference to 'type 29' via the prototype for the "a.RS" declaration, so the phantom type still gets created on import. We'd need some way to skip it as well.
Another hacky solution would be to set an interface finalized on creation if its parse_methods are empty.

What would happen if we changed Import::read_type (not Import_function_body::read_type) so that it calls finalize_methods_for_type after calling type_for_index, just as Import_function_body::read_type does?

I am OK with that I suppose. Input::read_type gets called quite early, but then again finalize_methods happens pretty early as well. I will give it a try.

It looks like an eager call to finalize_methods_for_type from Import::read_type has some problems -- what seems to happen is that we read a named type NT (but not its underlying type), create a forward declaration type for NT, then read another type T2 whose methods refer to NT. When we try to finalize methods for T2, we get an assert, e.g.

#1  Forward_declaration_type::warn () at ../../gcc-trunk/gcc/go/gofrontend/types.cc:12278
#2  Forward_declaration_type::real_type () at ../../gcc-trunk/gcc/go/gofrontend/types.cc:12327
#3  Forward_declaration_type::do_hash_for_method () at ../../gcc-trunk/gcc/go/gofrontend/types.h:3760
#4  Type::hash_for_method () at ../../gcc-trunk/gcc/go/gofrontend/types.cc:943
...

I'm going to propose an alternative, which is to change the importer to make a second pass through the types array after exported types are read in and call finalize_methods_for_type then.


Dark mode for /shabad doesn't take care of Toggles

https://github.com/bogas04/SikhJS/commit/5e043aeceb057b67583c8c1b0ee65c329a70faeb fixes it


feat: in-page navigation

Summary
Adds in-page navigation component
Related Issues or PRs
Resolves #2518
How To Test
Storybook
Screenshots (optional)

I keyboard tested this against Trusted Tester standard Check 2.4.3-focus-order-reveal, and I am not sure we are getting the expected behavior. In USWDS core, their demo shifts the focus to the header that was navigated to when the link is activated in the navigation.

We are currently resetting our focus when the link is activated. We probably want to replicate the behavior of the original component in USWDS, which I'd hope was tested with users and validated as the best way to provide an accessible AT experience.

tested in Chrome on Mac

I keyboard tested this against Trusted Tester standard Check 2.4.3-focus-order-reveal, and I am not sure we are getting the expected behavior. In USWDS core, their demo shifts the focus to the header that was navigated to when the link is activated in the navigation.
We are currently resetting our focus when the link is activated. We probably want to replicate the behavior of the original component in USWDS, which I'd hope was tested with users and validated as the best way to provide an accessible AT experience.

Oh great catch! I'll try to get around to that unless you've got a fix in mind?

Actually, no, it's working as intended; I just added some links to the story to demonstrate. Activate an anchor link and then tab to the link within the following paragraph. [localhost link]
Also, re your gif, I'm not sure why they set visible focus on the heading, since it's not interactive. W3 itself uses a similar component and it does not show visible focus on headings (e.g. click "Abstract")

Hello. I will do a design review on this now.


rustfmt

Run (and keep using) rustfmt real soon now 🙃
Edit: Also, think about using clippy

We have a TravisCI setup now which will enforce rustfmt and clippy warnings.