[Bug] Reader.getSelectedText returns altered version of actual text

Probably not an issue for you to fix but just to let you know the current version of Reader.getSelectedText() returns a version of the text that messes with the unicode value.
First reported on my plugin here
When selecting text with diacritics (eg "Å"), Reader.getSelectedText() incorrectly returns a two unicode character string (U+0041 (LATIN CAPITAL LETTER A) and U+030A (COMBINING RING ABOVE))
Whereas getting the selected text with something like
Zotero.Reader.getByTabID(Zotero_Tabs.selectedID)
  ._iframeWindow
  .getSelection()
  .getRangeAt(0)
  .toString()

correctly returns a one character string (U+00C5 (LATIN CAPITAL LETTER A WITH RING ABOVE))
Also passed on to Zotero here
Since this is seemingly caused by Zotero itself and your toolkit doesn't do any form of re-encoding/etc, it's probably best fixed by them. But just in case it doesn't get fixed for some reason, I thought I'd let you know.

Thanks for letting me know. The problem you mentioned is an issue with Zotero and is not related to this package. I'm afraid there is nothing I can do.

Turns out, I jumped the gun and didn't do my research, whoops...
Unicode has different normalised forms for encoding (accessed through String.prototype.normalize()) and Zotero consistently normalises to NFC (decomposed into parts, also the default), whereas what I needed was NFD (decomposed then recomposed systematically, not the default)
So if anything, the two character version, while not true to the original text, is consistent within Zotero, and my _iframeWindow.getSelection() version is a hacky work around that skips Zotero's normalisation...
Sorry for the false alarm lol I'll be sure to be more careful in the future 😅


Biology  implement of ColossalAI

Hi @XIXIYOUNG2018  Thanks for your contribution!  Here are some suggestions for improvement:

Upload the data file to Google Drive or Baiduwangpan, rather than here.
Polish README: Why did you implement this biology example, how this example will help others, what is the expectation training result for this example, and did you verify its correctness (please provide the satisfactory log)?
Is there any reason for you to use resnet18 in this example? Colossal-AI is mainly designed for large AI models with parallel techniques, which perform better for transformer structures.
Currently, this example does not support main features in Colossal-AI, eg. data/tensor/pipeline/sequence parallel, ZeRO, etc. Is there any reason why this example is limited to a single GPU?

This PR is closed due to inactivity.


Person nodes can be created with duplicate email addresses

Email addresses need to be unique across Person nodes. Currently, it is possible to create Person nodes with duplicate email addresses through the api. This can happen through the create or update modes.
We need to prevent this by checking for existing Person nodes with the passed email address before proceeding with the create or update operation.

This is in 8ebcd28e48bc507e799ab06ecdac837444da4620. That commit is on the about-those-groups branch and will get folded in when that branch is merged.

Although see https://github.com/paleobot/pbot-dev/issues/43 for other user-related checks to be implemented in the future.


run wth -t flag on android shows devices and emulators, but question is about emulators only

Describe the bug
run wth -t flag on android shows devices and emulators, but question is about emulators only
To Reproduce

have device connected
do npx rnv run -p android -t

? What emulator would you like to use?
❯ Pixel_6 | Phone 📱  | arch: arm64-v8a | udid: <IP_ADDRESS>:40635 (device)  (active)
  Pixel_6 | Phone 📱  | arch: arm64-v8a | udid: adb-1C011FDF6003E5-Iac2B2._adb-tls-connect._tcp
. (device)  (active)
  Pixel_4_API_29 | Phone 📱  | arch: x86 | udid: unknown
  Pixel_4_API_33 | Phone 📱  | arch: x86_64 | udid: unknown
  Pixel_6_API_33 | Phone 📱  | arch: x86_64 | udid: unknown

Expected behavior
What emulator or device would you like to use?, What target would you like to use?
Desktop (please complete the following information):

OS: macOS Ventura 13.5.2
Node Version 18.19.0
RNV Version 1.0.0-rc.10

@pavjacko said "rename "emulator / simulator / device" to unified target for all use cases"


Add support for Android 12 SplashScreen API

Details
First step for [New Feature] Animate Native SplashScreen #14151
This update the current BootSplash module to support Android 12 SplashScreen API (removing the double splash screen issue: the one displayed on the system thread and the one displayed by the app).
Why not using androidx.core:core-splashscreen?
There's currently a few issues with Google library (which is used by react-native-bootsplash v4). I can list:

It locks the full UI until the splash screen is hidden (related issue). This is mostly due to the way the splash screen is suspended. That's why this implementation immediately switch to a Dialog on init.
Splash screen is never init on Android 12 when the app is opened though an intent. This means that it will not appear if you starts your app using the CLI, or even worse, using a notification. This also means that setOnExitAnimationListener is never called on these cases, making its usage unreliable. This sounds silly but it hasn't been fixed yet (at least for Android 12, not for Android 13 - one of the many related issues).
That's also why I put a Dialog to the rescue 😄
Splash screen flickers on fade on Android 13 (related issue). I initially though it was an issue with a React Native new version. After checks, it's not: it only occurs on Android 13.
The polyfill package try to mimic the system thread splash screen by setting transparent status / navigation bar until it's hidden. But it messes react-native (let's suppose your mount a <StatusBar /> + hide the splash screen at initial render - you get the idea)
The polyfill is not compatible with Android < 6 (it only display the background color - related)

This is why I will stop using it. I investigated a lot lately and this PR is just the result of my current work on react-native-bootsplash v5 (which should be coming coming soon) 🙂
Fixed Issues
https://github.com/Expensify/App/issues/14151#issuecomment-1480655738
Tests

Compiles and starts the app on a device with Android > 5
Verify that there's an unique splash screen and that it is dismissed

Screenshots/Videos
Android
https://user-images.githubusercontent.com/1902323/229376794-65e73722-0eeb-4347-b29b-acceb85ed83f.mp4

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]


OSGi and Maven version mismatch breaks the build

mvn clean install
Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:1.0.0:validate-version(default-validate-version) on project org.symphonyoss.symphony.tools.rest.ui.console: Unqua
lified OSGi version 0.1.0.qualifier must match unqualified Maven version 0.1.2-SNAPSHOT for SNAPSHOT builds

I was mid way through a release which caused this, I don't have time to finish the job now so I have merged this so the master branch builds in case anyone else looks immediately.

When I say "merged this" I mean merged the PR which you raised to fix it.


add_method_tracer modifies object arguments

add_method_tracer causes object arguments to be cloned.
Description
When tracing a method that takes an object argument that is supposed to be mutated during the execution of that method, the tracing causes the passed argument to be a clone of the object, meaning that any mutations are lost to outside references to the same object.
Expected Behavior
No cloning of arguments should happen and the passed object should be included in the call to the method as is.
Steps to Reproduce
class Demonstration
  include ::NewRelic::Agent::MethodTracer

  def call
    (1..10).each_with_object({}) do |i, hash|
      process(i, hash)
    end
  end

  def process(i, hash)
    hash[i] = i * 2
  end

  add_method_tracer :process, 'Demonstration/process'
end

Demonstration.new.call
#=> {}

Expected result:
Demonstration.new.call
=> {1=>2, 2=>4, 3=>6, 4=>8, 5=>10, 6=>12, 7=>14, 8=>16, 9=>18, 10=>20}

Your Environment
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
Additional context
It seems like this is not an issue in Ruby 2.6

Hello @dipth. We will take a closer look at this.
Thank you for bringing this to our attention.

This should be solved by this PR: #422


[WIP] KubeVirt cli release tool

This tool will be used by release automation for cutting release branches and new releases.
The tool will be capable of

detecting blockers
cutting new release branches
cutting new release candidates
promoting release candidates to offical releases
automate generating official release notes using merged release-notes in PR descriptions and list of contributors from previous official release.

Release note:

release tool used to automate kubevirt releases.

obsoleted by https://github.com/kubevirt/project-infra/pull/495


A few nitpicks with ddlist

I've found a few problems with lv_ddlist, though some of them technically would be problems with lv_page. These are particularly obvious when dealing with small displays. Unscii font is used in these examples.
The first issue is a combination things dealing with the text line spacing and highlighted selection drawing.
The word "Testy" is used because the T includes pixels in the top row of the 8 pixel height font, and the y includes pixels in the bottom row of the 8 pixel height font. So, the word spans the full height of the font.

The collapsed ddlist should show only one option regardless of line spacing (a line spacing of 8 here makes it very clear, you wouldn't necessarily see this with a smaller line spacing):

The highlighted option draws more under the text than below the text. It seems to me it should be more balanced and try to draw the highlight such that the text is centered vertically within it.
With line spacing of 8 you can clearly see more pixels below than above:

With line spacing of 2 there is an extra row below but not above, so the top of the T blends with the black background:

The other thing is that the scrollbar looks awkward when the ddlist is closed. It would look better if it was centered vertically when collapsed, or disappeared when collapsed.
I know these seem like nitpicky little details but they are pretty significant when dealing with smaller screens with fewer pixels. My intent is only to improve the project 😄

Hi,
Thank you for the detailed report.
To examine it please send the code and styles you used to create the ddlist.

ddlist code (nothing special I think):
	lv_obj_t *dropdown = lv_ddlist_create(lv_scr_act(), NULL);
	lv_ddlist_set_options(dropdown, "Testy\nTest2\nTest3\nTest4\nTest5\nTest6\nTest7\nTest8");
	lv_ddlist_set_fix_height(dropdown, 50);
	lv_ddlist_set_hor_fit(dropdown, false);
	lv_obj_set_width(dropdown, 50);
	lv_ddlist_set_sb_mode(dropdown, LV_SB_MODE_AUTO);
	lv_obj_align(dropdown, NULL, LV_ALIGN_IN_TOP_RIGHT, -10, 10);

Theme is the same as that in issue #175
Play around with def.text.line_space in the theme to see how it affects the dropdown.
Font used is unscii.

Hi,
I know it's a quite old issue but hopefully, you or somebody are still interested in the updates.
I made some test and seems some of the issues are already solved.
Here is the result with text.line_space = 4 using the dev-5.2 branch. The selected rectangle is symmetrical now.

The intention was to use the default  LV_SB_MODE_DRAG which is invisible when the ddlist is closed. However, it is really useful to use LV_SB_MODE_AUTO. So I updated the ddlist to handle other scrollbar modes too.

As there was no activity here for a while  I suppose the issue is solved.
If it's not working feel free the comment here and reopen this issue.