Write up outcomes of the standards/practices session

User Story
As a mod platform engineer, I want to have a guidance on standards and practices.
User Type(s)
MP engineers
Value
Consistency, code quality, guidance for new or more junior team members.
Proposal
See the miro board to for the outcomes of the standards/Practices session.
Document it in the MP user guide.
Definition of done

[x] readme has been updated
[x] standards added to public docs / team guide
[x] another team member has reviewed
[x] tests are green
[ ] UR test OR added to continual research plan

Reference
How to write good user stories

Implemented with: https://github.com/ministryofjustice/modernisation-platform/pull/2688 & https://github.com/ministryofjustice/modernisation-platform/pull/2701


Update tasks run and format

Coverage remained the same at 52.564% when pulling cc780cd8b9e860eb4e28cd5388c87f1579ec2006 on mresti:update_makefile into 4cb425754cd3afdde877d822dc553b8e9ed9ff23 on ManageIQ-Exchange:master.

Coverage remained the same at 52.564% when pulling cc780cd8b9e860eb4e28cd5388c87f1579ec2006 on mresti:update_makefile into 4cb425754cd3afdde877d822dc553b8e9ed9ff23 on ManageIQ-Exchange:master.


[carbonmark] Disable Credit Card payment for ICR listings

If @psparacino has not done this yet--
The fiat tooling doesn't support tokenIds yet. Until we upgrade it, we need to prevent users from trying to pay with credit card on an ICR listing.
This is a temporary workaround until we ship the fiat tooling upgrade to support ICR

This needs to happen after #2052 is merged

That is not in the current PR, correct

That is not in the current ICR PRs, correct

@psparacino @sprrwhwk #2052 is merged so we should be moving now on this high priority item


Update job-scheduler.md

recent change to run slots per #shipped post

thanks so much @schottj , added a link to the release note in case users wanted more context.
quick question, we don't seem to mention dev and team plans having 2 run slots (not even on our pricing page), do you think we can add this like the below:

Developer and Team plan accounts have two run slots, and...

hey @schottj , i think you opened pr https://github.com/dbt-labs/docs.getdbt.com/pull/3737/files, which makes the same changes as this pr. did you want to work on this pr first?

I liked how you changed it:
| Run slot | Run slots control the number of jobs that can run concurrently. Developer and Team plan accounts have a fixed number of run slots, and Enterprise users have unlimited run slots. Each running job occupies a run slot for the duration of the run. |
I guess I forgot i had a pr open and tried to make the change 2x. Once you change it to the above, please feel free to merge!


HDDS-9980. Improve assertTrue assertions in hdds-common

What changes were proposed in this pull request?
Replace some assertTrue/assertFalse with assertThat, which can provide details about the failure, in hadoop-hdds/common.
https://issues.apache.org/jira/browse/HDDS-9980
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7390928267

Thanks @hemantk-12 for the review.


Compactor: Document reasons and solutions about overlaps

Signed-off-by: Xiang Dai<EMAIL_ADDRESS>Fix #2182

I mean.. totally new section in docs, and new directory (:

I would name such a section in the docs “Operational guide”.

Added section @daixiang0  https://github.com/thanos-io/thanos/pull/2195 (: You can rebase your PR on mine or wait until merged to put you amazing doc there. What do you think? (: :hugs:

I would rebase that :)

Well, because you have a healthy system! (:
Feel free to take something from issue.
On Thu, 27 Feb 2020 at 10:18, Xiang Dai<EMAIL_ADDRESS>wrote:

@daixiang0 commented on this pull request.
In docs/operating/troubleshooting.md
https://github.com/thanos-io/thanos/pull/2191#discussion_r385032885:

@@ -5,4 +5,22 @@ menu: operating
slug: /troubleshooting.md

-Work in progress (:
+# Overlaps
+
+Overlaps should never happen in healthy and well configured Thanos system. That's why there is no automatic repair.
That would be helpful!
But i do not see any overlaps when use compator :(
I would use logs in related issues.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/pull/2191?email_source=notifications&email_token=ABVA3O66UXBB3WIZUQDSQWTRE6HOBA5CNFSM4K35PLT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXFAPZQ#discussion_r385032885,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3OZKCZF46UMQJ4BP47DRE6HOBANCNFSM4K35PLTQ
.


Merge marsha's env.d/development & development_secret files

Purpose
Two environment files are currently required to bootstrap a development environment to work on:

env.d/development
env.d/development_secret

The first one is committed in the repository and the second one is not. I think this can be improved with a single environment file (e.g. env.d/development) that is committed as a template (with fake values and appropriate comments) and git-ignored (this should already be the case).
Proposal

[ ] merge those two files as env.d/development
[ ] add fake values
[ ] add a relevant comment for each variable

As discussed in the team: we should distribute this configuration example as an explicit template. The issue description has been updated consequently.

IMO the files have to remain separate.
You may not have experienced it because you started on the project when the create-state is already done.


Feat/add abstract broker class

Summary by CodeRabbit

New Features

Introduced new methods in the Broker class for improved handling of JSON data and generation of Time-based One-Time Passwords (TOTP).
Enhanced JSON parsing and response handling capabilities.
Added functionality to download expiry dates from the National Stock Exchange (NSE) and Bombay Stock Exchange (BSE) with user-friendly Jupyter notebooks.

Bug Fixes

Improved error handling for invalid JSON inputs and TOTP generation scenarios.

Tests

Added comprehensive test cases for JSON parsing, TOTP functionalities, and the new expiry date retrieval methods, ensuring reliability and robustness.

Chores

Updated CI workflow to enhance security model and reflect changes in project structure.

@coderabbit create an issue to resolve the conversations on this PR.


Updating README.md

Updated README.md file with the below details:

the project type
the questions of interest
the goal for the project output (what are you going to produce?)
the data sources you will use

Looks mostly good! However, it might be better to use this https://transtats.bts.gov/Tables.asp?QO_VQ=EFD&QO_anzr=Nv4yv0r�b0-gvzr�cr4s14zn0pr�Qn6n&QO_fu146_anzr=b0-gvzr as the source for the flight delay information instead of the overall BTS aviation page!

It looks great!


Unable to remap the l and k keys

Hi ! First of all I am really thankful for this great extension, saves me a lot of pain !
However, I am not able to remap thel or k keys, and don't really understand why. I have a weird vimrc (I use a bépo keyboard) so I have the settings like this :
jupyter_vimrc.txt
The problem is with the following two lines :
in nnoremap :
['k', 's'] ,
['l', 'r'] ,

These substitution don't work (l still goes to the right, and k goes down) and I don't understand why, because the others work perfectly. Even though I don't believe they fall in the category of your noremap warning, I tried placing them in the nmap section, with no success.
Also I found that the ^ character doesn't work.
Would be happy to provide more information if you feel it is necessary.

Hi @vnepveu
with that vimrc I can see why this is helpful!
I also find that nmap doesn't work for that remapping, which is especially confusing because if you do the mapping wiht :nmap k s from inside an editor it works as expected. So i think you've found a bug :bug:, so congrats on being an official bug finder i guess?

I will try to look into this soon, but I'm a little bit lost as to why this is happening, I thought that what I was doing to remap was the same as typing it in manually, but I guess not.
If you want to poke around then the relative lines are these:
https://github.com/ianhi/jupyterlab-vimrc/blob/f5c4afbf0224186ff7fbc4c1801ffeb29312507a/src/index.ts#L42-L47

looking at https://github.com/codemirror/CodeMirror/blob/55d0333907117c9231ffdf555ae8824705993bbb/keymap/vim.js#L4788-L4799
it really seems that this extension is doing exactly the same thing

@vnepveu i seem to be able to remap l->r but not k->s
I also seem to be unable to use s in jlab-vim even though it works on https://codemirror.net/demo/vim.html
Can you do the following:

see if s works without any remappings
use this barebones vimrc and see if the l->r mapping works

{
    "nmap":[
        ["k", "s"],
        ["l", "r"]
    ]
}

So :

With an empty vimrc, on my setup, using s in jlab does work as in vanilla vim (substitutes starting under cursor).
With the barebone vimrc you provided, the l -> r mapping does work ! But not the k -> s one (pressing k moves down) in jlab.
Even if I don't know TypeScript, reading the lines you showed I do feel like it's weird that it doesn't work...

Some details :
pip3 list | grep ipython:
ipython                      7.13.0
ipython-genutils             0.2.0

pip3 list | grep jupyter:
jupyter                      1.0.0
jupyter-client               6.1.2
jupyter-console              6.2.0
jupyter-core                 4.6.3
jupyterlab                   2.2.8
jupyterlab-server            1.2.0

I'm on Ubuntu 20.04.1

I also get that s works without the remap now, not sure what was wrong before. this is all very mysterious.
I won't have time to look into this in any depth until at least this weekend, but I'm happy to comment if you get into the weeds of it (you'd need to install nodejs (conda install -c conda-forge nodejs) and then follow these instructions https://github.com/ianhi/jupyterlab-vimrc#install-1)
Until we understand this better as a workaround you can just run :nmap k s from any editor in jlab and it should apply to every editor until you refresh the browser.

And even if I don't know TypeScript, reading the lines you showed I do feel like it's weird that it doesn't work...

not so long ago i didn't know any typescript either, then I really wanted to fix a bug in jupyterlab so who knows how much you'll know in a month from now 🙃

You are also using the jupyterlab-vim extension I imagine?

Also I found that the ^ character doesn't work.

I never addressed this. How do you mean? like d^ doesn't delete to the start of the line? That works for me

Pressing ^ normally would put you at the beginning of the line, that doesn't happen here.
I do have jupyterlab_vim :
jupyter labextension list
JupyterLab v2.2.8
Known labextensions:
   app dir: /home/lulwat/.local/share/jupyter/lab
        @axlair/jupyterlab_vim v0.12.4  enabled  OK
        jupyterlab-vimrc v0.3.0  enabled  OK

I'm going to try working on it in the meantime, but it's not urgent !

Pressing ^ normally would put you at the beginning of the line

Wow, somehow I've only ever used shift-i for this....
Confusingly that works for me in jlab without any remappings, and it doesn't look as though anything in your remappings should have affected that.


[Enhancement] Aggreagte push down support local aggregate mode

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Modify aggreagte push down.
for aggregate node, when finish split rule, all aggregate state must be:

Global && un-split (one stage aggregate)
Global && split (two stage aggregate)
Local && split (two stage aggregate)
Global Distinct && split
Local Distinct && split

modify set isSplit logical. all types will set isSplit to true except Global type, because other type always come from SplitAggRule, but isSplit was not set correctly before this pr
add a special stage: Local && un-split, meanings this aggregate don't promise complete aggregation result, just do pre-aggregate on local node.

can be controll the enhancement by session:
set cbo_push_down_aggregate='auto';
set cbo_push_down_aggregate='preaggregation';

example:

don't push down aggregation

set
MySQL td> explain   select sum(t1.v2) from t0 join t1 on t0.v2 = t1.v2 group by t1.v3;
+-----------------------------------------+
| Explain String                          |
+-----------------------------------------+
..........
|   |                                     |
|   8:AGGREGATE (merge finalize)          |
|   |  output: sum(7: sum)                |
|   |  group by: 6: v3                    |
|   |                                     |
|   7:EXCHANGE                            |
|                                         |
| PLAN FRAGMENT 2                         |
|  OUTPUT EXPRS:                          |
|   PARTITION: HASH_PARTITIONED: 2: v2    |
|                                         |
|   STREAM DATA SINK                      |
|     EXCHANGE ID: 07                     |
|     HASH_PARTITIONED: 6: v3             |
|                                         |
|   6:AGGREGATE (update serialize)        |
|   |  STREAMING                          |
|   |  output: sum(5: v2)                 |
|   |  group by: 6: v3                    |
|   |                                     |
|   5:Project                             |
|   |  <slot 5> : 5: v2                   |
|   |  <slot 6> : 6: v3                   |
|   |                                     |
|   4:HASH JOIN                           |
|   |  join op: INNER JOIN (PARTITIONED)  |
|   |  colocate: false, reason:           |
|   |  equal join conjunct: 2: v2 = 5: v2 |
|   |                                     |
|   |----3:EXCHANGE                       |
|   |                                     |
|   1:EXCHANGE                            |
|                                         |
| PLAN FRAGMENT 3                         |
|  OUTPUT EXPRS:                          |
|   PARTITION: RANDOM                     |
|                                         |
|   STREAM DATA SINK                      |
|     EXCHANGE ID: 03                     |
|     HASH_PARTITIONED: 5: v2             |
|                                         |
|   2:OlapScanNode                        |
|      TABLE: t1                          |
..........
|                                         |
| PLAN FRAGMENT 4                         |
|  OUTPUT EXPRS:                          |
|   PARTITION: RANDOM                     |
|                                         |
|   STREAM DATA SINK                      |
|     EXCHANGE ID: 01                     |
|     HASH_PARTITIONED: 2: v2             |
|                                         |
|   0:OlapScanNode                        |
|      TABLE: t0                          |
..........
+-----------------------------------------+

Push down a complate aggregation, like node 3&5

MySQL td> set cbo_push_down_aggregate='auto';
Query OK, 0 rows affected
Time: 0.002s
MySQL td> set cbo_push_down_aggregate_mode=1;
Query OK, 0 rows affected
Time: 0.001s
MySQL td> explain   select sum(t1.v2) from t0 join t1 on t0.v2 = t1.v2 group by t1.v3;
+---------------------------------------------+
| Explain String                              |
+---------------------------------------------+
| PLAN FRAGMENT 0                             |
..........
|   |                                         |
|   11:AGGREGATE (merge finalize)             |
|   |  output: sum(7: sum)                    |
|   |  group by: 6: v3                        |
|   |                                         |
|   10:EXCHANGE                               |
|                                             |
| PLAN FRAGMENT 2                             |
|  OUTPUT EXPRS:                              |
|   PARTITION: HASH_PARTITIONED: 2: v2        |
|                                             |
|   STREAM DATA SINK                          |
|     EXCHANGE ID: 10                         |
|     HASH_PARTITIONED: 6: v3                 |
|                                             |
|   9:AGGREGATE (update serialize)            |
|   |  STREAMING                              |
|   |  output: sum(8: sum)                    |
|   |  group by: 6: v3                        |
|   |                                         |
|   8:Project                                 |
|   |  <slot 6> : 6: v3                       |
|   |  <slot 8> : 8: sum                      |
|   |                                         |
|   7:HASH JOIN                               |
|   |  join op: INNER JOIN (PARTITIONED)      |
|   |  colocate: false, reason:               |
|   |  equal join conjunct: 2: v2 = 5: v2     |
|   |                                         |
|   |----6:EXCHANGE                           |
|   |                                         |
|   1:EXCHANGE                                |
|                                             |
| PLAN FRAGMENT 3                             |
|  OUTPUT EXPRS:                              |
|   PARTITION: HASH_PARTITIONED: 5: v2, 6: v3 |
|                                             |
|   STREAM DATA SINK                          |
|     EXCHANGE ID: 06                         |
|     HASH_PARTITIONED: 5: v2                 |
|                                             |
|   5:AGGREGATE (merge finalize)              |
|   |  output: sum(8: sum)                    |
|   |  group by: 5: v2, 6: v3                 |
|   |                                         |
|   4:EXCHANGE                                |
|                                             |
| PLAN FRAGMENT 4                             |
|  OUTPUT EXPRS:                              |
|   PARTITION: RANDOM                         |
|                                             |
|   STREAM DATA SINK                          |
|     EXCHANGE ID: 04                         |
|     HASH_PARTITIONED: 5: v2, 6: v3          |
|                                             |
|   3:AGGREGATE (update serialize)            |
|   |  STREAMING                              |
|   |  output: sum(5: v2)                     |
|   |  group by: 5: v2, 6: v3                 |
|   |                                         |
|   2:OlapScanNode                            |
|      TABLE: t1                              |
..........
|                                             |
| PLAN FRAGMENT 5                             |
|  OUTPUT EXPRS:                              |
|   PARTITION: RANDOM                         |
|                                             |
|   STREAM DATA SINK                          |
|     EXCHANGE ID: 01                         |
|     HASH_PARTITIONED: 2: v2                 |
|                                             |
|   0:OlapScanNode                            |
|      TABLE: t0                              |
..........
+---------------------------------------------+
109 rows in set
Time: 0.021s

Push down a pre-aggregation, like node 3

MySQL td> set cbo_push_down_aggregate='preaggregation';
Query OK, 0 rows affected
Time: 0.002s
MySQL td> set cbo_push_down_aggregate_mode=1;
Query OK, 0 rows affected
Time: 0.001s
MySQL td> explain   select sum(t1.v2) from t0 join t1 on t0.v2 = t1.v2 group by t1.v3;
+-----------------------------------------+
| Explain String                          |
+-----------------------------------------+
| PLAN FRAGMENT 0                         |
..........
|   |                                     |
|   9:AGGREGATE (merge finalize)          |
|   |  output: sum(7: sum)                |
|   |  group by: 6: v3                    |
|   |                                     |
|   8:EXCHANGE                            |
|                                         |
| PLAN FRAGMENT 2                         |
|  OUTPUT EXPRS:                          |
|   PARTITION: HASH_PARTITIONED: 2: v2    |
|                                         |
|   STREAM DATA SINK                      |
|     EXCHANGE ID: 08                     |
|     HASH_PARTITIONED: 6: v3             |
|                                         |
|   7:AGGREGATE (update serialize)        |
|   |  STREAMING                          |
|   |  output: sum(8: sum)                |
|   |  group by: 6: v3                    |
|   |                                     |
|   6:Project                             |
|   |  <slot 6> : 6: v3                   |
|   |  <slot 8> : 8: sum                  |
|   |                                     |
|   5:HASH JOIN                           |
|   |  join op: INNER JOIN (PARTITIONED)  |
|   |  colocate: false, reason:           |
|   |  equal join conjunct: 2: v2 = 5: v2 |
|   |                                     |
|   |----4:EXCHANGE                       |
|   |                                     |
|   1:EXCHANGE                            |
|                                         |
| PLAN FRAGMENT 3                         |
|  OUTPUT EXPRS:                          |
|   PARTITION: RANDOM                     |
|                                         |
|   STREAM DATA SINK                      |
|     EXCHANGE ID: 04                     |
|     HASH_PARTITIONED: 5: v2             |
|                                         |
|   3:AGGREGATE (update finalize)         |
|   |  output: sum(5: v2)                 |
|   |  group by: 5: v2, 6: v3             |
|   |                                     |
|   2:OlapScanNode                        |
|      TABLE: t1                          |
..........
|                                         |
| PLAN FRAGMENT 4                         |
|  OUTPUT EXPRS:                          |
|   PARTITION: RANDOM                     |
|                                         |
|   STREAM DATA SINK                      |
|     EXCHANGE ID: 01                     |
|     HASH_PARTITIONED: 2: v2             |
|                                         |
|   0:OlapScanNode                        |
|      TABLE: t0                          |
..........
+-----------------------------------------+

Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 24 / 24 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownAggregateRewriter.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAggregationOperator.java
11
11
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 25 / 25 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownAggregateRewriter.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAggregationOperator.java
11
11
100.00%
[]

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 25 / 25 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownAggregateRewriter.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalAggregationOperator.java
11
11
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Relax dask.dataframe assert_eq type checks

This allows other dask.dataframe-like projects to leverage assert_eq and shouldn't negatitvely affect the power of current tests within dask.dataframe.

cc @rjzamora


METRON-734 Builds failing because of MaxMind DB transitive dependency

The pure exclude solution.  Still being tested on Vagrant, but making it available for viewing.

Spun up in Vagrant and saw enrichment data pass through (including Geo data) as expected.  In addition, GEO_GET in Stellar worked as expected for all data.

+1 by inspection.  Let's wait for a travis build and I move that we merge.

+1, build and tests run (  mvn -q clean integration-test install && build_utils/verify_licenses.sh ), on machine that was failing every every time.

+1 Ran exactly what Travis does locally and it worked, where previously it failed consistently.

This build is not even starting in travis :(

+1 builds and all tests passing. Maybe close and reopen to kick travis?

@kylerichardson nah, travis hasn't gotten to it yet.  It's in the queue.

gotcha, must just be backed up today
On Wed, Feb 22, 2017 at 3:07 PM, Casey Stella<EMAIL_ADDRESS>wrote:

@kylerichardson https://github.com/kylerichardson nah, travis hasn't
gotten to it yet. It's in the queue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-metron/pull/462#issuecomment-281787260,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ6R3ZpPyaqnbvq473HkizS5jLsMlAq_ks5rfJV8gaJpZM4MItYb
.

Apparently https://issues.apache.org/jira/browse/METRON-728 occurs more frequently on travis than my local machine.
The Travis running on my personal account already succeed (https://travis-ci.org/justinleet/incubator-metron/builds/204210174)
I'll kick Travis and hopefully we aren't waiting 16 hours for a build

Given the fact that we are without a working build, the failure here is a known sporadic failure and the Travis queue seems to be very backed up lately, I move that we wait for 3 hours and then commit this PR on the basis of Justin's Travis results linked above.
Objections?

+1 to proceeded with commit based on @justinleet's Travis results
On Thu, Feb 23, 2017 at 7:39 AM, Casey Stella<EMAIL_ADDRESS>wrote:

Given the fact that we are without a working build, the failure here is a
known sporadic failure and the Travis queue seems to be very backed up
lately, I move that we wait for 3 hours and then commit this PR on the
basis of Justin's Travis results linked above.
Objections?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-metron/pull/462#issuecomment-281981347,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ6R3Y0xIeA0OdvKmpmCvIeWmjYmdckXks5rfX35gaJpZM4MItYb
.

I'm also going to tackle METRON-728 this morning, so we can avoid this in the future.

+1 on committing based on Justin's Travis results

Given the fact that we are without a working build, the failure here is a known sporadic failure and the Travis queue seems to be very backed up lately, I move that we wait for 3 hours and then commit this PR on the basis of Justin's Travis results linked above.

+1 to commit based on previous successful travis run.


vendor: update lerna, remove parallel flag from build

Closes #422

LGTM

Am 24.07.2017 um 13:32 schrieb Jonas Keinholz<EMAIL_ADDRESS>Closes #422
You can view, comment on, or merge this pull request online at:
https://github.com/ory/editor/pull/426
Commit Summary
vendor: update lerna, remove parallel flag from build
File Changes
A examples/package-lock.json (6295)
M package.json (4)
Patch Links:
https://github.com/ory/editor/pull/426.patch
https://github.com/ory/editor/pull/426.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@inyono for some reason CI with npm i fails, can you take a look?

Seems like travis runs out of memory (https://github.com/travis-ci/travis-ci/issues/4192#issuecomment-118631896). Not sure what to do about that :/

Ok, I'll check it when I'm back, maybe switching to yarn or clearing caches can help.

Am 30.07.2017 um 01:46 schrieb Jonas Keinholz<EMAIL_ADDRESS>Seems like travis runs out of memory (travis-ci/travis-ci#4192 (comment)). Not sure what to do about that :/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

fixed in #430


Add the capacity to check multiple permissions.

can() method now accepts both string and array arguments.
Create Group model, entity, and migration.
Create Permission model, entity, and migration.
Rename and update the model Group -> GroupUser.
Rename and update the model Permission -> PermissionUser.
Merge file-based permissions with database query results.

Thank you for sending PR.
 Atomic commit is recommended.
Please read https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

First of all, you must GPG-sign your commits.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

Thank you for sending PR.
 Atomic commit is recommended. Please read https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

That is true. I'll look into that in my subsequent PR.
Thank you.

I recommend you send a very small PR that contains only:

can() method now accepts both string and array arguments.

Creating a fine PR that would be merged is not an easy task especially to new contributors.
There are a lot of tasks.
We also invite you to skim https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md.
If you have any questions, please feel free to ask.


Type collisions in Axios HTTP client

Right now when setting
httpClientType: "axios"
Inside HTTPClient class there are some type collisions when constructing headers

I assume this file is autogenerated from here

You can use axios with version 0.21.4
"dependencies": {
    "axios": "^0.21.4",

You can use axios with version 0.21.4
"dependencies": {
    "axios": "^0.21.4",

While this works, of course, it's not a real solution.
Is there any progress made on this?

The problem was introduced with this commit in Axios 0.23.0 by adding explicit type for default headers.
This should not be too hard to fix. I can do the PR, just need some feedback on my initial analysis (due to my limited experience and usage of/with the generator):

mergeRequestParams - I don't understand why this function works with Axios defaults (this.instance.defaults and this.instance.defaults.headers) in the first place. Defaults are set on the instance and will be merged into a request config by Axios itself. So these lines can be safely removed
request function (if (type === ContentType.FormData condition) - little bit harder to make a call as I don't understand the reason for the code and even the PR which introduced it  is not clear why it manipulates the headers (almost feels like it was just useful for the contributor himself for his use case). Anyway common, put etc. keys are not allowed on headers key of the request config and must be removed

Any feedback appreciated

Fingers crossed for compatible fix with axios 0.24 🤞

any update?

Is this fixed yet? Would love to update axios to latest version.

any updates on that? thanks.

as workaround, you can remove default headers from the api instance.
const api = new Api();

api.instance.defaults.headers.put = {};
api.instance.defaults.headers.post = {};
api.instance.defaults.headers.patch = {};

api.auth.login()

now, type: ContentType.Json is working properly. I will try to create a PR to fix this behavior (so, type prop will have more prio)

Actually, it's already fixed in https://github.com/acacode/swagger-typescript-api/commit/94087eca8ff3d717fec054725c159e8f9f5d9cb8

I also have a type problem (axios 0.21.4)

this is used here

But if you just delete HeadersDefaults everything is fine.

This issue still occurs for me:
ERROR in ./src/js/api/swagger/http-client.ts:12:67
TS2614: Module '"axios"' has no exported member 'HeadersDefaults'. Did you mean to use 'import HeadersDefaults from "axios"' instead?
    10 |  */
    11 |
  > 12 | import axios, { AxiosInstance, AxiosRequestConfig, AxiosResponse, HeadersDefaults, ResponseType } from "axios";

Package.json has:

"axios": "^0.21.4"
swagger-typescript-api": "^12.0.4"


physfs: 3.0.1 -> 3.0.2

Motivation for this change
https://icculus.org/pipermail/physfs/2019-March/001280.html
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Reviewer suggested by github, not sure who to bug :).

I think it suggested me because I cleaned it up for dxx-rebirth.
@GrahamcOfBorg build dxx-rebirth

@peterhoeg is the dxx-rebirth failure on aarch64-linux expected?
@dtzWill did you run nix-review pr 57937 on this? physfs is a pretty low level library so I'm guessing at least a few packages depend on it and it would be great to know none of them break.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/12

Thanks all :tada:


AWS region of the CodeCommit repository is hard-coded

The AWS region of the CodeCommit repository is hard-coded into ArgoCD's ConfigMap, so it won't work in other regions.

https://github.com/aws-samples/aws-pipeline-demo-with-tekton/blob/main/tekton-pipeline-demo-k8s-artifacts/templates/argocd/codecommit-repo.yaml#L11
https://github.com/aws-samples/aws-pipeline-demo-with-tekton/blob/main/tekton-pipeline-demo-k8s-artifacts/templates/argocd/demo-app.yaml#L9

Hi @sotoiwa,
Good point! Thanks for letting me know.
I'm going to template the region and publish the changes with the upcoming release.

I am facing an issue when running the below step-
echo "[INFO] $(date +"%T") Create <> Cloudformation Stack..."

Also I want to setup a external github repo. How can I do that


chore: fix osv license scan config and add license override

What this PR does / why we need it:

fix file name in --config arg - I used yaml instead of toml by mistake.
Comment out vulnerability.ignore flag which was added here since it's only supported in osv-scanner v1.9.1. The current osv-scanner-action is v1.9.0. I opened an issue to release a new version.
Added license override for golang.org/x/crypto since it doesn't appear yet on deps.dev.
Opened an issue.

BTW the workflow didn't fail because 127 status code is redirected to 0 when running inside osv-scanner container.
I opened an issue a long time ago.
Release Notes: No

/retest


STEP-7: Design of calculation methods (Start information)

Create a class containing calculation methods for "Start information"
Acceptance criteria:

The "Start information" calculation class was created

Implements in https://github.com/EllsaG/power-supply-design/pull/38 pull request.


Add markdown-lint

I write follow MD022 - Headings should be surrounded by blank lines in my own writings because I find it nicer to read in raw Markdown form. So I would set it to true and adhere it. WDYT?

Looks good, let's give this a go.


Doc says "Azure AD Authentication" is not supported, but it is

Once deployed, there are two SignIn options in the Portal:

Local SignIn
External SignIn (Azure AD)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 735705b0-93eb-09cc-e200-75f1c47c9bc9
Version Independent ID: f8d7c38e-80ea-ca0d-c4e6-10c1d5127fa4
Content: Create a Common Data Service starter portal in Dynamics 365 for Customer Engagement
Content Source: ce/portals/cds-portal.md
Service: dynamics-365-customerservice
GitHub Login: @sbmjais
Microsoft Alias: shjais

Thank you for reaching out. The documentation has been updated.


[CHAD-8803] thermostatOperatingState” and “temperatureAlarmt” updated

thermostatOperatingState” and “temperatureAlarmt” updated to  only contain capabilities that are supported by the device.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Bhavik Thati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@bflorian @greens updated capability configurations

@ctowns can you update this one too?


Python Library error after painful compilation.

❓ Question
After very painfully building the repo from source due to a lot of strangely hardcoded paths to libraries and include which had me modify both the setup.py and the WORKSPACE, I have successfully completed the compilation using bazel. However when I try to use the python extension, I get the following error upon import of the library:
    import trtorch
  File "/home/user/.local/lib/python3.8/site-packages/trtorch/__init__.py", line 11, in <module>
    from trtorch._compiler import *
  File "/home/user/.local/lib/python3.8/site-packages/trtorch/_compiler.py", line 5, in <module>
    import trtorch._C
ImportError: /home/anhman/.local/lib/python3.8/site-packages/trtorch/lib/libtrtorch.so: undefined symbol: _ZN2at11show_configB5cxx11Ev

What you have already tried
The last time I have seen something similar, it was due to attempts of running a compiled binary under a different version of pytorch than the one it was compiled with. It's not the case here as I compiles with 1.7.1.
Environment

Build information about the TRTorch compiler can be found by turning on debug messages

PyTorch Version (e.g., 1.0): 1.7.1-cu110
CPU Architecture: x64
OS (e.g., Linux): Ubuntu20.04
How you installed PyTorch (conda, pip, libtorch, source): pip
Build command you used (if compiling from source): bazel build //:libtrtorch --compilation_mode opt and then python3 setup.py install.
Are you using local sources or building from archives: source
Python version: 3.8.7
CUDA version: 11.2
GPU models and configuration: RTX 3070
Any other relevant information: TensorRT <IP_ADDRESS> and cudnn 8.1

Additional context

Usually this error occurs when the Python API was compiled using the wrong C++ ABI. I would try doing a bazel clean then directly using python3 setup.py install without the intermediate bazel build step

Usually this error occurs when the Python API was compiled using the wrong C++ ABI. I would try doing a bazel clean then directly using python3 setup.py install without the intermediate bazel build step

I just did this an now its erroring out one line sooner:
    from trtorch._version import __version__
ModuleNotFoundError: No module named 'trtorch._version'

I just did this an now its erroring out one line sooner:
    from trtorch._version import __version__
ModuleNotFoundError: No module named 'trtorch._version'

for future notice TensorRT must be in the LD_LIBRARY_PATH

for future notice TensorRT must be in the LD_LIBRARY_PATH

When I tried to run "python setup.py install" two times, this problem is solved.
But I don't know what problem is.

@rafale77 How do you solve it?

It can get a bit complicated depending on your installation. I thought you fixed your problem did you not? Where are you stuck? The key is to get the compiler to find all the files it is looking for either by placing them where it is expecting them or by telling it where they are. Adding tensorRT to the LD_LIBRARY_PATH and to the include path helps but it isn't suffiscient. The repo seems to be made to compile in a container which is not what I am using.


DRAFT: fix: adjust createPages to re-enable hot reload

This PR fixes an issue that causes the hot reload not to work.

DO NOT MERGE - there is a regression in combination with the previous update to enable faster dev build.


Custom Authorizer function

I configured my api to be authorized with an custom authorizer function like this:
api:
    handler: wsgi_handler.handler
    events:
      - http:
          path: /
          method: ANY
          authorizer: validate_firebase_access_token
      - http:
          path: /{proxy+}
          method: ANY
          authorizer: validate_firebase_access_token

validate_firebase_access_token:
    handler: auth.validate_firebase_access_token

But when I run wsgi the authorizer function won't be called... how can I fix this for local development?

I guess by now you figured this out, but let me provide an example of how we use a custom authorizer in case it helps
functions:
  app:
    name: ourapp-service-handler
    handler: wsgi_handler.handler
    events:
      - http:
          method: ANY
          path: /
          cors: true
      - http:
          method: ANY
          path: '{proxy+}'
          cors: true
          authorizer:
            name: custom_auth
            identitySource: method.request.header.Authorization
            type: token
  custom_auth:
    handler: ourapp.functionxyz.auth_authorizer
    warmup:
      enabled: false

So on ourapp.functionxyz.py there is auth_authorizer function that performs authorization. And of course requests need an Authorization header in order to be authenticated, otherwise they are not getting called at all

Suggestion for @logandk : you might want to enable Github Discussions and transform threads like this on to Discussions, so that the Issues list has only issues.
Cheers


storage: support scale in to 1 when no space's replica_factor greater than 1

I failed to scale storage back to 1 after scale out it form 1 to 2. And there only have 1 space with replica_factor=1.
Logs:
I0510 09:18:21.354524   123 Balancer.cpp:306] Too few hosts, no need for balance!

Bug confirmed, will fix, thx!


Fix unreachable code in file creation

This PR aims to improve error handling for failed signature file creation. As I mentioned here, the code responsible for handling the failed pair of promises is unreachable in the current master branch. Additionally, there is an unhandled promise rejection which causes node to issue a warning, which - in turn - makes the action output harder to read. The changes proposed here should solve both problems.
Additionally, I have taken the liberty of switching the build process from local TSC and GH-based node workflow to a fully local build step which includes dependency bundling.
Cheers!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Writhe, This is amazing!!. Thank you very much for your submission 😄 . We will soon review this PR..

@ibakshay Sure thing. I wasn't 100% convinced I should interfere with the workflow, to be honest.
Aaaaand I've just realised you have the entire node_modules directory included in the repo. For some reason I'd assumed the deps were somehow provided by the CI - my bad. I think they can safely be .gitignored, now.
I'll restore the workflow file, then, but will leave the CI bits to you. My Github-fu is too weak to propose a ready solution, but it would probably make sense to run ncc as part of CI, whenever the linting / testing part succeeds. Never tried that on GH, tbh.

I've decided against removing node_modules in this PR. I don't even want to know what a diff with over 7000 removed files looks like. 😄

I'll restore the workflow file, then, but will leave the CI bits to you. My Github-fu is too weak to propose a ready solution, but it would probably make sense to run ncc as part of CI, whenever the linting / testing part succeeds. Never tried that on GH, tbh.

Hi @Writhe, thank you very much :). Your proposal for CI  definitely makes sense, however, test cases are not implemented in this action yet. It is in our backlog and I have also opened an issue for that.

Aaaaand I've just realised you have the entire node_modules directory included in the repo. For some reason I'd assumed the deps were somehow provided by the CI - my bad. I think they can safely be .gitignored, now.

Yes, you are right :). node_modules can be ignored in .gitignore. thanks for pointing it out 😄, I didn't notice until now.

I've decided against removing node_modules in this PR. I don't even want to know what a diff with > >over 7000 removed files looks like. 😄

Haha, I will remove node_modules after merging this Pull Request.  Thank you very much once again for your contribution, highly appreciated 🏅.

You're welcome, cheers.

I didn't notice until now.

I think node_modules were un-ignored on purpose several commits ago, to make up for the lack of bundling. It's not a bad idea, but ncc seems cleaner. Both approaches are mentioned in Github's official docs.

You're welcome, cheers.

I didn't notice until now.

I think node_modules were un-ignored on purpose several commits ago, to make up for the lack of bundling. It's not a bad idea, but ncc seems cleaner. Both approaches are mentioned in Github's official docs.

Could you please send the link of the GitHub's official docs  ?. I am interested to go through to  it :).

@ibakshay
Of course. Intro to GH Actions. This specific part mentions ncc as an alternative to checking in your node_modules dir.


Unable to find driver for Lenovo ThinkPad P14S Gen 2 Type 21A0 21A1

Greetings,
Lenovo hadn't properly updated their driver packages to show that it supported 22H2. I submitted a case with Lenovo to update this and it now shows correctly in DAT, but I get an error when I try to download, extract, and import: "[Error] - Unable to find driver for Lenovo ThinkPad P14S Gen 2 Type 21A0 21A1"
I can download the file directly from Lenovo, perhaps DAT cannot? Can you investigate?

Is this helpful?
https://github.com/MSEndpointMgr/ModernDriverManagement/issues/274#issuecomment-1979629547

Is this helpful? #274 (comment)

Thanks for this. I didn't see 7.2.3 came out. I updated to that version and all worked well. I appreciate your reply!


Add prop to specify if videos is private

This PR aim to add a prop to each video in the playlist of it private or not.
The check based on the fact that owner doesn't appears in private videos.

¯_(ツ)_/¯ sad that project is dead, that feature would be nice (of course adding this by hand in-code is great too but tho...)


3.4.4 ColorPickerButton color_changed signal not emitted on setting .color in code

Godot version
3.4.4.stable
System information
Windows 10, GLES3, NVIDIA RTX 2060, driver 512.95
Issue description
In code, I've created UI scenes for picking a color to tint a part of a material. For example:
var tinter = preload("res://ui/TintSelect.tscn")
// ...later instantiating UI
		var node = tinter.instance()
		node.set_name(tintable)
		node.get_node("VBoxContainer/Label").text = tintable
		var slider = node.get_node("VBoxContainer/HBoxContainer/HSlider")
		slider.value = 0
		slider.connect("value_changed", self, "_on_tint_changed", ["strength", node])
		var colorPicker = node.get_node("VBoxContainer/HBoxContainer/ColorPickerButton")
		colorPicker.connect("color_changed", self, "_on_tint_changed", ["tint", node])
		shapes.add_child(node)

With TintSelect having a scene tree as follows

I'd like to set the tinter to default values in code, after creating the UI:
	var hairTint = shapes.get_node("hair")
	hairTint.get_node("VBoxContainer/HBoxContainer/HSlider").value = 1.0
	var button: ColorPickerButton = hairTint.get_node("VBoxContainer/HBoxContainer/ColorPickerButton")
	button.color = Color8(255, 227, 230)

Which correctly results in the scene starting with the slider value and the color picker button's color being set:

However, only the "value_changed" signal from the slider gets emitted while the "color_changed" signal from the colorPicker does not get emitted. Instead, I have to manually call the slot:
	_on_tint_changed(button.color, "tint", hairTint)

The "color_changed" signal should be emitted when I set the .color property. I've also tried explicitly setting the property via .set("color", ...) to get the same incorrect result. Additionally, I've also tried setting a delay between creating the UI and setting its color value in case it took time to setup its signals, but that also did not change anyything.
	yield(get_tree().create_timer(0.5), "timeout")

Steps to reproduce

create scene with a ColorPickerButton child
instantiate scene in the main scene in code
connect ColorPickerButton's "color_changed" signal to any slot
change the instantiated ColorPickerButton's color property in code
expect the signal to be emitted, but it does not

Minimal reproduction project
No response

Some details about the cause of this issue from Haledire on discord:
https://github.com/godotengine/godot/blob/c02325ffda2258172385e70e160cd476fb19a004/scene/gui/color_picker.cpp#L213
This is the function that changes the color.  It doesn't emit a signal
Neither does the setter:
https://github.com/godotengine/godot/blob/c02325ffda2258172385e70e160cd476fb19a004/scene/gui/color_picker.cpp#L135
https://github.com/godotengine/godot/blob/c02325ffda2258172385e70e160cd476fb19a004/scene/gui/color_picker.cpp#L870
This is where the signal is connected to call the function that emits the color_changed signal.  The function called in he callback here calls the previous function before it emits the color_changed signal
This means it isn't the color value changing that emits the signal - only the slider moving of some internal scroll object emits it
so yes - it's not hooked up to emit the signal when it is expected to (when changing the color property), only when the internal scroll object of the ColorPicker is interacted with, or upon mouse inputs into the ColorPicker as the things that emit "color_changed" are also calling the setter

Most controls in Godot don't emit signals when the value is updated by code. It's Slider/Range's value_changed that is the special case here.
https://github.com/godotengine/godot/blob/a0f70c58196ad6c879926f8b40f1c2c083114d8f/doc/classes/Range.xml#L68

I see, that's kind of a strange design decision. Are there good reasons why that's the case? If so, what is the best way for me to workaround them? Is it to either emit the signal or call the slot directly as in my example case above?

It's like this maybe because when you're updating the value by code, you're able to call the handler function manually. But the other way around is much harder (prevent the signal from emitting when you're updating the value by code).


Add a duk_config.h header to supply platform specific typedefs and defines

The current feature detection approach is based on duk_features.h.in which detects the compiler, platform, user feature options (DUK_OPT_xxx) and provides the necessary feature defines (DUK_USE_xxx), typedefs, and other misc defines expected by Duktape internally. This model has been a sort of a placeholder before a better solution to see how much variability will actually be needed. There are various problems with this approach:

It's non-modular and becomes progressively more difficult to maintain over time, with potential for accidental regression growing over time.
People working on mainline platforms need to wade through a lot of detection stuff that's intended for quite exotic platforms, e.g. platforms with broken compilers, headers, or built-in functions, and low memory embedded environments which may run on bare metal without a proper standard library.
Even so, the model doesn't properly support exotic proprietary platforms, support for which would probably never make it to mainline (nor would that necessarily be appropriate for every exotic platform).
To arrive at the same effective options, typedefs, etc, the user needs to provide the same feature options when compiling Duktape and any application using Duktape. Otherwise the two might not be binary compatible. This works is awkward when the Duktape library is shared (e.g. in distributions).
Because of these shortcomings several users are maintaining patches to duk_features.h.in to support their platform, and the patch needs to be updated when Duktape is upgraded.

The outcome of this detection process, i.e. DUK_USE_xxx and the various typedefs, is OK in my opinion. There would be some potential to drop rarely used options or option combinations, but other than that the separation is quite clean. There's no compiler detection stuff inside Duktape itself, which is nice.
There are many ways to make this more modular. The proposal in this issue is to require a user to provide a duk_config.h header which would define the effective DUK_USE_xxx flags, typedefs, and any other required defines one way or another. More specifically:

Deprecate the current feature options (DUK_OPT_xxx) entirely and remove them from documentation.
Document the DUK_USE_xxx options instead because they'll be tweaked by duk_config.h files directly. This is mostly straightforward, as many DUK_OPT_xxx options map directly to DUK_USE_xxx options.
Keep a DUK_USE_xxx sanity check inside Duktape to detect outright incorrect and unworkable combinations. It's not important that this is 100% correct I think.
Include a script to detect and/or generate duk_config.h headers for specific platforms. Alternatives range from autoconf to a manually written script that can generate various config files based on command line options.
Ship a set of pre-built configuration files for major platforms with Duktape. Perhaps a default duk_config.h could exist, with detection for mainline platforms only, so that there would be a default file that worked out of the box for 90+% of users.
People with custom platforms would make a copy of a generic header and apply their changes there. They'd still need to effectively float a diff when upgrading Duktape, but it'd perhaps be easier than applying the diff to Duktape internals.
If backwards compatibility is an issue, ship a duk_config.h which is basically a snapshot of Duktape 1.x duk_features.h.in (although I think this would be unnecessary and perhaps confusing).
Perhaps prune existing DUK_USE_xxx a bit at the same time; this is an incompatible change so it's also an opportunity to clean up unnecessary cruft.

On a related note, it would be nice to be able to provide the necessary functions to support the Date built-in outside of the master branch. Date built-in is a major component which often needs platform modifications, and collecting all the variants in the mainline is awkward in the longer term. It may be sensible to have Date support for major platforms built-in but it should be easy to replace the provider function(s) through duk_config.h.

The following branch contains a first pass of this (I'll merge the branch in a few days):

https://github.com/svaarala/duktape/compare/external-duk-config-h

The branch provides the basics needed:

An external duk_config.h which is required to be in the include path.
A "genconfig" tool to autogenerate the default, autodetecting duk_config.h header (compatible with Duktape 1.2); genconfig uses config option metadata and header snippets to build the header.
Minimal (unfinished) internal and external documentation changes.
Support for external Date provider.

The only action needed for user build scripts etc at this point is to ensure duk_config.h is in the include path like duktape.h.
Genconfig will be extended to also generate a barebones duk_config.h for a specific platform/compiler/architecture combination. Such headers are smaller than the autodetecting default header and thus easier to tweak for exotic platforms: choose a base header matching the target as closely as possible, and then tweak it manually or through scripting. This branch provides an unfinished draft for barebones headers (Linux/gcc only at this point).
Genconfig will also be extended to autogenerate option documentation so that once a config option has been in a YAML metadata file, it will appear in generated headers and documentation.

The initial branch is now merged to master.
The minimum change needed for user build scripts is to ensure that the default duk_config.h (src/duk_config.h in the distributable) is in the include path when compiling Duktape and user application.

The bulk of this change is now merged to master, cleanups will be tracked separately.


Fix: LIVE-8269 cosmos amount string parser

📝 Description
In the response of cosmos events from explorer. The "amount" field string can contain prefix. Our parser should be able to remove this prefix and get the correct amount string. Otherwise, it will cause a bug in the portfolio graph because of the incorrect amount.
It is a problem due to the multi chain rewards update of cosmos. Before the update, we didn't have this prefix as the follows:
{
                  "key": "amount",
                  "value": "11717uosmo"
},

Now we can have prefix of the amount value since multi chain rewards update
{
                  "key": "amount",
                  "value": "56ibc/0025F8A87464A471E66B234C4F93AEC5B4DA3D42D7986451A059273426290DD5,512ibc/6B8A3F5C2AD51CD6171FA41A7E8C35AD594AB69226438DB94450436EA57B3A89,11717uosmo"
},

we should remove the prefix to get the correct value
❓ Context

Impacted projects: LLC
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-8269

✅ Checklist

[X] Test coverage
[X] Atomic delivery
[X] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

changeset added

/prbot describe


remove onDisconnect for upgraded/secure sockets

In lieu of https://github.com/freedomjs/freedom-for-firefox/pull/60
Fixes https://github.com/freedomjs/freedom-for-firefox/issues/61
Doesn't change anything else, as something about the previous changes (possibly all the crazy continuation passing) was negatively affecting proxying stability. Still worth getting in this because it's basically the single thing blocking uProxy using up-to-date freedom-for-firefox (and thus collecting anonymized metrics, etc.).

:+1:

Just to document before merging - the freedom-for-firefox-jsm built from this works fine w/uProxy (got 180 down/90 up proxying through one of our test users who evidently is sitting on a nice pipe), and the test status is unchanged from current HEAD (failing tests: RTC getInfo, TCP pause/resume, secure socket, two expected TCP errors).


Doubt/suggestion about webui

Hello
I'm running rclone 1.49.1 and I run the command below:
rclone rcd --rc-web-gui --rc-addr <IP_ADDRESS>:5572 --rc-user admin --rc-pass admin
Is possible to run as a daemon this command?
So, I can access webui.
About dashboards I've done a test and notice that when I download a file the graphics works.
Is it possible to get dashboards from another instance of rclone running ? Would be amazing.

I'm running rclone 1.49.1 and I run the command below:
rclone rcd --rc-web-gui --rc-addr <IP_ADDRESS>:5572 --rc-user admin --rc-pass admin
Is possible to run as a daemon this command?

Not currently.  You can set it up in a screen or get systemd to start it for you as a work around.

So, I can access webui.
About dashboards I've done a test and notice that when I download a file the graphics works.
Is it possible to get dashboards from another instance of rclone running ? Would be amazing.

The gui will attach to any rclone you've run with --rc.  However I suspect you are asking, could it show the status of "rclone sync" or "rclone mount"?

Not currently. You can set it up in a screen or get systemd to start it for you as a work  around.

OK

The gui will attach to any rclone you've run with --rc. However I suspect you are asking, could it show the status of "rclone sync" or "rclone mount"?

That's it!  I'm talking about "rclone copy, rclone sync, rclone mount, etc".
I've made a test with the following command and it looks worked.
Is the command below OK or there some parameter that can improve it?
rclone copyto /backup/Volume-Diario-0001 wasabi:bucket-name/Volume-Diario-0001 --stats=1000m --rc --rc-addr <IP_ADDRESS>:5572 --rc-user admin --rc-pass admin --rc-web-gui --log-file /var/log/bacula/wasabi.tmp --log-level INFO

I have 3 kinds of files with 4gb or 10gb to upload (Bacula Volumes)

Files Backup Daily - (run everyday monday to thursday)
Files Backup Weekly - (run everyday friday)
Files Backup Monthly - (everyday saturday)

To improve performance and not generate too much log, I have a script with a loop that execute rclone by backup type. (Today is Thursday, I will run rclone just with only daily volumes)
How do I want to get a stats by every single file, I have the stats with a long time, to generate only when the file was upload successfully "--stats=1000m"
The average speed of my backups is too slow for Wasabi, and using webui I can check in real time.
Thanks

Is the command below OK or there some parameter that can improve it?

That looks about right.  Do you see useful stuff in the GUI?

That looks about right. Do you see useful stuff in the GUI?

I'm loving this new feature!
For the past few weeks, I've been having problems with Wasabi, which is too slow to upload files. Now I can track realtime backup and see if something is wrong
Would be great if in the running jobs dashboard had a information about "Bytes remaining"
The  speeds dashboard appearance it looks have some problem.
I also noticed that in the running jobs dashboard when a job is finished ("Total transferred" is equal of "Size"), it looks is spending more time to finish and start a new file.