Application is crashing when expanding/collapsing nodes with more than 25 levels or adding new nodes after 20th level

Describe the bug
Application crashes when expanding/collapsing nodes with more than 25 levels or adding new nodes after 20th level
To Reproduce
Steps to reproduce the behavior:

Create nodes with more than 25 levels and try to expand by default or try to add the new node after the 25th level using the chart.addNode method

Expected behavior
It should expand/collapse or add a new node without any performance issue

Can you provide an online sample where the issue is reproduced?
I've tested the new  3.x version for 500 level tree and it was working as expected, previous version was inefficient for large level trees.
You can fork this example - https://stackblitz.com/edit/js-mfzkbs?file=index.html

Appreciate the prompt response!
I have tested with the latest 3.x version(3.1.1) and it is working as expected but observed that Pagination is not working with the 3.1.1 version with angular15.
The issue is reproducible in the below link:
https://stackblitz.com/edit/angular-ivy-x5qr97?file=package.json,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fcomponents%2Fd3-org-chart%2Fd3-org-chart.component.html,src%2Fapp%2Fcomponents%2Fd3-org-chart%2Fd3-org-chart.component.ts,src%2Fapp%2Fapp.component.html,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fcomponents%2Fphoto-gallery%2Fphoto-gallery.component.ts

Yes, I know about paging - #316 , will get to that eventually


Problem with scripts containing document.write()

Problem
if one of your scripts contains document.write() e.g. old versions of GA, once the plugin has executed the "sleeping" script, the whole page will disappear and you will see a blank page.
Explanation
document.write() is used to write to the document stream.
Calling document.write() on a closed document stream automatically calls document.open(), which will clear the document.
More info on StackOverflow
Solutions in other libraries

CookieBot overwrites document.write with their own function called writeOverride in its scope
GTM utilises a library called postscribe

Possible solution
// Adding import at the very beginning of CookieConsent
import postscribe from './postscribe.min'
// Creating two helper functions inside CookieConsent function
  /**
   * Save native document.write function for later use
   */
  var _nativeWrite = document.write;

  /**
   * Enhanced document.write function
   * @param {String} html
   */
  var _enhancedWrite = function (html) {
      var element = document.createElement("div");
      element.style.display = "none";
      element.style.visibility = "hidden";
      document.body.appendChild(element);
      postscribe(element, html, {
          done: function() {
              document.write = _nativeWrite;
          }
      });
  }

// Adding document.write = _enhancedWrite;  before curr_script.parentNode.replaceChild(fresh_script, curr_script);
// Replace current "sleeping" script with the new "revived" one
document.write = _enhancedWrite;
curr_script.parentNode.replaceChild(fresh_script, curr_script);

Hi @N4thyra,
I appreciate the detailed explanation + solution!
I understand that it's something which is a must-have for your configuration to work — but — this is also quite a niche feature and for many would be a significant chunk of "dead-weight" (or at least for me).
If there was a simpler/shorter way (relatively little code) to achieve this, then I'd consider adding this feature as a "plugin" once v3 releases.

Hey @orestbida,
Thanks for the reply! I agree that this might be an overkill for many.
Not only is it discouraged to use document.write but e.g. old GA using it should've already been replaced as it's deprecated.
I'm working on a platform that will detect and auto-assign categories to each script, and it's likely that I will need to keep this feature.

I'd like to leave this issue open. I'll see what I can do only after the v3 release.


Chart Editor playtest crash

What is your question?
I'm recharting Blammed, but each time i try to test the chart, I get this error:
Uncaught Error: Null Object Reference PlayState.startCharacterPos() [line 1930] PlayState.addCharacterToList() [line 1773] PlayState.eventPushedUnique() [line 3063] PlayState.eventPushed() [line 3035] PlayState.generateSong() [line 2788] PlayState.create() [line 1191] flixel/FlxGame.switchState() [line 639] flixel/FlxGame.update() [line 726] flixel/FlxGame.step() [line 679] flixel/FlxGame.onEnterFrame() [line 558]
Does anyone know what this means? Any help would be appreciated! This is also my first time modding.

JSEngine_2024-11-26_19'19'34.log

added a character but their positionarray is null


chore: add CODEOWNERS

@cjpillsbury can you merge this one? I can't

Github is saying the file has errors. Still ok to merge?

Approved


Add reactions to issues/PR and comments

Screenshots:

For unauthorized users and tooltip to show reacted users:

Seems good.
Just a question to the team: Should it really look almost identical to GitHub's reactions? Or should it be different to don't look like a GitHub's copy?

@andreynering reactions looks same also in other products (mattermost, discord etc)

reactions looks same also in other products (mattermost, discord etc)

Yes, you're right. I think it's fine, then.

As for these 6 reactions and their naming it just for being API compatible with github

@lafriks It's ready for review so that we can add it to v1.4?

@lunny still WIP, will finish it this week

Ok, I think I have finished it now, so feel free to test and review it.

@ethantkoenig I think have fixed all recommendations

Codecov Report

Merging #2856 into master will decrease coverage by 0.16%.
The diff coverage is 13.84%.

@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
- Coverage   32.53%   32.37%   -0.17%
==========================================
  Files         267      269       +2
  Lines       39271    39556     +285
==========================================
+ Hits        12778    12807      +29
- Misses      24700    24952     +252
- Partials     1793     1797       +4

Impacted Files
Coverage Δ

models/migrations/migrations.go
2.9% <ø> (ø)
:arrow_up:

models/migrations/v49.go
0% <0%> (ø)

modules/auth/repo_form.go
32% <0%> (-0.88%)
:arrow_down:

routers/routes/routes.go
86.41% <100%> (+0.04%)
:arrow_up:

models/models.go
49.33% <100%> (+0.22%)
:arrow_up:

models/issue_reaction.go
12.37% <12.5%> (ø)

models/issue_comment.go
52.31% <17.64%> (-1.43%)
:arrow_down:

routers/repo/issue.go
31.92% <2.6%> (-3.46%)
:arrow_down:

models/issue.go
44.89% <44.82%> (-0.02%)
:arrow_down:

modules/templates/helper.go
52.36% <50%> (-0.11%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a58e3f...ffce2b2. Read the comment docs.

It seems it's not correct popup.

And when click the reations, no request was sent to server.

@lunny did you do Ctrl+f5 seems css&js was used from browser cache

firefox and safari on macOS are almost right. But on safari, see above screenshot. I will clear chrome cache and try it again.

After I clear Chrome's cache files, it's great. LGTM except Safari's problem.

@lunny as I don't have Safari could you help me out to fix that?

@lunny refactored as you suggested :)

@ethantkoenig fixed your suggestions.
Thanks for remaining about unauthorized users, had forgotten about that. While fixing that also realized that I have forgotten adding tooltip to display reacted users. So added that as well

If you add one reaction to a comment that previously had no reactions, then try to unreact by clicking on the reaction icon, the reaction icon will not disappear until you reload the page.

@lafriks need rebase

@ethantkoenig rebased and fixed your reported issues

Lint error

@lunny already fixed that but drone did not pick up latest commit correctly :(

@lafriks You get a 500 if you view an issue that a deleted user reacted to. I think we need to delete all of a user's reactions when a user deletes his/her account.

I think we need to delete all of a user's reactions when a user deletes his/her account.

Hence foreign keys...

https://github.com/go-xorm/xorm/issues/73

@ethantkoenig @bkcsoft Added checks for deleted user and reaction deletion when deleting user

@ethantkoenig moved that hardcoded limit to UI settings

LGTM

@ethantkoenig need your approval

@lafriks I don't mean to unnecessarily delay this PR, but it is too late to ask for tests?

@ethantkoenig I will do them in other PR


[Feature]: Don't require tomli under Python 3.11

To Dos

[X] I have checked the issues and think that this is not a duplicate.

[X] I added a very descriptive title to this issue.

Description
Python has since 3.11 tomli bundled under the name tomllib, so rstchecker should read pyproject.toml without tomli being installed.
Operating System
Linux
Operating System Details
No response
Python Version
3.11.1
rstcheck Version
rstcheck CLI Version: 6.1.1 rstcheck-core Version: 1.0.3

The dependency tomli itself is used in core and I made an issue some time ago. But with python 3.11 being released (since some months) this should finally be resolve. Thanks for the reminder.
https://github.com/rstcheck/rstcheck-core/issues/2
I will probably also add a python version constraint on the optional toml extra in this repo.

Because I am currently rather infrequently at home, I cannot say when I will have time for file changes.
PR welcome. Those I can merge on the way.

Released with 6.1.2


json-path 2.7.0 vulnerabilities should be fixed

What?
Json-path 2.7.0 seems to have a number of vulnerabilities that should be fixed
To reproduce
Simply browse to: https://mvnrepository.com/artifact/com.jayway.jsonpath/json-path/2.7.0

@alainlompo please see the following as they are being addressed. https://github.com/json-path/JsonPath/pull/869
https://github.com/json-path/JsonPath/pull/866

Would argue this should be closed

@UcanInfosec thank you. Allright, then I close this issue.

Being addressed in #869 and #866


gentx: ov-903a9c

First try to add gentx file
This is my gentx file for my validator ov-903a9c for the testnet

My discord id is crampon-viticole if you want to reach me

Hello Pretid,
Thank you for your contribution. We've recently updated the repository structure, which might require you to adjust your pull request accordingly.
Could you please re-commit your gentx file, ensuring it's placed in the new directory galactica_9301-1/gentx/?
Additionally, I noticed a discrepancy in the staking amount specified in your gentx file. It appears to be<PHONE_NUMBER>0000000000agnet, which equates to only 10 GNET. However, the correct staking amount should be<PHONE_NUMBER>00000000000agnet, representing 100 GNET. This error likely stemmed from a typo in our initial instructions, for which we've updated the README to prevent future confusion.
Please regenerate your gentx file with the correct staking amount and submit a new commit reflecting these changes.


REQUEST: support add/remove triage labels on pingcap/tiflash repo

Ref:

https://github.com/pingcap/tiflash/issues/8270

/assign wuhuizuo

/assign wuhuizuo

/unassign Mini256

statics for add/remove affect labels by comments:

It looks that pd and tiflash are not supported. I will fix it.

It looks that pd and tiflash are not supported. I will fix it.

PD is supported, just need to fix for tiflash.


Upgrade @opencensus/web-types to match @opencensus/core v0.0.11

This will require some refactors of the type usage but it up to date with the latest OpenCensus Node release's types.

Fixed


[zh] Resync concepts/scheduling-eviction/assign-pod-node.md

The first commit normalize the current translation -- wrap long lines.
The second commit is about the real sync.

good job
/lgtm
/approve

good job
/lgtm
/approve


Empty pattern array on .isMatch should not match

I would expect this to return false because if there are no patterns, there can not be a match.
> require("matcher").isMatch("hi", []);
true

I guess technically one can interpret a array of "all patterns" with no pattern present as a "matches everything".

It could really be both. However, I'm slightly leaning towards this being a bug and that an empty array should mean that nothing should be matched. Not sure though. Regardless, the behavior needs to be clearly documented.
We also need to think about what patterns like '' and [''] should do.

Well, the current behaviour is:
''       //false
['']     //false
['', ''] //false
[]       //true

I would argue that they should either all be true or all be false, and the smallest breaking change would be to change the emtpy array to false.
I just encountered this problem in a project, and I would have to write a lot of ugly code to fix it, so I'll try to submit a PR here instead.

@atjn Yes, let's go with the empty array meaning false. PR welcome. The behavior should also be clearly documented.


SDK Feature re-org

Overview

removed unnecessary folders in spatial awareness and diagnostics feature folders
updated system file icons

Because we're not doing that literally anywhere else. This is for consistency, and the folder is for all the system level scripts anyway. Anything else shouldn't be in the folder to begin with.

It had been previously proposed (#2540) and discussed in shiproom (and originally checked in for Boundary) to have a structure that resembled:
Feature
\ Prefabs
\ Scripts
\ < any additional folders >
\ System
For the SDK. This is intended to help make it clear for customers importing SDK packages which folders mapped the higher level components and which were the systems as well has representing each SDK package with a single folder containing everything available for that feature (easy import / easy delete).


Add release notes for January release

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/161/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/161/


Issues to access local addons starting with Supervisor Version 174

Home Assistant release with the issue:
0.97.2
Operating environment (HassOS/Generic):
hassio Docker on Ubuntu Server
Description of problem:
Its not possible to connect to some addons like (glances and portainer) with a local IP and a manuell port. (the login dialog appears, but its not possible to login)
Ingress working fine.
Also setting up MariaDB is not working to. Got this error messages in the log.
Error during connection setup: (MySQLdb._exceptions.OperationalError) (2002, "Can't connect to MySQL server on 'core-mariadb' (115)") (Background on this error at: http://sqlalche.me/e/e3q8) (retrying in 3 seconds)
If I downgrade the Supervisor to Version 173 everything starts working again for a shot peroid of time, because the supervisor upgrade again to 179 after a few seconds.

I have the same issues!
My HA is unusable... :(

Duplicate of #1231

I'm sorry. All of my issues still exists on Version 180 :-(
I dont now whats wrong. I cant connect local via IP and Port to the addons (glances, portainer....) and MariaDB is also still not working.
The CLI command: hassio dns Info shows

dns://<IP_ADDRESS>
dns://<IP_ADDRESS>

should this not <IP_ADDRESS> because of Quad9?

MariaDB Addon still not working.

I managed to make MariaDB work again, by uninstalling and re-installing the addon.
I lost the history, but at least is working again.


question about batch size

From the discriminator implementation (model.py), the default value for self.stddev_group is 4.
This gives error in reshaping(or view) operation if the batch size not set multiple of 4 ( and I used multiple GPUs)
below is original implementation of yours
    def forward(self, input, is_feature = False):
        out = self.convs(input)

        batch, channel, height, width = out.shape
        group = min(batch,self.stddev_group)
        stddev = out.view(
            group, -1, self.stddev_feat, channel // self.stddev_feat, height, width
        )

but I found that when I changed the code
 group = min(batch,self.stddev_group)
into
group = max(batch,self.stddev_group)
it does not give error.
I wonder this would be problematic?

I guess it will be not very problematic, but I don't know exactly how it will affect the results.

Thanks :)
I could not find a difference in the generated images (at least in my visual inspection)


add instructions on how to run examples locally to main README.md

This addresses in an obvious way how to build the examples in the README.md: https://github.com/gkjohnson/three-gpu-pathtracer/issues/218

Thanks!


ImportError: No module named tensorflow

Hello,
I am using  TensorFlow For Poets guides for retraining  model. I followed first 3 step successfully. While I run following command at tensorflow root directory.
python tensorflow/examples/image_retraining/retrain.py
--bottleneck_dir=/tf_files/bottlenecks
--how_many_training_steps 500
--model_dir=/tf_files/inception
--output_graph=/tf_files/retrained_graph.pb
--output_labels=/tf_files/retrained_labels.txt
--image_dir /tf_files/flower_photos
I get error   File "tensorflow/examples/image_retraining/retrain.py", line 79, in
import tensorflow as tf
ImportError: No module named tensorflow
System : Ubantu 14.04 LTS
Python Version 3.4.3

Running from the home directory may cause this issue. It may cause python to search for the package within this directory. (Especially you have compiled from source)
Could you try cd-ing into the "tensorflow/examples/..." folder and try running it from there?

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!

Hey kinDSa, have you figured out where the issue is for this? Thanks.


Duffle should not require a credential when it is optional

Consider the following duffle.json:
{
    "description": "A short description of your bundle",
    "credentials": {
        "username": {
            "description": "this is a cred",
            "env": "HOST_KEY"
        }
    },
	"invocationImages": {
		"cnab": {
			"builder": "docker",
			"configuration": {
				"registry": "jeremyrickard"
			},
			"name": "cnab"
		}
	},
	"keywords": ["test", "cnab", "tutorial"],
	"maintainers": [{
		"email"<EMAIL_ADDRESS>		"name": "John Doe",
		"url": "https://example.com"
	}, {
		"email"<EMAIL_ADDRESS>		"name": "Jane Doe",
		"url": "https://example.com"
	}],
	"definitions": {
		"foo": {
			"type": "string"
		}
	},
	"parameters": {
		"foo": {
			"definition": "foo",
			"required": false,
			"destination": {
				"path": "",
				"env": "APP_URL"
			}
		},
		"manifest_file": {
            "definition": "foo",
            "required": false,
			"destination": {
                "path" : "",
				"env": "MANIFEST_FILE"
			}
		}
	},
	"name": "test",
	"schemaVersion": "v1.0.0-WD",
	"version": "0.1.0"
}

This produces a bundle that looks like:
{"credentials":{"username":{"description":"this is a cred","env":"HOST_KEY"}},"definitions":{"foo":{"type":"string"}},"description":"A short description of your bundle","invocationImages":[{"image":"jeremyrickard/test-cnab:7612a24756ad13e91aa1ff2d7795039045b43462","imageType":"docker"}],"keywords":["test","cnab","tutorial"],"maintainers":[{"email":"john.doe@example.com","name":"John Doe","url":"https://example.com"},{"email":"jane.doe@example.com","name":"Jane Doe","url":"https://example.com"}],"name":"test","parameters":{"foo":{"definition":"foo","destination":{"env":"APP_URL"}},"manifest_file":{"definition":"foo","destination":{"env":"MANIFEST_FILE"}}},"schemaVersion":"v1.0.0-WD","version":"0.1.0"}

In this case, the spec is clear that the credential is not required. We currently fail installation if any credentials are defined though:
$ duffle install blah test:0.1.0
Error: bundle requires credential for username

Per the spec, we MUST fail if the credential is required. I believe if a credential is optional we should fail fast. The bundle may or may not need the credential and we should defer to the bundle author to
a.) tell the bundle consumers that it is required by setting it to be required
b.) handle optional credentials in their bundle.
This allows use cases like #574

My take is easy : unless the bundle author marks a cred ad "optional", duffle should fail nicely. The bundle author is in control here.
Do I misunderstand?

The spec says that unless you say it is required, it is optional. Since duffle is the reference implementation of the spec, that is the way it’s implemented. Either way, we produce an error when any credential is declared and not provided. That seems unexpected to me.

If it's optional by the spec, we should not fail if it is not provided. If the bundle requires it, then we must fail. Does that sound right?

This is actually a problem in cnab-go, will move the issue over there.


Base64 for binary fields

For fields that contain non-string binary data (e.g. random tokens), base64 encode the value for display in list views and in forms, and base64 decode the value on save.
It's unlikely that you'll want such fields to actually have their value be visible and editable in kaffy. But all fields are visible and editable by default in kaffy, and we don't want a broken out-of-the-box experience for any field types. And, in case you do want to work with such fields, they should be visible in a legible / useful format, and they should be editable without the value getting corrupted on save.

Hi,
Thanks for your contribution!
Is this still required and works on the latest version?
Gavin.

@ghenry yes it's still needed, yes it works on the latest version


Add SQL Query relative to Fuzzy Search

Questions
Answers

Description?
Add SQL Query relative to Fuzzy Search. Configuration was introduced in <IP_ADDRESS> by @Lathanao in PrestaShop/PrestaShop#14428

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/PrestaShop#27823

How to test?
Cf. PrestaShop/PrestaShop#27823

Thanks @sLorenzini


Ability to add new Document Type

I can't find any guide about adding new Document Type (File > New > ...)
I placed new files (AS3 Class.fdt, AS3 Event.fdt, AS3 Static Class.fdt)
to
C:\Users%username%\AppData\Local\FlashDevelop\Templates
then restart FD
but no luck?
If I missing somethings? Please help!
Thanks!!!

Copy C:/Program Files/FlashDevelop/Settings/MainMenu.xml,
Select Tools > User Config Files... to open your user FD files,
Paste and edit MainMenu.xml under /Setting/MainMenu.xml.

Seem like a little bug here. The labels was not displayed

Thanks!

Sorry! It's my mistake. I replaced "Label.AS3ClassDocument" by "AS3 Class Document" and now it worked!
Thank so much!


cant set the placeholder of textview

When i am trying to set the placeholder text of textview from code . its showing error
cell.textView.placeholderText = "Test"
Error is Ambiguous use of 'placeholderText'

@Raviojha62 Please share your code so that we can better assist you
Sent with GitHawk

@Raviojha62 are you using another library which also has placeholderText property?

No[

](url)

i have created a custom tableview cell in which i have put a textview animatableTextView
Other property works except placeholder

@Raviojha62 interesting, I don't know why, can you please provide a sample project if possible. Or can you create a method liket `setPlaceholderText(text: string) { placeholderText = text }' to get around this issue?

BTW, It's okay to rename placeholderText to placeholder to align UIKit's naming convention? Or you have another consideration?

Completely ok, let's discuss this in another issue. Closing this now, let us know if you still have any issues.


pull request for e2e test at 02/06/2017 09:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Import-PSParquet returns an list in stead of objects

Describe the bug
Import-Parquet returns a List of PSObjects in stead of objects. That makes it difficult to iterate over the objects in the next step of a pipeline. The cmdlet has to be wrapped in $() in order to produce objects for the pipeline
To Reproduce
PS> Import-Parquet -FilePath $File| gm

   TypeName: System.Collections.Generic.List`1[[System.Management.Automation.PSObject, System.Management.Automation,
Version=<IP_ADDRESS>0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]

Expected behavior
PS> Import-Parquet -FilePath $File| gm

   TypeName: System.Management.Automation.PSCustomObject

Screenshots
If applicable, add screenshots to help explain your problem.
PowerShell info
PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.4.3
PSEdition                      Core
GitCommitId                    7.4.3
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Desktop (please complete the following information):

OS: Windows and Linux

Additional context
Add any other context about the problem here.

Fixed in 0.2.13


PhantomJS does not exit / terminate

When executing PhantomJS.exe on Windows it doesn't appear to exit.
This was noted by a few hundred of phantomjs.exe processes being listed in Windows Task Manager after automating execution of grunt for Twitter Bootstrap during development.
To reproduce this you can simply execute the following at the Windows Command Prompt:
phantomjs.exe --help
Note that this should exit and return to the command line, it does not - phantomjs.exe continues to run, Ctrl+C nor Ctrl+Break will close the process.
This is the same for other executions of PhantomJS as executed by Twitter Bootstrap's default grunt build process.
This was reproduced by downloading version 1.9.2 from here: https://phantomjs.googlecode.com/files/phantomjs-1.9.2-windows.zip
On Windows 7 Service Pack 1:
Microsoft Windows [Version 6.1.7601]

I have the same problem with v2.1.1 on OSX (El Capitan)

I have the same problem with v2.1.1 on OSX (El Capitan): phantomjs x.js just hangs.


Add a note explaining why kerberos is a dependency

It seemed like an unused dependency, and when I searched the repo I couldn't find any mention of what it was for. After googling it, I found out it was apparently required by mongodb for some systems?
I think making a note of that in the structured data tutorial would be helpful.

I don't think this needs a separate note (outside of perhaps package.json), and adding one would detract from the conciseness of the tutorial. (Also, specifying it in package.json means that no additional effort is required on the user's part - they have to type npm install anyway, whether this note is there or not.)
You're correct that Kerberos is sometimes required by MongoDB - more information about that [here].


Strange solutions

Good solution and strange code, as example:
toHTML: function () {
     var form = this;
     var iterator = arguments.length > 1 ? arguments[1] : arguments[0];
     var name = arguments.length > 1 ? arguments[0] : void 0;

it's maximal not IDE frendly, I dont have any idea why parameters not defined.

not cross html solutions, as example:
return '<' + safeTagName + attrsHTML + (isSelfClosing(safeTagName) ? ' />' : '>' + safeContent + '</' + safeTagName + '>');

html5 dont use slash at end to single tags

a) IDE-friendly is irrelevant; many people don't use an IDE at all, myself included.
b) the arguments are optional and variadic, and defining them would make the code less readable, and make the function's length be wrong
c) HTML5 does not require the closing slash, but it does allow it, and it's required in XHTML, so "always including the closing slash" is a better practice.
Generally speaking, offering an unsolicited code review of code you don't maintain (and perhaps don't fully understand) is considered rude and hostile. I'm going to close this for now, but if you have any issues to report or concrete PRs to file, please do so.


Invalid Loads value

Hi everyone. I am having an issue with GPU memory on a Windows machine when I try to run the code from the terminal of vscode. Tried directly copying the command, and also tried other values, seems nothing is working. What might be the problem?

Hi, could you provide the detailed procedures to reproduce this error? Thanks. From the screenshot, I guess you do not run the script in a shell environment.


docs(README.md): Update "Downloading a binary from GitHub Releases" section

add directory parameter for unzip operation.
Signed-off-by: Bora Oren<EMAIL_ADDRESS>

@boraoren Thank you for the PR! Looks great! :100:
/ok-to-test
/release-note-none

/retest


toastDrv/kmdf/filter/sideband: Ensure that queue event callbacks are run at PASSIVE_LEVEL

According to https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/wdfio/nc-wdfio-evt_wdf_io_queue_io_device_control, an EVT_WDF_IO_QUEUE_IO_DEVICE_CONTROL callback function may be called at any IRQL <= DISPATCH_LEVEL. It states especially:

The EvtIoDeviceControl callback function can be called at IRQL <= DISPATCH_LEVEL, unless the ExecutionLevel member of the device or driver's WDF_OBJECT_ATTRIBUTES structure is set to WdfExecutionLevelPassive.

Not doing that is among the three most common mistakes when developing KMDF drivers according to https://www.osr.com/nt-insider/2015-issue3/common-kmdf-errors/
However, the toastDrv/kmdf/filter/sideband example currently doesn't specify any ExecutionLevel.
Instead, it just silences the related warning.
This PR adds the initialization of a WDF_OBJECT_ATTRIBUTES structure with ExecutionLevel set to WdfExecutionLevelPassive, which is then passed to WdfIoQueueCreate.
If this change is fine, the same fix should be applied to other sample drivers as well.
If WdfExecutionLevelPassive is deterministically not needed or even makes things worse, I would like to hear an explanation and have all related documentation adjusted. Currenlty, it feels like not using WdfExecutionLevelPassive is a serious mistake.

Bump. Is anybody going to look at this?

Bump again


another api_key use

How can I change the api_key used without restarting the program?

solved this problem
added reset=True in OpenAI.configure


Netcheck does not query AAAA records for the derp server

When resolving the derp URL netcheck seems to query only A records, even on a machine which has a full public IPv6 address.

according to lookup_ip it should do a dual stack lookup, why do you think we do not resolve AAAA records?

likely this is the current behaviour:
https://docs.rs/trust-dns-resolver/latest/trust_dns_resolver/config/enum.LookupIpStrategy.html#variant.Ipv4thenIpv6

according to lookup_ip it should do a dual stack lookup, why do you think we do not resolve AAAA records?

Yes, I was also surprised it didn't.  But didn't dig deeper and created this issue instead.  You can tell when having debug logging as the resolver library logs the full query.

likely this is the current behaviour:
https://docs.rs/trust-dns-resolver/latest/trust_dns_resolver/config/enum.LookupIpStrategy.html#variant.Ipv4thenIpv6

Good find, rather possible.

Eh, good point about the lack of streaming API and this delaying the IPv4 result.  This could delay netcheck further for us.

ugh, that is bad, we should probably manually issue ipv4 and ipv6 queries then..

Fixed in #2026


Message "Sorry this display is unsupported" appearing

On my laptop I get a big green message saying "Sorry this display is unsupported" when I try and use your plugin. I think the problem is that I have two adapters, one is used to display the desktop and another one for high apps that need high level performance. The app is run on the high performance GPU.
I could fix this my changing my app to run on the low performance adapter but I would prefer not to do this. Is it possible to make it so you can run the app on the high performance GPU while grabbing the screen from the desktop one? Thanks

Sorry, uDD doesn't work with graphics hardwares which have on-chip/discrete GPUs like your laptop because the plugin uses Windows Desktop Duplication API (DDA) and this API doesn't allows it to run app on discrete GPU.

https://docs.microsoft.com/en-us/windows-hardware/drivers/display/using-cross-adapter-resources-in-a-hybrid-system
https://support.microsoft.com/en-us/help/3019314/error-generated-when-desktop-duplication-api-capable-application-is-ru

I heard from my some friends that there are some PCs which can disable the on-chip GPU completely and DDA works with the setting. But if not, we cannot run app with discrete GPU sadly.
I've also developed a window capture plugin, uWindowCapture (https://github.com/hecomi/uWindowCapture), and it also has a desktop-capture function. The capture itself is done asynchronously so the main thread doesn't get affected but its performance is slower than uDesktopDuplication, but you can run your app with high-performance GPU. Some people use this plugin as a fallback of uDesktopDuplication. Please think about using this depending on your use case.

How about capturing desktop using Desktop Duplication API in a standalone process, then use shared memory to load those data in the unity3d process?

How about capturing desktop using Desktop Duplication API in a standalone process, then use shared memory to load those data in the unity3d process?

I implemented this approach in a new lib: https://github.com/DiscreteTom/HyperDesktopDuplication


File can't be formatted while it's detected as GitHub Actions Workflow

Describe the bug
The file cannot be formatted while it's detected as a GitHub Actions Workflow.
To Reproduce
Steps to reproduce the behavior:
Install the Prettier extension: esbenp.prettier-vscode
Use these settings:
"**/.github/**/*.yml": "github-actions-workflow",
"[yaml]": {
  "editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[github-actions-workflow]": {
  "editor.defaultFormatter": "esbenp.prettier-vscode",
},

Try to format the file, it doesn't work.
Expected behavior
The file should be able to be formatted.
Screenshots
If applicable, add screenshots to help explain your problem.
Extension Version
v0.25.2
Additional context

@krokofant what was your solution to this?

@krokofant what was your solution to this?

I restarted VS Code after the extension update and it started to work 😆

For anyone else that ended up here trying to use the default formatter "editor.defaultFormatter":  "redhat.vscode-yaml",, that one just does not work. It worked flawlessly when I used "editor.defaultFormatter": "esbenp.prettier-vscode" (after installing the Prettier extension). It must be an issue with redhat.vscode-yaml" because there is a similar problem with ansible files

I'm running VS Code Insiders. Now despite restarting or setting prettier as the default formatter globally or for just github-actions-workflow it doesn't work. Right-clicking doesn't display a formatting action either.


Usage based metadata manager fixes

See individual commits for description.

12:25:29 Running test Reflection
12:25:29 Unhandled Exception: System.Exception: 'ReflectionTest+TestContainment+NeverUsedContainerType' could not be located
12:25:29    at ReflectionTest.GetTestType(String, String) + 0x11e

Unhandled Exception

Yeah, that's the damn multi-obj compilation mode that doesn't run scanner, yet runs optimizations. In this case we inlined a method, making the owning type no longer reflectable. I'm not even sure we should consider an optimized multi-obj build a supported scenario (we're trying to do runtime perf optimizations on a build mode that is designed for build throughput, not runtime perf).

I'm not even sure we should consider an optimized multi-obj build a supported scenario

Agree given how it is done today. We would need to run the scanner for it to make it behave in predictable way.


Add support for __gap

__gaps can be processed after the layouts are overlayed and aligned.
Edit: See 'Update' at the end for easier approach! 👇

How to do this:
Let's say that we have a contract X.
This is its storage layout:
x1
x2
__gap [10]

Gaps are often used when developing upgradeable smart contracts. See OpenZeppelin's documentation.
Let's say we update X to look like this:
x1
x2
x3
x4
__gap [8]

(assuming x3 and x4 occupy one slot each)
We added two new variables (x3 and x4), and correctly shrink the gap by two (10 => 8).
However, if we run Storage Delta, these variables will be marked!
We need to identify that these variables are in the storage space previously reserved by the gap, and de-escalate the findings.
I recommend taking a look at alignedOldVisualized and alignedOverlayedVisualized JSONs to think about it.
Keep in mind that there can be multiple __gaps in a contract (regex: /^__gap/).
Additionally, we need to make sure gaps have been shrunk by the right amount.
Update
There may be a straightforward way to solve this.
We won't be changing layout JSONs at all.
First, we determine 'gap spaces' from the old layout JSON.
For example, let's say there are gap spaces at positions 10-14 and 24-26.
Thats's 2 gap spaces of sizes 4 and 2. We record this for future reference.
The first rule is to de-escalate findings for variables in a gap space.
For example, 🏴 becomes 🌱, and so on.
This can be done by always asking, "Is the variable in a gap space?" before we write to the report, and de-escalating if so.
The second rule is that we print an empty line to the old report for each variable that has been de-escalated.
This way our reports will remain aligned.
The third rule is to make sure that the gap space is either filled completely, or contains a gap at the end, correctly shrunk based its current position and its old position.
Gaps can be of any type, so we should use size to perform the check.

Hey @ZeroEkkusu!
I made some changes in the script and got output something like this.
Old Contract:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract Counter {
    uint256 public a;
    uint256 public b;
    uint256[48] public __gap;
}

New Contract:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract Counter {
    uint256 public a;
    uint256 public b;
    uint256 public c;
    uint256 public d;
    uint256 public e;
    uint256 public f;
    uint256[44] public __gap;
}

Old Report:
    0          a                            uint256
    1          b                            uint256

New Report:
    0          a                            uint256
    1          b                            uint256
🔻  2          c                            uint256
🔻  3          d                            uint256
🔻  4          e                            uint256
🔻  5          f                            uint256
🏴  6          __gap                        uint256[44]

🔻 is a new symbol I added to show that this variable is filled in the storage that was reversed by the __gap . I still have some changes to do in which I will need your help but is this something you would like to see?

Maybe you can push to a branch on your fork so we can take a look?

Maybe you can push to a branch on your fork so we can take a look?

Yes I have pushed my changed to my forked repo. Here's a link to the repo:
https://github.com/kamuik16/storage-delta/tree/kamuik16/issue8

Thanks; let me get on this tomorrow moring.

Thanks; let me get on this tomorrow moring.

One thing I realized is that I have used an array for storing gaps but there can be only one __gap variable so ignore the array logic in the code because that can be changed for a single variable instance.

It may also be useful if we create a draft PR for easier reviewing. Also, I'll be able to push something if needed that way.

I have used an array for storing gaps but there can be only one __gap

There can be more than one __gap (and usually, there is!). The reason for that is because __gaps are usually private variables.
Let's say we have contracts A, B, and C.
Where A is B, C (meaning that inherits them).
Let's say that each contract has a private variable __gap.
That means that A will actually have 3 __gaps! You can look at the storage layout yourself if you want to confirm it.
So, your approach with an array was correct.

It may also be useful if we create a draft PR for easier reviewing. Also, I'll be able to push something if needed that way.

I have used an array for storing gaps but there can be only one __gap

There can be more than one __gap (and usually, there is!). The reason for that is because __gaps are usually private variables.
Let's say we have contracts A, B, and C. Where A is B, C (meaning that inherits them). Let's say that each contract has a private variable __gap. That means that A will actually have 3 __gaps! You can look at the storage layout yourself if you want to confirm it.
So, your approach with an array was correct.

So what do you think of my approach? Also any ideas about solving the errors I am facing?

i think we're on the right path:

instead of detecting gaps in createLayout, let's just add another step (add a new helper function that iterates over our 'old' JSON)
we'll probably need to change the line that uses variableFitInGap, but i need to debug it with some example first

yep, feel free to open a draft PR!

there's an edge case where a variable can start before a gap and 'spill' into it:
struct S {
    uint256
}

0   S
1   _gap

but if we change the struct to:
struct S {
    uint256
    bool
}

the layout now looks like this:
0   S
2   _gap

for this, i think we need to make another helper function onlyClashesWithGap that takes an item from the new layout, and the old layout.
it then iterates over the old layout to check if the item from the new layout only conflicts with the gap.
we'll figure out what to do with it later.

i think we're on the right path:

instead of detecting gaps in createLayout, let's just add another step (add a new helper function that iterates over our 'old' JSON)
we'll probably need to change the line that uses variableFitInGap, but i need to debug it with some example first

yep, feel free to open a draft PR!
there's an edge case where a variable can start before a gap and 'spill' into it:
struct S {
    uint256
}

0   S
1   _gap

but if we change the struct to:
struct S {
    uint256
    bool
}

the layout now looks like this:
0   S
2   _gap

for this, i think we need to make another helper function onlyClashesWithGap that takes an item from the new layout, and the old layout. it then iterates over the old layout to check if the item from the new layout only conflicts with the gap.
we'll figure out what to do with it later.

Opened a draft PR: https://github.com/0xPolygon/storage-delta/pull/16


Re-expose commands.

I was trying to pull in the recent upstream updates to a downstream repo that was invoking the CLI via cli.Sign().Exec(...) and this regressed in the cobra migration.  In a perfect world, we could pull in the CLI functionality without needing to go through cobra.Command to do it, but we're not there yet.  The alternative to cli.Sign().Exec(...) is cli.SignCmd(...), which takes 11 arguments and growing each release.  The alternative fo cli.Attest().Exec(...) is cli.AttestCmd(...) with 9 arguments.  etc, etc, etc...
What's more, the above functions are also colocated with their cobra wrappers so we also can't save on not vendoring cobra yet, so it's a mystery to me why we'd force folks to not use this interface.
Signed-off-by: Matt Moore<EMAIL_ADDRESS>Ticket Link
Fixes: https://github.com/sigstore/cosign/issues/880
Release Note
NONE

I also noticed that we were generating markdown docs without the piv-tool present, so this passes the needed tags to that command.

touching things to kick DCO 🤞


Toolbar text and icons are not tinted on new version

They are grey/black and they are pretty much invisible in many cases.

Is this only with the light the or also with the dark?

Found the issue: textColorPrimary/-Secondary weren't set for the light theme


[Bug]: View-PDF typed in Chinese,can not displayed.

Installation Method
Docker
The Problem
"I am using Docker mode. After opening 'View PDF' and loading a test.pdf file, I added some text and typed in Chinese. The Chinese characters are displayed correctly while typing, but after saving and downloading the PDF, all the Chinese characters cannot be displayed. However, the English letters and numbers are displayed normally. How can I resolve this issue?"

Version of Stirling-PDF
latesed
Last Working Version of Stirling-PDF
No response
Page Where the Problem Occurred
No response
Docker Configuration
No response
Relevant Log Output
No response
Additional Information
No response
Browsers Affected
No response
No Duplicate of the Issue

[X] I have verified that there are no existing issues raised related to my problem.

Which characters exactly? This showed correctly 儿勒屁艾 艾艾西艾 艾艾 西吉艾艾伊娜伊


SPGo: Publish local workspace command not work

Hello @ sg-chrishasz!
Great API!
But, I'm trying to use the SPGo command: Publish local workspace to no avail. Or maybe you're not fully understanding your concept.
In my view this command would publish all files with check out inside my workspace, correct?

Hello @paulinhps -
Thank you for using SPGo! You are correct, the >SPGo : Publish Local Workspace command will publish all files that you have checked out from the server, but that is not all. This command has two features:

to push all local files under the local src folder to their relative path on the server, if they do not yet exist on the server.
to publish all checked out files in your local workspace (this is your usecase)

Can you provide more details on the error you are seeing? It may help to also copy any text from the output tab in Visual Studio Code (scoped to SPGo in the dropdown).
If you can provide that data, I can help resolve this issue.
Thanks!

Chris

Hello @ sg-chrishasz
Thanks for the reply! This is the problem, you do not have a message. The "Publishing workspace" loading message runs and runs for a while and then stops, but the files are not pushed or published.
File a file is published correctly using Publish Major Version of current file
SPGo has log files?

@sg-chrishasz, today this function performed correctly...
Maybe because I rebooted my pc.
Thanks you


[stable/influxdb] Add fullnameOverride

Similar to other charts, this allows configurable name
overrides so 'cleaner' resource names can be achieved,
which are independent from the wanted release names.

This is a must have if you want to integrate influxdb with
other charts, where a resource name can't be templated
and has to be fixed in the values.yaml, and you have to
deploy that in multiple instances on the same k8s cluster.
For example if you have an integration chart and
the grafana data source URI points to a fixed influxdb
service name, then without this patch,
it can't be deployed in multiple instances,
since the service name depends on the release name,
which has to be unique.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign @unguiculus

/ok-to-test


repo sync

This is an automated pull request to sync changes between the public and private repos.
:robot: This pull request should be merged (not squashed) to preserve continuity across repos, so please let a bot do the merging!

I'm in vacation do what you have to do but later you will come to eat in
then we will have a talk you guys make this beast now will be concecuences
I see everything what is going with the cartels I'm going to have to fix
this country now you going through the process of this country and you will
need the best thing you can do to help them to make a difference if they
don't want you to get the same thing with them good day I see you soon now
I have some thing to do in my own life because I'm not going back into your
relationship with the other ones you have no clue how much this is going
for me and I think it's worth the risk for the same thing as you do I will
take care thing with my own hands like I did before you use me I know
everything you have to know about this particular situation with my life is
my job to get the best of me I want you to get your money back into your
relationship with the rest of the reaches life never change your kingdom in
the world of the same way you do not going back into your relationship with
your business to make your life for me I know what I did wrong I will fixed
my self you keep your country me where I was born this country is fake keep
it me I going with my family and friends who don't have any other day to
get the best thing talk about slavery this is the most corrupt country
reaches only cowards hide in the world has been doing a great deal for your
own life good luck I born with nothing I will take nothing money just make
people lazy and to drugs I learn my lesson kids don't have to go to
School only reaches make it to the top but I proved the I take care
business true the end same for United kingdom in all nations all the money
of the world they don't know what to do with it you play good with my life
but I didn't all the way to the end there's justice one day will come back
into your life 6AM you have no clue what you are going to say I know you
have a good day
On Thu, Jun 10, 2021, 6:01 PM Octomerger Bot @.***>
wrote:

This is an automated pull request to sync changes between the public and
private repos.
🤖 This pull request should be merged (not squashed) to preserve
continuity across repos, so please let a bot do the merging!
You can view, comment on, or merge this pull request online at:
https://github.com/github/docs/pull/7279
Commit Summary

Update OpenAPI Descriptions (#19759)
Merge branch 'main' into repo-sync

File Changes

M lib/rest/static/dereferenced/api.github.com.deref.json
https://github.com/github/docs/pull/7279/files#diff-ebc40eabfb5ee795ac9ff80987851365a4b5d9acf4df994566ec4b5c7fa47100
(12)
M lib/rest/static/dereferenced/ghes-2.18.deref.json
https://github.com/github/docs/pull/7279/files#diff-8cb3b0faf4cd7028104038946954a16963c7b2669ff0deec596aa7cc77c89dbc
(16)
M lib/rest/static/dereferenced/ghes-2.19.deref.json
https://github.com/github/docs/pull/7279/files#diff-8213af14eb1020af04ed9b72a3cccce09e8621ebd48f5f9539d5e17102940258
(16)
M lib/rest/static/dereferenced/ghes-2.20.deref.json
https://github.com/github/docs/pull/7279/files#diff-4f925f0f5cf0f4b4ed5c045115ba97ac939d29a7b5d59c143a1570bbfc0a0e39
(16)
M lib/rest/static/dereferenced/ghes-2.21.deref.json
https://github.com/github/docs/pull/7279/files#diff-c7a6cdbec4968ce374849cc043bd50710908f24ee4b313ed14d229873b536ce6
(12)
M lib/rest/static/dereferenced/ghes-2.22.deref.json
https://github.com/github/docs/pull/7279/files#diff-1bb215164fb3cfb4f21784122a45080ca0e8ff2831c0970827289b4dad4e1458
(12)
M lib/rest/static/dereferenced/ghes-3.0.deref.json
https://github.com/github/docs/pull/7279/files#diff-c89664bb1817cee84b1fa2af5678576208e6c964ee017391a3cc045bd37815b8
(12)
M lib/rest/static/dereferenced/ghes-3.1.deref.json
https://github.com/github/docs/pull/7279/files#diff-105a642308f4b28ada54813b0b2e1d72b61c9819518f75d95eb6d14947964933
(12)
M lib/rest/static/dereferenced/github.ae.deref.json
https://github.com/github/docs/pull/7279/files#diff-2ce10c91a36aa225daad4ee7971ef45badfac4ebeb4c11de1096f74be23b537b
(12)

Patch Links:

https://github.com/github/docs/pull/7279.patch
https://github.com/github/docs/pull/7279.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/7279, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUM2YKKLXIBJD7J55AE5DBLTSFG4FANCNFSM46PTGPZA
.


Fix typo

@aharpervc : Thanks for your contribution! The author, @MikeRayMSFT, has been notified to review your proposed change.

@aharpervc thank you for the help.  fyi @MikeRayMSFT


refactor: add factory methods for consumers/producers by annotations

Description
Add some factory methods to create the consumer and producers and to hide the specific details.
Checklist

[x] My code follows the style guidelines of the project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation

:tada: This PR is included in version 2.9.1 :tada:
The release is available on:

2.9.1
GitHub release

Your semantic-release bot :package::rocket:


feat: add backlight support for rpi4

This commit adds support for controlling the backlight on the official touch display for the Raspberry Pi 4. Using this overlay, the brightness on the display can be controlled using the following snippet:
echo "55" > /sys/class/backlight/rpi_backlight/brightness

Things done

[x] Tested the changes in your own NixOS Configuration
[x] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

Is anyone testing these on mainline kernels? Because those don't have rpi_backlight at all.

@K900 good catch, I only tested with the RPi4 kernel. I'm not even sure the driver is required. I'll try to remove it and test again.

Is anyone testing these on mainline kernels? Because those don't have rpi_backlight at all.

No, I don't have all this hardware for testing. That's why we ask contributor to test.


Make the banner component  for V2

Add the HTML and css for the banner
Update change log

This is part of the ticket OST-134
Once this has been merged we will need to create a new release (2.10.0) and then update all the supplier-frontend app.
For the stylings and JavaScript, I got them from govuk-frontend/notification-banner and removed the parts we didn't need (just some CSS)

Looks reasonable. I assume you've checked that this looks as expected? If so, ship it!

Sorry, I should have included a screenshot:


not equal selector

I am looking for selector not equal here, just found _gte and _lte, all i want to select all other records beside item with id value is 1

Added in v0.8.3 :) just append _ne.
Thank you for the feedback.

@typicode Is this _ne customizable? And is it part of an API style guide?


[18.09 backport] Fix: plugin-tests discarding current environment

Thought I'd backport this one, as it caused some head-scratching when working on https://github.com/moby/moby/pull/38404#issuecomment-453307983
backport of https://github.com/moby/moby/pull/38543 for 18.09. Cherry-pick was clean; no conflicts.
By default, exec uses the environment of the current process, however,
if exec.Env is not nil, the environment is discarded:
https://github.com/golang/go/blob/e73f4894949c4ced611881329ff8f37805152585/src/os/exec/exec.go#L57-L60

If Env is nil, the new process uses the current process's environment.

When adding a new environment variable, prepend the current environment,
to make sure it is not discarded.

ping @kolyshkin @andrewhsu ptal

LGTM, thanks!


Log automatic topic compaction failures

Describe the bug
If a namespace is set up with a compaction-threshold, compaction should be triggered automatically.
I configured a namespace with compaction, produced messages, and in the main log file, I could see that 'phase one' of compaction was started. But there was no sign of phase two, and no WARN or ERROR message. I tried manual compaction with
bin/pulsar compact-topic --topic persistent://tenant/namespace/topic
and then there was reported an error (TimeoutException)
Expected behavior
If automatic triggered compaction fails, it should be logged in the broker log file.
Discussion
org.apache.pulsar.broker.service.persistent.PersistentTopic#triggerCompaction() starts compaction, but does not report any failures. For example, one could add logging with
public synchronized void triggerCompaction()
            throws PulsarServerException, AlreadyRunningException {
        if (currentCompaction.isDone()) {
            currentCompaction = brokerService.pulsar().getCompactor().compact(topic);
            currentCompaction.whenComplete((ledger, error) -> {
                if (error != null) { log.error( ...
                ...
        } else {
            throw new AlreadyRunningException("Compaction already in progress");
        }
    }

Additional context
Pulsar 2.5.0 release

This might be related to hasMessageAvailable semantics in ConsumerImpl. No logs of phase 2 may denote the compaction is hanging forever.

Yes, I am quite certain that compaction failed in TwoPhaseCompactor.phaseOneLoop as indicated here
CompletableFuture future = reader.readNextAsync();
scheduleTimeout(future);
The readNextAsync() did not complete in 10 seconds, and the whole compaction was aborted (this could also be reported better, but that is another issue i guess).

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.


Pytorch refactor 2

Recreating pytorch refactor branch to reduce confusion.

I don't think this is ever going to get merged in -- this refactor is too large ...
Let's open a new branch and when the time comes, we'll switch over to that branch exclusively.


feat(lamp): add rhythms cicle

Owner

[x] Nickname(Tuya): Sophia
[x] Intra-group review（组内审阅人员）：若叶，萧瑟

Description
add rhythms circle
Package

[x] tuya-panel-lamp-sdk

Type of change
Please select the relevant option.

[x] New feature (non-breaking change which adds functionality)

Self CheckList
Please check all options.

[x] Intra-group review
[x] ESLint lint
[x] Example Run
[x] Jest Run
[x] No Grammer Error
[x] No Spell Error
[x] No Merge Conflict

Codecov Report

Merging #160 (aad154e) into main (276aca0) will decrease coverage by 0.22%.
The diff coverage is 40.52%.

:exclamation: Current head aad154e differs from pull request most recent head e82bcc5. Consider uploading reports for the commit e82bcc5 to get more accurate results

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   62.66%   62.43%   -0.23%
==========================================
  Files         292      296       +4
  Lines       10962    11300     +338
  Branches     2505     2577      +72
==========================================
+ Hits         6869     7055     +186
- Misses       4076     4228     +152
  Partials       17       17

Impacted Files
Coverage Δ

...l-lamp-sdk/src/components/rhythms-circle/index.tsx
40.52% <40.52%> (ø)

...dk/src/components/time/countdown-subpage/index.tsx
66.66% <0.00%> (ø)

...onents/time/countdown-subpage/timePicker/index.tsx
62.29% <0.00%> (ø)

.../components/time/countdown-subpage/clock/index.tsx
94.87% <0.00%> (ø)

...k/src/components/gradient/conical-gradient/Ios.tsx
100.00% <0.00%> (+50.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276aca0...e82bcc5. Read the comment docs.

LGTM


TFLite Shared Library build error on Raspberry Pi 4 (native build with Bazel). Trying to build with XNNPACK enabled

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Raspbian Buster
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: Raspberry Pi 4
TensorFlow installed from (source or binary): source (attempt to compile tensorflow lite libraries)
TensorFlow version: 2.3
Python version: 3.7.3
Installed using virtualenv? pip? conda?: --
Bazel version (if compiling from source): Bazel 3.4.1
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 8.3.0
GPU model and memory: not relevant

Describe the problem
Trying to compile the shared library for Raspberry Pi 4 using Bazel to enable XNNPACK doesn't work (doing a native build on the Raspberry Pi 4). I have used the instructions from https://blog.tensorflow.org/2020/07/accelerating-tensorflow-lite-xnnpack-integration.html to enable XNNPACK and https://www.tensorflow.org/lite/guide/build_rpi as instructed.
Provide the exact sequence of commands / steps that you executed before running into the problem
bazel build --define tflite_with_xnnpack=true -c opt //tensorflow/lite/c:libtensorflowlite_c.so
I have removed the cross compile option mentioned in https://www.tensorflow.org/lite/guide/build_rpi  which is https://www.tensorflow.org/lite/guide/build_rpi and added --define tflite_with_xnnpack=true to enable xnnpack.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
ERROR: /home/lahiru/workfolder/bazel_patch_test/tensorflow/tensorflow/lite/c/BUILD:22:24: Linking of rule '//tensorflow/lite/c:libtensorflowlite_c.so' failed (Exit 1)
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunKernel<(ruy::Path)4, signed char, signed char, int, ruy::MulParams<int, int> >(ruy::Tuning,
ruy::SidePair<ruy::PEMat> const&, void*, ruy::SidePair<int> const&, ruy::SidePair<int> const&, ruy::EMat*): error: undefined reference to 'ruy::Kernel8bitNeonOutOfOrder(ruy::KernelParams8bit<4, 2> const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunKernel<(ruy::Path)4, signed char, signed char, int, ruy::MulParams<int, int> >(ruy::Tuning,
ruy::SidePair<ruy::PEMat> const&, void*, ruy::SidePair<int> const&, ruy::SidePair<int> const&, ruy::EMat*): error: undefined reference to 'ruy::Kernel8bitNeonOutOfOrder1Col(ruy::KernelParams8bit<4, 2> const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 2>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder2Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 2>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder2Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 2>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder2Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 2>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder2Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 4>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder4Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 4>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder4Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 4>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder4Cols(ruy::PackParams8bit const&)'
bazel-out/arm-opt/bin/tensorflow/lite/kernels/internal/_objs/neon_tensor_utils/neon_tensor_utils.pic.o:neon_tensor_utils.cc:function void ruy::RunPack<(ruy::Path)4, ruy::FixedKernelLayout<(ruy::Order)0, 16, 4>, signed char, signed char>(r
uy::Tuning, ruy::EMat const&, ruy::PEMat*, int, int): error: undefined reference to 'ruy::Pack8bitNeonOutOfOrder4Cols(ruy::PackParams8bit const&)'
collect2: error: ld returned 1 exit status
Target //tensorflow/lite/c:libtensorflowlite_c.so failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1574.126s, Critical Path: 260.79s
INFO: 1088 processes: 1088 local.
FAILED: Build did NOT complete successfully

Current build system assumes that Bazel is running under x86_64. So you'd better build it on x86_64 machine with "--config=elinux_armhf"

We don't use bazel for ARM native build. For the native build, we can use Makefile but it doesn't build XNNPACK.
If you want to build ARM binary with XNNPACK enabled, cross compiling with bazel is the way to go.
Actually you can also use CMake on ARM devices.
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/tools/cmake
But it wasn't tested with ARM devices.


Fallout Equestria PNP, fixes and updates

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[x] This sheet has been made on behalf of, or by, the game's publisher.
[x] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ x This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.

Hey @Sycofear13
All looks good here - one small request:  Renaming your attr_endurence attributes to attr_endurance will cause any existing sheets to lose the data that's currently assigned to those attributes, and they'd have to re-enter these values.  If you could add a quick sheet worker on sheet open to transfer old values to the new name, that'd keep every sheet's data intact.
If you have any questions on this, let me know and I can point you to some examples of this update functionality in other sheets.
Thanks!

Hey, just went through and edited the sheet to not mess with the attributes. Going to wait until I better understand how they work before I try to implement them.

Hey @Sycofear13
All good!
If you'd like, this commit is a pretty good example of what it'd take to carry the values from old attribute names to new.
There are a few different ways to accomplish this.  The example sheet checks some of the old names to see if they have values, uses that to decide whether it should run the update or not, and clears those old name attributes if so.  You can instead implement a versioning system, where you track the sheet's version in a hidden attribute, then check the version number whenever the sheet's opened, updating it and running any associated code.
I'm merging this PR for now, but if you elect to make this change in the future, feel free to reach out to me or post on the Roll20 forums with any questions!
Thanks!


wip: feat: implementing trickle ice

wip

The CI errors look specific to your branch, I've re-run the tests on the main branch and I'm not getting errors. see https://github.com/jlaine/aioice/actions/runs/2205560373
I have to admit I don't see where this code is going. I was expecting something like gather() becoming an async iterator. Also the "hard" changes are going to concern candidate pairing: you can no longer count on having all your local candidates before you start adding remote candidates.

The CI errors look specific to your branch, I've re-run the tests on the main branch and I'm not getting errors. see https://github.com/jlaine/aioice/actions/runs/2205560373
Sorry, I made something wrong in my local environment.

I have to admit I don't see where this code is going. I was expecting something like gather() becoming an async iterator. Also the "hard" changes are going to concern candidate pairing: you can no longer count on having all your local candidates before you start adding remote candidates.
I thought at that moment refactor the function get_component_candidates and then find a way to use the gather for each element in local candidates step can be called concurrently and provide an intermediate local candidates list ASAP to  send offer . Do you agree or you see another point?

I still think you probably want an async iterator at the end of the day, so that we can yield the candidates as we collect them. That way API users can do:
async for candidate in conn.gather():
    do_something(candidate)

@rprata @jlaine Just landed on this PR looking for Trickle support but last activity here was almost an year ago, which makes me sad :(.   Any hope on getting this PR in anytime soon guys.   Thank you!!!

@rprata @jlaine Just landed on this PR looking for Trickle support but last activity here was almost an year ago, which makes me sad :(. Any hope on getting this PR in anytime soon guys. Thank you!!!

Just to clarify, this PR doesn't implement trickle ICE, as it stands it just does some refactoring.

@rprata @jlaine Just landed on this PR looking for Trickle support but last activity here was almost an year ago, which makes me sad :(. Any hope on getting this PR in anytime soon guys. Thank you!!!

Just to clarify, this PR doesn't implement trickle ICE, as it stands it just does some refactoring.

Sorry @jlaine, but I can't continue this work now. Feel free to this ti close the PR.


Ensure that captured messages are fingerprinted based on the message

Feature request: Captured messages should have the option to be fingerprinted based on the PSR-3 (https://www.php-fig.org/psr/psr-3/) message.
Hi. Maybe someone can point me in the right direction, but the edited code I have here is an example of an implementation of the feature request, which solves my issue.
We enjoy being able to log messages (not exceptions, necessarily) to sentry. However, since every monolog record is unique (based on the time and context e.g. https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/ErrorLogHandler.php#L67), sentry only reports 1 event per log message. Needless to say, it's pretty hard to accurately gauge the frequency of each log statement. Fingerprinting seems like the exact feature to avoid this issue, but I don't see an easy way to do that.
What are people's thoughts on adding a feature like this?

Ugh, I forgot I manually changed this line for the reference value to work. https://github.com/getsentry/sentry-php/blob/master/src/State/Hub.php#L98
        $scope = $this->getScope();

        $callback($scope);

I'll work on a better solution that doesn't involve changes to sentry-php, brb heh.


Frames get dropped with  low bitrate

I am trying to encode a video of 2281 frames (1080p, 30fps) into two spatial layers. The bitrate of the base layer is 1mbps, and 4.5mbps for the enhancement layer. Yet, I noticed huge drop in number of frames (2281  --> 701). Then, when I increased the bitrate for base, and enhancement to 5mbps, 9.5 mbps ; respectively. The number of encoded frames increased ( 701 ->  1726). But still there are a lot of frames got dropped in compare to the original video (2281).
./h264enc  -org 1080p_video.yuv -utype 0 -numl 2 -numtl 1 -frin 30 -frout 0 30 -frout 1 30 -sw 1920 -sh 1080 -dw 0 1280 -dh 0 720 -dw 1 1920 -dh 1 1080 -minqp 0 -maxqp 51 -ltarb 0 1000k -lmaxb 0 1000k -ltarb 1 4500k -lmaxb 1 4500k -tarb 5500k -maxbrTotal 5500k -lqp 0 24 -lqp 1 24 -iper 30 -rc 1 -bf layer.h264 -mfile 1
Width:		1920
Height:		1080
Frames:		701
encode time:	25.238339 sec
FPS:		27.775203 fps

./h264enc  -org 1080p_video.yuv -utype 0 -numl 2 -numtl 1 -frin 30 -frout 0 30 -frout 1 30 -sw 1920 -sh 1080 -dw 0 1280 -dh 0 720 -dw 1 1920 -dh 1 1080 -minqp 0 -maxqp 51 -ltarb 0 5000k -lmaxb 0 5000k -ltarb 1 9500k -lmaxb 1 9500k -tarb 14500k -maxbrTotal 14500k -lqp 0 24 -lqp 1 24 -iper 30 -rc 1 -bf L.h264 -mfile 1
Width:		1920
Height:		1080
Frames:		1726
encode time:	50.162285 sec
FPS:		34.408321 fps

After digging into the source code for a bit, I found that plenty of frames are of type "videoFrameTypeSkip". Any reason why this is happening ?

Could you please try "5000000" instead of "5000k", and all similar changes?


Need option to disable 'chunk-manifest-webpack-plugin'

chunk-manifest-webpack-plugin doesn't provide enough information(only chunks).
I need to use webpack-manifest-plugin.
Since<EMAIL_ADDRESS>const ManifestPlugin = require ( 'webpack-manifest-plugin' );
const InlineChunkManifestHtmlWebpackPlugin = require ( 'inline-chunk-manifest-html-webpack-plugin' );

...
plugins: [
    new ManifestPlugin ( { publicPath } ),
    new InlineChunkManifestHtmlWebpackPlugin ( { manifestVariable: 'manifest' } ),
  ]
...

Using like above  makes System.import('filename') fail.
Maybe providing necessary plugin from a user like before is better idea?

@Batbold-Gansukh: Thank you for reaching out. For now, use the version 0.2.1 and I'll compare webpack-manifest-plugin with chunk-manifest-webpack-plugin.

Can you explain the scenario where you need to use webpack-manifest-plugin, what is the output you need?
I myself am using inline-chunk-manifest-html-webpack-plugin here https://github.com/jouni-kantola/webpack-output-by-build-type, and it works fine with dynamic imports.

However, I hadn't really thought of the idea before to consider any plugin generating a chunk manifest (manifest.json) as a dependency.
I'll update the inline-chunk-manifest-html-webpack-plugin to override the default behaviour with something like this:
manifestPlugins: [ new ManifestPlugin(/*args*/) ]

Thanks for response.
I'm using inline-chunk-manifest-html-webpack-plugin to develop React and Typescript app.
Only small part of my app uses big jquery library and I'm loading this library's dependencies manually from code not by dynamic import. Also I want to process this library's assets through webpack. To do that I'm using webpack-manifest-plugin.
Using webpack-manifest-plugin with<EMAIL_ADDRESS>does output manifest.json containing all assets. But breaks dynamic imports in other parts of the app.
I'm currently using the 1.0.0 by commenting like below:
this.plugins = [
      //new ChunkManifestPlugin({
      //  filename: this.manifestFilename,
      //  manifestVariable: this.manifestVariable
      //})
    ];

That is why I thinking maybe a user providing a plugin that generates manifest.json is better idea.

If you update your package.json to reference:
"inline-chunk-manifest-html-webpack-plugin": "https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin.git#f3a0379c769697b4476128a150aeb6b4ab30244a"
Then update your webpack.config.js to this:
new InlineChunkManifestHtmlWebpackPlugin({
    manifestPlugins: [
      new WebpackManifestPlugin()
    ],
    manifestVariable: "manifest"
  }),
// example below, match how your html-webpack-config looks
  new HtmlWebpackPlugin({
    template: "./tmpl/index.ejs"
  })

As a more bruteforce version you can use:
      new WebpackManifestPlugin(),
new InlineChunkManifestHtmlWebpackPlugin({
    manifestVariable: "manifest",
    extractManifest: false
  }),
  // example below, match how your html-webpack-config looks
  new HtmlWebpackPlugin({
    template: "./tmpl/index.ejs"
  })

Both should work as you expect. Please get back to me and I'll:

merge the PR
close this issue
publish a v1.1.0 to NPM

You have the instructions in the readme here (in the bottom):
https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin/blob/56cb5a0efc89443f4a8fe0be197c6a365a9df55d/README.md

Thank you for your time.
Both version working without problem. 👍

Thanks for reaching out. I'm glad the plugin just got even more versatile 👍
I'll make a note here when I've pushed a new release.

v1.1.0 now published to npm.


aspect / spring integration

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@zoeself deregister

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.


Change for compatibility with 0.8.5

Hello,
i was having a look at modulecompatility for 0.8.5 and it seems it work by replacing (in blindroll.js / line 52-56)
    if(msg.flags){
      if(skillsToBlind.includes(msg.flags.dnd5e?.roll?.skillId)) { makeRollBlind = true; }
      if(game.settings.get("blind-roll-skills", "hideDeathSaves") && (msg.flags.dnd5e?.roll?.type === "death")) { makeRollBlind = true; }
      if(game.settings.get("blind-roll-skills", "hideInitiative") && msg.flags['core.initiativeRoll']) { makeRollBlind = true; }
    }

with
    if(msg.data.flags){
      if(skillsToBlind.includes(msg.data.flags.dnd5e?.roll?.skillId)) { makeRollBlind = true; }
      if(game.settings.get("blind-roll-skills", "hideDeathSaves") && (msg.data.flags.dnd5e?.roll?.type === "death")) { makeRollBlind = true; }
      if(game.settings.get("blind-roll-skills", "hideInitiative") && msg.data.flags['core.initiativeRoll']) { makeRollBlind = true; }
    }

Hope that helps if you did not look into it yet.

Hey, thanks for this. Updating is lagging behind a bit, as I'm waiting for some of the supported roll modules (like Better Rolls) to get themselves stabilized on the new version, but I'll try to be on top of it shortly.

Came here for some reason! Love the module look forward to the release :)

Currently I'm waiting on an issue with how Core displays the content of blind/whisper/private rolls to get this finished up. There was a change made way back in 0.8.1 that messed things up a little bit and it didn't get discovered until like last week.
It seems like a fix for that will be out next week sometime? I'm keeping an eye on it for sure. https://gitlab.com/foundrynet/foundryvtt/-/issues/5302

Fixed in 0.7.1.


lineTo does nothing without moveTo

If you just call "lineTo" you will get no line, but if you first call "moveTo" the line will appear:
e.g:
this does not work:
var line = new createjs.Graphics();
line.beginStroke( '#FF00FF' );
line.lineTo( 300, 0 );

This however does work:
var line = new createjs.Graphics();
line.beginStroke( '#FF00FF' );
line.moveTo( 0, 0 );
line.lineTo( 300, 0 );

I would expect it to have a default position of 0, 0 and then draw from there.

Hi there could you consider updating your API docs at least to reflect this just spent an unreasonable amount of time scratching my head over this issue of my lines not drawing.
Another thing I'd like to highlight is the moveTo must be after the beginStroke in order for this to work again seemingly counter intuitive.

Updated lineTo docs. This issue will also manifest in other places (such as curveTo), but I think the one doc comment should suffice. Thanks guys!

@lannymcnie thanks!


Fix The Emperor's Birthday of 2018

Looking at the government page, the Emperor 's Birthday of 2018 is still December 23
the same as 2017.
see: http://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html

Probably, era name will change at the beginning of 2019.
http://mainichi.jp/articles/20170111/k00/00m/010/101000c

Thanks for your PR.
But it is under consideration now.
Let's change the code if it becomes the official law.

Thank you for your reply.

Let's change the code if it becomes the official law.
I agree with you.

+1
This PR should be merged ASAP. Holidays in 2018 have been officially defined on Feb 2017 by Japanese law.

@matsubo I think that It is under consideration yet in japanese law.
http://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html
If you know tell me law information by url.

@komagata
2017/11/13 現在の以下の内閣府のリンクの記述からすると、2018は12/23 日が天皇誕生日といういうことで決まっていると考えてよいのでこの PR がマージされるのが適切だとおもいます。
http://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html

@nyaago Thank you for you infroamtion.


fix: run npm audit fix

npm audit fix

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Enhancement: don't ship help by default

When you use CLI in CI/CD or Azure Functions, you don't need help. Because we include it in the package, it unnecessarily bloats the package and slows down the installation time.
We should consider excluding help files from the package and download them either on first request or have a command to install help files explicitly.

I'd appreciate your opinion @pnp/cli-for-microsoft-365-maintainers

Interesting! Functionally speaking I’d want it installed when I run —help for the first time. That’s the route that seems to align closest with existing functionality…

Would be a great enhancement for CI/CD and Azure Functions. But a less better experience for our users, they'll have to wait few seconds before the help page will be displayed. I remember we had a discussion about tracking the shell in the telemetry. We were unsure because it would add a delay of a few milliseconds. I'm afraid that this change will have a bigger impact.
Do we know how much benefit we get when we exclude the pages? If it's like 5-10 seconds, I don't think it's worth it to do the change. I don't think 5-10 seconds would make a difference for a CI/CD pipeline since it's a background process anyway.
If we proceed with this, my votes goes to downloading all pages when we need to display one of them.

That is interesting thought. Like the idea of minimizing the package which speeds installation.
Adding to that, it is also would make sense for a user who don't depend on the shell help but rather use the docs from the web.
For installing it, I liked what Martin suggested to install it when you run --help for the first time. I think installation also should be triggered when there is error in the execution and showHelpOnFailure is true by default.

I like it 👍.
I also agree we should install all needed for help when you run it for the first time.
When some command fails we could display a prompt if help should be downloaded and installed, otherwise the user could be redirected to the docs in the browser (this is done in a separate issue, not sure what is the latest status on this one 😅)

Do we know how much benefit we get when we exclude the pages? If it's like 5-10 seconds, I don't think it's worth it to do the change. I don't think 5-10 seconds would make a difference for a CI/CD pipeline since it's a background process anyway.

I'm with @milanholemans on this, whilst I think trimming the package down is a good step, it's hard to understand the impact of this change without comparing the install times of CLI with and without help files.

Thanks for chiming in, folks. The install time will depend on the resources an agent has assigned (memory, CPU, disk, etc), so I don't think we can get a definitive answer here. We could start by comparing different setups and see how much difference it would make.

If it's like 5-10 seconds, I don't think it's worth it to do the change. I don't think 5-10 seconds would make a difference for a CI/CD pipeline since it's a background process anyway.

If the whole pipe takes 20s of which 10s is installing the CLI then we would cut the pipe execution time by half. I'd call that a win 😄

But a less better experience for our users, they'll have to wait few seconds before the help page will be displayed. I remember we had a discussion about tracking the shell in the telemetry. We were unsure because it would add a delay of a few milliseconds. I'm afraid that this change will have a bigger impact.

I think scenario is a bit different. Tracking shell in telemetry happens on every command and is not something the user is asking for, which is why it needs to add as little overhead as possible. Requesting help is a conscious action (unless you've got showHelpOnFailure set to true and used invalid options with the command).
Interestingly, I just realized that we don't track the use of help so we can't say with certainty how often people invoke help from terminal vs. looking up information on the web.
Shall we start with gathering information about how long installing the CLI takes on different CI agents to see if the change is worth the effort?

I've just created a local package with and without docs, based on what we've got in main right now. Oddly, the package with docs is smaller 🤯
With docs:
npm notice package size:  875.3 kB
npm notice unpacked size: 6.4 MB
npm notice total files:   1733

Without docs:
npm notice package size:  1.5 MB
npm notice unpacked size: 5.9 MB
npm notice total files:   1139

that's something I would not expect 😉

I've done a few runs on GitHub Actions and it seems like there's no conclusive difference: https://github.com/waldekmastykarz/fuzzy-octo-meme/actions. Do you have a way to test the difference on Azure DevOps?
I don't know if we should also take into account the installation on Azure Functions: it's a one time process and the difference between with and without docs is extra 600kB unpacked.

don't know if we should also take into account the installation on Azure Functions: it's a one time process and the difference between with and without docs is extra 600kB unpacked.

Agreed. Its a one time process. Installing on Azure Functions takes a very long time, probably due to the way Azure Functions handle file operations.
I'm not sure we'd reach a real benefit here anyhow, and anyway I think the actual npm install should be run once locally before deploying the function or once from Kudu. As I'm writing about in my blog posts on this.

For GitHub I created two files with a matrix setup testing on macOS, Windows and Linux. Across all OSes I haven't seen a noticeable difference between a full and doc-less release.

I'm not sure we'd reach a real benefit here anyhow, and anyway I think the actual npm install should be run once locally before deploying the function or once from Kudu. As I'm writing about in my blog posts on this.

How would you deploy your function in a real-life setup? I doubt it would be from your local machine, right?

IIRC node consumption based Azure Functions have a really bad warmup time and npm install is incredibly slow.
Not sure if this is different if you use an app service as you can allocate more resources.


esp_ping - Document that timeout units are in milliseconds

Remove 1000 multiplier from esp_ping_set_target() parameters that define time

Thanks for bringing this to our attention, @chmorgan .
I agree that milliseconds seems to make more sense here. The dilemma is whether to document the current units (seconds) and leave the behaviour unchanged, or change the behaviour and risk breaking existing code. I've asked my colleague who originally wrote this API for their opinion on this.

Thanks for taking a look st it.
Seconds isn’t a very good unit for a network operation like this. I’m
guessing there are few users of this code. The example I found on the forum
looked like it was assuming milliseconds so perhaps they didn’t test it.
On Tue, Feb 20, 2018 at 10:34 PM Angus Gratton<EMAIL_ADDRESS>wrote:

Thanks for bringing this to our attention, @chmorgan
https://github.com/chmorgan .
I agree that milliseconds seems to make more sense here. The dilemma is
whether to document the current units (seconds) and leave the behaviour
unchanged, or change the behaviour and risk breaking existing code. I've
asked my colleague who originally wrote this API for their opinion on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/pull/1638#issuecomment-367203186,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJ-ALkwdWPdBVhzrfORLNxSUrIOenmQks5tW47AgaJpZM4SJ6Hz
.

LGTM

Thanks @liuzfesp . I've pushed this into our internal review & merge queue.

@igrr @projectgus Any chance this change gets cherry-picked into the branch release/v3.0? A ping timeout and delay time in milliseconds make a lot more sense, e.g. during production testing.

Hi @chrta ,
Sorry I didn't reply to you earlier. Unfortunately backporting this to the release branch would change the behaviour of the ping API, which we're reluctant to do in a bugfix point release.
It will be available in the v3.1 release (or you can cherry-pick it yourself if needed, I don't think it will lead to any problems updating IDF in the future.)
Angus


gitlab: build the grpc gem with gcc13

This is a bit hacky; feel free to improve.
Broken by switching the default stdenv to gcc14.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixosTests.gitlab still won't pass, I'm afraid.

This is a bit hacky; feel free to improve. Broken by switching the default stdenv to gcc14.

https://boringssl.googlesource.com/boringssl/+/c70190368c7040c37c1d655f0690bcde2b109a0d fixes according to https://github.com/grpc/grpc/issues/35945 tho I am not sure how to get a plain text diff

This is a bit hacky; feel free to improve. Broken by switching the default stdenv to gcc14.

ok -- got it to build with gcc-14.  fix ruby-modules not to clobber NIX_CFLAGS_COMPILE and add a patch to fix the build.
nixosTests.gitlab still timing out tho.
gcc-14-fixes
diff --git a/pkgs/development/ruby-modules/gem-config/default.nix b/pkgs/development/ruby-modules/gem-config/default.nix
index 0c34601fd725..b6542ebeccc2 100644
--- a/pkgs/development/ruby-modules/gem-config/default.nix
+++ b/pkgs/development/ruby-modules/gem-config/default.nix
@@ -17,7 +17,7 @@
 # This separates "what to build" (the exact gem versions) from "how to build"
 # (to make gems behave if necessary).

-{ lib, fetchurl, fetchpatch2, writeScript, ruby, libkrb5, libxml2, libxslt, python2, stdenv, which
+{ lib, fetchurl, fetchpatch, fetchpatch2, writeScript, ruby, libkrb5, libxml2, libxslt, python2, stdenv, which
 , libiconv, postgresql, nodejs, clang, sqlite, zlib, imagemagick, lasem
 , pkg-config , ncurses, xapian, gpgme, util-linux, tzdata, icu, libffi
 , cmake, libssh2, openssl, openssl_1_1, libmysqlclient, git, perl, pcre2, gecode_3, curl
@@ -407,15 +407,16 @@ in
       ++ lib.optional (lib.versionAtLeast attrs.version "1.53.0" && stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64) autoSignDarwinBinariesHook;
     buildInputs = [ openssl ];
     hardeningDisable = [ "format" ];
-    env.NIX_CFLAGS_COMPILE = toString [
-      "-Wno-error=stringop-overflow"
-      "-Wno-error=implicit-fallthrough"
-      "-Wno-error=sizeof-pointer-memaccess"
-      "-Wno-error=cast-function-type"
-      "-Wno-error=class-memaccess"
-      "-Wno-error=ignored-qualifiers"
-      "-Wno-error=tautological-compare"
-      "-Wno-error=stringop-truncation"
+    env.NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-pointer-types";
+    patches = [
+      (fetchpatch {
+        name = "gcc-14-fixes.patch";
+        url = "https://boringssl.googlesource.com/boringssl/+/c70190368c7040c37c1d655f0690bcde2b109a0d%5E%21/?format=TEXT";
+        decode = "base64 -d";
+        stripLen=1;
+        extraPrefix = "third_party/boringssl-with-bazel/src/";
+        hash = "sha256-1QyQm5s55op268r72dfExNGV+UyV5Ty6boHa9DQq40U=";
+       })
     ];
     dontBuild = false;
     postPatch = ''
diff --git a/pkgs/development/ruby-modules/gem/default.nix b/pkgs/development/ruby-modules/gem/default.nix
index 5d7379cf56c7..700d1a8e6c4f 100644
--- a/pkgs/development/ruby-modules/gem/default.nix
+++ b/pkgs/development/ruby-modules/gem/default.nix
@@ -175,6 +175,7 @@ lib.makeOverridable (
           [
             "-fdeclspec"
           ]
+        ++ lib.optional (attrs.env.NIX_CFLAGS_COMPILE or "" != "") attrs.env.NIX_CFLAGS_COMPILE
       );

       buildPhase =

This is a bit hacky; feel free to improve. Broken by switching the default stdenv to gcc14.

ok -- got it to build with gcc-14. fix ruby-modules not to clobber NIX_CFLAGS_COMPILE and add a patch to fix the build.
nixosTests.gitlab still timing out tho.

PR with gcc-14 fixes: https://github.com/NixOS/nixpkgs/pull/367783

I gently pinged all gitlab maintainers to bring the unsolved failure to their attention.  I know it's probably bad timing now...

nixosTests.gitlab still timing out tho.

It did succeed for me now.  (current nixpkgs master after merging that PR)  So I hope it will be just OK.

Ah, man.  The failure apparently remained on aarch64-linux, so it's still blocking nixos-unstable.

So maybe we just demote aarch64?  https://github.com/NixOS/nixpkgs/pull/368509


Update PDF render to allow questions to have no answer

Changes
Allow a question to have no answer on PDF output.
How to test

Submit a survey with no comment (question id 146)
Verify the image files are generated successfully

Who can test
Anyone but @ajmaddaford

👍


For review purposes only

Any feedback is welcome, if you want to get it running on your own machine and need help let me know. Looking for general feedback and also on the user facing side of the driver in particular.

Hi @ptsOSL I will build and run this up before taking a look through the code.  Will look to do this by the end of this week or early next week.

I'm only seeing a few test changes on the review "Files Changed" tab 🤔  I guess my idea to have the full code-base reviewed in a PR isn't really working out(?)